xref: /openbsd-src/usr.bin/ssh/krl.c (revision 50b7afb2c2c0993b0894d4e34bf857cb13ed9c80)
1 /*
2  * Copyright (c) 2012 Damien Miller <djm@mindrot.org>
3  *
4  * Permission to use, copy, modify, and distribute this software for any
5  * purpose with or without fee is hereby granted, provided that the above
6  * copyright notice and this permission notice appear in all copies.
7  *
8  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
9  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
10  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
11  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
12  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
13  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
14  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
15  */
16 
17 /* $OpenBSD: krl.c,v 1.17 2014/06/24 01:13:21 djm Exp $ */
18 
19 #include <sys/types.h>
20 #include <sys/param.h>
21 #include <sys/tree.h>
22 #include <sys/queue.h>
23 
24 #include <errno.h>
25 #include <fcntl.h>
26 #include <limits.h>
27 #include <string.h>
28 #include <time.h>
29 #include <unistd.h>
30 
31 #include "buffer.h"
32 #include "key.h"
33 #include "authfile.h"
34 #include "misc.h"
35 #include "log.h"
36 #include "xmalloc.h"
37 
38 #include "krl.h"
39 
40 /* #define DEBUG_KRL */
41 #ifdef DEBUG_KRL
42 # define KRL_DBG(x) debug3 x
43 #else
44 # define KRL_DBG(x)
45 #endif
46 
47 /*
48  * Trees of revoked serial numbers, key IDs and keys. This allows
49  * quick searching, querying and producing lists in canonical order.
50  */
51 
52 /* Tree of serial numbers. XXX make smarter: really need a real sparse bitmap */
53 struct revoked_serial {
54 	u_int64_t lo, hi;
55 	RB_ENTRY(revoked_serial) tree_entry;
56 };
57 static int serial_cmp(struct revoked_serial *a, struct revoked_serial *b);
58 RB_HEAD(revoked_serial_tree, revoked_serial);
59 RB_GENERATE_STATIC(revoked_serial_tree, revoked_serial, tree_entry, serial_cmp);
60 
61 /* Tree of key IDs */
62 struct revoked_key_id {
63 	char *key_id;
64 	RB_ENTRY(revoked_key_id) tree_entry;
65 };
66 static int key_id_cmp(struct revoked_key_id *a, struct revoked_key_id *b);
67 RB_HEAD(revoked_key_id_tree, revoked_key_id);
68 RB_GENERATE_STATIC(revoked_key_id_tree, revoked_key_id, tree_entry, key_id_cmp);
69 
70 /* Tree of blobs (used for keys and fingerprints) */
71 struct revoked_blob {
72 	u_char *blob;
73 	u_int len;
74 	RB_ENTRY(revoked_blob) tree_entry;
75 };
76 static int blob_cmp(struct revoked_blob *a, struct revoked_blob *b);
77 RB_HEAD(revoked_blob_tree, revoked_blob);
78 RB_GENERATE_STATIC(revoked_blob_tree, revoked_blob, tree_entry, blob_cmp);
79 
80 /* Tracks revoked certs for a single CA */
81 struct revoked_certs {
82 	Key *ca_key;
83 	struct revoked_serial_tree revoked_serials;
84 	struct revoked_key_id_tree revoked_key_ids;
85 	TAILQ_ENTRY(revoked_certs) entry;
86 };
87 TAILQ_HEAD(revoked_certs_list, revoked_certs);
88 
89 struct ssh_krl {
90 	u_int64_t krl_version;
91 	u_int64_t generated_date;
92 	u_int64_t flags;
93 	char *comment;
94 	struct revoked_blob_tree revoked_keys;
95 	struct revoked_blob_tree revoked_sha1s;
96 	struct revoked_certs_list revoked_certs;
97 };
98 
99 /* Return equal if a and b overlap */
100 static int
101 serial_cmp(struct revoked_serial *a, struct revoked_serial *b)
102 {
103 	if (a->hi >= b->lo && a->lo <= b->hi)
104 		return 0;
105 	return a->lo < b->lo ? -1 : 1;
106 }
107 
108 static int
109 key_id_cmp(struct revoked_key_id *a, struct revoked_key_id *b)
110 {
111 	return strcmp(a->key_id, b->key_id);
112 }
113 
114 static int
115 blob_cmp(struct revoked_blob *a, struct revoked_blob *b)
116 {
117 	int r;
118 
119 	if (a->len != b->len) {
120 		if ((r = memcmp(a->blob, b->blob, MIN(a->len, b->len))) != 0)
121 			return r;
122 		return a->len > b->len ? 1 : -1;
123 	} else
124 		return memcmp(a->blob, b->blob, a->len);
125 }
126 
127 struct ssh_krl *
128 ssh_krl_init(void)
129 {
130 	struct ssh_krl *krl;
131 
132 	if ((krl = calloc(1, sizeof(*krl))) == NULL)
133 		return NULL;
134 	RB_INIT(&krl->revoked_keys);
135 	RB_INIT(&krl->revoked_sha1s);
136 	TAILQ_INIT(&krl->revoked_certs);
137 	return krl;
138 }
139 
140 static void
141 revoked_certs_free(struct revoked_certs *rc)
142 {
143 	struct revoked_serial *rs, *trs;
144 	struct revoked_key_id *rki, *trki;
145 
146 	RB_FOREACH_SAFE(rs, revoked_serial_tree, &rc->revoked_serials, trs) {
147 		RB_REMOVE(revoked_serial_tree, &rc->revoked_serials, rs);
148 		free(rs);
149 	}
150 	RB_FOREACH_SAFE(rki, revoked_key_id_tree, &rc->revoked_key_ids, trki) {
151 		RB_REMOVE(revoked_key_id_tree, &rc->revoked_key_ids, rki);
152 		free(rki->key_id);
153 		free(rki);
154 	}
155 	if (rc->ca_key != NULL)
156 		key_free(rc->ca_key);
157 }
158 
159 void
160 ssh_krl_free(struct ssh_krl *krl)
161 {
162 	struct revoked_blob *rb, *trb;
163 	struct revoked_certs *rc, *trc;
164 
165 	if (krl == NULL)
166 		return;
167 
168 	free(krl->comment);
169 	RB_FOREACH_SAFE(rb, revoked_blob_tree, &krl->revoked_keys, trb) {
170 		RB_REMOVE(revoked_blob_tree, &krl->revoked_keys, rb);
171 		free(rb->blob);
172 		free(rb);
173 	}
174 	RB_FOREACH_SAFE(rb, revoked_blob_tree, &krl->revoked_sha1s, trb) {
175 		RB_REMOVE(revoked_blob_tree, &krl->revoked_sha1s, rb);
176 		free(rb->blob);
177 		free(rb);
178 	}
179 	TAILQ_FOREACH_SAFE(rc, &krl->revoked_certs, entry, trc) {
180 		TAILQ_REMOVE(&krl->revoked_certs, rc, entry);
181 		revoked_certs_free(rc);
182 	}
183 }
184 
185 void
186 ssh_krl_set_version(struct ssh_krl *krl, u_int64_t version)
187 {
188 	krl->krl_version = version;
189 }
190 
191 void
192 ssh_krl_set_comment(struct ssh_krl *krl, const char *comment)
193 {
194 	free(krl->comment);
195 	if ((krl->comment = strdup(comment)) == NULL)
196 		fatal("%s: strdup", __func__);
197 }
198 
199 /*
200  * Find the revoked_certs struct for a CA key. If allow_create is set then
201  * create a new one in the tree if one did not exist already.
202  */
203 static int
204 revoked_certs_for_ca_key(struct ssh_krl *krl, const Key *ca_key,
205     struct revoked_certs **rcp, int allow_create)
206 {
207 	struct revoked_certs *rc;
208 
209 	*rcp = NULL;
210 	TAILQ_FOREACH(rc, &krl->revoked_certs, entry) {
211 		if (key_equal(rc->ca_key, ca_key)) {
212 			*rcp = rc;
213 			return 0;
214 		}
215 	}
216 	if (!allow_create)
217 		return 0;
218 	/* If this CA doesn't exist in the list then add it now */
219 	if ((rc = calloc(1, sizeof(*rc))) == NULL)
220 		return -1;
221 	if ((rc->ca_key = key_from_private(ca_key)) == NULL) {
222 		free(rc);
223 		return -1;
224 	}
225 	RB_INIT(&rc->revoked_serials);
226 	RB_INIT(&rc->revoked_key_ids);
227 	TAILQ_INSERT_TAIL(&krl->revoked_certs, rc, entry);
228 	debug3("%s: new CA %s", __func__, key_type(ca_key));
229 	*rcp = rc;
230 	return 0;
231 }
232 
233 static int
234 insert_serial_range(struct revoked_serial_tree *rt, u_int64_t lo, u_int64_t hi)
235 {
236 	struct revoked_serial rs, *ers, *crs, *irs;
237 
238 	KRL_DBG(("%s: insert %llu:%llu", __func__, lo, hi));
239 	memset(&rs, 0, sizeof(rs));
240 	rs.lo = lo;
241 	rs.hi = hi;
242 	ers = RB_NFIND(revoked_serial_tree, rt, &rs);
243 	if (ers == NULL || serial_cmp(ers, &rs) != 0) {
244 		/* No entry matches. Just insert */
245 		if ((irs = malloc(sizeof(rs))) == NULL)
246 			return -1;
247 		memcpy(irs, &rs, sizeof(*irs));
248 		ers = RB_INSERT(revoked_serial_tree, rt, irs);
249 		if (ers != NULL) {
250 			KRL_DBG(("%s: bad: ers != NULL", __func__));
251 			/* Shouldn't happen */
252 			free(irs);
253 			return -1;
254 		}
255 		ers = irs;
256 	} else {
257 		KRL_DBG(("%s: overlap found %llu:%llu", __func__,
258 		    ers->lo, ers->hi));
259 		/*
260 		 * The inserted entry overlaps an existing one. Grow the
261 		 * existing entry.
262 		 */
263 		if (ers->lo > lo)
264 			ers->lo = lo;
265 		if (ers->hi < hi)
266 			ers->hi = hi;
267 	}
268 	/*
269 	 * The inserted or revised range might overlap or abut adjacent ones;
270 	 * coalesce as necessary.
271 	 */
272 
273 	/* Check predecessors */
274 	while ((crs = RB_PREV(revoked_serial_tree, rt, ers)) != NULL) {
275 		KRL_DBG(("%s: pred %llu:%llu", __func__, crs->lo, crs->hi));
276 		if (ers->lo != 0 && crs->hi < ers->lo - 1)
277 			break;
278 		/* This entry overlaps. */
279 		if (crs->lo < ers->lo) {
280 			ers->lo = crs->lo;
281 			KRL_DBG(("%s: pred extend %llu:%llu", __func__,
282 			    ers->lo, ers->hi));
283 		}
284 		RB_REMOVE(revoked_serial_tree, rt, crs);
285 		free(crs);
286 	}
287 	/* Check successors */
288 	while ((crs = RB_NEXT(revoked_serial_tree, rt, ers)) != NULL) {
289 		KRL_DBG(("%s: succ %llu:%llu", __func__, crs->lo, crs->hi));
290 		if (ers->hi != (u_int64_t)-1 && crs->lo > ers->hi + 1)
291 			break;
292 		/* This entry overlaps. */
293 		if (crs->hi > ers->hi) {
294 			ers->hi = crs->hi;
295 			KRL_DBG(("%s: succ extend %llu:%llu", __func__,
296 			    ers->lo, ers->hi));
297 		}
298 		RB_REMOVE(revoked_serial_tree, rt, crs);
299 		free(crs);
300 	}
301 	KRL_DBG(("%s: done, final %llu:%llu", __func__, ers->lo, ers->hi));
302 	return 0;
303 }
304 
305 int
306 ssh_krl_revoke_cert_by_serial(struct ssh_krl *krl, const Key *ca_key,
307     u_int64_t serial)
308 {
309 	return ssh_krl_revoke_cert_by_serial_range(krl, ca_key, serial, serial);
310 }
311 
312 int
313 ssh_krl_revoke_cert_by_serial_range(struct ssh_krl *krl, const Key *ca_key,
314     u_int64_t lo, u_int64_t hi)
315 {
316 	struct revoked_certs *rc;
317 
318 	if (lo > hi || lo == 0)
319 		return -1;
320 	if (revoked_certs_for_ca_key(krl, ca_key, &rc, 1) != 0)
321 		return -1;
322 	return insert_serial_range(&rc->revoked_serials, lo, hi);
323 }
324 
325 int
326 ssh_krl_revoke_cert_by_key_id(struct ssh_krl *krl, const Key *ca_key,
327     const char *key_id)
328 {
329 	struct revoked_key_id *rki, *erki;
330 	struct revoked_certs *rc;
331 
332 	if (revoked_certs_for_ca_key(krl, ca_key, &rc, 1) != 0)
333 		return -1;
334 
335 	debug3("%s: revoke %s", __func__, key_id);
336 	if ((rki = calloc(1, sizeof(*rki))) == NULL ||
337 	    (rki->key_id = strdup(key_id)) == NULL) {
338 		free(rki);
339 		fatal("%s: strdup", __func__);
340 	}
341 	erki = RB_INSERT(revoked_key_id_tree, &rc->revoked_key_ids, rki);
342 	if (erki != NULL) {
343 		free(rki->key_id);
344 		free(rki);
345 	}
346 	return 0;
347 }
348 
349 /* Convert "key" to a public key blob without any certificate information */
350 static int
351 plain_key_blob(const Key *key, u_char **blob, u_int *blen)
352 {
353 	Key *kcopy;
354 	int r;
355 
356 	if ((kcopy = key_from_private(key)) == NULL)
357 		return -1;
358 	if (key_is_cert(kcopy)) {
359 		if (key_drop_cert(kcopy) != 0) {
360 			error("%s: key_drop_cert", __func__);
361 			key_free(kcopy);
362 			return -1;
363 		}
364 	}
365 	r = key_to_blob(kcopy, blob, blen);
366 	free(kcopy);
367 	return r;
368 }
369 
370 /* Revoke a key blob. Ownership of blob is transferred to the tree */
371 static int
372 revoke_blob(struct revoked_blob_tree *rbt, u_char *blob, u_int len)
373 {
374 	struct revoked_blob *rb, *erb;
375 
376 	if ((rb = calloc(1, sizeof(*rb))) == NULL)
377 		return -1;
378 	rb->blob = blob;
379 	rb->len = len;
380 	erb = RB_INSERT(revoked_blob_tree, rbt, rb);
381 	if (erb != NULL) {
382 		free(rb->blob);
383 		free(rb);
384 	}
385 	return 0;
386 }
387 
388 int
389 ssh_krl_revoke_key_explicit(struct ssh_krl *krl, const Key *key)
390 {
391 	u_char *blob;
392 	u_int len;
393 
394 	debug3("%s: revoke type %s", __func__, key_type(key));
395 	if (plain_key_blob(key, &blob, &len) < 0)
396 		return -1;
397 	return revoke_blob(&krl->revoked_keys, blob, len);
398 }
399 
400 int
401 ssh_krl_revoke_key_sha1(struct ssh_krl *krl, const Key *key)
402 {
403 	u_char *blob;
404 	u_int len;
405 
406 	debug3("%s: revoke type %s by sha1", __func__, key_type(key));
407 	if ((blob = key_fingerprint_raw(key, SSH_FP_SHA1, &len)) == NULL)
408 		return -1;
409 	return revoke_blob(&krl->revoked_sha1s, blob, len);
410 }
411 
412 int
413 ssh_krl_revoke_key(struct ssh_krl *krl, const Key *key)
414 {
415 	if (!key_is_cert(key))
416 		return ssh_krl_revoke_key_sha1(krl, key);
417 
418 	if (key_cert_is_legacy(key) || key->cert->serial == 0) {
419 		return ssh_krl_revoke_cert_by_key_id(krl,
420 		    key->cert->signature_key,
421 		    key->cert->key_id);
422 	} else {
423 		return ssh_krl_revoke_cert_by_serial(krl,
424 		    key->cert->signature_key,
425 		    key->cert->serial);
426 	}
427 }
428 
429 /*
430  * Select a copact next section type to emit in a KRL based on the
431  * current section type, the run length of contiguous revoked serial
432  * numbers and the gaps from the last and to the next revoked serial.
433  * Applies a mostly-accurate bit cost model to select the section type
434  * that will minimise the size of the resultant KRL.
435  */
436 static int
437 choose_next_state(int current_state, u_int64_t contig, int final,
438     u_int64_t last_gap, u_int64_t next_gap, int *force_new_section)
439 {
440 	int new_state;
441 	u_int64_t cost, cost_list, cost_range, cost_bitmap, cost_bitmap_restart;
442 
443 	/*
444 	 * Avoid unsigned overflows.
445 	 * The limits are high enough to avoid confusing the calculations.
446 	 */
447 	contig = MIN(contig, 1ULL<<31);
448 	last_gap = MIN(last_gap, 1ULL<<31);
449 	next_gap = MIN(next_gap, 1ULL<<31);
450 
451 	/*
452 	 * Calculate the cost to switch from the current state to candidates.
453 	 * NB. range sections only ever contain a single range, so their
454 	 * switching cost is independent of the current_state.
455 	 */
456 	cost_list = cost_bitmap = cost_bitmap_restart = 0;
457 	cost_range = 8;
458 	switch (current_state) {
459 	case KRL_SECTION_CERT_SERIAL_LIST:
460 		cost_bitmap_restart = cost_bitmap = 8 + 64;
461 		break;
462 	case KRL_SECTION_CERT_SERIAL_BITMAP:
463 		cost_list = 8;
464 		cost_bitmap_restart = 8 + 64;
465 		break;
466 	case KRL_SECTION_CERT_SERIAL_RANGE:
467 	case 0:
468 		cost_bitmap_restart = cost_bitmap = 8 + 64;
469 		cost_list = 8;
470 	}
471 
472 	/* Estimate base cost in bits of each section type */
473 	cost_list += 64 * contig + (final ? 0 : 8+64);
474 	cost_range += (2 * 64) + (final ? 0 : 8+64);
475 	cost_bitmap += last_gap + contig + (final ? 0 : MIN(next_gap, 8+64));
476 	cost_bitmap_restart += contig + (final ? 0 : MIN(next_gap, 8+64));
477 
478 	/* Convert to byte costs for actual comparison */
479 	cost_list = (cost_list + 7) / 8;
480 	cost_bitmap = (cost_bitmap + 7) / 8;
481 	cost_bitmap_restart = (cost_bitmap_restart + 7) / 8;
482 	cost_range = (cost_range + 7) / 8;
483 
484 	/* Now pick the best choice */
485 	*force_new_section = 0;
486 	new_state = KRL_SECTION_CERT_SERIAL_BITMAP;
487 	cost = cost_bitmap;
488 	if (cost_range < cost) {
489 		new_state = KRL_SECTION_CERT_SERIAL_RANGE;
490 		cost = cost_range;
491 	}
492 	if (cost_list < cost) {
493 		new_state = KRL_SECTION_CERT_SERIAL_LIST;
494 		cost = cost_list;
495 	}
496 	if (cost_bitmap_restart < cost) {
497 		new_state = KRL_SECTION_CERT_SERIAL_BITMAP;
498 		*force_new_section = 1;
499 		cost = cost_bitmap_restart;
500 	}
501 	debug3("%s: contig %llu last_gap %llu next_gap %llu final %d, costs:"
502 	    "list %llu range %llu bitmap %llu new bitmap %llu, "
503 	    "selected 0x%02x%s", __func__, (long long unsigned)contig,
504 	    (long long unsigned)last_gap, (long long unsigned)next_gap, final,
505 	    (long long unsigned)cost_list, (long long unsigned)cost_range,
506 	    (long long unsigned)cost_bitmap,
507 	    (long long unsigned)cost_bitmap_restart, new_state,
508 	    *force_new_section ? " restart" : "");
509 	return new_state;
510 }
511 
512 /* Generate a KRL_SECTION_CERTIFICATES KRL section */
513 static int
514 revoked_certs_generate(struct revoked_certs *rc, Buffer *buf)
515 {
516 	int final, force_new_sect, r = -1;
517 	u_int64_t i, contig, gap, last = 0, bitmap_start = 0;
518 	struct revoked_serial *rs, *nrs;
519 	struct revoked_key_id *rki;
520 	int next_state, state = 0;
521 	Buffer sect;
522 	u_char *kblob = NULL;
523 	u_int klen;
524 	BIGNUM *bitmap = NULL;
525 
526 	/* Prepare CA scope key blob if we have one supplied */
527 	if (key_to_blob(rc->ca_key, &kblob, &klen) == 0)
528 		return -1;
529 
530 	buffer_init(&sect);
531 
532 	/* Store the header */
533 	buffer_put_string(buf, kblob, klen);
534 	buffer_put_string(buf, NULL, 0); /* Reserved */
535 
536 	free(kblob);
537 
538 	/* Store the revoked serials.  */
539 	for (rs = RB_MIN(revoked_serial_tree, &rc->revoked_serials);
540 	     rs != NULL;
541 	     rs = RB_NEXT(revoked_serial_tree, &rc->revoked_serials, rs)) {
542 		debug3("%s: serial %llu:%llu state 0x%02x", __func__,
543 		    (long long unsigned)rs->lo, (long long unsigned)rs->hi,
544 		    state);
545 
546 		/* Check contiguous length and gap to next section (if any) */
547 		nrs = RB_NEXT(revoked_serial_tree, &rc->revoked_serials, rs);
548 		final = nrs == NULL;
549 		gap = nrs == NULL ? 0 : nrs->lo - rs->hi;
550 		contig = 1 + (rs->hi - rs->lo);
551 
552 		/* Choose next state based on these */
553 		next_state = choose_next_state(state, contig, final,
554 		    state == 0 ? 0 : rs->lo - last, gap, &force_new_sect);
555 
556 		/*
557 		 * If the current section is a range section or has a different
558 		 * type to the next section, then finish it off now.
559 		 */
560 		if (state != 0 && (force_new_sect || next_state != state ||
561 		    state == KRL_SECTION_CERT_SERIAL_RANGE)) {
562 			debug3("%s: finish state 0x%02x", __func__, state);
563 			switch (state) {
564 			case KRL_SECTION_CERT_SERIAL_LIST:
565 			case KRL_SECTION_CERT_SERIAL_RANGE:
566 				break;
567 			case KRL_SECTION_CERT_SERIAL_BITMAP:
568 				buffer_put_bignum2(&sect, bitmap);
569 				BN_free(bitmap);
570 				bitmap = NULL;
571 				break;
572 			}
573 			buffer_put_char(buf, state);
574 			buffer_put_string(buf,
575 			    buffer_ptr(&sect), buffer_len(&sect));
576 			buffer_clear(&sect);
577 		}
578 
579 		/* If we are starting a new section then prepare it now */
580 		if (next_state != state || force_new_sect) {
581 			debug3("%s: start state 0x%02x", __func__, next_state);
582 			state = next_state;
583 			buffer_clear(&sect);
584 			switch (state) {
585 			case KRL_SECTION_CERT_SERIAL_LIST:
586 			case KRL_SECTION_CERT_SERIAL_RANGE:
587 				break;
588 			case KRL_SECTION_CERT_SERIAL_BITMAP:
589 				if ((bitmap = BN_new()) == NULL)
590 					goto out;
591 				bitmap_start = rs->lo;
592 				buffer_put_int64(&sect, bitmap_start);
593 				break;
594 			}
595 		}
596 
597 		/* Perform section-specific processing */
598 		switch (state) {
599 		case KRL_SECTION_CERT_SERIAL_LIST:
600 			for (i = 0; i < contig; i++)
601 				buffer_put_int64(&sect, rs->lo + i);
602 			break;
603 		case KRL_SECTION_CERT_SERIAL_RANGE:
604 			buffer_put_int64(&sect, rs->lo);
605 			buffer_put_int64(&sect, rs->hi);
606 			break;
607 		case KRL_SECTION_CERT_SERIAL_BITMAP:
608 			if (rs->lo - bitmap_start > INT_MAX) {
609 				error("%s: insane bitmap gap", __func__);
610 				goto out;
611 			}
612 			for (i = 0; i < contig; i++) {
613 				if (BN_set_bit(bitmap,
614 				    rs->lo + i - bitmap_start) != 1)
615 					goto out;
616 			}
617 			break;
618 		}
619 		last = rs->hi;
620 	}
621 	/* Flush the remaining section, if any */
622 	if (state != 0) {
623 		debug3("%s: serial final flush for state 0x%02x",
624 		    __func__, state);
625 		switch (state) {
626 		case KRL_SECTION_CERT_SERIAL_LIST:
627 		case KRL_SECTION_CERT_SERIAL_RANGE:
628 			break;
629 		case KRL_SECTION_CERT_SERIAL_BITMAP:
630 			buffer_put_bignum2(&sect, bitmap);
631 			BN_free(bitmap);
632 			bitmap = NULL;
633 			break;
634 		}
635 		buffer_put_char(buf, state);
636 		buffer_put_string(buf,
637 		    buffer_ptr(&sect), buffer_len(&sect));
638 	}
639 	debug3("%s: serial done ", __func__);
640 
641 	/* Now output a section for any revocations by key ID */
642 	buffer_clear(&sect);
643 	RB_FOREACH(rki, revoked_key_id_tree, &rc->revoked_key_ids) {
644 		debug3("%s: key ID %s", __func__, rki->key_id);
645 		buffer_put_cstring(&sect, rki->key_id);
646 	}
647 	if (buffer_len(&sect) != 0) {
648 		buffer_put_char(buf, KRL_SECTION_CERT_KEY_ID);
649 		buffer_put_string(buf, buffer_ptr(&sect),
650 		    buffer_len(&sect));
651 	}
652 	r = 0;
653  out:
654 	if (bitmap != NULL)
655 		BN_free(bitmap);
656 	buffer_free(&sect);
657 	return r;
658 }
659 
660 int
661 ssh_krl_to_blob(struct ssh_krl *krl, Buffer *buf, const Key **sign_keys,
662     u_int nsign_keys)
663 {
664 	int r = -1;
665 	struct revoked_certs *rc;
666 	struct revoked_blob *rb;
667 	Buffer sect;
668 	u_char *kblob = NULL, *sblob = NULL;
669 	u_int klen, slen, i;
670 
671 	if (krl->generated_date == 0)
672 		krl->generated_date = time(NULL);
673 
674 	buffer_init(&sect);
675 
676 	/* Store the header */
677 	buffer_append(buf, KRL_MAGIC, sizeof(KRL_MAGIC) - 1);
678 	buffer_put_int(buf, KRL_FORMAT_VERSION);
679 	buffer_put_int64(buf, krl->krl_version);
680 	buffer_put_int64(buf, krl->generated_date);
681 	buffer_put_int64(buf, krl->flags);
682 	buffer_put_string(buf, NULL, 0);
683 	buffer_put_cstring(buf, krl->comment ? krl->comment : "");
684 
685 	/* Store sections for revoked certificates */
686 	TAILQ_FOREACH(rc, &krl->revoked_certs, entry) {
687 		if (revoked_certs_generate(rc, &sect) != 0)
688 			goto out;
689 		buffer_put_char(buf, KRL_SECTION_CERTIFICATES);
690 		buffer_put_string(buf, buffer_ptr(&sect),
691 		    buffer_len(&sect));
692 	}
693 
694 	/* Finally, output sections for revocations by public key/hash */
695 	buffer_clear(&sect);
696 	RB_FOREACH(rb, revoked_blob_tree, &krl->revoked_keys) {
697 		debug3("%s: key len %u ", __func__, rb->len);
698 		buffer_put_string(&sect, rb->blob, rb->len);
699 	}
700 	if (buffer_len(&sect) != 0) {
701 		buffer_put_char(buf, KRL_SECTION_EXPLICIT_KEY);
702 		buffer_put_string(buf, buffer_ptr(&sect),
703 		    buffer_len(&sect));
704 	}
705 	buffer_clear(&sect);
706 	RB_FOREACH(rb, revoked_blob_tree, &krl->revoked_sha1s) {
707 		debug3("%s: hash len %u ", __func__, rb->len);
708 		buffer_put_string(&sect, rb->blob, rb->len);
709 	}
710 	if (buffer_len(&sect) != 0) {
711 		buffer_put_char(buf, KRL_SECTION_FINGERPRINT_SHA1);
712 		buffer_put_string(buf, buffer_ptr(&sect),
713 		    buffer_len(&sect));
714 	}
715 
716 	for (i = 0; i < nsign_keys; i++) {
717 		if (key_to_blob(sign_keys[i], &kblob, &klen) == 0)
718 			goto out;
719 
720 		debug3("%s: signature key len %u", __func__, klen);
721 		buffer_put_char(buf, KRL_SECTION_SIGNATURE);
722 		buffer_put_string(buf, kblob, klen);
723 
724 		if (key_sign(sign_keys[i], &sblob, &slen,
725 		    buffer_ptr(buf), buffer_len(buf)) == -1)
726 			goto out;
727 		debug3("%s: signature sig len %u", __func__, slen);
728 		buffer_put_string(buf, sblob, slen);
729 	}
730 
731 	r = 0;
732  out:
733 	free(kblob);
734 	free(sblob);
735 	buffer_free(&sect);
736 	return r;
737 }
738 
739 static void
740 format_timestamp(u_int64_t timestamp, char *ts, size_t nts)
741 {
742 	time_t t;
743 	struct tm *tm;
744 
745 	t = timestamp;
746 	tm = localtime(&t);
747 	*ts = '\0';
748 	strftime(ts, nts, "%Y%m%dT%H%M%S", tm);
749 }
750 
751 static int
752 parse_revoked_certs(Buffer *buf, struct ssh_krl *krl)
753 {
754 	int ret = -1, nbits;
755 	u_char type;
756 	const u_char *blob;
757 	u_int blen;
758 	Buffer subsect;
759 	u_int64_t serial, serial_lo, serial_hi;
760 	BIGNUM *bitmap = NULL;
761 	char *key_id = NULL;
762 	Key *ca_key = NULL;
763 
764 	buffer_init(&subsect);
765 
766 	if ((blob = buffer_get_string_ptr_ret(buf, &blen)) == NULL ||
767 	    buffer_get_string_ptr_ret(buf, NULL) == NULL) { /* reserved */
768 		error("%s: buffer error", __func__);
769 		goto out;
770 	}
771 	if ((ca_key = key_from_blob(blob, blen)) == NULL)
772 		goto out;
773 
774 	while (buffer_len(buf) > 0) {
775 		if (buffer_get_char_ret(&type, buf) != 0 ||
776 		    (blob = buffer_get_string_ptr_ret(buf, &blen)) == NULL) {
777 			error("%s: buffer error", __func__);
778 			goto out;
779 		}
780 		buffer_clear(&subsect);
781 		buffer_append(&subsect, blob, blen);
782 		debug3("%s: subsection type 0x%02x", __func__, type);
783 		/* buffer_dump(&subsect); */
784 
785 		switch (type) {
786 		case KRL_SECTION_CERT_SERIAL_LIST:
787 			while (buffer_len(&subsect) > 0) {
788 				if (buffer_get_int64_ret(&serial,
789 				    &subsect) != 0) {
790 					error("%s: buffer error", __func__);
791 					goto out;
792 				}
793 				if (ssh_krl_revoke_cert_by_serial(krl, ca_key,
794 				    serial) != 0) {
795 					error("%s: update failed", __func__);
796 					goto out;
797 				}
798 			}
799 			break;
800 		case KRL_SECTION_CERT_SERIAL_RANGE:
801 			if (buffer_get_int64_ret(&serial_lo, &subsect) != 0 ||
802 			    buffer_get_int64_ret(&serial_hi, &subsect) != 0) {
803 				error("%s: buffer error", __func__);
804 				goto out;
805 			}
806 			if (ssh_krl_revoke_cert_by_serial_range(krl, ca_key,
807 			    serial_lo, serial_hi) != 0) {
808 				error("%s: update failed", __func__);
809 				goto out;
810 			}
811 			break;
812 		case KRL_SECTION_CERT_SERIAL_BITMAP:
813 			if ((bitmap = BN_new()) == NULL) {
814 				error("%s: BN_new", __func__);
815 				goto out;
816 			}
817 			if (buffer_get_int64_ret(&serial_lo, &subsect) != 0 ||
818 			    buffer_get_bignum2_ret(&subsect, bitmap) != 0) {
819 				error("%s: buffer error", __func__);
820 				goto out;
821 			}
822 			if ((nbits = BN_num_bits(bitmap)) < 0) {
823 				error("%s: bitmap bits < 0", __func__);
824 				goto out;
825 			}
826 			for (serial = 0; serial < (u_int)nbits; serial++) {
827 				if (serial > 0 && serial_lo + serial == 0) {
828 					error("%s: bitmap wraps u64", __func__);
829 					goto out;
830 				}
831 				if (!BN_is_bit_set(bitmap, serial))
832 					continue;
833 				if (ssh_krl_revoke_cert_by_serial(krl, ca_key,
834 				    serial_lo + serial) != 0) {
835 					error("%s: update failed", __func__);
836 					goto out;
837 				}
838 			}
839 			BN_free(bitmap);
840 			bitmap = NULL;
841 			break;
842 		case KRL_SECTION_CERT_KEY_ID:
843 			while (buffer_len(&subsect) > 0) {
844 				if ((key_id = buffer_get_cstring_ret(&subsect,
845 				    NULL)) == NULL) {
846 					error("%s: buffer error", __func__);
847 					goto out;
848 				}
849 				if (ssh_krl_revoke_cert_by_key_id(krl, ca_key,
850 				    key_id) != 0) {
851 					error("%s: update failed", __func__);
852 					goto out;
853 				}
854 				free(key_id);
855 				key_id = NULL;
856 			}
857 			break;
858 		default:
859 			error("Unsupported KRL certificate section %u", type);
860 			goto out;
861 		}
862 		if (buffer_len(&subsect) > 0) {
863 			error("KRL certificate section contains unparsed data");
864 			goto out;
865 		}
866 	}
867 
868 	ret = 0;
869  out:
870 	if (ca_key != NULL)
871 		key_free(ca_key);
872 	if (bitmap != NULL)
873 		BN_free(bitmap);
874 	free(key_id);
875 	buffer_free(&subsect);
876 	return ret;
877 }
878 
879 
880 /* Attempt to parse a KRL, checking its signature (if any) with sign_ca_keys. */
881 int
882 ssh_krl_from_blob(Buffer *buf, struct ssh_krl **krlp,
883     const Key **sign_ca_keys, u_int nsign_ca_keys)
884 {
885 	Buffer copy, sect;
886 	struct ssh_krl *krl;
887 	char timestamp[64];
888 	int ret = -1, r, sig_seen;
889 	Key *key = NULL, **ca_used = NULL;
890 	u_char type, *rdata = NULL;
891 	const u_char *blob;
892 	u_int i, j, sig_off, sects_off, rlen, blen, format_version, nca_used;
893 
894 	nca_used = 0;
895 	*krlp = NULL;
896 	if (buffer_len(buf) < sizeof(KRL_MAGIC) - 1 ||
897 	    memcmp(buffer_ptr(buf), KRL_MAGIC, sizeof(KRL_MAGIC) - 1) != 0) {
898 		debug3("%s: not a KRL", __func__);
899 		/*
900 		 * Return success but a NULL *krlp here to signal that the
901 		 * file might be a simple list of keys.
902 		 */
903 		return 0;
904 	}
905 
906 	/* Take a copy of the KRL buffer so we can verify its signature later */
907 	buffer_init(&copy);
908 	buffer_append(&copy, buffer_ptr(buf), buffer_len(buf));
909 
910 	buffer_init(&sect);
911 	buffer_consume(&copy, sizeof(KRL_MAGIC) - 1);
912 
913 	if ((krl = ssh_krl_init()) == NULL) {
914 		error("%s: alloc failed", __func__);
915 		goto out;
916 	}
917 
918 	if (buffer_get_int_ret(&format_version, &copy) != 0) {
919 		error("%s: KRL truncated", __func__);
920 		goto out;
921 	}
922 	if (format_version != KRL_FORMAT_VERSION) {
923 		error("%s: KRL unsupported format version %u",
924 		    __func__, format_version);
925 		goto out;
926 	}
927 	if (buffer_get_int64_ret(&krl->krl_version, &copy) != 0 ||
928 	    buffer_get_int64_ret(&krl->generated_date, &copy) != 0 ||
929 	    buffer_get_int64_ret(&krl->flags, &copy) != 0 ||
930 	    buffer_get_string_ptr_ret(&copy, NULL) == NULL || /* reserved */
931 	    (krl->comment = buffer_get_cstring_ret(&copy, NULL)) == NULL) {
932 		error("%s: buffer error", __func__);
933 		goto out;
934 	}
935 
936 	format_timestamp(krl->generated_date, timestamp, sizeof(timestamp));
937 	debug("KRL version %llu generated at %s%s%s",
938 	    (long long unsigned)krl->krl_version, timestamp,
939 	    *krl->comment ? ": " : "", krl->comment);
940 
941 	/*
942 	 * 1st pass: verify signatures, if any. This is done to avoid
943 	 * detailed parsing of data whose provenance is unverified.
944 	 */
945 	sig_seen = 0;
946 	sects_off = buffer_len(buf) - buffer_len(&copy);
947 	while (buffer_len(&copy) > 0) {
948 		if (buffer_get_char_ret(&type, &copy) != 0 ||
949 		    (blob = buffer_get_string_ptr_ret(&copy, &blen)) == NULL) {
950 			error("%s: buffer error", __func__);
951 			goto out;
952 		}
953 		debug3("%s: first pass, section 0x%02x", __func__, type);
954 		if (type != KRL_SECTION_SIGNATURE) {
955 			if (sig_seen) {
956 				error("KRL contains non-signature section "
957 				    "after signature");
958 				goto out;
959 			}
960 			/* Not interested for now. */
961 			continue;
962 		}
963 		sig_seen = 1;
964 		/* First string component is the signing key */
965 		if ((key = key_from_blob(blob, blen)) == NULL) {
966 			error("%s: invalid signature key", __func__);
967 			goto out;
968 		}
969 		sig_off = buffer_len(buf) - buffer_len(&copy);
970 		/* Second string component is the signature itself */
971 		if ((blob = buffer_get_string_ptr_ret(&copy, &blen)) == NULL) {
972 			error("%s: buffer error", __func__);
973 			goto out;
974 		}
975 		/* Check signature over entire KRL up to this point */
976 		if (key_verify(key, blob, blen,
977 		    buffer_ptr(buf), buffer_len(buf) - sig_off) != 1) {
978 			error("bad signaure on KRL");
979 			goto out;
980 		}
981 		/* Check if this key has already signed this KRL */
982 		for (i = 0; i < nca_used; i++) {
983 			if (key_equal(ca_used[i], key)) {
984 				error("KRL signed more than once with "
985 				    "the same key");
986 				goto out;
987 			}
988 		}
989 		/* Record keys used to sign the KRL */
990 		ca_used = xrealloc(ca_used, nca_used + 1, sizeof(*ca_used));
991 		ca_used[nca_used++] = key;
992 		key = NULL;
993 		break;
994 	}
995 
996 	/*
997 	 * 2nd pass: parse and load the KRL, skipping the header to the point
998 	 * where the section start.
999 	 */
1000 	buffer_append(&copy, (u_char*)buffer_ptr(buf) + sects_off,
1001 	    buffer_len(buf) - sects_off);
1002 	while (buffer_len(&copy) > 0) {
1003 		if (buffer_get_char_ret(&type, &copy) != 0 ||
1004 		    (blob = buffer_get_string_ptr_ret(&copy, &blen)) == NULL) {
1005 			error("%s: buffer error", __func__);
1006 			goto out;
1007 		}
1008 		debug3("%s: second pass, section 0x%02x", __func__, type);
1009 		buffer_clear(&sect);
1010 		buffer_append(&sect, blob, blen);
1011 
1012 		switch (type) {
1013 		case KRL_SECTION_CERTIFICATES:
1014 			if ((r = parse_revoked_certs(&sect, krl)) != 0)
1015 				goto out;
1016 			break;
1017 		case KRL_SECTION_EXPLICIT_KEY:
1018 		case KRL_SECTION_FINGERPRINT_SHA1:
1019 			while (buffer_len(&sect) > 0) {
1020 				if ((rdata = buffer_get_string_ret(&sect,
1021 				    &rlen)) == NULL) {
1022 					error("%s: buffer error", __func__);
1023 					goto out;
1024 				}
1025 				if (type == KRL_SECTION_FINGERPRINT_SHA1 &&
1026 				    rlen != 20) {
1027 					error("%s: bad SHA1 length", __func__);
1028 					goto out;
1029 				}
1030 				if (revoke_blob(
1031 				    type == KRL_SECTION_EXPLICIT_KEY ?
1032 				    &krl->revoked_keys : &krl->revoked_sha1s,
1033 				    rdata, rlen) != 0)
1034 					goto out;
1035 				rdata = NULL; /* revoke_blob frees blob */
1036 			}
1037 			break;
1038 		case KRL_SECTION_SIGNATURE:
1039 			/* Handled above, but still need to stay in synch */
1040 			buffer_clear(&sect);
1041 			if ((blob = buffer_get_string_ptr_ret(&copy,
1042 			    &blen)) == NULL) {
1043 				error("%s: buffer error", __func__);
1044 				goto out;
1045 			}
1046 			break;
1047 		default:
1048 			error("Unsupported KRL section %u", type);
1049 			goto out;
1050 		}
1051 		if (buffer_len(&sect) > 0) {
1052 			error("KRL section contains unparsed data");
1053 			goto out;
1054 		}
1055 	}
1056 
1057 	/* Check that the key(s) used to sign the KRL weren't revoked */
1058 	sig_seen = 0;
1059 	for (i = 0; i < nca_used; i++) {
1060 		if (ssh_krl_check_key(krl, ca_used[i]) == 0)
1061 			sig_seen = 1;
1062 		else {
1063 			key_free(ca_used[i]);
1064 			ca_used[i] = NULL;
1065 		}
1066 	}
1067 	if (nca_used && !sig_seen) {
1068 		error("All keys used to sign KRL were revoked");
1069 		goto out;
1070 	}
1071 
1072 	/* If we have CA keys, then verify that one was used to sign the KRL */
1073 	if (sig_seen && nsign_ca_keys != 0) {
1074 		sig_seen = 0;
1075 		for (i = 0; !sig_seen && i < nsign_ca_keys; i++) {
1076 			for (j = 0; j < nca_used; j++) {
1077 				if (ca_used[j] == NULL)
1078 					continue;
1079 				if (key_equal(ca_used[j], sign_ca_keys[i])) {
1080 					sig_seen = 1;
1081 					break;
1082 				}
1083 			}
1084 		}
1085 		if (!sig_seen) {
1086 			error("KRL not signed with any trusted key");
1087 			goto out;
1088 		}
1089 	}
1090 
1091 	*krlp = krl;
1092 	ret = 0;
1093  out:
1094 	if (ret != 0)
1095 		ssh_krl_free(krl);
1096 	for (i = 0; i < nca_used; i++) {
1097 		if (ca_used[i] != NULL)
1098 			key_free(ca_used[i]);
1099 	}
1100 	free(ca_used);
1101 	free(rdata);
1102 	if (key != NULL)
1103 		key_free(key);
1104 	buffer_free(&copy);
1105 	buffer_free(&sect);
1106 	return ret;
1107 }
1108 
1109 /* Checks whether a given key/cert is revoked. Does not check its CA */
1110 static int
1111 is_key_revoked(struct ssh_krl *krl, const Key *key)
1112 {
1113 	struct revoked_blob rb, *erb;
1114 	struct revoked_serial rs, *ers;
1115 	struct revoked_key_id rki, *erki;
1116 	struct revoked_certs *rc;
1117 
1118 	/* Check explicitly revoked hashes first */
1119 	memset(&rb, 0, sizeof(rb));
1120 	if ((rb.blob = key_fingerprint_raw(key, SSH_FP_SHA1, &rb.len)) == NULL)
1121 		return -1;
1122 	erb = RB_FIND(revoked_blob_tree, &krl->revoked_sha1s, &rb);
1123 	free(rb.blob);
1124 	if (erb != NULL) {
1125 		debug("%s: revoked by key SHA1", __func__);
1126 		return -1;
1127 	}
1128 
1129 	/* Next, explicit keys */
1130 	memset(&rb, 0, sizeof(rb));
1131 	if (plain_key_blob(key, &rb.blob, &rb.len) < 0)
1132 		return -1;
1133 	erb = RB_FIND(revoked_blob_tree, &krl->revoked_keys, &rb);
1134 	free(rb.blob);
1135 	if (erb != NULL) {
1136 		debug("%s: revoked by explicit key", __func__);
1137 		return -1;
1138 	}
1139 
1140 	if (!key_is_cert(key))
1141 		return 0;
1142 
1143 	/* Check cert revocation */
1144 	if (revoked_certs_for_ca_key(krl, key->cert->signature_key,
1145 	    &rc, 0) != 0)
1146 		return -1;
1147 	if (rc == NULL)
1148 		return 0; /* No entry for this CA */
1149 
1150 	/* Check revocation by cert key ID */
1151 	memset(&rki, 0, sizeof(rki));
1152 	rki.key_id = key->cert->key_id;
1153 	erki = RB_FIND(revoked_key_id_tree, &rc->revoked_key_ids, &rki);
1154 	if (erki != NULL) {
1155 		debug("%s: revoked by key ID", __func__);
1156 		return -1;
1157 	}
1158 
1159 	/*
1160 	 * Legacy cert formats lack serial numbers. Zero serials numbers
1161 	 * are ignored (it's the default when the CA doesn't specify one).
1162 	 */
1163 	if (key_cert_is_legacy(key) || key->cert->serial == 0)
1164 		return 0;
1165 
1166 	memset(&rs, 0, sizeof(rs));
1167 	rs.lo = rs.hi = key->cert->serial;
1168 	ers = RB_FIND(revoked_serial_tree, &rc->revoked_serials, &rs);
1169 	if (ers != NULL) {
1170 		KRL_DBG(("%s: %llu matched %llu:%llu", __func__,
1171 		    key->cert->serial, ers->lo, ers->hi));
1172 		debug("%s: revoked by serial", __func__);
1173 		return -1;
1174 	}
1175 	KRL_DBG(("%s: %llu no match", __func__, key->cert->serial));
1176 
1177 	return 0;
1178 }
1179 
1180 int
1181 ssh_krl_check_key(struct ssh_krl *krl, const Key *key)
1182 {
1183 	int r;
1184 
1185 	debug2("%s: checking key", __func__);
1186 	if ((r = is_key_revoked(krl, key)) != 0)
1187 		return r;
1188 	if (key_is_cert(key)) {
1189 		debug2("%s: checking CA key", __func__);
1190 		if ((r = is_key_revoked(krl, key->cert->signature_key)) != 0)
1191 			return r;
1192 	}
1193 	debug3("%s: key okay", __func__);
1194 	return 0;
1195 }
1196 
1197 /* Returns 0 on success, -1 on error or key revoked, -2 if path is not a KRL */
1198 int
1199 ssh_krl_file_contains_key(const char *path, const Key *key)
1200 {
1201 	Buffer krlbuf;
1202 	struct ssh_krl *krl;
1203 	int revoked, fd;
1204 
1205 	if (path == NULL)
1206 		return 0;
1207 
1208 	if ((fd = open(path, O_RDONLY)) == -1) {
1209 		error("open %s: %s", path, strerror(errno));
1210 		error("Revoked keys file not accessible - refusing public key "
1211 		    "authentication");
1212 		return -1;
1213 	}
1214 	buffer_init(&krlbuf);
1215 	if (!key_load_file(fd, path, &krlbuf)) {
1216 		close(fd);
1217 		buffer_free(&krlbuf);
1218 		error("Revoked keys file not readable - refusing public key "
1219 		    "authentication");
1220 		return -1;
1221 	}
1222 	close(fd);
1223 	if (ssh_krl_from_blob(&krlbuf, &krl, NULL, 0) != 0) {
1224 		buffer_free(&krlbuf);
1225 		error("Invalid KRL, refusing public key "
1226 		    "authentication");
1227 		return -1;
1228 	}
1229 	buffer_free(&krlbuf);
1230 	if (krl == NULL) {
1231 		debug3("%s: %s is not a KRL file", __func__, path);
1232 		return -2;
1233 	}
1234 	debug2("%s: checking KRL %s", __func__, path);
1235 	revoked = ssh_krl_check_key(krl, key) != 0;
1236 	ssh_krl_free(krl);
1237 	return revoked ? -1 : 0;
1238 }
1239