1e5dd7070Spatrick //==-- RetainCountChecker.cpp - Checks for leaks and other issues -*- C++ -*--//
2e5dd7070Spatrick //
3e5dd7070Spatrick // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4e5dd7070Spatrick // See https://llvm.org/LICENSE.txt for license information.
5e5dd7070Spatrick // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6e5dd7070Spatrick //
7e5dd7070Spatrick //===----------------------------------------------------------------------===//
8e5dd7070Spatrick //
9e5dd7070Spatrick // This file defines the methods for RetainCountChecker, which implements
10e5dd7070Spatrick // a reference count checker for Core Foundation and Cocoa on (Mac OS X).
11e5dd7070Spatrick //
12e5dd7070Spatrick //===----------------------------------------------------------------------===//
13e5dd7070Spatrick
14e5dd7070Spatrick #include "RetainCountChecker.h"
15ec727ea7Spatrick #include "clang/StaticAnalyzer/Core/Checker.h"
16e5dd7070Spatrick #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
17*12c85518Srobert #include <optional>
18e5dd7070Spatrick
19e5dd7070Spatrick using namespace clang;
20e5dd7070Spatrick using namespace ento;
21e5dd7070Spatrick using namespace retaincountchecker;
22e5dd7070Spatrick
23e5dd7070Spatrick REGISTER_MAP_WITH_PROGRAMSTATE(RefBindings, SymbolRef, RefVal)
24e5dd7070Spatrick
25e5dd7070Spatrick namespace clang {
26e5dd7070Spatrick namespace ento {
27e5dd7070Spatrick namespace retaincountchecker {
28e5dd7070Spatrick
getRefBinding(ProgramStateRef State,SymbolRef Sym)29e5dd7070Spatrick const RefVal *getRefBinding(ProgramStateRef State, SymbolRef Sym) {
30e5dd7070Spatrick return State->get<RefBindings>(Sym);
31e5dd7070Spatrick }
32e5dd7070Spatrick
33e5dd7070Spatrick } // end namespace retaincountchecker
34e5dd7070Spatrick } // end namespace ento
35e5dd7070Spatrick } // end namespace clang
36e5dd7070Spatrick
setRefBinding(ProgramStateRef State,SymbolRef Sym,RefVal Val)37e5dd7070Spatrick static ProgramStateRef setRefBinding(ProgramStateRef State, SymbolRef Sym,
38e5dd7070Spatrick RefVal Val) {
39e5dd7070Spatrick assert(Sym != nullptr);
40e5dd7070Spatrick return State->set<RefBindings>(Sym, Val);
41e5dd7070Spatrick }
42e5dd7070Spatrick
removeRefBinding(ProgramStateRef State,SymbolRef Sym)43e5dd7070Spatrick static ProgramStateRef removeRefBinding(ProgramStateRef State, SymbolRef Sym) {
44e5dd7070Spatrick return State->remove<RefBindings>(Sym);
45e5dd7070Spatrick }
46e5dd7070Spatrick
print(raw_ostream & Out) const47e5dd7070Spatrick void RefVal::print(raw_ostream &Out) const {
48e5dd7070Spatrick if (!T.isNull())
49*12c85518Srobert Out << "Tracked " << T << " | ";
50e5dd7070Spatrick
51e5dd7070Spatrick switch (getKind()) {
52e5dd7070Spatrick default: llvm_unreachable("Invalid RefVal kind");
53e5dd7070Spatrick case Owned: {
54e5dd7070Spatrick Out << "Owned";
55e5dd7070Spatrick unsigned cnt = getCount();
56e5dd7070Spatrick if (cnt) Out << " (+ " << cnt << ")";
57e5dd7070Spatrick break;
58e5dd7070Spatrick }
59e5dd7070Spatrick
60e5dd7070Spatrick case NotOwned: {
61e5dd7070Spatrick Out << "NotOwned";
62e5dd7070Spatrick unsigned cnt = getCount();
63e5dd7070Spatrick if (cnt) Out << " (+ " << cnt << ")";
64e5dd7070Spatrick break;
65e5dd7070Spatrick }
66e5dd7070Spatrick
67e5dd7070Spatrick case ReturnedOwned: {
68e5dd7070Spatrick Out << "ReturnedOwned";
69e5dd7070Spatrick unsigned cnt = getCount();
70e5dd7070Spatrick if (cnt) Out << " (+ " << cnt << ")";
71e5dd7070Spatrick break;
72e5dd7070Spatrick }
73e5dd7070Spatrick
74e5dd7070Spatrick case ReturnedNotOwned: {
75e5dd7070Spatrick Out << "ReturnedNotOwned";
76e5dd7070Spatrick unsigned cnt = getCount();
77e5dd7070Spatrick if (cnt) Out << " (+ " << cnt << ")";
78e5dd7070Spatrick break;
79e5dd7070Spatrick }
80e5dd7070Spatrick
81e5dd7070Spatrick case Released:
82e5dd7070Spatrick Out << "Released";
83e5dd7070Spatrick break;
84e5dd7070Spatrick
85e5dd7070Spatrick case ErrorDeallocNotOwned:
86e5dd7070Spatrick Out << "-dealloc (not-owned)";
87e5dd7070Spatrick break;
88e5dd7070Spatrick
89e5dd7070Spatrick case ErrorLeak:
90e5dd7070Spatrick Out << "Leaked";
91e5dd7070Spatrick break;
92e5dd7070Spatrick
93e5dd7070Spatrick case ErrorLeakReturned:
94e5dd7070Spatrick Out << "Leaked (Bad naming)";
95e5dd7070Spatrick break;
96e5dd7070Spatrick
97e5dd7070Spatrick case ErrorUseAfterRelease:
98e5dd7070Spatrick Out << "Use-After-Release [ERROR]";
99e5dd7070Spatrick break;
100e5dd7070Spatrick
101e5dd7070Spatrick case ErrorReleaseNotOwned:
102e5dd7070Spatrick Out << "Release of Not-Owned [ERROR]";
103e5dd7070Spatrick break;
104e5dd7070Spatrick
105e5dd7070Spatrick case RefVal::ErrorOverAutorelease:
106e5dd7070Spatrick Out << "Over-autoreleased";
107e5dd7070Spatrick break;
108e5dd7070Spatrick
109e5dd7070Spatrick case RefVal::ErrorReturnedNotOwned:
110e5dd7070Spatrick Out << "Non-owned object returned instead of owned";
111e5dd7070Spatrick break;
112e5dd7070Spatrick }
113e5dd7070Spatrick
114e5dd7070Spatrick switch (getIvarAccessHistory()) {
115e5dd7070Spatrick case IvarAccessHistory::None:
116e5dd7070Spatrick break;
117e5dd7070Spatrick case IvarAccessHistory::AccessedDirectly:
118e5dd7070Spatrick Out << " [direct ivar access]";
119e5dd7070Spatrick break;
120e5dd7070Spatrick case IvarAccessHistory::ReleasedAfterDirectAccess:
121e5dd7070Spatrick Out << " [released after direct ivar access]";
122e5dd7070Spatrick }
123e5dd7070Spatrick
124e5dd7070Spatrick if (ACnt) {
125e5dd7070Spatrick Out << " [autorelease -" << ACnt << ']';
126e5dd7070Spatrick }
127e5dd7070Spatrick }
128e5dd7070Spatrick
129e5dd7070Spatrick namespace {
130e5dd7070Spatrick class StopTrackingCallback final : public SymbolVisitor {
131e5dd7070Spatrick ProgramStateRef state;
132e5dd7070Spatrick public:
StopTrackingCallback(ProgramStateRef st)133e5dd7070Spatrick StopTrackingCallback(ProgramStateRef st) : state(std::move(st)) {}
getState() const134e5dd7070Spatrick ProgramStateRef getState() const { return state; }
135e5dd7070Spatrick
VisitSymbol(SymbolRef sym)136e5dd7070Spatrick bool VisitSymbol(SymbolRef sym) override {
137e5dd7070Spatrick state = removeRefBinding(state, sym);
138e5dd7070Spatrick return true;
139e5dd7070Spatrick }
140e5dd7070Spatrick };
141e5dd7070Spatrick } // end anonymous namespace
142e5dd7070Spatrick
143e5dd7070Spatrick //===----------------------------------------------------------------------===//
144e5dd7070Spatrick // Handle statements that may have an effect on refcounts.
145e5dd7070Spatrick //===----------------------------------------------------------------------===//
146e5dd7070Spatrick
checkPostStmt(const BlockExpr * BE,CheckerContext & C) const147e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const BlockExpr *BE,
148e5dd7070Spatrick CheckerContext &C) const {
149e5dd7070Spatrick
150e5dd7070Spatrick // Scan the BlockDecRefExprs for any object the retain count checker
151e5dd7070Spatrick // may be tracking.
152e5dd7070Spatrick if (!BE->getBlockDecl()->hasCaptures())
153e5dd7070Spatrick return;
154e5dd7070Spatrick
155e5dd7070Spatrick ProgramStateRef state = C.getState();
156e5dd7070Spatrick auto *R = cast<BlockDataRegion>(C.getSVal(BE).getAsRegion());
157e5dd7070Spatrick
158e5dd7070Spatrick BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
159e5dd7070Spatrick E = R->referenced_vars_end();
160e5dd7070Spatrick
161e5dd7070Spatrick if (I == E)
162e5dd7070Spatrick return;
163e5dd7070Spatrick
164e5dd7070Spatrick // FIXME: For now we invalidate the tracking of all symbols passed to blocks
165e5dd7070Spatrick // via captured variables, even though captured variables result in a copy
166e5dd7070Spatrick // and in implicit increment/decrement of a retain count.
167e5dd7070Spatrick SmallVector<const MemRegion*, 10> Regions;
168e5dd7070Spatrick const LocationContext *LC = C.getLocationContext();
169e5dd7070Spatrick MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
170e5dd7070Spatrick
171e5dd7070Spatrick for ( ; I != E; ++I) {
172e5dd7070Spatrick const VarRegion *VR = I.getCapturedRegion();
173e5dd7070Spatrick if (VR->getSuperRegion() == R) {
174e5dd7070Spatrick VR = MemMgr.getVarRegion(VR->getDecl(), LC);
175e5dd7070Spatrick }
176e5dd7070Spatrick Regions.push_back(VR);
177e5dd7070Spatrick }
178e5dd7070Spatrick
179e5dd7070Spatrick state = state->scanReachableSymbols<StopTrackingCallback>(Regions).getState();
180e5dd7070Spatrick C.addTransition(state);
181e5dd7070Spatrick }
182e5dd7070Spatrick
checkPostStmt(const CastExpr * CE,CheckerContext & C) const183e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const CastExpr *CE,
184e5dd7070Spatrick CheckerContext &C) const {
185e5dd7070Spatrick const ObjCBridgedCastExpr *BE = dyn_cast<ObjCBridgedCastExpr>(CE);
186e5dd7070Spatrick if (!BE)
187e5dd7070Spatrick return;
188e5dd7070Spatrick
189e5dd7070Spatrick QualType QT = CE->getType();
190e5dd7070Spatrick ObjKind K;
191e5dd7070Spatrick if (QT->isObjCObjectPointerType()) {
192e5dd7070Spatrick K = ObjKind::ObjC;
193e5dd7070Spatrick } else {
194e5dd7070Spatrick K = ObjKind::CF;
195e5dd7070Spatrick }
196e5dd7070Spatrick
197e5dd7070Spatrick ArgEffect AE = ArgEffect(IncRef, K);
198e5dd7070Spatrick
199e5dd7070Spatrick switch (BE->getBridgeKind()) {
200e5dd7070Spatrick case OBC_Bridge:
201e5dd7070Spatrick // Do nothing.
202e5dd7070Spatrick return;
203e5dd7070Spatrick case OBC_BridgeRetained:
204e5dd7070Spatrick AE = AE.withKind(IncRef);
205e5dd7070Spatrick break;
206e5dd7070Spatrick case OBC_BridgeTransfer:
207e5dd7070Spatrick AE = AE.withKind(DecRefBridgedTransferred);
208e5dd7070Spatrick break;
209e5dd7070Spatrick }
210e5dd7070Spatrick
211e5dd7070Spatrick ProgramStateRef state = C.getState();
212e5dd7070Spatrick SymbolRef Sym = C.getSVal(CE).getAsLocSymbol();
213e5dd7070Spatrick if (!Sym)
214e5dd7070Spatrick return;
215e5dd7070Spatrick const RefVal* T = getRefBinding(state, Sym);
216e5dd7070Spatrick if (!T)
217e5dd7070Spatrick return;
218e5dd7070Spatrick
219e5dd7070Spatrick RefVal::Kind hasErr = (RefVal::Kind) 0;
220e5dd7070Spatrick state = updateSymbol(state, Sym, *T, AE, hasErr, C);
221e5dd7070Spatrick
222e5dd7070Spatrick if (hasErr) {
223e5dd7070Spatrick // FIXME: If we get an error during a bridge cast, should we report it?
224e5dd7070Spatrick return;
225e5dd7070Spatrick }
226e5dd7070Spatrick
227e5dd7070Spatrick C.addTransition(state);
228e5dd7070Spatrick }
229e5dd7070Spatrick
processObjCLiterals(CheckerContext & C,const Expr * Ex) const230e5dd7070Spatrick void RetainCountChecker::processObjCLiterals(CheckerContext &C,
231e5dd7070Spatrick const Expr *Ex) const {
232e5dd7070Spatrick ProgramStateRef state = C.getState();
233e5dd7070Spatrick const ExplodedNode *pred = C.getPredecessor();
234e5dd7070Spatrick for (const Stmt *Child : Ex->children()) {
235e5dd7070Spatrick SVal V = pred->getSVal(Child);
236e5dd7070Spatrick if (SymbolRef sym = V.getAsSymbol())
237e5dd7070Spatrick if (const RefVal* T = getRefBinding(state, sym)) {
238e5dd7070Spatrick RefVal::Kind hasErr = (RefVal::Kind) 0;
239e5dd7070Spatrick state = updateSymbol(state, sym, *T,
240e5dd7070Spatrick ArgEffect(MayEscape, ObjKind::ObjC), hasErr, C);
241e5dd7070Spatrick if (hasErr) {
242e5dd7070Spatrick processNonLeakError(state, Child->getSourceRange(), hasErr, sym, C);
243e5dd7070Spatrick return;
244e5dd7070Spatrick }
245e5dd7070Spatrick }
246e5dd7070Spatrick }
247e5dd7070Spatrick
248e5dd7070Spatrick // Return the object as autoreleased.
249e5dd7070Spatrick // RetEffect RE = RetEffect::MakeNotOwned(ObjKind::ObjC);
250e5dd7070Spatrick if (SymbolRef sym =
251e5dd7070Spatrick state->getSVal(Ex, pred->getLocationContext()).getAsSymbol()) {
252e5dd7070Spatrick QualType ResultTy = Ex->getType();
253e5dd7070Spatrick state = setRefBinding(state, sym,
254e5dd7070Spatrick RefVal::makeNotOwned(ObjKind::ObjC, ResultTy));
255e5dd7070Spatrick }
256e5dd7070Spatrick
257e5dd7070Spatrick C.addTransition(state);
258e5dd7070Spatrick }
259e5dd7070Spatrick
checkPostStmt(const ObjCArrayLiteral * AL,CheckerContext & C) const260e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const ObjCArrayLiteral *AL,
261e5dd7070Spatrick CheckerContext &C) const {
262e5dd7070Spatrick // Apply the 'MayEscape' to all values.
263e5dd7070Spatrick processObjCLiterals(C, AL);
264e5dd7070Spatrick }
265e5dd7070Spatrick
checkPostStmt(const ObjCDictionaryLiteral * DL,CheckerContext & C) const266e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const ObjCDictionaryLiteral *DL,
267e5dd7070Spatrick CheckerContext &C) const {
268e5dd7070Spatrick // Apply the 'MayEscape' to all keys and values.
269e5dd7070Spatrick processObjCLiterals(C, DL);
270e5dd7070Spatrick }
271e5dd7070Spatrick
checkPostStmt(const ObjCBoxedExpr * Ex,CheckerContext & C) const272e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const ObjCBoxedExpr *Ex,
273e5dd7070Spatrick CheckerContext &C) const {
274e5dd7070Spatrick const ExplodedNode *Pred = C.getPredecessor();
275e5dd7070Spatrick ProgramStateRef State = Pred->getState();
276e5dd7070Spatrick
277e5dd7070Spatrick if (SymbolRef Sym = Pred->getSVal(Ex).getAsSymbol()) {
278e5dd7070Spatrick QualType ResultTy = Ex->getType();
279e5dd7070Spatrick State = setRefBinding(State, Sym,
280e5dd7070Spatrick RefVal::makeNotOwned(ObjKind::ObjC, ResultTy));
281e5dd7070Spatrick }
282e5dd7070Spatrick
283e5dd7070Spatrick C.addTransition(State);
284e5dd7070Spatrick }
285e5dd7070Spatrick
checkPostStmt(const ObjCIvarRefExpr * IRE,CheckerContext & C) const286e5dd7070Spatrick void RetainCountChecker::checkPostStmt(const ObjCIvarRefExpr *IRE,
287e5dd7070Spatrick CheckerContext &C) const {
288*12c85518Srobert std::optional<Loc> IVarLoc = C.getSVal(IRE).getAs<Loc>();
289e5dd7070Spatrick if (!IVarLoc)
290e5dd7070Spatrick return;
291e5dd7070Spatrick
292e5dd7070Spatrick ProgramStateRef State = C.getState();
293e5dd7070Spatrick SymbolRef Sym = State->getSVal(*IVarLoc).getAsSymbol();
294*12c85518Srobert if (!Sym || !isa_and_nonnull<ObjCIvarRegion>(Sym->getOriginRegion()))
295e5dd7070Spatrick return;
296e5dd7070Spatrick
297e5dd7070Spatrick // Accessing an ivar directly is unusual. If we've done that, be more
298e5dd7070Spatrick // forgiving about what the surrounding code is allowed to do.
299e5dd7070Spatrick
300e5dd7070Spatrick QualType Ty = Sym->getType();
301e5dd7070Spatrick ObjKind Kind;
302e5dd7070Spatrick if (Ty->isObjCRetainableType())
303e5dd7070Spatrick Kind = ObjKind::ObjC;
304e5dd7070Spatrick else if (coreFoundation::isCFObjectRef(Ty))
305e5dd7070Spatrick Kind = ObjKind::CF;
306e5dd7070Spatrick else
307e5dd7070Spatrick return;
308e5dd7070Spatrick
309e5dd7070Spatrick // If the value is already known to be nil, don't bother tracking it.
310e5dd7070Spatrick ConstraintManager &CMgr = State->getConstraintManager();
311e5dd7070Spatrick if (CMgr.isNull(State, Sym).isConstrainedTrue())
312e5dd7070Spatrick return;
313e5dd7070Spatrick
314e5dd7070Spatrick if (const RefVal *RV = getRefBinding(State, Sym)) {
315e5dd7070Spatrick // If we've seen this symbol before, or we're only seeing it now because
316e5dd7070Spatrick // of something the analyzer has synthesized, don't do anything.
317e5dd7070Spatrick if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None ||
318e5dd7070Spatrick isSynthesizedAccessor(C.getStackFrame())) {
319e5dd7070Spatrick return;
320e5dd7070Spatrick }
321e5dd7070Spatrick
322e5dd7070Spatrick // Note that this value has been loaded from an ivar.
323e5dd7070Spatrick C.addTransition(setRefBinding(State, Sym, RV->withIvarAccess()));
324e5dd7070Spatrick return;
325e5dd7070Spatrick }
326e5dd7070Spatrick
327e5dd7070Spatrick RefVal PlusZero = RefVal::makeNotOwned(Kind, Ty);
328e5dd7070Spatrick
329e5dd7070Spatrick // In a synthesized accessor, the effective retain count is +0.
330e5dd7070Spatrick if (isSynthesizedAccessor(C.getStackFrame())) {
331e5dd7070Spatrick C.addTransition(setRefBinding(State, Sym, PlusZero));
332e5dd7070Spatrick return;
333e5dd7070Spatrick }
334e5dd7070Spatrick
335e5dd7070Spatrick State = setRefBinding(State, Sym, PlusZero.withIvarAccess());
336e5dd7070Spatrick C.addTransition(State);
337e5dd7070Spatrick }
338e5dd7070Spatrick
isReceiverUnconsumedSelf(const CallEvent & Call)339e5dd7070Spatrick static bool isReceiverUnconsumedSelf(const CallEvent &Call) {
340e5dd7070Spatrick if (const auto *MC = dyn_cast<ObjCMethodCall>(&Call)) {
341e5dd7070Spatrick
342e5dd7070Spatrick // Check if the message is not consumed, we know it will not be used in
343e5dd7070Spatrick // an assignment, ex: "self = [super init]".
344e5dd7070Spatrick return MC->getMethodFamily() == OMF_init && MC->isReceiverSelfOrSuper() &&
345e5dd7070Spatrick !Call.getLocationContext()
346e5dd7070Spatrick ->getAnalysisDeclContext()
347e5dd7070Spatrick ->getParentMap()
348e5dd7070Spatrick .isConsumedExpr(Call.getOriginExpr());
349e5dd7070Spatrick }
350e5dd7070Spatrick return false;
351e5dd7070Spatrick }
352e5dd7070Spatrick
getSummary(RetainSummaryManager & Summaries,const CallEvent & Call,QualType ReceiverType)353e5dd7070Spatrick const static RetainSummary *getSummary(RetainSummaryManager &Summaries,
354e5dd7070Spatrick const CallEvent &Call,
355e5dd7070Spatrick QualType ReceiverType) {
356e5dd7070Spatrick const Expr *CE = Call.getOriginExpr();
357e5dd7070Spatrick AnyCall C =
358e5dd7070Spatrick CE ? *AnyCall::forExpr(CE)
359e5dd7070Spatrick : AnyCall(cast<CXXDestructorDecl>(Call.getDecl()));
360e5dd7070Spatrick return Summaries.getSummary(C, Call.hasNonZeroCallbackArg(),
361e5dd7070Spatrick isReceiverUnconsumedSelf(Call), ReceiverType);
362e5dd7070Spatrick }
363e5dd7070Spatrick
checkPostCall(const CallEvent & Call,CheckerContext & C) const364e5dd7070Spatrick void RetainCountChecker::checkPostCall(const CallEvent &Call,
365e5dd7070Spatrick CheckerContext &C) const {
366e5dd7070Spatrick RetainSummaryManager &Summaries = getSummaryManager(C);
367e5dd7070Spatrick
368e5dd7070Spatrick // Leave null if no receiver.
369e5dd7070Spatrick QualType ReceiverType;
370e5dd7070Spatrick if (const auto *MC = dyn_cast<ObjCMethodCall>(&Call)) {
371e5dd7070Spatrick if (MC->isInstanceMessage()) {
372e5dd7070Spatrick SVal ReceiverV = MC->getReceiverSVal();
373e5dd7070Spatrick if (SymbolRef Sym = ReceiverV.getAsLocSymbol())
374e5dd7070Spatrick if (const RefVal *T = getRefBinding(C.getState(), Sym))
375e5dd7070Spatrick ReceiverType = T->getType();
376e5dd7070Spatrick }
377e5dd7070Spatrick }
378e5dd7070Spatrick
379e5dd7070Spatrick const RetainSummary *Summ = getSummary(Summaries, Call, ReceiverType);
380e5dd7070Spatrick
381e5dd7070Spatrick if (C.wasInlined) {
382e5dd7070Spatrick processSummaryOfInlined(*Summ, Call, C);
383e5dd7070Spatrick return;
384e5dd7070Spatrick }
385e5dd7070Spatrick checkSummary(*Summ, Call, C);
386e5dd7070Spatrick }
387e5dd7070Spatrick
388e5dd7070Spatrick /// GetReturnType - Used to get the return type of a message expression or
389e5dd7070Spatrick /// function call with the intention of affixing that type to a tracked symbol.
390e5dd7070Spatrick /// While the return type can be queried directly from RetEx, when
391e5dd7070Spatrick /// invoking class methods we augment to the return type to be that of
392e5dd7070Spatrick /// a pointer to the class (as opposed it just being id).
393e5dd7070Spatrick // FIXME: We may be able to do this with related result types instead.
394e5dd7070Spatrick // This function is probably overestimating.
GetReturnType(const Expr * RetE,ASTContext & Ctx)395e5dd7070Spatrick static QualType GetReturnType(const Expr *RetE, ASTContext &Ctx) {
396e5dd7070Spatrick QualType RetTy = RetE->getType();
397e5dd7070Spatrick // If RetE is not a message expression just return its type.
398e5dd7070Spatrick // If RetE is a message expression, return its types if it is something
399e5dd7070Spatrick /// more specific than id.
400e5dd7070Spatrick if (const ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(RetE))
401e5dd7070Spatrick if (const ObjCObjectPointerType *PT = RetTy->getAs<ObjCObjectPointerType>())
402e5dd7070Spatrick if (PT->isObjCQualifiedIdType() || PT->isObjCIdType() ||
403e5dd7070Spatrick PT->isObjCClassType()) {
404e5dd7070Spatrick // At this point we know the return type of the message expression is
405e5dd7070Spatrick // id, id<...>, or Class. If we have an ObjCInterfaceDecl, we know this
406e5dd7070Spatrick // is a call to a class method whose type we can resolve. In such
407e5dd7070Spatrick // cases, promote the return type to XXX* (where XXX is the class).
408e5dd7070Spatrick const ObjCInterfaceDecl *D = ME->getReceiverInterface();
409e5dd7070Spatrick return !D ? RetTy :
410e5dd7070Spatrick Ctx.getObjCObjectPointerType(Ctx.getObjCInterfaceType(D));
411e5dd7070Spatrick }
412e5dd7070Spatrick
413e5dd7070Spatrick return RetTy;
414e5dd7070Spatrick }
415e5dd7070Spatrick
refValFromRetEffect(RetEffect RE,QualType ResultTy)416*12c85518Srobert static std::optional<RefVal> refValFromRetEffect(RetEffect RE,
417e5dd7070Spatrick QualType ResultTy) {
418e5dd7070Spatrick if (RE.isOwned()) {
419e5dd7070Spatrick return RefVal::makeOwned(RE.getObjKind(), ResultTy);
420e5dd7070Spatrick } else if (RE.notOwned()) {
421e5dd7070Spatrick return RefVal::makeNotOwned(RE.getObjKind(), ResultTy);
422e5dd7070Spatrick }
423e5dd7070Spatrick
424*12c85518Srobert return std::nullopt;
425e5dd7070Spatrick }
426e5dd7070Spatrick
isPointerToObject(QualType QT)427e5dd7070Spatrick static bool isPointerToObject(QualType QT) {
428e5dd7070Spatrick QualType PT = QT->getPointeeType();
429e5dd7070Spatrick if (!PT.isNull())
430e5dd7070Spatrick if (PT->getAsCXXRecordDecl())
431e5dd7070Spatrick return true;
432e5dd7070Spatrick return false;
433e5dd7070Spatrick }
434e5dd7070Spatrick
435e5dd7070Spatrick /// Whether the tracked value should be escaped on a given call.
436e5dd7070Spatrick /// OSObjects are escaped when passed to void * / etc.
shouldEscapeOSArgumentOnCall(const CallEvent & CE,unsigned ArgIdx,const RefVal * TrackedValue)437e5dd7070Spatrick static bool shouldEscapeOSArgumentOnCall(const CallEvent &CE, unsigned ArgIdx,
438e5dd7070Spatrick const RefVal *TrackedValue) {
439e5dd7070Spatrick if (TrackedValue->getObjKind() != ObjKind::OS)
440e5dd7070Spatrick return false;
441e5dd7070Spatrick if (ArgIdx >= CE.parameters().size())
442e5dd7070Spatrick return false;
443e5dd7070Spatrick return !isPointerToObject(CE.parameters()[ArgIdx]->getType());
444e5dd7070Spatrick }
445e5dd7070Spatrick
446e5dd7070Spatrick // We don't always get the exact modeling of the function with regards to the
447e5dd7070Spatrick // retain count checker even when the function is inlined. For example, we need
448e5dd7070Spatrick // to stop tracking the symbols which were marked with StopTrackingHard.
processSummaryOfInlined(const RetainSummary & Summ,const CallEvent & CallOrMsg,CheckerContext & C) const449e5dd7070Spatrick void RetainCountChecker::processSummaryOfInlined(const RetainSummary &Summ,
450e5dd7070Spatrick const CallEvent &CallOrMsg,
451e5dd7070Spatrick CheckerContext &C) const {
452e5dd7070Spatrick ProgramStateRef state = C.getState();
453e5dd7070Spatrick
454e5dd7070Spatrick // Evaluate the effect of the arguments.
455e5dd7070Spatrick for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
456e5dd7070Spatrick SVal V = CallOrMsg.getArgSVal(idx);
457e5dd7070Spatrick
458e5dd7070Spatrick if (SymbolRef Sym = V.getAsLocSymbol()) {
459e5dd7070Spatrick bool ShouldRemoveBinding = Summ.getArg(idx).getKind() == StopTrackingHard;
460e5dd7070Spatrick if (const RefVal *T = getRefBinding(state, Sym))
461e5dd7070Spatrick if (shouldEscapeOSArgumentOnCall(CallOrMsg, idx, T))
462e5dd7070Spatrick ShouldRemoveBinding = true;
463e5dd7070Spatrick
464e5dd7070Spatrick if (ShouldRemoveBinding)
465e5dd7070Spatrick state = removeRefBinding(state, Sym);
466e5dd7070Spatrick }
467e5dd7070Spatrick }
468e5dd7070Spatrick
469e5dd7070Spatrick // Evaluate the effect on the message receiver.
470e5dd7070Spatrick if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
471e5dd7070Spatrick if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
472e5dd7070Spatrick if (Summ.getReceiverEffect().getKind() == StopTrackingHard) {
473e5dd7070Spatrick state = removeRefBinding(state, Sym);
474e5dd7070Spatrick }
475e5dd7070Spatrick }
476e5dd7070Spatrick }
477e5dd7070Spatrick
478e5dd7070Spatrick // Consult the summary for the return value.
479e5dd7070Spatrick RetEffect RE = Summ.getRetEffect();
480e5dd7070Spatrick
481e5dd7070Spatrick if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
482e5dd7070Spatrick if (RE.getKind() == RetEffect::NoRetHard)
483e5dd7070Spatrick state = removeRefBinding(state, Sym);
484e5dd7070Spatrick }
485e5dd7070Spatrick
486e5dd7070Spatrick C.addTransition(state);
487e5dd7070Spatrick }
488e5dd7070Spatrick
isSmartPtrField(const MemRegion * MR)489e5dd7070Spatrick static bool isSmartPtrField(const MemRegion *MR) {
490e5dd7070Spatrick const auto *TR = dyn_cast<TypedValueRegion>(
491e5dd7070Spatrick cast<SubRegion>(MR)->getSuperRegion());
492e5dd7070Spatrick return TR && RetainSummaryManager::isKnownSmartPointer(TR->getValueType());
493e5dd7070Spatrick }
494e5dd7070Spatrick
495e5dd7070Spatrick
496e5dd7070Spatrick /// A value escapes in these possible cases:
497e5dd7070Spatrick ///
498e5dd7070Spatrick /// - binding to something that is not a memory region.
499e5dd7070Spatrick /// - binding to a memregion that does not have stack storage
500e5dd7070Spatrick /// - binding to a variable that has a destructor attached using CleanupAttr
501e5dd7070Spatrick ///
502e5dd7070Spatrick /// We do not currently model what happens when a symbol is
503e5dd7070Spatrick /// assigned to a struct field, unless it is a known smart pointer
504e5dd7070Spatrick /// implementation, about which we know that it is inlined.
505e5dd7070Spatrick /// FIXME: This could definitely be improved upon.
shouldEscapeRegion(const MemRegion * R)506e5dd7070Spatrick static bool shouldEscapeRegion(const MemRegion *R) {
507e5dd7070Spatrick if (isSmartPtrField(R))
508e5dd7070Spatrick return false;
509e5dd7070Spatrick
510e5dd7070Spatrick const auto *VR = dyn_cast<VarRegion>(R);
511e5dd7070Spatrick
512e5dd7070Spatrick if (!R->hasStackStorage() || !VR)
513e5dd7070Spatrick return true;
514e5dd7070Spatrick
515e5dd7070Spatrick const VarDecl *VD = VR->getDecl();
516e5dd7070Spatrick if (!VD->hasAttr<CleanupAttr>())
517e5dd7070Spatrick return false; // CleanupAttr attaches destructors, which cause escaping.
518e5dd7070Spatrick return true;
519e5dd7070Spatrick }
520e5dd7070Spatrick
521e5dd7070Spatrick static SmallVector<ProgramStateRef, 2>
updateOutParameters(ProgramStateRef State,const RetainSummary & Summ,const CallEvent & CE)522e5dd7070Spatrick updateOutParameters(ProgramStateRef State, const RetainSummary &Summ,
523e5dd7070Spatrick const CallEvent &CE) {
524e5dd7070Spatrick
525e5dd7070Spatrick SVal L = CE.getReturnValue();
526e5dd7070Spatrick
527e5dd7070Spatrick // Splitting is required to support out parameters,
528e5dd7070Spatrick // as out parameters might be created only on the "success" branch.
529e5dd7070Spatrick // We want to avoid eagerly splitting unless out parameters are actually
530e5dd7070Spatrick // needed.
531e5dd7070Spatrick bool SplitNecessary = false;
532e5dd7070Spatrick for (auto &P : Summ.getArgEffects())
533e5dd7070Spatrick if (P.second.getKind() == RetainedOutParameterOnNonZero ||
534e5dd7070Spatrick P.second.getKind() == RetainedOutParameterOnZero)
535e5dd7070Spatrick SplitNecessary = true;
536e5dd7070Spatrick
537e5dd7070Spatrick ProgramStateRef AssumeNonZeroReturn = State;
538e5dd7070Spatrick ProgramStateRef AssumeZeroReturn = State;
539e5dd7070Spatrick
540e5dd7070Spatrick if (SplitNecessary) {
541e5dd7070Spatrick if (!CE.getResultType()->isScalarType()) {
542e5dd7070Spatrick // Structures cannot be assumed. This probably deserves
543e5dd7070Spatrick // a compiler warning for invalid annotations.
544e5dd7070Spatrick return {State};
545e5dd7070Spatrick }
546e5dd7070Spatrick if (auto DL = L.getAs<DefinedOrUnknownSVal>()) {
547e5dd7070Spatrick AssumeNonZeroReturn = AssumeNonZeroReturn->assume(*DL, true);
548e5dd7070Spatrick AssumeZeroReturn = AssumeZeroReturn->assume(*DL, false);
549e5dd7070Spatrick }
550e5dd7070Spatrick }
551e5dd7070Spatrick
552e5dd7070Spatrick for (unsigned idx = 0, e = CE.getNumArgs(); idx != e; ++idx) {
553e5dd7070Spatrick SVal ArgVal = CE.getArgSVal(idx);
554e5dd7070Spatrick ArgEffect AE = Summ.getArg(idx);
555e5dd7070Spatrick
556e5dd7070Spatrick auto *ArgRegion = dyn_cast_or_null<TypedValueRegion>(ArgVal.getAsRegion());
557e5dd7070Spatrick if (!ArgRegion)
558e5dd7070Spatrick continue;
559e5dd7070Spatrick
560e5dd7070Spatrick QualType PointeeTy = ArgRegion->getValueType();
561e5dd7070Spatrick SVal PointeeVal = State->getSVal(ArgRegion);
562e5dd7070Spatrick SymbolRef Pointee = PointeeVal.getAsLocSymbol();
563e5dd7070Spatrick if (!Pointee)
564e5dd7070Spatrick continue;
565e5dd7070Spatrick
566e5dd7070Spatrick if (shouldEscapeRegion(ArgRegion))
567e5dd7070Spatrick continue;
568e5dd7070Spatrick
569e5dd7070Spatrick auto makeNotOwnedParameter = [&](ProgramStateRef St) {
570e5dd7070Spatrick return setRefBinding(St, Pointee,
571e5dd7070Spatrick RefVal::makeNotOwned(AE.getObjKind(), PointeeTy));
572e5dd7070Spatrick };
573e5dd7070Spatrick auto makeOwnedParameter = [&](ProgramStateRef St) {
574e5dd7070Spatrick return setRefBinding(St, Pointee,
575e5dd7070Spatrick RefVal::makeOwned(ObjKind::OS, PointeeTy));
576e5dd7070Spatrick };
577e5dd7070Spatrick
578e5dd7070Spatrick switch (AE.getKind()) {
579e5dd7070Spatrick case UnretainedOutParameter:
580e5dd7070Spatrick AssumeNonZeroReturn = makeNotOwnedParameter(AssumeNonZeroReturn);
581e5dd7070Spatrick AssumeZeroReturn = makeNotOwnedParameter(AssumeZeroReturn);
582e5dd7070Spatrick break;
583e5dd7070Spatrick case RetainedOutParameter:
584e5dd7070Spatrick AssumeNonZeroReturn = makeOwnedParameter(AssumeNonZeroReturn);
585e5dd7070Spatrick AssumeZeroReturn = makeOwnedParameter(AssumeZeroReturn);
586e5dd7070Spatrick break;
587e5dd7070Spatrick case RetainedOutParameterOnNonZero:
588e5dd7070Spatrick AssumeNonZeroReturn = makeOwnedParameter(AssumeNonZeroReturn);
589e5dd7070Spatrick break;
590e5dd7070Spatrick case RetainedOutParameterOnZero:
591e5dd7070Spatrick AssumeZeroReturn = makeOwnedParameter(AssumeZeroReturn);
592e5dd7070Spatrick break;
593e5dd7070Spatrick default:
594e5dd7070Spatrick break;
595e5dd7070Spatrick }
596e5dd7070Spatrick }
597e5dd7070Spatrick
598e5dd7070Spatrick if (SplitNecessary) {
599e5dd7070Spatrick return {AssumeNonZeroReturn, AssumeZeroReturn};
600e5dd7070Spatrick } else {
601e5dd7070Spatrick assert(AssumeZeroReturn == AssumeNonZeroReturn);
602e5dd7070Spatrick return {AssumeZeroReturn};
603e5dd7070Spatrick }
604e5dd7070Spatrick }
605e5dd7070Spatrick
checkSummary(const RetainSummary & Summ,const CallEvent & CallOrMsg,CheckerContext & C) const606e5dd7070Spatrick void RetainCountChecker::checkSummary(const RetainSummary &Summ,
607e5dd7070Spatrick const CallEvent &CallOrMsg,
608e5dd7070Spatrick CheckerContext &C) const {
609e5dd7070Spatrick ProgramStateRef state = C.getState();
610e5dd7070Spatrick
611e5dd7070Spatrick // Evaluate the effect of the arguments.
612e5dd7070Spatrick RefVal::Kind hasErr = (RefVal::Kind) 0;
613e5dd7070Spatrick SourceRange ErrorRange;
614e5dd7070Spatrick SymbolRef ErrorSym = nullptr;
615e5dd7070Spatrick
616e5dd7070Spatrick // Helper tag for providing diagnostics: indicate whether dealloc was sent
617e5dd7070Spatrick // at this location.
618e5dd7070Spatrick bool DeallocSent = false;
619e5dd7070Spatrick
620e5dd7070Spatrick for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
621e5dd7070Spatrick SVal V = CallOrMsg.getArgSVal(idx);
622e5dd7070Spatrick
623e5dd7070Spatrick ArgEffect Effect = Summ.getArg(idx);
624e5dd7070Spatrick if (SymbolRef Sym = V.getAsLocSymbol()) {
625e5dd7070Spatrick if (const RefVal *T = getRefBinding(state, Sym)) {
626e5dd7070Spatrick
627e5dd7070Spatrick if (shouldEscapeOSArgumentOnCall(CallOrMsg, idx, T))
628e5dd7070Spatrick Effect = ArgEffect(StopTrackingHard, ObjKind::OS);
629e5dd7070Spatrick
630e5dd7070Spatrick state = updateSymbol(state, Sym, *T, Effect, hasErr, C);
631e5dd7070Spatrick if (hasErr) {
632e5dd7070Spatrick ErrorRange = CallOrMsg.getArgSourceRange(idx);
633e5dd7070Spatrick ErrorSym = Sym;
634e5dd7070Spatrick break;
635e5dd7070Spatrick } else if (Effect.getKind() == Dealloc) {
636e5dd7070Spatrick DeallocSent = true;
637e5dd7070Spatrick }
638e5dd7070Spatrick }
639e5dd7070Spatrick }
640e5dd7070Spatrick }
641e5dd7070Spatrick
642e5dd7070Spatrick // Evaluate the effect on the message receiver / `this` argument.
643e5dd7070Spatrick bool ReceiverIsTracked = false;
644e5dd7070Spatrick if (!hasErr) {
645e5dd7070Spatrick if (const auto *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg)) {
646e5dd7070Spatrick if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
647e5dd7070Spatrick if (const RefVal *T = getRefBinding(state, Sym)) {
648e5dd7070Spatrick ReceiverIsTracked = true;
649e5dd7070Spatrick state = updateSymbol(state, Sym, *T,
650e5dd7070Spatrick Summ.getReceiverEffect(), hasErr, C);
651e5dd7070Spatrick if (hasErr) {
652e5dd7070Spatrick ErrorRange = MsgInvocation->getOriginExpr()->getReceiverRange();
653e5dd7070Spatrick ErrorSym = Sym;
654e5dd7070Spatrick } else if (Summ.getReceiverEffect().getKind() == Dealloc) {
655e5dd7070Spatrick DeallocSent = true;
656e5dd7070Spatrick }
657e5dd7070Spatrick }
658e5dd7070Spatrick }
659e5dd7070Spatrick } else if (const auto *MCall = dyn_cast<CXXMemberCall>(&CallOrMsg)) {
660e5dd7070Spatrick if (SymbolRef Sym = MCall->getCXXThisVal().getAsLocSymbol()) {
661e5dd7070Spatrick if (const RefVal *T = getRefBinding(state, Sym)) {
662e5dd7070Spatrick state = updateSymbol(state, Sym, *T, Summ.getThisEffect(),
663e5dd7070Spatrick hasErr, C);
664e5dd7070Spatrick if (hasErr) {
665e5dd7070Spatrick ErrorRange = MCall->getOriginExpr()->getSourceRange();
666e5dd7070Spatrick ErrorSym = Sym;
667e5dd7070Spatrick }
668e5dd7070Spatrick }
669e5dd7070Spatrick }
670e5dd7070Spatrick }
671e5dd7070Spatrick }
672e5dd7070Spatrick
673e5dd7070Spatrick // Process any errors.
674e5dd7070Spatrick if (hasErr) {
675e5dd7070Spatrick processNonLeakError(state, ErrorRange, hasErr, ErrorSym, C);
676e5dd7070Spatrick return;
677e5dd7070Spatrick }
678e5dd7070Spatrick
679e5dd7070Spatrick // Consult the summary for the return value.
680e5dd7070Spatrick RetEffect RE = Summ.getRetEffect();
681e5dd7070Spatrick
682e5dd7070Spatrick if (RE.getKind() == RetEffect::OwnedWhenTrackedReceiver) {
683e5dd7070Spatrick if (ReceiverIsTracked)
684e5dd7070Spatrick RE = getSummaryManager(C).getObjAllocRetEffect();
685e5dd7070Spatrick else
686e5dd7070Spatrick RE = RetEffect::MakeNoRet();
687e5dd7070Spatrick }
688e5dd7070Spatrick
689e5dd7070Spatrick if (SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol()) {
690e5dd7070Spatrick QualType ResultTy = CallOrMsg.getResultType();
691e5dd7070Spatrick if (RE.notOwned()) {
692e5dd7070Spatrick const Expr *Ex = CallOrMsg.getOriginExpr();
693e5dd7070Spatrick assert(Ex);
694e5dd7070Spatrick ResultTy = GetReturnType(Ex, C.getASTContext());
695e5dd7070Spatrick }
696*12c85518Srobert if (std::optional<RefVal> updatedRefVal = refValFromRetEffect(RE, ResultTy))
697e5dd7070Spatrick state = setRefBinding(state, Sym, *updatedRefVal);
698e5dd7070Spatrick }
699e5dd7070Spatrick
700e5dd7070Spatrick SmallVector<ProgramStateRef, 2> Out =
701e5dd7070Spatrick updateOutParameters(state, Summ, CallOrMsg);
702e5dd7070Spatrick
703e5dd7070Spatrick for (ProgramStateRef St : Out) {
704e5dd7070Spatrick if (DeallocSent) {
705ec727ea7Spatrick C.addTransition(St, C.getPredecessor(), &getDeallocSentTag());
706e5dd7070Spatrick } else {
707e5dd7070Spatrick C.addTransition(St);
708e5dd7070Spatrick }
709e5dd7070Spatrick }
710e5dd7070Spatrick }
711e5dd7070Spatrick
updateSymbol(ProgramStateRef state,SymbolRef sym,RefVal V,ArgEffect AE,RefVal::Kind & hasErr,CheckerContext & C) const712e5dd7070Spatrick ProgramStateRef RetainCountChecker::updateSymbol(ProgramStateRef state,
713e5dd7070Spatrick SymbolRef sym, RefVal V,
714e5dd7070Spatrick ArgEffect AE,
715e5dd7070Spatrick RefVal::Kind &hasErr,
716e5dd7070Spatrick CheckerContext &C) const {
717e5dd7070Spatrick bool IgnoreRetainMsg = (bool)C.getASTContext().getLangOpts().ObjCAutoRefCount;
718e5dd7070Spatrick if (AE.getObjKind() == ObjKind::ObjC && IgnoreRetainMsg) {
719e5dd7070Spatrick switch (AE.getKind()) {
720e5dd7070Spatrick default:
721e5dd7070Spatrick break;
722e5dd7070Spatrick case IncRef:
723e5dd7070Spatrick AE = AE.withKind(DoNothing);
724e5dd7070Spatrick break;
725e5dd7070Spatrick case DecRef:
726e5dd7070Spatrick AE = AE.withKind(DoNothing);
727e5dd7070Spatrick break;
728e5dd7070Spatrick case DecRefAndStopTrackingHard:
729e5dd7070Spatrick AE = AE.withKind(StopTracking);
730e5dd7070Spatrick break;
731e5dd7070Spatrick }
732e5dd7070Spatrick }
733e5dd7070Spatrick
734e5dd7070Spatrick // Handle all use-after-releases.
735e5dd7070Spatrick if (V.getKind() == RefVal::Released) {
736e5dd7070Spatrick V = V ^ RefVal::ErrorUseAfterRelease;
737e5dd7070Spatrick hasErr = V.getKind();
738e5dd7070Spatrick return setRefBinding(state, sym, V);
739e5dd7070Spatrick }
740e5dd7070Spatrick
741e5dd7070Spatrick switch (AE.getKind()) {
742e5dd7070Spatrick case UnretainedOutParameter:
743e5dd7070Spatrick case RetainedOutParameter:
744e5dd7070Spatrick case RetainedOutParameterOnZero:
745e5dd7070Spatrick case RetainedOutParameterOnNonZero:
746e5dd7070Spatrick llvm_unreachable("Applies to pointer-to-pointer parameters, which should "
747e5dd7070Spatrick "not have ref state.");
748e5dd7070Spatrick
749e5dd7070Spatrick case Dealloc: // NB. we only need to add a note in a non-error case.
750e5dd7070Spatrick switch (V.getKind()) {
751e5dd7070Spatrick default:
752e5dd7070Spatrick llvm_unreachable("Invalid RefVal state for an explicit dealloc.");
753e5dd7070Spatrick case RefVal::Owned:
754e5dd7070Spatrick // The object immediately transitions to the released state.
755e5dd7070Spatrick V = V ^ RefVal::Released;
756e5dd7070Spatrick V.clearCounts();
757e5dd7070Spatrick return setRefBinding(state, sym, V);
758e5dd7070Spatrick case RefVal::NotOwned:
759e5dd7070Spatrick V = V ^ RefVal::ErrorDeallocNotOwned;
760e5dd7070Spatrick hasErr = V.getKind();
761e5dd7070Spatrick break;
762e5dd7070Spatrick }
763e5dd7070Spatrick break;
764e5dd7070Spatrick
765e5dd7070Spatrick case MayEscape:
766e5dd7070Spatrick if (V.getKind() == RefVal::Owned) {
767e5dd7070Spatrick V = V ^ RefVal::NotOwned;
768e5dd7070Spatrick break;
769e5dd7070Spatrick }
770e5dd7070Spatrick
771*12c85518Srobert [[fallthrough]];
772e5dd7070Spatrick
773e5dd7070Spatrick case DoNothing:
774e5dd7070Spatrick return state;
775e5dd7070Spatrick
776e5dd7070Spatrick case Autorelease:
777e5dd7070Spatrick // Update the autorelease counts.
778e5dd7070Spatrick V = V.autorelease();
779e5dd7070Spatrick break;
780e5dd7070Spatrick
781e5dd7070Spatrick case StopTracking:
782e5dd7070Spatrick case StopTrackingHard:
783e5dd7070Spatrick return removeRefBinding(state, sym);
784e5dd7070Spatrick
785e5dd7070Spatrick case IncRef:
786e5dd7070Spatrick switch (V.getKind()) {
787e5dd7070Spatrick default:
788e5dd7070Spatrick llvm_unreachable("Invalid RefVal state for a retain.");
789e5dd7070Spatrick case RefVal::Owned:
790e5dd7070Spatrick case RefVal::NotOwned:
791e5dd7070Spatrick V = V + 1;
792e5dd7070Spatrick break;
793e5dd7070Spatrick }
794e5dd7070Spatrick break;
795e5dd7070Spatrick
796e5dd7070Spatrick case DecRef:
797e5dd7070Spatrick case DecRefBridgedTransferred:
798e5dd7070Spatrick case DecRefAndStopTrackingHard:
799e5dd7070Spatrick switch (V.getKind()) {
800e5dd7070Spatrick default:
801e5dd7070Spatrick // case 'RefVal::Released' handled above.
802e5dd7070Spatrick llvm_unreachable("Invalid RefVal state for a release.");
803e5dd7070Spatrick
804e5dd7070Spatrick case RefVal::Owned:
805e5dd7070Spatrick assert(V.getCount() > 0);
806e5dd7070Spatrick if (V.getCount() == 1) {
807e5dd7070Spatrick if (AE.getKind() == DecRefBridgedTransferred ||
808e5dd7070Spatrick V.getIvarAccessHistory() ==
809e5dd7070Spatrick RefVal::IvarAccessHistory::AccessedDirectly)
810e5dd7070Spatrick V = V ^ RefVal::NotOwned;
811e5dd7070Spatrick else
812e5dd7070Spatrick V = V ^ RefVal::Released;
813e5dd7070Spatrick } else if (AE.getKind() == DecRefAndStopTrackingHard) {
814e5dd7070Spatrick return removeRefBinding(state, sym);
815e5dd7070Spatrick }
816e5dd7070Spatrick
817e5dd7070Spatrick V = V - 1;
818e5dd7070Spatrick break;
819e5dd7070Spatrick
820e5dd7070Spatrick case RefVal::NotOwned:
821e5dd7070Spatrick if (V.getCount() > 0) {
822e5dd7070Spatrick if (AE.getKind() == DecRefAndStopTrackingHard)
823e5dd7070Spatrick return removeRefBinding(state, sym);
824e5dd7070Spatrick V = V - 1;
825e5dd7070Spatrick } else if (V.getIvarAccessHistory() ==
826e5dd7070Spatrick RefVal::IvarAccessHistory::AccessedDirectly) {
827e5dd7070Spatrick // Assume that the instance variable was holding on the object at
828e5dd7070Spatrick // +1, and we just didn't know.
829e5dd7070Spatrick if (AE.getKind() == DecRefAndStopTrackingHard)
830e5dd7070Spatrick return removeRefBinding(state, sym);
831e5dd7070Spatrick V = V.releaseViaIvar() ^ RefVal::Released;
832e5dd7070Spatrick } else {
833e5dd7070Spatrick V = V ^ RefVal::ErrorReleaseNotOwned;
834e5dd7070Spatrick hasErr = V.getKind();
835e5dd7070Spatrick }
836e5dd7070Spatrick break;
837e5dd7070Spatrick }
838e5dd7070Spatrick break;
839e5dd7070Spatrick }
840e5dd7070Spatrick return setRefBinding(state, sym, V);
841e5dd7070Spatrick }
842e5dd7070Spatrick
843e5dd7070Spatrick const RefCountBug &
errorKindToBugKind(RefVal::Kind ErrorKind,SymbolRef Sym) const844e5dd7070Spatrick RetainCountChecker::errorKindToBugKind(RefVal::Kind ErrorKind,
845e5dd7070Spatrick SymbolRef Sym) const {
846e5dd7070Spatrick switch (ErrorKind) {
847e5dd7070Spatrick case RefVal::ErrorUseAfterRelease:
848ec727ea7Spatrick return *UseAfterRelease;
849e5dd7070Spatrick case RefVal::ErrorReleaseNotOwned:
850ec727ea7Spatrick return *ReleaseNotOwned;
851e5dd7070Spatrick case RefVal::ErrorDeallocNotOwned:
852e5dd7070Spatrick if (Sym->getType()->getPointeeCXXRecordDecl())
853ec727ea7Spatrick return *FreeNotOwned;
854ec727ea7Spatrick return *DeallocNotOwned;
855e5dd7070Spatrick default:
856e5dd7070Spatrick llvm_unreachable("Unhandled error.");
857e5dd7070Spatrick }
858e5dd7070Spatrick }
859e5dd7070Spatrick
processNonLeakError(ProgramStateRef St,SourceRange ErrorRange,RefVal::Kind ErrorKind,SymbolRef Sym,CheckerContext & C) const860e5dd7070Spatrick void RetainCountChecker::processNonLeakError(ProgramStateRef St,
861e5dd7070Spatrick SourceRange ErrorRange,
862e5dd7070Spatrick RefVal::Kind ErrorKind,
863e5dd7070Spatrick SymbolRef Sym,
864e5dd7070Spatrick CheckerContext &C) const {
865e5dd7070Spatrick // HACK: Ignore retain-count issues on values accessed through ivars,
866e5dd7070Spatrick // because of cases like this:
867e5dd7070Spatrick // [_contentView retain];
868e5dd7070Spatrick // [_contentView removeFromSuperview];
869e5dd7070Spatrick // [self addSubview:_contentView]; // invalidates 'self'
870e5dd7070Spatrick // [_contentView release];
871e5dd7070Spatrick if (const RefVal *RV = getRefBinding(St, Sym))
872e5dd7070Spatrick if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
873e5dd7070Spatrick return;
874e5dd7070Spatrick
875e5dd7070Spatrick ExplodedNode *N = C.generateErrorNode(St);
876e5dd7070Spatrick if (!N)
877e5dd7070Spatrick return;
878e5dd7070Spatrick
879e5dd7070Spatrick auto report = std::make_unique<RefCountReport>(
880e5dd7070Spatrick errorKindToBugKind(ErrorKind, Sym),
881e5dd7070Spatrick C.getASTContext().getLangOpts(), N, Sym);
882e5dd7070Spatrick report->addRange(ErrorRange);
883e5dd7070Spatrick C.emitReport(std::move(report));
884e5dd7070Spatrick }
885e5dd7070Spatrick
886e5dd7070Spatrick //===----------------------------------------------------------------------===//
887e5dd7070Spatrick // Handle the return values of retain-count-related functions.
888e5dd7070Spatrick //===----------------------------------------------------------------------===//
889e5dd7070Spatrick
evalCall(const CallEvent & Call,CheckerContext & C) const890e5dd7070Spatrick bool RetainCountChecker::evalCall(const CallEvent &Call,
891e5dd7070Spatrick CheckerContext &C) const {
892e5dd7070Spatrick ProgramStateRef state = C.getState();
893e5dd7070Spatrick const auto *FD = dyn_cast_or_null<FunctionDecl>(Call.getDecl());
894e5dd7070Spatrick if (!FD)
895e5dd7070Spatrick return false;
896e5dd7070Spatrick
897e5dd7070Spatrick const auto *CE = dyn_cast_or_null<CallExpr>(Call.getOriginExpr());
898e5dd7070Spatrick if (!CE)
899e5dd7070Spatrick return false;
900e5dd7070Spatrick
901e5dd7070Spatrick RetainSummaryManager &SmrMgr = getSummaryManager(C);
902e5dd7070Spatrick QualType ResultTy = Call.getResultType();
903e5dd7070Spatrick
904e5dd7070Spatrick // See if the function has 'rc_ownership_trusted_implementation'
905e5dd7070Spatrick // annotate attribute. If it does, we will not inline it.
906e5dd7070Spatrick bool hasTrustedImplementationAnnotation = false;
907e5dd7070Spatrick
908e5dd7070Spatrick const LocationContext *LCtx = C.getLocationContext();
909e5dd7070Spatrick
910e5dd7070Spatrick using BehaviorSummary = RetainSummaryManager::BehaviorSummary;
911*12c85518Srobert std::optional<BehaviorSummary> BSmr =
912e5dd7070Spatrick SmrMgr.canEval(CE, FD, hasTrustedImplementationAnnotation);
913e5dd7070Spatrick
914e5dd7070Spatrick // See if it's one of the specific functions we know how to eval.
915e5dd7070Spatrick if (!BSmr)
916e5dd7070Spatrick return false;
917e5dd7070Spatrick
918e5dd7070Spatrick // Bind the return value.
919e5dd7070Spatrick if (BSmr == BehaviorSummary::Identity ||
920e5dd7070Spatrick BSmr == BehaviorSummary::IdentityOrZero ||
921e5dd7070Spatrick BSmr == BehaviorSummary::IdentityThis) {
922e5dd7070Spatrick
923e5dd7070Spatrick const Expr *BindReturnTo =
924e5dd7070Spatrick (BSmr == BehaviorSummary::IdentityThis)
925e5dd7070Spatrick ? cast<CXXMemberCallExpr>(CE)->getImplicitObjectArgument()
926e5dd7070Spatrick : CE->getArg(0);
927e5dd7070Spatrick SVal RetVal = state->getSVal(BindReturnTo, LCtx);
928e5dd7070Spatrick
929e5dd7070Spatrick // If the receiver is unknown or the function has
930e5dd7070Spatrick // 'rc_ownership_trusted_implementation' annotate attribute, conjure a
931e5dd7070Spatrick // return value.
932e5dd7070Spatrick // FIXME: this branch is very strange.
933e5dd7070Spatrick if (RetVal.isUnknown() ||
934e5dd7070Spatrick (hasTrustedImplementationAnnotation && !ResultTy.isNull())) {
935e5dd7070Spatrick SValBuilder &SVB = C.getSValBuilder();
936e5dd7070Spatrick RetVal =
937e5dd7070Spatrick SVB.conjureSymbolVal(nullptr, CE, LCtx, ResultTy, C.blockCount());
938e5dd7070Spatrick }
939e5dd7070Spatrick
940e5dd7070Spatrick // Bind the value.
941e5dd7070Spatrick state = state->BindExpr(CE, LCtx, RetVal, /*Invalidate=*/false);
942e5dd7070Spatrick
943e5dd7070Spatrick if (BSmr == BehaviorSummary::IdentityOrZero) {
944e5dd7070Spatrick // Add a branch where the output is zero.
945e5dd7070Spatrick ProgramStateRef NullOutputState = C.getState();
946e5dd7070Spatrick
947e5dd7070Spatrick // Assume that output is zero on the other branch.
948e5dd7070Spatrick NullOutputState = NullOutputState->BindExpr(
949*12c85518Srobert CE, LCtx, C.getSValBuilder().makeNullWithType(ResultTy),
950*12c85518Srobert /*Invalidate=*/false);
951ec727ea7Spatrick C.addTransition(NullOutputState, &getCastFailTag());
952e5dd7070Spatrick
953e5dd7070Spatrick // And on the original branch assume that both input and
954e5dd7070Spatrick // output are non-zero.
955e5dd7070Spatrick if (auto L = RetVal.getAs<DefinedOrUnknownSVal>())
956e5dd7070Spatrick state = state->assume(*L, /*assumption=*/true);
957e5dd7070Spatrick
958e5dd7070Spatrick }
959e5dd7070Spatrick }
960e5dd7070Spatrick
961e5dd7070Spatrick C.addTransition(state);
962e5dd7070Spatrick return true;
963e5dd7070Spatrick }
964e5dd7070Spatrick
processReturn(const ReturnStmt * S,CheckerContext & C) const965e5dd7070Spatrick ExplodedNode * RetainCountChecker::processReturn(const ReturnStmt *S,
966e5dd7070Spatrick CheckerContext &C) const {
967e5dd7070Spatrick ExplodedNode *Pred = C.getPredecessor();
968e5dd7070Spatrick
969e5dd7070Spatrick // Only adjust the reference count if this is the top-level call frame,
970e5dd7070Spatrick // and not the result of inlining. In the future, we should do
971e5dd7070Spatrick // better checking even for inlined calls, and see if they match
972e5dd7070Spatrick // with their expected semantics (e.g., the method should return a retained
973e5dd7070Spatrick // object, etc.).
974e5dd7070Spatrick if (!C.inTopFrame())
975e5dd7070Spatrick return Pred;
976e5dd7070Spatrick
977e5dd7070Spatrick if (!S)
978e5dd7070Spatrick return Pred;
979e5dd7070Spatrick
980e5dd7070Spatrick const Expr *RetE = S->getRetValue();
981e5dd7070Spatrick if (!RetE)
982e5dd7070Spatrick return Pred;
983e5dd7070Spatrick
984e5dd7070Spatrick ProgramStateRef state = C.getState();
985e5dd7070Spatrick // We need to dig down to the symbolic base here because various
986e5dd7070Spatrick // custom allocators do sometimes return the symbol with an offset.
987e5dd7070Spatrick SymbolRef Sym = state->getSValAsScalarOrLoc(RetE, C.getLocationContext())
988e5dd7070Spatrick .getAsLocSymbol(/*IncludeBaseRegions=*/true);
989e5dd7070Spatrick if (!Sym)
990e5dd7070Spatrick return Pred;
991e5dd7070Spatrick
992e5dd7070Spatrick // Get the reference count binding (if any).
993e5dd7070Spatrick const RefVal *T = getRefBinding(state, Sym);
994e5dd7070Spatrick if (!T)
995e5dd7070Spatrick return Pred;
996e5dd7070Spatrick
997e5dd7070Spatrick // Change the reference count.
998e5dd7070Spatrick RefVal X = *T;
999e5dd7070Spatrick
1000e5dd7070Spatrick switch (X.getKind()) {
1001e5dd7070Spatrick case RefVal::Owned: {
1002e5dd7070Spatrick unsigned cnt = X.getCount();
1003e5dd7070Spatrick assert(cnt > 0);
1004e5dd7070Spatrick X.setCount(cnt - 1);
1005e5dd7070Spatrick X = X ^ RefVal::ReturnedOwned;
1006e5dd7070Spatrick break;
1007e5dd7070Spatrick }
1008e5dd7070Spatrick
1009e5dd7070Spatrick case RefVal::NotOwned: {
1010e5dd7070Spatrick unsigned cnt = X.getCount();
1011e5dd7070Spatrick if (cnt) {
1012e5dd7070Spatrick X.setCount(cnt - 1);
1013e5dd7070Spatrick X = X ^ RefVal::ReturnedOwned;
1014e5dd7070Spatrick } else {
1015e5dd7070Spatrick X = X ^ RefVal::ReturnedNotOwned;
1016e5dd7070Spatrick }
1017e5dd7070Spatrick break;
1018e5dd7070Spatrick }
1019e5dd7070Spatrick
1020e5dd7070Spatrick default:
1021e5dd7070Spatrick return Pred;
1022e5dd7070Spatrick }
1023e5dd7070Spatrick
1024e5dd7070Spatrick // Update the binding.
1025e5dd7070Spatrick state = setRefBinding(state, Sym, X);
1026e5dd7070Spatrick Pred = C.addTransition(state);
1027e5dd7070Spatrick
1028e5dd7070Spatrick // At this point we have updated the state properly.
1029e5dd7070Spatrick // Everything after this is merely checking to see if the return value has
1030e5dd7070Spatrick // been over- or under-retained.
1031e5dd7070Spatrick
1032e5dd7070Spatrick // Did we cache out?
1033e5dd7070Spatrick if (!Pred)
1034e5dd7070Spatrick return nullptr;
1035e5dd7070Spatrick
1036e5dd7070Spatrick // Update the autorelease counts.
1037e5dd7070Spatrick static CheckerProgramPointTag AutoreleaseTag(this, "Autorelease");
1038e5dd7070Spatrick state = handleAutoreleaseCounts(state, Pred, &AutoreleaseTag, C, Sym, X, S);
1039e5dd7070Spatrick
1040e5dd7070Spatrick // Have we generated a sink node?
1041e5dd7070Spatrick if (!state)
1042e5dd7070Spatrick return nullptr;
1043e5dd7070Spatrick
1044e5dd7070Spatrick // Get the updated binding.
1045e5dd7070Spatrick T = getRefBinding(state, Sym);
1046e5dd7070Spatrick assert(T);
1047e5dd7070Spatrick X = *T;
1048e5dd7070Spatrick
1049e5dd7070Spatrick // Consult the summary of the enclosing method.
1050e5dd7070Spatrick RetainSummaryManager &Summaries = getSummaryManager(C);
1051e5dd7070Spatrick const Decl *CD = &Pred->getCodeDecl();
1052e5dd7070Spatrick RetEffect RE = RetEffect::MakeNoRet();
1053e5dd7070Spatrick
1054e5dd7070Spatrick // FIXME: What is the convention for blocks? Is there one?
1055e5dd7070Spatrick if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(CD)) {
1056e5dd7070Spatrick const RetainSummary *Summ = Summaries.getSummary(AnyCall(MD));
1057e5dd7070Spatrick RE = Summ->getRetEffect();
1058e5dd7070Spatrick } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(CD)) {
1059e5dd7070Spatrick if (!isa<CXXMethodDecl>(FD)) {
1060e5dd7070Spatrick const RetainSummary *Summ = Summaries.getSummary(AnyCall(FD));
1061e5dd7070Spatrick RE = Summ->getRetEffect();
1062e5dd7070Spatrick }
1063e5dd7070Spatrick }
1064e5dd7070Spatrick
1065e5dd7070Spatrick return checkReturnWithRetEffect(S, C, Pred, RE, X, Sym, state);
1066e5dd7070Spatrick }
1067e5dd7070Spatrick
checkReturnWithRetEffect(const ReturnStmt * S,CheckerContext & C,ExplodedNode * Pred,RetEffect RE,RefVal X,SymbolRef Sym,ProgramStateRef state) const1068e5dd7070Spatrick ExplodedNode * RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S,
1069e5dd7070Spatrick CheckerContext &C,
1070e5dd7070Spatrick ExplodedNode *Pred,
1071e5dd7070Spatrick RetEffect RE, RefVal X,
1072e5dd7070Spatrick SymbolRef Sym,
1073e5dd7070Spatrick ProgramStateRef state) const {
1074e5dd7070Spatrick // HACK: Ignore retain-count issues on values accessed through ivars,
1075e5dd7070Spatrick // because of cases like this:
1076e5dd7070Spatrick // [_contentView retain];
1077e5dd7070Spatrick // [_contentView removeFromSuperview];
1078e5dd7070Spatrick // [self addSubview:_contentView]; // invalidates 'self'
1079e5dd7070Spatrick // [_contentView release];
1080e5dd7070Spatrick if (X.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1081e5dd7070Spatrick return Pred;
1082e5dd7070Spatrick
1083e5dd7070Spatrick // Any leaks or other errors?
1084e5dd7070Spatrick if (X.isReturnedOwned() && X.getCount() == 0) {
1085e5dd7070Spatrick if (RE.getKind() != RetEffect::NoRet) {
1086e5dd7070Spatrick if (!RE.isOwned()) {
1087e5dd7070Spatrick
1088e5dd7070Spatrick // The returning type is a CF, we expect the enclosing method should
1089e5dd7070Spatrick // return ownership.
1090e5dd7070Spatrick X = X ^ RefVal::ErrorLeakReturned;
1091e5dd7070Spatrick
1092e5dd7070Spatrick // Generate an error node.
1093e5dd7070Spatrick state = setRefBinding(state, Sym, X);
1094e5dd7070Spatrick
1095e5dd7070Spatrick static CheckerProgramPointTag ReturnOwnLeakTag(this, "ReturnsOwnLeak");
1096e5dd7070Spatrick ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag);
1097e5dd7070Spatrick if (N) {
1098e5dd7070Spatrick const LangOptions &LOpts = C.getASTContext().getLangOpts();
1099e5dd7070Spatrick auto R =
1100ec727ea7Spatrick std::make_unique<RefLeakReport>(*LeakAtReturn, LOpts, N, Sym, C);
1101e5dd7070Spatrick C.emitReport(std::move(R));
1102e5dd7070Spatrick }
1103e5dd7070Spatrick return N;
1104e5dd7070Spatrick }
1105e5dd7070Spatrick }
1106e5dd7070Spatrick } else if (X.isReturnedNotOwned()) {
1107e5dd7070Spatrick if (RE.isOwned()) {
1108e5dd7070Spatrick if (X.getIvarAccessHistory() ==
1109e5dd7070Spatrick RefVal::IvarAccessHistory::AccessedDirectly) {
1110e5dd7070Spatrick // Assume the method was trying to transfer a +1 reference from a
1111e5dd7070Spatrick // strong ivar to the caller.
1112e5dd7070Spatrick state = setRefBinding(state, Sym,
1113e5dd7070Spatrick X.releaseViaIvar() ^ RefVal::ReturnedOwned);
1114e5dd7070Spatrick } else {
1115e5dd7070Spatrick // Trying to return a not owned object to a caller expecting an
1116e5dd7070Spatrick // owned object.
1117e5dd7070Spatrick state = setRefBinding(state, Sym, X ^ RefVal::ErrorReturnedNotOwned);
1118e5dd7070Spatrick
1119e5dd7070Spatrick static CheckerProgramPointTag
1120e5dd7070Spatrick ReturnNotOwnedTag(this, "ReturnNotOwnedForOwned");
1121e5dd7070Spatrick
1122e5dd7070Spatrick ExplodedNode *N = C.addTransition(state, Pred, &ReturnNotOwnedTag);
1123e5dd7070Spatrick if (N) {
1124e5dd7070Spatrick auto R = std::make_unique<RefCountReport>(
1125ec727ea7Spatrick *ReturnNotOwnedForOwned, C.getASTContext().getLangOpts(), N, Sym);
1126e5dd7070Spatrick C.emitReport(std::move(R));
1127e5dd7070Spatrick }
1128e5dd7070Spatrick return N;
1129e5dd7070Spatrick }
1130e5dd7070Spatrick }
1131e5dd7070Spatrick }
1132e5dd7070Spatrick return Pred;
1133e5dd7070Spatrick }
1134e5dd7070Spatrick
1135e5dd7070Spatrick //===----------------------------------------------------------------------===//
1136e5dd7070Spatrick // Check various ways a symbol can be invalidated.
1137e5dd7070Spatrick //===----------------------------------------------------------------------===//
1138e5dd7070Spatrick
checkBind(SVal loc,SVal val,const Stmt * S,CheckerContext & C) const1139e5dd7070Spatrick void RetainCountChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1140e5dd7070Spatrick CheckerContext &C) const {
1141e5dd7070Spatrick ProgramStateRef state = C.getState();
1142e5dd7070Spatrick const MemRegion *MR = loc.getAsRegion();
1143e5dd7070Spatrick
1144e5dd7070Spatrick // Find all symbols referenced by 'val' that we are tracking
1145e5dd7070Spatrick // and stop tracking them.
1146e5dd7070Spatrick if (MR && shouldEscapeRegion(MR)) {
1147e5dd7070Spatrick state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1148e5dd7070Spatrick C.addTransition(state);
1149e5dd7070Spatrick }
1150e5dd7070Spatrick }
1151e5dd7070Spatrick
evalAssume(ProgramStateRef state,SVal Cond,bool Assumption) const1152e5dd7070Spatrick ProgramStateRef RetainCountChecker::evalAssume(ProgramStateRef state,
1153e5dd7070Spatrick SVal Cond,
1154e5dd7070Spatrick bool Assumption) const {
1155e5dd7070Spatrick // FIXME: We may add to the interface of evalAssume the list of symbols
1156e5dd7070Spatrick // whose assumptions have changed. For now we just iterate through the
1157e5dd7070Spatrick // bindings and check if any of the tracked symbols are NULL. This isn't
1158e5dd7070Spatrick // too bad since the number of symbols we will track in practice are
1159e5dd7070Spatrick // probably small and evalAssume is only called at branches and a few
1160e5dd7070Spatrick // other places.
1161e5dd7070Spatrick RefBindingsTy B = state->get<RefBindings>();
1162e5dd7070Spatrick
1163e5dd7070Spatrick if (B.isEmpty())
1164e5dd7070Spatrick return state;
1165e5dd7070Spatrick
1166e5dd7070Spatrick bool changed = false;
1167e5dd7070Spatrick RefBindingsTy::Factory &RefBFactory = state->get_context<RefBindings>();
1168e5dd7070Spatrick ConstraintManager &CMgr = state->getConstraintManager();
1169e5dd7070Spatrick
1170e5dd7070Spatrick for (auto &I : B) {
1171e5dd7070Spatrick // Check if the symbol is null stop tracking the symbol.
1172e5dd7070Spatrick ConditionTruthVal AllocFailed = CMgr.isNull(state, I.first);
1173e5dd7070Spatrick if (AllocFailed.isConstrainedTrue()) {
1174e5dd7070Spatrick changed = true;
1175e5dd7070Spatrick B = RefBFactory.remove(B, I.first);
1176e5dd7070Spatrick }
1177e5dd7070Spatrick }
1178e5dd7070Spatrick
1179e5dd7070Spatrick if (changed)
1180e5dd7070Spatrick state = state->set<RefBindings>(B);
1181e5dd7070Spatrick
1182e5dd7070Spatrick return state;
1183e5dd7070Spatrick }
1184e5dd7070Spatrick
checkRegionChanges(ProgramStateRef state,const InvalidatedSymbols * invalidated,ArrayRef<const MemRegion * > ExplicitRegions,ArrayRef<const MemRegion * > Regions,const LocationContext * LCtx,const CallEvent * Call) const1185e5dd7070Spatrick ProgramStateRef RetainCountChecker::checkRegionChanges(
1186e5dd7070Spatrick ProgramStateRef state, const InvalidatedSymbols *invalidated,
1187e5dd7070Spatrick ArrayRef<const MemRegion *> ExplicitRegions,
1188e5dd7070Spatrick ArrayRef<const MemRegion *> Regions, const LocationContext *LCtx,
1189e5dd7070Spatrick const CallEvent *Call) const {
1190e5dd7070Spatrick if (!invalidated)
1191e5dd7070Spatrick return state;
1192e5dd7070Spatrick
1193*12c85518Srobert llvm::SmallPtrSet<SymbolRef, 8> AllowedSymbols;
1194e5dd7070Spatrick
1195e5dd7070Spatrick for (const MemRegion *I : ExplicitRegions)
1196e5dd7070Spatrick if (const SymbolicRegion *SR = I->StripCasts()->getAs<SymbolicRegion>())
1197*12c85518Srobert AllowedSymbols.insert(SR->getSymbol());
1198e5dd7070Spatrick
1199e5dd7070Spatrick for (SymbolRef sym : *invalidated) {
1200*12c85518Srobert if (AllowedSymbols.count(sym))
1201e5dd7070Spatrick continue;
1202e5dd7070Spatrick // Remove any existing reference-count binding.
1203e5dd7070Spatrick state = removeRefBinding(state, sym);
1204e5dd7070Spatrick }
1205e5dd7070Spatrick return state;
1206e5dd7070Spatrick }
1207e5dd7070Spatrick
1208e5dd7070Spatrick ProgramStateRef
handleAutoreleaseCounts(ProgramStateRef state,ExplodedNode * Pred,const ProgramPointTag * Tag,CheckerContext & Ctx,SymbolRef Sym,RefVal V,const ReturnStmt * S) const1209e5dd7070Spatrick RetainCountChecker::handleAutoreleaseCounts(ProgramStateRef state,
1210e5dd7070Spatrick ExplodedNode *Pred,
1211e5dd7070Spatrick const ProgramPointTag *Tag,
1212e5dd7070Spatrick CheckerContext &Ctx,
1213e5dd7070Spatrick SymbolRef Sym,
1214e5dd7070Spatrick RefVal V,
1215e5dd7070Spatrick const ReturnStmt *S) const {
1216e5dd7070Spatrick unsigned ACnt = V.getAutoreleaseCount();
1217e5dd7070Spatrick
1218e5dd7070Spatrick // No autorelease counts? Nothing to be done.
1219e5dd7070Spatrick if (!ACnt)
1220e5dd7070Spatrick return state;
1221e5dd7070Spatrick
1222e5dd7070Spatrick unsigned Cnt = V.getCount();
1223e5dd7070Spatrick
1224e5dd7070Spatrick // FIXME: Handle sending 'autorelease' to already released object.
1225e5dd7070Spatrick
1226e5dd7070Spatrick if (V.getKind() == RefVal::ReturnedOwned)
1227e5dd7070Spatrick ++Cnt;
1228e5dd7070Spatrick
1229e5dd7070Spatrick // If we would over-release here, but we know the value came from an ivar,
1230e5dd7070Spatrick // assume it was a strong ivar that's just been relinquished.
1231e5dd7070Spatrick if (ACnt > Cnt &&
1232e5dd7070Spatrick V.getIvarAccessHistory() == RefVal::IvarAccessHistory::AccessedDirectly) {
1233e5dd7070Spatrick V = V.releaseViaIvar();
1234e5dd7070Spatrick --ACnt;
1235e5dd7070Spatrick }
1236e5dd7070Spatrick
1237e5dd7070Spatrick if (ACnt <= Cnt) {
1238e5dd7070Spatrick if (ACnt == Cnt) {
1239e5dd7070Spatrick V.clearCounts();
1240e5dd7070Spatrick if (V.getKind() == RefVal::ReturnedOwned) {
1241e5dd7070Spatrick V = V ^ RefVal::ReturnedNotOwned;
1242e5dd7070Spatrick } else {
1243e5dd7070Spatrick V = V ^ RefVal::NotOwned;
1244e5dd7070Spatrick }
1245e5dd7070Spatrick } else {
1246e5dd7070Spatrick V.setCount(V.getCount() - ACnt);
1247e5dd7070Spatrick V.setAutoreleaseCount(0);
1248e5dd7070Spatrick }
1249e5dd7070Spatrick return setRefBinding(state, Sym, V);
1250e5dd7070Spatrick }
1251e5dd7070Spatrick
1252e5dd7070Spatrick // HACK: Ignore retain-count issues on values accessed through ivars,
1253e5dd7070Spatrick // because of cases like this:
1254e5dd7070Spatrick // [_contentView retain];
1255e5dd7070Spatrick // [_contentView removeFromSuperview];
1256e5dd7070Spatrick // [self addSubview:_contentView]; // invalidates 'self'
1257e5dd7070Spatrick // [_contentView release];
1258e5dd7070Spatrick if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1259e5dd7070Spatrick return state;
1260e5dd7070Spatrick
1261e5dd7070Spatrick // Woah! More autorelease counts then retain counts left.
1262e5dd7070Spatrick // Emit hard error.
1263e5dd7070Spatrick V = V ^ RefVal::ErrorOverAutorelease;
1264e5dd7070Spatrick state = setRefBinding(state, Sym, V);
1265e5dd7070Spatrick
1266e5dd7070Spatrick ExplodedNode *N = Ctx.generateSink(state, Pred, Tag);
1267e5dd7070Spatrick if (N) {
1268e5dd7070Spatrick SmallString<128> sbuf;
1269e5dd7070Spatrick llvm::raw_svector_ostream os(sbuf);
1270e5dd7070Spatrick os << "Object was autoreleased ";
1271e5dd7070Spatrick if (V.getAutoreleaseCount() > 1)
1272e5dd7070Spatrick os << V.getAutoreleaseCount() << " times but the object ";
1273e5dd7070Spatrick else
1274e5dd7070Spatrick os << "but ";
1275e5dd7070Spatrick os << "has a +" << V.getCount() << " retain count";
1276e5dd7070Spatrick
1277e5dd7070Spatrick const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
1278ec727ea7Spatrick auto R = std::make_unique<RefCountReport>(*OverAutorelease, LOpts, N, Sym,
1279e5dd7070Spatrick os.str());
1280e5dd7070Spatrick Ctx.emitReport(std::move(R));
1281e5dd7070Spatrick }
1282e5dd7070Spatrick
1283e5dd7070Spatrick return nullptr;
1284e5dd7070Spatrick }
1285e5dd7070Spatrick
1286e5dd7070Spatrick ProgramStateRef
handleSymbolDeath(ProgramStateRef state,SymbolRef sid,RefVal V,SmallVectorImpl<SymbolRef> & Leaked) const1287e5dd7070Spatrick RetainCountChecker::handleSymbolDeath(ProgramStateRef state,
1288e5dd7070Spatrick SymbolRef sid, RefVal V,
1289e5dd7070Spatrick SmallVectorImpl<SymbolRef> &Leaked) const {
1290e5dd7070Spatrick bool hasLeak;
1291e5dd7070Spatrick
1292e5dd7070Spatrick // HACK: Ignore retain-count issues on values accessed through ivars,
1293e5dd7070Spatrick // because of cases like this:
1294e5dd7070Spatrick // [_contentView retain];
1295e5dd7070Spatrick // [_contentView removeFromSuperview];
1296e5dd7070Spatrick // [self addSubview:_contentView]; // invalidates 'self'
1297e5dd7070Spatrick // [_contentView release];
1298e5dd7070Spatrick if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
1299e5dd7070Spatrick hasLeak = false;
1300e5dd7070Spatrick else if (V.isOwned())
1301e5dd7070Spatrick hasLeak = true;
1302e5dd7070Spatrick else if (V.isNotOwned() || V.isReturnedOwned())
1303e5dd7070Spatrick hasLeak = (V.getCount() > 0);
1304e5dd7070Spatrick else
1305e5dd7070Spatrick hasLeak = false;
1306e5dd7070Spatrick
1307e5dd7070Spatrick if (!hasLeak)
1308e5dd7070Spatrick return removeRefBinding(state, sid);
1309e5dd7070Spatrick
1310e5dd7070Spatrick Leaked.push_back(sid);
1311e5dd7070Spatrick return setRefBinding(state, sid, V ^ RefVal::ErrorLeak);
1312e5dd7070Spatrick }
1313e5dd7070Spatrick
1314e5dd7070Spatrick ExplodedNode *
processLeaks(ProgramStateRef state,SmallVectorImpl<SymbolRef> & Leaked,CheckerContext & Ctx,ExplodedNode * Pred) const1315e5dd7070Spatrick RetainCountChecker::processLeaks(ProgramStateRef state,
1316e5dd7070Spatrick SmallVectorImpl<SymbolRef> &Leaked,
1317e5dd7070Spatrick CheckerContext &Ctx,
1318e5dd7070Spatrick ExplodedNode *Pred) const {
1319e5dd7070Spatrick // Generate an intermediate node representing the leak point.
1320e5dd7070Spatrick ExplodedNode *N = Ctx.addTransition(state, Pred);
1321e5dd7070Spatrick const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
1322e5dd7070Spatrick
1323e5dd7070Spatrick if (N) {
1324e5dd7070Spatrick for (SymbolRef L : Leaked) {
1325ec727ea7Spatrick const RefCountBug &BT = Pred ? *LeakWithinFunction : *LeakAtReturn;
1326e5dd7070Spatrick Ctx.emitReport(std::make_unique<RefLeakReport>(BT, LOpts, N, L, Ctx));
1327e5dd7070Spatrick }
1328e5dd7070Spatrick }
1329e5dd7070Spatrick
1330e5dd7070Spatrick return N;
1331e5dd7070Spatrick }
1332e5dd7070Spatrick
checkBeginFunction(CheckerContext & Ctx) const1333e5dd7070Spatrick void RetainCountChecker::checkBeginFunction(CheckerContext &Ctx) const {
1334e5dd7070Spatrick if (!Ctx.inTopFrame())
1335e5dd7070Spatrick return;
1336e5dd7070Spatrick
1337e5dd7070Spatrick RetainSummaryManager &SmrMgr = getSummaryManager(Ctx);
1338e5dd7070Spatrick const LocationContext *LCtx = Ctx.getLocationContext();
1339e5dd7070Spatrick const Decl *D = LCtx->getDecl();
1340*12c85518Srobert std::optional<AnyCall> C = AnyCall::forDecl(D);
1341e5dd7070Spatrick
1342e5dd7070Spatrick if (!C || SmrMgr.isTrustedReferenceCountImplementation(D))
1343e5dd7070Spatrick return;
1344e5dd7070Spatrick
1345e5dd7070Spatrick ProgramStateRef state = Ctx.getState();
1346e5dd7070Spatrick const RetainSummary *FunctionSummary = SmrMgr.getSummary(*C);
1347e5dd7070Spatrick ArgEffects CalleeSideArgEffects = FunctionSummary->getArgEffects();
1348e5dd7070Spatrick
1349e5dd7070Spatrick for (unsigned idx = 0, e = C->param_size(); idx != e; ++idx) {
1350e5dd7070Spatrick const ParmVarDecl *Param = C->parameters()[idx];
1351e5dd7070Spatrick SymbolRef Sym = state->getSVal(state->getRegion(Param, LCtx)).getAsSymbol();
1352e5dd7070Spatrick
1353e5dd7070Spatrick QualType Ty = Param->getType();
1354e5dd7070Spatrick const ArgEffect *AE = CalleeSideArgEffects.lookup(idx);
1355e5dd7070Spatrick if (AE) {
1356e5dd7070Spatrick ObjKind K = AE->getObjKind();
1357e5dd7070Spatrick if (K == ObjKind::Generalized || K == ObjKind::OS ||
1358e5dd7070Spatrick (TrackNSCFStartParam && (K == ObjKind::ObjC || K == ObjKind::CF))) {
1359e5dd7070Spatrick RefVal NewVal = AE->getKind() == DecRef ? RefVal::makeOwned(K, Ty)
1360e5dd7070Spatrick : RefVal::makeNotOwned(K, Ty);
1361e5dd7070Spatrick state = setRefBinding(state, Sym, NewVal);
1362e5dd7070Spatrick }
1363e5dd7070Spatrick }
1364e5dd7070Spatrick }
1365e5dd7070Spatrick
1366e5dd7070Spatrick Ctx.addTransition(state);
1367e5dd7070Spatrick }
1368e5dd7070Spatrick
checkEndFunction(const ReturnStmt * RS,CheckerContext & Ctx) const1369e5dd7070Spatrick void RetainCountChecker::checkEndFunction(const ReturnStmt *RS,
1370e5dd7070Spatrick CheckerContext &Ctx) const {
1371e5dd7070Spatrick ExplodedNode *Pred = processReturn(RS, Ctx);
1372e5dd7070Spatrick
1373e5dd7070Spatrick // Created state cached out.
1374e5dd7070Spatrick if (!Pred) {
1375e5dd7070Spatrick return;
1376e5dd7070Spatrick }
1377e5dd7070Spatrick
1378e5dd7070Spatrick ProgramStateRef state = Pred->getState();
1379e5dd7070Spatrick RefBindingsTy B = state->get<RefBindings>();
1380e5dd7070Spatrick
1381e5dd7070Spatrick // Don't process anything within synthesized bodies.
1382e5dd7070Spatrick const LocationContext *LCtx = Pred->getLocationContext();
1383e5dd7070Spatrick if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) {
1384e5dd7070Spatrick assert(!LCtx->inTopFrame());
1385e5dd7070Spatrick return;
1386e5dd7070Spatrick }
1387e5dd7070Spatrick
1388e5dd7070Spatrick for (auto &I : B) {
1389e5dd7070Spatrick state = handleAutoreleaseCounts(state, Pred, /*Tag=*/nullptr, Ctx,
1390e5dd7070Spatrick I.first, I.second);
1391e5dd7070Spatrick if (!state)
1392e5dd7070Spatrick return;
1393e5dd7070Spatrick }
1394e5dd7070Spatrick
1395e5dd7070Spatrick // If the current LocationContext has a parent, don't check for leaks.
1396e5dd7070Spatrick // We will do that later.
1397e5dd7070Spatrick // FIXME: we should instead check for imbalances of the retain/releases,
1398e5dd7070Spatrick // and suggest annotations.
1399e5dd7070Spatrick if (LCtx->getParent())
1400e5dd7070Spatrick return;
1401e5dd7070Spatrick
1402e5dd7070Spatrick B = state->get<RefBindings>();
1403e5dd7070Spatrick SmallVector<SymbolRef, 10> Leaked;
1404e5dd7070Spatrick
1405e5dd7070Spatrick for (auto &I : B)
1406e5dd7070Spatrick state = handleSymbolDeath(state, I.first, I.second, Leaked);
1407e5dd7070Spatrick
1408e5dd7070Spatrick processLeaks(state, Leaked, Ctx, Pred);
1409e5dd7070Spatrick }
1410e5dd7070Spatrick
checkDeadSymbols(SymbolReaper & SymReaper,CheckerContext & C) const1411e5dd7070Spatrick void RetainCountChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1412e5dd7070Spatrick CheckerContext &C) const {
1413e5dd7070Spatrick ExplodedNode *Pred = C.getPredecessor();
1414e5dd7070Spatrick
1415e5dd7070Spatrick ProgramStateRef state = C.getState();
1416e5dd7070Spatrick SmallVector<SymbolRef, 10> Leaked;
1417e5dd7070Spatrick
1418e5dd7070Spatrick // Update counts from autorelease pools
1419e5dd7070Spatrick for (const auto &I: state->get<RefBindings>()) {
1420e5dd7070Spatrick SymbolRef Sym = I.first;
1421e5dd7070Spatrick if (SymReaper.isDead(Sym)) {
1422e5dd7070Spatrick static CheckerProgramPointTag Tag(this, "DeadSymbolAutorelease");
1423e5dd7070Spatrick const RefVal &V = I.second;
1424e5dd7070Spatrick state = handleAutoreleaseCounts(state, Pred, &Tag, C, Sym, V);
1425e5dd7070Spatrick if (!state)
1426e5dd7070Spatrick return;
1427e5dd7070Spatrick
1428e5dd7070Spatrick // Fetch the new reference count from the state, and use it to handle
1429e5dd7070Spatrick // this symbol.
1430e5dd7070Spatrick state = handleSymbolDeath(state, Sym, *getRefBinding(state, Sym), Leaked);
1431e5dd7070Spatrick }
1432e5dd7070Spatrick }
1433e5dd7070Spatrick
1434e5dd7070Spatrick if (Leaked.empty()) {
1435e5dd7070Spatrick C.addTransition(state);
1436e5dd7070Spatrick return;
1437e5dd7070Spatrick }
1438e5dd7070Spatrick
1439e5dd7070Spatrick Pred = processLeaks(state, Leaked, C, Pred);
1440e5dd7070Spatrick
1441e5dd7070Spatrick // Did we cache out?
1442e5dd7070Spatrick if (!Pred)
1443e5dd7070Spatrick return;
1444e5dd7070Spatrick
1445e5dd7070Spatrick // Now generate a new node that nukes the old bindings.
1446e5dd7070Spatrick // The only bindings left at this point are the leaked symbols.
1447e5dd7070Spatrick RefBindingsTy::Factory &F = state->get_context<RefBindings>();
1448e5dd7070Spatrick RefBindingsTy B = state->get<RefBindings>();
1449e5dd7070Spatrick
1450e5dd7070Spatrick for (SymbolRef L : Leaked)
1451e5dd7070Spatrick B = F.remove(B, L);
1452e5dd7070Spatrick
1453e5dd7070Spatrick state = state->set<RefBindings>(B);
1454e5dd7070Spatrick C.addTransition(state, Pred);
1455e5dd7070Spatrick }
1456e5dd7070Spatrick
printState(raw_ostream & Out,ProgramStateRef State,const char * NL,const char * Sep) const1457e5dd7070Spatrick void RetainCountChecker::printState(raw_ostream &Out, ProgramStateRef State,
1458e5dd7070Spatrick const char *NL, const char *Sep) const {
1459e5dd7070Spatrick
1460e5dd7070Spatrick RefBindingsTy B = State->get<RefBindings>();
1461e5dd7070Spatrick
1462e5dd7070Spatrick if (B.isEmpty())
1463e5dd7070Spatrick return;
1464e5dd7070Spatrick
1465e5dd7070Spatrick Out << Sep << NL;
1466e5dd7070Spatrick
1467e5dd7070Spatrick for (auto &I : B) {
1468e5dd7070Spatrick Out << I.first << " : ";
1469e5dd7070Spatrick I.second.print(Out);
1470e5dd7070Spatrick Out << NL;
1471e5dd7070Spatrick }
1472e5dd7070Spatrick }
1473e5dd7070Spatrick
1474e5dd7070Spatrick //===----------------------------------------------------------------------===//
1475e5dd7070Spatrick // Checker registration.
1476e5dd7070Spatrick //===----------------------------------------------------------------------===//
1477e5dd7070Spatrick
1478ec727ea7Spatrick std::unique_ptr<CheckerProgramPointTag> RetainCountChecker::DeallocSentTag;
1479ec727ea7Spatrick std::unique_ptr<CheckerProgramPointTag> RetainCountChecker::CastFailTag;
1480ec727ea7Spatrick
registerRetainCountBase(CheckerManager & Mgr)1481e5dd7070Spatrick void ento::registerRetainCountBase(CheckerManager &Mgr) {
1482ec727ea7Spatrick auto *Chk = Mgr.registerChecker<RetainCountChecker>();
1483ec727ea7Spatrick Chk->DeallocSentTag =
1484ec727ea7Spatrick std::make_unique<CheckerProgramPointTag>(Chk, "DeallocSent");
1485ec727ea7Spatrick Chk->CastFailTag =
1486ec727ea7Spatrick std::make_unique<CheckerProgramPointTag>(Chk, "DynamicCastFail");
1487e5dd7070Spatrick }
1488e5dd7070Spatrick
shouldRegisterRetainCountBase(const CheckerManager & mgr)1489ec727ea7Spatrick bool ento::shouldRegisterRetainCountBase(const CheckerManager &mgr) {
1490e5dd7070Spatrick return true;
1491e5dd7070Spatrick }
registerRetainCountChecker(CheckerManager & Mgr)1492e5dd7070Spatrick void ento::registerRetainCountChecker(CheckerManager &Mgr) {
1493e5dd7070Spatrick auto *Chk = Mgr.getChecker<RetainCountChecker>();
1494e5dd7070Spatrick Chk->TrackObjCAndCFObjects = true;
1495ec727ea7Spatrick Chk->TrackNSCFStartParam = Mgr.getAnalyzerOptions().getCheckerBooleanOption(
1496ec727ea7Spatrick Mgr.getCurrentCheckerName(), "TrackNSCFStartParam");
1497ec727ea7Spatrick
1498ec727ea7Spatrick #define INIT_BUGTYPE(KIND) \
1499ec727ea7Spatrick Chk->KIND = std::make_unique<RefCountBug>(Mgr.getCurrentCheckerName(), \
1500ec727ea7Spatrick RefCountBug::KIND);
1501ec727ea7Spatrick // TODO: Ideally, we should have a checker for each of these bug types.
1502ec727ea7Spatrick INIT_BUGTYPE(UseAfterRelease)
1503ec727ea7Spatrick INIT_BUGTYPE(ReleaseNotOwned)
1504ec727ea7Spatrick INIT_BUGTYPE(DeallocNotOwned)
1505ec727ea7Spatrick INIT_BUGTYPE(FreeNotOwned)
1506ec727ea7Spatrick INIT_BUGTYPE(OverAutorelease)
1507ec727ea7Spatrick INIT_BUGTYPE(ReturnNotOwnedForOwned)
1508ec727ea7Spatrick INIT_BUGTYPE(LeakWithinFunction)
1509ec727ea7Spatrick INIT_BUGTYPE(LeakAtReturn)
1510ec727ea7Spatrick #undef INIT_BUGTYPE
1511e5dd7070Spatrick }
1512e5dd7070Spatrick
shouldRegisterRetainCountChecker(const CheckerManager & mgr)1513ec727ea7Spatrick bool ento::shouldRegisterRetainCountChecker(const CheckerManager &mgr) {
1514e5dd7070Spatrick return true;
1515e5dd7070Spatrick }
1516e5dd7070Spatrick
registerOSObjectRetainCountChecker(CheckerManager & Mgr)1517e5dd7070Spatrick void ento::registerOSObjectRetainCountChecker(CheckerManager &Mgr) {
1518e5dd7070Spatrick auto *Chk = Mgr.getChecker<RetainCountChecker>();
1519e5dd7070Spatrick Chk->TrackOSObjects = true;
1520ec727ea7Spatrick
1521ec727ea7Spatrick // FIXME: We want bug reports to always have the same checker name associated
1522ec727ea7Spatrick // with them, yet here, if RetainCountChecker is disabled but
1523ec727ea7Spatrick // OSObjectRetainCountChecker is enabled, the checker names will be different.
1524ec727ea7Spatrick // This hack will make it so that the checker name depends on which checker is
1525ec727ea7Spatrick // enabled rather than on the registration order.
1526ec727ea7Spatrick // For the most part, we want **non-hidden checkers** to be associated with
1527ec727ea7Spatrick // diagnostics, and **hidden checker options** with the fine-tuning of
1528ec727ea7Spatrick // modeling. Following this logic, OSObjectRetainCountChecker should be the
1529ec727ea7Spatrick // latter, but we can't just remove it for backward compatibility reasons.
1530ec727ea7Spatrick #define LAZY_INIT_BUGTYPE(KIND) \
1531ec727ea7Spatrick if (!Chk->KIND) \
1532ec727ea7Spatrick Chk->KIND = std::make_unique<RefCountBug>(Mgr.getCurrentCheckerName(), \
1533ec727ea7Spatrick RefCountBug::KIND);
1534ec727ea7Spatrick LAZY_INIT_BUGTYPE(UseAfterRelease)
1535ec727ea7Spatrick LAZY_INIT_BUGTYPE(ReleaseNotOwned)
1536ec727ea7Spatrick LAZY_INIT_BUGTYPE(DeallocNotOwned)
1537ec727ea7Spatrick LAZY_INIT_BUGTYPE(FreeNotOwned)
1538ec727ea7Spatrick LAZY_INIT_BUGTYPE(OverAutorelease)
1539ec727ea7Spatrick LAZY_INIT_BUGTYPE(ReturnNotOwnedForOwned)
1540ec727ea7Spatrick LAZY_INIT_BUGTYPE(LeakWithinFunction)
1541ec727ea7Spatrick LAZY_INIT_BUGTYPE(LeakAtReturn)
1542ec727ea7Spatrick #undef LAZY_INIT_BUGTYPE
1543e5dd7070Spatrick }
1544e5dd7070Spatrick
shouldRegisterOSObjectRetainCountChecker(const CheckerManager & mgr)1545ec727ea7Spatrick bool ento::shouldRegisterOSObjectRetainCountChecker(const CheckerManager &mgr) {
1546e5dd7070Spatrick return true;
1547e5dd7070Spatrick }
1548