1e5dd7070Spatrick //=== CastSizeChecker.cpp ---------------------------------------*- C++ -*-===//
2e5dd7070Spatrick //
3e5dd7070Spatrick // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4e5dd7070Spatrick // See https://llvm.org/LICENSE.txt for license information.
5e5dd7070Spatrick // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6e5dd7070Spatrick //
7e5dd7070Spatrick //===----------------------------------------------------------------------===//
8e5dd7070Spatrick //
9e5dd7070Spatrick // CastSizeChecker checks when casting a malloc'ed symbolic region to type T,
10e5dd7070Spatrick // whether the size of the symbolic region is a multiple of the size of T.
11e5dd7070Spatrick //
12e5dd7070Spatrick //===----------------------------------------------------------------------===//
13ec727ea7Spatrick
14e5dd7070Spatrick #include "clang/AST/CharUnits.h"
15ec727ea7Spatrick #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
16e5dd7070Spatrick #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
17e5dd7070Spatrick #include "clang/StaticAnalyzer/Core/Checker.h"
18e5dd7070Spatrick #include "clang/StaticAnalyzer/Core/CheckerManager.h"
19e5dd7070Spatrick #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
20*a9ac8606Spatrick #include "clang/StaticAnalyzer/Core/PathSensitive/DynamicExtent.h"
21e5dd7070Spatrick
22e5dd7070Spatrick using namespace clang;
23e5dd7070Spatrick using namespace ento;
24e5dd7070Spatrick
25e5dd7070Spatrick namespace {
26e5dd7070Spatrick class CastSizeChecker : public Checker< check::PreStmt<CastExpr> > {
27e5dd7070Spatrick mutable std::unique_ptr<BuiltinBug> BT;
28e5dd7070Spatrick
29e5dd7070Spatrick public:
30e5dd7070Spatrick void checkPreStmt(const CastExpr *CE, CheckerContext &C) const;
31e5dd7070Spatrick };
32e5dd7070Spatrick }
33e5dd7070Spatrick
34e5dd7070Spatrick /// Check if we are casting to a struct with a flexible array at the end.
35e5dd7070Spatrick /// \code
36e5dd7070Spatrick /// struct foo {
37e5dd7070Spatrick /// size_t len;
38e5dd7070Spatrick /// struct bar data[];
39e5dd7070Spatrick /// };
40e5dd7070Spatrick /// \endcode
41e5dd7070Spatrick /// or
42e5dd7070Spatrick /// \code
43e5dd7070Spatrick /// struct foo {
44e5dd7070Spatrick /// size_t len;
45e5dd7070Spatrick /// struct bar data[0];
46e5dd7070Spatrick /// }
47e5dd7070Spatrick /// \endcode
48e5dd7070Spatrick /// In these cases it is also valid to allocate size of struct foo + a multiple
49e5dd7070Spatrick /// of struct bar.
evenFlexibleArraySize(ASTContext & Ctx,CharUnits RegionSize,CharUnits TypeSize,QualType ToPointeeTy)50e5dd7070Spatrick static bool evenFlexibleArraySize(ASTContext &Ctx, CharUnits RegionSize,
51e5dd7070Spatrick CharUnits TypeSize, QualType ToPointeeTy) {
52e5dd7070Spatrick const RecordType *RT = ToPointeeTy->getAs<RecordType>();
53e5dd7070Spatrick if (!RT)
54e5dd7070Spatrick return false;
55e5dd7070Spatrick
56e5dd7070Spatrick const RecordDecl *RD = RT->getDecl();
57e5dd7070Spatrick RecordDecl::field_iterator Iter(RD->field_begin());
58e5dd7070Spatrick RecordDecl::field_iterator End(RD->field_end());
59e5dd7070Spatrick const FieldDecl *Last = nullptr;
60e5dd7070Spatrick for (; Iter != End; ++Iter)
61e5dd7070Spatrick Last = *Iter;
62e5dd7070Spatrick assert(Last && "empty structs should already be handled");
63e5dd7070Spatrick
64e5dd7070Spatrick const Type *ElemType = Last->getType()->getArrayElementTypeNoTypeQual();
65e5dd7070Spatrick CharUnits FlexSize;
66e5dd7070Spatrick if (const ConstantArrayType *ArrayTy =
67e5dd7070Spatrick Ctx.getAsConstantArrayType(Last->getType())) {
68e5dd7070Spatrick FlexSize = Ctx.getTypeSizeInChars(ElemType);
69e5dd7070Spatrick if (ArrayTy->getSize() == 1 && TypeSize > FlexSize)
70e5dd7070Spatrick TypeSize -= FlexSize;
71e5dd7070Spatrick else if (ArrayTy->getSize() != 0)
72e5dd7070Spatrick return false;
73e5dd7070Spatrick } else if (RD->hasFlexibleArrayMember()) {
74e5dd7070Spatrick FlexSize = Ctx.getTypeSizeInChars(ElemType);
75e5dd7070Spatrick } else {
76e5dd7070Spatrick return false;
77e5dd7070Spatrick }
78e5dd7070Spatrick
79e5dd7070Spatrick if (FlexSize.isZero())
80e5dd7070Spatrick return false;
81e5dd7070Spatrick
82e5dd7070Spatrick CharUnits Left = RegionSize - TypeSize;
83e5dd7070Spatrick if (Left.isNegative())
84e5dd7070Spatrick return false;
85e5dd7070Spatrick
86e5dd7070Spatrick return Left % FlexSize == 0;
87e5dd7070Spatrick }
88e5dd7070Spatrick
checkPreStmt(const CastExpr * CE,CheckerContext & C) const89e5dd7070Spatrick void CastSizeChecker::checkPreStmt(const CastExpr *CE,CheckerContext &C) const {
90e5dd7070Spatrick const Expr *E = CE->getSubExpr();
91e5dd7070Spatrick ASTContext &Ctx = C.getASTContext();
92e5dd7070Spatrick QualType ToTy = Ctx.getCanonicalType(CE->getType());
93e5dd7070Spatrick const PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr());
94e5dd7070Spatrick
95e5dd7070Spatrick if (!ToPTy)
96e5dd7070Spatrick return;
97e5dd7070Spatrick
98e5dd7070Spatrick QualType ToPointeeTy = ToPTy->getPointeeType();
99e5dd7070Spatrick
100e5dd7070Spatrick // Only perform the check if 'ToPointeeTy' is a complete type.
101e5dd7070Spatrick if (ToPointeeTy->isIncompleteType())
102e5dd7070Spatrick return;
103e5dd7070Spatrick
104e5dd7070Spatrick ProgramStateRef state = C.getState();
105e5dd7070Spatrick const MemRegion *R = C.getSVal(E).getAsRegion();
106e5dd7070Spatrick if (!R)
107e5dd7070Spatrick return;
108e5dd7070Spatrick
109e5dd7070Spatrick const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
110e5dd7070Spatrick if (!SR)
111e5dd7070Spatrick return;
112e5dd7070Spatrick
113e5dd7070Spatrick SValBuilder &svalBuilder = C.getSValBuilder();
114ec727ea7Spatrick
115*a9ac8606Spatrick DefinedOrUnknownSVal Size = getDynamicExtent(state, SR, svalBuilder);
116ec727ea7Spatrick const llvm::APSInt *SizeInt = svalBuilder.getKnownValue(state, Size);
117ec727ea7Spatrick if (!SizeInt)
118e5dd7070Spatrick return;
119e5dd7070Spatrick
120ec727ea7Spatrick CharUnits regionSize = CharUnits::fromQuantity(SizeInt->getZExtValue());
121e5dd7070Spatrick CharUnits typeSize = C.getASTContext().getTypeSizeInChars(ToPointeeTy);
122e5dd7070Spatrick
123e5dd7070Spatrick // Ignore void, and a few other un-sizeable types.
124e5dd7070Spatrick if (typeSize.isZero())
125e5dd7070Spatrick return;
126e5dd7070Spatrick
127e5dd7070Spatrick if (regionSize % typeSize == 0)
128e5dd7070Spatrick return;
129e5dd7070Spatrick
130e5dd7070Spatrick if (evenFlexibleArraySize(Ctx, regionSize, typeSize, ToPointeeTy))
131e5dd7070Spatrick return;
132e5dd7070Spatrick
133e5dd7070Spatrick if (ExplodedNode *errorNode = C.generateErrorNode()) {
134e5dd7070Spatrick if (!BT)
135e5dd7070Spatrick BT.reset(new BuiltinBug(this, "Cast region with wrong size.",
136e5dd7070Spatrick "Cast a region whose size is not a multiple"
137e5dd7070Spatrick " of the destination type size."));
138e5dd7070Spatrick auto R = std::make_unique<PathSensitiveBugReport>(*BT, BT->getDescription(),
139e5dd7070Spatrick errorNode);
140e5dd7070Spatrick R->addRange(CE->getSourceRange());
141e5dd7070Spatrick C.emitReport(std::move(R));
142e5dd7070Spatrick }
143e5dd7070Spatrick }
144e5dd7070Spatrick
registerCastSizeChecker(CheckerManager & mgr)145e5dd7070Spatrick void ento::registerCastSizeChecker(CheckerManager &mgr) {
146e5dd7070Spatrick mgr.registerChecker<CastSizeChecker>();
147e5dd7070Spatrick }
148e5dd7070Spatrick
shouldRegisterCastSizeChecker(const CheckerManager & mgr)149ec727ea7Spatrick bool ento::shouldRegisterCastSizeChecker(const CheckerManager &mgr) {
150e5dd7070Spatrick // PR31226: C++ is more complicated than what this checker currently supports.
151e5dd7070Spatrick // There are derived-to-base casts, there are different rules for 0-size
152e5dd7070Spatrick // structures, no flexible arrays, etc.
153e5dd7070Spatrick // FIXME: Disabled on C++ for now.
154ec727ea7Spatrick const LangOptions &LO = mgr.getLangOpts();
155e5dd7070Spatrick return !LO.CPlusPlus;
156e5dd7070Spatrick }
157