xref: /netbsd-src/sys/arch/arm/sunxi/sunxi_lcdc.c (revision 181254a7b1bdde6873432bffef2d2decc4b5c22f)
1 /* $NetBSD: sunxi_lcdc.c,v 1.7 2019/11/23 20:28:04 jmcneill Exp $ */
2 
3 /*-
4  * Copyright (c) 2019 Jared D. McNeill <jmcneill@invisible.ca>
5  * All rights reserved.
6  *
7  * Redistribution and use in source and binary forms, with or without
8  * modification, are permitted provided that the following conditions
9  * are met:
10  * 1. Redistributions of source code must retain the above copyright
11  *    notice, this list of conditions and the following disclaimer.
12  * 2. Redistributions in binary form must reproduce the above copyright
13  *    notice, this list of conditions and the following disclaimer in the
14  *    documentation and/or other materials provided with the distribution.
15  *
16  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
17  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
18  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
19  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
20  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
21  * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
22  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
23  * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
24  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
25  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
26  * SUCH DAMAGE.
27  */
28 
29 #include <sys/cdefs.h>
30 __KERNEL_RCSID(0, "$NetBSD: sunxi_lcdc.c,v 1.7 2019/11/23 20:28:04 jmcneill Exp $");
31 
32 #include <sys/param.h>
33 #include <sys/bus.h>
34 #include <sys/device.h>
35 #include <sys/intr.h>
36 #include <sys/systm.h>
37 #include <sys/kernel.h>
38 #include <sys/conf.h>
39 
40 #include <drm/drmP.h>
41 #include <drm/drm_crtc_helper.h>
42 
43 #include <dev/fdt/fdtvar.h>
44 #include <dev/fdt/fdt_port.h>
45 
46 #include <arm/sunxi/sunxi_drm.h>
47 
48 #define	TCON_GCTL_REG		0x000
49 #define	 TCON_GCTL_TCON_EN			__BIT(31)
50 #define	 TCON_GCTL_GAMMA_EN			__BIT(30)
51 #define	 TCON_GCTL_IO_MAP_SEL			__BIT(0)
52 #define	TCON_GINT0_REG		0x004
53 #define	 TCON_GINT0_TCON0_VB_INT_EN		__BIT(31)
54 #define	 TCON_GINT0_TCON1_VB_INT_EN		__BIT(30)
55 #define	 TCON_GINT0_TCON0_VB_INT_FLAG		__BIT(15)
56 #define	 TCON_GINT0_TCON1_VB_INT_FLAG		__BIT(14)
57 #define	TCON_GINT1_REG		0x008
58 #define	 TCON_GINT1_TCON1_LINE_INT_NUM		__BITS(11,0)
59 
60 #define	TCON0_CTL_REG		0x040
61 #define	 TCON0_CTL_TCON0_EN			__BIT(31)
62 #define	 TCON0_CTL_START_DELAY			__BITS(8,4)
63 #define	 TCON0_CTL_TCON0_SRC_SEL		__BITS(2,0)
64 #define	TCON0_DCLK_REG		0x044
65 #define	 TCON0_DCLK_EN				__BITS(31,28)
66 #define	 TCON0_DCLK_DIV				__BITS(6,0)
67 #define	TCON0_BASIC0_REG	0x048
68 #define	TCON0_BASIC1_REG	0x04c
69 #define	TCON0_BASIC2_REG	0x050
70 #define	TCON0_BASIC3_REG	0x054
71 #define	TCON0_IO_POL_REG	0x088
72 #define	 TCON0_IO_POL_IO_OUTPUT_SEL		__BIT(31)
73 #define	 TCON0_IO_POL_DCLK_SEL			__BITS(30,28)
74 #define	 TCON0_IO_POL_IO3_INV			__BIT(27)
75 #define	 TCON0_IO_POL_IO2_INV			__BIT(26)
76 #define	 TCON0_IO_POL_IO1_INV			__BIT(25)
77 #define	 TCON0_IO_POL_IO0_INV			__BIT(24)
78 #define	 TCON0_IO_POL_DATA_INV			__BITS(23,0)
79 #define	TCON0_IO_TRI_REG	0x08c
80 
81 #define	TCON1_CTL_REG		0x090
82 #define	 TCON1_CTL_TCON1_EN			__BIT(31)
83 #define	 TCON1_CTL_START_DELAY			__BITS(8,4)
84 #define	 TCON1_CTL_TCON1_SRC_SEL		__BITS(1,0)
85 #define	TCON1_BASIC0_REG	0x094
86 #define	TCON1_BASIC1_REG	0x098
87 #define	TCON1_BASIC2_REG	0x09c
88 #define	TCON1_BASIC3_REG	0x0a0
89 #define	TCON1_BASIC4_REG	0x0a4
90 #define	TCON1_BASIC5_REG	0x0a8
91 #define	TCON1_IO_POL_REG	0x0f0
92 #define	 TCON1_IO_POL_IO3_INV			__BIT(27)
93 #define	 TCON1_IO_POL_IO2_INV			__BIT(26)
94 #define	 TCON1_IO_POL_IO1_INV			__BIT(25)
95 #define	 TCON1_IO_POL_IO0_INV			__BIT(24)
96 #define	 TCON1_IO_POL_DATA_INV			__BITS(23,0)
97 #define	TCON1_IO_TRI_REG	0x0f4
98 
99 enum {
100 	TCON_PORT_INPUT = 0,
101 	TCON_PORT_OUTPUT = 1,
102 };
103 
104 enum tcon_type {
105 	TYPE_TCON0,
106 	TYPE_TCON1,
107 };
108 
109 static const struct of_compat_data compat_data[] = {
110 	{ "allwinner,sun8i-h3-tcon-tv",		TYPE_TCON1 },
111 	{ "allwinner,sun50i-a64-tcon-lcd",	TYPE_TCON0 },
112 	{ "allwinner,sun50i-a64-tcon-tv",	TYPE_TCON1 },
113 	{ NULL }
114 };
115 
116 struct sunxi_lcdc_softc;
117 
118 struct sunxi_lcdc_encoder {
119 	struct drm_encoder	base;
120 	struct sunxi_lcdc_softc *sc;
121 	struct drm_display_mode	curmode;
122 };
123 
124 struct sunxi_lcdc_softc {
125 	device_t		sc_dev;
126 	bus_space_tag_t		sc_bst;
127 	bus_space_handle_t	sc_bsh;
128 	int			sc_phandle;
129 
130 	enum tcon_type		sc_type;
131 
132 	struct clk		*sc_clk_ch[2];
133 
134 	struct sunxi_lcdc_encoder sc_encoder;
135 	struct drm_connector	sc_connector;
136 
137 	struct fdt_device_ports	sc_ports;
138 
139 	uint32_t		sc_vbl_counter;
140 };
141 
142 #define	to_sunxi_lcdc_encoder(x)	container_of(x, struct sunxi_lcdc_encoder, base)
143 
144 #define	TCON_READ(sc, reg)				\
145 	bus_space_read_4((sc)->sc_bst, (sc)->sc_bsh, (reg))
146 #define	TCON_WRITE(sc, reg, val)			\
147 	bus_space_write_4((sc)->sc_bst, (sc)->sc_bsh, (reg), (val))
148 
149 static void
150 sunxi_lcdc_destroy(struct drm_encoder *encoder)
151 {
152 }
153 
154 static const struct drm_encoder_funcs sunxi_lcdc_funcs = {
155 	.destroy = sunxi_lcdc_destroy,
156 };
157 
158 static void
159 sunxi_lcdc_tcon_dpms(struct drm_encoder *encoder, int mode)
160 {
161 }
162 
163 static bool
164 sunxi_lcdc_tcon_mode_fixup(struct drm_encoder *encoder,
165     const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode)
166 {
167 	return true;
168 }
169 
170 static void
171 sunxi_lcdc_tcon_mode_set(struct drm_encoder *encoder,
172     struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode)
173 {
174 	struct sunxi_lcdc_encoder *lcdc_encoder = to_sunxi_lcdc_encoder(encoder);
175 
176 	lcdc_encoder->curmode = *adjusted_mode;
177 }
178 
179 static void
180 sunxi_lcdc_tcon0_prepare(struct drm_encoder *encoder)
181 {
182 	struct sunxi_lcdc_encoder *lcdc_encoder = to_sunxi_lcdc_encoder(encoder);
183 	struct sunxi_lcdc_softc * const sc = lcdc_encoder->sc;
184 	uint32_t val;
185 
186 	val = TCON_READ(sc, TCON_GCTL_REG);
187 	val |= TCON_GCTL_TCON_EN;
188 	val &= ~TCON_GCTL_IO_MAP_SEL;
189 	TCON_WRITE(sc, TCON_GCTL_REG, val);
190 
191 	TCON_WRITE(sc, TCON0_IO_TRI_REG, 0);
192 }
193 
194 static void
195 sunxi_lcdc_tcon1_prepare(struct drm_encoder *encoder)
196 {
197 	struct sunxi_lcdc_encoder *lcdc_encoder = to_sunxi_lcdc_encoder(encoder);
198 	struct sunxi_lcdc_softc * const sc = lcdc_encoder->sc;
199 	uint32_t val;
200 
201 	val = TCON_READ(sc, TCON_GCTL_REG);
202 	val |= TCON_GCTL_TCON_EN;
203 	TCON_WRITE(sc, TCON_GCTL_REG, val);
204 
205 	TCON_WRITE(sc, TCON1_IO_POL_REG, 0);
206 	TCON_WRITE(sc, TCON1_IO_TRI_REG, 0xffffffff);
207 }
208 
209 static void
210 sunxi_lcdc_tcon0_commit(struct drm_encoder *encoder)
211 {
212 	struct sunxi_lcdc_encoder *lcdc_encoder = to_sunxi_lcdc_encoder(encoder);
213 	struct sunxi_lcdc_softc * const sc = lcdc_encoder->sc;
214 	struct drm_display_mode *mode = &lcdc_encoder->curmode;
215 	uint32_t val;
216 	int error;
217 
218 	const u_int interlace_p = (mode->flags & DRM_MODE_FLAG_INTERLACE) != 0;
219 	const u_int hspw = mode->crtc_hsync_end - mode->crtc_hsync_start;
220 	const u_int hbp = mode->crtc_htotal - mode->crtc_hsync_start;
221 	const u_int vspw = mode->crtc_vsync_end - mode->crtc_vsync_start;
222 	const u_int vbp = mode->crtc_vtotal - mode->crtc_vsync_start;
223 	const u_int vblank_len = (mode->crtc_vtotal - mode->crtc_vdisplay) >> interlace_p;
224 	const u_int start_delay = uimin(vblank_len, 30);
225 
226 	val = TCON0_CTL_TCON0_EN |
227 	      __SHIFTIN(start_delay, TCON0_CTL_START_DELAY);
228 	TCON_WRITE(sc, TCON0_CTL_REG, val);
229 
230 	TCON_WRITE(sc, TCON0_BASIC0_REG, ((mode->crtc_hdisplay - 1) << 16) | (mode->crtc_vdisplay - 1));
231 	TCON_WRITE(sc, TCON0_BASIC1_REG, ((mode->crtc_htotal - 1) << 16) | (hbp - 1));
232 	TCON_WRITE(sc, TCON0_BASIC2_REG, ((mode->crtc_vtotal * 2) << 16) | (vbp - 1));
233 	TCON_WRITE(sc, TCON0_BASIC3_REG, ((hspw - 1) << 16) | (vspw - 1));
234 
235 	val = TCON_READ(sc, TCON0_IO_POL_REG);
236 	val &= ~(TCON0_IO_POL_IO3_INV|TCON0_IO_POL_IO2_INV|
237 		 TCON0_IO_POL_IO1_INV|TCON0_IO_POL_IO0_INV|
238 		 TCON0_IO_POL_DATA_INV);
239 	if ((mode->flags & DRM_MODE_FLAG_PHSYNC) == 0)
240 		val |= TCON0_IO_POL_IO1_INV;
241 	if ((mode->flags & DRM_MODE_FLAG_PVSYNC) == 0)
242 		val |= TCON0_IO_POL_IO0_INV;
243 	TCON_WRITE(sc, TCON0_IO_POL_REG, val);
244 
245 	if (sc->sc_clk_ch[0] != NULL) {
246 		error = clk_set_rate(sc->sc_clk_ch[0], mode->crtc_clock * 1000);
247 		if (error != 0) {
248 			device_printf(sc->sc_dev, "failed to set CH0 PLL rate to %u Hz: %d\n",
249 			    mode->crtc_clock * 1000, error);
250 			return;
251 		}
252 		error = clk_enable(sc->sc_clk_ch[0]);
253 		if (error != 0) {
254 			device_printf(sc->sc_dev, "failed to enable CH0 PLL: %d\n", error);
255 			return;
256 		}
257 	} else {
258 		device_printf(sc->sc_dev, "no CH0 PLL configured\n");
259 	}
260 }
261 
262 static void
263 sunxi_lcdc_tcon1_commit(struct drm_encoder *encoder)
264 {
265 	struct sunxi_lcdc_encoder *lcdc_encoder = to_sunxi_lcdc_encoder(encoder);
266 	struct sunxi_lcdc_softc * const sc = lcdc_encoder->sc;
267 	struct drm_display_mode *mode = &lcdc_encoder->curmode;
268 	uint32_t val;
269 	int error;
270 
271 	const u_int interlace_p = (mode->flags & DRM_MODE_FLAG_INTERLACE) != 0;
272 	const u_int hspw = mode->crtc_hsync_end - mode->crtc_hsync_start;
273 	const u_int hbp = mode->crtc_htotal - mode->crtc_hsync_start;
274 	const u_int vspw = mode->crtc_vsync_end - mode->crtc_vsync_start;
275 	const u_int vbp = mode->crtc_vtotal - mode->crtc_vsync_start;
276 	const u_int vblank_len = ((mode->crtc_vtotal - mode->crtc_vdisplay) >> interlace_p) - 2;
277 	const u_int start_delay = uimin(vblank_len, 30);
278 
279 	val = TCON1_CTL_TCON1_EN |
280 	      __SHIFTIN(start_delay, TCON1_CTL_START_DELAY);
281 	TCON_WRITE(sc, TCON1_CTL_REG, val);
282 
283 	TCON_WRITE(sc, TCON1_BASIC0_REG, ((mode->crtc_hdisplay - 1) << 16) | (mode->crtc_vdisplay - 1));
284 	TCON_WRITE(sc, TCON1_BASIC1_REG, ((mode->crtc_hdisplay - 1) << 16) | (mode->crtc_vdisplay - 1));
285 	TCON_WRITE(sc, TCON1_BASIC2_REG, ((mode->crtc_hdisplay - 1) << 16) | (mode->crtc_vdisplay - 1));
286 	TCON_WRITE(sc, TCON1_BASIC3_REG, ((mode->crtc_htotal - 1) << 16) | (hbp - 1));
287 	TCON_WRITE(sc, TCON1_BASIC4_REG, ((mode->crtc_vtotal * 2) << 16) | (vbp - 1));
288 	TCON_WRITE(sc, TCON1_BASIC5_REG, ((hspw - 1) << 16) | (vspw - 1));
289 
290 	TCON_WRITE(sc, TCON_GINT1_REG,
291 	    __SHIFTIN(start_delay + 2, TCON_GINT1_TCON1_LINE_INT_NUM));
292 
293 	if (sc->sc_clk_ch[1] != NULL) {
294 		error = clk_set_rate(sc->sc_clk_ch[1], mode->crtc_clock * 1000);
295 		if (error != 0) {
296 			device_printf(sc->sc_dev, "failed to set CH1 PLL rate to %u Hz: %d\n",
297 			    mode->crtc_clock * 1000, error);
298 			return;
299 		}
300 		error = clk_enable(sc->sc_clk_ch[1]);
301 		if (error != 0) {
302 			device_printf(sc->sc_dev, "failed to enable CH1 PLL: %d\n", error);
303 			return;
304 		}
305 	} else {
306 		device_printf(sc->sc_dev, "no CH1 PLL configured\n");
307 	}
308 }
309 
310 static const struct drm_encoder_helper_funcs sunxi_lcdc_tcon0_helper_funcs = {
311 	.dpms = sunxi_lcdc_tcon_dpms,
312 	.mode_fixup = sunxi_lcdc_tcon_mode_fixup,
313 	.prepare = sunxi_lcdc_tcon0_prepare,
314 	.commit = sunxi_lcdc_tcon0_commit,
315 	.mode_set = sunxi_lcdc_tcon_mode_set,
316 };
317 
318 static const struct drm_encoder_helper_funcs sunxi_lcdc_tcon1_helper_funcs = {
319 	.dpms = sunxi_lcdc_tcon_dpms,
320 	.mode_fixup = sunxi_lcdc_tcon_mode_fixup,
321 	.prepare = sunxi_lcdc_tcon1_prepare,
322 	.commit = sunxi_lcdc_tcon1_commit,
323 	.mode_set = sunxi_lcdc_tcon_mode_set,
324 };
325 
326 static int
327 sunxi_lcdc_encoder_mode(struct fdt_endpoint *out_ep)
328 {
329 	struct fdt_endpoint *remote_ep = fdt_endpoint_remote(out_ep);
330 
331 	if (remote_ep == NULL)
332 		return DRM_MODE_ENCODER_NONE;
333 
334 	switch (fdt_endpoint_type(remote_ep)) {
335 	case EP_DRM_BRIDGE:
336 		return DRM_MODE_ENCODER_TMDS;
337 	case EP_DRM_PANEL:
338 		return DRM_MODE_ENCODER_LVDS;
339 	default:
340 		return DRM_MODE_ENCODER_NONE;
341 	}
342 }
343 
344 static uint32_t
345 sunxi_lcdc_get_vblank_counter(void *priv)
346 {
347 	struct sunxi_lcdc_softc * const sc = priv;
348 
349 	return sc->sc_vbl_counter;
350 }
351 
352 static void
353 sunxi_lcdc_enable_vblank(void *priv)
354 {
355 	struct sunxi_lcdc_softc * const sc = priv;
356         const int crtc_index = ffs32(sc->sc_encoder.base.possible_crtcs) - 1;
357 
358 	if (crtc_index == 0)
359 		TCON_WRITE(sc, TCON_GINT0_REG, TCON_GINT0_TCON0_VB_INT_EN);
360 	else
361 		TCON_WRITE(sc, TCON_GINT0_REG, TCON_GINT0_TCON1_VB_INT_EN);
362 }
363 
364 static void
365 sunxi_lcdc_disable_vblank(void *priv)
366 {
367 	struct sunxi_lcdc_softc * const sc = priv;
368 
369 	TCON_WRITE(sc, TCON_GINT0_REG, 0);
370 }
371 
372 static void
373 sunxi_lcdc_setup_vblank(struct sunxi_lcdc_softc *sc)
374 {
375         const int crtc_index = ffs32(sc->sc_encoder.base.possible_crtcs) - 1;
376 	struct drm_device *ddev = sc->sc_encoder.base.dev;
377 	struct sunxi_drm_softc *drm_sc;
378 
379 	KASSERT(ddev != NULL);
380 
381 	drm_sc = device_private(ddev->dev);
382 	drm_sc->sc_vbl[crtc_index].priv = sc;
383 	drm_sc->sc_vbl[crtc_index].get_vblank_counter = sunxi_lcdc_get_vblank_counter;
384 	drm_sc->sc_vbl[crtc_index].enable_vblank = sunxi_lcdc_enable_vblank;
385 	drm_sc->sc_vbl[crtc_index].disable_vblank = sunxi_lcdc_disable_vblank;
386 }
387 
388 static int
389 sunxi_lcdc_ep_activate(device_t dev, struct fdt_endpoint *ep, bool activate)
390 {
391 	struct sunxi_lcdc_softc * const sc = device_private(dev);
392 	struct fdt_endpoint *in_ep = fdt_endpoint_remote(ep);
393 	struct fdt_endpoint *out_ep;
394 	struct drm_crtc *crtc;
395 
396 	if (!activate)
397 		return EINVAL;
398 
399 	if (fdt_endpoint_port_index(ep) != TCON_PORT_INPUT)
400 		return EINVAL;
401 
402 	if (fdt_endpoint_type(in_ep) != EP_DRM_CRTC)
403 		return EINVAL;
404 
405 	crtc = fdt_endpoint_get_data(in_ep);
406 
407 	sc->sc_encoder.sc = sc;
408 	sc->sc_encoder.base.possible_crtcs = 1 << drm_crtc_index(crtc);
409 
410 	out_ep = fdt_endpoint_get_from_index(&sc->sc_ports, TCON_PORT_OUTPUT, 0);
411 	if (out_ep != NULL) {
412 		drm_encoder_init(crtc->dev, &sc->sc_encoder.base, &sunxi_lcdc_funcs,
413 		    sunxi_lcdc_encoder_mode(out_ep));
414 		drm_encoder_helper_add(&sc->sc_encoder.base, &sunxi_lcdc_tcon0_helper_funcs);
415 
416 		sunxi_lcdc_setup_vblank(sc);
417 
418 		return fdt_endpoint_activate(out_ep, activate);
419 	}
420 
421 	out_ep = fdt_endpoint_get_from_index(&sc->sc_ports, TCON_PORT_OUTPUT, 1);
422 	if (out_ep != NULL) {
423 		drm_encoder_init(crtc->dev, &sc->sc_encoder.base, &sunxi_lcdc_funcs,
424 		    sunxi_lcdc_encoder_mode(out_ep));
425 		drm_encoder_helper_add(&sc->sc_encoder.base, &sunxi_lcdc_tcon1_helper_funcs);
426 
427 		sunxi_lcdc_setup_vblank(sc);
428 
429 		return fdt_endpoint_activate(out_ep, activate);
430 	}
431 
432 	return ENXIO;
433 }
434 
435 static void *
436 sunxi_lcdc_ep_get_data(device_t dev, struct fdt_endpoint *ep)
437 {
438 	struct sunxi_lcdc_softc * const sc = device_private(dev);
439 
440 	return &sc->sc_encoder;
441 }
442 
443 static int
444 sunxi_lcdc_intr(void *priv)
445 {
446 	struct sunxi_lcdc_softc * const sc = priv;
447 	uint32_t val;
448 	int rv = 0;
449 
450 	const int crtc_index = ffs32(sc->sc_encoder.base.possible_crtcs) - 1;
451 	const uint32_t status_mask = crtc_index == 0 ?
452 	    TCON_GINT0_TCON0_VB_INT_FLAG : TCON_GINT0_TCON1_VB_INT_FLAG;
453 
454 	val = TCON_READ(sc, TCON_GINT0_REG);
455 	if ((val & status_mask) != 0) {
456 		TCON_WRITE(sc, TCON_GINT0_REG, val & ~status_mask);
457 		atomic_inc_32(&sc->sc_vbl_counter);
458 		drm_handle_vblank(sc->sc_encoder.base.dev, crtc_index);
459 		rv = 1;
460 	}
461 
462 	return rv;
463 }
464 
465 static int
466 sunxi_lcdc_match(device_t parent, cfdata_t cf, void *aux)
467 {
468 	struct fdt_attach_args * const faa = aux;
469 
470 	return of_match_compat_data(faa->faa_phandle, compat_data);
471 }
472 
473 static void
474 sunxi_lcdc_attach(device_t parent, device_t self, void *aux)
475 {
476 	struct sunxi_lcdc_softc * const sc = device_private(self);
477 	struct fdt_attach_args * const faa = aux;
478 	const int phandle = faa->faa_phandle;
479 	struct fdtbus_reset *rst;
480 	char intrstr[128];
481 	struct clk *clk;
482 	bus_addr_t addr;
483 	bus_size_t size;
484 	void *ih;
485 
486 	if (fdtbus_get_reg(phandle, 0, &addr, &size) != 0) {
487 		aprint_error(": couldn't get registers\n");
488 		return;
489 	}
490 
491 	if (!fdtbus_intr_str(phandle, 0, intrstr, sizeof(intrstr))) {
492 		aprint_error(": couldn't decode interrupt\n");
493 		return;
494 	}
495 
496 	rst = fdtbus_reset_get(phandle, "lcd");
497 	if (rst == NULL || fdtbus_reset_deassert(rst) != 0) {
498 		aprint_error(": couldn't de-assert reset\n");
499 		return;
500 	}
501 
502 	clk = fdtbus_clock_get(phandle, "ahb");
503 	if (clk == NULL || clk_enable(clk) != 0) {
504 		aprint_error(": couldn't enable bus clock\n");
505 		return;
506 	}
507 
508 	sc->sc_dev = self;
509 	sc->sc_bst = faa->faa_bst;
510 	if (bus_space_map(sc->sc_bst, addr, size, 0, &sc->sc_bsh) != 0) {
511 		aprint_error(": couldn't map registers\n");
512 		return;
513 	}
514 	sc->sc_phandle = faa->faa_phandle;
515 	sc->sc_type = of_search_compatible(phandle, compat_data)->data;
516 	sc->sc_clk_ch[0] = fdtbus_clock_get(phandle, "tcon-ch0");
517 	sc->sc_clk_ch[1] = fdtbus_clock_get(phandle, "tcon-ch1");
518 
519 	aprint_naive("\n");
520 	switch (sc->sc_type) {
521 	case TYPE_TCON0:
522 		aprint_normal(": TCON0\n");
523 		break;
524 	case TYPE_TCON1:
525 		aprint_normal(": TCON1\n");
526 		break;
527 	}
528 
529 	sc->sc_ports.dp_ep_activate = sunxi_lcdc_ep_activate;
530 	sc->sc_ports.dp_ep_get_data = sunxi_lcdc_ep_get_data;
531 	fdt_ports_register(&sc->sc_ports, self, phandle, EP_DRM_ENCODER);
532 
533 	ih = fdtbus_intr_establish(phandle, 0, IPL_VM, FDT_INTR_MPSAFE,
534 	    sunxi_lcdc_intr, sc);
535 	if (ih == NULL) {
536 		aprint_error_dev(self, "couldn't establish interrupt on %s\n",
537 		    intrstr);
538 		return;
539 	}
540 	aprint_normal_dev(self, "interrupting on %s\n", intrstr);
541 }
542 
543 CFATTACH_DECL_NEW(sunxi_lcdc, sizeof(struct sunxi_lcdc_softc),
544 	sunxi_lcdc_match, sunxi_lcdc_attach, NULL, NULL);
545