1 //===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 10 #define DEBUG_TYPE "format-test" 11 12 #include "clang/Format/Format.h" 13 #include "clang/Lex/Lexer.h" 14 #include "llvm/Support/Debug.h" 15 #include "gtest/gtest.h" 16 17 namespace clang { 18 namespace format { 19 20 class FormatTest : public ::testing::Test { 21 protected: 22 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length, 23 const FormatStyle &Style) { 24 DEBUG(llvm::errs() << "---\n"); 25 DEBUG(llvm::errs() << Code << "\n\n"); 26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); 27 tooling::Replacements Replaces = reformat(Style, Code, Ranges); 28 ReplacementCount = Replaces.size(); 29 std::string Result = applyAllReplacements(Code, Replaces); 30 EXPECT_NE("", Result); 31 DEBUG(llvm::errs() << "\n" << Result << "\n\n"); 32 return Result; 33 } 34 35 std::string 36 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) { 37 return format(Code, 0, Code.size(), Style); 38 } 39 40 std::string messUp(llvm::StringRef Code) { 41 std::string MessedUp(Code.str()); 42 bool InComment = false; 43 bool InPreprocessorDirective = false; 44 bool JustReplacedNewline = false; 45 for (unsigned i = 0, e = MessedUp.size() - 1; i != e; ++i) { 46 if (MessedUp[i] == '/' && MessedUp[i + 1] == '/') { 47 if (JustReplacedNewline) 48 MessedUp[i - 1] = '\n'; 49 InComment = true; 50 } else if (MessedUp[i] == '#' && (JustReplacedNewline || i == 0)) { 51 if (i != 0) 52 MessedUp[i - 1] = '\n'; 53 InPreprocessorDirective = true; 54 } else if (MessedUp[i] == '\\' && MessedUp[i + 1] == '\n') { 55 MessedUp[i] = ' '; 56 MessedUp[i + 1] = ' '; 57 } else if (MessedUp[i] == '\n') { 58 if (InComment) { 59 InComment = false; 60 } else if (InPreprocessorDirective) { 61 InPreprocessorDirective = false; 62 } else { 63 JustReplacedNewline = true; 64 MessedUp[i] = ' '; 65 } 66 } else if (MessedUp[i] != ' ') { 67 JustReplacedNewline = false; 68 } 69 } 70 std::string WithoutWhitespace; 71 if (MessedUp[0] != ' ') 72 WithoutWhitespace.push_back(MessedUp[0]); 73 for (unsigned i = 1, e = MessedUp.size(); i != e; ++i) { 74 if (MessedUp[i] != ' ' || MessedUp[i - 1] != ' ') 75 WithoutWhitespace.push_back(MessedUp[i]); 76 } 77 return WithoutWhitespace; 78 } 79 80 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { 81 FormatStyle Style = getLLVMStyle(); 82 Style.ColumnLimit = ColumnLimit; 83 return Style; 84 } 85 86 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { 87 FormatStyle Style = getGoogleStyle(); 88 Style.ColumnLimit = ColumnLimit; 89 return Style; 90 } 91 92 void verifyFormat(llvm::StringRef Code, 93 const FormatStyle &Style = getLLVMStyle()) { 94 EXPECT_EQ(Code.str(), format(messUp(Code), Style)); 95 } 96 97 void verifyGoogleFormat(llvm::StringRef Code) { 98 verifyFormat(Code, getGoogleStyle()); 99 } 100 101 void verifyIndependentOfContext(llvm::StringRef text) { 102 verifyFormat(text); 103 verifyFormat(llvm::Twine("void f() { " + text + " }").str()); 104 } 105 106 int ReplacementCount; 107 }; 108 109 TEST_F(FormatTest, MessUp) { 110 EXPECT_EQ("1 2 3", messUp("1 2 3")); 111 EXPECT_EQ("1 2 3\n", messUp("1\n2\n3\n")); 112 EXPECT_EQ("a\n//b\nc", messUp("a\n//b\nc")); 113 EXPECT_EQ("a\n#b\nc", messUp("a\n#b\nc")); 114 EXPECT_EQ("a\n#b c d\ne", messUp("a\n#b\\\nc\\\nd\ne")); 115 } 116 117 //===----------------------------------------------------------------------===// 118 // Basic function tests. 119 //===----------------------------------------------------------------------===// 120 121 TEST_F(FormatTest, DoesNotChangeCorrectlyFormattedCode) { 122 EXPECT_EQ(";", format(";")); 123 } 124 125 TEST_F(FormatTest, FormatsGlobalStatementsAt0) { 126 EXPECT_EQ("int i;", format(" int i;")); 127 EXPECT_EQ("\nint i;", format(" \n\t \v \f int i;")); 128 EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); 129 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); 130 } 131 132 TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { 133 EXPECT_EQ("int i;", format("int\ni;")); 134 } 135 136 TEST_F(FormatTest, FormatsNestedBlockStatements) { 137 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); 138 } 139 140 TEST_F(FormatTest, FormatsNestedCall) { 141 verifyFormat("Method(f1, f2(f3));"); 142 verifyFormat("Method(f1(f2, f3()));"); 143 verifyFormat("Method(f1(f2, (f3())));"); 144 } 145 146 TEST_F(FormatTest, NestedNameSpecifiers) { 147 verifyFormat("vector< ::Type> v;"); 148 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); 149 verifyFormat("static constexpr bool Bar = decltype(bar())::value;"); 150 } 151 152 TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { 153 EXPECT_EQ("if (a) {\n" 154 " f();\n" 155 "}", 156 format("if(a){f();}")); 157 EXPECT_EQ(4, ReplacementCount); 158 EXPECT_EQ("if (a) {\n" 159 " f();\n" 160 "}", 161 format("if (a) {\n" 162 " f();\n" 163 "}")); 164 EXPECT_EQ(0, ReplacementCount); 165 } 166 167 TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) { 168 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle())); 169 EXPECT_EQ("int a;", format("int a; ")); 170 EXPECT_EQ("int a;\n", format("int a; \n \n \n ")); 171 EXPECT_EQ("int a;\nint b; ", 172 format("int a; \nint b; ", 0, 0, getLLVMStyle())); 173 } 174 175 TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) { 176 EXPECT_EQ("int b;\nint a;", 177 format("int b;\n int a;", 7, 0, getLLVMStyle())); 178 EXPECT_EQ("int b;\n int a;", 179 format("int b;\n int a;", 6, 0, getLLVMStyle())); 180 181 EXPECT_EQ("#define A \\\n" 182 " int a; \\\n" 183 " int b;", 184 format("#define A \\\n" 185 " int a; \\\n" 186 " int b;", 187 26, 0, getLLVMStyleWithColumns(12))); 188 EXPECT_EQ("#define A \\\n" 189 " int a; \\\n" 190 " int b;", 191 format("#define A \\\n" 192 " int a; \\\n" 193 " int b;", 194 25, 0, getLLVMStyleWithColumns(12))); 195 } 196 197 TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) { 198 EXPECT_EQ("int a;\n\n int b;", 199 format("int a;\n \n\n int b;", 7, 0, getLLVMStyle())); 200 EXPECT_EQ("int a;\n\n int b;", 201 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle())); 202 } 203 204 TEST_F(FormatTest, RemovesEmptyLines) { 205 EXPECT_EQ("class C {\n" 206 " int i;\n" 207 "};", 208 format("class C {\n" 209 " int i;\n" 210 "\n" 211 "};")); 212 213 // Don't remove empty lines in more complex control statements. 214 EXPECT_EQ("void f() {\n" 215 " if (a) {\n" 216 " f();\n" 217 "\n" 218 " } else if (b) {\n" 219 " f();\n" 220 " }\n" 221 "}", 222 format("void f() {\n" 223 " if (a) {\n" 224 " f();\n" 225 "\n" 226 " } else if (b) {\n" 227 " f();\n" 228 "\n" 229 " }\n" 230 "\n" 231 "}")); 232 233 // FIXME: This is slightly inconsistent. 234 EXPECT_EQ("namespace {\n" 235 "int i;\n" 236 "}", 237 format("namespace {\n" 238 "int i;\n" 239 "\n" 240 "}")); 241 EXPECT_EQ("namespace {\n" 242 "int i;\n" 243 "\n" 244 "} // namespace", 245 format("namespace {\n" 246 "int i;\n" 247 "\n" 248 "} // namespace")); 249 } 250 251 TEST_F(FormatTest, ReformatsMovedLines) { 252 EXPECT_EQ( 253 "template <typename T> T *getFETokenInfo() const {\n" 254 " return static_cast<T *>(FETokenInfo);\n" 255 "}\n" 256 " int a; // <- Should not be formatted", 257 format( 258 "template<typename T>\n" 259 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" 260 " int a; // <- Should not be formatted", 261 9, 5, getLLVMStyle())); 262 } 263 264 //===----------------------------------------------------------------------===// 265 // Tests for control statements. 266 //===----------------------------------------------------------------------===// 267 268 TEST_F(FormatTest, FormatIfWithoutCompoundStatement) { 269 verifyFormat("if (true)\n f();\ng();"); 270 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); 271 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); 272 273 FormatStyle AllowsMergedIf = getLLVMStyle(); 274 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 275 verifyFormat("if (a)\n" 276 " // comment\n" 277 " f();", 278 AllowsMergedIf); 279 verifyFormat("if (a)\n" 280 " ;", 281 AllowsMergedIf); 282 verifyFormat("if (a)\n" 283 " if (b) return;", 284 AllowsMergedIf); 285 286 verifyFormat("if (a) // Can't merge this\n" 287 " f();\n", 288 AllowsMergedIf); 289 verifyFormat("if (a) /* still don't merge */\n" 290 " f();", 291 AllowsMergedIf); 292 verifyFormat("if (a) { // Never merge this\n" 293 " f();\n" 294 "}", 295 AllowsMergedIf); 296 verifyFormat("if (a) { /* Never merge this */\n" 297 " f();\n" 298 "}", 299 AllowsMergedIf); 300 301 EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1, AllowsMergedIf)); 302 EXPECT_EQ("if (a) return; // comment", 303 format("if(a)\nreturn; // comment", 20, 1, AllowsMergedIf)); 304 305 AllowsMergedIf.ColumnLimit = 14; 306 verifyFormat("if (a) return;", AllowsMergedIf); 307 verifyFormat("if (aaaaaaaaa)\n" 308 " return;", 309 AllowsMergedIf); 310 311 AllowsMergedIf.ColumnLimit = 13; 312 verifyFormat("if (a)\n return;", AllowsMergedIf); 313 } 314 315 TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) { 316 FormatStyle AllowsMergedLoops = getLLVMStyle(); 317 AllowsMergedLoops.AllowShortLoopsOnASingleLine = true; 318 verifyFormat("while (true) continue;", AllowsMergedLoops); 319 verifyFormat("for (;;) continue;", AllowsMergedLoops); 320 verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops); 321 verifyFormat("while (true)\n" 322 " ;", 323 AllowsMergedLoops); 324 verifyFormat("for (;;)\n" 325 " ;", 326 AllowsMergedLoops); 327 verifyFormat("for (;;)\n" 328 " for (;;) continue;", 329 AllowsMergedLoops); 330 verifyFormat("for (;;) // Can't merge this\n" 331 " continue;", 332 AllowsMergedLoops); 333 verifyFormat("for (;;) /* still don't merge */\n" 334 " continue;", 335 AllowsMergedLoops); 336 } 337 338 TEST_F(FormatTest, ParseIfElse) { 339 verifyFormat("if (true)\n" 340 " if (true)\n" 341 " if (true)\n" 342 " f();\n" 343 " else\n" 344 " g();\n" 345 " else\n" 346 " h();\n" 347 "else\n" 348 " i();"); 349 verifyFormat("if (true)\n" 350 " if (true)\n" 351 " if (true) {\n" 352 " if (true)\n" 353 " f();\n" 354 " } else {\n" 355 " g();\n" 356 " }\n" 357 " else\n" 358 " h();\n" 359 "else {\n" 360 " i();\n" 361 "}"); 362 verifyFormat("void f() {\n" 363 " if (a) {\n" 364 " } else {\n" 365 " }\n" 366 "}"); 367 } 368 369 TEST_F(FormatTest, ElseIf) { 370 verifyFormat("if (a) {\n} else if (b) {\n}"); 371 verifyFormat("if (a)\n" 372 " f();\n" 373 "else if (b)\n" 374 " g();\n" 375 "else\n" 376 " h();"); 377 verifyFormat("if (a) {\n" 378 " f();\n" 379 "}\n" 380 "// or else ..\n" 381 "else {\n" 382 " g()\n" 383 "}"); 384 } 385 386 TEST_F(FormatTest, FormatsForLoop) { 387 verifyFormat( 388 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" 389 " ++VeryVeryLongLoopVariable)\n" 390 " ;"); 391 verifyFormat("for (;;)\n" 392 " f();"); 393 verifyFormat("for (;;) {\n}"); 394 verifyFormat("for (;;) {\n" 395 " f();\n" 396 "}"); 397 verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); 398 399 verifyFormat( 400 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 401 " E = UnwrappedLines.end();\n" 402 " I != E; ++I) {\n}"); 403 404 verifyFormat( 405 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" 406 " ++IIIII) {\n}"); 407 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" 408 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" 409 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); 410 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" 411 " I = FD->getDeclsInPrototypeScope().begin(),\n" 412 " E = FD->getDeclsInPrototypeScope().end();\n" 413 " I != E; ++I) {\n}"); 414 415 // FIXME: Not sure whether we want extra identation in line 3 here: 416 verifyFormat( 417 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 418 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" 419 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 420 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 421 " ++aaaaaaaaaaa) {\n}"); 422 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" 423 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 424 "}"); 425 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" 426 " aaaaaaaaaa);\n" 427 " iter; ++iter) {\n" 428 "}"); 429 430 FormatStyle NoBinPacking = getLLVMStyle(); 431 NoBinPacking.BinPackParameters = false; 432 verifyFormat("for (int aaaaaaaaaaa = 1;\n" 433 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" 434 " aaaaaaaaaaaaaaaa,\n" 435 " aaaaaaaaaaaaaaaa,\n" 436 " aaaaaaaaaaaaaaaa);\n" 437 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 438 "}", 439 NoBinPacking); 440 verifyFormat( 441 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 442 " E = UnwrappedLines.end();\n" 443 " I != E;\n" 444 " ++I) {\n}", 445 NoBinPacking); 446 } 447 448 TEST_F(FormatTest, RangeBasedForLoops) { 449 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 450 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 451 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" 452 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); 453 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" 454 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 455 } 456 457 TEST_F(FormatTest, FormatsWhileLoop) { 458 verifyFormat("while (true) {\n}"); 459 verifyFormat("while (true)\n" 460 " f();"); 461 verifyFormat("while () {\n}"); 462 verifyFormat("while () {\n" 463 " f();\n" 464 "}"); 465 } 466 467 TEST_F(FormatTest, FormatsDoWhile) { 468 verifyFormat("do {\n" 469 " do_something();\n" 470 "} while (something());"); 471 verifyFormat("do\n" 472 " do_something();\n" 473 "while (something());"); 474 } 475 476 TEST_F(FormatTest, FormatsSwitchStatement) { 477 verifyFormat("switch (x) {\n" 478 "case 1:\n" 479 " f();\n" 480 " break;\n" 481 "case kFoo:\n" 482 "case ns::kBar:\n" 483 "case kBaz:\n" 484 " break;\n" 485 "default:\n" 486 " g();\n" 487 " break;\n" 488 "}"); 489 verifyFormat("switch (x) {\n" 490 "case 1: {\n" 491 " f();\n" 492 " break;\n" 493 "}\n" 494 "}"); 495 verifyFormat("switch (x) {\n" 496 "case 1: {\n" 497 " f();\n" 498 " {\n" 499 " g();\n" 500 " h();\n" 501 " }\n" 502 " break;\n" 503 "}\n" 504 "}"); 505 verifyFormat("switch (x) {\n" 506 "case 1: {\n" 507 " f();\n" 508 " if (foo) {\n" 509 " g();\n" 510 " h();\n" 511 " }\n" 512 " break;\n" 513 "}\n" 514 "}"); 515 verifyFormat("switch (x) {\n" 516 "case 1: {\n" 517 " f();\n" 518 " g();\n" 519 "} break;\n" 520 "}"); 521 verifyFormat("switch (test)\n" 522 " ;"); 523 verifyFormat("switch (x) {\n" 524 "default: {\n" 525 " // Do nothing.\n" 526 "}\n" 527 "}"); 528 verifyFormat("switch (x) {\n" 529 "// comment\n" 530 "// if 1, do f()\n" 531 "case 1:\n" 532 " f();\n" 533 "}"); 534 verifyFormat("switch (x) {\n" 535 "case 1:\n" 536 " // Do amazing stuff\n" 537 " {\n" 538 " f();\n" 539 " g();\n" 540 " }\n" 541 " break;\n" 542 "}"); 543 verifyFormat("#define A \\\n" 544 " switch (x) { \\\n" 545 " case a: \\\n" 546 " foo = b; \\\n" 547 " }", getLLVMStyleWithColumns(20)); 548 verifyFormat("#define OPERATION_CASE(name) \\\n" 549 " case OP_name: \\\n" 550 " return operations::Operation##name\n", 551 getLLVMStyleWithColumns(40)); 552 553 verifyGoogleFormat("switch (x) {\n" 554 " case 1:\n" 555 " f();\n" 556 " break;\n" 557 " case kFoo:\n" 558 " case ns::kBar:\n" 559 " case kBaz:\n" 560 " break;\n" 561 " default:\n" 562 " g();\n" 563 " break;\n" 564 "}"); 565 verifyGoogleFormat("switch (x) {\n" 566 " case 1: {\n" 567 " f();\n" 568 " break;\n" 569 " }\n" 570 "}"); 571 verifyGoogleFormat("switch (test)\n" 572 " ;"); 573 574 verifyGoogleFormat("#define OPERATION_CASE(name) \\\n" 575 " case OP_name: \\\n" 576 " return operations::Operation##name\n"); 577 verifyGoogleFormat("Operation codeToOperation(OperationCode OpCode) {\n" 578 " // Get the correction operation class.\n" 579 " switch (OpCode) {\n" 580 " CASE(Add);\n" 581 " CASE(Subtract);\n" 582 " default:\n" 583 " return operations::Unknown;\n" 584 " }\n" 585 "#undef OPERATION_CASE\n" 586 "}"); 587 verifyFormat("DEBUG({\n" 588 " switch (x) {\n" 589 " case A:\n" 590 " f();\n" 591 " break;\n" 592 " // On B:\n" 593 " case B:\n" 594 " g();\n" 595 " break;\n" 596 " }\n" 597 "});"); 598 } 599 600 TEST_F(FormatTest, CaseRanges) { 601 verifyFormat("switch (x) {\n" 602 "case 'A' ... 'Z':\n" 603 "case 1 ... 5:\n" 604 " break;\n" 605 "}"); 606 } 607 608 TEST_F(FormatTest, FormatsLabels) { 609 verifyFormat("void f() {\n" 610 " some_code();\n" 611 "test_label:\n" 612 " some_other_code();\n" 613 " {\n" 614 " some_more_code();\n" 615 " another_label:\n" 616 " some_more_code();\n" 617 " }\n" 618 "}"); 619 verifyFormat("some_code();\n" 620 "test_label:\n" 621 "some_other_code();"); 622 } 623 624 //===----------------------------------------------------------------------===// 625 // Tests for comments. 626 //===----------------------------------------------------------------------===// 627 628 TEST_F(FormatTest, UnderstandsSingleLineComments) { 629 verifyFormat("//* */"); 630 verifyFormat("// line 1\n" 631 "// line 2\n" 632 "void f() {}\n"); 633 634 verifyFormat("void f() {\n" 635 " // Doesn't do anything\n" 636 "}"); 637 verifyFormat("SomeObject\n" 638 " // Calling someFunction on SomeObject\n" 639 " .someFunction();"); 640 verifyFormat("void f(int i, // some comment (probably for i)\n" 641 " int j, // some comment (probably for j)\n" 642 " int k); // some comment (probably for k)"); 643 verifyFormat("void f(int i,\n" 644 " // some comment (probably for j)\n" 645 " int j,\n" 646 " // some comment (probably for k)\n" 647 " int k);"); 648 649 verifyFormat("int i // This is a fancy variable\n" 650 " = 5; // with nicely aligned comment."); 651 652 verifyFormat("// Leading comment.\n" 653 "int a; // Trailing comment."); 654 verifyFormat("int a; // Trailing comment\n" 655 " // on 2\n" 656 " // or 3 lines.\n" 657 "int b;"); 658 verifyFormat("int a; // Trailing comment\n" 659 "\n" 660 "// Leading comment.\n" 661 "int b;"); 662 verifyFormat("int a; // Comment.\n" 663 " // More details.\n" 664 "int bbbb; // Another comment."); 665 verifyFormat( 666 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 667 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" 668 "int cccccccccccccccccccccccccccccc; // comment\n" 669 "int ddd; // looooooooooooooooooooooooong comment\n" 670 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 671 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" 672 "int ccccccccccccccccccc; // comment"); 673 674 verifyFormat("#include \"a\" // comment\n" 675 "#include \"a/b/c\" // comment"); 676 verifyFormat("#include <a> // comment\n" 677 "#include <a/b/c> // comment"); 678 EXPECT_EQ("#include \"a\" // comment\n" 679 "#include \"a/b/c\" // comment", 680 format("#include \\\n" 681 " \"a\" // comment\n" 682 "#include \"a/b/c\" // comment")); 683 684 verifyFormat("enum E {\n" 685 " // comment\n" 686 " VAL_A, // comment\n" 687 " VAL_B\n" 688 "};"); 689 690 verifyFormat( 691 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 692 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); 693 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 694 " // Comment inside a statement.\n" 695 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 696 verifyFormat( 697 "bool aaaaaaaaaaaaa = // comment\n" 698 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 699 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 700 701 verifyFormat("int aaaa; // aaaaa\n" 702 "int aa; // aaaaaaa", 703 getLLVMStyleWithColumns(20)); 704 705 EXPECT_EQ("void f() { // This does something ..\n" 706 "}\n" 707 "int a; // This is unrelated", 708 format("void f() { // This does something ..\n" 709 " }\n" 710 "int a; // This is unrelated")); 711 EXPECT_EQ("class C {\n" 712 " void f() { // This does something ..\n" 713 " } // awesome..\n" 714 "\n" 715 " int a; // This is unrelated\n" 716 "};", 717 format("class C{void f() { // This does something ..\n" 718 " } // awesome..\n" 719 " \n" 720 "int a; // This is unrelated\n" 721 "};")); 722 723 EXPECT_EQ("int i; // single line trailing comment", 724 format("int i;\\\n// single line trailing comment")); 725 726 verifyGoogleFormat("int a; // Trailing comment."); 727 728 verifyFormat("someFunction(anotherFunction( // Force break.\n" 729 " parameter));"); 730 731 verifyGoogleFormat("#endif // HEADER_GUARD"); 732 733 verifyFormat("const char *test[] = {\n" 734 " // A\n" 735 " \"aaaa\",\n" 736 " // B\n" 737 " \"aaaaa\",\n" 738 "};"); 739 verifyGoogleFormat( 740 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 741 " aaaaaaaaaaaaaaaaaaaaaa); // 81_cols_with_this_comment"); 742 EXPECT_EQ("D(a, {\n" 743 " // test\n" 744 " int a;\n" 745 "});", 746 format("D(a, {\n" 747 "// test\n" 748 "int a;\n" 749 "});")); 750 751 EXPECT_EQ("lineWith(); // comment\n" 752 "// at start\n" 753 "otherLine();", 754 format("lineWith(); // comment\n" 755 "// at start\n" 756 "otherLine();")); 757 EXPECT_EQ("lineWith(); // comment\n" 758 " // at start\n" 759 "otherLine();", 760 format("lineWith(); // comment\n" 761 " // at start\n" 762 "otherLine();")); 763 764 EXPECT_EQ("lineWith(); // comment\n" 765 "// at start\n" 766 "otherLine(); // comment", 767 format("lineWith(); // comment\n" 768 "// at start\n" 769 "otherLine(); // comment")); 770 EXPECT_EQ("lineWith();\n" 771 "// at start\n" 772 "otherLine(); // comment", 773 format("lineWith();\n" 774 " // at start\n" 775 "otherLine(); // comment")); 776 EXPECT_EQ("// first\n" 777 "// at start\n" 778 "otherLine(); // comment", 779 format("// first\n" 780 " // at start\n" 781 "otherLine(); // comment")); 782 EXPECT_EQ("f();\n" 783 "// first\n" 784 "// at start\n" 785 "otherLine(); // comment", 786 format("f();\n" 787 "// first\n" 788 " // at start\n" 789 "otherLine(); // comment")); 790 verifyFormat("f(); // comment\n" 791 "// first\n" 792 "// at start\n" 793 "otherLine();"); 794 EXPECT_EQ("f(); // comment\n" 795 "// first\n" 796 "// at start\n" 797 "otherLine();", 798 format("f(); // comment\n" 799 "// first\n" 800 " // at start\n" 801 "otherLine();")); 802 EXPECT_EQ("f(); // comment\n" 803 " // first\n" 804 "// at start\n" 805 "otherLine();", 806 format("f(); // comment\n" 807 " // first\n" 808 "// at start\n" 809 "otherLine();")); 810 } 811 812 TEST_F(FormatTest, CanFormatCommentsLocally) { 813 EXPECT_EQ("int a; // comment\n" 814 "int b; // comment", 815 format("int a; // comment\n" 816 "int b; // comment", 817 0, 0, getLLVMStyle())); 818 EXPECT_EQ("int a; // comment\n" 819 " // line 2\n" 820 "int b;", 821 format("int a; // comment\n" 822 " // line 2\n" 823 "int b;", 824 28, 0, getLLVMStyle())); 825 EXPECT_EQ("int aaaaaa; // comment\n" 826 "int b;\n" 827 "int c; // unrelated comment", 828 format("int aaaaaa; // comment\n" 829 "int b;\n" 830 "int c; // unrelated comment", 831 31, 0, getLLVMStyle())); 832 } 833 834 TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) { 835 EXPECT_EQ("// comment", format("// comment ")); 836 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", 837 format("int aaaaaaa, bbbbbbb; // comment ", 838 getLLVMStyleWithColumns(33))); 839 EXPECT_EQ("// comment\\\n", format("// comment\\\n \t \v \f ")); 840 EXPECT_EQ("// comment \\\n", format("// comment \\\n \t \v \f ")); 841 } 842 843 TEST_F(FormatTest, UnderstandsBlockComments) { 844 verifyFormat("f(/*noSpaceAfterParameterNamingComment=*/true);"); 845 EXPECT_EQ( 846 "f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" 847 " bbbbbbbbbbbbbbbbbbbbbbbbb);", 848 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n/* Trailing comment for aa... */\n" 849 " bbbbbbbbbbbbbbbbbbbbbbbbb);")); 850 EXPECT_EQ( 851 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 852 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", 853 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" 854 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); 855 EXPECT_EQ( 856 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 857 " aaaaaaaaaaaaaaaaaa,\n" 858 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 859 "}", 860 format("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 861 " aaaaaaaaaaaaaaaaaa ,\n" 862 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 863 "}")); 864 865 FormatStyle NoBinPacking = getLLVMStyle(); 866 NoBinPacking.BinPackParameters = false; 867 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" 868 " /* parameter 2 */ aaaaaa,\n" 869 " /* parameter 3 */ aaaaaa,\n" 870 " /* parameter 4 */ aaaaaa);", 871 NoBinPacking); 872 } 873 874 TEST_F(FormatTest, AlignsBlockComments) { 875 EXPECT_EQ("/*\n" 876 " * Really multi-line\n" 877 " * comment.\n" 878 " */\n" 879 "void f() {}", 880 format(" /*\n" 881 " * Really multi-line\n" 882 " * comment.\n" 883 " */\n" 884 " void f() {}")); 885 EXPECT_EQ("class C {\n" 886 " /*\n" 887 " * Another multi-line\n" 888 " * comment.\n" 889 " */\n" 890 " void f() {}\n" 891 "};", 892 format("class C {\n" 893 "/*\n" 894 " * Another multi-line\n" 895 " * comment.\n" 896 " */\n" 897 "void f() {}\n" 898 "};")); 899 EXPECT_EQ("/*\n" 900 " 1. This is a comment with non-trivial formatting.\n" 901 " 1.1. We have to indent/outdent all lines equally\n" 902 " 1.1.1. to keep the formatting.\n" 903 " */", 904 format(" /*\n" 905 " 1. This is a comment with non-trivial formatting.\n" 906 " 1.1. We have to indent/outdent all lines equally\n" 907 " 1.1.1. to keep the formatting.\n" 908 " */")); 909 EXPECT_EQ("/*\n" 910 "Don't try to outdent if there's not enough indentation.\n" 911 "*/", 912 format(" /*\n" 913 " Don't try to outdent if there's not enough indentation.\n" 914 " */")); 915 916 EXPECT_EQ("int i; /* Comment with empty...\n" 917 " *\n" 918 " * line. */", 919 format("int i; /* Comment with empty...\n" 920 " *\n" 921 " * line. */")); 922 } 923 924 TEST_F(FormatTest, CorrectlyHandlesLengthOfBlockComments) { 925 EXPECT_EQ("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 926 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */", 927 format("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 928 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */")); 929 EXPECT_EQ( 930 "void ffffffffffff(\n" 931 " int aaaaaaaa, int bbbbbbbb,\n" 932 " int cccccccccccc) { /*\n" 933 " aaaaaaaaaa\n" 934 " aaaaaaaaaaaaa\n" 935 " bbbbbbbbbbbbbb\n" 936 " bbbbbbbbbb\n" 937 " */\n" 938 "}", 939 format("void ffffffffffff(int aaaaaaaa, int bbbbbbbb, int cccccccccccc)\n" 940 "{ /*\n" 941 " aaaaaaaaaa aaaaaaaaaaaaa\n" 942 " bbbbbbbbbbbbbb bbbbbbbbbb\n" 943 " */\n" 944 "}", 945 getLLVMStyleWithColumns(40))); 946 } 947 948 TEST_F(FormatTest, DontBreakNonTrailingBlockComments) { 949 EXPECT_EQ("void\n" 950 "ffffffffff(int aaaaa /* test */);", 951 format("void ffffffffff(int aaaaa /* test */);", 952 getLLVMStyleWithColumns(35))); 953 } 954 955 TEST_F(FormatTest, SplitsLongCxxComments) { 956 EXPECT_EQ("// A comment that\n" 957 "// doesn't fit on\n" 958 "// one line", 959 format("// A comment that doesn't fit on one line", 960 getLLVMStyleWithColumns(20))); 961 EXPECT_EQ("// a b c d\n" 962 "// e f g\n" 963 "// h i j k", 964 format("// a b c d e f g h i j k", 965 getLLVMStyleWithColumns(10))); 966 EXPECT_EQ("// a b c d\n" 967 "// e f g\n" 968 "// h i j k", 969 format("\\\n// a b c d e f g h i j k", 970 getLLVMStyleWithColumns(10))); 971 EXPECT_EQ("if (true) // A comment that\n" 972 " // doesn't fit on\n" 973 " // one line", 974 format("if (true) // A comment that doesn't fit on one line ", 975 getLLVMStyleWithColumns(30))); 976 EXPECT_EQ("// Don't_touch_leading_whitespace", 977 format("// Don't_touch_leading_whitespace", 978 getLLVMStyleWithColumns(20))); 979 EXPECT_EQ("// Add leading\n" 980 "// whitespace", 981 format("//Add leading whitespace", getLLVMStyleWithColumns(20))); 982 EXPECT_EQ("// whitespace", format("//whitespace", getLLVMStyle())); 983 EXPECT_EQ("// Even if it makes the line exceed the column\n" 984 "// limit", 985 format("//Even if it makes the line exceed the column limit", 986 getLLVMStyleWithColumns(51))); 987 EXPECT_EQ("//--But not here", format("//--But not here", getLLVMStyle())); 988 989 EXPECT_EQ("// aa bb cc dd", 990 format("// aa bb cc dd ", 991 getLLVMStyleWithColumns(15))); 992 993 EXPECT_EQ("// A comment before\n" 994 "// a macro\n" 995 "// definition\n" 996 "#define a b", 997 format("// A comment before a macro definition\n" 998 "#define a b", 999 getLLVMStyleWithColumns(20))); 1000 EXPECT_EQ("void ffffff(int aaaaaaaaa, // wwww\n" 1001 " int a, int bbb, // xxxxxxx\n" 1002 " // yyyyyyyyy\n" 1003 " int c, int d, int e) {}", 1004 format("void ffffff(\n" 1005 " int aaaaaaaaa, // wwww\n" 1006 " int a,\n" 1007 " int bbb, // xxxxxxx yyyyyyyyy\n" 1008 " int c, int d, int e) {}", 1009 getLLVMStyleWithColumns(40))); 1010 EXPECT_EQ("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1011 format("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1012 getLLVMStyleWithColumns(20))); 1013 EXPECT_EQ( 1014 "#define XXX // a b c d\n" 1015 " // e f g h", 1016 format("#define XXX // a b c d e f g h", getLLVMStyleWithColumns(22))); 1017 EXPECT_EQ( 1018 "#define XXX // q w e r\n" 1019 " // t y u i", 1020 format("#define XXX //q w e r t y u i", getLLVMStyleWithColumns(22))); 1021 } 1022 1023 TEST_F(FormatTest, DontSplitLineCommentsWithEscapedNewlines) { 1024 EXPECT_EQ("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1025 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1026 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1027 format("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1028 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1029 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")); 1030 EXPECT_EQ("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1031 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1032 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1033 format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1034 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1035 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1036 getLLVMStyleWithColumns(50))); 1037 // FIXME: One day we might want to implement adjustment of leading whitespace 1038 // of the consecutive lines in this kind of comment: 1039 EXPECT_EQ("int\n" 1040 "a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1041 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1042 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1043 format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1044 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1045 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1046 getLLVMStyleWithColumns(49))); 1047 } 1048 1049 TEST_F(FormatTest, PriorityOfCommentBreaking) { 1050 EXPECT_EQ("if (xxx ==\n" 1051 " yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1052 " zzz)\n" 1053 " q();", 1054 format("if (xxx == yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1055 " zzz) q();", 1056 getLLVMStyleWithColumns(40))); 1057 EXPECT_EQ("if (xxxxxxxxxx ==\n" 1058 " yyy && // aaaaaa bbbbbbbb cccc\n" 1059 " zzz)\n" 1060 " q();", 1061 format("if (xxxxxxxxxx == yyy && // aaaaaa bbbbbbbb cccc\n" 1062 " zzz) q();", 1063 getLLVMStyleWithColumns(40))); 1064 EXPECT_EQ("if (xxxxxxxxxx &&\n" 1065 " yyy || // aaaaaa bbbbbbbb cccc\n" 1066 " zzz)\n" 1067 " q();", 1068 format("if (xxxxxxxxxx && yyy || // aaaaaa bbbbbbbb cccc\n" 1069 " zzz) q();", 1070 getLLVMStyleWithColumns(40))); 1071 EXPECT_EQ("fffffffff(&xxx, // aaaaaaaaaaaa\n" 1072 " // bbbbbbbbbbb\n" 1073 " zzz);", 1074 format("fffffffff(&xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1075 " zzz);", 1076 getLLVMStyleWithColumns(40))); 1077 } 1078 1079 TEST_F(FormatTest, MultiLineCommentsInDefines) { 1080 EXPECT_EQ("#define A(x) /* \\\n" 1081 " a comment \\\n" 1082 " inside */ \\\n" 1083 " f();", 1084 format("#define A(x) /* \\\n" 1085 " a comment \\\n" 1086 " inside */ \\\n" 1087 " f();", 1088 getLLVMStyleWithColumns(17))); 1089 EXPECT_EQ("#define A( \\\n" 1090 " x) /* \\\n" 1091 " a comment \\\n" 1092 " inside */ \\\n" 1093 " f();", 1094 format("#define A( \\\n" 1095 " x) /* \\\n" 1096 " a comment \\\n" 1097 " inside */ \\\n" 1098 " f();", 1099 getLLVMStyleWithColumns(17))); 1100 } 1101 1102 TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) { 1103 EXPECT_EQ("namespace {}\n// Test\n#define A", 1104 format("namespace {}\n // Test\n#define A")); 1105 EXPECT_EQ("namespace {}\n/* Test */\n#define A", 1106 format("namespace {}\n /* Test */\n#define A")); 1107 EXPECT_EQ("namespace {}\n/* Test */ #define A", 1108 format("namespace {}\n /* Test */ #define A")); 1109 } 1110 1111 TEST_F(FormatTest, SplitsLongLinesInComments) { 1112 EXPECT_EQ("/* This is a long\n" 1113 " * comment that\n" 1114 " * doesn't\n" 1115 " * fit on one line.\n" 1116 " */", 1117 format("/* " 1118 "This is a long " 1119 "comment that " 1120 "doesn't " 1121 "fit on one line. */", 1122 getLLVMStyleWithColumns(20))); 1123 EXPECT_EQ("/* a b c d\n" 1124 " * e f g\n" 1125 " * h i j k\n" 1126 " */", 1127 format("/* a b c d e f g h i j k */", 1128 getLLVMStyleWithColumns(10))); 1129 EXPECT_EQ("/* a b c d\n" 1130 " * e f g\n" 1131 " * h i j k\n" 1132 " */", 1133 format("\\\n/* a b c d e f g h i j k */", 1134 getLLVMStyleWithColumns(10))); 1135 EXPECT_EQ("/*\n" 1136 "This is a long\n" 1137 "comment that doesn't\n" 1138 "fit on one line.\n" 1139 "*/", 1140 format("/*\n" 1141 "This is a long " 1142 "comment that doesn't " 1143 "fit on one line. \n" 1144 "*/", getLLVMStyleWithColumns(20))); 1145 EXPECT_EQ("/*\n" 1146 " * This is a long\n" 1147 " * comment that\n" 1148 " * doesn't fit on\n" 1149 " * one line.\n" 1150 " */", 1151 format("/* \n" 1152 " * This is a long " 1153 " comment that " 1154 " doesn't fit on " 1155 " one line. \n" 1156 " */", getLLVMStyleWithColumns(20))); 1157 EXPECT_EQ("/*\n" 1158 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" 1159 " * so_it_should_be_broken\n" 1160 " * wherever_a_space_occurs\n" 1161 " */", 1162 format("/*\n" 1163 " * This_is_a_comment_with_words_that_dont_fit_on_one_line " 1164 " so_it_should_be_broken " 1165 " wherever_a_space_occurs \n" 1166 " */", 1167 getLLVMStyleWithColumns(20))); 1168 EXPECT_EQ("/*\n" 1169 " * This_comment_can_not_be_broken_into_lines\n" 1170 " */", 1171 format("/*\n" 1172 " * This_comment_can_not_be_broken_into_lines\n" 1173 " */", 1174 getLLVMStyleWithColumns(20))); 1175 EXPECT_EQ("{\n" 1176 " /*\n" 1177 " This is another\n" 1178 " long comment that\n" 1179 " doesn't fit on one\n" 1180 " line 1234567890\n" 1181 " */\n" 1182 "}", 1183 format("{\n" 1184 "/*\n" 1185 "This is another " 1186 " long comment that " 1187 " doesn't fit on one" 1188 " line 1234567890\n" 1189 "*/\n" 1190 "}", getLLVMStyleWithColumns(20))); 1191 EXPECT_EQ("{\n" 1192 " /*\n" 1193 " * This i s\n" 1194 " * another comment\n" 1195 " * t hat doesn' t\n" 1196 " * fit on one l i\n" 1197 " * n e\n" 1198 " */\n" 1199 "}", 1200 format("{\n" 1201 "/*\n" 1202 " * This i s" 1203 " another comment" 1204 " t hat doesn' t" 1205 " fit on one l i" 1206 " n e\n" 1207 " */\n" 1208 "}", getLLVMStyleWithColumns(20))); 1209 EXPECT_EQ("/*\n" 1210 " * This is a long\n" 1211 " * comment that\n" 1212 " * doesn't fit on\n" 1213 " * one line\n" 1214 " */", 1215 format(" /*\n" 1216 " * This is a long comment that doesn't fit on one line\n" 1217 " */", getLLVMStyleWithColumns(20))); 1218 EXPECT_EQ("{\n" 1219 " if (something) /* This is a\n" 1220 " long\n" 1221 " comment */\n" 1222 " ;\n" 1223 "}", 1224 format("{\n" 1225 " if (something) /* This is a long comment */\n" 1226 " ;\n" 1227 "}", 1228 getLLVMStyleWithColumns(30))); 1229 1230 EXPECT_EQ("/* A comment before\n" 1231 " * a macro\n" 1232 " * definition */\n" 1233 "#define a b", 1234 format("/* A comment before a macro definition */\n" 1235 "#define a b", 1236 getLLVMStyleWithColumns(20))); 1237 1238 EXPECT_EQ("/* some comment\n" 1239 " * a comment\n" 1240 "* that we break\n" 1241 " * another comment\n" 1242 "* we have to break\n" 1243 "* a left comment\n" 1244 " */", 1245 format(" /* some comment\n" 1246 " * a comment that we break\n" 1247 " * another comment we have to break\n" 1248 "* a left comment\n" 1249 " */", 1250 getLLVMStyleWithColumns(20))); 1251 1252 EXPECT_EQ("/*\n" 1253 "\n" 1254 "\n" 1255 " */\n", 1256 format(" /* \n" 1257 " \n" 1258 " \n" 1259 " */\n")); 1260 1261 EXPECT_EQ("/* a a */", 1262 format("/* a a */", getLLVMStyleWithColumns(15))); 1263 EXPECT_EQ("/* a a bc */", 1264 format("/* a a bc */", getLLVMStyleWithColumns(15))); 1265 EXPECT_EQ("/* aaa aaa\n" 1266 " * aaaaa */", 1267 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1268 EXPECT_EQ("/* aaa aaa\n" 1269 " * aaaaa */", 1270 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1271 } 1272 1273 TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) { 1274 EXPECT_EQ("#define X \\\n" 1275 " /* \\\n" 1276 " Test \\\n" 1277 " Macro comment \\\n" 1278 " with a long \\\n" 1279 " line \\\n" 1280 " */ \\\n" 1281 " A + B", 1282 format("#define X \\\n" 1283 " /*\n" 1284 " Test\n" 1285 " Macro comment with a long line\n" 1286 " */ \\\n" 1287 " A + B", 1288 getLLVMStyleWithColumns(20))); 1289 EXPECT_EQ("#define X \\\n" 1290 " /* Macro comment \\\n" 1291 " with a long \\\n" 1292 " line */ \\\n" 1293 " A + B", 1294 format("#define X \\\n" 1295 " /* Macro comment with a long\n" 1296 " line */ \\\n" 1297 " A + B", 1298 getLLVMStyleWithColumns(20))); 1299 EXPECT_EQ("#define X \\\n" 1300 " /* Macro comment \\\n" 1301 " * with a long \\\n" 1302 " * line */ \\\n" 1303 " A + B", 1304 format("#define X \\\n" 1305 " /* Macro comment with a long line */ \\\n" 1306 " A + B", 1307 getLLVMStyleWithColumns(20))); 1308 } 1309 1310 TEST_F(FormatTest, CommentsInStaticInitializers) { 1311 EXPECT_EQ( 1312 "static SomeType type = { aaaaaaaaaaaaaaaaaaaa, /* comment */\n" 1313 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" 1314 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" 1315 " aaaaaaaaaaaaaaaaaaaa, // comment\n" 1316 " aaaaaaaaaaaaaaaaaaaa };", 1317 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" 1318 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" 1319 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" 1320 " aaaaaaaaaaaaaaaaaaaa , // comment\n" 1321 " aaaaaaaaaaaaaaaaaaaa };")); 1322 verifyFormat("static SomeType type = { aaaaaaaaaaa, // comment for aa...\n" 1323 " bbbbbbbbbbb, ccccccccccc };"); 1324 verifyFormat("static SomeType type = { aaaaaaaaaaa,\n" 1325 " // comment for bb....\n" 1326 " bbbbbbbbbbb, ccccccccccc };"); 1327 verifyGoogleFormat( 1328 "static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1329 " bbbbbbbbbbb, ccccccccccc};"); 1330 verifyGoogleFormat("static SomeType type = {aaaaaaaaaaa,\n" 1331 " // comment for bb....\n" 1332 " bbbbbbbbbbb, ccccccccccc};"); 1333 1334 verifyFormat("S s = { { a, b, c }, // Group #1\n" 1335 " { d, e, f }, // Group #2\n" 1336 " { g, h, i } }; // Group #3"); 1337 verifyFormat("S s = { { // Group #1\n" 1338 " a, b, c },\n" 1339 " { // Group #2\n" 1340 " d, e, f },\n" 1341 " { // Group #3\n" 1342 " g, h, i } };"); 1343 1344 EXPECT_EQ("S s = {\n" 1345 " // Some comment\n" 1346 " a,\n" 1347 "\n" 1348 " // Comment after empty line\n" 1349 " b\n" 1350 "}", 1351 format("S s = {\n" 1352 " // Some comment\n" 1353 " a,\n" 1354 " \n" 1355 " // Comment after empty line\n" 1356 " b\n" 1357 "}")); 1358 EXPECT_EQ("S s = {\n" 1359 " /* Some comment */\n" 1360 " a,\n" 1361 "\n" 1362 " /* Comment after empty line */\n" 1363 " b\n" 1364 "}", 1365 format("S s = {\n" 1366 " /* Some comment */\n" 1367 " a,\n" 1368 " \n" 1369 " /* Comment after empty line */\n" 1370 " b\n" 1371 "}")); 1372 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" 1373 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1374 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1375 " 0x00, 0x00, 0x00, 0x00 // comment\n" 1376 "};"); 1377 } 1378 1379 TEST_F(FormatTest, IgnoresIf0Contents) { 1380 EXPECT_EQ("#if 0\n" 1381 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1382 "#endif\n" 1383 "void f() {}", 1384 format("#if 0\n" 1385 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1386 "#endif\n" 1387 "void f( ) { }")); 1388 EXPECT_EQ("#if false\n" 1389 "void f( ) { }\n" 1390 "#endif\n" 1391 "void g() {}\n", 1392 format("#if false\n" 1393 "void f( ) { }\n" 1394 "#endif\n" 1395 "void g( ) { }\n")); 1396 EXPECT_EQ("enum E {\n" 1397 " One,\n" 1398 " Two,\n" 1399 "#if 0\n" 1400 "Three,\n" 1401 " Four,\n" 1402 "#endif\n" 1403 " Five\n" 1404 "};", 1405 format("enum E {\n" 1406 " One,Two,\n" 1407 "#if 0\n" 1408 "Three,\n" 1409 " Four,\n" 1410 "#endif\n" 1411 " Five};")); 1412 EXPECT_EQ("enum F {\n" 1413 " One,\n" 1414 "#if 1\n" 1415 " Two,\n" 1416 "#if 0\n" 1417 "Three,\n" 1418 " Four,\n" 1419 "#endif\n" 1420 " Five\n" 1421 "#endif\n" 1422 "};", 1423 format("enum F {\n" 1424 "One,\n" 1425 "#if 1\n" 1426 "Two,\n" 1427 "#if 0\n" 1428 "Three,\n" 1429 " Four,\n" 1430 "#endif\n" 1431 "Five\n" 1432 "#endif\n" 1433 "};")); 1434 EXPECT_EQ("enum G {\n" 1435 " One,\n" 1436 "#if 0\n" 1437 "Two,\n" 1438 "#else\n" 1439 " Three,\n" 1440 "#endif\n" 1441 " Four\n" 1442 "};", 1443 format("enum G {\n" 1444 "One,\n" 1445 "#if 0\n" 1446 "Two,\n" 1447 "#else\n" 1448 "Three,\n" 1449 "#endif\n" 1450 "Four\n" 1451 "};")); 1452 EXPECT_EQ("enum H {\n" 1453 " One,\n" 1454 "#if 0\n" 1455 "#ifdef Q\n" 1456 "Two,\n" 1457 "#else\n" 1458 "Three,\n" 1459 "#endif\n" 1460 "#endif\n" 1461 " Four\n" 1462 "};", 1463 format("enum H {\n" 1464 "One,\n" 1465 "#if 0\n" 1466 "#ifdef Q\n" 1467 "Two,\n" 1468 "#else\n" 1469 "Three,\n" 1470 "#endif\n" 1471 "#endif\n" 1472 "Four\n" 1473 "};")); 1474 EXPECT_EQ("enum I {\n" 1475 " One,\n" 1476 "#if /* test */ 0 || 1\n" 1477 "Two,\n" 1478 "Three,\n" 1479 "#endif\n" 1480 " Four\n" 1481 "};", 1482 format("enum I {\n" 1483 "One,\n" 1484 "#if /* test */ 0 || 1\n" 1485 "Two,\n" 1486 "Three,\n" 1487 "#endif\n" 1488 "Four\n" 1489 "};")); 1490 EXPECT_EQ("enum J {\n" 1491 " One,\n" 1492 "#if 0\n" 1493 "#if 0\n" 1494 "Two,\n" 1495 "#else\n" 1496 "Three,\n" 1497 "#endif\n" 1498 "Four,\n" 1499 "#endif\n" 1500 " Five\n" 1501 "};", 1502 format("enum J {\n" 1503 "One,\n" 1504 "#if 0\n" 1505 "#if 0\n" 1506 "Two,\n" 1507 "#else\n" 1508 "Three,\n" 1509 "#endif\n" 1510 "Four,\n" 1511 "#endif\n" 1512 "Five\n" 1513 "};")); 1514 1515 } 1516 1517 //===----------------------------------------------------------------------===// 1518 // Tests for classes, namespaces, etc. 1519 //===----------------------------------------------------------------------===// 1520 1521 TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { 1522 verifyFormat("class A {};"); 1523 } 1524 1525 TEST_F(FormatTest, UnderstandsAccessSpecifiers) { 1526 verifyFormat("class A {\n" 1527 "public:\n" 1528 "public: // comment\n" 1529 "protected:\n" 1530 "private:\n" 1531 " void f() {}\n" 1532 "};"); 1533 verifyGoogleFormat("class A {\n" 1534 " public:\n" 1535 " protected:\n" 1536 " private:\n" 1537 " void f() {}\n" 1538 "};"); 1539 } 1540 1541 TEST_F(FormatTest, SeparatesLogicalBlocks) { 1542 EXPECT_EQ("class A {\n" 1543 "public:\n" 1544 " void f();\n" 1545 "\n" 1546 "private:\n" 1547 " void g() {}\n" 1548 " // test\n" 1549 "protected:\n" 1550 " int h;\n" 1551 "};", 1552 format("class A {\n" 1553 "public:\n" 1554 "void f();\n" 1555 "private:\n" 1556 "void g() {}\n" 1557 "// test\n" 1558 "protected:\n" 1559 "int h;\n" 1560 "};")); 1561 EXPECT_EQ("class A {\n" 1562 "protected:\n" 1563 "public:\n" 1564 " void f();\n" 1565 "};", 1566 format("class A {\n" 1567 "protected:\n" 1568 "\n" 1569 "public:\n" 1570 "\n" 1571 " void f();\n" 1572 "};")); 1573 } 1574 1575 TEST_F(FormatTest, FormatsClasses) { 1576 verifyFormat("class A : public B {};"); 1577 verifyFormat("class A : public ::B {};"); 1578 1579 verifyFormat( 1580 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1581 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1582 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" 1583 " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1584 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1585 verifyFormat( 1586 "class A : public B, public C, public D, public E, public F {};"); 1587 verifyFormat("class AAAAAAAAAAAA : public B,\n" 1588 " public C,\n" 1589 " public D,\n" 1590 " public E,\n" 1591 " public F,\n" 1592 " public G {};"); 1593 1594 verifyFormat("class\n" 1595 " ReallyReallyLongClassName {\n" 1596 " int i;\n" 1597 "};", 1598 getLLVMStyleWithColumns(32)); 1599 verifyFormat("struct aaaaaaaaaaaaa : public aaaaaaaaaaaaaaaaaaa< // break\n" 1600 " aaaaaaaaaaaaaaaa> {};"); 1601 verifyFormat("struct aaaaaaaaaaaaaaaaaaaa\n" 1602 " : public aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaa,\n" 1603 " aaaaaaaaaaaaaaaaaaaaaa> {};"); 1604 } 1605 1606 TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { 1607 verifyFormat("class A {\n} a, b;"); 1608 verifyFormat("struct A {\n} a, b;"); 1609 verifyFormat("union A {\n} a;"); 1610 } 1611 1612 TEST_F(FormatTest, FormatsEnum) { 1613 verifyFormat("enum {\n" 1614 " Zero,\n" 1615 " One = 1,\n" 1616 " Two = One + 1,\n" 1617 " Three = (One + Two),\n" 1618 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1619 " Five = (One, Two, Three, Four, 5)\n" 1620 "};"); 1621 verifyGoogleFormat("enum {\n" 1622 " Zero,\n" 1623 " One = 1,\n" 1624 " Two = One + 1,\n" 1625 " Three = (One + Two),\n" 1626 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1627 " Five = (One, Two, Three, Four, 5)\n" 1628 "};"); 1629 verifyFormat("enum Enum {};"); 1630 verifyFormat("enum {};"); 1631 verifyFormat("enum X E {} d;"); 1632 verifyFormat("enum __attribute__((...)) E {} d;"); 1633 verifyFormat("enum __declspec__((...)) E {} d;"); 1634 verifyFormat("enum X f() {\n a();\n return 42;\n}"); 1635 verifyFormat("enum {\n" 1636 " Bar = Foo<int, int>::value\n" 1637 "};"); 1638 } 1639 1640 TEST_F(FormatTest, FormatsEnumsWithErrors) { 1641 verifyFormat("enum Type {\n" 1642 " One = 0;\n" // These semicolons should be commas. 1643 " Two = 1;\n" 1644 "};"); 1645 verifyFormat("namespace n {\n" 1646 "enum Type {\n" 1647 " One,\n" 1648 " Two,\n" // missing }; 1649 " int i;\n" 1650 "}\n" 1651 "void g() {}"); 1652 } 1653 1654 TEST_F(FormatTest, FormatsEnumStruct) { 1655 verifyFormat("enum struct {\n" 1656 " Zero,\n" 1657 " One = 1,\n" 1658 " Two = One + 1,\n" 1659 " Three = (One + Two),\n" 1660 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1661 " Five = (One, Two, Three, Four, 5)\n" 1662 "};"); 1663 verifyFormat("enum struct Enum {};"); 1664 verifyFormat("enum struct {};"); 1665 verifyFormat("enum struct X E {} d;"); 1666 verifyFormat("enum struct __attribute__((...)) E {} d;"); 1667 verifyFormat("enum struct __declspec__((...)) E {} d;"); 1668 verifyFormat("enum struct X f() {\n a();\n return 42;\n}"); 1669 } 1670 1671 TEST_F(FormatTest, FormatsEnumClass) { 1672 verifyFormat("enum class {\n" 1673 " Zero,\n" 1674 " One = 1,\n" 1675 " Two = One + 1,\n" 1676 " Three = (One + Two),\n" 1677 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1678 " Five = (One, Two, Three, Four, 5)\n" 1679 "};"); 1680 verifyFormat("enum class Enum {};"); 1681 verifyFormat("enum class {};"); 1682 verifyFormat("enum class X E {} d;"); 1683 verifyFormat("enum class __attribute__((...)) E {} d;"); 1684 verifyFormat("enum class __declspec__((...)) E {} d;"); 1685 verifyFormat("enum class X f() {\n a();\n return 42;\n}"); 1686 } 1687 1688 TEST_F(FormatTest, FormatsEnumTypes) { 1689 verifyFormat("enum X : int {\n" 1690 " A,\n" 1691 " B\n" 1692 "};"); 1693 verifyFormat("enum X : std::uint32_t {\n" 1694 " A,\n" 1695 " B\n" 1696 "};"); 1697 } 1698 1699 TEST_F(FormatTest, FormatsBitfields) { 1700 verifyFormat("struct Bitfields {\n" 1701 " unsigned sClass : 8;\n" 1702 " unsigned ValueKind : 2;\n" 1703 "};"); 1704 verifyFormat("struct A {\n" 1705 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa : 1,\n" 1706 " bbbbbbbbbbbbbbbbbbbbbbbbb;\n" 1707 "};"); 1708 } 1709 1710 TEST_F(FormatTest, FormatsNamespaces) { 1711 verifyFormat("namespace some_namespace {\n" 1712 "class A {};\n" 1713 "void f() { f(); }\n" 1714 "}"); 1715 verifyFormat("namespace {\n" 1716 "class A {};\n" 1717 "void f() { f(); }\n" 1718 "}"); 1719 verifyFormat("inline namespace X {\n" 1720 "class A {};\n" 1721 "void f() { f(); }\n" 1722 "}"); 1723 verifyFormat("using namespace some_namespace;\n" 1724 "class A {};\n" 1725 "void f() { f(); }"); 1726 1727 // This code is more common than we thought; if we 1728 // layout this correctly the semicolon will go into 1729 // its own line, which is undesireable. 1730 verifyFormat("namespace {};"); 1731 verifyFormat("namespace {\n" 1732 "class A {};\n" 1733 "};"); 1734 1735 verifyFormat("namespace {\n" 1736 "int SomeVariable = 0; // comment\n" 1737 "} // namespace"); 1738 EXPECT_EQ("#ifndef HEADER_GUARD\n" 1739 "#define HEADER_GUARD\n" 1740 "namespace my_namespace {\n" 1741 "int i;\n" 1742 "} // my_namespace\n" 1743 "#endif // HEADER_GUARD", 1744 format("#ifndef HEADER_GUARD\n" 1745 " #define HEADER_GUARD\n" 1746 " namespace my_namespace {\n" 1747 "int i;\n" 1748 "} // my_namespace\n" 1749 "#endif // HEADER_GUARD")); 1750 1751 FormatStyle Style = getLLVMStyle(); 1752 Style.NamespaceIndentation = FormatStyle::NI_All; 1753 EXPECT_EQ("namespace out {\n" 1754 " int i;\n" 1755 " namespace in {\n" 1756 " int i;\n" 1757 " } // namespace\n" 1758 "} // namespace", 1759 format("namespace out {\n" 1760 "int i;\n" 1761 "namespace in {\n" 1762 "int i;\n" 1763 "} // namespace\n" 1764 "} // namespace", 1765 Style)); 1766 1767 Style.NamespaceIndentation = FormatStyle::NI_Inner; 1768 EXPECT_EQ("namespace out {\n" 1769 "int i;\n" 1770 "namespace in {\n" 1771 " int i;\n" 1772 "} // namespace\n" 1773 "} // namespace", 1774 format("namespace out {\n" 1775 "int i;\n" 1776 "namespace in {\n" 1777 "int i;\n" 1778 "} // namespace\n" 1779 "} // namespace", 1780 Style)); 1781 } 1782 1783 TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); } 1784 1785 TEST_F(FormatTest, FormatsInlineASM) { 1786 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); 1787 verifyFormat( 1788 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" 1789 " \"cpuid\\n\\t\"\n" 1790 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" 1791 " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n" 1792 " : \"a\"(value));"); 1793 } 1794 1795 TEST_F(FormatTest, FormatTryCatch) { 1796 // FIXME: Handle try-catch explicitly in the UnwrappedLineParser, then we'll 1797 // also not create single-line-blocks. 1798 verifyFormat("try {\n" 1799 " throw a * b;\n" 1800 "}\n" 1801 "catch (int a) {\n" 1802 " // Do nothing.\n" 1803 "}\n" 1804 "catch (...) {\n" 1805 " exit(42);\n" 1806 "}"); 1807 1808 // Function-level try statements. 1809 verifyFormat("int f() try { return 4; }\n" 1810 "catch (...) {\n" 1811 " return 5;\n" 1812 "}"); 1813 verifyFormat("class A {\n" 1814 " int a;\n" 1815 " A() try : a(0) {}\n" 1816 " catch (...) {\n" 1817 " throw;\n" 1818 " }\n" 1819 "};\n"); 1820 } 1821 1822 TEST_F(FormatTest, FormatObjCTryCatch) { 1823 verifyFormat("@try {\n" 1824 " f();\n" 1825 "}\n" 1826 "@catch (NSException e) {\n" 1827 " @throw;\n" 1828 "}\n" 1829 "@finally {\n" 1830 " exit(42);\n" 1831 "}"); 1832 } 1833 1834 TEST_F(FormatTest, StaticInitializers) { 1835 verifyFormat("static SomeClass SC = { 1, 'a' };"); 1836 1837 verifyFormat( 1838 "static SomeClass WithALoooooooooooooooooooongName = {\n" 1839 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" 1840 "};"); 1841 1842 // Here, everything other than the "}" would fit on a line. 1843 verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n" 1844 " 100000000000000000000000\n" 1845 "};"); 1846 EXPECT_EQ("S s = { a, b };", format("S s = {\n" 1847 " a,\n" 1848 "\n" 1849 " b\n" 1850 "};")); 1851 1852 // FIXME: This would fit into the column limit if we'd fit "{ {" on the first 1853 // line. However, the formatting looks a bit off and this probably doesn't 1854 // happen often in practice. 1855 verifyFormat("static int Variable[1] = {\n" 1856 " { 1000000000000000000000000000000000000 }\n" 1857 "};", 1858 getLLVMStyleWithColumns(40)); 1859 } 1860 1861 TEST_F(FormatTest, DesignatedInitializers) { 1862 verifyFormat("const struct A a = { .a = 1, .b = 2 };"); 1863 verifyFormat("const struct A a = { .aaaaaaaaaa = 1,\n" 1864 " .bbbbbbbbbb = 2,\n" 1865 " .cccccccccc = 3,\n" 1866 " .dddddddddd = 4,\n" 1867 " .eeeeeeeeee = 5 };"); 1868 verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" 1869 " .aaaaaaaaaaaaaaaaaaaaaaaaaaa = 1,\n" 1870 " .bbbbbbbbbbbbbbbbbbbbbbbbbbb = 2,\n" 1871 " .ccccccccccccccccccccccccccc = 3,\n" 1872 " .ddddddddddddddddddddddddddd = 4,\n" 1873 " .eeeeeeeeeeeeeeeeeeeeeeeeeee = 5\n" 1874 "};"); 1875 1876 verifyGoogleFormat("const struct A a = {.a = 1, .b = 2};"); 1877 } 1878 1879 TEST_F(FormatTest, NestedStaticInitializers) { 1880 verifyFormat("static A x = { { {} } };\n"); 1881 verifyFormat("static A x = { { { init1, init2, init3, init4 },\n" 1882 " { init1, init2, init3, init4 } } };"); 1883 1884 verifyFormat("somes Status::global_reps[3] = {\n" 1885 " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n" 1886 " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n" 1887 " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n" 1888 "};"); 1889 verifyGoogleFormat("SomeType Status::global_reps[3] = {\n" 1890 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 1891 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 1892 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};"); 1893 verifyFormat( 1894 "CGRect cg_rect = { { rect.fLeft, rect.fTop },\n" 1895 " { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop" 1896 " } };"); 1897 1898 verifyFormat( 1899 "SomeArrayOfSomeType a = { { { 1, 2, 3 }, { 1, 2, 3 },\n" 1900 " { 111111111111111111111111111111,\n" 1901 " 222222222222222222222222222222,\n" 1902 " 333333333333333333333333333333 },\n" 1903 " { 1, 2, 3 }, { 1, 2, 3 } } };"); 1904 verifyFormat( 1905 "SomeArrayOfSomeType a = { { { 1, 2, 3 } }, { { 1, 2, 3 } },\n" 1906 " { { 111111111111111111111111111111,\n" 1907 " 222222222222222222222222222222,\n" 1908 " 333333333333333333333333333333 } },\n" 1909 " { { 1, 2, 3 } }, { { 1, 2, 3 } } };"); 1910 verifyGoogleFormat( 1911 "SomeArrayOfSomeType a = {\n" 1912 " {{1, 2, 3}}, {{1, 2, 3}},\n" 1913 " {{111111111111111111111111111111, 222222222222222222222222222222,\n" 1914 " 333333333333333333333333333333}},\n" 1915 " {{1, 2, 3}}, {{1, 2, 3}}};"); 1916 1917 verifyFormat( 1918 "struct {\n" 1919 " unsigned bit;\n" 1920 " const char *const name;\n" 1921 "} kBitsToOs[] = { { kOsMac, \"Mac\" },\n" 1922 " { kOsWin, \"Windows\" },\n" 1923 " { kOsLinux, \"Linux\" },\n" 1924 " { kOsCrOS, \"Chrome OS\" } };"); 1925 } 1926 1927 TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { 1928 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 1929 " \\\n" 1930 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); 1931 } 1932 1933 TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { 1934 verifyFormat("virtual void write(ELFWriter *writerrr,\n" 1935 " OwningPtr<FileOutputBuffer> &buffer) = 0;"); 1936 } 1937 1938 TEST_F(FormatTest, BreaksStringLiteralsOnlyInDefine) { 1939 verifyFormat("# 1111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\" 2 3", 1940 getLLVMStyleWithColumns(40)); 1941 verifyFormat("#line 11111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 1942 getLLVMStyleWithColumns(40)); 1943 EXPECT_EQ("#define Q \\\n" 1944 " \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/\" \\\n" 1945 " \"aaaaaaaa.cpp\"", 1946 format("#define Q \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 1947 getLLVMStyleWithColumns(40))); 1948 } 1949 1950 TEST_F(FormatTest, UnderstandsLinePPDirective) { 1951 EXPECT_EQ("# 123 \"A string literal\"", 1952 format(" # 123 \"A string literal\"")); 1953 } 1954 1955 TEST_F(FormatTest, LayoutUnknownPPDirective) { 1956 EXPECT_EQ("#;", format("#;")); 1957 verifyFormat("#\n;\n;\n;"); 1958 } 1959 1960 TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { 1961 EXPECT_EQ("#line 42 \"test\"\n", 1962 format("# \\\n line \\\n 42 \\\n \"test\"\n")); 1963 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", 1964 getLLVMStyleWithColumns(12))); 1965 } 1966 1967 TEST_F(FormatTest, EndOfFileEndsPPDirective) { 1968 EXPECT_EQ("#line 42 \"test\"", 1969 format("# \\\n line \\\n 42 \\\n \"test\"")); 1970 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); 1971 } 1972 1973 TEST_F(FormatTest, DoesntRemoveUnknownTokens) { 1974 verifyFormat("#define A \\x20"); 1975 verifyFormat("#define A \\ x20"); 1976 EXPECT_EQ("#define A \\ x20", format("#define A \\ x20")); 1977 verifyFormat("#define A ''"); 1978 verifyFormat("#define A ''qqq"); 1979 verifyFormat("#define A `qqq"); 1980 verifyFormat("f(\"aaaa, bbbb, \"\\\"ccccc\\\"\");"); 1981 } 1982 1983 TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { 1984 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); 1985 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); 1986 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); 1987 // FIXME: We never break before the macro name. 1988 verifyFormat("#define AA( \\\n B)", getLLVMStyleWithColumns(12)); 1989 1990 verifyFormat("#define A A\n#define A A"); 1991 verifyFormat("#define A(X) A\n#define A A"); 1992 1993 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); 1994 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); 1995 } 1996 1997 TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { 1998 EXPECT_EQ("// somecomment\n" 1999 "#include \"a.h\"\n" 2000 "#define A( \\\n" 2001 " A, B)\n" 2002 "#include \"b.h\"\n" 2003 "// somecomment\n", 2004 format(" // somecomment\n" 2005 " #include \"a.h\"\n" 2006 "#define A(A,\\\n" 2007 " B)\n" 2008 " #include \"b.h\"\n" 2009 " // somecomment\n", 2010 getLLVMStyleWithColumns(13))); 2011 } 2012 2013 TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } 2014 2015 TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { 2016 EXPECT_EQ("#define A \\\n" 2017 " c; \\\n" 2018 " e;\n" 2019 "f;", 2020 format("#define A c; e;\n" 2021 "f;", 2022 getLLVMStyleWithColumns(14))); 2023 } 2024 2025 TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } 2026 2027 TEST_F(FormatTest, AlwaysFormatsEntireMacroDefinitions) { 2028 EXPECT_EQ("int i;\n" 2029 "#define A \\\n" 2030 " int i; \\\n" 2031 " int j\n" 2032 "int k;", 2033 format("int i;\n" 2034 "#define A \\\n" 2035 " int i ; \\\n" 2036 " int j\n" 2037 "int k;", 2038 8, 0, getGoogleStyle())); // 8: position of "#define". 2039 EXPECT_EQ("int i;\n" 2040 "#define A \\\n" 2041 " int i; \\\n" 2042 " int j\n" 2043 "int k;", 2044 format("int i;\n" 2045 "#define A \\\n" 2046 " int i ; \\\n" 2047 " int j\n" 2048 "int k;", 2049 45, 0, getGoogleStyle())); // 45: position of "j". 2050 } 2051 2052 TEST_F(FormatTest, MacroDefinitionInsideStatement) { 2053 EXPECT_EQ("int x,\n" 2054 "#define A\n" 2055 " y;", 2056 format("int x,\n#define A\ny;")); 2057 } 2058 2059 TEST_F(FormatTest, HashInMacroDefinition) { 2060 EXPECT_EQ("#define A(c) L#c", format("#define A(c) L#c", getLLVMStyle())); 2061 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); 2062 verifyFormat("#define A \\\n" 2063 " { \\\n" 2064 " f(#c); \\\n" 2065 " }", 2066 getLLVMStyleWithColumns(11)); 2067 2068 verifyFormat("#define A(X) \\\n" 2069 " void function##X()", 2070 getLLVMStyleWithColumns(22)); 2071 2072 verifyFormat("#define A(a, b, c) \\\n" 2073 " void a##b##c()", 2074 getLLVMStyleWithColumns(22)); 2075 2076 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); 2077 } 2078 2079 TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { 2080 verifyFormat("#define A (1)"); 2081 } 2082 2083 TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { 2084 EXPECT_EQ("#define A b;", format("#define A \\\n" 2085 " \\\n" 2086 " b;", 2087 getLLVMStyleWithColumns(25))); 2088 EXPECT_EQ("#define A \\\n" 2089 " \\\n" 2090 " a; \\\n" 2091 " b;", 2092 format("#define A \\\n" 2093 " \\\n" 2094 " a; \\\n" 2095 " b;", 2096 getLLVMStyleWithColumns(11))); 2097 EXPECT_EQ("#define A \\\n" 2098 " a; \\\n" 2099 " \\\n" 2100 " b;", 2101 format("#define A \\\n" 2102 " a; \\\n" 2103 " \\\n" 2104 " b;", 2105 getLLVMStyleWithColumns(11))); 2106 } 2107 2108 TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { 2109 verifyFormat("#define A :"); 2110 verifyFormat("#define SOMECASES \\\n" 2111 " case 1: \\\n" 2112 " case 2\n", 2113 getLLVMStyleWithColumns(20)); 2114 verifyFormat("#define A template <typename T>"); 2115 verifyFormat("#define STR(x) #x\n" 2116 "f(STR(this_is_a_string_literal{));"); 2117 verifyFormat("#pragma omp threadprivate( \\\n" 2118 " y)), // expected-warning", 2119 getLLVMStyleWithColumns(28)); 2120 } 2121 2122 TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { 2123 verifyFormat("SOME_TYPE_NAME abc;"); // Gated on the newline. 2124 EXPECT_EQ("class A : public QObject {\n" 2125 " Q_OBJECT\n" 2126 "\n" 2127 " A() {}\n" 2128 "};", 2129 format("class A : public QObject {\n" 2130 " Q_OBJECT\n" 2131 "\n" 2132 " A() {\n}\n" 2133 "} ;")); 2134 EXPECT_EQ("SOME_MACRO\n" 2135 "namespace {\n" 2136 "void f();\n" 2137 "}", 2138 format("SOME_MACRO\n" 2139 " namespace {\n" 2140 "void f( );\n" 2141 "}")); 2142 // Only if the identifier contains at least 5 characters. 2143 EXPECT_EQ("HTTP f();", 2144 format("HTTP\nf();")); 2145 EXPECT_EQ("MACRO\nf();", 2146 format("MACRO\nf();")); 2147 // Only if everything is upper case. 2148 EXPECT_EQ("class A : public QObject {\n" 2149 " Q_Object A() {}\n" 2150 "};", 2151 format("class A : public QObject {\n" 2152 " Q_Object\n" 2153 "\n" 2154 " A() {\n}\n" 2155 "} ;")); 2156 } 2157 2158 TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { 2159 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2160 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2161 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2162 "class X {};\n" 2163 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2164 "int *createScopDetectionPass() { return 0; }", 2165 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2166 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2167 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2168 " class X {};\n" 2169 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2170 " int *createScopDetectionPass() { return 0; }")); 2171 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as 2172 // braces, so that inner block is indented one level more. 2173 EXPECT_EQ("int q() {\n" 2174 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2175 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2176 " IPC_END_MESSAGE_MAP()\n" 2177 "}", 2178 format("int q() {\n" 2179 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2180 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2181 " IPC_END_MESSAGE_MAP()\n" 2182 "}")); 2183 2184 // These must not be recognized as macros. 2185 EXPECT_EQ("int q() {\n" 2186 " f(x);\n" 2187 " f(x) {}\n" 2188 " f(x)->g();\n" 2189 " f(x)->*g();\n" 2190 " f(x).g();\n" 2191 " f(x) = x;\n" 2192 " f(x) += x;\n" 2193 " f(x) -= x;\n" 2194 " f(x) *= x;\n" 2195 " f(x) /= x;\n" 2196 " f(x) %= x;\n" 2197 " f(x) &= x;\n" 2198 " f(x) |= x;\n" 2199 " f(x) ^= x;\n" 2200 " f(x) >>= x;\n" 2201 " f(x) <<= x;\n" 2202 " f(x)[y].z();\n" 2203 " LOG(INFO) << x;\n" 2204 " ifstream(x) >> x;\n" 2205 "}\n", 2206 format("int q() {\n" 2207 " f(x)\n;\n" 2208 " f(x)\n {}\n" 2209 " f(x)\n->g();\n" 2210 " f(x)\n->*g();\n" 2211 " f(x)\n.g();\n" 2212 " f(x)\n = x;\n" 2213 " f(x)\n += x;\n" 2214 " f(x)\n -= x;\n" 2215 " f(x)\n *= x;\n" 2216 " f(x)\n /= x;\n" 2217 " f(x)\n %= x;\n" 2218 " f(x)\n &= x;\n" 2219 " f(x)\n |= x;\n" 2220 " f(x)\n ^= x;\n" 2221 " f(x)\n >>= x;\n" 2222 " f(x)\n <<= x;\n" 2223 " f(x)\n[y].z();\n" 2224 " LOG(INFO)\n << x;\n" 2225 " ifstream(x)\n >> x;\n" 2226 "}\n")); 2227 EXPECT_EQ("int q() {\n" 2228 " f(x)\n" 2229 " if (1) {\n" 2230 " }\n" 2231 " f(x)\n" 2232 " while (1) {\n" 2233 " }\n" 2234 " f(x)\n" 2235 " g(x);\n" 2236 " f(x)\n" 2237 " try {\n" 2238 " q();\n" 2239 " }\n" 2240 " catch (...) {\n" 2241 " }\n" 2242 "}\n", 2243 format("int q() {\n" 2244 "f(x)\n" 2245 "if (1) {}\n" 2246 "f(x)\n" 2247 "while (1) {}\n" 2248 "f(x)\n" 2249 "g(x);\n" 2250 "f(x)\n" 2251 "try { q(); } catch (...) {}\n" 2252 "}\n")); 2253 EXPECT_EQ("class A {\n" 2254 " A() : t(0) {}\n" 2255 " A(X x)\n" // FIXME: function-level try blocks are broken. 2256 " try : t(0) {\n" 2257 " }\n" 2258 " catch (...) {\n" 2259 " }\n" 2260 "};", 2261 format("class A {\n" 2262 " A()\n : t(0) {}\n" 2263 " A(X x)\n" 2264 " try : t(0) {} catch (...) {}\n" 2265 "};")); 2266 } 2267 2268 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { 2269 verifyFormat("#define A \\\n" 2270 " f({ \\\n" 2271 " g(); \\\n" 2272 " });", getLLVMStyleWithColumns(11)); 2273 } 2274 2275 TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) { 2276 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}")); 2277 } 2278 2279 TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { 2280 verifyFormat("{\n { a #c; }\n}"); 2281 } 2282 2283 TEST_F(FormatTest, FormatUnbalancedStructuralElements) { 2284 EXPECT_EQ("#define A \\\n { \\\n {\nint i;", 2285 format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); 2286 EXPECT_EQ("#define A \\\n } \\\n }\nint i;", 2287 format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); 2288 } 2289 2290 TEST_F(FormatTest, EscapedNewlineAtStartOfToken) { 2291 EXPECT_EQ( 2292 "#define A \\\n int i; \\\n int j;", 2293 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11))); 2294 EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); 2295 } 2296 2297 TEST_F(FormatTest, NoEscapedNewlineHandlingInBlockComments) { 2298 EXPECT_EQ("/* \\ \\ \\\n*/", format("\\\n/* \\ \\ \\\n*/")); 2299 } 2300 2301 TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { 2302 verifyFormat("#define A \\\n" 2303 " int v( \\\n" 2304 " a); \\\n" 2305 " int i;", 2306 getLLVMStyleWithColumns(11)); 2307 } 2308 2309 TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { 2310 EXPECT_EQ( 2311 "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2312 " \\\n" 2313 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2314 "\n" 2315 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2316 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", 2317 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2318 "\\\n" 2319 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2320 " \n" 2321 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2322 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); 2323 } 2324 2325 TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { 2326 EXPECT_EQ("int\n" 2327 "#define A\n" 2328 " a;", 2329 format("int\n#define A\na;", getGoogleStyle())); 2330 verifyFormat("functionCallTo(\n" 2331 " someOtherFunction(\n" 2332 " withSomeParameters, whichInSequence,\n" 2333 " areLongerThanALine(andAnotherCall,\n" 2334 "#define A B\n" 2335 " withMoreParamters,\n" 2336 " whichStronglyInfluenceTheLayout),\n" 2337 " andMoreParameters),\n" 2338 " trailing);", 2339 getLLVMStyleWithColumns(69)); 2340 verifyFormat("Foo::Foo()\n" 2341 "#ifdef BAR\n" 2342 " : baz(0)\n" 2343 "#endif\n" 2344 "{\n" 2345 "}"); 2346 verifyFormat("void f() {\n" 2347 " if (true)\n" 2348 "#ifdef A\n" 2349 " f(42);\n" 2350 " x();\n" 2351 "#else\n" 2352 " g();\n" 2353 " x();\n" 2354 "#endif\n" 2355 "}"); 2356 verifyFormat("void f(param1, param2,\n" 2357 " param3,\n" 2358 "#ifdef A\n" 2359 " param4(param5,\n" 2360 "#ifdef A1\n" 2361 " param6,\n" 2362 "#ifdef A2\n" 2363 " param7),\n" 2364 "#else\n" 2365 " param8),\n" 2366 " param9,\n" 2367 "#endif\n" 2368 " param10,\n" 2369 "#endif\n" 2370 " param11)\n" 2371 "#else\n" 2372 " param12)\n" 2373 "#endif\n" 2374 "{\n" 2375 " x();\n" 2376 "}", 2377 getLLVMStyleWithColumns(28)); 2378 verifyFormat("#if 1\n" 2379 "int i;"); 2380 verifyFormat( 2381 "#if 1\n" 2382 "#endif\n" 2383 "#if 1\n" 2384 "#else\n" 2385 "#endif\n"); 2386 verifyFormat("DEBUG({\n" 2387 " return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2388 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 2389 "});\n" 2390 "#if a\n" 2391 "#else\n" 2392 "#endif"); 2393 } 2394 2395 TEST_F(FormatTest, FormatsJoinedLinesOnSubsequentRuns) { 2396 FormatStyle SingleLine = getLLVMStyle(); 2397 SingleLine.AllowShortIfStatementsOnASingleLine = true; 2398 verifyFormat( 2399 "#if 0\n" 2400 "#elif 1\n" 2401 "#endif\n" 2402 "void foo() {\n" 2403 " if (test) foo2();\n" 2404 "}", 2405 SingleLine); 2406 } 2407 2408 TEST_F(FormatTest, LayoutBlockInsideParens) { 2409 EXPECT_EQ("functionCall({ int i; });", format(" functionCall ( {int i;} );")); 2410 EXPECT_EQ("functionCall({\n" 2411 " int i;\n" 2412 " int j;\n" 2413 "});", 2414 format(" functionCall ( {int i;int j;} );")); 2415 EXPECT_EQ("functionCall({\n" 2416 " int i;\n" 2417 " int j;\n" 2418 " },\n" 2419 " aaaa, bbbb, cccc);", 2420 format(" functionCall ( {int i;int j;}, aaaa, bbbb, cccc);")); 2421 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2422 format(" functionCall (aaaa, bbbb, {int i;});")); 2423 EXPECT_EQ("functionCall(aaaa, bbbb, {\n" 2424 " int i;\n" 2425 " int j;\n" 2426 "});", 2427 format(" functionCall (aaaa, bbbb, {int i;int j;});")); 2428 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2429 format(" functionCall (aaaa, bbbb, {int i;});")); 2430 verifyFormat( 2431 "Aaa({\n" 2432 " int i; // break\n" 2433 " },\n" 2434 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 2435 " ccccccccccccccccc));"); 2436 verifyFormat("DEBUG({\n" 2437 " if (a)\n" 2438 " f();\n" 2439 "});"); 2440 } 2441 2442 TEST_F(FormatTest, LayoutBlockInsideStatement) { 2443 EXPECT_EQ("SOME_MACRO { int i; }\n" 2444 "int i;", 2445 format(" SOME_MACRO {int i;} int i;")); 2446 } 2447 2448 TEST_F(FormatTest, LayoutNestedBlocks) { 2449 verifyFormat("void AddOsStrings(unsigned bitmask) {\n" 2450 " struct s {\n" 2451 " int i;\n" 2452 " };\n" 2453 " s kBitsToOs[] = { { 10 } };\n" 2454 " for (int i = 0; i < 10; ++i)\n" 2455 " return;\n" 2456 "}"); 2457 verifyFormat("call(parameter, {\n" 2458 " something();\n" 2459 " // Comment using all columns.\n" 2460 " somethingelse();\n" 2461 "});", 2462 getLLVMStyleWithColumns(40)); 2463 EXPECT_EQ("call(parameter, {\n" 2464 " something();\n" 2465 " // Comment too\n" 2466 " // looooooooooong.\n" 2467 " somethingElse();\n" 2468 "});", 2469 format("call(parameter, {\n" 2470 " something();\n" 2471 " // Comment too looooooooooong.\n" 2472 " somethingElse();\n" 2473 "});", 2474 getLLVMStyleWithColumns(29))); 2475 EXPECT_EQ("DEBUG({ int i; });", format("DEBUG({ int i; });")); 2476 EXPECT_EQ("DEBUG({ // comment\n" 2477 " int i;\n" 2478 "});", 2479 format("DEBUG({ // comment\n" 2480 "int i;\n" 2481 "});")); 2482 EXPECT_EQ("DEBUG({\n" 2483 " int i;\n" 2484 "\n" 2485 " // comment\n" 2486 " int j;\n" 2487 "});", 2488 format("DEBUG({\n" 2489 " int i;\n" 2490 "\n" 2491 " // comment\n" 2492 " int j;\n" 2493 "});")); 2494 2495 verifyFormat("DEBUG({\n" 2496 " if (a)\n" 2497 " return;\n" 2498 "});"); 2499 verifyGoogleFormat("DEBUG({\n" 2500 " if (a) return;\n" 2501 "});"); 2502 FormatStyle Style = getGoogleStyle(); 2503 Style.ColumnLimit = 45; 2504 verifyFormat("Debug(aaaaa, {\n" 2505 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2506 " return;\n" 2507 " },\n" 2508 " a);", Style); 2509 2510 EXPECT_EQ("Debug({\n" 2511 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2512 " return;\n" 2513 " },\n" 2514 " a);", 2515 format("Debug({\n" 2516 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2517 " return;\n" 2518 " },\n" 2519 " a);", 2520 50, 1, getLLVMStyle())); 2521 } 2522 2523 TEST_F(FormatTest, IndividualStatementsOfNestedBlocks) { 2524 EXPECT_EQ("DEBUG({\n" 2525 " int i;\n" 2526 " int j;\n" 2527 "});", 2528 format("DEBUG( {\n" 2529 " int i;\n" 2530 " int j;\n" 2531 "} ) ;", 2532 40, 1, getLLVMStyle())); 2533 } 2534 2535 TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { 2536 EXPECT_EQ("{}", format("{}")); 2537 verifyFormat("enum E {};"); 2538 verifyFormat("enum E {}"); 2539 } 2540 2541 //===----------------------------------------------------------------------===// 2542 // Line break tests. 2543 //===----------------------------------------------------------------------===// 2544 2545 TEST_F(FormatTest, PreventConfusingIndents) { 2546 verifyFormat( 2547 "void f() {\n" 2548 " SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" 2549 " parameter, parameter, parameter)),\n" 2550 " SecondLongCall(parameter));\n" 2551 "}"); 2552 verifyFormat( 2553 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2554 " aaaaaaaaaaaaaaaaaaaaaaaa(\n" 2555 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2556 " aaaaaaaaaaaaaaaaaaaaaaaa);"); 2557 verifyFormat( 2558 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2559 " [aaaaaaaaaaaaaaaaaaaaaaaa\n" 2560 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 2561 " [aaaaaaaaaaaaaaaaaaaaaaaa]];"); 2562 verifyFormat( 2563 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 2564 " aaaaaaaaaaaaaaaaaaaaaaaa<\n" 2565 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" 2566 " aaaaaaaaaaaaaaaaaaaaaaaa>;"); 2567 verifyFormat("int a = bbbb && ccc && fffff(\n" 2568 "#define A Just forcing a new line\n" 2569 " ddd);"); 2570 } 2571 2572 TEST_F(FormatTest, LineBreakingInBinaryExpressions) { 2573 verifyFormat( 2574 "bool aaaaaaa =\n" 2575 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" 2576 " bbbbbbbb();"); 2577 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 2578 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" 2579 " ccccccccc == ddddddddddd;"); 2580 2581 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 2582 " aaaaaa) &&\n" 2583 " bbbbbb && cccccc;"); 2584 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 2585 " aaaaaa) >>\n" 2586 " bbbbbb;"); 2587 verifyFormat("Whitespaces.addUntouchableComment(\n" 2588 " SourceMgr.getSpellingColumnNumber(\n" 2589 " TheLine.Last->FormatTok.Tok.getLocation()) -\n" 2590 " 1);"); 2591 2592 verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 2593 " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaaaaaaa\n" 2594 " cccccc) {\n}"); 2595 2596 // If the LHS of a comparison is not a binary expression itself, the 2597 // additional linebreak confuses many people. 2598 verifyFormat( 2599 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2600 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) > 5) {\n" 2601 "}"); 2602 verifyFormat( 2603 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2604 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 2605 "}"); 2606 verifyFormat( 2607 "if (aaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaa(\n" 2608 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 2609 "}"); 2610 // Even explicit parentheses stress the precedence enough to make the 2611 // additional break unnecessary. 2612 verifyFormat( 2613 "if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2614 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 2615 "}"); 2616 // This cases is borderline, but with the indentation it is still readable. 2617 verifyFormat( 2618 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2619 " aaaaaaaaaaaaaaa) > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2620 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 2621 "}", 2622 getLLVMStyleWithColumns(75)); 2623 2624 // If the LHS is a binary expression, we should still use the additional break 2625 // as otherwise the formatting hides the operator precedence. 2626 verifyFormat( 2627 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2628 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 2629 " 5) {\n" 2630 "}"); 2631 2632 FormatStyle OnePerLine = getLLVMStyle(); 2633 OnePerLine.BinPackParameters = false; 2634 verifyFormat( 2635 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 2636 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 2637 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}", 2638 OnePerLine); 2639 } 2640 2641 TEST_F(FormatTest, ExpressionIndentation) { 2642 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2643 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2644 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 2645 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 2646 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" 2647 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" 2648 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 2649 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" 2650 " ccccccccccccccccccccccccccccccccccccccccc;"); 2651 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 2652 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2653 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 2654 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 2655 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2656 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 2657 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 2658 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 2659 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 2660 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 2661 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2662 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 2663 verifyFormat("if () {\n" 2664 "} else if (aaaaa && bbbbb > // break\n" 2665 " ccccc) {\n" 2666 "}"); 2667 2668 // Presence of a trailing comment used to change indentation of b. 2669 verifyFormat("return aaaaaaaaaaaaaaaaaaa +\n" 2670 " b;\n" 2671 "return aaaaaaaaaaaaaaaaaaa +\n" 2672 " b; //", 2673 getLLVMStyleWithColumns(30)); 2674 } 2675 2676 TEST_F(FormatTest, ExpressionIndentationBreakingBeforeOperators) { 2677 // Not sure what the best system is here. Like this, the LHS can be found 2678 // immediately above an operator (everything with the same or a higher 2679 // indent). The RHS is aligned right of the operator and so compasses 2680 // everything until something with the same indent as the operator is found. 2681 // FIXME: Is this a good system? 2682 FormatStyle Style = getLLVMStyle(); 2683 Style.BreakBeforeBinaryOperators = true; 2684 verifyFormat( 2685 "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2686 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2687 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2688 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2689 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 2690 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 2691 " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2692 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2693 " > ccccccccccccccccccccccccccccccccccccccccc;", 2694 Style); 2695 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2696 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2697 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2698 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 2699 Style); 2700 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2701 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2702 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2703 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 2704 Style); 2705 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2706 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2707 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2708 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 2709 Style); 2710 verifyFormat("if () {\n" 2711 "} else if (aaaaa && bbbbb // break\n" 2712 " > ccccc) {\n" 2713 "}", 2714 Style); 2715 2716 // Forced by comments. 2717 verifyFormat( 2718 "unsigned ContentSize =\n" 2719 " sizeof(int16_t) // DWARF ARange version number\n" 2720 " + sizeof(int32_t) // Offset of CU in the .debug_info section\n" 2721 " + sizeof(int8_t) // Pointer Size (in bytes)\n" 2722 " + sizeof(int8_t); // Segment Size (in bytes)"); 2723 } 2724 2725 TEST_F(FormatTest, ConstructorInitializers) { 2726 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); 2727 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", 2728 getLLVMStyleWithColumns(45)); 2729 verifyFormat("Constructor()\n" 2730 " : Inttializer(FitsOnTheLine) {}", 2731 getLLVMStyleWithColumns(44)); 2732 verifyFormat("Constructor()\n" 2733 " : Inttializer(FitsOnTheLine) {}", 2734 getLLVMStyleWithColumns(43)); 2735 2736 verifyFormat( 2737 "SomeClass::Constructor()\n" 2738 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 2739 2740 verifyFormat( 2741 "SomeClass::Constructor()\n" 2742 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 2743 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); 2744 verifyFormat( 2745 "SomeClass::Constructor()\n" 2746 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2747 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 2748 2749 verifyFormat("Constructor()\n" 2750 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2751 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 2752 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2753 " aaaaaaaaaaaaaaaaaaaaaaa() {}"); 2754 2755 verifyFormat("Constructor()\n" 2756 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2757 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 2758 2759 verifyFormat("Constructor(int Parameter = 0)\n" 2760 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" 2761 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); 2762 verifyFormat("Constructor()\n" 2763 " : aaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" 2764 "}", 2765 getLLVMStyleWithColumns(60)); 2766 verifyFormat("Constructor()\n" 2767 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2768 " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}"); 2769 2770 // Here a line could be saved by splitting the second initializer onto two 2771 // lines, but that is not desireable. 2772 verifyFormat("Constructor()\n" 2773 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" 2774 " aaaaaaaaaaa(aaaaaaaaaaa),\n" 2775 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 2776 2777 FormatStyle OnePerLine = getLLVMStyle(); 2778 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 2779 verifyFormat("SomeClass::Constructor()\n" 2780 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 2781 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 2782 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 2783 OnePerLine); 2784 verifyFormat("SomeClass::Constructor()\n" 2785 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" 2786 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 2787 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 2788 OnePerLine); 2789 verifyFormat("MyClass::MyClass(int var)\n" 2790 " : some_var_(var), // 4 space indent\n" 2791 " some_other_var_(var + 1) { // lined up\n" 2792 "}", 2793 OnePerLine); 2794 verifyFormat("Constructor()\n" 2795 " : aaaaa(aaaaaa),\n" 2796 " aaaaa(aaaaaa),\n" 2797 " aaaaa(aaaaaa),\n" 2798 " aaaaa(aaaaaa),\n" 2799 " aaaaa(aaaaaa) {}", 2800 OnePerLine); 2801 verifyFormat("Constructor()\n" 2802 " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" 2803 " aaaaaaaaaaaaaaaaaaaaaa) {}", 2804 OnePerLine); 2805 } 2806 2807 TEST_F(FormatTest, MemoizationTests) { 2808 // This breaks if the memoization lookup does not take \c Indent and 2809 // \c LastSpace into account. 2810 verifyFormat( 2811 "extern CFRunLoopTimerRef\n" 2812 "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" 2813 " CFTimeInterval interval, CFOptionFlags flags,\n" 2814 " CFIndex order, CFRunLoopTimerCallBack callout,\n" 2815 " CFRunLoopTimerContext *context) {}"); 2816 2817 // Deep nesting somewhat works around our memoization. 2818 verifyFormat( 2819 "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 2820 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 2821 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 2822 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 2823 " aaaaa())))))))))))))))))))))))))))))))))))))));", 2824 getLLVMStyleWithColumns(65)); 2825 verifyFormat( 2826 "aaaaa(\n" 2827 " aaaaa,\n" 2828 " aaaaa(\n" 2829 " aaaaa,\n" 2830 " aaaaa(\n" 2831 " aaaaa,\n" 2832 " aaaaa(\n" 2833 " aaaaa,\n" 2834 " aaaaa(\n" 2835 " aaaaa,\n" 2836 " aaaaa(\n" 2837 " aaaaa,\n" 2838 " aaaaa(\n" 2839 " aaaaa,\n" 2840 " aaaaa(\n" 2841 " aaaaa,\n" 2842 " aaaaa(\n" 2843 " aaaaa,\n" 2844 " aaaaa(\n" 2845 " aaaaa,\n" 2846 " aaaaa(\n" 2847 " aaaaa,\n" 2848 " aaaaa(\n" 2849 " aaaaa,\n" 2850 " aaaaa))))))))))));", 2851 getLLVMStyleWithColumns(65)); 2852 verifyFormat( 2853 "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n" 2854 " a),\n" 2855 " a),\n" 2856 " a),\n" 2857 " a),\n" 2858 " a),\n" 2859 " a),\n" 2860 " a),\n" 2861 " a),\n" 2862 " a),\n" 2863 " a),\n" 2864 " a),\n" 2865 " a),\n" 2866 " a),\n" 2867 " a),\n" 2868 " a),\n" 2869 " a),\n" 2870 " a)", 2871 getLLVMStyleWithColumns(65)); 2872 2873 // This test takes VERY long when memoization is broken. 2874 FormatStyle OnePerLine = getLLVMStyle(); 2875 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 2876 OnePerLine.BinPackParameters = false; 2877 std::string input = "Constructor()\n" 2878 " : aaaa(a,\n"; 2879 for (unsigned i = 0, e = 80; i != e; ++i) { 2880 input += " a,\n"; 2881 } 2882 input += " a) {}"; 2883 verifyFormat(input, OnePerLine); 2884 } 2885 2886 TEST_F(FormatTest, BreaksAsHighAsPossible) { 2887 verifyFormat( 2888 "void f() {\n" 2889 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" 2890 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" 2891 " f();\n" 2892 "}"); 2893 verifyFormat("if (Intervals[i].getRange().getFirst() <\n" 2894 " Intervals[i - 1].getRange().getLast()) {\n}"); 2895 } 2896 2897 TEST_F(FormatTest, BreaksFunctionDeclarations) { 2898 // Principially, we break function declarations in a certain order: 2899 // 1) break amongst arguments. 2900 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" 2901 " Cccccccccccccc cccccccccccccc);"); 2902 verifyFormat( 2903 "template <class TemplateIt>\n" 2904 "SomeReturnType SomeFunction(TemplateIt begin, TemplateIt end,\n" 2905 " TemplateIt *stop) {}"); 2906 2907 // 2) break after return type. 2908 verifyFormat( 2909 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2910 " bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);", 2911 getGoogleStyle()); 2912 2913 // 3) break after (. 2914 verifyFormat( 2915 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" 2916 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);", 2917 getGoogleStyle()); 2918 2919 // 4) break before after nested name specifiers. 2920 verifyFormat( 2921 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2922 " SomeClasssssssssssssssssssssssssssssssssssssss::\n" 2923 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);", 2924 getGoogleStyle()); 2925 2926 // However, there are exceptions, if a sufficient amount of lines can be 2927 // saved. 2928 // FIXME: The precise cut-offs wrt. the number of saved lines might need some 2929 // more adjusting. 2930 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 2931 " Cccccccccccccc cccccccccc,\n" 2932 " Cccccccccccccc cccccccccc,\n" 2933 " Cccccccccccccc cccccccccc,\n" 2934 " Cccccccccccccc cccccccccc);"); 2935 verifyFormat( 2936 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2937 " bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 2938 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 2939 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);", 2940 getGoogleStyle()); 2941 verifyFormat( 2942 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 2943 " Cccccccccccccc cccccccccc,\n" 2944 " Cccccccccccccc cccccccccc,\n" 2945 " Cccccccccccccc cccccccccc,\n" 2946 " Cccccccccccccc cccccccccc,\n" 2947 " Cccccccccccccc cccccccccc,\n" 2948 " Cccccccccccccc cccccccccc);"); 2949 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 2950 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 2951 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 2952 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 2953 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); 2954 2955 // Break after multi-line parameters. 2956 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2957 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2958 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 2959 " bbbb bbbb);"); 2960 2961 // Treat overloaded operators like other functions. 2962 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 2963 "operator>(const SomeLoooooooooooooooooooooooooogType &other);"); 2964 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 2965 "operator>>(const SomeLooooooooooooooooooooooooogType &other);"); 2966 verifyGoogleFormat( 2967 "SomeLoooooooooooooooooooooooooooooogType operator<<(\n" 2968 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 2969 } 2970 2971 TEST_F(FormatTest, TrailingReturnType) { 2972 verifyFormat("auto foo() -> int;\n"); 2973 verifyFormat("struct S {\n" 2974 " auto bar() const -> int;\n" 2975 "};"); 2976 verifyFormat("template <size_t Order, typename T>\n" 2977 "auto load_img(const std::string &filename)\n" 2978 " -> alias::tensor<Order, T, mem::tag::cpu> {}"); 2979 2980 // Not trailing return types. 2981 verifyFormat("void f() { auto a = b->c(); }"); 2982 } 2983 2984 TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) { 2985 // Avoid breaking before trailing 'const' or other trailing annotations, if 2986 // they are not function-like. 2987 FormatStyle Style = getGoogleStyle(); 2988 Style.ColumnLimit = 47; 2989 verifyFormat("void\n" 2990 "someLongFunction(int someLongParameter) const {\n}", 2991 getLLVMStyleWithColumns(47)); 2992 verifyFormat("LoooooongReturnType\n" 2993 "someLoooooooongFunction() const {}", 2994 getLLVMStyleWithColumns(47)); 2995 verifyFormat("LoooooongReturnType someLoooooooongFunction()\n" 2996 " const {}", 2997 Style); 2998 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 2999 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE;"); 3000 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3001 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE FINAL;"); 3002 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3003 " aaaaa aaaaaaaaaaaaaaaaaaaa) override final;"); 3004 3005 // Unless this would lead to the first parameter being broken. 3006 verifyFormat("void someLongFunction(int someLongParameter)\n" 3007 " const {}", 3008 getLLVMStyleWithColumns(46)); 3009 verifyFormat("void someLongFunction(int someLongParameter)\n" 3010 " const {}", 3011 Style); 3012 verifyFormat("void SomeFunction(aaaaaaaaaa aaaaaaaaaaaaaaa,\n" 3013 " aaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3014 " LONG_AND_UGLY_ANNOTATION;"); 3015 3016 // Breaking before function-like trailing annotations is fine to keep them 3017 // close to their arguments. 3018 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3019 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3020 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3021 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3022 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3023 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); 3024 3025 verifyFormat( 3026 "void aaaaaaaaaaaaaaaaaa()\n" 3027 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" 3028 " aaaaaaaaaaaaaaaaaaaaaaaaa));"); 3029 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3030 " __attribute__((unused));"); 3031 verifyFormat( 3032 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3033 " GUARDED_BY(aaaaaaaaaaaa);", 3034 getGoogleStyle()); 3035 verifyFormat( 3036 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3037 " GUARDED_BY(aaaaaaaaaaaa);", 3038 getGoogleStyle()); 3039 } 3040 3041 TEST_F(FormatTest, BreaksDesireably) { 3042 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3043 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3044 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); 3045 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3046 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 3047 "}"); 3048 3049 verifyFormat( 3050 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3051 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3052 3053 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3054 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3055 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3056 3057 verifyFormat( 3058 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3059 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3060 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3061 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); 3062 3063 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3064 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3065 3066 verifyFormat( 3067 "void f() {\n" 3068 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" 3069 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3070 "}"); 3071 verifyFormat( 3072 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3073 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3074 verifyFormat( 3075 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3076 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3077 verifyFormat( 3078 "aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3079 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3080 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3081 3082 // Indent consistently indenpendent of call expression. 3083 verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccc(\n" 3084 " dddddddddddddddddddddddddddddd));\n" 3085 "aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3086 " dddddddddddddddddddddddddddddd));"); 3087 3088 // This test case breaks on an incorrect memoization, i.e. an optimization not 3089 // taking into account the StopAt value. 3090 verifyFormat( 3091 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3092 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3093 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3094 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3095 3096 verifyFormat("{\n {\n {\n" 3097 " Annotation.SpaceRequiredBefore =\n" 3098 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" 3099 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" 3100 " }\n }\n}"); 3101 3102 // Break on an outer level if there was a break on an inner level. 3103 EXPECT_EQ("f(g(h(a, // comment\n" 3104 " b, c),\n" 3105 " d, e),\n" 3106 " x, y);", 3107 format("f(g(h(a, // comment\n" 3108 " b, c), d, e), x, y);")); 3109 3110 // Prefer breaking similar line breaks. 3111 verifyFormat( 3112 "const int kTrackingOptions = NSTrackingMouseMoved |\n" 3113 " NSTrackingMouseEnteredAndExited |\n" 3114 " NSTrackingActiveAlways;"); 3115 } 3116 3117 TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { 3118 FormatStyle NoBinPacking = getGoogleStyle(); 3119 NoBinPacking.BinPackParameters = false; 3120 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" 3121 " aaaaaaaaaaaaaaaaaaaa,\n" 3122 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", 3123 NoBinPacking); 3124 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" 3125 " aaaaaaaaaaaaa,\n" 3126 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", 3127 NoBinPacking); 3128 verifyFormat( 3129 "aaaaaaaa(aaaaaaaaaaaaa,\n" 3130 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3131 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3132 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3133 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", 3134 NoBinPacking); 3135 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3136 " .aaaaaaaaaaaaaaaaaa();", 3137 NoBinPacking); 3138 verifyFormat("void f() {\n" 3139 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3140 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);\n" 3141 "}", 3142 NoBinPacking); 3143 3144 verifyFormat( 3145 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3146 " aaaaaaaaaaaa,\n" 3147 " aaaaaaaaaaaa);", 3148 NoBinPacking); 3149 verifyFormat( 3150 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" 3151 " ddddddddddddddddddddddddddddd),\n" 3152 " test);", 3153 NoBinPacking); 3154 3155 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" 3156 " aaaaaaaaaaaaaaaaaaaaaaa,\n" 3157 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;", 3158 NoBinPacking); 3159 verifyFormat("a(\"a\"\n" 3160 " \"a\",\n" 3161 " a);"); 3162 3163 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; 3164 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" 3165 " aaaaaaaaa,\n" 3166 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3167 NoBinPacking); 3168 verifyFormat( 3169 "void f() {\n" 3170 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3171 " .aaaaaaa();\n" 3172 "}", 3173 NoBinPacking); 3174 verifyFormat( 3175 "template <class SomeType, class SomeOtherType>\n" 3176 "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}", 3177 NoBinPacking); 3178 } 3179 3180 TEST_F(FormatTest, AdaptiveOnePerLineFormatting) { 3181 FormatStyle Style = getLLVMStyleWithColumns(15); 3182 Style.ExperimentalAutoDetectBinPacking = true; 3183 EXPECT_EQ("aaa(aaaa,\n" 3184 " aaaa,\n" 3185 " aaaa);\n" 3186 "aaa(aaaa,\n" 3187 " aaaa,\n" 3188 " aaaa);", 3189 format("aaa(aaaa,\n" // one-per-line 3190 " aaaa,\n" 3191 " aaaa );\n" 3192 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3193 Style)); 3194 EXPECT_EQ("aaa(aaaa, aaaa,\n" 3195 " aaaa);\n" 3196 "aaa(aaaa, aaaa,\n" 3197 " aaaa);", 3198 format("aaa(aaaa, aaaa,\n" // bin-packed 3199 " aaaa );\n" 3200 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3201 Style)); 3202 } 3203 3204 TEST_F(FormatTest, FormatsBuilderPattern) { 3205 verifyFormat( 3206 "return llvm::StringSwitch<Reference::Kind>(name)\n" 3207 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" 3208 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME)\n" 3209 " .StartsWith(\".init\", ORDER_INIT)\n" 3210 " .StartsWith(\".fini\", ORDER_FINI)\n" 3211 " .StartsWith(\".hash\", ORDER_HASH)\n" 3212 " .Default(ORDER_TEXT);\n"); 3213 3214 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" 3215 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); 3216 verifyFormat( 3217 "aaaaaaa->aaaaaaa->aaaaaaaaaaaaaaaa(\n" 3218 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3219 " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); 3220 verifyFormat( 3221 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" 3222 " aaaaaaaaaaaaaa);"); 3223 verifyFormat( 3224 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa =\n" 3225 " aaaaaa->aaaaaaaaaaaa()\n" 3226 " ->aaaaaaaaaaaaaaaa(\n" 3227 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3228 " ->aaaaaaaaaaaaaaaaa();"); 3229 verifyGoogleFormat( 3230 "void f() {\n" 3231 " someo->Add((new util::filetools::Handler(dir))\n" 3232 " ->OnEvent1(NewPermanentCallback(\n" 3233 " this, &HandlerHolderClass::EventHandlerCBA))\n" 3234 " ->OnEvent2(NewPermanentCallback(\n" 3235 " this, &HandlerHolderClass::EventHandlerCBB))\n" 3236 " ->OnEvent3(NewPermanentCallback(\n" 3237 " this, &HandlerHolderClass::EventHandlerCBC))\n" 3238 " ->OnEvent5(NewPermanentCallback(\n" 3239 " this, &HandlerHolderClass::EventHandlerCBD))\n" 3240 " ->OnEvent6(NewPermanentCallback(\n" 3241 " this, &HandlerHolderClass::EventHandlerCBE)));\n" 3242 "}"); 3243 3244 verifyFormat( 3245 "aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa();"); 3246 verifyFormat("aaaaaaaaaaaaaaa()\n" 3247 " .aaaaaaaaaaaaaaa()\n" 3248 " .aaaaaaaaaaaaaaa()\n" 3249 " .aaaaaaaaaaaaaaa()\n" 3250 " .aaaaaaaaaaaaaaa();"); 3251 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3252 " .aaaaaaaaaaaaaaa()\n" 3253 " .aaaaaaaaaaaaaaa()\n" 3254 " .aaaaaaaaaaaaaaa();"); 3255 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3256 " .aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3257 " .aaaaaaaaaaaaaaa();"); 3258 verifyFormat("aaaaaaaaaaaaa->aaaaaaaaaaaaaaaaaaaaaaaa()\n" 3259 " ->aaaaaaaaaaaaaae(0)\n" 3260 " ->aaaaaaaaaaaaaaa();"); 3261 3262 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3263 " .aaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3264 " .has<bbbbbbbbbbbbbbbbbbbbb>();"); 3265 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3266 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 3267 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); 3268 3269 // Prefer not to break after empty parentheses. 3270 verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" 3271 " First->LastNewlineOffset);"); 3272 } 3273 3274 TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { 3275 verifyFormat( 3276 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3277 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); 3278 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3279 " ccccccccccccccccccccccccc) {\n}"); 3280 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3281 " ccccccccccccccccccccccccc) {\n}"); 3282 verifyFormat( 3283 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" 3284 " ccccccccccccccccccccccccc) {\n}"); 3285 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" 3286 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" 3287 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" 3288 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 3289 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" 3290 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" 3291 " aaaaaaaaaaaaaaa != aa) {\n}"); 3292 } 3293 3294 TEST_F(FormatTest, BreaksAfterAssignments) { 3295 verifyFormat( 3296 "unsigned Cost =\n" 3297 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" 3298 " SI->getPointerAddressSpaceee());\n"); 3299 verifyFormat( 3300 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" 3301 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); 3302 3303 verifyFormat( 3304 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa().aaaaaaaaa(\n" 3305 " aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); 3306 verifyFormat("unsigned OriginalStartColumn =\n" 3307 " SourceMgr.getSpellingColumnNumber(\n" 3308 " Current.FormatTok.getStartOfNonWhitespace()) -\n" 3309 " 1;"); 3310 } 3311 3312 TEST_F(FormatTest, AlignsAfterAssignments) { 3313 verifyFormat( 3314 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3315 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3316 verifyFormat( 3317 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3318 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3319 verifyFormat( 3320 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3321 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3322 verifyFormat( 3323 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3324 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3325 verifyFormat( 3326 "double LooooooooooooooooooooooooongResult = aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3327 " aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3328 " aaaaaaaaaaaaaaaaaaaaaaaa;"); 3329 } 3330 3331 TEST_F(FormatTest, AlignsAfterReturn) { 3332 verifyFormat( 3333 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3334 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3335 verifyFormat( 3336 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3337 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3338 verifyFormat( 3339 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3340 " aaaaaaaaaaaaaaaaaaaaaa();"); 3341 verifyFormat( 3342 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3343 " aaaaaaaaaaaaaaaaaaaaaa());"); 3344 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3345 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3346 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3347 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" 3348 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3349 verifyFormat("return\n" 3350 " // true if code is one of a or b.\n" 3351 " code == a || code == b;"); 3352 } 3353 3354 TEST_F(FormatTest, BreaksConditionalExpressions) { 3355 verifyFormat( 3356 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3357 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3358 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3359 verifyFormat( 3360 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3361 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3362 verifyFormat( 3363 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" 3364 " : aaaaaaaaaaaaa);"); 3365 verifyFormat( 3366 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3367 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3368 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3369 " aaaaaaaaaaaaa);"); 3370 verifyFormat( 3371 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3372 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3373 " aaaaaaaaaaaaa);"); 3374 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3375 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3376 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3377 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3378 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3379 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3380 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3381 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3382 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3383 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3384 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3385 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3386 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3387 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3388 " ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3389 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3390 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3391 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3392 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3393 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3394 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 3395 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3396 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3397 " : aaaaaaaaaaaaaaaa;"); 3398 verifyFormat( 3399 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3400 " ? aaaaaaaaaaaaaaa\n" 3401 " : aaaaaaaaaaaaaaa;"); 3402 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 3403 " aaaaaaaaa\n" 3404 " ? b\n" 3405 " : c);"); 3406 verifyFormat( 3407 "unsigned Indent =\n" 3408 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n" 3409 " ? IndentForLevel[TheLine.Level]\n" 3410 " : TheLine * 2,\n" 3411 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 3412 getLLVMStyleWithColumns(70)); 3413 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3414 " ? aaaaaaaaaaaaaaa\n" 3415 " : bbbbbbbbbbbbbbb //\n" 3416 " ? ccccccccccccccc\n" 3417 " : ddddddddddddddd;"); 3418 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3419 " ? aaaaaaaaaaaaaaa\n" 3420 " : (bbbbbbbbbbbbbbb //\n" 3421 " ? ccccccccccccccc\n" 3422 " : ddddddddddddddd);"); 3423 3424 FormatStyle NoBinPacking = getLLVMStyle(); 3425 NoBinPacking.BinPackParameters = false; 3426 verifyFormat( 3427 "void f() {\n" 3428 " g(aaa,\n" 3429 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3430 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3431 " ? aaaaaaaaaaaaaaa\n" 3432 " : aaaaaaaaaaaaaaa);\n" 3433 "}", 3434 NoBinPacking); 3435 verifyFormat( 3436 "void f() {\n" 3437 " g(aaa,\n" 3438 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3439 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3440 " ?: aaaaaaaaaaaaaaa);\n" 3441 "}", 3442 NoBinPacking); 3443 } 3444 3445 TEST_F(FormatTest, BreaksConditionalExpressionsAfterOperator) { 3446 FormatStyle Style = getLLVMStyle(); 3447 Style.BreakBeforeTernaryOperators = false; 3448 Style.ColumnLimit = 70; 3449 verifyFormat( 3450 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3451 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3452 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3453 Style); 3454 verifyFormat( 3455 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3456 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3457 Style); 3458 verifyFormat( 3459 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa) :\n" 3460 " aaaaaaaaaaaaa);", 3461 Style); 3462 verifyFormat( 3463 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3464 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3465 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3466 " aaaaaaaaaaaaa);", 3467 Style); 3468 verifyFormat( 3469 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3470 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3471 " aaaaaaaaaaaaa);", 3472 Style); 3473 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3474 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3475 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 3476 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3477 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3478 Style); 3479 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3480 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3481 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3482 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 3483 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3484 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3485 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3486 Style); 3487 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3488 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?:\n" 3489 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3490 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3491 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3492 Style); 3493 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3494 " aaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3495 " aaaaaaaaaaaaaaaaaaaaaaaaaaa;", 3496 Style); 3497 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 3498 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3499 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3500 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 3501 Style); 3502 verifyFormat( 3503 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3504 " aaaaaaaaaaaaaaa :\n" 3505 " aaaaaaaaaaaaaaa;", 3506 Style); 3507 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 3508 " aaaaaaaaa ?\n" 3509 " b :\n" 3510 " c);", 3511 Style); 3512 verifyFormat( 3513 "unsigned Indent =\n" 3514 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0 ?\n" 3515 " IndentForLevel[TheLine.Level] :\n" 3516 " TheLine * 2,\n" 3517 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 3518 Style); 3519 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 3520 " aaaaaaaaaaaaaaa :\n" 3521 " bbbbbbbbbbbbbbb ? //\n" 3522 " ccccccccccccccc :\n" 3523 " ddddddddddddddd;", 3524 Style); 3525 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 3526 " aaaaaaaaaaaaaaa :\n" 3527 " (bbbbbbbbbbbbbbb ? //\n" 3528 " ccccccccccccccc :\n" 3529 " ddddddddddddddd);", 3530 Style); 3531 } 3532 3533 TEST_F(FormatTest, DeclarationsOfMultipleVariables) { 3534 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" 3535 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); 3536 verifyFormat("bool a = true, b = false;"); 3537 3538 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" 3539 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" 3540 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" 3541 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); 3542 verifyFormat( 3543 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 3544 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" 3545 " d = e && f;"); 3546 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" 3547 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); 3548 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 3549 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); 3550 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" 3551 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); 3552 // FIXME: If multiple variables are defined, the "*" needs to move to the new 3553 // line. Also fix indent for breaking after the type, this looks bad. 3554 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*\n" 3555 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" 3556 " *b = bbbbbbbbbbbbbbbbbbb;", 3557 getGoogleStyle()); 3558 3559 // Not ideal, but pointer-with-type does not allow much here. 3560 verifyGoogleFormat( 3561 "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 3562 " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;"); 3563 } 3564 3565 TEST_F(FormatTest, ConditionalExpressionsInBrackets) { 3566 verifyFormat("arr[foo ? bar : baz];"); 3567 verifyFormat("f()[foo ? bar : baz];"); 3568 verifyFormat("(a + b)[foo ? bar : baz];"); 3569 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); 3570 } 3571 3572 TEST_F(FormatTest, AlignsStringLiterals) { 3573 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" 3574 " \"short literal\");"); 3575 verifyFormat( 3576 "looooooooooooooooooooooooongFunction(\n" 3577 " \"short literal\"\n" 3578 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); 3579 verifyFormat("someFunction(\"Always break between multi-line\"\n" 3580 " \" string literals\",\n" 3581 " and, other, parameters);"); 3582 EXPECT_EQ("fun + \"1243\" /* comment */\n" 3583 " \"5678\";", 3584 format("fun + \"1243\" /* comment */\n" 3585 " \"5678\";", 3586 getLLVMStyleWithColumns(28))); 3587 EXPECT_EQ( 3588 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 3589 " \"aaaaaaaaaaaaaaaaaaaaa\"\n" 3590 " \"aaaaaaaaaaaaaaaa\";", 3591 format("aaaaaa =" 3592 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " 3593 "aaaaaaaaaaaaaaaaaaaaa\" " 3594 "\"aaaaaaaaaaaaaaaa\";")); 3595 verifyFormat("a = a + \"a\"\n" 3596 " \"a\"\n" 3597 " \"a\";"); 3598 verifyFormat("f(\"a\", \"b\"\n" 3599 " \"c\");"); 3600 3601 verifyFormat( 3602 "#define LL_FORMAT \"ll\"\n" 3603 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" 3604 " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); 3605 3606 verifyFormat("#define A(X) \\\n" 3607 " \"aaaaa\" #X \"bbbbbb\" \\\n" 3608 " \"ccccc\"", 3609 getLLVMStyleWithColumns(23)); 3610 verifyFormat("#define A \"def\"\n" 3611 "f(\"abc\" A \"ghi\"\n" 3612 " \"jkl\");"); 3613 } 3614 3615 TEST_F(FormatTest, AlwaysBreakBeforeMultilineStrings) { 3616 FormatStyle NoBreak = getLLVMStyle(); 3617 NoBreak.AlwaysBreakBeforeMultilineStrings = false; 3618 FormatStyle Break = getLLVMStyle(); 3619 Break.AlwaysBreakBeforeMultilineStrings = true; 3620 verifyFormat("aaaa = \"bbbb\"\n" 3621 " \"cccc\";", 3622 NoBreak); 3623 verifyFormat("aaaa =\n" 3624 " \"bbbb\"\n" 3625 " \"cccc\";", 3626 Break); 3627 verifyFormat("aaaa(\"bbbb\"\n" 3628 " \"cccc\");", 3629 NoBreak); 3630 verifyFormat("aaaa(\n" 3631 " \"bbbb\"\n" 3632 " \"cccc\");", 3633 Break); 3634 verifyFormat("aaaa(qqq, \"bbbb\"\n" 3635 " \"cccc\");", 3636 NoBreak); 3637 verifyFormat("aaaa(qqq,\n" 3638 " \"bbbb\"\n" 3639 " \"cccc\");", 3640 Break); 3641 3642 // Don't break if there is no column gain. 3643 verifyFormat("f(\"aaaa\"\n" 3644 " \"bbbb\");", 3645 Break); 3646 3647 // Treat literals with escaped newlines like multi-line string literals. 3648 EXPECT_EQ("x = \"a\\\n" 3649 "b\\\n" 3650 "c\";", 3651 format("x = \"a\\\n" 3652 "b\\\n" 3653 "c\";", 3654 NoBreak)); 3655 EXPECT_EQ("x =\n" 3656 " \"a\\\n" 3657 "b\\\n" 3658 "c\";", 3659 format("x = \"a\\\n" 3660 "b\\\n" 3661 "c\";", 3662 Break)); 3663 3664 // Exempt ObjC strings for now. 3665 EXPECT_EQ("NSString *const kString = @\"aaaa\"\n" 3666 " \"bbbb\";", 3667 format("NSString *const kString = @\"aaaa\"\n" 3668 "\"bbbb\";", 3669 Break)); 3670 } 3671 3672 TEST_F(FormatTest, AlignsPipes) { 3673 verifyFormat( 3674 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3675 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3676 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3677 verifyFormat( 3678 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" 3679 " << aaaaaaaaaaaaaaaaaaaa;"); 3680 verifyFormat( 3681 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3682 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3683 verifyFormat( 3684 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" 3685 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" 3686 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); 3687 verifyFormat( 3688 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3689 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3690 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3691 3692 verifyFormat("return out << \"somepacket = {\\n\"\n" 3693 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" 3694 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" 3695 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" 3696 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" 3697 " << \"}\";"); 3698 3699 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 3700 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 3701 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa;"); 3702 verifyFormat( 3703 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" 3704 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" 3705 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" 3706 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" 3707 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); 3708 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" 3709 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 3710 verifyFormat( 3711 "void f() {\n" 3712 " llvm::outs() << \"aaaaaaaaaaaaaaaaaaaa: \"\n" 3713 " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3714 "}"); 3715 3716 // Breaking before the first "<<" is generally not desirable. 3717 verifyFormat( 3718 "llvm::errs()\n" 3719 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3720 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3721 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3722 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 3723 getLLVMStyleWithColumns(70)); 3724 verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaa: \"\n" 3725 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3726 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 3727 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3728 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 3729 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 3730 getLLVMStyleWithColumns(70)); 3731 3732 // But sometimes, breaking before the first "<<" is desirable. 3733 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbb)\n" 3734 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3735 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3736 verifyFormat("SemaRef.Diag(Loc, diag::note_for_range_begin_end)\n" 3737 " << BEF << IsTemplate << Description << E->getType();"); 3738 3739 verifyFormat( 3740 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3741 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 3742 3743 // Incomplete string literal. 3744 EXPECT_EQ("llvm::errs() << \"\n" 3745 " << a;", 3746 format("llvm::errs() << \"\n<<a;")); 3747 } 3748 3749 TEST_F(FormatTest, UnderstandsEquals) { 3750 verifyFormat( 3751 "aaaaaaaaaaaaaaaaa =\n" 3752 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3753 verifyFormat( 3754 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 3755 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 3756 verifyFormat( 3757 "if (a) {\n" 3758 " f();\n" 3759 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 3760 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 3761 "}"); 3762 3763 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 3764 " 100000000 + 10000000) {\n}"); 3765 } 3766 3767 TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { 3768 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 3769 " .looooooooooooooooooooooooooooooooooooooongFunction();"); 3770 3771 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 3772 " ->looooooooooooooooooooooooooooooooooooooongFunction();"); 3773 3774 verifyFormat( 3775 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" 3776 " Parameter2);"); 3777 3778 verifyFormat( 3779 "ShortObject->shortFunction(\n" 3780 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" 3781 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); 3782 3783 verifyFormat("loooooooooooooongFunction(\n" 3784 " LoooooooooooooongObject->looooooooooooooooongFunction());"); 3785 3786 verifyFormat( 3787 "function(LoooooooooooooooooooooooooooooooooooongObject\n" 3788 " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); 3789 3790 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" 3791 " .WillRepeatedly(Return(SomeValue));"); 3792 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)]\n" 3793 " .insert(ccccccccccccccccccccccc);"); 3794 verifyFormat("aaaaa(aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3795 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).aaaaa(aaaaa),\n" 3796 " aaaaaaaaaaaaaaaaaaaaa);"); 3797 verifyFormat("void f() {\n" 3798 " aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3799 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa)->aaaaaaaaa());\n" 3800 "}"); 3801 verifyFormat( 3802 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3803 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3804 " .aaaaaaaaaaaaaaa(aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3805 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3806 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3807 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3808 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3809 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3810 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" 3811 "}"); 3812 3813 // Here, it is not necessary to wrap at "." or "->". 3814 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" 3815 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 3816 verifyFormat( 3817 "aaaaaaaaaaa->aaaaaaaaa(\n" 3818 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3819 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); 3820 3821 verifyFormat( 3822 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3823 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); 3824 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" 3825 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 3826 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" 3827 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 3828 3829 // FIXME: Should we break before .a()? 3830 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3831 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();"); 3832 3833 FormatStyle NoBinPacking = getLLVMStyle(); 3834 NoBinPacking.BinPackParameters = false; 3835 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 3836 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 3837 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" 3838 " aaaaaaaaaaaaaaaaaaa,\n" 3839 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3840 NoBinPacking); 3841 3842 // If there is a subsequent call, change to hanging indentation. 3843 verifyFormat( 3844 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3845 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa))\n" 3846 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 3847 verifyFormat( 3848 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3849 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa));"); 3850 } 3851 3852 TEST_F(FormatTest, WrapsTemplateDeclarations) { 3853 verifyFormat("template <typename T>\n" 3854 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 3855 verifyFormat("template <typename T>\n" 3856 "// T should be one of {A, B}.\n" 3857 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 3858 verifyFormat( 3859 "template <typename T>\n" 3860 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); 3861 verifyFormat("template <typename T>\n" 3862 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" 3863 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); 3864 verifyFormat( 3865 "template <typename T>\n" 3866 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" 3867 " int Paaaaaaaaaaaaaaaaaaaaram2);"); 3868 verifyFormat( 3869 "template <typename T>\n" 3870 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" 3871 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" 3872 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3873 verifyFormat("template <typename T>\n" 3874 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3875 " int aaaaaaaaaaaaaaaaaaaaaa);"); 3876 verifyFormat( 3877 "template <typename T1, typename T2 = char, typename T3 = char,\n" 3878 " typename T4 = char>\n" 3879 "void f();"); 3880 verifyFormat( 3881 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" 3882 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3883 3884 verifyFormat("void f() {\n" 3885 " a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" 3886 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));\n" 3887 "}"); 3888 3889 verifyFormat("template <typename T> class C {};"); 3890 verifyFormat("template <typename T> void f();"); 3891 verifyFormat("template <typename T> void f() {}"); 3892 verifyFormat( 3893 "aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 3894 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3895 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> *aaaa =\n" 3896 " new aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 3897 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3898 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>(\n" 3899 " bbbbbbbbbbbbbbbbbbbbbbbb);", 3900 getLLVMStyleWithColumns(72)); 3901 3902 FormatStyle AlwaysBreak = getLLVMStyle(); 3903 AlwaysBreak.AlwaysBreakTemplateDeclarations = true; 3904 verifyFormat("template <typename T>\nclass C {};", AlwaysBreak); 3905 verifyFormat("template <typename T>\nvoid f();", AlwaysBreak); 3906 verifyFormat("template <typename T>\nvoid f() {}", AlwaysBreak); 3907 verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3908 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" 3909 " ccccccccccccccccccccccccccccccccccccccccccccccc);"); 3910 verifyFormat("template <template <typename> class Fooooooo,\n" 3911 " template <typename> class Baaaaaaar>\n" 3912 "struct C {};", 3913 AlwaysBreak); 3914 verifyFormat("template <typename T> // T can be A, B or C.\n" 3915 "struct C {};", 3916 AlwaysBreak); 3917 } 3918 3919 TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { 3920 verifyFormat( 3921 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3922 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 3923 verifyFormat( 3924 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3925 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3926 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 3927 3928 // FIXME: Should we have the extra indent after the second break? 3929 verifyFormat( 3930 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3931 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3932 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 3933 3934 verifyFormat( 3935 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" 3936 " cccccccccccccccccccccccccccccccccccccccccccccc());"); 3937 3938 // Breaking at nested name specifiers is generally not desirable. 3939 verifyFormat( 3940 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3941 " aaaaaaaaaaaaaaaaaaaaaaa);"); 3942 3943 verifyFormat( 3944 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3945 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3946 " aaaaaaaaaaaaaaaaaaaaa);", 3947 getLLVMStyleWithColumns(74)); 3948 3949 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 3950 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3951 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 3952 } 3953 3954 TEST_F(FormatTest, UnderstandsTemplateParameters) { 3955 verifyFormat("A<int> a;"); 3956 verifyFormat("A<A<A<int> > > a;"); 3957 verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); 3958 verifyFormat("bool x = a < 1 || 2 > a;"); 3959 verifyFormat("bool x = 5 < f<int>();"); 3960 verifyFormat("bool x = f<int>() > 5;"); 3961 verifyFormat("bool x = 5 < a<int>::x;"); 3962 verifyFormat("bool x = a < 4 ? a > 2 : false;"); 3963 verifyFormat("bool x = f() ? a < 2 : a > 2;"); 3964 3965 verifyGoogleFormat("A<A<int>> a;"); 3966 verifyGoogleFormat("A<A<A<int>>> a;"); 3967 verifyGoogleFormat("A<A<A<A<int>>>> a;"); 3968 verifyGoogleFormat("A<A<int> > a;"); 3969 verifyGoogleFormat("A<A<A<int> > > a;"); 3970 verifyGoogleFormat("A<A<A<A<int> > > > a;"); 3971 verifyGoogleFormat("A<::A<int>> a;"); 3972 verifyGoogleFormat("A<::A> a;"); 3973 verifyGoogleFormat("A< ::A> a;"); 3974 verifyGoogleFormat("A< ::A<int> > a;"); 3975 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); 3976 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); 3977 EXPECT_EQ("A<::A<int>> a;", format("A< ::A<int>> a;", getGoogleStyle())); 3978 EXPECT_EQ("A<::A<int>> a;", format("A<::A<int> > a;", getGoogleStyle())); 3979 3980 verifyFormat("test >> a >> b;"); 3981 verifyFormat("test << a >> b;"); 3982 3983 verifyFormat("f<int>();"); 3984 verifyFormat("template <typename T> void f() {}"); 3985 3986 // Not template parameters. 3987 verifyFormat("return a < b && c > d;"); 3988 verifyFormat("void f() {\n" 3989 " while (a < b && c > d) {\n" 3990 " }\n" 3991 "}"); 3992 verifyFormat("template <typename... Types>\n" 3993 "typename enable_if<0 < sizeof...(Types)>::type Foo() {}"); 3994 3995 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3996 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);", 3997 getLLVMStyleWithColumns(60)); 3998 } 3999 4000 TEST_F(FormatTest, UnderstandsBinaryOperators) { 4001 verifyFormat("COMPARE(a, ==, b);"); 4002 } 4003 4004 TEST_F(FormatTest, UnderstandsPointersToMembers) { 4005 verifyFormat("int A::*x;"); 4006 verifyFormat("int (S::*func)(void *);"); 4007 verifyFormat("void f() { int (S::*func)(void *); }"); 4008 verifyFormat("typedef bool *(Class::*Member)() const;"); 4009 verifyFormat("void f() {\n" 4010 " (a->*f)();\n" 4011 " a->*x;\n" 4012 " (a.*f)();\n" 4013 " ((*a).*f)();\n" 4014 " a.*x;\n" 4015 "}"); 4016 verifyFormat("void f() {\n" 4017 " (a->*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 4018 " aaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);\n" 4019 "}"); 4020 FormatStyle Style = getLLVMStyle(); 4021 Style.PointerBindsToType = true; 4022 verifyFormat("typedef bool* (Class::*Member)() const;", Style); 4023 } 4024 4025 TEST_F(FormatTest, UnderstandsUnaryOperators) { 4026 verifyFormat("int a = -2;"); 4027 verifyFormat("f(-1, -2, -3);"); 4028 verifyFormat("a[-1] = 5;"); 4029 verifyFormat("int a = 5 + -2;"); 4030 verifyFormat("if (i == -1) {\n}"); 4031 verifyFormat("if (i != -1) {\n}"); 4032 verifyFormat("if (i > -1) {\n}"); 4033 verifyFormat("if (i < -1) {\n}"); 4034 verifyFormat("++(a->f());"); 4035 verifyFormat("--(a->f());"); 4036 verifyFormat("(a->f())++;"); 4037 verifyFormat("a[42]++;"); 4038 verifyFormat("if (!(a->f())) {\n}"); 4039 4040 verifyFormat("a-- > b;"); 4041 verifyFormat("b ? -a : c;"); 4042 verifyFormat("n * sizeof char16;"); 4043 verifyFormat("n * alignof char16;", getGoogleStyle()); 4044 verifyFormat("sizeof(char);"); 4045 verifyFormat("alignof(char);", getGoogleStyle()); 4046 4047 verifyFormat("return -1;"); 4048 verifyFormat("switch (a) {\n" 4049 "case -1:\n" 4050 " break;\n" 4051 "}"); 4052 verifyFormat("#define X -1"); 4053 verifyFormat("#define X -kConstant"); 4054 4055 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { -5, +3 };"); 4056 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { +5, -3 };"); 4057 4058 verifyFormat("int a = /* confusing comment */ -1;"); 4059 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. 4060 verifyFormat("int a = i /* confusing comment */++;"); 4061 } 4062 4063 TEST_F(FormatTest, IndentsRelativeToUnaryOperators) { 4064 verifyFormat("if (!aaaaaaaaaa( // break\n" 4065 " aaaaa)) {\n" 4066 "}"); 4067 verifyFormat("aaaaaaaaaa(!aaaaaaaaaa( // break\n" 4068 " aaaaa));"); 4069 4070 // Only indent relative to unary operators if the expression is nested. 4071 verifyFormat("*aaa = aaaaaaa( // break\n" 4072 " bbbbbb);"); 4073 } 4074 4075 TEST_F(FormatTest, UnderstandsOverloadedOperators) { 4076 verifyFormat("bool operator<();"); 4077 verifyFormat("bool operator>();"); 4078 verifyFormat("bool operator=();"); 4079 verifyFormat("bool operator==();"); 4080 verifyFormat("bool operator!=();"); 4081 verifyFormat("int operator+();"); 4082 verifyFormat("int operator++();"); 4083 verifyFormat("bool operator();"); 4084 verifyFormat("bool operator()();"); 4085 verifyFormat("bool operator[]();"); 4086 verifyFormat("operator bool();"); 4087 verifyFormat("operator int();"); 4088 verifyFormat("operator void *();"); 4089 verifyFormat("operator SomeType<int>();"); 4090 verifyFormat("operator SomeType<int, int>();"); 4091 verifyFormat("operator SomeType<SomeType<int> >();"); 4092 verifyFormat("void *operator new(std::size_t size);"); 4093 verifyFormat("void *operator new[](std::size_t size);"); 4094 verifyFormat("void operator delete(void *ptr);"); 4095 verifyFormat("void operator delete[](void *ptr);"); 4096 verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n" 4097 "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);"); 4098 4099 verifyFormat( 4100 "ostream &operator<<(ostream &OutputStream,\n" 4101 " SomeReallyLongType WithSomeReallyLongValue);"); 4102 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" 4103 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" 4104 " return left.group < right.group;\n" 4105 "}"); 4106 verifyFormat("SomeType &operator=(const SomeType &S);"); 4107 4108 verifyGoogleFormat("operator void*();"); 4109 verifyGoogleFormat("operator SomeType<SomeType<int>>();"); 4110 verifyGoogleFormat("operator ::A();"); 4111 4112 verifyFormat("using A::operator+;"); 4113 } 4114 4115 TEST_F(FormatTest, UnderstandsNewAndDelete) { 4116 verifyFormat("void f() {\n" 4117 " A *a = new A;\n" 4118 " A *a = new (placement) A;\n" 4119 " delete a;\n" 4120 " delete (A *)a;\n" 4121 "}"); 4122 } 4123 4124 TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { 4125 verifyFormat("int *f(int *a) {}"); 4126 verifyFormat("int main(int argc, char **argv) {}"); 4127 verifyFormat("Test::Test(int b) : a(b * b) {}"); 4128 verifyIndependentOfContext("f(a, *a);"); 4129 verifyFormat("void g() { f(*a); }"); 4130 verifyIndependentOfContext("int a = b * 10;"); 4131 verifyIndependentOfContext("int a = 10 * b;"); 4132 verifyIndependentOfContext("int a = b * c;"); 4133 verifyIndependentOfContext("int a += b * c;"); 4134 verifyIndependentOfContext("int a -= b * c;"); 4135 verifyIndependentOfContext("int a *= b * c;"); 4136 verifyIndependentOfContext("int a /= b * c;"); 4137 verifyIndependentOfContext("int a = *b;"); 4138 verifyIndependentOfContext("int a = *b * c;"); 4139 verifyIndependentOfContext("int a = b * *c;"); 4140 verifyIndependentOfContext("return 10 * b;"); 4141 verifyIndependentOfContext("return *b * *c;"); 4142 verifyIndependentOfContext("return a & ~b;"); 4143 verifyIndependentOfContext("f(b ? *c : *d);"); 4144 verifyIndependentOfContext("int a = b ? *c : *d;"); 4145 verifyIndependentOfContext("*b = a;"); 4146 verifyIndependentOfContext("a * ~b;"); 4147 verifyIndependentOfContext("a * !b;"); 4148 verifyIndependentOfContext("a * +b;"); 4149 verifyIndependentOfContext("a * -b;"); 4150 verifyIndependentOfContext("a * ++b;"); 4151 verifyIndependentOfContext("a * --b;"); 4152 verifyIndependentOfContext("a[4] * b;"); 4153 verifyIndependentOfContext("a[a * a] = 1;"); 4154 verifyIndependentOfContext("f() * b;"); 4155 verifyIndependentOfContext("a * [self dostuff];"); 4156 verifyIndependentOfContext("int x = a * (a + b);"); 4157 verifyIndependentOfContext("(a *)(a + b);"); 4158 verifyIndependentOfContext("int *pa = (int *)&a;"); 4159 verifyIndependentOfContext("return sizeof(int **);"); 4160 verifyIndependentOfContext("return sizeof(int ******);"); 4161 verifyIndependentOfContext("return (int **&)a;"); 4162 verifyIndependentOfContext("f((*PointerToArray)[10]);"); 4163 verifyFormat("void f(Type (*parameter)[10]) {}"); 4164 verifyGoogleFormat("return sizeof(int**);"); 4165 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); 4166 verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); 4167 verifyFormat("auto a = [](int **&, int ***) {};"); 4168 verifyFormat("auto PointerBinding = [](const char *S) {};"); 4169 verifyFormat("typedef typeof(int(int, int)) *MyFunc;"); 4170 4171 verifyIndependentOfContext("InvalidRegions[*R] = 0;"); 4172 4173 verifyIndependentOfContext("A<int *> a;"); 4174 verifyIndependentOfContext("A<int **> a;"); 4175 verifyIndependentOfContext("A<int *, int *> a;"); 4176 verifyIndependentOfContext( 4177 "const char *const p = reinterpret_cast<const char *const>(q);"); 4178 verifyIndependentOfContext("A<int **, int **> a;"); 4179 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); 4180 verifyFormat("for (char **a = b; *a; ++a) {\n}"); 4181 verifyFormat("for (; a && b;) {\n}"); 4182 4183 verifyFormat( 4184 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4185 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4186 4187 verifyGoogleFormat("int main(int argc, char** argv) {}"); 4188 verifyGoogleFormat("A<int*> a;"); 4189 verifyGoogleFormat("A<int**> a;"); 4190 verifyGoogleFormat("A<int*, int*> a;"); 4191 verifyGoogleFormat("A<int**, int**> a;"); 4192 verifyGoogleFormat("f(b ? *c : *d);"); 4193 verifyGoogleFormat("int a = b ? *c : *d;"); 4194 verifyGoogleFormat("Type* t = **x;"); 4195 verifyGoogleFormat("Type* t = *++*x;"); 4196 verifyGoogleFormat("*++*x;"); 4197 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); 4198 verifyGoogleFormat("Type* t = x++ * y;"); 4199 verifyGoogleFormat( 4200 "const char* const p = reinterpret_cast<const char* const>(q);"); 4201 4202 verifyIndependentOfContext("a = *(x + y);"); 4203 verifyIndependentOfContext("a = &(x + y);"); 4204 verifyIndependentOfContext("*(x + y).call();"); 4205 verifyIndependentOfContext("&(x + y)->call();"); 4206 verifyFormat("void f() { &(*I).first; }"); 4207 4208 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); 4209 verifyFormat( 4210 "int *MyValues = {\n" 4211 " *A, // Operator detection might be confused by the '{'\n" 4212 " *BB // Operator detection might be confused by previous comment\n" 4213 "};"); 4214 4215 verifyIndependentOfContext("if (int *a = &b)"); 4216 verifyIndependentOfContext("if (int &a = *b)"); 4217 verifyIndependentOfContext("if (a & b[i])"); 4218 verifyIndependentOfContext("if (a::b::c::d & b[i])"); 4219 verifyIndependentOfContext("if (*b[i])"); 4220 verifyIndependentOfContext("if (int *a = (&b))"); 4221 verifyIndependentOfContext("while (int *a = &b)"); 4222 verifyIndependentOfContext("size = sizeof *a;"); 4223 verifyFormat("void f() {\n" 4224 " for (const int &v : Values) {\n" 4225 " }\n" 4226 "}"); 4227 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); 4228 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); 4229 verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); 4230 4231 verifyFormat("#define A (!a * b)"); 4232 verifyFormat("#define MACRO \\\n" 4233 " int *i = a * b; \\\n" 4234 " void f(a *b);", 4235 getLLVMStyleWithColumns(19)); 4236 4237 verifyIndependentOfContext("A = new SomeType *[Length];"); 4238 verifyIndependentOfContext("A = new SomeType *[Length]();"); 4239 verifyIndependentOfContext("T **t = new T *;"); 4240 verifyIndependentOfContext("T **t = new T *();"); 4241 verifyGoogleFormat("A = new SomeType* [Length]();"); 4242 verifyGoogleFormat("A = new SomeType* [Length];"); 4243 verifyGoogleFormat("T** t = new T*;"); 4244 verifyGoogleFormat("T** t = new T*();"); 4245 4246 FormatStyle PointerLeft = getLLVMStyle(); 4247 PointerLeft.PointerBindsToType = true; 4248 verifyFormat("delete *x;", PointerLeft); 4249 } 4250 4251 TEST_F(FormatTest, UnderstandsAttributes) { 4252 verifyFormat("SomeType s __attribute__((unused)) (InitValue);"); 4253 } 4254 4255 TEST_F(FormatTest, UnderstandsEllipsis) { 4256 verifyFormat("int printf(const char *fmt, ...);"); 4257 verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); 4258 verifyFormat("template <class... Ts> void Foo(Ts *... ts) {}"); 4259 4260 FormatStyle PointersLeft = getLLVMStyle(); 4261 PointersLeft.PointerBindsToType = true; 4262 verifyFormat("template <class... Ts> void Foo(Ts*... ts) {}", PointersLeft); 4263 } 4264 4265 TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { 4266 EXPECT_EQ("int *a;\n" 4267 "int *a;\n" 4268 "int *a;", 4269 format("int *a;\n" 4270 "int* a;\n" 4271 "int *a;", 4272 getGoogleStyle())); 4273 EXPECT_EQ("int* a;\n" 4274 "int* a;\n" 4275 "int* a;", 4276 format("int* a;\n" 4277 "int* a;\n" 4278 "int *a;", 4279 getGoogleStyle())); 4280 EXPECT_EQ("int *a;\n" 4281 "int *a;\n" 4282 "int *a;", 4283 format("int *a;\n" 4284 "int * a;\n" 4285 "int * a;", 4286 getGoogleStyle())); 4287 } 4288 4289 TEST_F(FormatTest, UnderstandsRvalueReferences) { 4290 verifyFormat("int f(int &&a) {}"); 4291 verifyFormat("int f(int a, char &&b) {}"); 4292 verifyFormat("void f() { int &&a = b; }"); 4293 verifyGoogleFormat("int f(int a, char&& b) {}"); 4294 verifyGoogleFormat("void f() { int&& a = b; }"); 4295 4296 verifyIndependentOfContext("A<int &&> a;"); 4297 verifyIndependentOfContext("A<int &&, int &&> a;"); 4298 verifyGoogleFormat("A<int&&> a;"); 4299 verifyGoogleFormat("A<int&&, int&&> a;"); 4300 4301 // Not rvalue references: 4302 verifyFormat("template <bool B, bool C> class A {\n" 4303 " static_assert(B && C, \"Something is wrong\");\n" 4304 "};"); 4305 verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))"); 4306 verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))"); 4307 } 4308 4309 TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { 4310 verifyFormat("void f() {\n" 4311 " x[aaaaaaaaa -\n" 4312 " b] = 23;\n" 4313 "}", 4314 getLLVMStyleWithColumns(15)); 4315 } 4316 4317 TEST_F(FormatTest, FormatsCasts) { 4318 verifyFormat("Type *A = static_cast<Type *>(P);"); 4319 verifyFormat("Type *A = (Type *)P;"); 4320 verifyFormat("Type *A = (vector<Type *, int *>)P;"); 4321 verifyFormat("int a = (int)(2.0f);"); 4322 verifyFormat("int a = (int)2.0f;"); 4323 verifyFormat("x[(int32)y];"); 4324 verifyFormat("x = (int32)y;"); 4325 verifyFormat("#define AA(X) sizeof(((X *)NULL)->a)"); 4326 verifyFormat("int a = (int)*b;"); 4327 verifyFormat("int a = (int)2.0f;"); 4328 verifyFormat("int a = (int)~0;"); 4329 verifyFormat("int a = (int)++a;"); 4330 verifyFormat("int a = (int)sizeof(int);"); 4331 verifyFormat("int a = (int)+2;"); 4332 verifyFormat("my_int a = (my_int)2.0f;"); 4333 verifyFormat("my_int a = (my_int)sizeof(int);"); 4334 verifyFormat("return (my_int)aaa;"); 4335 verifyFormat("#define x ((int)-1)"); 4336 verifyFormat("#define p(q) ((int *)&q)"); 4337 4338 // FIXME: Without type knowledge, this can still fall apart miserably. 4339 verifyFormat("void f() { my_int a = (my_int) * b; }"); 4340 verifyFormat("void f() { return P ? (my_int) * P : (my_int)0; }"); 4341 verifyFormat("my_int a = (my_int) ~0;"); 4342 verifyFormat("my_int a = (my_int)++ a;"); 4343 verifyFormat("my_int a = (my_int) + 2;"); 4344 4345 // Don't break after a cast's 4346 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4347 " (aaaaaaaaaaaaaaaaaaaaaaaaaa *)(aaaaaaaaaaaaaaaaaaaaaa +\n" 4348 " bbbbbbbbbbbbbbbbbbbbbb);"); 4349 4350 // These are not casts. 4351 verifyFormat("void f(int *) {}"); 4352 verifyFormat("f(foo)->b;"); 4353 verifyFormat("f(foo).b;"); 4354 verifyFormat("f(foo)(b);"); 4355 verifyFormat("f(foo)[b];"); 4356 verifyFormat("[](foo) { return 4; }(bar);"); 4357 verifyFormat("(*funptr)(foo)[4];"); 4358 verifyFormat("funptrs[4](foo)[4];"); 4359 verifyFormat("void f(int *);"); 4360 verifyFormat("void f(int *) = 0;"); 4361 verifyFormat("void f(SmallVector<int>) {}"); 4362 verifyFormat("void f(SmallVector<int>);"); 4363 verifyFormat("void f(SmallVector<int>) = 0;"); 4364 verifyFormat("void f(int i = (kValue) * kMask) {}"); 4365 verifyFormat("void f(int i = (kA * kB) & kMask) {}"); 4366 verifyFormat("int a = sizeof(int) * b;"); 4367 verifyFormat("int a = alignof(int) * b;", getGoogleStyle()); 4368 verifyFormat("template <> void f<int>(int i) SOME_ANNOTATION;"); 4369 verifyFormat("f(\"%\" SOME_MACRO(ll) \"d\");"); 4370 verifyFormat("aaaaa &operator=(const aaaaa &) LLVM_DELETED_FUNCTION;"); 4371 4372 // These are not casts, but at some point were confused with casts. 4373 verifyFormat("virtual void foo(int *) override;"); 4374 verifyFormat("virtual void foo(char &) const;"); 4375 verifyFormat("virtual void foo(int *a, char *) const;"); 4376 verifyFormat("int a = sizeof(int *) + b;"); 4377 verifyFormat("int a = alignof(int *) + b;", getGoogleStyle()); 4378 4379 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *foo = (aaaaaaaaaaaaaaaaa *)\n" 4380 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4381 // FIXME: The indentation here is not ideal. 4382 verifyFormat( 4383 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4384 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = (*cccccccccccccccc)\n" 4385 " [dddddddddddddddddddddddddddddddddddddddddddddddddddddddd];"); 4386 } 4387 4388 TEST_F(FormatTest, FormatsFunctionTypes) { 4389 verifyFormat("A<bool()> a;"); 4390 verifyFormat("A<SomeType()> a;"); 4391 verifyFormat("A<void (*)(int, std::string)> a;"); 4392 verifyFormat("A<void *(int)>;"); 4393 verifyFormat("void *(*a)(int *, SomeType *);"); 4394 verifyFormat("int (*func)(void *);"); 4395 verifyFormat("void f() { int (*func)(void *); }"); 4396 verifyFormat("template <class CallbackClass>\n" 4397 "using MyCallback = void (CallbackClass::*)(SomeObject *Data);"); 4398 4399 verifyGoogleFormat("A<void*(int*, SomeType*)>;"); 4400 verifyGoogleFormat("void* (*a)(int);"); 4401 verifyGoogleFormat( 4402 "template <class CallbackClass>\n" 4403 "using MyCallback = void (CallbackClass::*)(SomeObject* Data);"); 4404 4405 // Other constructs can look somewhat like function types: 4406 verifyFormat("A<sizeof(*x)> a;"); 4407 verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)"); 4408 verifyFormat("some_var = function(*some_pointer_var)[0];"); 4409 verifyFormat("void f() { function(*some_pointer_var)[0] = 10; }"); 4410 } 4411 4412 TEST_F(FormatTest, BreaksLongDeclarations) { 4413 verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" 4414 " AnotherNameForTheLongType;", 4415 getGoogleStyle()); 4416 verifyFormat("typedef LongTemplateType<aaaaaaaaaaaaaaaaaaa()>\n" 4417 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4418 getGoogleStyle()); 4419 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 4420 " LoooooooooooooooooooooooooooooooooooooooongVariable;", 4421 getGoogleStyle()); 4422 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType const\n" 4423 " LoooooooooooooooooooooooooooooooooooooooongVariable;", 4424 getGoogleStyle()); 4425 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 4426 " LoooooooooooooooooooooooooooooooongFunctionDeclaration();", 4427 getGoogleStyle()); 4428 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 4429 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 4430 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 4431 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 4432 4433 // FIXME: Without the comment, this breaks after "(". 4434 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" 4435 " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();", 4436 getGoogleStyle()); 4437 4438 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" 4439 " int LoooooooooooooooooooongParam2) {}"); 4440 verifyFormat( 4441 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" 4442 " SourceLocation L, IdentifierIn *II,\n" 4443 " Type *T) {}"); 4444 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" 4445 "ReallyReallyLongFunctionName(\n" 4446 " const std::string &SomeParameter,\n" 4447 " const SomeType<string, SomeOtherTemplateParameter> &\n" 4448 " ReallyReallyLongParameterName,\n" 4449 " const SomeType<string, SomeOtherTemplateParameter> &\n" 4450 " AnotherLongParameterName) {}"); 4451 verifyFormat("template <typename A>\n" 4452 "SomeLoooooooooooooooooooooongType<\n" 4453 " typename some_namespace::SomeOtherType<A>::Type>\n" 4454 "Function() {}"); 4455 4456 verifyGoogleFormat( 4457 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" 4458 " aaaaaaaaaaaaaaaaaaaaaaa;"); 4459 verifyGoogleFormat( 4460 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" 4461 " SourceLocation L) {}"); 4462 verifyGoogleFormat( 4463 "some_namespace::LongReturnType\n" 4464 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" 4465 " int first_long_parameter, int second_parameter) {}"); 4466 4467 verifyGoogleFormat("template <typename T>\n" 4468 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" 4469 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); 4470 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4471 " int aaaaaaaaaaaaaaaaaaaaaaa);"); 4472 } 4473 4474 TEST_F(FormatTest, FormatsArrays) { 4475 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 4476 " [bbbbbbbbbbbbbbbbbbbbbbbbb] = c;"); 4477 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4478 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 4479 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4480 " [a][bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = cccccccc;"); 4481 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4482 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 4483 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 4484 verifyFormat( 4485 "llvm::outs() << \"aaaaaaaaaaaa: \"\n" 4486 " << (*aaaaaaaiaaaaaaa)[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 4487 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); 4488 } 4489 4490 TEST_F(FormatTest, LineStartsWithSpecialCharacter) { 4491 verifyFormat("(a)->b();"); 4492 verifyFormat("--a;"); 4493 } 4494 4495 TEST_F(FormatTest, HandlesIncludeDirectives) { 4496 verifyFormat("#include <string>\n" 4497 "#include <a/b/c.h>\n" 4498 "#include \"a/b/string\"\n" 4499 "#include \"string.h\"\n" 4500 "#include \"string.h\"\n" 4501 "#include <a-a>\n" 4502 "#include < path with space >\n" 4503 "#include \"abc.h\" // this is included for ABC\n" 4504 "#include \"some long include\" // with a comment\n" 4505 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"", 4506 getLLVMStyleWithColumns(35)); 4507 EXPECT_EQ("#include \"a.h\"", format("#include \"a.h\"")); 4508 EXPECT_EQ("#include <a>", format("#include<a>")); 4509 4510 verifyFormat("#import <string>"); 4511 verifyFormat("#import <a/b/c.h>"); 4512 verifyFormat("#import \"a/b/string\""); 4513 verifyFormat("#import \"string.h\""); 4514 verifyFormat("#import \"string.h\""); 4515 verifyFormat("#if __has_include(<strstream>)\n" 4516 "#include <strstream>\n" 4517 "#endif"); 4518 } 4519 4520 //===----------------------------------------------------------------------===// 4521 // Error recovery tests. 4522 //===----------------------------------------------------------------------===// 4523 4524 TEST_F(FormatTest, IncompleteParameterLists) { 4525 FormatStyle NoBinPacking = getLLVMStyle(); 4526 NoBinPacking.BinPackParameters = false; 4527 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" 4528 " double *min_x,\n" 4529 " double *max_x,\n" 4530 " double *min_y,\n" 4531 " double *max_y,\n" 4532 " double *min_z,\n" 4533 " double *max_z, ) {}", 4534 NoBinPacking); 4535 } 4536 4537 TEST_F(FormatTest, IncorrectCodeTrailingStuff) { 4538 verifyFormat("void f() { return; }\n42"); 4539 verifyFormat("void f() {\n" 4540 " if (0)\n" 4541 " return;\n" 4542 "}\n" 4543 "42"); 4544 verifyFormat("void f() { return }\n42"); 4545 verifyFormat("void f() {\n" 4546 " if (0)\n" 4547 " return\n" 4548 "}\n" 4549 "42"); 4550 } 4551 4552 TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { 4553 EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); 4554 EXPECT_EQ("void f() {\n" 4555 " if (a)\n" 4556 " return\n" 4557 "}", 4558 format("void f ( ) { if ( a ) return }")); 4559 EXPECT_EQ("namespace N {\n" 4560 "void f()\n" 4561 "}", 4562 format("namespace N { void f() }")); 4563 EXPECT_EQ("namespace N {\n" 4564 "void f() {}\n" 4565 "void g()\n" 4566 "}", 4567 format("namespace N { void f( ) { } void g( ) }")); 4568 } 4569 4570 TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { 4571 verifyFormat("int aaaaaaaa =\n" 4572 " // Overlylongcomment\n" 4573 " b;", 4574 getLLVMStyleWithColumns(20)); 4575 verifyFormat("function(\n" 4576 " ShortArgument,\n" 4577 " LoooooooooooongArgument);\n", 4578 getLLVMStyleWithColumns(20)); 4579 } 4580 4581 TEST_F(FormatTest, IncorrectAccessSpecifier) { 4582 verifyFormat("public:"); 4583 verifyFormat("class A {\n" 4584 "public\n" 4585 " void f() {}\n" 4586 "};"); 4587 verifyFormat("public\n" 4588 "int qwerty;"); 4589 verifyFormat("public\n" 4590 "B {}"); 4591 verifyFormat("public\n" 4592 "{}"); 4593 verifyFormat("public\n" 4594 "B { int x; }"); 4595 } 4596 4597 TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { 4598 verifyFormat("{"); 4599 verifyFormat("#})"); 4600 } 4601 4602 TEST_F(FormatTest, IncorrectCodeDoNoWhile) { 4603 verifyFormat("do {\n}"); 4604 verifyFormat("do {\n}\n" 4605 "f();"); 4606 verifyFormat("do {\n}\n" 4607 "wheeee(fun);"); 4608 verifyFormat("do {\n" 4609 " f();\n" 4610 "}"); 4611 } 4612 4613 TEST_F(FormatTest, IncorrectCodeMissingParens) { 4614 verifyFormat("if {\n foo;\n foo();\n}"); 4615 verifyFormat("switch {\n foo;\n foo();\n}"); 4616 verifyFormat("for {\n foo;\n foo();\n}"); 4617 verifyFormat("while {\n foo;\n foo();\n}"); 4618 verifyFormat("do {\n foo;\n foo();\n} while;"); 4619 } 4620 4621 TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { 4622 verifyFormat("namespace {\n" 4623 "class Foo { Foo (\n" 4624 "};\n" 4625 "} // comment"); 4626 } 4627 4628 TEST_F(FormatTest, IncorrectCodeErrorDetection) { 4629 EXPECT_EQ("{\n {}\n", format("{\n{\n}\n")); 4630 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); 4631 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); 4632 EXPECT_EQ("{\n {}\n}\n}\n", format("{\n {\n }\n }\n}\n")); 4633 4634 EXPECT_EQ("{\n" 4635 " {\n" 4636 " breakme(\n" 4637 " qwe);\n" 4638 " }\n", 4639 format("{\n" 4640 " {\n" 4641 " breakme(qwe);\n" 4642 "}\n", 4643 getLLVMStyleWithColumns(10))); 4644 } 4645 4646 TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { 4647 verifyFormat("int x = {\n" 4648 " avariable,\n" 4649 " b(alongervariable)\n" 4650 "};", 4651 getLLVMStyleWithColumns(25)); 4652 } 4653 4654 TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { 4655 verifyFormat("return (a)(b) { 1, 2, 3 };"); 4656 } 4657 4658 TEST_F(FormatTest, LayoutCxx11ConstructorBraceInitializers) { 4659 verifyFormat("vector<int> x{ 1, 2, 3, 4 };"); 4660 verifyFormat("vector<T> x{ {}, {}, {}, {} };"); 4661 verifyFormat("f({ 1, 2 });"); 4662 verifyFormat("auto v = Foo{ 1 };"); 4663 verifyFormat("f({ 1, 2 }, { { 2, 3 }, { 4, 5 } }, c, { d });"); 4664 verifyFormat("Class::Class : member{ 1, 2, 3 } {}"); 4665 verifyFormat("new vector<int>{ 1, 2, 3 };"); 4666 verifyFormat("new int[3]{ 1, 2, 3 };"); 4667 verifyFormat("return { arg1, arg2 };"); 4668 verifyFormat("return { arg1, SomeType{ parameter } };"); 4669 verifyFormat("new T{ arg1, arg2 };"); 4670 verifyFormat("f(MyMap[{ composite, key }]);"); 4671 verifyFormat("class Class {\n" 4672 " T member = { arg1, arg2 };\n" 4673 "};"); 4674 verifyFormat( 4675 "foo = aaaaaaaaaaa ? vector<int>{ aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4676 " aaaaaaaaaaaaaaaaaaaa, aaaaa }\n" 4677 " : vector<int>{ bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 4678 " bbbbbbbbbbbbbbbbbbbb, bbbbb };"); 4679 verifyFormat("DoSomethingWithVector({} /* No data */);"); 4680 verifyFormat("DoSomethingWithVector({ {} /* No data */ }, { { 1, 2 } });"); 4681 verifyFormat( 4682 "someFunction(OtherParam, BracedList{\n" 4683 " // comment 1 (Forcing interesting break)\n" 4684 " param1, param2,\n" 4685 " // comment 2\n" 4686 " param3, param4\n" 4687 " });"); 4688 verifyFormat( 4689 "std::this_thread::sleep_for(\n" 4690 " std::chrono::nanoseconds{ std::chrono::seconds{ 1 } } / 5);"); 4691 4692 FormatStyle NoSpaces = getLLVMStyle(); 4693 NoSpaces.Cpp11BracedListStyle = true; 4694 verifyFormat("vector<int> x{1, 2, 3, 4};", NoSpaces); 4695 verifyFormat("vector<T> x{{}, {}, {}, {}};", NoSpaces); 4696 verifyFormat("f({1, 2});", NoSpaces); 4697 verifyFormat("auto v = Foo{-1};", NoSpaces); 4698 verifyFormat("f({1, 2}, {{2, 3}, {4, 5}}, c, {d});", NoSpaces); 4699 verifyFormat("Class::Class : member{1, 2, 3} {}", NoSpaces); 4700 verifyFormat("new vector<int>{1, 2, 3};", NoSpaces); 4701 verifyFormat("new int[3]{1, 2, 3};", NoSpaces); 4702 verifyFormat("return {arg1, arg2};", NoSpaces); 4703 verifyFormat("return {arg1, SomeType{parameter}};", NoSpaces); 4704 verifyFormat("new T{arg1, arg2};", NoSpaces); 4705 verifyFormat("f(MyMap[{composite, key}]);", NoSpaces); 4706 verifyFormat("class Class {\n" 4707 " T member = {arg1, arg2};\n" 4708 "};", 4709 NoSpaces); 4710 verifyFormat("Constructor::Constructor()\n" 4711 " : some_value{ //\n" 4712 " aaaaaaa //\n" 4713 " } {}", 4714 NoSpaces); 4715 } 4716 4717 TEST_F(FormatTest, FormatsBracedListsInColumnLayout) { 4718 verifyFormat("vector<int> x = { 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4719 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4720 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4721 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4722 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4723 " 1, 22, 333, 4444, 55555, 666666, 7777777 };"); 4724 verifyFormat("vector<int> x = { 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4725 " // line comment\n" 4726 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4727 " 1, 22, 333, 4444, 55555,\n" 4728 " // line comment\n" 4729 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4730 " 1, 22, 333, 4444, 55555, 666666, 7777777 };"); 4731 verifyFormat( 4732 "vector<int> x = { 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4733 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 4734 " 1, 22, 333, 4444, 55555, 666666, // comment\n" 4735 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 4736 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 4737 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 4738 " 7777777 };"); 4739 verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" 4740 " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" 4741 " X86::R8, X86::R9, X86::R10, X86::R11, 0\n" 4742 "};"); 4743 verifyFormat("vector<int> x = { 1, 1, 1, 1,\n" 4744 " 1, 1, 1, 1 };", 4745 getLLVMStyleWithColumns(39)); 4746 verifyFormat("vector<int> x = { 1, 1, 1, 1,\n" 4747 " 1, 1, 1, 1 };", 4748 getLLVMStyleWithColumns(38)); 4749 verifyFormat("vector<int> aaaaaaaaaaaaaaaaaaaaaa = {\n" 4750 " 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n" 4751 "};", 4752 getLLVMStyleWithColumns(40)); 4753 4754 // Trailing commas. 4755 verifyFormat("vector<int> x = { 1, 1, 1, 1,\n" 4756 " 1, 1, 1, 1, };", 4757 getLLVMStyleWithColumns(39)); 4758 verifyFormat("vector<int> x = { 1, 1, 1, 1,\n" 4759 " 1, 1, 1, 1, //\n" 4760 "};", 4761 getLLVMStyleWithColumns(39)); 4762 verifyFormat("vector<int> x = { 1, 1, 1, 1,\n" 4763 " 1, 1, 1, 1,\n" 4764 " /**/ /**/ };", 4765 getLLVMStyleWithColumns(39)); 4766 verifyFormat("return { { aaaaaaaaaaaaaaaaaaaaa },\n" 4767 " { aaaaaaaaaaaaaaaaaaa },\n" 4768 " { aaaaaaaaaaaaaaaaaaaaa },\n" 4769 " { aaaaaaaaaaaaaaaaa } };", 4770 getLLVMStyleWithColumns(60)); 4771 } 4772 4773 TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { 4774 verifyFormat("void f() { return 42; }"); 4775 verifyFormat("void f() {\n" 4776 " // Comment\n" 4777 "}"); 4778 verifyFormat("{\n" 4779 "#error {\n" 4780 " int a;\n" 4781 "}"); 4782 verifyFormat("{\n" 4783 " int a;\n" 4784 "#error {\n" 4785 "}"); 4786 verifyFormat("void f() {} // comment"); 4787 verifyFormat("void f() { int a; } // comment"); 4788 verifyFormat("void f() {\n" 4789 "} // comment", 4790 getLLVMStyleWithColumns(15)); 4791 4792 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); 4793 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); 4794 4795 verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); 4796 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); 4797 } 4798 4799 TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { 4800 // Elaborate type variable declarations. 4801 verifyFormat("struct foo a = { bar };\nint n;"); 4802 verifyFormat("class foo a = { bar };\nint n;"); 4803 verifyFormat("union foo a = { bar };\nint n;"); 4804 4805 // Elaborate types inside function definitions. 4806 verifyFormat("struct foo f() {}\nint n;"); 4807 verifyFormat("class foo f() {}\nint n;"); 4808 verifyFormat("union foo f() {}\nint n;"); 4809 4810 // Templates. 4811 verifyFormat("template <class X> void f() {}\nint n;"); 4812 verifyFormat("template <struct X> void f() {}\nint n;"); 4813 verifyFormat("template <union X> void f() {}\nint n;"); 4814 4815 // Actual definitions... 4816 verifyFormat("struct {\n} n;"); 4817 verifyFormat( 4818 "template <template <class T, class Y>, class Z> class X {\n} n;"); 4819 verifyFormat("union Z {\n int n;\n} x;"); 4820 verifyFormat("class MACRO Z {\n} n;"); 4821 verifyFormat("class MACRO(X) Z {\n} n;"); 4822 verifyFormat("class __attribute__(X) Z {\n} n;"); 4823 verifyFormat("class __declspec(X) Z {\n} n;"); 4824 verifyFormat("class A##B##C {\n} n;"); 4825 verifyFormat("class alignas(16) Z {\n} n;"); 4826 4827 // Redefinition from nested context: 4828 verifyFormat("class A::B::C {\n} n;"); 4829 4830 // Template definitions. 4831 verifyFormat( 4832 "template <typename F>\n" 4833 "Matcher(const Matcher<F> &Other,\n" 4834 " typename enable_if_c<is_base_of<F, T>::value &&\n" 4835 " !is_same<F, T>::value>::type * = 0)\n" 4836 " : Implementation(new ImplicitCastMatcher<F>(Other)) {}"); 4837 4838 // FIXME: This is still incorrectly handled at the formatter side. 4839 verifyFormat("template <> struct X < 15, i<3 && 42 < 50 && 33 < 28> {};"); 4840 4841 // FIXME: 4842 // This now gets parsed incorrectly as class definition. 4843 // verifyFormat("class A<int> f() {\n}\nint n;"); 4844 4845 // Elaborate types where incorrectly parsing the structural element would 4846 // break the indent. 4847 verifyFormat("if (true)\n" 4848 " class X x;\n" 4849 "else\n" 4850 " f();\n"); 4851 4852 // This is simply incomplete. Formatting is not important, but must not crash. 4853 verifyFormat("class A:"); 4854 } 4855 4856 TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { 4857 EXPECT_EQ("#error Leave all white!!!!! space* alone!\n", 4858 format("#error Leave all white!!!!! space* alone!\n")); 4859 EXPECT_EQ( 4860 "#warning Leave all white!!!!! space* alone!\n", 4861 format("#warning Leave all white!!!!! space* alone!\n")); 4862 EXPECT_EQ("#error 1", format(" # error 1")); 4863 EXPECT_EQ("#warning 1", format(" # warning 1")); 4864 } 4865 4866 TEST_F(FormatTest, FormatHashIfExpressions) { 4867 // FIXME: Come up with a better indentation for #elif. 4868 verifyFormat( 4869 "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" 4870 " defined(BBBBBBBB)\n" 4871 "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" 4872 " defined(BBBBBBBB)\n" 4873 "#endif", 4874 getLLVMStyleWithColumns(65)); 4875 } 4876 4877 TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { 4878 FormatStyle AllowsMergedIf = getGoogleStyle(); 4879 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 4880 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); 4881 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); 4882 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); 4883 EXPECT_EQ("if (true) return 42;", 4884 format("if (true)\nreturn 42;", AllowsMergedIf)); 4885 FormatStyle ShortMergedIf = AllowsMergedIf; 4886 ShortMergedIf.ColumnLimit = 25; 4887 verifyFormat("#define A \\\n" 4888 " if (true) return 42;", 4889 ShortMergedIf); 4890 verifyFormat("#define A \\\n" 4891 " f(); \\\n" 4892 " if (true)\n" 4893 "#define B", 4894 ShortMergedIf); 4895 verifyFormat("#define A \\\n" 4896 " f(); \\\n" 4897 " if (true)\n" 4898 "g();", 4899 ShortMergedIf); 4900 verifyFormat("{\n" 4901 "#ifdef A\n" 4902 " // Comment\n" 4903 " if (true) continue;\n" 4904 "#endif\n" 4905 " // Comment\n" 4906 " if (true) continue;\n" 4907 "}", 4908 ShortMergedIf); 4909 } 4910 4911 TEST_F(FormatTest, BlockCommentsInControlLoops) { 4912 verifyFormat("if (0) /* a comment in a strange place */ {\n" 4913 " f();\n" 4914 "}"); 4915 verifyFormat("if (0) /* a comment in a strange place */ {\n" 4916 " f();\n" 4917 "} /* another comment */ else /* comment #3 */ {\n" 4918 " g();\n" 4919 "}"); 4920 verifyFormat("while (0) /* a comment in a strange place */ {\n" 4921 " f();\n" 4922 "}"); 4923 verifyFormat("for (;;) /* a comment in a strange place */ {\n" 4924 " f();\n" 4925 "}"); 4926 verifyFormat("do /* a comment in a strange place */ {\n" 4927 " f();\n" 4928 "} /* another comment */ while (0);"); 4929 } 4930 4931 TEST_F(FormatTest, BlockComments) { 4932 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", 4933 format("/* *//* */ /* */\n/* *//* */ /* */")); 4934 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); 4935 EXPECT_EQ("#define A /*123*/ \\\n" 4936 " b\n" 4937 "/* */\n" 4938 "someCall(\n" 4939 " parameter);", 4940 format("#define A /*123*/ b\n" 4941 "/* */\n" 4942 "someCall(parameter);", 4943 getLLVMStyleWithColumns(15))); 4944 4945 EXPECT_EQ("#define A\n" 4946 "/* */ someCall(\n" 4947 " parameter);", 4948 format("#define A\n" 4949 "/* */someCall(parameter);", 4950 getLLVMStyleWithColumns(15))); 4951 EXPECT_EQ("/*\n**\n*/", format("/*\n**\n*/")); 4952 EXPECT_EQ("/*\n" 4953 "*\n" 4954 " * aaaaaa\n" 4955 "*aaaaaa\n" 4956 "*/", 4957 format("/*\n" 4958 "*\n" 4959 " * aaaaaa aaaaaa\n" 4960 "*/", 4961 getLLVMStyleWithColumns(10))); 4962 EXPECT_EQ("/*\n" 4963 "**\n" 4964 "* aaaaaa\n" 4965 "*aaaaaa\n" 4966 "*/", 4967 format("/*\n" 4968 "**\n" 4969 "* aaaaaa aaaaaa\n" 4970 "*/", 4971 getLLVMStyleWithColumns(10))); 4972 4973 FormatStyle NoBinPacking = getLLVMStyle(); 4974 NoBinPacking.BinPackParameters = false; 4975 EXPECT_EQ("someFunction(1, /* comment 1 */\n" 4976 " 2, /* comment 2 */\n" 4977 " 3, /* comment 3 */\n" 4978 " aaaa,\n" 4979 " bbbb);", 4980 format("someFunction (1, /* comment 1 */\n" 4981 " 2, /* comment 2 */ \n" 4982 " 3, /* comment 3 */\n" 4983 "aaaa, bbbb );", 4984 NoBinPacking)); 4985 verifyFormat( 4986 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 4987 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4988 EXPECT_EQ( 4989 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 4990 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 4991 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", 4992 format( 4993 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 4994 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 4995 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); 4996 EXPECT_EQ( 4997 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 4998 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 4999 "int cccccccccccccccccccccccccccccc; /* comment */\n", 5000 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 5001 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 5002 "int cccccccccccccccccccccccccccccc; /* comment */\n")); 5003 5004 verifyFormat("void f(int * /* unused */) {}"); 5005 5006 EXPECT_EQ("/*\n" 5007 " **\n" 5008 " */", 5009 format("/*\n" 5010 " **\n" 5011 " */")); 5012 EXPECT_EQ("/*\n" 5013 " *q\n" 5014 " */", 5015 format("/*\n" 5016 " *q\n" 5017 " */")); 5018 EXPECT_EQ("/*\n" 5019 " * q\n" 5020 " */", 5021 format("/*\n" 5022 " * q\n" 5023 " */")); 5024 EXPECT_EQ("/*\n" 5025 " **/", 5026 format("/*\n" 5027 " **/")); 5028 EXPECT_EQ("/*\n" 5029 " ***/", 5030 format("/*\n" 5031 " ***/")); 5032 } 5033 5034 TEST_F(FormatTest, BlockCommentsInMacros) { 5035 EXPECT_EQ("#define A \\\n" 5036 " { \\\n" 5037 " /* one line */ \\\n" 5038 " someCall();", 5039 format("#define A { \\\n" 5040 " /* one line */ \\\n" 5041 " someCall();", 5042 getLLVMStyleWithColumns(20))); 5043 EXPECT_EQ("#define A \\\n" 5044 " { \\\n" 5045 " /* previous */ \\\n" 5046 " /* one line */ \\\n" 5047 " someCall();", 5048 format("#define A { \\\n" 5049 " /* previous */ \\\n" 5050 " /* one line */ \\\n" 5051 " someCall();", 5052 getLLVMStyleWithColumns(20))); 5053 } 5054 5055 TEST_F(FormatTest, BlockCommentsAtEndOfLine) { 5056 EXPECT_EQ("a = {\n" 5057 " 1111 /* */\n" 5058 "};", 5059 format("a = {1111 /* */\n" 5060 "};", 5061 getLLVMStyleWithColumns(15))); 5062 EXPECT_EQ("a = {\n" 5063 " 1111 /* */\n" 5064 "};", 5065 format("a = {1111 /* */\n" 5066 "};", 5067 getLLVMStyleWithColumns(15))); 5068 5069 // FIXME: The formatting is still wrong here. 5070 EXPECT_EQ("a = {\n" 5071 " 1111 /* a\n" 5072 " */\n" 5073 "};", 5074 format("a = {1111 /* a */\n" 5075 "};", 5076 getLLVMStyleWithColumns(15))); 5077 } 5078 5079 TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) { 5080 // FIXME: This is not what we want... 5081 verifyFormat("{\n" 5082 "// a" 5083 "// b"); 5084 } 5085 5086 TEST_F(FormatTest, FormatStarDependingOnContext) { 5087 verifyFormat("void f(int *a);"); 5088 verifyFormat("void f() { f(fint * b); }"); 5089 verifyFormat("class A {\n void f(int *a);\n};"); 5090 verifyFormat("class A {\n int *a;\n};"); 5091 verifyFormat("namespace a {\n" 5092 "namespace b {\n" 5093 "class A {\n" 5094 " void f() {}\n" 5095 " int *a;\n" 5096 "};\n" 5097 "}\n" 5098 "}"); 5099 } 5100 5101 TEST_F(FormatTest, SpecialTokensAtEndOfLine) { 5102 verifyFormat("while"); 5103 verifyFormat("operator"); 5104 } 5105 5106 //===----------------------------------------------------------------------===// 5107 // Objective-C tests. 5108 //===----------------------------------------------------------------------===// 5109 5110 TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { 5111 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); 5112 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", 5113 format("-(NSUInteger)indexOfObject:(id)anObject;")); 5114 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); 5115 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); 5116 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", 5117 format("-(NSInteger)Method3:(id)anObject;")); 5118 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", 5119 format("-(NSInteger)Method4:(id)anObject;")); 5120 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", 5121 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); 5122 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", 5123 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); 5124 EXPECT_EQ( 5125 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;", 5126 format( 5127 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;")); 5128 5129 // Very long objectiveC method declaration. 5130 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" 5131 " inRange:(NSRange)range\n" 5132 " outRange:(NSRange)out_range\n" 5133 " outRange1:(NSRange)out_range1\n" 5134 " outRange2:(NSRange)out_range2\n" 5135 " outRange3:(NSRange)out_range3\n" 5136 " outRange4:(NSRange)out_range4\n" 5137 " outRange5:(NSRange)out_range5\n" 5138 " outRange6:(NSRange)out_range6\n" 5139 " outRange7:(NSRange)out_range7\n" 5140 " outRange8:(NSRange)out_range8\n" 5141 " outRange9:(NSRange)out_range9;"); 5142 5143 verifyFormat("- (int)sum:(vector<int>)numbers;"); 5144 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); 5145 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC 5146 // protocol lists (but not for template classes): 5147 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); 5148 5149 verifyFormat("- (int (*)())foo:(int (*)())f;"); 5150 verifyGoogleFormat("- (int (*)())foo:(int (*)())foo;"); 5151 5152 // If there's no return type (very rare in practice!), LLVM and Google style 5153 // agree. 5154 verifyFormat("- foo;"); 5155 verifyFormat("- foo:(int)f;"); 5156 verifyGoogleFormat("- foo:(int)foo;"); 5157 } 5158 5159 TEST_F(FormatTest, FormatObjCBlocks) { 5160 verifyFormat("int (^Block)(int, int);"); 5161 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)"); 5162 } 5163 5164 TEST_F(FormatTest, FormatObjCInterface) { 5165 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" 5166 "@public\n" 5167 " int field1;\n" 5168 "@protected\n" 5169 " int field2;\n" 5170 "@private\n" 5171 " int field3;\n" 5172 "@package\n" 5173 " int field4;\n" 5174 "}\n" 5175 "+ (id)init;\n" 5176 "@end"); 5177 5178 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n" 5179 " @public\n" 5180 " int field1;\n" 5181 " @protected\n" 5182 " int field2;\n" 5183 " @private\n" 5184 " int field3;\n" 5185 " @package\n" 5186 " int field4;\n" 5187 "}\n" 5188 "+ (id)init;\n" 5189 "@end"); 5190 5191 verifyFormat("@interface /* wait for it */ Foo\n" 5192 "+ (id)init;\n" 5193 "// Look, a comment!\n" 5194 "- (int)answerWith:(int)i;\n" 5195 "@end"); 5196 5197 verifyFormat("@interface Foo\n" 5198 "@end\n" 5199 "@interface Bar\n" 5200 "@end"); 5201 5202 verifyFormat("@interface Foo : Bar\n" 5203 "+ (id)init;\n" 5204 "@end"); 5205 5206 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" 5207 "+ (id)init;\n" 5208 "@end"); 5209 5210 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n" 5211 "+ (id)init;\n" 5212 "@end"); 5213 5214 verifyFormat("@interface Foo (HackStuff)\n" 5215 "+ (id)init;\n" 5216 "@end"); 5217 5218 verifyFormat("@interface Foo ()\n" 5219 "+ (id)init;\n" 5220 "@end"); 5221 5222 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" 5223 "+ (id)init;\n" 5224 "@end"); 5225 5226 verifyGoogleFormat("@interface Foo (HackStuff)<MyProtocol>\n" 5227 "+ (id)init;\n" 5228 "@end"); 5229 5230 verifyFormat("@interface Foo {\n" 5231 " int _i;\n" 5232 "}\n" 5233 "+ (id)init;\n" 5234 "@end"); 5235 5236 verifyFormat("@interface Foo : Bar {\n" 5237 " int _i;\n" 5238 "}\n" 5239 "+ (id)init;\n" 5240 "@end"); 5241 5242 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" 5243 " int _i;\n" 5244 "}\n" 5245 "+ (id)init;\n" 5246 "@end"); 5247 5248 verifyFormat("@interface Foo (HackStuff) {\n" 5249 " int _i;\n" 5250 "}\n" 5251 "+ (id)init;\n" 5252 "@end"); 5253 5254 verifyFormat("@interface Foo () {\n" 5255 " int _i;\n" 5256 "}\n" 5257 "+ (id)init;\n" 5258 "@end"); 5259 5260 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" 5261 " int _i;\n" 5262 "}\n" 5263 "+ (id)init;\n" 5264 "@end"); 5265 } 5266 5267 TEST_F(FormatTest, FormatObjCImplementation) { 5268 verifyFormat("@implementation Foo : NSObject {\n" 5269 "@public\n" 5270 " int field1;\n" 5271 "@protected\n" 5272 " int field2;\n" 5273 "@private\n" 5274 " int field3;\n" 5275 "@package\n" 5276 " int field4;\n" 5277 "}\n" 5278 "+ (id)init {\n}\n" 5279 "@end"); 5280 5281 verifyGoogleFormat("@implementation Foo : NSObject {\n" 5282 " @public\n" 5283 " int field1;\n" 5284 " @protected\n" 5285 " int field2;\n" 5286 " @private\n" 5287 " int field3;\n" 5288 " @package\n" 5289 " int field4;\n" 5290 "}\n" 5291 "+ (id)init {\n}\n" 5292 "@end"); 5293 5294 verifyFormat("@implementation Foo\n" 5295 "+ (id)init {\n" 5296 " if (true)\n" 5297 " return nil;\n" 5298 "}\n" 5299 "// Look, a comment!\n" 5300 "- (int)answerWith:(int)i {\n" 5301 " return i;\n" 5302 "}\n" 5303 "+ (int)answerWith:(int)i {\n" 5304 " return i;\n" 5305 "}\n" 5306 "@end"); 5307 5308 verifyFormat("@implementation Foo\n" 5309 "@end\n" 5310 "@implementation Bar\n" 5311 "@end"); 5312 5313 verifyFormat("@implementation Foo : Bar\n" 5314 "+ (id)init {\n}\n" 5315 "- (void)foo {\n}\n" 5316 "@end"); 5317 5318 verifyFormat("@implementation Foo {\n" 5319 " int _i;\n" 5320 "}\n" 5321 "+ (id)init {\n}\n" 5322 "@end"); 5323 5324 verifyFormat("@implementation Foo : Bar {\n" 5325 " int _i;\n" 5326 "}\n" 5327 "+ (id)init {\n}\n" 5328 "@end"); 5329 5330 verifyFormat("@implementation Foo (HackStuff)\n" 5331 "+ (id)init {\n}\n" 5332 "@end"); 5333 verifyFormat("@implementation ObjcClass\n" 5334 "- (void)method;\n" 5335 "{}\n" 5336 "@end"); 5337 } 5338 5339 TEST_F(FormatTest, FormatObjCProtocol) { 5340 verifyFormat("@protocol Foo\n" 5341 "@property(weak) id delegate;\n" 5342 "- (NSUInteger)numberOfThings;\n" 5343 "@end"); 5344 5345 verifyFormat("@protocol MyProtocol <NSObject>\n" 5346 "- (NSUInteger)numberOfThings;\n" 5347 "@end"); 5348 5349 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n" 5350 "- (NSUInteger)numberOfThings;\n" 5351 "@end"); 5352 5353 verifyFormat("@protocol Foo;\n" 5354 "@protocol Bar;\n"); 5355 5356 verifyFormat("@protocol Foo\n" 5357 "@end\n" 5358 "@protocol Bar\n" 5359 "@end"); 5360 5361 verifyFormat("@protocol myProtocol\n" 5362 "- (void)mandatoryWithInt:(int)i;\n" 5363 "@optional\n" 5364 "- (void)optional;\n" 5365 "@required\n" 5366 "- (void)required;\n" 5367 "@optional\n" 5368 "@property(assign) int madProp;\n" 5369 "@end\n"); 5370 5371 verifyFormat("@property(nonatomic, assign, readonly)\n" 5372 " int *looooooooooooooooooooooooooooongNumber;\n" 5373 "@property(nonatomic, assign, readonly)\n" 5374 " NSString *looooooooooooooooooooooooooooongName;"); 5375 } 5376 5377 TEST_F(FormatTest, FormatObjCMethodDeclarations) { 5378 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" 5379 " rect:(NSRect)theRect\n" 5380 " interval:(float)theInterval {\n" 5381 "}"); 5382 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" 5383 " longKeyword:(NSRect)theRect\n" 5384 " evenLongerKeyword:(float)theInterval\n" 5385 " error:(NSError **)theError {\n" 5386 "}"); 5387 } 5388 5389 TEST_F(FormatTest, FormatObjCMethodExpr) { 5390 verifyFormat("[foo bar:baz];"); 5391 verifyFormat("return [foo bar:baz];"); 5392 verifyFormat("f([foo bar:baz]);"); 5393 verifyFormat("f(2, [foo bar:baz]);"); 5394 verifyFormat("f(2, a ? b : c);"); 5395 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); 5396 5397 // Unary operators. 5398 verifyFormat("int a = +[foo bar:baz];"); 5399 verifyFormat("int a = -[foo bar:baz];"); 5400 verifyFormat("int a = ![foo bar:baz];"); 5401 verifyFormat("int a = ~[foo bar:baz];"); 5402 verifyFormat("int a = ++[foo bar:baz];"); 5403 verifyFormat("int a = --[foo bar:baz];"); 5404 verifyFormat("int a = sizeof [foo bar:baz];"); 5405 verifyFormat("int a = alignof [foo bar:baz];", getGoogleStyle()); 5406 verifyFormat("int a = &[foo bar:baz];"); 5407 verifyFormat("int a = *[foo bar:baz];"); 5408 // FIXME: Make casts work, without breaking f()[4]. 5409 //verifyFormat("int a = (int)[foo bar:baz];"); 5410 //verifyFormat("return (int)[foo bar:baz];"); 5411 //verifyFormat("(void)[foo bar:baz];"); 5412 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); 5413 5414 // Binary operators. 5415 verifyFormat("[foo bar:baz], [foo bar:baz];"); 5416 verifyFormat("[foo bar:baz] = [foo bar:baz];"); 5417 verifyFormat("[foo bar:baz] *= [foo bar:baz];"); 5418 verifyFormat("[foo bar:baz] /= [foo bar:baz];"); 5419 verifyFormat("[foo bar:baz] %= [foo bar:baz];"); 5420 verifyFormat("[foo bar:baz] += [foo bar:baz];"); 5421 verifyFormat("[foo bar:baz] -= [foo bar:baz];"); 5422 verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); 5423 verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); 5424 verifyFormat("[foo bar:baz] &= [foo bar:baz];"); 5425 verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); 5426 verifyFormat("[foo bar:baz] |= [foo bar:baz];"); 5427 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); 5428 verifyFormat("[foo bar:baz] || [foo bar:baz];"); 5429 verifyFormat("[foo bar:baz] && [foo bar:baz];"); 5430 verifyFormat("[foo bar:baz] | [foo bar:baz];"); 5431 verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); 5432 verifyFormat("[foo bar:baz] & [foo bar:baz];"); 5433 verifyFormat("[foo bar:baz] == [foo bar:baz];"); 5434 verifyFormat("[foo bar:baz] != [foo bar:baz];"); 5435 verifyFormat("[foo bar:baz] >= [foo bar:baz];"); 5436 verifyFormat("[foo bar:baz] <= [foo bar:baz];"); 5437 verifyFormat("[foo bar:baz] > [foo bar:baz];"); 5438 verifyFormat("[foo bar:baz] < [foo bar:baz];"); 5439 verifyFormat("[foo bar:baz] >> [foo bar:baz];"); 5440 verifyFormat("[foo bar:baz] << [foo bar:baz];"); 5441 verifyFormat("[foo bar:baz] - [foo bar:baz];"); 5442 verifyFormat("[foo bar:baz] + [foo bar:baz];"); 5443 verifyFormat("[foo bar:baz] * [foo bar:baz];"); 5444 verifyFormat("[foo bar:baz] / [foo bar:baz];"); 5445 verifyFormat("[foo bar:baz] % [foo bar:baz];"); 5446 // Whew! 5447 5448 verifyFormat("return in[42];"); 5449 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" 5450 "}"); 5451 5452 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); 5453 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); 5454 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); 5455 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); 5456 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); 5457 verifyFormat("[button setAction:@selector(zoomOut:)];"); 5458 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); 5459 5460 verifyFormat("arr[[self indexForFoo:a]];"); 5461 verifyFormat("throw [self errorFor:a];"); 5462 verifyFormat("@throw [self errorFor:a];"); 5463 5464 verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); 5465 verifyFormat("[(id)foo bar:(id) ? baz : quux];"); 5466 verifyFormat("4 > 4 ? (id)a : (id)baz;"); 5467 5468 // This tests that the formatter doesn't break after "backing" but before ":", 5469 // which would be at 80 columns. 5470 verifyFormat( 5471 "void f() {\n" 5472 " if ((self = [super initWithContentRect:contentRect\n" 5473 " styleMask:styleMask ?: otherMask\n" 5474 " backing:NSBackingStoreBuffered\n" 5475 " defer:YES]))"); 5476 5477 verifyFormat( 5478 "[foo checkThatBreakingAfterColonWorksOk:\n" 5479 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); 5480 5481 verifyFormat("[myObj short:arg1 // Force line break\n" 5482 " longKeyword:arg2 != nil ? arg2 : @\"longKeyword\"\n" 5483 " evenLongerKeyword:arg3 ?: @\"evenLongerKeyword\"\n" 5484 " error:arg4];"); 5485 verifyFormat( 5486 "void f() {\n" 5487 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 5488 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" 5489 " pos.width(), pos.height())\n" 5490 " styleMask:NSBorderlessWindowMask\n" 5491 " backing:NSBackingStoreBuffered\n" 5492 " defer:NO]);\n" 5493 "}"); 5494 verifyFormat( 5495 "void f() {\n" 5496 " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" 5497 " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" 5498 " pos.width(), pos.height())\n" 5499 " syeMask:NSBorderlessWindowMask\n" 5500 " bking:NSBackingStoreBuffered\n" 5501 " der:NO]);\n" 5502 "}", 5503 getLLVMStyleWithColumns(70)); 5504 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" 5505 " with:contentsNativeView];"); 5506 5507 verifyFormat( 5508 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" 5509 " owner:nillllll];"); 5510 5511 verifyFormat( 5512 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" 5513 " forType:kBookmarkButtonDragType];"); 5514 5515 verifyFormat("[defaultCenter addObserver:self\n" 5516 " selector:@selector(willEnterFullscreen)\n" 5517 " name:kWillEnterFullscreenNotification\n" 5518 " object:nil];"); 5519 verifyFormat("[image_rep drawInRect:drawRect\n" 5520 " fromRect:NSZeroRect\n" 5521 " operation:NSCompositeCopy\n" 5522 " fraction:1.0\n" 5523 " respectFlipped:NO\n" 5524 " hints:nil];"); 5525 5526 verifyFormat( 5527 "scoped_nsobject<NSTextField> message(\n" 5528 " // The frame will be fixed up when |-setMessageText:| is called.\n" 5529 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); 5530 verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" 5531 " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" 5532 " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" 5533 " aaaa:bbb];"); 5534 verifyFormat("[self param:function( //\n" 5535 " parameter)]"); 5536 verifyFormat( 5537 "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 5538 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 5539 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); 5540 5541 // Variadic parameters. 5542 verifyFormat( 5543 "NSArray *myStrings = [NSArray stringarray:@\"a\", @\"b\", nil];"); 5544 verifyFormat( 5545 "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 5546 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 5547 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); 5548 verifyFormat("[self // break\n" 5549 " a:a\n" 5550 " aaa:aaa];"); 5551 } 5552 5553 TEST_F(FormatTest, ObjCAt) { 5554 verifyFormat("@autoreleasepool"); 5555 verifyFormat("@catch"); 5556 verifyFormat("@class"); 5557 verifyFormat("@compatibility_alias"); 5558 verifyFormat("@defs"); 5559 verifyFormat("@dynamic"); 5560 verifyFormat("@encode"); 5561 verifyFormat("@end"); 5562 verifyFormat("@finally"); 5563 verifyFormat("@implementation"); 5564 verifyFormat("@import"); 5565 verifyFormat("@interface"); 5566 verifyFormat("@optional"); 5567 verifyFormat("@package"); 5568 verifyFormat("@private"); 5569 verifyFormat("@property"); 5570 verifyFormat("@protected"); 5571 verifyFormat("@protocol"); 5572 verifyFormat("@public"); 5573 verifyFormat("@required"); 5574 verifyFormat("@selector"); 5575 verifyFormat("@synchronized"); 5576 verifyFormat("@synthesize"); 5577 verifyFormat("@throw"); 5578 verifyFormat("@try"); 5579 5580 EXPECT_EQ("@interface", format("@ interface")); 5581 5582 // The precise formatting of this doesn't matter, nobody writes code like 5583 // this. 5584 verifyFormat("@ /*foo*/ interface"); 5585 } 5586 5587 TEST_F(FormatTest, ObjCSnippets) { 5588 verifyFormat("@autoreleasepool {\n" 5589 " foo();\n" 5590 "}"); 5591 verifyFormat("@class Foo, Bar;"); 5592 verifyFormat("@compatibility_alias AliasName ExistingClass;"); 5593 verifyFormat("@dynamic textColor;"); 5594 verifyFormat("char *buf1 = @encode(int *);"); 5595 verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); 5596 verifyFormat("char *buf1 = @encode(int **);"); 5597 verifyFormat("Protocol *proto = @protocol(p1);"); 5598 verifyFormat("SEL s = @selector(foo:);"); 5599 verifyFormat("@synchronized(self) {\n" 5600 " f();\n" 5601 "}"); 5602 5603 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 5604 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 5605 5606 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); 5607 verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); 5608 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;"); 5609 5610 verifyFormat("@import foo.bar;\n" 5611 "@import baz;"); 5612 } 5613 5614 TEST_F(FormatTest, ObjCLiterals) { 5615 verifyFormat("@\"String\""); 5616 verifyFormat("@1"); 5617 verifyFormat("@+4.8"); 5618 verifyFormat("@-4"); 5619 verifyFormat("@1LL"); 5620 verifyFormat("@.5"); 5621 verifyFormat("@'c'"); 5622 verifyFormat("@true"); 5623 5624 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); 5625 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); 5626 verifyFormat("NSNumber *favoriteColor = @(Green);"); 5627 verifyFormat("NSString *path = @(getenv(\"PATH\"));"); 5628 } 5629 5630 TEST_F(FormatTest, ObjCDictLiterals) { 5631 verifyFormat("@{"); 5632 verifyFormat("@{}"); 5633 verifyFormat("@{ @\"one\" : @1 }"); 5634 verifyFormat("return @{ @\"one\" : @1 };"); 5635 verifyFormat("@{ @\"one\" : @1, }"); 5636 5637 verifyFormat("@{ @\"one\" : @{ @2 : @1 } }"); 5638 verifyFormat("@{ @\"one\" : @{ @2 : @1 }, }"); 5639 5640 verifyFormat("@{ 1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2 }"); 5641 verifyFormat("[self setDict:@{}"); 5642 verifyFormat("[self setDict:@{ @1 : @2 }"); 5643 verifyFormat("NSLog(@\"%@\", @{ @1 : @2, @2 : @3 }[@1]);"); 5644 verifyFormat( 5645 "NSDictionary *masses = @{ @\"H\" : @1.0078, @\"He\" : @4.0026 };"); 5646 verifyFormat( 5647 "NSDictionary *settings = @{ AVEncoderKey : @(AVAudioQualityMax) };"); 5648 5649 verifyFormat( 5650 "NSDictionary *d = @{\n" 5651 " @\"nam\" : NSUserNam(),\n" 5652 " @\"dte\" : [NSDate date],\n" 5653 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 5654 "};"); 5655 verifyFormat( 5656 "@{\n" 5657 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 5658 "regularFont,\n" 5659 "};"); 5660 verifyGoogleFormat( 5661 "@{\n" 5662 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 5663 "regularFont,\n" 5664 "};"); 5665 5666 // We should try to be robust in case someone forgets the "@". 5667 verifyFormat( 5668 "NSDictionary *d = {\n" 5669 " @\"nam\" : NSUserNam(),\n" 5670 " @\"dte\" : [NSDate date],\n" 5671 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 5672 "};"); 5673 } 5674 5675 TEST_F(FormatTest, ObjCArrayLiterals) { 5676 verifyFormat("@["); 5677 verifyFormat("@[]"); 5678 verifyFormat( 5679 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); 5680 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); 5681 verifyFormat("NSArray *array = @[ [foo description] ];"); 5682 5683 verifyFormat( 5684 "NSArray *some_variable = @[\n" 5685 " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" 5686 " @\"aaaaaaaaaaaaaaaaa\",\n" 5687 " @\"aaaaaaaaaaaaaaaaa\",\n" 5688 " @\"aaaaaaaaaaaaaaaaa\"\n" 5689 "];"); 5690 verifyFormat("NSArray *some_variable = @[\n" 5691 " @\"aaaaaaaaaaaaaaaaa\",\n" 5692 " @\"aaaaaaaaaaaaaaaaa\",\n" 5693 " @\"aaaaaaaaaaaaaaaaa\",\n" 5694 " @\"aaaaaaaaaaaaaaaaa\",\n" 5695 "];"); 5696 verifyGoogleFormat("NSArray *some_variable = @[\n" 5697 " @\"aaaaaaaaaaaaaaaaa\",\n" 5698 " @\"aaaaaaaaaaaaaaaaa\",\n" 5699 " @\"aaaaaaaaaaaaaaaaa\",\n" 5700 " @\"aaaaaaaaaaaaaaaaa\"\n" 5701 "];"); 5702 5703 // We should try to be robust in case someone forgets the "@". 5704 verifyFormat("NSArray *some_variable = [\n" 5705 " @\"aaaaaaaaaaaaaaaaa\",\n" 5706 " @\"aaaaaaaaaaaaaaaaa\",\n" 5707 " @\"aaaaaaaaaaaaaaaaa\",\n" 5708 " @\"aaaaaaaaaaaaaaaaa\",\n" 5709 "];"); 5710 } 5711 5712 TEST_F(FormatTest, ReformatRegionAdjustsIndent) { 5713 EXPECT_EQ("{\n" 5714 "{\n" 5715 "a;\n" 5716 "b;\n" 5717 "}\n" 5718 "}", 5719 format("{\n" 5720 "{\n" 5721 "a;\n" 5722 " b;\n" 5723 "}\n" 5724 "}", 5725 13, 2, getLLVMStyle())); 5726 EXPECT_EQ("{\n" 5727 "{\n" 5728 " a;\n" 5729 "b;\n" 5730 "}\n" 5731 "}", 5732 format("{\n" 5733 "{\n" 5734 " a;\n" 5735 "b;\n" 5736 "}\n" 5737 "}", 5738 9, 2, getLLVMStyle())); 5739 EXPECT_EQ("{\n" 5740 "{\n" 5741 "public:\n" 5742 " b;\n" 5743 "}\n" 5744 "}", 5745 format("{\n" 5746 "{\n" 5747 "public:\n" 5748 " b;\n" 5749 "}\n" 5750 "}", 5751 17, 2, getLLVMStyle())); 5752 EXPECT_EQ("{\n" 5753 "{\n" 5754 "a;\n" 5755 "}\n" 5756 "{\n" 5757 " b; //\n" 5758 "}\n" 5759 "}", 5760 format("{\n" 5761 "{\n" 5762 "a;\n" 5763 "}\n" 5764 "{\n" 5765 " b; //\n" 5766 "}\n" 5767 "}", 5768 22, 2, getLLVMStyle())); 5769 EXPECT_EQ(" {\n" 5770 " a; //\n" 5771 " }", 5772 format(" {\n" 5773 "a; //\n" 5774 " }", 5775 4, 2, getLLVMStyle())); 5776 EXPECT_EQ("void f() {}\n" 5777 "void g() {}", 5778 format("void f() {}\n" 5779 "void g() {}", 5780 13, 0, getLLVMStyle())); 5781 EXPECT_EQ("int a; // comment\n" 5782 " // line 2\n" 5783 "int b;", 5784 format("int a; // comment\n" 5785 " // line 2\n" 5786 " int b;", 5787 35, 0, getLLVMStyle())); 5788 EXPECT_EQ(" int a;\n" 5789 " void\n" 5790 " ffffff() {\n" 5791 " }", 5792 format(" int a;\n" 5793 "void ffffff() {}", 5794 11, 0, getLLVMStyleWithColumns(11))); 5795 } 5796 5797 TEST_F(FormatTest, BreakStringLiterals) { 5798 EXPECT_EQ("\"some text \"\n" 5799 "\"other\";", 5800 format("\"some text other\";", getLLVMStyleWithColumns(12))); 5801 EXPECT_EQ("\"some text \"\n" 5802 "\"other\";", 5803 format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); 5804 EXPECT_EQ( 5805 "#define A \\\n" 5806 " \"some \" \\\n" 5807 " \"text \" \\\n" 5808 " \"other\";", 5809 format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); 5810 EXPECT_EQ( 5811 "#define A \\\n" 5812 " \"so \" \\\n" 5813 " \"text \" \\\n" 5814 " \"other\";", 5815 format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); 5816 5817 EXPECT_EQ("\"some text\"", 5818 format("\"some text\"", getLLVMStyleWithColumns(1))); 5819 EXPECT_EQ("\"some text\"", 5820 format("\"some text\"", getLLVMStyleWithColumns(11))); 5821 EXPECT_EQ("\"some \"\n" 5822 "\"text\"", 5823 format("\"some text\"", getLLVMStyleWithColumns(10))); 5824 EXPECT_EQ("\"some \"\n" 5825 "\"text\"", 5826 format("\"some text\"", getLLVMStyleWithColumns(7))); 5827 EXPECT_EQ("\"some\"\n" 5828 "\" tex\"\n" 5829 "\"t\"", 5830 format("\"some text\"", getLLVMStyleWithColumns(6))); 5831 EXPECT_EQ("\"some\"\n" 5832 "\" tex\"\n" 5833 "\" and\"", 5834 format("\"some tex and\"", getLLVMStyleWithColumns(6))); 5835 EXPECT_EQ("\"some\"\n" 5836 "\"/tex\"\n" 5837 "\"/and\"", 5838 format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); 5839 5840 EXPECT_EQ("variable =\n" 5841 " \"long string \"\n" 5842 " \"literal\";", 5843 format("variable = \"long string literal\";", 5844 getLLVMStyleWithColumns(20))); 5845 5846 EXPECT_EQ("variable = f(\n" 5847 " \"long string \"\n" 5848 " \"literal\",\n" 5849 " short,\n" 5850 " loooooooooooooooooooong);", 5851 format("variable = f(\"long string literal\", short, " 5852 "loooooooooooooooooooong);", 5853 getLLVMStyleWithColumns(20))); 5854 5855 EXPECT_EQ("f(g(\"long string \"\n" 5856 " \"literal\"),\n" 5857 " b);", 5858 format("f(g(\"long string literal\"), b);", 5859 getLLVMStyleWithColumns(20))); 5860 EXPECT_EQ("f(g(\"long string \"\n" 5861 " \"literal\",\n" 5862 " a),\n" 5863 " b);", 5864 format("f(g(\"long string literal\", a), b);", 5865 getLLVMStyleWithColumns(20))); 5866 EXPECT_EQ( 5867 "f(\"one two\".split(\n" 5868 " variable));", 5869 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); 5870 EXPECT_EQ("f(\"one two three four five six \"\n" 5871 " \"seven\".split(\n" 5872 " really_looooong_variable));", 5873 format("f(\"one two three four five six seven\"." 5874 "split(really_looooong_variable));", 5875 getLLVMStyleWithColumns(33))); 5876 5877 EXPECT_EQ("f(\"some \"\n" 5878 " \"text\",\n" 5879 " other);", 5880 format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); 5881 5882 // Only break as a last resort. 5883 verifyFormat( 5884 "aaaaaaaaaaaaaaaaaaaa(\n" 5885 " aaaaaaaaaaaaaaaaaaaa,\n" 5886 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); 5887 5888 EXPECT_EQ( 5889 "\"splitmea\"\n" 5890 "\"trandomp\"\n" 5891 "\"oint\"", 5892 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); 5893 5894 EXPECT_EQ( 5895 "\"split/\"\n" 5896 "\"pathat/\"\n" 5897 "\"slashes\"", 5898 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 5899 5900 EXPECT_EQ( 5901 "\"split/\"\n" 5902 "\"pathat/\"\n" 5903 "\"slashes\"", 5904 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 5905 EXPECT_EQ("\"split at \"\n" 5906 "\"spaces/at/\"\n" 5907 "\"slashes.at.any$\"\n" 5908 "\"non-alphanumeric%\"\n" 5909 "\"1111111111characte\"\n" 5910 "\"rs\"", 5911 format("\"split at " 5912 "spaces/at/" 5913 "slashes.at." 5914 "any$non-" 5915 "alphanumeric%" 5916 "1111111111characte" 5917 "rs\"", 5918 getLLVMStyleWithColumns(20))); 5919 5920 // Verify that splitting the strings understands 5921 // Style::AlwaysBreakBeforeMultilineStrings. 5922 EXPECT_EQ("aaaaaaaaaaaa(aaaaaaaaaaaaa,\n" 5923 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa \"\n" 5924 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\");", 5925 format("aaaaaaaaaaaa(aaaaaaaaaaaaa, \"aaaaaaaaaaaaaaaaaaaaaa " 5926 "aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa " 5927 "aaaaaaaaaaaaaaaaaaaaaa\");", 5928 getGoogleStyle())); 5929 EXPECT_EQ("return \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 5930 " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\";", 5931 format("return \"aaaaaaaaaaaaaaaaaaaaaa " 5932 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " 5933 "aaaaaaaaaaaaaaaaaaaaaa\";", 5934 getGoogleStyle())); 5935 EXPECT_EQ("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 5936 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 5937 format("llvm::outs() << " 5938 "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa" 5939 "aaaaaaaaaaaaaaaaaaa\";")); 5940 EXPECT_EQ("ffff(\n" 5941 " {\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 5942 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 5943 format("ffff({\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " 5944 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 5945 getGoogleStyle())); 5946 5947 FormatStyle AlignLeft = getLLVMStyleWithColumns(12); 5948 AlignLeft.AlignEscapedNewlinesLeft = true; 5949 EXPECT_EQ( 5950 "#define A \\\n" 5951 " \"some \" \\\n" 5952 " \"text \" \\\n" 5953 " \"other\";", 5954 format("#define A \"some text other\";", AlignLeft)); 5955 } 5956 5957 TEST_F(FormatTest, BreaksWideStringLiterals) { 5958 EXPECT_EQ( 5959 "u8\"utf8 string \"\n" 5960 "u8\"literal\";", 5961 format("u8\"utf8 string literal\";", getGoogleStyleWithColumns(16))); 5962 EXPECT_EQ( 5963 "u\"utf16 string \"\n" 5964 "u\"literal\";", 5965 format("u\"utf16 string literal\";", getGoogleStyleWithColumns(16))); 5966 EXPECT_EQ( 5967 "U\"utf32 string \"\n" 5968 "U\"literal\";", 5969 format("U\"utf32 string literal\";", getGoogleStyleWithColumns(16))); 5970 EXPECT_EQ("L\"wide string \"\n" 5971 "L\"literal\";", 5972 format("L\"wide string literal\";", getGoogleStyleWithColumns(16))); 5973 } 5974 5975 TEST_F(FormatTest, BreaksRawStringLiterals) { 5976 EXPECT_EQ("R\"x(raw )x\"\n" 5977 "R\"x(literal)x\";", 5978 format("R\"x(raw literal)x\";", getGoogleStyleWithColumns(15))); 5979 EXPECT_EQ("uR\"x(raw )x\"\n" 5980 "uR\"x(literal)x\";", 5981 format("uR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 5982 EXPECT_EQ("u8R\"x(raw )x\"\n" 5983 "u8R\"x(literal)x\";", 5984 format("u8R\"x(raw literal)x\";", getGoogleStyleWithColumns(17))); 5985 EXPECT_EQ("LR\"x(raw )x\"\n" 5986 "LR\"x(literal)x\";", 5987 format("LR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 5988 EXPECT_EQ("UR\"x(raw )x\"\n" 5989 "UR\"x(literal)x\";", 5990 format("UR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 5991 } 5992 5993 TEST_F(FormatTest, BreaksStringLiteralsWithin_TMacro) { 5994 FormatStyle Style = getLLVMStyleWithColumns(20); 5995 EXPECT_EQ( 5996 "_T(\"aaaaaaaaaaaaaa\")\n" 5997 "_T(\"aaaaaaaaaaaaaa\")\n" 5998 "_T(\"aaaaaaaaaaaa\")", 5999 format(" _T(\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")", Style)); 6000 EXPECT_EQ("f(x, _T(\"aaaaaaaaa\")\n" 6001 " _T(\"aaaaaa\"),\n" 6002 " z);", 6003 format("f(x, _T(\"aaaaaaaaaaaaaaa\"), z);", Style)); 6004 6005 // FIXME: Handle embedded spaces in one iteration. 6006 // EXPECT_EQ("_T(\"aaaaaaaaaaaaa\")\n" 6007 // "_T(\"aaaaaaaaaaaaa\")\n" 6008 // "_T(\"aaaaaaaaaaaaa\")\n" 6009 // "_T(\"a\")", 6010 // format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 6011 // getLLVMStyleWithColumns(20))); 6012 EXPECT_EQ( 6013 "_T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 6014 format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", Style)); 6015 } 6016 6017 TEST_F(FormatTest, DontSplitStringLiteralsWithEscapedNewlines) { 6018 EXPECT_EQ( 6019 "aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 6020 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 6021 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 6022 format("aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 6023 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 6024 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";")); 6025 } 6026 6027 TEST_F(FormatTest, CountsCharactersInMultilineRawStringLiterals) { 6028 EXPECT_EQ("f(g(R\"x(raw literal)x\", a), b);", 6029 format("f(g(R\"x(raw literal)x\", a), b);", getGoogleStyle())); 6030 EXPECT_EQ("fffffffffff(g(R\"x(\n" 6031 "multiline raw string literal xxxxxxxxxxxxxx\n" 6032 ")x\",\n" 6033 " a),\n" 6034 " b);", 6035 format("fffffffffff(g(R\"x(\n" 6036 "multiline raw string literal xxxxxxxxxxxxxx\n" 6037 ")x\", a), b);", 6038 getGoogleStyleWithColumns(20))); 6039 EXPECT_EQ("fffffffffff(\n" 6040 " g(R\"x(qqq\n" 6041 "multiline raw string literal xxxxxxxxxxxxxx\n" 6042 ")x\",\n" 6043 " a),\n" 6044 " b);", 6045 format("fffffffffff(g(R\"x(qqq\n" 6046 "multiline raw string literal xxxxxxxxxxxxxx\n" 6047 ")x\", a), b);", 6048 getGoogleStyleWithColumns(20))); 6049 6050 EXPECT_EQ("fffffffffff(R\"x(\n" 6051 "multiline raw string literal xxxxxxxxxxxxxx\n" 6052 ")x\");", 6053 format("fffffffffff(R\"x(\n" 6054 "multiline raw string literal xxxxxxxxxxxxxx\n" 6055 ")x\");", 6056 getGoogleStyleWithColumns(20))); 6057 EXPECT_EQ("fffffffffff(R\"x(\n" 6058 "multiline raw string literal xxxxxxxxxxxxxx\n" 6059 ")x\" +\n" 6060 " bbbbbb);", 6061 format("fffffffffff(R\"x(\n" 6062 "multiline raw string literal xxxxxxxxxxxxxx\n" 6063 ")x\" + bbbbbb);", 6064 getGoogleStyleWithColumns(20))); 6065 } 6066 6067 TEST_F(FormatTest, SkipsUnknownStringLiterals) { 6068 verifyFormat("string a = \"unterminated;"); 6069 EXPECT_EQ("function(\"unterminated,\n" 6070 " OtherParameter);", 6071 format("function( \"unterminated,\n" 6072 " OtherParameter);")); 6073 } 6074 6075 TEST_F(FormatTest, DoesNotTryToParseUDLiteralsInPreCpp11Code) { 6076 EXPECT_EQ("#define x(_a) printf(\"foo\" _a);", 6077 format("#define x(_a) printf(\"foo\"_a);", getLLVMStyle())); 6078 } 6079 6080 TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) { 6081 EXPECT_EQ("someFunction(\"aaabbbcccd\"\n" 6082 " \"ddeeefff\");", 6083 format("someFunction(\"aaabbbcccdddeeefff\");", 6084 getLLVMStyleWithColumns(25))); 6085 EXPECT_EQ("someFunction1234567890(\n" 6086 " \"aaabbbcccdddeeefff\");", 6087 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 6088 getLLVMStyleWithColumns(26))); 6089 EXPECT_EQ("someFunction1234567890(\n" 6090 " \"aaabbbcccdddeeeff\"\n" 6091 " \"f\");", 6092 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 6093 getLLVMStyleWithColumns(25))); 6094 EXPECT_EQ("someFunction1234567890(\n" 6095 " \"aaabbbcccdddeeeff\"\n" 6096 " \"f\");", 6097 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 6098 getLLVMStyleWithColumns(24))); 6099 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 6100 " \"ddde \"\n" 6101 " \"efff\");", 6102 format("someFunction(\"aaabbbcc ddde efff\");", 6103 getLLVMStyleWithColumns(25))); 6104 EXPECT_EQ("someFunction(\"aaabbbccc \"\n" 6105 " \"ddeeefff\");", 6106 format("someFunction(\"aaabbbccc ddeeefff\");", 6107 getLLVMStyleWithColumns(25))); 6108 EXPECT_EQ("someFunction1234567890(\n" 6109 " \"aaabb \"\n" 6110 " \"cccdddeeefff\");", 6111 format("someFunction1234567890(\"aaabb cccdddeeefff\");", 6112 getLLVMStyleWithColumns(25))); 6113 EXPECT_EQ("#define A \\\n" 6114 " string s = \\\n" 6115 " \"123456789\" \\\n" 6116 " \"0\"; \\\n" 6117 " int i;", 6118 format("#define A string s = \"1234567890\"; int i;", 6119 getLLVMStyleWithColumns(20))); 6120 // FIXME: Put additional penalties on breaking at non-whitespace locations. 6121 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 6122 " \"dddeeeff\"\n" 6123 " \"f\");", 6124 format("someFunction(\"aaabbbcc dddeeefff\");", 6125 getLLVMStyleWithColumns(25))); 6126 } 6127 6128 TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { 6129 EXPECT_EQ("\"\\a\"", 6130 format("\"\\a\"", getLLVMStyleWithColumns(3))); 6131 EXPECT_EQ("\"\\\"", 6132 format("\"\\\"", getLLVMStyleWithColumns(2))); 6133 EXPECT_EQ("\"test\"\n" 6134 "\"\\n\"", 6135 format("\"test\\n\"", getLLVMStyleWithColumns(7))); 6136 EXPECT_EQ("\"tes\\\\\"\n" 6137 "\"n\"", 6138 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); 6139 EXPECT_EQ("\"\\\\\\\\\"\n" 6140 "\"\\n\"", 6141 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); 6142 EXPECT_EQ("\"\\uff01\"", 6143 format("\"\\uff01\"", getLLVMStyleWithColumns(7))); 6144 EXPECT_EQ("\"\\uff01\"\n" 6145 "\"test\"", 6146 format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); 6147 EXPECT_EQ("\"\\Uff01ff02\"", 6148 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); 6149 EXPECT_EQ("\"\\x000000000001\"\n" 6150 "\"next\"", 6151 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); 6152 EXPECT_EQ("\"\\x000000000001next\"", 6153 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); 6154 EXPECT_EQ("\"\\x000000000001\"", 6155 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); 6156 EXPECT_EQ("\"test\"\n" 6157 "\"\\000000\"\n" 6158 "\"000001\"", 6159 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); 6160 EXPECT_EQ("\"test\\000\"\n" 6161 "\"00000000\"\n" 6162 "\"1\"", 6163 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); 6164 // FIXME: We probably don't need to care about escape sequences in raw 6165 // literals. 6166 EXPECT_EQ("R\"(\\x)\"\n" 6167 "R\"(\\x00)\"\n", 6168 format("R\"(\\x\\x00)\"\n", getGoogleStyleWithColumns(7))); 6169 } 6170 6171 TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { 6172 verifyFormat("void f() {\n" 6173 " return g() {}\n" 6174 " void h() {}"); 6175 verifyFormat("if (foo)\n" 6176 " return { forgot_closing_brace();\n" 6177 "test();"); 6178 verifyFormat("int a[] = { void forgot_closing_brace() { f();\n" 6179 "g();\n" 6180 "}"); 6181 } 6182 6183 TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) { 6184 verifyFormat("class X {\n" 6185 " void f() {\n" 6186 " }\n" 6187 "};", 6188 getLLVMStyleWithColumns(12)); 6189 } 6190 6191 TEST_F(FormatTest, ConfigurableIndentWidth) { 6192 FormatStyle EightIndent = getLLVMStyleWithColumns(18); 6193 EightIndent.IndentWidth = 8; 6194 verifyFormat("void f() {\n" 6195 " someFunction();\n" 6196 " if (true) {\n" 6197 " f();\n" 6198 " }\n" 6199 "}", 6200 EightIndent); 6201 verifyFormat("class X {\n" 6202 " void f() {\n" 6203 " }\n" 6204 "};", 6205 EightIndent); 6206 verifyFormat("int x[] = {\n" 6207 " call(),\n" 6208 " call(),\n" 6209 "};", 6210 EightIndent); 6211 } 6212 6213 TEST_F(FormatTest, ConfigurableFunctionDeclarationIndentAfterType) { 6214 verifyFormat("void\n" 6215 "f();", 6216 getLLVMStyleWithColumns(8)); 6217 } 6218 6219 TEST_F(FormatTest, ConfigurableUseOfTab) { 6220 FormatStyle Tab = getLLVMStyleWithColumns(42); 6221 Tab.IndentWidth = 8; 6222 Tab.UseTab = FormatStyle::UT_Always; 6223 Tab.AlignEscapedNewlinesLeft = true; 6224 6225 EXPECT_EQ("if (aaaaaaaa && // q\n" 6226 " bb)\t\t// w\n" 6227 "\t;", 6228 format("if (aaaaaaaa &&// q\n" 6229 "bb)// w\n" 6230 ";", 6231 Tab)); 6232 EXPECT_EQ("if (aaa && bbb) // w\n" 6233 "\t;", 6234 format("if(aaa&&bbb)// w\n" 6235 ";", 6236 Tab)); 6237 6238 verifyFormat("class X {\n" 6239 "\tvoid f() {\n" 6240 "\t\tsomeFunction(parameter1,\n" 6241 "\t\t\t parameter2);\n" 6242 "\t}\n" 6243 "};", 6244 Tab); 6245 verifyFormat("#define A \\\n" 6246 "\tvoid f() { \\\n" 6247 "\t\tsomeFunction( \\\n" 6248 "\t\t parameter1, \\\n" 6249 "\t\t parameter2); \\\n" 6250 "\t}", 6251 Tab); 6252 EXPECT_EQ("void f() {\n" 6253 "\tf();\n" 6254 "\tg();\n" 6255 "}", 6256 format("void f() {\n" 6257 "\tf();\n" 6258 "\tg();\n" 6259 "}", 6260 0, 0, Tab)); 6261 EXPECT_EQ("void f() {\n" 6262 "\tf();\n" 6263 "\tg();\n" 6264 "}", 6265 format("void f() {\n" 6266 "\tf();\n" 6267 "\tg();\n" 6268 "}", 6269 16, 0, Tab)); 6270 EXPECT_EQ("void f() {\n" 6271 " \tf();\n" 6272 "\tg();\n" 6273 "}", 6274 format("void f() {\n" 6275 " \tf();\n" 6276 " \tg();\n" 6277 "}", 6278 21, 0, Tab)); 6279 6280 Tab.TabWidth = 4; 6281 Tab.IndentWidth = 8; 6282 verifyFormat("class TabWidth4Indent8 {\n" 6283 "\t\tvoid f() {\n" 6284 "\t\t\t\tsomeFunction(parameter1,\n" 6285 "\t\t\t\t\t\t\t parameter2);\n" 6286 "\t\t}\n" 6287 "};", 6288 Tab); 6289 6290 Tab.TabWidth = 4; 6291 Tab.IndentWidth = 4; 6292 verifyFormat("class TabWidth4Indent4 {\n" 6293 "\tvoid f() {\n" 6294 "\t\tsomeFunction(parameter1,\n" 6295 "\t\t\t\t\t parameter2);\n" 6296 "\t}\n" 6297 "};", 6298 Tab); 6299 6300 Tab.TabWidth = 8; 6301 Tab.IndentWidth = 4; 6302 verifyFormat("class TabWidth8Indent4 {\n" 6303 " void f() {\n" 6304 "\tsomeFunction(parameter1,\n" 6305 "\t\t parameter2);\n" 6306 " }\n" 6307 "};", 6308 Tab); 6309 6310 Tab.TabWidth = 8; 6311 Tab.IndentWidth = 8; 6312 EXPECT_EQ("/*\n" 6313 "\t a\t\tcomment\n" 6314 "\t in multiple lines\n" 6315 " */", 6316 format(" /*\t \t \n" 6317 " \t \t a\t\tcomment\t \t\n" 6318 " \t \t in multiple lines\t\n" 6319 " \t */", 6320 Tab)); 6321 6322 Tab.UseTab = FormatStyle::UT_ForIndentation; 6323 verifyFormat("T t[] = {\n" 6324 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6325 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6326 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6327 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6328 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6329 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 6330 "};", 6331 Tab); 6332 verifyFormat("enum A {\n" 6333 "\ta1,\n" 6334 "\ta2,\n" 6335 "\ta3\n" 6336 "};", 6337 Tab); 6338 EXPECT_EQ("if (aaaaaaaa && // q\n" 6339 " bb) // w\n" 6340 "\t;", 6341 format("if (aaaaaaaa &&// q\n" 6342 "bb)// w\n" 6343 ";", 6344 Tab)); 6345 verifyFormat("class X {\n" 6346 "\tvoid f() {\n" 6347 "\t\tsomeFunction(parameter1,\n" 6348 "\t\t parameter2);\n" 6349 "\t}\n" 6350 "};", 6351 Tab); 6352 verifyFormat("{\n" 6353 "\tQ({\n" 6354 "\t\t int a;\n" 6355 "\t\t someFunction(aaaaaaaaaa,\n" 6356 "\t\t bbbbbbbbb);\n" 6357 "\t },\n" 6358 "\t p);\n" 6359 "}", 6360 Tab); 6361 EXPECT_EQ("{\n" 6362 "\t/* aaaa\n" 6363 "\t bbbb */\n" 6364 "}", 6365 format("{\n" 6366 "/* aaaa\n" 6367 " bbbb */\n" 6368 "}", 6369 Tab)); 6370 EXPECT_EQ("{\n" 6371 "\t/*\n" 6372 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 6373 "\t bbbbbbbbbbbbb\n" 6374 "\t*/\n" 6375 "}", 6376 format("{\n" 6377 "/*\n" 6378 " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 6379 "*/\n" 6380 "}", 6381 Tab)); 6382 EXPECT_EQ("{\n" 6383 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 6384 "\t// bbbbbbbbbbbbb\n" 6385 "}", 6386 format("{\n" 6387 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 6388 "}", 6389 Tab)); 6390 EXPECT_EQ("{\n" 6391 "\t/*\n" 6392 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 6393 "\t bbbbbbbbbbbbb\n" 6394 "\t*/\n" 6395 "}", 6396 format("{\n" 6397 "\t/*\n" 6398 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 6399 "\t*/\n" 6400 "}", 6401 Tab)); 6402 EXPECT_EQ("{\n" 6403 "\t/*\n" 6404 "\n" 6405 "\t*/\n" 6406 "}", 6407 format("{\n" 6408 "\t/*\n" 6409 "\n" 6410 "\t*/\n" 6411 "}", 6412 Tab)); 6413 EXPECT_EQ("{\n" 6414 "\t/*\n" 6415 " asdf\n" 6416 "\t*/\n" 6417 "}", 6418 format("{\n" 6419 "\t/*\n" 6420 " asdf\n" 6421 "\t*/\n" 6422 "}", 6423 Tab)); 6424 6425 Tab.UseTab = FormatStyle::UT_Never; 6426 EXPECT_EQ("/*\n" 6427 " a\t\tcomment\n" 6428 " in multiple lines\n" 6429 " */", 6430 format(" /*\t \t \n" 6431 " \t \t a\t\tcomment\t \t\n" 6432 " \t \t in multiple lines\t\n" 6433 " \t */", 6434 Tab)); 6435 EXPECT_EQ("/* some\n" 6436 " comment */", 6437 format(" \t \t /* some\n" 6438 " \t \t comment */", 6439 Tab)); 6440 EXPECT_EQ("int a; /* some\n" 6441 " comment */", 6442 format(" \t \t int a; /* some\n" 6443 " \t \t comment */", 6444 Tab)); 6445 6446 EXPECT_EQ("int a; /* some\n" 6447 "comment */", 6448 format(" \t \t int\ta; /* some\n" 6449 " \t \t comment */", 6450 Tab)); 6451 EXPECT_EQ("f(\"\t\t\"); /* some\n" 6452 " comment */", 6453 format(" \t \t f(\"\t\t\"); /* some\n" 6454 " \t \t comment */", 6455 Tab)); 6456 EXPECT_EQ("{\n" 6457 " /*\n" 6458 " * Comment\n" 6459 " */\n" 6460 " int i;\n" 6461 "}", 6462 format("{\n" 6463 "\t/*\n" 6464 "\t * Comment\n" 6465 "\t */\n" 6466 "\t int i;\n" 6467 "}")); 6468 } 6469 6470 TEST_F(FormatTest, CalculatesOriginalColumn) { 6471 EXPECT_EQ("\"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6472 "q\"; /* some\n" 6473 " comment */", 6474 format(" \"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6475 "q\"; /* some\n" 6476 " comment */", 6477 getLLVMStyle())); 6478 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 6479 "/* some\n" 6480 " comment */", 6481 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 6482 " /* some\n" 6483 " comment */", 6484 getLLVMStyle())); 6485 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6486 "qqq\n" 6487 "/* some\n" 6488 " comment */", 6489 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6490 "qqq\n" 6491 " /* some\n" 6492 " comment */", 6493 getLLVMStyle())); 6494 EXPECT_EQ("inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6495 "wwww; /* some\n" 6496 " comment */", 6497 format(" inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 6498 "wwww; /* some\n" 6499 " comment */", 6500 getLLVMStyle())); 6501 } 6502 6503 TEST_F(FormatTest, ConfigurableSpaceAfterControlStatementKeyword) { 6504 FormatStyle NoSpace = getLLVMStyle(); 6505 NoSpace.SpaceAfterControlStatementKeyword = false; 6506 6507 verifyFormat("while(true)\n" 6508 " continue;", NoSpace); 6509 verifyFormat("for(;;)\n" 6510 " continue;", NoSpace); 6511 verifyFormat("if(true)\n" 6512 " f();\n" 6513 "else if(true)\n" 6514 " f();", NoSpace); 6515 verifyFormat("do {\n" 6516 " do_something();\n" 6517 "} while(something());", NoSpace); 6518 verifyFormat("switch(x) {\n" 6519 "default:\n" 6520 " break;\n" 6521 "}", NoSpace); 6522 } 6523 6524 TEST_F(FormatTest, ConfigurableSpacesInParentheses) { 6525 FormatStyle Spaces = getLLVMStyle(); 6526 6527 Spaces.SpacesInParentheses = true; 6528 verifyFormat("call( x, y, z );", Spaces); 6529 verifyFormat("while ( (bool)1 )\n" 6530 " continue;", Spaces); 6531 verifyFormat("for ( ;; )\n" 6532 " continue;", Spaces); 6533 verifyFormat("if ( true )\n" 6534 " f();\n" 6535 "else if ( true )\n" 6536 " f();", Spaces); 6537 verifyFormat("do {\n" 6538 " do_something( (int)i );\n" 6539 "} while ( something() );", Spaces); 6540 verifyFormat("switch ( x ) {\n" 6541 "default:\n" 6542 " break;\n" 6543 "}", Spaces); 6544 6545 Spaces.SpacesInParentheses = false; 6546 Spaces.SpacesInCStyleCastParentheses = true; 6547 verifyFormat("Type *A = ( Type * )P;", Spaces); 6548 verifyFormat("Type *A = ( vector<Type *, int *> )P;", Spaces); 6549 verifyFormat("x = ( int32 )y;", Spaces); 6550 verifyFormat("int a = ( int )(2.0f);", Spaces); 6551 verifyFormat("#define AA(X) sizeof((( X * )NULL)->a)", Spaces); 6552 verifyFormat("my_int a = ( my_int )sizeof(int);", Spaces); 6553 verifyFormat("#define x (( int )-1)", Spaces); 6554 6555 Spaces.SpacesInParentheses = false; 6556 Spaces.SpaceInEmptyParentheses = true; 6557 verifyFormat("call(x, y, z);", Spaces); 6558 verifyFormat("call( )", Spaces); 6559 6560 // Run the first set of tests again with 6561 // Spaces.SpacesInParentheses = false, 6562 // Spaces.SpaceInEmptyParentheses = true and 6563 // Spaces.SpacesInCStyleCastParentheses = true 6564 Spaces.SpacesInParentheses = false, 6565 Spaces.SpaceInEmptyParentheses = true; 6566 Spaces.SpacesInCStyleCastParentheses = true; 6567 verifyFormat("call(x, y, z);", Spaces); 6568 verifyFormat("while (( bool )1)\n" 6569 " continue;", Spaces); 6570 verifyFormat("for (;;)\n" 6571 " continue;", Spaces); 6572 verifyFormat("if (true)\n" 6573 " f( );\n" 6574 "else if (true)\n" 6575 " f( );", Spaces); 6576 verifyFormat("do {\n" 6577 " do_something(( int )i);\n" 6578 "} while (something( ));", Spaces); 6579 verifyFormat("switch (x) {\n" 6580 "default:\n" 6581 " break;\n" 6582 "}", Spaces); 6583 } 6584 6585 TEST_F(FormatTest, ConfigurableSpaceBeforeAssignmentOperators) { 6586 verifyFormat("int a = 5;"); 6587 verifyFormat("a += 42;"); 6588 verifyFormat("a or_eq 8;"); 6589 6590 FormatStyle Spaces = getLLVMStyle(); 6591 Spaces.SpaceBeforeAssignmentOperators = false; 6592 verifyFormat("int a= 5;", Spaces); 6593 verifyFormat("a+= 42;", Spaces); 6594 verifyFormat("a or_eq 8;", Spaces); 6595 } 6596 6597 TEST_F(FormatTest, LinuxBraceBreaking) { 6598 FormatStyle BreakBeforeBrace = getLLVMStyle(); 6599 BreakBeforeBrace.BreakBeforeBraces = FormatStyle::BS_Linux; 6600 verifyFormat("namespace a\n" 6601 "{\n" 6602 "class A\n" 6603 "{\n" 6604 " void f()\n" 6605 " {\n" 6606 " if (true) {\n" 6607 " a();\n" 6608 " b();\n" 6609 " }\n" 6610 " }\n" 6611 " void g()\n" 6612 " {\n" 6613 " return;\n" 6614 " }\n" 6615 "}\n" 6616 "}", 6617 BreakBeforeBrace); 6618 } 6619 6620 TEST_F(FormatTest, StroustrupBraceBreaking) { 6621 FormatStyle BreakBeforeBrace = getLLVMStyle(); 6622 BreakBeforeBrace.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 6623 verifyFormat("namespace a {\n" 6624 "class A {\n" 6625 " void f()\n" 6626 " {\n" 6627 " if (true) {\n" 6628 " a();\n" 6629 " b();\n" 6630 " }\n" 6631 " }\n" 6632 " void g()\n" 6633 " {\n" 6634 " return;\n" 6635 " }\n" 6636 "}\n" 6637 "}", 6638 BreakBeforeBrace); 6639 } 6640 6641 TEST_F(FormatTest, AllmanBraceBreaking) { 6642 FormatStyle BreakBeforeBrace = getLLVMStyle(); 6643 BreakBeforeBrace.BreakBeforeBraces = FormatStyle::BS_Allman; 6644 verifyFormat("namespace a\n" 6645 "{\n" 6646 "class A\n" 6647 "{\n" 6648 " void f()\n" 6649 " {\n" 6650 " if (true)\n" 6651 " {\n" 6652 " a();\n" 6653 " b();\n" 6654 " }\n" 6655 " }\n" 6656 " void g()\n" 6657 " {\n" 6658 " return;\n" 6659 " }\n" 6660 "}\n" 6661 "}", 6662 BreakBeforeBrace); 6663 6664 verifyFormat("void f()\n" 6665 "{\n" 6666 " if (true)\n" 6667 " {\n" 6668 " a();\n" 6669 " }\n" 6670 " else if (false)\n" 6671 " {\n" 6672 " b();\n" 6673 " }\n" 6674 " else\n" 6675 " {\n" 6676 " c();\n" 6677 " }\n" 6678 "}\n", 6679 BreakBeforeBrace); 6680 6681 verifyFormat("void f()\n" 6682 "{\n" 6683 " for (int i = 0; i < 10; ++i)\n" 6684 " {\n" 6685 " a();\n" 6686 " }\n" 6687 " while (false)\n" 6688 " {\n" 6689 " b();\n" 6690 " }\n" 6691 " do\n" 6692 " {\n" 6693 " c();\n" 6694 " } while (false)\n" 6695 "}\n", 6696 BreakBeforeBrace); 6697 6698 verifyFormat("void f(int a)\n" 6699 "{\n" 6700 " switch (a)\n" 6701 " {\n" 6702 " case 0:\n" 6703 " break;\n" 6704 " case 1:\n" 6705 " {\n" 6706 " break;\n" 6707 " }\n" 6708 " case 2:\n" 6709 " {\n" 6710 " }\n" 6711 " break;\n" 6712 " default:\n" 6713 " break;\n" 6714 " }\n" 6715 "}\n", 6716 BreakBeforeBrace); 6717 6718 verifyFormat("enum X\n" 6719 "{\n" 6720 " Y = 0,\n" 6721 "}\n", 6722 BreakBeforeBrace); 6723 6724 FormatStyle BreakBeforeBraceShortIfs = BreakBeforeBrace; 6725 BreakBeforeBraceShortIfs.AllowShortIfStatementsOnASingleLine = true; 6726 BreakBeforeBraceShortIfs.AllowShortLoopsOnASingleLine = true; 6727 verifyFormat("void f(bool b)\n" 6728 "{\n" 6729 " if (b)\n" 6730 " {\n" 6731 " return;\n" 6732 " }\n" 6733 "}\n", 6734 BreakBeforeBraceShortIfs); 6735 verifyFormat("void f(bool b)\n" 6736 "{\n" 6737 " if (b) return;\n" 6738 "}\n", 6739 BreakBeforeBraceShortIfs); 6740 verifyFormat("void f(bool b)\n" 6741 "{\n" 6742 " while (b)\n" 6743 " {\n" 6744 " return;\n" 6745 " }\n" 6746 "}\n", 6747 BreakBeforeBraceShortIfs); 6748 } 6749 6750 TEST_F(FormatTest, CatchExceptionReferenceBinding) { 6751 verifyFormat("void f() {\n" 6752 " try {\n" 6753 " }\n" 6754 " catch (const Exception &e) {\n" 6755 " }\n" 6756 "}\n", 6757 getLLVMStyle()); 6758 } 6759 6760 TEST_F(FormatTest, UnderstandsPragmas) { 6761 verifyFormat("#pragma omp reduction(| : var)"); 6762 verifyFormat("#pragma omp reduction(+ : var)"); 6763 } 6764 6765 bool allStylesEqual(ArrayRef<FormatStyle> Styles) { 6766 for (size_t i = 1; i < Styles.size(); ++i) 6767 if (!(Styles[0] == Styles[i])) 6768 return false; 6769 return true; 6770 } 6771 6772 TEST_F(FormatTest, GetsPredefinedStyleByName) { 6773 FormatStyle Styles[3]; 6774 6775 Styles[0] = getLLVMStyle(); 6776 EXPECT_TRUE(getPredefinedStyle("LLVM", &Styles[1])); 6777 EXPECT_TRUE(getPredefinedStyle("lLvM", &Styles[2])); 6778 EXPECT_TRUE(allStylesEqual(Styles)); 6779 6780 Styles[0] = getGoogleStyle(); 6781 EXPECT_TRUE(getPredefinedStyle("Google", &Styles[1])); 6782 EXPECT_TRUE(getPredefinedStyle("gOOgle", &Styles[2])); 6783 EXPECT_TRUE(allStylesEqual(Styles)); 6784 6785 Styles[0] = getChromiumStyle(); 6786 EXPECT_TRUE(getPredefinedStyle("Chromium", &Styles[1])); 6787 EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", &Styles[2])); 6788 EXPECT_TRUE(allStylesEqual(Styles)); 6789 6790 Styles[0] = getMozillaStyle(); 6791 EXPECT_TRUE(getPredefinedStyle("Mozilla", &Styles[1])); 6792 EXPECT_TRUE(getPredefinedStyle("moZILla", &Styles[2])); 6793 EXPECT_TRUE(allStylesEqual(Styles)); 6794 6795 Styles[0] = getWebKitStyle(); 6796 EXPECT_TRUE(getPredefinedStyle("WebKit", &Styles[1])); 6797 EXPECT_TRUE(getPredefinedStyle("wEbKit", &Styles[2])); 6798 EXPECT_TRUE(allStylesEqual(Styles)); 6799 6800 EXPECT_FALSE(getPredefinedStyle("qwerty", &Styles[0])); 6801 } 6802 6803 TEST_F(FormatTest, ParsesConfiguration) { 6804 FormatStyle Style = {}; 6805 #define CHECK_PARSE(TEXT, FIELD, VALUE) \ 6806 EXPECT_NE(VALUE, Style.FIELD); \ 6807 EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ 6808 EXPECT_EQ(VALUE, Style.FIELD) 6809 6810 #define CHECK_PARSE_BOOL(FIELD) \ 6811 Style.FIELD = false; \ 6812 EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value()); \ 6813 EXPECT_TRUE(Style.FIELD); \ 6814 EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value()); \ 6815 EXPECT_FALSE(Style.FIELD); 6816 6817 CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft); 6818 CHECK_PARSE_BOOL(AlignTrailingComments); 6819 CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); 6820 CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); 6821 CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine); 6822 CHECK_PARSE_BOOL(AlwaysBreakTemplateDeclarations); 6823 CHECK_PARSE_BOOL(BinPackParameters); 6824 CHECK_PARSE_BOOL(BreakBeforeBinaryOperators); 6825 CHECK_PARSE_BOOL(BreakBeforeTernaryOperators); 6826 CHECK_PARSE_BOOL(BreakConstructorInitializersBeforeComma); 6827 CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); 6828 CHECK_PARSE_BOOL(DerivePointerBinding); 6829 CHECK_PARSE_BOOL(IndentCaseLabels); 6830 CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); 6831 CHECK_PARSE_BOOL(PointerBindsToType); 6832 CHECK_PARSE_BOOL(Cpp11BracedListStyle); 6833 CHECK_PARSE_BOOL(IndentFunctionDeclarationAfterType); 6834 CHECK_PARSE_BOOL(SpacesInParentheses); 6835 CHECK_PARSE_BOOL(SpacesInAngles); 6836 CHECK_PARSE_BOOL(SpaceInEmptyParentheses); 6837 CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); 6838 CHECK_PARSE_BOOL(SpaceAfterControlStatementKeyword); 6839 CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); 6840 6841 CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); 6842 CHECK_PARSE("ConstructorInitializerIndentWidth: 1234", 6843 ConstructorInitializerIndentWidth, 1234u); 6844 CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); 6845 CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); 6846 CHECK_PARSE("PenaltyBreakBeforeFirstCallParameter: 1234", 6847 PenaltyBreakBeforeFirstCallParameter, 1234u); 6848 CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); 6849 CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", 6850 PenaltyReturnTypeOnItsOwnLine, 1234u); 6851 CHECK_PARSE("SpacesBeforeTrailingComments: 1234", 6852 SpacesBeforeTrailingComments, 1234u); 6853 CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u); 6854 CHECK_PARSE("ContinuationIndentWidth: 11", ContinuationIndentWidth, 11u); 6855 6856 Style.Standard = FormatStyle::LS_Auto; 6857 CHECK_PARSE("Standard: Cpp03", Standard, FormatStyle::LS_Cpp03); 6858 CHECK_PARSE("Standard: Cpp11", Standard, FormatStyle::LS_Cpp11); 6859 CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); 6860 CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); 6861 CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); 6862 6863 Style.UseTab = FormatStyle::UT_ForIndentation; 6864 CHECK_PARSE("UseTab: false", UseTab, FormatStyle::UT_Never); 6865 CHECK_PARSE("UseTab: true", UseTab, FormatStyle::UT_Always); 6866 CHECK_PARSE("UseTab: Never", UseTab, FormatStyle::UT_Never); 6867 CHECK_PARSE("UseTab: ForIndentation", UseTab, FormatStyle::UT_ForIndentation); 6868 CHECK_PARSE("UseTab: Always", UseTab, FormatStyle::UT_Always); 6869 6870 Style.ColumnLimit = 123; 6871 FormatStyle BaseStyle = getLLVMStyle(); 6872 CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); 6873 CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); 6874 6875 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 6876 CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, 6877 FormatStyle::BS_Attach); 6878 CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces, 6879 FormatStyle::BS_Linux); 6880 CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces, 6881 FormatStyle::BS_Stroustrup); 6882 6883 Style.NamespaceIndentation = FormatStyle::NI_All; 6884 CHECK_PARSE("NamespaceIndentation: None", NamespaceIndentation, 6885 FormatStyle::NI_None); 6886 CHECK_PARSE("NamespaceIndentation: Inner", NamespaceIndentation, 6887 FormatStyle::NI_Inner); 6888 CHECK_PARSE("NamespaceIndentation: All", NamespaceIndentation, 6889 FormatStyle::NI_All); 6890 6891 #undef CHECK_PARSE 6892 #undef CHECK_PARSE_BOOL 6893 } 6894 6895 TEST_F(FormatTest, ConfigurationRoundTripTest) { 6896 FormatStyle Style = getLLVMStyle(); 6897 std::string YAML = configurationAsText(Style); 6898 FormatStyle ParsedStyle = {}; 6899 EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); 6900 EXPECT_EQ(Style, ParsedStyle); 6901 } 6902 6903 TEST_F(FormatTest, WorksFor8bitEncodings) { 6904 EXPECT_EQ("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 \"\n" 6905 "\"\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \"\n" 6906 "\"\xe7\xe8\xec\xed\xfe\xfe \"\n" 6907 "\"\xef\xee\xf0\xf3...\"", 6908 format("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 " 6909 "\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \xe7\xe8\xec\xed\xfe\xfe " 6910 "\xef\xee\xf0\xf3...\"", 6911 getLLVMStyleWithColumns(12))); 6912 } 6913 6914 TEST_F(FormatTest, HandlesUTF8BOM) { 6915 EXPECT_EQ("\xef\xbb\xbf", format("\xef\xbb\xbf")); 6916 EXPECT_EQ("\xef\xbb\xbf#include <iostream>", 6917 format("\xef\xbb\xbf#include <iostream>")); 6918 EXPECT_EQ("\xef\xbb\xbf\n#include <iostream>", 6919 format("\xef\xbb\xbf\n#include <iostream>")); 6920 } 6921 6922 // FIXME: Encode Cyrillic and CJK characters below to appease MS compilers. 6923 #if !defined(_MSC_VER) 6924 6925 TEST_F(FormatTest, CountsUTF8CharactersProperly) { 6926 verifyFormat("\"Однажды в студёную зимнюю пору...\"", 6927 getLLVMStyleWithColumns(35)); 6928 verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", 6929 getLLVMStyleWithColumns(31)); 6930 verifyFormat("// Однажды в студёную зимнюю пору...", 6931 getLLVMStyleWithColumns(36)); 6932 verifyFormat("// 一 二 三 四 五 六 七 八 九 十", 6933 getLLVMStyleWithColumns(32)); 6934 verifyFormat("/* Однажды в студёную зимнюю пору... */", 6935 getLLVMStyleWithColumns(39)); 6936 verifyFormat("/* 一 二 三 四 五 六 七 八 九 十 */", 6937 getLLVMStyleWithColumns(35)); 6938 } 6939 6940 TEST_F(FormatTest, SplitsUTF8Strings) { 6941 EXPECT_EQ( 6942 "\"Однажды, в \"\n" 6943 "\"студёную \"\n" 6944 "\"зимнюю \"\n" 6945 "\"пору,\"", 6946 format("\"Однажды, в студёную зимнюю пору,\"", 6947 getLLVMStyleWithColumns(13))); 6948 EXPECT_EQ("\"一 二 三 \"\n" 6949 "\"四 五六 \"\n" 6950 "\"七 八 九 \"\n" 6951 "\"十\"", 6952 format("\"一 二 三 四 五六 七 八 九 十\"", 6953 getLLVMStyleWithColumns(11))); 6954 EXPECT_EQ("\"一\t二 \"\n" 6955 "\"\t三 \"\n" 6956 "\"四 五\t六 \"\n" 6957 "\"\t七 \"\n" 6958 "\"八九十\tqq\"", 6959 format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"", 6960 getLLVMStyleWithColumns(11))); 6961 } 6962 6963 6964 TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) { 6965 EXPECT_EQ("const char *sssss =\n" 6966 " \"一二三四五六七八\\\n" 6967 " 九 十\";", 6968 format("const char *sssss = \"一二三四五六七八\\\n" 6969 " 九 十\";", 6970 getLLVMStyleWithColumns(30))); 6971 } 6972 6973 TEST_F(FormatTest, SplitsUTF8LineComments) { 6974 EXPECT_EQ("// Я из лесу\n" 6975 "// вышел; был\n" 6976 "// сильный\n" 6977 "// мороз.", 6978 format("// Я из лесу вышел; был сильный мороз.", 6979 getLLVMStyleWithColumns(13))); 6980 EXPECT_EQ("// 一二三\n" 6981 "// 四五六七\n" 6982 "// 八 九\n" 6983 "// 十", 6984 format("// 一二三 四五六七 八 九 十", getLLVMStyleWithColumns(9))); 6985 } 6986 6987 TEST_F(FormatTest, SplitsUTF8BlockComments) { 6988 EXPECT_EQ("/* Гляжу,\n" 6989 " * поднимается\n" 6990 " * медленно в\n" 6991 " * гору\n" 6992 " * Лошадка,\n" 6993 " * везущая\n" 6994 " * хворосту\n" 6995 " * воз. */", 6996 format("/* Гляжу, поднимается медленно в гору\n" 6997 " * Лошадка, везущая хворосту воз. */", 6998 getLLVMStyleWithColumns(13))); 6999 EXPECT_EQ( 7000 "/* 一二三\n" 7001 " * 四五六七\n" 7002 " * 八 九\n" 7003 " * 十 */", 7004 format("/* 一二三 四五六七 八 九 十 */", getLLVMStyleWithColumns(9))); 7005 EXPECT_EQ("/* �������� ��������\n" 7006 " * ��������\n" 7007 " * ������-�� */", 7008 format("/* �������� �������� �������� ������-�� */", getLLVMStyleWithColumns(12))); 7009 } 7010 7011 #endif // _MSC_VER 7012 7013 TEST_F(FormatTest, ConstructorInitializerIndentWidth) { 7014 FormatStyle Style = getLLVMStyle(); 7015 7016 Style.ConstructorInitializerIndentWidth = 4; 7017 verifyFormat( 7018 "SomeClass::Constructor()\n" 7019 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 7020 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 7021 Style); 7022 7023 Style.ConstructorInitializerIndentWidth = 2; 7024 verifyFormat( 7025 "SomeClass::Constructor()\n" 7026 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 7027 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 7028 Style); 7029 7030 Style.ConstructorInitializerIndentWidth = 0; 7031 verifyFormat( 7032 "SomeClass::Constructor()\n" 7033 ": aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 7034 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 7035 Style); 7036 7037 Style.BreakConstructorInitializersBeforeComma = true; 7038 Style.ConstructorInitializerIndentWidth = 4; 7039 verifyFormat("SomeClass::Constructor()\n" 7040 " : a(a)\n" 7041 " , b(b)\n" 7042 " , c(c) {}", 7043 Style); 7044 7045 Style.ConstructorInitializerIndentWidth = 2; 7046 verifyFormat("SomeClass::Constructor()\n" 7047 " : a(a)\n" 7048 " , b(b)\n" 7049 " , c(c) {}", 7050 Style); 7051 7052 Style.ConstructorInitializerIndentWidth = 0; 7053 verifyFormat("SomeClass::Constructor()\n" 7054 ": a(a)\n" 7055 ", b(b)\n" 7056 ", c(c) {}", 7057 Style); 7058 7059 Style.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 7060 Style.ConstructorInitializerIndentWidth = 4; 7061 verifyFormat( 7062 "SomeClass::Constructor()\n" 7063 " : aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa) {}", 7064 Style); 7065 Style.ConstructorInitializerIndentWidth = 4; 7066 Style.ColumnLimit = 60; 7067 verifyFormat("SomeClass::Constructor()\n" 7068 " : aaaaaaaa(aaaaaaaa)\n" 7069 " , aaaaaaaa(aaaaaaaa)\n" 7070 " , aaaaaaaa(aaaaaaaa) {}", 7071 Style); 7072 } 7073 7074 TEST_F(FormatTest, FormatsWithWebKitStyle) { 7075 FormatStyle Style = getWebKitStyle(); 7076 7077 // Don't indent in outer namespaces. 7078 verifyFormat("namespace outer {\n" 7079 "int i;\n" 7080 "namespace inner {\n" 7081 " int i;\n" 7082 "} // namespace inner\n" 7083 "} // namespace outer\n" 7084 "namespace other_outer {\n" 7085 "int i;\n" 7086 "}", 7087 Style); 7088 7089 // Don't indent case labels. 7090 verifyFormat("switch (variable) {\n" 7091 "case 1:\n" 7092 "case 2:\n" 7093 " doSomething();\n" 7094 " break;\n" 7095 "default:\n" 7096 " ++variable;\n" 7097 "}", 7098 Style); 7099 7100 // Wrap before binary operators. 7101 EXPECT_EQ( 7102 "void f()\n" 7103 "{\n" 7104 " if (aaaaaaaaaaaaaaaa\n" 7105 " && bbbbbbbbbbbbbbbbbbbbbbbb\n" 7106 " && (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 7107 " return;\n" 7108 "}", 7109 format( 7110 "void f() {\n" 7111 "if (aaaaaaaaaaaaaaaa\n" 7112 "&& bbbbbbbbbbbbbbbbbbbbbbbb\n" 7113 "&& (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 7114 "return;\n" 7115 "}", 7116 Style)); 7117 7118 // Constructor initializers are formatted one per line with the "," on the 7119 // new line. 7120 verifyFormat("Constructor()\n" 7121 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 7122 " , aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaa, // break\n" 7123 " aaaaaaaaaaaaaa)\n" 7124 " , aaaaaaaaaaaaaaaaaaaaaaa()\n{\n}", 7125 Style); 7126 7127 // Access specifiers should be aligned left. 7128 verifyFormat("class C {\n" 7129 "public:\n" 7130 " int i;\n" 7131 "};", 7132 Style); 7133 7134 // Do not align comments. 7135 verifyFormat("int a; // Do not\n" 7136 "double b; // align comments.", 7137 Style); 7138 7139 // Accept input's line breaks. 7140 EXPECT_EQ("if (aaaaaaaaaaaaaaa\n" 7141 " || bbbbbbbbbbbbbbb) {\n" 7142 " i++;\n" 7143 "}", 7144 format("if (aaaaaaaaaaaaaaa\n" 7145 "|| bbbbbbbbbbbbbbb) { i++; }", 7146 Style)); 7147 EXPECT_EQ("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) {\n" 7148 " i++;\n" 7149 "}", 7150 format("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) { i++; }", Style)); 7151 7152 // Don't automatically break all macro definitions (llvm.org/PR17842). 7153 verifyFormat("#define aNumber 10", Style); 7154 // However, generally keep the line breaks that the user authored. 7155 EXPECT_EQ("#define aNumber \\\n" 7156 " 10", 7157 format("#define aNumber \\\n" 7158 " 10", 7159 Style)); 7160 } 7161 7162 TEST_F(FormatTest, FormatsProtocolBufferDefinitions) { 7163 // It seems that clang-format can format protocol buffer definitions 7164 // (see https://code.google.com/p/protobuf/). 7165 verifyFormat("message SomeMessage {\n" 7166 " required int32 field1 = 1;\n" 7167 " optional string field2 = 2 [default = \"2\"]\n" 7168 "}"); 7169 } 7170 7171 TEST_F(FormatTest, FormatsLambdas) { 7172 verifyFormat("int c = [b]() mutable {\n" 7173 " return [&b] { return b++; }();\n" 7174 "}();\n"); 7175 verifyFormat("int c = [&] {\n" 7176 " [=] { return b++; }();\n" 7177 "}();\n"); 7178 verifyFormat("int c = [&, &a, a] {\n" 7179 " [=, c, &d] { return b++; }();\n" 7180 "}();\n"); 7181 verifyFormat("int c = [&a, &a, a] {\n" 7182 " [=, a, b, &c] { return b++; }();\n" 7183 "}();\n"); 7184 verifyFormat("auto c = { [&a, &a, a] {\n" 7185 " [=, a, b, &c] { return b++; }();\n" 7186 "} }\n"); 7187 verifyFormat("auto c = { [&a, &a, a] { [=, a, b, &c] {}(); } }\n"); 7188 verifyFormat("void f() {\n" 7189 " other(x.begin(), x.end(), [&](int, int) { return 1; });\n" 7190 "}\n"); 7191 verifyFormat("void f() {\n" 7192 " other(x.begin(), //\n" 7193 " x.end(), //\n" 7194 " [&](int, int) { return 1; });\n" 7195 "}\n"); 7196 7197 // Not lambdas. 7198 verifyFormat("constexpr char hello[]{ \"hello\" };"); 7199 verifyFormat("double &operator[](int i) { return 0; }\n" 7200 "int i;"); 7201 } 7202 7203 TEST_F(FormatTest, FormatsBlocks) { 7204 // FIXME: Make whitespace formatting consistent. Ask a ObjC dev how 7205 // it would ideally look. 7206 verifyFormat("[operation setCompletionBlock:^{ [self onOperationDone]; }];"); 7207 verifyFormat("int i = {[operation setCompletionBlock : ^{ [self " 7208 "onOperationDone]; }] };"); 7209 } 7210 7211 TEST_F(FormatTest, SupportsCRLF) { 7212 EXPECT_EQ("int a;\r\n" 7213 "int b;\r\n" 7214 "int c;\r\n", 7215 format("int a;\r\n" 7216 " int b;\r\n" 7217 " int c;\r\n", 7218 getLLVMStyle())); 7219 EXPECT_EQ("int a;\r\n" 7220 "int b;\r\n" 7221 "int c;\r\n", 7222 format("int a;\r\n" 7223 " int b;\n" 7224 " int c;\r\n", 7225 getLLVMStyle())); 7226 EXPECT_EQ("int a;\n" 7227 "int b;\n" 7228 "int c;\n", 7229 format("int a;\r\n" 7230 " int b;\n" 7231 " int c;\n", 7232 getLLVMStyle())); 7233 EXPECT_EQ("\"aaaaaaa \"\r\n" 7234 "\"bbbbbbb\";\r\n", 7235 format("\"aaaaaaa bbbbbbb\";\r\n", getLLVMStyleWithColumns(10))); 7236 EXPECT_EQ("#define A \\\r\n" 7237 " b; \\\r\n" 7238 " c; \\\r\n" 7239 " d;\r\n", 7240 format("#define A \\\r\n" 7241 " b; \\\r\n" 7242 " c; d; \r\n", 7243 getGoogleStyle())); 7244 7245 EXPECT_EQ("/*\r\n" 7246 "multi line block comments\r\n" 7247 "should not introduce\r\n" 7248 "an extra carriage return\r\n" 7249 "*/\r\n", 7250 format("/*\r\n" 7251 "multi line block comments\r\n" 7252 "should not introduce\r\n" 7253 "an extra carriage return\r\n" 7254 "*/\r\n")); 7255 } 7256 7257 TEST_F(FormatTest, MunchSemicolonAfterBlocks) { 7258 verifyFormat("MY_CLASS(C) {\n" 7259 " int i;\n" 7260 " int j;\n" 7261 "};"); 7262 } 7263 7264 TEST_F(FormatTest, ConfigurableContinuationIndentWidth) { 7265 FormatStyle TwoIndent = getLLVMStyleWithColumns(15); 7266 TwoIndent.ContinuationIndentWidth = 2; 7267 7268 EXPECT_EQ("int i =\n" 7269 " longFunction(\n" 7270 " arg);", 7271 format("int i = longFunction(arg);", TwoIndent)); 7272 7273 FormatStyle SixIndent = getLLVMStyleWithColumns(20); 7274 SixIndent.ContinuationIndentWidth = 6; 7275 7276 EXPECT_EQ("int i =\n" 7277 " longFunction(\n" 7278 " arg);", 7279 format("int i = longFunction(arg);", SixIndent)); 7280 } 7281 7282 TEST_F(FormatTest, SpacesInAngles) { 7283 FormatStyle Spaces = getLLVMStyle(); 7284 Spaces.SpacesInAngles = true; 7285 7286 verifyFormat("static_cast< int >(arg);", Spaces); 7287 verifyFormat("template < typename T0, typename T1 > void f() {}", Spaces); 7288 verifyFormat("f< int, float >();", Spaces); 7289 verifyFormat("template <> g() {}", Spaces); 7290 verifyFormat("template < std::vector< int > > f() {}", Spaces); 7291 7292 Spaces.Standard = FormatStyle::LS_Cpp03; 7293 Spaces.SpacesInAngles = true; 7294 verifyFormat("A< A< int > >();", Spaces); 7295 7296 Spaces.SpacesInAngles = false; 7297 verifyFormat("A<A<int> >();", Spaces); 7298 7299 Spaces.Standard = FormatStyle::LS_Cpp11; 7300 Spaces.SpacesInAngles = true; 7301 verifyFormat("A< A< int > >();", Spaces); 7302 7303 Spaces.SpacesInAngles = false; 7304 verifyFormat("A<A<int>>();", Spaces); 7305 } 7306 7307 } // end namespace tooling 7308 } // end namespace clang 7309