xref: /llvm-project/llvm/lib/Transforms/Scalar/MergeICmps.cpp (revision 0272cb077f4da79a7ac23c4079a29aaa517c2d7f)
1 //===- MergeICmps.cpp - Optimize chains of integer comparisons ------------===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 // This pass turns chains of integer comparisons into memcmp (the memcmp is
11 // later typically inlined as a chain of efficient hardware comparisons). This
12 // typically benefits c++ member or nonmember operator==().
13 //
14 // The basic idea is to replace a larger chain of integer comparisons loaded
15 // from contiguous memory locations into a smaller chain of such integer
16 // comparisons. Benefits are double:
17 //  - There are less jumps, and therefore less opportunities for mispredictions
18 //    and I-cache misses.
19 //  - Code size is smaller, both because jumps are removed and because the
20 //    encoding of a 2*n byte compare is smaller than that of two n-byte
21 //    compares.
22 
23 //===----------------------------------------------------------------------===//
24 
25 #include <algorithm>
26 #include <numeric>
27 #include <utility>
28 #include <vector>
29 #include "llvm/Analysis/Loads.h"
30 #include "llvm/Analysis/TargetLibraryInfo.h"
31 #include "llvm/Analysis/TargetTransformInfo.h"
32 #include "llvm/IR/Function.h"
33 #include "llvm/IR/IRBuilder.h"
34 #include "llvm/Pass.h"
35 #include "llvm/Transforms/Scalar.h"
36 #include "llvm/Transforms/Utils/BuildLibCalls.h"
37 
38 using namespace llvm;
39 
40 namespace {
41 
42 #define DEBUG_TYPE "mergeicmps"
43 
44 // A BCE atom.
45 struct BCEAtom {
46   BCEAtom() : GEP(nullptr), LoadI(nullptr), Offset() {}
47 
48   const Value *Base() const { return GEP ? GEP->getPointerOperand() : nullptr; }
49 
50   bool operator<(const BCEAtom &O) const {
51     assert(Base() && "invalid atom");
52     assert(O.Base() && "invalid atom");
53     // Just ordering by (Base(), Offset) is sufficient. However because this
54     // means that the ordering will depend on the addresses of the base
55     // values, which are not reproducible from run to run. To guarantee
56     // stability, we use the names of the values if they exist; we sort by:
57     // (Base.getName(), Base(), Offset).
58     const int NameCmp = Base()->getName().compare(O.Base()->getName());
59     if (NameCmp == 0) {
60       if (Base() == O.Base()) {
61         return Offset.slt(O.Offset);
62       }
63       return Base() < O.Base();
64     }
65     return NameCmp < 0;
66   }
67 
68   GetElementPtrInst *GEP;
69   LoadInst *LoadI;
70   APInt Offset;
71 };
72 
73 // If this value is a load from a constant offset w.r.t. a base address, and
74 // there are no other users of the load or address, returns the base address and
75 // the offset.
76 BCEAtom visitICmpLoadOperand(Value *const Val) {
77   BCEAtom Result;
78   if (auto *const LoadI = dyn_cast<LoadInst>(Val)) {
79     DEBUG(dbgs() << "load\n");
80     if (LoadI->isUsedOutsideOfBlock(LoadI->getParent())) {
81       DEBUG(dbgs() << "used outside of block\n");
82       return {};
83     }
84     if (LoadI->isVolatile()) {
85       DEBUG(dbgs() << "volatile\n");
86       return {};
87     }
88     Value *const Addr = LoadI->getOperand(0);
89     if (auto *const GEP = dyn_cast<GetElementPtrInst>(Addr)) {
90       DEBUG(dbgs() << "GEP\n");
91       if (LoadI->isUsedOutsideOfBlock(LoadI->getParent())) {
92         DEBUG(dbgs() << "used outside of block\n");
93         return {};
94       }
95       const auto &DL = GEP->getModule()->getDataLayout();
96       if (!isDereferenceablePointer(GEP, DL)) {
97         DEBUG(dbgs() << "not dereferenceable\n");
98         // We need to make sure that we can do comparison in any order, so we
99         // require memory to be unconditionnally dereferencable.
100         return {};
101       }
102       Result.Offset = APInt(DL.getPointerTypeSizeInBits(GEP->getType()), 0);
103       if (GEP->accumulateConstantOffset(DL, Result.Offset)) {
104         Result.GEP = GEP;
105         Result.LoadI = LoadI;
106       }
107     }
108   }
109   return Result;
110 }
111 
112 // A basic block with a comparison between two BCE atoms.
113 // Note: the terminology is misleading: the comparison is symmetric, so there
114 // is no real {l/r}hs. What we want though is to have the same base on the
115 // left (resp. right), so that we can detect consecutive loads. To ensure this
116 // we put the smallest atom on the left.
117 class BCECmpBlock {
118  public:
119   BCECmpBlock() {}
120 
121   BCECmpBlock(BCEAtom L, BCEAtom R, int SizeBits)
122       : Lhs_(L), Rhs_(R), SizeBits_(SizeBits) {
123     if (Rhs_ < Lhs_) std::swap(Rhs_, Lhs_);
124   }
125 
126   bool IsValid() const {
127     return Lhs_.Base() != nullptr && Rhs_.Base() != nullptr;
128   }
129 
130   // Assert the block is consistent: If valid, it should also have
131   // non-null members besides Lhs_ and Rhs_.
132   void AssertConsistent() const {
133     if (IsValid()) {
134       assert(BB);
135       assert(CmpI);
136       assert(BranchI);
137     }
138   }
139 
140   const BCEAtom &Lhs() const { return Lhs_; }
141   const BCEAtom &Rhs() const { return Rhs_; }
142   int SizeBits() const { return SizeBits_; }
143 
144   // Returns true if the block does other works besides comparison.
145   bool doesOtherWork() const;
146 
147   // The basic block where this comparison happens.
148   BasicBlock *BB = nullptr;
149   // The ICMP for this comparison.
150   ICmpInst *CmpI = nullptr;
151   // The terminating branch.
152   BranchInst *BranchI = nullptr;
153 
154  private:
155   BCEAtom Lhs_;
156   BCEAtom Rhs_;
157   int SizeBits_ = 0;
158 };
159 
160 bool BCECmpBlock::doesOtherWork() const {
161   AssertConsistent();
162   // All the instructions we care about in the BCE cmp block.
163   DenseSet<Instruction *> BlockInsts(
164       {Lhs_.GEP, Rhs_.GEP, Lhs_.LoadI, Rhs_.LoadI, CmpI, BranchI});
165   // TODO(courbet): Can we allow some other things ? This is very conservative.
166   // We might be able to get away with anything does does not have any side
167   // effects outside of the basic block.
168   // Note: The GEPs and/or loads are not necessarily in the same block.
169   for (const Instruction &Inst : *BB) {
170     if (!BlockInsts.count(&Inst))
171       return true;
172   }
173   return false;
174 }
175 
176 // Visit the given comparison. If this is a comparison between two valid
177 // BCE atoms, returns the comparison.
178 BCECmpBlock visitICmp(const ICmpInst *const CmpI,
179                       const ICmpInst::Predicate ExpectedPredicate) {
180   // The comparison can only be used once:
181   //  - For intermediate blocks, as a branch condition.
182   //  - For the final block, as an incoming value for the Phi.
183   // If there are any other uses of the comparison, we cannot merge it with
184   // other comparisons as we would create an orphan use of the value.
185   if (!CmpI->hasOneUse()) {
186     DEBUG(dbgs() << "cmp has several uses\n");
187     return {};
188   }
189   if (CmpI->getPredicate() == ExpectedPredicate) {
190     DEBUG(dbgs() << "cmp "
191                  << (ExpectedPredicate == ICmpInst::ICMP_EQ ? "eq" : "ne")
192                  << "\n");
193     auto Lhs = visitICmpLoadOperand(CmpI->getOperand(0));
194     if (!Lhs.Base()) return {};
195     auto Rhs = visitICmpLoadOperand(CmpI->getOperand(1));
196     if (!Rhs.Base()) return {};
197     return BCECmpBlock(std::move(Lhs), std::move(Rhs),
198                        CmpI->getOperand(0)->getType()->getScalarSizeInBits());
199   }
200   return {};
201 }
202 
203 // Visit the given comparison block. If this is a comparison between two valid
204 // BCE atoms, returns the comparison.
205 BCECmpBlock visitCmpBlock(Value *const Val, BasicBlock *const Block,
206                           const BasicBlock *const PhiBlock) {
207   if (Block->empty()) return {};
208   auto *const BranchI = dyn_cast<BranchInst>(Block->getTerminator());
209   if (!BranchI) return {};
210   DEBUG(dbgs() << "branch\n");
211   if (BranchI->isUnconditional()) {
212     // In this case, we expect an incoming value which is the result of the
213     // comparison. This is the last link in the chain of comparisons (note
214     // that this does not mean that this is the last incoming value, blocks
215     // can be reordered).
216     auto *const CmpI = dyn_cast<ICmpInst>(Val);
217     if (!CmpI) return {};
218     DEBUG(dbgs() << "icmp\n");
219     auto Result = visitICmp(CmpI, ICmpInst::ICMP_EQ);
220     Result.CmpI = CmpI;
221     Result.BranchI = BranchI;
222     return Result;
223   } else {
224     // In this case, we expect a constant incoming value (the comparison is
225     // chained).
226     const auto *const Const = dyn_cast<ConstantInt>(Val);
227     DEBUG(dbgs() << "const\n");
228     if (!Const->isZero()) return {};
229     DEBUG(dbgs() << "false\n");
230     auto *const CmpI = dyn_cast<ICmpInst>(BranchI->getCondition());
231     if (!CmpI) return {};
232     DEBUG(dbgs() << "icmp\n");
233     assert(BranchI->getNumSuccessors() == 2 && "expecting a cond branch");
234     BasicBlock *const FalseBlock = BranchI->getSuccessor(1);
235     auto Result = visitICmp(
236         CmpI, FalseBlock == PhiBlock ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE);
237     Result.CmpI = CmpI;
238     Result.BranchI = BranchI;
239     return Result;
240   }
241   return {};
242 }
243 
244 // A chain of comparisons.
245 class BCECmpChain {
246  public:
247   BCECmpChain(const std::vector<BasicBlock *> &Blocks, PHINode &Phi);
248 
249   int size() const { return Comparisons_.size(); }
250 
251 #ifdef MERGEICMPS_DOT_ON
252   void dump() const;
253 #endif  // MERGEICMPS_DOT_ON
254 
255   bool simplify(const TargetLibraryInfo *const TLI);
256 
257  private:
258   static bool IsContiguous(const BCECmpBlock &First,
259                            const BCECmpBlock &Second) {
260     return First.Lhs().Base() == Second.Lhs().Base() &&
261            First.Rhs().Base() == Second.Rhs().Base() &&
262            First.Lhs().Offset + First.SizeBits() / 8 == Second.Lhs().Offset &&
263            First.Rhs().Offset + First.SizeBits() / 8 == Second.Rhs().Offset;
264   }
265 
266   // Merges the given comparison blocks into one memcmp block and update
267   // branches. Comparisons are assumed to be continguous. If NextBBInChain is
268   // null, the merged block will link to the phi block.
269   static void mergeComparisons(ArrayRef<BCECmpBlock> Comparisons,
270                                BasicBlock *const NextBBInChain, PHINode &Phi,
271                                const TargetLibraryInfo *const TLI);
272 
273   PHINode &Phi_;
274   std::vector<BCECmpBlock> Comparisons_;
275   // The original entry block (before sorting);
276   BasicBlock *EntryBlock_;
277 };
278 
279 BCECmpChain::BCECmpChain(const std::vector<BasicBlock *> &Blocks, PHINode &Phi)
280     : Phi_(Phi) {
281   assert(!Blocks.empty() && "a chain should have at least one block");
282   // Now look inside blocks to check for BCE comparisons.
283   std::vector<BCECmpBlock> Comparisons;
284   for (size_t BlockIdx = 0; BlockIdx < Blocks.size(); ++BlockIdx) {
285     BasicBlock *const Block = Blocks[BlockIdx];
286     assert(Block && "invalid block");
287     BCECmpBlock Comparison = visitCmpBlock(Phi.getIncomingValueForBlock(Block),
288                                            Block, Phi.getParent());
289     Comparison.BB = Block;
290     if (!Comparison.IsValid()) {
291       DEBUG(dbgs() << "skip: not a valid BCECmpBlock\n");
292       return;
293     }
294     if (Comparison.doesOtherWork()) {
295       DEBUG(dbgs() << "block '" << Comparison.BB->getName()
296                    << "' does extra work besides compare\n");
297       if (Comparisons.empty()) {
298         // TODO(courbet): The initial block can do other things, and we should
299         // split them apart in a separate block before the comparison chain.
300         // Right now we just discard it and make the chain shorter.
301         DEBUG(dbgs()
302               << "ignoring initial block '" << Comparison.BB->getName()
303               << "' that does extra work besides compare\n");
304         continue;
305       }
306       // TODO(courbet): Right now we abort the whole chain. We could be
307       // merging only the blocks that don't do other work and resume the
308       // chain from there. For example:
309       //  if (a[0] == b[0]) {  // bb1
310       //    if (a[1] == b[1]) {  // bb2
311       //      some_value = 3; //bb3
312       //      if (a[2] == b[2]) { //bb3
313       //        do a ton of stuff  //bb4
314       //      }
315       //    }
316       //  }
317       //
318       // This is:
319       //
320       // bb1 --eq--> bb2 --eq--> bb3* -eq--> bb4 --+
321       //  \            \           \               \
322       //   ne           ne          ne              \
323       //    \            \           \               v
324       //     +------------+-----------+----------> bb_phi
325       //
326       // We can only merge the first two comparisons, because bb3* does
327       // "other work" (setting some_value to 3).
328       // We could still merge bb1 and bb2 though.
329       return;
330     }
331     DEBUG(dbgs() << "Block '" << Comparison.BB->getName()<< "': Found cmp of "
332                  << Comparison.SizeBits() << " bits between "
333                  << Comparison.Lhs().Base() << " + " << Comparison.Lhs().Offset
334                  << " and " << Comparison.Rhs().Base() << " + "
335                  << Comparison.Rhs().Offset << "\n");
336     DEBUG(dbgs() << "\n");
337     Comparisons.push_back(Comparison);
338   }
339 
340   // It is possible we have no suitable comparison to merge.
341   if (Comparisons.empty()) {
342     DEBUG(dbgs() << "chain with no BCE basic blocks, no merge\n");
343     return;
344   }
345   EntryBlock_ = Comparisons[0].BB;
346   Comparisons_ = std::move(Comparisons);
347 #ifdef MERGEICMPS_DOT_ON
348   errs() << "BEFORE REORDERING:\n\n";
349   dump();
350 #endif  // MERGEICMPS_DOT_ON
351   // Reorder blocks by LHS. We can do that without changing the
352   // semantics because we are only accessing dereferencable memory.
353   std::sort(Comparisons_.begin(), Comparisons_.end(),
354             [](const BCECmpBlock &a, const BCECmpBlock &b) {
355               return a.Lhs() < b.Lhs();
356             });
357 #ifdef MERGEICMPS_DOT_ON
358   errs() << "AFTER REORDERING:\n\n";
359   dump();
360 #endif  // MERGEICMPS_DOT_ON
361 }
362 
363 #ifdef MERGEICMPS_DOT_ON
364 void BCECmpChain::dump() const {
365   errs() << "digraph dag {\n";
366   errs() << " graph [bgcolor=transparent];\n";
367   errs() << " node [color=black,style=filled,fillcolor=lightyellow];\n";
368   errs() << " edge [color=black];\n";
369   for (size_t I = 0; I < Comparisons_.size(); ++I) {
370     const auto &Comparison = Comparisons_[I];
371     errs() << " \"" << I << "\" [label=\"%"
372            << Comparison.Lhs().Base()->getName() << " + "
373            << Comparison.Lhs().Offset << " == %"
374            << Comparison.Rhs().Base()->getName() << " + "
375            << Comparison.Rhs().Offset << " (" << (Comparison.SizeBits() / 8)
376            << " bytes)\"];\n";
377     const Value *const Val = Phi_.getIncomingValueForBlock(Comparison.BB);
378     if (I > 0) errs() << " \"" << (I - 1) << "\" -> \"" << I << "\";\n";
379     errs() << " \"" << I << "\" -> \"Phi\" [label=\"" << *Val << "\"];\n";
380   }
381   errs() << " \"Phi\" [label=\"Phi\"];\n";
382   errs() << "}\n\n";
383 }
384 #endif  // MERGEICMPS_DOT_ON
385 
386 bool BCECmpChain::simplify(const TargetLibraryInfo *const TLI) {
387   // First pass to check if there is at least one merge. If not, we don't do
388   // anything and we keep analysis passes intact.
389   {
390     bool AtLeastOneMerged = false;
391     for (size_t I = 1; I < Comparisons_.size(); ++I) {
392       if (IsContiguous(Comparisons_[I - 1], Comparisons_[I])) {
393         AtLeastOneMerged = true;
394         break;
395       }
396     }
397     if (!AtLeastOneMerged) return false;
398   }
399 
400   // Remove phi references to comparison blocks, they will be rebuilt as we
401   // merge the blocks.
402   for (const auto &Comparison : Comparisons_) {
403     Phi_.removeIncomingValue(Comparison.BB, false);
404   }
405 
406   // If entry block is part of the chain, we need to make the first block
407   // of the chain the new entry block of the function.
408   BasicBlock *Entry = &Comparisons_[0].BB->getParent()->getEntryBlock();
409   for (size_t I = 1; I < Comparisons_.size(); ++I) {
410     if (Entry == Comparisons_[I].BB) {
411       BasicBlock *NEntryBB = BasicBlock::Create(Entry->getContext(), "",
412                                                 Entry->getParent(), Entry);
413       BranchInst::Create(Entry, NEntryBB);
414       break;
415     }
416   }
417 
418   // Point the predecessors of the chain to the first comparison block (which is
419   // the new entry point).
420   if (EntryBlock_ != Comparisons_[0].BB)
421     EntryBlock_->replaceAllUsesWith(Comparisons_[0].BB);
422 
423   // Effectively merge blocks.
424   int NumMerged = 1;
425   for (size_t I = 1; I < Comparisons_.size(); ++I) {
426     if (IsContiguous(Comparisons_[I - 1], Comparisons_[I])) {
427       ++NumMerged;
428     } else {
429       // Merge all previous comparisons and start a new merge block.
430       mergeComparisons(
431           makeArrayRef(Comparisons_).slice(I - NumMerged, NumMerged),
432           Comparisons_[I].BB, Phi_, TLI);
433       NumMerged = 1;
434     }
435   }
436   mergeComparisons(makeArrayRef(Comparisons_)
437                        .slice(Comparisons_.size() - NumMerged, NumMerged),
438                    nullptr, Phi_, TLI);
439 
440   return true;
441 }
442 
443 void BCECmpChain::mergeComparisons(ArrayRef<BCECmpBlock> Comparisons,
444                                    BasicBlock *const NextBBInChain,
445                                    PHINode &Phi,
446                                    const TargetLibraryInfo *const TLI) {
447   assert(!Comparisons.empty());
448   const auto &FirstComparison = *Comparisons.begin();
449   BasicBlock *const BB = FirstComparison.BB;
450   LLVMContext &Context = BB->getContext();
451 
452   if (Comparisons.size() >= 2) {
453     DEBUG(dbgs() << "Merging " << Comparisons.size() << " comparisons\n");
454     const auto TotalSize =
455         std::accumulate(Comparisons.begin(), Comparisons.end(), 0,
456                         [](int Size, const BCECmpBlock &C) {
457                           return Size + C.SizeBits();
458                         }) /
459         8;
460 
461     // Incoming edges do not need to be updated, and both GEPs are already
462     // computing the right address, we just need to:
463     //   - replace the two loads and the icmp with the memcmp
464     //   - update the branch
465     //   - update the incoming values in the phi.
466     FirstComparison.BranchI->eraseFromParent();
467     FirstComparison.CmpI->eraseFromParent();
468     FirstComparison.Lhs().LoadI->eraseFromParent();
469     FirstComparison.Rhs().LoadI->eraseFromParent();
470 
471     IRBuilder<> Builder(BB);
472     const auto &DL = Phi.getModule()->getDataLayout();
473     Value *const MemCmpCall = emitMemCmp(
474         FirstComparison.Lhs().GEP, FirstComparison.Rhs().GEP,
475         ConstantInt::get(DL.getIntPtrType(Context), TotalSize),
476         Builder, DL, TLI);
477     Value *const MemCmpIsZero = Builder.CreateICmpEQ(
478         MemCmpCall, ConstantInt::get(Type::getInt32Ty(Context), 0));
479 
480     // Add a branch to the next basic block in the chain.
481     if (NextBBInChain) {
482       Builder.CreateCondBr(MemCmpIsZero, NextBBInChain, Phi.getParent());
483       Phi.addIncoming(ConstantInt::getFalse(Context), BB);
484     } else {
485       Builder.CreateBr(Phi.getParent());
486       Phi.addIncoming(MemCmpIsZero, BB);
487     }
488 
489     // Delete merged blocks.
490     for (size_t I = 1; I < Comparisons.size(); ++I) {
491       BasicBlock *CBB = Comparisons[I].BB;
492       CBB->replaceAllUsesWith(BB);
493       CBB->eraseFromParent();
494     }
495   } else {
496     assert(Comparisons.size() == 1);
497     // There are no blocks to merge, but we still need to update the branches.
498     DEBUG(dbgs() << "Only one comparison, updating branches\n");
499     if (NextBBInChain) {
500       if (FirstComparison.BranchI->isConditional()) {
501         DEBUG(dbgs() << "conditional -> conditional\n");
502         // Just update the "true" target, the "false" target should already be
503         // the phi block.
504         assert(FirstComparison.BranchI->getSuccessor(1) == Phi.getParent());
505         FirstComparison.BranchI->setSuccessor(0, NextBBInChain);
506         Phi.addIncoming(ConstantInt::getFalse(Context), BB);
507       } else {
508         DEBUG(dbgs() << "unconditional -> conditional\n");
509         // Replace the unconditional branch by a conditional one.
510         FirstComparison.BranchI->eraseFromParent();
511         IRBuilder<> Builder(BB);
512         Builder.CreateCondBr(FirstComparison.CmpI, NextBBInChain,
513                              Phi.getParent());
514         Phi.addIncoming(FirstComparison.CmpI, BB);
515       }
516     } else {
517       if (FirstComparison.BranchI->isConditional()) {
518         DEBUG(dbgs() << "conditional -> unconditional\n");
519         // Replace the conditional branch by an unconditional one.
520         FirstComparison.BranchI->eraseFromParent();
521         IRBuilder<> Builder(BB);
522         Builder.CreateBr(Phi.getParent());
523         Phi.addIncoming(FirstComparison.CmpI, BB);
524       } else {
525         DEBUG(dbgs() << "unconditional -> unconditional\n");
526         Phi.addIncoming(FirstComparison.CmpI, BB);
527       }
528     }
529   }
530 }
531 
532 std::vector<BasicBlock *> getOrderedBlocks(PHINode &Phi,
533                                            BasicBlock *const LastBlock,
534                                            int NumBlocks) {
535   // Walk up from the last block to find other blocks.
536   std::vector<BasicBlock *> Blocks(NumBlocks);
537   assert(LastBlock && "invalid last block");
538   BasicBlock *CurBlock = LastBlock;
539   for (int BlockIndex = NumBlocks - 1; BlockIndex > 0; --BlockIndex) {
540     if (CurBlock->hasAddressTaken()) {
541       // Somebody is jumping to the block through an address, all bets are
542       // off.
543       DEBUG(dbgs() << "skip: block " << BlockIndex
544                    << " has its address taken\n");
545       return {};
546     }
547     Blocks[BlockIndex] = CurBlock;
548     auto *SinglePredecessor = CurBlock->getSinglePredecessor();
549     if (!SinglePredecessor) {
550       // The block has two or more predecessors.
551       DEBUG(dbgs() << "skip: block " << BlockIndex
552                    << " has two or more predecessors\n");
553       return {};
554     }
555     if (Phi.getBasicBlockIndex(SinglePredecessor) < 0) {
556       // The block does not link back to the phi.
557       DEBUG(dbgs() << "skip: block " << BlockIndex
558                    << " does not link back to the phi\n");
559       return {};
560     }
561     CurBlock = SinglePredecessor;
562   }
563   Blocks[0] = CurBlock;
564   return Blocks;
565 }
566 
567 bool processPhi(PHINode &Phi, const TargetLibraryInfo *const TLI) {
568   DEBUG(dbgs() << "processPhi()\n");
569   if (Phi.getNumIncomingValues() <= 1) {
570     DEBUG(dbgs() << "skip: only one incoming value in phi\n");
571     return false;
572   }
573   // We are looking for something that has the following structure:
574   //   bb1 --eq--> bb2 --eq--> bb3 --eq--> bb4 --+
575   //     \            \           \               \
576   //      ne           ne          ne              \
577   //       \            \           \               v
578   //        +------------+-----------+----------> bb_phi
579   //
580   //  - The last basic block (bb4 here) must branch unconditionally to bb_phi.
581   //    It's the only block that contributes a non-constant value to the Phi.
582   //  - All other blocks (b1, b2, b3) must have exactly two successors, one of
583   //    them being the phi block.
584   //  - All intermediate blocks (bb2, bb3) must have only one predecessor.
585   //  - Blocks cannot do other work besides the comparison, see doesOtherWork()
586 
587   // The blocks are not necessarily ordered in the phi, so we start from the
588   // last block and reconstruct the order.
589   BasicBlock *LastBlock = nullptr;
590   for (unsigned I = 0; I < Phi.getNumIncomingValues(); ++I) {
591     if (isa<ConstantInt>(Phi.getIncomingValue(I))) continue;
592     if (LastBlock) {
593       // There are several non-constant values.
594       DEBUG(dbgs() << "skip: several non-constant values\n");
595       return false;
596     }
597     if (!isa<ICmpInst>(Phi.getIncomingValue(I)) ||
598         cast<ICmpInst>(Phi.getIncomingValue(I))->getParent() !=
599             Phi.getIncomingBlock(I)) {
600       // Non-constant incoming value is not from a cmp instruction or not
601       // produced by the last block. We could end up processing the value
602       // producing block more than once.
603       //
604       // This is an uncommon case, so we bail.
605       DEBUG(
606           dbgs()
607           << "skip: non-constant value not from cmp or not from last block.\n");
608       return false;
609     }
610     LastBlock = Phi.getIncomingBlock(I);
611   }
612   if (!LastBlock) {
613     // There is no non-constant block.
614     DEBUG(dbgs() << "skip: no non-constant block\n");
615     return false;
616   }
617   if (LastBlock->getSingleSuccessor() != Phi.getParent()) {
618     DEBUG(dbgs() << "skip: last block non-phi successor\n");
619     return false;
620   }
621 
622   const auto Blocks =
623       getOrderedBlocks(Phi, LastBlock, Phi.getNumIncomingValues());
624   if (Blocks.empty()) return false;
625   BCECmpChain CmpChain(Blocks, Phi);
626 
627   if (CmpChain.size() < 2) {
628     DEBUG(dbgs() << "skip: only one compare block\n");
629     return false;
630   }
631 
632   return CmpChain.simplify(TLI);
633 }
634 
635 class MergeICmps : public FunctionPass {
636  public:
637   static char ID;
638 
639   MergeICmps() : FunctionPass(ID) {
640     initializeMergeICmpsPass(*PassRegistry::getPassRegistry());
641   }
642 
643   bool runOnFunction(Function &F) override {
644     if (skipFunction(F)) return false;
645     const auto &TLI = getAnalysis<TargetLibraryInfoWrapperPass>().getTLI();
646     const auto &TTI = getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F);
647     auto PA = runImpl(F, &TLI, &TTI);
648     return !PA.areAllPreserved();
649   }
650 
651  private:
652   void getAnalysisUsage(AnalysisUsage &AU) const override {
653     AU.addRequired<TargetLibraryInfoWrapperPass>();
654     AU.addRequired<TargetTransformInfoWrapperPass>();
655   }
656 
657   PreservedAnalyses runImpl(Function &F, const TargetLibraryInfo *TLI,
658                             const TargetTransformInfo *TTI);
659 };
660 
661 PreservedAnalyses MergeICmps::runImpl(Function &F, const TargetLibraryInfo *TLI,
662                                       const TargetTransformInfo *TTI) {
663   DEBUG(dbgs() << "MergeICmpsPass: " << F.getName() << "\n");
664 
665   // We only try merging comparisons if the target wants to expand memcmp later.
666   // The rationale is to avoid turning small chains into memcmp calls.
667   if (!TTI->enableMemCmpExpansion(true)) return PreservedAnalyses::all();
668 
669   bool MadeChange = false;
670 
671   for (auto BBIt = ++F.begin(); BBIt != F.end(); ++BBIt) {
672     // A Phi operation is always first in a basic block.
673     if (auto *const Phi = dyn_cast<PHINode>(&*BBIt->begin()))
674       MadeChange |= processPhi(*Phi, TLI);
675   }
676 
677   if (MadeChange) return PreservedAnalyses::none();
678   return PreservedAnalyses::all();
679 }
680 
681 }  // namespace
682 
683 char MergeICmps::ID = 0;
684 INITIALIZE_PASS_BEGIN(MergeICmps, "mergeicmps",
685                       "Merge contiguous icmps into a memcmp", false, false)
686 INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
687 INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
688 INITIALIZE_PASS_END(MergeICmps, "mergeicmps",
689                     "Merge contiguous icmps into a memcmp", false, false)
690 
691 Pass *llvm::createMergeICmpsPass() { return new MergeICmps(); }
692