xref: /llvm-project/llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp (revision a8d9d50762c42d726274d3f1126ec97ff96e2a22)
1 //===-- SIFormMemoryClauses.cpp -------------------------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 /// \file
10 /// This pass creates bundles of SMEM and VMEM instructions forming memory
11 /// clauses if XNACK is enabled. Def operands of clauses are marked as early
12 /// clobber to make sure we will not override any source within a clause.
13 ///
14 //===----------------------------------------------------------------------===//
15 
16 #include "AMDGPU.h"
17 #include "GCNRegPressure.h"
18 #include "SIMachineFunctionInfo.h"
19 #include "llvm/InitializePasses.h"
20 
21 using namespace llvm;
22 
23 #define DEBUG_TYPE "si-form-memory-clauses"
24 
25 // Clauses longer then 15 instructions would overflow one of the counters
26 // and stall. They can stall even earlier if there are outstanding counters.
27 static cl::opt<unsigned>
28 MaxClause("amdgpu-max-memory-clause", cl::Hidden, cl::init(15),
29           cl::desc("Maximum length of a memory clause, instructions"));
30 
31 namespace {
32 
33 class SIFormMemoryClauses : public MachineFunctionPass {
34   typedef DenseMap<unsigned, std::pair<unsigned, LaneBitmask>> RegUse;
35 
36 public:
37   static char ID;
38 
39 public:
40   SIFormMemoryClauses() : MachineFunctionPass(ID) {
41     initializeSIFormMemoryClausesPass(*PassRegistry::getPassRegistry());
42   }
43 
44   bool runOnMachineFunction(MachineFunction &MF) override;
45 
46   StringRef getPassName() const override {
47     return "SI Form memory clauses";
48   }
49 
50   void getAnalysisUsage(AnalysisUsage &AU) const override {
51     AU.addRequired<LiveIntervals>();
52     AU.setPreservesAll();
53     MachineFunctionPass::getAnalysisUsage(AU);
54   }
55 
56   MachineFunctionProperties getClearedProperties() const override {
57     return MachineFunctionProperties().set(
58         MachineFunctionProperties::Property::IsSSA);
59   }
60 
61 private:
62   template <typename Callable>
63   void forAllLanes(Register Reg, LaneBitmask LaneMask, Callable Func) const;
64 
65   bool canBundle(const MachineInstr &MI, const RegUse &Defs,
66                  const RegUse &Uses) const;
67   bool checkPressure(const MachineInstr &MI, GCNDownwardRPTracker &RPT);
68   void collectRegUses(const MachineInstr &MI, RegUse &Defs, RegUse &Uses) const;
69   bool processRegUses(const MachineInstr &MI, RegUse &Defs, RegUse &Uses,
70                       GCNDownwardRPTracker &RPT);
71 
72   const GCNSubtarget *ST;
73   const SIRegisterInfo *TRI;
74   const MachineRegisterInfo *MRI;
75   SIMachineFunctionInfo *MFI;
76 
77   unsigned LastRecordedOccupancy;
78   unsigned MaxVGPRs;
79   unsigned MaxSGPRs;
80 };
81 
82 } // End anonymous namespace.
83 
84 INITIALIZE_PASS_BEGIN(SIFormMemoryClauses, DEBUG_TYPE,
85                       "SI Form memory clauses", false, false)
86 INITIALIZE_PASS_DEPENDENCY(LiveIntervals)
87 INITIALIZE_PASS_END(SIFormMemoryClauses, DEBUG_TYPE,
88                     "SI Form memory clauses", false, false)
89 
90 
91 char SIFormMemoryClauses::ID = 0;
92 
93 char &llvm::SIFormMemoryClausesID = SIFormMemoryClauses::ID;
94 
95 FunctionPass *llvm::createSIFormMemoryClausesPass() {
96   return new SIFormMemoryClauses();
97 }
98 
99 static bool isVMEMClauseInst(const MachineInstr &MI) {
100   return SIInstrInfo::isFLAT(MI) || SIInstrInfo::isVMEM(MI);
101 }
102 
103 static bool isSMEMClauseInst(const MachineInstr &MI) {
104   return SIInstrInfo::isSMRD(MI);
105 }
106 
107 // There no sense to create store clauses, they do not define anything,
108 // thus there is nothing to set early-clobber.
109 static bool isValidClauseInst(const MachineInstr &MI, bool IsVMEMClause) {
110   assert(!MI.isDebugInstr() && "debug instructions should not reach here");
111   if (MI.isBundled())
112     return false;
113   if (!MI.mayLoad() || MI.mayStore())
114     return false;
115   if (SIInstrInfo::isAtomic(MI))
116     return false;
117   if (IsVMEMClause && !isVMEMClauseInst(MI))
118     return false;
119   if (!IsVMEMClause && !isSMEMClauseInst(MI))
120     return false;
121   // If this is a load instruction where the result has been coalesced with an operand, then we cannot clause it.
122   for (const MachineOperand &ResMO : MI.defs()) {
123     Register ResReg = ResMO.getReg();
124     for (const MachineOperand &MO : MI.uses()) {
125       if (!MO.isReg() || MO.isDef())
126         continue;
127       if (MO.getReg() == ResReg)
128         return false;
129     }
130     break; // Only check the first def.
131   }
132   return true;
133 }
134 
135 static unsigned getMopState(const MachineOperand &MO) {
136   unsigned S = 0;
137   if (MO.isImplicit())
138     S |= RegState::Implicit;
139   if (MO.isDead())
140     S |= RegState::Dead;
141   if (MO.isUndef())
142     S |= RegState::Undef;
143   if (MO.isKill())
144     S |= RegState::Kill;
145   if (MO.isEarlyClobber())
146     S |= RegState::EarlyClobber;
147   if (MO.getReg().isPhysical() && MO.isRenamable())
148     S |= RegState::Renamable;
149   return S;
150 }
151 
152 template <typename Callable>
153 void SIFormMemoryClauses::forAllLanes(Register Reg, LaneBitmask LaneMask,
154                                       Callable Func) const {
155   if (LaneMask.all() || Reg.isPhysical() ||
156       LaneMask == MRI->getMaxLaneMaskForVReg(Reg)) {
157     Func(0);
158     return;
159   }
160 
161   const TargetRegisterClass *RC = MRI->getRegClass(Reg);
162   unsigned E = TRI->getNumSubRegIndices();
163   SmallVector<unsigned, AMDGPU::NUM_TARGET_SUBREGS> CoveringSubregs;
164   for (unsigned Idx = 1; Idx < E; ++Idx) {
165     // Is this index even compatible with the given class?
166     if (TRI->getSubClassWithSubReg(RC, Idx) != RC)
167       continue;
168     LaneBitmask SubRegMask = TRI->getSubRegIndexLaneMask(Idx);
169     // Early exit if we found a perfect match.
170     if (SubRegMask == LaneMask) {
171       Func(Idx);
172       return;
173     }
174 
175     if ((SubRegMask & ~LaneMask).any() || (SubRegMask & LaneMask).none())
176       continue;
177 
178     CoveringSubregs.push_back(Idx);
179   }
180 
181   llvm::sort(CoveringSubregs, [this](unsigned A, unsigned B) {
182     LaneBitmask MaskA = TRI->getSubRegIndexLaneMask(A);
183     LaneBitmask MaskB = TRI->getSubRegIndexLaneMask(B);
184     unsigned NA = MaskA.getNumLanes();
185     unsigned NB = MaskB.getNumLanes();
186     if (NA != NB)
187       return NA > NB;
188     return MaskA.getHighestLane() > MaskB.getHighestLane();
189   });
190 
191   MCRegister RepReg;
192   for (MCRegister R : *MRI->getRegClass(Reg)) {
193     if (!MRI->isReserved(R)) {
194       RepReg = R;
195       break;
196     }
197   }
198   if (!RepReg)
199     llvm_unreachable("Failed to find required allocatable register");
200 
201   for (unsigned Idx : CoveringSubregs) {
202     LaneBitmask SubRegMask = TRI->getSubRegIndexLaneMask(Idx);
203     if ((SubRegMask & ~LaneMask).any() || (SubRegMask & LaneMask).none())
204       continue;
205 
206     if (MRI->isReserved(TRI->getSubReg(RepReg, Idx)))
207       continue;
208 
209     Func(Idx);
210     LaneMask &= ~SubRegMask;
211     if (LaneMask.none())
212       return;
213   }
214 
215   llvm_unreachable("Failed to find all subregs to cover lane mask");
216 }
217 
218 // Returns false if there is a use of a def already in the map.
219 // In this case we must break the clause.
220 bool SIFormMemoryClauses::canBundle(const MachineInstr &MI, const RegUse &Defs,
221                                     const RegUse &Uses) const {
222   // Check interference with defs.
223   for (const MachineOperand &MO : MI.operands()) {
224     // TODO: Prologue/Epilogue Insertion pass does not process bundled
225     //       instructions.
226     if (MO.isFI())
227       return false;
228 
229     if (!MO.isReg())
230       continue;
231 
232     Register Reg = MO.getReg();
233 
234     // If it is tied we will need to write same register as we read.
235     if (MO.isTied())
236       return false;
237 
238     const RegUse &Map = MO.isDef() ? Uses : Defs;
239     auto Conflict = Map.find(Reg);
240     if (Conflict == Map.end())
241       continue;
242 
243     if (Reg.isPhysical())
244       return false;
245 
246     LaneBitmask Mask = TRI->getSubRegIndexLaneMask(MO.getSubReg());
247     if ((Conflict->second.second & Mask).any())
248       return false;
249   }
250 
251   return true;
252 }
253 
254 // Since all defs in the clause are early clobber we can run out of registers.
255 // Function returns false if pressure would hit the limit if instruction is
256 // bundled into a memory clause.
257 bool SIFormMemoryClauses::checkPressure(const MachineInstr &MI,
258                                         GCNDownwardRPTracker &RPT) {
259   // NB: skip advanceBeforeNext() call. Since all defs will be marked
260   // early-clobber they will all stay alive at least to the end of the
261   // clause. Therefor we should not decrease pressure even if load
262   // pointer becomes dead and could otherwise be reused for destination.
263   RPT.advanceToNext();
264   GCNRegPressure MaxPressure = RPT.moveMaxPressure();
265   unsigned Occupancy = MaxPressure.getOccupancy(*ST);
266 
267   // Don't push over half the register budget. We don't want to introduce
268   // spilling just to form a soft clause.
269   //
270   // FIXME: This pressure check is fundamentally broken. First, this is checking
271   // the global pressure, not the pressure at this specific point in the
272   // program. Second, it's not accounting for the increased liveness of the use
273   // operands due to the early clobber we will introduce. Third, the pressure
274   // tracking does not account for the alignment requirements for SGPRs, or the
275   // fragmentation of registers the allocator will need to satisfy.
276   if (Occupancy >= MFI->getMinAllowedOccupancy() &&
277       MaxPressure.getVGPRNum(ST->hasGFX90AInsts()) <= MaxVGPRs / 2 &&
278       MaxPressure.getSGPRNum() <= MaxSGPRs / 2) {
279     LastRecordedOccupancy = Occupancy;
280     return true;
281   }
282   return false;
283 }
284 
285 // Collect register defs and uses along with their lane masks and states.
286 void SIFormMemoryClauses::collectRegUses(const MachineInstr &MI,
287                                          RegUse &Defs, RegUse &Uses) const {
288   for (const MachineOperand &MO : MI.operands()) {
289     if (!MO.isReg())
290       continue;
291     Register Reg = MO.getReg();
292     if (!Reg)
293       continue;
294 
295     LaneBitmask Mask = Reg.isVirtual()
296                            ? TRI->getSubRegIndexLaneMask(MO.getSubReg())
297                            : LaneBitmask::getAll();
298     RegUse &Map = MO.isDef() ? Defs : Uses;
299 
300     auto Loc = Map.find(Reg);
301     unsigned State = getMopState(MO);
302     if (Loc == Map.end()) {
303       Map[Reg] = std::make_pair(State, Mask);
304     } else {
305       Loc->second.first |= State;
306       Loc->second.second |= Mask;
307     }
308   }
309 }
310 
311 // Check register def/use conflicts, occupancy limits and collect def/use maps.
312 // Return true if instruction can be bundled with previous. It it cannot
313 // def/use maps are not updated.
314 bool SIFormMemoryClauses::processRegUses(const MachineInstr &MI,
315                                          RegUse &Defs, RegUse &Uses,
316                                          GCNDownwardRPTracker &RPT) {
317   if (!canBundle(MI, Defs, Uses))
318     return false;
319 
320   if (!checkPressure(MI, RPT))
321     return false;
322 
323   collectRegUses(MI, Defs, Uses);
324   return true;
325 }
326 
327 bool SIFormMemoryClauses::runOnMachineFunction(MachineFunction &MF) {
328   if (skipFunction(MF.getFunction()))
329     return false;
330 
331   ST = &MF.getSubtarget<GCNSubtarget>();
332   if (!ST->isXNACKEnabled())
333     return false;
334 
335   const SIInstrInfo *TII = ST->getInstrInfo();
336   TRI = ST->getRegisterInfo();
337   MRI = &MF.getRegInfo();
338   MFI = MF.getInfo<SIMachineFunctionInfo>();
339   LiveIntervals *LIS = &getAnalysis<LiveIntervals>();
340   SlotIndexes *Ind = LIS->getSlotIndexes();
341   bool Changed = false;
342 
343   MaxVGPRs = TRI->getAllocatableSet(MF, &AMDGPU::VGPR_32RegClass).count();
344   MaxSGPRs = TRI->getAllocatableSet(MF, &AMDGPU::SGPR_32RegClass).count();
345   unsigned FuncMaxClause = AMDGPU::getIntegerAttribute(
346       MF.getFunction(), "amdgpu-max-memory-clause", MaxClause);
347 
348   SmallVector<MachineInstr *> DbgInstrs;
349 
350   for (MachineBasicBlock &MBB : MF) {
351     GCNDownwardRPTracker RPT(*LIS);
352     MachineBasicBlock::instr_iterator Next;
353     for (auto I = MBB.instr_begin(), E = MBB.instr_end(); I != E; I = Next) {
354       MachineInstr &MI = *I;
355       Next = std::next(I);
356 
357       if (MI.isDebugInstr())
358         continue;
359 
360       bool IsVMEM = isVMEMClauseInst(MI);
361 
362       if (!isValidClauseInst(MI, IsVMEM))
363         continue;
364 
365       if (!RPT.getNext().isValid())
366         RPT.reset(MI);
367       else { // Advance the state to the current MI.
368         RPT.advance(MachineBasicBlock::const_iterator(MI));
369         RPT.advanceBeforeNext();
370       }
371 
372       const GCNRPTracker::LiveRegSet LiveRegsCopy(RPT.getLiveRegs());
373       RegUse Defs, Uses;
374       if (!processRegUses(MI, Defs, Uses, RPT)) {
375         RPT.reset(MI, &LiveRegsCopy);
376         continue;
377       }
378 
379       unsigned Length = 1;
380       for ( ; Next != E && Length < FuncMaxClause; ++Next) {
381         // Debug instructions should not change the bundling. We need to move
382         // these after the bundle
383         if (Next->isDebugInstr())
384           continue;
385 
386         if (!isValidClauseInst(*Next, IsVMEM))
387           break;
388 
389         // A load from pointer which was loaded inside the same bundle is an
390         // impossible clause because we will need to write and read the same
391         // register inside. In this case processRegUses will return false.
392         if (!processRegUses(*Next, Defs, Uses, RPT))
393           break;
394 
395         ++Length;
396       }
397       if (Length < 2) {
398         RPT.reset(MI, &LiveRegsCopy);
399         continue;
400       }
401 
402       Changed = true;
403       MFI->limitOccupancy(LastRecordedOccupancy);
404 
405       auto B = BuildMI(MBB, I, DebugLoc(), TII->get(TargetOpcode::BUNDLE));
406       Ind->insertMachineInstrInMaps(*B);
407 
408       // Restore the state after processing the bundle.
409       RPT.reset(*B, &LiveRegsCopy);
410       DbgInstrs.clear();
411 
412       auto BundleNext = I;
413       for (auto BI = I; BI != Next; BI = BundleNext) {
414         BundleNext = std::next(BI);
415 
416         if (BI->isDebugValue()) {
417           DbgInstrs.push_back(BI->removeFromParent());
418           continue;
419         }
420 
421         BI->bundleWithPred();
422         Ind->removeSingleMachineInstrFromMaps(*BI);
423 
424         for (MachineOperand &MO : BI->defs())
425           if (MO.readsReg())
426             MO.setIsInternalRead(true);
427       }
428 
429       // Replace any debug instructions after the new bundle.
430       for (MachineInstr *DbgInst : DbgInstrs)
431         MBB.insert(Next, DbgInst);
432 
433       for (auto &&R : Defs) {
434         forAllLanes(R.first, R.second.second, [&R, &B](unsigned SubReg) {
435           unsigned S = R.second.first | RegState::EarlyClobber;
436           if (!SubReg)
437             S &= ~(RegState::Undef | RegState::Dead);
438           B.addDef(R.first, S, SubReg);
439         });
440       }
441 
442       for (auto &&R : Uses) {
443         forAllLanes(R.first, R.second.second, [&R, &B](unsigned SubReg) {
444           B.addUse(R.first, R.second.first & ~RegState::Kill, SubReg);
445         });
446       }
447 
448       for (auto &&R : Defs) {
449         Register Reg = R.first;
450         Uses.erase(Reg);
451         if (Reg.isPhysical())
452           continue;
453         LIS->removeInterval(Reg);
454         LIS->createAndComputeVirtRegInterval(Reg);
455       }
456 
457       for (auto &&R : Uses) {
458         Register Reg = R.first;
459         if (Reg.isPhysical())
460           continue;
461         LIS->removeInterval(Reg);
462         LIS->createAndComputeVirtRegInterval(Reg);
463       }
464     }
465   }
466 
467   return Changed;
468 }
469