1 //===- TailDuplicator.cpp - Duplicate blocks into predecessors' tails -----===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This utility class duplicates basic blocks ending in unconditional branches 10 // into the tails of their predecessors. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "llvm/CodeGen/TailDuplicator.h" 15 #include "llvm/ADT/DenseMap.h" 16 #include "llvm/ADT/DenseSet.h" 17 #include "llvm/ADT/STLExtras.h" 18 #include "llvm/ADT/SetVector.h" 19 #include "llvm/ADT/SmallPtrSet.h" 20 #include "llvm/ADT/SmallVector.h" 21 #include "llvm/ADT/Statistic.h" 22 #include "llvm/CodeGen/MachineBasicBlock.h" 23 #include "llvm/CodeGen/MachineBranchProbabilityInfo.h" 24 #include "llvm/CodeGen/MachineFunction.h" 25 #include "llvm/CodeGen/MachineInstr.h" 26 #include "llvm/CodeGen/MachineInstrBuilder.h" 27 #include "llvm/CodeGen/MachineOperand.h" 28 #include "llvm/CodeGen/MachineRegisterInfo.h" 29 #include "llvm/CodeGen/MachineSSAUpdater.h" 30 #include "llvm/CodeGen/MachineSizeOpts.h" 31 #include "llvm/CodeGen/TargetInstrInfo.h" 32 #include "llvm/CodeGen/TargetRegisterInfo.h" 33 #include "llvm/CodeGen/TargetSubtargetInfo.h" 34 #include "llvm/IR/DebugLoc.h" 35 #include "llvm/IR/Function.h" 36 #include "llvm/Support/CommandLine.h" 37 #include "llvm/Support/Debug.h" 38 #include "llvm/Support/ErrorHandling.h" 39 #include "llvm/Support/raw_ostream.h" 40 #include "llvm/Target/TargetMachine.h" 41 #include <algorithm> 42 #include <cassert> 43 #include <iterator> 44 #include <utility> 45 46 using namespace llvm; 47 48 #define DEBUG_TYPE "tailduplication" 49 50 STATISTIC(NumTails, "Number of tails duplicated"); 51 STATISTIC(NumTailDups, "Number of tail duplicated blocks"); 52 STATISTIC(NumTailDupAdded, 53 "Number of instructions added due to tail duplication"); 54 STATISTIC(NumTailDupRemoved, 55 "Number of instructions removed due to tail duplication"); 56 STATISTIC(NumDeadBlocks, "Number of dead blocks removed"); 57 STATISTIC(NumAddedPHIs, "Number of phis added"); 58 59 // Heuristic for tail duplication. 60 static cl::opt<unsigned> TailDuplicateSize( 61 "tail-dup-size", 62 cl::desc("Maximum instructions to consider tail duplicating"), cl::init(2), 63 cl::Hidden); 64 65 static cl::opt<unsigned> TailDupIndirectBranchSize( 66 "tail-dup-indirect-size", 67 cl::desc("Maximum instructions to consider tail duplicating blocks that " 68 "end with indirect branches."), cl::init(20), 69 cl::Hidden); 70 71 static cl::opt<bool> 72 TailDupVerify("tail-dup-verify", 73 cl::desc("Verify sanity of PHI instructions during taildup"), 74 cl::init(false), cl::Hidden); 75 76 static cl::opt<unsigned> TailDupLimit("tail-dup-limit", cl::init(~0U), 77 cl::Hidden); 78 79 void TailDuplicator::initMF(MachineFunction &MFin, bool PreRegAlloc, 80 const MachineBranchProbabilityInfo *MBPIin, 81 MBFIWrapper *MBFIin, 82 ProfileSummaryInfo *PSIin, 83 bool LayoutModeIn, unsigned TailDupSizeIn) { 84 MF = &MFin; 85 TII = MF->getSubtarget().getInstrInfo(); 86 TRI = MF->getSubtarget().getRegisterInfo(); 87 MRI = &MF->getRegInfo(); 88 MMI = &MF->getMMI(); 89 MBPI = MBPIin; 90 MBFI = MBFIin; 91 PSI = PSIin; 92 TailDupSize = TailDupSizeIn; 93 94 assert(MBPI != nullptr && "Machine Branch Probability Info required"); 95 96 LayoutMode = LayoutModeIn; 97 this->PreRegAlloc = PreRegAlloc; 98 } 99 100 static void VerifyPHIs(MachineFunction &MF, bool CheckExtra) { 101 for (MachineBasicBlock &MBB : llvm::drop_begin(MF)) { 102 SmallSetVector<MachineBasicBlock *, 8> Preds(MBB.pred_begin(), 103 MBB.pred_end()); 104 MachineBasicBlock::iterator MI = MBB.begin(); 105 while (MI != MBB.end()) { 106 if (!MI->isPHI()) 107 break; 108 for (MachineBasicBlock *PredBB : Preds) { 109 bool Found = false; 110 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) { 111 MachineBasicBlock *PHIBB = MI->getOperand(i + 1).getMBB(); 112 if (PHIBB == PredBB) { 113 Found = true; 114 break; 115 } 116 } 117 if (!Found) { 118 dbgs() << "Malformed PHI in " << printMBBReference(MBB) << ": " 119 << *MI; 120 dbgs() << " missing input from predecessor " 121 << printMBBReference(*PredBB) << '\n'; 122 llvm_unreachable(nullptr); 123 } 124 } 125 126 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) { 127 MachineBasicBlock *PHIBB = MI->getOperand(i + 1).getMBB(); 128 if (CheckExtra && !Preds.count(PHIBB)) { 129 dbgs() << "Warning: malformed PHI in " << printMBBReference(MBB) 130 << ": " << *MI; 131 dbgs() << " extra input from predecessor " 132 << printMBBReference(*PHIBB) << '\n'; 133 llvm_unreachable(nullptr); 134 } 135 if (PHIBB->getNumber() < 0) { 136 dbgs() << "Malformed PHI in " << printMBBReference(MBB) << ": " 137 << *MI; 138 dbgs() << " non-existing " << printMBBReference(*PHIBB) << '\n'; 139 llvm_unreachable(nullptr); 140 } 141 } 142 ++MI; 143 } 144 } 145 } 146 147 /// Tail duplicate the block and cleanup. 148 /// \p IsSimple - return value of isSimpleBB 149 /// \p MBB - block to be duplicated 150 /// \p ForcedLayoutPred - If non-null, treat this block as the layout 151 /// predecessor, instead of using the ordering in MF 152 /// \p DuplicatedPreds - if non-null, \p DuplicatedPreds will contain a list of 153 /// all Preds that received a copy of \p MBB. 154 /// \p RemovalCallback - if non-null, called just before MBB is deleted. 155 bool TailDuplicator::tailDuplicateAndUpdate( 156 bool IsSimple, MachineBasicBlock *MBB, 157 MachineBasicBlock *ForcedLayoutPred, 158 SmallVectorImpl<MachineBasicBlock*> *DuplicatedPreds, 159 function_ref<void(MachineBasicBlock *)> *RemovalCallback, 160 SmallVectorImpl<MachineBasicBlock *> *CandidatePtr) { 161 // Save the successors list. 162 SmallSetVector<MachineBasicBlock *, 8> Succs(MBB->succ_begin(), 163 MBB->succ_end()); 164 165 SmallVector<MachineBasicBlock *, 8> TDBBs; 166 SmallVector<MachineInstr *, 16> Copies; 167 if (!tailDuplicate(IsSimple, MBB, ForcedLayoutPred, 168 TDBBs, Copies, CandidatePtr)) 169 return false; 170 171 ++NumTails; 172 173 SmallVector<MachineInstr *, 8> NewPHIs; 174 MachineSSAUpdater SSAUpdate(*MF, &NewPHIs); 175 176 // TailBB's immediate successors are now successors of those predecessors 177 // which duplicated TailBB. Add the predecessors as sources to the PHI 178 // instructions. 179 bool isDead = MBB->pred_empty() && !MBB->hasAddressTaken(); 180 if (PreRegAlloc) 181 updateSuccessorsPHIs(MBB, isDead, TDBBs, Succs); 182 183 // If it is dead, remove it. 184 if (isDead) { 185 NumTailDupRemoved += MBB->size(); 186 removeDeadBlock(MBB, RemovalCallback); 187 ++NumDeadBlocks; 188 } 189 190 // Update SSA form. 191 if (!SSAUpdateVRs.empty()) { 192 for (unsigned i = 0, e = SSAUpdateVRs.size(); i != e; ++i) { 193 unsigned VReg = SSAUpdateVRs[i]; 194 SSAUpdate.Initialize(VReg); 195 196 // If the original definition is still around, add it as an available 197 // value. 198 MachineInstr *DefMI = MRI->getVRegDef(VReg); 199 MachineBasicBlock *DefBB = nullptr; 200 if (DefMI) { 201 DefBB = DefMI->getParent(); 202 SSAUpdate.AddAvailableValue(DefBB, VReg); 203 } 204 205 // Add the new vregs as available values. 206 DenseMap<Register, AvailableValsTy>::iterator LI = 207 SSAUpdateVals.find(VReg); 208 for (std::pair<MachineBasicBlock *, Register> &J : LI->second) { 209 MachineBasicBlock *SrcBB = J.first; 210 Register SrcReg = J.second; 211 SSAUpdate.AddAvailableValue(SrcBB, SrcReg); 212 } 213 214 SmallVector<MachineOperand *> DebugUses; 215 // Rewrite uses that are outside of the original def's block. 216 for (MachineOperand &UseMO : 217 llvm::make_early_inc_range(MRI->use_operands(VReg))) { 218 MachineInstr *UseMI = UseMO.getParent(); 219 // Rewrite debug uses last so that they can take advantage of any 220 // register mappings introduced by other users in its BB, since we 221 // cannot create new register definitions specifically for the debug 222 // instruction (as debug instructions should not affect CodeGen). 223 if (UseMI->isDebugValue()) { 224 DebugUses.push_back(&UseMO); 225 continue; 226 } 227 if (UseMI->getParent() == DefBB && !UseMI->isPHI()) 228 continue; 229 SSAUpdate.RewriteUse(UseMO); 230 } 231 for (auto *UseMO : DebugUses) { 232 MachineInstr *UseMI = UseMO->getParent(); 233 UseMO->setReg( 234 SSAUpdate.GetValueInMiddleOfBlock(UseMI->getParent(), true)); 235 } 236 } 237 238 SSAUpdateVRs.clear(); 239 SSAUpdateVals.clear(); 240 } 241 242 // Eliminate some of the copies inserted by tail duplication to maintain 243 // SSA form. 244 for (unsigned i = 0, e = Copies.size(); i != e; ++i) { 245 MachineInstr *Copy = Copies[i]; 246 if (!Copy->isCopy()) 247 continue; 248 Register Dst = Copy->getOperand(0).getReg(); 249 Register Src = Copy->getOperand(1).getReg(); 250 if (MRI->hasOneNonDBGUse(Src) && 251 MRI->constrainRegClass(Src, MRI->getRegClass(Dst))) { 252 // Copy is the only use. Do trivial copy propagation here. 253 MRI->replaceRegWith(Dst, Src); 254 Copy->eraseFromParent(); 255 } 256 } 257 258 if (NewPHIs.size()) 259 NumAddedPHIs += NewPHIs.size(); 260 261 if (DuplicatedPreds) 262 *DuplicatedPreds = std::move(TDBBs); 263 264 return true; 265 } 266 267 /// Look for small blocks that are unconditionally branched to and do not fall 268 /// through. Tail-duplicate their instructions into their predecessors to 269 /// eliminate (dynamic) branches. 270 bool TailDuplicator::tailDuplicateBlocks() { 271 bool MadeChange = false; 272 273 if (PreRegAlloc && TailDupVerify) { 274 LLVM_DEBUG(dbgs() << "\n*** Before tail-duplicating\n"); 275 VerifyPHIs(*MF, true); 276 } 277 278 for (MachineBasicBlock &MBB : 279 llvm::make_early_inc_range(llvm::drop_begin(*MF))) { 280 if (NumTails == TailDupLimit) 281 break; 282 283 bool IsSimple = isSimpleBB(&MBB); 284 285 if (!shouldTailDuplicate(IsSimple, MBB)) 286 continue; 287 288 MadeChange |= tailDuplicateAndUpdate(IsSimple, &MBB, nullptr); 289 } 290 291 if (PreRegAlloc && TailDupVerify) 292 VerifyPHIs(*MF, false); 293 294 return MadeChange; 295 } 296 297 static bool isDefLiveOut(Register Reg, MachineBasicBlock *BB, 298 const MachineRegisterInfo *MRI) { 299 for (MachineInstr &UseMI : MRI->use_instructions(Reg)) { 300 if (UseMI.isDebugValue()) 301 continue; 302 if (UseMI.getParent() != BB) 303 return true; 304 } 305 return false; 306 } 307 308 static unsigned getPHISrcRegOpIdx(MachineInstr *MI, MachineBasicBlock *SrcBB) { 309 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) 310 if (MI->getOperand(i + 1).getMBB() == SrcBB) 311 return i; 312 return 0; 313 } 314 315 // Remember which registers are used by phis in this block. This is 316 // used to determine which registers are liveout while modifying the 317 // block (which is why we need to copy the information). 318 static void getRegsUsedByPHIs(const MachineBasicBlock &BB, 319 DenseSet<Register> *UsedByPhi) { 320 for (const auto &MI : BB) { 321 if (!MI.isPHI()) 322 break; 323 for (unsigned i = 1, e = MI.getNumOperands(); i != e; i += 2) { 324 Register SrcReg = MI.getOperand(i).getReg(); 325 UsedByPhi->insert(SrcReg); 326 } 327 } 328 } 329 330 /// Add a definition and source virtual registers pair for SSA update. 331 void TailDuplicator::addSSAUpdateEntry(Register OrigReg, Register NewReg, 332 MachineBasicBlock *BB) { 333 DenseMap<Register, AvailableValsTy>::iterator LI = 334 SSAUpdateVals.find(OrigReg); 335 if (LI != SSAUpdateVals.end()) 336 LI->second.push_back(std::make_pair(BB, NewReg)); 337 else { 338 AvailableValsTy Vals; 339 Vals.push_back(std::make_pair(BB, NewReg)); 340 SSAUpdateVals.insert(std::make_pair(OrigReg, Vals)); 341 SSAUpdateVRs.push_back(OrigReg); 342 } 343 } 344 345 /// Process PHI node in TailBB by turning it into a copy in PredBB. Remember the 346 /// source register that's contributed by PredBB and update SSA update map. 347 void TailDuplicator::processPHI( 348 MachineInstr *MI, MachineBasicBlock *TailBB, MachineBasicBlock *PredBB, 349 DenseMap<Register, RegSubRegPair> &LocalVRMap, 350 SmallVectorImpl<std::pair<Register, RegSubRegPair>> &Copies, 351 const DenseSet<Register> &RegsUsedByPhi, bool Remove) { 352 Register DefReg = MI->getOperand(0).getReg(); 353 unsigned SrcOpIdx = getPHISrcRegOpIdx(MI, PredBB); 354 assert(SrcOpIdx && "Unable to find matching PHI source?"); 355 Register SrcReg = MI->getOperand(SrcOpIdx).getReg(); 356 unsigned SrcSubReg = MI->getOperand(SrcOpIdx).getSubReg(); 357 const TargetRegisterClass *RC = MRI->getRegClass(DefReg); 358 LocalVRMap.insert(std::make_pair(DefReg, RegSubRegPair(SrcReg, SrcSubReg))); 359 360 // Insert a copy from source to the end of the block. The def register is the 361 // available value liveout of the block. 362 Register NewDef = MRI->createVirtualRegister(RC); 363 Copies.push_back(std::make_pair(NewDef, RegSubRegPair(SrcReg, SrcSubReg))); 364 if (isDefLiveOut(DefReg, TailBB, MRI) || RegsUsedByPhi.count(DefReg)) 365 addSSAUpdateEntry(DefReg, NewDef, PredBB); 366 367 if (!Remove) 368 return; 369 370 // Remove PredBB from the PHI node. 371 MI->removeOperand(SrcOpIdx + 1); 372 MI->removeOperand(SrcOpIdx); 373 if (MI->getNumOperands() == 1) 374 MI->eraseFromParent(); 375 } 376 377 /// Duplicate a TailBB instruction to PredBB and update 378 /// the source operands due to earlier PHI translation. 379 void TailDuplicator::duplicateInstruction( 380 MachineInstr *MI, MachineBasicBlock *TailBB, MachineBasicBlock *PredBB, 381 DenseMap<Register, RegSubRegPair> &LocalVRMap, 382 const DenseSet<Register> &UsedByPhi) { 383 // Allow duplication of CFI instructions. 384 if (MI->isCFIInstruction()) { 385 BuildMI(*PredBB, PredBB->end(), PredBB->findDebugLoc(PredBB->begin()), 386 TII->get(TargetOpcode::CFI_INSTRUCTION)).addCFIIndex( 387 MI->getOperand(0).getCFIIndex()); 388 return; 389 } 390 MachineInstr &NewMI = TII->duplicate(*PredBB, PredBB->end(), *MI); 391 if (PreRegAlloc) { 392 for (unsigned i = 0, e = NewMI.getNumOperands(); i != e; ++i) { 393 MachineOperand &MO = NewMI.getOperand(i); 394 if (!MO.isReg()) 395 continue; 396 Register Reg = MO.getReg(); 397 if (!Register::isVirtualRegister(Reg)) 398 continue; 399 if (MO.isDef()) { 400 const TargetRegisterClass *RC = MRI->getRegClass(Reg); 401 Register NewReg = MRI->createVirtualRegister(RC); 402 MO.setReg(NewReg); 403 LocalVRMap.insert(std::make_pair(Reg, RegSubRegPair(NewReg, 0))); 404 if (isDefLiveOut(Reg, TailBB, MRI) || UsedByPhi.count(Reg)) 405 addSSAUpdateEntry(Reg, NewReg, PredBB); 406 } else { 407 auto VI = LocalVRMap.find(Reg); 408 if (VI != LocalVRMap.end()) { 409 // Need to make sure that the register class of the mapped register 410 // will satisfy the constraints of the class of the register being 411 // replaced. 412 auto *OrigRC = MRI->getRegClass(Reg); 413 auto *MappedRC = MRI->getRegClass(VI->second.Reg); 414 const TargetRegisterClass *ConstrRC; 415 if (VI->second.SubReg != 0) { 416 ConstrRC = TRI->getMatchingSuperRegClass(MappedRC, OrigRC, 417 VI->second.SubReg); 418 if (ConstrRC) { 419 // The actual constraining (as in "find appropriate new class") 420 // is done by getMatchingSuperRegClass, so now we only need to 421 // change the class of the mapped register. 422 MRI->setRegClass(VI->second.Reg, ConstrRC); 423 } 424 } else { 425 // For mapped registers that do not have sub-registers, simply 426 // restrict their class to match the original one. 427 ConstrRC = MRI->constrainRegClass(VI->second.Reg, OrigRC); 428 } 429 430 if (ConstrRC) { 431 // If the class constraining succeeded, we can simply replace 432 // the old register with the mapped one. 433 MO.setReg(VI->second.Reg); 434 // We have Reg -> VI.Reg:VI.SubReg, so if Reg is used with a 435 // sub-register, we need to compose the sub-register indices. 436 MO.setSubReg(TRI->composeSubRegIndices(MO.getSubReg(), 437 VI->second.SubReg)); 438 } else { 439 // The direct replacement is not possible, due to failing register 440 // class constraints. An explicit COPY is necessary. Create one 441 // that can be reused 442 auto *NewRC = MI->getRegClassConstraint(i, TII, TRI); 443 if (NewRC == nullptr) 444 NewRC = OrigRC; 445 Register NewReg = MRI->createVirtualRegister(NewRC); 446 BuildMI(*PredBB, NewMI, NewMI.getDebugLoc(), 447 TII->get(TargetOpcode::COPY), NewReg) 448 .addReg(VI->second.Reg, 0, VI->second.SubReg); 449 LocalVRMap.erase(VI); 450 LocalVRMap.insert(std::make_pair(Reg, RegSubRegPair(NewReg, 0))); 451 MO.setReg(NewReg); 452 // The composed VI.Reg:VI.SubReg is replaced with NewReg, which 453 // is equivalent to the whole register Reg. Hence, Reg:subreg 454 // is same as NewReg:subreg, so keep the sub-register index 455 // unchanged. 456 } 457 // Clear any kill flags from this operand. The new register could 458 // have uses after this one, so kills are not valid here. 459 MO.setIsKill(false); 460 } 461 } 462 } 463 } 464 } 465 466 /// After FromBB is tail duplicated into its predecessor blocks, the successors 467 /// have gained new predecessors. Update the PHI instructions in them 468 /// accordingly. 469 void TailDuplicator::updateSuccessorsPHIs( 470 MachineBasicBlock *FromBB, bool isDead, 471 SmallVectorImpl<MachineBasicBlock *> &TDBBs, 472 SmallSetVector<MachineBasicBlock *, 8> &Succs) { 473 for (MachineBasicBlock *SuccBB : Succs) { 474 for (MachineInstr &MI : *SuccBB) { 475 if (!MI.isPHI()) 476 break; 477 MachineInstrBuilder MIB(*FromBB->getParent(), MI); 478 unsigned Idx = 0; 479 for (unsigned i = 1, e = MI.getNumOperands(); i != e; i += 2) { 480 MachineOperand &MO = MI.getOperand(i + 1); 481 if (MO.getMBB() == FromBB) { 482 Idx = i; 483 break; 484 } 485 } 486 487 assert(Idx != 0); 488 MachineOperand &MO0 = MI.getOperand(Idx); 489 Register Reg = MO0.getReg(); 490 if (isDead) { 491 // Folded into the previous BB. 492 // There could be duplicate phi source entries. FIXME: Should sdisel 493 // or earlier pass fixed this? 494 for (unsigned i = MI.getNumOperands() - 2; i != Idx; i -= 2) { 495 MachineOperand &MO = MI.getOperand(i + 1); 496 if (MO.getMBB() == FromBB) { 497 MI.removeOperand(i + 1); 498 MI.removeOperand(i); 499 } 500 } 501 } else 502 Idx = 0; 503 504 // If Idx is set, the operands at Idx and Idx+1 must be removed. 505 // We reuse the location to avoid expensive removeOperand calls. 506 507 DenseMap<Register, AvailableValsTy>::iterator LI = 508 SSAUpdateVals.find(Reg); 509 if (LI != SSAUpdateVals.end()) { 510 // This register is defined in the tail block. 511 for (const std::pair<MachineBasicBlock *, Register> &J : LI->second) { 512 MachineBasicBlock *SrcBB = J.first; 513 // If we didn't duplicate a bb into a particular predecessor, we 514 // might still have added an entry to SSAUpdateVals to correcly 515 // recompute SSA. If that case, avoid adding a dummy extra argument 516 // this PHI. 517 if (!SrcBB->isSuccessor(SuccBB)) 518 continue; 519 520 Register SrcReg = J.second; 521 if (Idx != 0) { 522 MI.getOperand(Idx).setReg(SrcReg); 523 MI.getOperand(Idx + 1).setMBB(SrcBB); 524 Idx = 0; 525 } else { 526 MIB.addReg(SrcReg).addMBB(SrcBB); 527 } 528 } 529 } else { 530 // Live in tail block, must also be live in predecessors. 531 for (MachineBasicBlock *SrcBB : TDBBs) { 532 if (Idx != 0) { 533 MI.getOperand(Idx).setReg(Reg); 534 MI.getOperand(Idx + 1).setMBB(SrcBB); 535 Idx = 0; 536 } else { 537 MIB.addReg(Reg).addMBB(SrcBB); 538 } 539 } 540 } 541 if (Idx != 0) { 542 MI.removeOperand(Idx + 1); 543 MI.removeOperand(Idx); 544 } 545 } 546 } 547 } 548 549 /// Determine if it is profitable to duplicate this block. 550 bool TailDuplicator::shouldTailDuplicate(bool IsSimple, 551 MachineBasicBlock &TailBB) { 552 // When doing tail-duplication during layout, the block ordering is in flux, 553 // so canFallThrough returns a result based on incorrect information and 554 // should just be ignored. 555 if (!LayoutMode && TailBB.canFallThrough()) 556 return false; 557 558 // Don't try to tail-duplicate single-block loops. 559 if (TailBB.isSuccessor(&TailBB)) 560 return false; 561 562 // Set the limit on the cost to duplicate. When optimizing for size, 563 // duplicate only one, because one branch instruction can be eliminated to 564 // compensate for the duplication. 565 unsigned MaxDuplicateCount; 566 bool OptForSize = MF->getFunction().hasOptSize() || 567 llvm::shouldOptimizeForSize(&TailBB, PSI, MBFI); 568 if (TailDupSize == 0) 569 MaxDuplicateCount = TailDuplicateSize; 570 else 571 MaxDuplicateCount = TailDupSize; 572 if (OptForSize) 573 MaxDuplicateCount = 1; 574 575 // If the block to be duplicated ends in an unanalyzable fallthrough, don't 576 // duplicate it. 577 // A similar check is necessary in MachineBlockPlacement to make sure pairs of 578 // blocks with unanalyzable fallthrough get layed out contiguously. 579 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 580 SmallVector<MachineOperand, 4> PredCond; 581 if (TII->analyzeBranch(TailBB, PredTBB, PredFBB, PredCond) && 582 TailBB.canFallThrough()) 583 return false; 584 585 // If the target has hardware branch prediction that can handle indirect 586 // branches, duplicating them can often make them predictable when there 587 // are common paths through the code. The limit needs to be high enough 588 // to allow undoing the effects of tail merging and other optimizations 589 // that rearrange the predecessors of the indirect branch. 590 591 bool HasIndirectbr = false; 592 if (!TailBB.empty()) 593 HasIndirectbr = TailBB.back().isIndirectBranch(); 594 595 if (HasIndirectbr && PreRegAlloc) 596 MaxDuplicateCount = TailDupIndirectBranchSize; 597 598 // Check the instructions in the block to determine whether tail-duplication 599 // is invalid or unlikely to be profitable. 600 unsigned InstrCount = 0; 601 for (MachineInstr &MI : TailBB) { 602 // Non-duplicable things shouldn't be tail-duplicated. 603 // CFI instructions are marked as non-duplicable, because Darwin compact 604 // unwind info emission can't handle multiple prologue setups. In case of 605 // DWARF, allow them be duplicated, so that their existence doesn't prevent 606 // tail duplication of some basic blocks, that would be duplicated otherwise. 607 if (MI.isNotDuplicable() && 608 (TailBB.getParent()->getTarget().getTargetTriple().isOSDarwin() || 609 !MI.isCFIInstruction())) 610 return false; 611 612 // Convergent instructions can be duplicated only if doing so doesn't add 613 // new control dependencies, which is what we're going to do here. 614 if (MI.isConvergent()) 615 return false; 616 617 // Do not duplicate 'return' instructions if this is a pre-regalloc run. 618 // A return may expand into a lot more instructions (e.g. reload of callee 619 // saved registers) after PEI. 620 if (PreRegAlloc && MI.isReturn()) 621 return false; 622 623 // Avoid duplicating calls before register allocation. Calls presents a 624 // barrier to register allocation so duplicating them may end up increasing 625 // spills. 626 if (PreRegAlloc && MI.isCall()) 627 return false; 628 629 // TailDuplicator::appendCopies will erroneously place COPYs after 630 // INLINEASM_BR instructions after 4b0aa5724fea, which demonstrates the same 631 // bug that was fixed in f7a53d82c090. 632 // FIXME: Use findPHICopyInsertPoint() to find the correct insertion point 633 // for the COPY when replacing PHIs. 634 if (MI.getOpcode() == TargetOpcode::INLINEASM_BR) 635 return false; 636 637 if (MI.isBundle()) 638 InstrCount += MI.getBundleSize(); 639 else if (!MI.isPHI() && !MI.isMetaInstruction()) 640 InstrCount += 1; 641 642 if (InstrCount > MaxDuplicateCount) 643 return false; 644 } 645 646 // Check if any of the successors of TailBB has a PHI node in which the 647 // value corresponding to TailBB uses a subregister. 648 // If a phi node uses a register paired with a subregister, the actual 649 // "value type" of the phi may differ from the type of the register without 650 // any subregisters. Due to a bug, tail duplication may add a new operand 651 // without a necessary subregister, producing an invalid code. This is 652 // demonstrated by test/CodeGen/Hexagon/tail-dup-subreg-abort.ll. 653 // Disable tail duplication for this case for now, until the problem is 654 // fixed. 655 for (auto SB : TailBB.successors()) { 656 for (auto &I : *SB) { 657 if (!I.isPHI()) 658 break; 659 unsigned Idx = getPHISrcRegOpIdx(&I, &TailBB); 660 assert(Idx != 0); 661 MachineOperand &PU = I.getOperand(Idx); 662 if (PU.getSubReg() != 0) 663 return false; 664 } 665 } 666 667 if (HasIndirectbr && PreRegAlloc) 668 return true; 669 670 if (IsSimple) 671 return true; 672 673 if (!PreRegAlloc) 674 return true; 675 676 return canCompletelyDuplicateBB(TailBB); 677 } 678 679 /// True if this BB has only one unconditional jump. 680 bool TailDuplicator::isSimpleBB(MachineBasicBlock *TailBB) { 681 if (TailBB->succ_size() != 1) 682 return false; 683 if (TailBB->pred_empty()) 684 return false; 685 MachineBasicBlock::iterator I = TailBB->getFirstNonDebugInstr(true); 686 if (I == TailBB->end()) 687 return true; 688 return I->isUnconditionalBranch(); 689 } 690 691 static bool bothUsedInPHI(const MachineBasicBlock &A, 692 const SmallPtrSet<MachineBasicBlock *, 8> &SuccsB) { 693 for (MachineBasicBlock *BB : A.successors()) 694 if (SuccsB.count(BB) && !BB->empty() && BB->begin()->isPHI()) 695 return true; 696 697 return false; 698 } 699 700 bool TailDuplicator::canCompletelyDuplicateBB(MachineBasicBlock &BB) { 701 for (MachineBasicBlock *PredBB : BB.predecessors()) { 702 if (PredBB->succ_size() > 1) 703 return false; 704 705 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 706 SmallVector<MachineOperand, 4> PredCond; 707 if (TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond)) 708 return false; 709 710 if (!PredCond.empty()) 711 return false; 712 } 713 return true; 714 } 715 716 bool TailDuplicator::duplicateSimpleBB( 717 MachineBasicBlock *TailBB, SmallVectorImpl<MachineBasicBlock *> &TDBBs, 718 const DenseSet<Register> &UsedByPhi, 719 SmallVectorImpl<MachineInstr *> &Copies) { 720 SmallPtrSet<MachineBasicBlock *, 8> Succs(TailBB->succ_begin(), 721 TailBB->succ_end()); 722 SmallVector<MachineBasicBlock *, 8> Preds(TailBB->predecessors()); 723 bool Changed = false; 724 for (MachineBasicBlock *PredBB : Preds) { 725 if (PredBB->hasEHPadSuccessor() || PredBB->mayHaveInlineAsmBr()) 726 continue; 727 728 if (bothUsedInPHI(*PredBB, Succs)) 729 continue; 730 731 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 732 SmallVector<MachineOperand, 4> PredCond; 733 if (TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond)) 734 continue; 735 736 Changed = true; 737 LLVM_DEBUG(dbgs() << "\nTail-duplicating into PredBB: " << *PredBB 738 << "From simple Succ: " << *TailBB); 739 740 MachineBasicBlock *NewTarget = *TailBB->succ_begin(); 741 MachineBasicBlock *NextBB = PredBB->getNextNode(); 742 743 // Make PredFBB explicit. 744 if (PredCond.empty()) 745 PredFBB = PredTBB; 746 747 // Make fall through explicit. 748 if (!PredTBB) 749 PredTBB = NextBB; 750 if (!PredFBB) 751 PredFBB = NextBB; 752 753 // Redirect 754 if (PredFBB == TailBB) 755 PredFBB = NewTarget; 756 if (PredTBB == TailBB) 757 PredTBB = NewTarget; 758 759 // Make the branch unconditional if possible 760 if (PredTBB == PredFBB) { 761 PredCond.clear(); 762 PredFBB = nullptr; 763 } 764 765 // Avoid adding fall through branches. 766 if (PredFBB == NextBB) 767 PredFBB = nullptr; 768 if (PredTBB == NextBB && PredFBB == nullptr) 769 PredTBB = nullptr; 770 771 auto DL = PredBB->findBranchDebugLoc(); 772 TII->removeBranch(*PredBB); 773 774 if (!PredBB->isSuccessor(NewTarget)) 775 PredBB->replaceSuccessor(TailBB, NewTarget); 776 else { 777 PredBB->removeSuccessor(TailBB, true); 778 assert(PredBB->succ_size() <= 1); 779 } 780 781 if (PredTBB) 782 TII->insertBranch(*PredBB, PredTBB, PredFBB, PredCond, DL); 783 784 TDBBs.push_back(PredBB); 785 } 786 return Changed; 787 } 788 789 bool TailDuplicator::canTailDuplicate(MachineBasicBlock *TailBB, 790 MachineBasicBlock *PredBB) { 791 // EH edges are ignored by analyzeBranch. 792 if (PredBB->succ_size() > 1) 793 return false; 794 795 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 796 SmallVector<MachineOperand, 4> PredCond; 797 if (TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond)) 798 return false; 799 if (!PredCond.empty()) 800 return false; 801 return true; 802 } 803 804 /// If it is profitable, duplicate TailBB's contents in each 805 /// of its predecessors. 806 /// \p IsSimple result of isSimpleBB 807 /// \p TailBB Block to be duplicated. 808 /// \p ForcedLayoutPred When non-null, use this block as the layout predecessor 809 /// instead of the previous block in MF's order. 810 /// \p TDBBs A vector to keep track of all blocks tail-duplicated 811 /// into. 812 /// \p Copies A vector of copy instructions inserted. Used later to 813 /// walk all the inserted copies and remove redundant ones. 814 bool TailDuplicator::tailDuplicate(bool IsSimple, MachineBasicBlock *TailBB, 815 MachineBasicBlock *ForcedLayoutPred, 816 SmallVectorImpl<MachineBasicBlock *> &TDBBs, 817 SmallVectorImpl<MachineInstr *> &Copies, 818 SmallVectorImpl<MachineBasicBlock *> *CandidatePtr) { 819 LLVM_DEBUG(dbgs() << "\n*** Tail-duplicating " << printMBBReference(*TailBB) 820 << '\n'); 821 822 bool ShouldUpdateTerminators = TailBB->canFallThrough(); 823 824 DenseSet<Register> UsedByPhi; 825 getRegsUsedByPHIs(*TailBB, &UsedByPhi); 826 827 if (IsSimple) 828 return duplicateSimpleBB(TailBB, TDBBs, UsedByPhi, Copies); 829 830 // Iterate through all the unique predecessors and tail-duplicate this 831 // block into them, if possible. Copying the list ahead of time also 832 // avoids trouble with the predecessor list reallocating. 833 bool Changed = false; 834 SmallSetVector<MachineBasicBlock *, 8> Preds; 835 if (CandidatePtr) 836 Preds.insert(CandidatePtr->begin(), CandidatePtr->end()); 837 else 838 Preds.insert(TailBB->pred_begin(), TailBB->pred_end()); 839 840 for (MachineBasicBlock *PredBB : Preds) { 841 assert(TailBB != PredBB && 842 "Single-block loop should have been rejected earlier!"); 843 844 if (!canTailDuplicate(TailBB, PredBB)) 845 continue; 846 847 // Don't duplicate into a fall-through predecessor (at least for now). 848 // If profile is available, findDuplicateCandidates can choose better 849 // fall-through predecessor. 850 if (!(MF->getFunction().hasProfileData() && LayoutMode)) { 851 bool IsLayoutSuccessor = false; 852 if (ForcedLayoutPred) 853 IsLayoutSuccessor = (ForcedLayoutPred == PredBB); 854 else if (PredBB->isLayoutSuccessor(TailBB) && PredBB->canFallThrough()) 855 IsLayoutSuccessor = true; 856 if (IsLayoutSuccessor) 857 continue; 858 } 859 860 LLVM_DEBUG(dbgs() << "\nTail-duplicating into PredBB: " << *PredBB 861 << "From Succ: " << *TailBB); 862 863 TDBBs.push_back(PredBB); 864 865 // Remove PredBB's unconditional branch. 866 TII->removeBranch(*PredBB); 867 868 // Clone the contents of TailBB into PredBB. 869 DenseMap<Register, RegSubRegPair> LocalVRMap; 870 SmallVector<std::pair<Register, RegSubRegPair>, 4> CopyInfos; 871 for (MachineInstr &MI : llvm::make_early_inc_range(*TailBB)) { 872 if (MI.isPHI()) { 873 // Replace the uses of the def of the PHI with the register coming 874 // from PredBB. 875 processPHI(&MI, TailBB, PredBB, LocalVRMap, CopyInfos, UsedByPhi, true); 876 } else { 877 // Replace def of virtual registers with new registers, and update 878 // uses with PHI source register or the new registers. 879 duplicateInstruction(&MI, TailBB, PredBB, LocalVRMap, UsedByPhi); 880 } 881 } 882 appendCopies(PredBB, CopyInfos, Copies); 883 884 NumTailDupAdded += TailBB->size() - 1; // subtract one for removed branch 885 886 // Update the CFG. 887 PredBB->removeSuccessor(PredBB->succ_begin()); 888 assert(PredBB->succ_empty() && 889 "TailDuplicate called on block with multiple successors!"); 890 for (MachineBasicBlock *Succ : TailBB->successors()) 891 PredBB->addSuccessor(Succ, MBPI->getEdgeProbability(TailBB, Succ)); 892 893 // Update branches in pred to jump to tail's layout successor if needed. 894 if (ShouldUpdateTerminators) 895 PredBB->updateTerminator(TailBB->getNextNode()); 896 897 Changed = true; 898 ++NumTailDups; 899 } 900 901 // If TailBB was duplicated into all its predecessors except for the prior 902 // block, which falls through unconditionally, move the contents of this 903 // block into the prior block. 904 MachineBasicBlock *PrevBB = ForcedLayoutPred; 905 if (!PrevBB) 906 PrevBB = &*std::prev(TailBB->getIterator()); 907 MachineBasicBlock *PriorTBB = nullptr, *PriorFBB = nullptr; 908 SmallVector<MachineOperand, 4> PriorCond; 909 // This has to check PrevBB->succ_size() because EH edges are ignored by 910 // analyzeBranch. 911 if (PrevBB->succ_size() == 1 && 912 // Layout preds are not always CFG preds. Check. 913 *PrevBB->succ_begin() == TailBB && 914 !TII->analyzeBranch(*PrevBB, PriorTBB, PriorFBB, PriorCond) && 915 PriorCond.empty() && 916 (!PriorTBB || PriorTBB == TailBB) && 917 TailBB->pred_size() == 1 && 918 !TailBB->hasAddressTaken()) { 919 LLVM_DEBUG(dbgs() << "\nMerging into block: " << *PrevBB 920 << "From MBB: " << *TailBB); 921 // There may be a branch to the layout successor. This is unlikely but it 922 // happens. The correct thing to do is to remove the branch before 923 // duplicating the instructions in all cases. 924 bool RemovedBranches = TII->removeBranch(*PrevBB) != 0; 925 926 // If there are still tail instructions, abort the merge 927 if (PrevBB->getFirstTerminator() == PrevBB->end()) { 928 if (PreRegAlloc) { 929 DenseMap<Register, RegSubRegPair> LocalVRMap; 930 SmallVector<std::pair<Register, RegSubRegPair>, 4> CopyInfos; 931 MachineBasicBlock::iterator I = TailBB->begin(); 932 // Process PHI instructions first. 933 while (I != TailBB->end() && I->isPHI()) { 934 // Replace the uses of the def of the PHI with the register coming 935 // from PredBB. 936 MachineInstr *MI = &*I++; 937 processPHI(MI, TailBB, PrevBB, LocalVRMap, CopyInfos, UsedByPhi, 938 true); 939 } 940 941 // Now copy the non-PHI instructions. 942 while (I != TailBB->end()) { 943 // Replace def of virtual registers with new registers, and update 944 // uses with PHI source register or the new registers. 945 MachineInstr *MI = &*I++; 946 assert(!MI->isBundle() && "Not expecting bundles before regalloc!"); 947 duplicateInstruction(MI, TailBB, PrevBB, LocalVRMap, UsedByPhi); 948 MI->eraseFromParent(); 949 } 950 appendCopies(PrevBB, CopyInfos, Copies); 951 } else { 952 TII->removeBranch(*PrevBB); 953 // No PHIs to worry about, just splice the instructions over. 954 PrevBB->splice(PrevBB->end(), TailBB, TailBB->begin(), TailBB->end()); 955 } 956 PrevBB->removeSuccessor(PrevBB->succ_begin()); 957 assert(PrevBB->succ_empty()); 958 PrevBB->transferSuccessors(TailBB); 959 960 // Update branches in PrevBB based on Tail's layout successor. 961 if (ShouldUpdateTerminators) 962 PrevBB->updateTerminator(TailBB->getNextNode()); 963 964 TDBBs.push_back(PrevBB); 965 Changed = true; 966 } else { 967 LLVM_DEBUG(dbgs() << "Abort merging blocks, the predecessor still " 968 "contains terminator instructions"); 969 // Return early if no changes were made 970 if (!Changed) 971 return RemovedBranches; 972 } 973 Changed |= RemovedBranches; 974 } 975 976 // If this is after register allocation, there are no phis to fix. 977 if (!PreRegAlloc) 978 return Changed; 979 980 // If we made no changes so far, we are safe. 981 if (!Changed) 982 return Changed; 983 984 // Handle the nasty case in that we duplicated a block that is part of a loop 985 // into some but not all of its predecessors. For example: 986 // 1 -> 2 <-> 3 | 987 // \ | 988 // \---> rest | 989 // if we duplicate 2 into 1 but not into 3, we end up with 990 // 12 -> 3 <-> 2 -> rest | 991 // \ / | 992 // \----->-----/ | 993 // If there was a "var = phi(1, 3)" in 2, it has to be ultimately replaced 994 // with a phi in 3 (which now dominates 2). 995 // What we do here is introduce a copy in 3 of the register defined by the 996 // phi, just like when we are duplicating 2 into 3, but we don't copy any 997 // real instructions or remove the 3 -> 2 edge from the phi in 2. 998 for (MachineBasicBlock *PredBB : Preds) { 999 if (is_contained(TDBBs, PredBB)) 1000 continue; 1001 1002 // EH edges 1003 if (PredBB->succ_size() != 1) 1004 continue; 1005 1006 DenseMap<Register, RegSubRegPair> LocalVRMap; 1007 SmallVector<std::pair<Register, RegSubRegPair>, 4> CopyInfos; 1008 MachineBasicBlock::iterator I = TailBB->begin(); 1009 // Process PHI instructions first. 1010 while (I != TailBB->end() && I->isPHI()) { 1011 // Replace the uses of the def of the PHI with the register coming 1012 // from PredBB. 1013 MachineInstr *MI = &*I++; 1014 processPHI(MI, TailBB, PredBB, LocalVRMap, CopyInfos, UsedByPhi, false); 1015 } 1016 appendCopies(PredBB, CopyInfos, Copies); 1017 } 1018 1019 return Changed; 1020 } 1021 1022 /// At the end of the block \p MBB generate COPY instructions between registers 1023 /// described by \p CopyInfos. Append resulting instructions to \p Copies. 1024 void TailDuplicator::appendCopies(MachineBasicBlock *MBB, 1025 SmallVectorImpl<std::pair<Register, RegSubRegPair>> &CopyInfos, 1026 SmallVectorImpl<MachineInstr*> &Copies) { 1027 MachineBasicBlock::iterator Loc = MBB->getFirstTerminator(); 1028 const MCInstrDesc &CopyD = TII->get(TargetOpcode::COPY); 1029 for (auto &CI : CopyInfos) { 1030 auto C = BuildMI(*MBB, Loc, DebugLoc(), CopyD, CI.first) 1031 .addReg(CI.second.Reg, 0, CI.second.SubReg); 1032 Copies.push_back(C); 1033 } 1034 } 1035 1036 /// Remove the specified dead machine basic block from the function, updating 1037 /// the CFG. 1038 void TailDuplicator::removeDeadBlock( 1039 MachineBasicBlock *MBB, 1040 function_ref<void(MachineBasicBlock *)> *RemovalCallback) { 1041 assert(MBB->pred_empty() && "MBB must be dead!"); 1042 LLVM_DEBUG(dbgs() << "\nRemoving MBB: " << *MBB); 1043 1044 MachineFunction *MF = MBB->getParent(); 1045 // Update the call site info. 1046 for (const MachineInstr &MI : *MBB) 1047 if (MI.shouldUpdateCallSiteInfo()) 1048 MF->eraseCallSiteInfo(&MI); 1049 1050 if (RemovalCallback) 1051 (*RemovalCallback)(MBB); 1052 1053 // Remove all successors. 1054 while (!MBB->succ_empty()) 1055 MBB->removeSuccessor(MBB->succ_end() - 1); 1056 1057 // Remove the block. 1058 MBB->eraseFromParent(); 1059 } 1060