xref: /llvm-project/llvm/lib/CodeGen/ReachingDefAnalysis.cpp (revision 1d06e75df2a332edae972876e0e2b08dca3ba925)
1 //===---- ReachingDefAnalysis.cpp - Reaching Def Analysis ---*- C++ -*-----===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 
9 #include "llvm/ADT/SmallSet.h"
10 #include "llvm/CodeGen/LivePhysRegs.h"
11 #include "llvm/CodeGen/ReachingDefAnalysis.h"
12 #include "llvm/CodeGen/TargetRegisterInfo.h"
13 #include "llvm/CodeGen/TargetSubtargetInfo.h"
14 #include "llvm/Support/Debug.h"
15 
16 using namespace llvm;
17 
18 #define DEBUG_TYPE "reaching-deps-analysis"
19 
20 char ReachingDefAnalysis::ID = 0;
21 INITIALIZE_PASS(ReachingDefAnalysis, DEBUG_TYPE, "ReachingDefAnalysis", false,
22                 true)
23 
24 void ReachingDefAnalysis::enterBasicBlock(
25     const LoopTraversal::TraversedMBBInfo &TraversedMBB) {
26 
27   MachineBasicBlock *MBB = TraversedMBB.MBB;
28   unsigned MBBNumber = MBB->getNumber();
29   assert(MBBNumber < MBBReachingDefs.size() &&
30          "Unexpected basic block number.");
31   MBBReachingDefs[MBBNumber].resize(NumRegUnits);
32 
33   // Reset instruction counter in each basic block.
34   CurInstr = 0;
35 
36   // Set up LiveRegs to represent registers entering MBB.
37   // Default values are 'nothing happened a long time ago'.
38   if (LiveRegs.empty())
39     LiveRegs.assign(NumRegUnits, ReachingDefDefaultVal);
40 
41   // This is the entry block.
42   if (MBB->pred_empty()) {
43     for (const auto &LI : MBB->liveins()) {
44       for (MCRegUnitIterator Unit(LI.PhysReg, TRI); Unit.isValid(); ++Unit) {
45         // Treat function live-ins as if they were defined just before the first
46         // instruction.  Usually, function arguments are set up immediately
47         // before the call.
48         LiveRegs[*Unit] = -1;
49         MBBReachingDefs[MBBNumber][*Unit].push_back(LiveRegs[*Unit]);
50       }
51     }
52     LLVM_DEBUG(dbgs() << printMBBReference(*MBB) << ": entry\n");
53     return;
54   }
55 
56   // Try to coalesce live-out registers from predecessors.
57   for (MachineBasicBlock *pred : MBB->predecessors()) {
58     assert(unsigned(pred->getNumber()) < MBBOutRegsInfos.size() &&
59            "Should have pre-allocated MBBInfos for all MBBs");
60     const LiveRegsDefInfo &Incoming = MBBOutRegsInfos[pred->getNumber()];
61     // Incoming is null if this is a backedge from a BB
62     // we haven't processed yet
63     if (Incoming.empty())
64       continue;
65 
66     for (unsigned Unit = 0; Unit != NumRegUnits; ++Unit) {
67       // Use the most recent predecessor def for each register.
68       LiveRegs[Unit] = std::max(LiveRegs[Unit], Incoming[Unit]);
69       if ((LiveRegs[Unit] != ReachingDefDefaultVal))
70         MBBReachingDefs[MBBNumber][Unit].push_back(LiveRegs[Unit]);
71     }
72   }
73 
74   LLVM_DEBUG(dbgs() << printMBBReference(*MBB)
75                     << (!TraversedMBB.IsDone ? ": incomplete\n"
76                                              : ": all preds known\n"));
77 }
78 
79 void ReachingDefAnalysis::leaveBasicBlock(
80     const LoopTraversal::TraversedMBBInfo &TraversedMBB) {
81   assert(!LiveRegs.empty() && "Must enter basic block first.");
82   unsigned MBBNumber = TraversedMBB.MBB->getNumber();
83   assert(MBBNumber < MBBOutRegsInfos.size() &&
84          "Unexpected basic block number.");
85   // Save register clearances at end of MBB - used by enterBasicBlock().
86   MBBOutRegsInfos[MBBNumber] = LiveRegs;
87 
88   // While processing the basic block, we kept `Def` relative to the start
89   // of the basic block for convenience. However, future use of this information
90   // only cares about the clearance from the end of the block, so adjust
91   // everything to be relative to the end of the basic block.
92   for (int &OutLiveReg : MBBOutRegsInfos[MBBNumber])
93     OutLiveReg -= CurInstr;
94   LiveRegs.clear();
95 }
96 
97 void ReachingDefAnalysis::processDefs(MachineInstr *MI) {
98   assert(!MI->isDebugInstr() && "Won't process debug instructions");
99 
100   unsigned MBBNumber = MI->getParent()->getNumber();
101   assert(MBBNumber < MBBReachingDefs.size() &&
102          "Unexpected basic block number.");
103   const MCInstrDesc &MCID = MI->getDesc();
104   for (unsigned i = 0,
105                 e = MI->isVariadic() ? MI->getNumOperands() : MCID.getNumDefs();
106        i != e; ++i) {
107     MachineOperand &MO = MI->getOperand(i);
108     if (!MO.isReg() || !MO.getReg())
109       continue;
110     if (MO.isUse())
111       continue;
112     for (MCRegUnitIterator Unit(MO.getReg(), TRI); Unit.isValid(); ++Unit) {
113       // This instruction explicitly defines the current reg unit.
114       LLVM_DEBUG(dbgs() << printReg(MO.getReg(), TRI) << ":\t" << CurInstr
115                         << '\t' << *MI);
116 
117       // How many instructions since this reg unit was last written?
118       LiveRegs[*Unit] = CurInstr;
119       MBBReachingDefs[MBBNumber][*Unit].push_back(CurInstr);
120     }
121   }
122   InstIds[MI] = CurInstr;
123   ++CurInstr;
124 }
125 
126 void ReachingDefAnalysis::processBasicBlock(
127     const LoopTraversal::TraversedMBBInfo &TraversedMBB) {
128   enterBasicBlock(TraversedMBB);
129   for (MachineInstr &MI : *TraversedMBB.MBB) {
130     if (!MI.isDebugInstr())
131       processDefs(&MI);
132   }
133   leaveBasicBlock(TraversedMBB);
134 }
135 
136 bool ReachingDefAnalysis::runOnMachineFunction(MachineFunction &mf) {
137   MF = &mf;
138   TRI = MF->getSubtarget().getRegisterInfo();
139   LLVM_DEBUG(dbgs() << "********** REACHING DEFINITION ANALYSIS **********\n");
140   init();
141   traverse();
142   return false;
143 }
144 
145 void ReachingDefAnalysis::releaseMemory() {
146   // Clear the internal vectors.
147   MBBOutRegsInfos.clear();
148   MBBReachingDefs.clear();
149   InstIds.clear();
150   LiveRegs.clear();
151 }
152 
153 void ReachingDefAnalysis::reset() {
154   releaseMemory();
155   init();
156   traverse();
157 }
158 
159 void ReachingDefAnalysis::init() {
160   NumRegUnits = TRI->getNumRegUnits();
161   MBBReachingDefs.resize(MF->getNumBlockIDs());
162   // Initialize the MBBOutRegsInfos
163   MBBOutRegsInfos.resize(MF->getNumBlockIDs());
164   LoopTraversal Traversal;
165   TraversedMBBOrder = Traversal.traverse(*MF);
166 }
167 
168 void ReachingDefAnalysis::traverse() {
169   // Traverse the basic blocks.
170   for (LoopTraversal::TraversedMBBInfo TraversedMBB : TraversedMBBOrder)
171     processBasicBlock(TraversedMBB);
172   // Sorting all reaching defs found for a ceartin reg unit in a given BB.
173   for (MBBDefsInfo &MBBDefs : MBBReachingDefs) {
174     for (MBBRegUnitDefs &RegUnitDefs : MBBDefs)
175       llvm::sort(RegUnitDefs);
176   }
177 }
178 
179 int ReachingDefAnalysis::getReachingDef(MachineInstr *MI, int PhysReg) const {
180   assert(InstIds.count(MI) && "Unexpected machine instuction.");
181   int InstId = InstIds.lookup(MI);
182   int DefRes = ReachingDefDefaultVal;
183   unsigned MBBNumber = MI->getParent()->getNumber();
184   assert(MBBNumber < MBBReachingDefs.size() &&
185          "Unexpected basic block number.");
186   int LatestDef = ReachingDefDefaultVal;
187   for (MCRegUnitIterator Unit(PhysReg, TRI); Unit.isValid(); ++Unit) {
188     for (int Def : MBBReachingDefs[MBBNumber][*Unit]) {
189       if (Def >= InstId)
190         break;
191       DefRes = Def;
192     }
193     LatestDef = std::max(LatestDef, DefRes);
194   }
195   return LatestDef;
196 }
197 
198 MachineInstr* ReachingDefAnalysis::getReachingLocalMIDef(MachineInstr *MI,
199                                                     int PhysReg) const {
200   return getInstFromId(MI->getParent(), getReachingDef(MI, PhysReg));
201 }
202 
203 bool ReachingDefAnalysis::hasSameReachingDef(MachineInstr *A, MachineInstr *B,
204                                              int PhysReg) const {
205   MachineBasicBlock *ParentA = A->getParent();
206   MachineBasicBlock *ParentB = B->getParent();
207   if (ParentA != ParentB)
208     return false;
209 
210   return getReachingDef(A, PhysReg) == getReachingDef(B, PhysReg);
211 }
212 
213 MachineInstr *ReachingDefAnalysis::getInstFromId(MachineBasicBlock *MBB,
214                                                  int InstId) const {
215   assert(static_cast<size_t>(MBB->getNumber()) < MBBReachingDefs.size() &&
216          "Unexpected basic block number.");
217   assert(InstId < static_cast<int>(MBB->size()) &&
218          "Unexpected instruction id.");
219 
220   if (InstId < 0)
221     return nullptr;
222 
223   for (auto &MI : *MBB) {
224     auto F = InstIds.find(&MI);
225     if (F != InstIds.end() && F->second == InstId)
226       return &MI;
227   }
228 
229   return nullptr;
230 }
231 
232 int
233 ReachingDefAnalysis::getClearance(MachineInstr *MI, MCPhysReg PhysReg) const {
234   assert(InstIds.count(MI) && "Unexpected machine instuction.");
235   return InstIds.lookup(MI) - getReachingDef(MI, PhysReg);
236 }
237 
238 bool
239 ReachingDefAnalysis::hasLocalDefBefore(MachineInstr *MI, int PhysReg) const {
240   return getReachingDef(MI, PhysReg) >= 0;
241 }
242 
243 void ReachingDefAnalysis::getReachingLocalUses(MachineInstr *Def, int PhysReg,
244                                                InstSet &Uses) const {
245   MachineBasicBlock *MBB = Def->getParent();
246   MachineBasicBlock::iterator MI = MachineBasicBlock::iterator(Def);
247   while (++MI != MBB->end()) {
248     if (MI->isDebugInstr())
249       continue;
250 
251     // If/when we find a new reaching def, we know that there's no more uses
252     // of 'Def'.
253     if (getReachingLocalMIDef(&*MI, PhysReg) != Def)
254       return;
255 
256     for (auto &MO : MI->operands()) {
257       if (!MO.isReg() || !MO.isUse() || MO.getReg() != PhysReg)
258         continue;
259 
260       Uses.insert(&*MI);
261       if (MO.isKill())
262         return;
263     }
264   }
265 }
266 
267 bool
268 ReachingDefAnalysis::getLiveInUses(MachineBasicBlock *MBB, int PhysReg,
269                                    InstSet &Uses) const {
270   for (auto &MI : *MBB) {
271     if (MI.isDebugInstr())
272       continue;
273     for (auto &MO : MI.operands()) {
274       if (!MO.isReg() || !MO.isUse() || MO.getReg() != PhysReg)
275         continue;
276       if (getReachingDef(&MI, PhysReg) >= 0)
277         return false;
278       Uses.insert(&MI);
279     }
280   }
281   return isReachingDefLiveOut(&MBB->back(), PhysReg);
282 }
283 
284 void
285 ReachingDefAnalysis::getGlobalUses(MachineInstr *MI, int PhysReg,
286                                    InstSet &Uses) const {
287   MachineBasicBlock *MBB = MI->getParent();
288 
289   // Collect the uses that each def touches within the block.
290   getReachingLocalUses(MI, PhysReg, Uses);
291 
292   // Handle live-out values.
293   if (auto *LiveOut = getLocalLiveOutMIDef(MI->getParent(), PhysReg)) {
294     if (LiveOut != MI)
295       return;
296 
297     SmallVector<MachineBasicBlock*, 4> ToVisit;
298     ToVisit.insert(ToVisit.begin(), MBB->successors().begin(),
299                    MBB->successors().end());
300     SmallPtrSet<MachineBasicBlock*, 4>Visited;
301     while (!ToVisit.empty()) {
302       MachineBasicBlock *MBB = ToVisit.back();
303       ToVisit.pop_back();
304       if (Visited.count(MBB) || !MBB->isLiveIn(PhysReg))
305         continue;
306       if (getLiveInUses(MBB, PhysReg, Uses))
307         ToVisit.insert(ToVisit.end(), MBB->successors().begin(),
308                        MBB->successors().end());
309       Visited.insert(MBB);
310     }
311   }
312 }
313 
314 void
315 ReachingDefAnalysis::getLiveOuts(MachineBasicBlock *MBB, int PhysReg,
316                                  InstSet &Defs, BlockSet &VisitedBBs) const {
317   if (VisitedBBs.count(MBB))
318     return;
319 
320   VisitedBBs.insert(MBB);
321   LivePhysRegs LiveRegs(*TRI);
322   LiveRegs.addLiveOuts(*MBB);
323   if (!LiveRegs.contains(PhysReg))
324     return;
325 
326   if (auto *Def = getLocalLiveOutMIDef(MBB, PhysReg))
327     Defs.insert(Def);
328   else
329     for (auto *Pred : MBB->predecessors())
330       getLiveOuts(Pred, PhysReg, Defs, VisitedBBs);
331 }
332 
333 MachineInstr *ReachingDefAnalysis::getUniqueReachingMIDef(MachineInstr *MI,
334                                                           int PhysReg) const {
335   // If there's a local def before MI, return it.
336   MachineInstr *LocalDef = getReachingLocalMIDef(MI, PhysReg);
337   if (InstIds.lookup(LocalDef) < InstIds.lookup(MI))
338     return LocalDef;
339 
340   SmallPtrSet<MachineBasicBlock*, 4> VisitedBBs;
341   SmallPtrSet<MachineInstr*, 2> Incoming;
342   for (auto *Pred : MI->getParent()->predecessors())
343     getLiveOuts(Pred, PhysReg, Incoming, VisitedBBs);
344 
345   // If we have a local def and an incoming instruction, then there's not a
346   // unique instruction def.
347   if (!Incoming.empty() && LocalDef)
348     return nullptr;
349   else if (Incoming.size() == 1)
350     return *Incoming.begin();
351   else
352     return LocalDef;
353 }
354 
355 MachineInstr *ReachingDefAnalysis::getMIOperand(MachineInstr *MI,
356                                                 unsigned Idx) const {
357   assert(MI->getOperand(Idx).isReg() && "Expected register operand");
358   return getUniqueReachingMIDef(MI, MI->getOperand(Idx).getReg());
359 }
360 
361 MachineInstr *ReachingDefAnalysis::getMIOperand(MachineInstr *MI,
362                                                 MachineOperand &MO) const {
363   assert(MO.isReg() && "Expected register operand");
364   return getUniqueReachingMIDef(MI, MO.getReg());
365 }
366 
367 bool ReachingDefAnalysis::isRegUsedAfter(MachineInstr *MI, int PhysReg) const {
368   MachineBasicBlock *MBB = MI->getParent();
369   LivePhysRegs LiveRegs(*TRI);
370   LiveRegs.addLiveOuts(*MBB);
371 
372   // Yes if the register is live out of the basic block.
373   if (LiveRegs.contains(PhysReg))
374     return true;
375 
376   // Walk backwards through the block to see if the register is live at some
377   // point.
378   for (auto Last = MBB->rbegin(), End = MBB->rend(); Last != End; ++Last) {
379     LiveRegs.stepBackward(*Last);
380     if (LiveRegs.contains(PhysReg))
381       return InstIds.lookup(&*Last) > InstIds.lookup(MI);
382   }
383   return false;
384 }
385 
386 bool ReachingDefAnalysis::isRegDefinedAfter(MachineInstr *MI,
387                                             int PhysReg) const {
388   MachineBasicBlock *MBB = MI->getParent();
389   if (getReachingDef(MI, PhysReg) != getReachingDef(&MBB->back(), PhysReg))
390     return true;
391 
392   if (auto *Def = getLocalLiveOutMIDef(MBB, PhysReg))
393     return Def == getReachingLocalMIDef(MI, PhysReg);
394 
395   return false;
396 }
397 
398 bool
399 ReachingDefAnalysis::isReachingDefLiveOut(MachineInstr *MI, int PhysReg) const {
400   MachineBasicBlock *MBB = MI->getParent();
401   LivePhysRegs LiveRegs(*TRI);
402   LiveRegs.addLiveOuts(*MBB);
403   if (!LiveRegs.contains(PhysReg))
404     return false;
405 
406   MachineInstr *Last = &MBB->back();
407   int Def = getReachingDef(MI, PhysReg);
408   if (getReachingDef(Last, PhysReg) != Def)
409     return false;
410 
411   // Finally check that the last instruction doesn't redefine the register.
412   for (auto &MO : Last->operands())
413     if (MO.isReg() && MO.isDef() && MO.getReg() == PhysReg)
414       return false;
415 
416   return true;
417 }
418 
419 MachineInstr* ReachingDefAnalysis::getLocalLiveOutMIDef(MachineBasicBlock *MBB,
420                                                         int PhysReg) const {
421   LivePhysRegs LiveRegs(*TRI);
422   LiveRegs.addLiveOuts(*MBB);
423   if (!LiveRegs.contains(PhysReg))
424     return nullptr;
425 
426   MachineInstr *Last = &MBB->back();
427   int Def = getReachingDef(Last, PhysReg);
428   for (auto &MO : Last->operands())
429     if (MO.isReg() && MO.isDef() && MO.getReg() == PhysReg)
430       return Last;
431 
432   return Def < 0 ? nullptr : getInstFromId(MBB, Def);
433 }
434 
435 static bool mayHaveSideEffects(MachineInstr &MI) {
436   return MI.mayLoadOrStore() || MI.mayRaiseFPException() ||
437          MI.hasUnmodeledSideEffects() || MI.isTerminator() ||
438          MI.isCall() || MI.isBarrier() || MI.isBranch() || MI.isReturn();
439 }
440 
441 // Can we safely move 'From' to just before 'To'? To satisfy this, 'From' must
442 // not define a register that is used by any instructions, after and including,
443 // 'To'. These instructions also must not redefine any of Froms operands.
444 template<typename Iterator>
445 bool ReachingDefAnalysis::isSafeToMove(MachineInstr *From,
446                                        MachineInstr *To) const {
447   if (From->getParent() != To->getParent())
448     return false;
449 
450   SmallSet<int, 2> Defs;
451   // First check that From would compute the same value if moved.
452   for (auto &MO : From->operands()) {
453     if (!MO.isReg() || MO.isUndef() || !MO.getReg())
454       continue;
455     if (MO.isDef())
456       Defs.insert(MO.getReg());
457     else if (!hasSameReachingDef(From, To, MO.getReg()))
458       return false;
459   }
460 
461   // Now walk checking that the rest of the instructions will compute the same
462   // value and that we're not overwriting anything. Don't move the instruction
463   // past any memory, control-flow or other ambigious instructions.
464   for (auto I = ++Iterator(From), E = Iterator(To); I != E; ++I) {
465     if (mayHaveSideEffects(*I))
466       return false;
467     for (auto &MO : I->operands())
468       if (MO.isReg() && MO.getReg() && Defs.count(MO.getReg()))
469         return false;
470   }
471   return true;
472 }
473 
474 bool ReachingDefAnalysis::isSafeToMoveForwards(MachineInstr *From,
475                                                MachineInstr *To) const {
476   return isSafeToMove<MachineBasicBlock::reverse_iterator>(From, To);
477 }
478 
479 bool ReachingDefAnalysis::isSafeToMoveBackwards(MachineInstr *From,
480                                                 MachineInstr *To) const {
481   return isSafeToMove<MachineBasicBlock::iterator>(From, To);
482 }
483 
484 bool ReachingDefAnalysis::isSafeToRemove(MachineInstr *MI,
485                                          InstSet &ToRemove) const {
486   SmallPtrSet<MachineInstr*, 1> Ignore;
487   SmallPtrSet<MachineInstr*, 2> Visited;
488   return isSafeToRemove(MI, Visited, ToRemove, Ignore);
489 }
490 
491 bool
492 ReachingDefAnalysis::isSafeToRemove(MachineInstr *MI, InstSet &ToRemove,
493                                     InstSet &Ignore) const {
494   SmallPtrSet<MachineInstr*, 2> Visited;
495   return isSafeToRemove(MI, Visited, ToRemove, Ignore);
496 }
497 
498 bool
499 ReachingDefAnalysis::isSafeToRemove(MachineInstr *MI, InstSet &Visited,
500                                     InstSet &ToRemove, InstSet &Ignore) const {
501   if (Visited.count(MI) || Ignore.count(MI))
502     return true;
503   else if (mayHaveSideEffects(*MI)) {
504     // Unless told to ignore the instruction, don't remove anything which has
505     // side effects.
506     return false;
507   }
508 
509   Visited.insert(MI);
510   for (auto &MO : MI->operands()) {
511     if (!MO.isReg() || MO.isUse() || MO.getReg() == 0)
512       continue;
513 
514     SmallPtrSet<MachineInstr*, 4> Uses;
515     getGlobalUses(MI, MO.getReg(), Uses);
516 
517     for (auto I : Uses) {
518       if (Ignore.count(I) || ToRemove.count(I))
519         continue;
520       if (!isSafeToRemove(I, Visited, ToRemove, Ignore))
521         return false;
522     }
523   }
524   ToRemove.insert(MI);
525   return true;
526 }
527 
528 void ReachingDefAnalysis::collectLocalKilledOperands(MachineInstr *MI,
529                                                      InstSet &Dead) const {
530   Dead.insert(MI);
531   auto IsDead = [this](MachineInstr *Def, int PhysReg) {
532     unsigned LiveDefs = 0;
533     for (auto &MO : Def->defs())
534       if (!MO.isDead())
535         ++LiveDefs;
536 
537     if (LiveDefs > 1)
538       return false;
539 
540     SmallPtrSet<MachineInstr*, 4> Uses;
541     getGlobalUses(Def, PhysReg, Uses);
542     return Uses.size() == 1;
543   };
544 
545   for (auto &MO : MI->uses()) {
546     if (!MO.isReg() || MO.getReg() == 0 || !MO.isKill())
547       continue;
548     if (MachineInstr *Def = getReachingLocalMIDef(MI, MO.getReg()))
549       if (IsDead(Def, MO.getReg()))
550         collectLocalKilledOperands(Def, Dead);
551   }
552 }
553 
554 bool ReachingDefAnalysis::isSafeToDefRegAt(MachineInstr *MI,
555                                            int PhysReg) const {
556   SmallPtrSet<MachineInstr*, 1> Ignore;
557   return isSafeToDefRegAt(MI, PhysReg, Ignore);
558 }
559 
560 bool ReachingDefAnalysis::isSafeToDefRegAt(MachineInstr *MI, int PhysReg,
561                                            InstSet &Ignore) const {
562   // Check for any uses of the register after MI.
563   if (isRegUsedAfter(MI, PhysReg)) {
564     if (auto *Def = getReachingLocalMIDef(MI, PhysReg)) {
565       SmallPtrSet<MachineInstr*, 2> Uses;
566       getReachingLocalUses(Def, PhysReg, Uses);
567       for (auto *Use : Uses)
568         if (!Ignore.count(Use))
569           return false;
570     } else
571       return false;
572   }
573 
574   MachineBasicBlock *MBB = MI->getParent();
575   // Check for any defs after MI.
576   if (isRegDefinedAfter(MI, PhysReg)) {
577     auto I = MachineBasicBlock::iterator(MI);
578     for (auto E = MBB->end(); I != E; ++I) {
579       if (Ignore.count(&*I))
580         continue;
581       for (auto &MO : I->operands())
582         if (MO.isReg() && MO.isDef() && MO.getReg() == PhysReg)
583           return false;
584     }
585   }
586   return true;
587 }
588