1 //===- UncheckedOptionalAccessModelTest.cpp -------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // FIXME: Move this to clang/unittests/Analysis/FlowSensitive/Models. 9 10 #include "clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h" 11 #include "TestingSupport.h" 12 #include "clang/AST/ASTContext.h" 13 #include "clang/ASTMatchers/ASTMatchers.h" 14 #include "clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h" 15 #include "clang/Basic/SourceLocation.h" 16 #include "clang/Tooling/Tooling.h" 17 #include "llvm/ADT/DenseSet.h" 18 #include "llvm/ADT/STLExtras.h" 19 #include "llvm/Support/Error.h" 20 #include "gmock/gmock.h" 21 #include "gtest/gtest.h" 22 #include <string> 23 #include <utility> 24 #include <vector> 25 26 using namespace clang; 27 using namespace dataflow; 28 using namespace test; 29 30 using ::testing::ContainerEq; 31 32 // FIXME: Move header definitions in separate file(s). 33 static constexpr char CSDtdDefHeader[] = R"( 34 #ifndef CSTDDEF_H 35 #define CSTDDEF_H 36 37 namespace std { 38 39 typedef decltype(sizeof(char)) size_t; 40 41 using nullptr_t = decltype(nullptr); 42 43 } // namespace std 44 45 #endif // CSTDDEF_H 46 )"; 47 48 static constexpr char StdTypeTraitsHeader[] = R"( 49 #ifndef STD_TYPE_TRAITS_H 50 #define STD_TYPE_TRAITS_H 51 52 #include "cstddef.h" 53 54 namespace std { 55 56 template <typename T, T V> 57 struct integral_constant { 58 static constexpr T value = V; 59 }; 60 61 using true_type = integral_constant<bool, true>; 62 using false_type = integral_constant<bool, false>; 63 64 template< class T > struct remove_reference {typedef T type;}; 65 template< class T > struct remove_reference<T&> {typedef T type;}; 66 template< class T > struct remove_reference<T&&> {typedef T type;}; 67 68 template <class T> 69 using remove_reference_t = typename remove_reference<T>::type; 70 71 template <class T> 72 struct remove_extent { 73 typedef T type; 74 }; 75 76 template <class T> 77 struct remove_extent<T[]> { 78 typedef T type; 79 }; 80 81 template <class T, size_t N> 82 struct remove_extent<T[N]> { 83 typedef T type; 84 }; 85 86 template <class T> 87 struct is_array : false_type {}; 88 89 template <class T> 90 struct is_array<T[]> : true_type {}; 91 92 template <class T, size_t N> 93 struct is_array<T[N]> : true_type {}; 94 95 template <class> 96 struct is_function : false_type {}; 97 98 template <class Ret, class... Args> 99 struct is_function<Ret(Args...)> : true_type {}; 100 101 namespace detail { 102 103 template <class T> 104 struct type_identity { 105 using type = T; 106 }; // or use type_identity (since C++20) 107 108 template <class T> 109 auto try_add_pointer(int) -> type_identity<typename remove_reference<T>::type*>; 110 template <class T> 111 auto try_add_pointer(...) -> type_identity<T>; 112 113 } // namespace detail 114 115 template <class T> 116 struct add_pointer : decltype(detail::try_add_pointer<T>(0)) {}; 117 118 template <bool B, class T, class F> 119 struct conditional { 120 typedef T type; 121 }; 122 123 template <class T, class F> 124 struct conditional<false, T, F> { 125 typedef F type; 126 }; 127 128 template <class T> 129 struct remove_cv { 130 typedef T type; 131 }; 132 template <class T> 133 struct remove_cv<const T> { 134 typedef T type; 135 }; 136 template <class T> 137 struct remove_cv<volatile T> { 138 typedef T type; 139 }; 140 template <class T> 141 struct remove_cv<const volatile T> { 142 typedef T type; 143 }; 144 145 template <class T> 146 using remove_cv_t = typename remove_cv<T>::type; 147 148 template <class T> 149 struct decay { 150 private: 151 typedef typename remove_reference<T>::type U; 152 153 public: 154 typedef typename conditional< 155 is_array<U>::value, typename remove_extent<U>::type*, 156 typename conditional<is_function<U>::value, typename add_pointer<U>::type, 157 typename remove_cv<U>::type>::type>::type type; 158 }; 159 160 template <bool B, class T = void> 161 struct enable_if {}; 162 163 template <class T> 164 struct enable_if<true, T> { 165 typedef T type; 166 }; 167 168 template <bool B, class T = void> 169 using enable_if_t = typename enable_if<B, T>::type; 170 171 template <class T, class U> 172 struct is_same : false_type {}; 173 174 template <class T> 175 struct is_same<T, T> : true_type {}; 176 177 template <class T> 178 struct is_void : is_same<void, typename remove_cv<T>::type> {}; 179 180 namespace detail { 181 182 template <class T> 183 auto try_add_lvalue_reference(int) -> type_identity<T&>; 184 template <class T> 185 auto try_add_lvalue_reference(...) -> type_identity<T>; 186 187 template <class T> 188 auto try_add_rvalue_reference(int) -> type_identity<T&&>; 189 template <class T> 190 auto try_add_rvalue_reference(...) -> type_identity<T>; 191 192 } // namespace detail 193 194 template <class T> 195 struct add_lvalue_reference : decltype(detail::try_add_lvalue_reference<T>(0)) { 196 }; 197 198 template <class T> 199 struct add_rvalue_reference : decltype(detail::try_add_rvalue_reference<T>(0)) { 200 }; 201 202 template <class T> 203 typename add_rvalue_reference<T>::type declval() noexcept; 204 205 namespace detail { 206 207 template <class T> 208 auto test_returnable(int) 209 -> decltype(void(static_cast<T (*)()>(nullptr)), true_type{}); 210 template <class> 211 auto test_returnable(...) -> false_type; 212 213 template <class From, class To> 214 auto test_implicitly_convertible(int) 215 -> decltype(void(declval<void (&)(To)>()(declval<From>())), true_type{}); 216 template <class, class> 217 auto test_implicitly_convertible(...) -> false_type; 218 219 } // namespace detail 220 221 template <class From, class To> 222 struct is_convertible 223 : integral_constant<bool, 224 (decltype(detail::test_returnable<To>(0))::value && 225 decltype(detail::test_implicitly_convertible<From, To>( 226 0))::value) || 227 (is_void<From>::value && is_void<To>::value)> {}; 228 229 template <class From, class To> 230 inline constexpr bool is_convertible_v = is_convertible<From, To>::value; 231 232 template <class...> 233 using void_t = void; 234 235 template <class, class T, class... Args> 236 struct is_constructible_ : false_type {}; 237 238 template <class T, class... Args> 239 struct is_constructible_<void_t<decltype(T(declval<Args>()...))>, T, Args...> 240 : true_type {}; 241 242 template <class T, class... Args> 243 using is_constructible = is_constructible_<void_t<>, T, Args...>; 244 245 template <class T, class... Args> 246 inline constexpr bool is_constructible_v = is_constructible<T, Args...>::value; 247 248 template <class _Tp> 249 struct __uncvref { 250 typedef typename remove_cv<typename remove_reference<_Tp>::type>::type type; 251 }; 252 253 template <class _Tp> 254 using __uncvref_t = typename __uncvref<_Tp>::type; 255 256 template <bool _Val> 257 using _BoolConstant = integral_constant<bool, _Val>; 258 259 template <class _Tp, class _Up> 260 using _IsSame = _BoolConstant<__is_same(_Tp, _Up)>; 261 262 template <class _Tp, class _Up> 263 using _IsNotSame = _BoolConstant<!__is_same(_Tp, _Up)>; 264 265 template <bool> 266 struct _MetaBase; 267 template <> 268 struct _MetaBase<true> { 269 template <class _Tp, class _Up> 270 using _SelectImpl = _Tp; 271 template <template <class...> class _FirstFn, template <class...> class, 272 class... _Args> 273 using _SelectApplyImpl = _FirstFn<_Args...>; 274 template <class _First, class...> 275 using _FirstImpl = _First; 276 template <class, class _Second, class...> 277 using _SecondImpl = _Second; 278 template <class _Result, class _First, class... _Rest> 279 using _OrImpl = 280 typename _MetaBase<_First::value != true && sizeof...(_Rest) != 0>:: 281 template _OrImpl<_First, _Rest...>; 282 }; 283 284 template <> 285 struct _MetaBase<false> { 286 template <class _Tp, class _Up> 287 using _SelectImpl = _Up; 288 template <template <class...> class, template <class...> class _SecondFn, 289 class... _Args> 290 using _SelectApplyImpl = _SecondFn<_Args...>; 291 template <class _Result, class...> 292 using _OrImpl = _Result; 293 }; 294 295 template <bool _Cond, class _IfRes, class _ElseRes> 296 using _If = typename _MetaBase<_Cond>::template _SelectImpl<_IfRes, _ElseRes>; 297 298 template <class... _Rest> 299 using _Or = typename _MetaBase<sizeof...(_Rest) != 300 0>::template _OrImpl<false_type, _Rest...>; 301 302 template <bool _Bp, class _Tp = void> 303 using __enable_if_t = typename enable_if<_Bp, _Tp>::type; 304 305 template <class...> 306 using __expand_to_true = true_type; 307 template <class... _Pred> 308 __expand_to_true<__enable_if_t<_Pred::value>...> __and_helper(int); 309 template <class...> 310 false_type __and_helper(...); 311 template <class... _Pred> 312 using _And = decltype(__and_helper<_Pred...>(0)); 313 314 template <class _Pred> 315 struct _Not : _BoolConstant<!_Pred::value> {}; 316 317 struct __check_tuple_constructor_fail { 318 static constexpr bool __enable_explicit_default() { return false; } 319 static constexpr bool __enable_implicit_default() { return false; } 320 template <class...> 321 static constexpr bool __enable_explicit() { 322 return false; 323 } 324 template <class...> 325 static constexpr bool __enable_implicit() { 326 return false; 327 } 328 }; 329 330 template <typename, typename _Tp> 331 struct __select_2nd { 332 typedef _Tp type; 333 }; 334 template <class _Tp, class _Arg> 335 typename __select_2nd<decltype((declval<_Tp>() = declval<_Arg>())), 336 true_type>::type 337 __is_assignable_test(int); 338 template <class, class> 339 false_type __is_assignable_test(...); 340 template <class _Tp, class _Arg, 341 bool = is_void<_Tp>::value || is_void<_Arg>::value> 342 struct __is_assignable_imp 343 : public decltype((__is_assignable_test<_Tp, _Arg>(0))) {}; 344 template <class _Tp, class _Arg> 345 struct __is_assignable_imp<_Tp, _Arg, true> : public false_type {}; 346 template <class _Tp, class _Arg> 347 struct is_assignable : public __is_assignable_imp<_Tp, _Arg> {}; 348 349 template <class _Tp> 350 struct __libcpp_is_integral : public false_type {}; 351 template <> 352 struct __libcpp_is_integral<bool> : public true_type {}; 353 template <> 354 struct __libcpp_is_integral<char> : public true_type {}; 355 template <> 356 struct __libcpp_is_integral<signed char> : public true_type {}; 357 template <> 358 struct __libcpp_is_integral<unsigned char> : public true_type {}; 359 template <> 360 struct __libcpp_is_integral<wchar_t> : public true_type {}; 361 template <> 362 struct __libcpp_is_integral<short> : public true_type {}; // NOLINT 363 template <> 364 struct __libcpp_is_integral<unsigned short> : public true_type {}; // NOLINT 365 template <> 366 struct __libcpp_is_integral<int> : public true_type {}; 367 template <> 368 struct __libcpp_is_integral<unsigned int> : public true_type {}; 369 template <> 370 struct __libcpp_is_integral<long> : public true_type {}; // NOLINT 371 template <> 372 struct __libcpp_is_integral<unsigned long> : public true_type {}; // NOLINT 373 template <> 374 struct __libcpp_is_integral<long long> : public true_type {}; // NOLINT 375 template <> // NOLINTNEXTLINE 376 struct __libcpp_is_integral<unsigned long long> : public true_type {}; 377 template <class _Tp> 378 struct is_integral 379 : public __libcpp_is_integral<typename remove_cv<_Tp>::type> {}; 380 381 template <class _Tp> 382 struct __libcpp_is_floating_point : public false_type {}; 383 template <> 384 struct __libcpp_is_floating_point<float> : public true_type {}; 385 template <> 386 struct __libcpp_is_floating_point<double> : public true_type {}; 387 template <> 388 struct __libcpp_is_floating_point<long double> : public true_type {}; 389 template <class _Tp> 390 struct is_floating_point 391 : public __libcpp_is_floating_point<typename remove_cv<_Tp>::type> {}; 392 393 template <class _Tp> 394 struct is_arithmetic 395 : public integral_constant<bool, is_integral<_Tp>::value || 396 is_floating_point<_Tp>::value> {}; 397 398 template <class _Tp> 399 struct __libcpp_is_pointer : public false_type {}; 400 template <class _Tp> 401 struct __libcpp_is_pointer<_Tp*> : public true_type {}; 402 template <class _Tp> 403 struct is_pointer : public __libcpp_is_pointer<typename remove_cv<_Tp>::type> { 404 }; 405 406 template <class _Tp> 407 struct __libcpp_is_member_pointer : public false_type {}; 408 template <class _Tp, class _Up> 409 struct __libcpp_is_member_pointer<_Tp _Up::*> : public true_type {}; 410 template <class _Tp> 411 struct is_member_pointer 412 : public __libcpp_is_member_pointer<typename remove_cv<_Tp>::type> {}; 413 414 template <class _Tp> 415 struct __libcpp_union : public false_type {}; 416 template <class _Tp> 417 struct is_union : public __libcpp_union<typename remove_cv<_Tp>::type> {}; 418 419 template <class T> 420 struct is_reference : false_type {}; 421 template <class T> 422 struct is_reference<T&> : true_type {}; 423 template <class T> 424 struct is_reference<T&&> : true_type {}; 425 426 template <class T> 427 inline constexpr bool is_reference_v = is_reference<T>::value; 428 429 struct __two { 430 char __lx[2]; 431 }; 432 433 namespace __is_class_imp { 434 template <class _Tp> 435 char __test(int _Tp::*); 436 template <class _Tp> 437 __two __test(...); 438 } // namespace __is_class_imp 439 template <class _Tp> 440 struct is_class 441 : public integral_constant<bool, 442 sizeof(__is_class_imp::__test<_Tp>(0)) == 1 && 443 !is_union<_Tp>::value> {}; 444 445 template <class _Tp> 446 struct __is_nullptr_t_impl : public false_type {}; 447 template <> 448 struct __is_nullptr_t_impl<nullptr_t> : public true_type {}; 449 template <class _Tp> 450 struct __is_nullptr_t 451 : public __is_nullptr_t_impl<typename remove_cv<_Tp>::type> {}; 452 template <class _Tp> 453 struct is_null_pointer 454 : public __is_nullptr_t_impl<typename remove_cv<_Tp>::type> {}; 455 456 template <class _Tp> 457 struct is_enum 458 : public integral_constant< 459 bool, !is_void<_Tp>::value && !is_integral<_Tp>::value && 460 !is_floating_point<_Tp>::value && !is_array<_Tp>::value && 461 !is_pointer<_Tp>::value && !is_reference<_Tp>::value && 462 !is_member_pointer<_Tp>::value && !is_union<_Tp>::value && 463 !is_class<_Tp>::value && !is_function<_Tp>::value> {}; 464 465 template <class _Tp> 466 struct is_scalar 467 : public integral_constant< 468 bool, is_arithmetic<_Tp>::value || is_member_pointer<_Tp>::value || 469 is_pointer<_Tp>::value || __is_nullptr_t<_Tp>::value || 470 is_enum<_Tp>::value> {}; 471 template <> 472 struct is_scalar<nullptr_t> : public true_type {}; 473 474 } // namespace std 475 476 #endif // STD_TYPE_TRAITS_H 477 )"; 478 479 static constexpr char AbslTypeTraitsHeader[] = R"( 480 #ifndef ABSL_TYPE_TRAITS_H 481 #define ABSL_TYPE_TRAITS_H 482 483 #include "std_type_traits.h" 484 485 namespace absl { 486 487 template <typename... Ts> 488 struct conjunction : std::true_type {}; 489 490 template <typename T, typename... Ts> 491 struct conjunction<T, Ts...> 492 : std::conditional<T::value, conjunction<Ts...>, T>::type {}; 493 494 template <typename T> 495 struct conjunction<T> : T {}; 496 497 template <typename T> 498 struct negation : std::integral_constant<bool, !T::value> {}; 499 500 template <bool B, typename T = void> 501 using enable_if_t = typename std::enable_if<B, T>::type; 502 503 } // namespace absl 504 505 #endif // ABSL_TYPE_TRAITS_H 506 )"; 507 508 static constexpr char StdStringHeader[] = R"( 509 #ifndef STRING_H 510 #define STRING_H 511 512 namespace std { 513 514 struct string { 515 string(const char*); 516 ~string(); 517 bool empty(); 518 }; 519 bool operator!=(const string &LHS, const char *RHS); 520 521 } // namespace std 522 523 #endif // STRING_H 524 )"; 525 526 static constexpr char StdUtilityHeader[] = R"( 527 #ifndef UTILITY_H 528 #define UTILITY_H 529 530 #include "std_type_traits.h" 531 532 namespace std { 533 534 template <typename T> 535 constexpr remove_reference_t<T>&& move(T&& x); 536 537 template <typename T> 538 void swap(T& a, T& b) noexcept; 539 540 } // namespace std 541 542 #endif // UTILITY_H 543 )"; 544 545 static constexpr char StdInitializerListHeader[] = R"( 546 #ifndef INITIALIZER_LIST_H 547 #define INITIALIZER_LIST_H 548 549 namespace std { 550 551 template <typename T> 552 class initializer_list { 553 public: 554 initializer_list() noexcept; 555 }; 556 557 } // namespace std 558 559 #endif // INITIALIZER_LIST_H 560 )"; 561 562 static constexpr char StdOptionalHeader[] = R"( 563 #include "std_initializer_list.h" 564 #include "std_type_traits.h" 565 #include "std_utility.h" 566 567 namespace std { 568 569 struct in_place_t {}; 570 constexpr in_place_t in_place; 571 572 struct nullopt_t { 573 constexpr explicit nullopt_t() {} 574 }; 575 constexpr nullopt_t nullopt; 576 577 template <class _Tp> 578 struct __optional_destruct_base { 579 constexpr void reset() noexcept; 580 }; 581 582 template <class _Tp> 583 struct __optional_storage_base : __optional_destruct_base<_Tp> { 584 constexpr bool has_value() const noexcept; 585 }; 586 587 template <typename _Tp> 588 class optional : private __optional_storage_base<_Tp> { 589 using __base = __optional_storage_base<_Tp>; 590 591 public: 592 using value_type = _Tp; 593 594 private: 595 struct _CheckOptionalArgsConstructor { 596 template <class _Up> 597 static constexpr bool __enable_implicit() { 598 return is_constructible_v<_Tp, _Up&&> && is_convertible_v<_Up&&, _Tp>; 599 } 600 601 template <class _Up> 602 static constexpr bool __enable_explicit() { 603 return is_constructible_v<_Tp, _Up&&> && !is_convertible_v<_Up&&, _Tp>; 604 } 605 }; 606 template <class _Up> 607 using _CheckOptionalArgsCtor = 608 _If<_IsNotSame<__uncvref_t<_Up>, in_place_t>::value && 609 _IsNotSame<__uncvref_t<_Up>, optional>::value, 610 _CheckOptionalArgsConstructor, __check_tuple_constructor_fail>; 611 template <class _QualUp> 612 struct _CheckOptionalLikeConstructor { 613 template <class _Up, class _Opt = optional<_Up>> 614 using __check_constructible_from_opt = 615 _Or<is_constructible<_Tp, _Opt&>, is_constructible<_Tp, _Opt const&>, 616 is_constructible<_Tp, _Opt&&>, is_constructible<_Tp, _Opt const&&>, 617 is_convertible<_Opt&, _Tp>, is_convertible<_Opt const&, _Tp>, 618 is_convertible<_Opt&&, _Tp>, is_convertible<_Opt const&&, _Tp>>; 619 template <class _Up, class _QUp = _QualUp> 620 static constexpr bool __enable_implicit() { 621 return is_convertible<_QUp, _Tp>::value && 622 !__check_constructible_from_opt<_Up>::value; 623 } 624 template <class _Up, class _QUp = _QualUp> 625 static constexpr bool __enable_explicit() { 626 return !is_convertible<_QUp, _Tp>::value && 627 !__check_constructible_from_opt<_Up>::value; 628 } 629 }; 630 631 template <class _Up, class _QualUp> 632 using _CheckOptionalLikeCtor = 633 _If<_And<_IsNotSame<_Up, _Tp>, is_constructible<_Tp, _QualUp>>::value, 634 _CheckOptionalLikeConstructor<_QualUp>, 635 __check_tuple_constructor_fail>; 636 637 638 template <class _Up, class _QualUp> 639 using _CheckOptionalLikeAssign = _If< 640 _And< 641 _IsNotSame<_Up, _Tp>, 642 is_constructible<_Tp, _QualUp>, 643 is_assignable<_Tp&, _QualUp> 644 >::value, 645 _CheckOptionalLikeConstructor<_QualUp>, 646 __check_tuple_constructor_fail 647 >; 648 649 public: 650 constexpr optional() noexcept {} 651 constexpr optional(const optional&) = default; 652 constexpr optional(optional&&) = default; 653 constexpr optional(nullopt_t) noexcept {} 654 655 template < 656 class _InPlaceT, class... _Args, 657 class = enable_if_t<_And<_IsSame<_InPlaceT, in_place_t>, 658 is_constructible<value_type, _Args...>>::value>> 659 constexpr explicit optional(_InPlaceT, _Args&&... __args); 660 661 template <class _Up, class... _Args, 662 class = enable_if_t<is_constructible_v< 663 value_type, initializer_list<_Up>&, _Args...>>> 664 constexpr explicit optional(in_place_t, initializer_list<_Up> __il, 665 _Args&&... __args); 666 667 template < 668 class _Up = value_type, 669 enable_if_t<_CheckOptionalArgsCtor<_Up>::template __enable_implicit<_Up>(), 670 int> = 0> 671 constexpr optional(_Up&& __v); 672 673 template < 674 class _Up, 675 enable_if_t<_CheckOptionalArgsCtor<_Up>::template __enable_explicit<_Up>(), 676 int> = 0> 677 constexpr explicit optional(_Up&& __v); 678 679 template <class _Up, enable_if_t<_CheckOptionalLikeCtor<_Up, _Up const&>:: 680 template __enable_implicit<_Up>(), 681 int> = 0> 682 constexpr optional(const optional<_Up>& __v); 683 684 template <class _Up, enable_if_t<_CheckOptionalLikeCtor<_Up, _Up const&>:: 685 template __enable_explicit<_Up>(), 686 int> = 0> 687 constexpr explicit optional(const optional<_Up>& __v); 688 689 template <class _Up, enable_if_t<_CheckOptionalLikeCtor<_Up, _Up&&>:: 690 template __enable_implicit<_Up>(), 691 int> = 0> 692 constexpr optional(optional<_Up>&& __v); 693 694 template <class _Up, enable_if_t<_CheckOptionalLikeCtor<_Up, _Up&&>:: 695 template __enable_explicit<_Up>(), 696 int> = 0> 697 constexpr explicit optional(optional<_Up>&& __v); 698 699 constexpr optional& operator=(nullopt_t) noexcept; 700 701 optional& operator=(const optional&); 702 703 optional& operator=(optional&&); 704 705 template <class _Up = value_type, 706 class = enable_if_t<_And<_IsNotSame<__uncvref_t<_Up>, optional>, 707 _Or<_IsNotSame<__uncvref_t<_Up>, value_type>, 708 _Not<is_scalar<value_type>>>, 709 is_constructible<value_type, _Up>, 710 is_assignable<value_type&, _Up>>::value>> 711 constexpr optional& operator=(_Up&& __v); 712 713 template <class _Up, enable_if_t<_CheckOptionalLikeAssign<_Up, _Up const&>:: 714 template __enable_assign<_Up>(), 715 int> = 0> 716 constexpr optional& operator=(const optional<_Up>& __v); 717 718 template <class _Up, enable_if_t<_CheckOptionalLikeCtor<_Up, _Up&&>:: 719 template __enable_assign<_Up>(), 720 int> = 0> 721 constexpr optional& operator=(optional<_Up>&& __v); 722 723 const _Tp& operator*() const&; 724 _Tp& operator*() &; 725 const _Tp&& operator*() const&&; 726 _Tp&& operator*() &&; 727 728 const _Tp* operator->() const; 729 _Tp* operator->(); 730 731 const _Tp& value() const&; 732 _Tp& value() &; 733 const _Tp&& value() const&&; 734 _Tp&& value() &&; 735 736 template <typename U> 737 constexpr _Tp value_or(U&& v) const&; 738 template <typename U> 739 _Tp value_or(U&& v) &&; 740 741 template <typename... Args> 742 _Tp& emplace(Args&&... args); 743 744 template <typename U, typename... Args> 745 _Tp& emplace(std::initializer_list<U> ilist, Args&&... args); 746 747 using __base::reset; 748 749 constexpr explicit operator bool() const noexcept; 750 using __base::has_value; 751 752 constexpr void swap(optional& __opt) noexcept; 753 }; 754 755 template <typename T> 756 constexpr optional<typename std::decay<T>::type> make_optional(T&& v); 757 758 template <typename T, typename... Args> 759 constexpr optional<T> make_optional(Args&&... args); 760 761 template <typename T, typename U, typename... Args> 762 constexpr optional<T> make_optional(std::initializer_list<U> il, 763 Args&&... args); 764 765 template <typename T, typename U> 766 constexpr bool operator==(const optional<T> &lhs, const optional<U> &rhs); 767 template <typename T, typename U> 768 constexpr bool operator!=(const optional<T> &lhs, const optional<U> &rhs); 769 770 template <typename T> 771 constexpr bool operator==(const optional<T> &opt, nullopt_t); 772 template <typename T> 773 constexpr bool operator==(nullopt_t, const optional<T> &opt); 774 template <typename T> 775 constexpr bool operator!=(const optional<T> &opt, nullopt_t); 776 template <typename T> 777 constexpr bool operator!=(nullopt_t, const optional<T> &opt); 778 779 template <typename T, typename U> 780 constexpr bool operator==(const optional<T> &opt, const U &value); 781 template <typename T, typename U> 782 constexpr bool operator==(const T &value, const optional<U> &opt); 783 template <typename T, typename U> 784 constexpr bool operator!=(const optional<T> &opt, const U &value); 785 template <typename T, typename U> 786 constexpr bool operator!=(const T &value, const optional<U> &opt); 787 788 } // namespace std 789 )"; 790 791 static constexpr char AbslOptionalHeader[] = R"( 792 #include "absl_type_traits.h" 793 #include "std_initializer_list.h" 794 #include "std_type_traits.h" 795 #include "std_utility.h" 796 797 namespace absl { 798 799 struct nullopt_t { 800 constexpr explicit nullopt_t() {} 801 }; 802 constexpr nullopt_t nullopt; 803 804 struct in_place_t {}; 805 constexpr in_place_t in_place; 806 807 template <typename T> 808 class optional; 809 810 namespace optional_internal { 811 812 template <typename T, typename U> 813 struct is_constructible_convertible_from_optional 814 : std::integral_constant< 815 bool, std::is_constructible<T, optional<U>&>::value || 816 std::is_constructible<T, optional<U>&&>::value || 817 std::is_constructible<T, const optional<U>&>::value || 818 std::is_constructible<T, const optional<U>&&>::value || 819 std::is_convertible<optional<U>&, T>::value || 820 std::is_convertible<optional<U>&&, T>::value || 821 std::is_convertible<const optional<U>&, T>::value || 822 std::is_convertible<const optional<U>&&, T>::value> {}; 823 824 template <typename T, typename U> 825 struct is_constructible_convertible_assignable_from_optional 826 : std::integral_constant< 827 bool, is_constructible_convertible_from_optional<T, U>::value || 828 std::is_assignable<T&, optional<U>&>::value || 829 std::is_assignable<T&, optional<U>&&>::value || 830 std::is_assignable<T&, const optional<U>&>::value || 831 std::is_assignable<T&, const optional<U>&&>::value> {}; 832 833 } // namespace optional_internal 834 835 template <typename T> 836 class optional { 837 public: 838 constexpr optional() noexcept; 839 840 constexpr optional(nullopt_t) noexcept; 841 842 optional(const optional&) = default; 843 844 optional(optional&&) = default; 845 846 template <typename InPlaceT, typename... Args, 847 absl::enable_if_t<absl::conjunction< 848 std::is_same<InPlaceT, in_place_t>, 849 std::is_constructible<T, Args&&...>>::value>* = nullptr> 850 constexpr explicit optional(InPlaceT, Args&&... args); 851 852 template <typename U, typename... Args, 853 typename = typename std::enable_if<std::is_constructible< 854 T, std::initializer_list<U>&, Args&&...>::value>::type> 855 constexpr explicit optional(in_place_t, std::initializer_list<U> il, 856 Args&&... args); 857 858 template < 859 typename U = T, 860 typename std::enable_if< 861 absl::conjunction<absl::negation<std::is_same< 862 in_place_t, typename std::decay<U>::type>>, 863 absl::negation<std::is_same< 864 optional<T>, typename std::decay<U>::type>>, 865 std::is_convertible<U&&, T>, 866 std::is_constructible<T, U&&>>::value, 867 bool>::type = false> 868 constexpr optional(U&& v); 869 870 template < 871 typename U = T, 872 typename std::enable_if< 873 absl::conjunction<absl::negation<std::is_same< 874 in_place_t, typename std::decay<U>::type>>, 875 absl::negation<std::is_same< 876 optional<T>, typename std::decay<U>::type>>, 877 absl::negation<std::is_convertible<U&&, T>>, 878 std::is_constructible<T, U&&>>::value, 879 bool>::type = false> 880 explicit constexpr optional(U&& v); 881 882 template <typename U, 883 typename std::enable_if< 884 absl::conjunction< 885 absl::negation<std::is_same<T, U>>, 886 std::is_constructible<T, const U&>, 887 absl::negation< 888 optional_internal:: 889 is_constructible_convertible_from_optional<T, U>>, 890 std::is_convertible<const U&, T>>::value, 891 bool>::type = false> 892 optional(const optional<U>& rhs); 893 894 template <typename U, 895 typename std::enable_if< 896 absl::conjunction< 897 absl::negation<std::is_same<T, U>>, 898 std::is_constructible<T, const U&>, 899 absl::negation< 900 optional_internal:: 901 is_constructible_convertible_from_optional<T, U>>, 902 absl::negation<std::is_convertible<const U&, T>>>::value, 903 bool>::type = false> 904 explicit optional(const optional<U>& rhs); 905 906 template < 907 typename U, 908 typename std::enable_if< 909 absl::conjunction< 910 absl::negation<std::is_same<T, U>>, std::is_constructible<T, U&&>, 911 absl::negation< 912 optional_internal::is_constructible_convertible_from_optional< 913 T, U>>, 914 std::is_convertible<U&&, T>>::value, 915 bool>::type = false> 916 optional(optional<U>&& rhs); 917 918 template < 919 typename U, 920 typename std::enable_if< 921 absl::conjunction< 922 absl::negation<std::is_same<T, U>>, std::is_constructible<T, U&&>, 923 absl::negation< 924 optional_internal::is_constructible_convertible_from_optional< 925 T, U>>, 926 absl::negation<std::is_convertible<U&&, T>>>::value, 927 bool>::type = false> 928 explicit optional(optional<U>&& rhs); 929 930 optional& operator=(nullopt_t) noexcept; 931 932 optional& operator=(const optional& src); 933 934 optional& operator=(optional&& src); 935 936 template < 937 typename U = T, 938 typename = typename std::enable_if<absl::conjunction< 939 absl::negation< 940 std::is_same<optional<T>, typename std::decay<U>::type>>, 941 absl::negation< 942 absl::conjunction<std::is_scalar<T>, 943 std::is_same<T, typename std::decay<U>::type>>>, 944 std::is_constructible<T, U>, std::is_assignable<T&, U>>::value>::type> 945 optional& operator=(U&& v); 946 947 template < 948 typename U, 949 typename = typename std::enable_if<absl::conjunction< 950 absl::negation<std::is_same<T, U>>, 951 std::is_constructible<T, const U&>, std::is_assignable<T&, const U&>, 952 absl::negation< 953 optional_internal:: 954 is_constructible_convertible_assignable_from_optional< 955 T, U>>>::value>::type> 956 optional& operator=(const optional<U>& rhs); 957 958 template <typename U, 959 typename = typename std::enable_if<absl::conjunction< 960 absl::negation<std::is_same<T, U>>, std::is_constructible<T, U>, 961 std::is_assignable<T&, U>, 962 absl::negation< 963 optional_internal:: 964 is_constructible_convertible_assignable_from_optional< 965 T, U>>>::value>::type> 966 optional& operator=(optional<U>&& rhs); 967 968 const T& operator*() const&; 969 T& operator*() &; 970 const T&& operator*() const&&; 971 T&& operator*() &&; 972 973 const T* operator->() const; 974 T* operator->(); 975 976 const T& value() const&; 977 T& value() &; 978 const T&& value() const&&; 979 T&& value() &&; 980 981 template <typename U> 982 constexpr T value_or(U&& v) const&; 983 template <typename U> 984 T value_or(U&& v) &&; 985 986 template <typename... Args> 987 T& emplace(Args&&... args); 988 989 template <typename U, typename... Args> 990 T& emplace(std::initializer_list<U> ilist, Args&&... args); 991 992 void reset() noexcept; 993 994 constexpr explicit operator bool() const noexcept; 995 constexpr bool has_value() const noexcept; 996 997 void swap(optional& rhs) noexcept; 998 }; 999 1000 template <typename T> 1001 constexpr optional<typename std::decay<T>::type> make_optional(T&& v); 1002 1003 template <typename T, typename... Args> 1004 constexpr optional<T> make_optional(Args&&... args); 1005 1006 template <typename T, typename U, typename... Args> 1007 constexpr optional<T> make_optional(std::initializer_list<U> il, 1008 Args&&... args); 1009 1010 template <typename T, typename U> 1011 constexpr bool operator==(const optional<T> &lhs, const optional<U> &rhs); 1012 template <typename T, typename U> 1013 constexpr bool operator!=(const optional<T> &lhs, const optional<U> &rhs); 1014 1015 template <typename T> 1016 constexpr bool operator==(const optional<T> &opt, nullopt_t); 1017 template <typename T> 1018 constexpr bool operator==(nullopt_t, const optional<T> &opt); 1019 template <typename T> 1020 constexpr bool operator!=(const optional<T> &opt, nullopt_t); 1021 template <typename T> 1022 constexpr bool operator!=(nullopt_t, const optional<T> &opt); 1023 1024 template <typename T, typename U> 1025 constexpr bool operator==(const optional<T> &opt, const U &value); 1026 template <typename T, typename U> 1027 constexpr bool operator==(const T &value, const optional<U> &opt); 1028 template <typename T, typename U> 1029 constexpr bool operator!=(const optional<T> &opt, const U &value); 1030 template <typename T, typename U> 1031 constexpr bool operator!=(const T &value, const optional<U> &opt); 1032 1033 } // namespace absl 1034 )"; 1035 1036 static constexpr char BaseOptionalHeader[] = R"( 1037 #include "std_initializer_list.h" 1038 #include "std_type_traits.h" 1039 #include "std_utility.h" 1040 1041 namespace base { 1042 1043 struct in_place_t {}; 1044 constexpr in_place_t in_place; 1045 1046 struct nullopt_t { 1047 constexpr explicit nullopt_t() {} 1048 }; 1049 constexpr nullopt_t nullopt; 1050 1051 template <typename T> 1052 class Optional; 1053 1054 namespace internal { 1055 1056 template <typename T> 1057 using RemoveCvRefT = std::remove_cv_t<std::remove_reference_t<T>>; 1058 1059 template <typename T, typename U> 1060 struct IsConvertibleFromOptional 1061 : std::integral_constant< 1062 bool, std::is_constructible<T, Optional<U>&>::value || 1063 std::is_constructible<T, const Optional<U>&>::value || 1064 std::is_constructible<T, Optional<U>&&>::value || 1065 std::is_constructible<T, const Optional<U>&&>::value || 1066 std::is_convertible<Optional<U>&, T>::value || 1067 std::is_convertible<const Optional<U>&, T>::value || 1068 std::is_convertible<Optional<U>&&, T>::value || 1069 std::is_convertible<const Optional<U>&&, T>::value> {}; 1070 1071 template <typename T, typename U> 1072 struct IsAssignableFromOptional 1073 : std::integral_constant< 1074 bool, IsConvertibleFromOptional<T, U>::value || 1075 std::is_assignable<T&, Optional<U>&>::value || 1076 std::is_assignable<T&, const Optional<U>&>::value || 1077 std::is_assignable<T&, Optional<U>&&>::value || 1078 std::is_assignable<T&, const Optional<U>&&>::value> {}; 1079 1080 } // namespace internal 1081 1082 template <typename T> 1083 class Optional { 1084 public: 1085 using value_type = T; 1086 1087 constexpr Optional() = default; 1088 constexpr Optional(const Optional& other) noexcept = default; 1089 constexpr Optional(Optional&& other) noexcept = default; 1090 1091 constexpr Optional(nullopt_t); 1092 1093 template <typename U, 1094 typename std::enable_if< 1095 std::is_constructible<T, const U&>::value && 1096 !internal::IsConvertibleFromOptional<T, U>::value && 1097 std::is_convertible<const U&, T>::value, 1098 bool>::type = false> 1099 Optional(const Optional<U>& other) noexcept; 1100 1101 template <typename U, 1102 typename std::enable_if< 1103 std::is_constructible<T, const U&>::value && 1104 !internal::IsConvertibleFromOptional<T, U>::value && 1105 !std::is_convertible<const U&, T>::value, 1106 bool>::type = false> 1107 explicit Optional(const Optional<U>& other) noexcept; 1108 1109 template <typename U, 1110 typename std::enable_if< 1111 std::is_constructible<T, U&&>::value && 1112 !internal::IsConvertibleFromOptional<T, U>::value && 1113 std::is_convertible<U&&, T>::value, 1114 bool>::type = false> 1115 Optional(Optional<U>&& other) noexcept; 1116 1117 template <typename U, 1118 typename std::enable_if< 1119 std::is_constructible<T, U&&>::value && 1120 !internal::IsConvertibleFromOptional<T, U>::value && 1121 !std::is_convertible<U&&, T>::value, 1122 bool>::type = false> 1123 explicit Optional(Optional<U>&& other) noexcept; 1124 1125 template <class... Args> 1126 constexpr explicit Optional(in_place_t, Args&&... args); 1127 1128 template <class U, class... Args, 1129 class = typename std::enable_if<std::is_constructible< 1130 value_type, std::initializer_list<U>&, Args...>::value>::type> 1131 constexpr explicit Optional(in_place_t, std::initializer_list<U> il, 1132 Args&&... args); 1133 1134 template < 1135 typename U = value_type, 1136 typename std::enable_if< 1137 std::is_constructible<T, U&&>::value && 1138 !std::is_same<internal::RemoveCvRefT<U>, in_place_t>::value && 1139 !std::is_same<internal::RemoveCvRefT<U>, Optional<T>>::value && 1140 std::is_convertible<U&&, T>::value, 1141 bool>::type = false> 1142 constexpr Optional(U&& value); 1143 1144 template < 1145 typename U = value_type, 1146 typename std::enable_if< 1147 std::is_constructible<T, U&&>::value && 1148 !std::is_same<internal::RemoveCvRefT<U>, in_place_t>::value && 1149 !std::is_same<internal::RemoveCvRefT<U>, Optional<T>>::value && 1150 !std::is_convertible<U&&, T>::value, 1151 bool>::type = false> 1152 constexpr explicit Optional(U&& value); 1153 1154 Optional& operator=(const Optional& other) noexcept; 1155 1156 Optional& operator=(Optional&& other) noexcept; 1157 1158 Optional& operator=(nullopt_t); 1159 1160 template <typename U> 1161 typename std::enable_if< 1162 !std::is_same<internal::RemoveCvRefT<U>, Optional<T>>::value && 1163 std::is_constructible<T, U>::value && 1164 std::is_assignable<T&, U>::value && 1165 (!std::is_scalar<T>::value || 1166 !std::is_same<typename std::decay<U>::type, T>::value), 1167 Optional&>::type 1168 operator=(U&& value) noexcept; 1169 1170 template <typename U> 1171 typename std::enable_if<!internal::IsAssignableFromOptional<T, U>::value && 1172 std::is_constructible<T, const U&>::value && 1173 std::is_assignable<T&, const U&>::value, 1174 Optional&>::type 1175 operator=(const Optional<U>& other) noexcept; 1176 1177 template <typename U> 1178 typename std::enable_if<!internal::IsAssignableFromOptional<T, U>::value && 1179 std::is_constructible<T, U>::value && 1180 std::is_assignable<T&, U>::value, 1181 Optional&>::type 1182 operator=(Optional<U>&& other) noexcept; 1183 1184 const T& operator*() const&; 1185 T& operator*() &; 1186 const T&& operator*() const&&; 1187 T&& operator*() &&; 1188 1189 const T* operator->() const; 1190 T* operator->(); 1191 1192 const T& value() const&; 1193 T& value() &; 1194 const T&& value() const&&; 1195 T&& value() &&; 1196 1197 template <typename U> 1198 constexpr T value_or(U&& v) const&; 1199 template <typename U> 1200 T value_or(U&& v) &&; 1201 1202 template <typename... Args> 1203 T& emplace(Args&&... args); 1204 1205 template <typename U, typename... Args> 1206 T& emplace(std::initializer_list<U> ilist, Args&&... args); 1207 1208 void reset() noexcept; 1209 1210 constexpr explicit operator bool() const noexcept; 1211 constexpr bool has_value() const noexcept; 1212 1213 void swap(Optional& other); 1214 }; 1215 1216 template <typename T> 1217 constexpr Optional<typename std::decay<T>::type> make_optional(T&& v); 1218 1219 template <typename T, typename... Args> 1220 constexpr Optional<T> make_optional(Args&&... args); 1221 1222 template <typename T, typename U, typename... Args> 1223 constexpr Optional<T> make_optional(std::initializer_list<U> il, 1224 Args&&... args); 1225 1226 template <typename T, typename U> 1227 constexpr bool operator==(const Optional<T> &lhs, const Optional<U> &rhs); 1228 template <typename T, typename U> 1229 constexpr bool operator!=(const Optional<T> &lhs, const Optional<U> &rhs); 1230 1231 template <typename T> 1232 constexpr bool operator==(const Optional<T> &opt, nullopt_t); 1233 template <typename T> 1234 constexpr bool operator==(nullopt_t, const Optional<T> &opt); 1235 template <typename T> 1236 constexpr bool operator!=(const Optional<T> &opt, nullopt_t); 1237 template <typename T> 1238 constexpr bool operator!=(nullopt_t, const Optional<T> &opt); 1239 1240 template <typename T, typename U> 1241 constexpr bool operator==(const Optional<T> &opt, const U &value); 1242 template <typename T, typename U> 1243 constexpr bool operator==(const T &value, const Optional<U> &opt); 1244 template <typename T, typename U> 1245 constexpr bool operator!=(const Optional<T> &opt, const U &value); 1246 template <typename T, typename U> 1247 constexpr bool operator!=(const T &value, const Optional<U> &opt); 1248 1249 } // namespace base 1250 )"; 1251 1252 /// Replaces all occurrences of `Pattern` in `S` with `Replacement`. 1253 static void ReplaceAllOccurrences(std::string &S, const std::string &Pattern, 1254 const std::string &Replacement) { 1255 size_t Pos = 0; 1256 while (true) { 1257 Pos = S.find(Pattern, Pos); 1258 if (Pos == std::string::npos) 1259 break; 1260 S.replace(Pos, Pattern.size(), Replacement); 1261 } 1262 } 1263 1264 struct OptionalTypeIdentifier { 1265 std::string NamespaceName; 1266 std::string TypeName; 1267 }; 1268 1269 class UncheckedOptionalAccessTest 1270 : public ::testing::TestWithParam<OptionalTypeIdentifier> { 1271 protected: 1272 void ExpectDiagnosticsFor(std::string SourceCode) { 1273 ExpectDiagnosticsFor(SourceCode, ast_matchers::hasName("target")); 1274 } 1275 1276 private: 1277 template <typename FuncDeclMatcher> 1278 void ExpectDiagnosticsFor(std::string SourceCode, 1279 FuncDeclMatcher FuncMatcher) { 1280 ReplaceAllOccurrences(SourceCode, "$ns", GetParam().NamespaceName); 1281 ReplaceAllOccurrences(SourceCode, "$optional", GetParam().TypeName); 1282 1283 std::vector<std::pair<std::string, std::string>> Headers; 1284 Headers.emplace_back("cstddef.h", CSDtdDefHeader); 1285 Headers.emplace_back("std_initializer_list.h", StdInitializerListHeader); 1286 Headers.emplace_back("std_string.h", StdStringHeader); 1287 Headers.emplace_back("std_type_traits.h", StdTypeTraitsHeader); 1288 Headers.emplace_back("std_utility.h", StdUtilityHeader); 1289 Headers.emplace_back("std_optional.h", StdOptionalHeader); 1290 Headers.emplace_back("absl_type_traits.h", AbslTypeTraitsHeader); 1291 Headers.emplace_back("absl_optional.h", AbslOptionalHeader); 1292 Headers.emplace_back("base_optional.h", BaseOptionalHeader); 1293 Headers.emplace_back("unchecked_optional_access_test.h", R"( 1294 #include "absl_optional.h" 1295 #include "base_optional.h" 1296 #include "std_initializer_list.h" 1297 #include "std_optional.h" 1298 #include "std_string.h" 1299 #include "std_utility.h" 1300 1301 template <typename T> 1302 T Make(); 1303 )"); 1304 UncheckedOptionalAccessModelOptions Options{ 1305 /*IgnoreSmartPointerDereference=*/true}; 1306 std::vector<SourceLocation> Diagnostics; 1307 llvm::Error Error = checkDataflow<UncheckedOptionalAccessModel>( 1308 AnalysisInputs<UncheckedOptionalAccessModel>( 1309 SourceCode, std::move(FuncMatcher), 1310 [](ASTContext &Ctx, Environment &) { 1311 return UncheckedOptionalAccessModel(Ctx); 1312 }) 1313 .withPostVisitCFG( 1314 [&Diagnostics, 1315 Diagnoser = UncheckedOptionalAccessDiagnoser(Options)]( 1316 ASTContext &Ctx, const CFGElement &Elt, 1317 const TransferStateForDiagnostics<NoopLattice> 1318 &State) mutable { 1319 auto EltDiagnostics = 1320 Diagnoser.diagnose(Ctx, &Elt, State.Env); 1321 llvm::move(EltDiagnostics, std::back_inserter(Diagnostics)); 1322 }) 1323 .withASTBuildArgs( 1324 {"-fsyntax-only", "-std=c++17", "-Wno-undefined-inline"}) 1325 .withASTBuildVirtualMappedFiles( 1326 tooling::FileContentMappings(Headers.begin(), Headers.end())), 1327 /*VerifyResults=*/[&Diagnostics]( 1328 const llvm::DenseMap<unsigned, std::string> 1329 &Annotations, 1330 const AnalysisOutputs &AO) { 1331 llvm::DenseSet<unsigned> AnnotationLines; 1332 for (const auto &[Line, _] : Annotations) { 1333 AnnotationLines.insert(Line); 1334 } 1335 auto &SrcMgr = AO.ASTCtx.getSourceManager(); 1336 llvm::DenseSet<unsigned> DiagnosticLines; 1337 for (SourceLocation &Loc : Diagnostics) { 1338 DiagnosticLines.insert(SrcMgr.getPresumedLineNumber(Loc)); 1339 } 1340 1341 EXPECT_THAT(DiagnosticLines, ContainerEq(AnnotationLines)); 1342 }); 1343 if (Error) 1344 FAIL() << llvm::toString(std::move(Error)); 1345 } 1346 }; 1347 1348 INSTANTIATE_TEST_SUITE_P( 1349 UncheckedOptionalUseTestInst, UncheckedOptionalAccessTest, 1350 ::testing::Values(OptionalTypeIdentifier{"std", "optional"}, 1351 OptionalTypeIdentifier{"absl", "optional"}, 1352 OptionalTypeIdentifier{"base", "Optional"}), 1353 [](const ::testing::TestParamInfo<OptionalTypeIdentifier> &Info) { 1354 return Info.param.NamespaceName; 1355 }); 1356 1357 TEST_P(UncheckedOptionalAccessTest, EmptyFunctionBody) { 1358 ExpectDiagnosticsFor(R"( 1359 void target() { 1360 (void)0; 1361 } 1362 )"); 1363 } 1364 1365 TEST_P(UncheckedOptionalAccessTest, UnwrapUsingValueNoCheck) { 1366 ExpectDiagnosticsFor( 1367 R"( 1368 #include "unchecked_optional_access_test.h" 1369 1370 void target($ns::$optional<int> opt) { 1371 opt.value(); // [[unsafe]] 1372 } 1373 )"); 1374 1375 ExpectDiagnosticsFor( 1376 R"( 1377 #include "unchecked_optional_access_test.h" 1378 1379 void target($ns::$optional<int> opt) { 1380 std::move(opt).value(); // [[unsafe]] 1381 } 1382 )"); 1383 } 1384 1385 TEST_P(UncheckedOptionalAccessTest, UnwrapUsingOperatorStarNoCheck) { 1386 ExpectDiagnosticsFor( 1387 R"( 1388 #include "unchecked_optional_access_test.h" 1389 1390 void target($ns::$optional<int> opt) { 1391 *opt; // [[unsafe]] 1392 } 1393 )"); 1394 1395 ExpectDiagnosticsFor( 1396 R"( 1397 #include "unchecked_optional_access_test.h" 1398 1399 void target($ns::$optional<int> opt) { 1400 *std::move(opt); // [[unsafe]] 1401 } 1402 )"); 1403 } 1404 1405 TEST_P(UncheckedOptionalAccessTest, UnwrapUsingOperatorArrowNoCheck) { 1406 ExpectDiagnosticsFor( 1407 R"( 1408 #include "unchecked_optional_access_test.h" 1409 1410 struct Foo { 1411 void foo(); 1412 }; 1413 1414 void target($ns::$optional<Foo> opt) { 1415 opt->foo(); // [[unsafe]] 1416 } 1417 )"); 1418 1419 ExpectDiagnosticsFor( 1420 R"( 1421 #include "unchecked_optional_access_test.h" 1422 1423 struct Foo { 1424 void foo(); 1425 }; 1426 1427 void target($ns::$optional<Foo> opt) { 1428 std::move(opt)->foo(); // [[unsafe]] 1429 } 1430 )"); 1431 } 1432 1433 TEST_P(UncheckedOptionalAccessTest, HasValueCheck) { 1434 ExpectDiagnosticsFor(R"( 1435 #include "unchecked_optional_access_test.h" 1436 1437 void target($ns::$optional<int> opt) { 1438 if (opt.has_value()) { 1439 opt.value(); 1440 } 1441 } 1442 )"); 1443 } 1444 1445 TEST_P(UncheckedOptionalAccessTest, OperatorBoolCheck) { 1446 ExpectDiagnosticsFor(R"( 1447 #include "unchecked_optional_access_test.h" 1448 1449 void target($ns::$optional<int> opt) { 1450 if (opt) { 1451 opt.value(); 1452 } 1453 } 1454 )"); 1455 } 1456 1457 TEST_P(UncheckedOptionalAccessTest, UnwrapFunctionCallResultNoCheck) { 1458 ExpectDiagnosticsFor( 1459 R"( 1460 #include "unchecked_optional_access_test.h" 1461 1462 void target() { 1463 Make<$ns::$optional<int>>().value(); // [[unsafe]] 1464 (void)0; 1465 } 1466 )"); 1467 1468 ExpectDiagnosticsFor( 1469 R"( 1470 #include "unchecked_optional_access_test.h" 1471 1472 void target($ns::$optional<int> opt) { 1473 std::move(opt).value(); // [[unsafe]] 1474 } 1475 )"); 1476 } 1477 1478 TEST_P(UncheckedOptionalAccessTest, DefaultConstructor) { 1479 ExpectDiagnosticsFor( 1480 R"( 1481 #include "unchecked_optional_access_test.h" 1482 1483 void target() { 1484 $ns::$optional<int> opt; 1485 opt.value(); // [[unsafe]] 1486 } 1487 )"); 1488 } 1489 1490 TEST_P(UncheckedOptionalAccessTest, NulloptConstructor) { 1491 ExpectDiagnosticsFor( 1492 R"( 1493 #include "unchecked_optional_access_test.h" 1494 1495 void target() { 1496 $ns::$optional<int> opt($ns::nullopt); 1497 opt.value(); // [[unsafe]] 1498 } 1499 )"); 1500 } 1501 1502 TEST_P(UncheckedOptionalAccessTest, InPlaceConstructor) { 1503 ExpectDiagnosticsFor(R"( 1504 #include "unchecked_optional_access_test.h" 1505 1506 void target() { 1507 $ns::$optional<int> opt($ns::in_place, 3); 1508 opt.value(); 1509 } 1510 )"); 1511 1512 ExpectDiagnosticsFor(R"( 1513 #include "unchecked_optional_access_test.h" 1514 1515 struct Foo {}; 1516 1517 void target() { 1518 $ns::$optional<Foo> opt($ns::in_place); 1519 opt.value(); 1520 } 1521 )"); 1522 1523 ExpectDiagnosticsFor(R"( 1524 #include "unchecked_optional_access_test.h" 1525 1526 struct Foo { 1527 explicit Foo(int, bool); 1528 }; 1529 1530 void target() { 1531 $ns::$optional<Foo> opt($ns::in_place, 3, false); 1532 opt.value(); 1533 } 1534 )"); 1535 1536 ExpectDiagnosticsFor(R"( 1537 #include "unchecked_optional_access_test.h" 1538 1539 struct Foo { 1540 explicit Foo(std::initializer_list<int>); 1541 }; 1542 1543 void target() { 1544 $ns::$optional<Foo> opt($ns::in_place, {3}); 1545 opt.value(); 1546 } 1547 )"); 1548 } 1549 1550 TEST_P(UncheckedOptionalAccessTest, ValueConstructor) { 1551 ExpectDiagnosticsFor(R"( 1552 #include "unchecked_optional_access_test.h" 1553 1554 void target() { 1555 $ns::$optional<int> opt(21); 1556 opt.value(); 1557 } 1558 )"); 1559 1560 ExpectDiagnosticsFor(R"( 1561 #include "unchecked_optional_access_test.h" 1562 1563 void target() { 1564 $ns::$optional<int> opt = $ns::$optional<int>(21); 1565 opt.value(); 1566 } 1567 )"); 1568 ExpectDiagnosticsFor(R"( 1569 #include "unchecked_optional_access_test.h" 1570 1571 void target() { 1572 $ns::$optional<$ns::$optional<int>> opt(Make<$ns::$optional<int>>()); 1573 opt.value(); 1574 } 1575 )"); 1576 1577 ExpectDiagnosticsFor(R"( 1578 #include "unchecked_optional_access_test.h" 1579 1580 struct MyString { 1581 MyString(const char*); 1582 }; 1583 1584 void target() { 1585 $ns::$optional<MyString> opt("foo"); 1586 opt.value(); 1587 } 1588 )"); 1589 1590 ExpectDiagnosticsFor(R"( 1591 #include "unchecked_optional_access_test.h" 1592 1593 struct Foo {}; 1594 1595 struct Bar { 1596 Bar(const Foo&); 1597 }; 1598 1599 void target() { 1600 $ns::$optional<Bar> opt(Make<Foo>()); 1601 opt.value(); 1602 } 1603 )"); 1604 1605 ExpectDiagnosticsFor(R"( 1606 #include "unchecked_optional_access_test.h" 1607 1608 struct Foo { 1609 explicit Foo(int); 1610 }; 1611 1612 void target() { 1613 $ns::$optional<Foo> opt(3); 1614 opt.value(); 1615 } 1616 )"); 1617 } 1618 1619 TEST_P(UncheckedOptionalAccessTest, ConvertibleOptionalConstructor) { 1620 ExpectDiagnosticsFor( 1621 R"( 1622 #include "unchecked_optional_access_test.h" 1623 1624 struct Foo {}; 1625 1626 struct Bar { 1627 Bar(const Foo&); 1628 }; 1629 1630 void target() { 1631 $ns::$optional<Bar> opt(Make<$ns::$optional<Foo>>()); 1632 opt.value(); // [[unsafe]] 1633 } 1634 )"); 1635 1636 ExpectDiagnosticsFor( 1637 R"( 1638 #include "unchecked_optional_access_test.h" 1639 1640 struct Foo {}; 1641 1642 struct Bar { 1643 explicit Bar(const Foo&); 1644 }; 1645 1646 void target() { 1647 $ns::$optional<Bar> opt(Make<$ns::$optional<Foo>>()); 1648 opt.value(); // [[unsafe]] 1649 } 1650 )"); 1651 1652 ExpectDiagnosticsFor( 1653 R"( 1654 #include "unchecked_optional_access_test.h" 1655 1656 struct Foo {}; 1657 1658 struct Bar { 1659 Bar(const Foo&); 1660 }; 1661 1662 void target() { 1663 $ns::$optional<Foo> opt1 = $ns::nullopt; 1664 $ns::$optional<Bar> opt2(opt1); 1665 opt2.value(); // [[unsafe]] 1666 } 1667 )"); 1668 1669 ExpectDiagnosticsFor(R"( 1670 #include "unchecked_optional_access_test.h" 1671 1672 struct Foo {}; 1673 1674 struct Bar { 1675 Bar(const Foo&); 1676 }; 1677 1678 void target() { 1679 $ns::$optional<Foo> opt1(Make<Foo>()); 1680 $ns::$optional<Bar> opt2(opt1); 1681 opt2.value(); 1682 } 1683 )"); 1684 1685 ExpectDiagnosticsFor(R"( 1686 #include "unchecked_optional_access_test.h" 1687 1688 struct Foo {}; 1689 1690 struct Bar { 1691 explicit Bar(const Foo&); 1692 }; 1693 1694 void target() { 1695 $ns::$optional<Foo> opt1(Make<Foo>()); 1696 $ns::$optional<Bar> opt2(opt1); 1697 opt2.value(); 1698 } 1699 )"); 1700 } 1701 1702 TEST_P(UncheckedOptionalAccessTest, MakeOptional) { 1703 ExpectDiagnosticsFor(R"( 1704 #include "unchecked_optional_access_test.h" 1705 1706 void target() { 1707 $ns::$optional<int> opt = $ns::make_optional(0); 1708 opt.value(); 1709 } 1710 )"); 1711 1712 ExpectDiagnosticsFor(R"( 1713 #include "unchecked_optional_access_test.h" 1714 1715 struct Foo { 1716 Foo(int, int); 1717 }; 1718 1719 void target() { 1720 $ns::$optional<Foo> opt = $ns::make_optional<Foo>(21, 22); 1721 opt.value(); 1722 } 1723 )"); 1724 1725 ExpectDiagnosticsFor(R"( 1726 #include "unchecked_optional_access_test.h" 1727 1728 struct Foo { 1729 constexpr Foo(std::initializer_list<char>); 1730 }; 1731 1732 void target() { 1733 char a = 'a'; 1734 $ns::$optional<Foo> opt = $ns::make_optional<Foo>({a}); 1735 opt.value(); 1736 } 1737 )"); 1738 } 1739 1740 TEST_P(UncheckedOptionalAccessTest, ValueOr) { 1741 ExpectDiagnosticsFor(R"( 1742 #include "unchecked_optional_access_test.h" 1743 1744 void target() { 1745 $ns::$optional<int> opt; 1746 opt.value_or(0); 1747 (void)0; 1748 } 1749 )"); 1750 } 1751 1752 TEST_P(UncheckedOptionalAccessTest, ValueOrComparison) { 1753 // Pointers. 1754 ExpectDiagnosticsFor( 1755 R"code( 1756 #include "unchecked_optional_access_test.h" 1757 1758 void target($ns::$optional<int*> opt) { 1759 if (opt.value_or(nullptr) != nullptr) { 1760 opt.value(); 1761 } else { 1762 opt.value(); // [[unsafe]] 1763 } 1764 } 1765 )code"); 1766 1767 // Integers. 1768 ExpectDiagnosticsFor( 1769 R"code( 1770 #include "unchecked_optional_access_test.h" 1771 1772 void target($ns::$optional<int> opt) { 1773 if (opt.value_or(0) != 0) { 1774 opt.value(); 1775 } else { 1776 opt.value(); // [[unsafe]] 1777 } 1778 } 1779 )code"); 1780 1781 // Strings. 1782 ExpectDiagnosticsFor( 1783 R"code( 1784 #include "unchecked_optional_access_test.h" 1785 1786 void target($ns::$optional<std::string> opt) { 1787 if (!opt.value_or("").empty()) { 1788 opt.value(); 1789 } else { 1790 opt.value(); // [[unsafe]] 1791 } 1792 } 1793 )code"); 1794 1795 ExpectDiagnosticsFor( 1796 R"code( 1797 #include "unchecked_optional_access_test.h" 1798 1799 void target($ns::$optional<std::string> opt) { 1800 if (opt.value_or("") != "") { 1801 opt.value(); 1802 } else { 1803 opt.value(); // [[unsafe]] 1804 } 1805 } 1806 )code"); 1807 1808 // Pointer-to-optional. 1809 // 1810 // FIXME: make `opt` a parameter directly, once we ensure that all `optional` 1811 // values have a `has_value` property. 1812 ExpectDiagnosticsFor( 1813 R"code( 1814 #include "unchecked_optional_access_test.h" 1815 1816 void target($ns::$optional<int> p) { 1817 $ns::$optional<int> *opt = &p; 1818 if (opt->value_or(0) != 0) { 1819 opt->value(); 1820 } else { 1821 opt->value(); // [[unsafe]] 1822 } 1823 } 1824 )code"); 1825 } 1826 1827 TEST_P(UncheckedOptionalAccessTest, Emplace) { 1828 ExpectDiagnosticsFor(R"( 1829 #include "unchecked_optional_access_test.h" 1830 1831 void target() { 1832 $ns::$optional<int> opt; 1833 opt.emplace(0); 1834 opt.value(); 1835 } 1836 )"); 1837 1838 ExpectDiagnosticsFor(R"( 1839 #include "unchecked_optional_access_test.h" 1840 1841 void target($ns::$optional<int> *opt) { 1842 opt->emplace(0); 1843 opt->value(); 1844 } 1845 )"); 1846 1847 // FIXME: Add tests that call `emplace` in conditional branches: 1848 // ExpectDiagnosticsFor( 1849 // R"( 1850 // #include "unchecked_optional_access_test.h" 1851 // 1852 // void target($ns::$optional<int> opt, bool b) { 1853 // if (b) { 1854 // opt.emplace(0); 1855 // } 1856 // if (b) { 1857 // opt.value(); 1858 // } else { 1859 // opt.value(); // [[unsafe]] 1860 // } 1861 // } 1862 // )"); 1863 } 1864 1865 TEST_P(UncheckedOptionalAccessTest, Reset) { 1866 ExpectDiagnosticsFor( 1867 R"( 1868 #include "unchecked_optional_access_test.h" 1869 1870 void target() { 1871 $ns::$optional<int> opt = $ns::make_optional(0); 1872 opt.reset(); 1873 opt.value(); // [[unsafe]] 1874 } 1875 )"); 1876 1877 ExpectDiagnosticsFor( 1878 R"( 1879 #include "unchecked_optional_access_test.h" 1880 1881 void target($ns::$optional<int> &opt) { 1882 if (opt.has_value()) { 1883 opt.reset(); 1884 opt.value(); // [[unsafe]] 1885 } 1886 } 1887 )"); 1888 1889 // FIXME: Add tests that call `reset` in conditional branches: 1890 // ExpectDiagnosticsFor( 1891 // R"( 1892 // #include "unchecked_optional_access_test.h" 1893 // 1894 // void target(bool b) { 1895 // $ns::$optional<int> opt = $ns::make_optional(0); 1896 // if (b) { 1897 // opt.reset(); 1898 // } 1899 // if (b) { 1900 // opt.value(); // [[unsafe]] 1901 // } else { 1902 // opt.value(); 1903 // } 1904 // } 1905 // )"); 1906 } 1907 1908 TEST_P(UncheckedOptionalAccessTest, ValueAssignment) { 1909 ExpectDiagnosticsFor(R"( 1910 #include "unchecked_optional_access_test.h" 1911 1912 struct Foo {}; 1913 1914 void target() { 1915 $ns::$optional<Foo> opt; 1916 opt = Foo(); 1917 opt.value(); 1918 } 1919 )"); 1920 1921 ExpectDiagnosticsFor(R"( 1922 #include "unchecked_optional_access_test.h" 1923 1924 struct Foo {}; 1925 1926 void target() { 1927 $ns::$optional<Foo> opt; 1928 (opt = Foo()).value(); 1929 (void)0; 1930 } 1931 )"); 1932 1933 ExpectDiagnosticsFor(R"( 1934 #include "unchecked_optional_access_test.h" 1935 1936 struct MyString { 1937 MyString(const char*); 1938 }; 1939 1940 void target() { 1941 $ns::$optional<MyString> opt; 1942 opt = "foo"; 1943 opt.value(); 1944 } 1945 )"); 1946 1947 ExpectDiagnosticsFor(R"( 1948 #include "unchecked_optional_access_test.h" 1949 1950 struct MyString { 1951 MyString(const char*); 1952 }; 1953 1954 void target() { 1955 $ns::$optional<MyString> opt; 1956 (opt = "foo").value(); 1957 } 1958 )"); 1959 } 1960 1961 TEST_P(UncheckedOptionalAccessTest, OptionalConversionAssignment) { 1962 ExpectDiagnosticsFor( 1963 R"( 1964 #include "unchecked_optional_access_test.h" 1965 1966 struct Foo {}; 1967 1968 struct Bar { 1969 Bar(const Foo&); 1970 }; 1971 1972 void target() { 1973 $ns::$optional<Foo> opt1 = Foo(); 1974 $ns::$optional<Bar> opt2; 1975 opt2 = opt1; 1976 opt2.value(); 1977 } 1978 )"); 1979 1980 ExpectDiagnosticsFor( 1981 R"( 1982 #include "unchecked_optional_access_test.h" 1983 1984 struct Foo {}; 1985 1986 struct Bar { 1987 Bar(const Foo&); 1988 }; 1989 1990 void target() { 1991 $ns::$optional<Foo> opt1; 1992 $ns::$optional<Bar> opt2; 1993 if (opt2.has_value()) { 1994 opt2 = opt1; 1995 opt2.value(); // [[unsafe]] 1996 } 1997 } 1998 )"); 1999 2000 ExpectDiagnosticsFor( 2001 R"( 2002 #include "unchecked_optional_access_test.h" 2003 2004 struct Foo {}; 2005 2006 struct Bar { 2007 Bar(const Foo&); 2008 }; 2009 2010 void target() { 2011 $ns::$optional<Foo> opt1 = Foo(); 2012 $ns::$optional<Bar> opt2; 2013 (opt2 = opt1).value(); 2014 (void)0; 2015 } 2016 )"); 2017 } 2018 2019 TEST_P(UncheckedOptionalAccessTest, NulloptAssignment) { 2020 ExpectDiagnosticsFor( 2021 R"( 2022 #include "unchecked_optional_access_test.h" 2023 2024 void target() { 2025 $ns::$optional<int> opt = 3; 2026 opt = $ns::nullopt; 2027 opt.value(); // [[unsafe]] 2028 } 2029 )"); 2030 2031 ExpectDiagnosticsFor( 2032 R"( 2033 #include "unchecked_optional_access_test.h" 2034 2035 void target() { 2036 $ns::$optional<int> opt = 3; 2037 (opt = $ns::nullopt).value(); // [[unsafe]] 2038 } 2039 )"); 2040 } 2041 2042 TEST_P(UncheckedOptionalAccessTest, OptionalSwap) { 2043 ExpectDiagnosticsFor( 2044 R"( 2045 #include "unchecked_optional_access_test.h" 2046 2047 void target() { 2048 $ns::$optional<int> opt1 = $ns::nullopt; 2049 $ns::$optional<int> opt2 = 3; 2050 2051 opt1.swap(opt2); 2052 2053 opt1.value(); 2054 2055 opt2.value(); // [[unsafe]] 2056 } 2057 )"); 2058 2059 ExpectDiagnosticsFor( 2060 R"( 2061 #include "unchecked_optional_access_test.h" 2062 2063 void target() { 2064 $ns::$optional<int> opt1 = $ns::nullopt; 2065 $ns::$optional<int> opt2 = 3; 2066 2067 opt2.swap(opt1); 2068 2069 opt1.value(); 2070 2071 opt2.value(); // [[unsafe]] 2072 } 2073 )"); 2074 } 2075 2076 TEST_P(UncheckedOptionalAccessTest, StdSwap) { 2077 ExpectDiagnosticsFor( 2078 R"( 2079 #include "unchecked_optional_access_test.h" 2080 2081 void target() { 2082 $ns::$optional<int> opt1 = $ns::nullopt; 2083 $ns::$optional<int> opt2 = 3; 2084 2085 std::swap(opt1, opt2); 2086 2087 opt1.value(); 2088 2089 opt2.value(); // [[unsafe]] 2090 } 2091 )"); 2092 2093 ExpectDiagnosticsFor( 2094 R"( 2095 #include "unchecked_optional_access_test.h" 2096 2097 void target() { 2098 $ns::$optional<int> opt1 = $ns::nullopt; 2099 $ns::$optional<int> opt2 = 3; 2100 2101 std::swap(opt2, opt1); 2102 2103 opt1.value(); 2104 2105 opt2.value(); // [[unsafe]] 2106 } 2107 )"); 2108 } 2109 2110 TEST_P(UncheckedOptionalAccessTest, UniquePtrToOptional) { 2111 // We suppress diagnostics for optionals in smart pointers (other than 2112 // `optional` itself). 2113 ExpectDiagnosticsFor( 2114 R"( 2115 #include "unchecked_optional_access_test.h" 2116 2117 template <typename T> 2118 struct smart_ptr { 2119 T& operator*() &; 2120 T* operator->(); 2121 }; 2122 2123 void target() { 2124 smart_ptr<$ns::$optional<bool>> foo; 2125 foo->value(); 2126 (*foo).value(); 2127 } 2128 )"); 2129 } 2130 2131 TEST_P(UncheckedOptionalAccessTest, UniquePtrToStructWithOptionalField) { 2132 // We suppress diagnostics for optional fields reachable from smart pointers 2133 // (other than `optional` itself) through (exactly) one member access. 2134 ExpectDiagnosticsFor( 2135 R"( 2136 #include "unchecked_optional_access_test.h" 2137 2138 template <typename T> 2139 struct smart_ptr { 2140 T& operator*() &; 2141 T* operator->(); 2142 }; 2143 2144 struct Foo { 2145 $ns::$optional<int> opt; 2146 }; 2147 2148 void target() { 2149 smart_ptr<Foo> foo; 2150 *foo->opt; 2151 *(*foo).opt; 2152 } 2153 )"); 2154 } 2155 2156 TEST_P(UncheckedOptionalAccessTest, CallReturningOptional) { 2157 ExpectDiagnosticsFor( 2158 R"( 2159 #include "unchecked_optional_access_test.h" 2160 2161 $ns::$optional<int> MakeOpt(); 2162 2163 void target() { 2164 $ns::$optional<int> opt = 0; 2165 opt = MakeOpt(); 2166 opt.value(); // [[unsafe]] 2167 } 2168 )"); 2169 ExpectDiagnosticsFor( 2170 R"( 2171 #include "unchecked_optional_access_test.h" 2172 2173 const $ns::$optional<int>& MakeOpt(); 2174 2175 void target() { 2176 $ns::$optional<int> opt = 0; 2177 opt = MakeOpt(); 2178 opt.value(); // [[unsafe]] 2179 } 2180 )"); 2181 2182 ExpectDiagnosticsFor( 2183 R"( 2184 #include "unchecked_optional_access_test.h" 2185 2186 using IntOpt = $ns::$optional<int>; 2187 IntOpt MakeOpt(); 2188 2189 void target() { 2190 IntOpt opt = 0; 2191 opt = MakeOpt(); 2192 opt.value(); // [[unsafe]] 2193 } 2194 )"); 2195 2196 ExpectDiagnosticsFor( 2197 R"( 2198 #include "unchecked_optional_access_test.h" 2199 2200 using IntOpt = $ns::$optional<int>; 2201 const IntOpt& MakeOpt(); 2202 2203 void target() { 2204 IntOpt opt = 0; 2205 opt = MakeOpt(); 2206 opt.value(); // [[unsafe]] 2207 } 2208 )"); 2209 } 2210 2211 2212 TEST_P(UncheckedOptionalAccessTest, EqualityCheckLeftSet) { 2213 ExpectDiagnosticsFor( 2214 R"( 2215 #include "unchecked_optional_access_test.h" 2216 2217 void target() { 2218 $ns::$optional<int> opt1 = 3; 2219 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2220 2221 if (opt1 == opt2) { 2222 opt2.value(); 2223 } else { 2224 opt2.value(); // [[unsafe]] 2225 } 2226 } 2227 )"); 2228 } 2229 2230 TEST_P(UncheckedOptionalAccessTest, EqualityCheckRightSet) { 2231 ExpectDiagnosticsFor( 2232 R"( 2233 #include "unchecked_optional_access_test.h" 2234 2235 void target() { 2236 $ns::$optional<int> opt1 = 3; 2237 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2238 2239 if (opt2 == opt1) { 2240 opt2.value(); 2241 } else { 2242 opt2.value(); // [[unsafe]] 2243 } 2244 } 2245 )"); 2246 } 2247 2248 TEST_P(UncheckedOptionalAccessTest, EqualityCheckVerifySetAfterEq) { 2249 ExpectDiagnosticsFor( 2250 R"( 2251 #include "unchecked_optional_access_test.h" 2252 2253 void target() { 2254 $ns::$optional<int> opt1 = Make<$ns::$optional<int>>(); 2255 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2256 2257 if (opt1 == opt2) { 2258 if (opt1.has_value()) 2259 opt2.value(); 2260 if (opt2.has_value()) 2261 opt1.value(); 2262 } 2263 } 2264 )"); 2265 } 2266 2267 TEST_P(UncheckedOptionalAccessTest, EqualityCheckLeftUnset) { 2268 ExpectDiagnosticsFor( 2269 R"( 2270 #include "unchecked_optional_access_test.h" 2271 2272 void target() { 2273 $ns::$optional<int> opt1 = $ns::nullopt; 2274 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2275 2276 if (opt1 == opt2) { 2277 opt2.value(); // [[unsafe]] 2278 } else { 2279 opt2.value(); 2280 } 2281 } 2282 )"); 2283 } 2284 2285 TEST_P(UncheckedOptionalAccessTest, EqualityCheckRightUnset) { 2286 ExpectDiagnosticsFor( 2287 R"( 2288 #include "unchecked_optional_access_test.h" 2289 2290 void target() { 2291 $ns::$optional<int> opt1 = $ns::nullopt; 2292 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2293 2294 if (opt2 == opt1) { 2295 opt2.value(); // [[unsafe]] 2296 } else { 2297 opt2.value(); 2298 } 2299 } 2300 )"); 2301 } 2302 2303 TEST_P(UncheckedOptionalAccessTest, EqualityCheckRightNullopt) { 2304 ExpectDiagnosticsFor( 2305 R"( 2306 #include "unchecked_optional_access_test.h" 2307 2308 void target() { 2309 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2310 2311 if (opt == $ns::nullopt) { 2312 opt.value(); // [[unsafe]] 2313 } else { 2314 opt.value(); 2315 } 2316 } 2317 )"); 2318 } 2319 2320 TEST_P(UncheckedOptionalAccessTest, EqualityCheckLeftNullopt) { 2321 ExpectDiagnosticsFor( 2322 R"( 2323 #include "unchecked_optional_access_test.h" 2324 2325 void target() { 2326 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2327 2328 if ($ns::nullopt == opt) { 2329 opt.value(); // [[unsafe]] 2330 } else { 2331 opt.value(); 2332 } 2333 } 2334 )"); 2335 } 2336 2337 TEST_P(UncheckedOptionalAccessTest, EqualityCheckRightValue) { 2338 ExpectDiagnosticsFor( 2339 R"( 2340 #include "unchecked_optional_access_test.h" 2341 2342 void target() { 2343 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2344 2345 if (opt == 3) { 2346 opt.value(); 2347 } else { 2348 opt.value(); // [[unsafe]] 2349 } 2350 } 2351 )"); 2352 } 2353 2354 TEST_P(UncheckedOptionalAccessTest, EqualityCheckLeftValue) { 2355 ExpectDiagnosticsFor( 2356 R"( 2357 #include "unchecked_optional_access_test.h" 2358 2359 void target() { 2360 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2361 2362 if (3 == opt) { 2363 opt.value(); 2364 } else { 2365 opt.value(); // [[unsafe]] 2366 } 2367 } 2368 )"); 2369 } 2370 2371 TEST_P(UncheckedOptionalAccessTest, InequalityCheckLeftSet) { 2372 ExpectDiagnosticsFor( 2373 R"( 2374 #include "unchecked_optional_access_test.h" 2375 2376 void target() { 2377 $ns::$optional<int> opt1 = 3; 2378 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2379 2380 if (opt1 != opt2) { 2381 opt2.value(); // [[unsafe]] 2382 } else { 2383 opt2.value(); 2384 } 2385 } 2386 )"); 2387 } 2388 2389 TEST_P(UncheckedOptionalAccessTest, InequalityCheckRightSet) { 2390 ExpectDiagnosticsFor( 2391 R"( 2392 #include "unchecked_optional_access_test.h" 2393 2394 void target() { 2395 $ns::$optional<int> opt1 = 3; 2396 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2397 2398 if (opt2 != opt1) { 2399 opt2.value(); // [[unsafe]] 2400 } else { 2401 opt2.value(); 2402 } 2403 } 2404 )"); 2405 } 2406 2407 TEST_P(UncheckedOptionalAccessTest, InequalityCheckVerifySetAfterEq) { 2408 ExpectDiagnosticsFor( 2409 R"( 2410 #include "unchecked_optional_access_test.h" 2411 2412 void target() { 2413 $ns::$optional<int> opt1 = Make<$ns::$optional<int>>(); 2414 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2415 2416 if (opt1 != opt2) { 2417 if (opt1.has_value()) 2418 opt2.value(); // [[unsafe]] 2419 if (opt2.has_value()) 2420 opt1.value(); // [[unsafe]] 2421 } 2422 } 2423 )"); 2424 } 2425 2426 TEST_P(UncheckedOptionalAccessTest, InequalityCheckLeftUnset) { 2427 ExpectDiagnosticsFor( 2428 R"( 2429 #include "unchecked_optional_access_test.h" 2430 2431 void target() { 2432 $ns::$optional<int> opt1 = $ns::nullopt; 2433 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2434 2435 if (opt1 != opt2) { 2436 opt2.value(); 2437 } else { 2438 opt2.value(); // [[unsafe]] 2439 } 2440 } 2441 )"); 2442 } 2443 2444 TEST_P(UncheckedOptionalAccessTest, InequalityCheckRightUnset) { 2445 ExpectDiagnosticsFor( 2446 R"( 2447 #include "unchecked_optional_access_test.h" 2448 2449 void target() { 2450 $ns::$optional<int> opt1 = $ns::nullopt; 2451 $ns::$optional<int> opt2 = Make<$ns::$optional<int>>(); 2452 2453 if (opt2 != opt1) { 2454 opt2.value(); 2455 } else { 2456 opt2.value(); // [[unsafe]] 2457 } 2458 } 2459 )"); 2460 } 2461 2462 TEST_P(UncheckedOptionalAccessTest, InequalityCheckRightNullopt) { 2463 ExpectDiagnosticsFor( 2464 R"( 2465 #include "unchecked_optional_access_test.h" 2466 2467 void target() { 2468 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2469 2470 if (opt != $ns::nullopt) { 2471 opt.value(); 2472 } else { 2473 opt.value(); // [[unsafe]] 2474 } 2475 } 2476 )"); 2477 } 2478 2479 TEST_P(UncheckedOptionalAccessTest, InequalityCheckLeftNullopt) { 2480 ExpectDiagnosticsFor( 2481 R"( 2482 #include "unchecked_optional_access_test.h" 2483 2484 void target() { 2485 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2486 2487 if ($ns::nullopt != opt) { 2488 opt.value(); 2489 } else { 2490 opt.value(); // [[unsafe]] 2491 } 2492 } 2493 )"); 2494 } 2495 2496 TEST_P(UncheckedOptionalAccessTest, InequalityCheckRightValue) { 2497 ExpectDiagnosticsFor( 2498 R"( 2499 #include "unchecked_optional_access_test.h" 2500 2501 void target() { 2502 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2503 2504 if (opt != 3) { 2505 opt.value(); // [[unsafe]] 2506 } else { 2507 opt.value(); 2508 } 2509 } 2510 )"); 2511 } 2512 2513 TEST_P(UncheckedOptionalAccessTest, InequalityCheckLeftValue) { 2514 ExpectDiagnosticsFor( 2515 R"( 2516 #include "unchecked_optional_access_test.h" 2517 2518 void target() { 2519 $ns::$optional<int> opt = Make<$ns::$optional<int>>(); 2520 2521 if (3 != opt) { 2522 opt.value(); // [[unsafe]] 2523 } else { 2524 opt.value(); 2525 } 2526 } 2527 )"); 2528 } 2529 2530 // Verifies that the model sees through aliases. 2531 TEST_P(UncheckedOptionalAccessTest, WithAlias) { 2532 ExpectDiagnosticsFor( 2533 R"( 2534 #include "unchecked_optional_access_test.h" 2535 2536 template <typename T> 2537 using MyOptional = $ns::$optional<T>; 2538 2539 void target(MyOptional<int> opt) { 2540 opt.value(); // [[unsafe]] 2541 } 2542 )"); 2543 } 2544 2545 TEST_P(UncheckedOptionalAccessTest, OptionalValueOptional) { 2546 // Basic test that nested values are populated. We nest an optional because 2547 // its easy to use in a test, but the type of the nested value shouldn't 2548 // matter. 2549 ExpectDiagnosticsFor( 2550 R"( 2551 #include "unchecked_optional_access_test.h" 2552 2553 using Foo = $ns::$optional<std::string>; 2554 2555 void target($ns::$optional<Foo> foo) { 2556 if (foo && *foo) { 2557 foo->value(); 2558 } 2559 } 2560 )"); 2561 2562 // Mutation is supported for nested values. 2563 ExpectDiagnosticsFor( 2564 R"( 2565 #include "unchecked_optional_access_test.h" 2566 2567 using Foo = $ns::$optional<std::string>; 2568 2569 void target($ns::$optional<Foo> foo) { 2570 if (foo && *foo) { 2571 foo->reset(); 2572 foo->value(); // [[unsafe]] 2573 } 2574 } 2575 )"); 2576 } 2577 2578 // Tests that structs can be nested. We use an optional field because its easy 2579 // to use in a test, but the type of the field shouldn't matter. 2580 TEST_P(UncheckedOptionalAccessTest, OptionalValueStruct) { 2581 ExpectDiagnosticsFor( 2582 R"( 2583 #include "unchecked_optional_access_test.h" 2584 2585 struct Foo { 2586 $ns::$optional<std::string> opt; 2587 }; 2588 2589 void target($ns::$optional<Foo> foo) { 2590 if (foo && foo->opt) { 2591 foo->opt.value(); 2592 } 2593 } 2594 )"); 2595 } 2596 2597 TEST_P(UncheckedOptionalAccessTest, OptionalValueInitialization) { 2598 // FIXME: Fix when to initialize `value`. All unwrapping should be safe in 2599 // this example, but `value` initialization is done multiple times during the 2600 // fixpoint iterations and joining the environment won't correctly merge them. 2601 ExpectDiagnosticsFor( 2602 R"( 2603 #include "unchecked_optional_access_test.h" 2604 2605 using Foo = $ns::$optional<std::string>; 2606 2607 void target($ns::$optional<Foo> foo, bool b) { 2608 if (!foo.has_value()) return; 2609 if (b) { 2610 if (!foo->has_value()) return; 2611 // We have created `foo.value()`. 2612 foo->value(); 2613 } else { 2614 if (!foo->has_value()) return; 2615 // We have created `foo.value()` again, in a different environment. 2616 foo->value(); 2617 } 2618 // Now we merge the two values. UncheckedOptionalAccessModel::merge() will 2619 // throw away the "value" property. 2620 foo->value(); // [[unsafe]] 2621 } 2622 )"); 2623 } 2624 2625 // This test is aimed at the core model, not the diagnostic. It is a regression 2626 // test against a crash when using non-trivial smart pointers, like 2627 // `std::unique_ptr`. As such, it doesn't test the access itself, which would be 2628 // ignored regardless because of `IgnoreSmartPointerDereference = true`, above. 2629 TEST_P(UncheckedOptionalAccessTest, AssignThroughLvalueReferencePtr) { 2630 ExpectDiagnosticsFor( 2631 R"( 2632 #include "unchecked_optional_access_test.h" 2633 2634 template <typename T> 2635 struct smart_ptr { 2636 typename std::add_lvalue_reference<T>::type operator*() &; 2637 }; 2638 2639 void target() { 2640 smart_ptr<$ns::$optional<int>> x; 2641 // Verify that this assignment does not crash. 2642 *x = 3; 2643 } 2644 )"); 2645 } 2646 2647 TEST_P(UncheckedOptionalAccessTest, CorrelatedBranches) { 2648 ExpectDiagnosticsFor(R"code( 2649 #include "unchecked_optional_access_test.h" 2650 2651 void target(bool b, $ns::$optional<int> opt) { 2652 if (b || opt.has_value()) { 2653 if (!b) { 2654 opt.value(); 2655 } 2656 } 2657 } 2658 )code"); 2659 2660 ExpectDiagnosticsFor(R"code( 2661 #include "unchecked_optional_access_test.h" 2662 2663 void target(bool b, $ns::$optional<int> opt) { 2664 if (b && !opt.has_value()) return; 2665 if (b) { 2666 opt.value(); 2667 } 2668 } 2669 )code"); 2670 2671 ExpectDiagnosticsFor( 2672 R"code( 2673 #include "unchecked_optional_access_test.h" 2674 2675 void target(bool b, $ns::$optional<int> opt) { 2676 if (opt.has_value()) b = true; 2677 if (b) { 2678 opt.value(); // [[unsafe]] 2679 } 2680 } 2681 )code"); 2682 2683 ExpectDiagnosticsFor(R"code( 2684 #include "unchecked_optional_access_test.h" 2685 2686 void target(bool b, $ns::$optional<int> opt) { 2687 if (b) return; 2688 if (opt.has_value()) b = true; 2689 if (b) { 2690 opt.value(); 2691 } 2692 } 2693 )code"); 2694 2695 ExpectDiagnosticsFor(R"( 2696 #include "unchecked_optional_access_test.h" 2697 2698 void target(bool b, $ns::$optional<int> opt) { 2699 if (opt.has_value() == b) { 2700 if (b) { 2701 opt.value(); 2702 } 2703 } 2704 } 2705 )"); 2706 2707 ExpectDiagnosticsFor(R"( 2708 #include "unchecked_optional_access_test.h" 2709 2710 void target(bool b, $ns::$optional<int> opt) { 2711 if (opt.has_value() != b) { 2712 if (!b) { 2713 opt.value(); 2714 } 2715 } 2716 } 2717 )"); 2718 2719 ExpectDiagnosticsFor(R"( 2720 #include "unchecked_optional_access_test.h" 2721 2722 void target(bool b) { 2723 $ns::$optional<int> opt1 = $ns::nullopt; 2724 $ns::$optional<int> opt2; 2725 if (b) { 2726 opt2 = $ns::nullopt; 2727 } else { 2728 opt2 = $ns::nullopt; 2729 } 2730 if (opt2.has_value()) { 2731 opt1.value(); 2732 } 2733 } 2734 )"); 2735 2736 // FIXME: Add support for operator==. 2737 // ExpectDiagnosticsFor(R"( 2738 // #include "unchecked_optional_access_test.h" 2739 // 2740 // void target($ns::$optional<int> opt1, $ns::$optional<int> opt2) { 2741 // if (opt1 == opt2) { 2742 // if (opt1.has_value()) { 2743 // opt2.value(); 2744 // } 2745 // } 2746 // } 2747 // )"); 2748 } 2749 2750 TEST_P(UncheckedOptionalAccessTest, JoinDistinctValues) { 2751 ExpectDiagnosticsFor( 2752 R"code( 2753 #include "unchecked_optional_access_test.h" 2754 2755 void target(bool b) { 2756 $ns::$optional<int> opt; 2757 if (b) { 2758 opt = Make<$ns::$optional<int>>(); 2759 } else { 2760 opt = Make<$ns::$optional<int>>(); 2761 } 2762 if (opt.has_value()) { 2763 opt.value(); 2764 } else { 2765 opt.value(); // [[unsafe]] 2766 } 2767 } 2768 )code"); 2769 2770 ExpectDiagnosticsFor(R"code( 2771 #include "unchecked_optional_access_test.h" 2772 2773 void target(bool b) { 2774 $ns::$optional<int> opt; 2775 if (b) { 2776 opt = Make<$ns::$optional<int>>(); 2777 if (!opt.has_value()) return; 2778 } else { 2779 opt = Make<$ns::$optional<int>>(); 2780 if (!opt.has_value()) return; 2781 } 2782 opt.value(); 2783 } 2784 )code"); 2785 2786 ExpectDiagnosticsFor( 2787 R"code( 2788 #include "unchecked_optional_access_test.h" 2789 2790 void target(bool b) { 2791 $ns::$optional<int> opt; 2792 if (b) { 2793 opt = Make<$ns::$optional<int>>(); 2794 if (!opt.has_value()) return; 2795 } else { 2796 opt = Make<$ns::$optional<int>>(); 2797 } 2798 opt.value(); // [[unsafe]] 2799 } 2800 )code"); 2801 2802 ExpectDiagnosticsFor( 2803 R"code( 2804 #include "unchecked_optional_access_test.h" 2805 2806 void target(bool b) { 2807 $ns::$optional<int> opt; 2808 if (b) { 2809 opt = 1; 2810 } else { 2811 opt = 2; 2812 } 2813 opt.value(); 2814 } 2815 )code"); 2816 2817 ExpectDiagnosticsFor( 2818 R"code( 2819 #include "unchecked_optional_access_test.h" 2820 2821 void target(bool b) { 2822 $ns::$optional<int> opt; 2823 if (b) { 2824 opt = 1; 2825 } else { 2826 opt = Make<$ns::$optional<int>>(); 2827 } 2828 opt.value(); // [[unsafe]] 2829 } 2830 )code"); 2831 } 2832 2833 TEST_P(UncheckedOptionalAccessTest, ReassignValueInLoop) { 2834 ExpectDiagnosticsFor(R"( 2835 #include "unchecked_optional_access_test.h" 2836 2837 void target() { 2838 $ns::$optional<int> opt = 3; 2839 while (Make<bool>()) { 2840 opt.value(); 2841 } 2842 } 2843 )"); 2844 2845 ExpectDiagnosticsFor(R"( 2846 #include "unchecked_optional_access_test.h" 2847 2848 void target() { 2849 $ns::$optional<int> opt = 3; 2850 while (Make<bool>()) { 2851 opt.value(); 2852 2853 opt = Make<$ns::$optional<int>>(); 2854 if (!opt.has_value()) return; 2855 } 2856 } 2857 )"); 2858 2859 ExpectDiagnosticsFor( 2860 R"( 2861 #include "unchecked_optional_access_test.h" 2862 2863 void target() { 2864 $ns::$optional<int> opt = 3; 2865 while (Make<bool>()) { 2866 opt.value(); // [[unsafe]] 2867 2868 opt = Make<$ns::$optional<int>>(); 2869 } 2870 } 2871 )"); 2872 2873 ExpectDiagnosticsFor( 2874 R"( 2875 #include "unchecked_optional_access_test.h" 2876 2877 void target() { 2878 $ns::$optional<int> opt = 3; 2879 while (Make<bool>()) { 2880 opt.value(); // [[unsafe]] 2881 2882 opt = Make<$ns::$optional<int>>(); 2883 if (!opt.has_value()) continue; 2884 } 2885 } 2886 )"); 2887 } 2888 2889 TEST_P(UncheckedOptionalAccessTest, StructuredBindingsFromStruct) { 2890 ExpectDiagnosticsFor(R"( 2891 #include "unchecked_optional_access_test.h" 2892 2893 struct kv { $ns::$optional<int> opt; int x; }; 2894 int target() { 2895 auto [contents, x] = Make<kv>(); 2896 return contents ? *contents : x; 2897 } 2898 )"); 2899 2900 ExpectDiagnosticsFor(R"( 2901 #include "unchecked_optional_access_test.h" 2902 2903 template <typename T1, typename T2> 2904 struct pair { T1 fst; T2 snd; }; 2905 int target() { 2906 auto [contents, x] = Make<pair<$ns::$optional<int>, int>>(); 2907 return contents ? *contents : x; 2908 } 2909 )"); 2910 } 2911 2912 TEST_P(UncheckedOptionalAccessTest, StructuredBindingsFromTupleLikeType) { 2913 ExpectDiagnosticsFor(R"( 2914 #include "unchecked_optional_access_test.h" 2915 2916 namespace std { 2917 template <class> struct tuple_size; 2918 template <size_t, class> struct tuple_element; 2919 template <class...> class tuple; 2920 2921 template <class... T> 2922 struct tuple_size<tuple<T...>> : integral_constant<size_t, sizeof...(T)> {}; 2923 2924 template <size_t I, class... T> 2925 struct tuple_element<I, tuple<T...>> { 2926 using type = __type_pack_element<I, T...>; 2927 }; 2928 2929 template <class...> class tuple {}; 2930 template <size_t I, class... T> 2931 typename tuple_element<I, tuple<T...>>::type get(tuple<T...>); 2932 } // namespace std 2933 2934 std::tuple<$ns::$optional<const char *>, int> get_opt(); 2935 void target() { 2936 auto [content, ck] = get_opt(); 2937 content ? *content : ""; 2938 } 2939 )"); 2940 } 2941 2942 // FIXME: Add support for: 2943 // - constructors (copy, move) 2944 // - assignment operators (default, copy, move) 2945 // - invalidation (passing optional by non-const reference/pointer) 2946