183f875dcSMike Crowe // RUN: %check_clang_tidy \ 283f875dcSMike Crowe // RUN: -std=c++23 %s modernize-use-std-print %t -- \ 3*222dd235SCongcong Cai // RUN: -config="{CheckOptions: {modernize-use-std-print.StrictMode: true}}" \ 483f875dcSMike Crowe // RUN: -- -isystem %clang_tidy_headers 583f875dcSMike Crowe // RUN: %check_clang_tidy \ 683f875dcSMike Crowe // RUN: -std=c++23 %s modernize-use-std-print %t -- \ 7*222dd235SCongcong Cai // RUN: -config="{CheckOptions: {modernize-use-std-print.StrictMode: false}}" \ 883f875dcSMike Crowe // RUN: -- -isystem %clang_tidy_headers 983f875dcSMike Crowe 1083f875dcSMike Crowe #include <cstdio> 1183f875dcSMike Crowe #include <string.h> 1283f875dcSMike Crowe 1383f875dcSMike Crowe namespace absl 1483f875dcSMike Crowe { 1583f875dcSMike Crowe // Use const char * for the format since the real type is hard to mock up. 1683f875dcSMike Crowe template <typename... Args> 1783f875dcSMike Crowe int PrintF(const char *format, const Args&... args); 1883f875dcSMike Crowe 1983f875dcSMike Crowe template <typename... Args> 2083f875dcSMike Crowe int FPrintF(FILE* output, const char *format, const Args&... args); 2183f875dcSMike Crowe } 2283f875dcSMike Crowe 2383f875dcSMike Crowe void printf_simple() { 2483f875dcSMike Crowe absl::PrintF("Hello %s %d", "world", 42); 2583f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::print' instead of 'PrintF' [modernize-use-std-print] 2683f875dcSMike Crowe // CHECK-FIXES: std::print("Hello {} {}", "world", 42); 2783f875dcSMike Crowe } 2883f875dcSMike Crowe 2983f875dcSMike Crowe void printf_newline() { 3083f875dcSMike Crowe absl::PrintF("Hello %s %d\n", "world", 42); 3183f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'PrintF' [modernize-use-std-print] 3283f875dcSMike Crowe // CHECK-FIXES: std::println("Hello {} {}", "world", 42); 3383f875dcSMike Crowe 3483f875dcSMike Crowe using namespace absl; 3583f875dcSMike Crowe PrintF("Hello %s %d\n", "world", 42); 3683f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'PrintF' [modernize-use-std-print] 3783f875dcSMike Crowe // CHECK-FIXES: std::println("Hello {} {}", "world", 42); 3883f875dcSMike Crowe } 3983f875dcSMike Crowe 4083f875dcSMike Crowe // absl uses the type of the argument rather than the format string, so unsigned 4183f875dcSMike Crowe // types will be printed as unsigned even if the format string indicates signed 4283f875dcSMike Crowe // and vice-versa. This is exactly what std::print will do too, so no casts are 4383f875dcSMike Crowe // required. 4483f875dcSMike Crowe void printf_no_casts_in_strict_mode() { 4583f875dcSMike Crowe using namespace absl; 4683f875dcSMike Crowe 4783f875dcSMike Crowe const unsigned short us = 42U; 4883f875dcSMike Crowe PrintF("Integer %hd from unsigned short\n", us); 4983f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'PrintF' [modernize-use-std-print] 5083f875dcSMike Crowe // CHECK-FIXES: std::println("Integer {} from unsigned short", us); 5183f875dcSMike Crowe 5283f875dcSMike Crowe const short s = 42; 5383f875dcSMike Crowe PrintF("Unsigned integer %hu from short\n", s); 5483f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'PrintF' [modernize-use-std-print] 5583f875dcSMike Crowe // CHECK-FIXES: std::println("Unsigned integer {} from short", s); 5683f875dcSMike Crowe } 5783f875dcSMike Crowe 5809ed2102SMike Crowe int printf_uses_return_value(int i) { 5909ed2102SMike Crowe using namespace absl; 6009ed2102SMike Crowe 6109ed2102SMike Crowe return PrintF("return value %d\n", i); 6209ed2102SMike Crowe } 6309ed2102SMike Crowe 6483f875dcSMike Crowe void fprintf_simple(FILE *fp) { 6583f875dcSMike Crowe absl::FPrintF(fp, "Hello %s %d", "world", 42); 6683f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::print' instead of 'FPrintF' [modernize-use-std-print] 6783f875dcSMike Crowe // CHECK-FIXES: std::print(fp, "Hello {} {}", "world", 42); 6883f875dcSMike Crowe } 6983f875dcSMike Crowe 7083f875dcSMike Crowe void fprintf_newline(FILE *fp) { 7183f875dcSMike Crowe absl::FPrintF(fp, "Hello %s %d\n", "world", 42); 7283f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'FPrintF' [modernize-use-std-print] 7383f875dcSMike Crowe // CHECK-FIXES: std::println(fp, "Hello {} {}", "world", 42); 7483f875dcSMike Crowe 7583f875dcSMike Crowe using namespace absl; 7683f875dcSMike Crowe FPrintF(fp, "Hello %s %d\n", "world", 42); 7783f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'FPrintF' [modernize-use-std-print] 7883f875dcSMike Crowe // CHECK-FIXES: std::println(fp, "Hello {} {}", "world", 42); 7983f875dcSMike Crowe } 8083f875dcSMike Crowe 8183f875dcSMike Crowe void fprintf_no_casts_in_strict_mode(FILE *fp) { 8283f875dcSMike Crowe using namespace absl; 8383f875dcSMike Crowe 8483f875dcSMike Crowe const unsigned short us = 42U; 8583f875dcSMike Crowe FPrintF(fp, "Integer %hd from unsigned short\n", us); 8683f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'FPrintF' [modernize-use-std-print] 8783f875dcSMike Crowe // CHECK-FIXES: std::println(fp, "Integer {} from unsigned short", us); 8883f875dcSMike Crowe 8983f875dcSMike Crowe const short s = 42; 9083f875dcSMike Crowe FPrintF(fp, "Unsigned integer %hu from short\n", s); 9183f875dcSMike Crowe // CHECK-MESSAGES: [[@LINE-1]]:3: warning: use 'std::println' instead of 'FPrintF' [modernize-use-std-print] 9283f875dcSMike Crowe // CHECK-FIXES: std::println(fp, "Unsigned integer {} from short", s); 9383f875dcSMike Crowe } 9409ed2102SMike Crowe 9509ed2102SMike Crowe int fprintf_uses_return_value(FILE *fp, int i) { 9609ed2102SMike Crowe using namespace absl; 9709ed2102SMike Crowe 9809ed2102SMike Crowe return FPrintF(fp, "return value %d\n", i); 9909ed2102SMike Crowe } 100