xref: /freebsd-src/crypto/libecc/src/sig/ecrdsa.c (revision f0865ec9906d5a18fa2a3b61381f22ce16e606ad)
1*f0865ec9SKyle Evans /*
2*f0865ec9SKyle Evans  *  Copyright (C) 2017 - This file is part of libecc project
3*f0865ec9SKyle Evans  *
4*f0865ec9SKyle Evans  *  Authors:
5*f0865ec9SKyle Evans  *	Ryad BENADJILA <ryadbenadjila@gmail.com>
6*f0865ec9SKyle Evans  *	Arnaud EBALARD <arnaud.ebalard@ssi.gouv.fr>
7*f0865ec9SKyle Evans  *	Jean-Pierre FLORI <jean-pierre.flori@ssi.gouv.fr>
8*f0865ec9SKyle Evans  *
9*f0865ec9SKyle Evans  *  Contributors:
10*f0865ec9SKyle Evans  *	Nicolas VIVET <nicolas.vivet@ssi.gouv.fr>
11*f0865ec9SKyle Evans  *	Karim KHALFALLAH <karim.khalfallah@ssi.gouv.fr>
12*f0865ec9SKyle Evans  *
13*f0865ec9SKyle Evans  *  This software is licensed under a dual BSD and GPL v2 license.
14*f0865ec9SKyle Evans  *  See LICENSE file at the root folder of the project.
15*f0865ec9SKyle Evans  */
16*f0865ec9SKyle Evans #include <libecc/lib_ecc_config.h>
17*f0865ec9SKyle Evans #ifdef WITH_SIG_ECRDSA
18*f0865ec9SKyle Evans 
19*f0865ec9SKyle Evans #include <libecc/nn/nn_rand.h>
20*f0865ec9SKyle Evans #include <libecc/nn/nn_mul_public.h>
21*f0865ec9SKyle Evans #include <libecc/nn/nn_logical.h>
22*f0865ec9SKyle Evans 
23*f0865ec9SKyle Evans #include <libecc/sig/sig_algs_internal.h>
24*f0865ec9SKyle Evans #include <libecc/sig/ec_key.h>
25*f0865ec9SKyle Evans #ifdef VERBOSE_INNER_VALUES
26*f0865ec9SKyle Evans #define EC_SIG_ALG "ECRDSA"
27*f0865ec9SKyle Evans #endif
28*f0865ec9SKyle Evans #include <libecc/utils/dbg_sig.h>
29*f0865ec9SKyle Evans 
30*f0865ec9SKyle Evans 
31*f0865ec9SKyle Evans /*
32*f0865ec9SKyle Evans  * NOTE: ISO/IEC 14888-3 standard seems to diverge from the existing implementations
33*f0865ec9SKyle Evans  * of ECRDSA when treating the message hash, and from the examples of certificates provided
34*f0865ec9SKyle Evans  * in RFC 7091 and draft-deremin-rfc4491-bis. While in ISO/IEC 14888-3 it is explicitely asked
35*f0865ec9SKyle Evans  * to proceed with the hash of the message as big endian, the RFCs derived from the Russian
36*f0865ec9SKyle Evans  * standard expect the hash value to be treated as little endian when importing it as an integer
37*f0865ec9SKyle Evans  * (this discrepancy is exhibited and confirmed by test vectors present in ISO/IEC 14888-3, and
38*f0865ec9SKyle Evans  * by X.509 certificates present in the RFCs). This seems (to be confirmed) to be a discrepancy of
39*f0865ec9SKyle Evans  * ISO/IEC 14888-3 algorithm description that must be fixed there.
40*f0865ec9SKyle Evans  *
41*f0865ec9SKyle Evans  * In order to be conservative, libecc uses the Russian standard behavior as expected to be in line with
42*f0865ec9SKyle Evans  * other implemetations, but keeps the ISO/IEC 14888-3 behavior if forced/asked by the user using
43*f0865ec9SKyle Evans  * the USE_ISO14888_3_ECRDSA toggle. This allows to keep backward compatibility with previous versions of the
44*f0865ec9SKyle Evans  * library if needed.
45*f0865ec9SKyle Evans  *
46*f0865ec9SKyle Evans  */
47*f0865ec9SKyle Evans #ifndef USE_ISO14888_3_ECRDSA
48*f0865ec9SKyle Evans /* Reverses the endiannes of a buffer in place */
49*f0865ec9SKyle Evans ATTRIBUTE_WARN_UNUSED_RET static inline int _reverse_endianness(u8 *buf, u16 buf_size)
50*f0865ec9SKyle Evans {
51*f0865ec9SKyle Evans 	u16 i;
52*f0865ec9SKyle Evans 	u8 tmp;
53*f0865ec9SKyle Evans 	int ret;
54*f0865ec9SKyle Evans 
55*f0865ec9SKyle Evans 	MUST_HAVE((buf != NULL), ret, err);
56*f0865ec9SKyle Evans 
57*f0865ec9SKyle Evans 	if(buf_size > 1){
58*f0865ec9SKyle Evans 		for(i = 0; i < (buf_size / 2); i++){
59*f0865ec9SKyle Evans 			tmp = buf[i];
60*f0865ec9SKyle Evans 			buf[i] = buf[buf_size - 1 - i];
61*f0865ec9SKyle Evans 			buf[buf_size - 1 - i] = tmp;
62*f0865ec9SKyle Evans 		}
63*f0865ec9SKyle Evans 	}
64*f0865ec9SKyle Evans 
65*f0865ec9SKyle Evans 	ret = 0;
66*f0865ec9SKyle Evans err:
67*f0865ec9SKyle Evans 	return ret;
68*f0865ec9SKyle Evans }
69*f0865ec9SKyle Evans #endif
70*f0865ec9SKyle Evans 
71*f0865ec9SKyle Evans int ecrdsa_init_pub_key(ec_pub_key *out_pub, const ec_priv_key *in_priv)
72*f0865ec9SKyle Evans {
73*f0865ec9SKyle Evans 	int ret, cmp;
74*f0865ec9SKyle Evans 	prj_pt_src_t G;
75*f0865ec9SKyle Evans 	nn_src_t q;
76*f0865ec9SKyle Evans 
77*f0865ec9SKyle Evans 	MUST_HAVE((out_pub != NULL), ret, err);
78*f0865ec9SKyle Evans 
79*f0865ec9SKyle Evans 	/* Zero init public key to be generated */
80*f0865ec9SKyle Evans 	ret = local_memset(out_pub, 0, sizeof(ec_pub_key)); EG(ret, err);
81*f0865ec9SKyle Evans 
82*f0865ec9SKyle Evans 	ret = priv_key_check_initialized_and_type(in_priv, ECRDSA); EG(ret, err);
83*f0865ec9SKyle Evans 	q = &(in_priv->params->ec_gen_order);
84*f0865ec9SKyle Evans 
85*f0865ec9SKyle Evans 	/* Sanity check on key */
86*f0865ec9SKyle Evans 	MUST_HAVE((!nn_cmp(&(in_priv->x), q, &cmp)) && (cmp < 0), ret, err);
87*f0865ec9SKyle Evans 
88*f0865ec9SKyle Evans 	/* Y = xG */
89*f0865ec9SKyle Evans 	G = &(in_priv->params->ec_gen);
90*f0865ec9SKyle Evans 	/* Use blinding when computing point scalar multiplication */
91*f0865ec9SKyle Evans 	ret = prj_pt_mul_blind(&(out_pub->y), &(in_priv->x), G); EG(ret, err);
92*f0865ec9SKyle Evans 
93*f0865ec9SKyle Evans 	out_pub->key_type = ECRDSA;
94*f0865ec9SKyle Evans 	out_pub->params = in_priv->params;
95*f0865ec9SKyle Evans 	out_pub->magic = PUB_KEY_MAGIC;
96*f0865ec9SKyle Evans 
97*f0865ec9SKyle Evans err:
98*f0865ec9SKyle Evans 	return ret;
99*f0865ec9SKyle Evans }
100*f0865ec9SKyle Evans 
101*f0865ec9SKyle Evans int ecrdsa_siglen(u16 p_bit_len, u16 q_bit_len, u8 hsize, u8 blocksize, u8 *siglen)
102*f0865ec9SKyle Evans {
103*f0865ec9SKyle Evans 	int ret;
104*f0865ec9SKyle Evans 
105*f0865ec9SKyle Evans 	MUST_HAVE((siglen != NULL), ret, err);
106*f0865ec9SKyle Evans 	MUST_HAVE((p_bit_len <= CURVES_MAX_P_BIT_LEN) &&
107*f0865ec9SKyle Evans 		  (q_bit_len <= CURVES_MAX_Q_BIT_LEN) &&
108*f0865ec9SKyle Evans 		  (hsize <= MAX_DIGEST_SIZE) && (blocksize <= MAX_BLOCK_SIZE), ret, err);
109*f0865ec9SKyle Evans 	(*siglen) = (u8)ECRDSA_SIGLEN(q_bit_len);
110*f0865ec9SKyle Evans 	ret = 0;
111*f0865ec9SKyle Evans 
112*f0865ec9SKyle Evans err:
113*f0865ec9SKyle Evans 	return ret;
114*f0865ec9SKyle Evans }
115*f0865ec9SKyle Evans 
116*f0865ec9SKyle Evans /*
117*f0865ec9SKyle Evans  * Generic *internal* EC-RDSA signature functions (init, update and finalize).
118*f0865ec9SKyle Evans  * Their purpose is to allow passing a specific hash function (along with
119*f0865ec9SKyle Evans  * its output size) and the random ephemeral key k, so that compliance
120*f0865ec9SKyle Evans  * tests against test vectors can be made without ugly hack in the code
121*f0865ec9SKyle Evans  * itself.
122*f0865ec9SKyle Evans  *
123*f0865ec9SKyle Evans  * Global EC-RDSA signature process is as follows (I,U,F provides
124*f0865ec9SKyle Evans  * information in which function(s) (init(), update() or finalize())
125*f0865ec9SKyle Evans  * a specific step is performed):
126*f0865ec9SKyle Evans  *
127*f0865ec9SKyle Evans  *| IUF - EC-RDSA signature
128*f0865ec9SKyle Evans  *|
129*f0865ec9SKyle Evans  *|  UF	 1. Compute h = H(m)
130*f0865ec9SKyle Evans  *|   F	 2. Get a random value k in ]0,q[
131*f0865ec9SKyle Evans  *|   F	 3. Compute W = (W_x,W_y) = kG
132*f0865ec9SKyle Evans  *|   F	 4. Compute r = W_x mod q
133*f0865ec9SKyle Evans  *|   F	 5. If r is 0, restart the process at step 2.
134*f0865ec9SKyle Evans  *|   F	 6. Compute e = OS2I(h) mod q. If e is 0, set e to 1.
135*f0865ec9SKyle Evans  *|         NOTE: here, ISO/IEC 14888-3 and RFCs differ in the way e treated.
136*f0865ec9SKyle Evans  *|         e = OS2I(h) for ISO/IEC 14888-3, or e = OS2I(reversed(h)) when endianness of h
137*f0865ec9SKyle Evans  *|         is reversed for RFCs.
138*f0865ec9SKyle Evans  *|   F	 7. Compute s = (rx + ke) mod q
139*f0865ec9SKyle Evans  *|   F	 8. If s is 0, restart the process at step 2.
140*f0865ec9SKyle Evans  *|   F 11. Return (r,s)
141*f0865ec9SKyle Evans  *
142*f0865ec9SKyle Evans  */
143*f0865ec9SKyle Evans 
144*f0865ec9SKyle Evans #define ECRDSA_SIGN_MAGIC ((word_t)(0xcc97bbc8ada8973cULL))
145*f0865ec9SKyle Evans #define ECRDSA_SIGN_CHECK_INITIALIZED(A, ret, err) \
146*f0865ec9SKyle Evans 	MUST_HAVE((((void *)(A)) != NULL) && \
147*f0865ec9SKyle Evans 		  ((A)->magic == ECRDSA_SIGN_MAGIC), ret, err)
148*f0865ec9SKyle Evans 
149*f0865ec9SKyle Evans int _ecrdsa_sign_init(struct ec_sign_context *ctx)
150*f0865ec9SKyle Evans {
151*f0865ec9SKyle Evans 	int ret;
152*f0865ec9SKyle Evans 
153*f0865ec9SKyle Evans 	/* First, verify context has been initialized */
154*f0865ec9SKyle Evans 	ret = sig_sign_check_initialized(ctx); EG(ret, err);
155*f0865ec9SKyle Evans 
156*f0865ec9SKyle Evans 	/* Additional sanity checks on input params from context */
157*f0865ec9SKyle Evans 	ret = key_pair_check_initialized_and_type(ctx->key_pair, ECRDSA); EG(ret, err);
158*f0865ec9SKyle Evans 	MUST_HAVE((ctx->h != NULL) && (ctx->h->digest_size <= MAX_DIGEST_SIZE) &&
159*f0865ec9SKyle Evans 		  (ctx->h->block_size <= MAX_BLOCK_SIZE), ret, err);
160*f0865ec9SKyle Evans 
161*f0865ec9SKyle Evans 	/*
162*f0865ec9SKyle Evans 	 * Initialize hash context stored in our private part of context
163*f0865ec9SKyle Evans 	 * and record data init has been done
164*f0865ec9SKyle Evans 	 */
165*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
166*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
167*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_init(&(ctx->sign_data.ecrdsa.h_ctx)); EG(ret, err);
168*f0865ec9SKyle Evans 
169*f0865ec9SKyle Evans 	ctx->sign_data.ecrdsa.magic = ECRDSA_SIGN_MAGIC;
170*f0865ec9SKyle Evans 
171*f0865ec9SKyle Evans err:
172*f0865ec9SKyle Evans 	return ret;
173*f0865ec9SKyle Evans }
174*f0865ec9SKyle Evans 
175*f0865ec9SKyle Evans int _ecrdsa_sign_update(struct ec_sign_context *ctx,
176*f0865ec9SKyle Evans 			const u8 *chunk, u32 chunklen)
177*f0865ec9SKyle Evans {
178*f0865ec9SKyle Evans 	int ret;
179*f0865ec9SKyle Evans 	/*
180*f0865ec9SKyle Evans 	 * First, verify context has been initialized and private
181*f0865ec9SKyle Evans 	 * part too. This guarantees the context is an EC-RDSA
182*f0865ec9SKyle Evans 	 * signature one and we do not update() or finalize()
183*f0865ec9SKyle Evans 	 * before init().
184*f0865ec9SKyle Evans 	 */
185*f0865ec9SKyle Evans 	ret = sig_sign_check_initialized(ctx); EG(ret, err);
186*f0865ec9SKyle Evans 	ECRDSA_SIGN_CHECK_INITIALIZED(&(ctx->sign_data.ecrdsa), ret, err);
187*f0865ec9SKyle Evans 
188*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
189*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
190*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_update(&(ctx->sign_data.ecrdsa.h_ctx), chunk, chunklen);
191*f0865ec9SKyle Evans 
192*f0865ec9SKyle Evans err:
193*f0865ec9SKyle Evans 	return ret;
194*f0865ec9SKyle Evans }
195*f0865ec9SKyle Evans 
196*f0865ec9SKyle Evans int _ecrdsa_sign_finalize(struct ec_sign_context *ctx, u8 *sig, u8 siglen)
197*f0865ec9SKyle Evans {
198*f0865ec9SKyle Evans 	bitcnt_t q_bit_len, p_bit_len;
199*f0865ec9SKyle Evans 	const ec_priv_key *priv_key;
200*f0865ec9SKyle Evans 	u8 h_buf[MAX_DIGEST_SIZE];
201*f0865ec9SKyle Evans 	prj_pt_src_t G;
202*f0865ec9SKyle Evans 	prj_pt kG;
203*f0865ec9SKyle Evans 	nn_src_t q, x;
204*f0865ec9SKyle Evans 	u8 hsize, r_len, s_len;
205*f0865ec9SKyle Evans 	int ret, iszero, cmp;
206*f0865ec9SKyle Evans 	nn s, rx, ke, k, r, e;
207*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
208*f0865ec9SKyle Evans 	/* b is the blinding mask */
209*f0865ec9SKyle Evans 	nn b, binv;
210*f0865ec9SKyle Evans 	b.magic = binv.magic = WORD(0);
211*f0865ec9SKyle Evans #endif /* USE_SIG_BLINDING */
212*f0865ec9SKyle Evans 
213*f0865ec9SKyle Evans 	kG.magic = WORD(0);
214*f0865ec9SKyle Evans 	s.magic = rx.magic = ke.magic = WORD(0);
215*f0865ec9SKyle Evans 	k.magic = r.magic = e.magic = WORD(0);
216*f0865ec9SKyle Evans 
217*f0865ec9SKyle Evans 	/*
218*f0865ec9SKyle Evans 	 * First, verify context has been initialized and private
219*f0865ec9SKyle Evans 	 * part too. This guarantees the context is an EC-RDSA
220*f0865ec9SKyle Evans 	 * signature one and we do not finalize() before init().
221*f0865ec9SKyle Evans 	 */
222*f0865ec9SKyle Evans 	ret = sig_sign_check_initialized(ctx); EG(ret, err);
223*f0865ec9SKyle Evans 	ECRDSA_SIGN_CHECK_INITIALIZED(&(ctx->sign_data.ecrdsa), ret, err);
224*f0865ec9SKyle Evans 
225*f0865ec9SKyle Evans 	/* Zero init points */
226*f0865ec9SKyle Evans 	ret = local_memset(&kG, 0, sizeof(prj_pt)); EG(ret, err);
227*f0865ec9SKyle Evans 
228*f0865ec9SKyle Evans 	/* Make things more readable */
229*f0865ec9SKyle Evans 	priv_key = &(ctx->key_pair->priv_key);
230*f0865ec9SKyle Evans 	G = &(priv_key->params->ec_gen);
231*f0865ec9SKyle Evans 	q = &(priv_key->params->ec_gen_order);
232*f0865ec9SKyle Evans 	p_bit_len = priv_key->params->ec_fp.p_bitlen;
233*f0865ec9SKyle Evans 	q_bit_len = priv_key->params->ec_gen_order_bitlen;
234*f0865ec9SKyle Evans 	x = &(priv_key->x);
235*f0865ec9SKyle Evans 	r_len = (u8)ECRDSA_R_LEN(q_bit_len);
236*f0865ec9SKyle Evans 	s_len = (u8)ECRDSA_S_LEN(q_bit_len);
237*f0865ec9SKyle Evans 	hsize = ctx->h->digest_size;
238*f0865ec9SKyle Evans 
239*f0865ec9SKyle Evans 	/* Sanity check */
240*f0865ec9SKyle Evans 	ret = nn_cmp(x, q, &cmp); EG(ret, err);
241*f0865ec9SKyle Evans 	/* This should not happen and means that our
242*f0865ec9SKyle Evans 	 * private key is not compliant!
243*f0865ec9SKyle Evans 	 */
244*f0865ec9SKyle Evans 	MUST_HAVE((cmp < 0) && (p_bit_len <= NN_MAX_BIT_LEN) && (siglen == ECRDSA_SIGLEN(q_bit_len)), ret, err);
245*f0865ec9SKyle Evans 
246*f0865ec9SKyle Evans 	dbg_nn_print("p", &(priv_key->params->ec_fp.p));
247*f0865ec9SKyle Evans 	dbg_nn_print("q", q);
248*f0865ec9SKyle Evans 	dbg_priv_key_print("x", priv_key);
249*f0865ec9SKyle Evans 	dbg_pub_key_print("Y", &(ctx->key_pair->pub_key));
250*f0865ec9SKyle Evans 	dbg_ec_point_print("G", G);
251*f0865ec9SKyle Evans 
252*f0865ec9SKyle Evans  restart:
253*f0865ec9SKyle Evans 	/* 2. Get a random value k in ]0, q[ ... */
254*f0865ec9SKyle Evans #ifdef NO_KNOWN_VECTORS
255*f0865ec9SKyle Evans 	/* NOTE: when we do not need self tests for known vectors,
256*f0865ec9SKyle Evans 	 * we can be strict about random function handler!
257*f0865ec9SKyle Evans 	 * This allows us to avoid the corruption of such a pointer.
258*f0865ec9SKyle Evans 	 */
259*f0865ec9SKyle Evans 	/* Sanity check on the handler before calling it */
260*f0865ec9SKyle Evans 	MUST_HAVE((ctx->rand == nn_get_random_mod), ret, err);
261*f0865ec9SKyle Evans #endif
262*f0865ec9SKyle Evans 	MUST_HAVE((ctx->rand != NULL), ret, err);
263*f0865ec9SKyle Evans 	ret = ctx->rand(&k, q); EG(ret, err);
264*f0865ec9SKyle Evans 
265*f0865ec9SKyle Evans 	dbg_nn_print("k", &k);
266*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
267*f0865ec9SKyle Evans 	/* Note: if we use blinding, k and e are multiplied by
268*f0865ec9SKyle Evans 	 * a random value b in ]0,q[ */
269*f0865ec9SKyle Evans 	ret = nn_get_random_mod(&b, q); EG(ret, err);
270*f0865ec9SKyle Evans 	dbg_nn_print("b", &b);
271*f0865ec9SKyle Evans #endif /* USE_SIG_BLINDING */
272*f0865ec9SKyle Evans 
273*f0865ec9SKyle Evans 	/* 3. Compute W = kG = (Wx, Wy) */
274*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
275*f0865ec9SKyle Evans 	/* We use blinding for the scalar multiplication */
276*f0865ec9SKyle Evans 	ret = prj_pt_mul_blind(&kG, &k, G); EG(ret, err);
277*f0865ec9SKyle Evans #else
278*f0865ec9SKyle Evans 	ret = prj_pt_mul(&kG, &k, G); EG(ret, err);
279*f0865ec9SKyle Evans #endif /* USE_SIG_BLINDING */
280*f0865ec9SKyle Evans 	ret = prj_pt_unique(&kG, &kG); EG(ret, err);
281*f0865ec9SKyle Evans 	dbg_nn_print("W_x", &(kG.X.fp_val));
282*f0865ec9SKyle Evans 	dbg_nn_print("W_y", &(kG.Y.fp_val));
283*f0865ec9SKyle Evans 
284*f0865ec9SKyle Evans 	/* 4. Compute r = Wx mod q */
285*f0865ec9SKyle Evans 	ret = nn_mod(&r, &(kG.X.fp_val), q); EG(ret, err);
286*f0865ec9SKyle Evans 
287*f0865ec9SKyle Evans 	/* 5. If r is 0, restart the process at step 2. */
288*f0865ec9SKyle Evans 	ret = nn_iszero(&r, &iszero); EG(ret, err);
289*f0865ec9SKyle Evans 	if (iszero) {
290*f0865ec9SKyle Evans 		goto restart;
291*f0865ec9SKyle Evans 	}
292*f0865ec9SKyle Evans 	dbg_nn_print("r", &r);
293*f0865ec9SKyle Evans 
294*f0865ec9SKyle Evans 	/* Export r */
295*f0865ec9SKyle Evans 	ret = nn_export_to_buf(sig, r_len, &r); EG(ret, err);
296*f0865ec9SKyle Evans 
297*f0865ec9SKyle Evans 	/* 6. Compute e = OS2I(h) mod q. If e is 0, set e to 1. */
298*f0865ec9SKyle Evans 	ret = local_memset(h_buf, 0, hsize); EG(ret, err);
299*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
300*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
301*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_finalize(&(ctx->sign_data.ecrdsa.h_ctx), h_buf); EG(ret, err);
302*f0865ec9SKyle Evans 	dbg_buf_print("H(m)", h_buf, hsize);
303*f0865ec9SKyle Evans 	/* NOTE: this handles a discrepancy between ISO/IEC 14888-3 and
304*f0865ec9SKyle Evans 	 * Russian standard based RFCs.
305*f0865ec9SKyle Evans 	 */
306*f0865ec9SKyle Evans #ifndef USE_ISO14888_3_ECRDSA
307*f0865ec9SKyle Evans 	ret = _reverse_endianness(h_buf, hsize); EG(ret, err);
308*f0865ec9SKyle Evans #endif
309*f0865ec9SKyle Evans 	ret = nn_init_from_buf(&e, h_buf, hsize); EG(ret, err);
310*f0865ec9SKyle Evans 	ret = local_memset(h_buf, 0, hsize); EG(ret, err);
311*f0865ec9SKyle Evans 	ret = nn_mod(&e, &e, q); EG(ret, err);
312*f0865ec9SKyle Evans 	ret = nn_iszero(&e, &iszero); EG(ret, err);
313*f0865ec9SKyle Evans 	if (iszero) {
314*f0865ec9SKyle Evans 		ret = nn_inc(&e, &e); EG(ret, err);
315*f0865ec9SKyle Evans 	}
316*f0865ec9SKyle Evans 	dbg_nn_print("e", &e);
317*f0865ec9SKyle Evans 
318*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
319*f0865ec9SKyle Evans 	/* In case of blinding, we blind r and e */
320*f0865ec9SKyle Evans 	ret = nn_mod_mul(&r, &r, &b, q); EG(ret, err);
321*f0865ec9SKyle Evans 	ret = nn_mod_mul(&e, &e, &b, q); EG(ret, err);
322*f0865ec9SKyle Evans #endif /* USE_SIG_BLINDING */
323*f0865ec9SKyle Evans 
324*f0865ec9SKyle Evans 	/* Compute s = (rx + ke) mod q */
325*f0865ec9SKyle Evans 	ret = nn_mod_mul(&rx, &r, x, q); EG(ret, err);
326*f0865ec9SKyle Evans 	ret = nn_mod_mul(&ke, &k, &e, q); EG(ret, err);
327*f0865ec9SKyle Evans 	ret = nn_mod_add(&s, &rx, &ke, q); EG(ret, err);
328*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
329*f0865ec9SKyle Evans 	/* Unblind s */
330*f0865ec9SKyle Evans         /* NOTE: we use Fermat's little theorem inversion for
331*f0865ec9SKyle Evans          * constant time here. This is possible since q is prime.
332*f0865ec9SKyle Evans          */
333*f0865ec9SKyle Evans 	ret = nn_modinv_fermat(&binv, &b, q); EG(ret, err);
334*f0865ec9SKyle Evans 	ret = nn_mod_mul(&s, &s, &binv, q); EG(ret, err);
335*f0865ec9SKyle Evans #endif /* USE_SIG_BLINDING */
336*f0865ec9SKyle Evans 
337*f0865ec9SKyle Evans 	/* If s is 0, restart the process at step 2. */
338*f0865ec9SKyle Evans 	ret = nn_iszero(&s, &iszero); EG(ret, err);
339*f0865ec9SKyle Evans 	if (iszero) {
340*f0865ec9SKyle Evans 		goto restart;
341*f0865ec9SKyle Evans 	}
342*f0865ec9SKyle Evans 
343*f0865ec9SKyle Evans 	dbg_nn_print("s", &s);
344*f0865ec9SKyle Evans 
345*f0865ec9SKyle Evans 	/* Return (r,s) */
346*f0865ec9SKyle Evans 	ret = nn_export_to_buf(sig + r_len, s_len, &s);
347*f0865ec9SKyle Evans 
348*f0865ec9SKyle Evans  err:
349*f0865ec9SKyle Evans 	prj_pt_uninit(&kG);
350*f0865ec9SKyle Evans 	nn_uninit(&r);
351*f0865ec9SKyle Evans 	nn_uninit(&s);
352*f0865ec9SKyle Evans 	nn_uninit(&s);
353*f0865ec9SKyle Evans 	nn_uninit(&rx);
354*f0865ec9SKyle Evans 	nn_uninit(&ke);
355*f0865ec9SKyle Evans 	nn_uninit(&k);
356*f0865ec9SKyle Evans 	nn_uninit(&r);
357*f0865ec9SKyle Evans 	nn_uninit(&e);
358*f0865ec9SKyle Evans #ifdef USE_SIG_BLINDING
359*f0865ec9SKyle Evans 	nn_uninit(&b);
360*f0865ec9SKyle Evans 	nn_uninit(&binv);
361*f0865ec9SKyle Evans #endif
362*f0865ec9SKyle Evans 
363*f0865ec9SKyle Evans 	/*
364*f0865ec9SKyle Evans 	 * We can now clear data part of the context. This will clear
365*f0865ec9SKyle Evans 	 * magic and avoid further reuse of the whole context.
366*f0865ec9SKyle Evans 	 */
367*f0865ec9SKyle Evans 	if(ctx != NULL){
368*f0865ec9SKyle Evans 		IGNORE_RET_VAL(local_memset(&(ctx->sign_data.ecrdsa), 0, sizeof(ecrdsa_sign_data)));
369*f0865ec9SKyle Evans 	}
370*f0865ec9SKyle Evans 
371*f0865ec9SKyle Evans 	/* Clean what remains on the stack */
372*f0865ec9SKyle Evans 	VAR_ZEROIFY(r_len);
373*f0865ec9SKyle Evans 	VAR_ZEROIFY(s_len);
374*f0865ec9SKyle Evans 	VAR_ZEROIFY(q_bit_len);
375*f0865ec9SKyle Evans 	VAR_ZEROIFY(p_bit_len);
376*f0865ec9SKyle Evans 	VAR_ZEROIFY(hsize);
377*f0865ec9SKyle Evans 	PTR_NULLIFY(priv_key);
378*f0865ec9SKyle Evans 	PTR_NULLIFY(G);
379*f0865ec9SKyle Evans 	PTR_NULLIFY(q);
380*f0865ec9SKyle Evans 	PTR_NULLIFY(x);
381*f0865ec9SKyle Evans 
382*f0865ec9SKyle Evans 	return ret;
383*f0865ec9SKyle Evans }
384*f0865ec9SKyle Evans 
385*f0865ec9SKyle Evans #define ECRDSA_VERIFY_MAGIC ((word_t)(0xa8e16b7e8180cb9aULL))
386*f0865ec9SKyle Evans #define ECRDSA_VERIFY_CHECK_INITIALIZED(A, ret, err) \
387*f0865ec9SKyle Evans 	MUST_HAVE((((void *)(A)) != NULL) && \
388*f0865ec9SKyle Evans 		  ((A)->magic == ECRDSA_VERIFY_MAGIC), ret, err)
389*f0865ec9SKyle Evans 
390*f0865ec9SKyle Evans /*
391*f0865ec9SKyle Evans  * Generic *internal* EC-RDSA verification functions (init, update and finalize).
392*f0865ec9SKyle Evans  * Their purpose is to allow passing a specific hash function (along with
393*f0865ec9SKyle Evans  * their output size) and the random ephemeral key k, so that compliance
394*f0865ec9SKyle Evans  * tests against test vectors can be made without ugly hack in the code
395*f0865ec9SKyle Evans  * itself.
396*f0865ec9SKyle Evans  *
397*f0865ec9SKyle Evans  * Global EC-RDSA verification process is as follows (I,U,F provides
398*f0865ec9SKyle Evans  * information in which function(s) (init(), update() or finalize())
399*f0865ec9SKyle Evans  * a specific step is performed):
400*f0865ec9SKyle Evans  *
401*f0865ec9SKyle Evans  *| IUF - EC-RDSA verification
402*f0865ec9SKyle Evans  *|
403*f0865ec9SKyle Evans  *|  UF 1. Check that r and s are both in ]0,q[
404*f0865ec9SKyle Evans  *|   F 2. Compute h = H(m)
405*f0865ec9SKyle Evans  *|   F 3. Compute e = OS2I(h)^-1 mod q
406*f0865ec9SKyle Evans  *|         NOTE: here, ISO/IEC 14888-3 and RFCs differ in the way e treated.
407*f0865ec9SKyle Evans  *|         e = OS2I(h) for ISO/IEC 14888-3, or e = OS2I(reversed(h)) when endianness of h
408*f0865ec9SKyle Evans  *|         is reversed for RFCs.
409*f0865ec9SKyle Evans  *|   F 4. Compute u = es mod q
410*f0865ec9SKyle Evans  *|   F 5. Compute v = -er mod q
411*f0865ec9SKyle Evans  *|   F 6. Compute W' = uG + vY = (W'_x, W'_y)
412*f0865ec9SKyle Evans  *|   F 7. Compute r' = W'_x mod q
413*f0865ec9SKyle Evans  *|   F 8. Check r and r' are the same
414*f0865ec9SKyle Evans  *
415*f0865ec9SKyle Evans  */
416*f0865ec9SKyle Evans 
417*f0865ec9SKyle Evans int _ecrdsa_verify_init(struct ec_verify_context *ctx,
418*f0865ec9SKyle Evans 			const u8 *sig, u8 siglen)
419*f0865ec9SKyle Evans {
420*f0865ec9SKyle Evans 	bitcnt_t q_bit_len;
421*f0865ec9SKyle Evans 	u8 r_len, s_len;
422*f0865ec9SKyle Evans 	nn_src_t q;
423*f0865ec9SKyle Evans 	nn s, r;
424*f0865ec9SKyle Evans 	int ret, iszero1, iszero2, cmp1, cmp2;
425*f0865ec9SKyle Evans 	s.magic = r.magic = WORD(0);
426*f0865ec9SKyle Evans 
427*f0865ec9SKyle Evans 	/* First, verify context has been initialized */
428*f0865ec9SKyle Evans 	ret = sig_verify_check_initialized(ctx); EG(ret, err);
429*f0865ec9SKyle Evans 
430*f0865ec9SKyle Evans 	/* Do some sanity checks on input params */
431*f0865ec9SKyle Evans 	ret = pub_key_check_initialized_and_type(ctx->pub_key, ECRDSA); EG(ret, err);
432*f0865ec9SKyle Evans 	MUST_HAVE((ctx->h != NULL) && (ctx->h->digest_size <= MAX_DIGEST_SIZE) &&
433*f0865ec9SKyle Evans 		  (ctx->h->block_size <= MAX_BLOCK_SIZE), ret, err);
434*f0865ec9SKyle Evans 
435*f0865ec9SKyle Evans 	/* Make things more readable */
436*f0865ec9SKyle Evans 	q = &(ctx->pub_key->params->ec_gen_order);
437*f0865ec9SKyle Evans 	q_bit_len = ctx->pub_key->params->ec_gen_order_bitlen;
438*f0865ec9SKyle Evans 	r_len = (u8)ECRDSA_R_LEN(q_bit_len);
439*f0865ec9SKyle Evans 	s_len = (u8)ECRDSA_S_LEN(q_bit_len);
440*f0865ec9SKyle Evans 
441*f0865ec9SKyle Evans 	MUST_HAVE(siglen == ECRDSA_SIGLEN(q_bit_len), ret, err);
442*f0865ec9SKyle Evans 
443*f0865ec9SKyle Evans 	/* 1. Check that r and s are both in ]0,q[ */
444*f0865ec9SKyle Evans 	ret = nn_init_from_buf(&r, sig, r_len); EG(ret, err);
445*f0865ec9SKyle Evans 	ret = nn_init_from_buf(&s, sig + r_len, s_len); EG(ret, err);
446*f0865ec9SKyle Evans 	ret = nn_iszero(&s, &iszero1); EG(ret, err);
447*f0865ec9SKyle Evans 	ret = nn_iszero(&r, &iszero2); EG(ret, err);
448*f0865ec9SKyle Evans 	ret = nn_cmp(&s, q, &cmp1); EG(ret, err);
449*f0865ec9SKyle Evans 	ret = nn_cmp(&s, q, &cmp2); EG(ret, err);
450*f0865ec9SKyle Evans 	MUST_HAVE((!iszero1) && (cmp1 < 0) && (!iszero2) && (cmp2 < 0), ret, err);
451*f0865ec9SKyle Evans 
452*f0865ec9SKyle Evans 	/* Initialize the remaining of verify context. */
453*f0865ec9SKyle Evans 	ret = nn_copy(&(ctx->verify_data.ecrdsa.r), &r); EG(ret, err);
454*f0865ec9SKyle Evans 	ret = nn_copy(&(ctx->verify_data.ecrdsa.s), &s); EG(ret, err);
455*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
456*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
457*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_init(&(ctx->verify_data.ecrdsa.h_ctx)); EG(ret, err);
458*f0865ec9SKyle Evans 
459*f0865ec9SKyle Evans 	ctx->verify_data.ecrdsa.magic = ECRDSA_VERIFY_MAGIC;
460*f0865ec9SKyle Evans 
461*f0865ec9SKyle Evans  err:
462*f0865ec9SKyle Evans 	nn_uninit(&s);
463*f0865ec9SKyle Evans 	nn_uninit(&r);
464*f0865ec9SKyle Evans 
465*f0865ec9SKyle Evans 	/* Clean what remains on the stack */
466*f0865ec9SKyle Evans 	VAR_ZEROIFY(q_bit_len);
467*f0865ec9SKyle Evans 	VAR_ZEROIFY(r_len);
468*f0865ec9SKyle Evans 	VAR_ZEROIFY(s_len);
469*f0865ec9SKyle Evans 	PTR_NULLIFY(q);
470*f0865ec9SKyle Evans 
471*f0865ec9SKyle Evans 	return ret;
472*f0865ec9SKyle Evans }
473*f0865ec9SKyle Evans 
474*f0865ec9SKyle Evans int _ecrdsa_verify_update(struct ec_verify_context *ctx,
475*f0865ec9SKyle Evans 			  const u8 *chunk, u32 chunklen)
476*f0865ec9SKyle Evans {
477*f0865ec9SKyle Evans 	int ret;
478*f0865ec9SKyle Evans 
479*f0865ec9SKyle Evans 	/*
480*f0865ec9SKyle Evans 	 * First, verify context has been initialized and public
481*f0865ec9SKyle Evans 	 * part too. This guarantees the context is an EC-RDSA
482*f0865ec9SKyle Evans 	 * verification one and we do not update() or finalize()
483*f0865ec9SKyle Evans 	 * before init().
484*f0865ec9SKyle Evans 	 */
485*f0865ec9SKyle Evans 	ret = sig_verify_check_initialized(ctx); EG(ret, err);
486*f0865ec9SKyle Evans 	ECRDSA_VERIFY_CHECK_INITIALIZED(&(ctx->verify_data.ecrdsa), ret, err);
487*f0865ec9SKyle Evans 
488*f0865ec9SKyle Evans 	/* 2. Compute h = H(m) */
489*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
490*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
491*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_update(&(ctx->verify_data.ecrdsa.h_ctx), chunk,
492*f0865ec9SKyle Evans 			     chunklen);
493*f0865ec9SKyle Evans 
494*f0865ec9SKyle Evans err:
495*f0865ec9SKyle Evans 	return ret;
496*f0865ec9SKyle Evans }
497*f0865ec9SKyle Evans 
498*f0865ec9SKyle Evans int _ecrdsa_verify_finalize(struct ec_verify_context *ctx)
499*f0865ec9SKyle Evans {
500*f0865ec9SKyle Evans 	prj_pt_src_t G, Y;
501*f0865ec9SKyle Evans 	nn_src_t q;
502*f0865ec9SKyle Evans 	nn h, r_prime, e, v, u;
503*f0865ec9SKyle Evans 	prj_pt vY, uG;
504*f0865ec9SKyle Evans 	prj_pt_t Wprime;
505*f0865ec9SKyle Evans 	u8 h_buf[MAX_DIGEST_SIZE];
506*f0865ec9SKyle Evans 	nn *r, *s;
507*f0865ec9SKyle Evans 	u8 hsize;
508*f0865ec9SKyle Evans 	int ret, iszero, cmp;
509*f0865ec9SKyle Evans 
510*f0865ec9SKyle Evans 	h.magic = r_prime.magic = e.magic = v.magic = u.magic = WORD(0);
511*f0865ec9SKyle Evans 	vY.magic = uG.magic = WORD(0);
512*f0865ec9SKyle Evans 
513*f0865ec9SKyle Evans 	/* NOTE: we reuse uG for Wprime to optimize local variables */
514*f0865ec9SKyle Evans 	Wprime = &uG;
515*f0865ec9SKyle Evans 
516*f0865ec9SKyle Evans 	/*
517*f0865ec9SKyle Evans 	 * First, verify context has been initialized and public
518*f0865ec9SKyle Evans 	 * part too. This guarantees the context is an EC-RDSA
519*f0865ec9SKyle Evans 	 * verification one and we do not finalize() before init().
520*f0865ec9SKyle Evans 	 */
521*f0865ec9SKyle Evans 	ret = sig_verify_check_initialized(ctx); EG(ret, err);
522*f0865ec9SKyle Evans 	ECRDSA_VERIFY_CHECK_INITIALIZED(&(ctx->verify_data.ecrdsa), ret, err);
523*f0865ec9SKyle Evans 
524*f0865ec9SKyle Evans 	/* Zero init points */
525*f0865ec9SKyle Evans 	ret = local_memset(&uG, 0, sizeof(prj_pt)); EG(ret, err);
526*f0865ec9SKyle Evans 	ret = local_memset(&vY, 0, sizeof(prj_pt)); EG(ret, err);
527*f0865ec9SKyle Evans 
528*f0865ec9SKyle Evans 	/* Make things more readable */
529*f0865ec9SKyle Evans 	G = &(ctx->pub_key->params->ec_gen);
530*f0865ec9SKyle Evans 	Y = &(ctx->pub_key->y);
531*f0865ec9SKyle Evans 	q = &(ctx->pub_key->params->ec_gen_order);
532*f0865ec9SKyle Evans 	r = &(ctx->verify_data.ecrdsa.r);
533*f0865ec9SKyle Evans 	s = &(ctx->verify_data.ecrdsa.s);
534*f0865ec9SKyle Evans 	hsize = ctx->h->digest_size;
535*f0865ec9SKyle Evans 
536*f0865ec9SKyle Evans 	/* 2. Compute h = H(m) */
537*f0865ec9SKyle Evans 	ret = local_memset(h_buf, 0, hsize); EG(ret, err);
538*f0865ec9SKyle Evans 	/* Since we call a callback, sanity check our mapping */
539*f0865ec9SKyle Evans 	ret = hash_mapping_callbacks_sanity_check(ctx->h); EG(ret, err);
540*f0865ec9SKyle Evans 	ret = ctx->h->hfunc_finalize(&(ctx->verify_data.ecrdsa.h_ctx), h_buf); EG(ret, err);
541*f0865ec9SKyle Evans 	dbg_buf_print("H(m)", h_buf, hsize);
542*f0865ec9SKyle Evans 	/* NOTE: this handles a discrepancy between ISO/IEC 14888-3 and
543*f0865ec9SKyle Evans 	 * Russian standard based RFCs.
544*f0865ec9SKyle Evans 	 */
545*f0865ec9SKyle Evans #ifndef USE_ISO14888_3_ECRDSA
546*f0865ec9SKyle Evans 	ret = _reverse_endianness(h_buf, hsize); EG(ret, err);
547*f0865ec9SKyle Evans #endif
548*f0865ec9SKyle Evans 
549*f0865ec9SKyle Evans 	/* 3. Compute e = OS2I(h)^-1 mod q */
550*f0865ec9SKyle Evans 	ret = nn_init_from_buf(&h, h_buf, hsize); EG(ret, err);
551*f0865ec9SKyle Evans 	ret = local_memset(h_buf, 0, hsize); EG(ret, err);
552*f0865ec9SKyle Evans 	ret = nn_mod(&h, &h, q); EG(ret, err); /* h = OS2I(h) mod q */
553*f0865ec9SKyle Evans 	ret = nn_iszero(&h, &iszero); EG(ret, err);
554*f0865ec9SKyle Evans 	if (iszero) {	/* If h is equal to 0, set it to 1 */
555*f0865ec9SKyle Evans 		ret = nn_inc(&h, &h); EG(ret, err);
556*f0865ec9SKyle Evans 	}
557*f0865ec9SKyle Evans 	ret = nn_modinv(&e, &h, q); EG(ret, err); /* e = h^-1 mod q */
558*f0865ec9SKyle Evans 
559*f0865ec9SKyle Evans 	/* 4. Compute u = es mod q */
560*f0865ec9SKyle Evans 	ret = nn_mod_mul(&u, &e, s, q); EG(ret, err);
561*f0865ec9SKyle Evans 
562*f0865ec9SKyle Evans 	/* 5. Compute v = -er mod q
563*f0865ec9SKyle Evans 	 *
564*f0865ec9SKyle Evans 	 * Because we only support positive integers, we compute
565*f0865ec9SKyle Evans 	 * v = -er mod q = q - (er mod q) (except when er is 0).
566*f0865ec9SKyle Evans 	 * NOTE: we reuse e for er computation to avoid losing
567*f0865ec9SKyle Evans 	 * a variable.
568*f0865ec9SKyle Evans 	 */
569*f0865ec9SKyle Evans 	ret = nn_mod_mul(&e, &e, r, q); EG(ret, err);
570*f0865ec9SKyle Evans 	ret = nn_mod_neg(&v, &e, q); EG(ret, err);
571*f0865ec9SKyle Evans 
572*f0865ec9SKyle Evans 	/* 6. Compute W' = uG + vY = (W'_x, W'_y) */
573*f0865ec9SKyle Evans 	ret = prj_pt_mul(&uG, &u, G); EG(ret, err);
574*f0865ec9SKyle Evans 	ret = prj_pt_mul(&vY, &v, Y); EG(ret, err);
575*f0865ec9SKyle Evans 	ret = prj_pt_add(Wprime, &uG, &vY); EG(ret, err);
576*f0865ec9SKyle Evans 	ret = prj_pt_unique(Wprime, Wprime); EG(ret, err);
577*f0865ec9SKyle Evans 	dbg_nn_print("W'_x", &(Wprime->X.fp_val));
578*f0865ec9SKyle Evans 	dbg_nn_print("W'_y", &(Wprime->Y.fp_val));
579*f0865ec9SKyle Evans 
580*f0865ec9SKyle Evans 	/* 7. Compute r' = W'_x mod q */
581*f0865ec9SKyle Evans 	ret = nn_mod(&r_prime, &(Wprime->X.fp_val), q); EG(ret, err);
582*f0865ec9SKyle Evans 
583*f0865ec9SKyle Evans 	/* 8. Check r and r' are the same */
584*f0865ec9SKyle Evans 	ret = nn_cmp(r, &r_prime, &cmp); EG(ret, err);
585*f0865ec9SKyle Evans 	ret = (cmp == 0) ? 0 : -1;
586*f0865ec9SKyle Evans 
587*f0865ec9SKyle Evans err:
588*f0865ec9SKyle Evans 	nn_uninit(&h);
589*f0865ec9SKyle Evans 	nn_uninit(&r_prime);
590*f0865ec9SKyle Evans 	nn_uninit(&e);
591*f0865ec9SKyle Evans 	nn_uninit(&v);
592*f0865ec9SKyle Evans 	nn_uninit(&u);
593*f0865ec9SKyle Evans 	prj_pt_uninit(&vY);
594*f0865ec9SKyle Evans 	prj_pt_uninit(&uG);
595*f0865ec9SKyle Evans 
596*f0865ec9SKyle Evans 	/*
597*f0865ec9SKyle Evans 	 * We can now clear data part of the context. This will clear
598*f0865ec9SKyle Evans 	 * magic and avoid further reuse of the whole context.
599*f0865ec9SKyle Evans 	 */
600*f0865ec9SKyle Evans 	if(ctx != NULL){
601*f0865ec9SKyle Evans 		IGNORE_RET_VAL(local_memset(&(ctx->verify_data.ecrdsa), 0,
602*f0865ec9SKyle Evans 			     sizeof(ecrdsa_verify_data)));
603*f0865ec9SKyle Evans 	}
604*f0865ec9SKyle Evans 
605*f0865ec9SKyle Evans 	/* Clean what remains on the stack */
606*f0865ec9SKyle Evans 	PTR_NULLIFY(Wprime);
607*f0865ec9SKyle Evans 	PTR_NULLIFY(G);
608*f0865ec9SKyle Evans 	PTR_NULLIFY(Y);
609*f0865ec9SKyle Evans 	PTR_NULLIFY(q);
610*f0865ec9SKyle Evans 	PTR_NULLIFY(r);
611*f0865ec9SKyle Evans 	PTR_NULLIFY(s);
612*f0865ec9SKyle Evans 	VAR_ZEROIFY(hsize);
613*f0865ec9SKyle Evans 
614*f0865ec9SKyle Evans 	return ret;
615*f0865ec9SKyle Evans }
616*f0865ec9SKyle Evans 
617*f0865ec9SKyle Evans #else /* WITH_SIG_ECRDSA */
618*f0865ec9SKyle Evans 
619*f0865ec9SKyle Evans /*
620*f0865ec9SKyle Evans  * Dummy definition to avoid the empty translation unit ISO C warning
621*f0865ec9SKyle Evans  */
622*f0865ec9SKyle Evans typedef int dummy;
623*f0865ec9SKyle Evans #endif /* WITH_SIG_ECRDSA */
624