10b57cec5SDimitry Andric //== GenericTaintChecker.cpp ----------------------------------- -*- C++ -*--=// 20b57cec5SDimitry Andric // 30b57cec5SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 40b57cec5SDimitry Andric // See https://llvm.org/LICENSE.txt for license information. 50b57cec5SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 60b57cec5SDimitry Andric // 70b57cec5SDimitry Andric //===----------------------------------------------------------------------===// 80b57cec5SDimitry Andric // 90b57cec5SDimitry Andric // This checker defines the attack surface for generic taint propagation. 100b57cec5SDimitry Andric // 110b57cec5SDimitry Andric // The taint information produced by it might be useful to other checkers. For 120b57cec5SDimitry Andric // example, checkers should report errors which involve tainted data more 130b57cec5SDimitry Andric // aggressively, even if the involved symbols are under constrained. 140b57cec5SDimitry Andric // 150b57cec5SDimitry Andric //===----------------------------------------------------------------------===// 160b57cec5SDimitry Andric 17a7dea167SDimitry Andric #include "Yaml.h" 180b57cec5SDimitry Andric #include "clang/AST/Attr.h" 190b57cec5SDimitry Andric #include "clang/Basic/Builtins.h" 20a7dea167SDimitry Andric #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" 2181ad6265SDimitry Andric #include "clang/StaticAnalyzer/Checkers/Taint.h" 220b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" 230b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/Checker.h" 240b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/CheckerManager.h" 2504eeddc0SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h" 265ffd83dbSDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" 270b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" 280b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" 2906c3fb27SDimitry Andric #include "llvm/ADT/StringExtras.h" 30*0fca6ea1SDimitry Andric #include "llvm/ADT/StringRef.h" 31a7dea167SDimitry Andric #include "llvm/Support/YAMLTraits.h" 325ffd83dbSDimitry Andric 33a7dea167SDimitry Andric #include <limits> 345ffd83dbSDimitry Andric #include <memory> 35bdd1243dSDimitry Andric #include <optional> 360b57cec5SDimitry Andric #include <utility> 3706c3fb27SDimitry Andric #include <vector> 380b57cec5SDimitry Andric 3981ad6265SDimitry Andric #define DEBUG_TYPE "taint-checker" 4081ad6265SDimitry Andric 410b57cec5SDimitry Andric using namespace clang; 420b57cec5SDimitry Andric using namespace ento; 430b57cec5SDimitry Andric using namespace taint; 440b57cec5SDimitry Andric 4581ad6265SDimitry Andric using llvm::ImmutableSet; 4681ad6265SDimitry Andric 470b57cec5SDimitry Andric namespace { 4804eeddc0SDimitry Andric 4904eeddc0SDimitry Andric class GenericTaintChecker; 5004eeddc0SDimitry Andric 5104eeddc0SDimitry Andric /// Check for CWE-134: Uncontrolled Format String. 5204eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgUncontrolledFormatString = 5304eeddc0SDimitry Andric "Untrusted data is used as a format string " 5404eeddc0SDimitry Andric "(CWE-134: Uncontrolled Format String)"; 5504eeddc0SDimitry Andric 5604eeddc0SDimitry Andric /// Check for: 5704eeddc0SDimitry Andric /// CERT/STR02-C. "Sanitize data passed to complex subsystems" 5804eeddc0SDimitry Andric /// CWE-78, "Failure to Sanitize Data into an OS Command" 5904eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgSanitizeSystemArgs = 6004eeddc0SDimitry Andric "Untrusted data is passed to a system call " 6104eeddc0SDimitry Andric "(CERT/STR02-C. Sanitize data passed to complex subsystems)"; 6204eeddc0SDimitry Andric 6304eeddc0SDimitry Andric /// Check if tainted data is used as a custom sink's parameter. 6404eeddc0SDimitry Andric constexpr llvm::StringLiteral MsgCustomSink = 6504eeddc0SDimitry Andric "Untrusted data is passed to a user-defined sink"; 6604eeddc0SDimitry Andric 6704eeddc0SDimitry Andric using ArgIdxTy = int; 6804eeddc0SDimitry Andric using ArgVecTy = llvm::SmallVector<ArgIdxTy, 2>; 6904eeddc0SDimitry Andric 7004eeddc0SDimitry Andric /// Denotes the return value. 7104eeddc0SDimitry Andric constexpr ArgIdxTy ReturnValueIndex{-1}; 7204eeddc0SDimitry Andric 7304eeddc0SDimitry Andric static ArgIdxTy fromArgumentCount(unsigned Count) { 7404eeddc0SDimitry Andric assert(Count <= 7504eeddc0SDimitry Andric static_cast<std::size_t>(std::numeric_limits<ArgIdxTy>::max()) && 7604eeddc0SDimitry Andric "ArgIdxTy is not large enough to represent the number of arguments."); 7704eeddc0SDimitry Andric return Count; 7804eeddc0SDimitry Andric } 7904eeddc0SDimitry Andric 8004eeddc0SDimitry Andric /// Check if the region the expression evaluates to is the standard input, 8104eeddc0SDimitry Andric /// and thus, is tainted. 8204eeddc0SDimitry Andric /// FIXME: Move this to Taint.cpp. 8304eeddc0SDimitry Andric bool isStdin(SVal Val, const ASTContext &ACtx) { 8404eeddc0SDimitry Andric // FIXME: What if Val is NonParamVarRegion? 8504eeddc0SDimitry Andric 8604eeddc0SDimitry Andric // The region should be symbolic, we do not know it's value. 8704eeddc0SDimitry Andric const auto *SymReg = dyn_cast_or_null<SymbolicRegion>(Val.getAsRegion()); 8804eeddc0SDimitry Andric if (!SymReg) 8904eeddc0SDimitry Andric return false; 9004eeddc0SDimitry Andric 9104eeddc0SDimitry Andric // Get it's symbol and find the declaration region it's pointing to. 9281ad6265SDimitry Andric const auto *DeclReg = 9381ad6265SDimitry Andric dyn_cast_or_null<DeclRegion>(SymReg->getSymbol()->getOriginRegion()); 9404eeddc0SDimitry Andric if (!DeclReg) 9504eeddc0SDimitry Andric return false; 9604eeddc0SDimitry Andric 9704eeddc0SDimitry Andric // This region corresponds to a declaration, find out if it's a global/extern 9804eeddc0SDimitry Andric // variable named stdin with the proper type. 9904eeddc0SDimitry Andric if (const auto *D = dyn_cast_or_null<VarDecl>(DeclReg->getDecl())) { 10004eeddc0SDimitry Andric D = D->getCanonicalDecl(); 1015f757f3fSDimitry Andric if (D->getName() == "stdin" && D->hasExternalStorage() && D->isExternC()) { 10204eeddc0SDimitry Andric const QualType FILETy = ACtx.getFILEType().getCanonicalType(); 10304eeddc0SDimitry Andric const QualType Ty = D->getType().getCanonicalType(); 10404eeddc0SDimitry Andric 10504eeddc0SDimitry Andric if (Ty->isPointerType()) 10604eeddc0SDimitry Andric return Ty->getPointeeType() == FILETy; 10704eeddc0SDimitry Andric } 10804eeddc0SDimitry Andric } 10904eeddc0SDimitry Andric return false; 11004eeddc0SDimitry Andric } 11104eeddc0SDimitry Andric 11206c3fb27SDimitry Andric SVal getPointeeOf(ProgramStateRef State, Loc LValue) { 11306c3fb27SDimitry Andric const QualType ArgTy = LValue.getType(State->getStateManager().getContext()); 11404eeddc0SDimitry Andric if (!ArgTy->isPointerType() || !ArgTy->getPointeeType()->isVoidType()) 11506c3fb27SDimitry Andric return State->getSVal(LValue); 11604eeddc0SDimitry Andric 11704eeddc0SDimitry Andric // Do not dereference void pointers. Treat them as byte pointers instead. 11804eeddc0SDimitry Andric // FIXME: we might want to consider more than just the first byte. 11906c3fb27SDimitry Andric return State->getSVal(LValue, State->getStateManager().getContext().CharTy); 12004eeddc0SDimitry Andric } 12104eeddc0SDimitry Andric 12204eeddc0SDimitry Andric /// Given a pointer/reference argument, return the value it refers to. 12306c3fb27SDimitry Andric std::optional<SVal> getPointeeOf(ProgramStateRef State, SVal Arg) { 12404eeddc0SDimitry Andric if (auto LValue = Arg.getAs<Loc>()) 12506c3fb27SDimitry Andric return getPointeeOf(State, *LValue); 126bdd1243dSDimitry Andric return std::nullopt; 12704eeddc0SDimitry Andric } 12804eeddc0SDimitry Andric 12904eeddc0SDimitry Andric /// Given a pointer, return the SVal of its pointee or if it is tainted, 13004eeddc0SDimitry Andric /// otherwise return the pointer's SVal if tainted. 13104eeddc0SDimitry Andric /// Also considers stdin as a taint source. 13206c3fb27SDimitry Andric std::optional<SVal> getTaintedPointeeOrPointer(ProgramStateRef State, 133bdd1243dSDimitry Andric SVal Arg) { 13406c3fb27SDimitry Andric if (auto Pointee = getPointeeOf(State, Arg)) 13504eeddc0SDimitry Andric if (isTainted(State, *Pointee)) // FIXME: isTainted(...) ? Pointee : None; 13604eeddc0SDimitry Andric return Pointee; 13704eeddc0SDimitry Andric 13804eeddc0SDimitry Andric if (isTainted(State, Arg)) 13904eeddc0SDimitry Andric return Arg; 140bdd1243dSDimitry Andric return std::nullopt; 14104eeddc0SDimitry Andric } 14204eeddc0SDimitry Andric 14306c3fb27SDimitry Andric bool isTaintedOrPointsToTainted(ProgramStateRef State, SVal ExprSVal) { 14406c3fb27SDimitry Andric return getTaintedPointeeOrPointer(State, ExprSVal).has_value(); 14506c3fb27SDimitry Andric } 14606c3fb27SDimitry Andric 14706c3fb27SDimitry Andric /// Helps in printing taint diagnostics. 14806c3fb27SDimitry Andric /// Marks the incoming parameters of a function interesting (to be printed) 14906c3fb27SDimitry Andric /// when the return value, or the outgoing parameters are tainted. 15006c3fb27SDimitry Andric const NoteTag *taintOriginTrackerTag(CheckerContext &C, 15106c3fb27SDimitry Andric std::vector<SymbolRef> TaintedSymbols, 15206c3fb27SDimitry Andric std::vector<ArgIdxTy> TaintedArgs, 15306c3fb27SDimitry Andric const LocationContext *CallLocation) { 15406c3fb27SDimitry Andric return C.getNoteTag([TaintedSymbols = std::move(TaintedSymbols), 15506c3fb27SDimitry Andric TaintedArgs = std::move(TaintedArgs), CallLocation]( 15606c3fb27SDimitry Andric PathSensitiveBugReport &BR) -> std::string { 15706c3fb27SDimitry Andric SmallString<256> Msg; 15806c3fb27SDimitry Andric // We give diagnostics only for taint related reports 15906c3fb27SDimitry Andric if (!BR.isInteresting(CallLocation) || 16006c3fb27SDimitry Andric BR.getBugType().getCategory() != categories::TaintedData) { 16106c3fb27SDimitry Andric return ""; 16206c3fb27SDimitry Andric } 16306c3fb27SDimitry Andric if (TaintedSymbols.empty()) 16406c3fb27SDimitry Andric return "Taint originated here"; 16506c3fb27SDimitry Andric 16606c3fb27SDimitry Andric for (auto Sym : TaintedSymbols) { 16706c3fb27SDimitry Andric BR.markInteresting(Sym); 16806c3fb27SDimitry Andric } 16906c3fb27SDimitry Andric LLVM_DEBUG(for (auto Arg 17006c3fb27SDimitry Andric : TaintedArgs) { 17106c3fb27SDimitry Andric llvm::dbgs() << "Taint Propagated from argument " << Arg + 1 << "\n"; 17206c3fb27SDimitry Andric }); 17306c3fb27SDimitry Andric return ""; 17406c3fb27SDimitry Andric }); 17506c3fb27SDimitry Andric } 17606c3fb27SDimitry Andric 17706c3fb27SDimitry Andric /// Helps in printing taint diagnostics. 17806c3fb27SDimitry Andric /// Marks the function interesting (to be printed) 17906c3fb27SDimitry Andric /// when the return value, or the outgoing parameters are tainted. 18006c3fb27SDimitry Andric const NoteTag *taintPropagationExplainerTag( 18106c3fb27SDimitry Andric CheckerContext &C, std::vector<SymbolRef> TaintedSymbols, 18206c3fb27SDimitry Andric std::vector<ArgIdxTy> TaintedArgs, const LocationContext *CallLocation) { 18306c3fb27SDimitry Andric assert(TaintedSymbols.size() == TaintedArgs.size()); 18406c3fb27SDimitry Andric return C.getNoteTag([TaintedSymbols = std::move(TaintedSymbols), 18506c3fb27SDimitry Andric TaintedArgs = std::move(TaintedArgs), CallLocation]( 18606c3fb27SDimitry Andric PathSensitiveBugReport &BR) -> std::string { 18706c3fb27SDimitry Andric SmallString<256> Msg; 18806c3fb27SDimitry Andric llvm::raw_svector_ostream Out(Msg); 18906c3fb27SDimitry Andric // We give diagnostics only for taint related reports 19006c3fb27SDimitry Andric if (TaintedSymbols.empty() || 19106c3fb27SDimitry Andric BR.getBugType().getCategory() != categories::TaintedData) { 19206c3fb27SDimitry Andric return ""; 19306c3fb27SDimitry Andric } 19406c3fb27SDimitry Andric int nofTaintedArgs = 0; 19506c3fb27SDimitry Andric for (auto [Idx, Sym] : llvm::enumerate(TaintedSymbols)) { 19606c3fb27SDimitry Andric if (BR.isInteresting(Sym)) { 19706c3fb27SDimitry Andric BR.markInteresting(CallLocation); 19806c3fb27SDimitry Andric if (TaintedArgs[Idx] != ReturnValueIndex) { 19906c3fb27SDimitry Andric LLVM_DEBUG(llvm::dbgs() << "Taint Propagated to argument " 20006c3fb27SDimitry Andric << TaintedArgs[Idx] + 1 << "\n"); 20106c3fb27SDimitry Andric if (nofTaintedArgs == 0) 20206c3fb27SDimitry Andric Out << "Taint propagated to the "; 20306c3fb27SDimitry Andric else 20406c3fb27SDimitry Andric Out << ", "; 20506c3fb27SDimitry Andric Out << TaintedArgs[Idx] + 1 20606c3fb27SDimitry Andric << llvm::getOrdinalSuffix(TaintedArgs[Idx] + 1) << " argument"; 20706c3fb27SDimitry Andric nofTaintedArgs++; 20806c3fb27SDimitry Andric } else { 20906c3fb27SDimitry Andric LLVM_DEBUG(llvm::dbgs() << "Taint Propagated to return value.\n"); 21006c3fb27SDimitry Andric Out << "Taint propagated to the return value"; 21106c3fb27SDimitry Andric } 21206c3fb27SDimitry Andric } 21306c3fb27SDimitry Andric } 21406c3fb27SDimitry Andric return std::string(Out.str()); 21506c3fb27SDimitry Andric }); 21604eeddc0SDimitry Andric } 21704eeddc0SDimitry Andric 21804eeddc0SDimitry Andric /// ArgSet is used to describe arguments relevant for taint detection or 21904eeddc0SDimitry Andric /// taint application. A discrete set of argument indexes and a variadic 22004eeddc0SDimitry Andric /// argument list signified by a starting index are supported. 22104eeddc0SDimitry Andric class ArgSet { 22204eeddc0SDimitry Andric public: 22304eeddc0SDimitry Andric ArgSet() = default; 224bdd1243dSDimitry Andric ArgSet(ArgVecTy &&DiscreteArgs, 225bdd1243dSDimitry Andric std::optional<ArgIdxTy> VariadicIndex = std::nullopt) 22604eeddc0SDimitry Andric : DiscreteArgs(std::move(DiscreteArgs)), 22704eeddc0SDimitry Andric VariadicIndex(std::move(VariadicIndex)) {} 22804eeddc0SDimitry Andric 22904eeddc0SDimitry Andric bool contains(ArgIdxTy ArgIdx) const { 23004eeddc0SDimitry Andric if (llvm::is_contained(DiscreteArgs, ArgIdx)) 23104eeddc0SDimitry Andric return true; 23204eeddc0SDimitry Andric 23304eeddc0SDimitry Andric return VariadicIndex && ArgIdx >= *VariadicIndex; 23404eeddc0SDimitry Andric } 23504eeddc0SDimitry Andric 23604eeddc0SDimitry Andric bool isEmpty() const { return DiscreteArgs.empty() && !VariadicIndex; } 23704eeddc0SDimitry Andric 23804eeddc0SDimitry Andric private: 23904eeddc0SDimitry Andric ArgVecTy DiscreteArgs; 240bdd1243dSDimitry Andric std::optional<ArgIdxTy> VariadicIndex; 24104eeddc0SDimitry Andric }; 24204eeddc0SDimitry Andric 24304eeddc0SDimitry Andric /// A struct used to specify taint propagation rules for a function. 24404eeddc0SDimitry Andric /// 24504eeddc0SDimitry Andric /// If any of the possible taint source arguments is tainted, all of the 24604eeddc0SDimitry Andric /// destination arguments should also be tainted. If ReturnValueIndex is added 24704eeddc0SDimitry Andric /// to the dst list, the return value will be tainted. 24804eeddc0SDimitry Andric class GenericTaintRule { 24904eeddc0SDimitry Andric /// Arguments which are taints sinks and should be checked, and a report 25004eeddc0SDimitry Andric /// should be emitted if taint reaches these. 25104eeddc0SDimitry Andric ArgSet SinkArgs; 25204eeddc0SDimitry Andric /// Arguments which should be sanitized on function return. 25304eeddc0SDimitry Andric ArgSet FilterArgs; 25406c3fb27SDimitry Andric /// Arguments which can participate in taint propagation. If any of the 25504eeddc0SDimitry Andric /// arguments in PropSrcArgs is tainted, all arguments in PropDstArgs should 25604eeddc0SDimitry Andric /// be tainted. 25704eeddc0SDimitry Andric ArgSet PropSrcArgs; 25804eeddc0SDimitry Andric ArgSet PropDstArgs; 25904eeddc0SDimitry Andric 26004eeddc0SDimitry Andric /// A message that explains why the call is sensitive to taint. 261bdd1243dSDimitry Andric std::optional<StringRef> SinkMsg; 26204eeddc0SDimitry Andric 26304eeddc0SDimitry Andric GenericTaintRule() = default; 26404eeddc0SDimitry Andric 26504eeddc0SDimitry Andric GenericTaintRule(ArgSet &&Sink, ArgSet &&Filter, ArgSet &&Src, ArgSet &&Dst, 266bdd1243dSDimitry Andric std::optional<StringRef> SinkMsg = std::nullopt) 26704eeddc0SDimitry Andric : SinkArgs(std::move(Sink)), FilterArgs(std::move(Filter)), 26804eeddc0SDimitry Andric PropSrcArgs(std::move(Src)), PropDstArgs(std::move(Dst)), 26904eeddc0SDimitry Andric SinkMsg(SinkMsg) {} 27004eeddc0SDimitry Andric 27104eeddc0SDimitry Andric public: 27204eeddc0SDimitry Andric /// Make a rule that reports a warning if taint reaches any of \p FilterArgs 27304eeddc0SDimitry Andric /// arguments. 27404eeddc0SDimitry Andric static GenericTaintRule Sink(ArgSet &&SinkArgs, 275bdd1243dSDimitry Andric std::optional<StringRef> Msg = std::nullopt) { 27604eeddc0SDimitry Andric return {std::move(SinkArgs), {}, {}, {}, Msg}; 27704eeddc0SDimitry Andric } 27804eeddc0SDimitry Andric 27904eeddc0SDimitry Andric /// Make a rule that sanitizes all FilterArgs arguments. 28004eeddc0SDimitry Andric static GenericTaintRule Filter(ArgSet &&FilterArgs) { 28104eeddc0SDimitry Andric return {{}, std::move(FilterArgs), {}, {}}; 28204eeddc0SDimitry Andric } 28304eeddc0SDimitry Andric 28404eeddc0SDimitry Andric /// Make a rule that unconditionally taints all Args. 28504eeddc0SDimitry Andric /// If Func is provided, it must also return true for taint to propagate. 28604eeddc0SDimitry Andric static GenericTaintRule Source(ArgSet &&SourceArgs) { 28704eeddc0SDimitry Andric return {{}, {}, {}, std::move(SourceArgs)}; 28804eeddc0SDimitry Andric } 28904eeddc0SDimitry Andric 29004eeddc0SDimitry Andric /// Make a rule that taints all PropDstArgs if any of PropSrcArgs is tainted. 29104eeddc0SDimitry Andric static GenericTaintRule Prop(ArgSet &&SrcArgs, ArgSet &&DstArgs) { 29204eeddc0SDimitry Andric return {{}, {}, std::move(SrcArgs), std::move(DstArgs)}; 29304eeddc0SDimitry Andric } 29404eeddc0SDimitry Andric 29504eeddc0SDimitry Andric /// Process a function which could either be a taint source, a taint sink, a 29604eeddc0SDimitry Andric /// taint filter or a taint propagator. 29704eeddc0SDimitry Andric void process(const GenericTaintChecker &Checker, const CallEvent &Call, 29804eeddc0SDimitry Andric CheckerContext &C) const; 29904eeddc0SDimitry Andric 30004eeddc0SDimitry Andric /// Handles the resolution of indexes of type ArgIdxTy to Expr*-s. 30104eeddc0SDimitry Andric static const Expr *GetArgExpr(ArgIdxTy ArgIdx, const CallEvent &Call) { 30204eeddc0SDimitry Andric return ArgIdx == ReturnValueIndex ? Call.getOriginExpr() 30304eeddc0SDimitry Andric : Call.getArgExpr(ArgIdx); 30404eeddc0SDimitry Andric }; 30504eeddc0SDimitry Andric 30604eeddc0SDimitry Andric /// Functions for custom taintedness propagation. 30704eeddc0SDimitry Andric static bool UntrustedEnv(CheckerContext &C); 30804eeddc0SDimitry Andric }; 30904eeddc0SDimitry Andric 31004eeddc0SDimitry Andric using RuleLookupTy = CallDescriptionMap<GenericTaintRule>; 31104eeddc0SDimitry Andric 31204eeddc0SDimitry Andric /// Used to parse the configuration file. 31304eeddc0SDimitry Andric struct TaintConfiguration { 31404eeddc0SDimitry Andric using NameScopeArgs = std::tuple<std::string, std::string, ArgVecTy>; 31504eeddc0SDimitry Andric enum class VariadicType { None, Src, Dst }; 31604eeddc0SDimitry Andric 31704eeddc0SDimitry Andric struct Common { 31804eeddc0SDimitry Andric std::string Name; 31904eeddc0SDimitry Andric std::string Scope; 32004eeddc0SDimitry Andric }; 32104eeddc0SDimitry Andric 32204eeddc0SDimitry Andric struct Sink : Common { 32304eeddc0SDimitry Andric ArgVecTy SinkArgs; 32404eeddc0SDimitry Andric }; 32504eeddc0SDimitry Andric 32604eeddc0SDimitry Andric struct Filter : Common { 32704eeddc0SDimitry Andric ArgVecTy FilterArgs; 32804eeddc0SDimitry Andric }; 32904eeddc0SDimitry Andric 33004eeddc0SDimitry Andric struct Propagation : Common { 33104eeddc0SDimitry Andric ArgVecTy SrcArgs; 33204eeddc0SDimitry Andric ArgVecTy DstArgs; 33304eeddc0SDimitry Andric VariadicType VarType; 33404eeddc0SDimitry Andric ArgIdxTy VarIndex; 33504eeddc0SDimitry Andric }; 33604eeddc0SDimitry Andric 33704eeddc0SDimitry Andric std::vector<Propagation> Propagations; 33804eeddc0SDimitry Andric std::vector<Filter> Filters; 33904eeddc0SDimitry Andric std::vector<Sink> Sinks; 34004eeddc0SDimitry Andric 34104eeddc0SDimitry Andric TaintConfiguration() = default; 34204eeddc0SDimitry Andric TaintConfiguration(const TaintConfiguration &) = default; 34304eeddc0SDimitry Andric TaintConfiguration(TaintConfiguration &&) = default; 34404eeddc0SDimitry Andric TaintConfiguration &operator=(const TaintConfiguration &) = default; 34504eeddc0SDimitry Andric TaintConfiguration &operator=(TaintConfiguration &&) = default; 34604eeddc0SDimitry Andric }; 34704eeddc0SDimitry Andric 34804eeddc0SDimitry Andric struct GenericTaintRuleParser { 34904eeddc0SDimitry Andric GenericTaintRuleParser(CheckerManager &Mgr) : Mgr(Mgr) {} 35004eeddc0SDimitry Andric /// Container type used to gather call identification objects grouped into 35104eeddc0SDimitry Andric /// pairs with their corresponding taint rules. It is temporary as it is used 35204eeddc0SDimitry Andric /// to finally initialize RuleLookupTy, which is considered to be immutable. 35304eeddc0SDimitry Andric using RulesContTy = std::vector<std::pair<CallDescription, GenericTaintRule>>; 35404eeddc0SDimitry Andric RulesContTy parseConfiguration(const std::string &Option, 35504eeddc0SDimitry Andric TaintConfiguration &&Config) const; 35604eeddc0SDimitry Andric 35704eeddc0SDimitry Andric private: 358bdd1243dSDimitry Andric using NamePartsTy = llvm::SmallVector<StringRef, 2>; 35904eeddc0SDimitry Andric 36004eeddc0SDimitry Andric /// Validate part of the configuration, which contains a list of argument 36104eeddc0SDimitry Andric /// indexes. 36204eeddc0SDimitry Andric void validateArgVector(const std::string &Option, const ArgVecTy &Args) const; 36304eeddc0SDimitry Andric 36404eeddc0SDimitry Andric template <typename Config> static NamePartsTy parseNameParts(const Config &C); 36504eeddc0SDimitry Andric 36604eeddc0SDimitry Andric // Takes the config and creates a CallDescription for it and associates a Rule 36704eeddc0SDimitry Andric // with that. 36804eeddc0SDimitry Andric template <typename Config> 36904eeddc0SDimitry Andric static void consumeRulesFromConfig(const Config &C, GenericTaintRule &&Rule, 37004eeddc0SDimitry Andric RulesContTy &Rules); 37104eeddc0SDimitry Andric 37204eeddc0SDimitry Andric void parseConfig(const std::string &Option, TaintConfiguration::Sink &&P, 37304eeddc0SDimitry Andric RulesContTy &Rules) const; 37404eeddc0SDimitry Andric void parseConfig(const std::string &Option, TaintConfiguration::Filter &&P, 37504eeddc0SDimitry Andric RulesContTy &Rules) const; 37604eeddc0SDimitry Andric void parseConfig(const std::string &Option, 37704eeddc0SDimitry Andric TaintConfiguration::Propagation &&P, 37804eeddc0SDimitry Andric RulesContTy &Rules) const; 37904eeddc0SDimitry Andric 38004eeddc0SDimitry Andric CheckerManager &Mgr; 38104eeddc0SDimitry Andric }; 38204eeddc0SDimitry Andric 3835ffd83dbSDimitry Andric class GenericTaintChecker : public Checker<check::PreCall, check::PostCall> { 3840b57cec5SDimitry Andric public: 3855ffd83dbSDimitry Andric void checkPreCall(const CallEvent &Call, CheckerContext &C) const; 3865ffd83dbSDimitry Andric void checkPostCall(const CallEvent &Call, CheckerContext &C) const; 3870b57cec5SDimitry Andric 388a7dea167SDimitry Andric void printState(raw_ostream &Out, ProgramStateRef State, const char *NL, 389a7dea167SDimitry Andric const char *Sep) const override; 390a7dea167SDimitry Andric 391a7dea167SDimitry Andric /// Generate a report if the expression is tainted or points to tainted data. 392a7dea167SDimitry Andric bool generateReportIfTainted(const Expr *E, StringRef Msg, 393a7dea167SDimitry Andric CheckerContext &C) const; 394a7dea167SDimitry Andric 395*0fca6ea1SDimitry Andric bool isTaintReporterCheckerEnabled = false; 396*0fca6ea1SDimitry Andric std::optional<BugType> BT; 397480093f4SDimitry Andric 398*0fca6ea1SDimitry Andric private: 39904eeddc0SDimitry Andric bool checkUncontrolledFormatString(const CallEvent &Call, 40004eeddc0SDimitry Andric CheckerContext &C) const; 4010b57cec5SDimitry Andric 40204eeddc0SDimitry Andric void taintUnsafeSocketProtocol(const CallEvent &Call, 40304eeddc0SDimitry Andric CheckerContext &C) const; 4040b57cec5SDimitry Andric 405*0fca6ea1SDimitry Andric /// The taint rules are initalized with the help of a CheckerContext to 406*0fca6ea1SDimitry Andric /// access user-provided configuration. 40704eeddc0SDimitry Andric void initTaintRules(CheckerContext &C) const; 4080b57cec5SDimitry Andric 409*0fca6ea1SDimitry Andric // TODO: The two separate `CallDescriptionMap`s were introduced when 410*0fca6ea1SDimitry Andric // `CallDescription` was unable to restrict matches to the global namespace 411*0fca6ea1SDimitry Andric // only. This limitation no longer exists, so the following two maps should 412*0fca6ea1SDimitry Andric // be unified. 413bdd1243dSDimitry Andric mutable std::optional<RuleLookupTy> StaticTaintRules; 414bdd1243dSDimitry Andric mutable std::optional<RuleLookupTy> DynamicTaintRules; 4150b57cec5SDimitry Andric }; 4160b57cec5SDimitry Andric } // end of anonymous namespace 4170b57cec5SDimitry Andric 41804eeddc0SDimitry Andric /// YAML serialization mapping. 41904eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Sink) 42004eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Filter) 42104eeddc0SDimitry Andric LLVM_YAML_IS_SEQUENCE_VECTOR(TaintConfiguration::Propagation) 422a7dea167SDimitry Andric 423a7dea167SDimitry Andric namespace llvm { 424a7dea167SDimitry Andric namespace yaml { 42504eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration> { 42604eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration &Config) { 427a7dea167SDimitry Andric IO.mapOptional("Propagations", Config.Propagations); 428a7dea167SDimitry Andric IO.mapOptional("Filters", Config.Filters); 429a7dea167SDimitry Andric IO.mapOptional("Sinks", Config.Sinks); 430a7dea167SDimitry Andric } 431a7dea167SDimitry Andric }; 432a7dea167SDimitry Andric 43304eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Sink> { 43404eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Sink &Sink) { 43504eeddc0SDimitry Andric IO.mapRequired("Name", Sink.Name); 43604eeddc0SDimitry Andric IO.mapOptional("Scope", Sink.Scope); 43704eeddc0SDimitry Andric IO.mapRequired("Args", Sink.SinkArgs); 43804eeddc0SDimitry Andric } 43904eeddc0SDimitry Andric }; 44004eeddc0SDimitry Andric 44104eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Filter> { 44204eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Filter &Filter) { 44304eeddc0SDimitry Andric IO.mapRequired("Name", Filter.Name); 44404eeddc0SDimitry Andric IO.mapOptional("Scope", Filter.Scope); 44504eeddc0SDimitry Andric IO.mapRequired("Args", Filter.FilterArgs); 44604eeddc0SDimitry Andric } 44704eeddc0SDimitry Andric }; 44804eeddc0SDimitry Andric 44904eeddc0SDimitry Andric template <> struct MappingTraits<TaintConfiguration::Propagation> { 45004eeddc0SDimitry Andric static void mapping(IO &IO, TaintConfiguration::Propagation &Propagation) { 451a7dea167SDimitry Andric IO.mapRequired("Name", Propagation.Name); 452480093f4SDimitry Andric IO.mapOptional("Scope", Propagation.Scope); 453a7dea167SDimitry Andric IO.mapOptional("SrcArgs", Propagation.SrcArgs); 454a7dea167SDimitry Andric IO.mapOptional("DstArgs", Propagation.DstArgs); 45504eeddc0SDimitry Andric IO.mapOptional("VariadicType", Propagation.VarType); 45604eeddc0SDimitry Andric IO.mapOptional("VariadicIndex", Propagation.VarIndex); 457a7dea167SDimitry Andric } 458a7dea167SDimitry Andric }; 459a7dea167SDimitry Andric 46004eeddc0SDimitry Andric template <> struct ScalarEnumerationTraits<TaintConfiguration::VariadicType> { 46104eeddc0SDimitry Andric static void enumeration(IO &IO, TaintConfiguration::VariadicType &Value) { 46204eeddc0SDimitry Andric IO.enumCase(Value, "None", TaintConfiguration::VariadicType::None); 46304eeddc0SDimitry Andric IO.enumCase(Value, "Src", TaintConfiguration::VariadicType::Src); 46404eeddc0SDimitry Andric IO.enumCase(Value, "Dst", TaintConfiguration::VariadicType::Dst); 465a7dea167SDimitry Andric } 466a7dea167SDimitry Andric }; 467a7dea167SDimitry Andric } // namespace yaml 468a7dea167SDimitry Andric } // namespace llvm 469a7dea167SDimitry Andric 4700b57cec5SDimitry Andric /// A set which is used to pass information from call pre-visit instruction 47104eeddc0SDimitry Andric /// to the call post-visit. The values are signed integers, which are either 4720b57cec5SDimitry Andric /// ReturnValueIndex, or indexes of the pointer/reference argument, which 4730b57cec5SDimitry Andric /// points to data, which should be tainted on return. 47481ad6265SDimitry Andric REGISTER_MAP_WITH_PROGRAMSTATE(TaintArgsOnPostVisit, const LocationContext *, 47581ad6265SDimitry Andric ImmutableSet<ArgIdxTy>) 47681ad6265SDimitry Andric REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(ArgIdxFactory, ArgIdxTy) 4770b57cec5SDimitry Andric 47804eeddc0SDimitry Andric void GenericTaintRuleParser::validateArgVector(const std::string &Option, 47904eeddc0SDimitry Andric const ArgVecTy &Args) const { 48004eeddc0SDimitry Andric for (ArgIdxTy Arg : Args) { 48104eeddc0SDimitry Andric if (Arg < ReturnValueIndex) { 482a7dea167SDimitry Andric Mgr.reportInvalidCheckerOptionValue( 48304eeddc0SDimitry Andric Mgr.getChecker<GenericTaintChecker>(), Option, 484a7dea167SDimitry Andric "an argument number for propagation rules greater or equal to -1"); 485a7dea167SDimitry Andric } 486a7dea167SDimitry Andric } 487a7dea167SDimitry Andric } 488a7dea167SDimitry Andric 48904eeddc0SDimitry Andric template <typename Config> 49004eeddc0SDimitry Andric GenericTaintRuleParser::NamePartsTy 49104eeddc0SDimitry Andric GenericTaintRuleParser::parseNameParts(const Config &C) { 49204eeddc0SDimitry Andric NamePartsTy NameParts; 49304eeddc0SDimitry Andric if (!C.Scope.empty()) { 49404eeddc0SDimitry Andric // If the Scope argument contains multiple "::" parts, those are considered 49504eeddc0SDimitry Andric // namespace identifiers. 496bdd1243dSDimitry Andric StringRef{C.Scope}.split(NameParts, "::", /*MaxSplit*/ -1, 49704eeddc0SDimitry Andric /*KeepEmpty*/ false); 49804eeddc0SDimitry Andric } 49904eeddc0SDimitry Andric NameParts.emplace_back(C.Name); 50004eeddc0SDimitry Andric return NameParts; 501480093f4SDimitry Andric } 502480093f4SDimitry Andric 50304eeddc0SDimitry Andric template <typename Config> 50404eeddc0SDimitry Andric void GenericTaintRuleParser::consumeRulesFromConfig(const Config &C, 50504eeddc0SDimitry Andric GenericTaintRule &&Rule, 50604eeddc0SDimitry Andric RulesContTy &Rules) { 50704eeddc0SDimitry Andric NamePartsTy NameParts = parseNameParts(C); 508*0fca6ea1SDimitry Andric Rules.emplace_back(CallDescription(CDM::Unspecified, NameParts), 509*0fca6ea1SDimitry Andric std::move(Rule)); 51004eeddc0SDimitry Andric } 5110b57cec5SDimitry Andric 51204eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 51304eeddc0SDimitry Andric TaintConfiguration::Sink &&S, 51404eeddc0SDimitry Andric RulesContTy &Rules) const { 51504eeddc0SDimitry Andric validateArgVector(Option, S.SinkArgs); 51604eeddc0SDimitry Andric consumeRulesFromConfig(S, GenericTaintRule::Sink(std::move(S.SinkArgs)), 51704eeddc0SDimitry Andric Rules); 51804eeddc0SDimitry Andric } 51904eeddc0SDimitry Andric 52004eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 52104eeddc0SDimitry Andric TaintConfiguration::Filter &&S, 52204eeddc0SDimitry Andric RulesContTy &Rules) const { 52304eeddc0SDimitry Andric validateArgVector(Option, S.FilterArgs); 52404eeddc0SDimitry Andric consumeRulesFromConfig(S, GenericTaintRule::Filter(std::move(S.FilterArgs)), 52504eeddc0SDimitry Andric Rules); 52604eeddc0SDimitry Andric } 52704eeddc0SDimitry Andric 52804eeddc0SDimitry Andric void GenericTaintRuleParser::parseConfig(const std::string &Option, 52904eeddc0SDimitry Andric TaintConfiguration::Propagation &&P, 53004eeddc0SDimitry Andric RulesContTy &Rules) const { 53104eeddc0SDimitry Andric validateArgVector(Option, P.SrcArgs); 53204eeddc0SDimitry Andric validateArgVector(Option, P.DstArgs); 53304eeddc0SDimitry Andric bool IsSrcVariadic = P.VarType == TaintConfiguration::VariadicType::Src; 53404eeddc0SDimitry Andric bool IsDstVariadic = P.VarType == TaintConfiguration::VariadicType::Dst; 535bdd1243dSDimitry Andric std::optional<ArgIdxTy> JustVarIndex = P.VarIndex; 53604eeddc0SDimitry Andric 537bdd1243dSDimitry Andric ArgSet SrcDesc(std::move(P.SrcArgs), 538bdd1243dSDimitry Andric IsSrcVariadic ? JustVarIndex : std::nullopt); 539bdd1243dSDimitry Andric ArgSet DstDesc(std::move(P.DstArgs), 540bdd1243dSDimitry Andric IsDstVariadic ? JustVarIndex : std::nullopt); 54104eeddc0SDimitry Andric 54204eeddc0SDimitry Andric consumeRulesFromConfig( 54304eeddc0SDimitry Andric P, GenericTaintRule::Prop(std::move(SrcDesc), std::move(DstDesc)), Rules); 54404eeddc0SDimitry Andric } 54504eeddc0SDimitry Andric 54604eeddc0SDimitry Andric GenericTaintRuleParser::RulesContTy 54704eeddc0SDimitry Andric GenericTaintRuleParser::parseConfiguration(const std::string &Option, 54804eeddc0SDimitry Andric TaintConfiguration &&Config) const { 54904eeddc0SDimitry Andric 55004eeddc0SDimitry Andric RulesContTy Rules; 55104eeddc0SDimitry Andric 55204eeddc0SDimitry Andric for (auto &F : Config.Filters) 55304eeddc0SDimitry Andric parseConfig(Option, std::move(F), Rules); 55404eeddc0SDimitry Andric 55504eeddc0SDimitry Andric for (auto &S : Config.Sinks) 55604eeddc0SDimitry Andric parseConfig(Option, std::move(S), Rules); 55704eeddc0SDimitry Andric 55804eeddc0SDimitry Andric for (auto &P : Config.Propagations) 55904eeddc0SDimitry Andric parseConfig(Option, std::move(P), Rules); 56004eeddc0SDimitry Andric 56104eeddc0SDimitry Andric return Rules; 56204eeddc0SDimitry Andric } 56304eeddc0SDimitry Andric 56404eeddc0SDimitry Andric void GenericTaintChecker::initTaintRules(CheckerContext &C) const { 5650b57cec5SDimitry Andric // Check for exact name match for functions without builtin substitutes. 566480093f4SDimitry Andric // Use qualified name, because these are C functions without namespace. 5670b57cec5SDimitry Andric 56804eeddc0SDimitry Andric if (StaticTaintRules || DynamicTaintRules) 56904eeddc0SDimitry Andric return; 57004eeddc0SDimitry Andric 57104eeddc0SDimitry Andric using RulesConstructionTy = 57204eeddc0SDimitry Andric std::vector<std::pair<CallDescription, GenericTaintRule>>; 57304eeddc0SDimitry Andric using TR = GenericTaintRule; 57404eeddc0SDimitry Andric 57504eeddc0SDimitry Andric RulesConstructionTy GlobalCRules{ 57604eeddc0SDimitry Andric // Sources 577*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fdopen"}}, TR::Source({{ReturnValueIndex}})}, 578*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fopen"}}, TR::Source({{ReturnValueIndex}})}, 579*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"freopen"}}, TR::Source({{ReturnValueIndex}})}, 580*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getch"}}, TR::Source({{ReturnValueIndex}})}, 581*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getchar"}}, TR::Source({{ReturnValueIndex}})}, 582*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getchar_unlocked"}}, TR::Source({{ReturnValueIndex}})}, 583*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"gets"}}, TR::Source({{0, ReturnValueIndex}})}, 584*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"gets_s"}}, TR::Source({{0, ReturnValueIndex}})}, 585*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"scanf"}}, TR::Source({{}, 1})}, 586*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"scanf_s"}}, TR::Source({{}, 1})}, 587*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"wgetch"}}, TR::Source({{ReturnValueIndex}})}, 58881ad6265SDimitry Andric // Sometimes the line between taint sources and propagators is blurry. 58981ad6265SDimitry Andric // _IO_getc is choosen to be a source, but could also be a propagator. 59081ad6265SDimitry Andric // This way it is simpler, as modeling it as a propagator would require 59181ad6265SDimitry Andric // to model the possible sources of _IO_FILE * values, which the _IO_getc 59281ad6265SDimitry Andric // function takes as parameters. 593*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"_IO_getc"}}, TR::Source({{ReturnValueIndex}})}, 594*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getcwd"}}, TR::Source({{0, ReturnValueIndex}})}, 595*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getwd"}}, TR::Source({{0, ReturnValueIndex}})}, 596*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"readlink"}}, TR::Source({{1, ReturnValueIndex}})}, 597*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"readlinkat"}}, TR::Source({{2, ReturnValueIndex}})}, 598*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"get_current_dir_name"}}, 599*0fca6ea1SDimitry Andric TR::Source({{ReturnValueIndex}})}, 600*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"gethostname"}}, TR::Source({{0}})}, 601*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getnameinfo"}}, TR::Source({{2, 4}})}, 602*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getseuserbyname"}}, TR::Source({{1, 2}})}, 603*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getgroups"}}, TR::Source({{1, ReturnValueIndex}})}, 604*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getlogin"}}, TR::Source({{ReturnValueIndex}})}, 605*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getlogin_r"}}, TR::Source({{0}})}, 60604eeddc0SDimitry Andric 60704eeddc0SDimitry Andric // Props 608*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"accept"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 609*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"atoi"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 610*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"atol"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 611*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"atoll"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 612*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fgetc"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 613*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fgetln"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 614*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"fgets"}}, 615*0fca6ea1SDimitry Andric TR::Prop({{2}}, {{0, ReturnValueIndex}})}, 616*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"fgetws"}}, 617*0fca6ea1SDimitry Andric TR::Prop({{2}}, {{0, ReturnValueIndex}})}, 618*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fscanf"}}, TR::Prop({{0}}, {{}, 2})}, 619*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fscanf_s"}}, TR::Prop({{0}}, {{}, 2})}, 620*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"sscanf"}}, TR::Prop({{0}}, {{}, 2})}, 621*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"sscanf_s"}}, TR::Prop({{0}}, {{}, 2})}, 62281ad6265SDimitry Andric 623*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getc"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 624*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getc_unlocked"}}, 625*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 626*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getdelim"}}, TR::Prop({{3}}, {{0}})}, 627*0fca6ea1SDimitry Andric // TODO: this intends to match the C function `getline()`, but the call 628*0fca6ea1SDimitry Andric // description also matches the C++ function `std::getline()`; it should 629*0fca6ea1SDimitry Andric // be ruled out by some additional logic. 630*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getline"}}, TR::Prop({{2}}, {{0}})}, 631*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getw"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 632*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"pread"}}, 633*0fca6ea1SDimitry Andric TR::Prop({{0, 1, 2, 3}}, {{1, ReturnValueIndex}})}, 634*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"read"}}, 635*0fca6ea1SDimitry Andric TR::Prop({{0, 2}}, {{1, ReturnValueIndex}})}, 636*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"fread"}}, 637*0fca6ea1SDimitry Andric TR::Prop({{3}}, {{0, ReturnValueIndex}})}, 638*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"recv"}}, 639*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 640*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"recvfrom"}}, 641*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 64281ad6265SDimitry Andric 643*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"ttyname"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 644*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"ttyname_r"}}, 645*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 64681ad6265SDimitry Andric 647*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"basename"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 648*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"dirname"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 649*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fnmatch"}}, TR::Prop({{1}}, {{ReturnValueIndex}})}, 65081ad6265SDimitry Andric 651*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"mbtowc"}}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 652*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"wctomb"}}, TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 653*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"wcwidth"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 65481ad6265SDimitry Andric 655*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"memcmp"}}, 656*0fca6ea1SDimitry Andric TR::Prop({{0, 1, 2}}, {{ReturnValueIndex}})}, 657*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"memcpy"}}, 658*0fca6ea1SDimitry Andric TR::Prop({{1, 2}}, {{0, ReturnValueIndex}})}, 659*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"memmove"}}, 660*0fca6ea1SDimitry Andric TR::Prop({{1, 2}}, {{0, ReturnValueIndex}})}, 661*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"bcopy"}}, TR::Prop({{0, 2}}, {{1}})}, 66281ad6265SDimitry Andric 663*0fca6ea1SDimitry Andric // Note: "memmem" and its variants search for a byte sequence ("needle") 664*0fca6ea1SDimitry Andric // in a larger area ("haystack"). Currently we only propagate taint from 665*0fca6ea1SDimitry Andric // the haystack to the result, but in theory tampering with the needle 666*0fca6ea1SDimitry Andric // could also produce incorrect results. 667*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"memmem"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 668*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strstr"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 669*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strcasestr"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 67081ad6265SDimitry Andric 671*0fca6ea1SDimitry Andric // Analogously, the following functions search for a byte within a buffer 672*0fca6ea1SDimitry Andric // and we only propagate taint from the buffer to the result. 673*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"memchr"}}, 674*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 675*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"memrchr"}}, 676*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 677*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"rawmemchr"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 678*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strchr"}}, 679*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 680*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strrchr"}}, 681*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 682*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strchrnul"}}, 683*0fca6ea1SDimitry Andric TR::Prop({{0}}, {{ReturnValueIndex}})}, 684*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"index"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 685*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"rindex"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 68681ad6265SDimitry Andric 68781ad6265SDimitry Andric // FIXME: In case of arrays, only the first element of the array gets 68881ad6265SDimitry Andric // tainted. 689*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"qsort"}}, TR::Prop({{0}}, {{0}})}, 690*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"qsort_r"}}, TR::Prop({{0}}, {{0}})}, 69181ad6265SDimitry Andric 692*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strcmp"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 693*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strcasecmp"}}, 694*0fca6ea1SDimitry Andric TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 695*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strncmp"}}, 696*0fca6ea1SDimitry Andric TR::Prop({{0, 1, 2}}, {{ReturnValueIndex}})}, 697*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strncasecmp"}}, 698*0fca6ea1SDimitry Andric TR::Prop({{0, 1, 2}}, {{ReturnValueIndex}})}, 699*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strspn"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 700*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strcspn"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 701*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strpbrk"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 702*0fca6ea1SDimitry Andric 703*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strndup"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 704*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strndupa"}}, TR::Prop({{0, 1}}, {{ReturnValueIndex}})}, 705*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strdup"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 706*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strdupa"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 707*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"wcsdup"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 7085f757f3fSDimitry Andric 7095f757f3fSDimitry Andric // strlen, wcslen, strnlen and alike intentionally don't propagate taint. 7105f757f3fSDimitry Andric // See the details here: https://github.com/llvm/llvm-project/pull/66086 7115f757f3fSDimitry Andric 712*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strtol"}}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 713*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strtoll"}}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 714*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strtoul"}}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 715*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"strtoull"}}, TR::Prop({{0}}, {{1, ReturnValueIndex}})}, 71681ad6265SDimitry Andric 717*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"tolower"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 718*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"toupper"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 71981ad6265SDimitry Andric 720*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isalnum"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 721*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isalpha"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 722*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isascii"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 723*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isblank"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 724*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"iscntrl"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 725*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isdigit"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 726*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isgraph"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 727*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"islower"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 728*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isprint"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 729*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"ispunct"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 730*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isspace"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 731*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isupper"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 732*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"isxdigit"}}, TR::Prop({{0}}, {{ReturnValueIndex}})}, 733*0fca6ea1SDimitry Andric 734*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strcpy"}}, 735*0fca6ea1SDimitry Andric TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 736*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"stpcpy"}}, 737*0fca6ea1SDimitry Andric TR::Prop({{1}}, {{0, ReturnValueIndex}})}, 738*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strcat"}}, 739*0fca6ea1SDimitry Andric TR::Prop({{0, 1}}, {{0, ReturnValueIndex}})}, 740*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"wcsncat"}}, 741*0fca6ea1SDimitry Andric TR::Prop({{0, 1}}, {{0, ReturnValueIndex}})}, 742*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strncpy"}}, 74304eeddc0SDimitry Andric TR::Prop({{1, 2}}, {{0, ReturnValueIndex}})}, 744*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strncat"}}, 745*0fca6ea1SDimitry Andric TR::Prop({{0, 1, 2}}, {{0, ReturnValueIndex}})}, 746*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strlcpy"}}, TR::Prop({{1, 2}}, {{0}})}, 747*0fca6ea1SDimitry Andric {{CDM::CLibraryMaybeHardened, {"strlcat"}}, TR::Prop({{0, 1, 2}}, {{0}})}, 748*0fca6ea1SDimitry Andric 749*0fca6ea1SDimitry Andric // Usually the matching mode `CDM::CLibraryMaybeHardened` is sufficient 750*0fca6ea1SDimitry Andric // for unified handling of a function `FOO()` and its hardened variant 751*0fca6ea1SDimitry Andric // `__FOO_chk()`, but in the "sprintf" family the extra parameters of the 752*0fca6ea1SDimitry Andric // hardened variants are inserted into the middle of the parameter list, 753*0fca6ea1SDimitry Andric // so that would not work in their case. 754*0fca6ea1SDimitry Andric // int snprintf(char * str, size_t maxlen, const char * format, ...); 755*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"snprintf"}}, 756*0fca6ea1SDimitry Andric TR::Prop({{1, 2}, 3}, {{0, ReturnValueIndex}})}, 757*0fca6ea1SDimitry Andric // int sprintf(char * str, const char * format, ...); 758*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"sprintf"}}, 75904eeddc0SDimitry Andric TR::Prop({{1}, 2}, {{0, ReturnValueIndex}})}, 760*0fca6ea1SDimitry Andric // int __snprintf_chk(char * str, size_t maxlen, int flag, size_t strlen, 761*0fca6ea1SDimitry Andric // const char * format, ...); 762*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"__snprintf_chk"}}, 763*0fca6ea1SDimitry Andric TR::Prop({{1, 4}, 5}, {{0, ReturnValueIndex}})}, 764*0fca6ea1SDimitry Andric // int __sprintf_chk(char * str, int flag, size_t strlen, const char * 765*0fca6ea1SDimitry Andric // format, ...); 766*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"__sprintf_chk"}}, 767*0fca6ea1SDimitry Andric TR::Prop({{3}, 4}, {{0, ReturnValueIndex}})}, 76804eeddc0SDimitry Andric 76904eeddc0SDimitry Andric // Sinks 770*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"system"}}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 771*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"popen"}}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 772*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execl"}}, TR::Sink({{}, {0}}, MsgSanitizeSystemArgs)}, 773*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execle"}}, TR::Sink({{}, {0}}, MsgSanitizeSystemArgs)}, 774*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execlp"}}, TR::Sink({{}, {0}}, MsgSanitizeSystemArgs)}, 775*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execv"}}, TR::Sink({{0, 1}}, MsgSanitizeSystemArgs)}, 776*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execve"}}, 777*0fca6ea1SDimitry Andric TR::Sink({{0, 1, 2}}, MsgSanitizeSystemArgs)}, 778*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"fexecve"}}, 779*0fca6ea1SDimitry Andric TR::Sink({{0, 1, 2}}, MsgSanitizeSystemArgs)}, 780*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execvp"}}, TR::Sink({{0, 1}}, MsgSanitizeSystemArgs)}, 781*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"execvpe"}}, 782*0fca6ea1SDimitry Andric TR::Sink({{0, 1, 2}}, MsgSanitizeSystemArgs)}, 783*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"dlopen"}}, TR::Sink({{0}}, MsgSanitizeSystemArgs)}, 784*0fca6ea1SDimitry Andric 785*0fca6ea1SDimitry Andric // malloc, calloc, alloca, realloc, memccpy 786*0fca6ea1SDimitry Andric // are intentionally not marked as taint sinks because unconditional 787*0fca6ea1SDimitry Andric // reporting for these functions generates many false positives. 788*0fca6ea1SDimitry Andric // These taint sinks should be implemented in other checkers with more 789*0fca6ea1SDimitry Andric // sophisticated sanitation heuristics. 790*0fca6ea1SDimitry Andric 791*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"setproctitle"}}, 79204eeddc0SDimitry Andric TR::Sink({{0}, 1}, MsgUncontrolledFormatString)}, 793*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"setproctitle_fast"}}, 794*0fca6ea1SDimitry Andric TR::Sink({{0}, 1}, MsgUncontrolledFormatString)}}; 79504eeddc0SDimitry Andric 79604eeddc0SDimitry Andric if (TR::UntrustedEnv(C)) { 79704eeddc0SDimitry Andric // void setproctitle_init(int argc, char *argv[], char *envp[]) 798*0fca6ea1SDimitry Andric // TODO: replace `MsgCustomSink` with a message that fits this situation. 799*0fca6ea1SDimitry Andric GlobalCRules.push_back({{CDM::CLibrary, {"setproctitle_init"}}, 800*0fca6ea1SDimitry Andric TR::Sink({{1, 2}}, MsgCustomSink)}); 801*0fca6ea1SDimitry Andric 802*0fca6ea1SDimitry Andric // `getenv` returns taint only in untrusted environments. 80304eeddc0SDimitry Andric GlobalCRules.push_back( 804*0fca6ea1SDimitry Andric {{CDM::CLibrary, {"getenv"}}, TR::Source({{ReturnValueIndex}})}); 805349cc55cSDimitry Andric } 806349cc55cSDimitry Andric 80704eeddc0SDimitry Andric StaticTaintRules.emplace(std::make_move_iterator(GlobalCRules.begin()), 80804eeddc0SDimitry Andric std::make_move_iterator(GlobalCRules.end())); 8090b57cec5SDimitry Andric 81004eeddc0SDimitry Andric // User-provided taint configuration. 81104eeddc0SDimitry Andric CheckerManager *Mgr = C.getAnalysisManager().getCheckerManager(); 81204eeddc0SDimitry Andric assert(Mgr); 81304eeddc0SDimitry Andric GenericTaintRuleParser ConfigParser{*Mgr}; 81404eeddc0SDimitry Andric std::string Option{"Config"}; 81504eeddc0SDimitry Andric StringRef ConfigFile = 81604eeddc0SDimitry Andric Mgr->getAnalyzerOptions().getCheckerStringOption(this, Option); 817bdd1243dSDimitry Andric std::optional<TaintConfiguration> Config = 81804eeddc0SDimitry Andric getConfiguration<TaintConfiguration>(*Mgr, this, Option, ConfigFile); 81904eeddc0SDimitry Andric if (!Config) { 82004eeddc0SDimitry Andric // We don't have external taint config, no parsing required. 82104eeddc0SDimitry Andric DynamicTaintRules = RuleLookupTy{}; 82204eeddc0SDimitry Andric return; 8235ffd83dbSDimitry Andric } 8240b57cec5SDimitry Andric 82504eeddc0SDimitry Andric GenericTaintRuleParser::RulesContTy Rules{ 82681ad6265SDimitry Andric ConfigParser.parseConfiguration(Option, std::move(*Config))}; 8270b57cec5SDimitry Andric 82804eeddc0SDimitry Andric DynamicTaintRules.emplace(std::make_move_iterator(Rules.begin()), 82904eeddc0SDimitry Andric std::make_move_iterator(Rules.end())); 830480093f4SDimitry Andric } 831a7dea167SDimitry Andric 8325ffd83dbSDimitry Andric void GenericTaintChecker::checkPreCall(const CallEvent &Call, 8330b57cec5SDimitry Andric CheckerContext &C) const { 83404eeddc0SDimitry Andric initTaintRules(C); 835480093f4SDimitry Andric 83604eeddc0SDimitry Andric // FIXME: this should be much simpler. 83704eeddc0SDimitry Andric if (const auto *Rule = 83804eeddc0SDimitry Andric Call.isGlobalCFunction() ? StaticTaintRules->lookup(Call) : nullptr) 83904eeddc0SDimitry Andric Rule->process(*this, Call, C); 84004eeddc0SDimitry Andric else if (const auto *Rule = DynamicTaintRules->lookup(Call)) 84104eeddc0SDimitry Andric Rule->process(*this, Call, C); 8420b57cec5SDimitry Andric 84304eeddc0SDimitry Andric // FIXME: These edge cases are to be eliminated from here eventually. 84404eeddc0SDimitry Andric // 84504eeddc0SDimitry Andric // Additional check that is not supported by CallDescription. 84604eeddc0SDimitry Andric // TODO: Make CallDescription be able to match attributes such as printf-like 84704eeddc0SDimitry Andric // arguments. 84804eeddc0SDimitry Andric checkUncontrolledFormatString(Call, C); 849480093f4SDimitry Andric 85004eeddc0SDimitry Andric // TODO: Modeling sockets should be done in a specific checker. 85104eeddc0SDimitry Andric // Socket is a source, which taints the return value. 85204eeddc0SDimitry Andric taintUnsafeSocketProtocol(Call, C); 8530b57cec5SDimitry Andric } 8540b57cec5SDimitry Andric 8555ffd83dbSDimitry Andric void GenericTaintChecker::checkPostCall(const CallEvent &Call, 8560b57cec5SDimitry Andric CheckerContext &C) const { 8570b57cec5SDimitry Andric // Set the marked values as tainted. The return value only accessible from 8580b57cec5SDimitry Andric // checkPostStmt. 8590b57cec5SDimitry Andric ProgramStateRef State = C.getState(); 86081ad6265SDimitry Andric const StackFrameContext *CurrentFrame = C.getStackFrame(); 8610b57cec5SDimitry Andric 8620b57cec5SDimitry Andric // Depending on what was tainted at pre-visit, we determined a set of 8630b57cec5SDimitry Andric // arguments which should be tainted after the function returns. These are 8640b57cec5SDimitry Andric // stored in the state as TaintArgsOnPostVisit set. 86581ad6265SDimitry Andric TaintArgsOnPostVisitTy TaintArgsMap = State->get<TaintArgsOnPostVisit>(); 8660b57cec5SDimitry Andric 86781ad6265SDimitry Andric const ImmutableSet<ArgIdxTy> *TaintArgs = TaintArgsMap.lookup(CurrentFrame); 86881ad6265SDimitry Andric if (!TaintArgs) 86981ad6265SDimitry Andric return; 87081ad6265SDimitry Andric assert(!TaintArgs->isEmpty()); 87181ad6265SDimitry Andric 87281ad6265SDimitry Andric LLVM_DEBUG(for (ArgIdxTy I 87381ad6265SDimitry Andric : *TaintArgs) { 87481ad6265SDimitry Andric llvm::dbgs() << "PostCall<"; 87581ad6265SDimitry Andric Call.dump(llvm::dbgs()); 87681ad6265SDimitry Andric llvm::dbgs() << "> actually wants to taint arg index: " << I << '\n'; 87781ad6265SDimitry Andric }); 87881ad6265SDimitry Andric 87906c3fb27SDimitry Andric const NoteTag *InjectionTag = nullptr; 88006c3fb27SDimitry Andric std::vector<SymbolRef> TaintedSymbols; 88106c3fb27SDimitry Andric std::vector<ArgIdxTy> TaintedIndexes; 88281ad6265SDimitry Andric for (ArgIdxTy ArgNum : *TaintArgs) { 8830b57cec5SDimitry Andric // Special handling for the tainted return value. 8840b57cec5SDimitry Andric if (ArgNum == ReturnValueIndex) { 8855ffd83dbSDimitry Andric State = addTaint(State, Call.getReturnValue()); 88606c3fb27SDimitry Andric std::vector<SymbolRef> TaintedSyms = 88706c3fb27SDimitry Andric getTaintedSymbols(State, Call.getReturnValue()); 88806c3fb27SDimitry Andric if (!TaintedSyms.empty()) { 88906c3fb27SDimitry Andric TaintedSymbols.push_back(TaintedSyms[0]); 89006c3fb27SDimitry Andric TaintedIndexes.push_back(ArgNum); 89106c3fb27SDimitry Andric } 8920b57cec5SDimitry Andric continue; 8930b57cec5SDimitry Andric } 8940b57cec5SDimitry Andric // The arguments are pointer arguments. The data they are pointing at is 8950b57cec5SDimitry Andric // tainted after the call. 89606c3fb27SDimitry Andric if (auto V = getPointeeOf(State, Call.getArgSVal(ArgNum))) { 8970b57cec5SDimitry Andric State = addTaint(State, *V); 89806c3fb27SDimitry Andric std::vector<SymbolRef> TaintedSyms = getTaintedSymbols(State, *V); 89906c3fb27SDimitry Andric if (!TaintedSyms.empty()) { 90006c3fb27SDimitry Andric TaintedSymbols.push_back(TaintedSyms[0]); 90106c3fb27SDimitry Andric TaintedIndexes.push_back(ArgNum); 9020b57cec5SDimitry Andric } 90306c3fb27SDimitry Andric } 90406c3fb27SDimitry Andric } 90506c3fb27SDimitry Andric // Create a NoteTag callback, which prints to the user where the taintedness 90606c3fb27SDimitry Andric // was propagated to. 90706c3fb27SDimitry Andric InjectionTag = taintPropagationExplainerTag(C, TaintedSymbols, TaintedIndexes, 90806c3fb27SDimitry Andric Call.getCalleeStackFrame(0)); 9090b57cec5SDimitry Andric // Clear up the taint info from the state. 91081ad6265SDimitry Andric State = State->remove<TaintArgsOnPostVisit>(CurrentFrame); 91106c3fb27SDimitry Andric C.addTransition(State, InjectionTag); 9120b57cec5SDimitry Andric } 9130b57cec5SDimitry Andric 91404eeddc0SDimitry Andric void GenericTaintChecker::printState(raw_ostream &Out, ProgramStateRef State, 91504eeddc0SDimitry Andric const char *NL, const char *Sep) const { 91604eeddc0SDimitry Andric printTaint(State, Out, NL, Sep); 9170b57cec5SDimitry Andric } 9180b57cec5SDimitry Andric 91904eeddc0SDimitry Andric void GenericTaintRule::process(const GenericTaintChecker &Checker, 92004eeddc0SDimitry Andric const CallEvent &Call, CheckerContext &C) const { 9210b57cec5SDimitry Andric ProgramStateRef State = C.getState(); 92204eeddc0SDimitry Andric const ArgIdxTy CallNumArgs = fromArgumentCount(Call.getNumArgs()); 9230b57cec5SDimitry Andric 92404eeddc0SDimitry Andric /// Iterate every call argument, and get their corresponding Expr and SVal. 92504eeddc0SDimitry Andric const auto ForEachCallArg = [&C, &Call, CallNumArgs](auto &&Fun) { 92604eeddc0SDimitry Andric for (ArgIdxTy I = ReturnValueIndex; I < CallNumArgs; ++I) { 92704eeddc0SDimitry Andric const Expr *E = GetArgExpr(I, Call); 92804eeddc0SDimitry Andric Fun(I, E, C.getSVal(E)); 9290b57cec5SDimitry Andric } 93004eeddc0SDimitry Andric }; 9310b57cec5SDimitry Andric 93204eeddc0SDimitry Andric /// Check for taint sinks. 93304eeddc0SDimitry Andric ForEachCallArg([this, &Checker, &C, &State](ArgIdxTy I, const Expr *E, SVal) { 93406c3fb27SDimitry Andric // Add taintedness to stdin parameters 93506c3fb27SDimitry Andric if (isStdin(C.getSVal(E), C.getASTContext())) { 93606c3fb27SDimitry Andric State = addTaint(State, C.getSVal(E)); 93706c3fb27SDimitry Andric } 93806c3fb27SDimitry Andric if (SinkArgs.contains(I) && isTaintedOrPointsToTainted(State, C.getSVal(E))) 93981ad6265SDimitry Andric Checker.generateReportIfTainted(E, SinkMsg.value_or(MsgCustomSink), C); 94004eeddc0SDimitry Andric }); 9410b57cec5SDimitry Andric 94204eeddc0SDimitry Andric /// Check for taint filters. 94306c3fb27SDimitry Andric ForEachCallArg([this, &State](ArgIdxTy I, const Expr *E, SVal S) { 94404eeddc0SDimitry Andric if (FilterArgs.contains(I)) { 94504eeddc0SDimitry Andric State = removeTaint(State, S); 94606c3fb27SDimitry Andric if (auto P = getPointeeOf(State, S)) 94704eeddc0SDimitry Andric State = removeTaint(State, *P); 9480b57cec5SDimitry Andric } 94904eeddc0SDimitry Andric }); 9500b57cec5SDimitry Andric 95104eeddc0SDimitry Andric /// Check for taint propagation sources. 95206c3fb27SDimitry Andric /// A rule will make the destination variables tainted if PropSrcArgs 95306c3fb27SDimitry Andric /// is empty (taints the destination 95406c3fb27SDimitry Andric /// arguments unconditionally), or if any of its signified 95504eeddc0SDimitry Andric /// args are tainted in context of the current CallEvent. 95604eeddc0SDimitry Andric bool IsMatching = PropSrcArgs.isEmpty(); 95706c3fb27SDimitry Andric std::vector<SymbolRef> TaintedSymbols; 95806c3fb27SDimitry Andric std::vector<ArgIdxTy> TaintedIndexes; 95906c3fb27SDimitry Andric ForEachCallArg([this, &C, &IsMatching, &State, &TaintedSymbols, 96006c3fb27SDimitry Andric &TaintedIndexes](ArgIdxTy I, const Expr *E, SVal) { 96106c3fb27SDimitry Andric std::optional<SVal> TaintedSVal = 96206c3fb27SDimitry Andric getTaintedPointeeOrPointer(State, C.getSVal(E)); 96306c3fb27SDimitry Andric IsMatching = 96406c3fb27SDimitry Andric IsMatching || (PropSrcArgs.contains(I) && TaintedSVal.has_value()); 96506c3fb27SDimitry Andric 96606c3fb27SDimitry Andric // We track back tainted arguments except for stdin 96706c3fb27SDimitry Andric if (TaintedSVal && !isStdin(*TaintedSVal, C.getASTContext())) { 96806c3fb27SDimitry Andric std::vector<SymbolRef> TaintedArgSyms = 96906c3fb27SDimitry Andric getTaintedSymbols(State, *TaintedSVal); 97006c3fb27SDimitry Andric if (!TaintedArgSyms.empty()) { 97106c3fb27SDimitry Andric llvm::append_range(TaintedSymbols, TaintedArgSyms); 97206c3fb27SDimitry Andric TaintedIndexes.push_back(I); 97306c3fb27SDimitry Andric } 97406c3fb27SDimitry Andric } 97504eeddc0SDimitry Andric }); 9760b57cec5SDimitry Andric 97706c3fb27SDimitry Andric // Early return for propagation rules which dont match. 97806c3fb27SDimitry Andric // Matching propagations, Sinks and Filters will pass this point. 97904eeddc0SDimitry Andric if (!IsMatching) 98004eeddc0SDimitry Andric return; 9810b57cec5SDimitry Andric 98204eeddc0SDimitry Andric const auto WouldEscape = [](SVal V, QualType Ty) -> bool { 98381ad6265SDimitry Andric if (!isa<Loc>(V)) 9840b57cec5SDimitry Andric return false; 9850b57cec5SDimitry Andric 98604eeddc0SDimitry Andric const bool IsNonConstRef = Ty->isReferenceType() && !Ty.isConstQualified(); 98704eeddc0SDimitry Andric const bool IsNonConstPtr = 98804eeddc0SDimitry Andric Ty->isPointerType() && !Ty->getPointeeType().isConstQualified(); 9890b57cec5SDimitry Andric 99004eeddc0SDimitry Andric return IsNonConstRef || IsNonConstPtr; 99104eeddc0SDimitry Andric }; 99204eeddc0SDimitry Andric 99304eeddc0SDimitry Andric /// Propagate taint where it is necessary. 99481ad6265SDimitry Andric auto &F = State->getStateManager().get_context<ArgIdxFactory>(); 99581ad6265SDimitry Andric ImmutableSet<ArgIdxTy> Result = F.getEmptySet(); 99604eeddc0SDimitry Andric ForEachCallArg( 99781ad6265SDimitry Andric [&](ArgIdxTy I, const Expr *E, SVal V) { 99881ad6265SDimitry Andric if (PropDstArgs.contains(I)) { 99981ad6265SDimitry Andric LLVM_DEBUG(llvm::dbgs() << "PreCall<"; Call.dump(llvm::dbgs()); 100081ad6265SDimitry Andric llvm::dbgs() 100181ad6265SDimitry Andric << "> prepares tainting arg index: " << I << '\n';); 100281ad6265SDimitry Andric Result = F.add(Result, I); 100381ad6265SDimitry Andric } 100404eeddc0SDimitry Andric 100506c3fb27SDimitry Andric // Taint property gets lost if the variable is passed as a 100606c3fb27SDimitry Andric // non-const pointer or reference to a function which is 100706c3fb27SDimitry Andric // not inlined. For matching rules we want to preserve the taintedness. 100804eeddc0SDimitry Andric // TODO: We should traverse all reachable memory regions via the 100904eeddc0SDimitry Andric // escaping parameter. Instead of doing that we simply mark only the 101004eeddc0SDimitry Andric // referred memory region as tainted. 101106c3fb27SDimitry Andric if (WouldEscape(V, E->getType()) && getTaintedPointeeOrPointer(State, V)) { 101281ad6265SDimitry Andric LLVM_DEBUG(if (!Result.contains(I)) { 101381ad6265SDimitry Andric llvm::dbgs() << "PreCall<"; 101481ad6265SDimitry Andric Call.dump(llvm::dbgs()); 101581ad6265SDimitry Andric llvm::dbgs() << "> prepares tainting arg index: " << I << '\n'; 101681ad6265SDimitry Andric }); 101781ad6265SDimitry Andric Result = F.add(Result, I); 101881ad6265SDimitry Andric } 101904eeddc0SDimitry Andric }); 102004eeddc0SDimitry Andric 102181ad6265SDimitry Andric if (!Result.isEmpty()) 102281ad6265SDimitry Andric State = State->set<TaintArgsOnPostVisit>(C.getStackFrame(), Result); 102306c3fb27SDimitry Andric const NoteTag *InjectionTag = taintOriginTrackerTag( 102406c3fb27SDimitry Andric C, std::move(TaintedSymbols), std::move(TaintedIndexes), 102506c3fb27SDimitry Andric Call.getCalleeStackFrame(0)); 102606c3fb27SDimitry Andric C.addTransition(State, InjectionTag); 10270b57cec5SDimitry Andric } 10280b57cec5SDimitry Andric 102904eeddc0SDimitry Andric bool GenericTaintRule::UntrustedEnv(CheckerContext &C) { 103004eeddc0SDimitry Andric return !C.getAnalysisManager() 103104eeddc0SDimitry Andric .getAnalyzerOptions() 103204eeddc0SDimitry Andric .ShouldAssumeControlledEnvironment; 10330b57cec5SDimitry Andric } 10340b57cec5SDimitry Andric 1035a7dea167SDimitry Andric bool GenericTaintChecker::generateReportIfTainted(const Expr *E, StringRef Msg, 10360b57cec5SDimitry Andric CheckerContext &C) const { 10370b57cec5SDimitry Andric assert(E); 1038*0fca6ea1SDimitry Andric if (!isTaintReporterCheckerEnabled) 1039*0fca6ea1SDimitry Andric return false; 104006c3fb27SDimitry Andric std::optional<SVal> TaintedSVal = 104106c3fb27SDimitry Andric getTaintedPointeeOrPointer(C.getState(), C.getSVal(E)); 10420b57cec5SDimitry Andric 104304eeddc0SDimitry Andric if (!TaintedSVal) 10440b57cec5SDimitry Andric return false; 10450b57cec5SDimitry Andric 10460b57cec5SDimitry Andric // Generate diagnostic. 1047*0fca6ea1SDimitry Andric assert(BT); 1048*0fca6ea1SDimitry Andric static CheckerProgramPointTag Tag(BT->getCheckerName(), Msg); 1049*0fca6ea1SDimitry Andric if (ExplodedNode *N = C.generateNonFatalErrorNode(C.getState(), &Tag)) { 1050*0fca6ea1SDimitry Andric auto report = std::make_unique<PathSensitiveBugReport>(*BT, Msg, N); 10510b57cec5SDimitry Andric report->addRange(E->getSourceRange()); 105206c3fb27SDimitry Andric for (auto TaintedSym : getTaintedSymbols(C.getState(), *TaintedSVal)) { 105306c3fb27SDimitry Andric report->markInteresting(TaintedSym); 105406c3fb27SDimitry Andric } 10550b57cec5SDimitry Andric C.emitReport(std::move(report)); 10560b57cec5SDimitry Andric return true; 10570b57cec5SDimitry Andric } 10580b57cec5SDimitry Andric return false; 10590b57cec5SDimitry Andric } 10600b57cec5SDimitry Andric 106104eeddc0SDimitry Andric /// TODO: remove checking for printf format attributes and socket whitelisting 106204eeddc0SDimitry Andric /// from GenericTaintChecker, and that means the following functions: 106304eeddc0SDimitry Andric /// getPrintfFormatArgumentNum, 106404eeddc0SDimitry Andric /// GenericTaintChecker::checkUncontrolledFormatString, 106504eeddc0SDimitry Andric /// GenericTaintChecker::taintUnsafeSocketProtocol 106604eeddc0SDimitry Andric 106704eeddc0SDimitry Andric static bool getPrintfFormatArgumentNum(const CallEvent &Call, 106804eeddc0SDimitry Andric const CheckerContext &C, 106904eeddc0SDimitry Andric ArgIdxTy &ArgNum) { 107004eeddc0SDimitry Andric // Find if the function contains a format string argument. 107104eeddc0SDimitry Andric // Handles: fprintf, printf, sprintf, snprintf, vfprintf, vprintf, vsprintf, 107204eeddc0SDimitry Andric // vsnprintf, syslog, custom annotated functions. 107304eeddc0SDimitry Andric const Decl *CallDecl = Call.getDecl(); 107404eeddc0SDimitry Andric if (!CallDecl) 107504eeddc0SDimitry Andric return false; 107604eeddc0SDimitry Andric const FunctionDecl *FDecl = CallDecl->getAsFunction(); 107704eeddc0SDimitry Andric if (!FDecl) 107804eeddc0SDimitry Andric return false; 107904eeddc0SDimitry Andric 108004eeddc0SDimitry Andric const ArgIdxTy CallNumArgs = fromArgumentCount(Call.getNumArgs()); 108104eeddc0SDimitry Andric 108204eeddc0SDimitry Andric for (const auto *Format : FDecl->specific_attrs<FormatAttr>()) { 108304eeddc0SDimitry Andric ArgNum = Format->getFormatIdx() - 1; 108404eeddc0SDimitry Andric if ((Format->getType()->getName() == "printf") && CallNumArgs > ArgNum) 108504eeddc0SDimitry Andric return true; 108604eeddc0SDimitry Andric } 108704eeddc0SDimitry Andric 108804eeddc0SDimitry Andric return false; 108904eeddc0SDimitry Andric } 109004eeddc0SDimitry Andric 10910b57cec5SDimitry Andric bool GenericTaintChecker::checkUncontrolledFormatString( 10925ffd83dbSDimitry Andric const CallEvent &Call, CheckerContext &C) const { 10930b57cec5SDimitry Andric // Check if the function contains a format string argument. 109404eeddc0SDimitry Andric ArgIdxTy ArgNum = 0; 10955ffd83dbSDimitry Andric if (!getPrintfFormatArgumentNum(Call, C, ArgNum)) 10960b57cec5SDimitry Andric return false; 10970b57cec5SDimitry Andric 10980b57cec5SDimitry Andric // If either the format string content or the pointer itself are tainted, 10990b57cec5SDimitry Andric // warn. 11005ffd83dbSDimitry Andric return generateReportIfTainted(Call.getArgExpr(ArgNum), 11010b57cec5SDimitry Andric MsgUncontrolledFormatString, C); 11020b57cec5SDimitry Andric } 11030b57cec5SDimitry Andric 110404eeddc0SDimitry Andric void GenericTaintChecker::taintUnsafeSocketProtocol(const CallEvent &Call, 11050b57cec5SDimitry Andric CheckerContext &C) const { 110604eeddc0SDimitry Andric if (Call.getNumArgs() < 1) 110704eeddc0SDimitry Andric return; 110804eeddc0SDimitry Andric const IdentifierInfo *ID = Call.getCalleeIdentifier(); 110904eeddc0SDimitry Andric if (!ID) 111004eeddc0SDimitry Andric return; 1111*0fca6ea1SDimitry Andric if (ID->getName() != "socket") 111204eeddc0SDimitry Andric return; 11130b57cec5SDimitry Andric 111404eeddc0SDimitry Andric SourceLocation DomLoc = Call.getArgExpr(0)->getExprLoc(); 111504eeddc0SDimitry Andric StringRef DomName = C.getMacroNameOrSpelling(DomLoc); 111604eeddc0SDimitry Andric // Allow internal communication protocols. 1117*0fca6ea1SDimitry Andric bool SafeProtocol = DomName == "AF_SYSTEM" || DomName == "AF_LOCAL" || 1118*0fca6ea1SDimitry Andric DomName == "AF_UNIX" || DomName == "AF_RESERVED_36"; 111904eeddc0SDimitry Andric if (SafeProtocol) 112004eeddc0SDimitry Andric return; 11210b57cec5SDimitry Andric 112281ad6265SDimitry Andric ProgramStateRef State = C.getState(); 112381ad6265SDimitry Andric auto &F = State->getStateManager().get_context<ArgIdxFactory>(); 112481ad6265SDimitry Andric ImmutableSet<ArgIdxTy> Result = F.add(F.getEmptySet(), ReturnValueIndex); 112581ad6265SDimitry Andric State = State->set<TaintArgsOnPostVisit>(C.getStackFrame(), Result); 112681ad6265SDimitry Andric C.addTransition(State); 11270b57cec5SDimitry Andric } 11280b57cec5SDimitry Andric 112904eeddc0SDimitry Andric /// Checker registration 1130*0fca6ea1SDimitry Andric void ento::registerTaintPropagationChecker(CheckerManager &Mgr) { 113104eeddc0SDimitry Andric Mgr.registerChecker<GenericTaintChecker>(); 11320b57cec5SDimitry Andric } 11330b57cec5SDimitry Andric 1134*0fca6ea1SDimitry Andric bool ento::shouldRegisterTaintPropagationChecker(const CheckerManager &mgr) { 1135*0fca6ea1SDimitry Andric return true; 1136*0fca6ea1SDimitry Andric } 1137*0fca6ea1SDimitry Andric 1138*0fca6ea1SDimitry Andric void ento::registerGenericTaintChecker(CheckerManager &Mgr) { 1139*0fca6ea1SDimitry Andric GenericTaintChecker *checker = Mgr.getChecker<GenericTaintChecker>(); 1140*0fca6ea1SDimitry Andric checker->isTaintReporterCheckerEnabled = true; 1141*0fca6ea1SDimitry Andric checker->BT.emplace(Mgr.getCurrentCheckerName(), "Use of Untrusted Data", 1142*0fca6ea1SDimitry Andric categories::TaintedData); 1143*0fca6ea1SDimitry Andric } 1144*0fca6ea1SDimitry Andric 11455ffd83dbSDimitry Andric bool ento::shouldRegisterGenericTaintChecker(const CheckerManager &mgr) { 11460b57cec5SDimitry Andric return true; 11470b57cec5SDimitry Andric } 1148