xref: /dpdk/drivers/net/virtio/virtio_user_ethdev.c (revision a720e6740afcd6d21955d188c6e6a7136fcc7d6c)
1 /* SPDX-License-Identifier: BSD-3-Clause
2  * Copyright(c) 2010-2016 Intel Corporation
3  */
4 
5 #include <stdint.h>
6 #include <sys/types.h>
7 #include <unistd.h>
8 #include <fcntl.h>
9 #include <sys/socket.h>
10 
11 #include <rte_malloc.h>
12 #include <rte_kvargs.h>
13 #include <rte_ethdev_vdev.h>
14 #include <rte_bus_vdev.h>
15 #include <rte_alarm.h>
16 
17 #include "virtio_ethdev.h"
18 #include "virtio_logs.h"
19 #include "virtio_pci.h"
20 #include "virtqueue.h"
21 #include "virtio_rxtx.h"
22 #include "virtio_user/virtio_user_dev.h"
23 
24 #define virtio_user_get_dev(hw) \
25 	((struct virtio_user_dev *)(hw)->virtio_user_dev)
26 
27 static int
28 virtio_user_server_reconnect(struct virtio_user_dev *dev)
29 {
30 	int ret;
31 	int connectfd;
32 	struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->port_id];
33 
34 	connectfd = accept(dev->listenfd, NULL, NULL);
35 	if (connectfd < 0)
36 		return -1;
37 
38 	dev->vhostfd = connectfd;
39 	if (dev->ops->send_request(dev, VHOST_USER_GET_FEATURES,
40 				   &dev->device_features) < 0) {
41 		PMD_INIT_LOG(ERR, "get_features failed: %s",
42 			     strerror(errno));
43 		return -1;
44 	}
45 
46 	dev->device_features |= dev->frontend_features;
47 
48 	/* umask vhost-user unsupported features */
49 	dev->device_features &= ~(dev->unsupported_features);
50 
51 	dev->features &= dev->device_features;
52 
53 	ret = virtio_user_start_device(dev);
54 	if (ret < 0)
55 		return -1;
56 
57 	if (dev->queue_pairs > 1) {
58 		ret = virtio_user_handle_mq(dev, dev->queue_pairs);
59 		if (ret != 0) {
60 			PMD_INIT_LOG(ERR, "Fails to enable multi-queue pairs!");
61 			return -1;
62 		}
63 	}
64 	if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {
65 		if (rte_intr_disable(eth_dev->intr_handle) < 0) {
66 			PMD_DRV_LOG(ERR, "interrupt disable failed");
67 			return -1;
68 		}
69 		rte_intr_callback_unregister(eth_dev->intr_handle,
70 					     virtio_interrupt_handler,
71 					     eth_dev);
72 		eth_dev->intr_handle->fd = connectfd;
73 		rte_intr_callback_register(eth_dev->intr_handle,
74 					   virtio_interrupt_handler, eth_dev);
75 
76 		if (rte_intr_enable(eth_dev->intr_handle) < 0) {
77 			PMD_DRV_LOG(ERR, "interrupt enable failed");
78 			return -1;
79 		}
80 	}
81 	PMD_INIT_LOG(NOTICE, "server mode virtio-user reconnection succeeds!");
82 	return 0;
83 }
84 
85 static void
86 virtio_user_delayed_handler(void *param)
87 {
88 	struct virtio_hw *hw = (struct virtio_hw *)param;
89 	struct rte_eth_dev *eth_dev = &rte_eth_devices[hw->port_id];
90 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
91 
92 	if (rte_intr_disable(eth_dev->intr_handle) < 0) {
93 		PMD_DRV_LOG(ERR, "interrupt disable failed");
94 		return;
95 	}
96 	rte_intr_callback_unregister(eth_dev->intr_handle,
97 				     virtio_interrupt_handler, eth_dev);
98 	if (dev->is_server) {
99 		if (dev->vhostfd >= 0) {
100 			close(dev->vhostfd);
101 			dev->vhostfd = -1;
102 		}
103 		eth_dev->intr_handle->fd = dev->listenfd;
104 		rte_intr_callback_register(eth_dev->intr_handle,
105 					   virtio_interrupt_handler, eth_dev);
106 		if (rte_intr_enable(eth_dev->intr_handle) < 0) {
107 			PMD_DRV_LOG(ERR, "interrupt enable failed");
108 			return;
109 		}
110 	}
111 }
112 
113 static void
114 virtio_user_read_dev_config(struct virtio_hw *hw, size_t offset,
115 		     void *dst, int length)
116 {
117 	int i;
118 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
119 
120 	if (offset == offsetof(struct virtio_net_config, mac) &&
121 	    length == ETHER_ADDR_LEN) {
122 		for (i = 0; i < ETHER_ADDR_LEN; ++i)
123 			((uint8_t *)dst)[i] = dev->mac_addr[i];
124 		return;
125 	}
126 
127 	if (offset == offsetof(struct virtio_net_config, status)) {
128 		char buf[128];
129 
130 		if (dev->vhostfd >= 0) {
131 			int r;
132 			int flags;
133 
134 			flags = fcntl(dev->vhostfd, F_GETFL);
135 			if (fcntl(dev->vhostfd, F_SETFL,
136 					flags | O_NONBLOCK) == -1) {
137 				PMD_DRV_LOG(ERR, "error setting O_NONBLOCK flag");
138 				return;
139 			}
140 			r = recv(dev->vhostfd, buf, 128, MSG_PEEK);
141 			if (r == 0 || (r < 0 && errno != EAGAIN)) {
142 				dev->status &= (~VIRTIO_NET_S_LINK_UP);
143 				PMD_DRV_LOG(ERR, "virtio-user port %u is down",
144 					    hw->port_id);
145 
146 				/* This function could be called in the process
147 				 * of interrupt handling, callback cannot be
148 				 * unregistered here, set an alarm to do it.
149 				 */
150 				rte_eal_alarm_set(1,
151 						  virtio_user_delayed_handler,
152 						  (void *)hw);
153 			} else {
154 				dev->status |= VIRTIO_NET_S_LINK_UP;
155 			}
156 			if (fcntl(dev->vhostfd, F_SETFL,
157 					flags & ~O_NONBLOCK) == -1) {
158 				PMD_DRV_LOG(ERR, "error clearing O_NONBLOCK flag");
159 				return;
160 			}
161 		} else if (dev->is_server) {
162 			dev->status &= (~VIRTIO_NET_S_LINK_UP);
163 			if (virtio_user_server_reconnect(dev) >= 0)
164 				dev->status |= VIRTIO_NET_S_LINK_UP;
165 		}
166 
167 		*(uint16_t *)dst = dev->status;
168 	}
169 
170 	if (offset == offsetof(struct virtio_net_config, max_virtqueue_pairs))
171 		*(uint16_t *)dst = dev->max_queue_pairs;
172 }
173 
174 static void
175 virtio_user_write_dev_config(struct virtio_hw *hw, size_t offset,
176 		      const void *src, int length)
177 {
178 	int i;
179 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
180 
181 	if ((offset == offsetof(struct virtio_net_config, mac)) &&
182 	    (length == ETHER_ADDR_LEN))
183 		for (i = 0; i < ETHER_ADDR_LEN; ++i)
184 			dev->mac_addr[i] = ((const uint8_t *)src)[i];
185 	else
186 		PMD_DRV_LOG(ERR, "not supported offset=%zu, len=%d",
187 			    offset, length);
188 }
189 
190 static void
191 virtio_user_reset(struct virtio_hw *hw)
192 {
193 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
194 
195 	if (dev->status & VIRTIO_CONFIG_STATUS_DRIVER_OK)
196 		virtio_user_stop_device(dev);
197 }
198 
199 static void
200 virtio_user_set_status(struct virtio_hw *hw, uint8_t status)
201 {
202 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
203 
204 	if (status & VIRTIO_CONFIG_STATUS_DRIVER_OK)
205 		virtio_user_start_device(dev);
206 	else if (status == VIRTIO_CONFIG_STATUS_RESET)
207 		virtio_user_reset(hw);
208 	dev->status = status;
209 }
210 
211 static uint8_t
212 virtio_user_get_status(struct virtio_hw *hw)
213 {
214 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
215 
216 	return dev->status;
217 }
218 
219 static uint64_t
220 virtio_user_get_features(struct virtio_hw *hw)
221 {
222 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
223 
224 	/* unmask feature bits defined in vhost user protocol */
225 	return dev->device_features & VIRTIO_PMD_SUPPORTED_GUEST_FEATURES;
226 }
227 
228 static void
229 virtio_user_set_features(struct virtio_hw *hw, uint64_t features)
230 {
231 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
232 
233 	dev->features = features & dev->device_features;
234 }
235 
236 static uint8_t
237 virtio_user_get_isr(struct virtio_hw *hw __rte_unused)
238 {
239 	/* rxq interrupts and config interrupt are separated in virtio-user,
240 	 * here we only report config change.
241 	 */
242 	return VIRTIO_PCI_ISR_CONFIG;
243 }
244 
245 static uint16_t
246 virtio_user_set_config_irq(struct virtio_hw *hw __rte_unused,
247 		    uint16_t vec __rte_unused)
248 {
249 	return 0;
250 }
251 
252 static uint16_t
253 virtio_user_set_queue_irq(struct virtio_hw *hw __rte_unused,
254 			  struct virtqueue *vq __rte_unused,
255 			  uint16_t vec)
256 {
257 	/* pretend we have done that */
258 	return vec;
259 }
260 
261 /* This function is to get the queue size, aka, number of descs, of a specified
262  * queue. Different with the VHOST_USER_GET_QUEUE_NUM, which is used to get the
263  * max supported queues.
264  */
265 static uint16_t
266 virtio_user_get_queue_num(struct virtio_hw *hw, uint16_t queue_id __rte_unused)
267 {
268 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
269 
270 	/* Currently, each queue has same queue size */
271 	return dev->queue_size;
272 }
273 
274 static void
275 virtio_user_setup_queue_packed(struct virtqueue *vq,
276 			       struct virtio_user_dev *dev)
277 {
278 	uint16_t queue_idx = vq->vq_queue_index;
279 	struct vring_packed *vring;
280 	uint64_t desc_addr;
281 	uint64_t avail_addr;
282 	uint64_t used_addr;
283 	uint16_t i;
284 
285 	vring  = &dev->packed_vrings[queue_idx];
286 	desc_addr = (uintptr_t)vq->vq_ring_virt_mem;
287 	avail_addr = desc_addr + vq->vq_nentries *
288 		sizeof(struct vring_packed_desc);
289 	used_addr = RTE_ALIGN_CEIL(avail_addr +
290 			   sizeof(struct vring_packed_desc_event),
291 			   VIRTIO_PCI_VRING_ALIGN);
292 	vring->num = vq->vq_nentries;
293 	vring->desc = (void *)(uintptr_t)desc_addr;
294 	vring->driver = (void *)(uintptr_t)avail_addr;
295 	vring->device = (void *)(uintptr_t)used_addr;
296 	dev->packed_queues[queue_idx].avail_wrap_counter = true;
297 	dev->packed_queues[queue_idx].used_wrap_counter = true;
298 
299 	for (i = 0; i < vring->num; i++)
300 		vring->desc[i].flags = 0;
301 }
302 
303 static void
304 virtio_user_setup_queue_split(struct virtqueue *vq, struct virtio_user_dev *dev)
305 {
306 	uint16_t queue_idx = vq->vq_queue_index;
307 	uint64_t desc_addr, avail_addr, used_addr;
308 
309 	desc_addr = (uintptr_t)vq->vq_ring_virt_mem;
310 	avail_addr = desc_addr + vq->vq_nentries * sizeof(struct vring_desc);
311 	used_addr = RTE_ALIGN_CEIL(avail_addr + offsetof(struct vring_avail,
312 							 ring[vq->vq_nentries]),
313 				   VIRTIO_PCI_VRING_ALIGN);
314 
315 	dev->vrings[queue_idx].num = vq->vq_nentries;
316 	dev->vrings[queue_idx].desc = (void *)(uintptr_t)desc_addr;
317 	dev->vrings[queue_idx].avail = (void *)(uintptr_t)avail_addr;
318 	dev->vrings[queue_idx].used = (void *)(uintptr_t)used_addr;
319 }
320 
321 static int
322 virtio_user_setup_queue(struct virtio_hw *hw, struct virtqueue *vq)
323 {
324 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
325 
326 	if (vtpci_packed_queue(hw))
327 		virtio_user_setup_queue_packed(vq, dev);
328 	else
329 		virtio_user_setup_queue_split(vq, dev);
330 
331 	return 0;
332 }
333 
334 static void
335 virtio_user_del_queue(struct virtio_hw *hw, struct virtqueue *vq)
336 {
337 	/* For legacy devices, write 0 to VIRTIO_PCI_QUEUE_PFN port, QEMU
338 	 * correspondingly stops the ioeventfds, and reset the status of
339 	 * the device.
340 	 * For modern devices, set queue desc, avail, used in PCI bar to 0,
341 	 * not see any more behavior in QEMU.
342 	 *
343 	 * Here we just care about what information to deliver to vhost-user
344 	 * or vhost-kernel. So we just close ioeventfd for now.
345 	 */
346 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
347 
348 	close(dev->callfds[vq->vq_queue_index]);
349 	close(dev->kickfds[vq->vq_queue_index]);
350 }
351 
352 static void
353 virtio_user_notify_queue(struct virtio_hw *hw, struct virtqueue *vq)
354 {
355 	uint64_t buf = 1;
356 	struct virtio_user_dev *dev = virtio_user_get_dev(hw);
357 
358 	if (hw->cvq && (hw->cvq->vq == vq)) {
359 		if (vtpci_packed_queue(vq->hw))
360 			virtio_user_handle_cq_packed(dev, vq->vq_queue_index);
361 		else
362 			virtio_user_handle_cq(dev, vq->vq_queue_index);
363 		return;
364 	}
365 
366 	if (write(dev->kickfds[vq->vq_queue_index], &buf, sizeof(buf)) < 0)
367 		PMD_DRV_LOG(ERR, "failed to kick backend: %s",
368 			    strerror(errno));
369 }
370 
371 const struct virtio_pci_ops virtio_user_ops = {
372 	.read_dev_cfg	= virtio_user_read_dev_config,
373 	.write_dev_cfg	= virtio_user_write_dev_config,
374 	.get_status	= virtio_user_get_status,
375 	.set_status	= virtio_user_set_status,
376 	.get_features	= virtio_user_get_features,
377 	.set_features	= virtio_user_set_features,
378 	.get_isr	= virtio_user_get_isr,
379 	.set_config_irq	= virtio_user_set_config_irq,
380 	.set_queue_irq	= virtio_user_set_queue_irq,
381 	.get_queue_num	= virtio_user_get_queue_num,
382 	.setup_queue	= virtio_user_setup_queue,
383 	.del_queue	= virtio_user_del_queue,
384 	.notify_queue	= virtio_user_notify_queue,
385 };
386 
387 static const char *valid_args[] = {
388 #define VIRTIO_USER_ARG_QUEUES_NUM     "queues"
389 	VIRTIO_USER_ARG_QUEUES_NUM,
390 #define VIRTIO_USER_ARG_CQ_NUM         "cq"
391 	VIRTIO_USER_ARG_CQ_NUM,
392 #define VIRTIO_USER_ARG_MAC            "mac"
393 	VIRTIO_USER_ARG_MAC,
394 #define VIRTIO_USER_ARG_PATH           "path"
395 	VIRTIO_USER_ARG_PATH,
396 #define VIRTIO_USER_ARG_QUEUE_SIZE     "queue_size"
397 	VIRTIO_USER_ARG_QUEUE_SIZE,
398 #define VIRTIO_USER_ARG_INTERFACE_NAME "iface"
399 	VIRTIO_USER_ARG_INTERFACE_NAME,
400 #define VIRTIO_USER_ARG_SERVER_MODE    "server"
401 	VIRTIO_USER_ARG_SERVER_MODE,
402 #define VIRTIO_USER_ARG_MRG_RXBUF      "mrg_rxbuf"
403 	VIRTIO_USER_ARG_MRG_RXBUF,
404 #define VIRTIO_USER_ARG_IN_ORDER       "in_order"
405 	VIRTIO_USER_ARG_IN_ORDER,
406 #define VIRTIO_USER_ARG_PACKED_VQ      "packed_vq"
407 	VIRTIO_USER_ARG_PACKED_VQ,
408 	NULL
409 };
410 
411 #define VIRTIO_USER_DEF_CQ_EN	0
412 #define VIRTIO_USER_DEF_Q_NUM	1
413 #define VIRTIO_USER_DEF_Q_SZ	256
414 #define VIRTIO_USER_DEF_SERVER_MODE	0
415 
416 static int
417 get_string_arg(const char *key __rte_unused,
418 	       const char *value, void *extra_args)
419 {
420 	if (!value || !extra_args)
421 		return -EINVAL;
422 
423 	*(char **)extra_args = strdup(value);
424 
425 	if (!*(char **)extra_args)
426 		return -ENOMEM;
427 
428 	return 0;
429 }
430 
431 static int
432 get_integer_arg(const char *key __rte_unused,
433 		const char *value, void *extra_args)
434 {
435 	if (!value || !extra_args)
436 		return -EINVAL;
437 
438 	*(uint64_t *)extra_args = strtoull(value, NULL, 0);
439 
440 	return 0;
441 }
442 
443 static struct rte_vdev_driver virtio_user_driver;
444 
445 static struct rte_eth_dev *
446 virtio_user_eth_dev_alloc(struct rte_vdev_device *vdev)
447 {
448 	struct rte_eth_dev *eth_dev;
449 	struct rte_eth_dev_data *data;
450 	struct virtio_hw *hw;
451 	struct virtio_user_dev *dev;
452 
453 	eth_dev = rte_eth_vdev_allocate(vdev, sizeof(*hw));
454 	if (!eth_dev) {
455 		PMD_INIT_LOG(ERR, "cannot alloc rte_eth_dev");
456 		return NULL;
457 	}
458 
459 	data = eth_dev->data;
460 	hw = eth_dev->data->dev_private;
461 
462 	dev = rte_zmalloc(NULL, sizeof(*dev), 0);
463 	if (!dev) {
464 		PMD_INIT_LOG(ERR, "malloc virtio_user_dev failed");
465 		rte_eth_dev_release_port(eth_dev);
466 		return NULL;
467 	}
468 
469 	hw->port_id = data->port_id;
470 	dev->port_id = data->port_id;
471 	virtio_hw_internal[hw->port_id].vtpci_ops = &virtio_user_ops;
472 	/*
473 	 * MSIX is required to enable LSC (see virtio_init_device).
474 	 * Here just pretend that we support msix.
475 	 */
476 	hw->use_msix = 1;
477 	hw->modern   = 0;
478 	hw->use_simple_rx = 0;
479 	hw->use_inorder_rx = 0;
480 	hw->use_inorder_tx = 0;
481 	hw->virtio_user_dev = dev;
482 	return eth_dev;
483 }
484 
485 static void
486 virtio_user_eth_dev_free(struct rte_eth_dev *eth_dev)
487 {
488 	struct rte_eth_dev_data *data = eth_dev->data;
489 	struct virtio_hw *hw = data->dev_private;
490 
491 	rte_free(hw->virtio_user_dev);
492 	rte_eth_dev_release_port(eth_dev);
493 }
494 
495 /* Dev initialization routine. Invoked once for each virtio vdev at
496  * EAL init time, see rte_bus_probe().
497  * Returns 0 on success.
498  */
499 static int
500 virtio_user_pmd_probe(struct rte_vdev_device *dev)
501 {
502 	struct rte_kvargs *kvlist = NULL;
503 	struct rte_eth_dev *eth_dev;
504 	struct virtio_hw *hw;
505 	uint64_t queues = VIRTIO_USER_DEF_Q_NUM;
506 	uint64_t cq = VIRTIO_USER_DEF_CQ_EN;
507 	uint64_t queue_size = VIRTIO_USER_DEF_Q_SZ;
508 	uint64_t server_mode = VIRTIO_USER_DEF_SERVER_MODE;
509 	uint64_t mrg_rxbuf = 1;
510 	uint64_t in_order = 1;
511 	uint64_t packed_vq = 0;
512 	char *path = NULL;
513 	char *ifname = NULL;
514 	char *mac_addr = NULL;
515 	int ret = -1;
516 
517 	kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_args);
518 	if (!kvlist) {
519 		PMD_INIT_LOG(ERR, "error when parsing param");
520 		goto end;
521 	}
522 
523 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) {
524 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_PATH,
525 				       &get_string_arg, &path) < 0) {
526 			PMD_INIT_LOG(ERR, "error to parse %s",
527 				     VIRTIO_USER_ARG_PATH);
528 			goto end;
529 		}
530 	} else {
531 		PMD_INIT_LOG(ERR, "arg %s is mandatory for virtio_user",
532 			     VIRTIO_USER_ARG_PATH);
533 		goto end;
534 	}
535 
536 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME) == 1) {
537 		if (is_vhost_user_by_type(path)) {
538 			PMD_INIT_LOG(ERR,
539 				"arg %s applies only to vhost-kernel backend",
540 				VIRTIO_USER_ARG_INTERFACE_NAME);
541 			goto end;
542 		}
543 
544 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME,
545 				       &get_string_arg, &ifname) < 0) {
546 			PMD_INIT_LOG(ERR, "error to parse %s",
547 				     VIRTIO_USER_ARG_INTERFACE_NAME);
548 			goto end;
549 		}
550 	}
551 
552 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_MAC) == 1) {
553 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_MAC,
554 				       &get_string_arg, &mac_addr) < 0) {
555 			PMD_INIT_LOG(ERR, "error to parse %s",
556 				     VIRTIO_USER_ARG_MAC);
557 			goto end;
558 		}
559 	}
560 
561 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_QUEUE_SIZE) == 1) {
562 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_QUEUE_SIZE,
563 				       &get_integer_arg, &queue_size) < 0) {
564 			PMD_INIT_LOG(ERR, "error to parse %s",
565 				     VIRTIO_USER_ARG_QUEUE_SIZE);
566 			goto end;
567 		}
568 	}
569 
570 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_QUEUES_NUM) == 1) {
571 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_QUEUES_NUM,
572 				       &get_integer_arg, &queues) < 0) {
573 			PMD_INIT_LOG(ERR, "error to parse %s",
574 				     VIRTIO_USER_ARG_QUEUES_NUM);
575 			goto end;
576 		}
577 	}
578 
579 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_SERVER_MODE) == 1) {
580 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_SERVER_MODE,
581 				       &get_integer_arg, &server_mode) < 0) {
582 			PMD_INIT_LOG(ERR, "error to parse %s",
583 				     VIRTIO_USER_ARG_SERVER_MODE);
584 			goto end;
585 		}
586 	}
587 
588 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
589 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
590 				       &get_integer_arg, &cq) < 0) {
591 			PMD_INIT_LOG(ERR, "error to parse %s",
592 				     VIRTIO_USER_ARG_CQ_NUM);
593 			goto end;
594 		}
595 	} else if (queues > 1) {
596 		cq = 1;
597 	}
598 
599 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PACKED_VQ) == 1) {
600 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_PACKED_VQ,
601 				       &get_integer_arg, &packed_vq) < 0) {
602 			PMD_INIT_LOG(ERR, "error to parse %s",
603 				     VIRTIO_USER_ARG_PACKED_VQ);
604 			goto end;
605 		}
606 	}
607 
608 	if (queues > 1 && cq == 0) {
609 		PMD_INIT_LOG(ERR, "multi-q requires ctrl-q");
610 		goto end;
611 	}
612 
613 	if (queues > VIRTIO_MAX_VIRTQUEUE_PAIRS) {
614 		PMD_INIT_LOG(ERR, "arg %s %" PRIu64 " exceeds the limit %u",
615 			VIRTIO_USER_ARG_QUEUES_NUM, queues,
616 			VIRTIO_MAX_VIRTQUEUE_PAIRS);
617 		goto end;
618 	}
619 
620 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_MRG_RXBUF) == 1) {
621 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_MRG_RXBUF,
622 				       &get_integer_arg, &mrg_rxbuf) < 0) {
623 			PMD_INIT_LOG(ERR, "error to parse %s",
624 				     VIRTIO_USER_ARG_MRG_RXBUF);
625 			goto end;
626 		}
627 	}
628 
629 	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_IN_ORDER) == 1) {
630 		if (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_IN_ORDER,
631 				       &get_integer_arg, &in_order) < 0) {
632 			PMD_INIT_LOG(ERR, "error to parse %s",
633 				     VIRTIO_USER_ARG_IN_ORDER);
634 			goto end;
635 		}
636 	}
637 
638 	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
639 		struct virtio_user_dev *vu_dev;
640 
641 		eth_dev = virtio_user_eth_dev_alloc(dev);
642 		if (!eth_dev) {
643 			PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");
644 			goto end;
645 		}
646 
647 		hw = eth_dev->data->dev_private;
648 		vu_dev = virtio_user_get_dev(hw);
649 		if (server_mode == 1)
650 			vu_dev->is_server = true;
651 		else
652 			vu_dev->is_server = false;
653 		if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,
654 				 queue_size, mac_addr, &ifname, mrg_rxbuf,
655 				 in_order, packed_vq) < 0) {
656 			PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");
657 			virtio_user_eth_dev_free(eth_dev);
658 			goto end;
659 		}
660 
661 	} else {
662 		eth_dev = rte_eth_dev_attach_secondary(rte_vdev_device_name(dev));
663 		if (!eth_dev)
664 			goto end;
665 	}
666 
667 	/* previously called by rte_pci_probe() for physical dev */
668 	if (eth_virtio_dev_init(eth_dev) < 0) {
669 		PMD_INIT_LOG(ERR, "eth_virtio_dev_init fails");
670 		virtio_user_eth_dev_free(eth_dev);
671 		goto end;
672 	}
673 
674 	rte_eth_dev_probing_finish(eth_dev);
675 	ret = 0;
676 
677 end:
678 	if (kvlist)
679 		rte_kvargs_free(kvlist);
680 	if (path)
681 		free(path);
682 	if (mac_addr)
683 		free(mac_addr);
684 	if (ifname)
685 		free(ifname);
686 	return ret;
687 }
688 
689 static int
690 virtio_user_pmd_remove(struct rte_vdev_device *vdev)
691 {
692 	const char *name;
693 	struct rte_eth_dev *eth_dev;
694 	struct virtio_hw *hw;
695 	struct virtio_user_dev *dev;
696 
697 	if (!vdev)
698 		return -EINVAL;
699 
700 	name = rte_vdev_device_name(vdev);
701 	PMD_DRV_LOG(INFO, "Un-Initializing %s", name);
702 	eth_dev = rte_eth_dev_allocated(name);
703 	if (!eth_dev)
704 		return -ENODEV;
705 
706 	/* make sure the device is stopped, queues freed */
707 	rte_eth_dev_close(eth_dev->data->port_id);
708 
709 	hw = eth_dev->data->dev_private;
710 	dev = hw->virtio_user_dev;
711 	virtio_user_dev_uninit(dev);
712 
713 	rte_eth_dev_release_port(eth_dev);
714 
715 	return 0;
716 }
717 
718 static struct rte_vdev_driver virtio_user_driver = {
719 	.probe = virtio_user_pmd_probe,
720 	.remove = virtio_user_pmd_remove,
721 };
722 
723 RTE_PMD_REGISTER_VDEV(net_virtio_user, virtio_user_driver);
724 RTE_PMD_REGISTER_ALIAS(net_virtio_user, virtio_user);
725 RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
726 	"path=<path> "
727 	"mac=<mac addr> "
728 	"cq=<int> "
729 	"queue_size=<int> "
730 	"queues=<int> "
731 	"iface=<string> "
732 	"server=<0|1> "
733 	"mrg_rxbuf=<0|1> "
734 	"in_order=<0|1> "
735 	"packed_vq=<0|1>");
736