1 /* $NetBSD: tmpfs_subr.c,v 1.35 2007/07/09 21:10:50 ad Exp $ */ 2 3 /*- 4 * Copyright (c) 2005 The NetBSD Foundation, Inc. 5 * All rights reserved. 6 * 7 * This code is derived from software contributed to The NetBSD Foundation 8 * by Julio M. Merino Vidal, developed as part of Google's Summer of Code 9 * 2005 program. 10 * 11 * Redistribution and use in source and binary forms, with or without 12 * modification, are permitted provided that the following conditions 13 * are met: 14 * 1. Redistributions of source code must retain the above copyright 15 * notice, this list of conditions and the following disclaimer. 16 * 2. Redistributions in binary form must reproduce the above copyright 17 * notice, this list of conditions and the following disclaimer in the 18 * documentation and/or other materials provided with the distribution. 19 * 20 * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS 21 * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED 22 * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 23 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS 24 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 25 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 26 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 27 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 28 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 29 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE 30 * POSSIBILITY OF SUCH DAMAGE. 31 */ 32 33 /* 34 * Efficient memory file system supporting functions. 35 */ 36 37 #include <sys/kernel.h> 38 #include <sys/param.h> 39 #include <sys/namei.h> 40 #include <sys/priv.h> 41 #include <sys/proc.h> 42 #include <sys/stat.h> 43 #include <sys/systm.h> 44 #include <sys/vnode.h> 45 #include <sys/vmmeter.h> 46 47 #include <vm/vm.h> 48 #include <vm/vm_object.h> 49 #include <vm/vm_page.h> 50 #include <vm/vm_pager.h> 51 #include <vm/vm_extern.h> 52 53 #include <vfs/tmpfs/tmpfs.h> 54 #include <vfs/tmpfs/tmpfs_vnops.h> 55 56 static ino_t tmpfs_fetch_ino(struct tmpfs_mount *); 57 58 static int tmpfs_dirtree_compare(struct tmpfs_dirent *a, 59 struct tmpfs_dirent *b); 60 RB_GENERATE(tmpfs_dirtree, tmpfs_dirent, rb_node, tmpfs_dirtree_compare); 61 62 static int tmpfs_dirtree_compare_cookie(struct tmpfs_dirent *a, 63 struct tmpfs_dirent *b); 64 RB_GENERATE(tmpfs_dirtree_cookie, tmpfs_dirent, 65 rb_cookienode, tmpfs_dirtree_compare_cookie); 66 67 68 /* --------------------------------------------------------------------- */ 69 70 /* 71 * Allocates a new node of type 'type' inside the 'tmp' mount point, with 72 * its owner set to 'uid', its group to 'gid' and its mode set to 'mode', 73 * using the credentials of the process 'p'. 74 * 75 * If the node type is set to 'VDIR', then the parent parameter must point 76 * to the parent directory of the node being created. It may only be NULL 77 * while allocating the root node. 78 * 79 * If the node type is set to 'VBLK' or 'VCHR', then the rdev parameter 80 * specifies the device the node represents. 81 * 82 * If the node type is set to 'VLNK', then the parameter target specifies 83 * the file name of the target file for the symbolic link that is being 84 * created. 85 * 86 * Note that new nodes are retrieved from the available list if it has 87 * items or, if it is empty, from the node pool as long as there is enough 88 * space to create them. 89 * 90 * Returns zero on success or an appropriate error code on failure. 91 */ 92 int 93 tmpfs_alloc_node(struct tmpfs_mount *tmp, enum vtype type, 94 uid_t uid, gid_t gid, mode_t mode, 95 char *target, int rmajor, int rminor, 96 struct tmpfs_node **node) 97 { 98 struct tmpfs_node *nnode; 99 struct timespec ts; 100 udev_t rdev; 101 102 KKASSERT(IFF(type == VLNK, target != NULL)); 103 KKASSERT(IFF(type == VBLK || type == VCHR, rmajor != VNOVAL)); 104 105 if (tmp->tm_nodes_inuse >= tmp->tm_nodes_max) 106 return (ENOSPC); 107 108 nnode = objcache_get(tmp->tm_node_pool, M_WAITOK | M_NULLOK); 109 if (nnode == NULL) 110 return (ENOSPC); 111 112 /* Generic initialization. */ 113 nnode->tn_type = type; 114 vfs_timestamp(&ts); 115 nnode->tn_ctime = nnode->tn_mtime = nnode->tn_atime 116 = ts.tv_sec; 117 nnode->tn_ctimensec = nnode->tn_mtimensec = nnode->tn_atimensec 118 = ts.tv_nsec; 119 nnode->tn_uid = uid; 120 nnode->tn_gid = gid; 121 nnode->tn_mode = mode; 122 nnode->tn_id = tmpfs_fetch_ino(tmp); 123 nnode->tn_advlock.init_done = 0; 124 KKASSERT(nnode->tn_links == 0); 125 126 /* Type-specific initialization. */ 127 switch (nnode->tn_type) { 128 case VBLK: 129 case VCHR: 130 rdev = makeudev(rmajor, rminor); 131 if (rdev == NOUDEV) { 132 objcache_put(tmp->tm_node_pool, nnode); 133 return(EINVAL); 134 } 135 nnode->tn_rdev = rdev; 136 break; 137 138 case VDIR: 139 RB_INIT(&nnode->tn_dir.tn_dirtree); 140 RB_INIT(&nnode->tn_dir.tn_cookietree); 141 nnode->tn_size = 0; 142 break; 143 144 case VFIFO: 145 /* FALLTHROUGH */ 146 case VSOCK: 147 break; 148 149 case VLNK: 150 nnode->tn_size = strlen(target); 151 nnode->tn_link = kmalloc(nnode->tn_size + 1, tmp->tm_name_zone, 152 M_WAITOK | M_NULLOK); 153 if (nnode->tn_link == NULL) { 154 objcache_put(tmp->tm_node_pool, nnode); 155 return (ENOSPC); 156 } 157 bcopy(target, nnode->tn_link, nnode->tn_size); 158 nnode->tn_link[nnode->tn_size] = '\0'; 159 break; 160 161 case VREG: 162 nnode->tn_reg.tn_aobj = 163 swap_pager_alloc(NULL, 0, VM_PROT_DEFAULT, 0); 164 nnode->tn_reg.tn_aobj_pages = 0; 165 nnode->tn_size = 0; 166 break; 167 168 default: 169 panic("tmpfs_alloc_node: type %p %d", nnode, (int)nnode->tn_type); 170 } 171 172 TMPFS_NODE_LOCK(nnode); 173 TMPFS_LOCK(tmp); 174 LIST_INSERT_HEAD(&tmp->tm_nodes_used, nnode, tn_entries); 175 tmp->tm_nodes_inuse++; 176 TMPFS_UNLOCK(tmp); 177 TMPFS_NODE_UNLOCK(nnode); 178 179 *node = nnode; 180 return 0; 181 } 182 183 /* --------------------------------------------------------------------- */ 184 185 /* 186 * Destroys the node pointed to by node from the file system 'tmp'. 187 * If the node does not belong to the given mount point, the results are 188 * unpredicted. 189 * 190 * If the node references a directory; no entries are allowed because 191 * their removal could need a recursive algorithm, something forbidden in 192 * kernel space. Furthermore, there is not need to provide such 193 * functionality (recursive removal) because the only primitives offered 194 * to the user are the removal of empty directories and the deletion of 195 * individual files. 196 * 197 * Note that nodes are not really deleted; in fact, when a node has been 198 * allocated, it cannot be deleted during the whole life of the file 199 * system. Instead, they are moved to the available list and remain there 200 * until reused. 201 * 202 * A caller must have TMPFS_NODE_LOCK(node) and this function unlocks it. 203 */ 204 void 205 tmpfs_free_node(struct tmpfs_mount *tmp, struct tmpfs_node *node) 206 { 207 vm_pindex_t pages = 0; 208 209 #ifdef INVARIANTS 210 TMPFS_ASSERT_ELOCKED(node); 211 KKASSERT(node->tn_vnode == NULL); 212 KKASSERT((node->tn_vpstate & TMPFS_VNODE_ALLOCATING) == 0); 213 #endif 214 215 TMPFS_LOCK(tmp); 216 LIST_REMOVE(node, tn_entries); 217 tmp->tm_nodes_inuse--; 218 TMPFS_UNLOCK(tmp); 219 TMPFS_NODE_UNLOCK(node); /* Caller has this lock */ 220 221 switch (node->tn_type) { 222 case VNON: 223 /* Do not do anything. VNON is provided to let the 224 * allocation routine clean itself easily by avoiding 225 * duplicating code in it. */ 226 /* FALLTHROUGH */ 227 case VBLK: 228 /* FALLTHROUGH */ 229 case VCHR: 230 /* FALLTHROUGH */ 231 break; 232 case VDIR: 233 /* 234 * The parent link can be NULL if this is the root 235 * node or if it is a directory node that was rmdir'd. 236 * 237 * XXX what if node is a directory which still contains 238 * directory entries (e.g. due to a forced umount) ? 239 */ 240 node->tn_size = 0; 241 KKASSERT(node->tn_dir.tn_parent == NULL); 242 243 /* 244 * If the root node is being destroyed don't leave a 245 * dangling pointer in tmpfs_mount. 246 */ 247 if (node == tmp->tm_root) 248 tmp->tm_root = NULL; 249 break; 250 case VFIFO: 251 /* FALLTHROUGH */ 252 case VSOCK: 253 break; 254 255 case VLNK: 256 kfree(node->tn_link, tmp->tm_name_zone); 257 node->tn_link = NULL; 258 node->tn_size = 0; 259 break; 260 261 case VREG: 262 if (node->tn_reg.tn_aobj != NULL) 263 vm_object_deallocate(node->tn_reg.tn_aobj); 264 node->tn_reg.tn_aobj = NULL; 265 pages = node->tn_reg.tn_aobj_pages; 266 break; 267 268 default: 269 panic("tmpfs_free_node: type %p %d", node, (int)node->tn_type); 270 } 271 272 /* 273 * Clean up fields for the next allocation. The objcache only ctors 274 * new allocations. 275 */ 276 tmpfs_node_ctor(node, NULL, 0); 277 objcache_put(tmp->tm_node_pool, node); 278 /* node is now invalid */ 279 280 TMPFS_LOCK(tmp); 281 tmp->tm_pages_used -= pages; 282 TMPFS_UNLOCK(tmp); 283 } 284 285 /* --------------------------------------------------------------------- */ 286 287 /* 288 * Allocates a new directory entry for the node node with a name of name. 289 * The new directory entry is returned in *de. 290 * 291 * The link count of node is increased by one to reflect the new object 292 * referencing it. 293 * 294 * Returns zero on success or an appropriate error code on failure. 295 */ 296 int 297 tmpfs_alloc_dirent(struct tmpfs_mount *tmp, struct tmpfs_node *node, 298 const char *name, uint16_t len, struct tmpfs_dirent **de) 299 { 300 struct tmpfs_dirent *nde; 301 302 nde = objcache_get(tmp->tm_dirent_pool, M_WAITOK); 303 nde->td_name = kmalloc(len + 1, tmp->tm_name_zone, M_WAITOK | M_NULLOK); 304 if (nde->td_name == NULL) { 305 objcache_put(tmp->tm_dirent_pool, nde); 306 *de = NULL; 307 return (ENOSPC); 308 } 309 nde->td_namelen = len; 310 bcopy(name, nde->td_name, len); 311 nde->td_name[len] = '\0'; 312 313 nde->td_node = node; 314 315 TMPFS_NODE_LOCK(node); 316 ++node->tn_links; 317 TMPFS_NODE_UNLOCK(node); 318 319 *de = nde; 320 321 return 0; 322 } 323 324 /* --------------------------------------------------------------------- */ 325 326 /* 327 * Frees a directory entry. It is the caller's responsibility to destroy 328 * the node referenced by it if needed. 329 * 330 * The link count of node is decreased by one to reflect the removal of an 331 * object that referenced it. This only happens if 'node_exists' is true; 332 * otherwise the function will not access the node referred to by the 333 * directory entry, as it may already have been released from the outside. 334 */ 335 void 336 tmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de) 337 { 338 struct tmpfs_node *node; 339 340 node = de->td_node; 341 342 TMPFS_NODE_LOCK(node); 343 TMPFS_ASSERT_ELOCKED(node); 344 KKASSERT(node->tn_links > 0); 345 node->tn_links--; 346 TMPFS_NODE_UNLOCK(node); 347 348 kfree(de->td_name, tmp->tm_name_zone); 349 de->td_namelen = 0; 350 de->td_name = NULL; 351 de->td_node = NULL; 352 objcache_put(tmp->tm_dirent_pool, de); 353 } 354 355 /* --------------------------------------------------------------------- */ 356 357 /* 358 * Allocates a new vnode for the node node or returns a new reference to 359 * an existing one if the node had already a vnode referencing it. The 360 * resulting locked vnode is returned in *vpp. 361 * 362 * Returns zero on success or an appropriate error code on failure. 363 */ 364 int 365 tmpfs_alloc_vp(struct mount *mp, struct tmpfs_node *node, int lkflag, 366 struct vnode **vpp) 367 { 368 int error = 0; 369 struct vnode *vp; 370 371 loop: 372 /* 373 * Interlocked extraction from node. This can race many things. 374 * We have to get a soft reference on the vnode while we hold 375 * the node locked, then acquire it properly and check for races. 376 */ 377 TMPFS_NODE_LOCK(node); 378 if ((vp = node->tn_vnode) != NULL) { 379 KKASSERT((node->tn_vpstate & TMPFS_VNODE_DOOMED) == 0); 380 vhold(vp); 381 TMPFS_NODE_UNLOCK(node); 382 383 if (vget(vp, lkflag | LK_EXCLUSIVE) != 0) { 384 vdrop(vp); 385 goto loop; 386 } 387 if (node->tn_vnode != vp) { 388 vput(vp); 389 vdrop(vp); 390 goto loop; 391 } 392 vdrop(vp); 393 goto out; 394 } 395 /* vp is NULL */ 396 397 /* 398 * This should never happen. 399 */ 400 if (node->tn_vpstate & TMPFS_VNODE_DOOMED) { 401 TMPFS_NODE_UNLOCK(node); 402 error = ENOENT; 403 goto out; 404 } 405 406 /* 407 * Interlock against other calls to tmpfs_alloc_vp() trying to 408 * allocate and assign a vp to node. 409 */ 410 if (node->tn_vpstate & TMPFS_VNODE_ALLOCATING) { 411 node->tn_vpstate |= TMPFS_VNODE_WANT; 412 error = tsleep(&node->tn_vpstate, PINTERLOCKED | PCATCH, 413 "tmpfs_alloc_vp", 0); 414 TMPFS_NODE_UNLOCK(node); 415 if (error) 416 return error; 417 goto loop; 418 } 419 node->tn_vpstate |= TMPFS_VNODE_ALLOCATING; 420 TMPFS_NODE_UNLOCK(node); 421 422 /* 423 * Allocate a new vnode (may block). The ALLOCATING flag should 424 * prevent a race against someone else assigning node->tn_vnode. 425 */ 426 error = getnewvnode(VT_TMPFS, mp, &vp, VLKTIMEOUT, LK_CANRECURSE); 427 if (error != 0) 428 goto unlock; 429 430 KKASSERT(node->tn_vnode == NULL); 431 KKASSERT(vp != NULL); 432 vp->v_data = node; 433 vp->v_type = node->tn_type; 434 435 /* Type-specific initialization. */ 436 switch (node->tn_type) { 437 case VBLK: 438 /* FALLTHROUGH */ 439 case VCHR: 440 /* FALLTHROUGH */ 441 case VSOCK: 442 break; 443 case VREG: 444 vinitvmio(vp, node->tn_size, TMPFS_BLKMASK, -1); 445 break; 446 case VLNK: 447 break; 448 case VFIFO: 449 vp->v_ops = &mp->mnt_vn_fifo_ops; 450 break; 451 case VDIR: 452 break; 453 454 default: 455 panic("tmpfs_alloc_vp: type %p %d", node, (int)node->tn_type); 456 } 457 458 459 unlock: 460 TMPFS_NODE_LOCK(node); 461 462 KKASSERT(node->tn_vpstate & TMPFS_VNODE_ALLOCATING); 463 node->tn_vpstate &= ~TMPFS_VNODE_ALLOCATING; 464 node->tn_vnode = vp; 465 466 if (node->tn_vpstate & TMPFS_VNODE_WANT) { 467 node->tn_vpstate &= ~TMPFS_VNODE_WANT; 468 TMPFS_NODE_UNLOCK(node); 469 wakeup(&node->tn_vpstate); 470 } else { 471 TMPFS_NODE_UNLOCK(node); 472 } 473 474 out: 475 *vpp = vp; 476 477 KKASSERT(IFF(error == 0, *vpp != NULL && vn_islocked(*vpp))); 478 #ifdef INVARIANTS 479 TMPFS_NODE_LOCK(node); 480 KKASSERT(*vpp == node->tn_vnode); 481 TMPFS_NODE_UNLOCK(node); 482 #endif 483 484 return error; 485 } 486 487 /* --------------------------------------------------------------------- */ 488 489 /* 490 * Destroys the association between the vnode vp and the node it 491 * references. 492 */ 493 void 494 tmpfs_free_vp(struct vnode *vp) 495 { 496 struct tmpfs_node *node; 497 498 node = VP_TO_TMPFS_NODE(vp); 499 500 TMPFS_NODE_LOCK(node); 501 KKASSERT(lockcount(TMPFS_NODE_MTX(node)) > 0); 502 node->tn_vnode = NULL; 503 vp->v_data = NULL; 504 TMPFS_NODE_UNLOCK(node); 505 } 506 507 /* --------------------------------------------------------------------- */ 508 509 /* 510 * Allocates a new file of type 'type' and adds it to the parent directory 511 * 'dvp'; this addition is done using the component name given in 'cnp'. 512 * The ownership of the new file is automatically assigned based on the 513 * credentials of the caller (through 'cnp'), the group is set based on 514 * the parent directory and the mode is determined from the 'vap' argument. 515 * If successful, *vpp holds a vnode to the newly created file and zero 516 * is returned. Otherwise *vpp is NULL and the function returns an 517 * appropriate error code. 518 */ 519 int 520 tmpfs_alloc_file(struct vnode *dvp, struct vnode **vpp, struct vattr *vap, 521 struct namecache *ncp, struct ucred *cred, char *target) 522 { 523 int error; 524 struct tmpfs_dirent *de; 525 struct tmpfs_mount *tmp; 526 struct tmpfs_node *dnode; 527 struct tmpfs_node *node; 528 529 tmp = VFS_TO_TMPFS(dvp->v_mount); 530 dnode = VP_TO_TMPFS_DIR(dvp); 531 *vpp = NULL; 532 533 /* 534 * If the directory was removed but a process was CD'd into it, 535 * we do not allow any more file/dir creation within it. Otherwise 536 * we will lose track of it. 537 */ 538 KKASSERT(dnode->tn_type == VDIR); 539 if (dnode != tmp->tm_root && dnode->tn_dir.tn_parent == NULL) 540 return ENOENT; 541 542 /* 543 * Make sure the link count does not overflow. 544 */ 545 if (vap->va_type == VDIR && dnode->tn_links >= LINK_MAX) 546 return EMLINK; 547 548 /* Allocate a node that represents the new file. */ 549 error = tmpfs_alloc_node(tmp, vap->va_type, cred->cr_uid, 550 dnode->tn_gid, vap->va_mode, target, 551 vap->va_rmajor, vap->va_rminor, &node); 552 if (error != 0) 553 return error; 554 TMPFS_NODE_LOCK(node); 555 556 /* Allocate a directory entry that points to the new file. */ 557 error = tmpfs_alloc_dirent(tmp, node, ncp->nc_name, ncp->nc_nlen, &de); 558 if (error != 0) { 559 tmpfs_free_node(tmp, node); 560 /* eats node lock */ 561 return error; 562 } 563 564 /* Allocate a vnode for the new file. */ 565 error = tmpfs_alloc_vp(dvp->v_mount, node, LK_EXCLUSIVE, vpp); 566 if (error != 0) { 567 tmpfs_free_dirent(tmp, de); 568 tmpfs_free_node(tmp, node); 569 /* eats node lock */ 570 return error; 571 } 572 573 /* 574 * Now that all required items are allocated, we can proceed to 575 * insert the new node into the directory, an operation that 576 * cannot fail. 577 */ 578 tmpfs_dir_attach(dnode, de); 579 TMPFS_NODE_UNLOCK(node); 580 581 return error; 582 } 583 584 /* --------------------------------------------------------------------- */ 585 586 /* 587 * Attaches the directory entry de to the directory represented by dnode. 588 * Note that this does not change the link count of the node pointed by 589 * the directory entry, as this is done by tmpfs_alloc_dirent. 590 */ 591 void 592 tmpfs_dir_attach(struct tmpfs_node *dnode, struct tmpfs_dirent *de) 593 { 594 struct tmpfs_node *node = de->td_node; 595 596 TMPFS_NODE_LOCK(dnode); 597 if (node && node->tn_type == VDIR) { 598 TMPFS_NODE_LOCK(node); 599 ++node->tn_links; 600 node->tn_status |= TMPFS_NODE_CHANGED; 601 node->tn_dir.tn_parent = dnode; 602 ++dnode->tn_links; 603 TMPFS_NODE_UNLOCK(node); 604 } 605 RB_INSERT(tmpfs_dirtree, &dnode->tn_dir.tn_dirtree, de); 606 RB_INSERT(tmpfs_dirtree_cookie, &dnode->tn_dir.tn_cookietree, de); 607 dnode->tn_size += sizeof(struct tmpfs_dirent); 608 dnode->tn_status |= TMPFS_NODE_ACCESSED | TMPFS_NODE_CHANGED | 609 TMPFS_NODE_MODIFIED; 610 TMPFS_NODE_UNLOCK(dnode); 611 } 612 613 /* --------------------------------------------------------------------- */ 614 615 /* 616 * Detaches the directory entry de from the directory represented by dnode. 617 * Note that this does not change the link count of the node pointed by 618 * the directory entry, as this is done by tmpfs_free_dirent. 619 */ 620 void 621 tmpfs_dir_detach(struct tmpfs_node *dnode, struct tmpfs_dirent *de) 622 { 623 struct tmpfs_node *node = de->td_node; 624 625 TMPFS_NODE_LOCK(dnode); 626 RB_REMOVE(tmpfs_dirtree, &dnode->tn_dir.tn_dirtree, de); 627 RB_REMOVE(tmpfs_dirtree_cookie, &dnode->tn_dir.tn_cookietree, de); 628 dnode->tn_size -= sizeof(struct tmpfs_dirent); 629 dnode->tn_status |= TMPFS_NODE_ACCESSED | TMPFS_NODE_CHANGED | 630 TMPFS_NODE_MODIFIED; 631 TMPFS_NODE_UNLOCK(dnode); 632 633 /* 634 * Clean out the tn_parent pointer immediately when removing a 635 * directory. 636 * 637 * Removal of the parent linkage also cleans out the extra tn_links 638 * count we had on both node and dnode. 639 * 640 * node can be NULL (typ during a forced umount), in which case 641 * the mount code is dealing with the linkages from a linked list 642 * scan. 643 */ 644 if (node && node->tn_type == VDIR && node->tn_dir.tn_parent) { 645 TMPFS_NODE_LOCK(dnode); 646 TMPFS_NODE_LOCK(node); 647 KKASSERT(node->tn_dir.tn_parent == dnode); 648 dnode->tn_links--; 649 node->tn_links--; 650 node->tn_dir.tn_parent = NULL; 651 TMPFS_NODE_UNLOCK(node); 652 TMPFS_NODE_UNLOCK(dnode); 653 } 654 } 655 656 /* --------------------------------------------------------------------- */ 657 658 /* 659 * Looks for a directory entry in the directory represented by node. 660 * 'ncp' describes the name of the entry to look for. Note that the . 661 * and .. components are not allowed as they do not physically exist 662 * within directories. 663 * 664 * Returns a pointer to the entry when found, otherwise NULL. 665 * 666 * Caller must hold the node locked (shared ok) 667 */ 668 struct tmpfs_dirent * 669 tmpfs_dir_lookup(struct tmpfs_node *node, struct tmpfs_node *f, 670 struct namecache *ncp) 671 { 672 struct tmpfs_dirent *de; 673 int len = ncp->nc_nlen; 674 struct tmpfs_dirent wanted; 675 676 wanted.td_namelen = len; 677 wanted.td_name = ncp->nc_name; 678 679 TMPFS_VALIDATE_DIR(node); 680 681 de = RB_FIND(tmpfs_dirtree, &node->tn_dir.tn_dirtree, &wanted); 682 683 KKASSERT(f == NULL || f == de->td_node); 684 685 return de; 686 } 687 688 /* --------------------------------------------------------------------- */ 689 690 /* 691 * Helper function for tmpfs_readdir. Creates a '.' entry for the given 692 * directory and returns it in the uio space. The function returns 0 693 * on success, -1 if there was not enough space in the uio structure to 694 * hold the directory entry or an appropriate error code if another 695 * error happens. 696 */ 697 int 698 tmpfs_dir_getdotdent(struct tmpfs_node *node, struct uio *uio) 699 { 700 int error; 701 struct dirent dent; 702 int dirsize; 703 704 TMPFS_VALIDATE_DIR(node); 705 KKASSERT(uio->uio_offset == TMPFS_DIRCOOKIE_DOT); 706 707 dent.d_ino = node->tn_id; 708 dent.d_type = DT_DIR; 709 dent.d_namlen = 1; 710 dent.d_name[0] = '.'; 711 dent.d_name[1] = '\0'; 712 dirsize = _DIRENT_DIRSIZ(&dent); 713 714 if (dirsize > uio->uio_resid) 715 error = -1; 716 else { 717 error = uiomove((caddr_t)&dent, dirsize, uio); 718 if (error == 0) 719 uio->uio_offset = TMPFS_DIRCOOKIE_DOTDOT; 720 } 721 return error; 722 } 723 724 /* --------------------------------------------------------------------- */ 725 726 /* 727 * Helper function for tmpfs_readdir. Creates a '..' entry for the given 728 * directory and returns it in the uio space. The function returns 0 729 * on success, -1 if there was not enough space in the uio structure to 730 * hold the directory entry or an appropriate error code if another 731 * error happens. 732 */ 733 int 734 tmpfs_dir_getdotdotdent(struct tmpfs_mount *tmp, struct tmpfs_node *node, 735 struct uio *uio) 736 { 737 int error; 738 struct dirent dent; 739 int dirsize; 740 741 TMPFS_VALIDATE_DIR(node); 742 KKASSERT(uio->uio_offset == TMPFS_DIRCOOKIE_DOTDOT); 743 744 if (node->tn_dir.tn_parent) { 745 TMPFS_NODE_LOCK(node); 746 if (node->tn_dir.tn_parent) 747 dent.d_ino = node->tn_dir.tn_parent->tn_id; 748 else 749 dent.d_ino = tmp->tm_root->tn_id; 750 TMPFS_NODE_UNLOCK(node); 751 } else { 752 dent.d_ino = tmp->tm_root->tn_id; 753 } 754 755 dent.d_type = DT_DIR; 756 dent.d_namlen = 2; 757 dent.d_name[0] = '.'; 758 dent.d_name[1] = '.'; 759 dent.d_name[2] = '\0'; 760 dirsize = _DIRENT_DIRSIZ(&dent); 761 762 if (dirsize > uio->uio_resid) 763 error = -1; 764 else { 765 error = uiomove((caddr_t)&dent, dirsize, uio); 766 if (error == 0) { 767 struct tmpfs_dirent *de; 768 769 de = RB_MIN(tmpfs_dirtree_cookie, 770 &node->tn_dir.tn_cookietree); 771 if (de == NULL) 772 uio->uio_offset = TMPFS_DIRCOOKIE_EOF; 773 else 774 uio->uio_offset = tmpfs_dircookie(de); 775 } 776 } 777 return error; 778 } 779 780 /* --------------------------------------------------------------------- */ 781 782 /* 783 * Lookup a directory entry by its associated cookie. 784 * 785 * Must be called with the directory node locked (shared ok) 786 */ 787 struct lubycookie_info { 788 off_t cookie; 789 struct tmpfs_dirent *de; 790 }; 791 792 static int 793 lubycookie_cmp(struct tmpfs_dirent *de, void *arg) 794 { 795 struct lubycookie_info *info = arg; 796 off_t cookie = tmpfs_dircookie(de); 797 798 if (cookie < info->cookie) 799 return(-1); 800 if (cookie > info->cookie) 801 return(1); 802 return(0); 803 } 804 805 static int 806 lubycookie_callback(struct tmpfs_dirent *de, void *arg) 807 { 808 struct lubycookie_info *info = arg; 809 810 if (tmpfs_dircookie(de) == info->cookie) { 811 info->de = de; 812 return(-1); 813 } 814 return(0); 815 } 816 817 struct tmpfs_dirent * 818 tmpfs_dir_lookupbycookie(struct tmpfs_node *node, off_t cookie) 819 { 820 struct lubycookie_info info; 821 822 info.cookie = cookie; 823 info.de = NULL; 824 RB_SCAN(tmpfs_dirtree_cookie, &node->tn_dir.tn_cookietree, 825 lubycookie_cmp, lubycookie_callback, &info); 826 return (info.de); 827 } 828 829 /* --------------------------------------------------------------------- */ 830 831 /* 832 * Helper function for tmpfs_readdir. Returns as much directory entries 833 * as can fit in the uio space. The read starts at uio->uio_offset. 834 * The function returns 0 on success, -1 if there was not enough space 835 * in the uio structure to hold the directory entry or an appropriate 836 * error code if another error happens. 837 * 838 * Caller must hold the node locked (shared ok) 839 */ 840 int 841 tmpfs_dir_getdents(struct tmpfs_node *node, struct uio *uio, off_t *cntp) 842 { 843 int error; 844 off_t startcookie; 845 struct tmpfs_dirent *de; 846 847 TMPFS_VALIDATE_DIR(node); 848 849 /* 850 * Locate the first directory entry we have to return. We have cached 851 * the last readdir in the node, so use those values if appropriate. 852 * Otherwise do a linear scan to find the requested entry. 853 */ 854 startcookie = uio->uio_offset; 855 KKASSERT(startcookie != TMPFS_DIRCOOKIE_DOT); 856 KKASSERT(startcookie != TMPFS_DIRCOOKIE_DOTDOT); 857 858 if (startcookie == TMPFS_DIRCOOKIE_EOF) 859 return 0; 860 861 de = tmpfs_dir_lookupbycookie(node, startcookie); 862 if (de == NULL) 863 return EINVAL; 864 865 /* 866 * Read as much entries as possible; i.e., until we reach the end of 867 * the directory or we exhaust uio space. 868 */ 869 do { 870 struct dirent d; 871 int reclen; 872 873 /* Create a dirent structure representing the current 874 * tmpfs_node and fill it. */ 875 d.d_ino = de->td_node->tn_id; 876 switch (de->td_node->tn_type) { 877 case VBLK: 878 d.d_type = DT_BLK; 879 break; 880 881 case VCHR: 882 d.d_type = DT_CHR; 883 break; 884 885 case VDIR: 886 d.d_type = DT_DIR; 887 break; 888 889 case VFIFO: 890 d.d_type = DT_FIFO; 891 break; 892 893 case VLNK: 894 d.d_type = DT_LNK; 895 break; 896 897 case VREG: 898 d.d_type = DT_REG; 899 break; 900 901 case VSOCK: 902 d.d_type = DT_SOCK; 903 break; 904 905 default: 906 panic("tmpfs_dir_getdents: type %p %d", 907 de->td_node, (int)de->td_node->tn_type); 908 } 909 d.d_namlen = de->td_namelen; 910 KKASSERT(de->td_namelen < sizeof(d.d_name)); 911 bcopy(de->td_name, d.d_name, d.d_namlen); 912 d.d_name[d.d_namlen] = '\0'; 913 reclen = _DIRENT_RECLEN(d.d_namlen); 914 915 /* Stop reading if the directory entry we are treating is 916 * bigger than the amount of data that can be returned. */ 917 if (reclen > uio->uio_resid) { 918 error = -1; 919 break; 920 } 921 922 /* Copy the new dirent structure into the output buffer and 923 * advance pointers. */ 924 error = uiomove((caddr_t)&d, reclen, uio); 925 926 (*cntp)++; 927 de = RB_NEXT(tmpfs_dirtree_cookie, 928 node->tn_dir.tn_cookietree, de); 929 } while (error == 0 && uio->uio_resid > 0 && de != NULL); 930 931 /* Update the offset and cache. */ 932 if (de == NULL) { 933 uio->uio_offset = TMPFS_DIRCOOKIE_EOF; 934 } else { 935 uio->uio_offset = tmpfs_dircookie(de); 936 } 937 938 return error; 939 } 940 941 /* --------------------------------------------------------------------- */ 942 943 /* 944 * Resizes the aobj associated to the regular file pointed to by vp to 945 * the size newsize. 'vp' must point to a vnode that represents a regular 946 * file. 'newsize' must be positive. 947 * 948 * pass trivial as 1 when buf content will be overwritten, otherwise set 0 949 * to be zero filled. 950 * 951 * Returns zero on success or an appropriate error code on failure. 952 */ 953 int 954 tmpfs_reg_resize(struct vnode *vp, off_t newsize, int trivial) 955 { 956 int error; 957 vm_pindex_t newpages, oldpages; 958 struct tmpfs_mount *tmp; 959 struct tmpfs_node *node; 960 off_t oldsize; 961 962 #ifdef INVARIANTS 963 KKASSERT(vp->v_type == VREG); 964 KKASSERT(newsize >= 0); 965 #endif 966 967 node = VP_TO_TMPFS_NODE(vp); 968 tmp = VFS_TO_TMPFS(vp->v_mount); 969 970 /* 971 * Convert the old and new sizes to the number of pages needed to 972 * store them. It may happen that we do not need to do anything 973 * because the last allocated page can accommodate the change on 974 * its own. 975 */ 976 TMPFS_NODE_LOCK(node); 977 oldsize = node->tn_size; 978 oldpages = round_page64(oldsize) / PAGE_SIZE; 979 KKASSERT(oldpages == node->tn_reg.tn_aobj_pages); 980 newpages = round_page64(newsize) / PAGE_SIZE; 981 982 if (newpages > oldpages && 983 tmp->tm_pages_used + newpages - oldpages > tmp->tm_pages_max) { 984 TMPFS_NODE_UNLOCK(node); 985 error = ENOSPC; 986 goto out; 987 } 988 node->tn_reg.tn_aobj_pages = newpages; 989 node->tn_size = newsize; 990 TMPFS_NODE_UNLOCK(node); 991 992 TMPFS_LOCK(tmp); 993 tmp->tm_pages_used += (newpages - oldpages); 994 TMPFS_UNLOCK(tmp); 995 996 /* 997 * When adjusting the vnode filesize and its VM object we must 998 * also adjust our backing VM object (aobj). The blocksize 999 * used must match the block sized we use for the buffer cache. 1000 * 1001 * The backing VM object contains no VM pages, only swap 1002 * assignments. 1003 */ 1004 if (newsize < oldsize) { 1005 vm_pindex_t osize; 1006 vm_pindex_t nsize; 1007 vm_object_t aobj; 1008 1009 error = nvtruncbuf(vp, newsize, TMPFS_BLKSIZE, -1, 0); 1010 aobj = node->tn_reg.tn_aobj; 1011 if (aobj) { 1012 osize = aobj->size; 1013 nsize = vp->v_object->size; 1014 if (nsize < osize) { 1015 aobj->size = osize; 1016 swap_pager_freespace(aobj, nsize, 1017 osize - nsize); 1018 } 1019 } 1020 } else { 1021 vm_object_t aobj; 1022 1023 error = nvextendbuf(vp, oldsize, newsize, 1024 TMPFS_BLKSIZE, TMPFS_BLKSIZE, 1025 -1, -1, trivial); 1026 aobj = node->tn_reg.tn_aobj; 1027 if (aobj) 1028 aobj->size = vp->v_object->size; 1029 } 1030 1031 out: 1032 return error; 1033 } 1034 1035 /* --------------------------------------------------------------------- */ 1036 1037 /* 1038 * Change flags of the given vnode. 1039 * Caller should execute tmpfs_update on vp after a successful execution. 1040 * The vnode must be locked on entry and remain locked on exit. 1041 */ 1042 int 1043 tmpfs_chflags(struct vnode *vp, int vaflags, struct ucred *cred) 1044 { 1045 int error; 1046 struct tmpfs_node *node; 1047 int flags; 1048 1049 KKASSERT(vn_islocked(vp)); 1050 1051 node = VP_TO_TMPFS_NODE(vp); 1052 flags = node->tn_flags; 1053 1054 /* Disallow this operation if the file system is mounted read-only. */ 1055 if (vp->v_mount->mnt_flag & MNT_RDONLY) 1056 return EROFS; 1057 error = vop_helper_setattr_flags(&flags, vaflags, node->tn_uid, cred); 1058 1059 /* Actually change the flags on the node itself */ 1060 if (error == 0) { 1061 TMPFS_NODE_LOCK(node); 1062 node->tn_flags = flags; 1063 node->tn_status |= TMPFS_NODE_CHANGED; 1064 TMPFS_NODE_UNLOCK(node); 1065 } 1066 1067 KKASSERT(vn_islocked(vp)); 1068 1069 return error; 1070 } 1071 1072 /* --------------------------------------------------------------------- */ 1073 1074 /* 1075 * Change access mode on the given vnode. 1076 * Caller should execute tmpfs_update on vp after a successful execution. 1077 * The vnode must be locked on entry and remain locked on exit. 1078 */ 1079 int 1080 tmpfs_chmod(struct vnode *vp, mode_t vamode, struct ucred *cred) 1081 { 1082 struct tmpfs_node *node; 1083 mode_t cur_mode; 1084 int error; 1085 1086 KKASSERT(vn_islocked(vp)); 1087 1088 node = VP_TO_TMPFS_NODE(vp); 1089 1090 /* Disallow this operation if the file system is mounted read-only. */ 1091 if (vp->v_mount->mnt_flag & MNT_RDONLY) 1092 return EROFS; 1093 1094 /* Immutable or append-only files cannot be modified, either. */ 1095 if (node->tn_flags & (IMMUTABLE | APPEND)) 1096 return EPERM; 1097 1098 cur_mode = node->tn_mode; 1099 error = vop_helper_chmod(vp, vamode, cred, node->tn_uid, node->tn_gid, 1100 &cur_mode); 1101 1102 if (error == 0 && 1103 (node->tn_mode & ALLPERMS) != (cur_mode & ALLPERMS)) { 1104 TMPFS_NODE_LOCK(node); 1105 node->tn_mode &= ~ALLPERMS; 1106 node->tn_mode |= cur_mode & ALLPERMS; 1107 1108 node->tn_status |= TMPFS_NODE_CHANGED; 1109 TMPFS_NODE_UNLOCK(node); 1110 } 1111 1112 KKASSERT(vn_islocked(vp)); 1113 1114 return 0; 1115 } 1116 1117 /* --------------------------------------------------------------------- */ 1118 1119 /* 1120 * Change ownership of the given vnode. At least one of uid or gid must 1121 * be different than VNOVAL. If one is set to that value, the attribute 1122 * is unchanged. 1123 * Caller should execute tmpfs_update on vp after a successful execution. 1124 * The vnode must be locked on entry and remain locked on exit. 1125 */ 1126 int 1127 tmpfs_chown(struct vnode *vp, uid_t uid, gid_t gid, struct ucred *cred) 1128 { 1129 mode_t cur_mode; 1130 uid_t cur_uid; 1131 gid_t cur_gid; 1132 struct tmpfs_node *node; 1133 int error; 1134 1135 KKASSERT(vn_islocked(vp)); 1136 node = VP_TO_TMPFS_NODE(vp); 1137 1138 /* Disallow this operation if the file system is mounted read-only. */ 1139 if (vp->v_mount->mnt_flag & MNT_RDONLY) 1140 return EROFS; 1141 1142 /* Immutable or append-only files cannot be modified, either. */ 1143 if (node->tn_flags & (IMMUTABLE | APPEND)) 1144 return EPERM; 1145 1146 cur_uid = node->tn_uid; 1147 cur_gid = node->tn_gid; 1148 cur_mode = node->tn_mode; 1149 error = vop_helper_chown(vp, uid, gid, cred, 1150 &cur_uid, &cur_gid, &cur_mode); 1151 1152 if (error == 0) { 1153 TMPFS_NODE_LOCK(node); 1154 if (cur_uid != node->tn_uid || 1155 cur_gid != node->tn_gid || 1156 cur_mode != node->tn_mode) { 1157 node->tn_uid = cur_uid; 1158 node->tn_gid = cur_gid; 1159 node->tn_mode = cur_mode; 1160 node->tn_status |= TMPFS_NODE_CHANGED; 1161 } 1162 TMPFS_NODE_UNLOCK(node); 1163 } 1164 1165 return error; 1166 } 1167 1168 /* --------------------------------------------------------------------- */ 1169 1170 /* 1171 * Change size of the given vnode. 1172 * Caller should execute tmpfs_update on vp after a successful execution. 1173 * The vnode must be locked on entry and remain locked on exit. 1174 */ 1175 int 1176 tmpfs_chsize(struct vnode *vp, u_quad_t size, struct ucred *cred) 1177 { 1178 int error; 1179 struct tmpfs_node *node; 1180 1181 KKASSERT(vn_islocked(vp)); 1182 1183 node = VP_TO_TMPFS_NODE(vp); 1184 1185 /* Decide whether this is a valid operation based on the file type. */ 1186 error = 0; 1187 switch (vp->v_type) { 1188 case VDIR: 1189 return EISDIR; 1190 1191 case VREG: 1192 if (vp->v_mount->mnt_flag & MNT_RDONLY) 1193 return EROFS; 1194 break; 1195 1196 case VBLK: 1197 /* FALLTHROUGH */ 1198 case VCHR: 1199 /* FALLTHROUGH */ 1200 case VFIFO: 1201 /* Allow modifications of special files even if in the file 1202 * system is mounted read-only (we are not modifying the 1203 * files themselves, but the objects they represent). */ 1204 return 0; 1205 1206 default: 1207 /* Anything else is unsupported. */ 1208 return EOPNOTSUPP; 1209 } 1210 1211 /* Immutable or append-only files cannot be modified, either. */ 1212 if (node->tn_flags & (IMMUTABLE | APPEND)) 1213 return EPERM; 1214 1215 error = tmpfs_truncate(vp, size); 1216 /* tmpfs_truncate will raise the NOTE_EXTEND and NOTE_ATTRIB kevents 1217 * for us, as will update tn_status; no need to do that here. */ 1218 1219 KKASSERT(vn_islocked(vp)); 1220 1221 return error; 1222 } 1223 1224 /* --------------------------------------------------------------------- */ 1225 1226 /* 1227 * Change access and modification times of the given vnode. 1228 * Caller should execute tmpfs_update on vp after a successful execution. 1229 * The vnode must be locked on entry and remain locked on exit. 1230 */ 1231 int 1232 tmpfs_chtimes(struct vnode *vp, struct timespec *atime, struct timespec *mtime, 1233 int vaflags, struct ucred *cred) 1234 { 1235 struct tmpfs_node *node; 1236 1237 KKASSERT(vn_islocked(vp)); 1238 1239 node = VP_TO_TMPFS_NODE(vp); 1240 1241 /* Disallow this operation if the file system is mounted read-only. */ 1242 if (vp->v_mount->mnt_flag & MNT_RDONLY) 1243 return EROFS; 1244 1245 /* Immutable or append-only files cannot be modified, either. */ 1246 if (node->tn_flags & (IMMUTABLE | APPEND)) 1247 return EPERM; 1248 1249 TMPFS_NODE_LOCK(node); 1250 if (atime->tv_sec != VNOVAL && atime->tv_nsec != VNOVAL) 1251 node->tn_status |= TMPFS_NODE_ACCESSED; 1252 1253 if (mtime->tv_sec != VNOVAL && mtime->tv_nsec != VNOVAL) 1254 node->tn_status |= TMPFS_NODE_MODIFIED; 1255 1256 TMPFS_NODE_UNLOCK(node); 1257 1258 tmpfs_itimes(vp, atime, mtime); 1259 1260 KKASSERT(vn_islocked(vp)); 1261 1262 return 0; 1263 } 1264 1265 /* --------------------------------------------------------------------- */ 1266 /* Sync timestamps */ 1267 void 1268 tmpfs_itimes(struct vnode *vp, const struct timespec *acc, 1269 const struct timespec *mod) 1270 { 1271 struct tmpfs_node *node; 1272 struct timespec now; 1273 1274 node = VP_TO_TMPFS_NODE(vp); 1275 1276 if ((node->tn_status & (TMPFS_NODE_ACCESSED | TMPFS_NODE_MODIFIED | 1277 TMPFS_NODE_CHANGED)) == 0) 1278 return; 1279 1280 vfs_timestamp(&now); 1281 1282 TMPFS_NODE_LOCK(node); 1283 if (node->tn_status & TMPFS_NODE_ACCESSED) { 1284 if (acc == NULL) 1285 acc = &now; 1286 node->tn_atime = acc->tv_sec; 1287 node->tn_atimensec = acc->tv_nsec; 1288 } 1289 if (node->tn_status & TMPFS_NODE_MODIFIED) { 1290 if (mod == NULL) 1291 mod = &now; 1292 node->tn_mtime = mod->tv_sec; 1293 node->tn_mtimensec = mod->tv_nsec; 1294 } 1295 if (node->tn_status & TMPFS_NODE_CHANGED) { 1296 node->tn_ctime = now.tv_sec; 1297 node->tn_ctimensec = now.tv_nsec; 1298 } 1299 node->tn_status &= 1300 ~(TMPFS_NODE_ACCESSED | TMPFS_NODE_MODIFIED | TMPFS_NODE_CHANGED); 1301 TMPFS_NODE_UNLOCK(node); 1302 } 1303 1304 /* --------------------------------------------------------------------- */ 1305 1306 void 1307 tmpfs_update(struct vnode *vp) 1308 { 1309 tmpfs_itimes(vp, NULL, NULL); 1310 } 1311 1312 /* --------------------------------------------------------------------- */ 1313 1314 int 1315 tmpfs_truncate(struct vnode *vp, off_t length) 1316 { 1317 int error; 1318 struct tmpfs_node *node; 1319 1320 node = VP_TO_TMPFS_NODE(vp); 1321 1322 if (length < 0) { 1323 error = EINVAL; 1324 goto out; 1325 } 1326 1327 if (node->tn_size == length) { 1328 error = 0; 1329 goto out; 1330 } 1331 1332 if (length > VFS_TO_TMPFS(vp->v_mount)->tm_maxfilesize) 1333 return (EFBIG); 1334 1335 1336 error = tmpfs_reg_resize(vp, length, 1); 1337 1338 if (error == 0) { 1339 TMPFS_NODE_LOCK(node); 1340 node->tn_status |= TMPFS_NODE_CHANGED | TMPFS_NODE_MODIFIED; 1341 TMPFS_NODE_UNLOCK(node); 1342 } 1343 1344 out: 1345 tmpfs_update(vp); 1346 1347 return error; 1348 } 1349 1350 /* --------------------------------------------------------------------- */ 1351 1352 static ino_t 1353 tmpfs_fetch_ino(struct tmpfs_mount *tmp) 1354 { 1355 ino_t ret; 1356 1357 TMPFS_LOCK(tmp); 1358 ret = tmp->tm_ino++; 1359 TMPFS_UNLOCK(tmp); 1360 1361 return (ret); 1362 } 1363 1364 static int 1365 tmpfs_dirtree_compare(struct tmpfs_dirent *a, struct tmpfs_dirent *b) 1366 { 1367 if (a->td_namelen > b->td_namelen) 1368 return 1; 1369 else if (a->td_namelen < b->td_namelen) 1370 return -1; 1371 else 1372 return strncmp(a->td_name, b->td_name, a->td_namelen); 1373 } 1374 1375 static int 1376 tmpfs_dirtree_compare_cookie(struct tmpfs_dirent *a, struct tmpfs_dirent *b) 1377 { 1378 if (a < b) 1379 return(-1); 1380 if (a > b) 1381 return(1); 1382 return 0; 1383 } 1384