1*38fd1498Szrj /* -Wnonnull-compare warning support.
2*38fd1498Szrj Copyright (C) 2016-2018 Free Software Foundation, Inc.
3*38fd1498Szrj Contributed by Jakub Jelinek <jakub@redhat.com>
4*38fd1498Szrj
5*38fd1498Szrj This file is part of GCC.
6*38fd1498Szrj
7*38fd1498Szrj GCC is free software; you can redistribute it and/or modify
8*38fd1498Szrj it under the terms of the GNU General Public License as published by
9*38fd1498Szrj the Free Software Foundation; either version 3, or (at your option)
10*38fd1498Szrj any later version.
11*38fd1498Szrj
12*38fd1498Szrj GCC is distributed in the hope that it will be useful,
13*38fd1498Szrj but WITHOUT ANY WARRANTY; without even the implied warranty of
14*38fd1498Szrj MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15*38fd1498Szrj GNU General Public License for more details.
16*38fd1498Szrj
17*38fd1498Szrj You should have received a copy of the GNU General Public License
18*38fd1498Szrj along with GCC; see the file COPYING3. If not see
19*38fd1498Szrj <http://www.gnu.org/licenses/>. */
20*38fd1498Szrj
21*38fd1498Szrj #include "config.h"
22*38fd1498Szrj #include "system.h"
23*38fd1498Szrj #include "coretypes.h"
24*38fd1498Szrj #include "backend.h"
25*38fd1498Szrj #include "tree.h"
26*38fd1498Szrj #include "gimple.h"
27*38fd1498Szrj #include "tree-pass.h"
28*38fd1498Szrj #include "ssa.h"
29*38fd1498Szrj #include "diagnostic-core.h"
30*38fd1498Szrj #include "tree-dfa.h"
31*38fd1498Szrj
32*38fd1498Szrj /* Warn about comparison of nonnull_arg_p argument initial values
33*38fd1498Szrj with NULL. */
34*38fd1498Szrj
35*38fd1498Szrj static void
do_warn_nonnull_compare(function * fun,tree arg)36*38fd1498Szrj do_warn_nonnull_compare (function *fun, tree arg)
37*38fd1498Szrj {
38*38fd1498Szrj if (!POINTER_TYPE_P (TREE_TYPE (arg))
39*38fd1498Szrj && TREE_CODE (TREE_TYPE (arg)) != OFFSET_TYPE)
40*38fd1498Szrj return;
41*38fd1498Szrj
42*38fd1498Szrj if (!nonnull_arg_p (arg))
43*38fd1498Szrj return;
44*38fd1498Szrj
45*38fd1498Szrj tree d = ssa_default_def (fun, arg);
46*38fd1498Szrj if (d == NULL_TREE)
47*38fd1498Szrj return;
48*38fd1498Szrj
49*38fd1498Szrj use_operand_p use_p;
50*38fd1498Szrj imm_use_iterator iter;
51*38fd1498Szrj
52*38fd1498Szrj FOR_EACH_IMM_USE_FAST (use_p, iter, d)
53*38fd1498Szrj {
54*38fd1498Szrj gimple *stmt = USE_STMT (use_p);
55*38fd1498Szrj tree op = NULL_TREE;
56*38fd1498Szrj location_t loc = gimple_location (stmt);
57*38fd1498Szrj if (gimple_code (stmt) == GIMPLE_COND)
58*38fd1498Szrj switch (gimple_cond_code (stmt))
59*38fd1498Szrj {
60*38fd1498Szrj case EQ_EXPR:
61*38fd1498Szrj case NE_EXPR:
62*38fd1498Szrj if (gimple_cond_lhs (stmt) == d)
63*38fd1498Szrj op = gimple_cond_rhs (stmt);
64*38fd1498Szrj break;
65*38fd1498Szrj default:
66*38fd1498Szrj break;
67*38fd1498Szrj }
68*38fd1498Szrj else if (is_gimple_assign (stmt))
69*38fd1498Szrj switch (gimple_assign_rhs_code (stmt))
70*38fd1498Szrj {
71*38fd1498Szrj case EQ_EXPR:
72*38fd1498Szrj case NE_EXPR:
73*38fd1498Szrj if (gimple_assign_rhs1 (stmt) == d)
74*38fd1498Szrj op = gimple_assign_rhs2 (stmt);
75*38fd1498Szrj break;
76*38fd1498Szrj case COND_EXPR:
77*38fd1498Szrj switch (TREE_CODE (gimple_assign_rhs1 (stmt)))
78*38fd1498Szrj {
79*38fd1498Szrj case EQ_EXPR:
80*38fd1498Szrj case NE_EXPR:
81*38fd1498Szrj op = gimple_assign_rhs1 (stmt);
82*38fd1498Szrj if (TREE_OPERAND (op, 0) != d)
83*38fd1498Szrj {
84*38fd1498Szrj op = NULL_TREE;
85*38fd1498Szrj break;
86*38fd1498Szrj }
87*38fd1498Szrj loc = EXPR_LOC_OR_LOC (op, loc);
88*38fd1498Szrj op = TREE_OPERAND (op, 1);
89*38fd1498Szrj break;
90*38fd1498Szrj default:
91*38fd1498Szrj break;
92*38fd1498Szrj }
93*38fd1498Szrj break;
94*38fd1498Szrj default:
95*38fd1498Szrj break;
96*38fd1498Szrj }
97*38fd1498Szrj if (op
98*38fd1498Szrj && (POINTER_TYPE_P (TREE_TYPE (arg))
99*38fd1498Szrj ? integer_zerop (op) : integer_minus_onep (op))
100*38fd1498Szrj && !gimple_no_warning_p (stmt))
101*38fd1498Szrj warning_at (loc, OPT_Wnonnull_compare,
102*38fd1498Szrj "nonnull argument %qD compared to NULL", arg);
103*38fd1498Szrj }
104*38fd1498Szrj }
105*38fd1498Szrj
106*38fd1498Szrj namespace {
107*38fd1498Szrj
108*38fd1498Szrj const pass_data pass_data_warn_nonnull_compare =
109*38fd1498Szrj {
110*38fd1498Szrj GIMPLE_PASS, /* type */
111*38fd1498Szrj "*nonnullcmp", /* name */
112*38fd1498Szrj OPTGROUP_NONE, /* optinfo_flags */
113*38fd1498Szrj TV_NONE, /* tv_id */
114*38fd1498Szrj PROP_ssa, /* properties_required */
115*38fd1498Szrj 0, /* properties_provided */
116*38fd1498Szrj 0, /* properties_destroyed */
117*38fd1498Szrj 0, /* todo_flags_start */
118*38fd1498Szrj 0, /* todo_flags_finish */
119*38fd1498Szrj };
120*38fd1498Szrj
121*38fd1498Szrj class pass_warn_nonnull_compare : public gimple_opt_pass
122*38fd1498Szrj {
123*38fd1498Szrj public:
pass_warn_nonnull_compare(gcc::context * ctxt)124*38fd1498Szrj pass_warn_nonnull_compare (gcc::context *ctxt)
125*38fd1498Szrj : gimple_opt_pass (pass_data_warn_nonnull_compare, ctxt)
126*38fd1498Szrj {}
127*38fd1498Szrj
128*38fd1498Szrj /* opt_pass methods: */
gate(function *)129*38fd1498Szrj virtual bool gate (function *) { return warn_nonnull_compare; }
130*38fd1498Szrj
131*38fd1498Szrj virtual unsigned int execute (function *);
132*38fd1498Szrj
133*38fd1498Szrj }; // class pass_warn_nonnull_compare
134*38fd1498Szrj
135*38fd1498Szrj unsigned int
execute(function * fun)136*38fd1498Szrj pass_warn_nonnull_compare::execute (function *fun)
137*38fd1498Szrj {
138*38fd1498Szrj if (fun->static_chain_decl)
139*38fd1498Szrj do_warn_nonnull_compare (fun, fun->static_chain_decl);
140*38fd1498Szrj
141*38fd1498Szrj for (tree arg = DECL_ARGUMENTS (cfun->decl); arg; arg = DECL_CHAIN (arg))
142*38fd1498Szrj do_warn_nonnull_compare (fun, arg);
143*38fd1498Szrj return 0;
144*38fd1498Szrj }
145*38fd1498Szrj
146*38fd1498Szrj } // anon namespace
147*38fd1498Szrj
148*38fd1498Szrj gimple_opt_pass *
make_pass_warn_nonnull_compare(gcc::context * ctxt)149*38fd1498Szrj make_pass_warn_nonnull_compare (gcc::context *ctxt)
150*38fd1498Szrj {
151*38fd1498Szrj return new pass_warn_nonnull_compare (ctxt);
152*38fd1498Szrj }
153