1*10352Shelge /* up.c 4.3 83/01/17 */ 29974Ssam 310023Ssam /* 410023Ssam * UNIBUS peripheral standalone driver 510023Ssam * with ECC correction and bad block forwarding. 610023Ssam * Also supports header operation and write 710023Ssam * check for data and/or header. 810023Ssam */ 9*10352Shelge 109974Ssam #include "../h/param.h" 119974Ssam #include "../h/inode.h" 129974Ssam #include "../h/fs.h" 139974Ssam #include "../h/dkbad.h" 149974Ssam #include "../h/vmmac.h" 159974Ssam 169974Ssam #include "../vax/pte.h" 179974Ssam #include "../vaxuba/upreg.h" 189974Ssam #include "../vaxuba/ubareg.h" 199974Ssam 2010023Ssam #include "saio.h" 219974Ssam #include "savax.h" 229974Ssam 23*10352Shelge #define MAXBADDESC 126 /* max number of bad sectors recorded */ 24*10352Shelge #define SECTSIZ 512 /* sector size in bytes */ 25*10352Shelge #define HDRSIZ 4 /* number of bytes in sector header */ 26*10352Shelge #define MAXECC 5 /* max number of bad bits accepted in 27*10352Shelge * a soft ecc error when F_ECCLM is set */ 28*10352Shelge #define NUPTYPES 3 29*10352Shelge 3010023Ssam u_short ubastd[] = { 0776700 }; 319974Ssam 329974Ssam char up_gottype[MAXNUBA*8] = { 0 }; 339974Ssam char up_type[MAXNUBA*8] = { 0 }; 349974Ssam short up_off[] = { 0, 27, 68, -1, -1, -1, -1, 82 }; 359974Ssam short fj_off[] = { 0, 50, 0, -1, -1, -1, -1, 155 }; 369974Ssam /* this is called upam instead of am because hp.c has a similar array */ 379974Ssam short upam_off[] = { 0, 32, 0, 668, 723, 778, 668, 98 }; 3810023Ssam 39*10352Shelge struct st upst[NUPTYPES] = { 4010023Ssam 32, 19, 32*19, 823, up_off, /* 9300/equiv */ 4110023Ssam 32, 10, 32*10, 823, fj_off, /* Fuji 160 */ 4210023Ssam 32, 16, 32*16, 1024, upam_off, /* Capricorn */ 439974Ssam }; 4410023Ssam 459974Ssam u_char up_offset[16] = { 469974Ssam UPOF_P400, UPOF_M400, UPOF_P400, UPOF_M400, 479974Ssam UPOF_P800, UPOF_M800, UPOF_P800, UPOF_M800, 489974Ssam UPOF_P1200, UPOF_M1200, UPOF_P1200, UPOF_M1200, 499974Ssam 0, 0, 0, 0 509974Ssam }; 519974Ssam 5210023Ssam struct dkbad upbad[MAXNUBA*8]; /* bad sector table */ 53*10352Shelge int sectsiz; /* real sector size */ 5410023Ssam 559974Ssam upopen(io) 569974Ssam register struct iob *io; 579974Ssam { 58*10352Shelge register unit = io->i_unit; 5910023Ssam register struct updevice *upaddr; 60*10352Shelge register struct st *st = &upst[up_type[unit]]; 619974Ssam 6210023Ssam if (io->i_boff < 0 || io->i_boff > 7 || st->off[io->i_boff] == -1) 6310023Ssam _stop("up bad unit"); 64*10352Shelge upaddr = (struct updevice *)ubamem(unit, ubastd[0]); 659974Ssam while ((upaddr->upcs1 & UP_DVA) == 0) /* infinite wait */ 669974Ssam ; 67*10352Shelge if (up_gottype[unit] == 0) { 6810023Ssam register int i; 6910023Ssam struct iob tio; 7010023Ssam 719974Ssam upaddr->uphr = UPHR_MAXTRAK; 7210023Ssam for (st = upst; st < &upst[NUPTYPES]; st++) 7310023Ssam if (upaddr->uphr == st->ntrak - 1) { 74*10352Shelge up_type[unit] = st - upst; 7510023Ssam break; 7610023Ssam } 7710023Ssam if (st == &upst[NUPTYPES]) { 78*10352Shelge printf("up%d: uphr=%x\n", unit, upaddr->uphr); 7910023Ssam _stop("unknown drive type"); 8010023Ssam } 819974Ssam upaddr->upcs2 = UPCS2_CLR; 829974Ssam #ifdef DEBUG 83*10352Shelge printf("Unittype=%d\n",up_type[unit]); 849974Ssam #endif 859974Ssam 8610023Ssam /* 8710023Ssam * Read in the bad sector table: 8810023Ssam * copy the contents of the io structure 8910023Ssam * to tio for use during the bb pointer 9010023Ssam * read operation. 9110023Ssam */ 9210023Ssam tio = *io; 9310023Ssam tio.i_bn = st->nspc * st->ncyl - st->nsect; 949974Ssam tio.i_ma = (char *)&upbad[tio.i_unit]; 9510023Ssam tio.i_cc = sizeof (upbad); 9610023Ssam tio.i_flgs |= F_RDDATA; 9710023Ssam for (i = 0; i < 5; i++) { 9810023Ssam if (upstrategy(&tio, READ) == sizeof (upbad)) 9910023Ssam break; 1009974Ssam tio.i_bn += 2; 1019974Ssam } 1029974Ssam if (i == 5) { 10310023Ssam printf("Unable to read bad sector table\n"); 104*10352Shelge for (i = 0; i < MAXBADDESC; i++) { 105*10352Shelge upbad[unit].bt_bad[i].bt_cyl = -1; 106*10352Shelge upbad[unit].bt_bad[i].bt_trksec = -1; 1079974Ssam } 1089974Ssam } 109*10352Shelge up_gottype[unit] = 1; 1109974Ssam } 1119974Ssam io->i_boff = st->off[io->i_boff] * st->nspc; 11210023Ssam io->i_flgs &= ~F_TYPEMASK; 1139974Ssam } 1149974Ssam 1159974Ssam upstrategy(io, func) 1169974Ssam register struct iob *io; 1179974Ssam { 118*10352Shelge int cn, tn, sn; 119*10352Shelge register unit = io->i_unit; 1209974Ssam daddr_t bn; 1219974Ssam int recal, info, waitdry; 1229974Ssam register struct updevice *upaddr = 123*10352Shelge (struct updevice *)ubamem(unit, ubastd[0]); 124*10352Shelge register struct st *st = &upst[up_type[unit]]; 1259974Ssam 126*10352Shelge sectsiz = SECTSIZ; 127*10352Shelge if ((io->i_flgs & (F_HDR|F_CHECK)) != 0) 128*10352Shelge sectsiz += HDRSIZ; 1299974Ssam io->i_errcnt = 0; 130*10352Shelge recal = 1; 1319974Ssam upaddr->upcs2 = unit; 1329974Ssam if ((upaddr->upds & UPDS_VV) == 0) { 1339974Ssam upaddr->upcs1 = UP_DCLR|UP_GO; 1349974Ssam upaddr->upcs1 = UP_PRESET|UP_GO; 1359974Ssam upaddr->upof = UPOF_FMT22; 1369974Ssam } 1379974Ssam if ((upaddr->upds & UPDS_DREADY) != UPDS_DREADY) 1389974Ssam _stop("up not ready"); 1399974Ssam info = ubasetup(io, 1); 1409974Ssam upaddr->upwc = -io->i_cc / sizeof (short); 1419974Ssam upaddr->upba = info; 1429974Ssam readmore: 143*10352Shelge bn = io->i_bn + (io->i_cc + upaddr->upwc*sizeof(short))/sectsiz; 14410023Ssam while((upaddr->upds & UPDS_DRY) == 0) 14510023Ssam ; 146*10352Shelge if (upstart(io, bn) != 0) { 147*10352Shelge ubafree(io, info); 1489974Ssam return (-1); 149*10352Shelge } 1509974Ssam do { 1519974Ssam DELAY(25); 1529974Ssam } while ((upaddr->upcs1 & UP_RDY) == 0); 1539974Ssam 154*10352Shelge if (((upaddr->upds&UPDS_ERR) | (upaddr->upcs1&UP_TRE)) == 0 ) { 155*10352Shelge ubafree(io, info); 1569974Ssam return(io->i_cc); 157*10352Shelge } 1589974Ssam 1599974Ssam #ifdef LOGALLERRS 1609974Ssam printf("uper: (c,t,s)=(%d,%d,%d) cs2=%b er1=%b er2=%b wc=%x\n", 1619974Ssam upaddr->updc, upaddr->upda>>8, (upaddr->upda&0x1f-1), 1629974Ssam upaddr->upcs2, UPCS2_BITS, upaddr->uper1, 1639974Ssam UPER1_BITS, upaddr->uper2, UPER2_BITS,-upaddr->upwc); 1649974Ssam #endif 1659974Ssam waitdry = 0; 166*10352Shelge while ((upaddr->upds & UPDS_DRY) == 0 && ++waitdry < sectsiz) 16710023Ssam DELAY(5); 1689974Ssam if (++io->i_errcnt > 27) { 1699974Ssam /* 1709974Ssam * After 28 retries (16 without offset, and 1719974Ssam * 12 with offset positioning) give up. 1729974Ssam */ 17310023Ssam io->i_error = EHER; 17410023Ssam if (upaddr->upcs2 & UPCS2_WCE) 17510023Ssam io->i_error = EWCK; 176*10352Shelge hard: 177*10352Shelge bn = io->i_bn + (io->i_cc + upaddr->upwc*sizeof(short))/sectsiz; 1789974Ssam cn = bn/st->nspc; 1799974Ssam sn = bn%st->nspc; 1809974Ssam tn = sn/st->nsect; 1819974Ssam sn = sn%st->nsect; 1829974Ssam printf("up error: (cyl,trk,sec)=(%d,%d,%d) cs2=%b er1=%b er2=%b\n", 1839974Ssam cn, tn, sn, 1849974Ssam upaddr->upcs2, UPCS2_BITS, upaddr->uper1, 1859974Ssam UPER1_BITS, upaddr->uper2, UPER2_BITS); 1869974Ssam upaddr->upcs1 = UP_TRE|UP_DCLR|UP_GO; 187*10352Shelge io->i_errblk = bn; 1889974Ssam return (io->i_cc + upaddr->upwc*sizeof(short)); 1899974Ssam } else 1909974Ssam if (upaddr->uper1&UPER1_WLE) { 19110023Ssam /* 19210023Ssam * Give up on write locked devices 19310023Ssam * immediately. 19410023Ssam */ 19510023Ssam printf("up%d: write locked\n", unit); 19610023Ssam return(-1); 1979974Ssam } 1989974Ssam #ifndef NOBADSECT 1999974Ssam else if (upaddr->uper2 & UPER2_BSE) { 200*10352Shelge if (io->i_flgs & F_NBSF) { 201*10352Shelge io->i_error = EBSE; 202*10352Shelge goto hard; 203*10352Shelge } 204*10352Shelge if (upecc( io, BSE) == 0) 2059974Ssam goto success; 2069974Ssam else { 20710023Ssam io->i_error = EBSE; 2089974Ssam goto hard; 2099974Ssam } 2109974Ssam } 2119974Ssam #endif 2129974Ssam else { 2139974Ssam /* 2149974Ssam * Retriable error. 2159974Ssam * If a soft ecc, correct it 2169974Ssam * Otherwise fall through and retry the transfer 2179974Ssam */ 218*10352Shelge if ((upaddr->uper1 & UPER1_DCK) != 0) { 219*10352Shelge /* 220*10352Shelge * If a write check command is active, all 221*10352Shelge * ecc errors give UPER1_ECH. 222*10352Shelge */ 223*10352Shelge if (((upaddr->uper1 & UPER1_ECH) == 0 )|| 224*10352Shelge ((upaddr->upcs2 & UPCS2_WCE) != 0 )) { 225*10352Shelge if (upecc(io, ECC) == 0) 226*10352Shelge goto success; 227*10352Shelge else { 228*10352Shelge io->i_error = EECC; 229*10352Shelge goto hard; 230*10352Shelge } 231*10352Shelge } 232*10352Shelge } 233*10352Shelge io->i_active = 0; /* else force retry */ 2349974Ssam } 2359974Ssam /* 2369974Ssam * Clear drive error and, every eight attempts, 2379974Ssam * (starting with the fourth) 2389974Ssam * recalibrate to clear the slate. 2399974Ssam */ 2409974Ssam upaddr->upcs1 = UP_TRE|UP_DCLR|UP_GO; 2419974Ssam if ((io->i_errcnt&07) == 4 && io->i_active == 0) { 2429974Ssam upaddr->upcs1 = UP_RECAL|UP_GO; 2439974Ssam recal = 0; 2449974Ssam goto nextrecal; 2459974Ssam } 2469974Ssam /* 2479974Ssam * Advance recalibration finite state machine 2489974Ssam * if recalibrate in progress, through 2499974Ssam * RECAL 2509974Ssam * SEEK 2519974Ssam * OFFSET (optional) 2529974Ssam * RETRY 2539974Ssam */ 2549974Ssam switch (recal) { 2559974Ssam 2569974Ssam case 1: 2579974Ssam upaddr->updc = cn; 2589974Ssam upaddr->upcs1 = UP_SEEK|UP_GO; 2599974Ssam goto nextrecal; 26010023Ssam 2619974Ssam case 2: 2629974Ssam if (io->i_errcnt < 16 || (func & READ) == 0) 2639974Ssam goto donerecal; 2649974Ssam upaddr->upof = up_offset[io->i_errcnt & 017] | UPOF_FMT22; 2659974Ssam upaddr->upcs1 = UP_OFFSET|UP_GO; 2669974Ssam nextrecal: 2679974Ssam recal++; 2689974Ssam io->i_active = 1; 2699974Ssam goto readmore; 27010023Ssam 2719974Ssam donerecal: 2729974Ssam case 3: 2739974Ssam recal = 0; 2749974Ssam io->i_active = 0; 2759974Ssam break; 2769974Ssam } 2779974Ssam /* 2789974Ssam * If still ``active'', then don't need any more retries. 2799974Ssam */ 2809974Ssam if (io->i_active) { 2819974Ssam /* 2829974Ssam * If we were offset positioning, 2839974Ssam * return to centerline. 2849974Ssam */ 2859974Ssam if (io->i_errcnt >= 16) { 2869974Ssam upaddr->upof = UPOF_FMT22; 2879974Ssam upaddr->upcs1 = UP_RTC|UP_GO; 28810023Ssam while ((upaddr->upds&UPDS_DRY) == 0) 2899974Ssam DELAY(25); 2909974Ssam } 2919974Ssam goto readmore; 2929974Ssam } 2939974Ssam success: 2949974Ssam io->i_active = 1; 29510023Ssam if (upaddr->upwc != 0) 2969974Ssam goto readmore; 2979974Ssam /* 2989974Ssam * Release unibus 2999974Ssam */ 3009974Ssam ubafree(io, info); 3019974Ssam return (io->i_cc); 3029974Ssam } 3039974Ssam 3049974Ssam /* 3059974Ssam * Correct an ECC error, and restart the i/o to complete 3069974Ssam * the transfer if necessary. This is quite complicated because 3079974Ssam * the transfer may be going to an odd memory address base and/or 3089974Ssam * across a page boundary. 3099974Ssam */ 31010023Ssam upecc(io, flag) 3119974Ssam register struct iob *io; 3129974Ssam int flag; 3139974Ssam { 3149974Ssam register struct updevice *up = 3159974Ssam (struct updevice *)ubamem(io->i_unit, ubastd[0]); 316*10352Shelge register struct st *st; 3179974Ssam register int i; 3189974Ssam caddr_t addr; 319*10352Shelge int bn, twc, npf, mask; 320*10352Shelge daddr_t bbn; 3219974Ssam 3229974Ssam /* 3239974Ssam * Npf is the number of sectors transferred before the sector 3249974Ssam * containing the ECC error, bn is the current block number 3259974Ssam */ 326*10352Shelge twc = up->upwc; 327*10352Shelge npf = ((twc * sizeof(short)) + io->i_cc)/sectsiz; 3289974Ssam #ifdef UPECCDEBUG 3299974Ssam printf("npf %d mask 0x%x pos %d wc 0x%x\n",npf,mask,up->upec1,-up->upwc); 3309974Ssam #endif 331*10352Shelge bn = io->i_bn + npf ; 3329974Ssam st = &upst[up_type[io->i_unit]]; 3339974Ssam io->i_active = 2; 3349974Ssam /* 3359974Ssam * action taken depends on the flag 3369974Ssam */ 3379974Ssam if (flag == ECC) { 338*10352Shelge int bit, byte, ecccnt; 339*10352Shelge ecccnt = 0; 3409974Ssam mask = up->upec2; 341*10352Shelge printf("up%d: soft ecc sn%d\n", io->i_unit, io->i_bn + npf ); 3429974Ssam /* 3439974Ssam * Compute the 3449974Ssam * byte and bit position of the error. The variable i 3459974Ssam * is the byte offset in the transfer. 3469974Ssam */ 3479974Ssam i = up->upec1 - 1; /* -1 makes 0 origin */ 3489974Ssam bit = i&07; 3499974Ssam i = (i&~07)>>3; 3509974Ssam byte = i; 3519974Ssam up->upcs1 = UP_TRE|UP_DCLR|UP_GO; 3529974Ssam /* 3539974Ssam * Correct while possible bits remain of mask. Since mask 3549974Ssam * contains 11 bits, we continue while the bit offset is > -11. 3559974Ssam * Also watch out for end of this block and the end of the whole 3569974Ssam * transfer. 3579974Ssam */ 358*10352Shelge while (i < sectsiz && (npf*sectsiz)+i < io->i_cc && bit > -11) { 3599974Ssam /* 36010023Ssam * addr = vax base addr + (number of sectors transferred 3619974Ssam * before the error sector times the sector size) 3629974Ssam * + byte number 3639974Ssam */ 364*10352Shelge addr = io->i_ma + (npf*sectsiz) + byte; 3659974Ssam #ifdef UPECCDEBUG 366*10352Shelge printf("addr %x old: %x ",addr, (*addr&0xff)); 3679974Ssam #endif 368*10352Shelge if ((io->i_flgs & (F_CHECK|F_HCHECK)) == 0) 369*10352Shelge *addr ^= (mask << bit); 3709974Ssam #ifdef UPECCDEBUG 371*10352Shelge printf("new: %x\n", (*addr&0xff)); 3729974Ssam #endif 3739974Ssam byte++; 3749974Ssam i++; 3759974Ssam bit -= 8; 376*10352Shelge if ((ecccnt++ >= MAXECC) && ((io->i_flgs&F_ECCLM) != 0)) 377*10352Shelge return(1); 3789974Ssam } 379*10352Shelge return(0); 3809974Ssam #ifndef NOBADSECT 3819974Ssam } else if (flag == BSE) { 3829974Ssam /* 383*10352Shelge * if not in bad sector table, return 1 (= hard error) 3849974Ssam */ 385*10352Shelge up->upcs1 = UP_TRE|UP_DCLR|UP_GO; 3869974Ssam if ((bbn = isbad(&upbad[io->i_unit], st, bn)) < 0) 387*10352Shelge return(1); 3889974Ssam bbn = st->ncyl * st->nspc -st->nsect - 1 - bbn; 389*10352Shelge twc = up->upwc + sectsiz; 390*10352Shelge up->upwc = -(sectsiz / sizeof (short)); 3919974Ssam #ifdef UPECCDEBUG 3929974Ssam printf("revector to block %d\n", bbn); 3939974Ssam #endif 3949974Ssam /* 3959974Ssam * Clear the drive & read the replacement sector. 3969974Ssam * If this is in the middle of a transfer, then set up the 3979974Ssam * controller registers in a normal fashion. 3989974Ssam * The ub-address need not be changed. 3999974Ssam */ 40010023Ssam while (up->upcs1 & UP_RDY == 0) 4019974Ssam ; 40210023Ssam if (upstart(io, bbn) != 0) 403*10352Shelge return (1); /* error */ 404*10352Shelge io->i_errcnt = 0; /* success */ 4059974Ssam do { 4069974Ssam DELAY(25); 4079974Ssam } while ( up->upcs1 & UP_RDY == 0) ; 4089974Ssam if (up->upds & UPDS_ERR || up->upcs1 & UP_TRE) { 409*10352Shelge up->upwc = twc -sectsiz; 410*10352Shelge return (1); 4119974Ssam } 4129974Ssam } 41310023Ssam if (twc != 0) 4149974Ssam up->upwc = twc; 415*10352Shelge return (0); 4169974Ssam } 4179974Ssam 4189974Ssam upstart(io, bn) 41910023Ssam register struct iob *io; 42010023Ssam daddr_t bn; 4219974Ssam { 4229974Ssam register struct updevice *upaddr = 42310023Ssam (struct updevice *)ubamem(io->i_unit, ubastd[0]); 424*10352Shelge register struct st *st = &upst[up_type[io->i_unit]]; 4259974Ssam int sn, tn; 4269974Ssam 4279974Ssam sn = bn%st->nspc; 4289974Ssam tn = sn/st->nsect; 4299974Ssam sn %= st->nsect; 4309974Ssam upaddr->updc = bn/st->nspc; 4319974Ssam upaddr->upda = (tn << 8) + sn; 432*10352Shelge switch (io->i_flgs & F_TYPEMASK) { 43310023Ssam 43410023Ssam case F_RDDATA: 43510023Ssam upaddr->upcs1 = UP_RCOM|UP_GO; 4369974Ssam break; 43710023Ssam 43810023Ssam case F_WRDATA: 43910023Ssam upaddr->upcs1 = UP_WCOM|UP_GO; 4409974Ssam break; 44110023Ssam 44210023Ssam case F_HDR|F_RDDATA: 44310023Ssam upaddr->upcs1 = UP_RHDR|UP_GO; 44410023Ssam break; 44510023Ssam 44610023Ssam case F_HDR|F_WRDATA: 44710023Ssam upaddr->upcs1 = UP_WHDR|UP_GO; 44810023Ssam break; 44910023Ssam 45010023Ssam case F_CHECK|F_WRDATA: 45110023Ssam case F_CHECK|F_RDDATA: 4529974Ssam upaddr->upcs1 = UP_WCDATA|UP_GO; 4539974Ssam break; 45410023Ssam 45510023Ssam case F_HCHECK|F_WRDATA: 45610023Ssam case F_HCHECK|F_RDDATA: 4579974Ssam upaddr->upcs1 = UP_WCHDR|UP_GO; 4589974Ssam break; 45910023Ssam 4609974Ssam default: 46110023Ssam io->i_error = ECMD; 46210023Ssam io->i_flgs &= ~F_TYPEMASK; 46310023Ssam return (1); 4649974Ssam } 46510023Ssam return (0); 4669974Ssam } 4679974Ssam 46810023Ssam /*ARGSUSED*/ 46910023Ssam upioctl(io, cmd, arg) 47010023Ssam struct iob *io; 47110023Ssam int cmd; 47210023Ssam caddr_t arg; 47310023Ssam { 47410023Ssam 475*10352Shelge struct st *st = &upst[up_type[io->i_unit]], *tmp; 476*10352Shelge 477*10352Shelge switch(cmd) { 478*10352Shelge 479*10352Shelge case SAIODEVDATA: 480*10352Shelge tmp = (struct st *)arg; 481*10352Shelge *tmp = *st; 482*10352Shelge return(0); 483*10352Shelge 484*10352Shelge default: 485*10352Shelge return (ECMD); 486*10352Shelge } 48710023Ssam } 488*10352Shelge 489*10352Shelge /* this routine is common to up & hp, move to separate file */ 490*10352Shelge 491*10352Shelge /* 492*10352Shelge * Search the bad sector table looking for 493*10352Shelge * the specified sector. Return index if found. 494*10352Shelge * Return -1 if not found. 495*10352Shelge */ 496*10352Shelge 497*10352Shelge isbad(bt, st, blno) 498*10352Shelge register struct dkbad *bt; 499*10352Shelge register struct st *st; 500*10352Shelge { 501*10352Shelge register int i; 502*10352Shelge register long blk, bblk; 503*10352Shelge int trk, sec; 504*10352Shelge 505*10352Shelge sec = blno % st->nspc; 506*10352Shelge trk = sec / st->nsect; 507*10352Shelge sec %= st->nsect; 508*10352Shelge blk = ((long)(blno/st->nspc) << 16) + (trk << 8) + sec; 509*10352Shelge for (i = 0; i < MAXBADDESC; i++) { 510*10352Shelge bblk = ((long)bt->bt_bad[i].bt_cyl << 16) + 511*10352Shelge bt->bt_bad[i].bt_trksec; 512*10352Shelge if (blk == bblk) 513*10352Shelge return (i); 514*10352Shelge if (blk < bblk || bblk < 0) 515*10352Shelge break; 516*10352Shelge } 517*10352Shelge return (-1); 518*10352Shelge } 519