xref: /openbsd-src/gnu/llvm/lld/MachO/SectionPriorities.cpp (revision dfe94b169149f14cc1aee2cf6dad58a8d9a1860c)
1*dfe94b16Srobert //===- SectionPriorities.cpp ----------------------------------------------===//
2*dfe94b16Srobert //
3*dfe94b16Srobert // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4*dfe94b16Srobert // See https://llvm.org/LICENSE.txt for license information.
5*dfe94b16Srobert // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6*dfe94b16Srobert //
7*dfe94b16Srobert //===----------------------------------------------------------------------===//
8*dfe94b16Srobert ///
9*dfe94b16Srobert /// This is based on the ELF port, see ELF/CallGraphSort.cpp for the details
10*dfe94b16Srobert /// about the algorithm.
11*dfe94b16Srobert ///
12*dfe94b16Srobert //===----------------------------------------------------------------------===//
13*dfe94b16Srobert 
14*dfe94b16Srobert #include "SectionPriorities.h"
15*dfe94b16Srobert #include "Config.h"
16*dfe94b16Srobert #include "InputFiles.h"
17*dfe94b16Srobert #include "Symbols.h"
18*dfe94b16Srobert #include "Target.h"
19*dfe94b16Srobert 
20*dfe94b16Srobert #include "lld/Common/Args.h"
21*dfe94b16Srobert #include "lld/Common/CommonLinkerContext.h"
22*dfe94b16Srobert #include "lld/Common/ErrorHandler.h"
23*dfe94b16Srobert #include "llvm/ADT/DenseMap.h"
24*dfe94b16Srobert #include "llvm/ADT/MapVector.h"
25*dfe94b16Srobert #include "llvm/Support/Path.h"
26*dfe94b16Srobert #include "llvm/Support/TimeProfiler.h"
27*dfe94b16Srobert #include "llvm/Support/raw_ostream.h"
28*dfe94b16Srobert 
29*dfe94b16Srobert #include <numeric>
30*dfe94b16Srobert 
31*dfe94b16Srobert using namespace llvm;
32*dfe94b16Srobert using namespace llvm::MachO;
33*dfe94b16Srobert using namespace llvm::sys;
34*dfe94b16Srobert using namespace lld;
35*dfe94b16Srobert using namespace lld::macho;
36*dfe94b16Srobert 
37*dfe94b16Srobert PriorityBuilder macho::priorityBuilder;
38*dfe94b16Srobert 
39*dfe94b16Srobert namespace {
40*dfe94b16Srobert 
41*dfe94b16Srobert size_t highestAvailablePriority = std::numeric_limits<size_t>::max();
42*dfe94b16Srobert 
43*dfe94b16Srobert struct Edge {
44*dfe94b16Srobert   int from;
45*dfe94b16Srobert   uint64_t weight;
46*dfe94b16Srobert };
47*dfe94b16Srobert 
48*dfe94b16Srobert struct Cluster {
Cluster__anon6d216c980111::Cluster49*dfe94b16Srobert   Cluster(int sec, size_t s) : next(sec), prev(sec), size(s) {}
50*dfe94b16Srobert 
getDensity__anon6d216c980111::Cluster51*dfe94b16Srobert   double getDensity() const {
52*dfe94b16Srobert     if (size == 0)
53*dfe94b16Srobert       return 0;
54*dfe94b16Srobert     return double(weight) / double(size);
55*dfe94b16Srobert   }
56*dfe94b16Srobert 
57*dfe94b16Srobert   int next;
58*dfe94b16Srobert   int prev;
59*dfe94b16Srobert   uint64_t size;
60*dfe94b16Srobert   uint64_t weight = 0;
61*dfe94b16Srobert   uint64_t initialWeight = 0;
62*dfe94b16Srobert   Edge bestPred = {-1, 0};
63*dfe94b16Srobert };
64*dfe94b16Srobert 
65*dfe94b16Srobert class CallGraphSort {
66*dfe94b16Srobert public:
67*dfe94b16Srobert   CallGraphSort(const MapVector<SectionPair, uint64_t> &profile);
68*dfe94b16Srobert 
69*dfe94b16Srobert   DenseMap<const InputSection *, size_t> run();
70*dfe94b16Srobert 
71*dfe94b16Srobert private:
72*dfe94b16Srobert   std::vector<Cluster> clusters;
73*dfe94b16Srobert   std::vector<const InputSection *> sections;
74*dfe94b16Srobert };
75*dfe94b16Srobert // Maximum amount the combined cluster density can be worse than the original
76*dfe94b16Srobert // cluster to consider merging.
77*dfe94b16Srobert constexpr int MAX_DENSITY_DEGRADATION = 8;
78*dfe94b16Srobert } // end anonymous namespace
79*dfe94b16Srobert 
80*dfe94b16Srobert // Take the edge list in callGraphProfile, resolve symbol names to Symbols, and
81*dfe94b16Srobert // generate a graph between InputSections with the provided weights.
CallGraphSort(const MapVector<SectionPair,uint64_t> & profile)82*dfe94b16Srobert CallGraphSort::CallGraphSort(const MapVector<SectionPair, uint64_t> &profile) {
83*dfe94b16Srobert   DenseMap<const InputSection *, int> secToCluster;
84*dfe94b16Srobert 
85*dfe94b16Srobert   auto getOrCreateCluster = [&](const InputSection *isec) -> int {
86*dfe94b16Srobert     auto res = secToCluster.try_emplace(isec, clusters.size());
87*dfe94b16Srobert     if (res.second) {
88*dfe94b16Srobert       sections.push_back(isec);
89*dfe94b16Srobert       clusters.emplace_back(clusters.size(), isec->getSize());
90*dfe94b16Srobert     }
91*dfe94b16Srobert     return res.first->second;
92*dfe94b16Srobert   };
93*dfe94b16Srobert 
94*dfe94b16Srobert   // Create the graph
95*dfe94b16Srobert   for (const std::pair<SectionPair, uint64_t> &c : profile) {
96*dfe94b16Srobert     const auto fromSec = c.first.first->canonical();
97*dfe94b16Srobert     const auto toSec = c.first.second->canonical();
98*dfe94b16Srobert     uint64_t weight = c.second;
99*dfe94b16Srobert     // Ignore edges between input sections belonging to different output
100*dfe94b16Srobert     // sections.  This is done because otherwise we would end up with clusters
101*dfe94b16Srobert     // containing input sections that can't actually be placed adjacently in the
102*dfe94b16Srobert     // output.  This messes with the cluster size and density calculations.  We
103*dfe94b16Srobert     // would also end up moving input sections in other output sections without
104*dfe94b16Srobert     // moving them closer to what calls them.
105*dfe94b16Srobert     if (fromSec->parent != toSec->parent)
106*dfe94b16Srobert       continue;
107*dfe94b16Srobert 
108*dfe94b16Srobert     int from = getOrCreateCluster(fromSec);
109*dfe94b16Srobert     int to = getOrCreateCluster(toSec);
110*dfe94b16Srobert 
111*dfe94b16Srobert     clusters[to].weight += weight;
112*dfe94b16Srobert 
113*dfe94b16Srobert     if (from == to)
114*dfe94b16Srobert       continue;
115*dfe94b16Srobert 
116*dfe94b16Srobert     // Remember the best edge.
117*dfe94b16Srobert     Cluster &toC = clusters[to];
118*dfe94b16Srobert     if (toC.bestPred.from == -1 || toC.bestPred.weight < weight) {
119*dfe94b16Srobert       toC.bestPred.from = from;
120*dfe94b16Srobert       toC.bestPred.weight = weight;
121*dfe94b16Srobert     }
122*dfe94b16Srobert   }
123*dfe94b16Srobert   for (Cluster &c : clusters)
124*dfe94b16Srobert     c.initialWeight = c.weight;
125*dfe94b16Srobert }
126*dfe94b16Srobert 
127*dfe94b16Srobert // It's bad to merge clusters which would degrade the density too much.
isNewDensityBad(Cluster & a,Cluster & b)128*dfe94b16Srobert static bool isNewDensityBad(Cluster &a, Cluster &b) {
129*dfe94b16Srobert   double newDensity = double(a.weight + b.weight) / double(a.size + b.size);
130*dfe94b16Srobert   return newDensity < a.getDensity() / MAX_DENSITY_DEGRADATION;
131*dfe94b16Srobert }
132*dfe94b16Srobert 
133*dfe94b16Srobert // Find the leader of V's belonged cluster (represented as an equivalence
134*dfe94b16Srobert // class). We apply union-find path-halving technique (simple to implement) in
135*dfe94b16Srobert // the meantime as it decreases depths and the time complexity.
getLeader(std::vector<int> & leaders,int v)136*dfe94b16Srobert static int getLeader(std::vector<int> &leaders, int v) {
137*dfe94b16Srobert   while (leaders[v] != v) {
138*dfe94b16Srobert     leaders[v] = leaders[leaders[v]];
139*dfe94b16Srobert     v = leaders[v];
140*dfe94b16Srobert   }
141*dfe94b16Srobert   return v;
142*dfe94b16Srobert }
143*dfe94b16Srobert 
mergeClusters(std::vector<Cluster> & cs,Cluster & into,int intoIdx,Cluster & from,int fromIdx)144*dfe94b16Srobert static void mergeClusters(std::vector<Cluster> &cs, Cluster &into, int intoIdx,
145*dfe94b16Srobert                           Cluster &from, int fromIdx) {
146*dfe94b16Srobert   int tail1 = into.prev, tail2 = from.prev;
147*dfe94b16Srobert   into.prev = tail2;
148*dfe94b16Srobert   cs[tail2].next = intoIdx;
149*dfe94b16Srobert   from.prev = tail1;
150*dfe94b16Srobert   cs[tail1].next = fromIdx;
151*dfe94b16Srobert   into.size += from.size;
152*dfe94b16Srobert   into.weight += from.weight;
153*dfe94b16Srobert   from.size = 0;
154*dfe94b16Srobert   from.weight = 0;
155*dfe94b16Srobert }
156*dfe94b16Srobert 
157*dfe94b16Srobert // Group InputSections into clusters using the Call-Chain Clustering heuristic
158*dfe94b16Srobert // then sort the clusters by density.
run()159*dfe94b16Srobert DenseMap<const InputSection *, size_t> CallGraphSort::run() {
160*dfe94b16Srobert   const uint64_t maxClusterSize = target->getPageSize();
161*dfe94b16Srobert 
162*dfe94b16Srobert   // Cluster indices sorted by density.
163*dfe94b16Srobert   std::vector<int> sorted(clusters.size());
164*dfe94b16Srobert   // For union-find.
165*dfe94b16Srobert   std::vector<int> leaders(clusters.size());
166*dfe94b16Srobert 
167*dfe94b16Srobert   std::iota(leaders.begin(), leaders.end(), 0);
168*dfe94b16Srobert   std::iota(sorted.begin(), sorted.end(), 0);
169*dfe94b16Srobert 
170*dfe94b16Srobert   llvm::stable_sort(sorted, [&](int a, int b) {
171*dfe94b16Srobert     return clusters[a].getDensity() > clusters[b].getDensity();
172*dfe94b16Srobert   });
173*dfe94b16Srobert 
174*dfe94b16Srobert   for (int l : sorted) {
175*dfe94b16Srobert     // The cluster index is the same as the index of its leader here because
176*dfe94b16Srobert     // clusters[L] has not been merged into another cluster yet.
177*dfe94b16Srobert     Cluster &c = clusters[l];
178*dfe94b16Srobert 
179*dfe94b16Srobert     // Don't consider merging if the edge is unlikely.
180*dfe94b16Srobert     if (c.bestPred.from == -1 || c.bestPred.weight * 10 <= c.initialWeight)
181*dfe94b16Srobert       continue;
182*dfe94b16Srobert 
183*dfe94b16Srobert     int predL = getLeader(leaders, c.bestPred.from);
184*dfe94b16Srobert     // Already in the same cluster.
185*dfe94b16Srobert     if (l == predL)
186*dfe94b16Srobert       continue;
187*dfe94b16Srobert 
188*dfe94b16Srobert     Cluster *predC = &clusters[predL];
189*dfe94b16Srobert     if (c.size + predC->size > maxClusterSize)
190*dfe94b16Srobert       continue;
191*dfe94b16Srobert 
192*dfe94b16Srobert     if (isNewDensityBad(*predC, c))
193*dfe94b16Srobert       continue;
194*dfe94b16Srobert 
195*dfe94b16Srobert     leaders[l] = predL;
196*dfe94b16Srobert     mergeClusters(clusters, *predC, predL, c, l);
197*dfe94b16Srobert   }
198*dfe94b16Srobert   // Sort remaining non-empty clusters by density.
199*dfe94b16Srobert   sorted.clear();
200*dfe94b16Srobert   for (int i = 0, e = (int)clusters.size(); i != e; ++i)
201*dfe94b16Srobert     if (clusters[i].size > 0)
202*dfe94b16Srobert       sorted.push_back(i);
203*dfe94b16Srobert   llvm::stable_sort(sorted, [&](int a, int b) {
204*dfe94b16Srobert     return clusters[a].getDensity() > clusters[b].getDensity();
205*dfe94b16Srobert   });
206*dfe94b16Srobert 
207*dfe94b16Srobert   DenseMap<const InputSection *, size_t> orderMap;
208*dfe94b16Srobert 
209*dfe94b16Srobert   // Sections will be sorted by decreasing order. Absent sections will have
210*dfe94b16Srobert   // priority 0 and be placed at the end of sections.
211*dfe94b16Srobert   // NB: This is opposite from COFF/ELF to be compatible with the existing
212*dfe94b16Srobert   // order-file code.
213*dfe94b16Srobert   int curOrder = highestAvailablePriority;
214*dfe94b16Srobert   for (int leader : sorted) {
215*dfe94b16Srobert     for (int i = leader;;) {
216*dfe94b16Srobert       orderMap[sections[i]] = curOrder--;
217*dfe94b16Srobert       i = clusters[i].next;
218*dfe94b16Srobert       if (i == leader)
219*dfe94b16Srobert         break;
220*dfe94b16Srobert     }
221*dfe94b16Srobert   }
222*dfe94b16Srobert   if (!config->printSymbolOrder.empty()) {
223*dfe94b16Srobert     std::error_code ec;
224*dfe94b16Srobert     raw_fd_ostream os(config->printSymbolOrder, ec, sys::fs::OF_None);
225*dfe94b16Srobert     if (ec) {
226*dfe94b16Srobert       error("cannot open " + config->printSymbolOrder + ": " + ec.message());
227*dfe94b16Srobert       return orderMap;
228*dfe94b16Srobert     }
229*dfe94b16Srobert     // Print the symbols ordered by C3, in the order of decreasing curOrder
230*dfe94b16Srobert     // Instead of sorting all the orderMap, just repeat the loops above.
231*dfe94b16Srobert     for (int leader : sorted)
232*dfe94b16Srobert       for (int i = leader;;) {
233*dfe94b16Srobert         const InputSection *isec = sections[i];
234*dfe94b16Srobert         // Search all the symbols in the file of the section
235*dfe94b16Srobert         // and find out a Defined symbol with name that is within the
236*dfe94b16Srobert         // section.
237*dfe94b16Srobert         for (Symbol *sym : isec->getFile()->symbols) {
238*dfe94b16Srobert           if (auto *d = dyn_cast_or_null<Defined>(sym)) {
239*dfe94b16Srobert             if (d->isec == isec)
240*dfe94b16Srobert               os << sym->getName() << "\n";
241*dfe94b16Srobert           }
242*dfe94b16Srobert         }
243*dfe94b16Srobert         i = clusters[i].next;
244*dfe94b16Srobert         if (i == leader)
245*dfe94b16Srobert           break;
246*dfe94b16Srobert       }
247*dfe94b16Srobert   }
248*dfe94b16Srobert 
249*dfe94b16Srobert   return orderMap;
250*dfe94b16Srobert }
251*dfe94b16Srobert 
252*dfe94b16Srobert std::optional<size_t>
getSymbolPriority(const Defined * sym)253*dfe94b16Srobert macho::PriorityBuilder::getSymbolPriority(const Defined *sym) {
254*dfe94b16Srobert   if (sym->isAbsolute())
255*dfe94b16Srobert     return std::nullopt;
256*dfe94b16Srobert 
257*dfe94b16Srobert   auto it = priorities.find(sym->getName());
258*dfe94b16Srobert   if (it == priorities.end())
259*dfe94b16Srobert     return std::nullopt;
260*dfe94b16Srobert   const SymbolPriorityEntry &entry = it->second;
261*dfe94b16Srobert   const InputFile *f = sym->isec->getFile();
262*dfe94b16Srobert   if (!f)
263*dfe94b16Srobert     return entry.anyObjectFile;
264*dfe94b16Srobert   // We don't use toString(InputFile *) here because it returns the full path
265*dfe94b16Srobert   // for object files, and we only want the basename.
266*dfe94b16Srobert   StringRef filename;
267*dfe94b16Srobert   if (f->archiveName.empty())
268*dfe94b16Srobert     filename = path::filename(f->getName());
269*dfe94b16Srobert   else
270*dfe94b16Srobert     filename = saver().save(path::filename(f->archiveName) + "(" +
271*dfe94b16Srobert                             path::filename(f->getName()) + ")");
272*dfe94b16Srobert   return std::max(entry.objectFiles.lookup(filename), entry.anyObjectFile);
273*dfe94b16Srobert }
274*dfe94b16Srobert 
extractCallGraphProfile()275*dfe94b16Srobert void macho::PriorityBuilder::extractCallGraphProfile() {
276*dfe94b16Srobert   TimeTraceScope timeScope("Extract call graph profile");
277*dfe94b16Srobert   bool hasOrderFile = !priorities.empty();
278*dfe94b16Srobert   for (const InputFile *file : inputFiles) {
279*dfe94b16Srobert     auto *obj = dyn_cast_or_null<ObjFile>(file);
280*dfe94b16Srobert     if (!obj)
281*dfe94b16Srobert       continue;
282*dfe94b16Srobert     for (const CallGraphEntry &entry : obj->callGraph) {
283*dfe94b16Srobert       assert(entry.fromIndex < obj->symbols.size() &&
284*dfe94b16Srobert              entry.toIndex < obj->symbols.size());
285*dfe94b16Srobert       auto *fromSym = dyn_cast_or_null<Defined>(obj->symbols[entry.fromIndex]);
286*dfe94b16Srobert       auto *toSym = dyn_cast_or_null<Defined>(obj->symbols[entry.toIndex]);
287*dfe94b16Srobert       if (fromSym && toSym &&
288*dfe94b16Srobert           (!hasOrderFile ||
289*dfe94b16Srobert            (!getSymbolPriority(fromSym) && !getSymbolPriority(toSym))))
290*dfe94b16Srobert         callGraphProfile[{fromSym->isec, toSym->isec}] += entry.count;
291*dfe94b16Srobert     }
292*dfe94b16Srobert   }
293*dfe94b16Srobert }
294*dfe94b16Srobert 
parseOrderFile(StringRef path)295*dfe94b16Srobert void macho::PriorityBuilder::parseOrderFile(StringRef path) {
296*dfe94b16Srobert   assert(callGraphProfile.empty() &&
297*dfe94b16Srobert          "Order file must be parsed before call graph profile is processed");
298*dfe94b16Srobert   std::optional<MemoryBufferRef> buffer = readFile(path);
299*dfe94b16Srobert   if (!buffer) {
300*dfe94b16Srobert     error("Could not read order file at " + path);
301*dfe94b16Srobert     return;
302*dfe94b16Srobert   }
303*dfe94b16Srobert 
304*dfe94b16Srobert   MemoryBufferRef mbref = *buffer;
305*dfe94b16Srobert   for (StringRef line : args::getLines(mbref)) {
306*dfe94b16Srobert     StringRef objectFile, symbol;
307*dfe94b16Srobert     line = line.take_until([](char c) { return c == '#'; }); // ignore comments
308*dfe94b16Srobert     line = line.ltrim();
309*dfe94b16Srobert 
310*dfe94b16Srobert     CPUType cpuType = StringSwitch<CPUType>(line)
311*dfe94b16Srobert                           .StartsWith("i386:", CPU_TYPE_I386)
312*dfe94b16Srobert                           .StartsWith("x86_64:", CPU_TYPE_X86_64)
313*dfe94b16Srobert                           .StartsWith("arm:", CPU_TYPE_ARM)
314*dfe94b16Srobert                           .StartsWith("arm64:", CPU_TYPE_ARM64)
315*dfe94b16Srobert                           .StartsWith("ppc:", CPU_TYPE_POWERPC)
316*dfe94b16Srobert                           .StartsWith("ppc64:", CPU_TYPE_POWERPC64)
317*dfe94b16Srobert                           .Default(CPU_TYPE_ANY);
318*dfe94b16Srobert 
319*dfe94b16Srobert     if (cpuType != CPU_TYPE_ANY && cpuType != target->cpuType)
320*dfe94b16Srobert       continue;
321*dfe94b16Srobert 
322*dfe94b16Srobert     // Drop the CPU type as well as the colon
323*dfe94b16Srobert     if (cpuType != CPU_TYPE_ANY)
324*dfe94b16Srobert       line = line.drop_until([](char c) { return c == ':'; }).drop_front();
325*dfe94b16Srobert 
326*dfe94b16Srobert     constexpr std::array<StringRef, 2> fileEnds = {".o:", ".o):"};
327*dfe94b16Srobert     for (StringRef fileEnd : fileEnds) {
328*dfe94b16Srobert       size_t pos = line.find(fileEnd);
329*dfe94b16Srobert       if (pos != StringRef::npos) {
330*dfe94b16Srobert         // Split the string around the colon
331*dfe94b16Srobert         objectFile = line.take_front(pos + fileEnd.size() - 1);
332*dfe94b16Srobert         line = line.drop_front(pos + fileEnd.size());
333*dfe94b16Srobert         break;
334*dfe94b16Srobert       }
335*dfe94b16Srobert     }
336*dfe94b16Srobert     symbol = line.trim();
337*dfe94b16Srobert 
338*dfe94b16Srobert     if (!symbol.empty()) {
339*dfe94b16Srobert       SymbolPriorityEntry &entry = priorities[symbol];
340*dfe94b16Srobert       if (!objectFile.empty())
341*dfe94b16Srobert         entry.objectFiles.insert(
342*dfe94b16Srobert             std::make_pair(objectFile, highestAvailablePriority));
343*dfe94b16Srobert       else
344*dfe94b16Srobert         entry.anyObjectFile =
345*dfe94b16Srobert             std::max(entry.anyObjectFile, highestAvailablePriority);
346*dfe94b16Srobert     }
347*dfe94b16Srobert 
348*dfe94b16Srobert     --highestAvailablePriority;
349*dfe94b16Srobert   }
350*dfe94b16Srobert }
351*dfe94b16Srobert 
352*dfe94b16Srobert DenseMap<const InputSection *, size_t>
buildInputSectionPriorities()353*dfe94b16Srobert macho::PriorityBuilder::buildInputSectionPriorities() {
354*dfe94b16Srobert   DenseMap<const InputSection *, size_t> sectionPriorities;
355*dfe94b16Srobert   if (config->callGraphProfileSort) {
356*dfe94b16Srobert     // Sort sections by the profile data provided by __LLVM,__cg_profile
357*dfe94b16Srobert     // sections.
358*dfe94b16Srobert     //
359*dfe94b16Srobert     // This first builds a call graph based on the profile data then merges
360*dfe94b16Srobert     // sections according to the C³ heuristic. All clusters are then sorted by a
361*dfe94b16Srobert     // density metric to further improve locality.
362*dfe94b16Srobert     TimeTraceScope timeScope("Call graph profile sort");
363*dfe94b16Srobert     sectionPriorities = CallGraphSort(callGraphProfile).run();
364*dfe94b16Srobert   }
365*dfe94b16Srobert 
366*dfe94b16Srobert   if (priorities.empty())
367*dfe94b16Srobert     return sectionPriorities;
368*dfe94b16Srobert 
369*dfe94b16Srobert   auto addSym = [&](const Defined *sym) {
370*dfe94b16Srobert     std::optional<size_t> symbolPriority = getSymbolPriority(sym);
371*dfe94b16Srobert     if (!symbolPriority)
372*dfe94b16Srobert       return;
373*dfe94b16Srobert     size_t &priority = sectionPriorities[sym->isec];
374*dfe94b16Srobert     priority = std::max(priority, *symbolPriority);
375*dfe94b16Srobert   };
376*dfe94b16Srobert 
377*dfe94b16Srobert   // TODO: Make sure this handles weak symbols correctly.
378*dfe94b16Srobert   for (const InputFile *file : inputFiles) {
379*dfe94b16Srobert     if (isa<ObjFile>(file))
380*dfe94b16Srobert       for (Symbol *sym : file->symbols)
381*dfe94b16Srobert         if (auto *d = dyn_cast_or_null<Defined>(sym))
382*dfe94b16Srobert           addSym(d);
383*dfe94b16Srobert   }
384*dfe94b16Srobert 
385*dfe94b16Srobert   return sectionPriorities;
386*dfe94b16Srobert }
387