xref: /netbsd-src/tests/usr.bin/xlint/lint1/msg_338.c (revision b2baa50111d645353fa30b4deab0f79d93650c8c)
1*b2baa501Srillig /*	$NetBSD: msg_338.c,v 1.9 2023/03/28 14:44:35 rillig Exp $	*/
2746e9c89Srillig # 3 "msg_338.c"
3746e9c89Srillig 
4746e9c89Srillig // Test for message: option '%c' should be handled in the switch [338]
5746e9c89Srillig 
6*b2baa501Srillig /* lint1-extra-flags: -X 351 */
7*b2baa501Srillig 
8746e9c89Srillig int getopt(int, char *const *, const char *);
9746e9c89Srillig extern char *optarg;
10746e9c89Srillig 
11746e9c89Srillig int
main(int argc,char ** argv)12746e9c89Srillig main(int argc, char **argv)
13746e9c89Srillig {
14746e9c89Srillig 	int o;
15746e9c89Srillig 
16ec42194bSrillig 	/* expect+2: warning: option 'c' should be handled in the switch [338] */
17ec42194bSrillig 	/* expect+1: warning: option 'd' should be handled in the switch [338] */
18ec42194bSrillig 	while ((o = getopt(argc, argv, "a:bc:d")) != -1) {
19746e9c89Srillig 		switch (o) {
20746e9c89Srillig 		case 'a':
21746e9c89Srillig 			break;
22746e9c89Srillig 		case 'b':
23746e9c89Srillig 			/*
24746e9c89Srillig 			 * The following while loop must not finish the check
25746e9c89Srillig 			 * for the getopt options.
26746e9c89Srillig 			 */
27746e9c89Srillig 			while (optarg[0] != '\0')
28746e9c89Srillig 				optarg++;
29746e9c89Srillig 			break;
30ec42194bSrillig 		case 'e':
31ec42194bSrillig 			/* expect-1: warning: option 'e' should be listed in the options string [339] */
32746e9c89Srillig 			break;
33ec42194bSrillig 		case 'f':
34ec42194bSrillig 			/* expect-1: warning: option 'f' should be listed in the options string [339] */
35746e9c89Srillig 			/*
36746e9c89Srillig 			 * The case labels in nested switch statements are
37746e9c89Srillig 			 * ignored by the check for getopt options.
38746e9c89Srillig 			 */
39746e9c89Srillig 			switch (optarg[0]) {
40746e9c89Srillig 			case 'X':
41746e9c89Srillig 				break;
42746e9c89Srillig 			}
43746e9c89Srillig 			break;
44746e9c89Srillig 		case '?':
45746e9c89Srillig 		default:
46746e9c89Srillig 			break;
47746e9c89Srillig 		}
48746e9c89Srillig 	}
49746e9c89Srillig 
506e51f5afSrillig 	/* A while loop that is not related to getopt is simply skipped. */
516e51f5afSrillig 	while (o != 0) {
526e51f5afSrillig 		switch (o) {
536e51f5afSrillig 		case '?':
546e51f5afSrillig 			o = ':';
556e51f5afSrillig 		}
566e51f5afSrillig 	}
576e51f5afSrillig 
58746e9c89Srillig 	return 0;
59746e9c89Srillig }
60da417136Srillig 
61da417136Srillig void usage(void);
62da417136Srillig 
634fce6b72Srillig /*
644fce6b72Srillig  * Before ckgetopt.c 1.11 from 2021-08-23, lint wrongly warned about a
654fce6b72Srillig  * missing '?' in the switch statement, even though it was there.
664fce6b72Srillig  *
674fce6b72Srillig  * Seen in usr.bin/ftp/main.c 1.127 from 2020-07-18.
684fce6b72Srillig  */
69da417136Srillig int
question_option(int argc,char ** argv)70da417136Srillig question_option(int argc, char **argv)
71da417136Srillig {
72da417136Srillig 	int c;
73da417136Srillig 
74da417136Srillig 	while ((c = getopt(argc, argv, "?x")) != -1) {
75da417136Srillig 		switch (c) {
76da417136Srillig 		case 'x':
77da417136Srillig 			break;
78da417136Srillig 		case '?':
79da417136Srillig 			usage();
80da417136Srillig 			return 0;
81da417136Srillig 		default:
82da417136Srillig 			usage();
83da417136Srillig 			return 1;
84da417136Srillig 		}
85da417136Srillig 	}
86da417136Srillig 	return 0;
87da417136Srillig }
887b18e026Srillig 
897b18e026Srillig /*
907b18e026Srillig  * If the first character of the options string is ':', getopt does not print
917b18e026Srillig  * its own error messages. Getopt returns ':' if an option is missing its
927b18e026Srillig  * argument; that is handled by the 'default:' already.
937b18e026Srillig  */
947b18e026Srillig int
suppress_errors(int argc,char ** argv)957b18e026Srillig suppress_errors(int argc, char **argv)
967b18e026Srillig {
977b18e026Srillig 	int c;
987b18e026Srillig 
997b18e026Srillig 	/* expect+1: warning: option 'o' should be handled in the switch [338] */
1007b18e026Srillig 	while ((c = getopt(argc, argv, ":b:o")) != -1) {
1017b18e026Srillig 		switch (c) {
1027b18e026Srillig 		case 'b':
1037b18e026Srillig 			return 'b';
1047b18e026Srillig 		default:
1057b18e026Srillig 			usage();
1067b18e026Srillig 		}
1077b18e026Srillig 	}
1087b18e026Srillig 	return 0;
1097b18e026Srillig }
1107b18e026Srillig 
1117b18e026Srillig /*
1127b18e026Srillig  * If the first character of the options string is ':', getopt returns ':'
1137b18e026Srillig  * if an option is missing its argument. This condition can be handled
1147b18e026Srillig  * separately from '?', which getopt returns for unknown options.
1157b18e026Srillig  */
1167b18e026Srillig int
missing_argument(int argc,char ** argv)1177b18e026Srillig missing_argument(int argc, char **argv)
1187b18e026Srillig {
1197b18e026Srillig 	int c;
1207b18e026Srillig 
1217b18e026Srillig 	/* expect+1: warning: option 'o' should be handled in the switch [338] */
1227b18e026Srillig 	while ((c = getopt(argc, argv, ":b:o")) != -1) {
1237b18e026Srillig 		switch (c) {
1247b18e026Srillig 		case 'b':
1257b18e026Srillig 			return 'b';
1267b18e026Srillig 		case ':':
1277b18e026Srillig 			return 'm';
1287b18e026Srillig 		default:
1297b18e026Srillig 			usage();
1307b18e026Srillig 		}
1317b18e026Srillig 	}
1327b18e026Srillig 	return 0;
1337b18e026Srillig }
1347b18e026Srillig 
1357b18e026Srillig /*
1367b18e026Srillig  * Getopt only returns ':' if ':' is the first character in the options
1377b18e026Srillig  * string. Everywhere else, a ':' marks the preceding option as having a
1387b18e026Srillig  * required argument. In theory, if the options string contained "a::x",
1397b18e026Srillig  * that could be interpreted as '-a argument', followed by '-:' and '-x',
1407b18e026Srillig  * but nobody does that.
1417b18e026Srillig  */
1427b18e026Srillig int
unreachable_colon(int argc,char ** argv)1437b18e026Srillig unreachable_colon(int argc, char **argv)
1447b18e026Srillig {
1457b18e026Srillig 	int c;
1467b18e026Srillig 
1477b18e026Srillig 	/* expect+1: warning: option 'b' should be handled in the switch [338] */
1487b18e026Srillig 	while ((c = getopt(argc, argv, "b:")) != -1) {
1497b18e026Srillig 		switch (c) {
150dff6fadbSrillig 		/* expect+1: warning: option ':' should be listed in the options string [339] */
1517b18e026Srillig 		case ':':
1527b18e026Srillig 			return 'm';
1537b18e026Srillig 		default:
1547b18e026Srillig 			usage();
1557b18e026Srillig 		}
1567b18e026Srillig 	}
1577b18e026Srillig 	return 0;
1587b18e026Srillig }
159