1*00831369Sandvar /* $NetBSD: t_zombie.c,v 1.3 2022/05/24 20:08:38 andvar Exp $ */
2ce34db38Skamil
3ce34db38Skamil /*-
4ce34db38Skamil * Copyright (c) 2018 The NetBSD Foundation, Inc.
5ce34db38Skamil * All rights reserved.
6ce34db38Skamil *
7ce34db38Skamil * Redistribution and use in source and binary forms, with or without
8ce34db38Skamil * modification, are permitted provided that the following conditions
9ce34db38Skamil * are met:
10ce34db38Skamil * 1. Redistributions of source code must retain the above copyright
11ce34db38Skamil * notice, this list of conditions and the following disclaimer.
12ce34db38Skamil * 2. Redistributions in binary form must reproduce the above copyright
13ce34db38Skamil * notice, this list of conditions and the following disclaimer in the
14ce34db38Skamil * documentation and/or other materials provided with the distribution.
15ce34db38Skamil *
16ce34db38Skamil * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
17ce34db38Skamil * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
18ce34db38Skamil * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
19ce34db38Skamil * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
20ce34db38Skamil * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
21ce34db38Skamil * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
22ce34db38Skamil * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
23ce34db38Skamil * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
24ce34db38Skamil * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
25ce34db38Skamil * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
26ce34db38Skamil * POSSIBILITY OF SUCH DAMAGE.
27ce34db38Skamil */
28ce34db38Skamil
29ce34db38Skamil #include <sys/cdefs.h>
30ce34db38Skamil __COPYRIGHT("@(#) Copyright (c) 2018\
31ce34db38Skamil The NetBSD Foundation, inc. All rights reserved.");
32*00831369Sandvar __RCSID("$NetBSD: t_zombie.c,v 1.3 2022/05/24 20:08:38 andvar Exp $");
33ce34db38Skamil
34ce34db38Skamil #include <sys/types.h>
35ce34db38Skamil #include <sys/sysctl.h>
36ce34db38Skamil #include <sys/wait.h>
37ce34db38Skamil #include <errno.h>
38ce34db38Skamil #include <stdbool.h>
39ce34db38Skamil #include <stddef.h>
40ce34db38Skamil #include <stdio.h>
41ce34db38Skamil #include <stdlib.h>
42ce34db38Skamil #include <signal.h>
43ce34db38Skamil #include <time.h>
44ce34db38Skamil #include <unistd.h>
45ce34db38Skamil #include <err.h>
46ce34db38Skamil
47ce34db38Skamil #include <atf-c.h>
48ce34db38Skamil
49ce34db38Skamil static int debug = 0;
50ce34db38Skamil
51ce34db38Skamil #define DPRINTF(a, ...) \
52ce34db38Skamil do { \
53ce34db38Skamil if (debug) printf(a, ##__VA_ARGS__); \
54ce34db38Skamil } while (/*CONSTCOND*/0)
55ce34db38Skamil
56ce34db38Skamil /*
57ce34db38Skamil * A child process cannot call atf functions and expect them to magically
58ce34db38Skamil * work like in the parent.
59ce34db38Skamil * The printf(3) messaging from a child will not work out of the box as well
60*00831369Sandvar * without establishing a communication protocol with its parent. To not
61ce34db38Skamil * overcomplicate the tests - do not log from a child and use err(3)/errx(3)
62ce34db38Skamil * wrapped with ASSERT_EQ()/ASSERT_NEQ() as that is guaranteed to work.
63ce34db38Skamil */
64ce34db38Skamil #define ASSERT_EQ(x, y) \
65ce34db38Skamil do { \
66ce34db38Skamil uintmax_t vx = (x); \
67ce34db38Skamil uintmax_t vy = (y); \
68ce34db38Skamil int ret = vx == vy; \
69ce34db38Skamil if (!ret) \
70ce34db38Skamil errx(EXIT_FAILURE, "%s:%d %s(): Assertion failed for: " \
71ce34db38Skamil "%s(%ju) == %s(%ju)", __FILE__, __LINE__, __func__, \
72ce34db38Skamil #x, vx, #y, vy); \
73ce34db38Skamil } while (/*CONSTCOND*/0)
74ce34db38Skamil
75ce34db38Skamil #define ASSERT_NEQ(x, y) \
76ce34db38Skamil do { \
77ce34db38Skamil uintmax_t vx = (x); \
78ce34db38Skamil uintmax_t vy = (y); \
79ce34db38Skamil int ret = vx != vy; \
80ce34db38Skamil if (!ret) \
81ce34db38Skamil errx(EXIT_FAILURE, "%s:%d %s(): Assertion failed for: " \
82ce34db38Skamil "%s(%ju) != %s(%ju)", __FILE__, __LINE__, __func__, \
83ce34db38Skamil #x, vx, #y, vy); \
84ce34db38Skamil } while (/*CONSTCOND*/0)
85ce34db38Skamil
86ce34db38Skamil #define ASSERT(x) \
87ce34db38Skamil do { \
88ce34db38Skamil int ret = (x); \
89ce34db38Skamil if (!ret) \
90ce34db38Skamil errx(EXIT_FAILURE, "%s:%d %s(): Assertion failed for: %s", \
91ce34db38Skamil __FILE__, __LINE__, __func__, #x); \
92ce34db38Skamil } while (/*CONSTCOND*/0)
93ce34db38Skamil
94ce34db38Skamil static bool
check_zombie(pid_t process)95ce34db38Skamil check_zombie(pid_t process)
96ce34db38Skamil {
97ce34db38Skamil struct kinfo_proc2 p;
98ce34db38Skamil size_t len = sizeof(p);
99ce34db38Skamil
100ce34db38Skamil const int name[] = {
101ce34db38Skamil [0] = CTL_KERN,
102ce34db38Skamil [1] = KERN_PROC2,
103ce34db38Skamil [2] = KERN_PROC_PID,
104ce34db38Skamil [3] = process,
105ce34db38Skamil [4] = sizeof(p),
106ce34db38Skamil [5] = 1
107ce34db38Skamil };
108ce34db38Skamil
109ce34db38Skamil const size_t namelen = __arraycount(name);
110ce34db38Skamil
111ce34db38Skamil ASSERT_EQ(sysctl(name, namelen, &p, &len, NULL, 0), 0);
112ce34db38Skamil
113ce34db38Skamil return (p.p_stat == LSZOMB);
114ce34db38Skamil }
115ce34db38Skamil
116ce34db38Skamil static void __used
await_zombie(pid_t process)117ce34db38Skamil await_zombie(pid_t process)
118ce34db38Skamil {
119ce34db38Skamil
120ce34db38Skamil /* Await the process becoming a zombie */
121ce34db38Skamil while (!check_zombie(process)) {
122ce34db38Skamil ASSERT_EQ(usleep(100), 0);
123ce34db38Skamil }
124ce34db38Skamil }
125ce34db38Skamil
126ce34db38Skamil static void
signal_raw(int sig)127ce34db38Skamil signal_raw(int sig)
128ce34db38Skamil {
129ce34db38Skamil int status;
130ce34db38Skamil pid_t child1, child2, pid;
131ce34db38Skamil
132ce34db38Skamil child1 = atf_utils_fork();
133ed68aafdSkamil ATF_REQUIRE(child1 != -1);
134ce34db38Skamil if (child1 == 0) {
135ce34db38Skamil /* Just die and turn into a zombie */
136ce34db38Skamil _exit(0);
137ce34db38Skamil }
138ce34db38Skamil
139ce34db38Skamil child2 = atf_utils_fork();
140ed68aafdSkamil ATF_REQUIRE(child2 != -1);
141ce34db38Skamil if (child2 == 0) {
142ce34db38Skamil await_zombie(child1);
143ce34db38Skamil
144ce34db38Skamil /*
145ce34db38Skamil * zombie does not process signals
146ce34db38Skamil * POSIX requires that zombie does not set errno ESRCH
147ce34db38Skamil * return value of kill() for a zombie is not specified
148ce34db38Skamil *
149ce34db38Skamil * Try to emit a signal towards it from an unrelated process.
150ce34db38Skamil */
151ce34db38Skamil errno = 0;
152ce34db38Skamil kill(child1, sig);
153ce34db38Skamil ASSERT_NEQ(errno, ESRCH);
154ce34db38Skamil
155ce34db38Skamil /* A zombie is still a zombie waiting for collecting */
156ce34db38Skamil ASSERT(check_zombie(child1));
157ce34db38Skamil
158ce34db38Skamil _exit(0);
159ce34db38Skamil }
160ce34db38Skamil
161ce34db38Skamil pid = waitpid(child2, &status, WEXITED);
162ce34db38Skamil ATF_REQUIRE_EQ(pid, child2);
163ce34db38Skamil ATF_REQUIRE(WIFEXITED(status));
164ce34db38Skamil ATF_REQUIRE(!WIFCONTINUED(status));
165ce34db38Skamil ATF_REQUIRE(!WIFSIGNALED(status));
166ce34db38Skamil ATF_REQUIRE(!WIFSTOPPED(status));
167ce34db38Skamil ATF_REQUIRE_EQ(WEXITSTATUS(status), 0);
168ce34db38Skamil
169ce34db38Skamil /* Assert that child1 is still a zombie after collecting child2 */
170ce34db38Skamil ATF_REQUIRE(check_zombie(child1));
171ce34db38Skamil
172ce34db38Skamil /*
173ce34db38Skamil * zombie does not process signals
174ce34db38Skamil * POSIX requires that zombie does not set errno ESRCH
175ce34db38Skamil * return value of kill() for a zombie is not specified
176ce34db38Skamil *
177ce34db38Skamil * Try to emit a signal towards it from the parent.
178ce34db38Skamil */
179ce34db38Skamil errno = 0;
180ce34db38Skamil kill(child1, sig);
181ce34db38Skamil // ATF_CHECK_NEQ not available
182ce34db38Skamil ASSERT_NEQ(errno, ESRCH);
183ce34db38Skamil
184ce34db38Skamil /* Assert that child1 is still a zombie after emitting a signal */
185ce34db38Skamil ATF_REQUIRE(check_zombie(child1));
186ce34db38Skamil
187ce34db38Skamil pid = waitpid(child1, &status, WEXITED);
188ce34db38Skamil ATF_REQUIRE_EQ(pid, child1);
189ce34db38Skamil ATF_REQUIRE(WIFEXITED(status));
190ce34db38Skamil ATF_REQUIRE(!WIFCONTINUED(status));
191ce34db38Skamil ATF_REQUIRE(!WIFSIGNALED(status));
192ce34db38Skamil ATF_REQUIRE(!WIFSTOPPED(status));
193ce34db38Skamil ATF_REQUIRE_EQ(WEXITSTATUS(status), 0);
194ce34db38Skamil }
195ce34db38Skamil
196ce34db38Skamil #define KILLABLE(test, sig) \
197ce34db38Skamil ATF_TC(test); \
198ce34db38Skamil ATF_TC_HEAD(test, tc) \
199ce34db38Skamil { \
200ce34db38Skamil \
201ce34db38Skamil atf_tc_set_md_var(tc, "descr", \
202ce34db38Skamil "process is not killable with " #sig); \
203ce34db38Skamil } \
204ce34db38Skamil \
205ce34db38Skamil ATF_TC_BODY(test, tc) \
206ce34db38Skamil { \
207ce34db38Skamil \
208ce34db38Skamil signal_raw(sig); \
209ce34db38Skamil }
210ce34db38Skamil
211ce34db38Skamil KILLABLE(signal1, SIGKILL) /* non-maskable */
212ce34db38Skamil KILLABLE(signal2, SIGSTOP) /* non-maskable */
213ce34db38Skamil KILLABLE(signal3, SIGABRT) /* regular abort trap */
214ce34db38Skamil KILLABLE(signal4, SIGHUP) /* hangup */
215ce34db38Skamil KILLABLE(signal5, SIGCONT) /* continued? */
216ce34db38Skamil
217ce34db38Skamil ATF_TC(race1);
ATF_TC_HEAD(race1,tc)218ce34db38Skamil ATF_TC_HEAD(race1, tc)
219ce34db38Skamil {
220ce34db38Skamil
221ce34db38Skamil atf_tc_set_md_var(tc, "descr",
222ce34db38Skamil "check if there are any races with sending signals, killing and "
223ce34db38Skamil "lookup of a zombie");
224ce34db38Skamil }
225ce34db38Skamil
ATF_TC_BODY(race1,tc)226ce34db38Skamil ATF_TC_BODY(race1, tc)
227ce34db38Skamil {
228ce34db38Skamil time_t start, end;
229ce34db38Skamil double diff;
230ce34db38Skamil unsigned long N = 0;
231ce34db38Skamil int sig;
232ce34db38Skamil
233ce34db38Skamil /*
234ce34db38Skamil * Assert that a dying process can be correctly looked up
235ce34db38Skamil * with sysctl(3) kern.proc and operation KERN_PROC_PID.
236ce34db38Skamil *
237ce34db38Skamil * This test has been inspired by a bug fixed in
238ce34db38Skamil * sys/kern/kern_proc.c 1.211
239ce34db38Skamil * "Make sysctl_doeproc() more predictable"
240ce34db38Skamil */
241ce34db38Skamil
242ce34db38Skamil start = time(NULL);
243ce34db38Skamil while (true) {
244ce34db38Skamil /*
245ce34db38Skamil * A signal number does not matter, but it does not harm to
246ce34db38Skamil * randomize it.
247ce34db38Skamil *
248ce34db38Skamil * Skip signal 0 as sending to it to a zombie is not
249ce34db38Skamil * defined in POSIX, and explicitly discouraged.
250ce34db38Skamil */
251ce34db38Skamil sig = 1 + arc4random_uniform(NSIG - 2);
252ce34db38Skamil
253ce34db38Skamil DPRINTF("Step: %lu (signal: %s)\n", N, signalname(sig));
254ce34db38Skamil
255ce34db38Skamil signal_raw(sig);
256ce34db38Skamil end = time(NULL);
257ce34db38Skamil diff = difftime(end, start);
258ce34db38Skamil if (diff >= 5.0)
259ce34db38Skamil break;
260ce34db38Skamil ++N;
261ce34db38Skamil }
262ce34db38Skamil DPRINTF("Iterations: %lu\n", N);
263ce34db38Skamil }
264ce34db38Skamil
ATF_TP_ADD_TCS(tp)265ce34db38Skamil ATF_TP_ADD_TCS(tp)
266ce34db38Skamil {
267ce34db38Skamil ATF_TP_ADD_TC(tp, signal1);
268ce34db38Skamil ATF_TP_ADD_TC(tp, signal2);
269ce34db38Skamil ATF_TP_ADD_TC(tp, signal3);
270ce34db38Skamil ATF_TP_ADD_TC(tp, signal4);
271ce34db38Skamil ATF_TP_ADD_TC(tp, signal5);
272ce34db38Skamil
273ce34db38Skamil ATF_TP_ADD_TC(tp, race1);
274ce34db38Skamil
275ce34db38Skamil return atf_no_error();
276ce34db38Skamil }
277