xref: /netbsd-src/sys/kern/kern_module.c (revision aad9773e38ed2370a628a6416e098f9008fc10a7)
1 /*	$NetBSD: kern_module.c,v 1.102 2014/12/02 13:00:38 pooka Exp $	*/
2 
3 /*-
4  * Copyright (c) 2008 The NetBSD Foundation, Inc.
5  * All rights reserved.
6  *
7  * This code is derived from software developed for The NetBSD Foundation
8  * by Andrew Doran.
9  *
10  * Redistribution and use in source and binary forms, with or without
11  * modification, are permitted provided that the following conditions
12  * are met:
13  * 1. Redistributions of source code must retain the above copyright
14  *    notice, this list of conditions and the following disclaimer.
15  * 2. Redistributions in binary form must reproduce the above copyright
16  *    notice, this list of conditions and the following disclaimer in the
17  *    documentation and/or other materials provided with the distribution.
18  *
19  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
20  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
21  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
22  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
23  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
24  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
25  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
26  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
27  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
28  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
29  * POSSIBILITY OF SUCH DAMAGE.
30  */
31 
32 /*
33  * Kernel module support.
34  */
35 
36 #include <sys/cdefs.h>
37 __KERNEL_RCSID(0, "$NetBSD: kern_module.c,v 1.102 2014/12/02 13:00:38 pooka Exp $");
38 
39 #define _MODULE_INTERNAL
40 
41 #ifdef _KERNEL_OPT
42 #include "opt_ddb.h"
43 #include "opt_modular.h"
44 #endif
45 
46 #include <sys/param.h>
47 #include <sys/systm.h>
48 #include <sys/kernel.h>
49 #include <sys/proc.h>
50 #include <sys/kauth.h>
51 #include <sys/kobj.h>
52 #include <sys/kmem.h>
53 #include <sys/module.h>
54 #include <sys/kthread.h>
55 #include <sys/sysctl.h>
56 #include <sys/lock.h>
57 
58 #include <uvm/uvm_extern.h>
59 
60 struct vm_map *module_map;
61 char	*module_machine;
62 char	module_base[MODULE_BASE_SIZE];
63 
64 struct modlist        module_list = TAILQ_HEAD_INITIALIZER(module_list);
65 struct modlist        module_builtins = TAILQ_HEAD_INITIALIZER(module_builtins);
66 static struct modlist module_bootlist = TAILQ_HEAD_INITIALIZER(module_bootlist);
67 
68 static module_t	*module_active;
69 static bool	module_verbose_on;
70 #ifdef MODULAR_DEFAULT_AUTOLOAD
71 static bool	module_autoload_on = true;
72 #else
73 static bool	module_autoload_on = false;
74 #endif
75 u_int		module_count;
76 u_int		module_builtinlist;
77 u_int		module_autotime = 10;
78 u_int		module_gen = 1;
79 static kcondvar_t module_thread_cv;
80 static kmutex_t module_thread_lock;
81 static int	module_thread_ticks;
82 int (*module_load_vfs_vec)(const char *, int, bool, module_t *,
83 			   prop_dictionary_t *) = (void *)eopnotsupp;
84 
85 static kauth_listener_t	module_listener;
86 
87 /* Ensure that the kernel's link set isn't empty. */
88 static modinfo_t module_dummy;
89 __link_set_add_rodata(modules, module_dummy);
90 
91 static module_t	*module_newmodule(modsrc_t);
92 static void	module_require_force(module_t *);
93 static int	module_do_load(const char *, bool, int, prop_dictionary_t,
94 		    module_t **, modclass_t modclass, bool);
95 static int	module_do_unload(const char *, bool);
96 static int	module_do_builtin(const char *, module_t **, prop_dictionary_t);
97 static int	module_fetch_info(module_t *);
98 static void	module_thread(void *);
99 
100 static module_t	*module_lookup(const char *);
101 static void	module_enqueue(module_t *);
102 
103 static bool	module_merge_dicts(prop_dictionary_t, const prop_dictionary_t);
104 
105 static void	sysctl_module_setup(void);
106 static int	sysctl_module_autotime(SYSCTLFN_PROTO);
107 
108 #define MODULE_CLASS_MATCH(mi, modclass) \
109 	((modclass) == MODULE_CLASS_ANY || (modclass) == (mi)->mi_class)
110 
111 static void
112 module_incompat(const modinfo_t *mi, int modclass)
113 {
114 	module_error("incompatible module class for `%s' (%d != %d)",
115 	    mi->mi_name, modclass, mi->mi_class);
116 }
117 
118 /*
119  * module_error:
120  *
121  *	Utility function: log an error.
122  */
123 void
124 module_error(const char *fmt, ...)
125 {
126 	va_list ap;
127 
128 	va_start(ap, fmt);
129 	printf("WARNING: module error: ");
130 	vprintf(fmt, ap);
131 	printf("\n");
132 	va_end(ap);
133 }
134 
135 /*
136  * module_print:
137  *
138  *	Utility function: log verbose output.
139  */
140 void
141 module_print(const char *fmt, ...)
142 {
143 	va_list ap;
144 
145 	if (module_verbose_on) {
146 		va_start(ap, fmt);
147 		printf("DEBUG: module: ");
148 		vprintf(fmt, ap);
149 		printf("\n");
150 		va_end(ap);
151 	}
152 }
153 
154 static int
155 module_listener_cb(kauth_cred_t cred, kauth_action_t action, void *cookie,
156     void *arg0, void *arg1, void *arg2, void *arg3)
157 {
158 	int result;
159 
160 	result = KAUTH_RESULT_DEFER;
161 
162 	if (action != KAUTH_SYSTEM_MODULE)
163 		return result;
164 
165 	if ((uintptr_t)arg2 != 0)	/* autoload */
166 		result = KAUTH_RESULT_ALLOW;
167 
168 	return result;
169 }
170 
171 /*
172  * Allocate a new module_t
173  */
174 static module_t *
175 module_newmodule(modsrc_t source)
176 {
177 	module_t *mod;
178 
179 	mod = kmem_zalloc(sizeof(*mod), KM_SLEEP);
180 	if (mod != NULL) {
181 		mod->mod_source = source;
182 		mod->mod_info = NULL;
183 		mod->mod_flags = 0;
184 	}
185 	return mod;
186 }
187 
188 /*
189  * Require the -f (force) flag to load a module
190  */
191 static void
192 module_require_force(struct module *mod)
193 {
194 	mod->mod_flags |= MODFLG_MUST_FORCE;
195 }
196 
197 /*
198  * Add modules to the builtin list.  This can done at boottime or
199  * at runtime if the module is linked into the kernel with an
200  * external linker.  All or none of the input will be handled.
201  * Optionally, the modules can be initialized.  If they are not
202  * initialized, module_init_class() or module_load() can be used
203  * later, but these are not guaranteed to give atomic results.
204  */
205 int
206 module_builtin_add(modinfo_t *const *mip, size_t nmodinfo, bool init)
207 {
208 	struct module **modp = NULL, *mod_iter;
209 	int rv = 0, i, mipskip;
210 
211 	if (init) {
212 		rv = kauth_authorize_system(kauth_cred_get(),
213 		    KAUTH_SYSTEM_MODULE, 0, (void *)(uintptr_t)MODCTL_LOAD,
214 		    (void *)(uintptr_t)1, NULL);
215 		if (rv) {
216 			return rv;
217 		}
218 	}
219 
220 	for (i = 0, mipskip = 0; i < nmodinfo; i++) {
221 		if (mip[i] == &module_dummy) {
222 			KASSERT(nmodinfo > 0);
223 			nmodinfo--;
224 		}
225 	}
226 	if (nmodinfo == 0)
227 		return 0;
228 
229 	modp = kmem_zalloc(sizeof(*modp) * nmodinfo, KM_SLEEP);
230 	for (i = 0, mipskip = 0; i < nmodinfo; i++) {
231 		if (mip[i+mipskip] == &module_dummy) {
232 			mipskip++;
233 			continue;
234 		}
235 		modp[i] = module_newmodule(MODULE_SOURCE_KERNEL);
236 		modp[i]->mod_info = mip[i+mipskip];
237 	}
238 	kernconfig_lock();
239 
240 	/* do this in three stages for error recovery and atomicity */
241 
242 	/* first check for presence */
243 	for (i = 0; i < nmodinfo; i++) {
244 		TAILQ_FOREACH(mod_iter, &module_builtins, mod_chain) {
245 			if (strcmp(mod_iter->mod_info->mi_name,
246 			    modp[i]->mod_info->mi_name) == 0)
247 				break;
248 		}
249 		if (mod_iter) {
250 			rv = EEXIST;
251 			goto out;
252 		}
253 
254 		if (module_lookup(modp[i]->mod_info->mi_name) != NULL) {
255 			rv = EEXIST;
256 			goto out;
257 		}
258 	}
259 
260 	/* then add to list */
261 	for (i = 0; i < nmodinfo; i++) {
262 		TAILQ_INSERT_TAIL(&module_builtins, modp[i], mod_chain);
263 		module_builtinlist++;
264 	}
265 
266 	/* finally, init (if required) */
267 	if (init) {
268 		for (i = 0; i < nmodinfo; i++) {
269 			rv = module_do_builtin(modp[i]->mod_info->mi_name,
270 			    NULL, NULL);
271 			/* throw in the towel, recovery hard & not worth it */
272 			if (rv)
273 				panic("builtin module \"%s\" init failed: %d",
274 				    modp[i]->mod_info->mi_name, rv);
275 		}
276 	}
277 
278  out:
279 	kernconfig_unlock();
280 	if (rv != 0) {
281 		for (i = 0; i < nmodinfo; i++) {
282 			if (modp[i])
283 				kmem_free(modp[i], sizeof(*modp[i]));
284 		}
285 	}
286 	kmem_free(modp, sizeof(*modp) * nmodinfo);
287 	return rv;
288 }
289 
290 /*
291  * Optionally fini and remove builtin module from the kernel.
292  * Note: the module will now be unreachable except via mi && builtin_add.
293  */
294 int
295 module_builtin_remove(modinfo_t *mi, bool fini)
296 {
297 	struct module *mod;
298 	int rv = 0;
299 
300 	if (fini) {
301 		rv = kauth_authorize_system(kauth_cred_get(),
302 		    KAUTH_SYSTEM_MODULE, 0, (void *)(uintptr_t)MODCTL_UNLOAD,
303 		    NULL, NULL);
304 		if (rv)
305 			return rv;
306 
307 		kernconfig_lock();
308 		rv = module_do_unload(mi->mi_name, true);
309 		if (rv) {
310 			goto out;
311 		}
312 	} else {
313 		kernconfig_lock();
314 	}
315 	TAILQ_FOREACH(mod, &module_builtins, mod_chain) {
316 		if (strcmp(mod->mod_info->mi_name, mi->mi_name) == 0)
317 			break;
318 	}
319 	if (mod) {
320 		TAILQ_REMOVE(&module_builtins, mod, mod_chain);
321 		module_builtinlist--;
322 	} else {
323 		KASSERT(fini == false);
324 		rv = ENOENT;
325 	}
326 
327  out:
328 	kernconfig_unlock();
329 	return rv;
330 }
331 
332 /*
333  * module_init:
334  *
335  *	Initialize the module subsystem.
336  */
337 void
338 module_init(void)
339 {
340 	__link_set_decl(modules, modinfo_t);
341 	extern struct vm_map *module_map;
342 	modinfo_t *const *mip;
343 	int rv;
344 
345 	if (module_map == NULL) {
346 		module_map = kernel_map;
347 	}
348 	cv_init(&module_thread_cv, "mod_unld");
349 	mutex_init(&module_thread_lock, MUTEX_DEFAULT, IPL_NONE);
350 
351 #ifdef MODULAR	/* XXX */
352 	module_init_md();
353 #endif
354 
355 	if (!module_machine)
356 		module_machine = machine;
357 #if __NetBSD_Version__ / 1000000 % 100 == 99	/* -current */
358 	snprintf(module_base, sizeof(module_base), "/stand/%s/%s/modules",
359 	    module_machine, osrelease);
360 #else						/* release */
361 	snprintf(module_base, sizeof(module_base), "/stand/%s/%d.%d/modules",
362 	    module_machine, __NetBSD_Version__ / 100000000,
363 	    __NetBSD_Version__ / 1000000 % 100);
364 #endif
365 
366 	module_listener = kauth_listen_scope(KAUTH_SCOPE_SYSTEM,
367 	    module_listener_cb, NULL);
368 
369 	__link_set_foreach(mip, modules) {
370 		if ((rv = module_builtin_add(mip, 1, false)) != 0)
371 			module_error("builtin %s failed: %d\n",
372 			    (*mip)->mi_name, rv);
373 	}
374 
375 	sysctl_module_setup();
376 }
377 
378 /*
379  * module_start_unload_thread:
380  *
381  *	Start the auto unload kthread.
382  */
383 void
384 module_start_unload_thread(void)
385 {
386 	int error;
387 
388 	error = kthread_create(PRI_VM, KTHREAD_MPSAFE, NULL, module_thread,
389 	    NULL, NULL, "modunload");
390 	if (error != 0)
391 		panic("module_init: %d", error);
392 }
393 
394 /*
395  * module_builtin_require_force
396  *
397  * Require MODCTL_MUST_FORCE to load any built-in modules that have
398  * not yet been initialized
399  */
400 void
401 module_builtin_require_force(void)
402 {
403 	module_t *mod;
404 
405 	kernconfig_lock();
406 	TAILQ_FOREACH(mod, &module_builtins, mod_chain) {
407 		module_require_force(mod);
408 	}
409 	kernconfig_unlock();
410 }
411 
412 static struct sysctllog *module_sysctllog;
413 
414 static int
415 sysctl_module_autotime(SYSCTLFN_ARGS)
416 {
417 	struct sysctlnode node;
418 	int t, error;
419 
420 	t = *(int *)rnode->sysctl_data;
421 
422 	node = *rnode;
423 	node.sysctl_data = &t;
424 	error = sysctl_lookup(SYSCTLFN_CALL(&node));
425 	if (error || newp == NULL)
426 		return (error);
427 
428 	if (t < 0)
429 		return (EINVAL);
430 
431 	*(int *)rnode->sysctl_data = t;
432 	return (0);
433 }
434 
435 static void
436 sysctl_module_setup(void)
437 {
438 	const struct sysctlnode *node = NULL;
439 
440 	sysctl_createv(&module_sysctllog, 0, NULL, &node,
441 		CTLFLAG_PERMANENT,
442 		CTLTYPE_NODE, "module",
443 		SYSCTL_DESCR("Module options"),
444 		NULL, 0, NULL, 0,
445 		CTL_KERN, CTL_CREATE, CTL_EOL);
446 
447 	if (node == NULL)
448 		return;
449 
450 	sysctl_createv(&module_sysctllog, 0, &node, NULL,
451 		CTLFLAG_PERMANENT | CTLFLAG_READWRITE,
452 		CTLTYPE_BOOL, "autoload",
453 		SYSCTL_DESCR("Enable automatic load of modules"),
454 		NULL, 0, &module_autoload_on, 0,
455 		CTL_CREATE, CTL_EOL);
456 	sysctl_createv(&module_sysctllog, 0, &node, NULL,
457 		CTLFLAG_PERMANENT | CTLFLAG_READWRITE,
458 		CTLTYPE_BOOL, "verbose",
459 		SYSCTL_DESCR("Enable verbose output"),
460 		NULL, 0, &module_verbose_on, 0,
461 		CTL_CREATE, CTL_EOL);
462 	sysctl_createv(&module_sysctllog, 0, &node, NULL,
463 		CTLFLAG_PERMANENT | CTLFLAG_READONLY,
464 		CTLTYPE_STRING, "path",
465 		SYSCTL_DESCR("Default module load path"),
466 		NULL, 0, module_base, 0,
467 		CTL_CREATE, CTL_EOL);
468 	sysctl_createv(&module_sysctllog, 0, &node, NULL,
469 		CTLFLAG_PERMANENT | CTLFLAG_READWRITE,
470 		CTLTYPE_INT, "autotime",
471 		SYSCTL_DESCR("Auto-unload delay"),
472 		sysctl_module_autotime, 0, &module_autotime, 0,
473 		CTL_CREATE, CTL_EOL);
474 }
475 
476 /*
477  * module_init_class:
478  *
479  *	Initialize all built-in and pre-loaded modules of the
480  *	specified class.
481  */
482 void
483 module_init_class(modclass_t modclass)
484 {
485 	TAILQ_HEAD(, module) bi_fail = TAILQ_HEAD_INITIALIZER(bi_fail);
486 	module_t *mod;
487 	modinfo_t *mi;
488 
489 	kernconfig_lock();
490 	/*
491 	 * Builtins first.  These will not depend on pre-loaded modules
492 	 * (because the kernel would not link).
493 	 */
494 	do {
495 		TAILQ_FOREACH(mod, &module_builtins, mod_chain) {
496 			mi = mod->mod_info;
497 			if (!MODULE_CLASS_MATCH(mi, modclass))
498 				continue;
499 			/*
500 			 * If initializing a builtin module fails, don't try
501 			 * to load it again.  But keep it around and queue it
502 			 * on the builtins list after we're done with module
503 			 * init.  Don't set it to MODFLG_MUST_FORCE in case a
504 			 * future attempt to initialize can be successful.
505 			 * (If the module has previously been set to
506 			 * MODFLG_MUST_FORCE, don't try to override that!)
507 			 */
508 			if ((mod->mod_flags & MODFLG_MUST_FORCE) ||
509 			    module_do_builtin(mi->mi_name, NULL, NULL) != 0) {
510 				TAILQ_REMOVE(&module_builtins, mod, mod_chain);
511 				TAILQ_INSERT_TAIL(&bi_fail, mod, mod_chain);
512 			}
513 			break;
514 		}
515 	} while (mod != NULL);
516 
517 	/*
518 	 * Now preloaded modules.  These will be pulled off the
519 	 * list as we call module_do_load();
520 	 */
521 	do {
522 		TAILQ_FOREACH(mod, &module_bootlist, mod_chain) {
523 			mi = mod->mod_info;
524 			if (!MODULE_CLASS_MATCH(mi, modclass))
525 				continue;
526 			module_do_load(mi->mi_name, false, 0, NULL, NULL,
527 			    modclass, false);
528 			break;
529 		}
530 	} while (mod != NULL);
531 
532 	/* return failed builtin modules to builtin list */
533 	while ((mod = TAILQ_FIRST(&bi_fail)) != NULL) {
534 		TAILQ_REMOVE(&bi_fail, mod, mod_chain);
535 		TAILQ_INSERT_TAIL(&module_builtins, mod, mod_chain);
536 	}
537 
538 	kernconfig_unlock();
539 }
540 
541 /*
542  * module_compatible:
543  *
544  *	Return true if the two supplied kernel versions are said to
545  *	have the same binary interface for kernel code.  The entire
546  *	version is signficant for the development tree (-current),
547  *	major and minor versions are significant for official
548  *	releases of the system.
549  */
550 bool
551 module_compatible(int v1, int v2)
552 {
553 
554 #if __NetBSD_Version__ / 1000000 % 100 == 99	/* -current */
555 	return v1 == v2;
556 #else						/* release */
557 	return abs(v1 - v2) < 10000;
558 #endif
559 }
560 
561 /*
562  * module_load:
563  *
564  *	Load a single module from the file system.
565  */
566 int
567 module_load(const char *filename, int flags, prop_dictionary_t props,
568 	    modclass_t modclass)
569 {
570 	int error;
571 
572 	/* Authorize. */
573 	error = kauth_authorize_system(kauth_cred_get(), KAUTH_SYSTEM_MODULE,
574 	    0, (void *)(uintptr_t)MODCTL_LOAD, NULL, NULL);
575 	if (error != 0) {
576 		return error;
577 	}
578 
579 	kernconfig_lock();
580 	error = module_do_load(filename, false, flags, props, NULL, modclass,
581 	    false);
582 	kernconfig_unlock();
583 
584 	return error;
585 }
586 
587 /*
588  * module_autoload:
589  *
590  *	Load a single module from the file system, system initiated.
591  */
592 int
593 module_autoload(const char *filename, modclass_t modclass)
594 {
595 	int error;
596 
597 	kernconfig_lock();
598 
599 	/* Nothing if the user has disabled it. */
600 	if (!module_autoload_on) {
601 		kernconfig_unlock();
602 		return EPERM;
603 	}
604 
605         /* Disallow path separators and magic symlinks. */
606         if (strchr(filename, '/') != NULL || strchr(filename, '@') != NULL ||
607             strchr(filename, '.') != NULL) {
608 		kernconfig_unlock();
609         	return EPERM;
610 	}
611 
612 	/* Authorize. */
613 	error = kauth_authorize_system(kauth_cred_get(), KAUTH_SYSTEM_MODULE,
614 	    0, (void *)(uintptr_t)MODCTL_LOAD, (void *)(uintptr_t)1, NULL);
615 
616 	if (error == 0)
617 		error = module_do_load(filename, false, 0, NULL, NULL, modclass,
618 		    true);
619 
620 	kernconfig_unlock();
621 	return error;
622 }
623 
624 /*
625  * module_unload:
626  *
627  *	Find and unload a module by name.
628  */
629 int
630 module_unload(const char *name)
631 {
632 	int error;
633 
634 	/* Authorize. */
635 	error = kauth_authorize_system(kauth_cred_get(), KAUTH_SYSTEM_MODULE,
636 	    0, (void *)(uintptr_t)MODCTL_UNLOAD, NULL, NULL);
637 	if (error != 0) {
638 		return error;
639 	}
640 
641 	kernconfig_lock();
642 	error = module_do_unload(name, true);
643 	kernconfig_unlock();
644 
645 	return error;
646 }
647 
648 /*
649  * module_lookup:
650  *
651  *	Look up a module by name.
652  */
653 module_t *
654 module_lookup(const char *name)
655 {
656 	module_t *mod;
657 
658 	KASSERT(kernconfig_is_held());
659 
660 	TAILQ_FOREACH(mod, &module_list, mod_chain) {
661 		if (strcmp(mod->mod_info->mi_name, name) == 0) {
662 			break;
663 		}
664 	}
665 
666 	return mod;
667 }
668 
669 /*
670  * module_hold:
671  *
672  *	Add a single reference to a module.  It's the caller's
673  *	responsibility to ensure that the reference is dropped
674  *	later.
675  */
676 int
677 module_hold(const char *name)
678 {
679 	module_t *mod;
680 
681 	kernconfig_lock();
682 	mod = module_lookup(name);
683 	if (mod == NULL) {
684 		kernconfig_unlock();
685 		return ENOENT;
686 	}
687 	mod->mod_refcnt++;
688 	kernconfig_unlock();
689 
690 	return 0;
691 }
692 
693 /*
694  * module_rele:
695  *
696  *	Release a reference acquired with module_hold().
697  */
698 void
699 module_rele(const char *name)
700 {
701 	module_t *mod;
702 
703 	kernconfig_lock();
704 	mod = module_lookup(name);
705 	if (mod == NULL) {
706 		kernconfig_unlock();
707 		panic("module_rele: gone");
708 	}
709 	mod->mod_refcnt--;
710 	kernconfig_unlock();
711 }
712 
713 /*
714  * module_enqueue:
715  *
716  *	Put a module onto the global list and update counters.
717  */
718 void
719 module_enqueue(module_t *mod)
720 {
721 	int i;
722 
723 	KASSERT(kernconfig_is_held());
724 
725 	/*
726 	 * If there are requisite modules, put at the head of the queue.
727 	 * This is so that autounload can unload requisite modules with
728 	 * only one pass through the queue.
729 	 */
730 	if (mod->mod_nrequired) {
731 		TAILQ_INSERT_HEAD(&module_list, mod, mod_chain);
732 
733 		/* Add references to the requisite modules. */
734 		for (i = 0; i < mod->mod_nrequired; i++) {
735 			KASSERT(mod->mod_required[i] != NULL);
736 			mod->mod_required[i]->mod_refcnt++;
737 		}
738 	} else {
739 		TAILQ_INSERT_TAIL(&module_list, mod, mod_chain);
740 	}
741 	module_count++;
742 	module_gen++;
743 }
744 
745 /*
746  * module_do_builtin:
747  *
748  *	Initialize a module from the list of modules that are
749  *	already linked into the kernel.
750  */
751 static int
752 module_do_builtin(const char *name, module_t **modp, prop_dictionary_t props)
753 {
754 	const char *p, *s;
755 	char buf[MAXMODNAME];
756 	modinfo_t *mi = NULL;
757 	module_t *mod, *mod2, *mod_loaded, *prev_active;
758 	size_t len;
759 	int error;
760 
761 	KASSERT(kernconfig_is_held());
762 
763 	/*
764 	 * Search the list to see if we have a module by this name.
765 	 */
766 	TAILQ_FOREACH(mod, &module_builtins, mod_chain) {
767 		if (strcmp(mod->mod_info->mi_name, name) == 0) {
768 			mi = mod->mod_info;
769 			break;
770 		}
771 	}
772 
773 	/*
774 	 * Check to see if already loaded.  This might happen if we
775 	 * were already loaded as a dependency.
776 	 */
777 	if ((mod_loaded = module_lookup(name)) != NULL) {
778 		KASSERT(mod == NULL);
779 		if (modp)
780 			*modp = mod_loaded;
781 		return 0;
782 	}
783 
784 	/* Note! This is from TAILQ, not immediate above */
785 	if (mi == NULL) {
786 		/*
787 		 * XXX: We'd like to panic here, but currently in some
788 		 * cases (such as nfsserver + nfs), the dependee can be
789 		 * succesfully linked without the dependencies.
790 		 */
791 		module_error("can't find builtin dependency `%s'", name);
792 		return ENOENT;
793 	}
794 
795 	/*
796 	 * Initialize pre-requisites.
797 	 */
798 	if (mi->mi_required != NULL) {
799 		for (s = mi->mi_required; *s != '\0'; s = p) {
800 			if (*s == ',')
801 				s++;
802 			p = s;
803 			while (*p != '\0' && *p != ',')
804 				p++;
805 			len = min(p - s + 1, sizeof(buf));
806 			strlcpy(buf, s, len);
807 			if (buf[0] == '\0')
808 				break;
809 			if (mod->mod_nrequired == MAXMODDEPS - 1) {
810 				module_error("too many required modules "
811 				    "%d >= %d", mod->mod_nrequired,
812 				    MAXMODDEPS - 1);
813 				return EINVAL;
814 			}
815 			error = module_do_builtin(buf, &mod2, NULL);
816 			if (error != 0) {
817 				return error;
818 			}
819 			mod->mod_required[mod->mod_nrequired++] = mod2;
820 		}
821 	}
822 
823 	/*
824 	 * Try to initialize the module.
825 	 */
826 	prev_active = module_active;
827 	module_active = mod;
828 	error = (*mi->mi_modcmd)(MODULE_CMD_INIT, props);
829 	module_active = prev_active;
830 	if (error != 0) {
831 		module_error("builtin module `%s' "
832 		    "failed to init, error %d", mi->mi_name, error);
833 		return error;
834 	}
835 
836 	/* load always succeeds after this point */
837 
838 	TAILQ_REMOVE(&module_builtins, mod, mod_chain);
839 	module_builtinlist--;
840 	if (modp != NULL) {
841 		*modp = mod;
842 	}
843 	module_enqueue(mod);
844 	return 0;
845 }
846 
847 /*
848  * module_do_load:
849  *
850  *	Helper routine: load a module from the file system, or one
851  *	pushed by the boot loader.
852  */
853 static int
854 module_do_load(const char *name, bool isdep, int flags,
855 	       prop_dictionary_t props, module_t **modp, modclass_t modclass,
856 	       bool autoload)
857 {
858 #define MODULE_MAX_DEPTH 6
859 
860 	TAILQ_HEAD(pending_t, module);
861 	static int depth = 0;
862 	static struct pending_t *pending_lists[MODULE_MAX_DEPTH];
863 	struct pending_t *pending;
864 	struct pending_t new_pending = TAILQ_HEAD_INITIALIZER(new_pending);
865 	modinfo_t *mi;
866 	module_t *mod, *mod2, *prev_active;
867 	prop_dictionary_t filedict;
868 	char buf[MAXMODNAME];
869 	const char *s, *p;
870 	int error;
871 	size_t len;
872 
873 	KASSERT(kernconfig_is_held());
874 
875 	filedict = NULL;
876 	error = 0;
877 
878 	/*
879 	 * Avoid recursing too far.
880 	 */
881 	if (++depth > MODULE_MAX_DEPTH) {
882 		module_error("recursion too deep for `%s' %d > %d", name,
883 		    depth, MODULE_MAX_DEPTH);
884 		depth--;
885 		return EMLINK;
886 	}
887 
888 	/*
889 	 * Set up the pending list for this depth.  If this is a
890 	 * recursive entry, then use same list as for outer call,
891 	 * else use the locally allocated list.  In either case,
892 	 * remember which one we're using.
893 	 */
894 	if (isdep) {
895 		KASSERT(depth > 1);
896 		pending = pending_lists[depth - 2];
897 	} else
898 		pending = &new_pending;
899 	pending_lists[depth - 1] = pending;
900 
901 	/*
902 	 * Search the list of disabled builtins first.
903 	 */
904 	TAILQ_FOREACH(mod, &module_builtins, mod_chain) {
905 		if (strcmp(mod->mod_info->mi_name, name) == 0) {
906 			break;
907 		}
908 	}
909 	if (mod) {
910 		if ((mod->mod_flags & MODFLG_MUST_FORCE) &&
911 		    (flags & MODCTL_LOAD_FORCE) == 0) {
912 			if (!autoload) {
913 				module_error("use -f to reinstate "
914 				    "builtin module `%s'", name);
915 			}
916 			depth--;
917 			return EPERM;
918 		} else {
919 			error = module_do_builtin(name, modp, props);
920 			depth--;
921 			return error;
922 		}
923 	}
924 
925 	/*
926 	 * Load the module and link.  Before going to the file system,
927 	 * scan the list of modules loaded by the boot loader.
928 	 */
929 	TAILQ_FOREACH(mod, &module_bootlist, mod_chain) {
930 		if (strcmp(mod->mod_info->mi_name, name) == 0) {
931 			TAILQ_REMOVE(&module_bootlist, mod, mod_chain);
932 			break;
933 		}
934 	}
935 	if (mod != NULL) {
936 		TAILQ_INSERT_TAIL(pending, mod, mod_chain);
937 	} else {
938 		/*
939 		 * If a requisite module, check to see if it is
940 		 * already present.
941 		 */
942 		if (isdep) {
943 			mod = module_lookup(name);
944 			if (mod != NULL) {
945 				if (modp != NULL) {
946 					*modp = mod;
947 				}
948 				depth--;
949 				return 0;
950 			}
951 		}
952 		mod = module_newmodule(MODULE_SOURCE_FILESYS);
953 		if (mod == NULL) {
954 			module_error("out of memory for `%s'", name);
955 			depth--;
956 			return ENOMEM;
957 		}
958 
959 		error = module_load_vfs_vec(name, flags, autoload, mod,
960 					    &filedict);
961 		if (error != 0) {
962 #ifdef DEBUG
963 			/*
964 			 * The exec class of modules contains a list of
965 			 * modules that is the union of all the modules
966 			 * available for each architecture, so we don't
967 			 * print an error if they are missing.
968 			 */
969 			if (modclass != MODULE_CLASS_EXEC || error != ENOENT)
970 				module_error("vfs load failed for `%s', "
971 				    "error %d", name, error);
972 #endif
973 			kmem_free(mod, sizeof(*mod));
974 			depth--;
975 			return error;
976 		}
977 		TAILQ_INSERT_TAIL(pending, mod, mod_chain);
978 
979 		error = module_fetch_info(mod);
980 		if (error != 0) {
981 			module_error("cannot fetch info for `%s', error %d",
982 			    name, error);
983 			goto fail;
984 		}
985 	}
986 
987 	/*
988 	 * Check compatibility.
989 	 */
990 	mi = mod->mod_info;
991 	if (strlen(mi->mi_name) >= MAXMODNAME) {
992 		error = EINVAL;
993 		module_error("module name `%s' longer than %d", mi->mi_name,
994 		    MAXMODNAME);
995 		goto fail;
996 	}
997 	if (!module_compatible(mi->mi_version, __NetBSD_Version__)) {
998 		module_error("module `%s' built for `%d', system `%d'",
999 		    mi->mi_name, mi->mi_version, __NetBSD_Version__);
1000 		if ((flags & MODCTL_LOAD_FORCE) != 0) {
1001 			module_error("forced load, system may be unstable");
1002 		} else {
1003 			error = EPROGMISMATCH;
1004 			goto fail;
1005 		}
1006 	}
1007 
1008 	/*
1009 	 * If a specific kind of module was requested, ensure that we have
1010 	 * a match.
1011 	 */
1012 	if (!MODULE_CLASS_MATCH(mi, modclass)) {
1013 		module_incompat(mi, modclass);
1014 		error = ENOENT;
1015 		goto fail;
1016 	}
1017 
1018 	/*
1019 	 * If loading a dependency, `name' is a plain module name.
1020 	 * The name must match.
1021 	 */
1022 	if (isdep && strcmp(mi->mi_name, name) != 0) {
1023 		module_error("dependency name mismatch (`%s' != `%s')",
1024 		    name, mi->mi_name);
1025 		error = ENOENT;
1026 		goto fail;
1027 	}
1028 
1029 	/*
1030 	 * Check to see if the module is already loaded.  If so, we may
1031 	 * have been recursively called to handle a dependency, so be sure
1032 	 * to set modp.
1033 	 */
1034 	if ((mod2 = module_lookup(mi->mi_name)) != NULL) {
1035 		if (modp != NULL)
1036 			*modp = mod2;
1037 		module_print("module `%s' already loaded", mi->mi_name);
1038 		error = EEXIST;
1039 		goto fail;
1040 	}
1041 
1042 	/*
1043 	 * Block circular dependencies.
1044 	 */
1045 	TAILQ_FOREACH(mod2, pending, mod_chain) {
1046 		if (mod == mod2) {
1047 			continue;
1048 		}
1049 		if (strcmp(mod2->mod_info->mi_name, mi->mi_name) == 0) {
1050 		    	error = EDEADLK;
1051 			module_error("circular dependency detected for `%s'",
1052 			    mi->mi_name);
1053 		    	goto fail;
1054 		}
1055 	}
1056 
1057 	/*
1058 	 * Now try to load any requisite modules.
1059 	 */
1060 	if (mi->mi_required != NULL) {
1061 		for (s = mi->mi_required; *s != '\0'; s = p) {
1062 			if (*s == ',')
1063 				s++;
1064 			p = s;
1065 			while (*p != '\0' && *p != ',')
1066 				p++;
1067 			len = p - s + 1;
1068 			if (len >= MAXMODNAME) {
1069 				error = EINVAL;
1070 				module_error("required module name `%s' "
1071 				    "longer than %d", mi->mi_required,
1072 				    MAXMODNAME);
1073 				goto fail;
1074 			}
1075 			strlcpy(buf, s, len);
1076 			if (buf[0] == '\0')
1077 				break;
1078 			if (mod->mod_nrequired == MAXMODDEPS - 1) {
1079 				error = EINVAL;
1080 				module_error("too many required modules "
1081 				    "%d >= %d", mod->mod_nrequired,
1082 				    MAXMODDEPS - 1);
1083 				goto fail;
1084 			}
1085 			if (strcmp(buf, mi->mi_name) == 0) {
1086 				error = EDEADLK;
1087 				module_error("self-dependency detected for "
1088 				   "`%s'", mi->mi_name);
1089 				goto fail;
1090 			}
1091 			error = module_do_load(buf, true, flags, NULL,
1092 			    &mod2, MODULE_CLASS_ANY, true);
1093 			if (error != 0) {
1094 				module_error("recursive load failed for `%s' "
1095 				    "(`%s' required), error %d", mi->mi_name,
1096 				    buf, error);
1097 				goto fail;
1098 			}
1099 			mod->mod_required[mod->mod_nrequired++] = mod2;
1100 		}
1101 	}
1102 
1103 	/*
1104 	 * We loaded all needed modules successfully: perform global
1105 	 * relocations and initialize.
1106 	 */
1107 	error = kobj_affix(mod->mod_kobj, mi->mi_name);
1108 	if (error != 0) {
1109 		/* Cannot touch 'mi' as the module is now gone. */
1110 		module_error("unable to affix module `%s', error %d", name,
1111 		    error);
1112 		goto fail2;
1113 	}
1114 
1115 	if (filedict) {
1116 		if (!module_merge_dicts(filedict, props)) {
1117 			module_error("module properties failed for %s", name);
1118 			error = EINVAL;
1119 			goto fail;
1120 		}
1121 	}
1122 	prev_active = module_active;
1123 	module_active = mod;
1124 	error = (*mi->mi_modcmd)(MODULE_CMD_INIT, filedict ? filedict : props);
1125 	module_active = prev_active;
1126 	if (filedict) {
1127 		prop_object_release(filedict);
1128 		filedict = NULL;
1129 	}
1130 	if (error != 0) {
1131 		module_error("modcmd function failed for `%s', error %d",
1132 		    mi->mi_name, error);
1133 		goto fail;
1134 	}
1135 
1136 	/*
1137 	 * Good, the module loaded successfully.  Put it onto the
1138 	 * list and add references to its requisite modules.
1139 	 */
1140 	TAILQ_REMOVE(pending, mod, mod_chain);
1141 	module_enqueue(mod);
1142 	if (modp != NULL) {
1143 		*modp = mod;
1144 	}
1145 	if (autoload && module_autotime > 0) {
1146 		/*
1147 		 * Arrange to try unloading the module after
1148 		 * a short delay unless auto-unload is disabled.
1149 		 */
1150 		mod->mod_autotime = time_second + module_autotime;
1151 		mod->mod_flags |= MODFLG_AUTO_LOADED;
1152 		module_thread_kick();
1153 	}
1154 	depth--;
1155 	return 0;
1156 
1157  fail:
1158 	kobj_unload(mod->mod_kobj);
1159  fail2:
1160 	if (filedict != NULL) {
1161 		prop_object_release(filedict);
1162 		filedict = NULL;
1163 	}
1164 	TAILQ_REMOVE(pending, mod, mod_chain);
1165 	kmem_free(mod, sizeof(*mod));
1166 	depth--;
1167 	return error;
1168 }
1169 
1170 /*
1171  * module_do_unload:
1172  *
1173  *	Helper routine: do the dirty work of unloading a module.
1174  */
1175 static int
1176 module_do_unload(const char *name, bool load_requires_force)
1177 {
1178 	module_t *mod, *prev_active;
1179 	int error;
1180 	u_int i;
1181 
1182 	KASSERT(kernconfig_is_held());
1183 	KASSERT(name != NULL);
1184 
1185 	mod = module_lookup(name);
1186 	if (mod == NULL) {
1187 		module_error("module `%s' not found", name);
1188 		return ENOENT;
1189 	}
1190 	if (mod->mod_refcnt != 0) {
1191 		module_print("module `%s' busy", name);
1192 		return EBUSY;
1193 	}
1194 
1195 	/*
1196 	 * Builtin secmodels are there to stay.
1197 	 */
1198 	if (mod->mod_source == MODULE_SOURCE_KERNEL &&
1199 	    mod->mod_info->mi_class == MODULE_CLASS_SECMODEL) {
1200 		return EPERM;
1201 	}
1202 
1203 	prev_active = module_active;
1204 	module_active = mod;
1205 	error = (*mod->mod_info->mi_modcmd)(MODULE_CMD_FINI, NULL);
1206 	module_active = prev_active;
1207 	if (error != 0) {
1208 		module_print("cannot unload module `%s' error=%d", name,
1209 		    error);
1210 		return error;
1211 	}
1212 	module_count--;
1213 	TAILQ_REMOVE(&module_list, mod, mod_chain);
1214 	for (i = 0; i < mod->mod_nrequired; i++) {
1215 		mod->mod_required[i]->mod_refcnt--;
1216 	}
1217 	module_print("unloaded module `%s'", name);
1218 	if (mod->mod_kobj != NULL) {
1219 		kobj_unload(mod->mod_kobj);
1220 	}
1221 	if (mod->mod_source == MODULE_SOURCE_KERNEL) {
1222 		mod->mod_nrequired = 0; /* will be re-parsed */
1223 		if (load_requires_force)
1224 			module_require_force(mod);
1225 		TAILQ_INSERT_TAIL(&module_builtins, mod, mod_chain);
1226 		module_builtinlist++;
1227 	} else {
1228 		kmem_free(mod, sizeof(*mod));
1229 	}
1230 	module_gen++;
1231 
1232 	return 0;
1233 }
1234 
1235 /*
1236  * module_prime:
1237  *
1238  *	Push a module loaded by the bootloader onto our internal
1239  *	list.
1240  */
1241 int
1242 module_prime(const char *name, void *base, size_t size)
1243 {
1244 	module_t *mod;
1245 	int error;
1246 
1247 	mod = module_newmodule(MODULE_SOURCE_BOOT);
1248 	if (mod == NULL) {
1249 		return ENOMEM;
1250 	}
1251 
1252 	error = kobj_load_mem(&mod->mod_kobj, name, base, size);
1253 	if (error != 0) {
1254 		kmem_free(mod, sizeof(*mod));
1255 		module_error("unable to load `%s' pushed by boot loader, "
1256 		    "error %d", name, error);
1257 		return error;
1258 	}
1259 	error = module_fetch_info(mod);
1260 	if (error != 0) {
1261 		kobj_unload(mod->mod_kobj);
1262 		kmem_free(mod, sizeof(*mod));
1263 		module_error("unable to load `%s' pushed by boot loader, "
1264 		    "error %d", name, error);
1265 		return error;
1266 	}
1267 
1268 	TAILQ_INSERT_TAIL(&module_bootlist, mod, mod_chain);
1269 
1270 	return 0;
1271 }
1272 
1273 /*
1274  * module_fetch_into:
1275  *
1276  *	Fetch modinfo record from a loaded module.
1277  */
1278 static int
1279 module_fetch_info(module_t *mod)
1280 {
1281 	int error;
1282 	void *addr;
1283 	size_t size;
1284 
1285 	/*
1286 	 * Find module info record and check compatibility.
1287 	 */
1288 	error = kobj_find_section(mod->mod_kobj, "link_set_modules",
1289 	    &addr, &size);
1290 	if (error != 0) {
1291 		module_error("`link_set_modules' section not present, "
1292 		    "error %d", error);
1293 		return error;
1294 	}
1295 	if (size != sizeof(modinfo_t **)) {
1296 		module_error("`link_set_modules' section wrong size %zu != %zu",
1297 		    size, sizeof(modinfo_t **));
1298 		return ENOEXEC;
1299 	}
1300 	mod->mod_info = *(modinfo_t **)addr;
1301 
1302 	return 0;
1303 }
1304 
1305 /*
1306  * module_find_section:
1307  *
1308  *	Allows a module that is being initialized to look up a section
1309  *	within its ELF object.
1310  */
1311 int
1312 module_find_section(const char *name, void **addr, size_t *size)
1313 {
1314 
1315 	KASSERT(kernconfig_is_held());
1316 	KASSERT(module_active != NULL);
1317 
1318 	return kobj_find_section(module_active->mod_kobj, name, addr, size);
1319 }
1320 
1321 /*
1322  * module_thread:
1323  *
1324  *	Automatically unload modules.  We try once to unload autoloaded
1325  *	modules after module_autotime seconds.  If the system is under
1326  *	severe memory pressure, we'll try unloading all modules, else if
1327  *	module_autotime is zero, we don't try to unload, even if the
1328  *	module was previously scheduled for unload.
1329  */
1330 static void
1331 module_thread(void *cookie)
1332 {
1333 	module_t *mod, *next;
1334 	modinfo_t *mi;
1335 	int error;
1336 
1337 	for (;;) {
1338 		kernconfig_lock();
1339 		for (mod = TAILQ_FIRST(&module_list); mod != NULL; mod = next) {
1340 			next = TAILQ_NEXT(mod, mod_chain);
1341 
1342 			/* skip built-in modules */
1343 			if (mod->mod_source == MODULE_SOURCE_KERNEL)
1344 				continue;
1345 			/* skip modules that weren't auto-loaded */
1346 			if ((mod->mod_flags & MODFLG_AUTO_LOADED) == 0)
1347 				continue;
1348 
1349 			if (uvmexp.free < uvmexp.freemin) {
1350 				module_thread_ticks = hz;
1351 			} else if (module_autotime == 0 ||
1352 				   mod->mod_autotime == 0) {
1353 				continue;
1354 			} else if (time_second < mod->mod_autotime) {
1355 				module_thread_ticks = hz;
1356 			    	continue;
1357 			} else {
1358 				mod->mod_autotime = 0;
1359 			}
1360 
1361 			/*
1362 			 * If this module wants to avoid autounload then
1363 			 * skip it.  Some modules can ping-pong in and out
1364 			 * because their use is transient but often.
1365 			 * Example: exec_script.
1366 			 */
1367 			mi = mod->mod_info;
1368 			error = (*mi->mi_modcmd)(MODULE_CMD_AUTOUNLOAD, NULL);
1369 			if (error == 0 || error == ENOTTY) {
1370 				(void)module_do_unload(mi->mi_name, false);
1371 			}
1372 		}
1373 		kernconfig_unlock();
1374 
1375 		mutex_enter(&module_thread_lock);
1376 		(void)cv_timedwait(&module_thread_cv, &module_thread_lock,
1377 		    module_thread_ticks);
1378 		module_thread_ticks = 0;
1379 		mutex_exit(&module_thread_lock);
1380 	}
1381 }
1382 
1383 /*
1384  * module_thread:
1385  *
1386  *	Kick the module thread into action, perhaps because the
1387  *	system is low on memory.
1388  */
1389 void
1390 module_thread_kick(void)
1391 {
1392 
1393 	mutex_enter(&module_thread_lock);
1394 	module_thread_ticks = hz;
1395 	cv_broadcast(&module_thread_cv);
1396 	mutex_exit(&module_thread_lock);
1397 }
1398 
1399 #ifdef DDB
1400 /*
1401  * module_whatis:
1402  *
1403  *	Helper routine for DDB.
1404  */
1405 void
1406 module_whatis(uintptr_t addr, void (*pr)(const char *, ...))
1407 {
1408 	module_t *mod;
1409 	size_t msize;
1410 	vaddr_t maddr;
1411 
1412 	TAILQ_FOREACH(mod, &module_list, mod_chain) {
1413 		if (mod->mod_kobj == NULL) {
1414 			continue;
1415 		}
1416 		if (kobj_stat(mod->mod_kobj, &maddr, &msize) != 0)
1417 			continue;
1418 		if (addr < maddr || addr >= maddr + msize) {
1419 			continue;
1420 		}
1421 		(*pr)("%p is %p+%zu, in kernel module `%s'\n",
1422 		    (void *)addr, (void *)maddr,
1423 		    (size_t)(addr - maddr), mod->mod_info->mi_name);
1424 	}
1425 }
1426 
1427 /*
1428  * module_print_list:
1429  *
1430  *	Helper routine for DDB.
1431  */
1432 void
1433 module_print_list(void (*pr)(const char *, ...))
1434 {
1435 	const char *src;
1436 	module_t *mod;
1437 	size_t msize;
1438 	vaddr_t maddr;
1439 
1440 	(*pr)("%16s %16s %8s %8s\n", "NAME", "TEXT/DATA", "SIZE", "SOURCE");
1441 
1442 	TAILQ_FOREACH(mod, &module_list, mod_chain) {
1443 		switch (mod->mod_source) {
1444 		case MODULE_SOURCE_KERNEL:
1445 			src = "builtin";
1446 			break;
1447 		case MODULE_SOURCE_FILESYS:
1448 			src = "filesys";
1449 			break;
1450 		case MODULE_SOURCE_BOOT:
1451 			src = "boot";
1452 			break;
1453 		default:
1454 			src = "unknown";
1455 			break;
1456 		}
1457 		if (mod->mod_kobj == NULL) {
1458 			maddr = 0;
1459 			msize = 0;
1460 		} else if (kobj_stat(mod->mod_kobj, &maddr, &msize) != 0)
1461 			continue;
1462 		(*pr)("%16s %16lx %8ld %8s\n", mod->mod_info->mi_name,
1463 		    (long)maddr, (long)msize, src);
1464 	}
1465 }
1466 #endif	/* DDB */
1467 
1468 static bool
1469 module_merge_dicts(prop_dictionary_t existing_dict,
1470 		   const prop_dictionary_t new_dict)
1471 {
1472 	prop_dictionary_keysym_t props_keysym;
1473 	prop_object_iterator_t props_iter;
1474 	prop_object_t props_obj;
1475 	const char *props_key;
1476 	bool error;
1477 
1478 	if (new_dict == NULL) {			/* nothing to merge */
1479 		return true;
1480 	}
1481 
1482 	error = false;
1483 	props_iter = prop_dictionary_iterator(new_dict);
1484 	if (props_iter == NULL) {
1485 		return false;
1486 	}
1487 
1488 	while ((props_obj = prop_object_iterator_next(props_iter)) != NULL) {
1489 		props_keysym = (prop_dictionary_keysym_t)props_obj;
1490 		props_key = prop_dictionary_keysym_cstring_nocopy(props_keysym);
1491 		props_obj = prop_dictionary_get_keysym(new_dict, props_keysym);
1492 		if ((props_obj == NULL) || !prop_dictionary_set(existing_dict,
1493 		    props_key, props_obj)) {
1494 			error = true;
1495 			goto out;
1496 		}
1497 	}
1498 	error = false;
1499 
1500 out:
1501 	prop_object_iterator_release(props_iter);
1502 
1503 	return !error;
1504 }
1505