17330f729Sjoerg //== TestAfterDivZeroChecker.cpp - Test after division by zero checker --*--==//
27330f729Sjoerg //
37330f729Sjoerg // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
47330f729Sjoerg // See https://llvm.org/LICENSE.txt for license information.
57330f729Sjoerg // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
67330f729Sjoerg //
77330f729Sjoerg //===----------------------------------------------------------------------===//
87330f729Sjoerg //
97330f729Sjoerg // This defines TestAfterDivZeroChecker, a builtin check that performs checks
107330f729Sjoerg // for division by zero where the division occurs before comparison with zero.
117330f729Sjoerg //
127330f729Sjoerg //===----------------------------------------------------------------------===//
137330f729Sjoerg
147330f729Sjoerg #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
157330f729Sjoerg #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
167330f729Sjoerg #include "clang/StaticAnalyzer/Core/Checker.h"
177330f729Sjoerg #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
187330f729Sjoerg #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
197330f729Sjoerg #include "llvm/ADT/FoldingSet.h"
207330f729Sjoerg
217330f729Sjoerg using namespace clang;
227330f729Sjoerg using namespace ento;
237330f729Sjoerg
247330f729Sjoerg namespace {
257330f729Sjoerg
267330f729Sjoerg class ZeroState {
277330f729Sjoerg private:
287330f729Sjoerg SymbolRef ZeroSymbol;
297330f729Sjoerg unsigned BlockID;
307330f729Sjoerg const StackFrameContext *SFC;
317330f729Sjoerg
327330f729Sjoerg public:
ZeroState(SymbolRef S,unsigned B,const StackFrameContext * SFC)337330f729Sjoerg ZeroState(SymbolRef S, unsigned B, const StackFrameContext *SFC)
347330f729Sjoerg : ZeroSymbol(S), BlockID(B), SFC(SFC) {}
357330f729Sjoerg
getStackFrameContext() const367330f729Sjoerg const StackFrameContext *getStackFrameContext() const { return SFC; }
377330f729Sjoerg
operator ==(const ZeroState & X) const387330f729Sjoerg bool operator==(const ZeroState &X) const {
397330f729Sjoerg return BlockID == X.BlockID && SFC == X.SFC && ZeroSymbol == X.ZeroSymbol;
407330f729Sjoerg }
417330f729Sjoerg
operator <(const ZeroState & X) const427330f729Sjoerg bool operator<(const ZeroState &X) const {
437330f729Sjoerg if (BlockID != X.BlockID)
447330f729Sjoerg return BlockID < X.BlockID;
457330f729Sjoerg if (SFC != X.SFC)
467330f729Sjoerg return SFC < X.SFC;
477330f729Sjoerg return ZeroSymbol < X.ZeroSymbol;
487330f729Sjoerg }
497330f729Sjoerg
Profile(llvm::FoldingSetNodeID & ID) const507330f729Sjoerg void Profile(llvm::FoldingSetNodeID &ID) const {
517330f729Sjoerg ID.AddInteger(BlockID);
527330f729Sjoerg ID.AddPointer(SFC);
537330f729Sjoerg ID.AddPointer(ZeroSymbol);
547330f729Sjoerg }
557330f729Sjoerg };
567330f729Sjoerg
577330f729Sjoerg class DivisionBRVisitor : public BugReporterVisitor {
587330f729Sjoerg private:
597330f729Sjoerg SymbolRef ZeroSymbol;
607330f729Sjoerg const StackFrameContext *SFC;
617330f729Sjoerg bool Satisfied;
627330f729Sjoerg
637330f729Sjoerg public:
DivisionBRVisitor(SymbolRef ZeroSymbol,const StackFrameContext * SFC)647330f729Sjoerg DivisionBRVisitor(SymbolRef ZeroSymbol, const StackFrameContext *SFC)
657330f729Sjoerg : ZeroSymbol(ZeroSymbol), SFC(SFC), Satisfied(false) {}
667330f729Sjoerg
Profile(llvm::FoldingSetNodeID & ID) const677330f729Sjoerg void Profile(llvm::FoldingSetNodeID &ID) const override {
687330f729Sjoerg ID.Add(ZeroSymbol);
697330f729Sjoerg ID.Add(SFC);
707330f729Sjoerg }
717330f729Sjoerg
727330f729Sjoerg PathDiagnosticPieceRef VisitNode(const ExplodedNode *Succ,
737330f729Sjoerg BugReporterContext &BRC,
747330f729Sjoerg PathSensitiveBugReport &BR) override;
757330f729Sjoerg };
767330f729Sjoerg
777330f729Sjoerg class TestAfterDivZeroChecker
787330f729Sjoerg : public Checker<check::PreStmt<BinaryOperator>, check::BranchCondition,
797330f729Sjoerg check::EndFunction> {
807330f729Sjoerg mutable std::unique_ptr<BuiltinBug> DivZeroBug;
817330f729Sjoerg void reportBug(SVal Val, CheckerContext &C) const;
827330f729Sjoerg
837330f729Sjoerg public:
847330f729Sjoerg void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
857330f729Sjoerg void checkBranchCondition(const Stmt *Condition, CheckerContext &C) const;
867330f729Sjoerg void checkEndFunction(const ReturnStmt *RS, CheckerContext &C) const;
877330f729Sjoerg void setDivZeroMap(SVal Var, CheckerContext &C) const;
887330f729Sjoerg bool hasDivZeroMap(SVal Var, const CheckerContext &C) const;
897330f729Sjoerg bool isZero(SVal S, CheckerContext &C) const;
907330f729Sjoerg };
917330f729Sjoerg } // end anonymous namespace
927330f729Sjoerg
REGISTER_SET_WITH_PROGRAMSTATE(DivZeroMap,ZeroState)937330f729Sjoerg REGISTER_SET_WITH_PROGRAMSTATE(DivZeroMap, ZeroState)
947330f729Sjoerg
957330f729Sjoerg PathDiagnosticPieceRef
967330f729Sjoerg DivisionBRVisitor::VisitNode(const ExplodedNode *Succ, BugReporterContext &BRC,
977330f729Sjoerg PathSensitiveBugReport &BR) {
987330f729Sjoerg if (Satisfied)
997330f729Sjoerg return nullptr;
1007330f729Sjoerg
1017330f729Sjoerg const Expr *E = nullptr;
1027330f729Sjoerg
1037330f729Sjoerg if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>())
1047330f729Sjoerg if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>()) {
1057330f729Sjoerg BinaryOperator::Opcode Op = BO->getOpcode();
1067330f729Sjoerg if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign ||
1077330f729Sjoerg Op == BO_RemAssign) {
1087330f729Sjoerg E = BO->getRHS();
1097330f729Sjoerg }
1107330f729Sjoerg }
1117330f729Sjoerg
1127330f729Sjoerg if (!E)
1137330f729Sjoerg return nullptr;
1147330f729Sjoerg
1157330f729Sjoerg SVal S = Succ->getSVal(E);
1167330f729Sjoerg if (ZeroSymbol == S.getAsSymbol() && SFC == Succ->getStackFrame()) {
1177330f729Sjoerg Satisfied = true;
1187330f729Sjoerg
1197330f729Sjoerg // Construct a new PathDiagnosticPiece.
1207330f729Sjoerg ProgramPoint P = Succ->getLocation();
1217330f729Sjoerg PathDiagnosticLocation L =
1227330f729Sjoerg PathDiagnosticLocation::create(P, BRC.getSourceManager());
1237330f729Sjoerg
1247330f729Sjoerg if (!L.isValid() || !L.asLocation().isValid())
1257330f729Sjoerg return nullptr;
1267330f729Sjoerg
1277330f729Sjoerg return std::make_shared<PathDiagnosticEventPiece>(
1287330f729Sjoerg L, "Division with compared value made here");
1297330f729Sjoerg }
1307330f729Sjoerg
1317330f729Sjoerg return nullptr;
1327330f729Sjoerg }
1337330f729Sjoerg
isZero(SVal S,CheckerContext & C) const1347330f729Sjoerg bool TestAfterDivZeroChecker::isZero(SVal S, CheckerContext &C) const {
1357330f729Sjoerg Optional<DefinedSVal> DSV = S.getAs<DefinedSVal>();
1367330f729Sjoerg
1377330f729Sjoerg if (!DSV)
1387330f729Sjoerg return false;
1397330f729Sjoerg
1407330f729Sjoerg ConstraintManager &CM = C.getConstraintManager();
1417330f729Sjoerg return !CM.assume(C.getState(), *DSV, true);
1427330f729Sjoerg }
1437330f729Sjoerg
setDivZeroMap(SVal Var,CheckerContext & C) const1447330f729Sjoerg void TestAfterDivZeroChecker::setDivZeroMap(SVal Var, CheckerContext &C) const {
1457330f729Sjoerg SymbolRef SR = Var.getAsSymbol();
1467330f729Sjoerg if (!SR)
1477330f729Sjoerg return;
1487330f729Sjoerg
1497330f729Sjoerg ProgramStateRef State = C.getState();
1507330f729Sjoerg State =
1517330f729Sjoerg State->add<DivZeroMap>(ZeroState(SR, C.getBlockID(), C.getStackFrame()));
1527330f729Sjoerg C.addTransition(State);
1537330f729Sjoerg }
1547330f729Sjoerg
hasDivZeroMap(SVal Var,const CheckerContext & C) const1557330f729Sjoerg bool TestAfterDivZeroChecker::hasDivZeroMap(SVal Var,
1567330f729Sjoerg const CheckerContext &C) const {
1577330f729Sjoerg SymbolRef SR = Var.getAsSymbol();
1587330f729Sjoerg if (!SR)
1597330f729Sjoerg return false;
1607330f729Sjoerg
1617330f729Sjoerg ZeroState ZS(SR, C.getBlockID(), C.getStackFrame());
1627330f729Sjoerg return C.getState()->contains<DivZeroMap>(ZS);
1637330f729Sjoerg }
1647330f729Sjoerg
reportBug(SVal Val,CheckerContext & C) const1657330f729Sjoerg void TestAfterDivZeroChecker::reportBug(SVal Val, CheckerContext &C) const {
1667330f729Sjoerg if (ExplodedNode *N = C.generateErrorNode(C.getState())) {
1677330f729Sjoerg if (!DivZeroBug)
1687330f729Sjoerg DivZeroBug.reset(new BuiltinBug(this, "Division by zero"));
1697330f729Sjoerg
1707330f729Sjoerg auto R = std::make_unique<PathSensitiveBugReport>(
1717330f729Sjoerg *DivZeroBug, "Value being compared against zero has already been used "
1727330f729Sjoerg "for division",
1737330f729Sjoerg N);
1747330f729Sjoerg
1757330f729Sjoerg R->addVisitor(std::make_unique<DivisionBRVisitor>(Val.getAsSymbol(),
1767330f729Sjoerg C.getStackFrame()));
1777330f729Sjoerg C.emitReport(std::move(R));
1787330f729Sjoerg }
1797330f729Sjoerg }
1807330f729Sjoerg
checkEndFunction(const ReturnStmt *,CheckerContext & C) const1817330f729Sjoerg void TestAfterDivZeroChecker::checkEndFunction(const ReturnStmt *,
1827330f729Sjoerg CheckerContext &C) const {
1837330f729Sjoerg ProgramStateRef State = C.getState();
1847330f729Sjoerg
1857330f729Sjoerg DivZeroMapTy DivZeroes = State->get<DivZeroMap>();
1867330f729Sjoerg if (DivZeroes.isEmpty())
1877330f729Sjoerg return;
1887330f729Sjoerg
1897330f729Sjoerg DivZeroMapTy::Factory &F = State->get_context<DivZeroMap>();
1907330f729Sjoerg for (llvm::ImmutableSet<ZeroState>::iterator I = DivZeroes.begin(),
1917330f729Sjoerg E = DivZeroes.end();
1927330f729Sjoerg I != E; ++I) {
1937330f729Sjoerg ZeroState ZS = *I;
1947330f729Sjoerg if (ZS.getStackFrameContext() == C.getStackFrame())
1957330f729Sjoerg DivZeroes = F.remove(DivZeroes, ZS);
1967330f729Sjoerg }
1977330f729Sjoerg C.addTransition(State->set<DivZeroMap>(DivZeroes));
1987330f729Sjoerg }
1997330f729Sjoerg
checkPreStmt(const BinaryOperator * B,CheckerContext & C) const2007330f729Sjoerg void TestAfterDivZeroChecker::checkPreStmt(const BinaryOperator *B,
2017330f729Sjoerg CheckerContext &C) const {
2027330f729Sjoerg BinaryOperator::Opcode Op = B->getOpcode();
2037330f729Sjoerg if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign ||
2047330f729Sjoerg Op == BO_RemAssign) {
2057330f729Sjoerg SVal S = C.getSVal(B->getRHS());
2067330f729Sjoerg
2077330f729Sjoerg if (!isZero(S, C))
2087330f729Sjoerg setDivZeroMap(S, C);
2097330f729Sjoerg }
2107330f729Sjoerg }
2117330f729Sjoerg
checkBranchCondition(const Stmt * Condition,CheckerContext & C) const2127330f729Sjoerg void TestAfterDivZeroChecker::checkBranchCondition(const Stmt *Condition,
2137330f729Sjoerg CheckerContext &C) const {
2147330f729Sjoerg if (const BinaryOperator *B = dyn_cast<BinaryOperator>(Condition)) {
2157330f729Sjoerg if (B->isComparisonOp()) {
2167330f729Sjoerg const IntegerLiteral *IntLiteral = dyn_cast<IntegerLiteral>(B->getRHS());
2177330f729Sjoerg bool LRHS = true;
2187330f729Sjoerg if (!IntLiteral) {
2197330f729Sjoerg IntLiteral = dyn_cast<IntegerLiteral>(B->getLHS());
2207330f729Sjoerg LRHS = false;
2217330f729Sjoerg }
2227330f729Sjoerg
2237330f729Sjoerg if (!IntLiteral || IntLiteral->getValue() != 0)
2247330f729Sjoerg return;
2257330f729Sjoerg
2267330f729Sjoerg SVal Val = C.getSVal(LRHS ? B->getLHS() : B->getRHS());
2277330f729Sjoerg if (hasDivZeroMap(Val, C))
2287330f729Sjoerg reportBug(Val, C);
2297330f729Sjoerg }
2307330f729Sjoerg } else if (const UnaryOperator *U = dyn_cast<UnaryOperator>(Condition)) {
2317330f729Sjoerg if (U->getOpcode() == UO_LNot) {
2327330f729Sjoerg SVal Val;
2337330f729Sjoerg if (const ImplicitCastExpr *I =
2347330f729Sjoerg dyn_cast<ImplicitCastExpr>(U->getSubExpr()))
2357330f729Sjoerg Val = C.getSVal(I->getSubExpr());
2367330f729Sjoerg
2377330f729Sjoerg if (hasDivZeroMap(Val, C))
2387330f729Sjoerg reportBug(Val, C);
2397330f729Sjoerg else {
2407330f729Sjoerg Val = C.getSVal(U->getSubExpr());
2417330f729Sjoerg if (hasDivZeroMap(Val, C))
2427330f729Sjoerg reportBug(Val, C);
2437330f729Sjoerg }
2447330f729Sjoerg }
2457330f729Sjoerg } else if (const ImplicitCastExpr *IE =
2467330f729Sjoerg dyn_cast<ImplicitCastExpr>(Condition)) {
2477330f729Sjoerg SVal Val = C.getSVal(IE->getSubExpr());
2487330f729Sjoerg
2497330f729Sjoerg if (hasDivZeroMap(Val, C))
2507330f729Sjoerg reportBug(Val, C);
2517330f729Sjoerg else {
2527330f729Sjoerg SVal Val = C.getSVal(Condition);
2537330f729Sjoerg
2547330f729Sjoerg if (hasDivZeroMap(Val, C))
2557330f729Sjoerg reportBug(Val, C);
2567330f729Sjoerg }
2577330f729Sjoerg }
2587330f729Sjoerg }
2597330f729Sjoerg
registerTestAfterDivZeroChecker(CheckerManager & mgr)2607330f729Sjoerg void ento::registerTestAfterDivZeroChecker(CheckerManager &mgr) {
2617330f729Sjoerg mgr.registerChecker<TestAfterDivZeroChecker>();
2627330f729Sjoerg }
2637330f729Sjoerg
shouldRegisterTestAfterDivZeroChecker(const CheckerManager & mgr)264*e038c9c4Sjoerg bool ento::shouldRegisterTestAfterDivZeroChecker(const CheckerManager &mgr) {
2657330f729Sjoerg return true;
2667330f729Sjoerg }
267