1 //===- MachineVerifier.cpp - Machine Code Verifier ------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // Pass to verify generated machine code. The following is checked: 10 // 11 // Operand counts: All explicit operands must be present. 12 // 13 // Register classes: All physical and virtual register operands must be 14 // compatible with the register class required by the instruction descriptor. 15 // 16 // Register live intervals: Registers must be defined only once, and must be 17 // defined before use. 18 // 19 // The machine code verifier is enabled from LLVMTargetMachine.cpp with the 20 // command-line option -verify-machineinstrs, or by defining the environment 21 // variable LLVM_VERIFY_MACHINEINSTRS to the name of a file that will receive 22 // the verifier errors. 23 //===----------------------------------------------------------------------===// 24 25 #include "LiveRangeCalc.h" 26 #include "llvm/ADT/BitVector.h" 27 #include "llvm/ADT/DenseMap.h" 28 #include "llvm/ADT/DenseSet.h" 29 #include "llvm/ADT/DepthFirstIterator.h" 30 #include "llvm/ADT/STLExtras.h" 31 #include "llvm/ADT/SetOperations.h" 32 #include "llvm/ADT/SmallPtrSet.h" 33 #include "llvm/ADT/SmallVector.h" 34 #include "llvm/ADT/StringRef.h" 35 #include "llvm/ADT/Twine.h" 36 #include "llvm/Analysis/EHPersonalities.h" 37 #include "llvm/CodeGen/GlobalISel/RegisterBank.h" 38 #include "llvm/CodeGen/LiveInterval.h" 39 #include "llvm/CodeGen/LiveIntervals.h" 40 #include "llvm/CodeGen/LiveStacks.h" 41 #include "llvm/CodeGen/LiveVariables.h" 42 #include "llvm/CodeGen/MachineBasicBlock.h" 43 #include "llvm/CodeGen/MachineFrameInfo.h" 44 #include "llvm/CodeGen/MachineFunction.h" 45 #include "llvm/CodeGen/MachineFunctionPass.h" 46 #include "llvm/CodeGen/MachineInstr.h" 47 #include "llvm/CodeGen/MachineInstrBundle.h" 48 #include "llvm/CodeGen/MachineMemOperand.h" 49 #include "llvm/CodeGen/MachineOperand.h" 50 #include "llvm/CodeGen/MachineRegisterInfo.h" 51 #include "llvm/CodeGen/PseudoSourceValue.h" 52 #include "llvm/CodeGen/SlotIndexes.h" 53 #include "llvm/CodeGen/StackMaps.h" 54 #include "llvm/CodeGen/TargetInstrInfo.h" 55 #include "llvm/CodeGen/TargetOpcodes.h" 56 #include "llvm/CodeGen/TargetRegisterInfo.h" 57 #include "llvm/CodeGen/TargetSubtargetInfo.h" 58 #include "llvm/IR/BasicBlock.h" 59 #include "llvm/IR/Function.h" 60 #include "llvm/IR/InlineAsm.h" 61 #include "llvm/IR/Instructions.h" 62 #include "llvm/MC/LaneBitmask.h" 63 #include "llvm/MC/MCAsmInfo.h" 64 #include "llvm/MC/MCInstrDesc.h" 65 #include "llvm/MC/MCRegisterInfo.h" 66 #include "llvm/MC/MCTargetOptions.h" 67 #include "llvm/Pass.h" 68 #include "llvm/Support/Casting.h" 69 #include "llvm/Support/ErrorHandling.h" 70 #include "llvm/Support/LowLevelTypeImpl.h" 71 #include "llvm/Support/MathExtras.h" 72 #include "llvm/Support/raw_ostream.h" 73 #include "llvm/Target/TargetMachine.h" 74 #include <algorithm> 75 #include <cassert> 76 #include <cstddef> 77 #include <cstdint> 78 #include <iterator> 79 #include <string> 80 #include <utility> 81 82 using namespace llvm; 83 84 namespace { 85 86 struct MachineVerifier { 87 MachineVerifier(Pass *pass, const char *b) : PASS(pass), Banner(b) {} 88 89 unsigned verify(MachineFunction &MF); 90 91 Pass *const PASS; 92 const char *Banner; 93 const MachineFunction *MF; 94 const TargetMachine *TM; 95 const TargetInstrInfo *TII; 96 const TargetRegisterInfo *TRI; 97 const MachineRegisterInfo *MRI; 98 99 unsigned foundErrors; 100 101 // Avoid querying the MachineFunctionProperties for each operand. 102 bool isFunctionRegBankSelected; 103 bool isFunctionSelected; 104 105 using RegVector = SmallVector<unsigned, 16>; 106 using RegMaskVector = SmallVector<const uint32_t *, 4>; 107 using RegSet = DenseSet<unsigned>; 108 using RegMap = DenseMap<unsigned, const MachineInstr *>; 109 using BlockSet = SmallPtrSet<const MachineBasicBlock *, 8>; 110 111 const MachineInstr *FirstNonPHI; 112 const MachineInstr *FirstTerminator; 113 BlockSet FunctionBlocks; 114 115 BitVector regsReserved; 116 RegSet regsLive; 117 RegVector regsDefined, regsDead, regsKilled; 118 RegMaskVector regMasks; 119 120 SlotIndex lastIndex; 121 122 // Add Reg and any sub-registers to RV 123 void addRegWithSubRegs(RegVector &RV, unsigned Reg) { 124 RV.push_back(Reg); 125 if (TargetRegisterInfo::isPhysicalRegister(Reg)) 126 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) 127 RV.push_back(*SubRegs); 128 } 129 130 struct BBInfo { 131 // Is this MBB reachable from the MF entry point? 132 bool reachable = false; 133 134 // Vregs that must be live in because they are used without being 135 // defined. Map value is the user. 136 RegMap vregsLiveIn; 137 138 // Regs killed in MBB. They may be defined again, and will then be in both 139 // regsKilled and regsLiveOut. 140 RegSet regsKilled; 141 142 // Regs defined in MBB and live out. Note that vregs passing through may 143 // be live out without being mentioned here. 144 RegSet regsLiveOut; 145 146 // Vregs that pass through MBB untouched. This set is disjoint from 147 // regsKilled and regsLiveOut. 148 RegSet vregsPassed; 149 150 // Vregs that must pass through MBB because they are needed by a successor 151 // block. This set is disjoint from regsLiveOut. 152 RegSet vregsRequired; 153 154 // Set versions of block's predecessor and successor lists. 155 BlockSet Preds, Succs; 156 157 BBInfo() = default; 158 159 // Add register to vregsPassed if it belongs there. Return true if 160 // anything changed. 161 bool addPassed(unsigned Reg) { 162 if (!TargetRegisterInfo::isVirtualRegister(Reg)) 163 return false; 164 if (regsKilled.count(Reg) || regsLiveOut.count(Reg)) 165 return false; 166 return vregsPassed.insert(Reg).second; 167 } 168 169 // Same for a full set. 170 bool addPassed(const RegSet &RS) { 171 bool changed = false; 172 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I) 173 if (addPassed(*I)) 174 changed = true; 175 return changed; 176 } 177 178 // Add register to vregsRequired if it belongs there. Return true if 179 // anything changed. 180 bool addRequired(unsigned Reg) { 181 if (!TargetRegisterInfo::isVirtualRegister(Reg)) 182 return false; 183 if (regsLiveOut.count(Reg)) 184 return false; 185 return vregsRequired.insert(Reg).second; 186 } 187 188 // Same for a full set. 189 bool addRequired(const RegSet &RS) { 190 bool changed = false; 191 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I) 192 if (addRequired(*I)) 193 changed = true; 194 return changed; 195 } 196 197 // Same for a full map. 198 bool addRequired(const RegMap &RM) { 199 bool changed = false; 200 for (RegMap::const_iterator I = RM.begin(), E = RM.end(); I != E; ++I) 201 if (addRequired(I->first)) 202 changed = true; 203 return changed; 204 } 205 206 // Live-out registers are either in regsLiveOut or vregsPassed. 207 bool isLiveOut(unsigned Reg) const { 208 return regsLiveOut.count(Reg) || vregsPassed.count(Reg); 209 } 210 }; 211 212 // Extra register info per MBB. 213 DenseMap<const MachineBasicBlock*, BBInfo> MBBInfoMap; 214 215 bool isReserved(unsigned Reg) { 216 return Reg < regsReserved.size() && regsReserved.test(Reg); 217 } 218 219 bool isAllocatable(unsigned Reg) const { 220 return Reg < TRI->getNumRegs() && TRI->isInAllocatableClass(Reg) && 221 !regsReserved.test(Reg); 222 } 223 224 // Analysis information if available 225 LiveVariables *LiveVars; 226 LiveIntervals *LiveInts; 227 LiveStacks *LiveStks; 228 SlotIndexes *Indexes; 229 230 void visitMachineFunctionBefore(); 231 void visitMachineBasicBlockBefore(const MachineBasicBlock *MBB); 232 void visitMachineBundleBefore(const MachineInstr *MI); 233 void visitMachineInstrBefore(const MachineInstr *MI); 234 void visitMachineOperand(const MachineOperand *MO, unsigned MONum); 235 void visitMachineInstrAfter(const MachineInstr *MI); 236 void visitMachineBundleAfter(const MachineInstr *MI); 237 void visitMachineBasicBlockAfter(const MachineBasicBlock *MBB); 238 void visitMachineFunctionAfter(); 239 240 void report(const char *msg, const MachineFunction *MF); 241 void report(const char *msg, const MachineBasicBlock *MBB); 242 void report(const char *msg, const MachineInstr *MI); 243 void report(const char *msg, const MachineOperand *MO, unsigned MONum, 244 LLT MOVRegType = LLT{}); 245 246 void report_context(const LiveInterval &LI) const; 247 void report_context(const LiveRange &LR, unsigned VRegUnit, 248 LaneBitmask LaneMask) const; 249 void report_context(const LiveRange::Segment &S) const; 250 void report_context(const VNInfo &VNI) const; 251 void report_context(SlotIndex Pos) const; 252 void report_context(MCPhysReg PhysReg) const; 253 void report_context_liverange(const LiveRange &LR) const; 254 void report_context_lanemask(LaneBitmask LaneMask) const; 255 void report_context_vreg(unsigned VReg) const; 256 void report_context_vreg_regunit(unsigned VRegOrUnit) const; 257 258 void verifyInlineAsm(const MachineInstr *MI); 259 260 void checkLiveness(const MachineOperand *MO, unsigned MONum); 261 void checkLivenessAtUse(const MachineOperand *MO, unsigned MONum, 262 SlotIndex UseIdx, const LiveRange &LR, unsigned VRegOrUnit, 263 LaneBitmask LaneMask = LaneBitmask::getNone()); 264 void checkLivenessAtDef(const MachineOperand *MO, unsigned MONum, 265 SlotIndex DefIdx, const LiveRange &LR, unsigned VRegOrUnit, 266 bool SubRangeCheck = false, 267 LaneBitmask LaneMask = LaneBitmask::getNone()); 268 269 void markReachable(const MachineBasicBlock *MBB); 270 void calcRegsPassed(); 271 void checkPHIOps(const MachineBasicBlock &MBB); 272 273 void calcRegsRequired(); 274 void verifyLiveVariables(); 275 void verifyLiveIntervals(); 276 void verifyLiveInterval(const LiveInterval&); 277 void verifyLiveRangeValue(const LiveRange&, const VNInfo*, unsigned, 278 LaneBitmask); 279 void verifyLiveRangeSegment(const LiveRange&, 280 const LiveRange::const_iterator I, unsigned, 281 LaneBitmask); 282 void verifyLiveRange(const LiveRange&, unsigned, 283 LaneBitmask LaneMask = LaneBitmask::getNone()); 284 285 void verifyStackFrame(); 286 287 void verifySlotIndexes() const; 288 void verifyProperties(const MachineFunction &MF); 289 }; 290 291 struct MachineVerifierPass : public MachineFunctionPass { 292 static char ID; // Pass ID, replacement for typeid 293 294 const std::string Banner; 295 296 MachineVerifierPass(std::string banner = std::string()) 297 : MachineFunctionPass(ID), Banner(std::move(banner)) { 298 initializeMachineVerifierPassPass(*PassRegistry::getPassRegistry()); 299 } 300 301 void getAnalysisUsage(AnalysisUsage &AU) const override { 302 AU.setPreservesAll(); 303 MachineFunctionPass::getAnalysisUsage(AU); 304 } 305 306 bool runOnMachineFunction(MachineFunction &MF) override { 307 unsigned FoundErrors = MachineVerifier(this, Banner.c_str()).verify(MF); 308 if (FoundErrors) 309 report_fatal_error("Found "+Twine(FoundErrors)+" machine code errors."); 310 return false; 311 } 312 }; 313 314 } // end anonymous namespace 315 316 char MachineVerifierPass::ID = 0; 317 318 INITIALIZE_PASS(MachineVerifierPass, "machineverifier", 319 "Verify generated machine code", false, false) 320 321 FunctionPass *llvm::createMachineVerifierPass(const std::string &Banner) { 322 return new MachineVerifierPass(Banner); 323 } 324 325 bool MachineFunction::verify(Pass *p, const char *Banner, bool AbortOnErrors) 326 const { 327 MachineFunction &MF = const_cast<MachineFunction&>(*this); 328 unsigned FoundErrors = MachineVerifier(p, Banner).verify(MF); 329 if (AbortOnErrors && FoundErrors) 330 report_fatal_error("Found "+Twine(FoundErrors)+" machine code errors."); 331 return FoundErrors == 0; 332 } 333 334 void MachineVerifier::verifySlotIndexes() const { 335 if (Indexes == nullptr) 336 return; 337 338 // Ensure the IdxMBB list is sorted by slot indexes. 339 SlotIndex Last; 340 for (SlotIndexes::MBBIndexIterator I = Indexes->MBBIndexBegin(), 341 E = Indexes->MBBIndexEnd(); I != E; ++I) { 342 assert(!Last.isValid() || I->first > Last); 343 Last = I->first; 344 } 345 } 346 347 void MachineVerifier::verifyProperties(const MachineFunction &MF) { 348 // If a pass has introduced virtual registers without clearing the 349 // NoVRegs property (or set it without allocating the vregs) 350 // then report an error. 351 if (MF.getProperties().hasProperty( 352 MachineFunctionProperties::Property::NoVRegs) && 353 MRI->getNumVirtRegs()) 354 report("Function has NoVRegs property but there are VReg operands", &MF); 355 } 356 357 unsigned MachineVerifier::verify(MachineFunction &MF) { 358 foundErrors = 0; 359 360 this->MF = &MF; 361 TM = &MF.getTarget(); 362 TII = MF.getSubtarget().getInstrInfo(); 363 TRI = MF.getSubtarget().getRegisterInfo(); 364 MRI = &MF.getRegInfo(); 365 366 const bool isFunctionFailedISel = MF.getProperties().hasProperty( 367 MachineFunctionProperties::Property::FailedISel); 368 369 // If we're mid-GlobalISel and we already triggered the fallback path then 370 // it's expected that the MIR is somewhat broken but that's ok since we'll 371 // reset it and clear the FailedISel attribute in ResetMachineFunctions. 372 if (isFunctionFailedISel) 373 return foundErrors; 374 375 isFunctionRegBankSelected = 376 !isFunctionFailedISel && 377 MF.getProperties().hasProperty( 378 MachineFunctionProperties::Property::RegBankSelected); 379 isFunctionSelected = !isFunctionFailedISel && 380 MF.getProperties().hasProperty( 381 MachineFunctionProperties::Property::Selected); 382 LiveVars = nullptr; 383 LiveInts = nullptr; 384 LiveStks = nullptr; 385 Indexes = nullptr; 386 if (PASS) { 387 LiveInts = PASS->getAnalysisIfAvailable<LiveIntervals>(); 388 // We don't want to verify LiveVariables if LiveIntervals is available. 389 if (!LiveInts) 390 LiveVars = PASS->getAnalysisIfAvailable<LiveVariables>(); 391 LiveStks = PASS->getAnalysisIfAvailable<LiveStacks>(); 392 Indexes = PASS->getAnalysisIfAvailable<SlotIndexes>(); 393 } 394 395 verifySlotIndexes(); 396 397 verifyProperties(MF); 398 399 visitMachineFunctionBefore(); 400 for (MachineFunction::const_iterator MFI = MF.begin(), MFE = MF.end(); 401 MFI!=MFE; ++MFI) { 402 visitMachineBasicBlockBefore(&*MFI); 403 // Keep track of the current bundle header. 404 const MachineInstr *CurBundle = nullptr; 405 // Do we expect the next instruction to be part of the same bundle? 406 bool InBundle = false; 407 408 for (MachineBasicBlock::const_instr_iterator MBBI = MFI->instr_begin(), 409 MBBE = MFI->instr_end(); MBBI != MBBE; ++MBBI) { 410 if (MBBI->getParent() != &*MFI) { 411 report("Bad instruction parent pointer", &*MFI); 412 errs() << "Instruction: " << *MBBI; 413 continue; 414 } 415 416 // Check for consistent bundle flags. 417 if (InBundle && !MBBI->isBundledWithPred()) 418 report("Missing BundledPred flag, " 419 "BundledSucc was set on predecessor", 420 &*MBBI); 421 if (!InBundle && MBBI->isBundledWithPred()) 422 report("BundledPred flag is set, " 423 "but BundledSucc not set on predecessor", 424 &*MBBI); 425 426 // Is this a bundle header? 427 if (!MBBI->isInsideBundle()) { 428 if (CurBundle) 429 visitMachineBundleAfter(CurBundle); 430 CurBundle = &*MBBI; 431 visitMachineBundleBefore(CurBundle); 432 } else if (!CurBundle) 433 report("No bundle header", &*MBBI); 434 visitMachineInstrBefore(&*MBBI); 435 for (unsigned I = 0, E = MBBI->getNumOperands(); I != E; ++I) { 436 const MachineInstr &MI = *MBBI; 437 const MachineOperand &Op = MI.getOperand(I); 438 if (Op.getParent() != &MI) { 439 // Make sure to use correct addOperand / RemoveOperand / ChangeTo 440 // functions when replacing operands of a MachineInstr. 441 report("Instruction has operand with wrong parent set", &MI); 442 } 443 444 visitMachineOperand(&Op, I); 445 } 446 447 visitMachineInstrAfter(&*MBBI); 448 449 // Was this the last bundled instruction? 450 InBundle = MBBI->isBundledWithSucc(); 451 } 452 if (CurBundle) 453 visitMachineBundleAfter(CurBundle); 454 if (InBundle) 455 report("BundledSucc flag set on last instruction in block", &MFI->back()); 456 visitMachineBasicBlockAfter(&*MFI); 457 } 458 visitMachineFunctionAfter(); 459 460 // Clean up. 461 regsLive.clear(); 462 regsDefined.clear(); 463 regsDead.clear(); 464 regsKilled.clear(); 465 regMasks.clear(); 466 MBBInfoMap.clear(); 467 468 return foundErrors; 469 } 470 471 void MachineVerifier::report(const char *msg, const MachineFunction *MF) { 472 assert(MF); 473 errs() << '\n'; 474 if (!foundErrors++) { 475 if (Banner) 476 errs() << "# " << Banner << '\n'; 477 if (LiveInts != nullptr) 478 LiveInts->print(errs()); 479 else 480 MF->print(errs(), Indexes); 481 } 482 errs() << "*** Bad machine code: " << msg << " ***\n" 483 << "- function: " << MF->getName() << "\n"; 484 } 485 486 void MachineVerifier::report(const char *msg, const MachineBasicBlock *MBB) { 487 assert(MBB); 488 report(msg, MBB->getParent()); 489 errs() << "- basic block: " << printMBBReference(*MBB) << ' ' 490 << MBB->getName() << " (" << (const void *)MBB << ')'; 491 if (Indexes) 492 errs() << " [" << Indexes->getMBBStartIdx(MBB) 493 << ';' << Indexes->getMBBEndIdx(MBB) << ')'; 494 errs() << '\n'; 495 } 496 497 void MachineVerifier::report(const char *msg, const MachineInstr *MI) { 498 assert(MI); 499 report(msg, MI->getParent()); 500 errs() << "- instruction: "; 501 if (Indexes && Indexes->hasIndex(*MI)) 502 errs() << Indexes->getInstructionIndex(*MI) << '\t'; 503 MI->print(errs(), /*SkipOpers=*/true); 504 } 505 506 void MachineVerifier::report(const char *msg, const MachineOperand *MO, 507 unsigned MONum, LLT MOVRegType) { 508 assert(MO); 509 report(msg, MO->getParent()); 510 errs() << "- operand " << MONum << ": "; 511 MO->print(errs(), MOVRegType, TRI); 512 errs() << "\n"; 513 } 514 515 void MachineVerifier::report_context(SlotIndex Pos) const { 516 errs() << "- at: " << Pos << '\n'; 517 } 518 519 void MachineVerifier::report_context(const LiveInterval &LI) const { 520 errs() << "- interval: " << LI << '\n'; 521 } 522 523 void MachineVerifier::report_context(const LiveRange &LR, unsigned VRegUnit, 524 LaneBitmask LaneMask) const { 525 report_context_liverange(LR); 526 report_context_vreg_regunit(VRegUnit); 527 if (LaneMask.any()) 528 report_context_lanemask(LaneMask); 529 } 530 531 void MachineVerifier::report_context(const LiveRange::Segment &S) const { 532 errs() << "- segment: " << S << '\n'; 533 } 534 535 void MachineVerifier::report_context(const VNInfo &VNI) const { 536 errs() << "- ValNo: " << VNI.id << " (def " << VNI.def << ")\n"; 537 } 538 539 void MachineVerifier::report_context_liverange(const LiveRange &LR) const { 540 errs() << "- liverange: " << LR << '\n'; 541 } 542 543 void MachineVerifier::report_context(MCPhysReg PReg) const { 544 errs() << "- p. register: " << printReg(PReg, TRI) << '\n'; 545 } 546 547 void MachineVerifier::report_context_vreg(unsigned VReg) const { 548 errs() << "- v. register: " << printReg(VReg, TRI) << '\n'; 549 } 550 551 void MachineVerifier::report_context_vreg_regunit(unsigned VRegOrUnit) const { 552 if (TargetRegisterInfo::isVirtualRegister(VRegOrUnit)) { 553 report_context_vreg(VRegOrUnit); 554 } else { 555 errs() << "- regunit: " << printRegUnit(VRegOrUnit, TRI) << '\n'; 556 } 557 } 558 559 void MachineVerifier::report_context_lanemask(LaneBitmask LaneMask) const { 560 errs() << "- lanemask: " << PrintLaneMask(LaneMask) << '\n'; 561 } 562 563 void MachineVerifier::markReachable(const MachineBasicBlock *MBB) { 564 BBInfo &MInfo = MBBInfoMap[MBB]; 565 if (!MInfo.reachable) { 566 MInfo.reachable = true; 567 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(), 568 SuE = MBB->succ_end(); SuI != SuE; ++SuI) 569 markReachable(*SuI); 570 } 571 } 572 573 void MachineVerifier::visitMachineFunctionBefore() { 574 lastIndex = SlotIndex(); 575 regsReserved = MRI->reservedRegsFrozen() ? MRI->getReservedRegs() 576 : TRI->getReservedRegs(*MF); 577 578 if (!MF->empty()) 579 markReachable(&MF->front()); 580 581 // Build a set of the basic blocks in the function. 582 FunctionBlocks.clear(); 583 for (const auto &MBB : *MF) { 584 FunctionBlocks.insert(&MBB); 585 BBInfo &MInfo = MBBInfoMap[&MBB]; 586 587 MInfo.Preds.insert(MBB.pred_begin(), MBB.pred_end()); 588 if (MInfo.Preds.size() != MBB.pred_size()) 589 report("MBB has duplicate entries in its predecessor list.", &MBB); 590 591 MInfo.Succs.insert(MBB.succ_begin(), MBB.succ_end()); 592 if (MInfo.Succs.size() != MBB.succ_size()) 593 report("MBB has duplicate entries in its successor list.", &MBB); 594 } 595 596 // Check that the register use lists are sane. 597 MRI->verifyUseLists(); 598 599 if (!MF->empty()) 600 verifyStackFrame(); 601 } 602 603 // Does iterator point to a and b as the first two elements? 604 static bool matchPair(MachineBasicBlock::const_succ_iterator i, 605 const MachineBasicBlock *a, const MachineBasicBlock *b) { 606 if (*i == a) 607 return *++i == b; 608 if (*i == b) 609 return *++i == a; 610 return false; 611 } 612 613 void 614 MachineVerifier::visitMachineBasicBlockBefore(const MachineBasicBlock *MBB) { 615 FirstTerminator = nullptr; 616 FirstNonPHI = nullptr; 617 618 if (!MF->getProperties().hasProperty( 619 MachineFunctionProperties::Property::NoPHIs) && MRI->tracksLiveness()) { 620 // If this block has allocatable physical registers live-in, check that 621 // it is an entry block or landing pad. 622 for (const auto &LI : MBB->liveins()) { 623 if (isAllocatable(LI.PhysReg) && !MBB->isEHPad() && 624 MBB->getIterator() != MBB->getParent()->begin()) { 625 report("MBB has allocatable live-in, but isn't entry or landing-pad.", MBB); 626 report_context(LI.PhysReg); 627 } 628 } 629 } 630 631 // Count the number of landing pad successors. 632 SmallPtrSet<MachineBasicBlock*, 4> LandingPadSuccs; 633 for (MachineBasicBlock::const_succ_iterator I = MBB->succ_begin(), 634 E = MBB->succ_end(); I != E; ++I) { 635 if ((*I)->isEHPad()) 636 LandingPadSuccs.insert(*I); 637 if (!FunctionBlocks.count(*I)) 638 report("MBB has successor that isn't part of the function.", MBB); 639 if (!MBBInfoMap[*I].Preds.count(MBB)) { 640 report("Inconsistent CFG", MBB); 641 errs() << "MBB is not in the predecessor list of the successor " 642 << printMBBReference(*(*I)) << ".\n"; 643 } 644 } 645 646 // Check the predecessor list. 647 for (MachineBasicBlock::const_pred_iterator I = MBB->pred_begin(), 648 E = MBB->pred_end(); I != E; ++I) { 649 if (!FunctionBlocks.count(*I)) 650 report("MBB has predecessor that isn't part of the function.", MBB); 651 if (!MBBInfoMap[*I].Succs.count(MBB)) { 652 report("Inconsistent CFG", MBB); 653 errs() << "MBB is not in the successor list of the predecessor " 654 << printMBBReference(*(*I)) << ".\n"; 655 } 656 } 657 658 const MCAsmInfo *AsmInfo = TM->getMCAsmInfo(); 659 const BasicBlock *BB = MBB->getBasicBlock(); 660 const Function &F = MF->getFunction(); 661 if (LandingPadSuccs.size() > 1 && 662 !(AsmInfo && 663 AsmInfo->getExceptionHandlingType() == ExceptionHandling::SjLj && 664 BB && isa<SwitchInst>(BB->getTerminator())) && 665 !isScopedEHPersonality(classifyEHPersonality(F.getPersonalityFn()))) 666 report("MBB has more than one landing pad successor", MBB); 667 668 // Call AnalyzeBranch. If it succeeds, there several more conditions to check. 669 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 670 SmallVector<MachineOperand, 4> Cond; 671 if (!TII->analyzeBranch(*const_cast<MachineBasicBlock *>(MBB), TBB, FBB, 672 Cond)) { 673 // Ok, AnalyzeBranch thinks it knows what's going on with this block. Let's 674 // check whether its answers match up with reality. 675 if (!TBB && !FBB) { 676 // Block falls through to its successor. 677 MachineFunction::const_iterator MBBI = MBB->getIterator(); 678 ++MBBI; 679 if (MBBI == MF->end()) { 680 // It's possible that the block legitimately ends with a noreturn 681 // call or an unreachable, in which case it won't actually fall 682 // out the bottom of the function. 683 } else if (MBB->succ_size() == LandingPadSuccs.size()) { 684 // It's possible that the block legitimately ends with a noreturn 685 // call or an unreachable, in which case it won't actually fall 686 // out of the block. 687 } else if (MBB->succ_size() != 1+LandingPadSuccs.size()) { 688 report("MBB exits via unconditional fall-through but doesn't have " 689 "exactly one CFG successor!", MBB); 690 } else if (!MBB->isSuccessor(&*MBBI)) { 691 report("MBB exits via unconditional fall-through but its successor " 692 "differs from its CFG successor!", MBB); 693 } 694 if (!MBB->empty() && MBB->back().isBarrier() && 695 !TII->isPredicated(MBB->back())) { 696 report("MBB exits via unconditional fall-through but ends with a " 697 "barrier instruction!", MBB); 698 } 699 if (!Cond.empty()) { 700 report("MBB exits via unconditional fall-through but has a condition!", 701 MBB); 702 } 703 } else if (TBB && !FBB && Cond.empty()) { 704 // Block unconditionally branches somewhere. 705 // If the block has exactly one successor, that happens to be a 706 // landingpad, accept it as valid control flow. 707 if (MBB->succ_size() != 1+LandingPadSuccs.size() && 708 (MBB->succ_size() != 1 || LandingPadSuccs.size() != 1 || 709 *MBB->succ_begin() != *LandingPadSuccs.begin())) { 710 report("MBB exits via unconditional branch but doesn't have " 711 "exactly one CFG successor!", MBB); 712 } else if (!MBB->isSuccessor(TBB)) { 713 report("MBB exits via unconditional branch but the CFG " 714 "successor doesn't match the actual successor!", MBB); 715 } 716 if (MBB->empty()) { 717 report("MBB exits via unconditional branch but doesn't contain " 718 "any instructions!", MBB); 719 } else if (!MBB->back().isBarrier()) { 720 report("MBB exits via unconditional branch but doesn't end with a " 721 "barrier instruction!", MBB); 722 } else if (!MBB->back().isTerminator()) { 723 report("MBB exits via unconditional branch but the branch isn't a " 724 "terminator instruction!", MBB); 725 } 726 } else if (TBB && !FBB && !Cond.empty()) { 727 // Block conditionally branches somewhere, otherwise falls through. 728 MachineFunction::const_iterator MBBI = MBB->getIterator(); 729 ++MBBI; 730 if (MBBI == MF->end()) { 731 report("MBB conditionally falls through out of function!", MBB); 732 } else if (MBB->succ_size() == 1) { 733 // A conditional branch with only one successor is weird, but allowed. 734 if (&*MBBI != TBB) 735 report("MBB exits via conditional branch/fall-through but only has " 736 "one CFG successor!", MBB); 737 else if (TBB != *MBB->succ_begin()) 738 report("MBB exits via conditional branch/fall-through but the CFG " 739 "successor don't match the actual successor!", MBB); 740 } else if (MBB->succ_size() != 2) { 741 report("MBB exits via conditional branch/fall-through but doesn't have " 742 "exactly two CFG successors!", MBB); 743 } else if (!matchPair(MBB->succ_begin(), TBB, &*MBBI)) { 744 report("MBB exits via conditional branch/fall-through but the CFG " 745 "successors don't match the actual successors!", MBB); 746 } 747 if (MBB->empty()) { 748 report("MBB exits via conditional branch/fall-through but doesn't " 749 "contain any instructions!", MBB); 750 } else if (MBB->back().isBarrier()) { 751 report("MBB exits via conditional branch/fall-through but ends with a " 752 "barrier instruction!", MBB); 753 } else if (!MBB->back().isTerminator()) { 754 report("MBB exits via conditional branch/fall-through but the branch " 755 "isn't a terminator instruction!", MBB); 756 } 757 } else if (TBB && FBB) { 758 // Block conditionally branches somewhere, otherwise branches 759 // somewhere else. 760 if (MBB->succ_size() == 1) { 761 // A conditional branch with only one successor is weird, but allowed. 762 if (FBB != TBB) 763 report("MBB exits via conditional branch/branch through but only has " 764 "one CFG successor!", MBB); 765 else if (TBB != *MBB->succ_begin()) 766 report("MBB exits via conditional branch/branch through but the CFG " 767 "successor don't match the actual successor!", MBB); 768 } else if (MBB->succ_size() != 2) { 769 report("MBB exits via conditional branch/branch but doesn't have " 770 "exactly two CFG successors!", MBB); 771 } else if (!matchPair(MBB->succ_begin(), TBB, FBB)) { 772 report("MBB exits via conditional branch/branch but the CFG " 773 "successors don't match the actual successors!", MBB); 774 } 775 if (MBB->empty()) { 776 report("MBB exits via conditional branch/branch but doesn't " 777 "contain any instructions!", MBB); 778 } else if (!MBB->back().isBarrier()) { 779 report("MBB exits via conditional branch/branch but doesn't end with a " 780 "barrier instruction!", MBB); 781 } else if (!MBB->back().isTerminator()) { 782 report("MBB exits via conditional branch/branch but the branch " 783 "isn't a terminator instruction!", MBB); 784 } 785 if (Cond.empty()) { 786 report("MBB exits via conditional branch/branch but there's no " 787 "condition!", MBB); 788 } 789 } else { 790 report("AnalyzeBranch returned invalid data!", MBB); 791 } 792 } 793 794 regsLive.clear(); 795 if (MRI->tracksLiveness()) { 796 for (const auto &LI : MBB->liveins()) { 797 if (!TargetRegisterInfo::isPhysicalRegister(LI.PhysReg)) { 798 report("MBB live-in list contains non-physical register", MBB); 799 continue; 800 } 801 for (MCSubRegIterator SubRegs(LI.PhysReg, TRI, /*IncludeSelf=*/true); 802 SubRegs.isValid(); ++SubRegs) 803 regsLive.insert(*SubRegs); 804 } 805 } 806 807 const MachineFrameInfo &MFI = MF->getFrameInfo(); 808 BitVector PR = MFI.getPristineRegs(*MF); 809 for (unsigned I : PR.set_bits()) { 810 for (MCSubRegIterator SubRegs(I, TRI, /*IncludeSelf=*/true); 811 SubRegs.isValid(); ++SubRegs) 812 regsLive.insert(*SubRegs); 813 } 814 815 regsKilled.clear(); 816 regsDefined.clear(); 817 818 if (Indexes) 819 lastIndex = Indexes->getMBBStartIdx(MBB); 820 } 821 822 // This function gets called for all bundle headers, including normal 823 // stand-alone unbundled instructions. 824 void MachineVerifier::visitMachineBundleBefore(const MachineInstr *MI) { 825 if (Indexes && Indexes->hasIndex(*MI)) { 826 SlotIndex idx = Indexes->getInstructionIndex(*MI); 827 if (!(idx > lastIndex)) { 828 report("Instruction index out of order", MI); 829 errs() << "Last instruction was at " << lastIndex << '\n'; 830 } 831 lastIndex = idx; 832 } 833 834 // Ensure non-terminators don't follow terminators. 835 // Ignore predicated terminators formed by if conversion. 836 // FIXME: If conversion shouldn't need to violate this rule. 837 if (MI->isTerminator() && !TII->isPredicated(*MI)) { 838 if (!FirstTerminator) 839 FirstTerminator = MI; 840 } else if (FirstTerminator) { 841 report("Non-terminator instruction after the first terminator", MI); 842 errs() << "First terminator was:\t" << *FirstTerminator; 843 } 844 } 845 846 // The operands on an INLINEASM instruction must follow a template. 847 // Verify that the flag operands make sense. 848 void MachineVerifier::verifyInlineAsm(const MachineInstr *MI) { 849 // The first two operands on INLINEASM are the asm string and global flags. 850 if (MI->getNumOperands() < 2) { 851 report("Too few operands on inline asm", MI); 852 return; 853 } 854 if (!MI->getOperand(0).isSymbol()) 855 report("Asm string must be an external symbol", MI); 856 if (!MI->getOperand(1).isImm()) 857 report("Asm flags must be an immediate", MI); 858 // Allowed flags are Extra_HasSideEffects = 1, Extra_IsAlignStack = 2, 859 // Extra_AsmDialect = 4, Extra_MayLoad = 8, and Extra_MayStore = 16, 860 // and Extra_IsConvergent = 32. 861 if (!isUInt<6>(MI->getOperand(1).getImm())) 862 report("Unknown asm flags", &MI->getOperand(1), 1); 863 864 static_assert(InlineAsm::MIOp_FirstOperand == 2, "Asm format changed"); 865 866 unsigned OpNo = InlineAsm::MIOp_FirstOperand; 867 unsigned NumOps; 868 for (unsigned e = MI->getNumOperands(); OpNo < e; OpNo += NumOps) { 869 const MachineOperand &MO = MI->getOperand(OpNo); 870 // There may be implicit ops after the fixed operands. 871 if (!MO.isImm()) 872 break; 873 NumOps = 1 + InlineAsm::getNumOperandRegisters(MO.getImm()); 874 } 875 876 if (OpNo > MI->getNumOperands()) 877 report("Missing operands in last group", MI); 878 879 // An optional MDNode follows the groups. 880 if (OpNo < MI->getNumOperands() && MI->getOperand(OpNo).isMetadata()) 881 ++OpNo; 882 883 // All trailing operands must be implicit registers. 884 for (unsigned e = MI->getNumOperands(); OpNo < e; ++OpNo) { 885 const MachineOperand &MO = MI->getOperand(OpNo); 886 if (!MO.isReg() || !MO.isImplicit()) 887 report("Expected implicit register after groups", &MO, OpNo); 888 } 889 } 890 891 void MachineVerifier::visitMachineInstrBefore(const MachineInstr *MI) { 892 const MCInstrDesc &MCID = MI->getDesc(); 893 if (MI->getNumOperands() < MCID.getNumOperands()) { 894 report("Too few operands", MI); 895 errs() << MCID.getNumOperands() << " operands expected, but " 896 << MI->getNumOperands() << " given.\n"; 897 } 898 899 if (MI->isPHI()) { 900 if (MF->getProperties().hasProperty( 901 MachineFunctionProperties::Property::NoPHIs)) 902 report("Found PHI instruction with NoPHIs property set", MI); 903 904 if (FirstNonPHI) 905 report("Found PHI instruction after non-PHI", MI); 906 } else if (FirstNonPHI == nullptr) 907 FirstNonPHI = MI; 908 909 // Check the tied operands. 910 if (MI->isInlineAsm()) 911 verifyInlineAsm(MI); 912 913 // Check the MachineMemOperands for basic consistency. 914 for (MachineInstr::mmo_iterator I = MI->memoperands_begin(), 915 E = MI->memoperands_end(); 916 I != E; ++I) { 917 if ((*I)->isLoad() && !MI->mayLoad()) 918 report("Missing mayLoad flag", MI); 919 if ((*I)->isStore() && !MI->mayStore()) 920 report("Missing mayStore flag", MI); 921 } 922 923 // Debug values must not have a slot index. 924 // Other instructions must have one, unless they are inside a bundle. 925 if (LiveInts) { 926 bool mapped = !LiveInts->isNotInMIMap(*MI); 927 if (MI->isDebugInstr()) { 928 if (mapped) 929 report("Debug instruction has a slot index", MI); 930 } else if (MI->isInsideBundle()) { 931 if (mapped) 932 report("Instruction inside bundle has a slot index", MI); 933 } else { 934 if (!mapped) 935 report("Missing slot index", MI); 936 } 937 } 938 939 if (isPreISelGenericOpcode(MCID.getOpcode())) { 940 if (isFunctionSelected) 941 report("Unexpected generic instruction in a Selected function", MI); 942 943 unsigned NumOps = MI->getNumOperands(); 944 945 // Check types. 946 SmallVector<LLT, 4> Types; 947 for (unsigned I = 0, E = std::min(MCID.getNumOperands(), NumOps); 948 I != E; ++I) { 949 if (!MCID.OpInfo[I].isGenericType()) 950 continue; 951 // Generic instructions specify type equality constraints between some of 952 // their operands. Make sure these are consistent. 953 size_t TypeIdx = MCID.OpInfo[I].getGenericTypeIndex(); 954 Types.resize(std::max(TypeIdx + 1, Types.size())); 955 956 const MachineOperand *MO = &MI->getOperand(I); 957 LLT OpTy = MRI->getType(MO->getReg()); 958 // Don't report a type mismatch if there is no actual mismatch, only a 959 // type missing, to reduce noise: 960 if (OpTy.isValid()) { 961 // Only the first valid type for a type index will be printed: don't 962 // overwrite it later so it's always clear which type was expected: 963 if (!Types[TypeIdx].isValid()) 964 Types[TypeIdx] = OpTy; 965 else if (Types[TypeIdx] != OpTy) 966 report("Type mismatch in generic instruction", MO, I, OpTy); 967 } else { 968 // Generic instructions must have types attached to their operands. 969 report("Generic instruction is missing a virtual register type", MO, I); 970 } 971 } 972 973 // Generic opcodes must not have physical register operands. 974 for (unsigned I = 0; I < MI->getNumOperands(); ++I) { 975 const MachineOperand *MO = &MI->getOperand(I); 976 if (MO->isReg() && TargetRegisterInfo::isPhysicalRegister(MO->getReg())) 977 report("Generic instruction cannot have physical register", MO, I); 978 } 979 980 // Avoid out of bounds in checks below. This was already reported earlier. 981 if (MI->getNumOperands() < MCID.getNumOperands()) 982 return; 983 } 984 985 StringRef ErrorInfo; 986 if (!TII->verifyInstruction(*MI, ErrorInfo)) 987 report(ErrorInfo.data(), MI); 988 989 // Verify properties of various specific instruction types 990 switch(MI->getOpcode()) { 991 default: 992 break; 993 case TargetOpcode::G_CONSTANT: 994 case TargetOpcode::G_FCONSTANT: { 995 if (MI->getNumOperands() < MCID.getNumOperands()) 996 break; 997 998 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 999 if (DstTy.isVector()) 1000 report("Instruction cannot use a vector result type", MI); 1001 break; 1002 } 1003 case TargetOpcode::G_LOAD: 1004 case TargetOpcode::G_STORE: 1005 case TargetOpcode::G_ZEXTLOAD: 1006 case TargetOpcode::G_SEXTLOAD: { 1007 LLT PtrTy = MRI->getType(MI->getOperand(1).getReg()); 1008 if (!PtrTy.isPointer()) 1009 report("Generic memory instruction must access a pointer", MI); 1010 1011 // Generic loads and stores must have a single MachineMemOperand 1012 // describing that access. 1013 if (!MI->hasOneMemOperand()) { 1014 report("Generic instruction accessing memory must have one mem operand", 1015 MI); 1016 } else { 1017 if (MI->getOpcode() == TargetOpcode::G_ZEXTLOAD || 1018 MI->getOpcode() == TargetOpcode::G_SEXTLOAD) { 1019 const MachineMemOperand &MMO = **MI->memoperands_begin(); 1020 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1021 if (MMO.getSize() * 8 >= DstTy.getSizeInBits()) { 1022 report("Generic extload must have a narrower memory type", MI); 1023 } 1024 } 1025 } 1026 1027 break; 1028 } 1029 case TargetOpcode::G_PHI: { 1030 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1031 if (!DstTy.isValid() || 1032 !std::all_of(MI->operands_begin() + 1, MI->operands_end(), 1033 [this, &DstTy](const MachineOperand &MO) { 1034 if (!MO.isReg()) 1035 return true; 1036 LLT Ty = MRI->getType(MO.getReg()); 1037 if (!Ty.isValid() || (Ty != DstTy)) 1038 return false; 1039 return true; 1040 })) 1041 report("Generic Instruction G_PHI has operands with incompatible/missing " 1042 "types", 1043 MI); 1044 break; 1045 } 1046 case TargetOpcode::G_BITCAST: { 1047 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1048 LLT SrcTy = MRI->getType(MI->getOperand(1).getReg()); 1049 if (!DstTy.isValid() || !SrcTy.isValid()) 1050 break; 1051 1052 if (SrcTy.isPointer() != DstTy.isPointer()) 1053 report("bitcast cannot convert between pointers and other types", MI); 1054 1055 if (SrcTy.getSizeInBits() != DstTy.getSizeInBits()) 1056 report("bitcast sizes must match", MI); 1057 break; 1058 } 1059 case TargetOpcode::G_SEXT: 1060 case TargetOpcode::G_ZEXT: 1061 case TargetOpcode::G_ANYEXT: 1062 case TargetOpcode::G_TRUNC: 1063 case TargetOpcode::G_FPEXT: 1064 case TargetOpcode::G_FPTRUNC: { 1065 // Number of operands and presense of types is already checked (and 1066 // reported in case of any issues), so no need to report them again. As 1067 // we're trying to report as many issues as possible at once, however, the 1068 // instructions aren't guaranteed to have the right number of operands or 1069 // types attached to them at this point 1070 assert(MCID.getNumOperands() == 2 && "Expected 2 operands G_*{EXT,TRUNC}"); 1071 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1072 LLT SrcTy = MRI->getType(MI->getOperand(1).getReg()); 1073 if (!DstTy.isValid() || !SrcTy.isValid()) 1074 break; 1075 1076 LLT DstElTy = DstTy.isVector() ? DstTy.getElementType() : DstTy; 1077 LLT SrcElTy = SrcTy.isVector() ? SrcTy.getElementType() : SrcTy; 1078 if (DstElTy.isPointer() || SrcElTy.isPointer()) 1079 report("Generic extend/truncate can not operate on pointers", MI); 1080 1081 if (DstTy.isVector() != SrcTy.isVector()) { 1082 report("Generic extend/truncate must be all-vector or all-scalar", MI); 1083 // Generally we try to report as many issues as possible at once, but in 1084 // this case it's not clear what should we be comparing the size of the 1085 // scalar with: the size of the whole vector or its lane. Instead of 1086 // making an arbitrary choice and emitting not so helpful message, let's 1087 // avoid the extra noise and stop here. 1088 break; 1089 } 1090 if (DstTy.isVector() && DstTy.getNumElements() != SrcTy.getNumElements()) 1091 report("Generic vector extend/truncate must preserve number of lanes", 1092 MI); 1093 unsigned DstSize = DstElTy.getSizeInBits(); 1094 unsigned SrcSize = SrcElTy.getSizeInBits(); 1095 switch (MI->getOpcode()) { 1096 default: 1097 if (DstSize <= SrcSize) 1098 report("Generic extend has destination type no larger than source", MI); 1099 break; 1100 case TargetOpcode::G_TRUNC: 1101 case TargetOpcode::G_FPTRUNC: 1102 if (DstSize >= SrcSize) 1103 report("Generic truncate has destination type no smaller than source", 1104 MI); 1105 break; 1106 } 1107 break; 1108 } 1109 case TargetOpcode::G_MERGE_VALUES: { 1110 // G_MERGE_VALUES should only be used to merge scalars into a larger scalar, 1111 // e.g. s2N = MERGE sN, sN 1112 // Merging multiple scalars into a vector is not allowed, should use 1113 // G_BUILD_VECTOR for that. 1114 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1115 LLT SrcTy = MRI->getType(MI->getOperand(1).getReg()); 1116 if (DstTy.isVector() || SrcTy.isVector()) 1117 report("G_MERGE_VALUES cannot operate on vectors", MI); 1118 break; 1119 } 1120 case TargetOpcode::G_UNMERGE_VALUES: { 1121 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1122 LLT SrcTy = MRI->getType(MI->getOperand(MI->getNumOperands()-1).getReg()); 1123 // For now G_UNMERGE can split vectors. 1124 for (unsigned i = 0; i < MI->getNumOperands()-1; ++i) { 1125 if (MRI->getType(MI->getOperand(i).getReg()) != DstTy) 1126 report("G_UNMERGE_VALUES destination types do not match", MI); 1127 } 1128 if (SrcTy.getSizeInBits() != 1129 (DstTy.getSizeInBits() * (MI->getNumOperands() - 1))) { 1130 report("G_UNMERGE_VALUES source operand does not cover dest operands", 1131 MI); 1132 } 1133 break; 1134 } 1135 case TargetOpcode::G_BUILD_VECTOR: { 1136 // Source types must be scalars, dest type a vector. Total size of scalars 1137 // must match the dest vector size. 1138 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1139 LLT SrcEltTy = MRI->getType(MI->getOperand(1).getReg()); 1140 if (!DstTy.isVector() || SrcEltTy.isVector()) 1141 report("G_BUILD_VECTOR must produce a vector from scalar operands", MI); 1142 for (unsigned i = 2; i < MI->getNumOperands(); ++i) { 1143 if (MRI->getType(MI->getOperand(1).getReg()) != 1144 MRI->getType(MI->getOperand(i).getReg())) 1145 report("G_BUILD_VECTOR source operand types are not homogeneous", MI); 1146 } 1147 if (DstTy.getSizeInBits() != 1148 SrcEltTy.getSizeInBits() * (MI->getNumOperands() - 1)) 1149 report("G_BUILD_VECTOR src operands total size don't match dest " 1150 "size.", 1151 MI); 1152 break; 1153 } 1154 case TargetOpcode::G_BUILD_VECTOR_TRUNC: { 1155 // Source types must be scalars, dest type a vector. Scalar types must be 1156 // larger than the dest vector elt type, as this is a truncating operation. 1157 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1158 LLT SrcEltTy = MRI->getType(MI->getOperand(1).getReg()); 1159 if (!DstTy.isVector() || SrcEltTy.isVector()) 1160 report("G_BUILD_VECTOR_TRUNC must produce a vector from scalar operands", 1161 MI); 1162 for (unsigned i = 2; i < MI->getNumOperands(); ++i) { 1163 if (MRI->getType(MI->getOperand(1).getReg()) != 1164 MRI->getType(MI->getOperand(i).getReg())) 1165 report("G_BUILD_VECTOR_TRUNC source operand types are not homogeneous", 1166 MI); 1167 } 1168 if (SrcEltTy.getSizeInBits() <= DstTy.getElementType().getSizeInBits()) 1169 report("G_BUILD_VECTOR_TRUNC source operand types are not larger than " 1170 "dest elt type", 1171 MI); 1172 break; 1173 } 1174 case TargetOpcode::G_CONCAT_VECTORS: { 1175 // Source types should be vectors, and total size should match the dest 1176 // vector size. 1177 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1178 LLT SrcTy = MRI->getType(MI->getOperand(1).getReg()); 1179 if (!DstTy.isVector() || !SrcTy.isVector()) 1180 report("G_CONCAT_VECTOR requires vector source and destination operands", 1181 MI); 1182 for (unsigned i = 2; i < MI->getNumOperands(); ++i) { 1183 if (MRI->getType(MI->getOperand(1).getReg()) != 1184 MRI->getType(MI->getOperand(i).getReg())) 1185 report("G_CONCAT_VECTOR source operand types are not homogeneous", MI); 1186 } 1187 if (DstTy.getNumElements() != 1188 SrcTy.getNumElements() * (MI->getNumOperands() - 1)) 1189 report("G_CONCAT_VECTOR num dest and source elements should match", MI); 1190 break; 1191 } 1192 case TargetOpcode::COPY: { 1193 if (foundErrors) 1194 break; 1195 const MachineOperand &DstOp = MI->getOperand(0); 1196 const MachineOperand &SrcOp = MI->getOperand(1); 1197 LLT DstTy = MRI->getType(DstOp.getReg()); 1198 LLT SrcTy = MRI->getType(SrcOp.getReg()); 1199 if (SrcTy.isValid() && DstTy.isValid()) { 1200 // If both types are valid, check that the types are the same. 1201 if (SrcTy != DstTy) { 1202 report("Copy Instruction is illegal with mismatching types", MI); 1203 errs() << "Def = " << DstTy << ", Src = " << SrcTy << "\n"; 1204 } 1205 } 1206 if (SrcTy.isValid() || DstTy.isValid()) { 1207 // If one of them have valid types, let's just check they have the same 1208 // size. 1209 unsigned SrcSize = TRI->getRegSizeInBits(SrcOp.getReg(), *MRI); 1210 unsigned DstSize = TRI->getRegSizeInBits(DstOp.getReg(), *MRI); 1211 assert(SrcSize && "Expecting size here"); 1212 assert(DstSize && "Expecting size here"); 1213 if (SrcSize != DstSize) 1214 if (!DstOp.getSubReg() && !SrcOp.getSubReg()) { 1215 report("Copy Instruction is illegal with mismatching sizes", MI); 1216 errs() << "Def Size = " << DstSize << ", Src Size = " << SrcSize 1217 << "\n"; 1218 } 1219 } 1220 break; 1221 } 1222 case TargetOpcode::G_ICMP: 1223 case TargetOpcode::G_FCMP: { 1224 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 1225 LLT SrcTy = MRI->getType(MI->getOperand(2).getReg()); 1226 1227 if ((DstTy.isVector() != SrcTy.isVector()) || 1228 (DstTy.isVector() && DstTy.getNumElements() != SrcTy.getNumElements())) 1229 report("Generic vector icmp/fcmp must preserve number of lanes", MI); 1230 1231 break; 1232 } 1233 case TargetOpcode::STATEPOINT: 1234 if (!MI->getOperand(StatepointOpers::IDPos).isImm() || 1235 !MI->getOperand(StatepointOpers::NBytesPos).isImm() || 1236 !MI->getOperand(StatepointOpers::NCallArgsPos).isImm()) 1237 report("meta operands to STATEPOINT not constant!", MI); 1238 break; 1239 1240 auto VerifyStackMapConstant = [&](unsigned Offset) { 1241 if (!MI->getOperand(Offset).isImm() || 1242 MI->getOperand(Offset).getImm() != StackMaps::ConstantOp || 1243 !MI->getOperand(Offset + 1).isImm()) 1244 report("stack map constant to STATEPOINT not well formed!", MI); 1245 }; 1246 const unsigned VarStart = StatepointOpers(MI).getVarIdx(); 1247 VerifyStackMapConstant(VarStart + StatepointOpers::CCOffset); 1248 VerifyStackMapConstant(VarStart + StatepointOpers::FlagsOffset); 1249 VerifyStackMapConstant(VarStart + StatepointOpers::NumDeoptOperandsOffset); 1250 1251 // TODO: verify we have properly encoded deopt arguments 1252 }; 1253 } 1254 1255 void 1256 MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) { 1257 const MachineInstr *MI = MO->getParent(); 1258 const MCInstrDesc &MCID = MI->getDesc(); 1259 unsigned NumDefs = MCID.getNumDefs(); 1260 if (MCID.getOpcode() == TargetOpcode::PATCHPOINT) 1261 NumDefs = (MONum == 0 && MO->isReg()) ? NumDefs : 0; 1262 1263 // The first MCID.NumDefs operands must be explicit register defines 1264 if (MONum < NumDefs) { 1265 const MCOperandInfo &MCOI = MCID.OpInfo[MONum]; 1266 if (!MO->isReg()) 1267 report("Explicit definition must be a register", MO, MONum); 1268 else if (!MO->isDef() && !MCOI.isOptionalDef()) 1269 report("Explicit definition marked as use", MO, MONum); 1270 else if (MO->isImplicit()) 1271 report("Explicit definition marked as implicit", MO, MONum); 1272 } else if (MONum < MCID.getNumOperands()) { 1273 const MCOperandInfo &MCOI = MCID.OpInfo[MONum]; 1274 // Don't check if it's the last operand in a variadic instruction. See, 1275 // e.g., LDM_RET in the arm back end. 1276 if (MO->isReg() && 1277 !(MI->isVariadic() && MONum == MCID.getNumOperands()-1)) { 1278 if (MO->isDef() && !MCOI.isOptionalDef()) 1279 report("Explicit operand marked as def", MO, MONum); 1280 if (MO->isImplicit()) 1281 report("Explicit operand marked as implicit", MO, MONum); 1282 } 1283 1284 int TiedTo = MCID.getOperandConstraint(MONum, MCOI::TIED_TO); 1285 if (TiedTo != -1) { 1286 if (!MO->isReg()) 1287 report("Tied use must be a register", MO, MONum); 1288 else if (!MO->isTied()) 1289 report("Operand should be tied", MO, MONum); 1290 else if (unsigned(TiedTo) != MI->findTiedOperandIdx(MONum)) 1291 report("Tied def doesn't match MCInstrDesc", MO, MONum); 1292 else if (TargetRegisterInfo::isPhysicalRegister(MO->getReg())) { 1293 const MachineOperand &MOTied = MI->getOperand(TiedTo); 1294 if (!MOTied.isReg()) 1295 report("Tied counterpart must be a register", &MOTied, TiedTo); 1296 else if (TargetRegisterInfo::isPhysicalRegister(MOTied.getReg()) && 1297 MO->getReg() != MOTied.getReg()) 1298 report("Tied physical registers must match.", &MOTied, TiedTo); 1299 } 1300 } else if (MO->isReg() && MO->isTied()) 1301 report("Explicit operand should not be tied", MO, MONum); 1302 } else { 1303 // ARM adds %reg0 operands to indicate predicates. We'll allow that. 1304 if (MO->isReg() && !MO->isImplicit() && !MI->isVariadic() && MO->getReg()) 1305 report("Extra explicit operand on non-variadic instruction", MO, MONum); 1306 } 1307 1308 switch (MO->getType()) { 1309 case MachineOperand::MO_Register: { 1310 const unsigned Reg = MO->getReg(); 1311 if (!Reg) 1312 return; 1313 if (MRI->tracksLiveness() && !MI->isDebugValue()) 1314 checkLiveness(MO, MONum); 1315 1316 // Verify the consistency of tied operands. 1317 if (MO->isTied()) { 1318 unsigned OtherIdx = MI->findTiedOperandIdx(MONum); 1319 const MachineOperand &OtherMO = MI->getOperand(OtherIdx); 1320 if (!OtherMO.isReg()) 1321 report("Must be tied to a register", MO, MONum); 1322 if (!OtherMO.isTied()) 1323 report("Missing tie flags on tied operand", MO, MONum); 1324 if (MI->findTiedOperandIdx(OtherIdx) != MONum) 1325 report("Inconsistent tie links", MO, MONum); 1326 if (MONum < MCID.getNumDefs()) { 1327 if (OtherIdx < MCID.getNumOperands()) { 1328 if (-1 == MCID.getOperandConstraint(OtherIdx, MCOI::TIED_TO)) 1329 report("Explicit def tied to explicit use without tie constraint", 1330 MO, MONum); 1331 } else { 1332 if (!OtherMO.isImplicit()) 1333 report("Explicit def should be tied to implicit use", MO, MONum); 1334 } 1335 } 1336 } 1337 1338 // Verify two-address constraints after leaving SSA form. 1339 unsigned DefIdx; 1340 if (!MRI->isSSA() && MO->isUse() && 1341 MI->isRegTiedToDefOperand(MONum, &DefIdx) && 1342 Reg != MI->getOperand(DefIdx).getReg()) 1343 report("Two-address instruction operands must be identical", MO, MONum); 1344 1345 // Check register classes. 1346 unsigned SubIdx = MO->getSubReg(); 1347 1348 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1349 if (SubIdx) { 1350 report("Illegal subregister index for physical register", MO, MONum); 1351 return; 1352 } 1353 if (MONum < MCID.getNumOperands()) { 1354 if (const TargetRegisterClass *DRC = 1355 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1356 if (!DRC->contains(Reg)) { 1357 report("Illegal physical register for instruction", MO, MONum); 1358 errs() << printReg(Reg, TRI) << " is not a " 1359 << TRI->getRegClassName(DRC) << " register.\n"; 1360 } 1361 } 1362 } 1363 if (MO->isRenamable()) { 1364 if (MRI->isReserved(Reg)) { 1365 report("isRenamable set on reserved register", MO, MONum); 1366 return; 1367 } 1368 } 1369 if (MI->isDebugValue() && MO->isUse() && !MO->isDebug()) { 1370 report("Use-reg is not IsDebug in a DBG_VALUE", MO, MONum); 1371 return; 1372 } 1373 } else { 1374 // Virtual register. 1375 const TargetRegisterClass *RC = MRI->getRegClassOrNull(Reg); 1376 if (!RC) { 1377 // This is a generic virtual register. 1378 1379 // If we're post-Select, we can't have gvregs anymore. 1380 if (isFunctionSelected) { 1381 report("Generic virtual register invalid in a Selected function", 1382 MO, MONum); 1383 return; 1384 } 1385 1386 // The gvreg must have a type and it must not have a SubIdx. 1387 LLT Ty = MRI->getType(Reg); 1388 if (!Ty.isValid()) { 1389 report("Generic virtual register must have a valid type", MO, 1390 MONum); 1391 return; 1392 } 1393 1394 const RegisterBank *RegBank = MRI->getRegBankOrNull(Reg); 1395 1396 // If we're post-RegBankSelect, the gvreg must have a bank. 1397 if (!RegBank && isFunctionRegBankSelected) { 1398 report("Generic virtual register must have a bank in a " 1399 "RegBankSelected function", 1400 MO, MONum); 1401 return; 1402 } 1403 1404 // Make sure the register fits into its register bank if any. 1405 if (RegBank && Ty.isValid() && 1406 RegBank->getSize() < Ty.getSizeInBits()) { 1407 report("Register bank is too small for virtual register", MO, 1408 MONum); 1409 errs() << "Register bank " << RegBank->getName() << " too small(" 1410 << RegBank->getSize() << ") to fit " << Ty.getSizeInBits() 1411 << "-bits\n"; 1412 return; 1413 } 1414 if (SubIdx) { 1415 report("Generic virtual register does not subregister index", MO, 1416 MONum); 1417 return; 1418 } 1419 1420 // If this is a target specific instruction and this operand 1421 // has register class constraint, the virtual register must 1422 // comply to it. 1423 if (!isPreISelGenericOpcode(MCID.getOpcode()) && 1424 MONum < MCID.getNumOperands() && 1425 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1426 report("Virtual register does not match instruction constraint", MO, 1427 MONum); 1428 errs() << "Expect register class " 1429 << TRI->getRegClassName( 1430 TII->getRegClass(MCID, MONum, TRI, *MF)) 1431 << " but got nothing\n"; 1432 return; 1433 } 1434 1435 break; 1436 } 1437 if (SubIdx) { 1438 const TargetRegisterClass *SRC = 1439 TRI->getSubClassWithSubReg(RC, SubIdx); 1440 if (!SRC) { 1441 report("Invalid subregister index for virtual register", MO, MONum); 1442 errs() << "Register class " << TRI->getRegClassName(RC) 1443 << " does not support subreg index " << SubIdx << "\n"; 1444 return; 1445 } 1446 if (RC != SRC) { 1447 report("Invalid register class for subregister index", MO, MONum); 1448 errs() << "Register class " << TRI->getRegClassName(RC) 1449 << " does not fully support subreg index " << SubIdx << "\n"; 1450 return; 1451 } 1452 } 1453 if (MONum < MCID.getNumOperands()) { 1454 if (const TargetRegisterClass *DRC = 1455 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1456 if (SubIdx) { 1457 const TargetRegisterClass *SuperRC = 1458 TRI->getLargestLegalSuperClass(RC, *MF); 1459 if (!SuperRC) { 1460 report("No largest legal super class exists.", MO, MONum); 1461 return; 1462 } 1463 DRC = TRI->getMatchingSuperRegClass(SuperRC, DRC, SubIdx); 1464 if (!DRC) { 1465 report("No matching super-reg register class.", MO, MONum); 1466 return; 1467 } 1468 } 1469 if (!RC->hasSuperClassEq(DRC)) { 1470 report("Illegal virtual register for instruction", MO, MONum); 1471 errs() << "Expected a " << TRI->getRegClassName(DRC) 1472 << " register, but got a " << TRI->getRegClassName(RC) 1473 << " register\n"; 1474 } 1475 } 1476 } 1477 } 1478 break; 1479 } 1480 1481 case MachineOperand::MO_RegisterMask: 1482 regMasks.push_back(MO->getRegMask()); 1483 break; 1484 1485 case MachineOperand::MO_MachineBasicBlock: 1486 if (MI->isPHI() && !MO->getMBB()->isSuccessor(MI->getParent())) 1487 report("PHI operand is not in the CFG", MO, MONum); 1488 break; 1489 1490 case MachineOperand::MO_FrameIndex: 1491 if (LiveStks && LiveStks->hasInterval(MO->getIndex()) && 1492 LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1493 int FI = MO->getIndex(); 1494 LiveInterval &LI = LiveStks->getInterval(FI); 1495 SlotIndex Idx = LiveInts->getInstructionIndex(*MI); 1496 1497 bool stores = MI->mayStore(); 1498 bool loads = MI->mayLoad(); 1499 // For a memory-to-memory move, we need to check if the frame 1500 // index is used for storing or loading, by inspecting the 1501 // memory operands. 1502 if (stores && loads) { 1503 for (auto *MMO : MI->memoperands()) { 1504 const PseudoSourceValue *PSV = MMO->getPseudoValue(); 1505 if (PSV == nullptr) continue; 1506 const FixedStackPseudoSourceValue *Value = 1507 dyn_cast<FixedStackPseudoSourceValue>(PSV); 1508 if (Value == nullptr) continue; 1509 if (Value->getFrameIndex() != FI) continue; 1510 1511 if (MMO->isStore()) 1512 loads = false; 1513 else 1514 stores = false; 1515 break; 1516 } 1517 if (loads == stores) 1518 report("Missing fixed stack memoperand.", MI); 1519 } 1520 if (loads && !LI.liveAt(Idx.getRegSlot(true))) { 1521 report("Instruction loads from dead spill slot", MO, MONum); 1522 errs() << "Live stack: " << LI << '\n'; 1523 } 1524 if (stores && !LI.liveAt(Idx.getRegSlot())) { 1525 report("Instruction stores to dead spill slot", MO, MONum); 1526 errs() << "Live stack: " << LI << '\n'; 1527 } 1528 } 1529 break; 1530 1531 default: 1532 break; 1533 } 1534 } 1535 1536 void MachineVerifier::checkLivenessAtUse(const MachineOperand *MO, 1537 unsigned MONum, SlotIndex UseIdx, const LiveRange &LR, unsigned VRegOrUnit, 1538 LaneBitmask LaneMask) { 1539 LiveQueryResult LRQ = LR.Query(UseIdx); 1540 // Check if we have a segment at the use, note however that we only need one 1541 // live subregister range, the others may be dead. 1542 if (!LRQ.valueIn() && LaneMask.none()) { 1543 report("No live segment at use", MO, MONum); 1544 report_context_liverange(LR); 1545 report_context_vreg_regunit(VRegOrUnit); 1546 report_context(UseIdx); 1547 } 1548 if (MO->isKill() && !LRQ.isKill()) { 1549 report("Live range continues after kill flag", MO, MONum); 1550 report_context_liverange(LR); 1551 report_context_vreg_regunit(VRegOrUnit); 1552 if (LaneMask.any()) 1553 report_context_lanemask(LaneMask); 1554 report_context(UseIdx); 1555 } 1556 } 1557 1558 void MachineVerifier::checkLivenessAtDef(const MachineOperand *MO, 1559 unsigned MONum, SlotIndex DefIdx, const LiveRange &LR, unsigned VRegOrUnit, 1560 bool SubRangeCheck, LaneBitmask LaneMask) { 1561 if (const VNInfo *VNI = LR.getVNInfoAt(DefIdx)) { 1562 assert(VNI && "NULL valno is not allowed"); 1563 if (VNI->def != DefIdx) { 1564 report("Inconsistent valno->def", MO, MONum); 1565 report_context_liverange(LR); 1566 report_context_vreg_regunit(VRegOrUnit); 1567 if (LaneMask.any()) 1568 report_context_lanemask(LaneMask); 1569 report_context(*VNI); 1570 report_context(DefIdx); 1571 } 1572 } else { 1573 report("No live segment at def", MO, MONum); 1574 report_context_liverange(LR); 1575 report_context_vreg_regunit(VRegOrUnit); 1576 if (LaneMask.any()) 1577 report_context_lanemask(LaneMask); 1578 report_context(DefIdx); 1579 } 1580 // Check that, if the dead def flag is present, LiveInts agree. 1581 if (MO->isDead()) { 1582 LiveQueryResult LRQ = LR.Query(DefIdx); 1583 if (!LRQ.isDeadDef()) { 1584 assert(TargetRegisterInfo::isVirtualRegister(VRegOrUnit) && 1585 "Expecting a virtual register."); 1586 // A dead subreg def only tells us that the specific subreg is dead. There 1587 // could be other non-dead defs of other subregs, or we could have other 1588 // parts of the register being live through the instruction. So unless we 1589 // are checking liveness for a subrange it is ok for the live range to 1590 // continue, given that we have a dead def of a subregister. 1591 if (SubRangeCheck || MO->getSubReg() == 0) { 1592 report("Live range continues after dead def flag", MO, MONum); 1593 report_context_liverange(LR); 1594 report_context_vreg_regunit(VRegOrUnit); 1595 if (LaneMask.any()) 1596 report_context_lanemask(LaneMask); 1597 } 1598 } 1599 } 1600 } 1601 1602 void MachineVerifier::checkLiveness(const MachineOperand *MO, unsigned MONum) { 1603 const MachineInstr *MI = MO->getParent(); 1604 const unsigned Reg = MO->getReg(); 1605 1606 // Both use and def operands can read a register. 1607 if (MO->readsReg()) { 1608 if (MO->isKill()) 1609 addRegWithSubRegs(regsKilled, Reg); 1610 1611 // Check that LiveVars knows this kill. 1612 if (LiveVars && TargetRegisterInfo::isVirtualRegister(Reg) && 1613 MO->isKill()) { 1614 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg); 1615 if (!is_contained(VI.Kills, MI)) 1616 report("Kill missing from LiveVariables", MO, MONum); 1617 } 1618 1619 // Check LiveInts liveness and kill. 1620 if (LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1621 SlotIndex UseIdx = LiveInts->getInstructionIndex(*MI); 1622 // Check the cached regunit intervals. 1623 if (TargetRegisterInfo::isPhysicalRegister(Reg) && !isReserved(Reg)) { 1624 for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units) { 1625 if (MRI->isReservedRegUnit(*Units)) 1626 continue; 1627 if (const LiveRange *LR = LiveInts->getCachedRegUnit(*Units)) 1628 checkLivenessAtUse(MO, MONum, UseIdx, *LR, *Units); 1629 } 1630 } 1631 1632 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1633 if (LiveInts->hasInterval(Reg)) { 1634 // This is a virtual register interval. 1635 const LiveInterval &LI = LiveInts->getInterval(Reg); 1636 checkLivenessAtUse(MO, MONum, UseIdx, LI, Reg); 1637 1638 if (LI.hasSubRanges() && !MO->isDef()) { 1639 unsigned SubRegIdx = MO->getSubReg(); 1640 LaneBitmask MOMask = SubRegIdx != 0 1641 ? TRI->getSubRegIndexLaneMask(SubRegIdx) 1642 : MRI->getMaxLaneMaskForVReg(Reg); 1643 LaneBitmask LiveInMask; 1644 for (const LiveInterval::SubRange &SR : LI.subranges()) { 1645 if ((MOMask & SR.LaneMask).none()) 1646 continue; 1647 checkLivenessAtUse(MO, MONum, UseIdx, SR, Reg, SR.LaneMask); 1648 LiveQueryResult LRQ = SR.Query(UseIdx); 1649 if (LRQ.valueIn()) 1650 LiveInMask |= SR.LaneMask; 1651 } 1652 // At least parts of the register has to be live at the use. 1653 if ((LiveInMask & MOMask).none()) { 1654 report("No live subrange at use", MO, MONum); 1655 report_context(LI); 1656 report_context(UseIdx); 1657 } 1658 } 1659 } else { 1660 report("Virtual register has no live interval", MO, MONum); 1661 } 1662 } 1663 } 1664 1665 // Use of a dead register. 1666 if (!regsLive.count(Reg)) { 1667 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1668 // Reserved registers may be used even when 'dead'. 1669 bool Bad = !isReserved(Reg); 1670 // We are fine if just any subregister has a defined value. 1671 if (Bad) { 1672 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); 1673 ++SubRegs) { 1674 if (regsLive.count(*SubRegs)) { 1675 Bad = false; 1676 break; 1677 } 1678 } 1679 } 1680 // If there is an additional implicit-use of a super register we stop 1681 // here. By definition we are fine if the super register is not 1682 // (completely) dead, if the complete super register is dead we will 1683 // get a report for its operand. 1684 if (Bad) { 1685 for (const MachineOperand &MOP : MI->uses()) { 1686 if (!MOP.isReg() || !MOP.isImplicit()) 1687 continue; 1688 1689 if (!TargetRegisterInfo::isPhysicalRegister(MOP.getReg())) 1690 continue; 1691 1692 for (MCSubRegIterator SubRegs(MOP.getReg(), TRI); SubRegs.isValid(); 1693 ++SubRegs) { 1694 if (*SubRegs == Reg) { 1695 Bad = false; 1696 break; 1697 } 1698 } 1699 } 1700 } 1701 if (Bad) 1702 report("Using an undefined physical register", MO, MONum); 1703 } else if (MRI->def_empty(Reg)) { 1704 report("Reading virtual register without a def", MO, MONum); 1705 } else { 1706 BBInfo &MInfo = MBBInfoMap[MI->getParent()]; 1707 // We don't know which virtual registers are live in, so only complain 1708 // if vreg was killed in this MBB. Otherwise keep track of vregs that 1709 // must be live in. PHI instructions are handled separately. 1710 if (MInfo.regsKilled.count(Reg)) 1711 report("Using a killed virtual register", MO, MONum); 1712 else if (!MI->isPHI()) 1713 MInfo.vregsLiveIn.insert(std::make_pair(Reg, MI)); 1714 } 1715 } 1716 } 1717 1718 if (MO->isDef()) { 1719 // Register defined. 1720 // TODO: verify that earlyclobber ops are not used. 1721 if (MO->isDead()) 1722 addRegWithSubRegs(regsDead, Reg); 1723 else 1724 addRegWithSubRegs(regsDefined, Reg); 1725 1726 // Verify SSA form. 1727 if (MRI->isSSA() && TargetRegisterInfo::isVirtualRegister(Reg) && 1728 std::next(MRI->def_begin(Reg)) != MRI->def_end()) 1729 report("Multiple virtual register defs in SSA form", MO, MONum); 1730 1731 // Check LiveInts for a live segment, but only for virtual registers. 1732 if (LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1733 SlotIndex DefIdx = LiveInts->getInstructionIndex(*MI); 1734 DefIdx = DefIdx.getRegSlot(MO->isEarlyClobber()); 1735 1736 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1737 if (LiveInts->hasInterval(Reg)) { 1738 const LiveInterval &LI = LiveInts->getInterval(Reg); 1739 checkLivenessAtDef(MO, MONum, DefIdx, LI, Reg); 1740 1741 if (LI.hasSubRanges()) { 1742 unsigned SubRegIdx = MO->getSubReg(); 1743 LaneBitmask MOMask = SubRegIdx != 0 1744 ? TRI->getSubRegIndexLaneMask(SubRegIdx) 1745 : MRI->getMaxLaneMaskForVReg(Reg); 1746 for (const LiveInterval::SubRange &SR : LI.subranges()) { 1747 if ((SR.LaneMask & MOMask).none()) 1748 continue; 1749 checkLivenessAtDef(MO, MONum, DefIdx, SR, Reg, true, SR.LaneMask); 1750 } 1751 } 1752 } else { 1753 report("Virtual register has no Live interval", MO, MONum); 1754 } 1755 } 1756 } 1757 } 1758 } 1759 1760 void MachineVerifier::visitMachineInstrAfter(const MachineInstr *MI) {} 1761 1762 // This function gets called after visiting all instructions in a bundle. The 1763 // argument points to the bundle header. 1764 // Normal stand-alone instructions are also considered 'bundles', and this 1765 // function is called for all of them. 1766 void MachineVerifier::visitMachineBundleAfter(const MachineInstr *MI) { 1767 BBInfo &MInfo = MBBInfoMap[MI->getParent()]; 1768 set_union(MInfo.regsKilled, regsKilled); 1769 set_subtract(regsLive, regsKilled); regsKilled.clear(); 1770 // Kill any masked registers. 1771 while (!regMasks.empty()) { 1772 const uint32_t *Mask = regMasks.pop_back_val(); 1773 for (RegSet::iterator I = regsLive.begin(), E = regsLive.end(); I != E; ++I) 1774 if (TargetRegisterInfo::isPhysicalRegister(*I) && 1775 MachineOperand::clobbersPhysReg(Mask, *I)) 1776 regsDead.push_back(*I); 1777 } 1778 set_subtract(regsLive, regsDead); regsDead.clear(); 1779 set_union(regsLive, regsDefined); regsDefined.clear(); 1780 } 1781 1782 void 1783 MachineVerifier::visitMachineBasicBlockAfter(const MachineBasicBlock *MBB) { 1784 MBBInfoMap[MBB].regsLiveOut = regsLive; 1785 regsLive.clear(); 1786 1787 if (Indexes) { 1788 SlotIndex stop = Indexes->getMBBEndIdx(MBB); 1789 if (!(stop > lastIndex)) { 1790 report("Block ends before last instruction index", MBB); 1791 errs() << "Block ends at " << stop 1792 << " last instruction was at " << lastIndex << '\n'; 1793 } 1794 lastIndex = stop; 1795 } 1796 } 1797 1798 // Calculate the largest possible vregsPassed sets. These are the registers that 1799 // can pass through an MBB live, but may not be live every time. It is assumed 1800 // that all vregsPassed sets are empty before the call. 1801 void MachineVerifier::calcRegsPassed() { 1802 // First push live-out regs to successors' vregsPassed. Remember the MBBs that 1803 // have any vregsPassed. 1804 SmallPtrSet<const MachineBasicBlock*, 8> todo; 1805 for (const auto &MBB : *MF) { 1806 BBInfo &MInfo = MBBInfoMap[&MBB]; 1807 if (!MInfo.reachable) 1808 continue; 1809 for (MachineBasicBlock::const_succ_iterator SuI = MBB.succ_begin(), 1810 SuE = MBB.succ_end(); SuI != SuE; ++SuI) { 1811 BBInfo &SInfo = MBBInfoMap[*SuI]; 1812 if (SInfo.addPassed(MInfo.regsLiveOut)) 1813 todo.insert(*SuI); 1814 } 1815 } 1816 1817 // Iteratively push vregsPassed to successors. This will converge to the same 1818 // final state regardless of DenseSet iteration order. 1819 while (!todo.empty()) { 1820 const MachineBasicBlock *MBB = *todo.begin(); 1821 todo.erase(MBB); 1822 BBInfo &MInfo = MBBInfoMap[MBB]; 1823 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(), 1824 SuE = MBB->succ_end(); SuI != SuE; ++SuI) { 1825 if (*SuI == MBB) 1826 continue; 1827 BBInfo &SInfo = MBBInfoMap[*SuI]; 1828 if (SInfo.addPassed(MInfo.vregsPassed)) 1829 todo.insert(*SuI); 1830 } 1831 } 1832 } 1833 1834 // Calculate the set of virtual registers that must be passed through each basic 1835 // block in order to satisfy the requirements of successor blocks. This is very 1836 // similar to calcRegsPassed, only backwards. 1837 void MachineVerifier::calcRegsRequired() { 1838 // First push live-in regs to predecessors' vregsRequired. 1839 SmallPtrSet<const MachineBasicBlock*, 8> todo; 1840 for (const auto &MBB : *MF) { 1841 BBInfo &MInfo = MBBInfoMap[&MBB]; 1842 for (MachineBasicBlock::const_pred_iterator PrI = MBB.pred_begin(), 1843 PrE = MBB.pred_end(); PrI != PrE; ++PrI) { 1844 BBInfo &PInfo = MBBInfoMap[*PrI]; 1845 if (PInfo.addRequired(MInfo.vregsLiveIn)) 1846 todo.insert(*PrI); 1847 } 1848 } 1849 1850 // Iteratively push vregsRequired to predecessors. This will converge to the 1851 // same final state regardless of DenseSet iteration order. 1852 while (!todo.empty()) { 1853 const MachineBasicBlock *MBB = *todo.begin(); 1854 todo.erase(MBB); 1855 BBInfo &MInfo = MBBInfoMap[MBB]; 1856 for (MachineBasicBlock::const_pred_iterator PrI = MBB->pred_begin(), 1857 PrE = MBB->pred_end(); PrI != PrE; ++PrI) { 1858 if (*PrI == MBB) 1859 continue; 1860 BBInfo &SInfo = MBBInfoMap[*PrI]; 1861 if (SInfo.addRequired(MInfo.vregsRequired)) 1862 todo.insert(*PrI); 1863 } 1864 } 1865 } 1866 1867 // Check PHI instructions at the beginning of MBB. It is assumed that 1868 // calcRegsPassed has been run so BBInfo::isLiveOut is valid. 1869 void MachineVerifier::checkPHIOps(const MachineBasicBlock &MBB) { 1870 BBInfo &MInfo = MBBInfoMap[&MBB]; 1871 1872 SmallPtrSet<const MachineBasicBlock*, 8> seen; 1873 for (const MachineInstr &Phi : MBB) { 1874 if (!Phi.isPHI()) 1875 break; 1876 seen.clear(); 1877 1878 const MachineOperand &MODef = Phi.getOperand(0); 1879 if (!MODef.isReg() || !MODef.isDef()) { 1880 report("Expected first PHI operand to be a register def", &MODef, 0); 1881 continue; 1882 } 1883 if (MODef.isTied() || MODef.isImplicit() || MODef.isInternalRead() || 1884 MODef.isEarlyClobber() || MODef.isDebug()) 1885 report("Unexpected flag on PHI operand", &MODef, 0); 1886 unsigned DefReg = MODef.getReg(); 1887 if (!TargetRegisterInfo::isVirtualRegister(DefReg)) 1888 report("Expected first PHI operand to be a virtual register", &MODef, 0); 1889 1890 for (unsigned I = 1, E = Phi.getNumOperands(); I != E; I += 2) { 1891 const MachineOperand &MO0 = Phi.getOperand(I); 1892 if (!MO0.isReg()) { 1893 report("Expected PHI operand to be a register", &MO0, I); 1894 continue; 1895 } 1896 if (MO0.isImplicit() || MO0.isInternalRead() || MO0.isEarlyClobber() || 1897 MO0.isDebug() || MO0.isTied()) 1898 report("Unexpected flag on PHI operand", &MO0, I); 1899 1900 const MachineOperand &MO1 = Phi.getOperand(I + 1); 1901 if (!MO1.isMBB()) { 1902 report("Expected PHI operand to be a basic block", &MO1, I + 1); 1903 continue; 1904 } 1905 1906 const MachineBasicBlock &Pre = *MO1.getMBB(); 1907 if (!Pre.isSuccessor(&MBB)) { 1908 report("PHI input is not a predecessor block", &MO1, I + 1); 1909 continue; 1910 } 1911 1912 if (MInfo.reachable) { 1913 seen.insert(&Pre); 1914 BBInfo &PrInfo = MBBInfoMap[&Pre]; 1915 if (!MO0.isUndef() && PrInfo.reachable && 1916 !PrInfo.isLiveOut(MO0.getReg())) 1917 report("PHI operand is not live-out from predecessor", &MO0, I); 1918 } 1919 } 1920 1921 // Did we see all predecessors? 1922 if (MInfo.reachable) { 1923 for (MachineBasicBlock *Pred : MBB.predecessors()) { 1924 if (!seen.count(Pred)) { 1925 report("Missing PHI operand", &Phi); 1926 errs() << printMBBReference(*Pred) 1927 << " is a predecessor according to the CFG.\n"; 1928 } 1929 } 1930 } 1931 } 1932 } 1933 1934 void MachineVerifier::visitMachineFunctionAfter() { 1935 calcRegsPassed(); 1936 1937 for (const MachineBasicBlock &MBB : *MF) 1938 checkPHIOps(MBB); 1939 1940 // Now check liveness info if available 1941 calcRegsRequired(); 1942 1943 // Check for killed virtual registers that should be live out. 1944 for (const auto &MBB : *MF) { 1945 BBInfo &MInfo = MBBInfoMap[&MBB]; 1946 for (RegSet::iterator 1947 I = MInfo.vregsRequired.begin(), E = MInfo.vregsRequired.end(); I != E; 1948 ++I) 1949 if (MInfo.regsKilled.count(*I)) { 1950 report("Virtual register killed in block, but needed live out.", &MBB); 1951 errs() << "Virtual register " << printReg(*I) 1952 << " is used after the block.\n"; 1953 } 1954 } 1955 1956 if (!MF->empty()) { 1957 BBInfo &MInfo = MBBInfoMap[&MF->front()]; 1958 for (RegSet::iterator 1959 I = MInfo.vregsRequired.begin(), E = MInfo.vregsRequired.end(); I != E; 1960 ++I) { 1961 report("Virtual register defs don't dominate all uses.", MF); 1962 report_context_vreg(*I); 1963 } 1964 } 1965 1966 if (LiveVars) 1967 verifyLiveVariables(); 1968 if (LiveInts) 1969 verifyLiveIntervals(); 1970 } 1971 1972 void MachineVerifier::verifyLiveVariables() { 1973 assert(LiveVars && "Don't call verifyLiveVariables without LiveVars"); 1974 for (unsigned i = 0, e = MRI->getNumVirtRegs(); i != e; ++i) { 1975 unsigned Reg = TargetRegisterInfo::index2VirtReg(i); 1976 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg); 1977 for (const auto &MBB : *MF) { 1978 BBInfo &MInfo = MBBInfoMap[&MBB]; 1979 1980 // Our vregsRequired should be identical to LiveVariables' AliveBlocks 1981 if (MInfo.vregsRequired.count(Reg)) { 1982 if (!VI.AliveBlocks.test(MBB.getNumber())) { 1983 report("LiveVariables: Block missing from AliveBlocks", &MBB); 1984 errs() << "Virtual register " << printReg(Reg) 1985 << " must be live through the block.\n"; 1986 } 1987 } else { 1988 if (VI.AliveBlocks.test(MBB.getNumber())) { 1989 report("LiveVariables: Block should not be in AliveBlocks", &MBB); 1990 errs() << "Virtual register " << printReg(Reg) 1991 << " is not needed live through the block.\n"; 1992 } 1993 } 1994 } 1995 } 1996 } 1997 1998 void MachineVerifier::verifyLiveIntervals() { 1999 assert(LiveInts && "Don't call verifyLiveIntervals without LiveInts"); 2000 for (unsigned i = 0, e = MRI->getNumVirtRegs(); i != e; ++i) { 2001 unsigned Reg = TargetRegisterInfo::index2VirtReg(i); 2002 2003 // Spilling and splitting may leave unused registers around. Skip them. 2004 if (MRI->reg_nodbg_empty(Reg)) 2005 continue; 2006 2007 if (!LiveInts->hasInterval(Reg)) { 2008 report("Missing live interval for virtual register", MF); 2009 errs() << printReg(Reg, TRI) << " still has defs or uses\n"; 2010 continue; 2011 } 2012 2013 const LiveInterval &LI = LiveInts->getInterval(Reg); 2014 assert(Reg == LI.reg && "Invalid reg to interval mapping"); 2015 verifyLiveInterval(LI); 2016 } 2017 2018 // Verify all the cached regunit intervals. 2019 for (unsigned i = 0, e = TRI->getNumRegUnits(); i != e; ++i) 2020 if (const LiveRange *LR = LiveInts->getCachedRegUnit(i)) 2021 verifyLiveRange(*LR, i); 2022 } 2023 2024 void MachineVerifier::verifyLiveRangeValue(const LiveRange &LR, 2025 const VNInfo *VNI, unsigned Reg, 2026 LaneBitmask LaneMask) { 2027 if (VNI->isUnused()) 2028 return; 2029 2030 const VNInfo *DefVNI = LR.getVNInfoAt(VNI->def); 2031 2032 if (!DefVNI) { 2033 report("Value not live at VNInfo def and not marked unused", MF); 2034 report_context(LR, Reg, LaneMask); 2035 report_context(*VNI); 2036 return; 2037 } 2038 2039 if (DefVNI != VNI) { 2040 report("Live segment at def has different VNInfo", MF); 2041 report_context(LR, Reg, LaneMask); 2042 report_context(*VNI); 2043 return; 2044 } 2045 2046 const MachineBasicBlock *MBB = LiveInts->getMBBFromIndex(VNI->def); 2047 if (!MBB) { 2048 report("Invalid VNInfo definition index", MF); 2049 report_context(LR, Reg, LaneMask); 2050 report_context(*VNI); 2051 return; 2052 } 2053 2054 if (VNI->isPHIDef()) { 2055 if (VNI->def != LiveInts->getMBBStartIdx(MBB)) { 2056 report("PHIDef VNInfo is not defined at MBB start", MBB); 2057 report_context(LR, Reg, LaneMask); 2058 report_context(*VNI); 2059 } 2060 return; 2061 } 2062 2063 // Non-PHI def. 2064 const MachineInstr *MI = LiveInts->getInstructionFromIndex(VNI->def); 2065 if (!MI) { 2066 report("No instruction at VNInfo def index", MBB); 2067 report_context(LR, Reg, LaneMask); 2068 report_context(*VNI); 2069 return; 2070 } 2071 2072 if (Reg != 0) { 2073 bool hasDef = false; 2074 bool isEarlyClobber = false; 2075 for (ConstMIBundleOperands MOI(*MI); MOI.isValid(); ++MOI) { 2076 if (!MOI->isReg() || !MOI->isDef()) 2077 continue; 2078 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 2079 if (MOI->getReg() != Reg) 2080 continue; 2081 } else { 2082 if (!TargetRegisterInfo::isPhysicalRegister(MOI->getReg()) || 2083 !TRI->hasRegUnit(MOI->getReg(), Reg)) 2084 continue; 2085 } 2086 if (LaneMask.any() && 2087 (TRI->getSubRegIndexLaneMask(MOI->getSubReg()) & LaneMask).none()) 2088 continue; 2089 hasDef = true; 2090 if (MOI->isEarlyClobber()) 2091 isEarlyClobber = true; 2092 } 2093 2094 if (!hasDef) { 2095 report("Defining instruction does not modify register", MI); 2096 report_context(LR, Reg, LaneMask); 2097 report_context(*VNI); 2098 } 2099 2100 // Early clobber defs begin at USE slots, but other defs must begin at 2101 // DEF slots. 2102 if (isEarlyClobber) { 2103 if (!VNI->def.isEarlyClobber()) { 2104 report("Early clobber def must be at an early-clobber slot", MBB); 2105 report_context(LR, Reg, LaneMask); 2106 report_context(*VNI); 2107 } 2108 } else if (!VNI->def.isRegister()) { 2109 report("Non-PHI, non-early clobber def must be at a register slot", MBB); 2110 report_context(LR, Reg, LaneMask); 2111 report_context(*VNI); 2112 } 2113 } 2114 } 2115 2116 void MachineVerifier::verifyLiveRangeSegment(const LiveRange &LR, 2117 const LiveRange::const_iterator I, 2118 unsigned Reg, LaneBitmask LaneMask) 2119 { 2120 const LiveRange::Segment &S = *I; 2121 const VNInfo *VNI = S.valno; 2122 assert(VNI && "Live segment has no valno"); 2123 2124 if (VNI->id >= LR.getNumValNums() || VNI != LR.getValNumInfo(VNI->id)) { 2125 report("Foreign valno in live segment", MF); 2126 report_context(LR, Reg, LaneMask); 2127 report_context(S); 2128 report_context(*VNI); 2129 } 2130 2131 if (VNI->isUnused()) { 2132 report("Live segment valno is marked unused", MF); 2133 report_context(LR, Reg, LaneMask); 2134 report_context(S); 2135 } 2136 2137 const MachineBasicBlock *MBB = LiveInts->getMBBFromIndex(S.start); 2138 if (!MBB) { 2139 report("Bad start of live segment, no basic block", MF); 2140 report_context(LR, Reg, LaneMask); 2141 report_context(S); 2142 return; 2143 } 2144 SlotIndex MBBStartIdx = LiveInts->getMBBStartIdx(MBB); 2145 if (S.start != MBBStartIdx && S.start != VNI->def) { 2146 report("Live segment must begin at MBB entry or valno def", MBB); 2147 report_context(LR, Reg, LaneMask); 2148 report_context(S); 2149 } 2150 2151 const MachineBasicBlock *EndMBB = 2152 LiveInts->getMBBFromIndex(S.end.getPrevSlot()); 2153 if (!EndMBB) { 2154 report("Bad end of live segment, no basic block", MF); 2155 report_context(LR, Reg, LaneMask); 2156 report_context(S); 2157 return; 2158 } 2159 2160 // No more checks for live-out segments. 2161 if (S.end == LiveInts->getMBBEndIdx(EndMBB)) 2162 return; 2163 2164 // RegUnit intervals are allowed dead phis. 2165 if (!TargetRegisterInfo::isVirtualRegister(Reg) && VNI->isPHIDef() && 2166 S.start == VNI->def && S.end == VNI->def.getDeadSlot()) 2167 return; 2168 2169 // The live segment is ending inside EndMBB 2170 const MachineInstr *MI = 2171 LiveInts->getInstructionFromIndex(S.end.getPrevSlot()); 2172 if (!MI) { 2173 report("Live segment doesn't end at a valid instruction", EndMBB); 2174 report_context(LR, Reg, LaneMask); 2175 report_context(S); 2176 return; 2177 } 2178 2179 // The block slot must refer to a basic block boundary. 2180 if (S.end.isBlock()) { 2181 report("Live segment ends at B slot of an instruction", EndMBB); 2182 report_context(LR, Reg, LaneMask); 2183 report_context(S); 2184 } 2185 2186 if (S.end.isDead()) { 2187 // Segment ends on the dead slot. 2188 // That means there must be a dead def. 2189 if (!SlotIndex::isSameInstr(S.start, S.end)) { 2190 report("Live segment ending at dead slot spans instructions", EndMBB); 2191 report_context(LR, Reg, LaneMask); 2192 report_context(S); 2193 } 2194 } 2195 2196 // A live segment can only end at an early-clobber slot if it is being 2197 // redefined by an early-clobber def. 2198 if (S.end.isEarlyClobber()) { 2199 if (I+1 == LR.end() || (I+1)->start != S.end) { 2200 report("Live segment ending at early clobber slot must be " 2201 "redefined by an EC def in the same instruction", EndMBB); 2202 report_context(LR, Reg, LaneMask); 2203 report_context(S); 2204 } 2205 } 2206 2207 // The following checks only apply to virtual registers. Physreg liveness 2208 // is too weird to check. 2209 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 2210 // A live segment can end with either a redefinition, a kill flag on a 2211 // use, or a dead flag on a def. 2212 bool hasRead = false; 2213 bool hasSubRegDef = false; 2214 bool hasDeadDef = false; 2215 for (ConstMIBundleOperands MOI(*MI); MOI.isValid(); ++MOI) { 2216 if (!MOI->isReg() || MOI->getReg() != Reg) 2217 continue; 2218 unsigned Sub = MOI->getSubReg(); 2219 LaneBitmask SLM = Sub != 0 ? TRI->getSubRegIndexLaneMask(Sub) 2220 : LaneBitmask::getAll(); 2221 if (MOI->isDef()) { 2222 if (Sub != 0) { 2223 hasSubRegDef = true; 2224 // An operand %0:sub0 reads %0:sub1..n. Invert the lane 2225 // mask for subregister defs. Read-undef defs will be handled by 2226 // readsReg below. 2227 SLM = ~SLM; 2228 } 2229 if (MOI->isDead()) 2230 hasDeadDef = true; 2231 } 2232 if (LaneMask.any() && (LaneMask & SLM).none()) 2233 continue; 2234 if (MOI->readsReg()) 2235 hasRead = true; 2236 } 2237 if (S.end.isDead()) { 2238 // Make sure that the corresponding machine operand for a "dead" live 2239 // range has the dead flag. We cannot perform this check for subregister 2240 // liveranges as partially dead values are allowed. 2241 if (LaneMask.none() && !hasDeadDef) { 2242 report("Instruction ending live segment on dead slot has no dead flag", 2243 MI); 2244 report_context(LR, Reg, LaneMask); 2245 report_context(S); 2246 } 2247 } else { 2248 if (!hasRead) { 2249 // When tracking subregister liveness, the main range must start new 2250 // values on partial register writes, even if there is no read. 2251 if (!MRI->shouldTrackSubRegLiveness(Reg) || LaneMask.any() || 2252 !hasSubRegDef) { 2253 report("Instruction ending live segment doesn't read the register", 2254 MI); 2255 report_context(LR, Reg, LaneMask); 2256 report_context(S); 2257 } 2258 } 2259 } 2260 } 2261 2262 // Now check all the basic blocks in this live segment. 2263 MachineFunction::const_iterator MFI = MBB->getIterator(); 2264 // Is this live segment the beginning of a non-PHIDef VN? 2265 if (S.start == VNI->def && !VNI->isPHIDef()) { 2266 // Not live-in to any blocks. 2267 if (MBB == EndMBB) 2268 return; 2269 // Skip this block. 2270 ++MFI; 2271 } 2272 2273 SmallVector<SlotIndex, 4> Undefs; 2274 if (LaneMask.any()) { 2275 LiveInterval &OwnerLI = LiveInts->getInterval(Reg); 2276 OwnerLI.computeSubRangeUndefs(Undefs, LaneMask, *MRI, *Indexes); 2277 } 2278 2279 while (true) { 2280 assert(LiveInts->isLiveInToMBB(LR, &*MFI)); 2281 // We don't know how to track physregs into a landing pad. 2282 if (!TargetRegisterInfo::isVirtualRegister(Reg) && 2283 MFI->isEHPad()) { 2284 if (&*MFI == EndMBB) 2285 break; 2286 ++MFI; 2287 continue; 2288 } 2289 2290 // Is VNI a PHI-def in the current block? 2291 bool IsPHI = VNI->isPHIDef() && 2292 VNI->def == LiveInts->getMBBStartIdx(&*MFI); 2293 2294 // Check that VNI is live-out of all predecessors. 2295 for (MachineBasicBlock::const_pred_iterator PI = MFI->pred_begin(), 2296 PE = MFI->pred_end(); PI != PE; ++PI) { 2297 SlotIndex PEnd = LiveInts->getMBBEndIdx(*PI); 2298 const VNInfo *PVNI = LR.getVNInfoBefore(PEnd); 2299 2300 // All predecessors must have a live-out value. However for a phi 2301 // instruction with subregister intervals 2302 // only one of the subregisters (not necessarily the current one) needs to 2303 // be defined. 2304 if (!PVNI && (LaneMask.none() || !IsPHI)) { 2305 if (LiveRangeCalc::isJointlyDominated(*PI, Undefs, *Indexes)) 2306 continue; 2307 report("Register not marked live out of predecessor", *PI); 2308 report_context(LR, Reg, LaneMask); 2309 report_context(*VNI); 2310 errs() << " live into " << printMBBReference(*MFI) << '@' 2311 << LiveInts->getMBBStartIdx(&*MFI) << ", not live before " 2312 << PEnd << '\n'; 2313 continue; 2314 } 2315 2316 // Only PHI-defs can take different predecessor values. 2317 if (!IsPHI && PVNI != VNI) { 2318 report("Different value live out of predecessor", *PI); 2319 report_context(LR, Reg, LaneMask); 2320 errs() << "Valno #" << PVNI->id << " live out of " 2321 << printMBBReference(*(*PI)) << '@' << PEnd << "\nValno #" 2322 << VNI->id << " live into " << printMBBReference(*MFI) << '@' 2323 << LiveInts->getMBBStartIdx(&*MFI) << '\n'; 2324 } 2325 } 2326 if (&*MFI == EndMBB) 2327 break; 2328 ++MFI; 2329 } 2330 } 2331 2332 void MachineVerifier::verifyLiveRange(const LiveRange &LR, unsigned Reg, 2333 LaneBitmask LaneMask) { 2334 for (const VNInfo *VNI : LR.valnos) 2335 verifyLiveRangeValue(LR, VNI, Reg, LaneMask); 2336 2337 for (LiveRange::const_iterator I = LR.begin(), E = LR.end(); I != E; ++I) 2338 verifyLiveRangeSegment(LR, I, Reg, LaneMask); 2339 } 2340 2341 void MachineVerifier::verifyLiveInterval(const LiveInterval &LI) { 2342 unsigned Reg = LI.reg; 2343 assert(TargetRegisterInfo::isVirtualRegister(Reg)); 2344 verifyLiveRange(LI, Reg); 2345 2346 LaneBitmask Mask; 2347 LaneBitmask MaxMask = MRI->getMaxLaneMaskForVReg(Reg); 2348 for (const LiveInterval::SubRange &SR : LI.subranges()) { 2349 if ((Mask & SR.LaneMask).any()) { 2350 report("Lane masks of sub ranges overlap in live interval", MF); 2351 report_context(LI); 2352 } 2353 if ((SR.LaneMask & ~MaxMask).any()) { 2354 report("Subrange lanemask is invalid", MF); 2355 report_context(LI); 2356 } 2357 if (SR.empty()) { 2358 report("Subrange must not be empty", MF); 2359 report_context(SR, LI.reg, SR.LaneMask); 2360 } 2361 Mask |= SR.LaneMask; 2362 verifyLiveRange(SR, LI.reg, SR.LaneMask); 2363 if (!LI.covers(SR)) { 2364 report("A Subrange is not covered by the main range", MF); 2365 report_context(LI); 2366 } 2367 } 2368 2369 // Check the LI only has one connected component. 2370 ConnectedVNInfoEqClasses ConEQ(*LiveInts); 2371 unsigned NumComp = ConEQ.Classify(LI); 2372 if (NumComp > 1) { 2373 report("Multiple connected components in live interval", MF); 2374 report_context(LI); 2375 for (unsigned comp = 0; comp != NumComp; ++comp) { 2376 errs() << comp << ": valnos"; 2377 for (LiveInterval::const_vni_iterator I = LI.vni_begin(), 2378 E = LI.vni_end(); I!=E; ++I) 2379 if (comp == ConEQ.getEqClass(*I)) 2380 errs() << ' ' << (*I)->id; 2381 errs() << '\n'; 2382 } 2383 } 2384 } 2385 2386 namespace { 2387 2388 // FrameSetup and FrameDestroy can have zero adjustment, so using a single 2389 // integer, we can't tell whether it is a FrameSetup or FrameDestroy if the 2390 // value is zero. 2391 // We use a bool plus an integer to capture the stack state. 2392 struct StackStateOfBB { 2393 StackStateOfBB() = default; 2394 StackStateOfBB(int EntryVal, int ExitVal, bool EntrySetup, bool ExitSetup) : 2395 EntryValue(EntryVal), ExitValue(ExitVal), EntryIsSetup(EntrySetup), 2396 ExitIsSetup(ExitSetup) {} 2397 2398 // Can be negative, which means we are setting up a frame. 2399 int EntryValue = 0; 2400 int ExitValue = 0; 2401 bool EntryIsSetup = false; 2402 bool ExitIsSetup = false; 2403 }; 2404 2405 } // end anonymous namespace 2406 2407 /// Make sure on every path through the CFG, a FrameSetup <n> is always followed 2408 /// by a FrameDestroy <n>, stack adjustments are identical on all 2409 /// CFG edges to a merge point, and frame is destroyed at end of a return block. 2410 void MachineVerifier::verifyStackFrame() { 2411 unsigned FrameSetupOpcode = TII->getCallFrameSetupOpcode(); 2412 unsigned FrameDestroyOpcode = TII->getCallFrameDestroyOpcode(); 2413 if (FrameSetupOpcode == ~0u && FrameDestroyOpcode == ~0u) 2414 return; 2415 2416 SmallVector<StackStateOfBB, 8> SPState; 2417 SPState.resize(MF->getNumBlockIDs()); 2418 df_iterator_default_set<const MachineBasicBlock*> Reachable; 2419 2420 // Visit the MBBs in DFS order. 2421 for (df_ext_iterator<const MachineFunction *, 2422 df_iterator_default_set<const MachineBasicBlock *>> 2423 DFI = df_ext_begin(MF, Reachable), DFE = df_ext_end(MF, Reachable); 2424 DFI != DFE; ++DFI) { 2425 const MachineBasicBlock *MBB = *DFI; 2426 2427 StackStateOfBB BBState; 2428 // Check the exit state of the DFS stack predecessor. 2429 if (DFI.getPathLength() >= 2) { 2430 const MachineBasicBlock *StackPred = DFI.getPath(DFI.getPathLength() - 2); 2431 assert(Reachable.count(StackPred) && 2432 "DFS stack predecessor is already visited.\n"); 2433 BBState.EntryValue = SPState[StackPred->getNumber()].ExitValue; 2434 BBState.EntryIsSetup = SPState[StackPred->getNumber()].ExitIsSetup; 2435 BBState.ExitValue = BBState.EntryValue; 2436 BBState.ExitIsSetup = BBState.EntryIsSetup; 2437 } 2438 2439 // Update stack state by checking contents of MBB. 2440 for (const auto &I : *MBB) { 2441 if (I.getOpcode() == FrameSetupOpcode) { 2442 if (BBState.ExitIsSetup) 2443 report("FrameSetup is after another FrameSetup", &I); 2444 BBState.ExitValue -= TII->getFrameTotalSize(I); 2445 BBState.ExitIsSetup = true; 2446 } 2447 2448 if (I.getOpcode() == FrameDestroyOpcode) { 2449 int Size = TII->getFrameTotalSize(I); 2450 if (!BBState.ExitIsSetup) 2451 report("FrameDestroy is not after a FrameSetup", &I); 2452 int AbsSPAdj = BBState.ExitValue < 0 ? -BBState.ExitValue : 2453 BBState.ExitValue; 2454 if (BBState.ExitIsSetup && AbsSPAdj != Size) { 2455 report("FrameDestroy <n> is after FrameSetup <m>", &I); 2456 errs() << "FrameDestroy <" << Size << "> is after FrameSetup <" 2457 << AbsSPAdj << ">.\n"; 2458 } 2459 BBState.ExitValue += Size; 2460 BBState.ExitIsSetup = false; 2461 } 2462 } 2463 SPState[MBB->getNumber()] = BBState; 2464 2465 // Make sure the exit state of any predecessor is consistent with the entry 2466 // state. 2467 for (MachineBasicBlock::const_pred_iterator I = MBB->pred_begin(), 2468 E = MBB->pred_end(); I != E; ++I) { 2469 if (Reachable.count(*I) && 2470 (SPState[(*I)->getNumber()].ExitValue != BBState.EntryValue || 2471 SPState[(*I)->getNumber()].ExitIsSetup != BBState.EntryIsSetup)) { 2472 report("The exit stack state of a predecessor is inconsistent.", MBB); 2473 errs() << "Predecessor " << printMBBReference(*(*I)) 2474 << " has exit state (" << SPState[(*I)->getNumber()].ExitValue 2475 << ", " << SPState[(*I)->getNumber()].ExitIsSetup << "), while " 2476 << printMBBReference(*MBB) << " has entry state (" 2477 << BBState.EntryValue << ", " << BBState.EntryIsSetup << ").\n"; 2478 } 2479 } 2480 2481 // Make sure the entry state of any successor is consistent with the exit 2482 // state. 2483 for (MachineBasicBlock::const_succ_iterator I = MBB->succ_begin(), 2484 E = MBB->succ_end(); I != E; ++I) { 2485 if (Reachable.count(*I) && 2486 (SPState[(*I)->getNumber()].EntryValue != BBState.ExitValue || 2487 SPState[(*I)->getNumber()].EntryIsSetup != BBState.ExitIsSetup)) { 2488 report("The entry stack state of a successor is inconsistent.", MBB); 2489 errs() << "Successor " << printMBBReference(*(*I)) 2490 << " has entry state (" << SPState[(*I)->getNumber()].EntryValue 2491 << ", " << SPState[(*I)->getNumber()].EntryIsSetup << "), while " 2492 << printMBBReference(*MBB) << " has exit state (" 2493 << BBState.ExitValue << ", " << BBState.ExitIsSetup << ").\n"; 2494 } 2495 } 2496 2497 // Make sure a basic block with return ends with zero stack adjustment. 2498 if (!MBB->empty() && MBB->back().isReturn()) { 2499 if (BBState.ExitIsSetup) 2500 report("A return block ends with a FrameSetup.", MBB); 2501 if (BBState.ExitValue) 2502 report("A return block ends with a nonzero stack adjustment.", MBB); 2503 } 2504 } 2505 } 2506