1 //===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 10 #include "FormatTestUtils.h" 11 #include "clang/Format/Format.h" 12 #include "llvm/Support/Debug.h" 13 #include "gtest/gtest.h" 14 15 #define DEBUG_TYPE "format-test" 16 17 namespace clang { 18 namespace format { 19 20 FormatStyle getGoogleStyle() { 21 return getGoogleStyle(FormatStyle::LK_Cpp); 22 } 23 24 class FormatTest : public ::testing::Test { 25 protected: 26 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length, 27 const FormatStyle &Style) { 28 DEBUG(llvm::errs() << "---\n"); 29 DEBUG(llvm::errs() << Code << "\n\n"); 30 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); 31 tooling::Replacements Replaces = reformat(Style, Code, Ranges); 32 ReplacementCount = Replaces.size(); 33 std::string Result = applyAllReplacements(Code, Replaces); 34 EXPECT_NE("", Result); 35 DEBUG(llvm::errs() << "\n" << Result << "\n\n"); 36 return Result; 37 } 38 39 std::string 40 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) { 41 return format(Code, 0, Code.size(), Style); 42 } 43 44 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { 45 FormatStyle Style = getLLVMStyle(); 46 Style.ColumnLimit = ColumnLimit; 47 return Style; 48 } 49 50 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { 51 FormatStyle Style = getGoogleStyle(); 52 Style.ColumnLimit = ColumnLimit; 53 return Style; 54 } 55 56 void verifyFormat(llvm::StringRef Code, 57 const FormatStyle &Style = getLLVMStyle()) { 58 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); 59 } 60 61 void verifyGoogleFormat(llvm::StringRef Code) { 62 verifyFormat(Code, getGoogleStyle()); 63 } 64 65 void verifyIndependentOfContext(llvm::StringRef text) { 66 verifyFormat(text); 67 verifyFormat(llvm::Twine("void f() { " + text + " }").str()); 68 } 69 70 int ReplacementCount; 71 }; 72 73 TEST_F(FormatTest, MessUp) { 74 EXPECT_EQ("1 2 3", test::messUp("1 2 3")); 75 EXPECT_EQ("1 2 3\n", test::messUp("1\n2\n3\n")); 76 EXPECT_EQ("a\n//b\nc", test::messUp("a\n//b\nc")); 77 EXPECT_EQ("a\n#b\nc", test::messUp("a\n#b\nc")); 78 EXPECT_EQ("a\n#b c d\ne", test::messUp("a\n#b\\\nc\\\nd\ne")); 79 } 80 81 //===----------------------------------------------------------------------===// 82 // Basic function tests. 83 //===----------------------------------------------------------------------===// 84 85 TEST_F(FormatTest, DoesNotChangeCorrectlyFormattedCode) { 86 EXPECT_EQ(";", format(";")); 87 } 88 89 TEST_F(FormatTest, FormatsGlobalStatementsAt0) { 90 EXPECT_EQ("int i;", format(" int i;")); 91 EXPECT_EQ("\nint i;", format(" \n\t \v \f int i;")); 92 EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); 93 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); 94 } 95 96 TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { 97 EXPECT_EQ("int i;", format("int\ni;")); 98 } 99 100 TEST_F(FormatTest, FormatsNestedBlockStatements) { 101 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); 102 } 103 104 TEST_F(FormatTest, FormatsNestedCall) { 105 verifyFormat("Method(f1, f2(f3));"); 106 verifyFormat("Method(f1(f2, f3()));"); 107 verifyFormat("Method(f1(f2, (f3())));"); 108 } 109 110 TEST_F(FormatTest, NestedNameSpecifiers) { 111 verifyFormat("vector<::Type> v;"); 112 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); 113 verifyFormat("static constexpr bool Bar = decltype(bar())::value;"); 114 } 115 116 TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { 117 EXPECT_EQ("if (a) {\n" 118 " f();\n" 119 "}", 120 format("if(a){f();}")); 121 EXPECT_EQ(4, ReplacementCount); 122 EXPECT_EQ("if (a) {\n" 123 " f();\n" 124 "}", 125 format("if (a) {\n" 126 " f();\n" 127 "}")); 128 EXPECT_EQ(0, ReplacementCount); 129 } 130 131 TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) { 132 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle())); 133 EXPECT_EQ("int a;", format("int a; ")); 134 EXPECT_EQ("int a;\n", format("int a; \n \n \n ")); 135 EXPECT_EQ("int a;\nint b; ", 136 format("int a; \nint b; ", 0, 0, getLLVMStyle())); 137 } 138 139 TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) { 140 EXPECT_EQ("int b;\nint a;", 141 format("int b;\n int a;", 7, 0, getLLVMStyle())); 142 EXPECT_EQ("int b;\n int a;", 143 format("int b;\n int a;", 6, 0, getLLVMStyle())); 144 145 EXPECT_EQ("#define A \\\n" 146 " int a; \\\n" 147 " int b;", 148 format("#define A \\\n" 149 " int a; \\\n" 150 " int b;", 151 26, 0, getLLVMStyleWithColumns(12))); 152 EXPECT_EQ("#define A \\\n" 153 " int a; \\\n" 154 " int b;", 155 format("#define A \\\n" 156 " int a; \\\n" 157 " int b;", 158 25, 0, getLLVMStyleWithColumns(12))); 159 } 160 161 TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) { 162 EXPECT_EQ("int a;\n\n int b;", 163 format("int a;\n \n\n int b;", 7, 0, getLLVMStyle())); 164 EXPECT_EQ("int a;\n\n int b;", 165 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle())); 166 } 167 168 TEST_F(FormatTest, RemovesEmptyLines) { 169 EXPECT_EQ("class C {\n" 170 " int i;\n" 171 "};", 172 format("class C {\n" 173 " int i;\n" 174 "\n" 175 "};")); 176 177 // Don't remove empty lines at the start of namespaces. 178 EXPECT_EQ("namespace N {\n" 179 "\n" 180 "int i;\n" 181 "}", 182 format("namespace N {\n" 183 "\n" 184 "int i;\n" 185 "}", 186 getGoogleStyle())); 187 188 // Remove empty lines at the beginning and end of blocks. 189 EXPECT_EQ("void f() {\n" 190 "\n" 191 " if (a) {\n" 192 "\n" 193 " f();\n" 194 " }\n" 195 "}", 196 format("void f() {\n" 197 "\n" 198 " if (a) {\n" 199 "\n" 200 " f();\n" 201 "\n" 202 " }\n" 203 "\n" 204 "}", 205 getLLVMStyle())); 206 EXPECT_EQ("void f() {\n" 207 " if (a) {\n" 208 " f();\n" 209 " }\n" 210 "}", 211 format("void f() {\n" 212 "\n" 213 " if (a) {\n" 214 "\n" 215 " f();\n" 216 "\n" 217 " }\n" 218 "\n" 219 "}", 220 getGoogleStyle())); 221 222 // Don't remove empty lines in more complex control statements. 223 EXPECT_EQ("void f() {\n" 224 " if (a) {\n" 225 " f();\n" 226 "\n" 227 " } else if (b) {\n" 228 " f();\n" 229 " }\n" 230 "}", 231 format("void f() {\n" 232 " if (a) {\n" 233 " f();\n" 234 "\n" 235 " } else if (b) {\n" 236 " f();\n" 237 "\n" 238 " }\n" 239 "\n" 240 "}")); 241 242 // FIXME: This is slightly inconsistent. 243 EXPECT_EQ("namespace {\n" 244 "int i;\n" 245 "}", 246 format("namespace {\n" 247 "int i;\n" 248 "\n" 249 "}")); 250 EXPECT_EQ("namespace {\n" 251 "int i;\n" 252 "\n" 253 "} // namespace", 254 format("namespace {\n" 255 "int i;\n" 256 "\n" 257 "} // namespace")); 258 } 259 260 TEST_F(FormatTest, ReformatsMovedLines) { 261 EXPECT_EQ( 262 "template <typename T> T *getFETokenInfo() const {\n" 263 " return static_cast<T *>(FETokenInfo);\n" 264 "}\n" 265 " int a; // <- Should not be formatted", 266 format( 267 "template<typename T>\n" 268 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" 269 " int a; // <- Should not be formatted", 270 9, 5, getLLVMStyle())); 271 } 272 273 TEST_F(FormatTest, RecognizesBinaryOperatorKeywords) { 274 verifyFormat("x = (a) and (b);"); 275 verifyFormat("x = (a) or (b);"); 276 verifyFormat("x = (a) bitand (b);"); 277 verifyFormat("x = (a) bitor (b);"); 278 verifyFormat("x = (a) not_eq (b);"); 279 verifyFormat("x = (a) and_eq (b);"); 280 verifyFormat("x = (a) or_eq (b);"); 281 verifyFormat("x = (a) xor (b);"); 282 } 283 284 //===----------------------------------------------------------------------===// 285 // Tests for control statements. 286 //===----------------------------------------------------------------------===// 287 288 TEST_F(FormatTest, FormatIfWithoutCompoundStatement) { 289 verifyFormat("if (true)\n f();\ng();"); 290 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); 291 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); 292 293 FormatStyle AllowsMergedIf = getLLVMStyle(); 294 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 295 verifyFormat("if (a)\n" 296 " // comment\n" 297 " f();", 298 AllowsMergedIf); 299 verifyFormat("if (a)\n" 300 " ;", 301 AllowsMergedIf); 302 verifyFormat("if (a)\n" 303 " if (b) return;", 304 AllowsMergedIf); 305 306 verifyFormat("if (a) // Can't merge this\n" 307 " f();\n", 308 AllowsMergedIf); 309 verifyFormat("if (a) /* still don't merge */\n" 310 " f();", 311 AllowsMergedIf); 312 verifyFormat("if (a) { // Never merge this\n" 313 " f();\n" 314 "}", 315 AllowsMergedIf); 316 verifyFormat("if (a) {/* Never merge this */\n" 317 " f();\n" 318 "}", 319 AllowsMergedIf); 320 321 EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1, AllowsMergedIf)); 322 EXPECT_EQ("if (a) return; // comment", 323 format("if(a)\nreturn; // comment", 20, 1, AllowsMergedIf)); 324 325 AllowsMergedIf.ColumnLimit = 14; 326 verifyFormat("if (a) return;", AllowsMergedIf); 327 verifyFormat("if (aaaaaaaaa)\n" 328 " return;", 329 AllowsMergedIf); 330 331 AllowsMergedIf.ColumnLimit = 13; 332 verifyFormat("if (a)\n return;", AllowsMergedIf); 333 } 334 335 TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) { 336 FormatStyle AllowsMergedLoops = getLLVMStyle(); 337 AllowsMergedLoops.AllowShortLoopsOnASingleLine = true; 338 verifyFormat("while (true) continue;", AllowsMergedLoops); 339 verifyFormat("for (;;) continue;", AllowsMergedLoops); 340 verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops); 341 verifyFormat("while (true)\n" 342 " ;", 343 AllowsMergedLoops); 344 verifyFormat("for (;;)\n" 345 " ;", 346 AllowsMergedLoops); 347 verifyFormat("for (;;)\n" 348 " for (;;) continue;", 349 AllowsMergedLoops); 350 verifyFormat("for (;;) // Can't merge this\n" 351 " continue;", 352 AllowsMergedLoops); 353 verifyFormat("for (;;) /* still don't merge */\n" 354 " continue;", 355 AllowsMergedLoops); 356 } 357 358 TEST_F(FormatTest, FormatShortBracedStatements) { 359 FormatStyle AllowSimpleBracedStatements = getLLVMStyle(); 360 AllowSimpleBracedStatements.AllowShortBlocksOnASingleLine = true; 361 362 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true; 363 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true; 364 365 verifyFormat("if (true) {}", AllowSimpleBracedStatements); 366 verifyFormat("while (true) {}", AllowSimpleBracedStatements); 367 verifyFormat("for (;;) {}", AllowSimpleBracedStatements); 368 verifyFormat("if (true) { f(); }", AllowSimpleBracedStatements); 369 verifyFormat("while (true) { f(); }", AllowSimpleBracedStatements); 370 verifyFormat("for (;;) { f(); }", AllowSimpleBracedStatements); 371 verifyFormat("if (true) { //\n" 372 " f();\n" 373 "}", 374 AllowSimpleBracedStatements); 375 verifyFormat("if (true) {\n" 376 " f();\n" 377 " f();\n" 378 "}", 379 AllowSimpleBracedStatements); 380 381 verifyFormat("template <int> struct A2 {\n" 382 " struct B {};\n" 383 "};", 384 AllowSimpleBracedStatements); 385 386 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = false; 387 verifyFormat("if (true) {\n" 388 " f();\n" 389 "}", 390 AllowSimpleBracedStatements); 391 392 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = false; 393 verifyFormat("while (true) {\n" 394 " f();\n" 395 "}", 396 AllowSimpleBracedStatements); 397 verifyFormat("for (;;) {\n" 398 " f();\n" 399 "}", 400 AllowSimpleBracedStatements); 401 } 402 403 TEST_F(FormatTest, ParseIfElse) { 404 verifyFormat("if (true)\n" 405 " if (true)\n" 406 " if (true)\n" 407 " f();\n" 408 " else\n" 409 " g();\n" 410 " else\n" 411 " h();\n" 412 "else\n" 413 " i();"); 414 verifyFormat("if (true)\n" 415 " if (true)\n" 416 " if (true) {\n" 417 " if (true)\n" 418 " f();\n" 419 " } else {\n" 420 " g();\n" 421 " }\n" 422 " else\n" 423 " h();\n" 424 "else {\n" 425 " i();\n" 426 "}"); 427 verifyFormat("void f() {\n" 428 " if (a) {\n" 429 " } else {\n" 430 " }\n" 431 "}"); 432 } 433 434 TEST_F(FormatTest, ElseIf) { 435 verifyFormat("if (a) {\n} else if (b) {\n}"); 436 verifyFormat("if (a)\n" 437 " f();\n" 438 "else if (b)\n" 439 " g();\n" 440 "else\n" 441 " h();"); 442 verifyFormat("if (a) {\n" 443 " f();\n" 444 "}\n" 445 "// or else ..\n" 446 "else {\n" 447 " g()\n" 448 "}"); 449 450 verifyFormat("if (a) {\n" 451 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 452 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 453 "}"); 454 } 455 456 TEST_F(FormatTest, FormatsForLoop) { 457 verifyFormat( 458 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" 459 " ++VeryVeryLongLoopVariable)\n" 460 " ;"); 461 verifyFormat("for (;;)\n" 462 " f();"); 463 verifyFormat("for (;;) {\n}"); 464 verifyFormat("for (;;) {\n" 465 " f();\n" 466 "}"); 467 verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); 468 469 verifyFormat( 470 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 471 " E = UnwrappedLines.end();\n" 472 " I != E; ++I) {\n}"); 473 474 verifyFormat( 475 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" 476 " ++IIIII) {\n}"); 477 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" 478 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" 479 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); 480 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" 481 " I = FD->getDeclsInPrototypeScope().begin(),\n" 482 " E = FD->getDeclsInPrototypeScope().end();\n" 483 " I != E; ++I) {\n}"); 484 485 // FIXME: Not sure whether we want extra identation in line 3 here: 486 verifyFormat( 487 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 488 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" 489 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 490 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 491 " ++aaaaaaaaaaa) {\n}"); 492 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" 493 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 494 "}"); 495 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" 496 " aaaaaaaaaa);\n" 497 " iter; ++iter) {\n" 498 "}"); 499 500 FormatStyle NoBinPacking = getLLVMStyle(); 501 NoBinPacking.BinPackParameters = false; 502 verifyFormat("for (int aaaaaaaaaaa = 1;\n" 503 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" 504 " aaaaaaaaaaaaaaaa,\n" 505 " aaaaaaaaaaaaaaaa,\n" 506 " aaaaaaaaaaaaaaaa);\n" 507 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 508 "}", 509 NoBinPacking); 510 verifyFormat( 511 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 512 " E = UnwrappedLines.end();\n" 513 " I != E;\n" 514 " ++I) {\n}", 515 NoBinPacking); 516 } 517 518 TEST_F(FormatTest, RangeBasedForLoops) { 519 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 520 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 521 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" 522 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); 523 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" 524 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 525 verifyFormat("for (aaaaaaaaa aaaaaaaaaaaaaaaaaaaaa :\n" 526 " aaaaaaaaaaaa.aaaaaaaaaaaa().aaaaaaaaa().a()) {\n}"); 527 } 528 529 TEST_F(FormatTest, ForEachLoops) { 530 verifyFormat("void f() {\n" 531 " foreach (Item *item, itemlist) {}\n" 532 " Q_FOREACH (Item *item, itemlist) {}\n" 533 " BOOST_FOREACH (Item *item, itemlist) {}\n" 534 " UNKNOWN_FORACH(Item * item, itemlist) {}\n" 535 "}"); 536 } 537 538 TEST_F(FormatTest, FormatsWhileLoop) { 539 verifyFormat("while (true) {\n}"); 540 verifyFormat("while (true)\n" 541 " f();"); 542 verifyFormat("while () {\n}"); 543 verifyFormat("while () {\n" 544 " f();\n" 545 "}"); 546 } 547 548 TEST_F(FormatTest, FormatsDoWhile) { 549 verifyFormat("do {\n" 550 " do_something();\n" 551 "} while (something());"); 552 verifyFormat("do\n" 553 " do_something();\n" 554 "while (something());"); 555 } 556 557 TEST_F(FormatTest, FormatsSwitchStatement) { 558 verifyFormat("switch (x) {\n" 559 "case 1:\n" 560 " f();\n" 561 " break;\n" 562 "case kFoo:\n" 563 "case ns::kBar:\n" 564 "case kBaz:\n" 565 " break;\n" 566 "default:\n" 567 " g();\n" 568 " break;\n" 569 "}"); 570 verifyFormat("switch (x) {\n" 571 "case 1: {\n" 572 " f();\n" 573 " break;\n" 574 "}\n" 575 "case 2: {\n" 576 " break;\n" 577 "}\n" 578 "}"); 579 verifyFormat("switch (x) {\n" 580 "case 1: {\n" 581 " f();\n" 582 " {\n" 583 " g();\n" 584 " h();\n" 585 " }\n" 586 " break;\n" 587 "}\n" 588 "}"); 589 verifyFormat("switch (x) {\n" 590 "case 1: {\n" 591 " f();\n" 592 " if (foo) {\n" 593 " g();\n" 594 " h();\n" 595 " }\n" 596 " break;\n" 597 "}\n" 598 "}"); 599 verifyFormat("switch (x) {\n" 600 "case 1: {\n" 601 " f();\n" 602 " g();\n" 603 "} break;\n" 604 "}"); 605 verifyFormat("switch (test)\n" 606 " ;"); 607 verifyFormat("switch (x) {\n" 608 "default: {\n" 609 " // Do nothing.\n" 610 "}\n" 611 "}"); 612 verifyFormat("switch (x) {\n" 613 "// comment\n" 614 "// if 1, do f()\n" 615 "case 1:\n" 616 " f();\n" 617 "}"); 618 verifyFormat("switch (x) {\n" 619 "case 1:\n" 620 " // Do amazing stuff\n" 621 " {\n" 622 " f();\n" 623 " g();\n" 624 " }\n" 625 " break;\n" 626 "}"); 627 verifyFormat("#define A \\\n" 628 " switch (x) { \\\n" 629 " case a: \\\n" 630 " foo = b; \\\n" 631 " }", getLLVMStyleWithColumns(20)); 632 verifyFormat("#define OPERATION_CASE(name) \\\n" 633 " case OP_name: \\\n" 634 " return operations::Operation##name\n", 635 getLLVMStyleWithColumns(40)); 636 637 verifyGoogleFormat("switch (x) {\n" 638 " case 1:\n" 639 " f();\n" 640 " break;\n" 641 " case kFoo:\n" 642 " case ns::kBar:\n" 643 " case kBaz:\n" 644 " break;\n" 645 " default:\n" 646 " g();\n" 647 " break;\n" 648 "}"); 649 verifyGoogleFormat("switch (x) {\n" 650 " case 1: {\n" 651 " f();\n" 652 " break;\n" 653 " }\n" 654 "}"); 655 verifyGoogleFormat("switch (test)\n" 656 " ;"); 657 658 verifyGoogleFormat("#define OPERATION_CASE(name) \\\n" 659 " case OP_name: \\\n" 660 " return operations::Operation##name\n"); 661 verifyGoogleFormat("Operation codeToOperation(OperationCode OpCode) {\n" 662 " // Get the correction operation class.\n" 663 " switch (OpCode) {\n" 664 " CASE(Add);\n" 665 " CASE(Subtract);\n" 666 " default:\n" 667 " return operations::Unknown;\n" 668 " }\n" 669 "#undef OPERATION_CASE\n" 670 "}"); 671 verifyFormat("DEBUG({\n" 672 " switch (x) {\n" 673 " case A:\n" 674 " f();\n" 675 " break;\n" 676 " // On B:\n" 677 " case B:\n" 678 " g();\n" 679 " break;\n" 680 " }\n" 681 "});"); 682 verifyFormat("switch (a) {\n" 683 "case (b):\n" 684 " return;\n" 685 "}"); 686 687 verifyFormat("switch (a) {\n" 688 "case some_namespace::\n" 689 " some_constant:\n" 690 " return;\n" 691 "}", 692 getLLVMStyleWithColumns(34)); 693 } 694 695 TEST_F(FormatTest, CaseRanges) { 696 verifyFormat("switch (x) {\n" 697 "case 'A' ... 'Z':\n" 698 "case 1 ... 5:\n" 699 " break;\n" 700 "}"); 701 } 702 703 TEST_F(FormatTest, FormatsLabels) { 704 verifyFormat("void f() {\n" 705 " some_code();\n" 706 "test_label:\n" 707 " some_other_code();\n" 708 " {\n" 709 " some_more_code();\n" 710 " another_label:\n" 711 " some_more_code();\n" 712 " }\n" 713 "}"); 714 verifyFormat("some_code();\n" 715 "test_label:\n" 716 "some_other_code();"); 717 } 718 719 //===----------------------------------------------------------------------===// 720 // Tests for comments. 721 //===----------------------------------------------------------------------===// 722 723 TEST_F(FormatTest, UnderstandsSingleLineComments) { 724 verifyFormat("//* */"); 725 verifyFormat("// line 1\n" 726 "// line 2\n" 727 "void f() {}\n"); 728 729 verifyFormat("void f() {\n" 730 " // Doesn't do anything\n" 731 "}"); 732 verifyFormat("SomeObject\n" 733 " // Calling someFunction on SomeObject\n" 734 " .someFunction();"); 735 verifyFormat("auto result = SomeObject\n" 736 " // Calling someFunction on SomeObject\n" 737 " .someFunction();"); 738 verifyFormat("void f(int i, // some comment (probably for i)\n" 739 " int j, // some comment (probably for j)\n" 740 " int k); // some comment (probably for k)"); 741 verifyFormat("void f(int i,\n" 742 " // some comment (probably for j)\n" 743 " int j,\n" 744 " // some comment (probably for k)\n" 745 " int k);"); 746 747 verifyFormat("int i // This is a fancy variable\n" 748 " = 5; // with nicely aligned comment."); 749 750 verifyFormat("// Leading comment.\n" 751 "int a; // Trailing comment."); 752 verifyFormat("int a; // Trailing comment\n" 753 " // on 2\n" 754 " // or 3 lines.\n" 755 "int b;"); 756 verifyFormat("int a; // Trailing comment\n" 757 "\n" 758 "// Leading comment.\n" 759 "int b;"); 760 verifyFormat("int a; // Comment.\n" 761 " // More details.\n" 762 "int bbbb; // Another comment."); 763 verifyFormat( 764 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 765 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" 766 "int cccccccccccccccccccccccccccccc; // comment\n" 767 "int ddd; // looooooooooooooooooooooooong comment\n" 768 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 769 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" 770 "int ccccccccccccccccccc; // comment"); 771 772 verifyFormat("#include \"a\" // comment\n" 773 "#include \"a/b/c\" // comment"); 774 verifyFormat("#include <a> // comment\n" 775 "#include <a/b/c> // comment"); 776 EXPECT_EQ("#include \"a\" // comment\n" 777 "#include \"a/b/c\" // comment", 778 format("#include \\\n" 779 " \"a\" // comment\n" 780 "#include \"a/b/c\" // comment")); 781 782 verifyFormat("enum E {\n" 783 " // comment\n" 784 " VAL_A, // comment\n" 785 " VAL_B\n" 786 "};"); 787 788 verifyFormat( 789 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 790 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); 791 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 792 " // Comment inside a statement.\n" 793 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 794 verifyFormat( 795 "bool aaaaaaaaaaaaa = // comment\n" 796 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 797 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 798 799 verifyFormat("int aaaa; // aaaaa\n" 800 "int aa; // aaaaaaa", 801 getLLVMStyleWithColumns(20)); 802 803 EXPECT_EQ("void f() { // This does something ..\n" 804 "}\n" 805 "int a; // This is unrelated", 806 format("void f() { // This does something ..\n" 807 " }\n" 808 "int a; // This is unrelated")); 809 EXPECT_EQ("class C {\n" 810 " void f() { // This does something ..\n" 811 " } // awesome..\n" 812 "\n" 813 " int a; // This is unrelated\n" 814 "};", 815 format("class C{void f() { // This does something ..\n" 816 " } // awesome..\n" 817 " \n" 818 "int a; // This is unrelated\n" 819 "};")); 820 821 EXPECT_EQ("int i; // single line trailing comment", 822 format("int i;\\\n// single line trailing comment")); 823 824 verifyGoogleFormat("int a; // Trailing comment."); 825 826 verifyFormat("someFunction(anotherFunction( // Force break.\n" 827 " parameter));"); 828 829 verifyGoogleFormat("#endif // HEADER_GUARD"); 830 831 verifyFormat("const char *test[] = {\n" 832 " // A\n" 833 " \"aaaa\",\n" 834 " // B\n" 835 " \"aaaaa\"};"); 836 verifyGoogleFormat( 837 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 838 " aaaaaaaaaaaaaaaaaaaaaa); // 81_cols_with_this_comment"); 839 EXPECT_EQ("D(a, {\n" 840 " // test\n" 841 " int a;\n" 842 "});", 843 format("D(a, {\n" 844 "// test\n" 845 "int a;\n" 846 "});")); 847 848 EXPECT_EQ("lineWith(); // comment\n" 849 "// at start\n" 850 "otherLine();", 851 format("lineWith(); // comment\n" 852 "// at start\n" 853 "otherLine();")); 854 EXPECT_EQ("lineWith(); // comment\n" 855 " // at start\n" 856 "otherLine();", 857 format("lineWith(); // comment\n" 858 " // at start\n" 859 "otherLine();")); 860 861 EXPECT_EQ("lineWith(); // comment\n" 862 "// at start\n" 863 "otherLine(); // comment", 864 format("lineWith(); // comment\n" 865 "// at start\n" 866 "otherLine(); // comment")); 867 EXPECT_EQ("lineWith();\n" 868 "// at start\n" 869 "otherLine(); // comment", 870 format("lineWith();\n" 871 " // at start\n" 872 "otherLine(); // comment")); 873 EXPECT_EQ("// first\n" 874 "// at start\n" 875 "otherLine(); // comment", 876 format("// first\n" 877 " // at start\n" 878 "otherLine(); // comment")); 879 EXPECT_EQ("f();\n" 880 "// first\n" 881 "// at start\n" 882 "otherLine(); // comment", 883 format("f();\n" 884 "// first\n" 885 " // at start\n" 886 "otherLine(); // comment")); 887 verifyFormat("f(); // comment\n" 888 "// first\n" 889 "// at start\n" 890 "otherLine();"); 891 EXPECT_EQ("f(); // comment\n" 892 "// first\n" 893 "// at start\n" 894 "otherLine();", 895 format("f(); // comment\n" 896 "// first\n" 897 " // at start\n" 898 "otherLine();")); 899 EXPECT_EQ("f(); // comment\n" 900 " // first\n" 901 "// at start\n" 902 "otherLine();", 903 format("f(); // comment\n" 904 " // first\n" 905 "// at start\n" 906 "otherLine();")); 907 908 verifyFormat( 909 "#define A \\\n" 910 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 911 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 912 getLLVMStyleWithColumns(60)); 913 verifyFormat( 914 "#define A \\\n" 915 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 916 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 917 getLLVMStyleWithColumns(61)); 918 919 verifyFormat("if ( // This is some comment\n" 920 " x + 3) {\n" 921 "}"); 922 EXPECT_EQ("if ( // This is some comment\n" 923 " // spanning two lines\n" 924 " x + 3) {\n" 925 "}", 926 format("if( // This is some comment\n" 927 " // spanning two lines\n" 928 " x + 3) {\n" 929 "}")); 930 } 931 932 TEST_F(FormatTest, KeepsParameterWithTrailingCommentsOnTheirOwnLine) { 933 EXPECT_EQ("SomeFunction(a,\n" 934 " b, // comment\n" 935 " c);", 936 format("SomeFunction(a,\n" 937 " b, // comment\n" 938 " c);")); 939 EXPECT_EQ("SomeFunction(a, b,\n" 940 " // comment\n" 941 " c);", 942 format("SomeFunction(a,\n" 943 " b,\n" 944 " // comment\n" 945 " c);")); 946 EXPECT_EQ("SomeFunction(a, b, // comment (unclear relation)\n" 947 " c);", 948 format("SomeFunction(a, b, // comment (unclear relation)\n" 949 " c);")); 950 EXPECT_EQ("SomeFunction(a, // comment\n" 951 " b,\n" 952 " c); // comment", 953 format("SomeFunction(a, // comment\n" 954 " b,\n" 955 " c); // comment")); 956 } 957 958 TEST_F(FormatTest, CanFormatCommentsLocally) { 959 EXPECT_EQ("int a; // comment\n" 960 "int b; // comment", 961 format("int a; // comment\n" 962 "int b; // comment", 963 0, 0, getLLVMStyle())); 964 EXPECT_EQ("int a; // comment\n" 965 " // line 2\n" 966 "int b;", 967 format("int a; // comment\n" 968 " // line 2\n" 969 "int b;", 970 28, 0, getLLVMStyle())); 971 EXPECT_EQ("int aaaaaa; // comment\n" 972 "int b;\n" 973 "int c; // unrelated comment", 974 format("int aaaaaa; // comment\n" 975 "int b;\n" 976 "int c; // unrelated comment", 977 31, 0, getLLVMStyle())); 978 979 EXPECT_EQ("int a; // This\n" 980 " // is\n" 981 " // a", 982 format("int a; // This\n" 983 " // is\n" 984 " // a", 985 0, 0, getLLVMStyle())); 986 EXPECT_EQ("int a; // This\n" 987 " // is\n" 988 " // a\n" 989 "// This is b\n" 990 "int b;", 991 format("int a; // This\n" 992 " // is\n" 993 " // a\n" 994 "// This is b\n" 995 "int b;", 996 0, 0, getLLVMStyle())); 997 EXPECT_EQ("int a; // This\n" 998 " // is\n" 999 " // a\n" 1000 "\n" 1001 " // This is unrelated", 1002 format("int a; // This\n" 1003 " // is\n" 1004 " // a\n" 1005 "\n" 1006 " // This is unrelated", 1007 0, 0, getLLVMStyle())); 1008 EXPECT_EQ("int a;\n" 1009 "// This is\n" 1010 "// not formatted. ", 1011 format("int a;\n" 1012 "// This is\n" 1013 "// not formatted. ", 1014 0, 0, getLLVMStyle())); 1015 } 1016 1017 TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) { 1018 EXPECT_EQ("// comment", format("// comment ")); 1019 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", 1020 format("int aaaaaaa, bbbbbbb; // comment ", 1021 getLLVMStyleWithColumns(33))); 1022 EXPECT_EQ("// comment\\\n", format("// comment\\\n \t \v \f ")); 1023 EXPECT_EQ("// comment \\\n", format("// comment \\\n \t \v \f ")); 1024 } 1025 1026 TEST_F(FormatTest, UnderstandsBlockComments) { 1027 verifyFormat("f(/*noSpaceAfterParameterNamingComment=*/true);"); 1028 verifyFormat("void f() { g(/*aaa=*/x, /*bbb=*/!y); }"); 1029 EXPECT_EQ("f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" 1030 " bbbbbbbbbbbbbbbbbbbbbbbbb);", 1031 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n" 1032 "/* Trailing comment for aa... */\n" 1033 " bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1034 EXPECT_EQ( 1035 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 1036 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", 1037 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" 1038 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1039 EXPECT_EQ( 1040 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1041 " aaaaaaaaaaaaaaaaaa,\n" 1042 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1043 "}", 1044 format("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1045 " aaaaaaaaaaaaaaaaaa ,\n" 1046 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1047 "}")); 1048 1049 FormatStyle NoBinPacking = getLLVMStyle(); 1050 NoBinPacking.BinPackParameters = false; 1051 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" 1052 " /* parameter 2 */ aaaaaa,\n" 1053 " /* parameter 3 */ aaaaaa,\n" 1054 " /* parameter 4 */ aaaaaa);", 1055 NoBinPacking); 1056 1057 // Aligning block comments in macros. 1058 verifyGoogleFormat("#define A \\\n" 1059 " int i; /*a*/ \\\n" 1060 " int jjj; /*b*/"); 1061 } 1062 1063 TEST_F(FormatTest, AlignsBlockComments) { 1064 EXPECT_EQ("/*\n" 1065 " * Really multi-line\n" 1066 " * comment.\n" 1067 " */\n" 1068 "void f() {}", 1069 format(" /*\n" 1070 " * Really multi-line\n" 1071 " * comment.\n" 1072 " */\n" 1073 " void f() {}")); 1074 EXPECT_EQ("class C {\n" 1075 " /*\n" 1076 " * Another multi-line\n" 1077 " * comment.\n" 1078 " */\n" 1079 " void f() {}\n" 1080 "};", 1081 format("class C {\n" 1082 "/*\n" 1083 " * Another multi-line\n" 1084 " * comment.\n" 1085 " */\n" 1086 "void f() {}\n" 1087 "};")); 1088 EXPECT_EQ("/*\n" 1089 " 1. This is a comment with non-trivial formatting.\n" 1090 " 1.1. We have to indent/outdent all lines equally\n" 1091 " 1.1.1. to keep the formatting.\n" 1092 " */", 1093 format(" /*\n" 1094 " 1. This is a comment with non-trivial formatting.\n" 1095 " 1.1. We have to indent/outdent all lines equally\n" 1096 " 1.1.1. to keep the formatting.\n" 1097 " */")); 1098 EXPECT_EQ("/*\n" 1099 "Don't try to outdent if there's not enough indentation.\n" 1100 "*/", 1101 format(" /*\n" 1102 " Don't try to outdent if there's not enough indentation.\n" 1103 " */")); 1104 1105 EXPECT_EQ("int i; /* Comment with empty...\n" 1106 " *\n" 1107 " * line. */", 1108 format("int i; /* Comment with empty...\n" 1109 " *\n" 1110 " * line. */")); 1111 EXPECT_EQ("int foobar = 0; /* comment */\n" 1112 "int bar = 0; /* multiline\n" 1113 " comment 1 */\n" 1114 "int baz = 0; /* multiline\n" 1115 " comment 2 */\n" 1116 "int bzz = 0; /* multiline\n" 1117 " comment 3 */", 1118 format("int foobar = 0; /* comment */\n" 1119 "int bar = 0; /* multiline\n" 1120 " comment 1 */\n" 1121 "int baz = 0; /* multiline\n" 1122 " comment 2 */\n" 1123 "int bzz = 0; /* multiline\n" 1124 " comment 3 */")); 1125 EXPECT_EQ("int foobar = 0; /* comment */\n" 1126 "int bar = 0; /* multiline\n" 1127 " comment */\n" 1128 "int baz = 0; /* multiline\n" 1129 "comment */", 1130 format("int foobar = 0; /* comment */\n" 1131 "int bar = 0; /* multiline\n" 1132 "comment */\n" 1133 "int baz = 0; /* multiline\n" 1134 "comment */")); 1135 } 1136 1137 TEST_F(FormatTest, CorrectlyHandlesLengthOfBlockComments) { 1138 EXPECT_EQ("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1139 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */", 1140 format("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1141 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */")); 1142 EXPECT_EQ( 1143 "void ffffffffffff(\n" 1144 " int aaaaaaaa, int bbbbbbbb,\n" 1145 " int cccccccccccc) { /*\n" 1146 " aaaaaaaaaa\n" 1147 " aaaaaaaaaaaaa\n" 1148 " bbbbbbbbbbbbbb\n" 1149 " bbbbbbbbbb\n" 1150 " */\n" 1151 "}", 1152 format("void ffffffffffff(int aaaaaaaa, int bbbbbbbb, int cccccccccccc)\n" 1153 "{ /*\n" 1154 " aaaaaaaaaa aaaaaaaaaaaaa\n" 1155 " bbbbbbbbbbbbbb bbbbbbbbbb\n" 1156 " */\n" 1157 "}", 1158 getLLVMStyleWithColumns(40))); 1159 } 1160 1161 TEST_F(FormatTest, DontBreakNonTrailingBlockComments) { 1162 EXPECT_EQ("void\n" 1163 "ffffffffff(int aaaaa /* test */);", 1164 format("void ffffffffff(int aaaaa /* test */);", 1165 getLLVMStyleWithColumns(35))); 1166 } 1167 1168 TEST_F(FormatTest, SplitsLongCxxComments) { 1169 EXPECT_EQ("// A comment that\n" 1170 "// doesn't fit on\n" 1171 "// one line", 1172 format("// A comment that doesn't fit on one line", 1173 getLLVMStyleWithColumns(20))); 1174 EXPECT_EQ("// a b c d\n" 1175 "// e f g\n" 1176 "// h i j k", 1177 format("// a b c d e f g h i j k", 1178 getLLVMStyleWithColumns(10))); 1179 EXPECT_EQ("// a b c d\n" 1180 "// e f g\n" 1181 "// h i j k", 1182 format("\\\n// a b c d e f g h i j k", 1183 getLLVMStyleWithColumns(10))); 1184 EXPECT_EQ("if (true) // A comment that\n" 1185 " // doesn't fit on\n" 1186 " // one line", 1187 format("if (true) // A comment that doesn't fit on one line ", 1188 getLLVMStyleWithColumns(30))); 1189 EXPECT_EQ("// Don't_touch_leading_whitespace", 1190 format("// Don't_touch_leading_whitespace", 1191 getLLVMStyleWithColumns(20))); 1192 EXPECT_EQ("// Add leading\n" 1193 "// whitespace", 1194 format("//Add leading whitespace", getLLVMStyleWithColumns(20))); 1195 EXPECT_EQ("// whitespace", format("//whitespace", getLLVMStyle())); 1196 EXPECT_EQ("// Even if it makes the line exceed the column\n" 1197 "// limit", 1198 format("//Even if it makes the line exceed the column limit", 1199 getLLVMStyleWithColumns(51))); 1200 EXPECT_EQ("//--But not here", format("//--But not here", getLLVMStyle())); 1201 1202 EXPECT_EQ("// aa bb cc dd", 1203 format("// aa bb cc dd ", 1204 getLLVMStyleWithColumns(15))); 1205 1206 EXPECT_EQ("// A comment before\n" 1207 "// a macro\n" 1208 "// definition\n" 1209 "#define a b", 1210 format("// A comment before a macro definition\n" 1211 "#define a b", 1212 getLLVMStyleWithColumns(20))); 1213 EXPECT_EQ("void\n" 1214 "ffffff(int aaaaaaaaa, // wwww\n" 1215 " int bbbbbbbbbb, // xxxxxxx\n" 1216 " // yyyyyyyyyy\n" 1217 " int c, int d, int e) {}", 1218 format("void ffffff(\n" 1219 " int aaaaaaaaa, // wwww\n" 1220 " int bbbbbbbbbb, // xxxxxxx yyyyyyyyyy\n" 1221 " int c, int d, int e) {}", 1222 getLLVMStyleWithColumns(40))); 1223 EXPECT_EQ("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1224 format("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1225 getLLVMStyleWithColumns(20))); 1226 EXPECT_EQ( 1227 "#define XXX // a b c d\n" 1228 " // e f g h", 1229 format("#define XXX // a b c d e f g h", getLLVMStyleWithColumns(22))); 1230 EXPECT_EQ( 1231 "#define XXX // q w e r\n" 1232 " // t y u i", 1233 format("#define XXX //q w e r t y u i", getLLVMStyleWithColumns(22))); 1234 } 1235 1236 TEST_F(FormatTest, PreservesHangingIndentInCxxComments) { 1237 EXPECT_EQ("// A comment\n" 1238 "// that doesn't\n" 1239 "// fit on one\n" 1240 "// line", 1241 format("// A comment that doesn't fit on one line", 1242 getLLVMStyleWithColumns(20))); 1243 EXPECT_EQ("/// A comment\n" 1244 "/// that doesn't\n" 1245 "/// fit on one\n" 1246 "/// line", 1247 format("/// A comment that doesn't fit on one line", 1248 getLLVMStyleWithColumns(20))); 1249 } 1250 1251 TEST_F(FormatTest, DontSplitLineCommentsWithEscapedNewlines) { 1252 EXPECT_EQ("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1253 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1254 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1255 format("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1256 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1257 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")); 1258 EXPECT_EQ("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1259 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1260 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1261 format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1262 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1263 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1264 getLLVMStyleWithColumns(50))); 1265 // FIXME: One day we might want to implement adjustment of leading whitespace 1266 // of the consecutive lines in this kind of comment: 1267 EXPECT_EQ("double\n" 1268 " a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1269 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1270 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1271 format("double a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1272 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1273 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1274 getLLVMStyleWithColumns(49))); 1275 } 1276 1277 TEST_F(FormatTest, DontSplitLineCommentsWithPragmas) { 1278 FormatStyle Pragmas = getLLVMStyleWithColumns(30); 1279 Pragmas.CommentPragmas = "^ IWYU pragma:"; 1280 EXPECT_EQ( 1281 "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", 1282 format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", Pragmas)); 1283 EXPECT_EQ( 1284 "/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", 1285 format("/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", Pragmas)); 1286 } 1287 1288 TEST_F(FormatTest, PriorityOfCommentBreaking) { 1289 EXPECT_EQ("if (xxx ==\n" 1290 " yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1291 " zzz)\n" 1292 " q();", 1293 format("if (xxx == yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1294 " zzz) q();", 1295 getLLVMStyleWithColumns(40))); 1296 EXPECT_EQ("if (xxxxxxxxxx ==\n" 1297 " yyy && // aaaaaa bbbbbbbb cccc\n" 1298 " zzz)\n" 1299 " q();", 1300 format("if (xxxxxxxxxx == yyy && // aaaaaa bbbbbbbb cccc\n" 1301 " zzz) q();", 1302 getLLVMStyleWithColumns(40))); 1303 EXPECT_EQ("if (xxxxxxxxxx &&\n" 1304 " yyy || // aaaaaa bbbbbbbb cccc\n" 1305 " zzz)\n" 1306 " q();", 1307 format("if (xxxxxxxxxx && yyy || // aaaaaa bbbbbbbb cccc\n" 1308 " zzz) q();", 1309 getLLVMStyleWithColumns(40))); 1310 EXPECT_EQ("fffffffff(\n" 1311 " &xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1312 " zzz);", 1313 format("fffffffff(&xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1314 " zzz);", 1315 getLLVMStyleWithColumns(40))); 1316 } 1317 1318 TEST_F(FormatTest, MultiLineCommentsInDefines) { 1319 EXPECT_EQ("#define A(x) /* \\\n" 1320 " a comment \\\n" 1321 " inside */ \\\n" 1322 " f();", 1323 format("#define A(x) /* \\\n" 1324 " a comment \\\n" 1325 " inside */ \\\n" 1326 " f();", 1327 getLLVMStyleWithColumns(17))); 1328 EXPECT_EQ("#define A( \\\n" 1329 " x) /* \\\n" 1330 " a comment \\\n" 1331 " inside */ \\\n" 1332 " f();", 1333 format("#define A( \\\n" 1334 " x) /* \\\n" 1335 " a comment \\\n" 1336 " inside */ \\\n" 1337 " f();", 1338 getLLVMStyleWithColumns(17))); 1339 } 1340 1341 TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) { 1342 EXPECT_EQ("namespace {}\n// Test\n#define A", 1343 format("namespace {}\n // Test\n#define A")); 1344 EXPECT_EQ("namespace {}\n/* Test */\n#define A", 1345 format("namespace {}\n /* Test */\n#define A")); 1346 EXPECT_EQ("namespace {}\n/* Test */ #define A", 1347 format("namespace {}\n /* Test */ #define A")); 1348 } 1349 1350 TEST_F(FormatTest, SplitsLongLinesInComments) { 1351 EXPECT_EQ("/* This is a long\n" 1352 " * comment that\n" 1353 " * doesn't\n" 1354 " * fit on one line.\n" 1355 " */", 1356 format("/* " 1357 "This is a long " 1358 "comment that " 1359 "doesn't " 1360 "fit on one line. */", 1361 getLLVMStyleWithColumns(20))); 1362 EXPECT_EQ("/* a b c d\n" 1363 " * e f g\n" 1364 " * h i j k\n" 1365 " */", 1366 format("/* a b c d e f g h i j k */", 1367 getLLVMStyleWithColumns(10))); 1368 EXPECT_EQ("/* a b c d\n" 1369 " * e f g\n" 1370 " * h i j k\n" 1371 " */", 1372 format("\\\n/* a b c d e f g h i j k */", 1373 getLLVMStyleWithColumns(10))); 1374 EXPECT_EQ("/*\n" 1375 "This is a long\n" 1376 "comment that doesn't\n" 1377 "fit on one line.\n" 1378 "*/", 1379 format("/*\n" 1380 "This is a long " 1381 "comment that doesn't " 1382 "fit on one line. \n" 1383 "*/", getLLVMStyleWithColumns(20))); 1384 EXPECT_EQ("/*\n" 1385 " * This is a long\n" 1386 " * comment that\n" 1387 " * doesn't fit on\n" 1388 " * one line.\n" 1389 " */", 1390 format("/* \n" 1391 " * This is a long " 1392 " comment that " 1393 " doesn't fit on " 1394 " one line. \n" 1395 " */", getLLVMStyleWithColumns(20))); 1396 EXPECT_EQ("/*\n" 1397 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" 1398 " * so_it_should_be_broken\n" 1399 " * wherever_a_space_occurs\n" 1400 " */", 1401 format("/*\n" 1402 " * This_is_a_comment_with_words_that_dont_fit_on_one_line " 1403 " so_it_should_be_broken " 1404 " wherever_a_space_occurs \n" 1405 " */", 1406 getLLVMStyleWithColumns(20))); 1407 EXPECT_EQ("/*\n" 1408 " * This_comment_can_not_be_broken_into_lines\n" 1409 " */", 1410 format("/*\n" 1411 " * This_comment_can_not_be_broken_into_lines\n" 1412 " */", 1413 getLLVMStyleWithColumns(20))); 1414 EXPECT_EQ("{\n" 1415 " /*\n" 1416 " This is another\n" 1417 " long comment that\n" 1418 " doesn't fit on one\n" 1419 " line 1234567890\n" 1420 " */\n" 1421 "}", 1422 format("{\n" 1423 "/*\n" 1424 "This is another " 1425 " long comment that " 1426 " doesn't fit on one" 1427 " line 1234567890\n" 1428 "*/\n" 1429 "}", getLLVMStyleWithColumns(20))); 1430 EXPECT_EQ("{\n" 1431 " /*\n" 1432 " * This i s\n" 1433 " * another comment\n" 1434 " * t hat doesn' t\n" 1435 " * fit on one l i\n" 1436 " * n e\n" 1437 " */\n" 1438 "}", 1439 format("{\n" 1440 "/*\n" 1441 " * This i s" 1442 " another comment" 1443 " t hat doesn' t" 1444 " fit on one l i" 1445 " n e\n" 1446 " */\n" 1447 "}", getLLVMStyleWithColumns(20))); 1448 EXPECT_EQ("/*\n" 1449 " * This is a long\n" 1450 " * comment that\n" 1451 " * doesn't fit on\n" 1452 " * one line\n" 1453 " */", 1454 format(" /*\n" 1455 " * This is a long comment that doesn't fit on one line\n" 1456 " */", getLLVMStyleWithColumns(20))); 1457 EXPECT_EQ("{\n" 1458 " if (something) /* This is a\n" 1459 " long\n" 1460 " comment */\n" 1461 " ;\n" 1462 "}", 1463 format("{\n" 1464 " if (something) /* This is a long comment */\n" 1465 " ;\n" 1466 "}", 1467 getLLVMStyleWithColumns(30))); 1468 1469 EXPECT_EQ("/* A comment before\n" 1470 " * a macro\n" 1471 " * definition */\n" 1472 "#define a b", 1473 format("/* A comment before a macro definition */\n" 1474 "#define a b", 1475 getLLVMStyleWithColumns(20))); 1476 1477 EXPECT_EQ("/* some comment\n" 1478 " * a comment\n" 1479 "* that we break\n" 1480 " * another comment\n" 1481 "* we have to break\n" 1482 "* a left comment\n" 1483 " */", 1484 format(" /* some comment\n" 1485 " * a comment that we break\n" 1486 " * another comment we have to break\n" 1487 "* a left comment\n" 1488 " */", 1489 getLLVMStyleWithColumns(20))); 1490 1491 EXPECT_EQ("/*\n" 1492 "\n" 1493 "\n" 1494 " */\n", 1495 format(" /* \n" 1496 " \n" 1497 " \n" 1498 " */\n")); 1499 1500 EXPECT_EQ("/* a a */", 1501 format("/* a a */", getLLVMStyleWithColumns(15))); 1502 EXPECT_EQ("/* a a bc */", 1503 format("/* a a bc */", getLLVMStyleWithColumns(15))); 1504 EXPECT_EQ("/* aaa aaa\n" 1505 " * aaaaa */", 1506 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1507 EXPECT_EQ("/* aaa aaa\n" 1508 " * aaaaa */", 1509 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1510 } 1511 1512 TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) { 1513 EXPECT_EQ("#define X \\\n" 1514 " /* \\\n" 1515 " Test \\\n" 1516 " Macro comment \\\n" 1517 " with a long \\\n" 1518 " line \\\n" 1519 " */ \\\n" 1520 " A + B", 1521 format("#define X \\\n" 1522 " /*\n" 1523 " Test\n" 1524 " Macro comment with a long line\n" 1525 " */ \\\n" 1526 " A + B", 1527 getLLVMStyleWithColumns(20))); 1528 EXPECT_EQ("#define X \\\n" 1529 " /* Macro comment \\\n" 1530 " with a long \\\n" 1531 " line */ \\\n" 1532 " A + B", 1533 format("#define X \\\n" 1534 " /* Macro comment with a long\n" 1535 " line */ \\\n" 1536 " A + B", 1537 getLLVMStyleWithColumns(20))); 1538 EXPECT_EQ("#define X \\\n" 1539 " /* Macro comment \\\n" 1540 " * with a long \\\n" 1541 " * line */ \\\n" 1542 " A + B", 1543 format("#define X \\\n" 1544 " /* Macro comment with a long line */ \\\n" 1545 " A + B", 1546 getLLVMStyleWithColumns(20))); 1547 } 1548 1549 TEST_F(FormatTest, CommentsInStaticInitializers) { 1550 EXPECT_EQ( 1551 "static SomeType type = {aaaaaaaaaaaaaaaaaaaa, /* comment */\n" 1552 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" 1553 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" 1554 " aaaaaaaaaaaaaaaaaaaa, // comment\n" 1555 " aaaaaaaaaaaaaaaaaaaa};", 1556 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" 1557 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" 1558 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" 1559 " aaaaaaaaaaaaaaaaaaaa , // comment\n" 1560 " aaaaaaaaaaaaaaaaaaaa };")); 1561 verifyFormat("static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1562 " bbbbbbbbbbb, ccccccccccc};"); 1563 verifyFormat("static SomeType type = {aaaaaaaaaaa,\n" 1564 " // comment for bb....\n" 1565 " bbbbbbbbbbb, ccccccccccc};"); 1566 verifyGoogleFormat( 1567 "static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1568 " bbbbbbbbbbb, ccccccccccc};"); 1569 verifyGoogleFormat("static SomeType type = {aaaaaaaaaaa,\n" 1570 " // comment for bb....\n" 1571 " bbbbbbbbbbb, ccccccccccc};"); 1572 1573 verifyFormat("S s = {{a, b, c}, // Group #1\n" 1574 " {d, e, f}, // Group #2\n" 1575 " {g, h, i}}; // Group #3"); 1576 verifyFormat("S s = {{// Group #1\n" 1577 " a, b, c},\n" 1578 " {// Group #2\n" 1579 " d, e, f},\n" 1580 " {// Group #3\n" 1581 " g, h, i}};"); 1582 1583 EXPECT_EQ("S s = {\n" 1584 " // Some comment\n" 1585 " a,\n" 1586 "\n" 1587 " // Comment after empty line\n" 1588 " b}", 1589 format("S s = {\n" 1590 " // Some comment\n" 1591 " a,\n" 1592 " \n" 1593 " // Comment after empty line\n" 1594 " b\n" 1595 "}")); 1596 EXPECT_EQ("S s = {\n" 1597 " /* Some comment */\n" 1598 " a,\n" 1599 "\n" 1600 " /* Comment after empty line */\n" 1601 " b}", 1602 format("S s = {\n" 1603 " /* Some comment */\n" 1604 " a,\n" 1605 " \n" 1606 " /* Comment after empty line */\n" 1607 " b\n" 1608 "}")); 1609 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" 1610 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1611 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1612 " 0x00, 0x00, 0x00, 0x00}; // comment\n"); 1613 } 1614 1615 TEST_F(FormatTest, IgnoresIf0Contents) { 1616 EXPECT_EQ("#if 0\n" 1617 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1618 "#endif\n" 1619 "void f() {}", 1620 format("#if 0\n" 1621 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1622 "#endif\n" 1623 "void f( ) { }")); 1624 EXPECT_EQ("#if false\n" 1625 "void f( ) { }\n" 1626 "#endif\n" 1627 "void g() {}\n", 1628 format("#if false\n" 1629 "void f( ) { }\n" 1630 "#endif\n" 1631 "void g( ) { }\n")); 1632 EXPECT_EQ("enum E {\n" 1633 " One,\n" 1634 " Two,\n" 1635 "#if 0\n" 1636 "Three,\n" 1637 " Four,\n" 1638 "#endif\n" 1639 " Five\n" 1640 "};", 1641 format("enum E {\n" 1642 " One,Two,\n" 1643 "#if 0\n" 1644 "Three,\n" 1645 " Four,\n" 1646 "#endif\n" 1647 " Five};")); 1648 EXPECT_EQ("enum F {\n" 1649 " One,\n" 1650 "#if 1\n" 1651 " Two,\n" 1652 "#if 0\n" 1653 "Three,\n" 1654 " Four,\n" 1655 "#endif\n" 1656 " Five\n" 1657 "#endif\n" 1658 "};", 1659 format("enum F {\n" 1660 "One,\n" 1661 "#if 1\n" 1662 "Two,\n" 1663 "#if 0\n" 1664 "Three,\n" 1665 " Four,\n" 1666 "#endif\n" 1667 "Five\n" 1668 "#endif\n" 1669 "};")); 1670 EXPECT_EQ("enum G {\n" 1671 " One,\n" 1672 "#if 0\n" 1673 "Two,\n" 1674 "#else\n" 1675 " Three,\n" 1676 "#endif\n" 1677 " Four\n" 1678 "};", 1679 format("enum G {\n" 1680 "One,\n" 1681 "#if 0\n" 1682 "Two,\n" 1683 "#else\n" 1684 "Three,\n" 1685 "#endif\n" 1686 "Four\n" 1687 "};")); 1688 EXPECT_EQ("enum H {\n" 1689 " One,\n" 1690 "#if 0\n" 1691 "#ifdef Q\n" 1692 "Two,\n" 1693 "#else\n" 1694 "Three,\n" 1695 "#endif\n" 1696 "#endif\n" 1697 " Four\n" 1698 "};", 1699 format("enum H {\n" 1700 "One,\n" 1701 "#if 0\n" 1702 "#ifdef Q\n" 1703 "Two,\n" 1704 "#else\n" 1705 "Three,\n" 1706 "#endif\n" 1707 "#endif\n" 1708 "Four\n" 1709 "};")); 1710 EXPECT_EQ("enum I {\n" 1711 " One,\n" 1712 "#if /* test */ 0 || 1\n" 1713 "Two,\n" 1714 "Three,\n" 1715 "#endif\n" 1716 " Four\n" 1717 "};", 1718 format("enum I {\n" 1719 "One,\n" 1720 "#if /* test */ 0 || 1\n" 1721 "Two,\n" 1722 "Three,\n" 1723 "#endif\n" 1724 "Four\n" 1725 "};")); 1726 EXPECT_EQ("enum J {\n" 1727 " One,\n" 1728 "#if 0\n" 1729 "#if 0\n" 1730 "Two,\n" 1731 "#else\n" 1732 "Three,\n" 1733 "#endif\n" 1734 "Four,\n" 1735 "#endif\n" 1736 " Five\n" 1737 "};", 1738 format("enum J {\n" 1739 "One,\n" 1740 "#if 0\n" 1741 "#if 0\n" 1742 "Two,\n" 1743 "#else\n" 1744 "Three,\n" 1745 "#endif\n" 1746 "Four,\n" 1747 "#endif\n" 1748 "Five\n" 1749 "};")); 1750 1751 } 1752 1753 //===----------------------------------------------------------------------===// 1754 // Tests for classes, namespaces, etc. 1755 //===----------------------------------------------------------------------===// 1756 1757 TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { 1758 verifyFormat("class A {};"); 1759 } 1760 1761 TEST_F(FormatTest, UnderstandsAccessSpecifiers) { 1762 verifyFormat("class A {\n" 1763 "public:\n" 1764 "public: // comment\n" 1765 "protected:\n" 1766 "private:\n" 1767 " void f() {}\n" 1768 "};"); 1769 verifyGoogleFormat("class A {\n" 1770 " public:\n" 1771 " protected:\n" 1772 " private:\n" 1773 " void f() {}\n" 1774 "};"); 1775 verifyFormat("class A {\n" 1776 "public slots:\n" 1777 " void f() {}\n" 1778 "public Q_SLOTS:\n" 1779 " void f() {}\n" 1780 "};"); 1781 } 1782 1783 TEST_F(FormatTest, SeparatesLogicalBlocks) { 1784 EXPECT_EQ("class A {\n" 1785 "public:\n" 1786 " void f();\n" 1787 "\n" 1788 "private:\n" 1789 " void g() {}\n" 1790 " // test\n" 1791 "protected:\n" 1792 " int h;\n" 1793 "};", 1794 format("class A {\n" 1795 "public:\n" 1796 "void f();\n" 1797 "private:\n" 1798 "void g() {}\n" 1799 "// test\n" 1800 "protected:\n" 1801 "int h;\n" 1802 "};")); 1803 EXPECT_EQ("class A {\n" 1804 "protected:\n" 1805 "public:\n" 1806 " void f();\n" 1807 "};", 1808 format("class A {\n" 1809 "protected:\n" 1810 "\n" 1811 "public:\n" 1812 "\n" 1813 " void f();\n" 1814 "};")); 1815 } 1816 1817 TEST_F(FormatTest, FormatsClasses) { 1818 verifyFormat("class A : public B {};"); 1819 verifyFormat("class A : public ::B {};"); 1820 1821 verifyFormat( 1822 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1823 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1824 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" 1825 " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1826 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1827 verifyFormat( 1828 "class A : public B, public C, public D, public E, public F {};"); 1829 verifyFormat("class AAAAAAAAAAAA : public B,\n" 1830 " public C,\n" 1831 " public D,\n" 1832 " public E,\n" 1833 " public F,\n" 1834 " public G {};"); 1835 1836 verifyFormat("class\n" 1837 " ReallyReallyLongClassName {\n" 1838 " int i;\n" 1839 "};", 1840 getLLVMStyleWithColumns(32)); 1841 verifyFormat("struct aaaaaaaaaaaaa : public aaaaaaaaaaaaaaaaaaa< // break\n" 1842 " aaaaaaaaaaaaaaaa> {};"); 1843 verifyFormat("struct aaaaaaaaaaaaaaaaaaaa\n" 1844 " : public aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaa,\n" 1845 " aaaaaaaaaaaaaaaaaaaaaa> {};"); 1846 verifyFormat("template <class R, class C>\n" 1847 "struct Aaaaaaaaaaaaaaaaa<R (C::*)(int) const>\n" 1848 " : Aaaaaaaaaaaaaaaaa<R (C::*)(int)> {};"); 1849 verifyFormat("class ::A::B {};"); 1850 } 1851 1852 TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { 1853 verifyFormat("class A {\n} a, b;"); 1854 verifyFormat("struct A {\n} a, b;"); 1855 verifyFormat("union A {\n} a;"); 1856 } 1857 1858 TEST_F(FormatTest, FormatsEnum) { 1859 verifyFormat("enum {\n" 1860 " Zero,\n" 1861 " One = 1,\n" 1862 " Two = One + 1,\n" 1863 " Three = (One + Two),\n" 1864 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1865 " Five = (One, Two, Three, Four, 5)\n" 1866 "};"); 1867 verifyGoogleFormat("enum {\n" 1868 " Zero,\n" 1869 " One = 1,\n" 1870 " Two = One + 1,\n" 1871 " Three = (One + Two),\n" 1872 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1873 " Five = (One, Two, Three, Four, 5)\n" 1874 "};"); 1875 verifyFormat("enum Enum {};"); 1876 verifyFormat("enum {};"); 1877 verifyFormat("enum X E {} d;"); 1878 verifyFormat("enum __attribute__((...)) E {} d;"); 1879 verifyFormat("enum __declspec__((...)) E {} d;"); 1880 verifyFormat("enum X f() {\n a();\n return 42;\n}"); 1881 verifyFormat("enum {\n" 1882 " Bar = Foo<int, int>::value\n" 1883 "};", 1884 getLLVMStyleWithColumns(30)); 1885 1886 verifyFormat("enum ShortEnum { A, B, C };"); 1887 verifyGoogleFormat("enum ShortEnum { A, B, C };"); 1888 1889 EXPECT_EQ("enum KeepEmptyLines {\n" 1890 " ONE,\n" 1891 "\n" 1892 " TWO,\n" 1893 "\n" 1894 " THREE\n" 1895 "}", 1896 format("enum KeepEmptyLines {\n" 1897 " ONE,\n" 1898 "\n" 1899 " TWO,\n" 1900 "\n" 1901 "\n" 1902 " THREE\n" 1903 "}")); 1904 verifyFormat("enum E { // comment\n" 1905 " ONE,\n" 1906 " TWO\n" 1907 "};"); 1908 } 1909 1910 TEST_F(FormatTest, FormatsEnumsWithErrors) { 1911 verifyFormat("enum Type {\n" 1912 " One = 0; // These semicolons should be commas.\n" 1913 " Two = 1;\n" 1914 "};"); 1915 verifyFormat("namespace n {\n" 1916 "enum Type {\n" 1917 " One,\n" 1918 " Two, // missing };\n" 1919 " int i;\n" 1920 "}\n" 1921 "void g() {}"); 1922 } 1923 1924 TEST_F(FormatTest, FormatsEnumStruct) { 1925 verifyFormat("enum struct {\n" 1926 " Zero,\n" 1927 " One = 1,\n" 1928 " Two = One + 1,\n" 1929 " Three = (One + Two),\n" 1930 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1931 " Five = (One, Two, Three, Four, 5)\n" 1932 "};"); 1933 verifyFormat("enum struct Enum {};"); 1934 verifyFormat("enum struct {};"); 1935 verifyFormat("enum struct X E {} d;"); 1936 verifyFormat("enum struct __attribute__((...)) E {} d;"); 1937 verifyFormat("enum struct __declspec__((...)) E {} d;"); 1938 verifyFormat("enum struct X f() {\n a();\n return 42;\n}"); 1939 } 1940 1941 TEST_F(FormatTest, FormatsEnumClass) { 1942 verifyFormat("enum class {\n" 1943 " Zero,\n" 1944 " One = 1,\n" 1945 " Two = One + 1,\n" 1946 " Three = (One + Two),\n" 1947 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1948 " Five = (One, Two, Three, Four, 5)\n" 1949 "};"); 1950 verifyFormat("enum class Enum {};"); 1951 verifyFormat("enum class {};"); 1952 verifyFormat("enum class X E {} d;"); 1953 verifyFormat("enum class __attribute__((...)) E {} d;"); 1954 verifyFormat("enum class __declspec__((...)) E {} d;"); 1955 verifyFormat("enum class X f() {\n a();\n return 42;\n}"); 1956 } 1957 1958 TEST_F(FormatTest, FormatsEnumTypes) { 1959 verifyFormat("enum X : int {\n" 1960 " A, // Force multiple lines.\n" 1961 " B\n" 1962 "};"); 1963 verifyFormat("enum X : int { A, B };"); 1964 verifyFormat("enum X : std::uint32_t { A, B };"); 1965 } 1966 1967 TEST_F(FormatTest, FormatsNSEnums) { 1968 verifyGoogleFormat("typedef NS_ENUM(NSInteger, SomeName) { AAA, BBB }"); 1969 verifyGoogleFormat("typedef NS_ENUM(NSInteger, MyType) {\n" 1970 " // Information about someDecentlyLongValue.\n" 1971 " someDecentlyLongValue,\n" 1972 " // Information about anotherDecentlyLongValue.\n" 1973 " anotherDecentlyLongValue,\n" 1974 " // Information about aThirdDecentlyLongValue.\n" 1975 " aThirdDecentlyLongValue\n" 1976 "};"); 1977 } 1978 1979 TEST_F(FormatTest, FormatsBitfields) { 1980 verifyFormat("struct Bitfields {\n" 1981 " unsigned sClass : 8;\n" 1982 " unsigned ValueKind : 2;\n" 1983 "};"); 1984 verifyFormat("struct A {\n" 1985 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa : 1,\n" 1986 " bbbbbbbbbbbbbbbbbbbbbbbbb;\n" 1987 "};"); 1988 } 1989 1990 TEST_F(FormatTest, FormatsNamespaces) { 1991 verifyFormat("namespace some_namespace {\n" 1992 "class A {};\n" 1993 "void f() { f(); }\n" 1994 "}"); 1995 verifyFormat("namespace {\n" 1996 "class A {};\n" 1997 "void f() { f(); }\n" 1998 "}"); 1999 verifyFormat("inline namespace X {\n" 2000 "class A {};\n" 2001 "void f() { f(); }\n" 2002 "}"); 2003 verifyFormat("using namespace some_namespace;\n" 2004 "class A {};\n" 2005 "void f() { f(); }"); 2006 2007 // This code is more common than we thought; if we 2008 // layout this correctly the semicolon will go into 2009 // its own line, which is undesirable. 2010 verifyFormat("namespace {};"); 2011 verifyFormat("namespace {\n" 2012 "class A {};\n" 2013 "};"); 2014 2015 verifyFormat("namespace {\n" 2016 "int SomeVariable = 0; // comment\n" 2017 "} // namespace"); 2018 EXPECT_EQ("#ifndef HEADER_GUARD\n" 2019 "#define HEADER_GUARD\n" 2020 "namespace my_namespace {\n" 2021 "int i;\n" 2022 "} // my_namespace\n" 2023 "#endif // HEADER_GUARD", 2024 format("#ifndef HEADER_GUARD\n" 2025 " #define HEADER_GUARD\n" 2026 " namespace my_namespace {\n" 2027 "int i;\n" 2028 "} // my_namespace\n" 2029 "#endif // HEADER_GUARD")); 2030 2031 FormatStyle Style = getLLVMStyle(); 2032 Style.NamespaceIndentation = FormatStyle::NI_All; 2033 EXPECT_EQ("namespace out {\n" 2034 " int i;\n" 2035 " namespace in {\n" 2036 " int i;\n" 2037 " } // namespace\n" 2038 "} // namespace", 2039 format("namespace out {\n" 2040 "int i;\n" 2041 "namespace in {\n" 2042 "int i;\n" 2043 "} // namespace\n" 2044 "} // namespace", 2045 Style)); 2046 2047 Style.NamespaceIndentation = FormatStyle::NI_Inner; 2048 EXPECT_EQ("namespace out {\n" 2049 "int i;\n" 2050 "namespace in {\n" 2051 " int i;\n" 2052 "} // namespace\n" 2053 "} // namespace", 2054 format("namespace out {\n" 2055 "int i;\n" 2056 "namespace in {\n" 2057 "int i;\n" 2058 "} // namespace\n" 2059 "} // namespace", 2060 Style)); 2061 } 2062 2063 TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); } 2064 2065 TEST_F(FormatTest, FormatsInlineASM) { 2066 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); 2067 verifyFormat( 2068 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" 2069 " \"cpuid\\n\\t\"\n" 2070 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" 2071 " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n" 2072 " : \"a\"(value));"); 2073 } 2074 2075 TEST_F(FormatTest, FormatTryCatch) { 2076 verifyFormat("try {\n" 2077 " throw a * b;\n" 2078 "} catch (int a) {\n" 2079 " // Do nothing.\n" 2080 "} catch (...) {\n" 2081 " exit(42);\n" 2082 "}"); 2083 2084 // Function-level try statements. 2085 verifyFormat("int f() try { return 4; } catch (...) {\n" 2086 " return 5;\n" 2087 "}"); 2088 verifyFormat("class A {\n" 2089 " int a;\n" 2090 " A() try : a(0) {\n" 2091 " } catch (...) {\n" 2092 " throw;\n" 2093 " }\n" 2094 "};\n"); 2095 } 2096 2097 TEST_F(FormatTest, IncompleteTryCatchBlocks) { 2098 verifyFormat("try {\n" 2099 " f();\n" 2100 "} catch {\n" 2101 " g();\n" 2102 "}"); 2103 verifyFormat("try {\n" 2104 " f();\n" 2105 "} catch (A a) MACRO(x) {\n" 2106 " g();\n" 2107 "} catch (B b) MACRO(x) {\n" 2108 " g();\n" 2109 "}"); 2110 } 2111 2112 TEST_F(FormatTest, FormatTryCatchBraceStyles) { 2113 FormatStyle Style = getLLVMStyle(); 2114 Style.BreakBeforeBraces = FormatStyle::BS_Attach; 2115 verifyFormat("try {\n" 2116 " // something\n" 2117 "} catch (...) {\n" 2118 " // something\n" 2119 "}", 2120 Style); 2121 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 2122 verifyFormat("try {\n" 2123 " // something\n" 2124 "}\n" 2125 "catch (...) {\n" 2126 " // something\n" 2127 "}", 2128 Style); 2129 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 2130 verifyFormat("try\n" 2131 "{\n" 2132 " // something\n" 2133 "}\n" 2134 "catch (...)\n" 2135 "{\n" 2136 " // something\n" 2137 "}", 2138 Style); 2139 Style.BreakBeforeBraces = FormatStyle::BS_GNU; 2140 verifyFormat("try\n" 2141 " {\n" 2142 " // something\n" 2143 " }\n" 2144 "catch (...)\n" 2145 " {\n" 2146 " // something\n" 2147 " }", 2148 Style); 2149 } 2150 2151 TEST_F(FormatTest, FormatObjCTryCatch) { 2152 verifyFormat("@try {\n" 2153 " f();\n" 2154 "}\n" 2155 "@catch (NSException e) {\n" 2156 " @throw;\n" 2157 "}\n" 2158 "@finally {\n" 2159 " exit(42);\n" 2160 "}"); 2161 } 2162 2163 TEST_F(FormatTest, StaticInitializers) { 2164 verifyFormat("static SomeClass SC = {1, 'a'};"); 2165 2166 verifyFormat( 2167 "static SomeClass WithALoooooooooooooooooooongName = {\n" 2168 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"};"); 2169 2170 // Here, everything other than the "}" would fit on a line. 2171 verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n" 2172 " 10000000000000000000000000};"); 2173 EXPECT_EQ("S s = {a,\n" 2174 "\n" 2175 " b};", 2176 format("S s = {\n" 2177 " a,\n" 2178 "\n" 2179 " b\n" 2180 "};")); 2181 2182 // FIXME: This would fit into the column limit if we'd fit "{ {" on the first 2183 // line. However, the formatting looks a bit off and this probably doesn't 2184 // happen often in practice. 2185 verifyFormat("static int Variable[1] = {\n" 2186 " {1000000000000000000000000000000000000}};", 2187 getLLVMStyleWithColumns(40)); 2188 } 2189 2190 TEST_F(FormatTest, DesignatedInitializers) { 2191 verifyFormat("const struct A a = {.a = 1, .b = 2};"); 2192 verifyFormat("const struct A a = {.aaaaaaaaaa = 1,\n" 2193 " .bbbbbbbbbb = 2,\n" 2194 " .cccccccccc = 3,\n" 2195 " .dddddddddd = 4,\n" 2196 " .eeeeeeeeee = 5};"); 2197 verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" 2198 " .aaaaaaaaaaaaaaaaaaaaaaaaaaa = 1,\n" 2199 " .bbbbbbbbbbbbbbbbbbbbbbbbbbb = 2,\n" 2200 " .ccccccccccccccccccccccccccc = 3,\n" 2201 " .ddddddddddddddddddddddddddd = 4,\n" 2202 " .eeeeeeeeeeeeeeeeeeeeeeeeeee = 5};"); 2203 2204 verifyGoogleFormat("const struct A a = {.a = 1, .b = 2};"); 2205 } 2206 2207 TEST_F(FormatTest, NestedStaticInitializers) { 2208 verifyFormat("static A x = {{{}}};\n"); 2209 verifyFormat("static A x = {{{init1, init2, init3, init4},\n" 2210 " {init1, init2, init3, init4}}};", 2211 getLLVMStyleWithColumns(50)); 2212 2213 verifyFormat("somes Status::global_reps[3] = {\n" 2214 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2215 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2216 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};", 2217 getLLVMStyleWithColumns(60)); 2218 verifyGoogleFormat("SomeType Status::global_reps[3] = {\n" 2219 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2220 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2221 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};"); 2222 verifyFormat( 2223 "CGRect cg_rect = {{rect.fLeft, rect.fTop},\n" 2224 " {rect.fRight - rect.fLeft, rect.fBottom - rect.fTop}};"); 2225 2226 verifyFormat( 2227 "SomeArrayOfSomeType a = {\n" 2228 " {{1, 2, 3},\n" 2229 " {1, 2, 3},\n" 2230 " {111111111111111111111111111111, 222222222222222222222222222222,\n" 2231 " 333333333333333333333333333333},\n" 2232 " {1, 2, 3},\n" 2233 " {1, 2, 3}}};"); 2234 verifyFormat( 2235 "SomeArrayOfSomeType a = {\n" 2236 " {{1, 2, 3}},\n" 2237 " {{1, 2, 3}},\n" 2238 " {{111111111111111111111111111111, 222222222222222222222222222222,\n" 2239 " 333333333333333333333333333333}},\n" 2240 " {{1, 2, 3}},\n" 2241 " {{1, 2, 3}}};"); 2242 2243 verifyFormat( 2244 "struct {\n" 2245 " unsigned bit;\n" 2246 " const char *const name;\n" 2247 "} kBitsToOs[] = {{kOsMac, \"Mac\"},\n" 2248 " {kOsWin, \"Windows\"},\n" 2249 " {kOsLinux, \"Linux\"},\n" 2250 " {kOsCrOS, \"Chrome OS\"}};"); 2251 } 2252 2253 TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { 2254 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2255 " \\\n" 2256 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); 2257 } 2258 2259 TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { 2260 verifyFormat("virtual void write(ELFWriter *writerrr,\n" 2261 " OwningPtr<FileOutputBuffer> &buffer) = 0;"); 2262 } 2263 2264 TEST_F(FormatTest, BreaksStringLiteralsOnlyInDefine) { 2265 verifyFormat("# 1111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\" 2 3", 2266 getLLVMStyleWithColumns(40)); 2267 verifyFormat("#line 11111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2268 getLLVMStyleWithColumns(40)); 2269 EXPECT_EQ("#define Q \\\n" 2270 " \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/\" \\\n" 2271 " \"aaaaaaaa.cpp\"", 2272 format("#define Q \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2273 getLLVMStyleWithColumns(40))); 2274 } 2275 2276 TEST_F(FormatTest, UnderstandsLinePPDirective) { 2277 EXPECT_EQ("# 123 \"A string literal\"", 2278 format(" # 123 \"A string literal\"")); 2279 } 2280 2281 TEST_F(FormatTest, LayoutUnknownPPDirective) { 2282 EXPECT_EQ("#;", format("#;")); 2283 verifyFormat("#\n;\n;\n;"); 2284 } 2285 2286 TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { 2287 EXPECT_EQ("#line 42 \"test\"\n", 2288 format("# \\\n line \\\n 42 \\\n \"test\"\n")); 2289 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", 2290 getLLVMStyleWithColumns(12))); 2291 } 2292 2293 TEST_F(FormatTest, EndOfFileEndsPPDirective) { 2294 EXPECT_EQ("#line 42 \"test\"", 2295 format("# \\\n line \\\n 42 \\\n \"test\"")); 2296 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); 2297 } 2298 2299 TEST_F(FormatTest, DoesntRemoveUnknownTokens) { 2300 verifyFormat("#define A \\x20"); 2301 verifyFormat("#define A \\ x20"); 2302 EXPECT_EQ("#define A \\ x20", format("#define A \\ x20")); 2303 verifyFormat("#define A ''"); 2304 verifyFormat("#define A ''qqq"); 2305 verifyFormat("#define A `qqq"); 2306 verifyFormat("f(\"aaaa, bbbb, \"\\\"ccccc\\\"\");"); 2307 EXPECT_EQ("const char *c = STRINGIFY(\n" 2308 "\\na : b);", 2309 format("const char * c = STRINGIFY(\n" 2310 "\\na : b);")); 2311 } 2312 2313 TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { 2314 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); 2315 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); 2316 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); 2317 // FIXME: We never break before the macro name. 2318 verifyFormat("#define AA( \\\n B)", getLLVMStyleWithColumns(12)); 2319 2320 verifyFormat("#define A A\n#define A A"); 2321 verifyFormat("#define A(X) A\n#define A A"); 2322 2323 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); 2324 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); 2325 } 2326 2327 TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { 2328 EXPECT_EQ("// somecomment\n" 2329 "#include \"a.h\"\n" 2330 "#define A( \\\n" 2331 " A, B)\n" 2332 "#include \"b.h\"\n" 2333 "// somecomment\n", 2334 format(" // somecomment\n" 2335 " #include \"a.h\"\n" 2336 "#define A(A,\\\n" 2337 " B)\n" 2338 " #include \"b.h\"\n" 2339 " // somecomment\n", 2340 getLLVMStyleWithColumns(13))); 2341 } 2342 2343 TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } 2344 2345 TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { 2346 EXPECT_EQ("#define A \\\n" 2347 " c; \\\n" 2348 " e;\n" 2349 "f;", 2350 format("#define A c; e;\n" 2351 "f;", 2352 getLLVMStyleWithColumns(14))); 2353 } 2354 2355 TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } 2356 2357 TEST_F(FormatTest, AlwaysFormatsEntireMacroDefinitions) { 2358 EXPECT_EQ("int i;\n" 2359 "#define A \\\n" 2360 " int i; \\\n" 2361 " int j\n" 2362 "int k;", 2363 format("int i;\n" 2364 "#define A \\\n" 2365 " int i ; \\\n" 2366 " int j\n" 2367 "int k;", 2368 8, 0, getGoogleStyle())); // 8: position of "#define". 2369 EXPECT_EQ("int i;\n" 2370 "#define A \\\n" 2371 " int i; \\\n" 2372 " int j\n" 2373 "int k;", 2374 format("int i;\n" 2375 "#define A \\\n" 2376 " int i ; \\\n" 2377 " int j\n" 2378 "int k;", 2379 45, 0, getGoogleStyle())); // 45: position of "j". 2380 } 2381 2382 TEST_F(FormatTest, MacroDefinitionInsideStatement) { 2383 EXPECT_EQ("int x,\n" 2384 "#define A\n" 2385 " y;", 2386 format("int x,\n#define A\ny;")); 2387 } 2388 2389 TEST_F(FormatTest, HashInMacroDefinition) { 2390 EXPECT_EQ("#define A(c) L#c", format("#define A(c) L#c", getLLVMStyle())); 2391 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); 2392 verifyFormat("#define A \\\n" 2393 " { \\\n" 2394 " f(#c); \\\n" 2395 " }", 2396 getLLVMStyleWithColumns(11)); 2397 2398 verifyFormat("#define A(X) \\\n" 2399 " void function##X()", 2400 getLLVMStyleWithColumns(22)); 2401 2402 verifyFormat("#define A(a, b, c) \\\n" 2403 " void a##b##c()", 2404 getLLVMStyleWithColumns(22)); 2405 2406 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); 2407 } 2408 2409 TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { 2410 EXPECT_EQ("#define A (x)", format("#define A (x)")); 2411 EXPECT_EQ("#define A(x)", format("#define A(x)")); 2412 } 2413 2414 TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { 2415 EXPECT_EQ("#define A b;", format("#define A \\\n" 2416 " \\\n" 2417 " b;", 2418 getLLVMStyleWithColumns(25))); 2419 EXPECT_EQ("#define A \\\n" 2420 " \\\n" 2421 " a; \\\n" 2422 " b;", 2423 format("#define A \\\n" 2424 " \\\n" 2425 " a; \\\n" 2426 " b;", 2427 getLLVMStyleWithColumns(11))); 2428 EXPECT_EQ("#define A \\\n" 2429 " a; \\\n" 2430 " \\\n" 2431 " b;", 2432 format("#define A \\\n" 2433 " a; \\\n" 2434 " \\\n" 2435 " b;", 2436 getLLVMStyleWithColumns(11))); 2437 } 2438 2439 TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { 2440 verifyFormat("#define A :"); 2441 verifyFormat("#define SOMECASES \\\n" 2442 " case 1: \\\n" 2443 " case 2\n", 2444 getLLVMStyleWithColumns(20)); 2445 verifyFormat("#define A template <typename T>"); 2446 verifyFormat("#define STR(x) #x\n" 2447 "f(STR(this_is_a_string_literal{));"); 2448 verifyFormat("#pragma omp threadprivate( \\\n" 2449 " y)), // expected-warning", 2450 getLLVMStyleWithColumns(28)); 2451 } 2452 2453 TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { 2454 verifyFormat("SOME_TYPE_NAME abc;"); // Gated on the newline. 2455 EXPECT_EQ("class A : public QObject {\n" 2456 " Q_OBJECT\n" 2457 "\n" 2458 " A() {}\n" 2459 "};", 2460 format("class A : public QObject {\n" 2461 " Q_OBJECT\n" 2462 "\n" 2463 " A() {\n}\n" 2464 "} ;")); 2465 EXPECT_EQ("SOME_MACRO\n" 2466 "namespace {\n" 2467 "void f();\n" 2468 "}", 2469 format("SOME_MACRO\n" 2470 " namespace {\n" 2471 "void f( );\n" 2472 "}")); 2473 // Only if the identifier contains at least 5 characters. 2474 EXPECT_EQ("HTTP f();", 2475 format("HTTP\nf();")); 2476 EXPECT_EQ("MACRO\nf();", 2477 format("MACRO\nf();")); 2478 // Only if everything is upper case. 2479 EXPECT_EQ("class A : public QObject {\n" 2480 " Q_Object A() {}\n" 2481 "};", 2482 format("class A : public QObject {\n" 2483 " Q_Object\n" 2484 " A() {\n}\n" 2485 "} ;")); 2486 } 2487 2488 TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { 2489 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2490 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2491 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2492 "class X {};\n" 2493 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2494 "int *createScopDetectionPass() { return 0; }", 2495 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2496 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2497 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2498 " class X {};\n" 2499 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2500 " int *createScopDetectionPass() { return 0; }")); 2501 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as 2502 // braces, so that inner block is indented one level more. 2503 EXPECT_EQ("int q() {\n" 2504 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2505 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2506 " IPC_END_MESSAGE_MAP()\n" 2507 "}", 2508 format("int q() {\n" 2509 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2510 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2511 " IPC_END_MESSAGE_MAP()\n" 2512 "}")); 2513 2514 // Same inside macros. 2515 EXPECT_EQ("#define LIST(L) \\\n" 2516 " L(A) \\\n" 2517 " L(B) \\\n" 2518 " L(C)", 2519 format("#define LIST(L) \\\n" 2520 " L(A) \\\n" 2521 " L(B) \\\n" 2522 " L(C)", 2523 getGoogleStyle())); 2524 2525 // These must not be recognized as macros. 2526 EXPECT_EQ("int q() {\n" 2527 " f(x);\n" 2528 " f(x) {}\n" 2529 " f(x)->g();\n" 2530 " f(x)->*g();\n" 2531 " f(x).g();\n" 2532 " f(x) = x;\n" 2533 " f(x) += x;\n" 2534 " f(x) -= x;\n" 2535 " f(x) *= x;\n" 2536 " f(x) /= x;\n" 2537 " f(x) %= x;\n" 2538 " f(x) &= x;\n" 2539 " f(x) |= x;\n" 2540 " f(x) ^= x;\n" 2541 " f(x) >>= x;\n" 2542 " f(x) <<= x;\n" 2543 " f(x)[y].z();\n" 2544 " LOG(INFO) << x;\n" 2545 " ifstream(x) >> x;\n" 2546 "}\n", 2547 format("int q() {\n" 2548 " f(x)\n;\n" 2549 " f(x)\n {}\n" 2550 " f(x)\n->g();\n" 2551 " f(x)\n->*g();\n" 2552 " f(x)\n.g();\n" 2553 " f(x)\n = x;\n" 2554 " f(x)\n += x;\n" 2555 " f(x)\n -= x;\n" 2556 " f(x)\n *= x;\n" 2557 " f(x)\n /= x;\n" 2558 " f(x)\n %= x;\n" 2559 " f(x)\n &= x;\n" 2560 " f(x)\n |= x;\n" 2561 " f(x)\n ^= x;\n" 2562 " f(x)\n >>= x;\n" 2563 " f(x)\n <<= x;\n" 2564 " f(x)\n[y].z();\n" 2565 " LOG(INFO)\n << x;\n" 2566 " ifstream(x)\n >> x;\n" 2567 "}\n")); 2568 EXPECT_EQ("int q() {\n" 2569 " F(x)\n" 2570 " if (1) {\n" 2571 " }\n" 2572 " F(x)\n" 2573 " while (1) {\n" 2574 " }\n" 2575 " F(x)\n" 2576 " G(x);\n" 2577 " F(x)\n" 2578 " try {\n" 2579 " Q();\n" 2580 " } catch (...) {\n" 2581 " }\n" 2582 "}\n", 2583 format("int q() {\n" 2584 "F(x)\n" 2585 "if (1) {}\n" 2586 "F(x)\n" 2587 "while (1) {}\n" 2588 "F(x)\n" 2589 "G(x);\n" 2590 "F(x)\n" 2591 "try { Q(); } catch (...) {}\n" 2592 "}\n")); 2593 EXPECT_EQ("class A {\n" 2594 " A() : t(0) {}\n" 2595 " A(int i) noexcept() : {}\n" 2596 " A(X x)\n" // FIXME: function-level try blocks are broken. 2597 " try : t(0) {\n" 2598 " } catch (...) {\n" 2599 " }\n" 2600 "};", 2601 format("class A {\n" 2602 " A()\n : t(0) {}\n" 2603 " A(int i)\n noexcept() : {}\n" 2604 " A(X x)\n" 2605 " try : t(0) {} catch (...) {}\n" 2606 "};")); 2607 EXPECT_EQ( 2608 "class SomeClass {\n" 2609 "public:\n" 2610 " SomeClass() EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2611 "};", 2612 format("class SomeClass {\n" 2613 "public:\n" 2614 " SomeClass()\n" 2615 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2616 "};")); 2617 EXPECT_EQ( 2618 "class SomeClass {\n" 2619 "public:\n" 2620 " SomeClass()\n" 2621 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2622 "};", 2623 format("class SomeClass {\n" 2624 "public:\n" 2625 " SomeClass()\n" 2626 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2627 "};", getLLVMStyleWithColumns(40))); 2628 } 2629 2630 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { 2631 verifyFormat("#define A \\\n" 2632 " f({ \\\n" 2633 " g(); \\\n" 2634 " });", getLLVMStyleWithColumns(11)); 2635 } 2636 2637 TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) { 2638 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}")); 2639 } 2640 2641 TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { 2642 verifyFormat("{\n { a #c; }\n}"); 2643 } 2644 2645 TEST_F(FormatTest, FormatUnbalancedStructuralElements) { 2646 EXPECT_EQ("#define A \\\n { \\\n {\nint i;", 2647 format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); 2648 EXPECT_EQ("#define A \\\n } \\\n }\nint i;", 2649 format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); 2650 } 2651 2652 TEST_F(FormatTest, EscapedNewlineAtStartOfToken) { 2653 EXPECT_EQ( 2654 "#define A \\\n int i; \\\n int j;", 2655 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11))); 2656 EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); 2657 } 2658 2659 TEST_F(FormatTest, NoEscapedNewlineHandlingInBlockComments) { 2660 EXPECT_EQ("/* \\ \\ \\\n*/", format("\\\n/* \\ \\ \\\n*/")); 2661 } 2662 2663 TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { 2664 verifyFormat("#define A \\\n" 2665 " int v( \\\n" 2666 " a); \\\n" 2667 " int i;", 2668 getLLVMStyleWithColumns(11)); 2669 } 2670 2671 TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { 2672 EXPECT_EQ( 2673 "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2674 " \\\n" 2675 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2676 "\n" 2677 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2678 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", 2679 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2680 "\\\n" 2681 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2682 " \n" 2683 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2684 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); 2685 } 2686 2687 TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { 2688 EXPECT_EQ("int\n" 2689 "#define A\n" 2690 " a;", 2691 format("int\n#define A\na;")); 2692 verifyFormat("functionCallTo(\n" 2693 " someOtherFunction(\n" 2694 " withSomeParameters, whichInSequence,\n" 2695 " areLongerThanALine(andAnotherCall,\n" 2696 "#define A B\n" 2697 " withMoreParamters,\n" 2698 " whichStronglyInfluenceTheLayout),\n" 2699 " andMoreParameters),\n" 2700 " trailing);", 2701 getLLVMStyleWithColumns(69)); 2702 verifyFormat("Foo::Foo()\n" 2703 "#ifdef BAR\n" 2704 " : baz(0)\n" 2705 "#endif\n" 2706 "{\n" 2707 "}"); 2708 verifyFormat("void f() {\n" 2709 " if (true)\n" 2710 "#ifdef A\n" 2711 " f(42);\n" 2712 " x();\n" 2713 "#else\n" 2714 " g();\n" 2715 " x();\n" 2716 "#endif\n" 2717 "}"); 2718 verifyFormat("void f(param1, param2,\n" 2719 " param3,\n" 2720 "#ifdef A\n" 2721 " param4(param5,\n" 2722 "#ifdef A1\n" 2723 " param6,\n" 2724 "#ifdef A2\n" 2725 " param7),\n" 2726 "#else\n" 2727 " param8),\n" 2728 " param9,\n" 2729 "#endif\n" 2730 " param10,\n" 2731 "#endif\n" 2732 " param11)\n" 2733 "#else\n" 2734 " param12)\n" 2735 "#endif\n" 2736 "{\n" 2737 " x();\n" 2738 "}", 2739 getLLVMStyleWithColumns(28)); 2740 verifyFormat("#if 1\n" 2741 "int i;"); 2742 verifyFormat( 2743 "#if 1\n" 2744 "#endif\n" 2745 "#if 1\n" 2746 "#else\n" 2747 "#endif\n"); 2748 verifyFormat("DEBUG({\n" 2749 " return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2750 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 2751 "});\n" 2752 "#if a\n" 2753 "#else\n" 2754 "#endif"); 2755 } 2756 2757 TEST_F(FormatTest, GraciouslyHandleIncorrectPreprocessorConditions) { 2758 verifyFormat("#endif\n" 2759 "#if B"); 2760 } 2761 2762 TEST_F(FormatTest, FormatsJoinedLinesOnSubsequentRuns) { 2763 FormatStyle SingleLine = getLLVMStyle(); 2764 SingleLine.AllowShortIfStatementsOnASingleLine = true; 2765 verifyFormat( 2766 "#if 0\n" 2767 "#elif 1\n" 2768 "#endif\n" 2769 "void foo() {\n" 2770 " if (test) foo2();\n" 2771 "}", 2772 SingleLine); 2773 } 2774 2775 TEST_F(FormatTest, LayoutBlockInsideParens) { 2776 EXPECT_EQ("functionCall({ int i; });", format(" functionCall ( {int i;} );")); 2777 EXPECT_EQ("functionCall({\n" 2778 " int i;\n" 2779 " int j;\n" 2780 "});", 2781 format(" functionCall ( {int i;int j;} );")); 2782 EXPECT_EQ("functionCall({\n" 2783 " int i;\n" 2784 " int j;\n" 2785 " },\n" 2786 " aaaa, bbbb, cccc);", 2787 format(" functionCall ( {int i;int j;}, aaaa, bbbb, cccc);")); 2788 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2789 format(" functionCall (aaaa, bbbb, {int i;});")); 2790 EXPECT_EQ("functionCall(aaaa, bbbb, {\n" 2791 " int i;\n" 2792 " int j;\n" 2793 "});", 2794 format(" functionCall (aaaa, bbbb, {int i;int j;});")); 2795 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2796 format(" functionCall (aaaa, bbbb, {int i;});")); 2797 verifyFormat( 2798 "Aaa({\n" 2799 " int i; // break\n" 2800 " },\n" 2801 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 2802 " ccccccccccccccccc));"); 2803 verifyFormat("DEBUG({\n" 2804 " if (a)\n" 2805 " f();\n" 2806 "});"); 2807 } 2808 2809 TEST_F(FormatTest, LayoutBlockInsideStatement) { 2810 EXPECT_EQ("SOME_MACRO { int i; }\n" 2811 "int i;", 2812 format(" SOME_MACRO {int i;} int i;")); 2813 } 2814 2815 TEST_F(FormatTest, LayoutNestedBlocks) { 2816 verifyFormat("void AddOsStrings(unsigned bitmask) {\n" 2817 " struct s {\n" 2818 " int i;\n" 2819 " };\n" 2820 " s kBitsToOs[] = {{10}};\n" 2821 " for (int i = 0; i < 10; ++i)\n" 2822 " return;\n" 2823 "}"); 2824 verifyFormat("call(parameter, {\n" 2825 " something();\n" 2826 " // Comment using all columns.\n" 2827 " somethingelse();\n" 2828 "});", 2829 getLLVMStyleWithColumns(40)); 2830 verifyFormat("DEBUG( //\n" 2831 " { f(); }, a);"); 2832 verifyFormat("DEBUG( //\n" 2833 " {\n" 2834 " f(); //\n" 2835 " },\n" 2836 " a);"); 2837 2838 EXPECT_EQ("call(parameter, {\n" 2839 " something();\n" 2840 " // Comment too\n" 2841 " // looooooooooong.\n" 2842 " somethingElse();\n" 2843 "});", 2844 format("call(parameter, {\n" 2845 " something();\n" 2846 " // Comment too looooooooooong.\n" 2847 " somethingElse();\n" 2848 "});", 2849 getLLVMStyleWithColumns(29))); 2850 EXPECT_EQ("DEBUG({ int i; });", format("DEBUG({ int i; });")); 2851 EXPECT_EQ("DEBUG({ // comment\n" 2852 " int i;\n" 2853 "});", 2854 format("DEBUG({ // comment\n" 2855 "int i;\n" 2856 "});")); 2857 EXPECT_EQ("DEBUG({\n" 2858 " int i;\n" 2859 "\n" 2860 " // comment\n" 2861 " int j;\n" 2862 "});", 2863 format("DEBUG({\n" 2864 " int i;\n" 2865 "\n" 2866 " // comment\n" 2867 " int j;\n" 2868 "});")); 2869 2870 verifyFormat("DEBUG({\n" 2871 " if (a)\n" 2872 " return;\n" 2873 "});"); 2874 verifyGoogleFormat("DEBUG({\n" 2875 " if (a) return;\n" 2876 "});"); 2877 FormatStyle Style = getGoogleStyle(); 2878 Style.ColumnLimit = 45; 2879 verifyFormat("Debug(aaaaa, {\n" 2880 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2881 " return;\n" 2882 " },\n" 2883 " a);", Style); 2884 } 2885 2886 TEST_F(FormatTest, IndividualStatementsOfNestedBlocks) { 2887 EXPECT_EQ("DEBUG({\n" 2888 " int i;\n" 2889 " int j;\n" 2890 "});", 2891 format("DEBUG( {\n" 2892 " int i;\n" 2893 " int j;\n" 2894 "} ) ;", 2895 20, 1, getLLVMStyle())); 2896 EXPECT_EQ("DEBUG( {\n" 2897 " int i;\n" 2898 " int j;\n" 2899 "} ) ;", 2900 format("DEBUG( {\n" 2901 " int i;\n" 2902 " int j;\n" 2903 "} ) ;", 2904 41, 1, getLLVMStyle())); 2905 EXPECT_EQ("DEBUG( {\n" 2906 " int i;\n" 2907 " int j;\n" 2908 "} ) ;", 2909 format("DEBUG( {\n" 2910 " int i;\n" 2911 " int j;\n" 2912 "} ) ;", 2913 41, 1, getLLVMStyle())); 2914 EXPECT_EQ("DEBUG({\n" 2915 " int i;\n" 2916 " int j;\n" 2917 "});", 2918 format("DEBUG( {\n" 2919 " int i;\n" 2920 " int j;\n" 2921 "} ) ;", 2922 20, 1, getLLVMStyle())); 2923 2924 EXPECT_EQ("Debug({\n" 2925 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2926 " return;\n" 2927 " },\n" 2928 " a);", 2929 format("Debug({\n" 2930 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2931 " return;\n" 2932 " },\n" 2933 " a);", 2934 50, 1, getLLVMStyle())); 2935 EXPECT_EQ("DEBUG({\n" 2936 " DEBUG({\n" 2937 " int a;\n" 2938 " int b;\n" 2939 " }) ;\n" 2940 "});", 2941 format("DEBUG({\n" 2942 " DEBUG({\n" 2943 " int a;\n" 2944 " int b;\n" // Format this line only. 2945 " }) ;\n" // Don't touch this line. 2946 "});", 2947 35, 0, getLLVMStyle())); 2948 EXPECT_EQ("DEBUG({\n" 2949 " int a; //\n" 2950 "});", 2951 format("DEBUG({\n" 2952 " int a; //\n" 2953 "});", 2954 0, 0, getLLVMStyle())); 2955 } 2956 2957 TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { 2958 EXPECT_EQ("{}", format("{}")); 2959 verifyFormat("enum E {};"); 2960 verifyFormat("enum E {}"); 2961 } 2962 2963 //===----------------------------------------------------------------------===// 2964 // Line break tests. 2965 //===----------------------------------------------------------------------===// 2966 2967 TEST_F(FormatTest, PreventConfusingIndents) { 2968 verifyFormat( 2969 "void f() {\n" 2970 " SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" 2971 " parameter, parameter, parameter)),\n" 2972 " SecondLongCall(parameter));\n" 2973 "}"); 2974 verifyFormat( 2975 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2976 " aaaaaaaaaaaaaaaaaaaaaaaa(\n" 2977 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2978 " aaaaaaaaaaaaaaaaaaaaaaaa);"); 2979 verifyFormat( 2980 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2981 " [aaaaaaaaaaaaaaaaaaaaaaaa\n" 2982 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 2983 " [aaaaaaaaaaaaaaaaaaaaaaaa]];"); 2984 verifyFormat( 2985 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 2986 " aaaaaaaaaaaaaaaaaaaaaaaa<\n" 2987 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" 2988 " aaaaaaaaaaaaaaaaaaaaaaaa>;"); 2989 verifyFormat("int a = bbbb && ccc && fffff(\n" 2990 "#define A Just forcing a new line\n" 2991 " ddd);"); 2992 } 2993 2994 TEST_F(FormatTest, LineBreakingInBinaryExpressions) { 2995 verifyFormat( 2996 "bool aaaaaaa =\n" 2997 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" 2998 " bbbbbbbb();"); 2999 verifyFormat( 3000 "bool aaaaaaa =\n" 3001 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() or\n" 3002 " bbbbbbbb();"); 3003 3004 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3005 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" 3006 " ccccccccc == ddddddddddd;"); 3007 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb and\n" 3009 " ccccccccc == ddddddddddd;"); 3010 verifyFormat( 3011 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 3012 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa not_eq bbbbbbbbbbbbbbbbbb and\n" 3013 " ccccccccc == ddddddddddd;"); 3014 3015 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3016 " aaaaaa) &&\n" 3017 " bbbbbb && cccccc;"); 3018 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3019 " aaaaaa) >>\n" 3020 " bbbbbb;"); 3021 verifyFormat("Whitespaces.addUntouchableComment(\n" 3022 " SourceMgr.getSpellingColumnNumber(\n" 3023 " TheLine.Last->FormatTok.Tok.getLocation()) -\n" 3024 " 1);"); 3025 3026 verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3027 " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaaaaaaa\n" 3028 " cccccc) {\n}"); 3029 3030 // If the LHS of a comparison is not a binary expression itself, the 3031 // additional linebreak confuses many people. 3032 verifyFormat( 3033 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3034 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) > 5) {\n" 3035 "}"); 3036 verifyFormat( 3037 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3038 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3039 "}"); 3040 verifyFormat( 3041 "if (aaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaa(\n" 3042 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3043 "}"); 3044 // Even explicit parentheses stress the precedence enough to make the 3045 // additional break unnecessary. 3046 verifyFormat( 3047 "if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3048 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3049 "}"); 3050 // This cases is borderline, but with the indentation it is still readable. 3051 verifyFormat( 3052 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3053 " aaaaaaaaaaaaaaa) > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3054 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 3055 "}", 3056 getLLVMStyleWithColumns(75)); 3057 3058 // If the LHS is a binary expression, we should still use the additional break 3059 // as otherwise the formatting hides the operator precedence. 3060 verifyFormat( 3061 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3062 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3063 " 5) {\n" 3064 "}"); 3065 3066 FormatStyle OnePerLine = getLLVMStyle(); 3067 OnePerLine.BinPackParameters = false; 3068 verifyFormat( 3069 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3070 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3071 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}", 3072 OnePerLine); 3073 } 3074 3075 TEST_F(FormatTest, ExpressionIndentation) { 3076 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3077 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3078 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3079 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3080 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" 3081 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" 3082 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3083 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" 3084 " ccccccccccccccccccccccccccccccccccccccccc;"); 3085 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3086 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3087 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3088 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3089 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3090 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3091 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3092 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3093 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3094 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3095 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3096 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3097 verifyFormat("if () {\n" 3098 "} else if (aaaaa &&\n" 3099 " bbbbb > // break\n" 3100 " ccccc) {\n" 3101 "}"); 3102 3103 // Presence of a trailing comment used to change indentation of b. 3104 verifyFormat("return aaaaaaaaaaaaaaaaaaa +\n" 3105 " b;\n" 3106 "return aaaaaaaaaaaaaaaaaaa +\n" 3107 " b; //", 3108 getLLVMStyleWithColumns(30)); 3109 } 3110 3111 TEST_F(FormatTest, ExpressionIndentationBreakingBeforeOperators) { 3112 // Not sure what the best system is here. Like this, the LHS can be found 3113 // immediately above an operator (everything with the same or a higher 3114 // indent). The RHS is aligned right of the operator and so compasses 3115 // everything until something with the same indent as the operator is found. 3116 // FIXME: Is this a good system? 3117 FormatStyle Style = getLLVMStyle(); 3118 Style.BreakBeforeBinaryOperators = true; 3119 verifyFormat( 3120 "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3121 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3122 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3123 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3124 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3125 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3126 " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3127 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3128 " > ccccccccccccccccccccccccccccccccccccccccc;", 3129 Style); 3130 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3131 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3132 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3133 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3134 Style); 3135 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3136 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3137 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3138 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3139 Style); 3140 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3141 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3142 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3143 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3144 Style); 3145 verifyFormat("if () {\n" 3146 "} else if (aaaaa\n" 3147 " && bbbbb // break\n" 3148 " > ccccc) {\n" 3149 "}", 3150 Style); 3151 3152 // Forced by comments. 3153 verifyFormat( 3154 "unsigned ContentSize =\n" 3155 " sizeof(int16_t) // DWARF ARange version number\n" 3156 " + sizeof(int32_t) // Offset of CU in the .debug_info section\n" 3157 " + sizeof(int8_t) // Pointer Size (in bytes)\n" 3158 " + sizeof(int8_t); // Segment Size (in bytes)"); 3159 3160 verifyFormat("return boost::fusion::at_c<0>(iiii).second\n" 3161 " == boost::fusion::at_c<1>(iiii).second;", 3162 Style); 3163 3164 Style.ColumnLimit = 60; 3165 verifyFormat("zzzzzzzzzz\n" 3166 " = bbbbbbbbbbbbbbbbb\n" 3167 " >> aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa);", 3168 Style); 3169 } 3170 3171 TEST_F(FormatTest, ConstructorInitializers) { 3172 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); 3173 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", 3174 getLLVMStyleWithColumns(45)); 3175 verifyFormat("Constructor()\n" 3176 " : Inttializer(FitsOnTheLine) {}", 3177 getLLVMStyleWithColumns(44)); 3178 verifyFormat("Constructor()\n" 3179 " : Inttializer(FitsOnTheLine) {}", 3180 getLLVMStyleWithColumns(43)); 3181 3182 verifyFormat( 3183 "SomeClass::Constructor()\n" 3184 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3185 3186 verifyFormat( 3187 "SomeClass::Constructor()\n" 3188 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3189 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); 3190 verifyFormat( 3191 "SomeClass::Constructor()\n" 3192 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3193 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3194 3195 verifyFormat("Constructor()\n" 3196 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3197 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3198 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3199 " aaaaaaaaaaaaaaaaaaaaaaa() {}"); 3200 3201 verifyFormat("Constructor()\n" 3202 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3203 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3204 3205 verifyFormat("Constructor(int Parameter = 0)\n" 3206 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" 3207 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); 3208 verifyFormat("Constructor()\n" 3209 " : aaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" 3210 "}", 3211 getLLVMStyleWithColumns(60)); 3212 verifyFormat("Constructor()\n" 3213 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3214 " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}"); 3215 3216 // Here a line could be saved by splitting the second initializer onto two 3217 // lines, but that is not desirable. 3218 verifyFormat("Constructor()\n" 3219 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" 3220 " aaaaaaaaaaa(aaaaaaaaaaa),\n" 3221 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3222 3223 FormatStyle OnePerLine = getLLVMStyle(); 3224 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3225 verifyFormat("SomeClass::Constructor()\n" 3226 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3227 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3228 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3229 OnePerLine); 3230 verifyFormat("SomeClass::Constructor()\n" 3231 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" 3232 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3233 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3234 OnePerLine); 3235 verifyFormat("MyClass::MyClass(int var)\n" 3236 " : some_var_(var), // 4 space indent\n" 3237 " some_other_var_(var + 1) { // lined up\n" 3238 "}", 3239 OnePerLine); 3240 verifyFormat("Constructor()\n" 3241 " : aaaaa(aaaaaa),\n" 3242 " aaaaa(aaaaaa),\n" 3243 " aaaaa(aaaaaa),\n" 3244 " aaaaa(aaaaaa),\n" 3245 " aaaaa(aaaaaa) {}", 3246 OnePerLine); 3247 verifyFormat("Constructor()\n" 3248 " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" 3249 " aaaaaaaaaaaaaaaaaaaaaa) {}", 3250 OnePerLine); 3251 3252 EXPECT_EQ("Constructor()\n" 3253 " : // Comment forcing unwanted break.\n" 3254 " aaaa(aaaa) {}", 3255 format("Constructor() :\n" 3256 " // Comment forcing unwanted break.\n" 3257 " aaaa(aaaa) {}")); 3258 } 3259 3260 TEST_F(FormatTest, MemoizationTests) { 3261 // This breaks if the memoization lookup does not take \c Indent and 3262 // \c LastSpace into account. 3263 verifyFormat( 3264 "extern CFRunLoopTimerRef\n" 3265 "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" 3266 " CFTimeInterval interval, CFOptionFlags flags,\n" 3267 " CFIndex order, CFRunLoopTimerCallBack callout,\n" 3268 " CFRunLoopTimerContext *context) {}"); 3269 3270 // Deep nesting somewhat works around our memoization. 3271 verifyFormat( 3272 "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3273 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3274 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3275 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3276 " aaaaa())))))))))))))))))))))))))))))))))))))));", 3277 getLLVMStyleWithColumns(65)); 3278 verifyFormat( 3279 "aaaaa(\n" 3280 " aaaaa,\n" 3281 " aaaaa(\n" 3282 " aaaaa,\n" 3283 " aaaaa(\n" 3284 " aaaaa,\n" 3285 " aaaaa(\n" 3286 " aaaaa,\n" 3287 " aaaaa(\n" 3288 " aaaaa,\n" 3289 " aaaaa(\n" 3290 " aaaaa,\n" 3291 " aaaaa(\n" 3292 " aaaaa,\n" 3293 " aaaaa(\n" 3294 " aaaaa,\n" 3295 " aaaaa(\n" 3296 " aaaaa,\n" 3297 " aaaaa(\n" 3298 " aaaaa,\n" 3299 " aaaaa(\n" 3300 " aaaaa,\n" 3301 " aaaaa(\n" 3302 " aaaaa,\n" 3303 " aaaaa))))))))))));", 3304 getLLVMStyleWithColumns(65)); 3305 verifyFormat( 3306 "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n" 3307 " a),\n" 3308 " a),\n" 3309 " a),\n" 3310 " a),\n" 3311 " a),\n" 3312 " a),\n" 3313 " a),\n" 3314 " a),\n" 3315 " a),\n" 3316 " a),\n" 3317 " a),\n" 3318 " a),\n" 3319 " a),\n" 3320 " a),\n" 3321 " a),\n" 3322 " a),\n" 3323 " a)", 3324 getLLVMStyleWithColumns(65)); 3325 3326 // This test takes VERY long when memoization is broken. 3327 FormatStyle OnePerLine = getLLVMStyle(); 3328 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3329 OnePerLine.BinPackParameters = false; 3330 std::string input = "Constructor()\n" 3331 " : aaaa(a,\n"; 3332 for (unsigned i = 0, e = 80; i != e; ++i) { 3333 input += " a,\n"; 3334 } 3335 input += " a) {}"; 3336 verifyFormat(input, OnePerLine); 3337 } 3338 3339 TEST_F(FormatTest, BreaksAsHighAsPossible) { 3340 verifyFormat( 3341 "void f() {\n" 3342 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" 3343 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" 3344 " f();\n" 3345 "}"); 3346 verifyFormat("if (Intervals[i].getRange().getFirst() <\n" 3347 " Intervals[i - 1].getRange().getLast()) {\n}"); 3348 } 3349 3350 TEST_F(FormatTest, BreaksFunctionDeclarations) { 3351 // Principially, we break function declarations in a certain order: 3352 // 1) break amongst arguments. 3353 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" 3354 " Cccccccccccccc cccccccccccccc);"); 3355 verifyFormat( 3356 "template <class TemplateIt>\n" 3357 "SomeReturnType SomeFunction(TemplateIt begin, TemplateIt end,\n" 3358 " TemplateIt *stop) {}"); 3359 3360 // 2) break after return type. 3361 verifyFormat( 3362 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3363 "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);", 3364 getGoogleStyle()); 3365 3366 // 3) break after (. 3367 verifyFormat( 3368 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" 3369 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);", 3370 getGoogleStyle()); 3371 3372 // 4) break before after nested name specifiers. 3373 verifyFormat( 3374 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3375 "SomeClasssssssssssssssssssssssssssssssssssssss::\n" 3376 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);", 3377 getGoogleStyle()); 3378 3379 // However, there are exceptions, if a sufficient amount of lines can be 3380 // saved. 3381 // FIXME: The precise cut-offs wrt. the number of saved lines might need some 3382 // more adjusting. 3383 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3384 " Cccccccccccccc cccccccccc,\n" 3385 " Cccccccccccccc cccccccccc,\n" 3386 " Cccccccccccccc cccccccccc,\n" 3387 " Cccccccccccccc cccccccccc);"); 3388 verifyFormat( 3389 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3390 "bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3391 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3392 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);", 3393 getGoogleStyle()); 3394 verifyFormat( 3395 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3396 " Cccccccccccccc cccccccccc,\n" 3397 " Cccccccccccccc cccccccccc,\n" 3398 " Cccccccccccccc cccccccccc,\n" 3399 " Cccccccccccccc cccccccccc,\n" 3400 " Cccccccccccccc cccccccccc,\n" 3401 " Cccccccccccccc cccccccccc);"); 3402 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3403 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3404 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3405 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3406 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); 3407 3408 // Break after multi-line parameters. 3409 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3410 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3411 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3412 " bbbb bbbb);"); 3413 3414 // Treat overloaded operators like other functions. 3415 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3416 "operator>(const SomeLoooooooooooooooooooooooooogType &other);"); 3417 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3418 "operator>>(const SomeLooooooooooooooooooooooooogType &other);"); 3419 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3420 "operator<<(const SomeLooooooooooooooooooooooooogType &other);"); 3421 verifyGoogleFormat( 3422 "SomeLoooooooooooooooooooooooooooooogType operator>>(\n" 3423 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3424 verifyGoogleFormat( 3425 "SomeLoooooooooooooooooooooooooooooogType operator<<(\n" 3426 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3427 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3428 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3429 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa\n" 3430 "aaaaaaaaaaaaaaaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3431 } 3432 3433 TEST_F(FormatTest, TrailingReturnType) { 3434 verifyFormat("auto foo() -> int;\n"); 3435 verifyFormat("struct S {\n" 3436 " auto bar() const -> int;\n" 3437 "};"); 3438 verifyFormat("template <size_t Order, typename T>\n" 3439 "auto load_img(const std::string &filename)\n" 3440 " -> alias::tensor<Order, T, mem::tag::cpu> {}"); 3441 3442 // Not trailing return types. 3443 verifyFormat("void f() { auto a = b->c(); }"); 3444 } 3445 3446 TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) { 3447 // Avoid breaking before trailing 'const' or other trailing annotations, if 3448 // they are not function-like. 3449 FormatStyle Style = getGoogleStyle(); 3450 Style.ColumnLimit = 47; 3451 verifyFormat("void\n" 3452 "someLongFunction(int someLongParameter) const {\n}", 3453 getLLVMStyleWithColumns(47)); 3454 verifyFormat("LoooooongReturnType\n" 3455 "someLoooooooongFunction() const {}", 3456 getLLVMStyleWithColumns(47)); 3457 verifyFormat("LoooooongReturnType someLoooooooongFunction()\n" 3458 " const {}", 3459 Style); 3460 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3461 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE;"); 3462 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3463 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE FINAL;"); 3464 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3465 " aaaaa aaaaaaaaaaaaaaaaaaaa) override final;"); 3466 verifyFormat("virtual void aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa,\n" 3467 " aaaaaaaaaaa aaaaa) const override;"); 3468 verifyGoogleFormat( 3469 "virtual void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3470 " const override;"); 3471 3472 // Even if the first parameter has to be wrapped. 3473 verifyFormat("void someLongFunction(\n" 3474 " int someLongParameter) const {}", 3475 getLLVMStyleWithColumns(46)); 3476 verifyFormat("void someLongFunction(\n" 3477 " int someLongParameter) const {}", 3478 Style); 3479 verifyFormat("void someLongFunction(\n" 3480 " int someLongParameter) override {}", 3481 Style); 3482 verifyFormat("void someLongFunction(\n" 3483 " int someLongParameter) OVERRIDE {}", 3484 Style); 3485 verifyFormat("void someLongFunction(\n" 3486 " int someLongParameter) final {}", 3487 Style); 3488 verifyFormat("void someLongFunction(\n" 3489 " int someLongParameter) FINAL {}", 3490 Style); 3491 verifyFormat("void someLongFunction(\n" 3492 " int parameter) const override {}", 3493 Style); 3494 3495 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 3496 verifyFormat("void someLongFunction(\n" 3497 " int someLongParameter) const\n" 3498 "{\n" 3499 "}", 3500 Style); 3501 3502 // Unless these are unknown annotations. 3503 verifyFormat("void SomeFunction(aaaaaaaaaa aaaaaaaaaaaaaaa,\n" 3504 " aaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3505 " LONG_AND_UGLY_ANNOTATION;"); 3506 3507 // Breaking before function-like trailing annotations is fine to keep them 3508 // close to their arguments. 3509 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3510 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3511 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3512 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3513 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3514 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); 3515 verifyGoogleFormat("void aaaaaaaaaaaaaa(aaaaaaaa aaa) override\n" 3516 " AAAAAAAAAAAAAAAAAAAAAAAA(aaaaaaaaaaaaaaa);"); 3517 verifyFormat("SomeFunction([](int i) LOCKS_EXCLUDED(a) {});"); 3518 3519 verifyFormat( 3520 "void aaaaaaaaaaaaaaaaaa()\n" 3521 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" 3522 " aaaaaaaaaaaaaaaaaaaaaaaaa));"); 3523 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3524 " __attribute__((unused));"); 3525 verifyGoogleFormat( 3526 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3527 " GUARDED_BY(aaaaaaaaaaaa);"); 3528 verifyGoogleFormat( 3529 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3530 " GUARDED_BY(aaaaaaaaaaaa);"); 3531 verifyGoogleFormat( 3532 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =\n" 3533 " aaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3534 } 3535 3536 TEST_F(FormatTest, BreaksDesireably) { 3537 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3538 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3539 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); 3540 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3541 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 3542 "}"); 3543 3544 verifyFormat( 3545 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3546 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3547 3548 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3549 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3550 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3551 3552 verifyFormat( 3553 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3554 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3555 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3556 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); 3557 3558 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3559 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3560 3561 verifyFormat( 3562 "void f() {\n" 3563 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" 3564 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3565 "}"); 3566 verifyFormat( 3567 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3568 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3569 verifyFormat( 3570 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3571 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3572 verifyFormat( 3573 "aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3574 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3575 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3576 3577 // Indent consistently independent of call expression. 3578 verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccc(\n" 3579 " dddddddddddddddddddddddddddddd));\n" 3580 "aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3581 " dddddddddddddddddddddddddddddd));"); 3582 3583 // This test case breaks on an incorrect memoization, i.e. an optimization not 3584 // taking into account the StopAt value. 3585 verifyFormat( 3586 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3587 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3588 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3589 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3590 3591 verifyFormat("{\n {\n {\n" 3592 " Annotation.SpaceRequiredBefore =\n" 3593 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" 3594 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" 3595 " }\n }\n}"); 3596 3597 // Break on an outer level if there was a break on an inner level. 3598 EXPECT_EQ("f(g(h(a, // comment\n" 3599 " b, c),\n" 3600 " d, e),\n" 3601 " x, y);", 3602 format("f(g(h(a, // comment\n" 3603 " b, c), d, e), x, y);")); 3604 3605 // Prefer breaking similar line breaks. 3606 verifyFormat( 3607 "const int kTrackingOptions = NSTrackingMouseMoved |\n" 3608 " NSTrackingMouseEnteredAndExited |\n" 3609 " NSTrackingActiveAlways;"); 3610 } 3611 3612 TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { 3613 FormatStyle NoBinPacking = getGoogleStyle(); 3614 NoBinPacking.BinPackParameters = false; 3615 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" 3616 " aaaaaaaaaaaaaaaaaaaa,\n" 3617 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", 3618 NoBinPacking); 3619 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" 3620 " aaaaaaaaaaaaa,\n" 3621 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", 3622 NoBinPacking); 3623 verifyFormat( 3624 "aaaaaaaa(aaaaaaaaaaaaa,\n" 3625 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3626 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3627 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3628 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", 3629 NoBinPacking); 3630 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3631 " .aaaaaaaaaaaaaaaaaa();", 3632 NoBinPacking); 3633 verifyFormat("void f() {\n" 3634 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3635 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);\n" 3636 "}", 3637 NoBinPacking); 3638 3639 verifyFormat( 3640 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3641 " aaaaaaaaaaaa,\n" 3642 " aaaaaaaaaaaa);", 3643 NoBinPacking); 3644 verifyFormat( 3645 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" 3646 " ddddddddddddddddddddddddddddd),\n" 3647 " test);", 3648 NoBinPacking); 3649 3650 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" 3651 " aaaaaaaaaaaaaaaaaaaaaaa,\n" 3652 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;", 3653 NoBinPacking); 3654 verifyFormat("a(\"a\"\n" 3655 " \"a\",\n" 3656 " a);"); 3657 3658 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; 3659 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" 3660 " aaaaaaaaa,\n" 3661 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3662 NoBinPacking); 3663 verifyFormat( 3664 "void f() {\n" 3665 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3666 " .aaaaaaa();\n" 3667 "}", 3668 NoBinPacking); 3669 verifyFormat( 3670 "template <class SomeType, class SomeOtherType>\n" 3671 "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}", 3672 NoBinPacking); 3673 } 3674 3675 TEST_F(FormatTest, AdaptiveOnePerLineFormatting) { 3676 FormatStyle Style = getLLVMStyleWithColumns(15); 3677 Style.ExperimentalAutoDetectBinPacking = true; 3678 EXPECT_EQ("aaa(aaaa,\n" 3679 " aaaa,\n" 3680 " aaaa);\n" 3681 "aaa(aaaa,\n" 3682 " aaaa,\n" 3683 " aaaa);", 3684 format("aaa(aaaa,\n" // one-per-line 3685 " aaaa,\n" 3686 " aaaa );\n" 3687 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3688 Style)); 3689 EXPECT_EQ("aaa(aaaa, aaaa,\n" 3690 " aaaa);\n" 3691 "aaa(aaaa, aaaa,\n" 3692 " aaaa);", 3693 format("aaa(aaaa, aaaa,\n" // bin-packed 3694 " aaaa );\n" 3695 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3696 Style)); 3697 } 3698 3699 TEST_F(FormatTest, FormatsBuilderPattern) { 3700 verifyFormat( 3701 "return llvm::StringSwitch<Reference::Kind>(name)\n" 3702 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" 3703 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME)\n" 3704 " .StartsWith(\".init\", ORDER_INIT)\n" 3705 " .StartsWith(\".fini\", ORDER_FINI)\n" 3706 " .StartsWith(\".hash\", ORDER_HASH)\n" 3707 " .Default(ORDER_TEXT);\n"); 3708 3709 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" 3710 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); 3711 verifyFormat( 3712 "aaaaaaa->aaaaaaa->aaaaaaaaaaaaaaaa(\n" 3713 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3714 " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); 3715 verifyFormat( 3716 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" 3717 " aaaaaaaaaaaaaa);"); 3718 verifyFormat( 3719 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa =\n" 3720 " aaaaaa->aaaaaaaaaaaa()\n" 3721 " ->aaaaaaaaaaaaaaaa(\n" 3722 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3723 " ->aaaaaaaaaaaaaaaaa();"); 3724 verifyGoogleFormat( 3725 "void f() {\n" 3726 " someo->Add((new util::filetools::Handler(dir))\n" 3727 " ->OnEvent1(NewPermanentCallback(\n" 3728 " this, &HandlerHolderClass::EventHandlerCBA))\n" 3729 " ->OnEvent2(NewPermanentCallback(\n" 3730 " this, &HandlerHolderClass::EventHandlerCBB))\n" 3731 " ->OnEvent3(NewPermanentCallback(\n" 3732 " this, &HandlerHolderClass::EventHandlerCBC))\n" 3733 " ->OnEvent5(NewPermanentCallback(\n" 3734 " this, &HandlerHolderClass::EventHandlerCBD))\n" 3735 " ->OnEvent6(NewPermanentCallback(\n" 3736 " this, &HandlerHolderClass::EventHandlerCBE)));\n" 3737 "}"); 3738 3739 verifyFormat( 3740 "aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa();"); 3741 verifyFormat("aaaaaaaaaaaaaaa()\n" 3742 " .aaaaaaaaaaaaaaa()\n" 3743 " .aaaaaaaaaaaaaaa()\n" 3744 " .aaaaaaaaaaaaaaa()\n" 3745 " .aaaaaaaaaaaaaaa();"); 3746 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3747 " .aaaaaaaaaaaaaaa()\n" 3748 " .aaaaaaaaaaaaaaa()\n" 3749 " .aaaaaaaaaaaaaaa();"); 3750 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3751 " .aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3752 " .aaaaaaaaaaaaaaa();"); 3753 verifyFormat("aaaaaaaaaaaaa->aaaaaaaaaaaaaaaaaaaaaaaa()\n" 3754 " ->aaaaaaaaaaaaaae(0)\n" 3755 " ->aaaaaaaaaaaaaaa();"); 3756 3757 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3758 " .aaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3759 " .has<bbbbbbbbbbbbbbbbbbbbb>();"); 3760 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3761 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 3762 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); 3763 3764 // Prefer not to break after empty parentheses. 3765 verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" 3766 " First->LastNewlineOffset);"); 3767 } 3768 3769 TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { 3770 verifyFormat( 3771 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3772 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); 3773 verifyFormat( 3774 "if (aaaaaaaaaaaaaaaaaaaaaaaaa or\n" 3775 " bbbbbbbbbbbbbbbbbbbbbbbbb and cccccccccccccccccccccccc) {\n}"); 3776 3777 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3778 " ccccccccccccccccccccccccc) {\n}"); 3779 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa and bbbbbbbbbbbbbbbbbbbbbbbb or\n" 3780 " ccccccccccccccccccccccccc) {\n}"); 3781 3782 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3783 " ccccccccccccccccccccccccc) {\n}"); 3784 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb or\n" 3785 " ccccccccccccccccccccccccc) {\n}"); 3786 3787 verifyFormat( 3788 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" 3789 " ccccccccccccccccccccccccc) {\n}"); 3790 verifyFormat( 3791 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb) and\n" 3792 " ccccccccccccccccccccccccc) {\n}"); 3793 3794 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" 3795 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" 3796 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" 3797 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 3798 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA or\n" 3799 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB or\n" 3800 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC or\n" 3801 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 3802 3803 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" 3804 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" 3805 " aaaaaaaaaaaaaaa != aa) {\n}"); 3806 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa or\n" 3807 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) and\n" 3808 " aaaaaaaaaaaaaaa != aa) {\n}"); 3809 } 3810 3811 TEST_F(FormatTest, BreaksAfterAssignments) { 3812 verifyFormat( 3813 "unsigned Cost =\n" 3814 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" 3815 " SI->getPointerAddressSpaceee());\n"); 3816 verifyFormat( 3817 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" 3818 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); 3819 3820 verifyFormat( 3821 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa().aaaaaaaaa(\n" 3822 " aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); 3823 verifyFormat("unsigned OriginalStartColumn =\n" 3824 " SourceMgr.getSpellingColumnNumber(\n" 3825 " Current.FormatTok.getStartOfNonWhitespace()) -\n" 3826 " 1;"); 3827 } 3828 3829 TEST_F(FormatTest, AlignsAfterAssignments) { 3830 verifyFormat( 3831 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3832 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3833 verifyFormat( 3834 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3835 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3836 verifyFormat( 3837 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3838 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3839 verifyFormat( 3840 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3841 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3842 verifyFormat( 3843 "double LooooooooooooooooooooooooongResult = aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3844 " aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3845 " aaaaaaaaaaaaaaaaaaaaaaaa;"); 3846 } 3847 3848 TEST_F(FormatTest, AlignsAfterReturn) { 3849 verifyFormat( 3850 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3851 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3852 verifyFormat( 3853 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3854 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3855 verifyFormat( 3856 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3857 " aaaaaaaaaaaaaaaaaaaaaa();"); 3858 verifyFormat( 3859 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3860 " aaaaaaaaaaaaaaaaaaaaaa());"); 3861 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3862 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3863 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3864 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" 3865 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3866 verifyFormat("return\n" 3867 " // true if code is one of a or b.\n" 3868 " code == a || code == b;"); 3869 } 3870 3871 TEST_F(FormatTest, BreaksConditionalExpressions) { 3872 verifyFormat( 3873 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3874 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3875 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3876 verifyFormat( 3877 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3878 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3879 verifyFormat( 3880 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" 3881 " : aaaaaaaaaaaaa);"); 3882 verifyFormat( 3883 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3884 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3885 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3886 " aaaaaaaaaaaaa);"); 3887 verifyFormat( 3888 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3889 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3890 " aaaaaaaaaaaaa);"); 3891 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3892 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3893 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3894 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3895 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3896 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3897 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3898 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3899 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3900 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3901 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3902 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3903 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3904 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3905 " ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3906 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3907 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3908 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3909 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3910 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3911 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 3912 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3913 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3914 " : aaaaaaaaaaaaaaaa;"); 3915 verifyFormat( 3916 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3917 " ? aaaaaaaaaaaaaaa\n" 3918 " : aaaaaaaaaaaaaaa;"); 3919 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 3920 " aaaaaaaaa\n" 3921 " ? b\n" 3922 " : c);"); 3923 verifyFormat( 3924 "unsigned Indent =\n" 3925 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n" 3926 " ? IndentForLevel[TheLine.Level]\n" 3927 " : TheLine * 2,\n" 3928 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 3929 getLLVMStyleWithColumns(70)); 3930 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3931 " ? aaaaaaaaaaaaaaa\n" 3932 " : bbbbbbbbbbbbbbb //\n" 3933 " ? ccccccccccccccc\n" 3934 " : ddddddddddddddd;"); 3935 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3936 " ? aaaaaaaaaaaaaaa\n" 3937 " : (bbbbbbbbbbbbbbb //\n" 3938 " ? ccccccccccccccc\n" 3939 " : ddddddddddddddd);"); 3940 verifyFormat( 3941 "int aaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3942 " ? aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3943 " aaaaaaaaaaaaaaaaaaaaa +\n" 3944 " aaaaaaaaaaaaaaaaaaaaa\n" 3945 " : aaaaaaaaaa;"); 3946 verifyFormat( 3947 "aaaaaa = aaaaaaaaaaaa\n" 3948 " ? aaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3949 " : aaaaaaaaaaaaaaaaaaaaaa\n" 3950 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3951 3952 FormatStyle NoBinPacking = getLLVMStyle(); 3953 NoBinPacking.BinPackParameters = false; 3954 verifyFormat( 3955 "void f() {\n" 3956 " g(aaa,\n" 3957 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3958 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3959 " ? aaaaaaaaaaaaaaa\n" 3960 " : aaaaaaaaaaaaaaa);\n" 3961 "}", 3962 NoBinPacking); 3963 verifyFormat( 3964 "void f() {\n" 3965 " g(aaa,\n" 3966 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3967 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3968 " ?: aaaaaaaaaaaaaaa);\n" 3969 "}", 3970 NoBinPacking); 3971 } 3972 3973 TEST_F(FormatTest, BreaksConditionalExpressionsAfterOperator) { 3974 FormatStyle Style = getLLVMStyle(); 3975 Style.BreakBeforeTernaryOperators = false; 3976 Style.ColumnLimit = 70; 3977 verifyFormat( 3978 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3979 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3980 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3981 Style); 3982 verifyFormat( 3983 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3984 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3985 Style); 3986 verifyFormat( 3987 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa) :\n" 3988 " aaaaaaaaaaaaa);", 3989 Style); 3990 verifyFormat( 3991 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3992 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3993 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3994 " aaaaaaaaaaaaa);", 3995 Style); 3996 verifyFormat( 3997 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3998 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3999 " aaaaaaaaaaaaa);", 4000 Style); 4001 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4002 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4003 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4004 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4005 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4006 Style); 4007 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4009 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4010 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4011 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4012 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4013 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4014 Style); 4015 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4016 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?:\n" 4017 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4018 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4019 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4020 Style); 4021 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4022 " aaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4023 " aaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4024 Style); 4025 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 4026 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4027 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4028 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4029 Style); 4030 verifyFormat( 4031 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4032 " aaaaaaaaaaaaaaa :\n" 4033 " aaaaaaaaaaaaaaa;", 4034 Style); 4035 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 4036 " aaaaaaaaa ?\n" 4037 " b :\n" 4038 " c);", 4039 Style); 4040 verifyFormat( 4041 "unsigned Indent =\n" 4042 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0 ?\n" 4043 " IndentForLevel[TheLine.Level] :\n" 4044 " TheLine * 2,\n" 4045 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 4046 Style); 4047 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4048 " aaaaaaaaaaaaaaa :\n" 4049 " bbbbbbbbbbbbbbb ? //\n" 4050 " ccccccccccccccc :\n" 4051 " ddddddddddddddd;", 4052 Style); 4053 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4054 " aaaaaaaaaaaaaaa :\n" 4055 " (bbbbbbbbbbbbbbb ? //\n" 4056 " ccccccccccccccc :\n" 4057 " ddddddddddddddd);", 4058 Style); 4059 } 4060 4061 TEST_F(FormatTest, DeclarationsOfMultipleVariables) { 4062 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" 4063 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); 4064 verifyFormat("bool a = true, b = false;"); 4065 4066 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4067 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" 4068 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" 4069 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); 4070 verifyFormat( 4071 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 4072 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" 4073 " d = e && f;"); 4074 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" 4075 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); 4076 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 4077 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); 4078 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" 4079 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); 4080 // FIXME: If multiple variables are defined, the "*" needs to move to the new 4081 // line. Also fix indent for breaking after the type, this looks bad. 4082 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*\n" 4083 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" 4084 " * b = bbbbbbbbbbbbbbbbbbb;", 4085 getGoogleStyle()); 4086 4087 // Not ideal, but pointer-with-type does not allow much here. 4088 verifyGoogleFormat( 4089 "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, * b = bbbbbbbbbbbbbbbbbbb,\n" 4090 " * b = bbbbbbbbbbbbbbbbbbb, * d = ddddddddddddddddddd;"); 4091 } 4092 4093 TEST_F(FormatTest, ConditionalExpressionsInBrackets) { 4094 verifyFormat("arr[foo ? bar : baz];"); 4095 verifyFormat("f()[foo ? bar : baz];"); 4096 verifyFormat("(a + b)[foo ? bar : baz];"); 4097 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); 4098 } 4099 4100 TEST_F(FormatTest, AlignsStringLiterals) { 4101 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" 4102 " \"short literal\");"); 4103 verifyFormat( 4104 "looooooooooooooooooooooooongFunction(\n" 4105 " \"short literal\"\n" 4106 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); 4107 verifyFormat("someFunction(\"Always break between multi-line\"\n" 4108 " \" string literals\",\n" 4109 " and, other, parameters);"); 4110 EXPECT_EQ("fun + \"1243\" /* comment */\n" 4111 " \"5678\";", 4112 format("fun + \"1243\" /* comment */\n" 4113 " \"5678\";", 4114 getLLVMStyleWithColumns(28))); 4115 EXPECT_EQ( 4116 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 4117 " \"aaaaaaaaaaaaaaaaaaaaa\"\n" 4118 " \"aaaaaaaaaaaaaaaa\";", 4119 format("aaaaaa =" 4120 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " 4121 "aaaaaaaaaaaaaaaaaaaaa\" " 4122 "\"aaaaaaaaaaaaaaaa\";")); 4123 verifyFormat("a = a + \"a\"\n" 4124 " \"a\"\n" 4125 " \"a\";"); 4126 verifyFormat("f(\"a\", \"b\"\n" 4127 " \"c\");"); 4128 4129 verifyFormat( 4130 "#define LL_FORMAT \"ll\"\n" 4131 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" 4132 " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); 4133 4134 verifyFormat("#define A(X) \\\n" 4135 " \"aaaaa\" #X \"bbbbbb\" \\\n" 4136 " \"ccccc\"", 4137 getLLVMStyleWithColumns(23)); 4138 verifyFormat("#define A \"def\"\n" 4139 "f(\"abc\" A \"ghi\"\n" 4140 " \"jkl\");"); 4141 4142 verifyFormat("f(L\"a\"\n" 4143 " L\"b\")"); 4144 verifyFormat("#define A(X) \\\n" 4145 " L\"aaaaa\" #X L\"bbbbbb\" \\\n" 4146 " L\"ccccc\"", 4147 getLLVMStyleWithColumns(25)); 4148 } 4149 4150 TEST_F(FormatTest, AlwaysBreakAfterDefinitionReturnType) { 4151 FormatStyle AfterType = getLLVMStyle(); 4152 AfterType.AlwaysBreakAfterDefinitionReturnType = true; 4153 verifyFormat("const char *\n" 4154 "f(void) {\n" // Break here. 4155 " return \"\";\n" 4156 "}\n" 4157 "const char *bar(void);\n", // No break here. 4158 AfterType); 4159 } 4160 4161 TEST_F(FormatTest, AlwaysBreakBeforeMultilineStrings) { 4162 FormatStyle NoBreak = getLLVMStyle(); 4163 NoBreak.AlwaysBreakBeforeMultilineStrings = false; 4164 FormatStyle Break = getLLVMStyle(); 4165 Break.AlwaysBreakBeforeMultilineStrings = true; 4166 verifyFormat("aaaa = \"bbbb\"\n" 4167 " \"cccc\";", 4168 NoBreak); 4169 verifyFormat("aaaa =\n" 4170 " \"bbbb\"\n" 4171 " \"cccc\";", 4172 Break); 4173 verifyFormat("aaaa(\"bbbb\"\n" 4174 " \"cccc\");", 4175 NoBreak); 4176 verifyFormat("aaaa(\n" 4177 " \"bbbb\"\n" 4178 " \"cccc\");", 4179 Break); 4180 verifyFormat("aaaa(qqq, \"bbbb\"\n" 4181 " \"cccc\");", 4182 NoBreak); 4183 verifyFormat("aaaa(qqq,\n" 4184 " \"bbbb\"\n" 4185 " \"cccc\");", 4186 Break); 4187 verifyFormat("aaaa(qqq,\n" 4188 " L\"bbbb\"\n" 4189 " L\"cccc\");", 4190 Break); 4191 4192 // As we break before unary operators, breaking right after them is bad. 4193 verifyFormat("string foo = abc ? \"x\"\n" 4194 " \"blah blah blah blah blah blah\"\n" 4195 " : \"y\";", 4196 Break); 4197 4198 // Don't break if there is no column gain. 4199 verifyFormat("f(\"aaaa\"\n" 4200 " \"bbbb\");", 4201 Break); 4202 4203 // Treat literals with escaped newlines like multi-line string literals. 4204 EXPECT_EQ("x = \"a\\\n" 4205 "b\\\n" 4206 "c\";", 4207 format("x = \"a\\\n" 4208 "b\\\n" 4209 "c\";", 4210 NoBreak)); 4211 EXPECT_EQ("x =\n" 4212 " \"a\\\n" 4213 "b\\\n" 4214 "c\";", 4215 format("x = \"a\\\n" 4216 "b\\\n" 4217 "c\";", 4218 Break)); 4219 4220 // Exempt ObjC strings for now. 4221 EXPECT_EQ("NSString *const kString = @\"aaaa\"\n" 4222 " \"bbbb\";", 4223 format("NSString *const kString = @\"aaaa\"\n" 4224 "\"bbbb\";", 4225 Break)); 4226 } 4227 4228 TEST_F(FormatTest, AlignsPipes) { 4229 verifyFormat( 4230 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4231 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4232 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4233 verifyFormat( 4234 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" 4235 " << aaaaaaaaaaaaaaaaaaaa;"); 4236 verifyFormat( 4237 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4238 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4239 verifyFormat( 4240 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" 4241 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" 4242 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); 4243 verifyFormat( 4244 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4245 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4246 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4247 verifyFormat( 4248 "llvm::errs() << \"a: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4249 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4250 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4251 verifyFormat( 4252 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4253 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4254 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4255 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4256 verifyFormat( 4257 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4258 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4259 4260 verifyFormat("return out << \"somepacket = {\\n\"\n" 4261 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" 4262 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" 4263 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" 4264 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" 4265 " << \"}\";"); 4266 4267 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4268 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4269 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa;"); 4270 verifyFormat( 4271 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" 4272 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" 4273 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" 4274 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" 4275 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); 4276 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" 4277 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4278 verifyFormat( 4279 "void f() {\n" 4280 " llvm::outs() << \"aaaaaaaaaaaaaaaaaaaa: \"\n" 4281 " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 4282 "}"); 4283 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \"\n" 4284 " << aaaaaaaa.aaaaaaaaaaaa(aaa)->aaaaaaaaaaaaaa();"); 4285 4286 // Breaking before the first "<<" is generally not desirable. 4287 verifyFormat( 4288 "llvm::errs()\n" 4289 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4290 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4291 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4292 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4293 getLLVMStyleWithColumns(70)); 4294 verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4295 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4296 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4297 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4298 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4299 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4300 getLLVMStyleWithColumns(70)); 4301 4302 // But sometimes, breaking before the first "<<" is desirable. 4303 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" 4304 " << aaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaa);"); 4305 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbb)\n" 4306 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4307 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4308 verifyFormat("SemaRef.Diag(Loc, diag::note_for_range_begin_end)\n" 4309 " << BEF << IsTemplate << Description << E->getType();"); 4310 4311 verifyFormat( 4312 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4313 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4314 4315 // Incomplete string literal. 4316 EXPECT_EQ("llvm::errs() << \"\n" 4317 " << a;", 4318 format("llvm::errs() << \"\n<<a;")); 4319 4320 verifyFormat("void f() {\n" 4321 " CHECK_EQ(aaaa, (*bbbbbbbbb)->cccccc)\n" 4322 " << \"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\";\n" 4323 "}"); 4324 } 4325 4326 TEST_F(FormatTest, UnderstandsEquals) { 4327 verifyFormat( 4328 "aaaaaaaaaaaaaaaaa =\n" 4329 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4330 verifyFormat( 4331 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4332 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4333 verifyFormat( 4334 "if (a) {\n" 4335 " f();\n" 4336 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4337 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 4338 "}"); 4339 4340 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4341 " 100000000 + 10000000) {\n}"); 4342 } 4343 4344 TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { 4345 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4346 " .looooooooooooooooooooooooooooooooooooooongFunction();"); 4347 4348 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4349 " ->looooooooooooooooooooooooooooooooooooooongFunction();"); 4350 4351 verifyFormat( 4352 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" 4353 " Parameter2);"); 4354 4355 verifyFormat( 4356 "ShortObject->shortFunction(\n" 4357 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" 4358 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); 4359 4360 verifyFormat("loooooooooooooongFunction(\n" 4361 " LoooooooooooooongObject->looooooooooooooooongFunction());"); 4362 4363 verifyFormat( 4364 "function(LoooooooooooooooooooooooooooooooooooongObject\n" 4365 " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); 4366 4367 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" 4368 " .WillRepeatedly(Return(SomeValue));"); 4369 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)].insert(\n" 4370 " ccccccccccccccccccccccc);"); 4371 verifyFormat("aaaaa(aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4372 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).aaaaa(aaaaa),\n" 4373 " aaaaaaaaaaaaaaaaaaaaa);"); 4374 verifyFormat("void f() {\n" 4375 " aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4376 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa)->aaaaaaaaa());\n" 4377 "}"); 4378 verifyFormat( 4379 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4380 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4381 " .aaaaaaaaaaaaaaa(aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4382 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4383 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 4384 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4385 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4386 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4387 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" 4388 "}"); 4389 4390 // Here, it is not necessary to wrap at "." or "->". 4391 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" 4392 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4393 verifyFormat( 4394 "aaaaaaaaaaa->aaaaaaaaa(\n" 4395 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4396 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); 4397 4398 verifyFormat( 4399 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4400 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); 4401 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" 4402 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4403 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" 4404 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4405 4406 // FIXME: Should we break before .a()? 4407 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4408 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();"); 4409 4410 FormatStyle NoBinPacking = getLLVMStyle(); 4411 NoBinPacking.BinPackParameters = false; 4412 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4413 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4414 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" 4415 " aaaaaaaaaaaaaaaaaaa,\n" 4416 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4417 NoBinPacking); 4418 4419 // If there is a subsequent call, change to hanging indentation. 4420 verifyFormat( 4421 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4422 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa))\n" 4423 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4424 verifyFormat( 4425 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4426 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa));"); 4427 verifyFormat("aaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4428 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4429 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4430 verifyFormat("aaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4431 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4432 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4433 } 4434 4435 TEST_F(FormatTest, WrapsTemplateDeclarations) { 4436 verifyFormat("template <typename T>\n" 4437 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4438 verifyFormat("template <typename T>\n" 4439 "// T should be one of {A, B}.\n" 4440 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4441 verifyFormat( 4442 "template <typename T>\n" 4443 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); 4444 verifyFormat("template <typename T>\n" 4445 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" 4446 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); 4447 verifyFormat( 4448 "template <typename T>\n" 4449 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" 4450 " int Paaaaaaaaaaaaaaaaaaaaram2);"); 4451 verifyFormat( 4452 "template <typename T>\n" 4453 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" 4454 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" 4455 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4456 verifyFormat("template <typename T>\n" 4457 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4458 " int aaaaaaaaaaaaaaaaaaaaaa);"); 4459 verifyFormat( 4460 "template <typename T1, typename T2 = char, typename T3 = char,\n" 4461 " typename T4 = char>\n" 4462 "void f();"); 4463 verifyFormat("template <typename aaaaaaaaaaa, typename bbbbbbbbbbbbb,\n" 4464 " template <typename> class cccccccccccccccccccccc,\n" 4465 " typename ddddddddddddd>\n" 4466 "class C {};"); 4467 verifyFormat( 4468 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" 4469 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4470 4471 verifyFormat("void f() {\n" 4472 " a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" 4473 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));\n" 4474 "}"); 4475 4476 verifyFormat("template <typename T> class C {};"); 4477 verifyFormat("template <typename T> void f();"); 4478 verifyFormat("template <typename T> void f() {}"); 4479 verifyFormat( 4480 "aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4481 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4482 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> *aaaa =\n" 4483 " new aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4484 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4485 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>(\n" 4486 " bbbbbbbbbbbbbbbbbbbbbbbb);", 4487 getLLVMStyleWithColumns(72)); 4488 EXPECT_EQ("static_cast<A< //\n" 4489 " B> *>(\n" 4490 "\n" 4491 " );", 4492 format("static_cast<A<//\n" 4493 " B>*>(\n" 4494 "\n" 4495 " );")); 4496 4497 FormatStyle AlwaysBreak = getLLVMStyle(); 4498 AlwaysBreak.AlwaysBreakTemplateDeclarations = true; 4499 verifyFormat("template <typename T>\nclass C {};", AlwaysBreak); 4500 verifyFormat("template <typename T>\nvoid f();", AlwaysBreak); 4501 verifyFormat("template <typename T>\nvoid f() {}", AlwaysBreak); 4502 verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4503 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" 4504 " ccccccccccccccccccccccccccccccccccccccccccccccc);"); 4505 verifyFormat("template <template <typename> class Fooooooo,\n" 4506 " template <typename> class Baaaaaaar>\n" 4507 "struct C {};", 4508 AlwaysBreak); 4509 verifyFormat("template <typename T> // T can be A, B or C.\n" 4510 "struct C {};", 4511 AlwaysBreak); 4512 } 4513 4514 TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { 4515 verifyFormat( 4516 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4517 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4518 verifyFormat( 4519 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4520 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4521 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4522 4523 // FIXME: Should we have the extra indent after the second break? 4524 verifyFormat( 4525 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4526 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4527 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4528 4529 verifyFormat( 4530 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" 4531 " cccccccccccccccccccccccccccccccccccccccccccccc());"); 4532 4533 // Breaking at nested name specifiers is generally not desirable. 4534 verifyFormat( 4535 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4536 " aaaaaaaaaaaaaaaaaaaaaaa);"); 4537 4538 verifyFormat( 4539 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4540 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4541 " aaaaaaaaaaaaaaaaaaaaa);", 4542 getLLVMStyleWithColumns(74)); 4543 4544 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4545 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4546 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4547 } 4548 4549 TEST_F(FormatTest, UnderstandsTemplateParameters) { 4550 verifyFormat("A<int> a;"); 4551 verifyFormat("A<A<A<int>>> a;"); 4552 verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); 4553 verifyFormat("bool x = a < 1 || 2 > a;"); 4554 verifyFormat("bool x = 5 < f<int>();"); 4555 verifyFormat("bool x = f<int>() > 5;"); 4556 verifyFormat("bool x = 5 < a<int>::x;"); 4557 verifyFormat("bool x = a < 4 ? a > 2 : false;"); 4558 verifyFormat("bool x = f() ? a < 2 : a > 2;"); 4559 4560 verifyGoogleFormat("A<A<int>> a;"); 4561 verifyGoogleFormat("A<A<A<int>>> a;"); 4562 verifyGoogleFormat("A<A<A<A<int>>>> a;"); 4563 verifyGoogleFormat("A<A<int> > a;"); 4564 verifyGoogleFormat("A<A<A<int> > > a;"); 4565 verifyGoogleFormat("A<A<A<A<int> > > > a;"); 4566 verifyGoogleFormat("A<::A<int>> a;"); 4567 verifyGoogleFormat("A<::A> a;"); 4568 verifyGoogleFormat("A< ::A> a;"); 4569 verifyGoogleFormat("A< ::A<int> > a;"); 4570 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); 4571 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); 4572 EXPECT_EQ("A<::A<int>> a;", format("A< ::A<int>> a;", getGoogleStyle())); 4573 EXPECT_EQ("A<::A<int>> a;", format("A<::A<int> > a;", getGoogleStyle())); 4574 4575 verifyFormat("test >> a >> b;"); 4576 verifyFormat("test << a >> b;"); 4577 4578 verifyFormat("f<int>();"); 4579 verifyFormat("template <typename T> void f() {}"); 4580 4581 // Not template parameters. 4582 verifyFormat("return a < b && c > d;"); 4583 verifyFormat("void f() {\n" 4584 " while (a < b && c > d) {\n" 4585 " }\n" 4586 "}"); 4587 verifyFormat("template <typename... Types>\n" 4588 "typename enable_if<0 < sizeof...(Types)>::type Foo() {}"); 4589 4590 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4591 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);", 4592 getLLVMStyleWithColumns(60)); 4593 verifyFormat("static_assert(is_convertible<A &&, B>::value, \"AAA\");"); 4594 verifyFormat("Constructor(A... a) : a_(X<A>{std::forward<A>(a)}...) {}"); 4595 } 4596 4597 TEST_F(FormatTest, UnderstandsBinaryOperators) { 4598 verifyFormat("COMPARE(a, ==, b);"); 4599 } 4600 4601 TEST_F(FormatTest, UnderstandsPointersToMembers) { 4602 verifyFormat("int A::*x;"); 4603 verifyFormat("int (S::*func)(void *);"); 4604 verifyFormat("void f() { int (S::*func)(void *); }"); 4605 verifyFormat("typedef bool *(Class::*Member)() const;"); 4606 verifyFormat("void f() {\n" 4607 " (a->*f)();\n" 4608 " a->*x;\n" 4609 " (a.*f)();\n" 4610 " ((*a).*f)();\n" 4611 " a.*x;\n" 4612 "}"); 4613 verifyFormat("void f() {\n" 4614 " (a->*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 4615 " aaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);\n" 4616 "}"); 4617 verifyFormat( 4618 "(aaaaaaaaaa->*bbbbbbb)(\n" 4619 " aaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 4620 FormatStyle Style = getLLVMStyle(); 4621 Style.PointerAlignment = FormatStyle::PAS_Left; 4622 verifyFormat("typedef bool* (Class::*Member)() const;", Style); 4623 } 4624 4625 TEST_F(FormatTest, UnderstandsUnaryOperators) { 4626 verifyFormat("int a = -2;"); 4627 verifyFormat("f(-1, -2, -3);"); 4628 verifyFormat("a[-1] = 5;"); 4629 verifyFormat("int a = 5 + -2;"); 4630 verifyFormat("if (i == -1) {\n}"); 4631 verifyFormat("if (i != -1) {\n}"); 4632 verifyFormat("if (i > -1) {\n}"); 4633 verifyFormat("if (i < -1) {\n}"); 4634 verifyFormat("++(a->f());"); 4635 verifyFormat("--(a->f());"); 4636 verifyFormat("(a->f())++;"); 4637 verifyFormat("a[42]++;"); 4638 verifyFormat("if (!(a->f())) {\n}"); 4639 4640 verifyFormat("a-- > b;"); 4641 verifyFormat("b ? -a : c;"); 4642 verifyFormat("n * sizeof char16;"); 4643 verifyFormat("n * alignof char16;", getGoogleStyle()); 4644 verifyFormat("sizeof(char);"); 4645 verifyFormat("alignof(char);", getGoogleStyle()); 4646 4647 verifyFormat("return -1;"); 4648 verifyFormat("switch (a) {\n" 4649 "case -1:\n" 4650 " break;\n" 4651 "}"); 4652 verifyFormat("#define X -1"); 4653 verifyFormat("#define X -kConstant"); 4654 4655 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {-5, +3};"); 4656 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {+5, -3};"); 4657 4658 verifyFormat("int a = /* confusing comment */ -1;"); 4659 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. 4660 verifyFormat("int a = i /* confusing comment */++;"); 4661 } 4662 4663 TEST_F(FormatTest, DoesNotIndentRelativeToUnaryOperators) { 4664 verifyFormat("if (!aaaaaaaaaa( // break\n" 4665 " aaaaa)) {\n" 4666 "}"); 4667 verifyFormat("aaaaaaaaaa(!aaaaaaaaaa( // break\n" 4668 " aaaaa));"); 4669 verifyFormat("*aaa = aaaaaaa( // break\n" 4670 " bbbbbb);"); 4671 } 4672 4673 TEST_F(FormatTest, UnderstandsOverloadedOperators) { 4674 verifyFormat("bool operator<();"); 4675 verifyFormat("bool operator>();"); 4676 verifyFormat("bool operator=();"); 4677 verifyFormat("bool operator==();"); 4678 verifyFormat("bool operator!=();"); 4679 verifyFormat("int operator+();"); 4680 verifyFormat("int operator++();"); 4681 verifyFormat("bool operator();"); 4682 verifyFormat("bool operator()();"); 4683 verifyFormat("bool operator[]();"); 4684 verifyFormat("operator bool();"); 4685 verifyFormat("operator int();"); 4686 verifyFormat("operator void *();"); 4687 verifyFormat("operator SomeType<int>();"); 4688 verifyFormat("operator SomeType<int, int>();"); 4689 verifyFormat("operator SomeType<SomeType<int>>();"); 4690 verifyFormat("void *operator new(std::size_t size);"); 4691 verifyFormat("void *operator new[](std::size_t size);"); 4692 verifyFormat("void operator delete(void *ptr);"); 4693 verifyFormat("void operator delete[](void *ptr);"); 4694 verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n" 4695 "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);"); 4696 4697 verifyFormat( 4698 "ostream &operator<<(ostream &OutputStream,\n" 4699 " SomeReallyLongType WithSomeReallyLongValue);"); 4700 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" 4701 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" 4702 " return left.group < right.group;\n" 4703 "}"); 4704 verifyFormat("SomeType &operator=(const SomeType &S);"); 4705 4706 verifyGoogleFormat("operator void*();"); 4707 verifyGoogleFormat("operator SomeType<SomeType<int>>();"); 4708 verifyGoogleFormat("operator ::A();"); 4709 4710 verifyFormat("using A::operator+;"); 4711 4712 verifyFormat("Deleted &operator=(const Deleted &)& = default;"); 4713 verifyFormat("Deleted &operator=(const Deleted &)&& = delete;"); 4714 verifyGoogleFormat("Deleted& operator=(const Deleted&)& = default;"); 4715 verifyGoogleFormat("Deleted& operator=(const Deleted&)&& = delete;"); 4716 4717 verifyFormat("string // break\n" 4718 "operator()() & {}"); 4719 verifyFormat("string // break\n" 4720 "operator()() && {}"); 4721 } 4722 4723 TEST_F(FormatTest, UnderstandsNewAndDelete) { 4724 verifyFormat("void f() {\n" 4725 " A *a = new A;\n" 4726 " A *a = new (placement) A;\n" 4727 " delete a;\n" 4728 " delete (A *)a;\n" 4729 "}"); 4730 verifyFormat("new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 4731 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 4732 verifyFormat("auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4733 " new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 4734 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 4735 } 4736 4737 TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { 4738 verifyFormat("int *f(int *a) {}"); 4739 verifyFormat("int main(int argc, char **argv) {}"); 4740 verifyFormat("Test::Test(int b) : a(b * b) {}"); 4741 verifyIndependentOfContext("f(a, *a);"); 4742 verifyFormat("void g() { f(*a); }"); 4743 verifyIndependentOfContext("int a = b * 10;"); 4744 verifyIndependentOfContext("int a = 10 * b;"); 4745 verifyIndependentOfContext("int a = b * c;"); 4746 verifyIndependentOfContext("int a += b * c;"); 4747 verifyIndependentOfContext("int a -= b * c;"); 4748 verifyIndependentOfContext("int a *= b * c;"); 4749 verifyIndependentOfContext("int a /= b * c;"); 4750 verifyIndependentOfContext("int a = *b;"); 4751 verifyIndependentOfContext("int a = *b * c;"); 4752 verifyIndependentOfContext("int a = b * *c;"); 4753 verifyIndependentOfContext("return 10 * b;"); 4754 verifyIndependentOfContext("return *b * *c;"); 4755 verifyIndependentOfContext("return a & ~b;"); 4756 verifyIndependentOfContext("f(b ? *c : *d);"); 4757 verifyIndependentOfContext("int a = b ? *c : *d;"); 4758 verifyIndependentOfContext("*b = a;"); 4759 verifyIndependentOfContext("a * ~b;"); 4760 verifyIndependentOfContext("a * !b;"); 4761 verifyIndependentOfContext("a * +b;"); 4762 verifyIndependentOfContext("a * -b;"); 4763 verifyIndependentOfContext("a * ++b;"); 4764 verifyIndependentOfContext("a * --b;"); 4765 verifyIndependentOfContext("a[4] * b;"); 4766 verifyIndependentOfContext("a[a * a] = 1;"); 4767 verifyIndependentOfContext("f() * b;"); 4768 verifyIndependentOfContext("a * [self dostuff];"); 4769 verifyIndependentOfContext("int x = a * (a + b);"); 4770 verifyIndependentOfContext("(a *)(a + b);"); 4771 verifyIndependentOfContext("*(int *)(p & ~3UL) = 0;"); 4772 verifyIndependentOfContext("int *pa = (int *)&a;"); 4773 verifyIndependentOfContext("return sizeof(int **);"); 4774 verifyIndependentOfContext("return sizeof(int ******);"); 4775 verifyIndependentOfContext("return (int **&)a;"); 4776 verifyIndependentOfContext("f((*PointerToArray)[10]);"); 4777 verifyFormat("void f(Type (*parameter)[10]) {}"); 4778 verifyGoogleFormat("return sizeof(int**);"); 4779 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); 4780 verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); 4781 verifyFormat("auto a = [](int **&, int ***) {};"); 4782 verifyFormat("auto PointerBinding = [](const char *S) {};"); 4783 verifyFormat("typedef typeof(int(int, int)) *MyFunc;"); 4784 verifyFormat("[](const decltype(*a) &value) {}"); 4785 verifyIndependentOfContext("typedef void (*f)(int *a);"); 4786 verifyIndependentOfContext("int i{a * b};"); 4787 verifyIndependentOfContext("aaa && aaa->f();"); 4788 verifyIndependentOfContext("int x = ~*p;"); 4789 4790 verifyIndependentOfContext("InvalidRegions[*R] = 0;"); 4791 4792 verifyIndependentOfContext("A<int *> a;"); 4793 verifyIndependentOfContext("A<int **> a;"); 4794 verifyIndependentOfContext("A<int *, int *> a;"); 4795 verifyIndependentOfContext("A<int *[]> a;"); 4796 verifyIndependentOfContext( 4797 "const char *const p = reinterpret_cast<const char *const>(q);"); 4798 verifyIndependentOfContext("A<int **, int **> a;"); 4799 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); 4800 verifyFormat("for (char **a = b; *a; ++a) {\n}"); 4801 verifyFormat("for (; a && b;) {\n}"); 4802 verifyFormat("bool foo = true && [] { return false; }();"); 4803 4804 verifyFormat( 4805 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4806 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4807 4808 verifyGoogleFormat("int main(int argc, char** argv) {}"); 4809 verifyGoogleFormat("A<int*> a;"); 4810 verifyGoogleFormat("A<int**> a;"); 4811 verifyGoogleFormat("A<int*, int*> a;"); 4812 verifyGoogleFormat("A<int**, int**> a;"); 4813 verifyGoogleFormat("f(b ? *c : *d);"); 4814 verifyGoogleFormat("int a = b ? *c : *d;"); 4815 verifyGoogleFormat("Type* t = **x;"); 4816 verifyGoogleFormat("Type* t = *++*x;"); 4817 verifyGoogleFormat("*++*x;"); 4818 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); 4819 verifyGoogleFormat("Type* t = x++ * y;"); 4820 verifyGoogleFormat( 4821 "const char* const p = reinterpret_cast<const char* const>(q);"); 4822 verifyGoogleFormat("void f(int i = 0, SomeType** temps = NULL);"); 4823 4824 verifyIndependentOfContext("a = *(x + y);"); 4825 verifyIndependentOfContext("a = &(x + y);"); 4826 verifyIndependentOfContext("*(x + y).call();"); 4827 verifyIndependentOfContext("&(x + y)->call();"); 4828 verifyFormat("void f() { &(*I).first; }"); 4829 4830 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); 4831 verifyFormat( 4832 "int *MyValues = {\n" 4833 " *A, // Operator detection might be confused by the '{'\n" 4834 " *BB // Operator detection might be confused by previous comment\n" 4835 "};"); 4836 4837 verifyIndependentOfContext("if (int *a = &b)"); 4838 verifyIndependentOfContext("if (int &a = *b)"); 4839 verifyIndependentOfContext("if (a & b[i])"); 4840 verifyIndependentOfContext("if (a::b::c::d & b[i])"); 4841 verifyIndependentOfContext("if (*b[i])"); 4842 verifyIndependentOfContext("if (int *a = (&b))"); 4843 verifyIndependentOfContext("while (int *a = &b)"); 4844 verifyIndependentOfContext("size = sizeof *a;"); 4845 verifyFormat("void f() {\n" 4846 " for (const int &v : Values) {\n" 4847 " }\n" 4848 "}"); 4849 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); 4850 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); 4851 verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); 4852 4853 verifyFormat("#define A (!a * b)"); 4854 verifyFormat("#define MACRO \\\n" 4855 " int *i = a * b; \\\n" 4856 " void f(a *b);", 4857 getLLVMStyleWithColumns(19)); 4858 4859 verifyIndependentOfContext("A = new SomeType *[Length];"); 4860 verifyIndependentOfContext("A = new SomeType *[Length]();"); 4861 verifyIndependentOfContext("T **t = new T *;"); 4862 verifyIndependentOfContext("T **t = new T *();"); 4863 verifyGoogleFormat("A = new SomeType* [Length]();"); 4864 verifyGoogleFormat("A = new SomeType* [Length];"); 4865 verifyGoogleFormat("T** t = new T*;"); 4866 verifyGoogleFormat("T** t = new T*();"); 4867 4868 FormatStyle PointerLeft = getLLVMStyle(); 4869 PointerLeft.PointerAlignment = FormatStyle::PAS_Left; 4870 verifyFormat("delete *x;", PointerLeft); 4871 verifyFormat("STATIC_ASSERT((a & b) == 0);"); 4872 verifyFormat("STATIC_ASSERT(0 == (a & b));"); 4873 verifyFormat("template <bool a, bool b> " 4874 "typename t::if<x && y>::type f() {}"); 4875 verifyFormat("template <int *y> f() {}"); 4876 verifyFormat("vector<int *> v;"); 4877 verifyFormat("vector<int *const> v;"); 4878 verifyFormat("vector<int *const **const *> v;"); 4879 verifyFormat("vector<int *volatile> v;"); 4880 verifyFormat("vector<a * b> v;"); 4881 verifyFormat("foo<b && false>();"); 4882 verifyFormat("foo<b & 1>();"); 4883 4884 verifyIndependentOfContext("MACRO(int *i);"); 4885 verifyIndependentOfContext("MACRO(auto *a);"); 4886 verifyIndependentOfContext("MACRO(const A *a);"); 4887 verifyIndependentOfContext("MACRO('0' <= c && c <= '9');"); 4888 // FIXME: Is there a way to make this work? 4889 // verifyIndependentOfContext("MACRO(A *a);"); 4890 4891 verifyFormat("DatumHandle const *operator->() const { return input_; }"); 4892 4893 EXPECT_EQ("#define OP(x) \\\n" 4894 " ostream &operator<<(ostream &s, const A &a) { \\\n" 4895 " return s << a.DebugString(); \\\n" 4896 " }", 4897 format("#define OP(x) \\\n" 4898 " ostream &operator<<(ostream &s, const A &a) { \\\n" 4899 " return s << a.DebugString(); \\\n" 4900 " }", 4901 getLLVMStyleWithColumns(50))); 4902 4903 // FIXME: We cannot handle this case yet; we might be able to figure out that 4904 // foo<x> d > v; doesn't make sense. 4905 verifyFormat("foo<a<b && c> d> v;"); 4906 4907 FormatStyle PointerMiddle = getLLVMStyle(); 4908 PointerMiddle.PointerAlignment = FormatStyle::PAS_Middle; 4909 verifyFormat("delete *x;", PointerMiddle); 4910 verifyFormat("int * x;", PointerMiddle); 4911 verifyFormat("template <int * y> f() {}", PointerMiddle); 4912 verifyFormat("int * f(int * a) {}", PointerMiddle); 4913 verifyFormat("int main(int argc, char ** argv) {}", PointerMiddle); 4914 verifyFormat("Test::Test(int b) : a(b * b) {}", PointerMiddle); 4915 verifyFormat("A<int *> a;", PointerMiddle); 4916 verifyFormat("A<int **> a;", PointerMiddle); 4917 verifyFormat("A<int *, int *> a;", PointerMiddle); 4918 verifyFormat("A<int * []> a;", PointerMiddle); 4919 verifyFormat("A = new SomeType * [Length]();", PointerMiddle); 4920 verifyFormat("A = new SomeType * [Length];", PointerMiddle); 4921 verifyFormat("T ** t = new T *;", PointerMiddle); 4922 } 4923 4924 TEST_F(FormatTest, UnderstandsAttributes) { 4925 verifyFormat("SomeType s __attribute__((unused)) (InitValue);"); 4926 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa __attribute__((unused))\n" 4927 "aaaaaaaaaaaaaaaaaaaaaaa(int i);"); 4928 } 4929 4930 TEST_F(FormatTest, UnderstandsEllipsis) { 4931 verifyFormat("int printf(const char *fmt, ...);"); 4932 verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); 4933 verifyFormat("template <class... Ts> void Foo(Ts *... ts) {}"); 4934 4935 FormatStyle PointersLeft = getLLVMStyle(); 4936 PointersLeft.PointerAlignment = FormatStyle::PAS_Left; 4937 verifyFormat("template <class... Ts> void Foo(Ts*... ts) {}", PointersLeft); 4938 } 4939 4940 TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { 4941 EXPECT_EQ("int *a;\n" 4942 "int *a;\n" 4943 "int *a;", 4944 format("int *a;\n" 4945 "int* a;\n" 4946 "int *a;", 4947 getGoogleStyle())); 4948 EXPECT_EQ("int* a;\n" 4949 "int* a;\n" 4950 "int* a;", 4951 format("int* a;\n" 4952 "int* a;\n" 4953 "int *a;", 4954 getGoogleStyle())); 4955 EXPECT_EQ("int *a;\n" 4956 "int *a;\n" 4957 "int *a;", 4958 format("int *a;\n" 4959 "int * a;\n" 4960 "int * a;", 4961 getGoogleStyle())); 4962 } 4963 4964 TEST_F(FormatTest, UnderstandsRvalueReferences) { 4965 verifyFormat("int f(int &&a) {}"); 4966 verifyFormat("int f(int a, char &&b) {}"); 4967 verifyFormat("void f() { int &&a = b; }"); 4968 verifyGoogleFormat("int f(int a, char&& b) {}"); 4969 verifyGoogleFormat("void f() { int&& a = b; }"); 4970 4971 verifyIndependentOfContext("A<int &&> a;"); 4972 verifyIndependentOfContext("A<int &&, int &&> a;"); 4973 verifyGoogleFormat("A<int&&> a;"); 4974 verifyGoogleFormat("A<int&&, int&&> a;"); 4975 4976 // Not rvalue references: 4977 verifyFormat("template <bool B, bool C> class A {\n" 4978 " static_assert(B && C, \"Something is wrong\");\n" 4979 "};"); 4980 verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))"); 4981 verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))"); 4982 verifyFormat("#define A(a, b) (a && b)"); 4983 } 4984 4985 TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { 4986 verifyFormat("void f() {\n" 4987 " x[aaaaaaaaa -\n" 4988 " b] = 23;\n" 4989 "}", 4990 getLLVMStyleWithColumns(15)); 4991 } 4992 4993 TEST_F(FormatTest, FormatsCasts) { 4994 verifyFormat("Type *A = static_cast<Type *>(P);"); 4995 verifyFormat("Type *A = (Type *)P;"); 4996 verifyFormat("Type *A = (vector<Type *, int *>)P;"); 4997 verifyFormat("int a = (int)(2.0f);"); 4998 verifyFormat("int a = (int)2.0f;"); 4999 verifyFormat("x[(int32)y];"); 5000 verifyFormat("x = (int32)y;"); 5001 verifyFormat("#define AA(X) sizeof(((X *)NULL)->a)"); 5002 verifyFormat("int a = (int)*b;"); 5003 verifyFormat("int a = (int)2.0f;"); 5004 verifyFormat("int a = (int)~0;"); 5005 verifyFormat("int a = (int)++a;"); 5006 verifyFormat("int a = (int)sizeof(int);"); 5007 verifyFormat("int a = (int)+2;"); 5008 verifyFormat("my_int a = (my_int)2.0f;"); 5009 verifyFormat("my_int a = (my_int)sizeof(int);"); 5010 verifyFormat("return (my_int)aaa;"); 5011 verifyFormat("#define x ((int)-1)"); 5012 verifyFormat("#define p(q) ((int *)&q)"); 5013 verifyFormat("fn(a)(b) + 1;"); 5014 5015 verifyFormat("void f() { my_int a = (my_int)*b; }"); 5016 verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }"); 5017 verifyFormat("my_int a = (my_int)~0;"); 5018 verifyFormat("my_int a = (my_int)++a;"); 5019 verifyFormat("my_int a = (my_int)+2;"); 5020 verifyFormat("my_int a = (my_int)1;"); 5021 verifyFormat("my_int a = (my_int *)1;"); 5022 verifyFormat("my_int a = (const my_int)-1;"); 5023 verifyFormat("my_int a = (const my_int *)-1;"); 5024 5025 // FIXME: single value wrapped with paren will be treated as cast. 5026 verifyFormat("void f(int i = (kValue)*kMask) {}"); 5027 5028 verifyFormat("{ (void)F; }"); 5029 5030 // Don't break after a cast's 5031 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 5032 " (aaaaaaaaaaaaaaaaaaaaaaaaaa *)(aaaaaaaaaaaaaaaaaaaaaa +\n" 5033 " bbbbbbbbbbbbbbbbbbbbbb);"); 5034 5035 // These are not casts. 5036 verifyFormat("void f(int *) {}"); 5037 verifyFormat("f(foo)->b;"); 5038 verifyFormat("f(foo).b;"); 5039 verifyFormat("f(foo)(b);"); 5040 verifyFormat("f(foo)[b];"); 5041 verifyFormat("[](foo) { return 4; }(bar);"); 5042 verifyFormat("(*funptr)(foo)[4];"); 5043 verifyFormat("funptrs[4](foo)[4];"); 5044 verifyFormat("void f(int *);"); 5045 verifyFormat("void f(int *) = 0;"); 5046 verifyFormat("void f(SmallVector<int>) {}"); 5047 verifyFormat("void f(SmallVector<int>);"); 5048 verifyFormat("void f(SmallVector<int>) = 0;"); 5049 verifyFormat("void f(int i = (kA * kB) & kMask) {}"); 5050 verifyFormat("int a = sizeof(int) * b;"); 5051 verifyFormat("int a = alignof(int) * b;", getGoogleStyle()); 5052 verifyFormat("template <> void f<int>(int i) SOME_ANNOTATION;"); 5053 verifyFormat("f(\"%\" SOME_MACRO(ll) \"d\");"); 5054 verifyFormat("aaaaa &operator=(const aaaaa &) LLVM_DELETED_FUNCTION;"); 5055 5056 // These are not casts, but at some point were confused with casts. 5057 verifyFormat("virtual void foo(int *) override;"); 5058 verifyFormat("virtual void foo(char &) const;"); 5059 verifyFormat("virtual void foo(int *a, char *) const;"); 5060 verifyFormat("int a = sizeof(int *) + b;"); 5061 verifyFormat("int a = alignof(int *) + b;", getGoogleStyle()); 5062 5063 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *foo = (aaaaaaaaaaaaaaaaa *)\n" 5064 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 5065 // FIXME: The indentation here is not ideal. 5066 verifyFormat( 5067 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5068 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = (*cccccccccccccccc)\n" 5069 " [dddddddddddddddddddddddddddddddddddddddddddddddddddddddd];"); 5070 } 5071 5072 TEST_F(FormatTest, FormatsFunctionTypes) { 5073 verifyFormat("A<bool()> a;"); 5074 verifyFormat("A<SomeType()> a;"); 5075 verifyFormat("A<void (*)(int, std::string)> a;"); 5076 verifyFormat("A<void *(int)>;"); 5077 verifyFormat("void *(*a)(int *, SomeType *);"); 5078 verifyFormat("int (*func)(void *);"); 5079 verifyFormat("void f() { int (*func)(void *); }"); 5080 verifyFormat("template <class CallbackClass>\n" 5081 "using MyCallback = void (CallbackClass::*)(SomeObject *Data);"); 5082 5083 verifyGoogleFormat("A<void*(int*, SomeType*)>;"); 5084 verifyGoogleFormat("void* (*a)(int);"); 5085 verifyGoogleFormat( 5086 "template <class CallbackClass>\n" 5087 "using MyCallback = void (CallbackClass::*)(SomeObject* Data);"); 5088 5089 // Other constructs can look somewhat like function types: 5090 verifyFormat("A<sizeof(*x)> a;"); 5091 verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)"); 5092 verifyFormat("some_var = function(*some_pointer_var)[0];"); 5093 verifyFormat("void f() { function(*some_pointer_var)[0] = 10; }"); 5094 } 5095 5096 TEST_F(FormatTest, BreaksLongVariableDeclarations) { 5097 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5098 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5099 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType const\n" 5100 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5101 5102 // Different ways of ()-initializiation. 5103 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5104 " LoooooooooooooooooooooooooooooooooooooooongVariable(1);"); 5105 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5106 " LoooooooooooooooooooooooooooooooooooooooongVariable(a);"); 5107 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5108 " LoooooooooooooooooooooooooooooooooooooooongVariable({});"); 5109 } 5110 5111 TEST_F(FormatTest, BreaksLongDeclarations) { 5112 verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" 5113 " AnotherNameForTheLongType;"); 5114 verifyFormat("typedef LongTemplateType<aaaaaaaaaaaaaaaaaaa()>\n" 5115 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 5116 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5117 "LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); 5118 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5119 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5120 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5121 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5122 verifyFormat("decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5123 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5124 FormatStyle Indented = getLLVMStyle(); 5125 Indented.IndentWrappedFunctionNames = true; 5126 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5127 " LoooooooooooooooooooooooooooooooongFunctionDeclaration();", 5128 Indented); 5129 verifyFormat( 5130 "LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5131 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5132 Indented); 5133 verifyFormat( 5134 "LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5135 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5136 Indented); 5137 verifyFormat( 5138 "decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5139 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5140 Indented); 5141 5142 // FIXME: Without the comment, this breaks after "(". 5143 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" 5144 " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();", 5145 getGoogleStyle()); 5146 5147 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" 5148 " int LoooooooooooooooooooongParam2) {}"); 5149 verifyFormat( 5150 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" 5151 " SourceLocation L, IdentifierIn *II,\n" 5152 " Type *T) {}"); 5153 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" 5154 "ReallyReallyLongFunctionName(\n" 5155 " const std::string &SomeParameter,\n" 5156 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5157 " ReallyReallyLongParameterName,\n" 5158 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5159 " AnotherLongParameterName) {}"); 5160 verifyFormat("template <typename A>\n" 5161 "SomeLoooooooooooooooooooooongType<\n" 5162 " typename some_namespace::SomeOtherType<A>::Type>\n" 5163 "Function() {}"); 5164 5165 verifyGoogleFormat( 5166 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" 5167 " aaaaaaaaaaaaaaaaaaaaaaa;"); 5168 verifyGoogleFormat( 5169 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" 5170 " SourceLocation L) {}"); 5171 verifyGoogleFormat( 5172 "some_namespace::LongReturnType\n" 5173 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" 5174 " int first_long_parameter, int second_parameter) {}"); 5175 5176 verifyGoogleFormat("template <typename T>\n" 5177 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" 5178 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); 5179 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5180 " int aaaaaaaaaaaaaaaaaaaaaaa);"); 5181 } 5182 5183 TEST_F(FormatTest, FormatsArrays) { 5184 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5185 " [bbbbbbbbbbbbbbbbbbbbbbbbb] = c;"); 5186 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5187 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5188 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5189 " [a][bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = cccccccc;"); 5190 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5191 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5192 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5193 verifyFormat( 5194 "llvm::outs() << \"aaaaaaaaaaaa: \"\n" 5195 " << (*aaaaaaaiaaaaaaa)[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5196 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); 5197 5198 verifyGoogleFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<int>\n" 5199 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaa];"); 5200 verifyFormat( 5201 "aaaaaaaaaaa aaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaa->aaaaaaaaa[0]\n" 5202 " .aaaaaaa[0]\n" 5203 " .aaaaaaaaaaaaaaaaaaaaaa();"); 5204 } 5205 5206 TEST_F(FormatTest, LineStartsWithSpecialCharacter) { 5207 verifyFormat("(a)->b();"); 5208 verifyFormat("--a;"); 5209 } 5210 5211 TEST_F(FormatTest, HandlesIncludeDirectives) { 5212 verifyFormat("#include <string>\n" 5213 "#include <a/b/c.h>\n" 5214 "#include \"a/b/string\"\n" 5215 "#include \"string.h\"\n" 5216 "#include \"string.h\"\n" 5217 "#include <a-a>\n" 5218 "#include < path with space >\n" 5219 "#include \"abc.h\" // this is included for ABC\n" 5220 "#include \"some long include\" // with a comment\n" 5221 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"", 5222 getLLVMStyleWithColumns(35)); 5223 EXPECT_EQ("#include \"a.h\"", format("#include \"a.h\"")); 5224 EXPECT_EQ("#include <a>", format("#include<a>")); 5225 5226 verifyFormat("#import <string>"); 5227 verifyFormat("#import <a/b/c.h>"); 5228 verifyFormat("#import \"a/b/string\""); 5229 verifyFormat("#import \"string.h\""); 5230 verifyFormat("#import \"string.h\""); 5231 verifyFormat("#if __has_include(<strstream>)\n" 5232 "#include <strstream>\n" 5233 "#endif"); 5234 5235 // Protocol buffer definition or missing "#". 5236 verifyFormat("import \"aaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaa\";", 5237 getLLVMStyleWithColumns(30)); 5238 5239 FormatStyle Style = getLLVMStyle(); 5240 Style.AlwaysBreakBeforeMultilineStrings = true; 5241 Style.ColumnLimit = 0; 5242 verifyFormat("#import \"abc.h\"", Style); 5243 } 5244 5245 //===----------------------------------------------------------------------===// 5246 // Error recovery tests. 5247 //===----------------------------------------------------------------------===// 5248 5249 TEST_F(FormatTest, IncompleteParameterLists) { 5250 FormatStyle NoBinPacking = getLLVMStyle(); 5251 NoBinPacking.BinPackParameters = false; 5252 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" 5253 " double *min_x,\n" 5254 " double *max_x,\n" 5255 " double *min_y,\n" 5256 " double *max_y,\n" 5257 " double *min_z,\n" 5258 " double *max_z, ) {}", 5259 NoBinPacking); 5260 } 5261 5262 TEST_F(FormatTest, IncorrectCodeTrailingStuff) { 5263 verifyFormat("void f() { return; }\n42"); 5264 verifyFormat("void f() {\n" 5265 " if (0)\n" 5266 " return;\n" 5267 "}\n" 5268 "42"); 5269 verifyFormat("void f() { return }\n42"); 5270 verifyFormat("void f() {\n" 5271 " if (0)\n" 5272 " return\n" 5273 "}\n" 5274 "42"); 5275 } 5276 5277 TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { 5278 EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); 5279 EXPECT_EQ("void f() {\n" 5280 " if (a)\n" 5281 " return\n" 5282 "}", 5283 format("void f ( ) { if ( a ) return }")); 5284 EXPECT_EQ("namespace N {\n" 5285 "void f()\n" 5286 "}", 5287 format("namespace N { void f() }")); 5288 EXPECT_EQ("namespace N {\n" 5289 "void f() {}\n" 5290 "void g()\n" 5291 "}", 5292 format("namespace N { void f( ) { } void g( ) }")); 5293 } 5294 5295 TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { 5296 verifyFormat("int aaaaaaaa =\n" 5297 " // Overlylongcomment\n" 5298 " b;", 5299 getLLVMStyleWithColumns(20)); 5300 verifyFormat("function(\n" 5301 " ShortArgument,\n" 5302 " LoooooooooooongArgument);\n", 5303 getLLVMStyleWithColumns(20)); 5304 } 5305 5306 TEST_F(FormatTest, IncorrectAccessSpecifier) { 5307 verifyFormat("public:"); 5308 verifyFormat("class A {\n" 5309 "public\n" 5310 " void f() {}\n" 5311 "};"); 5312 verifyFormat("public\n" 5313 "int qwerty;"); 5314 verifyFormat("public\n" 5315 "B {}"); 5316 verifyFormat("public\n" 5317 "{}"); 5318 verifyFormat("public\n" 5319 "B { int x; }"); 5320 } 5321 5322 TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { 5323 verifyFormat("{"); 5324 verifyFormat("#})"); 5325 } 5326 5327 TEST_F(FormatTest, IncorrectCodeDoNoWhile) { 5328 verifyFormat("do {\n}"); 5329 verifyFormat("do {\n}\n" 5330 "f();"); 5331 verifyFormat("do {\n}\n" 5332 "wheeee(fun);"); 5333 verifyFormat("do {\n" 5334 " f();\n" 5335 "}"); 5336 } 5337 5338 TEST_F(FormatTest, IncorrectCodeMissingParens) { 5339 verifyFormat("if {\n foo;\n foo();\n}"); 5340 verifyFormat("switch {\n foo;\n foo();\n}"); 5341 verifyFormat("for {\n foo;\n foo();\n}"); 5342 verifyFormat("while {\n foo;\n foo();\n}"); 5343 verifyFormat("do {\n foo;\n foo();\n} while;"); 5344 } 5345 5346 TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { 5347 verifyFormat("namespace {\n" 5348 "class Foo { Foo (\n" 5349 "};\n" 5350 "} // comment"); 5351 } 5352 5353 TEST_F(FormatTest, IncorrectCodeErrorDetection) { 5354 EXPECT_EQ("{\n {}\n", format("{\n{\n}\n")); 5355 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); 5356 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); 5357 EXPECT_EQ("{\n {}\n}\n}\n", format("{\n {\n }\n }\n}\n")); 5358 5359 EXPECT_EQ("{\n" 5360 " {\n" 5361 " breakme(\n" 5362 " qwe);\n" 5363 " }\n", 5364 format("{\n" 5365 " {\n" 5366 " breakme(qwe);\n" 5367 "}\n", 5368 getLLVMStyleWithColumns(10))); 5369 } 5370 5371 TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { 5372 verifyFormat("int x = {\n" 5373 " avariable,\n" 5374 " b(alongervariable)};", 5375 getLLVMStyleWithColumns(25)); 5376 } 5377 5378 TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { 5379 verifyFormat("return (a)(b){1, 2, 3};"); 5380 } 5381 5382 TEST_F(FormatTest, LayoutCxx11BraceInitializers) { 5383 verifyFormat("vector<int> x{1, 2, 3, 4};"); 5384 verifyFormat("vector<int> x{\n" 5385 " 1, 2, 3, 4,\n" 5386 "};"); 5387 verifyFormat("vector<T> x{{}, {}, {}, {}};"); 5388 verifyFormat("f({1, 2});"); 5389 verifyFormat("auto v = Foo{-1};"); 5390 verifyFormat("f({1, 2}, {{2, 3}, {4, 5}}, c, {d});"); 5391 verifyFormat("Class::Class : member{1, 2, 3} {}"); 5392 verifyFormat("new vector<int>{1, 2, 3};"); 5393 verifyFormat("new int[3]{1, 2, 3};"); 5394 verifyFormat("new int{1};"); 5395 verifyFormat("return {arg1, arg2};"); 5396 verifyFormat("return {arg1, SomeType{parameter}};"); 5397 verifyFormat("int count = set<int>{f(), g(), h()}.size();"); 5398 verifyFormat("new T{arg1, arg2};"); 5399 verifyFormat("f(MyMap[{composite, key}]);"); 5400 verifyFormat("class Class {\n" 5401 " T member = {arg1, arg2};\n" 5402 "};"); 5403 verifyFormat("vector<int> foo = {::SomeGlobalFunction()};"); 5404 verifyFormat("static_assert(std::is_integral<int>{} + 0, \"\");"); 5405 verifyFormat("int a = std::is_integral<int>{} + 0;"); 5406 5407 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5408 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5409 verifyFormat("auto i = decltype(x){};"); 5410 5411 // In combination with BinPackParameters = false. 5412 FormatStyle NoBinPacking = getLLVMStyle(); 5413 NoBinPacking.BinPackParameters = false; 5414 verifyFormat("const Aaaaaa aaaaa = {aaaaa,\n" 5415 " bbbbb,\n" 5416 " ccccc,\n" 5417 " ddddd,\n" 5418 " eeeee,\n" 5419 " ffffff,\n" 5420 " ggggg,\n" 5421 " hhhhhh,\n" 5422 " iiiiii,\n" 5423 " jjjjjj,\n" 5424 " kkkkkk};", 5425 NoBinPacking); 5426 verifyFormat("const Aaaaaa aaaaa = {\n" 5427 " aaaaa,\n" 5428 " bbbbb,\n" 5429 " ccccc,\n" 5430 " ddddd,\n" 5431 " eeeee,\n" 5432 " ffffff,\n" 5433 " ggggg,\n" 5434 " hhhhhh,\n" 5435 " iiiiii,\n" 5436 " jjjjjj,\n" 5437 " kkkkkk,\n" 5438 "};", 5439 NoBinPacking); 5440 5441 // FIXME: The alignment of these trailing comments might be bad. Then again, 5442 // this might be utterly useless in real code. 5443 verifyFormat("Constructor::Constructor()\n" 5444 " : some_value{ //\n" 5445 " aaaaaaa //\n" 5446 " } {}"); 5447 5448 // In braced lists, the first comment is always assumed to belong to the 5449 // first element. Thus, it can be moved to the next or previous line as 5450 // appropriate. 5451 EXPECT_EQ("function({// First element:\n" 5452 " 1,\n" 5453 " // Second element:\n" 5454 " 2});", 5455 format("function({\n" 5456 " // First element:\n" 5457 " 1,\n" 5458 " // Second element:\n" 5459 " 2});")); 5460 EXPECT_EQ("std::vector<int> MyNumbers{\n" 5461 " // First element:\n" 5462 " 1,\n" 5463 " // Second element:\n" 5464 " 2};", 5465 format("std::vector<int> MyNumbers{// First element:\n" 5466 " 1,\n" 5467 " // Second element:\n" 5468 " 2};", 5469 getLLVMStyleWithColumns(30))); 5470 5471 FormatStyle ExtraSpaces = getLLVMStyle(); 5472 ExtraSpaces.Cpp11BracedListStyle = false; 5473 ExtraSpaces.ColumnLimit = 75; 5474 verifyFormat("vector<int> x{ 1, 2, 3, 4 };", ExtraSpaces); 5475 verifyFormat("vector<T> x{ {}, {}, {}, {} };", ExtraSpaces); 5476 verifyFormat("f({ 1, 2 });", ExtraSpaces); 5477 verifyFormat("auto v = Foo{ 1 };", ExtraSpaces); 5478 verifyFormat("f({ 1, 2 }, { { 2, 3 }, { 4, 5 } }, c, { d });", ExtraSpaces); 5479 verifyFormat("Class::Class : member{ 1, 2, 3 } {}", ExtraSpaces); 5480 verifyFormat("new vector<int>{ 1, 2, 3 };", ExtraSpaces); 5481 verifyFormat("new int[3]{ 1, 2, 3 };", ExtraSpaces); 5482 verifyFormat("return { arg1, arg2 };", ExtraSpaces); 5483 verifyFormat("return { arg1, SomeType{ parameter } };", ExtraSpaces); 5484 verifyFormat("int count = set<int>{ f(), g(), h() }.size();", ExtraSpaces); 5485 verifyFormat("new T{ arg1, arg2 };", ExtraSpaces); 5486 verifyFormat("f(MyMap[{ composite, key }]);", ExtraSpaces); 5487 verifyFormat("class Class {\n" 5488 " T member = { arg1, arg2 };\n" 5489 "};", 5490 ExtraSpaces); 5491 verifyFormat( 5492 "foo = aaaaaaaaaaa ? vector<int>{ aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5493 " aaaaaaaaaaaaaaaaaaaa, aaaaa }\n" 5494 " : vector<int>{ bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 5495 " bbbbbbbbbbbbbbbbbbbb, bbbbb };", 5496 ExtraSpaces); 5497 verifyFormat("DoSomethingWithVector({} /* No data */);", ExtraSpaces); 5498 verifyFormat("DoSomethingWithVector({\n" 5499 " {} /* No data */\n" 5500 " },\n" 5501 " { { 1, 2 } });", 5502 ExtraSpaces); 5503 verifyFormat( 5504 "someFunction(OtherParam,\n" 5505 " BracedList{ // comment 1 (Forcing interesting break)\n" 5506 " param1, param2,\n" 5507 " // comment 2\n" 5508 " param3, param4\n" 5509 " });", 5510 ExtraSpaces); 5511 verifyFormat( 5512 "std::this_thread::sleep_for(\n" 5513 " std::chrono::nanoseconds{ std::chrono::seconds{ 1 } } / 5);", 5514 ExtraSpaces); 5515 verifyFormat("std::vector<MyValues> aaaaaaaaaaaaaaaaaaa{\n" 5516 " aaaaaaa, aaaaaaaaaa,\n" 5517 " aaaaa, aaaaaaaaaaaaaaa,\n" 5518 " aaa, aaaaaaaaaa,\n" 5519 " a, aaaaaaaaaaaaaaaaaaaaa,\n" 5520 " aaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaa,\n" 5521 " aaaaaaa, a\n" 5522 "};", 5523 ExtraSpaces); 5524 verifyFormat("vector<int> foo = { ::SomeGlobalFunction() };", ExtraSpaces); 5525 } 5526 5527 TEST_F(FormatTest, FormatsBracedListsInColumnLayout) { 5528 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5529 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5530 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5531 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5532 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5533 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 5534 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5535 " // line comment\n" 5536 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5537 " 1, 22, 333, 4444, 55555,\n" 5538 " // line comment\n" 5539 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5540 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 5541 verifyFormat( 5542 "vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5543 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5544 " 1, 22, 333, 4444, 55555, 666666, // comment\n" 5545 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5546 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5547 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5548 " 7777777};"); 5549 verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" 5550 " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" 5551 " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); 5552 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 5553 " 1, 1, 1, 1};", 5554 getLLVMStyleWithColumns(39)); 5555 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 5556 " 1, 1, 1, 1};", 5557 getLLVMStyleWithColumns(38)); 5558 verifyFormat("vector<int> aaaaaaaaaaaaaaaaaaaaaa = {\n" 5559 " 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1};", 5560 getLLVMStyleWithColumns(43)); 5561 5562 // Trailing commas. 5563 verifyFormat("vector<int> x = {\n" 5564 " 1, 1, 1, 1, 1, 1, 1, 1,\n" 5565 "};", 5566 getLLVMStyleWithColumns(39)); 5567 verifyFormat("vector<int> x = {\n" 5568 " 1, 1, 1, 1, 1, 1, 1, 1, //\n" 5569 "};", 5570 getLLVMStyleWithColumns(39)); 5571 verifyFormat("vector<int> x = {\n" 5572 " 1, 1, 1, 1, 1, 1, 1, 1,\n" 5573 " /**/ /**/\n" 5574 "};", 5575 getLLVMStyleWithColumns(39)); 5576 verifyFormat("return {{aaaaaaaaaaaaaaaaaaaaa},\n" 5577 " {aaaaaaaaaaaaaaaaaaa},\n" 5578 " {aaaaaaaaaaaaaaaaaaaaa},\n" 5579 " {aaaaaaaaaaaaaaaaa}};", 5580 getLLVMStyleWithColumns(60)); 5581 5582 // With nested lists, we should either format one item per line or all nested 5583 // lists one one line. 5584 // FIXME: For some nested lists, we can do better. 5585 verifyFormat( 5586 "SomeStruct my_struct_array = {\n" 5587 " {aaaaaa, aaaaaaaa, aaaaaaaaaa, aaaaaaaaa, aaaaaaaaa, aaaaaaaaaa,\n" 5588 " aaaaaaaaaaaaa, aaaaaaa, aaa},\n" 5589 " {aaa, aaa},\n" 5590 " {aaa, aaa},\n" 5591 " {aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaa},\n" 5592 " {aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaa,\n" 5593 " aaaaaaaaaaaa, a, aaaaaaaaaa, aaaaaaaaa, aaa}};"); 5594 5595 // No column layout should be used here. 5596 verifyFormat("aaaaaaaaaaaaaaa = {aaaaaaaaaaaaaaaaaaaaaaaaaaa, 0, 0,\n" 5597 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb};"); 5598 } 5599 5600 TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { 5601 FormatStyle DoNotMerge = getLLVMStyle(); 5602 DoNotMerge.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 5603 5604 verifyFormat("void f() { return 42; }"); 5605 verifyFormat("void f() {\n" 5606 " return 42;\n" 5607 "}", 5608 DoNotMerge); 5609 verifyFormat("void f() {\n" 5610 " // Comment\n" 5611 "}"); 5612 verifyFormat("{\n" 5613 "#error {\n" 5614 " int a;\n" 5615 "}"); 5616 verifyFormat("{\n" 5617 " int a;\n" 5618 "#error {\n" 5619 "}"); 5620 verifyFormat("void f() {} // comment"); 5621 verifyFormat("void f() { int a; } // comment"); 5622 verifyFormat("void f() {\n" 5623 "} // comment", 5624 DoNotMerge); 5625 verifyFormat("void f() {\n" 5626 " int a;\n" 5627 "} // comment", 5628 DoNotMerge); 5629 verifyFormat("void f() {\n" 5630 "} // comment", 5631 getLLVMStyleWithColumns(15)); 5632 5633 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); 5634 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); 5635 5636 verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); 5637 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); 5638 verifyFormat("class C {\n" 5639 " C()\n" 5640 " : iiiiiiii(nullptr),\n" 5641 " kkkkkkk(nullptr),\n" 5642 " mmmmmmm(nullptr),\n" 5643 " nnnnnnn(nullptr) {}\n" 5644 "};", 5645 getGoogleStyle()); 5646 5647 FormatStyle NoColumnLimit = getLLVMStyle(); 5648 NoColumnLimit.ColumnLimit = 0; 5649 EXPECT_EQ("A() : b(0) {}", format("A():b(0){}", NoColumnLimit)); 5650 EXPECT_EQ("class C {\n" 5651 " A() : b(0) {}\n" 5652 "};", format("class C{A():b(0){}};", NoColumnLimit)); 5653 EXPECT_EQ("A()\n" 5654 " : b(0) {\n" 5655 "}", 5656 format("A()\n:b(0)\n{\n}", NoColumnLimit)); 5657 5658 FormatStyle DoNotMergeNoColumnLimit = NoColumnLimit; 5659 DoNotMergeNoColumnLimit.AllowShortFunctionsOnASingleLine = 5660 FormatStyle::SFS_None; 5661 EXPECT_EQ("A()\n" 5662 " : b(0) {\n" 5663 "}", 5664 format("A():b(0){}", DoNotMergeNoColumnLimit)); 5665 EXPECT_EQ("A()\n" 5666 " : b(0) {\n" 5667 "}", 5668 format("A()\n:b(0)\n{\n}", DoNotMergeNoColumnLimit)); 5669 5670 verifyFormat("#define A \\\n" 5671 " void f() { \\\n" 5672 " int i; \\\n" 5673 " }", 5674 getLLVMStyleWithColumns(20)); 5675 verifyFormat("#define A \\\n" 5676 " void f() { int i; }", 5677 getLLVMStyleWithColumns(21)); 5678 verifyFormat("#define A \\\n" 5679 " void f() { \\\n" 5680 " int i; \\\n" 5681 " } \\\n" 5682 " int j;", 5683 getLLVMStyleWithColumns(22)); 5684 verifyFormat("#define A \\\n" 5685 " void f() { int i; } \\\n" 5686 " int j;", 5687 getLLVMStyleWithColumns(23)); 5688 } 5689 5690 TEST_F(FormatTest, PullInlineFunctionDefinitionsIntoSingleLine) { 5691 FormatStyle MergeInlineOnly = getLLVMStyle(); 5692 MergeInlineOnly.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 5693 verifyFormat("class C {\n" 5694 " int f() { return 42; }\n" 5695 "};", 5696 MergeInlineOnly); 5697 verifyFormat("int f() {\n" 5698 " return 42;\n" 5699 "}", 5700 MergeInlineOnly); 5701 } 5702 5703 TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { 5704 // Elaborate type variable declarations. 5705 verifyFormat("struct foo a = {bar};\nint n;"); 5706 verifyFormat("class foo a = {bar};\nint n;"); 5707 verifyFormat("union foo a = {bar};\nint n;"); 5708 5709 // Elaborate types inside function definitions. 5710 verifyFormat("struct foo f() {}\nint n;"); 5711 verifyFormat("class foo f() {}\nint n;"); 5712 verifyFormat("union foo f() {}\nint n;"); 5713 5714 // Templates. 5715 verifyFormat("template <class X> void f() {}\nint n;"); 5716 verifyFormat("template <struct X> void f() {}\nint n;"); 5717 verifyFormat("template <union X> void f() {}\nint n;"); 5718 5719 // Actual definitions... 5720 verifyFormat("struct {\n} n;"); 5721 verifyFormat( 5722 "template <template <class T, class Y>, class Z> class X {\n} n;"); 5723 verifyFormat("union Z {\n int n;\n} x;"); 5724 verifyFormat("class MACRO Z {\n} n;"); 5725 verifyFormat("class MACRO(X) Z {\n} n;"); 5726 verifyFormat("class __attribute__(X) Z {\n} n;"); 5727 verifyFormat("class __declspec(X) Z {\n} n;"); 5728 verifyFormat("class A##B##C {\n} n;"); 5729 verifyFormat("class alignas(16) Z {\n} n;"); 5730 5731 // Redefinition from nested context: 5732 verifyFormat("class A::B::C {\n} n;"); 5733 5734 // Template definitions. 5735 verifyFormat( 5736 "template <typename F>\n" 5737 "Matcher(const Matcher<F> &Other,\n" 5738 " typename enable_if_c<is_base_of<F, T>::value &&\n" 5739 " !is_same<F, T>::value>::type * = 0)\n" 5740 " : Implementation(new ImplicitCastMatcher<F>(Other)) {}"); 5741 5742 // FIXME: This is still incorrectly handled at the formatter side. 5743 verifyFormat("template <> struct X < 15, i<3 && 42 < 50 && 33 < 28> {};"); 5744 5745 // FIXME: 5746 // This now gets parsed incorrectly as class definition. 5747 // verifyFormat("class A<int> f() {\n}\nint n;"); 5748 5749 // Elaborate types where incorrectly parsing the structural element would 5750 // break the indent. 5751 verifyFormat("if (true)\n" 5752 " class X x;\n" 5753 "else\n" 5754 " f();\n"); 5755 5756 // This is simply incomplete. Formatting is not important, but must not crash. 5757 verifyFormat("class A:"); 5758 } 5759 5760 TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { 5761 EXPECT_EQ("#error Leave all white!!!!! space* alone!\n", 5762 format("#error Leave all white!!!!! space* alone!\n")); 5763 EXPECT_EQ( 5764 "#warning Leave all white!!!!! space* alone!\n", 5765 format("#warning Leave all white!!!!! space* alone!\n")); 5766 EXPECT_EQ("#error 1", format(" # error 1")); 5767 EXPECT_EQ("#warning 1", format(" # warning 1")); 5768 } 5769 5770 TEST_F(FormatTest, FormatHashIfExpressions) { 5771 verifyFormat("#if AAAA && BBBB"); 5772 // FIXME: Come up with a better indentation for #elif. 5773 verifyFormat( 5774 "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" 5775 " defined(BBBBBBBB)\n" 5776 "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" 5777 " defined(BBBBBBBB)\n" 5778 "#endif", 5779 getLLVMStyleWithColumns(65)); 5780 } 5781 5782 TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { 5783 FormatStyle AllowsMergedIf = getGoogleStyle(); 5784 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 5785 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); 5786 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); 5787 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); 5788 EXPECT_EQ("if (true) return 42;", 5789 format("if (true)\nreturn 42;", AllowsMergedIf)); 5790 FormatStyle ShortMergedIf = AllowsMergedIf; 5791 ShortMergedIf.ColumnLimit = 25; 5792 verifyFormat("#define A \\\n" 5793 " if (true) return 42;", 5794 ShortMergedIf); 5795 verifyFormat("#define A \\\n" 5796 " f(); \\\n" 5797 " if (true)\n" 5798 "#define B", 5799 ShortMergedIf); 5800 verifyFormat("#define A \\\n" 5801 " f(); \\\n" 5802 " if (true)\n" 5803 "g();", 5804 ShortMergedIf); 5805 verifyFormat("{\n" 5806 "#ifdef A\n" 5807 " // Comment\n" 5808 " if (true) continue;\n" 5809 "#endif\n" 5810 " // Comment\n" 5811 " if (true) continue;\n" 5812 "}", 5813 ShortMergedIf); 5814 ShortMergedIf.ColumnLimit = 29; 5815 verifyFormat("#define A \\\n" 5816 " if (aaaaaaaaaa) return 1; \\\n" 5817 " return 2;", 5818 ShortMergedIf); 5819 ShortMergedIf.ColumnLimit = 28; 5820 verifyFormat("#define A \\\n" 5821 " if (aaaaaaaaaa) \\\n" 5822 " return 1; \\\n" 5823 " return 2;", 5824 ShortMergedIf); 5825 } 5826 5827 TEST_F(FormatTest, BlockCommentsInControlLoops) { 5828 verifyFormat("if (0) /* a comment in a strange place */ {\n" 5829 " f();\n" 5830 "}"); 5831 verifyFormat("if (0) /* a comment in a strange place */ {\n" 5832 " f();\n" 5833 "} /* another comment */ else /* comment #3 */ {\n" 5834 " g();\n" 5835 "}"); 5836 verifyFormat("while (0) /* a comment in a strange place */ {\n" 5837 " f();\n" 5838 "}"); 5839 verifyFormat("for (;;) /* a comment in a strange place */ {\n" 5840 " f();\n" 5841 "}"); 5842 verifyFormat("do /* a comment in a strange place */ {\n" 5843 " f();\n" 5844 "} /* another comment */ while (0);"); 5845 } 5846 5847 TEST_F(FormatTest, BlockComments) { 5848 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", 5849 format("/* *//* */ /* */\n/* *//* */ /* */")); 5850 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); 5851 EXPECT_EQ("#define A /*123*/ \\\n" 5852 " b\n" 5853 "/* */\n" 5854 "someCall(\n" 5855 " parameter);", 5856 format("#define A /*123*/ b\n" 5857 "/* */\n" 5858 "someCall(parameter);", 5859 getLLVMStyleWithColumns(15))); 5860 5861 EXPECT_EQ("#define A\n" 5862 "/* */ someCall(\n" 5863 " parameter);", 5864 format("#define A\n" 5865 "/* */someCall(parameter);", 5866 getLLVMStyleWithColumns(15))); 5867 EXPECT_EQ("/*\n**\n*/", format("/*\n**\n*/")); 5868 EXPECT_EQ("/*\n" 5869 "*\n" 5870 " * aaaaaa\n" 5871 "*aaaaaa\n" 5872 "*/", 5873 format("/*\n" 5874 "*\n" 5875 " * aaaaaa aaaaaa\n" 5876 "*/", 5877 getLLVMStyleWithColumns(10))); 5878 EXPECT_EQ("/*\n" 5879 "**\n" 5880 "* aaaaaa\n" 5881 "*aaaaaa\n" 5882 "*/", 5883 format("/*\n" 5884 "**\n" 5885 "* aaaaaa aaaaaa\n" 5886 "*/", 5887 getLLVMStyleWithColumns(10))); 5888 5889 FormatStyle NoBinPacking = getLLVMStyle(); 5890 NoBinPacking.BinPackParameters = false; 5891 EXPECT_EQ("someFunction(1, /* comment 1 */\n" 5892 " 2, /* comment 2 */\n" 5893 " 3, /* comment 3 */\n" 5894 " aaaa,\n" 5895 " bbbb);", 5896 format("someFunction (1, /* comment 1 */\n" 5897 " 2, /* comment 2 */ \n" 5898 " 3, /* comment 3 */\n" 5899 "aaaa, bbbb );", 5900 NoBinPacking)); 5901 verifyFormat( 5902 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5903 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 5904 EXPECT_EQ( 5905 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 5906 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5907 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", 5908 format( 5909 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 5910 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5911 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); 5912 EXPECT_EQ( 5913 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 5914 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 5915 "int cccccccccccccccccccccccccccccc; /* comment */\n", 5916 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 5917 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 5918 "int cccccccccccccccccccccccccccccc; /* comment */\n")); 5919 5920 verifyFormat("void f(int * /* unused */) {}"); 5921 5922 EXPECT_EQ("/*\n" 5923 " **\n" 5924 " */", 5925 format("/*\n" 5926 " **\n" 5927 " */")); 5928 EXPECT_EQ("/*\n" 5929 " *q\n" 5930 " */", 5931 format("/*\n" 5932 " *q\n" 5933 " */")); 5934 EXPECT_EQ("/*\n" 5935 " * q\n" 5936 " */", 5937 format("/*\n" 5938 " * q\n" 5939 " */")); 5940 EXPECT_EQ("/*\n" 5941 " **/", 5942 format("/*\n" 5943 " **/")); 5944 EXPECT_EQ("/*\n" 5945 " ***/", 5946 format("/*\n" 5947 " ***/")); 5948 } 5949 5950 TEST_F(FormatTest, BlockCommentsInMacros) { 5951 EXPECT_EQ("#define A \\\n" 5952 " { \\\n" 5953 " /* one line */ \\\n" 5954 " someCall();", 5955 format("#define A { \\\n" 5956 " /* one line */ \\\n" 5957 " someCall();", 5958 getLLVMStyleWithColumns(20))); 5959 EXPECT_EQ("#define A \\\n" 5960 " { \\\n" 5961 " /* previous */ \\\n" 5962 " /* one line */ \\\n" 5963 " someCall();", 5964 format("#define A { \\\n" 5965 " /* previous */ \\\n" 5966 " /* one line */ \\\n" 5967 " someCall();", 5968 getLLVMStyleWithColumns(20))); 5969 } 5970 5971 TEST_F(FormatTest, BlockCommentsAtEndOfLine) { 5972 EXPECT_EQ("a = {\n" 5973 " 1111 /* */\n" 5974 "};", 5975 format("a = {1111 /* */\n" 5976 "};", 5977 getLLVMStyleWithColumns(15))); 5978 EXPECT_EQ("a = {\n" 5979 " 1111 /* */\n" 5980 "};", 5981 format("a = {1111 /* */\n" 5982 "};", 5983 getLLVMStyleWithColumns(15))); 5984 5985 // FIXME: The formatting is still wrong here. 5986 EXPECT_EQ("a = {\n" 5987 " 1111 /* a\n" 5988 " */\n" 5989 "};", 5990 format("a = {1111 /* a */\n" 5991 "};", 5992 getLLVMStyleWithColumns(15))); 5993 } 5994 5995 TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) { 5996 // FIXME: This is not what we want... 5997 verifyFormat("{\n" 5998 "// a" 5999 "// b"); 6000 } 6001 6002 TEST_F(FormatTest, FormatStarDependingOnContext) { 6003 verifyFormat("void f(int *a);"); 6004 verifyFormat("void f() { f(fint * b); }"); 6005 verifyFormat("class A {\n void f(int *a);\n};"); 6006 verifyFormat("class A {\n int *a;\n};"); 6007 verifyFormat("namespace a {\n" 6008 "namespace b {\n" 6009 "class A {\n" 6010 " void f() {}\n" 6011 " int *a;\n" 6012 "};\n" 6013 "}\n" 6014 "}"); 6015 } 6016 6017 TEST_F(FormatTest, SpecialTokensAtEndOfLine) { 6018 verifyFormat("while"); 6019 verifyFormat("operator"); 6020 } 6021 6022 //===----------------------------------------------------------------------===// 6023 // Objective-C tests. 6024 //===----------------------------------------------------------------------===// 6025 6026 TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { 6027 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); 6028 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", 6029 format("-(NSUInteger)indexOfObject:(id)anObject;")); 6030 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); 6031 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); 6032 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", 6033 format("-(NSInteger)Method3:(id)anObject;")); 6034 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", 6035 format("-(NSInteger)Method4:(id)anObject;")); 6036 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", 6037 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); 6038 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", 6039 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); 6040 EXPECT_EQ( 6041 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;", 6042 format( 6043 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;")); 6044 6045 // Very long objectiveC method declaration. 6046 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" 6047 " inRange:(NSRange)range\n" 6048 " outRange:(NSRange)out_range\n" 6049 " outRange1:(NSRange)out_range1\n" 6050 " outRange2:(NSRange)out_range2\n" 6051 " outRange3:(NSRange)out_range3\n" 6052 " outRange4:(NSRange)out_range4\n" 6053 " outRange5:(NSRange)out_range5\n" 6054 " outRange6:(NSRange)out_range6\n" 6055 " outRange7:(NSRange)out_range7\n" 6056 " outRange8:(NSRange)out_range8\n" 6057 " outRange9:(NSRange)out_range9;"); 6058 6059 verifyFormat("- (int)sum:(vector<int>)numbers;"); 6060 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); 6061 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC 6062 // protocol lists (but not for template classes): 6063 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); 6064 6065 verifyFormat("- (int (*)())foo:(int (*)())f;"); 6066 verifyGoogleFormat("- (int (*)())foo:(int (*)())foo;"); 6067 6068 // If there's no return type (very rare in practice!), LLVM and Google style 6069 // agree. 6070 verifyFormat("- foo;"); 6071 verifyFormat("- foo:(int)f;"); 6072 verifyGoogleFormat("- foo:(int)foo;"); 6073 } 6074 6075 TEST_F(FormatTest, FormatObjCInterface) { 6076 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" 6077 "@public\n" 6078 " int field1;\n" 6079 "@protected\n" 6080 " int field2;\n" 6081 "@private\n" 6082 " int field3;\n" 6083 "@package\n" 6084 " int field4;\n" 6085 "}\n" 6086 "+ (id)init;\n" 6087 "@end"); 6088 6089 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n" 6090 " @public\n" 6091 " int field1;\n" 6092 " @protected\n" 6093 " int field2;\n" 6094 " @private\n" 6095 " int field3;\n" 6096 " @package\n" 6097 " int field4;\n" 6098 "}\n" 6099 "+ (id)init;\n" 6100 "@end"); 6101 6102 verifyFormat("@interface /* wait for it */ Foo\n" 6103 "+ (id)init;\n" 6104 "// Look, a comment!\n" 6105 "- (int)answerWith:(int)i;\n" 6106 "@end"); 6107 6108 verifyFormat("@interface Foo\n" 6109 "@end\n" 6110 "@interface Bar\n" 6111 "@end"); 6112 6113 verifyFormat("@interface Foo : Bar\n" 6114 "+ (id)init;\n" 6115 "@end"); 6116 6117 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" 6118 "+ (id)init;\n" 6119 "@end"); 6120 6121 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n" 6122 "+ (id)init;\n" 6123 "@end"); 6124 6125 verifyFormat("@interface Foo (HackStuff)\n" 6126 "+ (id)init;\n" 6127 "@end"); 6128 6129 verifyFormat("@interface Foo ()\n" 6130 "+ (id)init;\n" 6131 "@end"); 6132 6133 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6134 "+ (id)init;\n" 6135 "@end"); 6136 6137 verifyGoogleFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6138 "+ (id)init;\n" 6139 "@end"); 6140 6141 verifyFormat("@interface Foo {\n" 6142 " int _i;\n" 6143 "}\n" 6144 "+ (id)init;\n" 6145 "@end"); 6146 6147 verifyFormat("@interface Foo : Bar {\n" 6148 " int _i;\n" 6149 "}\n" 6150 "+ (id)init;\n" 6151 "@end"); 6152 6153 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" 6154 " int _i;\n" 6155 "}\n" 6156 "+ (id)init;\n" 6157 "@end"); 6158 6159 verifyFormat("@interface Foo (HackStuff) {\n" 6160 " int _i;\n" 6161 "}\n" 6162 "+ (id)init;\n" 6163 "@end"); 6164 6165 verifyFormat("@interface Foo () {\n" 6166 " int _i;\n" 6167 "}\n" 6168 "+ (id)init;\n" 6169 "@end"); 6170 6171 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" 6172 " int _i;\n" 6173 "}\n" 6174 "+ (id)init;\n" 6175 "@end"); 6176 6177 FormatStyle OnePerLine = getGoogleStyle(); 6178 OnePerLine.BinPackParameters = false; 6179 verifyFormat("@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa () <\n" 6180 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6181 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6182 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6183 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" 6184 "}", 6185 OnePerLine); 6186 } 6187 6188 TEST_F(FormatTest, FormatObjCImplementation) { 6189 verifyFormat("@implementation Foo : NSObject {\n" 6190 "@public\n" 6191 " int field1;\n" 6192 "@protected\n" 6193 " int field2;\n" 6194 "@private\n" 6195 " int field3;\n" 6196 "@package\n" 6197 " int field4;\n" 6198 "}\n" 6199 "+ (id)init {\n}\n" 6200 "@end"); 6201 6202 verifyGoogleFormat("@implementation Foo : NSObject {\n" 6203 " @public\n" 6204 " int field1;\n" 6205 " @protected\n" 6206 " int field2;\n" 6207 " @private\n" 6208 " int field3;\n" 6209 " @package\n" 6210 " int field4;\n" 6211 "}\n" 6212 "+ (id)init {\n}\n" 6213 "@end"); 6214 6215 verifyFormat("@implementation Foo\n" 6216 "+ (id)init {\n" 6217 " if (true)\n" 6218 " return nil;\n" 6219 "}\n" 6220 "// Look, a comment!\n" 6221 "- (int)answerWith:(int)i {\n" 6222 " return i;\n" 6223 "}\n" 6224 "+ (int)answerWith:(int)i {\n" 6225 " return i;\n" 6226 "}\n" 6227 "@end"); 6228 6229 verifyFormat("@implementation Foo\n" 6230 "@end\n" 6231 "@implementation Bar\n" 6232 "@end"); 6233 6234 EXPECT_EQ("@implementation Foo : Bar\n" 6235 "+ (id)init {\n}\n" 6236 "- (void)foo {\n}\n" 6237 "@end", 6238 format("@implementation Foo : Bar\n" 6239 "+(id)init{}\n" 6240 "-(void)foo{}\n" 6241 "@end")); 6242 6243 verifyFormat("@implementation Foo {\n" 6244 " int _i;\n" 6245 "}\n" 6246 "+ (id)init {\n}\n" 6247 "@end"); 6248 6249 verifyFormat("@implementation Foo : Bar {\n" 6250 " int _i;\n" 6251 "}\n" 6252 "+ (id)init {\n}\n" 6253 "@end"); 6254 6255 verifyFormat("@implementation Foo (HackStuff)\n" 6256 "+ (id)init {\n}\n" 6257 "@end"); 6258 verifyFormat("@implementation ObjcClass\n" 6259 "- (void)method;\n" 6260 "{}\n" 6261 "@end"); 6262 } 6263 6264 TEST_F(FormatTest, FormatObjCProtocol) { 6265 verifyFormat("@protocol Foo\n" 6266 "@property(weak) id delegate;\n" 6267 "- (NSUInteger)numberOfThings;\n" 6268 "@end"); 6269 6270 verifyFormat("@protocol MyProtocol <NSObject>\n" 6271 "- (NSUInteger)numberOfThings;\n" 6272 "@end"); 6273 6274 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n" 6275 "- (NSUInteger)numberOfThings;\n" 6276 "@end"); 6277 6278 verifyFormat("@protocol Foo;\n" 6279 "@protocol Bar;\n"); 6280 6281 verifyFormat("@protocol Foo\n" 6282 "@end\n" 6283 "@protocol Bar\n" 6284 "@end"); 6285 6286 verifyFormat("@protocol myProtocol\n" 6287 "- (void)mandatoryWithInt:(int)i;\n" 6288 "@optional\n" 6289 "- (void)optional;\n" 6290 "@required\n" 6291 "- (void)required;\n" 6292 "@optional\n" 6293 "@property(assign) int madProp;\n" 6294 "@end\n"); 6295 6296 verifyFormat("@property(nonatomic, assign, readonly)\n" 6297 " int *looooooooooooooooooooooooooooongNumber;\n" 6298 "@property(nonatomic, assign, readonly)\n" 6299 " NSString *looooooooooooooooooooooooooooongName;"); 6300 6301 verifyFormat("@implementation PR18406\n" 6302 "}\n" 6303 "@end"); 6304 } 6305 6306 TEST_F(FormatTest, FormatObjCMethodDeclarations) { 6307 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" 6308 " rect:(NSRect)theRect\n" 6309 " interval:(float)theInterval {\n" 6310 "}"); 6311 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" 6312 " longKeyword:(NSRect)theRect\n" 6313 " evenLongerKeyword:(float)theInterval\n" 6314 " error:(NSError **)theError {\n" 6315 "}"); 6316 } 6317 6318 TEST_F(FormatTest, FormatObjCMethodExpr) { 6319 verifyFormat("[foo bar:baz];"); 6320 verifyFormat("return [foo bar:baz];"); 6321 verifyFormat("f([foo bar:baz]);"); 6322 verifyFormat("f(2, [foo bar:baz]);"); 6323 verifyFormat("f(2, a ? b : c);"); 6324 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); 6325 6326 // Unary operators. 6327 verifyFormat("int a = +[foo bar:baz];"); 6328 verifyFormat("int a = -[foo bar:baz];"); 6329 verifyFormat("int a = ![foo bar:baz];"); 6330 verifyFormat("int a = ~[foo bar:baz];"); 6331 verifyFormat("int a = ++[foo bar:baz];"); 6332 verifyFormat("int a = --[foo bar:baz];"); 6333 verifyFormat("int a = sizeof [foo bar:baz];"); 6334 verifyFormat("int a = alignof [foo bar:baz];", getGoogleStyle()); 6335 verifyFormat("int a = &[foo bar:baz];"); 6336 verifyFormat("int a = *[foo bar:baz];"); 6337 // FIXME: Make casts work, without breaking f()[4]. 6338 //verifyFormat("int a = (int)[foo bar:baz];"); 6339 //verifyFormat("return (int)[foo bar:baz];"); 6340 //verifyFormat("(void)[foo bar:baz];"); 6341 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); 6342 6343 // Binary operators. 6344 verifyFormat("[foo bar:baz], [foo bar:baz];"); 6345 verifyFormat("[foo bar:baz] = [foo bar:baz];"); 6346 verifyFormat("[foo bar:baz] *= [foo bar:baz];"); 6347 verifyFormat("[foo bar:baz] /= [foo bar:baz];"); 6348 verifyFormat("[foo bar:baz] %= [foo bar:baz];"); 6349 verifyFormat("[foo bar:baz] += [foo bar:baz];"); 6350 verifyFormat("[foo bar:baz] -= [foo bar:baz];"); 6351 verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); 6352 verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); 6353 verifyFormat("[foo bar:baz] &= [foo bar:baz];"); 6354 verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); 6355 verifyFormat("[foo bar:baz] |= [foo bar:baz];"); 6356 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); 6357 verifyFormat("[foo bar:baz] || [foo bar:baz];"); 6358 verifyFormat("[foo bar:baz] && [foo bar:baz];"); 6359 verifyFormat("[foo bar:baz] | [foo bar:baz];"); 6360 verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); 6361 verifyFormat("[foo bar:baz] & [foo bar:baz];"); 6362 verifyFormat("[foo bar:baz] == [foo bar:baz];"); 6363 verifyFormat("[foo bar:baz] != [foo bar:baz];"); 6364 verifyFormat("[foo bar:baz] >= [foo bar:baz];"); 6365 verifyFormat("[foo bar:baz] <= [foo bar:baz];"); 6366 verifyFormat("[foo bar:baz] > [foo bar:baz];"); 6367 verifyFormat("[foo bar:baz] < [foo bar:baz];"); 6368 verifyFormat("[foo bar:baz] >> [foo bar:baz];"); 6369 verifyFormat("[foo bar:baz] << [foo bar:baz];"); 6370 verifyFormat("[foo bar:baz] - [foo bar:baz];"); 6371 verifyFormat("[foo bar:baz] + [foo bar:baz];"); 6372 verifyFormat("[foo bar:baz] * [foo bar:baz];"); 6373 verifyFormat("[foo bar:baz] / [foo bar:baz];"); 6374 verifyFormat("[foo bar:baz] % [foo bar:baz];"); 6375 // Whew! 6376 6377 verifyFormat("return in[42];"); 6378 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" 6379 "}"); 6380 6381 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); 6382 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); 6383 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); 6384 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); 6385 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); 6386 verifyFormat("[button setAction:@selector(zoomOut:)];"); 6387 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); 6388 6389 verifyFormat("arr[[self indexForFoo:a]];"); 6390 verifyFormat("throw [self errorFor:a];"); 6391 verifyFormat("@throw [self errorFor:a];"); 6392 6393 verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); 6394 verifyFormat("[(id)foo bar:(id) ? baz : quux];"); 6395 verifyFormat("4 > 4 ? (id)a : (id)baz;"); 6396 6397 // This tests that the formatter doesn't break after "backing" but before ":", 6398 // which would be at 80 columns. 6399 verifyFormat( 6400 "void f() {\n" 6401 " if ((self = [super initWithContentRect:contentRect\n" 6402 " styleMask:styleMask ?: otherMask\n" 6403 " backing:NSBackingStoreBuffered\n" 6404 " defer:YES]))"); 6405 6406 verifyFormat( 6407 "[foo checkThatBreakingAfterColonWorksOk:\n" 6408 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); 6409 6410 verifyFormat("[myObj short:arg1 // Force line break\n" 6411 " longKeyword:arg2 != nil ? arg2 : @\"longKeyword\"\n" 6412 " evenLongerKeyword:arg3 ?: @\"evenLongerKeyword\"\n" 6413 " error:arg4];"); 6414 verifyFormat( 6415 "void f() {\n" 6416 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6417 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" 6418 " pos.width(), pos.height())\n" 6419 " styleMask:NSBorderlessWindowMask\n" 6420 " backing:NSBackingStoreBuffered\n" 6421 " defer:NO]);\n" 6422 "}"); 6423 verifyFormat( 6424 "void f() {\n" 6425 " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" 6426 " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" 6427 " pos.width(), pos.height())\n" 6428 " syeMask:NSBorderlessWindowMask\n" 6429 " bking:NSBackingStoreBuffered\n" 6430 " der:NO]);\n" 6431 "}", 6432 getLLVMStyleWithColumns(70)); 6433 verifyFormat("{\n" 6434 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6435 " initWithContentRect:NSMakeRect(origin_global.x,\n" 6436 " origin_global.y,\n" 6437 " pos.width(),\n" 6438 " pos.height())\n" 6439 " styleMask:NSBorderlessWindowMask\n" 6440 " backing:NSBackingStoreBuffered\n" 6441 " defer:NO]);\n" 6442 "}", 6443 getChromiumStyle(FormatStyle::LK_Cpp)); 6444 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" 6445 " with:contentsNativeView];"); 6446 6447 verifyFormat( 6448 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" 6449 " owner:nillllll];"); 6450 6451 verifyFormat( 6452 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" 6453 " forType:kBookmarkButtonDragType];"); 6454 6455 verifyFormat("[defaultCenter addObserver:self\n" 6456 " selector:@selector(willEnterFullscreen)\n" 6457 " name:kWillEnterFullscreenNotification\n" 6458 " object:nil];"); 6459 verifyFormat("[image_rep drawInRect:drawRect\n" 6460 " fromRect:NSZeroRect\n" 6461 " operation:NSCompositeCopy\n" 6462 " fraction:1.0\n" 6463 " respectFlipped:NO\n" 6464 " hints:nil];"); 6465 6466 verifyFormat( 6467 "scoped_nsobject<NSTextField> message(\n" 6468 " // The frame will be fixed up when |-setMessageText:| is called.\n" 6469 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); 6470 verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" 6471 " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" 6472 " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" 6473 " aaaa:bbb];"); 6474 verifyFormat("[self param:function( //\n" 6475 " parameter)]"); 6476 verifyFormat( 6477 "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 6478 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 6479 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); 6480 6481 // Variadic parameters. 6482 verifyFormat( 6483 "NSArray *myStrings = [NSArray stringarray:@\"a\", @\"b\", nil];"); 6484 verifyFormat( 6485 "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 6486 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 6487 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); 6488 verifyFormat("[self // break\n" 6489 " a:a\n" 6490 " aaa:aaa];"); 6491 verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" 6492 " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); 6493 } 6494 6495 TEST_F(FormatTest, ObjCAt) { 6496 verifyFormat("@autoreleasepool"); 6497 verifyFormat("@catch"); 6498 verifyFormat("@class"); 6499 verifyFormat("@compatibility_alias"); 6500 verifyFormat("@defs"); 6501 verifyFormat("@dynamic"); 6502 verifyFormat("@encode"); 6503 verifyFormat("@end"); 6504 verifyFormat("@finally"); 6505 verifyFormat("@implementation"); 6506 verifyFormat("@import"); 6507 verifyFormat("@interface"); 6508 verifyFormat("@optional"); 6509 verifyFormat("@package"); 6510 verifyFormat("@private"); 6511 verifyFormat("@property"); 6512 verifyFormat("@protected"); 6513 verifyFormat("@protocol"); 6514 verifyFormat("@public"); 6515 verifyFormat("@required"); 6516 verifyFormat("@selector"); 6517 verifyFormat("@synchronized"); 6518 verifyFormat("@synthesize"); 6519 verifyFormat("@throw"); 6520 verifyFormat("@try"); 6521 6522 EXPECT_EQ("@interface", format("@ interface")); 6523 6524 // The precise formatting of this doesn't matter, nobody writes code like 6525 // this. 6526 verifyFormat("@ /*foo*/ interface"); 6527 } 6528 6529 TEST_F(FormatTest, ObjCSnippets) { 6530 verifyFormat("@autoreleasepool {\n" 6531 " foo();\n" 6532 "}"); 6533 verifyFormat("@class Foo, Bar;"); 6534 verifyFormat("@compatibility_alias AliasName ExistingClass;"); 6535 verifyFormat("@dynamic textColor;"); 6536 verifyFormat("char *buf1 = @encode(int *);"); 6537 verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); 6538 verifyFormat("char *buf1 = @encode(int **);"); 6539 verifyFormat("Protocol *proto = @protocol(p1);"); 6540 verifyFormat("SEL s = @selector(foo:);"); 6541 verifyFormat("@synchronized(self) {\n" 6542 " f();\n" 6543 "}"); 6544 6545 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 6546 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 6547 6548 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); 6549 verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); 6550 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;"); 6551 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 6552 getMozillaStyle()); 6553 verifyFormat("@property BOOL editable;", getMozillaStyle()); 6554 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 6555 getWebKitStyle()); 6556 verifyFormat("@property BOOL editable;", getWebKitStyle()); 6557 6558 verifyFormat("@import foo.bar;\n" 6559 "@import baz;"); 6560 } 6561 6562 TEST_F(FormatTest, ObjCLiterals) { 6563 verifyFormat("@\"String\""); 6564 verifyFormat("@1"); 6565 verifyFormat("@+4.8"); 6566 verifyFormat("@-4"); 6567 verifyFormat("@1LL"); 6568 verifyFormat("@.5"); 6569 verifyFormat("@'c'"); 6570 verifyFormat("@true"); 6571 6572 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); 6573 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); 6574 verifyFormat("NSNumber *favoriteColor = @(Green);"); 6575 verifyFormat("NSString *path = @(getenv(\"PATH\"));"); 6576 6577 verifyFormat("[dictionary setObject:@(1) forKey:@\"number\"];"); 6578 } 6579 6580 TEST_F(FormatTest, ObjCDictLiterals) { 6581 verifyFormat("@{"); 6582 verifyFormat("@{}"); 6583 verifyFormat("@{@\"one\" : @1}"); 6584 verifyFormat("return @{@\"one\" : @1;"); 6585 verifyFormat("@{@\"one\" : @1}"); 6586 6587 verifyFormat("@{@\"one\" : @{@2 : @1}}"); 6588 verifyFormat("@{\n" 6589 " @\"one\" : @{@2 : @1},\n" 6590 "}"); 6591 6592 verifyFormat("@{1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2}"); 6593 verifyFormat("[self setDict:@{}"); 6594 verifyFormat("[self setDict:@{@1 : @2}"); 6595 verifyFormat("NSLog(@\"%@\", @{@1 : @2, @2 : @3}[@1]);"); 6596 verifyFormat( 6597 "NSDictionary *masses = @{@\"H\" : @1.0078, @\"He\" : @4.0026};"); 6598 verifyFormat( 6599 "NSDictionary *settings = @{AVEncoderKey : @(AVAudioQualityMax)};"); 6600 6601 verifyFormat( 6602 "NSDictionary *d = @{\n" 6603 " @\"nam\" : NSUserNam(),\n" 6604 " @\"dte\" : [NSDate date],\n" 6605 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 6606 "};"); 6607 verifyFormat( 6608 "@{\n" 6609 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 6610 "regularFont,\n" 6611 "};"); 6612 verifyGoogleFormat( 6613 "@{\n" 6614 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 6615 "regularFont,\n" 6616 "};"); 6617 verifyFormat( 6618 "@{\n" 6619 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" 6620 " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" 6621 "};"); 6622 6623 // We should try to be robust in case someone forgets the "@". 6624 verifyFormat( 6625 "NSDictionary *d = {\n" 6626 " @\"nam\" : NSUserNam(),\n" 6627 " @\"dte\" : [NSDate date],\n" 6628 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 6629 "};"); 6630 verifyFormat("NSMutableDictionary *dictionary =\n" 6631 " [NSMutableDictionary dictionaryWithDictionary:@{\n" 6632 " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" 6633 " bbbbbbbbbbbbbbbbbb : bbbbb,\n" 6634 " cccccccccccccccc : ccccccccccccccc\n" 6635 " }];"); 6636 } 6637 6638 TEST_F(FormatTest, ObjCArrayLiterals) { 6639 verifyFormat("@["); 6640 verifyFormat("@[]"); 6641 verifyFormat( 6642 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); 6643 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); 6644 verifyFormat("NSArray *array = @[ [foo description] ];"); 6645 6646 verifyFormat( 6647 "NSArray *some_variable = @[\n" 6648 " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" 6649 " @\"aaaaaaaaaaaaaaaaa\",\n" 6650 " @\"aaaaaaaaaaaaaaaaa\",\n" 6651 " @\"aaaaaaaaaaaaaaaaa\"\n" 6652 "];"); 6653 verifyFormat("NSArray *some_variable = @[\n" 6654 " @\"aaaaaaaaaaaaaaaaa\",\n" 6655 " @\"aaaaaaaaaaaaaaaaa\",\n" 6656 " @\"aaaaaaaaaaaaaaaaa\",\n" 6657 " @\"aaaaaaaaaaaaaaaaa\",\n" 6658 "];"); 6659 verifyGoogleFormat("NSArray *some_variable = @[\n" 6660 " @\"aaaaaaaaaaaaaaaaa\",\n" 6661 " @\"aaaaaaaaaaaaaaaaa\",\n" 6662 " @\"aaaaaaaaaaaaaaaaa\",\n" 6663 " @\"aaaaaaaaaaaaaaaaa\"\n" 6664 "];"); 6665 6666 // We should try to be robust in case someone forgets the "@". 6667 verifyFormat("NSArray *some_variable = [\n" 6668 " @\"aaaaaaaaaaaaaaaaa\",\n" 6669 " @\"aaaaaaaaaaaaaaaaa\",\n" 6670 " @\"aaaaaaaaaaaaaaaaa\",\n" 6671 " @\"aaaaaaaaaaaaaaaaa\",\n" 6672 "];"); 6673 verifyFormat( 6674 "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" 6675 " index:(NSUInteger)index\n" 6676 " nonDigitAttributes:\n" 6677 " (NSDictionary *)noDigitAttributes;"); 6678 verifyFormat( 6679 "[someFunction someLooooooooooooongParameter:\n" 6680 " @[ NSBundle.mainBundle.infoDictionary[@\"a\"] ]];"); 6681 } 6682 6683 TEST_F(FormatTest, ReformatRegionAdjustsIndent) { 6684 EXPECT_EQ("{\n" 6685 "{\n" 6686 "a;\n" 6687 "b;\n" 6688 "}\n" 6689 "}", 6690 format("{\n" 6691 "{\n" 6692 "a;\n" 6693 " b;\n" 6694 "}\n" 6695 "}", 6696 13, 2, getLLVMStyle())); 6697 EXPECT_EQ("{\n" 6698 "{\n" 6699 " a;\n" 6700 "b;\n" 6701 "}\n" 6702 "}", 6703 format("{\n" 6704 "{\n" 6705 " a;\n" 6706 "b;\n" 6707 "}\n" 6708 "}", 6709 9, 2, getLLVMStyle())); 6710 EXPECT_EQ("{\n" 6711 "{\n" 6712 "public:\n" 6713 " b;\n" 6714 "}\n" 6715 "}", 6716 format("{\n" 6717 "{\n" 6718 "public:\n" 6719 " b;\n" 6720 "}\n" 6721 "}", 6722 17, 2, getLLVMStyle())); 6723 EXPECT_EQ("{\n" 6724 "{\n" 6725 "a;\n" 6726 "}\n" 6727 "{\n" 6728 " b; //\n" 6729 "}\n" 6730 "}", 6731 format("{\n" 6732 "{\n" 6733 "a;\n" 6734 "}\n" 6735 "{\n" 6736 " b; //\n" 6737 "}\n" 6738 "}", 6739 22, 2, getLLVMStyle())); 6740 EXPECT_EQ(" {\n" 6741 " a; //\n" 6742 " }", 6743 format(" {\n" 6744 "a; //\n" 6745 " }", 6746 4, 2, getLLVMStyle())); 6747 EXPECT_EQ("void f() {}\n" 6748 "void g() {}", 6749 format("void f() {}\n" 6750 "void g() {}", 6751 13, 0, getLLVMStyle())); 6752 EXPECT_EQ("int a; // comment\n" 6753 " // line 2\n" 6754 "int b;", 6755 format("int a; // comment\n" 6756 " // line 2\n" 6757 " int b;", 6758 35, 0, getLLVMStyle())); 6759 EXPECT_EQ(" int a;\n" 6760 " void\n" 6761 " ffffff() {\n" 6762 " }", 6763 format(" int a;\n" 6764 "void ffffff() {}", 6765 11, 0, getLLVMStyleWithColumns(11))); 6766 6767 EXPECT_EQ(" void f() {\n" 6768 "#define A 1\n" 6769 " }", 6770 format(" void f() {\n" 6771 " #define A 1\n" // Format this line. 6772 " }", 6773 20, 0, getLLVMStyle())); 6774 EXPECT_EQ(" void f() {\n" 6775 " int i;\n" 6776 "#define A \\\n" 6777 " int i; \\\n" 6778 " int j;\n" 6779 " int k;\n" 6780 " }", 6781 format(" void f() {\n" 6782 " int i;\n" 6783 "#define A \\\n" 6784 " int i; \\\n" 6785 " int j;\n" 6786 " int k;\n" // Format this line. 6787 " }", 6788 67, 0, getLLVMStyle())); 6789 } 6790 6791 TEST_F(FormatTest, BreaksStringLiterals) { 6792 EXPECT_EQ("\"some text \"\n" 6793 "\"other\";", 6794 format("\"some text other\";", getLLVMStyleWithColumns(12))); 6795 EXPECT_EQ("\"some text \"\n" 6796 "\"other\";", 6797 format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); 6798 EXPECT_EQ( 6799 "#define A \\\n" 6800 " \"some \" \\\n" 6801 " \"text \" \\\n" 6802 " \"other\";", 6803 format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); 6804 EXPECT_EQ( 6805 "#define A \\\n" 6806 " \"so \" \\\n" 6807 " \"text \" \\\n" 6808 " \"other\";", 6809 format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); 6810 6811 EXPECT_EQ("\"some text\"", 6812 format("\"some text\"", getLLVMStyleWithColumns(1))); 6813 EXPECT_EQ("\"some text\"", 6814 format("\"some text\"", getLLVMStyleWithColumns(11))); 6815 EXPECT_EQ("\"some \"\n" 6816 "\"text\"", 6817 format("\"some text\"", getLLVMStyleWithColumns(10))); 6818 EXPECT_EQ("\"some \"\n" 6819 "\"text\"", 6820 format("\"some text\"", getLLVMStyleWithColumns(7))); 6821 EXPECT_EQ("\"some\"\n" 6822 "\" tex\"\n" 6823 "\"t\"", 6824 format("\"some text\"", getLLVMStyleWithColumns(6))); 6825 EXPECT_EQ("\"some\"\n" 6826 "\" tex\"\n" 6827 "\" and\"", 6828 format("\"some tex and\"", getLLVMStyleWithColumns(6))); 6829 EXPECT_EQ("\"some\"\n" 6830 "\"/tex\"\n" 6831 "\"/and\"", 6832 format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); 6833 6834 EXPECT_EQ("variable =\n" 6835 " \"long string \"\n" 6836 " \"literal\";", 6837 format("variable = \"long string literal\";", 6838 getLLVMStyleWithColumns(20))); 6839 6840 EXPECT_EQ("variable = f(\n" 6841 " \"long string \"\n" 6842 " \"literal\",\n" 6843 " short,\n" 6844 " loooooooooooooooooooong);", 6845 format("variable = f(\"long string literal\", short, " 6846 "loooooooooooooooooooong);", 6847 getLLVMStyleWithColumns(20))); 6848 6849 EXPECT_EQ("f(g(\"long string \"\n" 6850 " \"literal\"),\n" 6851 " b);", 6852 format("f(g(\"long string literal\"), b);", 6853 getLLVMStyleWithColumns(20))); 6854 EXPECT_EQ("f(g(\"long string \"\n" 6855 " \"literal\",\n" 6856 " a),\n" 6857 " b);", 6858 format("f(g(\"long string literal\", a), b);", 6859 getLLVMStyleWithColumns(20))); 6860 EXPECT_EQ( 6861 "f(\"one two\".split(\n" 6862 " variable));", 6863 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); 6864 EXPECT_EQ("f(\"one two three four five six \"\n" 6865 " \"seven\".split(\n" 6866 " really_looooong_variable));", 6867 format("f(\"one two three four five six seven\"." 6868 "split(really_looooong_variable));", 6869 getLLVMStyleWithColumns(33))); 6870 6871 EXPECT_EQ("f(\"some \"\n" 6872 " \"text\",\n" 6873 " other);", 6874 format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); 6875 6876 // Only break as a last resort. 6877 verifyFormat( 6878 "aaaaaaaaaaaaaaaaaaaa(\n" 6879 " aaaaaaaaaaaaaaaaaaaa,\n" 6880 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); 6881 6882 EXPECT_EQ( 6883 "\"splitmea\"\n" 6884 "\"trandomp\"\n" 6885 "\"oint\"", 6886 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); 6887 6888 EXPECT_EQ( 6889 "\"split/\"\n" 6890 "\"pathat/\"\n" 6891 "\"slashes\"", 6892 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 6893 6894 EXPECT_EQ( 6895 "\"split/\"\n" 6896 "\"pathat/\"\n" 6897 "\"slashes\"", 6898 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 6899 EXPECT_EQ("\"split at \"\n" 6900 "\"spaces/at/\"\n" 6901 "\"slashes.at.any$\"\n" 6902 "\"non-alphanumeric%\"\n" 6903 "\"1111111111characte\"\n" 6904 "\"rs\"", 6905 format("\"split at " 6906 "spaces/at/" 6907 "slashes.at." 6908 "any$non-" 6909 "alphanumeric%" 6910 "1111111111characte" 6911 "rs\"", 6912 getLLVMStyleWithColumns(20))); 6913 6914 // Verify that splitting the strings understands 6915 // Style::AlwaysBreakBeforeMultilineStrings. 6916 EXPECT_EQ("aaaaaaaaaaaa(aaaaaaaaaaaaa,\n" 6917 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa \"\n" 6918 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\");", 6919 format("aaaaaaaaaaaa(aaaaaaaaaaaaa, \"aaaaaaaaaaaaaaaaaaaaaa " 6920 "aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa " 6921 "aaaaaaaaaaaaaaaaaaaaaa\");", 6922 getGoogleStyle())); 6923 EXPECT_EQ("return \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6924 " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\";", 6925 format("return \"aaaaaaaaaaaaaaaaaaaaaa " 6926 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " 6927 "aaaaaaaaaaaaaaaaaaaaaa\";", 6928 getGoogleStyle())); 6929 EXPECT_EQ("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6930 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 6931 format("llvm::outs() << " 6932 "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa" 6933 "aaaaaaaaaaaaaaaaaaa\";")); 6934 EXPECT_EQ("ffff(\n" 6935 " {\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6936 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 6937 format("ffff({\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " 6938 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 6939 getGoogleStyle())); 6940 6941 FormatStyle AlignLeft = getLLVMStyleWithColumns(12); 6942 AlignLeft.AlignEscapedNewlinesLeft = true; 6943 EXPECT_EQ( 6944 "#define A \\\n" 6945 " \"some \" \\\n" 6946 " \"text \" \\\n" 6947 " \"other\";", 6948 format("#define A \"some text other\";", AlignLeft)); 6949 } 6950 6951 TEST_F(FormatTest, BreaksStringLiteralsWithTabs) { 6952 EXPECT_EQ( 6953 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 6954 "(\n" 6955 " \"x\t\");", 6956 format("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 6957 "aaaaaaa(" 6958 "\"x\t\");")); 6959 } 6960 6961 TEST_F(FormatTest, BreaksWideAndNSStringLiterals) { 6962 EXPECT_EQ( 6963 "u8\"utf8 string \"\n" 6964 "u8\"literal\";", 6965 format("u8\"utf8 string literal\";", getGoogleStyleWithColumns(16))); 6966 EXPECT_EQ( 6967 "u\"utf16 string \"\n" 6968 "u\"literal\";", 6969 format("u\"utf16 string literal\";", getGoogleStyleWithColumns(16))); 6970 EXPECT_EQ( 6971 "U\"utf32 string \"\n" 6972 "U\"literal\";", 6973 format("U\"utf32 string literal\";", getGoogleStyleWithColumns(16))); 6974 EXPECT_EQ("L\"wide string \"\n" 6975 "L\"literal\";", 6976 format("L\"wide string literal\";", getGoogleStyleWithColumns(16))); 6977 EXPECT_EQ("@\"NSString \"\n" 6978 "@\"literal\";", 6979 format("@\"NSString literal\";", getGoogleStyleWithColumns(19))); 6980 } 6981 6982 TEST_F(FormatTest, BreaksRawStringLiterals) { 6983 EXPECT_EQ("R\"x(raw )x\"\n" 6984 "R\"x(literal)x\";", 6985 format("R\"x(raw literal)x\";", getGoogleStyleWithColumns(15))); 6986 EXPECT_EQ("uR\"x(raw )x\"\n" 6987 "uR\"x(literal)x\";", 6988 format("uR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 6989 EXPECT_EQ("u8R\"x(raw )x\"\n" 6990 "u8R\"x(literal)x\";", 6991 format("u8R\"x(raw literal)x\";", getGoogleStyleWithColumns(17))); 6992 EXPECT_EQ("LR\"x(raw )x\"\n" 6993 "LR\"x(literal)x\";", 6994 format("LR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 6995 EXPECT_EQ("UR\"x(raw )x\"\n" 6996 "UR\"x(literal)x\";", 6997 format("UR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 6998 } 6999 7000 TEST_F(FormatTest, BreaksStringLiteralsWithin_TMacro) { 7001 FormatStyle Style = getLLVMStyleWithColumns(20); 7002 EXPECT_EQ( 7003 "_T(\"aaaaaaaaaaaaaa\")\n" 7004 "_T(\"aaaaaaaaaaaaaa\")\n" 7005 "_T(\"aaaaaaaaaaaa\")", 7006 format(" _T(\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")", Style)); 7007 EXPECT_EQ("f(x, _T(\"aaaaaaaaa\")\n" 7008 " _T(\"aaaaaa\"),\n" 7009 " z);", 7010 format("f(x, _T(\"aaaaaaaaaaaaaaa\"), z);", Style)); 7011 7012 // FIXME: Handle embedded spaces in one iteration. 7013 // EXPECT_EQ("_T(\"aaaaaaaaaaaaa\")\n" 7014 // "_T(\"aaaaaaaaaaaaa\")\n" 7015 // "_T(\"aaaaaaaaaaaaa\")\n" 7016 // "_T(\"a\")", 7017 // format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7018 // getLLVMStyleWithColumns(20))); 7019 EXPECT_EQ( 7020 "_T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7021 format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", Style)); 7022 } 7023 7024 TEST_F(FormatTest, DontSplitStringLiteralsWithEscapedNewlines) { 7025 EXPECT_EQ( 7026 "aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7027 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7028 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 7029 format("aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7030 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7031 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";")); 7032 } 7033 7034 TEST_F(FormatTest, CountsCharactersInMultilineRawStringLiterals) { 7035 EXPECT_EQ("f(g(R\"x(raw literal)x\", a), b);", 7036 format("f(g(R\"x(raw literal)x\", a), b);", getGoogleStyle())); 7037 EXPECT_EQ("fffffffffff(g(R\"x(\n" 7038 "multiline raw string literal xxxxxxxxxxxxxx\n" 7039 ")x\",\n" 7040 " a),\n" 7041 " b);", 7042 format("fffffffffff(g(R\"x(\n" 7043 "multiline raw string literal xxxxxxxxxxxxxx\n" 7044 ")x\", a), b);", 7045 getGoogleStyleWithColumns(20))); 7046 EXPECT_EQ("fffffffffff(\n" 7047 " g(R\"x(qqq\n" 7048 "multiline raw string literal xxxxxxxxxxxxxx\n" 7049 ")x\",\n" 7050 " a),\n" 7051 " b);", 7052 format("fffffffffff(g(R\"x(qqq\n" 7053 "multiline raw string literal xxxxxxxxxxxxxx\n" 7054 ")x\", a), b);", 7055 getGoogleStyleWithColumns(20))); 7056 7057 EXPECT_EQ("fffffffffff(R\"x(\n" 7058 "multiline raw string literal xxxxxxxxxxxxxx\n" 7059 ")x\");", 7060 format("fffffffffff(R\"x(\n" 7061 "multiline raw string literal xxxxxxxxxxxxxx\n" 7062 ")x\");", 7063 getGoogleStyleWithColumns(20))); 7064 EXPECT_EQ("fffffffffff(R\"x(\n" 7065 "multiline raw string literal xxxxxxxxxxxxxx\n" 7066 ")x\" + bbbbbb);", 7067 format("fffffffffff(R\"x(\n" 7068 "multiline raw string literal xxxxxxxxxxxxxx\n" 7069 ")x\" + bbbbbb);", 7070 getGoogleStyleWithColumns(20))); 7071 EXPECT_EQ("fffffffffff(\n" 7072 " R\"x(\n" 7073 "multiline raw string literal xxxxxxxxxxxxxx\n" 7074 ")x\" +\n" 7075 " bbbbbb);", 7076 format("fffffffffff(\n" 7077 " R\"x(\n" 7078 "multiline raw string literal xxxxxxxxxxxxxx\n" 7079 ")x\" + bbbbbb);", 7080 getGoogleStyleWithColumns(20))); 7081 } 7082 7083 TEST_F(FormatTest, SkipsUnknownStringLiterals) { 7084 verifyFormat("string a = \"unterminated;"); 7085 EXPECT_EQ("function(\"unterminated,\n" 7086 " OtherParameter);", 7087 format("function( \"unterminated,\n" 7088 " OtherParameter);")); 7089 } 7090 7091 TEST_F(FormatTest, DoesNotTryToParseUDLiteralsInPreCpp11Code) { 7092 FormatStyle Style = getLLVMStyle(); 7093 Style.Standard = FormatStyle::LS_Cpp03; 7094 EXPECT_EQ("#define x(_a) printf(\"foo\" _a);", 7095 format("#define x(_a) printf(\"foo\"_a);", Style)); 7096 } 7097 7098 TEST_F(FormatTest, UnderstandsCpp1y) { 7099 verifyFormat("int bi{1'000'000};"); 7100 } 7101 7102 TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) { 7103 EXPECT_EQ("someFunction(\"aaabbbcccd\"\n" 7104 " \"ddeeefff\");", 7105 format("someFunction(\"aaabbbcccdddeeefff\");", 7106 getLLVMStyleWithColumns(25))); 7107 EXPECT_EQ("someFunction1234567890(\n" 7108 " \"aaabbbcccdddeeefff\");", 7109 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7110 getLLVMStyleWithColumns(26))); 7111 EXPECT_EQ("someFunction1234567890(\n" 7112 " \"aaabbbcccdddeeeff\"\n" 7113 " \"f\");", 7114 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7115 getLLVMStyleWithColumns(25))); 7116 EXPECT_EQ("someFunction1234567890(\n" 7117 " \"aaabbbcccdddeeeff\"\n" 7118 " \"f\");", 7119 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7120 getLLVMStyleWithColumns(24))); 7121 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7122 " \"ddde \"\n" 7123 " \"efff\");", 7124 format("someFunction(\"aaabbbcc ddde efff\");", 7125 getLLVMStyleWithColumns(25))); 7126 EXPECT_EQ("someFunction(\"aaabbbccc \"\n" 7127 " \"ddeeefff\");", 7128 format("someFunction(\"aaabbbccc ddeeefff\");", 7129 getLLVMStyleWithColumns(25))); 7130 EXPECT_EQ("someFunction1234567890(\n" 7131 " \"aaabb \"\n" 7132 " \"cccdddeeefff\");", 7133 format("someFunction1234567890(\"aaabb cccdddeeefff\");", 7134 getLLVMStyleWithColumns(25))); 7135 EXPECT_EQ("#define A \\\n" 7136 " string s = \\\n" 7137 " \"123456789\" \\\n" 7138 " \"0\"; \\\n" 7139 " int i;", 7140 format("#define A string s = \"1234567890\"; int i;", 7141 getLLVMStyleWithColumns(20))); 7142 // FIXME: Put additional penalties on breaking at non-whitespace locations. 7143 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7144 " \"dddeeeff\"\n" 7145 " \"f\");", 7146 format("someFunction(\"aaabbbcc dddeeefff\");", 7147 getLLVMStyleWithColumns(25))); 7148 } 7149 7150 TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { 7151 EXPECT_EQ("\"\\a\"", 7152 format("\"\\a\"", getLLVMStyleWithColumns(3))); 7153 EXPECT_EQ("\"\\\"", 7154 format("\"\\\"", getLLVMStyleWithColumns(2))); 7155 EXPECT_EQ("\"test\"\n" 7156 "\"\\n\"", 7157 format("\"test\\n\"", getLLVMStyleWithColumns(7))); 7158 EXPECT_EQ("\"tes\\\\\"\n" 7159 "\"n\"", 7160 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); 7161 EXPECT_EQ("\"\\\\\\\\\"\n" 7162 "\"\\n\"", 7163 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); 7164 EXPECT_EQ("\"\\uff01\"", 7165 format("\"\\uff01\"", getLLVMStyleWithColumns(7))); 7166 EXPECT_EQ("\"\\uff01\"\n" 7167 "\"test\"", 7168 format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); 7169 EXPECT_EQ("\"\\Uff01ff02\"", 7170 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); 7171 EXPECT_EQ("\"\\x000000000001\"\n" 7172 "\"next\"", 7173 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); 7174 EXPECT_EQ("\"\\x000000000001next\"", 7175 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); 7176 EXPECT_EQ("\"\\x000000000001\"", 7177 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); 7178 EXPECT_EQ("\"test\"\n" 7179 "\"\\000000\"\n" 7180 "\"000001\"", 7181 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); 7182 EXPECT_EQ("\"test\\000\"\n" 7183 "\"00000000\"\n" 7184 "\"1\"", 7185 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); 7186 // FIXME: We probably don't need to care about escape sequences in raw 7187 // literals. 7188 EXPECT_EQ("R\"(\\x)\"\n" 7189 "R\"(\\x00)\"\n", 7190 format("R\"(\\x\\x00)\"\n", getGoogleStyleWithColumns(7))); 7191 } 7192 7193 TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { 7194 verifyFormat("void f() {\n" 7195 " return g() {}\n" 7196 " void h() {}"); 7197 verifyFormat("int a[] = {void forgot_closing_brace(){f();\n" 7198 "g();\n" 7199 "}"); 7200 } 7201 7202 TEST_F(FormatTest, DoNotPrematurelyEndUnwrappedLineForReturnStatements) { 7203 verifyFormat( 7204 "void f() { return C{param1, param2}.SomeCall(param1, param2); }"); 7205 } 7206 7207 TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) { 7208 verifyFormat("class X {\n" 7209 " void f() {\n" 7210 " }\n" 7211 "};", 7212 getLLVMStyleWithColumns(12)); 7213 } 7214 7215 TEST_F(FormatTest, ConfigurableIndentWidth) { 7216 FormatStyle EightIndent = getLLVMStyleWithColumns(18); 7217 EightIndent.IndentWidth = 8; 7218 EightIndent.ContinuationIndentWidth = 8; 7219 verifyFormat("void f() {\n" 7220 " someFunction();\n" 7221 " if (true) {\n" 7222 " f();\n" 7223 " }\n" 7224 "}", 7225 EightIndent); 7226 verifyFormat("class X {\n" 7227 " void f() {\n" 7228 " }\n" 7229 "};", 7230 EightIndent); 7231 verifyFormat("int x[] = {\n" 7232 " call(),\n" 7233 " call()};", 7234 EightIndent); 7235 } 7236 7237 TEST_F(FormatTest, ConfigurableFunctionDeclarationIndentAfterType) { 7238 verifyFormat("void\n" 7239 "f();", 7240 getLLVMStyleWithColumns(8)); 7241 } 7242 7243 TEST_F(FormatTest, ConfigurableUseOfTab) { 7244 FormatStyle Tab = getLLVMStyleWithColumns(42); 7245 Tab.IndentWidth = 8; 7246 Tab.UseTab = FormatStyle::UT_Always; 7247 Tab.AlignEscapedNewlinesLeft = true; 7248 7249 EXPECT_EQ("if (aaaaaaaa && // q\n" 7250 " bb)\t\t// w\n" 7251 "\t;", 7252 format("if (aaaaaaaa &&// q\n" 7253 "bb)// w\n" 7254 ";", 7255 Tab)); 7256 EXPECT_EQ("if (aaa && bbb) // w\n" 7257 "\t;", 7258 format("if(aaa&&bbb)// w\n" 7259 ";", 7260 Tab)); 7261 7262 verifyFormat("class X {\n" 7263 "\tvoid f() {\n" 7264 "\t\tsomeFunction(parameter1,\n" 7265 "\t\t\t parameter2);\n" 7266 "\t}\n" 7267 "};", 7268 Tab); 7269 verifyFormat("#define A \\\n" 7270 "\tvoid f() { \\\n" 7271 "\t\tsomeFunction( \\\n" 7272 "\t\t parameter1, \\\n" 7273 "\t\t parameter2); \\\n" 7274 "\t}", 7275 Tab); 7276 EXPECT_EQ("void f() {\n" 7277 "\tf();\n" 7278 "\tg();\n" 7279 "}", 7280 format("void f() {\n" 7281 "\tf();\n" 7282 "\tg();\n" 7283 "}", 7284 0, 0, Tab)); 7285 EXPECT_EQ("void f() {\n" 7286 "\tf();\n" 7287 "\tg();\n" 7288 "}", 7289 format("void f() {\n" 7290 "\tf();\n" 7291 "\tg();\n" 7292 "}", 7293 16, 0, Tab)); 7294 EXPECT_EQ("void f() {\n" 7295 " \tf();\n" 7296 "\tg();\n" 7297 "}", 7298 format("void f() {\n" 7299 " \tf();\n" 7300 " \tg();\n" 7301 "}", 7302 21, 0, Tab)); 7303 7304 Tab.TabWidth = 4; 7305 Tab.IndentWidth = 8; 7306 verifyFormat("class TabWidth4Indent8 {\n" 7307 "\t\tvoid f() {\n" 7308 "\t\t\t\tsomeFunction(parameter1,\n" 7309 "\t\t\t\t\t\t\t parameter2);\n" 7310 "\t\t}\n" 7311 "};", 7312 Tab); 7313 7314 Tab.TabWidth = 4; 7315 Tab.IndentWidth = 4; 7316 verifyFormat("class TabWidth4Indent4 {\n" 7317 "\tvoid f() {\n" 7318 "\t\tsomeFunction(parameter1,\n" 7319 "\t\t\t\t\t parameter2);\n" 7320 "\t}\n" 7321 "};", 7322 Tab); 7323 7324 Tab.TabWidth = 8; 7325 Tab.IndentWidth = 4; 7326 verifyFormat("class TabWidth8Indent4 {\n" 7327 " void f() {\n" 7328 "\tsomeFunction(parameter1,\n" 7329 "\t\t parameter2);\n" 7330 " }\n" 7331 "};", 7332 Tab); 7333 7334 Tab.TabWidth = 8; 7335 Tab.IndentWidth = 8; 7336 EXPECT_EQ("/*\n" 7337 "\t a\t\tcomment\n" 7338 "\t in multiple lines\n" 7339 " */", 7340 format(" /*\t \t \n" 7341 " \t \t a\t\tcomment\t \t\n" 7342 " \t \t in multiple lines\t\n" 7343 " \t */", 7344 Tab)); 7345 7346 Tab.UseTab = FormatStyle::UT_ForIndentation; 7347 verifyFormat("{\n" 7348 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7349 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7350 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7351 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7352 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7353 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7354 "};", 7355 Tab); 7356 verifyFormat("enum A {\n" 7357 "\ta1, // Force multiple lines\n" 7358 "\ta2,\n" 7359 "\ta3\n" 7360 "};", 7361 Tab); 7362 EXPECT_EQ("if (aaaaaaaa && // q\n" 7363 " bb) // w\n" 7364 "\t;", 7365 format("if (aaaaaaaa &&// q\n" 7366 "bb)// w\n" 7367 ";", 7368 Tab)); 7369 verifyFormat("class X {\n" 7370 "\tvoid f() {\n" 7371 "\t\tsomeFunction(parameter1,\n" 7372 "\t\t parameter2);\n" 7373 "\t}\n" 7374 "};", 7375 Tab); 7376 verifyFormat("{\n" 7377 "\tQ({\n" 7378 "\t\t int a;\n" 7379 "\t\t someFunction(aaaaaaaaaa,\n" 7380 "\t\t bbbbbbbbb);\n" 7381 "\t },\n" 7382 "\t p);\n" 7383 "}", 7384 Tab); 7385 EXPECT_EQ("{\n" 7386 "\t/* aaaa\n" 7387 "\t bbbb */\n" 7388 "}", 7389 format("{\n" 7390 "/* aaaa\n" 7391 " bbbb */\n" 7392 "}", 7393 Tab)); 7394 EXPECT_EQ("{\n" 7395 "\t/*\n" 7396 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7397 "\t bbbbbbbbbbbbb\n" 7398 "\t*/\n" 7399 "}", 7400 format("{\n" 7401 "/*\n" 7402 " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7403 "*/\n" 7404 "}", 7405 Tab)); 7406 EXPECT_EQ("{\n" 7407 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7408 "\t// bbbbbbbbbbbbb\n" 7409 "}", 7410 format("{\n" 7411 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7412 "}", 7413 Tab)); 7414 EXPECT_EQ("{\n" 7415 "\t/*\n" 7416 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7417 "\t bbbbbbbbbbbbb\n" 7418 "\t*/\n" 7419 "}", 7420 format("{\n" 7421 "\t/*\n" 7422 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7423 "\t*/\n" 7424 "}", 7425 Tab)); 7426 EXPECT_EQ("{\n" 7427 "\t/*\n" 7428 "\n" 7429 "\t*/\n" 7430 "}", 7431 format("{\n" 7432 "\t/*\n" 7433 "\n" 7434 "\t*/\n" 7435 "}", 7436 Tab)); 7437 EXPECT_EQ("{\n" 7438 "\t/*\n" 7439 " asdf\n" 7440 "\t*/\n" 7441 "}", 7442 format("{\n" 7443 "\t/*\n" 7444 " asdf\n" 7445 "\t*/\n" 7446 "}", 7447 Tab)); 7448 7449 Tab.UseTab = FormatStyle::UT_Never; 7450 EXPECT_EQ("/*\n" 7451 " a\t\tcomment\n" 7452 " in multiple lines\n" 7453 " */", 7454 format(" /*\t \t \n" 7455 " \t \t a\t\tcomment\t \t\n" 7456 " \t \t in multiple lines\t\n" 7457 " \t */", 7458 Tab)); 7459 EXPECT_EQ("/* some\n" 7460 " comment */", 7461 format(" \t \t /* some\n" 7462 " \t \t comment */", 7463 Tab)); 7464 EXPECT_EQ("int a; /* some\n" 7465 " comment */", 7466 format(" \t \t int a; /* some\n" 7467 " \t \t comment */", 7468 Tab)); 7469 7470 EXPECT_EQ("int a; /* some\n" 7471 "comment */", 7472 format(" \t \t int\ta; /* some\n" 7473 " \t \t comment */", 7474 Tab)); 7475 EXPECT_EQ("f(\"\t\t\"); /* some\n" 7476 " comment */", 7477 format(" \t \t f(\"\t\t\"); /* some\n" 7478 " \t \t comment */", 7479 Tab)); 7480 EXPECT_EQ("{\n" 7481 " /*\n" 7482 " * Comment\n" 7483 " */\n" 7484 " int i;\n" 7485 "}", 7486 format("{\n" 7487 "\t/*\n" 7488 "\t * Comment\n" 7489 "\t */\n" 7490 "\t int i;\n" 7491 "}")); 7492 } 7493 7494 TEST_F(FormatTest, CalculatesOriginalColumn) { 7495 EXPECT_EQ("\"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7496 "q\"; /* some\n" 7497 " comment */", 7498 format(" \"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7499 "q\"; /* some\n" 7500 " comment */", 7501 getLLVMStyle())); 7502 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 7503 "/* some\n" 7504 " comment */", 7505 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 7506 " /* some\n" 7507 " comment */", 7508 getLLVMStyle())); 7509 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7510 "qqq\n" 7511 "/* some\n" 7512 " comment */", 7513 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7514 "qqq\n" 7515 " /* some\n" 7516 " comment */", 7517 getLLVMStyle())); 7518 EXPECT_EQ("inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7519 "wwww; /* some\n" 7520 " comment */", 7521 format(" inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7522 "wwww; /* some\n" 7523 " comment */", 7524 getLLVMStyle())); 7525 } 7526 7527 TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { 7528 FormatStyle NoSpace = getLLVMStyle(); 7529 NoSpace.SpaceBeforeParens = FormatStyle::SBPO_Never; 7530 7531 verifyFormat("while(true)\n" 7532 " continue;", NoSpace); 7533 verifyFormat("for(;;)\n" 7534 " continue;", NoSpace); 7535 verifyFormat("if(true)\n" 7536 " f();\n" 7537 "else if(true)\n" 7538 " f();", NoSpace); 7539 verifyFormat("do {\n" 7540 " do_something();\n" 7541 "} while(something());", NoSpace); 7542 verifyFormat("switch(x) {\n" 7543 "default:\n" 7544 " break;\n" 7545 "}", NoSpace); 7546 verifyFormat("auto i = std::make_unique<int>(5);", NoSpace); 7547 verifyFormat("size_t x = sizeof(x);", NoSpace); 7548 verifyFormat("auto f(int x) -> decltype(x);", NoSpace); 7549 verifyFormat("int f(T x) noexcept(x.create());", NoSpace); 7550 verifyFormat("alignas(128) char a[128];", NoSpace); 7551 verifyFormat("size_t x = alignof(MyType);", NoSpace); 7552 verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace); 7553 verifyFormat("int f() throw(Deprecated);", NoSpace); 7554 7555 FormatStyle Space = getLLVMStyle(); 7556 Space.SpaceBeforeParens = FormatStyle::SBPO_Always; 7557 7558 verifyFormat("int f ();", Space); 7559 verifyFormat("void f (int a, T b) {\n" 7560 " while (true)\n" 7561 " continue;\n" 7562 "}", 7563 Space); 7564 verifyFormat("if (true)\n" 7565 " f ();\n" 7566 "else if (true)\n" 7567 " f ();", 7568 Space); 7569 verifyFormat("do {\n" 7570 " do_something ();\n" 7571 "} while (something ());", 7572 Space); 7573 verifyFormat("switch (x) {\n" 7574 "default:\n" 7575 " break;\n" 7576 "}", 7577 Space); 7578 verifyFormat("A::A () : a (1) {}", Space); 7579 verifyFormat("void f () __attribute__ ((asdf));", Space); 7580 verifyFormat("*(&a + 1);\n" 7581 "&((&a)[1]);\n" 7582 "a[(b + c) * d];\n" 7583 "(((a + 1) * 2) + 3) * 4;", 7584 Space); 7585 verifyFormat("#define A(x) x", Space); 7586 verifyFormat("#define A (x) x", Space); 7587 verifyFormat("#if defined(x)\n" 7588 "#endif", 7589 Space); 7590 verifyFormat("auto i = std::make_unique<int> (5);", Space); 7591 verifyFormat("size_t x = sizeof (x);", Space); 7592 verifyFormat("auto f (int x) -> decltype (x);", Space); 7593 verifyFormat("int f (T x) noexcept (x.create ());", Space); 7594 verifyFormat("alignas (128) char a[128];", Space); 7595 verifyFormat("size_t x = alignof (MyType);", Space); 7596 verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space); 7597 verifyFormat("int f () throw (Deprecated);", Space); 7598 } 7599 7600 TEST_F(FormatTest, ConfigurableSpacesInParentheses) { 7601 FormatStyle Spaces = getLLVMStyle(); 7602 7603 Spaces.SpacesInParentheses = true; 7604 verifyFormat("call( x, y, z );", Spaces); 7605 verifyFormat("while ( (bool)1 )\n" 7606 " continue;", Spaces); 7607 verifyFormat("for ( ;; )\n" 7608 " continue;", Spaces); 7609 verifyFormat("if ( true )\n" 7610 " f();\n" 7611 "else if ( true )\n" 7612 " f();", Spaces); 7613 verifyFormat("do {\n" 7614 " do_something( (int)i );\n" 7615 "} while ( something() );", Spaces); 7616 verifyFormat("switch ( x ) {\n" 7617 "default:\n" 7618 " break;\n" 7619 "}", Spaces); 7620 7621 Spaces.SpacesInParentheses = false; 7622 Spaces.SpacesInCStyleCastParentheses = true; 7623 verifyFormat("Type *A = ( Type * )P;", Spaces); 7624 verifyFormat("Type *A = ( vector<Type *, int *> )P;", Spaces); 7625 verifyFormat("x = ( int32 )y;", Spaces); 7626 verifyFormat("int a = ( int )(2.0f);", Spaces); 7627 verifyFormat("#define AA(X) sizeof((( X * )NULL)->a)", Spaces); 7628 verifyFormat("my_int a = ( my_int )sizeof(int);", Spaces); 7629 verifyFormat("#define x (( int )-1)", Spaces); 7630 7631 Spaces.SpacesInParentheses = false; 7632 Spaces.SpaceInEmptyParentheses = true; 7633 verifyFormat("call(x, y, z);", Spaces); 7634 verifyFormat("call( )", Spaces); 7635 7636 // Run the first set of tests again with 7637 // Spaces.SpacesInParentheses = false, 7638 // Spaces.SpaceInEmptyParentheses = true and 7639 // Spaces.SpacesInCStyleCastParentheses = true 7640 Spaces.SpacesInParentheses = false, 7641 Spaces.SpaceInEmptyParentheses = true; 7642 Spaces.SpacesInCStyleCastParentheses = true; 7643 verifyFormat("call(x, y, z);", Spaces); 7644 verifyFormat("while (( bool )1)\n" 7645 " continue;", Spaces); 7646 verifyFormat("for (;;)\n" 7647 " continue;", Spaces); 7648 verifyFormat("if (true)\n" 7649 " f( );\n" 7650 "else if (true)\n" 7651 " f( );", Spaces); 7652 verifyFormat("do {\n" 7653 " do_something(( int )i);\n" 7654 "} while (something( ));", Spaces); 7655 verifyFormat("switch (x) {\n" 7656 "default:\n" 7657 " break;\n" 7658 "}", Spaces); 7659 } 7660 7661 TEST_F(FormatTest, ConfigurableSpaceBeforeAssignmentOperators) { 7662 verifyFormat("int a = 5;"); 7663 verifyFormat("a += 42;"); 7664 verifyFormat("a or_eq 8;"); 7665 7666 FormatStyle Spaces = getLLVMStyle(); 7667 Spaces.SpaceBeforeAssignmentOperators = false; 7668 verifyFormat("int a= 5;", Spaces); 7669 verifyFormat("a+= 42;", Spaces); 7670 verifyFormat("a or_eq 8;", Spaces); 7671 } 7672 7673 TEST_F(FormatTest, LinuxBraceBreaking) { 7674 FormatStyle LinuxBraceStyle = getLLVMStyle(); 7675 LinuxBraceStyle.BreakBeforeBraces = FormatStyle::BS_Linux; 7676 verifyFormat("namespace a\n" 7677 "{\n" 7678 "class A\n" 7679 "{\n" 7680 " void f()\n" 7681 " {\n" 7682 " if (true) {\n" 7683 " a();\n" 7684 " b();\n" 7685 " }\n" 7686 " }\n" 7687 " void g() { return; }\n" 7688 "};\n" 7689 "struct B {\n" 7690 " int x;\n" 7691 "};\n" 7692 "}\n", 7693 LinuxBraceStyle); 7694 verifyFormat("enum X {\n" 7695 " Y = 0,\n" 7696 "}\n", 7697 LinuxBraceStyle); 7698 verifyFormat("struct S {\n" 7699 " int Type;\n" 7700 " union {\n" 7701 " int x;\n" 7702 " double y;\n" 7703 " } Value;\n" 7704 " class C\n" 7705 " {\n" 7706 " MyFavoriteType Value;\n" 7707 " } Class;\n" 7708 "}\n", 7709 LinuxBraceStyle); 7710 } 7711 7712 TEST_F(FormatTest, StroustrupBraceBreaking) { 7713 FormatStyle StroustrupBraceStyle = getLLVMStyle(); 7714 StroustrupBraceStyle.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 7715 verifyFormat("namespace a {\n" 7716 "class A {\n" 7717 " void f()\n" 7718 " {\n" 7719 " if (true) {\n" 7720 " a();\n" 7721 " b();\n" 7722 " }\n" 7723 " }\n" 7724 " void g() { return; }\n" 7725 "};\n" 7726 "struct B {\n" 7727 " int x;\n" 7728 "};\n" 7729 "}\n", 7730 StroustrupBraceStyle); 7731 7732 verifyFormat("void foo()\n" 7733 "{\n" 7734 " if (a) {\n" 7735 " a();\n" 7736 " }\n" 7737 " else {\n" 7738 " b();\n" 7739 " }\n" 7740 "}\n", 7741 StroustrupBraceStyle); 7742 7743 verifyFormat("#ifdef _DEBUG\n" 7744 "int foo(int i = 0)\n" 7745 "#else\n" 7746 "int foo(int i = 5)\n" 7747 "#endif\n" 7748 "{\n" 7749 " return i;\n" 7750 "}", 7751 StroustrupBraceStyle); 7752 7753 verifyFormat("void foo() {}\n" 7754 "void bar()\n" 7755 "#ifdef _DEBUG\n" 7756 "{\n" 7757 " foo();\n" 7758 "}\n" 7759 "#else\n" 7760 "{\n" 7761 "}\n" 7762 "#endif", 7763 StroustrupBraceStyle); 7764 7765 verifyFormat("void foobar() { int i = 5; }\n" 7766 "#ifdef _DEBUG\n" 7767 "void bar() {}\n" 7768 "#else\n" 7769 "void bar() { foobar(); }\n" 7770 "#endif", 7771 StroustrupBraceStyle); 7772 } 7773 7774 TEST_F(FormatTest, AllmanBraceBreaking) { 7775 FormatStyle AllmanBraceStyle = getLLVMStyle(); 7776 AllmanBraceStyle.BreakBeforeBraces = FormatStyle::BS_Allman; 7777 verifyFormat("namespace a\n" 7778 "{\n" 7779 "class A\n" 7780 "{\n" 7781 " void f()\n" 7782 " {\n" 7783 " if (true)\n" 7784 " {\n" 7785 " a();\n" 7786 " b();\n" 7787 " }\n" 7788 " }\n" 7789 " void g() { return; }\n" 7790 "};\n" 7791 "struct B\n" 7792 "{\n" 7793 " int x;\n" 7794 "};\n" 7795 "}", 7796 AllmanBraceStyle); 7797 7798 verifyFormat("void f()\n" 7799 "{\n" 7800 " if (true)\n" 7801 " {\n" 7802 " a();\n" 7803 " }\n" 7804 " else if (false)\n" 7805 " {\n" 7806 " b();\n" 7807 " }\n" 7808 " else\n" 7809 " {\n" 7810 " c();\n" 7811 " }\n" 7812 "}\n", 7813 AllmanBraceStyle); 7814 7815 verifyFormat("void f()\n" 7816 "{\n" 7817 " for (int i = 0; i < 10; ++i)\n" 7818 " {\n" 7819 " a();\n" 7820 " }\n" 7821 " while (false)\n" 7822 " {\n" 7823 " b();\n" 7824 " }\n" 7825 " do\n" 7826 " {\n" 7827 " c();\n" 7828 " } while (false)\n" 7829 "}\n", 7830 AllmanBraceStyle); 7831 7832 verifyFormat("void f(int a)\n" 7833 "{\n" 7834 " switch (a)\n" 7835 " {\n" 7836 " case 0:\n" 7837 " break;\n" 7838 " case 1:\n" 7839 " {\n" 7840 " break;\n" 7841 " }\n" 7842 " case 2:\n" 7843 " {\n" 7844 " }\n" 7845 " break;\n" 7846 " default:\n" 7847 " break;\n" 7848 " }\n" 7849 "}\n", 7850 AllmanBraceStyle); 7851 7852 verifyFormat("enum X\n" 7853 "{\n" 7854 " Y = 0,\n" 7855 "}\n", 7856 AllmanBraceStyle); 7857 verifyFormat("enum X\n" 7858 "{\n" 7859 " Y = 0\n" 7860 "}\n", 7861 AllmanBraceStyle); 7862 7863 verifyFormat("@interface BSApplicationController ()\n" 7864 "{\n" 7865 "@private\n" 7866 " id _extraIvar;\n" 7867 "}\n" 7868 "@end\n", 7869 AllmanBraceStyle); 7870 7871 verifyFormat("#ifdef _DEBUG\n" 7872 "int foo(int i = 0)\n" 7873 "#else\n" 7874 "int foo(int i = 5)\n" 7875 "#endif\n" 7876 "{\n" 7877 " return i;\n" 7878 "}", 7879 AllmanBraceStyle); 7880 7881 verifyFormat("void foo() {}\n" 7882 "void bar()\n" 7883 "#ifdef _DEBUG\n" 7884 "{\n" 7885 " foo();\n" 7886 "}\n" 7887 "#else\n" 7888 "{\n" 7889 "}\n" 7890 "#endif", 7891 AllmanBraceStyle); 7892 7893 verifyFormat("void foobar() { int i = 5; }\n" 7894 "#ifdef _DEBUG\n" 7895 "void bar() {}\n" 7896 "#else\n" 7897 "void bar() { foobar(); }\n" 7898 "#endif", 7899 AllmanBraceStyle); 7900 7901 // This shouldn't affect ObjC blocks.. 7902 verifyFormat("[self doSomeThingWithACompletionHandler:^{\n" 7903 " // ...\n" 7904 " int i;\n" 7905 "}];", 7906 AllmanBraceStyle); 7907 verifyFormat("void (^block)(void) = ^{\n" 7908 " // ...\n" 7909 " int i;\n" 7910 "};", 7911 AllmanBraceStyle); 7912 // .. or dict literals. 7913 verifyFormat("void f()\n" 7914 "{\n" 7915 " [object someMethod:@{ @\"a\" : @\"b\" }];\n" 7916 "}", 7917 AllmanBraceStyle); 7918 7919 AllmanBraceStyle.ColumnLimit = 19; 7920 verifyFormat("void f() { int i; }", AllmanBraceStyle); 7921 AllmanBraceStyle.ColumnLimit = 18; 7922 verifyFormat("void f()\n" 7923 "{\n" 7924 " int i;\n" 7925 "}", 7926 AllmanBraceStyle); 7927 AllmanBraceStyle.ColumnLimit = 80; 7928 7929 FormatStyle BreakBeforeBraceShortIfs = AllmanBraceStyle; 7930 BreakBeforeBraceShortIfs.AllowShortIfStatementsOnASingleLine = true; 7931 BreakBeforeBraceShortIfs.AllowShortLoopsOnASingleLine = true; 7932 verifyFormat("void f(bool b)\n" 7933 "{\n" 7934 " if (b)\n" 7935 " {\n" 7936 " return;\n" 7937 " }\n" 7938 "}\n", 7939 BreakBeforeBraceShortIfs); 7940 verifyFormat("void f(bool b)\n" 7941 "{\n" 7942 " if (b) return;\n" 7943 "}\n", 7944 BreakBeforeBraceShortIfs); 7945 verifyFormat("void f(bool b)\n" 7946 "{\n" 7947 " while (b)\n" 7948 " {\n" 7949 " return;\n" 7950 " }\n" 7951 "}\n", 7952 BreakBeforeBraceShortIfs); 7953 } 7954 7955 TEST_F(FormatTest, GNUBraceBreaking) { 7956 FormatStyle GNUBraceStyle = getLLVMStyle(); 7957 GNUBraceStyle.BreakBeforeBraces = FormatStyle::BS_GNU; 7958 verifyFormat("namespace a\n" 7959 "{\n" 7960 "class A\n" 7961 "{\n" 7962 " void f()\n" 7963 " {\n" 7964 " int a;\n" 7965 " {\n" 7966 " int b;\n" 7967 " }\n" 7968 " if (true)\n" 7969 " {\n" 7970 " a();\n" 7971 " b();\n" 7972 " }\n" 7973 " }\n" 7974 " void g() { return; }\n" 7975 "}\n" 7976 "}", 7977 GNUBraceStyle); 7978 7979 verifyFormat("void f()\n" 7980 "{\n" 7981 " if (true)\n" 7982 " {\n" 7983 " a();\n" 7984 " }\n" 7985 " else if (false)\n" 7986 " {\n" 7987 " b();\n" 7988 " }\n" 7989 " else\n" 7990 " {\n" 7991 " c();\n" 7992 " }\n" 7993 "}\n", 7994 GNUBraceStyle); 7995 7996 verifyFormat("void f()\n" 7997 "{\n" 7998 " for (int i = 0; i < 10; ++i)\n" 7999 " {\n" 8000 " a();\n" 8001 " }\n" 8002 " while (false)\n" 8003 " {\n" 8004 " b();\n" 8005 " }\n" 8006 " do\n" 8007 " {\n" 8008 " c();\n" 8009 " }\n" 8010 " while (false);\n" 8011 "}\n", 8012 GNUBraceStyle); 8013 8014 verifyFormat("void f(int a)\n" 8015 "{\n" 8016 " switch (a)\n" 8017 " {\n" 8018 " case 0:\n" 8019 " break;\n" 8020 " case 1:\n" 8021 " {\n" 8022 " break;\n" 8023 " }\n" 8024 " case 2:\n" 8025 " {\n" 8026 " }\n" 8027 " break;\n" 8028 " default:\n" 8029 " break;\n" 8030 " }\n" 8031 "}\n", 8032 GNUBraceStyle); 8033 8034 verifyFormat("enum X\n" 8035 "{\n" 8036 " Y = 0,\n" 8037 "}\n", 8038 GNUBraceStyle); 8039 8040 verifyFormat("@interface BSApplicationController ()\n" 8041 "{\n" 8042 "@private\n" 8043 " id _extraIvar;\n" 8044 "}\n" 8045 "@end\n", 8046 GNUBraceStyle); 8047 8048 verifyFormat("#ifdef _DEBUG\n" 8049 "int foo(int i = 0)\n" 8050 "#else\n" 8051 "int foo(int i = 5)\n" 8052 "#endif\n" 8053 "{\n" 8054 " return i;\n" 8055 "}", 8056 GNUBraceStyle); 8057 8058 verifyFormat("void foo() {}\n" 8059 "void bar()\n" 8060 "#ifdef _DEBUG\n" 8061 "{\n" 8062 " foo();\n" 8063 "}\n" 8064 "#else\n" 8065 "{\n" 8066 "}\n" 8067 "#endif", 8068 GNUBraceStyle); 8069 8070 verifyFormat("void foobar() { int i = 5; }\n" 8071 "#ifdef _DEBUG\n" 8072 "void bar() {}\n" 8073 "#else\n" 8074 "void bar() { foobar(); }\n" 8075 "#endif", 8076 GNUBraceStyle); 8077 } 8078 TEST_F(FormatTest, CatchExceptionReferenceBinding) { 8079 verifyFormat("void f() {\n" 8080 " try {\n" 8081 " } catch (const Exception &e) {\n" 8082 " }\n" 8083 "}\n", 8084 getLLVMStyle()); 8085 } 8086 8087 TEST_F(FormatTest, UnderstandsPragmas) { 8088 verifyFormat("#pragma omp reduction(| : var)"); 8089 verifyFormat("#pragma omp reduction(+ : var)"); 8090 8091 EXPECT_EQ("#pragma mark Any non-hyphenated or hyphenated string " 8092 "(including parentheses).", 8093 format("#pragma mark Any non-hyphenated or hyphenated string " 8094 "(including parentheses).")); 8095 } 8096 8097 #define EXPECT_ALL_STYLES_EQUAL(Styles) \ 8098 for (size_t i = 1; i < Styles.size(); ++i) \ 8099 EXPECT_EQ(Styles[0], Styles[i]) << "Style #" << i << " of " \ 8100 << Styles.size() \ 8101 << " differs from Style #0" 8102 8103 TEST_F(FormatTest, GetsPredefinedStyleByName) { 8104 SmallVector<FormatStyle, 3> Styles; 8105 Styles.resize(3); 8106 8107 Styles[0] = getLLVMStyle(); 8108 EXPECT_TRUE(getPredefinedStyle("LLVM", FormatStyle::LK_Cpp, &Styles[1])); 8109 EXPECT_TRUE(getPredefinedStyle("lLvM", FormatStyle::LK_Cpp, &Styles[2])); 8110 EXPECT_ALL_STYLES_EQUAL(Styles); 8111 8112 Styles[0] = getGoogleStyle(); 8113 EXPECT_TRUE(getPredefinedStyle("Google", FormatStyle::LK_Cpp, &Styles[1])); 8114 EXPECT_TRUE(getPredefinedStyle("gOOgle", FormatStyle::LK_Cpp, &Styles[2])); 8115 EXPECT_ALL_STYLES_EQUAL(Styles); 8116 8117 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8118 EXPECT_TRUE( 8119 getPredefinedStyle("Google", FormatStyle::LK_JavaScript, &Styles[1])); 8120 EXPECT_TRUE( 8121 getPredefinedStyle("gOOgle", FormatStyle::LK_JavaScript, &Styles[2])); 8122 EXPECT_ALL_STYLES_EQUAL(Styles); 8123 8124 Styles[0] = getChromiumStyle(FormatStyle::LK_Cpp); 8125 EXPECT_TRUE(getPredefinedStyle("Chromium", FormatStyle::LK_Cpp, &Styles[1])); 8126 EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", FormatStyle::LK_Cpp, &Styles[2])); 8127 EXPECT_ALL_STYLES_EQUAL(Styles); 8128 8129 Styles[0] = getMozillaStyle(); 8130 EXPECT_TRUE(getPredefinedStyle("Mozilla", FormatStyle::LK_Cpp, &Styles[1])); 8131 EXPECT_TRUE(getPredefinedStyle("moZILla", FormatStyle::LK_Cpp, &Styles[2])); 8132 EXPECT_ALL_STYLES_EQUAL(Styles); 8133 8134 Styles[0] = getWebKitStyle(); 8135 EXPECT_TRUE(getPredefinedStyle("WebKit", FormatStyle::LK_Cpp, &Styles[1])); 8136 EXPECT_TRUE(getPredefinedStyle("wEbKit", FormatStyle::LK_Cpp, &Styles[2])); 8137 EXPECT_ALL_STYLES_EQUAL(Styles); 8138 8139 Styles[0] = getGNUStyle(); 8140 EXPECT_TRUE(getPredefinedStyle("GNU", FormatStyle::LK_Cpp, &Styles[1])); 8141 EXPECT_TRUE(getPredefinedStyle("gnU", FormatStyle::LK_Cpp, &Styles[2])); 8142 EXPECT_ALL_STYLES_EQUAL(Styles); 8143 8144 EXPECT_FALSE(getPredefinedStyle("qwerty", FormatStyle::LK_Cpp, &Styles[0])); 8145 } 8146 8147 TEST_F(FormatTest, GetsCorrectBasedOnStyle) { 8148 SmallVector<FormatStyle, 8> Styles; 8149 Styles.resize(2); 8150 8151 Styles[0] = getGoogleStyle(); 8152 Styles[1] = getLLVMStyle(); 8153 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8154 EXPECT_ALL_STYLES_EQUAL(Styles); 8155 8156 Styles.resize(5); 8157 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8158 Styles[1] = getLLVMStyle(); 8159 Styles[1].Language = FormatStyle::LK_JavaScript; 8160 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8161 8162 Styles[2] = getLLVMStyle(); 8163 Styles[2].Language = FormatStyle::LK_JavaScript; 8164 EXPECT_EQ(0, parseConfiguration("Language: JavaScript\n" 8165 "BasedOnStyle: Google", 8166 &Styles[2]).value()); 8167 8168 Styles[3] = getLLVMStyle(); 8169 Styles[3].Language = FormatStyle::LK_JavaScript; 8170 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google\n" 8171 "Language: JavaScript", 8172 &Styles[3]).value()); 8173 8174 Styles[4] = getLLVMStyle(); 8175 Styles[4].Language = FormatStyle::LK_JavaScript; 8176 EXPECT_EQ(0, parseConfiguration("---\n" 8177 "BasedOnStyle: LLVM\n" 8178 "IndentWidth: 123\n" 8179 "---\n" 8180 "BasedOnStyle: Google\n" 8181 "Language: JavaScript", 8182 &Styles[4]).value()); 8183 EXPECT_ALL_STYLES_EQUAL(Styles); 8184 } 8185 8186 #define CHECK_PARSE(TEXT, FIELD, VALUE) \ 8187 EXPECT_NE(VALUE, Style.FIELD); \ 8188 EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ 8189 EXPECT_EQ(VALUE, Style.FIELD) 8190 8191 #define CHECK_PARSE_BOOL(FIELD) \ 8192 Style.FIELD = false; \ 8193 EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value()); \ 8194 EXPECT_TRUE(Style.FIELD); \ 8195 EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value()); \ 8196 EXPECT_FALSE(Style.FIELD); 8197 8198 TEST_F(FormatTest, ParsesConfiguration) { 8199 FormatStyle Style = {}; 8200 Style.Language = FormatStyle::LK_Cpp; 8201 CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft); 8202 CHECK_PARSE_BOOL(AlignTrailingComments); 8203 CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); 8204 CHECK_PARSE_BOOL(AllowShortBlocksOnASingleLine); 8205 CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); 8206 CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine); 8207 CHECK_PARSE_BOOL(AlwaysBreakAfterDefinitionReturnType); 8208 CHECK_PARSE_BOOL(AlwaysBreakTemplateDeclarations); 8209 CHECK_PARSE_BOOL(BinPackParameters); 8210 CHECK_PARSE_BOOL(BreakBeforeBinaryOperators); 8211 CHECK_PARSE_BOOL(BreakBeforeTernaryOperators); 8212 CHECK_PARSE_BOOL(BreakConstructorInitializersBeforeComma); 8213 CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); 8214 CHECK_PARSE_BOOL(DerivePointerAlignment); 8215 CHECK_PARSE_BOOL(IndentCaseLabels); 8216 CHECK_PARSE_BOOL(IndentWrappedFunctionNames); 8217 CHECK_PARSE_BOOL(KeepEmptyLinesAtTheStartOfBlocks); 8218 CHECK_PARSE_BOOL(ObjCSpaceAfterProperty); 8219 CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); 8220 CHECK_PARSE_BOOL(Cpp11BracedListStyle); 8221 CHECK_PARSE_BOOL(SpacesInParentheses); 8222 CHECK_PARSE_BOOL(SpacesInAngles); 8223 CHECK_PARSE_BOOL(SpaceInEmptyParentheses); 8224 CHECK_PARSE_BOOL(SpacesInContainerLiterals); 8225 CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); 8226 CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); 8227 8228 CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); 8229 CHECK_PARSE("ConstructorInitializerIndentWidth: 1234", 8230 ConstructorInitializerIndentWidth, 1234u); 8231 CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); 8232 CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); 8233 CHECK_PARSE("PenaltyBreakBeforeFirstCallParameter: 1234", 8234 PenaltyBreakBeforeFirstCallParameter, 1234u); 8235 CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); 8236 CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", 8237 PenaltyReturnTypeOnItsOwnLine, 1234u); 8238 CHECK_PARSE("SpacesBeforeTrailingComments: 1234", 8239 SpacesBeforeTrailingComments, 1234u); 8240 CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u); 8241 CHECK_PARSE("ContinuationIndentWidth: 11", ContinuationIndentWidth, 11u); 8242 8243 Style.PointerAlignment = FormatStyle::PAS_Middle; 8244 CHECK_PARSE("PointerAlignment: Left", PointerAlignment, FormatStyle::PAS_Left); 8245 CHECK_PARSE("PointerAlignment: Right", PointerAlignment, FormatStyle::PAS_Right); 8246 CHECK_PARSE("PointerAlignment: Middle", PointerAlignment, FormatStyle::PAS_Middle); 8247 8248 Style.Standard = FormatStyle::LS_Auto; 8249 CHECK_PARSE("Standard: Cpp03", Standard, FormatStyle::LS_Cpp03); 8250 CHECK_PARSE("Standard: Cpp11", Standard, FormatStyle::LS_Cpp11); 8251 CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); 8252 CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); 8253 CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); 8254 8255 Style.UseTab = FormatStyle::UT_ForIndentation; 8256 CHECK_PARSE("UseTab: false", UseTab, FormatStyle::UT_Never); 8257 CHECK_PARSE("UseTab: true", UseTab, FormatStyle::UT_Always); 8258 CHECK_PARSE("UseTab: Never", UseTab, FormatStyle::UT_Never); 8259 CHECK_PARSE("UseTab: ForIndentation", UseTab, FormatStyle::UT_ForIndentation); 8260 CHECK_PARSE("UseTab: Always", UseTab, FormatStyle::UT_Always); 8261 8262 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 8263 CHECK_PARSE("AllowShortFunctionsOnASingleLine: false", 8264 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8265 CHECK_PARSE("AllowShortFunctionsOnASingleLine: true", 8266 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8267 CHECK_PARSE("AllowShortFunctionsOnASingleLine: None", 8268 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8269 CHECK_PARSE("AllowShortFunctionsOnASingleLine: Inline", 8270 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Inline); 8271 CHECK_PARSE("AllowShortFunctionsOnASingleLine: All", 8272 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8273 8274 Style.SpaceBeforeParens = FormatStyle::SBPO_Always; 8275 CHECK_PARSE("SpaceBeforeParens: Never", SpaceBeforeParens, 8276 FormatStyle::SBPO_Never); 8277 CHECK_PARSE("SpaceBeforeParens: Always", SpaceBeforeParens, 8278 FormatStyle::SBPO_Always); 8279 CHECK_PARSE("SpaceBeforeParens: ControlStatements", SpaceBeforeParens, 8280 FormatStyle::SBPO_ControlStatements); 8281 // For backward compatibility: 8282 CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens, 8283 FormatStyle::SBPO_Never); 8284 CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens, 8285 FormatStyle::SBPO_ControlStatements); 8286 8287 Style.ColumnLimit = 123; 8288 FormatStyle BaseStyle = getLLVMStyle(); 8289 CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); 8290 CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); 8291 8292 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 8293 CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, 8294 FormatStyle::BS_Attach); 8295 CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces, 8296 FormatStyle::BS_Linux); 8297 CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces, 8298 FormatStyle::BS_Stroustrup); 8299 CHECK_PARSE("BreakBeforeBraces: Allman", BreakBeforeBraces, 8300 FormatStyle::BS_Allman); 8301 CHECK_PARSE("BreakBeforeBraces: GNU", BreakBeforeBraces, FormatStyle::BS_GNU); 8302 8303 Style.NamespaceIndentation = FormatStyle::NI_All; 8304 CHECK_PARSE("NamespaceIndentation: None", NamespaceIndentation, 8305 FormatStyle::NI_None); 8306 CHECK_PARSE("NamespaceIndentation: Inner", NamespaceIndentation, 8307 FormatStyle::NI_Inner); 8308 CHECK_PARSE("NamespaceIndentation: All", NamespaceIndentation, 8309 FormatStyle::NI_All); 8310 8311 Style.ForEachMacros.clear(); 8312 std::vector<std::string> BoostForeach; 8313 BoostForeach.push_back("BOOST_FOREACH"); 8314 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH]", ForEachMacros, BoostForeach); 8315 std::vector<std::string> BoostAndQForeach; 8316 BoostAndQForeach.push_back("BOOST_FOREACH"); 8317 BoostAndQForeach.push_back("Q_FOREACH"); 8318 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH, Q_FOREACH]", ForEachMacros, 8319 BoostAndQForeach); 8320 } 8321 8322 TEST_F(FormatTest, ParsesConfigurationWithLanguages) { 8323 FormatStyle Style = {}; 8324 Style.Language = FormatStyle::LK_Cpp; 8325 CHECK_PARSE("Language: Cpp\n" 8326 "IndentWidth: 12", 8327 IndentWidth, 12u); 8328 EXPECT_EQ(parseConfiguration("Language: JavaScript\n" 8329 "IndentWidth: 34", 8330 &Style), 8331 ParseError::Unsuitable); 8332 EXPECT_EQ(12u, Style.IndentWidth); 8333 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 8334 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 8335 8336 Style.Language = FormatStyle::LK_JavaScript; 8337 CHECK_PARSE("Language: JavaScript\n" 8338 "IndentWidth: 12", 8339 IndentWidth, 12u); 8340 CHECK_PARSE("IndentWidth: 23", IndentWidth, 23u); 8341 EXPECT_EQ(parseConfiguration("Language: Cpp\n" 8342 "IndentWidth: 34", 8343 &Style), 8344 ParseError::Unsuitable); 8345 EXPECT_EQ(23u, Style.IndentWidth); 8346 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 8347 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 8348 8349 CHECK_PARSE("BasedOnStyle: LLVM\n" 8350 "IndentWidth: 67", 8351 IndentWidth, 67u); 8352 8353 CHECK_PARSE("---\n" 8354 "Language: JavaScript\n" 8355 "IndentWidth: 12\n" 8356 "---\n" 8357 "Language: Cpp\n" 8358 "IndentWidth: 34\n" 8359 "...\n", 8360 IndentWidth, 12u); 8361 8362 Style.Language = FormatStyle::LK_Cpp; 8363 CHECK_PARSE("---\n" 8364 "Language: JavaScript\n" 8365 "IndentWidth: 12\n" 8366 "---\n" 8367 "Language: Cpp\n" 8368 "IndentWidth: 34\n" 8369 "...\n", 8370 IndentWidth, 34u); 8371 CHECK_PARSE("---\n" 8372 "IndentWidth: 78\n" 8373 "---\n" 8374 "Language: JavaScript\n" 8375 "IndentWidth: 56\n" 8376 "...\n", 8377 IndentWidth, 78u); 8378 8379 Style.ColumnLimit = 123; 8380 Style.IndentWidth = 234; 8381 Style.BreakBeforeBraces = FormatStyle::BS_Linux; 8382 Style.TabWidth = 345; 8383 EXPECT_FALSE(parseConfiguration("---\n" 8384 "IndentWidth: 456\n" 8385 "BreakBeforeBraces: Allman\n" 8386 "---\n" 8387 "Language: JavaScript\n" 8388 "IndentWidth: 111\n" 8389 "TabWidth: 111\n" 8390 "---\n" 8391 "Language: Cpp\n" 8392 "BreakBeforeBraces: Stroustrup\n" 8393 "TabWidth: 789\n" 8394 "...\n", 8395 &Style)); 8396 EXPECT_EQ(123u, Style.ColumnLimit); 8397 EXPECT_EQ(456u, Style.IndentWidth); 8398 EXPECT_EQ(FormatStyle::BS_Stroustrup, Style.BreakBeforeBraces); 8399 EXPECT_EQ(789u, Style.TabWidth); 8400 8401 EXPECT_EQ(parseConfiguration("---\n" 8402 "Language: JavaScript\n" 8403 "IndentWidth: 56\n" 8404 "---\n" 8405 "IndentWidth: 78\n" 8406 "...\n", 8407 &Style), 8408 ParseError::Error); 8409 EXPECT_EQ(parseConfiguration("---\n" 8410 "Language: JavaScript\n" 8411 "IndentWidth: 56\n" 8412 "---\n" 8413 "Language: JavaScript\n" 8414 "IndentWidth: 78\n" 8415 "...\n", 8416 &Style), 8417 ParseError::Error); 8418 8419 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 8420 } 8421 8422 #undef CHECK_PARSE 8423 #undef CHECK_PARSE_BOOL 8424 8425 TEST_F(FormatTest, UsesLanguageForBasedOnStyle) { 8426 FormatStyle Style = {}; 8427 Style.Language = FormatStyle::LK_JavaScript; 8428 Style.BreakBeforeTernaryOperators = true; 8429 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Style).value()); 8430 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 8431 8432 Style.BreakBeforeTernaryOperators = true; 8433 EXPECT_EQ(0, parseConfiguration("---\n" 8434 "BasedOnStyle: Google\n" 8435 "---\n" 8436 "Language: JavaScript\n" 8437 "IndentWidth: 76\n" 8438 "...\n", &Style).value()); 8439 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 8440 EXPECT_EQ(76u, Style.IndentWidth); 8441 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 8442 } 8443 8444 TEST_F(FormatTest, ConfigurationRoundTripTest) { 8445 FormatStyle Style = getLLVMStyle(); 8446 std::string YAML = configurationAsText(Style); 8447 FormatStyle ParsedStyle = {}; 8448 ParsedStyle.Language = FormatStyle::LK_Cpp; 8449 EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); 8450 EXPECT_EQ(Style, ParsedStyle); 8451 } 8452 8453 TEST_F(FormatTest, WorksFor8bitEncodings) { 8454 EXPECT_EQ("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 \"\n" 8455 "\"\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \"\n" 8456 "\"\xe7\xe8\xec\xed\xfe\xfe \"\n" 8457 "\"\xef\xee\xf0\xf3...\"", 8458 format("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 " 8459 "\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \xe7\xe8\xec\xed\xfe\xfe " 8460 "\xef\xee\xf0\xf3...\"", 8461 getLLVMStyleWithColumns(12))); 8462 } 8463 8464 TEST_F(FormatTest, HandlesUTF8BOM) { 8465 EXPECT_EQ("\xef\xbb\xbf", format("\xef\xbb\xbf")); 8466 EXPECT_EQ("\xef\xbb\xbf#include <iostream>", 8467 format("\xef\xbb\xbf#include <iostream>")); 8468 EXPECT_EQ("\xef\xbb\xbf\n#include <iostream>", 8469 format("\xef\xbb\xbf\n#include <iostream>")); 8470 } 8471 8472 // FIXME: Encode Cyrillic and CJK characters below to appease MS compilers. 8473 #if !defined(_MSC_VER) 8474 8475 TEST_F(FormatTest, CountsUTF8CharactersProperly) { 8476 verifyFormat("\"Однажды в студёную зимнюю пору...\"", 8477 getLLVMStyleWithColumns(35)); 8478 verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", 8479 getLLVMStyleWithColumns(31)); 8480 verifyFormat("// Однажды в студёную зимнюю пору...", 8481 getLLVMStyleWithColumns(36)); 8482 verifyFormat("// 一 二 三 四 五 六 七 八 九 十", 8483 getLLVMStyleWithColumns(32)); 8484 verifyFormat("/* Однажды в студёную зимнюю пору... */", 8485 getLLVMStyleWithColumns(39)); 8486 verifyFormat("/* 一 二 三 四 五 六 七 八 九 十 */", 8487 getLLVMStyleWithColumns(35)); 8488 } 8489 8490 TEST_F(FormatTest, SplitsUTF8Strings) { 8491 // Non-printable characters' width is currently considered to be the length in 8492 // bytes in UTF8. The characters can be displayed in very different manner 8493 // (zero-width, single width with a substitution glyph, expanded to their code 8494 // (e.g. "<8d>"), so there's no single correct way to handle them. 8495 EXPECT_EQ("\"aaaaÄ\"\n" 8496 "\"\xc2\x8d\";", 8497 format("\"aaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 8498 EXPECT_EQ("\"aaaaaaaÄ\"\n" 8499 "\"\xc2\x8d\";", 8500 format("\"aaaaaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 8501 EXPECT_EQ( 8502 "\"Однажды, в \"\n" 8503 "\"студёную \"\n" 8504 "\"зимнюю \"\n" 8505 "\"пору,\"", 8506 format("\"Однажды, в студёную зимнюю пору,\"", 8507 getLLVMStyleWithColumns(13))); 8508 EXPECT_EQ("\"一 二 三 \"\n" 8509 "\"四 五六 \"\n" 8510 "\"七 八 九 \"\n" 8511 "\"十\"", 8512 format("\"一 二 三 四 五六 七 八 九 十\"", 8513 getLLVMStyleWithColumns(11))); 8514 EXPECT_EQ("\"一\t二 \"\n" 8515 "\"\t三 \"\n" 8516 "\"四 五\t六 \"\n" 8517 "\"\t七 \"\n" 8518 "\"八九十\tqq\"", 8519 format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"", 8520 getLLVMStyleWithColumns(11))); 8521 } 8522 8523 8524 TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) { 8525 EXPECT_EQ("const char *sssss =\n" 8526 " \"一二三四五六七八\\\n" 8527 " 九 十\";", 8528 format("const char *sssss = \"一二三四五六七八\\\n" 8529 " 九 十\";", 8530 getLLVMStyleWithColumns(30))); 8531 } 8532 8533 TEST_F(FormatTest, SplitsUTF8LineComments) { 8534 EXPECT_EQ("// aaaaÄ\xc2\x8d", 8535 format("// aaaaÄ\xc2\x8d", getLLVMStyleWithColumns(10))); 8536 EXPECT_EQ("// Я из лесу\n" 8537 "// вышел; был\n" 8538 "// сильный\n" 8539 "// мороз.", 8540 format("// Я из лесу вышел; был сильный мороз.", 8541 getLLVMStyleWithColumns(13))); 8542 EXPECT_EQ("// 一二三\n" 8543 "// 四五六七\n" 8544 "// 八 九\n" 8545 "// 十", 8546 format("// 一二三 四五六七 八 九 十", getLLVMStyleWithColumns(9))); 8547 } 8548 8549 TEST_F(FormatTest, SplitsUTF8BlockComments) { 8550 EXPECT_EQ("/* Гляжу,\n" 8551 " * поднимается\n" 8552 " * медленно в\n" 8553 " * гору\n" 8554 " * Лошадка,\n" 8555 " * везущая\n" 8556 " * хворосту\n" 8557 " * воз. */", 8558 format("/* Гляжу, поднимается медленно в гору\n" 8559 " * Лошадка, везущая хворосту воз. */", 8560 getLLVMStyleWithColumns(13))); 8561 EXPECT_EQ( 8562 "/* 一二三\n" 8563 " * 四五六七\n" 8564 " * 八 九\n" 8565 " * 十 */", 8566 format("/* 一二三 四五六七 八 九 十 */", getLLVMStyleWithColumns(9))); 8567 EXPECT_EQ("/* \n" 8568 " * \n" 8569 " * - */", 8570 format("/* - */", getLLVMStyleWithColumns(12))); 8571 } 8572 8573 #endif // _MSC_VER 8574 8575 TEST_F(FormatTest, ConstructorInitializerIndentWidth) { 8576 FormatStyle Style = getLLVMStyle(); 8577 8578 Style.ConstructorInitializerIndentWidth = 4; 8579 verifyFormat( 8580 "SomeClass::Constructor()\n" 8581 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8582 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8583 Style); 8584 8585 Style.ConstructorInitializerIndentWidth = 2; 8586 verifyFormat( 8587 "SomeClass::Constructor()\n" 8588 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8589 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8590 Style); 8591 8592 Style.ConstructorInitializerIndentWidth = 0; 8593 verifyFormat( 8594 "SomeClass::Constructor()\n" 8595 ": aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8596 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8597 Style); 8598 8599 Style.BreakConstructorInitializersBeforeComma = true; 8600 Style.ConstructorInitializerIndentWidth = 4; 8601 verifyFormat("SomeClass::Constructor()\n" 8602 " : a(a)\n" 8603 " , b(b)\n" 8604 " , c(c) {}", 8605 Style); 8606 verifyFormat("SomeClass::Constructor()\n" 8607 " : a(a) {}", 8608 Style); 8609 8610 Style.ColumnLimit = 0; 8611 verifyFormat("SomeClass::Constructor()\n" 8612 " : a(a) {}", 8613 Style); 8614 verifyFormat("SomeClass::Constructor()\n" 8615 " : a(a)\n" 8616 " , b(b)\n" 8617 " , c(c) {}", 8618 Style); 8619 verifyFormat("SomeClass::Constructor()\n" 8620 " : a(a) {\n" 8621 " foo();\n" 8622 " bar();\n" 8623 "}", 8624 Style); 8625 8626 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 8627 verifyFormat("SomeClass::Constructor()\n" 8628 " : a(a)\n" 8629 " , b(b)\n" 8630 " , c(c) {\n}", 8631 Style); 8632 verifyFormat("SomeClass::Constructor()\n" 8633 " : a(a) {\n}", 8634 Style); 8635 8636 Style.ColumnLimit = 80; 8637 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; 8638 Style.ConstructorInitializerIndentWidth = 2; 8639 verifyFormat("SomeClass::Constructor()\n" 8640 " : a(a)\n" 8641 " , b(b)\n" 8642 " , c(c) {}", 8643 Style); 8644 8645 Style.ConstructorInitializerIndentWidth = 0; 8646 verifyFormat("SomeClass::Constructor()\n" 8647 ": a(a)\n" 8648 ", b(b)\n" 8649 ", c(c) {}", 8650 Style); 8651 8652 Style.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 8653 Style.ConstructorInitializerIndentWidth = 4; 8654 verifyFormat("SomeClass::Constructor() : aaaaaaaa(aaaaaaaa) {}", Style); 8655 verifyFormat( 8656 "SomeClass::Constructor() : aaaaa(aaaaa), aaaaa(aaaaa), aaaaa(aaaaa)\n", 8657 Style); 8658 verifyFormat( 8659 "SomeClass::Constructor()\n" 8660 " : aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa) {}", 8661 Style); 8662 Style.ConstructorInitializerIndentWidth = 4; 8663 Style.ColumnLimit = 60; 8664 verifyFormat("SomeClass::Constructor()\n" 8665 " : aaaaaaaa(aaaaaaaa)\n" 8666 " , aaaaaaaa(aaaaaaaa)\n" 8667 " , aaaaaaaa(aaaaaaaa) {}", 8668 Style); 8669 } 8670 8671 TEST_F(FormatTest, FormatsWithWebKitStyle) { 8672 FormatStyle Style = getWebKitStyle(); 8673 8674 // Don't indent in outer namespaces. 8675 verifyFormat("namespace outer {\n" 8676 "int i;\n" 8677 "namespace inner {\n" 8678 " int i;\n" 8679 "} // namespace inner\n" 8680 "} // namespace outer\n" 8681 "namespace other_outer {\n" 8682 "int i;\n" 8683 "}", 8684 Style); 8685 8686 // Don't indent case labels. 8687 verifyFormat("switch (variable) {\n" 8688 "case 1:\n" 8689 "case 2:\n" 8690 " doSomething();\n" 8691 " break;\n" 8692 "default:\n" 8693 " ++variable;\n" 8694 "}", 8695 Style); 8696 8697 // Wrap before binary operators. 8698 EXPECT_EQ( 8699 "void f()\n" 8700 "{\n" 8701 " if (aaaaaaaaaaaaaaaa\n" 8702 " && bbbbbbbbbbbbbbbbbbbbbbbb\n" 8703 " && (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 8704 " return;\n" 8705 "}", 8706 format( 8707 "void f() {\n" 8708 "if (aaaaaaaaaaaaaaaa\n" 8709 "&& bbbbbbbbbbbbbbbbbbbbbbbb\n" 8710 "&& (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 8711 "return;\n" 8712 "}", 8713 Style)); 8714 8715 // Allow functions on a single line. 8716 verifyFormat("void f() { return; }", Style); 8717 8718 // Constructor initializers are formatted one per line with the "," on the 8719 // new line. 8720 verifyFormat("Constructor()\n" 8721 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 8722 " , aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaa, // break\n" 8723 " aaaaaaaaaaaaaa)\n" 8724 " , aaaaaaaaaaaaaaaaaaaaaaa()\n" 8725 "{\n" 8726 "}", 8727 Style); 8728 verifyFormat("SomeClass::Constructor()\n" 8729 " : a(a)\n" 8730 "{\n" 8731 "}", 8732 Style); 8733 EXPECT_EQ("SomeClass::Constructor()\n" 8734 " : a(a)\n" 8735 "{\n" 8736 "}", 8737 format("SomeClass::Constructor():a(a){}", Style)); 8738 verifyFormat("SomeClass::Constructor()\n" 8739 " : a(a)\n" 8740 " , b(b)\n" 8741 " , c(c)\n" 8742 "{\n" 8743 "}", Style); 8744 verifyFormat("SomeClass::Constructor()\n" 8745 " : a(a)\n" 8746 "{\n" 8747 " foo();\n" 8748 " bar();\n" 8749 "}", 8750 Style); 8751 8752 // Access specifiers should be aligned left. 8753 verifyFormat("class C {\n" 8754 "public:\n" 8755 " int i;\n" 8756 "};", 8757 Style); 8758 8759 // Do not align comments. 8760 verifyFormat("int a; // Do not\n" 8761 "double b; // align comments.", 8762 Style); 8763 8764 // Accept input's line breaks. 8765 EXPECT_EQ("if (aaaaaaaaaaaaaaa\n" 8766 " || bbbbbbbbbbbbbbb) {\n" 8767 " i++;\n" 8768 "}", 8769 format("if (aaaaaaaaaaaaaaa\n" 8770 "|| bbbbbbbbbbbbbbb) { i++; }", 8771 Style)); 8772 EXPECT_EQ("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) {\n" 8773 " i++;\n" 8774 "}", 8775 format("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) { i++; }", Style)); 8776 8777 // Don't automatically break all macro definitions (llvm.org/PR17842). 8778 verifyFormat("#define aNumber 10", Style); 8779 // However, generally keep the line breaks that the user authored. 8780 EXPECT_EQ("#define aNumber \\\n" 8781 " 10", 8782 format("#define aNumber \\\n" 8783 " 10", 8784 Style)); 8785 8786 // Keep empty and one-element array literals on a single line. 8787 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[]\n" 8788 " copyItems:YES];", 8789 format("NSArray*a=[[NSArray alloc] initWithArray:@[]\n" 8790 "copyItems:YES];", 8791 Style)); 8792 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\" ]\n" 8793 " copyItems:YES];", 8794 format("NSArray*a=[[NSArray alloc]initWithArray:@[ @\"a\" ]\n" 8795 " copyItems:YES];", 8796 Style)); 8797 // FIXME: This does not seem right, there should be more indentation before 8798 // the array literal's entries. Nested blocks have the same problem. 8799 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 8800 " @\"a\",\n" 8801 " @\"a\"\n" 8802 "]\n" 8803 " copyItems:YES];", 8804 format("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 8805 " @\"a\",\n" 8806 " @\"a\"\n" 8807 " ]\n" 8808 " copyItems:YES];", 8809 Style)); 8810 EXPECT_EQ( 8811 "NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 8812 " copyItems:YES];", 8813 format("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 8814 " copyItems:YES];", 8815 Style)); 8816 8817 verifyFormat("[self.a b:c c:d];", Style); 8818 EXPECT_EQ("[self.a b:c\n" 8819 " c:d];", 8820 format("[self.a b:c\n" 8821 "c:d];", 8822 Style)); 8823 } 8824 8825 TEST_F(FormatTest, FormatsLambdas) { 8826 verifyFormat("int c = [b]() mutable { return [&b] { return b++; }(); }();\n"); 8827 verifyFormat("int c = [&] { [=] { return b++; }(); }();\n"); 8828 verifyFormat("int c = [&, &a, a] { [=, c, &d] { return b++; }(); }();\n"); 8829 verifyFormat("int c = [&a, &a, a] { [=, a, b, &c] { return b++; }(); }();\n"); 8830 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] { return b++; }(); }}\n"); 8831 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] {}(); }}\n"); 8832 verifyFormat("void f() {\n" 8833 " other(x.begin(), x.end(), [&](int, int) { return 1; });\n" 8834 "}\n"); 8835 verifyFormat("void f() {\n" 8836 " other(x.begin(), //\n" 8837 " x.end(), //\n" 8838 " [&](int, int) { return 1; });\n" 8839 "}\n"); 8840 verifyFormat("SomeFunction([]() { // A cool function...\n" 8841 " return 43;\n" 8842 "});"); 8843 verifyFormat("void f() {\n" 8844 " SomeFunction([](decltype(x), A *a) {});\n" 8845 "}"); 8846 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 8847 " [](const aaaaaaaaaa &a) { return a; });"); 8848 verifyFormat("string abc = SomeFunction(aaaaaaaaaaaaa, aaaaa, []() {\n" 8849 " SomeOtherFunctioooooooooooooooooooooooooon();\n" 8850 "});"); 8851 8852 // Lambdas with return types. 8853 verifyFormat("int c = []() -> int { return 2; }();\n"); 8854 verifyFormat("int c = []() -> vector<int> { return {2}; }();\n"); 8855 verifyFormat("Foo([]() -> std::vector<int> { return {2}; }());"); 8856 verifyFormat("auto aaaaaaaa = [](int i, // break for some reason\n" 8857 " int j) -> int {\n" 8858 " return ffffffffffffffffffffffffffffffffffffffffffff(i * j);\n" 8859 "};"); 8860 8861 // Multiple lambdas in the same parentheses change indentation rules. 8862 verifyFormat("SomeFunction([]() {\n" 8863 " int i = 42;\n" 8864 " return i;\n" 8865 " },\n" 8866 " []() {\n" 8867 " int j = 43;\n" 8868 " return j;\n" 8869 " });"); 8870 8871 // More complex introducers. 8872 verifyFormat("return [i, args...] {};"); 8873 8874 // Not lambdas. 8875 verifyFormat("constexpr char hello[]{\"hello\"};"); 8876 verifyFormat("double &operator[](int i) { return 0; }\n" 8877 "int i;"); 8878 verifyFormat("std::unique_ptr<int[]> foo() {}"); 8879 verifyFormat("int i = a[a][a]->f();"); 8880 verifyFormat("int i = (*b)[a]->f();"); 8881 8882 // Other corner cases. 8883 verifyFormat("void f() {\n" 8884 " bar([]() {} // Did not respect SpacesBeforeTrailingComments\n" 8885 " );\n" 8886 "}"); 8887 8888 // Lambdas created through weird macros. 8889 verifyFormat("void f() {\n" 8890 " MACRO((const AA &a) { return 1; });\n" 8891 "}"); 8892 } 8893 8894 TEST_F(FormatTest, FormatsBlocks) { 8895 verifyFormat("int (^Block)(int, int);"); 8896 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)"); 8897 verifyFormat("void (^block)(int) = ^(id test) { int i; };"); 8898 verifyFormat("void (^block)(int) = ^(int test) { int i; };"); 8899 verifyFormat("void (^block)(int) = ^id(int test) { int i; };"); 8900 verifyFormat("void (^block)(int) = ^int(int test) { int i; };"); 8901 8902 verifyFormat("foo(^{ bar(); });"); 8903 verifyFormat("foo(a, ^{ bar(); });"); 8904 8905 // FIXME: Make whitespace formatting consistent. Ask a ObjC dev how 8906 // it would ideally look. 8907 verifyFormat("[operation setCompletionBlock:^{ [self onOperationDone]; }];"); 8908 verifyFormat("int i = {[operation setCompletionBlock : ^{ [self " 8909 "onOperationDone]; }]};"); 8910 verifyFormat("[operation setCompletionBlock:^(int *i) { f(); }];"); 8911 verifyFormat("int a = [operation block:^int(int *i) { return 1; }];"); 8912 verifyFormat("[myObject doSomethingWith:arg1\n" 8913 " aaa:^int(int *a) { return 1; }\n" 8914 " bbb:f(a * bbbbbbbb)];"); 8915 8916 verifyFormat("[operation setCompletionBlock:^{\n" 8917 " [self.delegate newDataAvailable];\n" 8918 "}];", 8919 getLLVMStyleWithColumns(60)); 8920 verifyFormat("dispatch_async(_fileIOQueue, ^{\n" 8921 " NSString *path = [self sessionFilePath];\n" 8922 " if (path) {\n" 8923 " // ...\n" 8924 " }\n" 8925 "});"); 8926 verifyFormat("[[SessionService sharedService]\n" 8927 " loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" 8928 " if (window) {\n" 8929 " [self windowDidLoad:window];\n" 8930 " } else {\n" 8931 " [self errorLoadingWindow];\n" 8932 " }\n" 8933 " }];"); 8934 verifyFormat("void (^largeBlock)(void) = ^{\n" 8935 " // ...\n" 8936 "};\n", 8937 getLLVMStyleWithColumns(40)); 8938 verifyFormat("[[SessionService sharedService]\n" 8939 " loadWindowWithCompletionBlock: //\n" 8940 " ^(SessionWindow *window) {\n" 8941 " if (window) {\n" 8942 " [self windowDidLoad:window];\n" 8943 " } else {\n" 8944 " [self errorLoadingWindow];\n" 8945 " }\n" 8946 " }];", 8947 getLLVMStyleWithColumns(60)); 8948 verifyFormat("[myObject doSomethingWith:arg1\n" 8949 " firstBlock:^(Foo *a) {\n" 8950 " // ...\n" 8951 " int i;\n" 8952 " }\n" 8953 " secondBlock:^(Bar *b) {\n" 8954 " // ...\n" 8955 " int i;\n" 8956 " }\n" 8957 " thirdBlock:^Foo(Bar *b) {\n" 8958 " // ...\n" 8959 " int i;\n" 8960 " }];"); 8961 verifyFormat("[myObject doSomethingWith:arg1\n" 8962 " firstBlock:-1\n" 8963 " secondBlock:^(Bar *b) {\n" 8964 " // ...\n" 8965 " int i;\n" 8966 " }];"); 8967 8968 verifyFormat("f(^{\n" 8969 " @autoreleasepool {\n" 8970 " if (a) {\n" 8971 " g();\n" 8972 " }\n" 8973 " }\n" 8974 "});"); 8975 } 8976 8977 TEST_F(FormatTest, SupportsCRLF) { 8978 EXPECT_EQ("int a;\r\n" 8979 "int b;\r\n" 8980 "int c;\r\n", 8981 format("int a;\r\n" 8982 " int b;\r\n" 8983 " int c;\r\n", 8984 getLLVMStyle())); 8985 EXPECT_EQ("int a;\r\n" 8986 "int b;\r\n" 8987 "int c;\r\n", 8988 format("int a;\r\n" 8989 " int b;\n" 8990 " int c;\r\n", 8991 getLLVMStyle())); 8992 EXPECT_EQ("int a;\n" 8993 "int b;\n" 8994 "int c;\n", 8995 format("int a;\r\n" 8996 " int b;\n" 8997 " int c;\n", 8998 getLLVMStyle())); 8999 EXPECT_EQ("\"aaaaaaa \"\r\n" 9000 "\"bbbbbbb\";\r\n", 9001 format("\"aaaaaaa bbbbbbb\";\r\n", getLLVMStyleWithColumns(10))); 9002 EXPECT_EQ("#define A \\\r\n" 9003 " b; \\\r\n" 9004 " c; \\\r\n" 9005 " d;\r\n", 9006 format("#define A \\\r\n" 9007 " b; \\\r\n" 9008 " c; d; \r\n", 9009 getGoogleStyle())); 9010 9011 EXPECT_EQ("/*\r\n" 9012 "multi line block comments\r\n" 9013 "should not introduce\r\n" 9014 "an extra carriage return\r\n" 9015 "*/\r\n", 9016 format("/*\r\n" 9017 "multi line block comments\r\n" 9018 "should not introduce\r\n" 9019 "an extra carriage return\r\n" 9020 "*/\r\n")); 9021 } 9022 9023 TEST_F(FormatTest, MunchSemicolonAfterBlocks) { 9024 verifyFormat("MY_CLASS(C) {\n" 9025 " int i;\n" 9026 " int j;\n" 9027 "};"); 9028 } 9029 9030 TEST_F(FormatTest, ConfigurableContinuationIndentWidth) { 9031 FormatStyle TwoIndent = getLLVMStyleWithColumns(15); 9032 TwoIndent.ContinuationIndentWidth = 2; 9033 9034 EXPECT_EQ("int i =\n" 9035 " longFunction(\n" 9036 " arg);", 9037 format("int i = longFunction(arg);", TwoIndent)); 9038 9039 FormatStyle SixIndent = getLLVMStyleWithColumns(20); 9040 SixIndent.ContinuationIndentWidth = 6; 9041 9042 EXPECT_EQ("int i =\n" 9043 " longFunction(\n" 9044 " arg);", 9045 format("int i = longFunction(arg);", SixIndent)); 9046 } 9047 9048 TEST_F(FormatTest, SpacesInAngles) { 9049 FormatStyle Spaces = getLLVMStyle(); 9050 Spaces.SpacesInAngles = true; 9051 9052 verifyFormat("static_cast< int >(arg);", Spaces); 9053 verifyFormat("template < typename T0, typename T1 > void f() {}", Spaces); 9054 verifyFormat("f< int, float >();", Spaces); 9055 verifyFormat("template <> g() {}", Spaces); 9056 verifyFormat("template < std::vector< int > > f() {}", Spaces); 9057 9058 Spaces.Standard = FormatStyle::LS_Cpp03; 9059 Spaces.SpacesInAngles = true; 9060 verifyFormat("A< A< int > >();", Spaces); 9061 9062 Spaces.SpacesInAngles = false; 9063 verifyFormat("A<A<int> >();", Spaces); 9064 9065 Spaces.Standard = FormatStyle::LS_Cpp11; 9066 Spaces.SpacesInAngles = true; 9067 verifyFormat("A< A< int > >();", Spaces); 9068 9069 Spaces.SpacesInAngles = false; 9070 verifyFormat("A<A<int>>();", Spaces); 9071 } 9072 9073 TEST_F(FormatTest, HandleUnbalancedImplicitBracesAcrossPPBranches) { 9074 std::string code = "#if A\n" 9075 "#if B\n" 9076 "a.\n" 9077 "#endif\n" 9078 " a = 1;\n" 9079 "#else\n" 9080 "#endif\n" 9081 "#if C\n" 9082 "#else\n" 9083 "#endif\n"; 9084 EXPECT_EQ(code, format(code)); 9085 } 9086 9087 TEST_F(FormatTest, HandleConflictMarkers) { 9088 // Git/SVN conflict markers. 9089 EXPECT_EQ("int a;\n" 9090 "void f() {\n" 9091 " callme(some(parameter1,\n" 9092 "<<<<<<< text by the vcs\n" 9093 " parameter2),\n" 9094 "||||||| text by the vcs\n" 9095 " parameter2),\n" 9096 " parameter3,\n" 9097 "======= text by the vcs\n" 9098 " parameter2, parameter3),\n" 9099 ">>>>>>> text by the vcs\n" 9100 " otherparameter);\n", 9101 format("int a;\n" 9102 "void f() {\n" 9103 " callme(some(parameter1,\n" 9104 "<<<<<<< text by the vcs\n" 9105 " parameter2),\n" 9106 "||||||| text by the vcs\n" 9107 " parameter2),\n" 9108 " parameter3,\n" 9109 "======= text by the vcs\n" 9110 " parameter2,\n" 9111 " parameter3),\n" 9112 ">>>>>>> text by the vcs\n" 9113 " otherparameter);\n")); 9114 9115 // Perforce markers. 9116 EXPECT_EQ("void f() {\n" 9117 " function(\n" 9118 ">>>> text by the vcs\n" 9119 " parameter,\n" 9120 "==== text by the vcs\n" 9121 " parameter,\n" 9122 "==== text by the vcs\n" 9123 " parameter,\n" 9124 "<<<< text by the vcs\n" 9125 " parameter);\n", 9126 format("void f() {\n" 9127 " function(\n" 9128 ">>>> text by the vcs\n" 9129 " parameter,\n" 9130 "==== text by the vcs\n" 9131 " parameter,\n" 9132 "==== text by the vcs\n" 9133 " parameter,\n" 9134 "<<<< text by the vcs\n" 9135 " parameter);\n")); 9136 9137 EXPECT_EQ("<<<<<<<\n" 9138 "|||||||\n" 9139 "=======\n" 9140 ">>>>>>>", 9141 format("<<<<<<<\n" 9142 "|||||||\n" 9143 "=======\n" 9144 ">>>>>>>")); 9145 9146 EXPECT_EQ("<<<<<<<\n" 9147 "|||||||\n" 9148 "int i;\n" 9149 "=======\n" 9150 ">>>>>>>", 9151 format("<<<<<<<\n" 9152 "|||||||\n" 9153 "int i;\n" 9154 "=======\n" 9155 ">>>>>>>")); 9156 9157 // FIXME: Handle parsing of macros around conflict markers correctly: 9158 EXPECT_EQ("#define Macro \\\n" 9159 "<<<<<<<\n" 9160 "Something \\\n" 9161 "|||||||\n" 9162 "Else \\\n" 9163 "=======\n" 9164 "Other \\\n" 9165 ">>>>>>>\n" 9166 " End int i;\n", 9167 format("#define Macro \\\n" 9168 "<<<<<<<\n" 9169 " Something \\\n" 9170 "|||||||\n" 9171 " Else \\\n" 9172 "=======\n" 9173 " Other \\\n" 9174 ">>>>>>>\n" 9175 " End\n" 9176 "int i;\n")); 9177 } 9178 9179 TEST_F(FormatTest, DisableRegions) { 9180 EXPECT_EQ("int i;\n" 9181 "// clang-format off\n" 9182 " int j;\n" 9183 "// clang-format on\n" 9184 "int k;", 9185 format(" int i;\n" 9186 " // clang-format off\n" 9187 " int j;\n" 9188 " // clang-format on\n" 9189 " int k;")); 9190 } 9191 9192 } // end namespace tooling 9193 } // end namespace clang 9194