1*89a1d03eSRichard // RUN: %check_clang_tidy %s bugprone-integer-division %t
2*89a1d03eSRichard
3*89a1d03eSRichard // Functions expecting a floating-point parameter.
floatArg(float x)4*89a1d03eSRichard void floatArg(float x) {}
doubleArg(double x)5*89a1d03eSRichard void doubleArg(double x) {}
longDoubleArg(long double x)6*89a1d03eSRichard void longDoubleArg(long double x) {}
7*89a1d03eSRichard
8*89a1d03eSRichard // Functions expected to return a floating-point value.
singleDiv()9*89a1d03eSRichard float singleDiv() {
10*89a1d03eSRichard int x = -5;
11*89a1d03eSRichard int y = 2;
12*89a1d03eSRichard return x/y;
13*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: result of integer division used in
14*89a1d03eSRichard }
15*89a1d03eSRichard
wrongOrder(int x,int y)16*89a1d03eSRichard double wrongOrder(int x, int y) {
17*89a1d03eSRichard return x/y/0.1;
18*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: result of integer division used in
19*89a1d03eSRichard }
20*89a1d03eSRichard
rightOrder(int x,int y)21*89a1d03eSRichard long double rightOrder(int x, int y) {
22*89a1d03eSRichard return 0.1/x/y; // OK
23*89a1d03eSRichard }
24*89a1d03eSRichard
25*89a1d03eSRichard // Typical mathematical functions.
26*89a1d03eSRichard float sin(float);
27*89a1d03eSRichard double acos(double);
28*89a1d03eSRichard long double tanh(long double);
29*89a1d03eSRichard
30*89a1d03eSRichard namespace std {
31*89a1d03eSRichard using ::sin;
32*89a1d03eSRichard }
33*89a1d03eSRichard
34*89a1d03eSRichard template <typename T>
intDivSin(T x)35*89a1d03eSRichard void intDivSin(T x) {
36*89a1d03eSRichard sin(x);
37*89a1d03eSRichard }
38*89a1d03eSRichard
39*89a1d03eSRichard int intFunc(int);
40*89a1d03eSRichard
41*89a1d03eSRichard struct X {
42*89a1d03eSRichard int n;
mX43*89a1d03eSRichard void m() {
44*89a1d03eSRichard sin(n / 3);
45*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: result of integer division used in
46*89a1d03eSRichard }
47*89a1d03eSRichard };
48*89a1d03eSRichard
integerDivision()49*89a1d03eSRichard void integerDivision() {
50*89a1d03eSRichard char a = 2;
51*89a1d03eSRichard short b = -5;
52*89a1d03eSRichard int c = 9784;
53*89a1d03eSRichard enum third { x, y, z=2 };
54*89a1d03eSRichard third d = z;
55*89a1d03eSRichard char e[] = {'a', 'b', 'c'};
56*89a1d03eSRichard char f = *(e + 1 / a);
57*89a1d03eSRichard bool g = 1;
58*89a1d03eSRichard
59*89a1d03eSRichard sin(1 + c / (2 + 2));
60*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: result of integer division used in
61*89a1d03eSRichard sin(c / (1 + .5));
62*89a1d03eSRichard sin((c + .5) / 3);
63*89a1d03eSRichard
64*89a1d03eSRichard sin(intFunc(3) / 5);
65*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of integer division used in
66*89a1d03eSRichard acos(2 / intFunc(7));
67*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: result of integer division used in
68*89a1d03eSRichard
69*89a1d03eSRichard floatArg(1 + 2 / 3);
70*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: result of integer division used in
71*89a1d03eSRichard sin(1 + 2 / 3);
72*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: result of integer division used in
73*89a1d03eSRichard intFunc(sin(1 + 2 / 3));
74*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: result of integer division used in
75*89a1d03eSRichard
76*89a1d03eSRichard floatArg(1 + intFunc(1 + 2 / 3));
77*89a1d03eSRichard floatArg(1 + 3 * intFunc(a / b));
78*89a1d03eSRichard
79*89a1d03eSRichard 1 << (2 / 3);
80*89a1d03eSRichard 1 << intFunc(2 / 3);
81*89a1d03eSRichard
82*89a1d03eSRichard #define M_SIN sin(a / b);
83*89a1d03eSRichard M_SIN
84*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: result of integer division used in
85*89a1d03eSRichard
86*89a1d03eSRichard intDivSin<float>(a / b);
87*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: result of integer division used in
88*89a1d03eSRichard intDivSin<double>(c / d);
89*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: result of integer division used in
90*89a1d03eSRichard intDivSin<long double>(f / g);
91*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: result of integer division used in
92*89a1d03eSRichard
93*89a1d03eSRichard floatArg(1 / 3);
94*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: result of integer division used in
95*89a1d03eSRichard doubleArg(a / b);
96*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: result of integer division used in
97*89a1d03eSRichard longDoubleArg(3 / d);
98*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: result of integer division used in
99*89a1d03eSRichard floatArg(a / b / 0.1);
100*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: result of integer division used in
101*89a1d03eSRichard doubleArg(1 / 3 / 0.1);
102*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: result of integer division used in
103*89a1d03eSRichard longDoubleArg(2 / 3 / 5);
104*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: result of integer division used in
105*89a1d03eSRichard
106*89a1d03eSRichard std::sin(2 / 3);
107*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: result of integer division used in
108*89a1d03eSRichard ::acos(7 / d);
109*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: result of integer division used in
110*89a1d03eSRichard tanh(f / g);
111*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: result of integer division used in
112*89a1d03eSRichard
113*89a1d03eSRichard floatArg(0.1 / a / b);
114*89a1d03eSRichard doubleArg(0.1 / 3 / 1);
115*89a1d03eSRichard
116*89a1d03eSRichard singleDiv();
117*89a1d03eSRichard wrongOrder(a,b);
118*89a1d03eSRichard rightOrder(a,b);
119*89a1d03eSRichard
120*89a1d03eSRichard sin(a / b);
121*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of integer division used in
122*89a1d03eSRichard acos(f / d);
123*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: result of integer division used in
124*89a1d03eSRichard tanh(c / g);
125*89a1d03eSRichard // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: result of integer division used in
126*89a1d03eSRichard
127*89a1d03eSRichard sin(3.0 / a);
128*89a1d03eSRichard acos(b / 3.14);
129*89a1d03eSRichard tanh(3.14 / f / g);
130*89a1d03eSRichard }
131