xref: /llvm-project/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.cpp (revision cbdc3e1bf9da09911ba353bcd20c6709bda43893)
1a35efc4dSserge-sans-paille //===--- MisleadingIdentifier.cpp - clang-tidy-----------------------------===//
2a35efc4dSserge-sans-paille //
3a35efc4dSserge-sans-paille // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4a35efc4dSserge-sans-paille // See https://llvm.org/LICENSE.txt for license information.
5a35efc4dSserge-sans-paille // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6a35efc4dSserge-sans-paille //
7a35efc4dSserge-sans-paille //===----------------------------------------------------------------------===//
8a35efc4dSserge-sans-paille 
9a35efc4dSserge-sans-paille #include "MisleadingIdentifier.h"
10a35efc4dSserge-sans-paille 
11a35efc4dSserge-sans-paille #include "clang/Frontend/CompilerInstance.h"
12a35efc4dSserge-sans-paille #include "llvm/Support/ConvertUTF.h"
13a35efc4dSserge-sans-paille 
147d2ea6c4SCarlos Galvez namespace clang::tidy::misc {
15a35efc4dSserge-sans-paille 
16a35efc4dSserge-sans-paille // See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
isUnassignedAL(llvm::UTF32 CP)17a35efc4dSserge-sans-paille static bool isUnassignedAL(llvm::UTF32 CP) {
18a35efc4dSserge-sans-paille   return (0x0600 <= CP && CP <= 0x07BF) || (0x0860 <= CP && CP <= 0x08FF) ||
19a35efc4dSserge-sans-paille          (0xFB50 <= CP && CP <= 0xFDCF) || (0xFDF0 <= CP && CP <= 0xFDFF) ||
20a35efc4dSserge-sans-paille          (0xFE70 <= CP && CP <= 0xFEFF) ||
21a35efc4dSserge-sans-paille          (0x00010D00 <= CP && CP <= 0x00010D3F) ||
22a35efc4dSserge-sans-paille          (0x00010F30 <= CP && CP <= 0x00010F6F) ||
23a35efc4dSserge-sans-paille          (0x0001EC70 <= CP && CP <= 0x0001ECBF) ||
24a35efc4dSserge-sans-paille          (0x0001ED00 <= CP && CP <= 0x0001ED4F) ||
25a35efc4dSserge-sans-paille          (0x0001EE00 <= CP && CP <= 0x0001EEFF);
26a35efc4dSserge-sans-paille }
27a35efc4dSserge-sans-paille 
28a35efc4dSserge-sans-paille // See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
isUnassignedR(llvm::UTF32 CP)29a35efc4dSserge-sans-paille static bool isUnassignedR(llvm::UTF32 CP) {
30a35efc4dSserge-sans-paille   return (0x0590 <= CP && CP <= 0x05FF) || (0x07C0 <= CP && CP <= 0x085F) ||
31a35efc4dSserge-sans-paille          (0xFB1D <= CP && CP <= 0xFB4F) ||
32a35efc4dSserge-sans-paille          (0x00010800 <= CP && CP <= 0x00010CFF) ||
33a35efc4dSserge-sans-paille          (0x00010D40 <= CP && CP <= 0x00010F2F) ||
34a35efc4dSserge-sans-paille          (0x00010F70 <= CP && CP <= 0x00010FFF) ||
35a35efc4dSserge-sans-paille          (0x0001E800 <= CP && CP <= 0x0001EC6F) ||
36a35efc4dSserge-sans-paille          (0x0001ECC0 <= CP && CP <= 0x0001ECFF) ||
37a35efc4dSserge-sans-paille          (0x0001ED50 <= CP && CP <= 0x0001EDFF) ||
38a35efc4dSserge-sans-paille          (0x0001EF00 <= CP && CP <= 0x0001EFFF);
39a35efc4dSserge-sans-paille }
40a35efc4dSserge-sans-paille 
41a35efc4dSserge-sans-paille // See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
isR(llvm::UTF32 CP)42a35efc4dSserge-sans-paille static bool isR(llvm::UTF32 CP) {
43a35efc4dSserge-sans-paille   return (CP == 0x0590) || (CP == 0x05BE) || (CP == 0x05C0) || (CP == 0x05C3) ||
44a35efc4dSserge-sans-paille          (CP == 0x05C6) || (0x05C8 <= CP && CP <= 0x05CF) ||
45a35efc4dSserge-sans-paille          (0x05D0 <= CP && CP <= 0x05EA) || (0x05EB <= CP && CP <= 0x05EE) ||
46a35efc4dSserge-sans-paille          (0x05EF <= CP && CP <= 0x05F2) || (0x05F3 <= CP && CP <= 0x05F4) ||
47a35efc4dSserge-sans-paille          (0x05F5 <= CP && CP <= 0x05FF) || (0x07C0 <= CP && CP <= 0x07C9) ||
48a35efc4dSserge-sans-paille          (0x07CA <= CP && CP <= 0x07EA) || (0x07F4 <= CP && CP <= 0x07F5) ||
49a35efc4dSserge-sans-paille          (CP == 0x07FA) || (0x07FB <= CP && CP <= 0x07FC) ||
50a35efc4dSserge-sans-paille          (0x07FE <= CP && CP <= 0x07FF) || (0x0800 <= CP && CP <= 0x0815) ||
51a35efc4dSserge-sans-paille          (CP == 0x081A) || (CP == 0x0824) || (CP == 0x0828) ||
52a35efc4dSserge-sans-paille          (0x082E <= CP && CP <= 0x082F) || (0x0830 <= CP && CP <= 0x083E) ||
53a35efc4dSserge-sans-paille          (CP == 0x083F) || (0x0840 <= CP && CP <= 0x0858) ||
54a35efc4dSserge-sans-paille          (0x085C <= CP && CP <= 0x085D) || (CP == 0x085E) || (CP == 0x085F) ||
55a35efc4dSserge-sans-paille          (CP == 0x200F) || (CP == 0xFB1D) || (0xFB1F <= CP && CP <= 0xFB28) ||
56a35efc4dSserge-sans-paille          (0xFB2A <= CP && CP <= 0xFB36) || (CP == 0xFB37) ||
57a35efc4dSserge-sans-paille          (0xFB38 <= CP && CP <= 0xFB3C) || (CP == 0xFB3D) || (CP == 0xFB3E) ||
58a35efc4dSserge-sans-paille          (CP == 0xFB3F) || (0xFB40 <= CP && CP <= 0xFB41) || (CP == 0xFB42) ||
59a35efc4dSserge-sans-paille          (0xFB43 <= CP && CP <= 0xFB44) || (CP == 0xFB45) ||
60a35efc4dSserge-sans-paille          (0xFB46 <= CP && CP <= 0xFB4F) || (0x10800 <= CP && CP <= 0x10805) ||
61a35efc4dSserge-sans-paille          (0x10806 <= CP && CP <= 0x10807) || (CP == 0x10808) ||
62a35efc4dSserge-sans-paille          (CP == 0x10809) || (0x1080A <= CP && CP <= 0x10835) ||
63a35efc4dSserge-sans-paille          (CP == 0x10836) || (0x10837 <= CP && CP <= 0x10838) ||
64a35efc4dSserge-sans-paille          (0x10839 <= CP && CP <= 0x1083B) || (CP == 0x1083C) ||
65a35efc4dSserge-sans-paille          (0x1083D <= CP && CP <= 0x1083E) || (0x1083F <= CP && CP <= 0x10855) ||
66a35efc4dSserge-sans-paille          (CP == 0x10856) || (CP == 0x10857) ||
67a35efc4dSserge-sans-paille          (0x10858 <= CP && CP <= 0x1085F) || (0x10860 <= CP && CP <= 0x10876) ||
68a35efc4dSserge-sans-paille          (0x10877 <= CP && CP <= 0x10878) || (0x10879 <= CP && CP <= 0x1087F) ||
69a35efc4dSserge-sans-paille          (0x10880 <= CP && CP <= 0x1089E) || (0x1089F <= CP && CP <= 0x108A6) ||
70a35efc4dSserge-sans-paille          (0x108A7 <= CP && CP <= 0x108AF) || (0x108B0 <= CP && CP <= 0x108DF) ||
71a35efc4dSserge-sans-paille          (0x108E0 <= CP && CP <= 0x108F2) || (CP == 0x108F3) ||
72a35efc4dSserge-sans-paille          (0x108F4 <= CP && CP <= 0x108F5) || (0x108F6 <= CP && CP <= 0x108FA) ||
73a35efc4dSserge-sans-paille          (0x108FB <= CP && CP <= 0x108FF) || (0x10900 <= CP && CP <= 0x10915) ||
74a35efc4dSserge-sans-paille          (0x10916 <= CP && CP <= 0x1091B) || (0x1091C <= CP && CP <= 0x1091E) ||
75a35efc4dSserge-sans-paille          (0x10920 <= CP && CP <= 0x10939) || (0x1093A <= CP && CP <= 0x1093E) ||
76a35efc4dSserge-sans-paille          (CP == 0x1093F) || (0x10940 <= CP && CP <= 0x1097F) ||
77a35efc4dSserge-sans-paille          (0x10980 <= CP && CP <= 0x109B7) || (0x109B8 <= CP && CP <= 0x109BB) ||
78a35efc4dSserge-sans-paille          (0x109BC <= CP && CP <= 0x109BD) || (0x109BE <= CP && CP <= 0x109BF) ||
79a35efc4dSserge-sans-paille          (0x109C0 <= CP && CP <= 0x109CF) || (0x109D0 <= CP && CP <= 0x109D1) ||
80a35efc4dSserge-sans-paille          (0x109D2 <= CP && CP <= 0x109FF) || (CP == 0x10A00) ||
81a35efc4dSserge-sans-paille          (CP == 0x10A04) || (0x10A07 <= CP && CP <= 0x10A0B) ||
82a35efc4dSserge-sans-paille          (0x10A10 <= CP && CP <= 0x10A13) || (CP == 0x10A14) ||
83a35efc4dSserge-sans-paille          (0x10A15 <= CP && CP <= 0x10A17) || (CP == 0x10A18) ||
84a35efc4dSserge-sans-paille          (0x10A19 <= CP && CP <= 0x10A35) || (0x10A36 <= CP && CP <= 0x10A37) ||
85a35efc4dSserge-sans-paille          (0x10A3B <= CP && CP <= 0x10A3E) || (0x10A40 <= CP && CP <= 0x10A48) ||
86a35efc4dSserge-sans-paille          (0x10A49 <= CP && CP <= 0x10A4F) || (0x10A50 <= CP && CP <= 0x10A58) ||
87a35efc4dSserge-sans-paille          (0x10A59 <= CP && CP <= 0x10A5F) || (0x10A60 <= CP && CP <= 0x10A7C) ||
88a35efc4dSserge-sans-paille          (0x10A7D <= CP && CP <= 0x10A7E) || (CP == 0x10A7F) ||
89a35efc4dSserge-sans-paille          (0x10A80 <= CP && CP <= 0x10A9C) || (0x10A9D <= CP && CP <= 0x10A9F) ||
90a35efc4dSserge-sans-paille          (0x10AA0 <= CP && CP <= 0x10ABF) || (0x10AC0 <= CP && CP <= 0x10AC7) ||
91a35efc4dSserge-sans-paille          (CP == 0x10AC8) || (0x10AC9 <= CP && CP <= 0x10AE4) ||
92a35efc4dSserge-sans-paille          (0x10AE7 <= CP && CP <= 0x10AEA) || (0x10AEB <= CP && CP <= 0x10AEF) ||
93a35efc4dSserge-sans-paille          (0x10AF0 <= CP && CP <= 0x10AF6) || (0x10AF7 <= CP && CP <= 0x10AFF) ||
94a35efc4dSserge-sans-paille          (0x10B00 <= CP && CP <= 0x10B35) || (0x10B36 <= CP && CP <= 0x10B38) ||
95a35efc4dSserge-sans-paille          (0x10B40 <= CP && CP <= 0x10B55) || (0x10B56 <= CP && CP <= 0x10B57) ||
96a35efc4dSserge-sans-paille          (0x10B58 <= CP && CP <= 0x10B5F) || (0x10B60 <= CP && CP <= 0x10B72) ||
97a35efc4dSserge-sans-paille          (0x10B73 <= CP && CP <= 0x10B77) || (0x10B78 <= CP && CP <= 0x10B7F) ||
98a35efc4dSserge-sans-paille          (0x10B80 <= CP && CP <= 0x10B91) || (0x10B92 <= CP && CP <= 0x10B98) ||
99a35efc4dSserge-sans-paille          (0x10B99 <= CP && CP <= 0x10B9C) || (0x10B9D <= CP && CP <= 0x10BA8) ||
100a35efc4dSserge-sans-paille          (0x10BA9 <= CP && CP <= 0x10BAF) || (0x10BB0 <= CP && CP <= 0x10BFF) ||
101a35efc4dSserge-sans-paille          (0x10C00 <= CP && CP <= 0x10C48) || (0x10C49 <= CP && CP <= 0x10C7F) ||
102a35efc4dSserge-sans-paille          (0x10C80 <= CP && CP <= 0x10CB2) || (0x10CB3 <= CP && CP <= 0x10CBF) ||
103a35efc4dSserge-sans-paille          (0x10CC0 <= CP && CP <= 0x10CF2) || (0x10CF3 <= CP && CP <= 0x10CF9) ||
104a35efc4dSserge-sans-paille          (0x10CFA <= CP && CP <= 0x10CFF) || (0x10D40 <= CP && CP <= 0x10E5F) ||
105a35efc4dSserge-sans-paille          (CP == 0x10E7F) || (0x10E80 <= CP && CP <= 0x10EA9) ||
106a35efc4dSserge-sans-paille          (CP == 0x10EAA) || (CP == 0x10EAD) ||
107a35efc4dSserge-sans-paille          (0x10EAE <= CP && CP <= 0x10EAF) || (0x10EB0 <= CP && CP <= 0x10EB1) ||
108a35efc4dSserge-sans-paille          (0x10EB2 <= CP && CP <= 0x10EFF) || (0x10F00 <= CP && CP <= 0x10F1C) ||
109a35efc4dSserge-sans-paille          (0x10F1D <= CP && CP <= 0x10F26) || (CP == 0x10F27) ||
110a35efc4dSserge-sans-paille          (0x10F28 <= CP && CP <= 0x10F2F) || (0x10F70 <= CP && CP <= 0x10F81) ||
111a35efc4dSserge-sans-paille          (0x10F86 <= CP && CP <= 0x10F89) || (0x10F8A <= CP && CP <= 0x10FAF) ||
112a35efc4dSserge-sans-paille          (0x10FB0 <= CP && CP <= 0x10FC4) || (0x10FC5 <= CP && CP <= 0x10FCB) ||
113a35efc4dSserge-sans-paille          (0x10FCC <= CP && CP <= 0x10FDF) || (0x10FE0 <= CP && CP <= 0x10FF6) ||
114a35efc4dSserge-sans-paille          (0x10FF7 <= CP && CP <= 0x10FFF) || (0x1E800 <= CP && CP <= 0x1E8C4) ||
115a35efc4dSserge-sans-paille          (0x1E8C5 <= CP && CP <= 0x1E8C6) || (0x1E8C7 <= CP && CP <= 0x1E8CF) ||
116a35efc4dSserge-sans-paille          (0x1E8D7 <= CP && CP <= 0x1E8FF) || (0x1E900 <= CP && CP <= 0x1E943) ||
117a35efc4dSserge-sans-paille          (CP == 0x1E94B) || (0x1E94C <= CP && CP <= 0x1E94F) ||
118a35efc4dSserge-sans-paille          (0x1E950 <= CP && CP <= 0x1E959) || (0x1E95A <= CP && CP <= 0x1E95D) ||
119a35efc4dSserge-sans-paille          (0x1E95E <= CP && CP <= 0x1E95F) || (0x1E960 <= CP && CP <= 0x1EC6F) ||
120a35efc4dSserge-sans-paille          (0x1ECC0 <= CP && CP <= 0x1ECFF) || (0x1ED50 <= CP && CP <= 0x1EDFF);
121a35efc4dSserge-sans-paille }
122a35efc4dSserge-sans-paille 
hasRTLCharacters(StringRef Buffer)123a35efc4dSserge-sans-paille static bool hasRTLCharacters(StringRef Buffer) {
124a35efc4dSserge-sans-paille   const char *CurPtr = Buffer.begin();
125a35efc4dSserge-sans-paille   const char *EndPtr = Buffer.end();
126a35efc4dSserge-sans-paille   while (CurPtr < EndPtr) {
127*cbdc3e1bSPiotr Zegar     llvm::UTF32 CodePoint = 0;
128a35efc4dSserge-sans-paille     llvm::ConversionResult Result = llvm::convertUTF8Sequence(
129a35efc4dSserge-sans-paille         (const llvm::UTF8 **)&CurPtr, (const llvm::UTF8 *)EndPtr, &CodePoint,
130a35efc4dSserge-sans-paille         llvm::strictConversion);
131a35efc4dSserge-sans-paille     if (Result != llvm::conversionOK)
132a35efc4dSserge-sans-paille       break;
133a35efc4dSserge-sans-paille     if (isUnassignedAL(CodePoint) || isUnassignedR(CodePoint) || isR(CodePoint))
134a35efc4dSserge-sans-paille       return true;
135a35efc4dSserge-sans-paille   }
136a35efc4dSserge-sans-paille   return false;
137a35efc4dSserge-sans-paille }
138a35efc4dSserge-sans-paille 
MisleadingIdentifierCheck(StringRef Name,ClangTidyContext * Context)139a35efc4dSserge-sans-paille MisleadingIdentifierCheck::MisleadingIdentifierCheck(StringRef Name,
140a35efc4dSserge-sans-paille                                                      ClangTidyContext *Context)
141a35efc4dSserge-sans-paille     : ClangTidyCheck(Name, Context) {}
142a35efc4dSserge-sans-paille 
143a35efc4dSserge-sans-paille MisleadingIdentifierCheck::~MisleadingIdentifierCheck() = default;
144a35efc4dSserge-sans-paille 
check(const ast_matchers::MatchFinder::MatchResult & Result)145a35efc4dSserge-sans-paille void MisleadingIdentifierCheck::check(
146a35efc4dSserge-sans-paille     const ast_matchers::MatchFinder::MatchResult &Result) {
147a35efc4dSserge-sans-paille   if (const auto *ND = Result.Nodes.getNodeAs<NamedDecl>("nameddecl")) {
148a35efc4dSserge-sans-paille     IdentifierInfo *II = ND->getIdentifier();
149a35efc4dSserge-sans-paille     if (II) {
150a35efc4dSserge-sans-paille       StringRef NDName = II->getName();
151a35efc4dSserge-sans-paille       if (hasRTLCharacters(NDName))
152a35efc4dSserge-sans-paille         diag(ND->getBeginLoc(), "identifier has right-to-left codepoints");
153a35efc4dSserge-sans-paille     }
154a35efc4dSserge-sans-paille   }
155a35efc4dSserge-sans-paille }
156a35efc4dSserge-sans-paille 
registerMatchers(ast_matchers::MatchFinder * Finder)157a35efc4dSserge-sans-paille void MisleadingIdentifierCheck::registerMatchers(
158a35efc4dSserge-sans-paille     ast_matchers::MatchFinder *Finder) {
159a35efc4dSserge-sans-paille   Finder->addMatcher(ast_matchers::namedDecl().bind("nameddecl"), this);
160a35efc4dSserge-sans-paille }
161a35efc4dSserge-sans-paille 
1627d2ea6c4SCarlos Galvez } // namespace clang::tidy::misc
163