xref: /llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp (revision b06da39cae0f7e2c6b8bc0bb03b734f9715c0bf3)
1552b62edSJonas Toth //===--- MacroUsageCheck.cpp - clang-tidy----------------------------------===//
2552b62edSJonas Toth //
32946cd70SChandler Carruth // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
42946cd70SChandler Carruth // See https://llvm.org/LICENSE.txt for license information.
52946cd70SChandler Carruth // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6552b62edSJonas Toth //
7552b62edSJonas Toth //===----------------------------------------------------------------------===//
8552b62edSJonas Toth 
9552b62edSJonas Toth #include "MacroUsageCheck.h"
10*b06da39cSCongcong Cai #include "clang/Basic/TokenKinds.h"
11552b62edSJonas Toth #include "clang/Frontend/CompilerInstance.h"
12552b62edSJonas Toth #include "clang/Lex/PPCallbacks.h"
13860aefd0SNathan James #include "clang/Lex/Preprocessor.h"
14552b62edSJonas Toth #include "llvm/ADT/STLExtras.h"
15552b62edSJonas Toth #include "llvm/Support/Regex.h"
1674f201c3SJonas Toth #include <cctype>
17d83ecd77SRichard #include <functional>
18552b62edSJonas Toth 
197d2ea6c4SCarlos Galvez namespace clang::tidy::cppcoreguidelines {
20552b62edSJonas Toth 
isCapsOnly(StringRef Name)21d83ecd77SRichard static bool isCapsOnly(StringRef Name) {
22d83ecd77SRichard   return llvm::all_of(Name, [](const char C) {
23d83ecd77SRichard     return std::isupper(C) || std::isdigit(C) || C == '_';
24552b62edSJonas Toth   });
25552b62edSJonas Toth }
26552b62edSJonas Toth 
27d83ecd77SRichard namespace {
28d83ecd77SRichard 
29552b62edSJonas Toth class MacroUsageCallbacks : public PPCallbacks {
30552b62edSJonas Toth public:
MacroUsageCallbacks(MacroUsageCheck * Check,const SourceManager & SM,StringRef RegExpStr,bool CapsOnly,bool IgnoreCommandLine)31c367ba19SRoman Lebedev   MacroUsageCallbacks(MacroUsageCheck *Check, const SourceManager &SM,
32d83ecd77SRichard                       StringRef RegExpStr, bool CapsOnly,
33d83ecd77SRichard                       bool IgnoreCommandLine)
34269ef315Ssmhc       : Check(Check), SM(SM), RegExp(RegExpStr), CheckCapsOnly(CapsOnly),
35c367ba19SRoman Lebedev         IgnoreCommandLineMacros(IgnoreCommandLine) {}
MacroDefined(const Token & MacroNameTok,const MacroDirective * MD)36552b62edSJonas Toth   void MacroDefined(const Token &MacroNameTok,
37552b62edSJonas Toth                     const MacroDirective *MD) override {
384c177038SAlexander Kornienko     if (SM.isWrittenInBuiltinFile(MD->getLocation()) ||
394c177038SAlexander Kornienko         MD->getMacroInfo()->isUsedForHeaderGuard() ||
40*b06da39cSCongcong Cai         MD->getMacroInfo()->tokens_empty() ||
41*b06da39cSCongcong Cai         llvm::any_of(MD->getMacroInfo()->tokens(), [](const Token &T) {
42*b06da39cSCongcong Cai           return T.isOneOf(tok::TokenKind::hash, tok::TokenKind::hashhash);
43*b06da39cSCongcong Cai         }))
44552b62edSJonas Toth       return;
45552b62edSJonas Toth 
46c367ba19SRoman Lebedev     if (IgnoreCommandLineMacros &&
47c367ba19SRoman Lebedev         SM.isWrittenInCommandLineFile(MD->getLocation()))
48c367ba19SRoman Lebedev       return;
49c367ba19SRoman Lebedev 
50552b62edSJonas Toth     StringRef MacroName = MacroNameTok.getIdentifierInfo()->getName();
5146bf25a7SFangrui Song     if (MacroName == "__GCC_HAVE_DWARF2_CFI_ASM")
5246bf25a7SFangrui Song       return;
53269ef315Ssmhc     if (!CheckCapsOnly && !RegExp.match(MacroName))
54c367ba19SRoman Lebedev       Check->warnMacro(MD, MacroName);
55552b62edSJonas Toth 
56552b62edSJonas Toth     if (CheckCapsOnly && !isCapsOnly(MacroName))
57c367ba19SRoman Lebedev       Check->warnNaming(MD, MacroName);
58552b62edSJonas Toth   }
59552b62edSJonas Toth 
60552b62edSJonas Toth private:
61552b62edSJonas Toth   MacroUsageCheck *Check;
62c367ba19SRoman Lebedev   const SourceManager &SM;
63269ef315Ssmhc   const llvm::Regex RegExp;
64552b62edSJonas Toth   bool CheckCapsOnly;
65c367ba19SRoman Lebedev   bool IgnoreCommandLineMacros;
66552b62edSJonas Toth };
67552b62edSJonas Toth } // namespace
68552b62edSJonas Toth 
storeOptions(ClangTidyOptions::OptionMap & Opts)69552b62edSJonas Toth void MacroUsageCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
70552b62edSJonas Toth   Options.store(Opts, "AllowedRegexp", AllowedRegexp);
71552b62edSJonas Toth   Options.store(Opts, "CheckCapsOnly", CheckCapsOnly);
72c367ba19SRoman Lebedev   Options.store(Opts, "IgnoreCommandLineMacros", IgnoreCommandLineMacros);
73552b62edSJonas Toth }
74552b62edSJonas Toth 
registerPPCallbacks(const SourceManager & SM,Preprocessor * PP,Preprocessor * ModuleExpanderPP)75b6c4db99SAlexander Kornienko void MacroUsageCheck::registerPPCallbacks(const SourceManager &SM,
76b6c4db99SAlexander Kornienko                                           Preprocessor *PP,
77b6c4db99SAlexander Kornienko                                           Preprocessor *ModuleExpanderPP) {
781c705d9cSJonas Devlieghere   PP->addPPCallbacks(std::make_unique<MacroUsageCallbacks>(
79b6c4db99SAlexander Kornienko       this, SM, AllowedRegexp, CheckCapsOnly, IgnoreCommandLineMacros));
80552b62edSJonas Toth }
81552b62edSJonas Toth 
warnMacro(const MacroDirective * MD,StringRef MacroName)82c367ba19SRoman Lebedev void MacroUsageCheck::warnMacro(const MacroDirective *MD, StringRef MacroName) {
83d83ecd77SRichard   const MacroInfo *Info = MD->getMacroInfo();
84d83ecd77SRichard   StringRef Message;
85552b62edSJonas Toth 
86d83ecd77SRichard   if (llvm::all_of(Info->tokens(), std::mem_fn(&Token::isLiteral)))
87d83ecd77SRichard     Message = "macro '%0' used to declare a constant; consider using a "
88d83ecd77SRichard               "'constexpr' constant";
89d83ecd77SRichard   // A variadic macro is function-like at the same time. Therefore variadic
90d83ecd77SRichard   // macros are checked first and will be excluded for the function-like
91d83ecd77SRichard   // diagnostic.
92d83ecd77SRichard   else if (Info->isVariadic())
93c367ba19SRoman Lebedev     Message = "variadic macro '%0' used; consider using a 'constexpr' "
94552b62edSJonas Toth               "variadic template function";
95d83ecd77SRichard   else if (Info->isFunctionLike())
96c367ba19SRoman Lebedev     Message = "function-like macro '%0' used; consider a 'constexpr' template "
97552b62edSJonas Toth               "function";
98552b62edSJonas Toth 
99d83ecd77SRichard   if (!Message.empty())
100c367ba19SRoman Lebedev     diag(MD->getLocation(), Message) << MacroName;
101552b62edSJonas Toth }
102552b62edSJonas Toth 
warnNaming(const MacroDirective * MD,StringRef MacroName)103c367ba19SRoman Lebedev void MacroUsageCheck::warnNaming(const MacroDirective *MD,
104c367ba19SRoman Lebedev                                  StringRef MacroName) {
105552b62edSJonas Toth   diag(MD->getLocation(), "macro definition does not define the macro name "
106c367ba19SRoman Lebedev                           "'%0' using all uppercase characters")
107c367ba19SRoman Lebedev       << MacroName;
108552b62edSJonas Toth }
109552b62edSJonas Toth 
1107d2ea6c4SCarlos Galvez } // namespace clang::tidy::cppcoreguidelines
111