1e69e551eSFrank Derry Wanye //===--- SingleWorkItemBarrierCheck.cpp - clang-tidy-----------------------===//
2e69e551eSFrank Derry Wanye //
3e69e551eSFrank Derry Wanye // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4e69e551eSFrank Derry Wanye // See https://llvm.org/LICENSE.txt for license information.
5e69e551eSFrank Derry Wanye // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6e69e551eSFrank Derry Wanye //
7e69e551eSFrank Derry Wanye //===----------------------------------------------------------------------===//
8e69e551eSFrank Derry Wanye
9e69e551eSFrank Derry Wanye #include "SingleWorkItemBarrierCheck.h"
10e69e551eSFrank Derry Wanye #include "clang/AST/ASTContext.h"
11e69e551eSFrank Derry Wanye #include "clang/ASTMatchers/ASTMatchFinder.h"
12e69e551eSFrank Derry Wanye
13e69e551eSFrank Derry Wanye using namespace clang::ast_matchers;
14e69e551eSFrank Derry Wanye
157d2ea6c4SCarlos Galvez namespace clang::tidy::altera {
16e69e551eSFrank Derry Wanye
registerMatchers(MatchFinder * Finder)17e69e551eSFrank Derry Wanye void SingleWorkItemBarrierCheck::registerMatchers(MatchFinder *Finder) {
18e69e551eSFrank Derry Wanye // Find any function that calls barrier but does not call an ID function.
19e69e551eSFrank Derry Wanye // hasAttr(attr::Kind::OpenCLKernel) restricts it to only kernel functions.
20e69e551eSFrank Derry Wanye // FIXME: Have it accept all functions but check for a parameter that gets an
21e69e551eSFrank Derry Wanye // ID from one of the four ID functions.
22e69e551eSFrank Derry Wanye Finder->addMatcher(
23e69e551eSFrank Derry Wanye // Find function declarations...
24e69e551eSFrank Derry Wanye functionDecl(
25e69e551eSFrank Derry Wanye // That are OpenCL kernels...
26e69e551eSFrank Derry Wanye hasAttr(attr::Kind::OpenCLKernel),
27e69e551eSFrank Derry Wanye // And call a barrier function (either 1.x or 2.x version)...
28e69e551eSFrank Derry Wanye forEachDescendant(callExpr(callee(functionDecl(hasAnyName(
29e69e551eSFrank Derry Wanye "barrier", "work_group_barrier"))))
30e69e551eSFrank Derry Wanye .bind("barrier")),
31e69e551eSFrank Derry Wanye // But do not call an ID function.
32e69e551eSFrank Derry Wanye unless(hasDescendant(callExpr(callee(functionDecl(
33e69e551eSFrank Derry Wanye hasAnyName("get_global_id", "get_local_id", "get_group_id",
34*df0c8f25SNathan James "get_local_linear_id")))))))
35e69e551eSFrank Derry Wanye .bind("function"),
36e69e551eSFrank Derry Wanye this);
37e69e551eSFrank Derry Wanye }
38e69e551eSFrank Derry Wanye
check(const MatchFinder::MatchResult & Result)39e69e551eSFrank Derry Wanye void SingleWorkItemBarrierCheck::check(const MatchFinder::MatchResult &Result) {
40e69e551eSFrank Derry Wanye const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("function");
41e69e551eSFrank Derry Wanye const auto *MatchedBarrier = Result.Nodes.getNodeAs<CallExpr>("barrier");
42e69e551eSFrank Derry Wanye if (AOCVersion < 1701) {
43e69e551eSFrank Derry Wanye // get_group_id and get_local_linear_id were added at/after v17.01
44e69e551eSFrank Derry Wanye diag(MatchedDecl->getLocation(),
45e69e551eSFrank Derry Wanye "kernel function %0 does not call 'get_global_id' or 'get_local_id' "
46e69e551eSFrank Derry Wanye "and will be treated as a single work-item")
47e69e551eSFrank Derry Wanye << MatchedDecl;
48e69e551eSFrank Derry Wanye diag(MatchedBarrier->getBeginLoc(),
49e69e551eSFrank Derry Wanye "barrier call is in a single work-item and may error out",
50e69e551eSFrank Derry Wanye DiagnosticIDs::Note);
51e69e551eSFrank Derry Wanye } else {
52e69e551eSFrank Derry Wanye // If reqd_work_group_size is anything other than (1,1,1), it will be
53e69e551eSFrank Derry Wanye // interpreted as an NDRange in AOC version >= 17.1.
54e69e551eSFrank Derry Wanye bool IsNDRange = false;
55e69e551eSFrank Derry Wanye if (MatchedDecl->hasAttr<ReqdWorkGroupSizeAttr>()) {
56e69e551eSFrank Derry Wanye const auto *Attribute = MatchedDecl->getAttr<ReqdWorkGroupSizeAttr>();
57e69e551eSFrank Derry Wanye if (Attribute->getXDim() > 1 || Attribute->getYDim() > 1 ||
58e69e551eSFrank Derry Wanye Attribute->getZDim() > 1)
59e69e551eSFrank Derry Wanye IsNDRange = true;
60e69e551eSFrank Derry Wanye }
61e69e551eSFrank Derry Wanye if (IsNDRange) // No warning if kernel is treated as an NDRange.
62e69e551eSFrank Derry Wanye return;
63e69e551eSFrank Derry Wanye diag(MatchedDecl->getLocation(),
64e69e551eSFrank Derry Wanye "kernel function %0 does not call an ID function and may be a viable "
65e69e551eSFrank Derry Wanye "single work-item, but will be forced to execute as an NDRange")
66e69e551eSFrank Derry Wanye << MatchedDecl;
67e69e551eSFrank Derry Wanye diag(MatchedBarrier->getBeginLoc(),
68e69e551eSFrank Derry Wanye "barrier call will force NDRange execution; if single work-item "
69e69e551eSFrank Derry Wanye "semantics are desired a mem_fence may be more efficient",
70e69e551eSFrank Derry Wanye DiagnosticIDs::Note);
71e69e551eSFrank Derry Wanye }
72e69e551eSFrank Derry Wanye }
73e69e551eSFrank Derry Wanye
storeOptions(ClangTidyOptions::OptionMap & Opts)74e69e551eSFrank Derry Wanye void SingleWorkItemBarrierCheck::storeOptions(
75e69e551eSFrank Derry Wanye ClangTidyOptions::OptionMap &Opts) {
76e69e551eSFrank Derry Wanye Options.store(Opts, "AOCVersion", AOCVersion);
77e69e551eSFrank Derry Wanye }
78e69e551eSFrank Derry Wanye
797d2ea6c4SCarlos Galvez } // namespace clang::tidy::altera
80