Changes in Makefile

c6c1234de9e0015e670dd0b51bf6ce39ee0e07bd - add new trace BLOB_REQ_SET_START and BLOB_REQ_SET_COMPLETE.

Thu, 11 Jul 2024 09:29:04 +0000

add new trace BLOB_REQ_SET_START and BLOB_REQ_SET_COMPLETE.Through the both new trace, the bdev_io trace of lvol and the bdev_iotrace of base bdev of blobstore can be connected in series. Like this:RDMA_REQ_RDY_TO_EXECUTE id: r31BDEV_IO_START size: 8 id: i2964 (r31)BLOB_REQ_SET_START id: a11 (i2964)BDEV_IO_START size: 8 id: i2965 (a11)BDEV_NVME_IO_START id: N2957 (i2965)NVME_PCIE_SUBMIT id: p2959 (N2957)NVME_PCIE_COMPLETE id: p2959 (N2957)BDEV_NVME_IO_DONE id: N2957 (i2965)BDEV_IO_DONE id: i2965 (a11)BLOB_REQ_SET_COMPLETE id: a11 (i2964)BDEV_IO_DONE id: i2964 (r31)RDMA_REQ_EXECUTED id: r31Change-Id: I607428b094031814627ac4192b9e3defe7ed5337Signed-off-by: Xupeng Mingtu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24130Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris List of files: /spdk/lib/trace/Makefile

355312bfcd3751f9af17fbefc90373fb8a269614 - so_ver: increase all major versions after SPDK 24.01

Fri, 26 Jan 2024 11:19:16 +0000

so_ver: increase all major versions after SPDK 24.01To allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all componentsDue to patch below being introduced after v24.01 code freeze,bdev lib version should not be increased:61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_chShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Signed-off-by: Tomasz Zawadzki Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/trace/Makefile

ae5e1aaf6cb82594820b29d4376c41a5048b4ec3 - lib/trace : Enable tracing support for user created threads

Fri, 01 Dec 2023 12:48:43 +0000

lib/trace : Enable tracing support for user created threadsOnly the environment created threads have the tracing support.Added tracing support for the user created threads by reservinglcore_history entries.fio_plugin is modified to verify the tracing support for the usercreated threads.This allows all SPDK applications to use SPDK tracing,even if they are not using the SPDK app framework.Change-Id: Ib7831b30d7de420fcc4a5849f3757733755a5406Signed-off-by: Krishna Kanth Reddy Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20852Reviewed-by: Jim Harris Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/trace/Makefile

075d422f3480d3db11013734f833304606867da4 - build: enable Wpointer-arith in selected libraries

Tue, 06 Jun 2023 07:32:53 +0000

build: enable Wpointer-arith in selected librariesThere's an organization, called Timerland SIG [1], that uses SPDK's NVMedriver to implement NVMe Boot Specification under UEFI. The UEFI EDK2build environment uses both gcc and msvc. While SPDK can be builtwithout any issues with gcc, msvc complains about a few things, one ofwhich is void pointer arithmetic. So, to make Timberland's efforteasier, Wpointer-arith is enabled in the libraries they're using.[1] https://github.com/timberland-sigSigned-off-by: Konrad Sztyber Change-Id: Ic90330baa4e69ee72f7e040de91893093b96f476Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18529Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Ben Walker Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/trace/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/trace/Makefile

cd4ac9c7921328d35a618344680da499d9af9c80 - lib/trace: add trace_get_info RPC

Mon, 14 Nov 2022 02:47:03 +0000

lib/trace: add trace_get_info RPCAdd rpc method trace_get_info to show name of shared memory file,list of the available trace point groups and mask of the available trace points for each group.Fixes #2747Signed-off-by: Xinrui Mao Change-Id: I2098283bed454dc46644fd2ca1b9568ab2aea81bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15426Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris Reviewed-by: Xiaodong Liu Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build Bot List of files: /spdk/lib/trace/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/lib/trace/Makefile

e36f0d363ea2737e979df417f938643ef0749ea9 - nvme/pcie, nvme/tcp: add cb_arg context tracepoint argument

Wed, 10 Aug 2022 22:29:42 +0000

nvme/pcie, nvme/tcp: add cb_arg context tracepoint argumentThis allows mapping an nvme_request back to thenvme_bdev_io.This requires bumping up the max number of arguments pertracepoint. 5 was previously chosen as max since itexactly fit in 64 bytes (1 cacheline) when allarguments were stored as uint64_t, but now that wesupport uint32_t arguments we can afford extraarguments when some of them are uint32_t. I'vebumped it to 8 so we can avoid having to touchthis value multiple times if we find some caseswhere we need 7 or 8 args.Signed-off-by: Jim Harris Change-Id: Ie2ef5e59d10549860b47542e68c1c34efa63047fReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13995Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jacek Kalwas Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/trace/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/lib/trace/Makefile

047c067c05ff22df06c053990998184b8a940514 - so_ver: increase all major versions

Mon, 31 Jan 2022 09:55:58 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 22.05release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/trace/Makefile

aa1ec3730d46191bdb7068c5cdadf6bd8582fdf8 - trace: make trace_create_tpoint_group_mask() external

Wed, 22 Dec 2021 14:58:14 +0000

trace: make trace_create_tpoint_group_mask() externalMake trace_create_tpoint_group_mask() an external function.This is going to be used in following patch.Change-Id: I06cd1652bb30abddd49536bc76ec134a01121537Signed-off-by: Krzysztof Karas Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10830Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris List of files: /spdk/lib/trace/Makefile

70c171602a12549fd300b89a7b9dbb2a4e630fad - trace: enable adding relations between traces

Tue, 19 Oct 2021 10:02:46 +0000

trace: enable adding relations between tracesCurrently we do not have any way to connect traces from differentmodules in SPDK. This change modifies our trace libraryand app/trace to handle adding relations between trace pointsand a trace object.Additionally this patch adds classes and fields to structsinside trace.py to prepare it for future patches implementingprinting relation information.Change-Id: Ia09d01244d923957d589fd37e6d4c98f9f7bbd07Signed-off-by: Krzysztof Karas Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9620Reviewed-by: Tomasz Zawadzki Reviewed-by: Konrad Sztyber Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI List of files: /spdk/lib/trace/Makefile

f301d156f1e38fba27cba850d05ab221dd3574c8 - lib/trace: variable number of tracepoint arguments

Mon, 17 May 2021 13:10:39 +0000

lib/trace: variable number of tracepoint argumentsThis patch allows tracepoint to record a variable number of arugments.An additional function has been added,`spdk_trace_register_description_ext()`, which allows the user toregister definitions for tracepoints specifying all the arugments thatthey accept. Users can also call `spdk_trace_register_description()` toregister tpoints with a single argument (or none).Currently, all of the tracepoint arguments need to be passed asuint64_t.The trace record functions use variable arguments and rely on tracepointdescription to know the order and the format of the arguments passed.That means that the user needs to take care that they're always in sync.Moreover, this patch extends the tracepoint entry size from 32B to 64B,meaning that there are 40B that can be utilized for passing arguments,which in turn means that there can be up to 5 arguments per tracepoint.Signed-off-by: Konrad Sztyber Change-Id: I9993eabb2663078052439320e6d2f6ae607a47ffReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7956Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot List of files: /spdk/lib/trace/Makefile

e4070ee0e012c345f4c059f125f4f9ce3be66690 - so_ver: increase all major versions

Fri, 29 Jan 2021 10:11:25 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the quarterly releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 21.04release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: I44d01154430a074103bd21c7084f44932e81fe72Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6167Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/lib/trace/Makefile

9ae6f5893b4a4e5d60d82b80d4feea1a8db8d5fd - build: only link rt where needed

Thu, 24 Sep 2020 00:12:58 +0000

build: only link rt where neededOnly libraries that are using shm_open require linkingrt when creating the shared library. Stop includingit on every library and just add it to LOCAL_SYS_LIBSin the one case where it is used (spdk_trace).Signed-off-by: Jim Harris Change-Id: Ic13128873a76c355b14871a0dea0922488c9cd13Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4370Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/trace/Makefile

d18e63206a4b5d710756d7e7d9c42ef0db0c5d58 - mk/lib: add a check that major and minor version is set for libs.

Sun, 10 May 2020 20:40:09 +0000

mk/lib: add a check that major and minor version is set for libs.Also, while we are here, consolidate setting SO_SUFFIX to one spot.Previously, it was possible for a library to slip throughwithout an SO version.Signed-off-by: Seth Howell Change-Id: I4db5fa5839502d266c6259892e5719b05134518cReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotCommunity-CI: Broadcom CIReviewed-by: Paul Luse Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/trace/Makefile

74dcd8e25076fd64d8adde406fb7ec0fdd7ef26f - lib/trace: add a map file.

Sun, 10 May 2020 00:11:53 +0000

lib/trace: add a map file.Signed-off-by: Seth Howell Change-Id: Id3e4e1f3cd17739f534db9266d56ceda586312c1Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2300Community-CI: Mellanox Build BotCommunity-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/trace/Makefile

193927830ddced41dfebfe7cdb14d543aaf84a2c - make: rev SO versions individually for libraries.

Fri, 28 Feb 2020 20:47:11 +0000

make: rev SO versions individually for libraries.This will allow us to keep track of compatibility issues on aper-library basis.Change-Id: Ib0c796adb1efe1570212a503ed660bef6f142b6eSigned-off-by: Seth Howell Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1067Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/trace/Makefile

bc83adc2db4690d01106db1dbd07254350d99cfb - lib: move trace_rpc into lib/trace

Wed, 14 Aug 2019 22:26:37 +0000

lib: move trace_rpc into lib/traceCombinining these two libraries removes some directory complexity. Italso helps us to align on a common practice for including the rpc codewith a given module. This is how all of our bdev modules already do it.The nbd, net, and scsi modules also follow this pattern.Change-Id: I5e4c99d7f0facacc6dfe30b2274b60e0d151f8d8Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465210Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Darek Stojaczyk Reviewed-by: Jim Harris List of files: /spdk/lib/trace/Makefile

ae0aae1532c95473937a116c9b6e630f91965e3e - lib/trace: add 3 RPC method for tpoint_group_mask

Thu, 29 Nov 2018 11:12:26 +0000

lib/trace: add 3 RPC method for tpoint_group_maskNow trace facility can be enabled/disabled at runtime,besides app starting parametersChange-Id: I086564665ba4375b946a5339d5921d6584e9bfdaSigned-off-by: Liu Xiaodong Reviewed-on: https://review.gerrithub.io/435470Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/trace/Makefile