Changes in Makefile

b82fd48aab0e069e833fbcb7b8100d523311eb3d - thread: remove pool parameter from spdk_iobuf_for_each_entry

Fri, 19 Jul 2024 20:38:59 +0000

thread: remove pool parameter from spdk_iobuf_for_each_entryWe always want to iterate across the entire iobuf_channel, so justmake the iterator do exactly that, rather than requiring the callerto have to iterate both of the pools itself.This both simplifies the calling logic, and prepares for upcomingchanges which will support multiple NUMA node caches in one channel.Signed-off-by: Jim Harris Change-Id: Ieed144671e7ee7cb4d7b7b28e803ea3cae641feeReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24515Reviewed-by: Aleksey Marchuk Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Community-CI: Mellanox Build BotReviewed-by: Konrad Sztyber Community-CI: Community CI Samsung List of files: /spdk/lib/thread/Makefile

fa6aec49539e73a877c6cbd25aadc6d53c6bdc07 - lib/thread: register thread owner type for scheduler trace events

Fri, 20 Sep 2024 18:40:48 +0000

lib/thread: register thread owner type for scheduler trace eventsChange-Id: I0074148ab2a151e38a17fe8cb770fd3ef19ec543Signed-off-by: Anisa Su Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25067Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Konrad Sztyber Community-CI: Mellanox Build BotCommunity-CI: Broadcom CI List of files: /spdk/lib/thread/Makefile

df96ddcca6749fd6c82945fd545995e30d82041f - thread: Add API that allows to select interrupt event type

Tue, 07 May 2024 07:23:35 +0000

thread: Add API that allows to select interrupt event typeNew API call spdk_interrupt_register_for_events() - variant ofspdk_interrupt_register() with additional event type argument.It's needed to use interrupt mode also on events other than theSPDK_INTERRUPT_EVENT_IN.Change-Id: Ied1d3faf737c7efb028075eadb722b72234b9363Signed-off-by: Krzysztof Goreczny Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23030Reviewed-by: Boris Glimcher Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Community-CI: Mellanox Build BotReviewed-by: Konrad Sztyber List of files: /spdk/lib/thread/Makefile

355312bfcd3751f9af17fbefc90373fb8a269614 - so_ver: increase all major versions after SPDK 24.01

Fri, 26 Jan 2024 11:19:16 +0000

so_ver: increase all major versions after SPDK 24.01To allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all componentsDue to patch below being introduced after v24.01 code freeze,bdev lib version should not be increased:61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_chShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Signed-off-by: Tomasz Zawadzki Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/thread/Makefile

7bbba48a29aa973aa27e6903a698b32915e73f67 - thread: add iobuf stats

Tue, 30 May 2023 14:54:30 +0000

thread: add iobuf statsThese could help to find quickly misconfig and misbehavior of overallsystem under workload.Change-Id: I0d90afbeeb6f73ef83a849619350eca9995105e3Signed-off-by: Jacek Kalwas Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18465Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Jim Harris List of files: /spdk/lib/thread/Makefile

1b1967bdd61daa5ec110e2ca6c73c7b38a60bb89 - thread: add spdk_thread_is_app_thread()

Wed, 24 May 2023 15:01:52 +0000

thread: add spdk_thread_is_app_thread()This simply returns true if the current spdk_threadis the app thread.This is a simpler replacement for:spdk_thread_get_app_thread() == spdk_get_thread()Signed-off-by: Jim Harris Change-Id: Ib8754d4ecb91ee8bfb024e8c0b74c42bb8282b32Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18355Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/thread/Makefile

a9bcb7f2613c28948b141fdc3fd9cc7b1d3f30a9 - thread: Move iobuf code to a separate compilation unit.

Tue, 17 Jan 2023 07:50:36 +0000

thread: Move iobuf code to a separate compilation unit.This makes it much easier to mock this code in unit tests without havingto mock up the entire thread library.Change-Id: Ic3d9cb826ae71af780a06f88669c37cef2c9a4aeSigned-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16173Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk List of files: /spdk/lib/thread/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/thread/Makefile

090b8af12b91c28e3a73b99067dfb893f9af999c - thread: add spdk_thread_get_app_thread

Thu, 17 Nov 2022 02:22:44 +0000

thread: add spdk_thread_get_app_threadThe "app thread" will always be the firstthread created using spdk_thread_create(). Thereare many operations throughout SPDK that implicitlyexpect to happen in the context of this app thread,so by formalizing it we can start to make assertionson this to help clarify and simplify locking andsynchronization through the code base.Signed-off-by: Jim Harris Change-Id: I7133b58c311710f1d132ee5f09500ffeb4168b15Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15497Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/thread/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/lib/thread/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/lib/thread/Makefile

047c067c05ff22df06c053990998184b8a940514 - so_ver: increase all major versions

Mon, 31 Jan 2022 09:55:58 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 22.05release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/thread/Makefile

29c0e0dc3e847e6fd370138be7c6c3fca83aba7e - thread: add spdk_poller_get_id

Thu, 17 Dec 2020 01:25:53 +0000

thread: add spdk_poller_get_idIssue: spdk_top tracked pollers by the poller name string and thethread_id they are running on. This shows incorrect stats whenmultiple pollers exist on the same thread with the same name.Solution: Added a unique poller id for each poller on a thread andto allow spdk_top to track pollers by thread_id and poller_id.Signed-off-by: Michael Piszczek Change-Id: I1879e2afc9a929d1df9e8e35510f0092c5443bdcReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5868Community-CI: Mellanox Build BotCommunity-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/thread/Makefile

1aec9334d9d560d41c500889324d72898c6879d4 - thread: Change direct accesses to poller outside lib/thread to helper functions

Thu, 06 May 2021 23:02:30 +0000

thread: Change direct accesses to poller outside lib/thread to helper functionsMost accesses to the struct spdk_poller outside lib/thread have beendone via functions but a few direct accesses remain.Change these to indirect accesses by addinng a few helper functionsas SPDK internal APIs.Add spdk_poller_get_name() to get the name of the poller.Remove spdk_poller_state_str() and add spdk_poller_get_state_str().Exposing enum spdk_poller_state outside lib/thread is not reallynecessary.This removal requires us to update major SO version.Add spdk_poller_get_period_ticks() to get the period ticks of thepoller.Add struct spdk_poller_stats and spdk_poller_get_stats() to getthe stats of the poller.The next patch will move the definition of struct spdk_poller andenum spdk_poller_state from include/spdk_internal/thread.h tolib/thread/thread.c.Signed-off-by: Shuhei Matsumoto Change-Id: Id597dae074a15fcd8af09fd9d416a22ce2f403c3Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7798Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/thread/Makefile

cd83ea4a6d7bd7c46d676213c65d119e0449241e - thread: Add SPDK internal APIs spdk_thread_get_first/next_active/timed/paused_poller()

Fri, 30 Apr 2021 14:25:15 +0000

thread: Add SPDK internal APIs spdk_thread_get_first/next_active/timed/paused_poller()The following patches will introduce red black tree to managetimed pollers efficiently but it will be based on macros available onlyin lib/thread/thread.c. Hence then it will be difficult to expose theinternal of timed pollers tree outside the file. On the other hand,we do not want to include JSON into the file.Hence add a few SPDK internal APIs to iterate pollers list transparently.For spdk_thread_get_next_active/timed/pause_poller(), we omit the parameterthread and get it internally from poller->thread even if the names includethe term "thread". This will be slightly cleaner.Signed-off-by: Shuhei Matsumoto Change-Id: I000801a2e4dc42fa79801a2fd6f2b06e1b769c88Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7717Community-CI: Broadcom CICommunity-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/thread/Makefile

e4070ee0e012c345f4c059f125f4f9ce3be66690 - so_ver: increase all major versions

Fri, 29 Jan 2021 10:11:25 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the quarterly releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 21.04release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: I44d01154430a074103bd21c7084f44932e81fe72Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6167Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/lib/thread/Makefile

4bf6e4bb3298e4af55aa533f62290d038493a5ec - interrupt: apply fd_group in thd and reactor

Wed, 16 Sep 2020 20:03:56 +0000

interrupt: apply fd_group in thd and reactorEach reactor and each thread is assigned with one fd group.At the same time, each thread is treated as one interrupt sourceregistered into its corresponding reactor.The egrp function for reacotr is the only block point waitingfor events.Change-Id: Id092e66591b07b445342f8ae16dc218d28887427Signed-off-by: Liu Xiaodong Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4269Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris List of files: /spdk/lib/thread/Makefile

d18e63206a4b5d710756d7e7d9c42ef0db0c5d58 - mk/lib: add a check that major and minor version is set for libs.

Sun, 10 May 2020 20:40:09 +0000

mk/lib: add a check that major and minor version is set for libs.Also, while we are here, consolidate setting SO_SUFFIX to one spot.Previously, it was possible for a library to slip throughwithout an SO version.Signed-off-by: Seth Howell Change-Id: I4db5fa5839502d266c6259892e5719b05134518cReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotCommunity-CI: Broadcom CIReviewed-by: Paul Luse Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/thread/Makefile

90b435028439899c5c1682f248e66d19257de3b9 - lib/thread: add a map file.

Sat, 09 May 2020 23:54:19 +0000

lib/thread: add a map file.Signed-off-by: Seth Howell Change-Id: If5d934f7d3f46e5c508e40c0b0c3aea65d3ba113Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2298Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/thread/Makefile

acf25fed80cc4001a7a5c86b3f1a59a1529209aa - lib: update so version for multiple libraries.

Fri, 13 Mar 2020 21:48:44 +0000

lib: update so version for multiple libraries.the nvme, nvmf, and thread libraries have all had public APIsremoved or changed since the API was changed to 2.0 andbackported to 20.01.1 we should rev these so versions to makethat distinction obvious.Signed-off-by: Seth Howell Change-Id: Id48454b8d0451794abad4db452b5c4e337b23c0bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1269Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/thread/Makefile