Changes in Makefile

f7f0fdf5cc5eea40b02cc076412f7f141f22b3a2 - nvme: Add transport interface to enable interrupts

Tue, 03 Sep 2024 22:50:07 +0000

nvme: Add transport interface to enable interruptsThe following commit will enable interrupts for pcie transport.So add a new interface for the same.Change-Id: I5cd87b0bb4ec95d6a9b862b659405cf56d8f864aSigned-off-by: Ankit Kumar Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24904Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Community-CI: Community CI Samsung Community-CI: Mellanox Build Bot List of files: /spdk/lib/nvme/Makefile

2076ab31a15a22a3462f8b0a3178ea80495564a8 - nvme: Add spdk_nvme_ctrlr_get_id() for multipath identification

Tue, 22 Oct 2024 01:31:12 +0000

nvme: Add spdk_nvme_ctrlr_get_id() for multipath identificationctrlr->cntlid is easy to get. However, there was no public API toreturn ctrlr->cntlid yet.As the following comment in lib/nvme/nvme_ctrlr.c, Fabrics controllers should already have CNTLID from the Connect command. If CNTLID from Connect doesn't match CNTLID in the Identify Controller data, trust the one from Connect.ctrlr->cntlid is sufficiently reliable.Signed-off-by: Shuhei Matsumoto Change-Id: Iad7f1d8defcc427b7656e1b5f4f8104439bcfd51Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25297Community-CI: Community CI Samsung Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/nvme/Makefile

4ddd77b20bbb2b0f96dd9cc3601bff095f1bae40 - nvme: add methods for forcing (re)authentication

Mon, 01 Jul 2024 09:54:17 +0000

nvme: add methods for forcing (re)authenticationThese two functions can be used to force IO and admin qpairs toauthenticate. They can be called at any time while a qpair is active.If it has already been connected and authenticated, it'll be forced toreauthenticate. If the connection is still being established, thesefunctions will only register the callback and let the regularauthentication flow proceed.Signed-off-by: Konrad Sztyber Change-Id: I830fbe7d775c0997f24689fab2b2fc3cd875b15aReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24233Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot List of files: /spdk/lib/nvme/Makefile

4629dfb5373b5182177a22fb55a083e606beec6d - nvme: Get NVM Identify Namespace Data for Extended LBA Format

Fri, 07 Jun 2024 04:40:30 +0000

nvme: Get NVM Identify Namespace Data for Extended LBA FormatIf ns->csi is NVM and ctrlr->cdata.ctratt.bits.elbas is 1,get NVM identify namespace data to handle extended LBA format.Additionally, add a public API spdk_nvme_nvm_ns_get_data() for theupper layer to the identify data.Signed-off-by: Shuhei Matsumoto Change-Id: Icea8127b8a4834c4efb137369f3a8bfb388cb01bReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/23621Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris List of files: /spdk/lib/nvme/Makefile

3eee286a3f5ee3f4d6090096b71ac5af0fa644c1 - nvme/auth: make get_{digest,dhgroup}_name() functions public

Fri, 16 Feb 2024 08:44:53 +0000

nvme/auth: make get_{digest,dhgroup}_name() functions publicSigned-off-by: Konrad Sztyber Change-Id: I63da019d2d53e76a7533a74a824623faa4b4edbaReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22018Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/nvme/Makefile

fc8dece06bf594cc01e52a77551b3eed0eb22304 - nvme: initial in-band authentication code

Mon, 22 Jan 2024 14:48:32 +0000

nvme: initial in-band authentication codeThis patch adds structures that will be used to implement NVMe in-bandauthentication using the DH-HMAC-CHAP protocol. They're mostly empty fornow, the following patches will implement each step of this process.The authentication is executed by exchanging several messages using theAUTHENTICATION_SEND and AUTHENTICATION_RECEIVE commands from the FabricsCommand Set. The messages sent by the host map to the SEND commands,while those sent by the controller map to the RECEIVE commands.The flow roughly consists of 5 steps: 1. The host sends a AUTH_negotiate message to listing the hash function and Diffie-Hellman group it supports. 2. The controller responds with a DH-HMAC-CHAP_challenge message selecting one of the hash functions and DH groups from those sent by the host along with a challenge value and an optional DH public key. 3. The host calculates an HMAC of the challenge (optionally augmented with a DH secret) and sends it back to the controller using a DH-HMAC-CHAP_reply message along with its DH public key. If bidirectional authentication is requested, it includes its own challenge value in that message. 4. The controller verifies the response to the challenge received from the host comparing it to its HMAC calculation. If successful, it sends a DH-HMAC-CHAP_success1 message with an optional response to the host challenge. 5. If bidirectional authentication wasn't requested, the authentication process is finished at this point. Otherwise the host verifies controller's response to the host's challenge and, if successful, sends a DH-HMAC-CHAP_success2 message.Any errors during this process are reported by sending either anAUTH_failure1 message (sent by the controller) or AUTH_failure2 (sent bythe host).Signed-off-by: Konrad Sztyber Change-Id: I84cc1574e15884e1e3d3d03e517cb38f05e12ef6Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21981Reviewed-by: Ben Walker Reviewed-by: Jim Harris Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/nvme/Makefile

e838f2ec2d8ca58cfb8ea8a481cafe4a08fb6dcd - nvme: keep stubbed function in a single place

Thu, 29 Feb 2024 13:19:01 +0000

nvme: keep stubbed function in a single placeIt gets rid of a few #ifdefs from source files with actual code.Signed-off-by: Konrad Sztyber Change-Id: I62af47ba3c5cac0e00becb979b27df98ff05bfe6Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22112Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/nvme/Makefile

585b2d7662129230b4d5ee05283380473ecc81c7 - nvme: Don't build vfio-user transport if the user disabled it

Tue, 14 Nov 2023 17:00:13 +0000

nvme: Don't build vfio-user transport if the user disabled itChange-Id: Ibc169dff3e418df266c3b3ae3072616e04bb2b25Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21960Community-CI: Mellanox Build BotReviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/nvme/Makefile

355312bfcd3751f9af17fbefc90373fb8a269614 - so_ver: increase all major versions after SPDK 24.01

Fri, 26 Jan 2024 11:19:16 +0000

so_ver: increase all major versions after SPDK 24.01To allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all componentsDue to patch below being introduced after v24.01 code freeze,bdev lib version should not be increased:61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_chShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Signed-off-by: Tomasz Zawadzki Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/nvme/Makefile

127b5e84f80ae0feff648d2716fddec8dfc6eda8 - nvme: add fuse3 to LOCAL_SYS_LIBS

Tue, 19 Dec 2023 23:43:23 +0000

nvme: add fuse3 to LOCAL_SYS_LIBSLibrary makefiles are required to add dependent librariesto LOCAL_SYS_LIBS, although it seems at least some systemshave linkers which are able to workaround missing ones atsome times. Upcoming patches to make CONFIG_NVME_CUSE=yby default discovered external_code tests failed without this.Signed-off-by: Jim Harris Change-Id: I6fe702014e28a730e43e39bfa281984614953a8aReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21125Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/nvme/Makefile

d1357fd81938b34804872535fae82f07b94fb3a9 - nvme_rdma: Add option to limit indefinite growth of CQ size

Mon, 11 Dec 2023 07:23:00 +0000

nvme_rdma: Add option to limit indefinite growth of CQ sizeCQ size had grown indefinitely every when an I/O qpair was added to apoller. This was not desirable. To limit the CQ size, add a transportoption, rdma_max_cq_size. It is zero, which means unlimited, by default.Signed-off-by: Shuhei Matsumoto Change-Id: I8867ad4600ce85cc13c3c8b7129e39563e2cbfc9Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18840Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins List of files: /spdk/lib/nvme/Makefile

04a428f5496a3c860da70b2d7d455a54a5dd0e9d - nvme: add iovec passthru

Mon, 30 Oct 2023 13:35:43 +0000

nvme: add iovec passthruThis is used for sending big passthru commands, like Report Zones, over nvmf.Change-Id: I83188367e0266e093faadd49cdb2e051eae71829Signed-off-by: Karl Bonde Torp Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/20498Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Community-CI: Mellanox Build BotReviewed-by: Ben Walker List of files: /spdk/lib/nvme/Makefile

fc12d2763106c9bf4555412d873bb078b68c6bcf - nvme: remove remaining attribute((packed))

Tue, 06 Jun 2023 09:03:21 +0000

nvme: remove remaining __attribute__((packed))These strucutres had the packed attribute to make sure their sizechanged whenever a new field was added at the end for ABI compatibility.However, all of them have a corresponding *_get_opts() function, whichwill will out the new fields, even if the code using it was unaware ofthem when it was compiled. For the same reason, their size can beobtained with a regular sizeof(), and not SPDK_SIZEOF().Signed-off-by: Konrad Sztyber Change-Id: I658ce6619ed92015b6c61d8460abd192be368496Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18532Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Ben Walker List of files: /spdk/lib/nvme/Makefile

075d422f3480d3db11013734f833304606867da4 - build: enable Wpointer-arith in selected libraries

Tue, 06 Jun 2023 07:32:53 +0000

build: enable Wpointer-arith in selected librariesThere's an organization, called Timerland SIG [1], that uses SPDK's NVMedriver to implement NVMe Boot Specification under UEFI. The UEFI EDK2build environment uses both gcc and msvc. While SPDK can be builtwithout any issues with gcc, msvc complains about a few things, one ofwhich is void pointer arithmetic. So, to make Timberland's efforteasier, Wpointer-arith is enabled in the libraries they're using.[1] https://github.com/timberland-sigSigned-off-by: Konrad Sztyber Change-Id: Ic90330baa4e69ee72f7e040de91893093b96f476Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18529Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Ben Walker Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/nvme/Makefile

d1efcf8cefda31f3e22c4c086835a80df4e7c243 - nvme: Add spdk_nvme_qpair_is_connected() to check connection state

Fri, 19 May 2023 12:05:56 +0000

nvme: Add spdk_nvme_qpair_is_connected() to check connection stateThe upper layer wants to know when the qpair is actually connectedand can start processing I/Os. Add a new APIspdk_nvme_qpair_is_connected() for the purpose.Signed-off-by: Shuhei Matsumoto Change-Id: Ib15305aa7b08000c5a88baad5595ce99b1251506Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18242Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot List of files: /spdk/lib/nvme/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/nvme/Makefile

ce92d919d7d4494488a92a2626bd1af547d10087 - nvme: Add a helper function to return status type string

Fri, 09 Dec 2022 04:25:24 +0000

nvme: Add a helper function to return status type stringAdd spdk_nvme_cpl_get_status_type_string() to return ASCIIstring for the type of an error.Append a dummy entry to return "RESERVED" for unknown types.Signed-off-by: Shuhei Matsumoto Change-Id: Ibc07132ee067f146ac149884c6344f313bfcbfffReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15835Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris List of files: /spdk/lib/nvme/Makefile

86ba16c39c091790f79e99a033db86b6fd502606 - build: compile API functions with missing deps

Thu, 10 Nov 2022 15:32:42 +0000

build: compile API functions with missing depsWe should always build all function that are part of the API, even ifsome of the libraries they depend on are missing. In that case, theycan return an error instead.Signed-off-by: Konrad Sztyber Change-Id: I72b450b3a1d62e222bd843e45be547d926414775Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15414Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotReviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris List of files: /spdk/lib/nvme/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/lib/nvme/Makefile

e50ade3153ba6dcf83e7a88ea829a2e4c7b9daf5 - vfio_user: remove CONFIG_VFIO_USER flag for client library

Thu, 28 Jul 2022 07:42:43 +0000

vfio_user: remove CONFIG_VFIO_USER flag for client libraryThe client vfio_user library doesn't require this flag asit is totally owned in SPDK, so remove it.Change-Id: I8f7b1df18017ceac24dbb8a0417871f25f6bee0dSigned-off-by: Changpeng Liu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13895Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Ben Walker List of files: /spdk/lib/nvme/Makefile