Changes in Makefile

6e30ba64e50c2ecf566afe3ed0abbe5b414a3de1 - Remove RPC define

Wed, 10 Aug 2022 08:38:43 +0000

Remove RPC define List of files: /netbsd-src/usr.sbin/inetd/Makefile

9178dcce3626d36e4e42be09295e7247ecabb25e - PR bin/56963 Mark Davies: inetd not configured for rpc

Wed, 10 Aug 2022 03:35:38 +0000

PR bin/56963 Mark Davies: inetd not configured for rpcInstead of using negative flags to turn on positive flags, set -DRPCin the makefile. Corrects a problem where the SunRPC code in parse.cwas accidentally left disabled.This is a prime example of why we don't like negative flags... List of files: /netbsd-src/usr.sbin/inetd/Makefile

b19025f3ec67dd3a08ded30d9c8c92f8ce8df8cd - PR/56448: Solomon Ritzow: Various improvements.

Tue, 12 Oct 2021 19:08:04 +0000

PR/56448: Solomon Ritzow: Various improvements.Rate limiting code has been moved to ratelimit.c. I renamedclear_ip_list to rl_clear_ip_list and broke the code up into morefunctions. I have also made the per-IP rate limiting allocation moreefficient. IP addresses are now stored in their network format insteadof a string from getnameinfo (see inetd.h struct rl_ip_node). malloccalls use only the space needed by the structure by using offsetof onunion members (I suppose this can be a bit dangerous if not donecorrectly...). Per-IP rate limiting still supports textual comparisonusing getnameinfo for address families other than AF_INET and AF_INET6, but Idon't think there are any that are actually compatible or used by inetd (Ihaven't tested UNIX sockets with a remote bound to another file, but I did testusing IPv6 with the textual format by commenting out the IPv6 specificcode, and it works properly). Still potentially handy for the future.The IP node list (se_rl_ip_list) now uses the SLIST macrosinstead of a custom list. I've broken rl_process up into helper functionsfor each type of rate limiting and created a separate function foraddress stringification, for use with printouts from the -d flag. Itried to reduce stack memory use by moving printing code involvingstring buffers into separate functions. I haven't tested rl_ipv6_eq ona 32-bit system.The code for the positional syntax has also been moved to parse.c.Function try_biltin has been added to remove parse.c:parse_server'sdependency on the biltin structure definition.File inetd.h has been updated with the proper function prototypes, andthe servtab structure has been update with the new IP node SLIST. I alsomoved things around a bit. The way we (a peer and myself)formatted inetd.h previously was somewhat confusing. Function and globalvariable prototypes are now organized by the source file they aredefined in.I also added a -f flag that I saw in another problem report(https://gnats.netbsd.org/12823) that I thought could be useful. Itruns inetd in the foreground but without debug printouts or SO_DEBUG.I'm not completely sure about the line "if (foreground) setsid()" thatI changed from "if (debug) setsid()". List of files: /netbsd-src/usr.sbin/inetd/Makefile

adeed07f1b32244f669b1cfdc6690a01d1b3f2c8 - inetd: prepare for lint's strict bool mode

Fri, 03 Sep 2021 20:24:28 +0000

inetd: prepare for lint's strict bool modeLint's strict bool mode considers bool incompatible with the otherscalar types. This makes the type of expressions more visible in thecode. In particular, conditions of the form '!strcmp(...)' are nolonger allowed, they have to be written as 'strcmp(...) == 0'.The operator '!' cannot be used with sep->se_wait since that has typepid_t, not bool.No change to the resulting binary. List of files: /netbsd-src/usr.sbin/inetd/Makefile

5d133dbc57fa22d7fc372926131b07ac7dcad347 - inetd: raise WARNS from 5 to 6

Mon, 30 Aug 2021 18:21:11 +0000

inetd: raise WARNS from 5 to 6The necessary fixes include:* explicit integer conversions, to get rid of mixed signedness* function prototypes for parameterless functionsWhile here:* add space after comma* add space after 'if'* place the '{' of a function definition on a separate line* rename variables 'bits' and 'temp' to 'hi' and 'lo'* in parse_quote, prefer expressions over assignments* make hex_to_bits staticNo functional change. List of files: /netbsd-src/usr.sbin/inetd/Makefile

6344409ebf5db213828bfb644943fca422ba9c75 - remove -m32 accidentally committed

Sun, 29 Aug 2021 11:43:48 +0000

remove -m32 accidentally committed List of files: /netbsd-src/usr.sbin/inetd/Makefile

b74091d87399d717fde402bc87deb772fea59193 - fix printf formats (intmax -> j)

Sun, 29 Aug 2021 11:43:25 +0000

fix printf formats (intmax -> j) List of files: /netbsd-src/usr.sbin/inetd/Makefile

2557380693fe72f9b9a554a68affc1b669017f0b - Inetd enhancements by James Browning, Gabe Coffland, Alex Gavin, Solomon Ritzow

Sun, 29 Aug 2021 09:54:18 +0000

Inetd enhancements by James Browning, Gabe Coffland, Alex Gavin, Solomon RitzowDescribed in: https://www.mail-archive.com/tech-userlevel@netbsd.org/msg03114.htmlAnd developed in: https://github.com/ritzow/src/pull/1From their notes:All new functionality should be explained by the updated manpage.The manpage has been refactored a bit: A new section "Directives"has been added and the information about default hostnames andIPsec directives has been moved there, and the new file includedirective information is also there.getconfigent has the most major changes. A newline is no longerread immediately, but is called only by a "goto more" (inside anif(false) block). This allows multiple definitions or directivesto exist on a single line for anything that doesn't terminate usinga newline. This means a key-values service definition can be followedby another key-values service definition, a positional definition,or an ipsec, hostname, or .include directive on the same line.memset is no longer used explicitly to clear the servtab structure,a function init_servtab() is used instead, which uses a C structinitializer.The servtab se_group field is its own allocation now, and not justa pointer into the user:group string.Refactored some stuff out of getconfigent to separate functionsfor use by parse_v2.c. These functions in inetd.c are named withthe form parse_*()parse_v2.c only has code for parsing a key-values service definitioninto a provided servtab. It should not have anything that affectsglobal state other than line and line_number.Some function prototypes, structures, and #defines have been movedfrom inetd.c to inetd.h.The function config_root replaces config as the function called ona config file load/reload. The code removed from the end ofconfig(void) is now called in config_root, so it is not run on eachrecursive config call.setconfig(void) was removed and its code added into config_rootbecause that is the only place it is called, and redundant checksfor non-null globals were removed because they are always freed byendconfig. The fseek code was also removed because the config filesare always closed by endconfig.Rate limiting code was updated to add a per-service per-IP ratelimiting form. Some of that code was refactored out of other placesinto functions with names in the form rl_*()We have not added any of the license or version information to thenew files parse_v2.c, parse_v2.h, and inetd.h and we have notupdated the license or version info for inetd.c.Security related:The behavior when reading invalid IPsec strings has changed. Inetdno longer exits, it quits reading the current config file instead.Could this impact program security?We have not checked for memory leaks. Solomon tried to use dmallocwithout success. getconfigent seemed to have a memory leak at each"goto more". It seems like inetd has never free'd allocated stringswhen throwing away erroneous service definitions during parsing(i.e. when "goto more" is called when parsing fields). OpenBSD'sversion calls freeconfig on "goto more"(https://github.com/openbsd/src/blob/c5eae130d6c937080c3d30d124e8c8b86db7d625/usr.sbin/inetd/inetd.c#L1049)but NetBSD only calls it when service definitions are no longerneeded. This has been fixed. freeconfig is called immediately beforeany "goto more". There shouldn't be any time when a servtab is inan invalid state where freeconfig would break. List of files: /netbsd-src/usr.sbin/inetd/Makefile

d54a6e0c5dc9e23eb9a8d20099f5d58bb550eb91 - Add blocklist support to libwrap which enables all programs using libwrap

Sun, 07 Mar 2021 15:09:12 +0000

Add blocklist support to libwrap which enables all programs using libwrapto block access from hosts we deny. (libwrap support from Greg A. Woods) List of files: /netbsd-src/usr.sbin/inetd/Makefile

4a827eaa92495ce0d491749087bfb4141e10fa51 - Back out mDNS changes which were not discussed.

Thu, 22 Oct 2009 22:50:35 +0000

Back out mDNS changes which were not discussed.There is design work that needs to be done first. List of files: /netbsd-src/usr.sbin/inetd/Makefile

bd5b8260f5d5289a328e311dc83e7b12ee878882 - Add mDNS Service Directory support to inetd(8).

Thu, 22 Oct 2009 16:34:27 +0000

Add mDNS Service Directory support to inetd(8).inetd(8) can now advertize services in the mDNS-SD.(Per service configuration option in inetd.conf(5).) List of files: /netbsd-src/usr.sbin/inetd/Makefile

4147a3c54a369fdf2775e8a91ce4916614e21d3b - Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the

Mon, 28 May 2007 12:06:17 +0000

Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on theFORTIFY_SOURCE feature of libssp, thus checking the size of arguments tovarious string and memory copy and set functions (as well as a few systemcalls and other miscellany) where known at function entry. RedHat hasevidently built all "core system packages" with this option for some time.This option should be used at the top of Makefiles (or Makefile.inc wherethis is used for subdirectories) but after any setting of LIB.This is only useful for userland code, and cannot be used in libc or inany code which includes the libc internals, because it overrides certainlibc functions with macros. Some effort has been made to make USE_FORT=yeswork correctly for a full-system build by having the bsd.sys.mk logicdisable the feature where it should not be used (libc, libssp iteself,the kernel) but no attempt has been made to build the entire system withUSE_FORT and doing so will doubtless expose numerous bugs and misfeatures.Adjust the system build so that all programs and libraries that are setuid,directly handle network data (including serial comm data), performauthentication, or appear likely to have (or have a history of having)data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,with the exception of libc, which cannot use USE_FORT and thus usesonly USE_SSP by default. Tested on i386 with no ill results; USE_FORT=noper-directory or in a system build will disable if desired. List of files: /netbsd-src/usr.sbin/inetd/Makefile

7157011597d7c4594e582408c37eb35fb4c591b4 - Only compile in IPv6 support if ${USE_INET6} != "no"

Mon, 10 Jan 2005 02:58:58 +0000

Only compile in IPv6 support if ${USE_INET6} != "no"MKINET6 is for providing IPv6 infrastructure.USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6). List of files: /netbsd-src/usr.sbin/inetd/Makefile

f559c099895f0d939aaf53712db33737889a1652 - __ss_{len,family} #define hack is no longer necessary

Mon, 19 Nov 2001 03:18:28 +0000

__ss_{len,family} #define hack is no longer necessary List of files: /netbsd-src/usr.sbin/inetd/Makefile

de3a065dccab22754a20fd778cc6fe346d9061de - CPPFLAGS, not CFLAGS, for -D.

Thu, 13 Sep 2001 13:02:20 +0000

CPPFLAGS, not CFLAGS, for -D. List of files: /netbsd-src/usr.sbin/inetd/Makefile

4b061adfdb3f1366913fb9ee935a31dfeab2dc55 - sync with latest libipsec.

Mon, 31 Jan 2000 14:28:17 +0000

sync with latest libipsec.since outgoing and incoming policy is separated, inetd can take multiplepolicy specification, separated by ";". List of files: /netbsd-src/usr.sbin/inetd/Makefile

a77871b871312ae2c93f5a0ebb7597e2306fedff - dual-stack inetd. you can write "tcp6" or "tcp4" into "protocol" field.

Fri, 02 Jul 1999 04:48:19 +0000

dual-stack inetd. you can write "tcp6" or "tcp4" into "protocol" field.(the style is the rough consensus among v6 implementers so it will bethe standard style)TODO: test rpc and tcpmux on IPv6.TODO: test identd over IPv6. List of files: /netbsd-src/usr.sbin/inetd/Makefile

78688ba793b97ce997f3738d5db9691bf523768b - Use pidfile(3).

Sun, 06 Jun 1999 01:50:23 +0000

Use pidfile(3). List of files: /netbsd-src/usr.sbin/inetd/Makefile

0a94f4f07799cd2ae10e7ee3d8ccd3b9af1412e8 - use CPPFLAGS instead of CFLAGS

Sat, 25 Oct 1997 06:57:53 +0000

use CPPFLAGS instead of CFLAGS List of files: /netbsd-src/usr.sbin/inetd/Makefile

f5bf267d9096d2679cea06dfdac5978207559056 - enable WARNS=1 by default, but disable in unclean 3rd party code

Sat, 18 Oct 1997 06:42:25 +0000

enable WARNS=1 by default, but disable in unclean 3rd party code List of files: /netbsd-src/usr.sbin/inetd/Makefile