en Copyright 2015 Java http://src.rcs.uwaterloo.ca:8080/source/history/netbsd-src/tools/elftoolchain/libelf/Makefile#ad49149131b7552cf1c4fc41370cc055d9b4a80e elftoolchain: Be consistent about which ELF header files we use.1. For tools that use elftoolchain: always use elftoolchain's elfdefinitions.h. Don't even think about looking at the host's sys/exec_elf.h, which makes no sense and should never happen. (ELF tools that don't use elftoolchain, like m68k-elf2coff, continue to use nbincludes/sys/exec_elf.h. But no more nbincludes hacks in elftoolchain.)2. For kernel components (solaris, zfs, dtrace): always use sys/exec_elf.h, even in Solaris components via sys/elf.h. elfdefinitions.h is not wired up in the kernel build at all.3. For most userland components that involve libelf: use elfdefinitions.h via libelf header files (libelf.h, gelf.h). libdtrace in particular requires _all_ R_* reloc type definitions, but sys/exec_elf.h brings in only the _current machine's_ R_* reloc type definitions. (While here: Use uintptr_t instead of Elf_Addr for pointer-to-integer cast, since Elf_Addr is MD and provided only by sys/exec_elf.h, not by elfdefinitions.h.) And most userland components using libelf don't rely on any properties of the current machine from sys/exec_elf.h, so they can use libelf's elfdefinition.h. Exceptions: - dtrace drti.c relies on link.h -> link_elf.h -> sys/exec_elf.h, but it also relies on sys/dtrace.h -> sys/elf.h -> elfdefinitions.h like other userland components using sys/elf.h. - kdump-ioctl.c uses sys/exec_elf.h directly and sys/dtrace.h -> sys/elf.h -> elfdefinitions like other userland components using sys/elf.h. - t_ptrace_wait.c (via t_ptrace_core_wait.h) uses libelf to parse core files, but relies on sys/exec_elf.h for struct netbsd_elfcore_procinfo. None of these exceptions needs all R_* reloc type definitions, so as a workaround, we can just suppress libelf's elfdefinitions.h by defining _SYS_ELFDEFINITIONS_H_ and use sys/exec_elf.h in these exceptions.And undo the whole BUILTIN_ELF_HEADERS mistake. This was:- half bogus workarounds for missing build_install dependencies in tools/Makefile, which are no longer missing now, and- half futile attempt to use src/sys/sys/exec_elf.h via nbincludes in tools involving libelf instead of libelf's elfdefinitions.h, which collides.Longer-term, we may wish to unify sys/exec_elf.h and libelf'selfdefinitions.h, so we don't have to play these games.But at least now the games are limited to three .c files (one ofwhich is generated by Makefile.ioctl-c), rather than haphazardlyapplied tree-wide by monstrous kludges in widely used .h files withbroken hackarounds to get the tools build lurching to completion. List of files: /netbsd-src/tools/elftoolchain/libelf/Makefile Mon, 01 Apr 2024 18:33:22 +0000 riastradh <riastradh@NetBSD.org> http://src.rcs.uwaterloo.ca:8080/source/history/netbsd-src/tools/elftoolchain/libelf/Makefile#345cf9fb81bd0411c53e25d62cd93bdcaa865312 changes for r4037 List of files: /netbsd-src/tools/elftoolchain/libelf/Makefile Sun, 03 Mar 2024 17:37:58 +0000 christos <christos@NetBSD.org> http://src.rcs.uwaterloo.ca:8080/source/history/netbsd-src/tools/elftoolchain/libelf/Makefile#2718af68c3efc72c9769069b5c7f9ed36f6b9def Build 'libelf' and 'libdwarf' under 'tools/elftoolchain', after'tools/elftoolchain/common' has been built.This change aligns the 'tools' build with the regular build.Subsequent commits will change 'tools/libctf' and'tools/cft{merge,convert}' to use the new build paths. List of files: /netbsd-src/tools/elftoolchain/libelf/Makefile Mon, 18 Apr 2022 14:11:43 +0000 jkoshy <jkoshy@NetBSD.org>