Changes in debuginfo.ll

094572701dce4aaf36f4521d6cf750420d39f206 - [RemoveDIs] Print IR with debug records by default (#91724)

Fri, 14 Jun 2024 14:07:27 +0000

[RemoveDIs] Print IR with debug records by default (#91724)This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single one that tests for uses or declarations of debug intrinsics and does not explicitly disable writing records. If this patch has broken your downstream tests (or upstream tests on a configuration I wasn't able to run): 1. If you need to immediately unblock a build, pass `--write-experimental-debuginfo=false` to LLVM's option processing for all failing tests (remember to use `-mllvm` for clang/flang to forward arguments to LLVM). 2. For most test failures, the changes are trivial and mechanical, enough that they can be done by script; see the migration guide for a guide on how to do this: https://llvm.org/docs/RemoveDIsDebugInfo.html#test-updates 3. If any tests fail for reasons other than FileCheck check lines that need updating, such as assertion failures, that is most likely a real bug with this patch and should be reported as such. For more information, see the recent PSA: https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

d2d9dc8eb4126271ee1406c2586a4953db831d21 - [DebugInfo][RemoveDIs] Make debugify pass convert to/from RemoveDIs mode (#73251)

Wed, 29 Nov 2023 13:19:50 +0000

[DebugInfo][RemoveDIs] Make debugify pass convert to/from RemoveDIs mode (#73251)Debugify is extremely useful as a testing and debugging tool, and a good number of LLVM-IR transform tests use it. We need it to support "new" non-instruction debug-info to get test coverage, but it's not important enough to completely convert right now (and it'd be a large undertaking). Thus: convert to/from dbg.value/DPValue mode on entry and exit of the pass, which gives us the functionality without any further work. The cost is compile-time, but again this is only happening during tests. Tested by: the large set of debugify tests enabled here. Note the InstCombine test (cast-mul-select.ll) that hasn't been fully enabled: this is because there's a debug-info sinking piece of code there that hasn't been instrumented. List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

211cf8a384ebb29787367c8fd5858e2a5ed3c10f - [test] Use -passes in more Transforms tests

Thu, 20 Oct 2022 22:04:16 +0000

[test] Use -passes in more Transforms testsAnother step towards getting rid of dependencies to the legacypass manager.Primary change here is to just do -passes=foo instead of -foo insimple situations (when running a single transform pass). But alsoupdated a few test running multiple passes.Also removed some "duplicated" RUN lines in a few tests that whereusing both -foo and -passes=foo syntax. No need to do the same kindof testing twice. List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

f3a928e2334a4e8e3f09406f2ce7e1cbac520f95 - [opt] Don't translate legacy -analysis flag to require

Fri, 07 Oct 2022 20:12:59 +0000

[opt] Don't translate legacy -analysis flag to requireTests relying on this should explicitly use -passes='require,foo'. List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

c603cefbda1300983e81da545a307572fdb79d1e - [DSE] Convert tests to opaque pointers (NFC)

Wed, 05 Oct 2022 13:28:15 +0000

[DSE] Convert tests to opaque pointers (NFC)Using https://gist.github.com/nikic/98357b71fd67756b0f064c9517b62a34. List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

176bbcae1113fbb4f34d2b79eab35b086a9f2a8e - [DSE] Remove MemDep-based implementation

Wed, 03 Mar 2021 19:38:50 +0000

[DSE] Remove MemDep-based implementationThe MemorySSA-based implementation has been enabled without issuefor a while now, so keeping the old implementation around doesn'tseem useful anymore. This drops the MemDep-based implementation.Differential Revision: https://reviews.llvm.org/D97877 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

339eed5d0b18c627faa5368fde003dc46be66b46 - [NewPM][BasicAA] basicaa -> basic-aa in Transforms/DeadStoreElimination

Fri, 26 Jun 2020 22:06:47 +0000

[NewPM][BasicAA] basicaa -> basic-aa in Transforms/DeadStoreEliminationSummary: Following https://reviews.llvm.org/D82607.Reviewers: ychenSubscribers: george.burgess.iv, asbirlea, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D82689 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

cee313d288a4faf0355d76fb6e0e927e211d08a5 - Revert "Temporarily Revert "Add basic loop fusion pass.""

Wed, 17 Apr 2019 04:52:47 +0000

Revert "Temporarily Revert "Add basic loop fusion pass.""The reversion apparently deleted the test/Transforms directory.Will be re-reverting again.llvm-svn: 358552 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

b33a5c7347fce57f58ce5f0dbb086a11caa5220f - [DebugInfo] Don't salvage load operations (PR40628).

Tue, 12 Feb 2019 10:54:30 +0000

[DebugInfo] Don't salvage load operations (PR40628).Salvaging a redundant load instruction into a debug expression hides amemory read from optimisation passes. Passes that alter memory behaviour(such as LICM promoting memory to a register) aren't aware of these debugmemory reads and leave them unaltered, making the debug variable locationpoint somewhere unsafe.Teaching passes to know about these debug memory reads would be challengingand probably incomplete. Finding dbg.value instructions that need to be fixedwould likely be computationally expensive too, as more analysis would berequired. It's better to not generate debug-memory-reads instead, alas.Changed tests: * DeadStoreElim: test for salvaging of intermediate operations contributing to the dead store, instead of salvaging of the redundant load, * GVN: remove debuginfo behaviour checks completely, this behaviour is still covered by other tests, * InstCombine: don't test for salvaged loads, we're removing that behaviour.Differential Revision: https://reviews.llvm.org/D57962llvm-svn: 353824 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

6d354ed72e6e10b73c6a1d8481129a153434cdb4 - [Debugify] Move debug value intrinsics closer to their operand defs

Wed, 06 Jun 2018 19:05:42 +0000

[Debugify] Move debug value intrinsics closer to their operand defsBefore this patch, debugify would insert debug value intrinsics before theterminating instruction in a block. This had the advantage of being simple,but was a bit too simple/unrealistic.This patch teaches debugify to insert debug values immediately after theiroperand defs. This enables better testing of the compiler.For example, with this patch, `opt -debugify-each` is able to identify avectorizer DI-invariance bug fixed in llvm.org/PR32761. In this bug, thevectorizer produced different output with/without debug info present.Reverting Davide's bugfix locally, I see:$ ~/scripts/opt-check-dbg-invar.sh ./bin/opt \ .../SLPVectorizer/AArch64/spillcost-di.ll -slp-vectorizerComparing: -slp-vectorizer .../SLPVectorizer/AArch64/spillcost-di.ll Baseline: /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.iYYeL1kf With DI : /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.sQtQSeet9,11c9,11< %5 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1< %6 = bitcast i64* %4 to <2 x i64>*< %7 = load <2 x i64>, <2 x i64>* %6, align 8, !tbaa !0---> %5 = load i64, i64* %4, align 8, !tbaa !0> %6 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1> %7 = load i64, i64* %6, align 8, !tbaa !512a13> store i64 %5, i64* %8, align 8, !tbaa !014,15c15< %10 = bitcast i64* %8 to <2 x i64>*< store <2 x i64> %7, <2 x i64>* %10, align 8, !tbaa !0---> store i64 %7, i64* %9, align 8, !tbaa !5:: Found a test case ^Running this over the *.ll files in tree, I found four additional exampleswhich compile differently with/without DI present. I plan on filing bugs forthese.llvm-svn: 334118 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

4872535eb9573efb6b08a205458c845a988b74e2 - [Debugify] Set a DI version module flag for llc compatibility

Thu, 24 May 2018 23:00:23 +0000

[Debugify] Set a DI version module flag for llc compatibilitySetting the "Debug Info Version" module flag makes it possible to pipesynthetic debug info into llc, which is useful for testing backends.llvm-svn: 333237 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll

35fc103e1e8d1f069d7a5ada7131466c3402c265 - [DeadStoreElimination] Salvage debug info from dead insts

Tue, 13 Feb 2018 18:15:26 +0000

[DeadStoreElimination] Salvage debug info from dead instsAccording to `llvm-dwarfdump --statistics` this salvages 43 additionalunique source variables in a stage2 build of clang. It increases thesize of the .debug_loc section by 0.002% (or 2864 bytes).Differential Revision: https://reviews.llvm.org/D43220llvm-svn: 325035 List of files: /llvm-project/llvm/test/Transforms/DeadStoreElimination/debuginfo.ll