Changes in Watchpoint.cpp

b99d4112585302cbd01f9b851a04adc6e4fb5218 - [lldb-dap] Refactoring breakpoints to not use the `g_dap` reference. (#115208)

Fri, 08 Nov 2024 21:36:25 +0000

[lldb-dap] Refactoring breakpoints to not use the `g_dap` reference. (#115208)Refactoring breakpoints to not use the `g_dap` reference. Instead, when a breakpoint is constructed it will be passed a DAP reference that it should use for its lifetime. This is part of a larger refactor to remove the global `g_dap` variable to allow us to create multiple DAP instances. --------- Co-authored-by: Pavel Labath List of files: /llvm-project/lldb/tools/lldb-vscode/Watchpoint.cpp

2cacc7a61095577ff42177373d46c8cb8df0cb1f - [lldb-dap] Deduplicate watchpoints starting at the same address on SetDataBreakpointsRequest. (#83192)

Wed, 28 Feb 2024 19:56:55 +0000

[lldb-dap] Deduplicate watchpoints starting at the same address on SetDataBreakpointsRequest. (#83192)If a SetDataBreakpointsRequest contains a list data breakpoints which have duplicate starting addresses, the current behaviour is returning `{verified: true}` to both watchpoints with duplicated starting addresses. This confuses the client and what actually happens in lldb is the second one overwrite the first one. This fixes it by letting the last watchpoint at given address have `{verified: true}` and all previous watchpoints at the same address should have `{verfied: false}` at response. List of files: /llvm-project/lldb/tools/lldb-vscode/Watchpoint.cpp

df6f756a19277d936ec83f7cebc2501327ac3add - Re-land [lldb-dap] Add support for data breakpoint. (#81909)

Thu, 22 Feb 2024 21:11:40 +0000

Re-land [lldb-dap] Add support for data breakpoint. (#81909)This implements functionality to handle DataBreakpointInfo request and SetDataBreakpoints request. Previous commit https://github.com/llvm/llvm-project/commit/8c56e78ec531f0e2460213c20fff869b6b7add99 was reverted because setting 1 byte watchpoint failed in the new test on ARM64. So, I changed the test to setting 4 byte watchpoint instead, and hope this won't break it again. It also adds the fixes from https://github.com/llvm/llvm-project/pull/81680. List of files: /llvm-project/lldb/tools/lldb-vscode/Watchpoint.cpp

8c56e78ec531f0e2460213c20fff869b6b7add99 - [lldb-dap] Add support for data breakpoint. (#81541)

Tue, 13 Feb 2024 21:38:56 +0000

[lldb-dap] Add support for data breakpoint. (#81541)This implements functionality to handle `DataBreakpointInfo` request and `SetDataBreakpoints` request. If variablesReference is 0 or not provided, interpret name as ${number of bytes}@${expression} to set data breakpoint at the given expression because the spec https://microsoft.github.io/debug-adapter-protocol/specification#Requests_DataBreakpointInfo doesn't say how the client could specify the number of bytes to watch. This is based on top of https://github.com/llvm/llvm-project/pull/80753. List of files: /llvm-project/lldb/tools/lldb-vscode/Watchpoint.cpp