Changes in RunInTerminal.cpp

09c258ef6a2fcca2161488b214d53ef39891fa22 - [NFC][lldb-dap] Clean-up includes (#113839)

Mon, 28 Oct 2024 10:01:57 +0000

[NFC][lldb-dap] Clean-up includes (#113839)This commit cleans up the includes in the `lldb-dap` subfolder. The main motivation was that I got annoyed by `clangd` always complaining about unused includes while working on lldb-dap. List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

1da3a795fcf61a2c931d9320738db7d5c0444ce2 - JSON: llvm::Optional => std::optional

Fri, 16 Dec 2022 07:56:52 +0000

JSON: llvm::Optional => std::optionalMany files are from language servers.https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

01263c6c6fb495a94fe0ccbb1420bb1ec8460748 - [lldb] Rename lldb-vscode to lldb-dap (#69264)

Thu, 19 Oct 2023 16:48:54 +0000

[lldb] Rename lldb-vscode to lldb-dap (#69264)Rename lldb-vscode to lldb-dap. This change is largely mechanical. The following substitutions cover the majority of the changes in this commit: s/VSCODE/DAP/ s/VSCode/DAP/ s/vscode/dap/ s/g_vsc/g_dap/ Discourse RFC: https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/ List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

36496cc2992d6fa26e6024971efcfc7d15f69888 - [lldb-vscode] correctly use Windows macros

Thu, 04 Feb 2021 18:07:07 +0000

[lldb-vscode] correctly use Windows macros@mstorsjo found a mistake that I made when trying to fix some Windowscompilation errors encountered by @stella.stamenova.I was incorrectly using the LLVM_ON_UNIX macro. In any case, proper useof #if defined(_WIN32)should be the actual fix.Differential Revision: https://reviews.llvm.org/D96060 List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e - Fix lldb-vscode builds on Windows targeting POSIX

Thu, 28 Jan 2021 17:24:30 +0000

Fix lldb-vscode builds on Windows targeting POSIX@stella.stamenova found out that lldb-vscode's Win32 macros were failingwhen building on windows targetings POSIX platforms.I'm changing these macros for LLVM_ON_UNIX, which should be moreaccurate. List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

1ac36b34db81d2fccd2b4a98d497be62083de3b1 - Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6

Mon, 25 Jan 2021 22:05:04 +0000

Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6This fails on Windows because std::future fail to compile.Now switching to SBError as a workaround.Failed buildbot: http://lab.llvm.org:8011/#/builders/83/builds/3021 List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp

0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 - [vscode] Improve runInTerminal and support linux

Mon, 28 Dec 2020 20:00:47 +0000

[vscode] Improve runInTerminal and support linuxDepends on D93874.runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the debuggee:- it gets to know of the target late, which renders breakpoints in the main function almost impossible- polling might fail if there are already other processes with the same name- polling might also fail on some linux machine, as it's implemented with the ps command, and the ps command's args and output are not standard everywhereAs a better way to implement this so that it works well on Darwin and Linux, I'm using now the following process:- lldb-vscode notices the runInTerminal, so it spawns lldb-vscode with a special flag --launch-target . This flags tells lldb-vscode to wait to be attached and then it execs the target program. I'm using lldb-vscode itself to do this, because it makes finding the launcher program easier. Also no CMAKE INSTALL scripts are needed.- Besides this, the debugger creates a temporary FIFO file where the launcher program will write its pid to. That way the debugger will be sure of which program to attach.- Once attach happend, the debugger creates a second temporary file to notify the launcher program that it has been attached, so that it can then exec. I'm using this instead of using a signal or a similar mechanism because I don't want the launcher program to wait indefinitely to be attached in case the debugger crashed. That would pollute the process list with a lot of hanging processes. Instead, I'm setting a 20 seconds timeout (that's an overkill) and the launcher program seeks in intervals the second tepmorary file.Some notes:- I preferred not to use sockets because it requires a lot of code and I only need a pid. It would also require a lot of code when windows support is implemented.- I didn't add Windows support, as I don't have a windows machine, but adding support for it should be easy, as the FIFO file can be implemented with a named pipe, which is standard on Windows and works pretty much the same way.The existing test which didn't pass on Linux, now passes.Differential Revision: https://reviews.llvm.org/D93951 List of files: /llvm-project/lldb/tools/lldb-vscode/RunInTerminal.cpp