Changes in LLDBUtils.cpp

22561cfb443267905d4190f0e2a738e6b412457f - Revert "[lldb] Implement basic support for reverse-continue" (#123906)

Wed, 22 Jan 2025 08:43:11 +0000

Revert "[lldb] Implement basic support for reverse-continue" (#123906)Reverts llvm/llvm-project#112079 due to failures on the arm bot. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

b7b9ccf44988edf49886743ae5c3cf4184db211f - [lldb] Implement basic support for reverse-continue (#112079)

Wed, 22 Jan 2025 07:37:17 +0000

[lldb] Implement basic support for reverse-continue (#112079)This commit adds support for a`SBProcess::ContinueInDirection()` API. A user-accessible command forthis will follow in a later commit.This feature depends on a gdbserver implementation (e.g. `rr`) providingsupport for the `bc` and `bs` packets. `lldb-server` does not supportthose packets, and there is no plan to change that. For testingpurposes, this commit adds a Python implementation of *very limited*record-and-reverse-execute functionality, implemented as a proxy betweenlldb and lldb-server in `lldbreverse.py`. This should not (and inpractice cannot) be used for anything except testing.The tests here are quite minimal but we test that simple breakpoints andwatchpoints work as expected during reverse execution, and thatconditional breakpoints and watchpoints work when the condition calls afunction that must be executed in the forward direction. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

e5ba11727437456fbab7ce733c07843bf682fa0c - [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (#115933)

Tue, 12 Nov 2024 21:19:17 +0000

[lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (#115933)This refactor removes g_dap references from lldb-dap/LLDBUtils.{h,cpp} to allow us to create more than one g_dap instance in the future. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

09c258ef6a2fcca2161488b214d53ef39891fa22 - [NFC][lldb-dap] Clean-up includes (#113839)

Mon, 28 Oct 2024 10:01:57 +0000

[NFC][lldb-dap] Clean-up includes (#113839)This commit cleans up the includes in the `lldb-dap` subfolder. The main motivation was that I got annoyed by `clangd` always complaining about unused includes while working on lldb-dap. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

3bef742559f1556569423ec63c70b97dff1d426e - Revert "[lldb] Implement basic support for reverse-continue (#99736)"

Thu, 10 Oct 2024 23:22:24 +0000

Revert "[lldb] Implement basic support for reverse-continue (#99736)"Reverting this again; I added a commit which added @skipIfDarwinmarkers to the TestReverseContinueBreakpoints.py andTestReverseContinueNotSupported.py API tests, which use lldb-serverin gdbserver mode which does not work on Darwin. But the aarch64 ubuntubot reported a failure on TestReverseContinueBreakpoints.py,https://lab.llvm.org/buildbot/#/builders/59/builds/6397 File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 63, in test_reverse_continue_skip_breakpoint self.reverse_continue_skip_breakpoint_internal(async_mode=False) File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 81, in reverse_continue_skip_breakpoint_internal self.expect( File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2372, in expect self.runCmd( File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1002, in runCmd self.assertTrue(self.res.Succeeded(), msg + output)AssertionError: False is not true : Process should be stopped due to history boundaryError output:error: Process must be launched.This reverts commit 4f297566b3150097de26c6a23a987d2bd5fc19c5. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

4f297566b3150097de26c6a23a987d2bd5fc19c5 - [lldb] Implement basic support for reverse-continue (#99736)

Thu, 10 Oct 2024 20:01:47 +0000

[lldb] Implement basic support for reverse-continue (#99736)This commit only adds support for the `SBProcess::ReverseContinue()` API. A user-accessible command for this will follow in a later commit. This feature depends on a gdbserver implementation (e.g. `rr`) providing support for the `bc` and `bs` packets. `lldb-server` does not support those packets, and there is no plan to change that. So, for testing purposes, `lldbreverse.py` wraps `lldb-server` with a Python implementation of *very limited* record-and-replay functionality for use by *tests only*. The majority of this PR is test infrastructure (about 700 of the 950 lines added). List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9 - Revert "[lldb] Implement basic support for reverse-continue (#99736)"

Thu, 10 Oct 2024 22:01:20 +0000

Revert "[lldb] Implement basic support for reverse-continue (#99736)"This reverts commit d5e1de6da96c1ab3b8cae68447e8ed3696a7006e. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

d5e1de6da96c1ab3b8cae68447e8ed3696a7006e - [lldb] Implement basic support for reverse-continue (#99736)

Thu, 10 Oct 2024 20:01:47 +0000

d4c17891126a79ae49237a7de0f9948aeedcd177 - Make env and source map dictionaries #95137 (#106919)

Mon, 07 Oct 2024 16:38:36 +0000

Make env and source map dictionaries #95137 (#106919)Fixes #95137 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

2011cbcd84102236dd6d58e2079ac676a3403f25 - [lldb-dap] Add feature to remember last non-empty expression. (#107485)

Fri, 20 Sep 2024 21:04:44 +0000

[lldb-dap] Add feature to remember last non-empty expression. (#107485)Update lldb-dap so if the user just presses return, which sends an empty expression, it re-evaluates the most recent non-empty expression/command. Also udpated test to test this case. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

d7796855b87911b8ae6c726ab5df4949f173dbd2 - [lldb] Nits on uses of llvm::raw_string_ostream (NFC) (#108745)

Mon, 16 Sep 2024 04:26:51 +0000

[lldb] Nits on uses of llvm::raw_string_ostream (NFC) (#108745)As specified in the docs, 1) raw_string_ostream is always unbuffered and 2) the underlying buffer may be used directly ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) * Don't call raw_string_ostream::flush(), which is essentially a no-op. * Avoid unneeded calls to raw_string_ostream::str(), to avoid excess indirection. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

f838fa820f9271008617c345c477122d9e29a05c - New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (#90930)

Tue, 06 Aug 2024 00:26:39 +0000

New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (#90930)This PR introduces a new `ThreadPlanSingleThreadTimeout` that will be used to address potential deadlock during single-thread stepping. While debugging a target with a non-trivial number of threads (around 5000 threads in one example target), we noticed that a simple step over can take as long as 10 seconds. Enabling single-thread stepping mode significantly reduces the stepping time to around 3 seconds. However, this can introduce deadlock if we try to step over a method that depends on other threads to release a lock. To address this issue, we introduce a new `ThreadPlanSingleThreadTimeout` that can be controlled by the `target.process.thread.single-thread-plan-timeout` setting during single-thread stepping mode. The concept involves counting the elapsed time since the last internal stop to detect overall stepping progress. Once a timeout occurs, we assume the target is not making progress due to a potential deadlock, as mentioned above. We then send a new async interrupt, resume all threads, and `ThreadPlanSingleThreadTimeout` completes its task. To support this design, the major changes made in this PR are: 1. `ThreadPlanSingleThreadTimeout` is popped during every internal stop and reset (re-pushed) to the top of the stack (as a leaf node) during resume. This is achieved by always returning `true` from `ThreadPlanSingleThreadTimeout::DoPlanExplainsStop()` and `ThreadPlanSingleThreadTimeout::MischiefManaged()`. 2. A new thread-specific async interrupt stop is introduced, which can be detected/consumed by `ThreadPlanSingleThreadTimeout`. 3. The clearing of branch breakpoints in the range thread plan has been moved from `DoPlanExplainsStop()` to `ShouldStop()`, as it is not guaranteed that it will be called. The detailed design is discussed in the RFC below: [https://discourse.llvm.org/t/improve-single-thread-stepping/74599](https://discourse.llvm.org/t/improve-single-thread-stepping/74599) --------- Co-authored-by: jeffreytan81 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

e427e934f677567f8184ff900cb4cbdb8cf21a21 - [lldb][dap] Avoid concurrent `HandleCommand` calls (#83162)

Tue, 27 Feb 2024 18:43:05 +0000

[lldb][dap] Avoid concurrent `HandleCommand` calls (#83162)The `EventThreadFunction` can end up calling `HandleCommand` concurrently with the main request processing thread. The underlying API does not appear to be thread safe, so add a narrowly scoped mutex lock to prevent calling it in this place from more than one thread. Fixes #81686. Prior to this, TestDAP_launch.py is 4% flaky. After, it passes in 1000 runs. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

aa207674f9e6caf5bc29c1b4925183a398382d6f - [lldb-dap] Implement command directives (#74808)

Thu, 14 Dec 2023 20:04:35 +0000

[lldb-dap] Implement command directives (#74808)This adds support for optionally prefixing any command with `?` and/or `!`. - `?` prevents the output of a commands to be printed to the console unless it fails. - `!` aborts the dap if the command fails. They come in handy when programmatically running commands on behalf of the user without wanting them to know unless they fail, or when a critical setup is required as part of launchCommands and it's better to abort on failures than to silently skip. List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

01263c6c6fb495a94fe0ccbb1420bb1ec8460748 - [lldb] Rename lldb-vscode to lldb-dap (#69264)

Thu, 19 Oct 2023 16:48:54 +0000

[lldb] Rename lldb-vscode to lldb-dap (#69264)Rename lldb-vscode to lldb-dap. This change is largely mechanical. The following substitutions cover the majority of the changes in this commit: s/VSCODE/DAP/ s/VSCode/DAP/ s/vscode/dap/ s/g_vsc/g_dap/ Discourse RFC: https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/ List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

ca849352936dadadd232cf9ec74ac006ce410f51 - Fix lldb-vscode frame id integer overflow

Wed, 26 Jul 2023 19:28:57 +0000

Fix lldb-vscode frame id integer overflowThis patch fixes a 32bit integer overflow in lldb-vscode.The current implementation of frame_id does `(thread_index << 19 | frame_index)`. Since thread_index is a 32 bit integer this leaves only 32 - 19 == 13 bits available for the thread_index. As a result, lldb-vscode can only handle 2^13 == 8192 threads. Normally, this would be sufficient, but we have seen crazy process having +12000 threads, causing the frame_id algorithm above to integer overflow during casting.The patch fixes the overflow by up casting to 64 bit integer first before bit shifiting.Differential Revision: https://reviews.llvm.org/D156375 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

6c37984ebaf4ee01df6a9b3f78e45f70dcd6fb33 - [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

Mon, 29 Mar 2021 15:05:30 +0000

[lldb] [gdb-remote server] Introduce new stop reasons for fork and vforkIntroduce three new stop reasons for fork, vfork and vforkdone events.This includes server support for serializing fork/vfork events intogdb-remote protocol. The stop infos for the two base events take a pairof PID and TID for the newly forked process.Differential Revision: https://reviews.llvm.org/D100196 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

0b69756110db444282c40ea16929186b2910c3b1 - [trace][intel-pt] Implement trace start and trace stop

Mon, 09 Nov 2020 21:36:26 +0000

[trace][intel-pt] Implement trace start and trace stopThis implements the interactive trace start and stop methods.This diff ended up being much larger than I anticipated because, by doing it, I found that I had implemented in the beginning many things in a non optimal way. In any case, the code is much better now.There's a lot of boilerplate code due to the gdb-remote protocol, but the main changes are:- New tracing packets: jLLDBTraceStop, jLLDBTraceStart, jLLDBTraceGetBinaryData. The gdb-remote packet definitions are quite comprehensive.- Implementation of the "process trace start|stop" and "thread trace start|stop" commands.- Implementaiton of an API in Trace.h to interact with live traces.- Created an IntelPTDecoder for live threads, that use the debugger's stop id as checkpoint for its internal cache.- Added a functionality to stop the process in case "process tracing" is enabled and a new thread can't traced.- Added testsI have some ideas to unify the code paths for post mortem and live threads, but I'll do that in another diff.Differential Revision: https://reviews.llvm.org/D91679 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

9cb227f561f4e5491840694580abbe7c0123b358 - Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

Wed, 29 Jan 2020 22:11:40 +0000

Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.Summary: The VS Code DAP expects on response for each breakpoint that was requested. If we responsd with multiple entries for one breakpoint the VS Code UI gets out of date. Currently the VS code DAP doesn't handle one breakpoint with multiple locations. If this ever gets fixed we can modify our code.Reviewers: labathSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73665 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp

2946cd701067404b99c39fb29dc9c74bd7193eb3 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project/lldb/tools/lldb-vscode/LLDBUtils.cpp