Changes in FifoFiles.cpp

09c258ef6a2fcca2161488b214d53ef39891fa22 - [NFC][lldb-dap] Clean-up includes (#113839)

Mon, 28 Oct 2024 10:01:57 +0000

[NFC][lldb-dap] Clean-up includes (#113839)This commit cleans up the includes in the `lldb-dap` subfolder. The main motivation was that I got annoyed by `clangd` always complaining about unused includes while working on lldb-dap. List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

01263c6c6fb495a94fe0ccbb1420bb1ec8460748 - [lldb] Rename lldb-vscode to lldb-dap (#69264)

Thu, 19 Oct 2023 16:48:54 +0000

[lldb] Rename lldb-vscode to lldb-dap (#69264)Rename lldb-vscode to lldb-dap. This change is largely mechanical. The following substitutions cover the majority of the changes in this commit: s/VSCODE/DAP/ s/VSCode/DAP/ s/vscode/dap/ s/g_vsc/g_dap/ Discourse RFC: https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/ List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

2fe8327406050d2585d2ced910a678e28caefcf5 - [lldb] Use std::optional instead of llvm::Optional (NFC)

Sat, 07 Jan 2023 22:18:35 +0000

[lldb] Use std::optional instead of llvm::Optional (NFC)This patch replaces (llvm::|)Optional< with std::optional<. I'll posta separate patch to clean up the "using" declarations, #include"llvm/ADT/Optional.h", etc.This is part of an effort to migrate from llvm::Optional tostd::optional:https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

f190ce625ab0dc5a5e2b2515e6d26debb34843ab - [lldb] Add #include (NFC)

Sat, 07 Jan 2023 21:43:00 +0000

[lldb] Add #include (NFC)This patch adds #include to those files containingllvm::Optional<...> or Optional<...>.I'll post a separate patch to actually replace llvm::Optional withstd::optional.This is part of an effort to migrate from llvm::Optional tostd::optional:https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

5a197772ee3077e7bfa2eb3d047d4f36a28b0f39 - [LLDB][NFC] Suppress spurious static inspection warnings

Tue, 16 Aug 2022 21:09:46 +0000

[LLDB][NFC] Suppress spurious static inspection warningsSuppress coverity false positives.This diff contains comments only, including the hints for Coverity static code inspectionto suppress the warning originating at the next line after the comment.Differential Revision: https://reviews.llvm.org/D131998 List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

d66cbc565adbea8b7362349e527ac7aa2c75788f - Don't use Optional::hasValue (NFC)

Tue, 21 Jun 2022 03:26:05 +0000

Don't use Optional::hasValue (NFC) List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

36496cc2992d6fa26e6024971efcfc7d15f69888 - [lldb-vscode] correctly use Windows macros

Thu, 04 Feb 2021 18:07:07 +0000

[lldb-vscode] correctly use Windows macros@mstorsjo found a mistake that I made when trying to fix some Windowscompilation errors encountered by @stella.stamenova.I was incorrectly using the LLVM_ON_UNIX macro. In any case, proper useof #if defined(_WIN32)should be the actual fix.Differential Revision: https://reviews.llvm.org/D96060 List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

11e74e512d64ae2a2531156b6f0dde211b1ae19d - [lldb] Remove a stray semicolon, fixing GCC warnings. NFC.

Mon, 01 Feb 2021 11:45:07 +0000

[lldb] Remove a stray semicolon, fixing GCC warnings. NFC. List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

ab5591e1d8f5abcfa9e75193d3e8a29087b61425 - Fix runInTerminal failures on Windows

Wed, 27 Jan 2021 21:02:45 +0000

Fix runInTerminal failures on Windowsstella.stemenova mentioned in https://reviews.llvm.org/D93951 failures on Windows for this test.I'm fixing the macro definitions and disabling the tests for pythonversions lower than 3.7. I'll figure out that actual issue withpython3.6 after the buildbots are fine again. List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp

0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 - [vscode] Improve runInTerminal and support linux

Mon, 28 Dec 2020 20:00:47 +0000

[vscode] Improve runInTerminal and support linuxDepends on D93874.runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the debuggee:- it gets to know of the target late, which renders breakpoints in the main function almost impossible- polling might fail if there are already other processes with the same name- polling might also fail on some linux machine, as it's implemented with the ps command, and the ps command's args and output are not standard everywhereAs a better way to implement this so that it works well on Darwin and Linux, I'm using now the following process:- lldb-vscode notices the runInTerminal, so it spawns lldb-vscode with a special flag --launch-target . This flags tells lldb-vscode to wait to be attached and then it execs the target program. I'm using lldb-vscode itself to do this, because it makes finding the launcher program easier. Also no CMAKE INSTALL scripts are needed.- Besides this, the debugger creates a temporary FIFO file where the launcher program will write its pid to. That way the debugger will be sure of which program to attach.- Once attach happend, the debugger creates a second temporary file to notify the launcher program that it has been attached, so that it can then exec. I'm using this instead of using a signal or a similar mechanism because I don't want the launcher program to wait indefinitely to be attached in case the debugger crashed. That would pollute the process list with a lot of hanging processes. Instead, I'm setting a 20 seconds timeout (that's an overkill) and the launcher program seeks in intervals the second tepmorary file.Some notes:- I preferred not to use sockets because it requires a lot of code and I only need a pid. It would also require a lot of code when windows support is implemented.- I didn't add Windows support, as I don't have a windows machine, but adding support for it should be easy, as the FIFO file can be implemented with a named pipe, which is standard on Windows and works pretty much the same way.The existing test which didn't pass on Linux, now passes.Differential Revision: https://reviews.llvm.org/D93951 List of files: /llvm-project/lldb/tools/lldb-vscode/FifoFiles.cpp