Changes in TestCallThatThrows.py

fd35a92300a00edaf56ae94176317390677569a4 - [lldb] fix(lldb/**.py): fix comparison to True/False (#94039)

Wed, 26 Jun 2024 14:55:15 +0000

[lldb] fix(lldb/**.py): fix comparison to True/False (#94039)from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. Co-authored-by: Eisuke Kawashima List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

1eeeab82c6eb185f5139e633a59c2dbcb15616e4 - [lldb][test] Modernize assertEqual(value, bool) (#82526)

Thu, 22 Feb 2024 02:39:02 +0000

[lldb][test] Modernize assertEqual(value, bool) (#82526)Any time we see the pattern `assertEqual(value, bool)`, we can replace that with `assert(value)`. Likewise for `assertNotEqual`. Technically this relaxes the test a bit, as we may want to make sure `value` is either `True` or `False`, and not something that implicitly converts to a bool. For example, `assertEqual("foo", True)` will fail, but `assertTrue("foo")` will not. In most cases, this distinction is not important. There are two such places that this patch does **not** transform, since it seems intentional that we want the result to be a bool: * https://github.com/llvm/llvm-project/blob/5daf2001a1e4d71ce1273a1e7e31cf6e6ac37c10/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py#L90 * https://github.com/llvm/llvm-project/blob/5daf2001a1e4d71ce1273a1e7e31cf6e6ac37c10/lldb/test/API/commands/settings/TestSettings.py#L940 Followup to 9c2468821ec51defd09c246fea4a47886fff8c01. I patched `teyit` with a `visit_assertEqual` node handler to generate this. List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

9c2468821ec51defd09c246fea4a47886fff8c01 - [lldb][test] Modernize asserts (#82503)

Wed, 21 Feb 2024 19:02:30 +0000

[lldb][test] Modernize asserts (#82503)This uses [teyit](https://pypi.org/project/teyit/) to modernize asserts, as recommended by the [unittest release notes](https://docs.python.org/3.12/whatsnew/3.12.html#id3). For example, `assertTrue(a == b)` is replaced with `assertEqual(a, b)`. This produces better error messages, e.g. `error: unexpectedly found 1 and 2 to be different` instead of `error: False`. List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

80fcecb13c388ff087a27a4b0e7ca3dd8c98eaa4 - [lldb] Replace assertEquals with assertEqual (NFC) (#82073)

Sat, 17 Feb 2024 04:58:50 +0000

[lldb] Replace assertEquals with assertEqual (NFC) (#82073)assertEquals is a deprecated alias for assertEqual and has been removed in Python 3.12. This wasn't an issue previously because we used a vendored version of the unittest module. Now that we use the built-in version this gets updated together with the Python version used to run the test suite. List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

2238dcc39358353cac21df75c3c3286ab20b8f53 - [NFC][Py Reformat] Reformat python files in lldb

Thu, 25 May 2023 15:48:57 +0000

[NFC][Py Reformat] Reformat python files in lldbThis is an ongoing series of commits that are reformatting our Pythoncode. Reformatting is done with `black` (23.1.0).If you end up having problems merging this commit because you have madechanges to a python file, the best way to handle that is to run `gitcheckout --ours ` and then reformat it with black.RFC: https://discourse.llvm.org/t/rfc-document-and-standardize-python-code-styleDifferential revision: https://reviews.llvm.org/D151460 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

4cc8f2a017c76af25234afc7c380550e9c93135c - [lldb][tests] Automatically call compute_mydir (NFC)

Fri, 17 Jun 2022 00:38:47 +0000

[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

0ed758b26041ef4ec57e8511d289fb0b84468775 - [lldb] Convert more assertTrue to assertEqual (NFC)

Tue, 02 Feb 2021 22:46:37 +0000

[lldb] Convert more assertTrue to assertEqual (NFC)Follow up to D95813, this converts multiline assertTrue to assertEqual.Differential Revision: https://reviews.llvm.org/D95899 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

a852cf66ea5d130a09cd796b97b15c18059e95cd - [lldb] [test] Skip ObjC-based tests via 'objc' category

Mon, 09 Nov 2020 09:47:22 +0000

[lldb] [test] Skip ObjC-based tests via 'objc' categoryReplace the plethora of ObjC-implied 'skipUnlessDarwin' decoratorswith marking tests as 'objc' category (whenever missing), and skip allObjC tests on non-Darwin platforms. I have used '.categories' filewherever it was present already or all (>1) tests were relying on ObjC,and explicit add_test_categories() where there was only one test.Differential Revision: https://reviews.llvm.org/D91056 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

35674976f09ec99e74d0d28b4a64b6bce360c128 - [lldb/Test] Introduce "assertSuccess"

Mon, 29 Jun 2020 11:51:46 +0000

[lldb/Test] Introduce "assertSuccess"Summary:A lot of our tests do 'self.assertTrue(error.Success()'. The problemwith that is that when this fails, it produces a completely uselesserror message (False is not True) and the most important piece ofinformation -- the actual error message -- is completely hidden.Sometimes we mitigate that by including the error message in the "msg"argument, but this has two additional problems:- as the msg argument is evaluated unconditionally, one needs to be careful to not trigger an exception when the operation was actually successful.- it requires more typing, which means we often don't do itassertSuccess solves these problems by taking the entire SBError objectas an argument. If the operation was unsuccessful, it can format areasonable error message itself. The function still accepts a "msg"argument, which can include any additional context, but this context nowdoes not need to include the error message.To demonstrate usage, I replace a number of existing assertTrueassertions with the new function. As this process is not easilyautomatable, I have just manually updated a representative sample. Insome cases, I did not update the code to use assertSuccess, but I wentfor even higher-level assertion apis (runCmd, expect_expr), as these areeven shorter, and can produce even better failure messages.Reviewers: teemperor, JDevlieghereSubscribers: arphaman, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D82759 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

b3a0c4d7dcfa252be17ef5f5b63ffaaa83e01a2b - [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

Thu, 13 Feb 2020 12:40:22 +0000

[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.This patch was mostly written by a shell script with some manual verification afterwards:```lang=pythonimport sysdef sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return linefor a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line))```Reviewers: labath, JDevlieghereReviewed By: labathSubscribers: abidh, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74475 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py

99451b4453688a94c6014cac233d371ab4cc342d - [lldb][test] Remove symlink for API tests.

Tue, 11 Feb 2020 18:01:16 +0000

[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151 List of files: /llvm-project/lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py