Lines Matching refs:commit
39 those requested during any post-commit review.
46 Post-commit review is encouraged, and can be accomplished using any of the
48 promptly to post-commit feedback and address it. Failure to do so is cause for
51 If a community member expresses a concern about a recent commit, and this
53 pre-commit review (including around the need for more design discussions),
58 this is inherent to our post-commit review practices.
69 Please note: The bar for post-commit feedback is not higher than for pre-commit
72 pre-commit (had you noticed it earlier), please feel free to provide that
77 address the issues than comment on the original commit. The original patch
83 Pre-commit code reviews are conducted on GitHub with Pull Requests. See
123 commit message).
158 When providing an unqualified LGTM (approval to commit), it is the
192 then you shouldn't be providing final approval to commit. A reviewer providing
193 final approval should have commit access to the LLVM project.