Remove pointless cast. No binary change.

Break on waitpid success; we shouldn't continue on WIFSIGNALED, and
WIFCONTINUED can't happen in this case.

OK deraadt@.

Certain errors in editit() should be fatal.

Don't print warnings in editit(), instead make errno reliable on
failure. If the editor exits non-zero, errno is set to ECHILD.

OK deraadt@.

Accept $VISUAL in addition to $EDITOR.

Save and restore signal handlers. Although we do not install our
own signal handlers, this allows this code to be more easily reused
in other programs.

OK deraadt@

Restore errno before calling perror().

Check fork() == -1 instead of fork() < 0.

When someone hits ^C in an editor, the editor does exit(130), I
don't know why. Something to do with the shell, says deraadt@.
Continuing to ignore these signals in the child fixes this.

Now editit

When someone hits ^C in an editor, the editor does exit(130), I
don't know why. Something to do with the shell, says deraadt@.
Continuing to ignore these signals in the child fixes this.

Now editit()'s return value can be reliably checked.

OK deraadt@.

show more ...

more careful waitpid() discussed with ray (plus some knf)

fork() does not return EPROCLIM, so don't test for it.

more cleaning :)

Change editit() to return -1 on error and 0 on success, like many
other C functions. (Currently this return value is unchecked.)

KNF.

Save errno before calling signal().

correct signal handling and process waiting for the editor spawning
code, so that signals in the editor are handled right. written by ray
after he started looking at other code that does this better

Since we now have our own program, we can export more things that
matter. Include kern.version, which tells a hell of a lot. ok millert ray

Replace `&' in gecos field with login, prodded by deraadt@.

simplify cleanup by using an atexit handler. lets us use err() instead
of a series of warn()/gotos.
ok deraadt

re-org something for prettiness

support $PR_FORM environment variable

Don't insert double slashes ("/tmp//p.XXXXXXXXXX") if TMPDIR ends
in "/". Helps emacs and deraadt@.

Support command-line arguments in $EDITOR. Prodded by deraadt@.

spacing

-V in usage