use strcspn to properly overwrite '\n' in fgets returned buffer

ok pyr@, ray@, millert@, moritz@, chl@

- Change sizeof(type) to sizeof(*ptr).
- Move function prototypes before variables.

No binary change.

OK otto and millert.

Bring in some changes from rcsdiff:
1. Replace all the e*alloc functions with the x*alloc versions.
2. Whitespace syncs according to style.
3. Remove the __inline stuff.
4. Remove the min/max functio

Bring in some changes from rcsdiff:
1. Replace all the e*alloc functions with the x*alloc versions.
2. Whitespace syncs according to style.
3. Remove the __inline stuff.
4. Remove the min/max functions, using the MAX/MIN macros instead.

OK millert@

show more ...

improve -p for C++ code: classes definition often have
public:/protected:/private: at the start of line.
This lets the -p scanner just take note of the section and keep
looking for the actual class d

improve -p for C++ code: classes definition often have
public:/protected:/private: at the start of line.
This lets the -p scanner just take note of the section and keep
looking for the actual class definition.

Also increase function name bufsize so it shows most of these pesky C++
decls...

okay otto@

show more ...

print the header only once.
okay millert@

Defer printing of the per-file diff header until after the regexp
"ignore" processing has finished. This way we only print the header
for files that have diffs. The new behavior matches GNU diff (w

Defer printing of the per-file diff header until after the regexp
"ignore" processing has finished. This way we only print the header
for files that have diffs. The new behavior matches GNU diff (which
is where the -I flag comes from). OK otto@ espie@

show more ...

Append two string using strlcpy()/strlcat() instead of snprintf() to
avoid having to check for encoding errors returned by snprintf().
From Ray Lai; ok millert@ jaredy@

Strip newline from lines used with -I, otherwise ^$ will match all
lines and ignore them all. With and ok jaredy@

Handle all isspace() chars the same for -w and -b. ok millert@ markus@

If the -L option is specified twice, use it for the second filename
like GNU diff does. Adapted from a diff by YAMAMOTO Takashi

Use unsigned char for bytes that are fed to isxxx() functions, to improve
portability. Spotted by YAMAMOTO Takashi.
ok millert@

Change tabs in string constants to \t. "of course" deraadt@

use sizeof(struct cand) instead of defining an unused cand object, and
then doing sizeof(cand). silly kids

Implement -I option: ignore changes matching a set of regexes. From
Jared Yanovich, with twists from millert@ and me. Testing by brad@,
sturm@ and pval@. ok millert@

If a new hunk immediately follows the previous one, merge them
into a single hunk. This makes diff produce the same diff as gdiff
in more cases. Found by brad@ and sturm@ using the ports tree.

ok mi

If a new hunk immediately follows the previous one, merge them
into a single hunk. This makes diff produce the same diff as gdiff
in more cases. Found by brad@ and sturm@ using the ports tree.

ok millert@

show more ...

Implement -p option.

"works here" millert@ ok miod@ deraadt@

Fix diff -q exit value which was broken in last commit.

Fix broken assumption that a file must contain differences if files_differ()
fails. Fixes "diff -i" exit value. Problem found by Claudio Jeker.

Din't print the "No newline at end of file" to inline (ie: to stdout)
for edit scripts. Instead, print it to stderr. This matches the
GNU diff behavior and fixes a problem with RCS and files with n

Din't print the "No newline at end of file" to inline (ie: to stdout)
for edit scripts. Instead, print it to stderr. This matches the
GNU diff behavior and fixes a problem with RCS and files with no
trailing newline. tedu@ OK

show more ...

prototype declared static, but function was not. add static to function.
millert@ otto@ ok

correct ascii file test. ok deraadt@ pb@

Based on what otto@ said on icb. The expensive thing in diff is
newcand() (this is what blows up the memory usage so badly). Instead
of counting how many times we go through the loop, count how man

Based on what otto@ said on icb. The expensive thing in diff is
newcand() (this is what blows up the memory usage so badly). Instead
of counting how many times we go through the loop, count how many
times we called newcand(). I renamed loopcount -> numtries since
it is no longer the number of loop runs. This fixes espie@'s regression.
tedu@ OK

show more ...

Guess the number of lines in a file and use that number for initial
memory allocation. Initial version by me, cleanup by millert@.

ok millert@

- Change the hash function to a simple multiplicative one. The old
hash function was apparently optimized for 16 bit processors and
generates quite some collisions.
- Fix another case of excessive re

- Change the hash function to a simple multiplicative one. The old
hash function was apparently optimized for 16 bit processors and
generates quite some collisions.
- Fix another case of excessive reallocing.

ok millert@

show more ...

o correct exit code when comparing stdin and stdin (a noop)
o after copying to a temp file, lseek() to the beginning so the
inline cmp routine works.
Fixes an exit code issue when comparing against

o correct exit code when comparing stdin and stdin (a noop)
o after copying to a temp file, lseek() to the beginning so the
inline cmp routine works.
Fixes an exit code issue when comparing against stdin.

show more ...