support passing a template file for the auto-allocation to disklabel.
template gives mountpoints, min-max size ranges and percentage of disk
foremost intended for autoinstalls, installer bits to foll

support passing a template file for the auto-allocation to disklabel.
template gives mountpoints, min-max size ranges and percentage of disk
foremost intended for autoinstalls, installer bits to follow soon.
with input from many, ok theo

show more ...

for small mem machines, make sure max does not get smaller than
min, otherwise the constraint cannot be satisfied; ok deraadt@ okan@

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Constify the driver name to disk type table, and remove rz and ccd from that
list.
ok krw@ millert@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_N

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

show more ...

Userland reallocarray() audit.

Avoid potential integer overflow in the size argument of malloc() and
realloc() by using reallocarray() to avoid unchecked multiplication.

ok deraadt@

Forward declarations for mpcopy & mpfree.
OK miod@, deraadt@

remove unused variable

ok otto@ krw@

'for (part == 0; ...)' is not the same as 'for(part = 0; ...)'.

Should fix mysterious crashes when twiddling mount points. Too
much Marrakesh sun.

Pointed out by Owain G. Ainsworth. Thanks!

Don't leak mountpoint info. Now with replacement for silly realloc() dance
that appears to fix mysterious crashes seen with previous version that
tried to sneak in to 5.5.

ok otto@

Proper validation and computation of bsize in expert mode; ok krw@ millert@

Revert mountpoints tweaking. Needs much more serious surgery than time
permits before release, and is pointless without other following diffs
to justify it that will not make release.

Should fix seg

Revert mountpoints tweaking. Needs much more serious surgery than time
permits before release, and is pointless without other following diffs
to justify it that will not make release.

Should fix segfault's during install reported by Rod Whitworth on tech@

show more ...

Further tweak to mpfree(). Don't bother setting about-to-be-freed
memory to NULL.

Don't risk dereferencing NULL pointer to mountpoints array
when calling mpfree() with the array.

Stop leaking mount point strings in temporary copies of the
mountpoints array.

Whole bunch of (unsigned char) casts carefully added for ctype calls.
Careful second audit by millert

add a variety of missing prototypes

improve on last commit: take 10% for swap, with a max of physmem plus a bit

allow more space for swap with big disks, useful for hibernation;
requested by deraadt@

The disklabel variables aflag and dflag are boolean, use logical
instead of binary operators for comparison.
OK krw@

Print u_int64_t variables with %llu.

The rule is: daddr_t variables hold counts of 512-byte blocks, a.k.a.
DEV_BSIZE blocks. Counts of possibly other-sized blocks (e.g. disk
sector addresses) are u_int64_t. The values stored in disklabe

The rule is: daddr_t variables hold counts of 512-byte blocks, a.k.a.
DEV_BSIZE blocks. Counts of possibly other-sized blocks (e.g. disk
sector addresses) are u_int64_t. The values stored in disklabels are
counts of possibly other-sized blocks and hence should be handled with
u_int64_t variables.

Start enforcing this rule. No intended functional change.

Rule strongly suggested by deraadt@

show more ...

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

make sure the fs blocksize doesn't get too big; ok krw@

Replace a '512' with DEV_BSIZE. Calculate physmem size in blocks and
not sectors, since the values being tested/manipulated in the auto_alloc
tables are blocks at that point. Use MEG(256) instead of

Replace a '512' with DEV_BSIZE. Calculate physmem size in blocks and
not sectors, since the values being tested/manipulated in the auto_alloc
tables are blocks at that point. Use MEG(256) instead of hand
expanding it when testing physmem.

show more ...