crashlog.py: Improve regular expressions

This is yet another change to the regular expressions in crashlog.py
that fix a few edge cases, and attempt to improve the readability
quite a bit in the pro

crashlog.py: Improve regular expressions

This is yet another change to the regular expressions in crashlog.py
that fix a few edge cases, and attempt to improve the readability
quite a bit in the process. My last change to support spaces in
filenames introduced a bug that caused the version/archspec field to
be parsed as part of the image name.

For example, in "0x1111111 - 0x22222 +MyApp Pro arm64 <01234>", the
name of the image was recognized as "MyApp Pro arm64" instead of
"MyApp Pro" with a "version" of arm64.

The bugfix makes the space following an optional field mandatory
*inside* the optional group.

rdar://problem/56883435

Differential Revision: https://reviews.llvm.org/D69871

show more ...

[crashlog] Fix a mismatch between bytes and strings.

The functions in read_plist() want bytes as input, not
strings.

<rdar://problem/52600712>

llvm-svn: 365416

Python 3: decode string as utf-8 to avoid type mismatch.

rdar://problem/51464644

Differential Revision: https://reviews.llvm.org/D63311

llvm-svn: 363413

Make crashlog.py less noisy

For end-users there is no point in printing dSYM load errors for
system frameworks, since they will all fail and there's nothing they
can do about it. This patch hides th

Make crashlog.py less noisy

For end-users there is no point in printing dSYM load errors for
system frameworks, since they will all fail and there's nothing they
can do about it. This patch hides them by default and shows them when
--verbose is present.

Differential Revision: https://reviews.llvm.org/D63310

llvm-svn: 363412

show more ...

[lldb] Ignore null frames in lldb.macosx crashlog

llvm-svn: 363172

[crashlog] Add a missing call to decode.

<rdar://problem/51139357>

llvm-svn: 362044

[crashlog] Use loads() instead of readPlistFromString() for python 3.

<rdar://problem/50903413>

llvm-svn: 361087

[crashlog] Strip trailing `\n` from check_output return.

Generally having spurious `\n` doesn't matter, but here the
returning string is a command which is executed, so we want
to strip it. Pointed

[crashlog] Strip trailing `\n` from check_output return.

Generally having spurious `\n` doesn't matter, but here the
returning string is a command which is executed, so we want
to strip it. Pointed out by Jason.

llvm-svn: 358717

show more ...

[crashlog] Use the right path for dsymforUUID and remove an unnecessary import.

<rdar://problem/49925960>

llvm-svn: 358615

Portable exception value access across Python 2 / Python 3

Differential Revision: https://reviews.llvm.org/D59583

llvm-svn: 356670

crashlog.py: Catch exception from subprocess.

llvm-svn: 355572

[Python] Unbreak the recently modified tests for python 2.

llvm-svn: 355566

[testsuite] Port crashlog to python 3, second attempt.

llvm-svn: 355562

Revert "[testsuite] Port crashlog and dependencies to Python 3."

This revert the commit because it broke the bots. I need to find
a way that works with both versions.

llvm-svn: 355364

[testsuite] Port crashlog and dependencies to Python 3.

Fixes three tests in the testsuite.

llvm-svn: 355359

Fix use of non-existing variable in crashlog.py

Summary:
The method find_matching_slice(self) uses uuid_str on one of the paths but the variable does not exist and so this results in a NameError exc

Fix use of non-existing variable in crashlog.py

Summary:
The method find_matching_slice(self) uses uuid_str on one of the paths but the variable does not exist and so this results in a NameError exception if we take that path.

Differential Revision: https://reviews.llvm.org/D57467

llvm-svn: 352772

show more ...

Make crashlog.py work or binaries with spaces in their names

This is a little dangerous since the crashlog files aren't 100%
unambiguous, but the risk is mitigated by using a non-greedy +?
pattern.

Make crashlog.py work or binaries with spaces in their names

This is a little dangerous since the crashlog files aren't 100%
unambiguous, but the risk is mitigated by using a non-greedy +?
pattern.

rdar://problem/38478511

Differential Revision: https://reviews.llvm.org/D55608

llvm-svn: 349367

show more ...

Make crashlog.py work when a .dSYM is present, but a binary is missing

Often users have a crash log an d a .dSYM bundle, but not the original
application binary. It turns out that for crash symbolic

Make crashlog.py work when a .dSYM is present, but a binary is missing

Often users have a crash log an d a .dSYM bundle, but not the original
application binary. It turns out that for crash symbolication, we can
safely fall back to using the binary inside the .dSYM bundle.

Differential Revision: https://reviews.llvm.org/D55607

llvm-svn: 349366

show more ...

The save_crashlog command was still looking at lldb.target and
lldb.process. That hasn't worked for a long time. Convert it
to the form that takes an SBExecutionContext and use that instead.

llvm-

The save_crashlog command was still looking at lldb.target and
lldb.process. That hasn't worked for a long time. Convert it
to the form that takes an SBExecutionContext and use that instead.

llvm-svn: 315549

show more ...

Print the error if dsymForUUID sometimes produces bad plists.

Not much we can do about it but at least we can print the bad
plist and the error.

llvm-svn: 298958

Improve crashlog.py so it can handle more iOS crashlog files.

<rdar://problem/29191857>

llvm-svn: 289006

*** This commit represents a complete reformatting of the LLDB source code
*** to conform to clang-format’s LLVM style. This kind of mass change has
*** two obvious implications:

Firstly, merging t

*** This commit represents a complete reformatting of the LLDB source code
*** to conform to clang-format’s LLVM style. This kind of mass change has
*** two obvious implications:

Firstly, merging this particular commit into a downstream fork may be a huge
effort. Alternatively, it may be worth merging all changes up to this commit,
performing the same reformatting operation locally, and then discarding the
merge for this particular commit. The commands used to accomplish this
reformatting were as follows (with current working directory as the root of
the repository):

find . \( -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname "*.mm" \) -exec clang-format -i {} +
find . -iname "*.py" -exec autopep8 --in-place --aggressive --aggressive {} + ;

The version of clang-format used was 3.9.0, and autopep8 was 1.2.4.

Secondly, “blame” style tools will generally point to this commit instead of
a meaningful prior commit. There are alternatives available that will attempt
to look through this change and find the appropriate prior commit. YMMV.

llvm-svn: 280751

show more ...

Fixed a few places that were building a regex from an identifier without escaping the identifier text.

<rdar://problem/26090553>

llvm-svn: 272423

Remove a few uses of lldb.target, which is not valid
in a scripted command.

llvm-svn: 240451

Add a call to SBDebugger:Destroy() at the end of the self-hosted
version of this script. We picked up a bug at some point in March
where scripts that fail to call SBDebugger::Destroy() will crash
in

Add a call to SBDebugger:Destroy() at the end of the self-hosted
version of this script. We picked up a bug at some point in March
where scripts that fail to call SBDebugger::Destroy() will crash
in the Debugger C++ dtor. I want to track the change down which
introduced the change - but this script should be calling
SBDebugger::Destroy() in the first place, so do that.

llvm-svn: 233779

show more ...