Make tooling::applyAllReplacements return llvm::Expected<string> instead of empty string to indicate potential error.

Summary:
return llvm::Expected<> to carry error status and error information.
Th

Make tooling::applyAllReplacements return llvm::Expected<string> instead of empty string to indicate potential error.

Summary:
return llvm::Expected<> to carry error status and error information.
This is the first step towards introducing "Error" into tooling::Replacements.

Reviewers: djasper, klimek

Subscribers: ioeric, klimek, cfe-commits

Differential Revision: http://reviews.llvm.org/D21601

llvm-svn: 275062

show more ...

clang-format: [Java] Remove unnecessary line break after complex annotations

Before:
@Annotation("Some"
+ " text")
List<Integer>
list;

After:
@Annotation("Some"
+ " text")

clang-format: [Java] Remove unnecessary line break after complex annotations

Before:
@Annotation("Some"
+ " text")
List<Integer>
list;

After:
@Annotation("Some"
+ " text")
List<Integer> list;

llvm-svn: 258981

show more ...

clang-format: [JS] "operator" is not a keyword in Java/JavaScript.

llvm-svn: 256245

clang-format/java: Break after annotations on fields in Chromium style.

Chromium follows the Android style guide for Java code, and that doesn't make
the distinction between fields and non-fields th

clang-format/java: Break after annotations on fields in Chromium style.

Chromium follows the Android style guide for Java code, and that doesn't make
the distinction between fields and non-fields that the Google Java style guide
makes:

https://source.android.com/source/code-style.html#use-standard-java-annotations
https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations

llvm-svn: 250422

show more ...

Remove accidental superfluous newline added in r247750.

llvm-svn: 247752

clang-format: In Java, `assert` is followed by an expression.

Before: assert a&& b;
Now: assert a && b;
llvm-svn: 247750

clang-format: [Java/JS] Properly support instanceof and its precedence.

llvm-svn: 241337

Revert r240270 ("Fixed/added namespace ending comments using clang-tidy").

llvm-svn: 240353

Fixed/added namespace ending comments using clang-tidy. NFC

The patch is generated using this command:

$ tools/extra/clang-tidy/tool/run-clang-tidy.py -fix \
-checks=-*,llvm-namespace-comme

Fixed/added namespace ending comments using clang-tidy. NFC

The patch is generated using this command:

$ tools/extra/clang-tidy/tool/run-clang-tidy.py -fix \
-checks=-*,llvm-namespace-comment -header-filter='llvm/.*|clang/.*' \
work/llvm/tools/clang

To reduce churn, not touching namespaces spanning less than 10 lines.

llvm-svn: 240270

show more ...

clang-format: clang-format (NFC)

llvm-svn: 239903

clang-format: Indent relative to the ./-> and not the function name.

Before:
aaaaaaaaaaa //
.aaaa( //
bbbb) // This is different ..
.aaaa( //
cccc);

clang-format: Indent relative to the ./-> and not the function name.

Before:
aaaaaaaaaaa //
.aaaa( //
bbbb) // This is different ..
.aaaa( //
cccc); // .. from this.

After:
aaaaaaaaaaa //
.aaaa( //
bbbb) // This is identical ..
.aaaa( //
cccc); // .. to this.

llvm-svn: 234300

show more ...

clang-format: [Java] Support anonymous classes after = and return.

Before:
A a = new A(){public String toString(){return "NotReallyA";
}
}
;

After:
A a = return new A() {
public Strin

clang-format: [Java] Support anonymous classes after = and return.

Before:
A a = new A(){public String toString(){return "NotReallyA";
}
}
;

After:
A a = return new A() {
public String toString() {
return "NotReallyA";
}
};

This fixes llvm.org/PR22878.

llvm-svn: 232042

show more ...

clang-format: [Java] Support try blocks with resources.

Before:
try
(SomeResource rs = someFunction()) {
Something();
}

After:
try (SomeResource rs = someFunction()) {
Somethi

clang-format: [Java] Support try blocks with resources.

Before:
try
(SomeResource rs = someFunction()) {
Something();
}

After:
try (SomeResource rs = someFunction()) {
Something();
}

llvm-svn: 225973

show more ...

clang-format: [Java] Prefer not to break in parameter annotations.

Before:
boolean someFunction(@Param(aaaaaaaaaaaaaaaa)
String aaaaa,
String bbbbbbbbbbbbbbb) {}

Afte

clang-format: [Java] Prefer not to break in parameter annotations.

Before:
boolean someFunction(@Param(aaaaaaaaaaaaaaaa)
String aaaaa,
String bbbbbbbbbbbbbbb) {}

After:
boolean someFunction(
@Param(aaaaaaaaaaaaaaaa) String aaaaa,
String bbbbbbbbbbbbbbb) {}

llvm-svn: 225971

show more ...

clang-format: [Java] Understand "import static".

llvm-svn: 225965

clang-format: [Java] Don't let annotations confuse return type analysis.

Before:
@Test
ReturnType
doSomething(String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}

After:
@Test
ReturnType doSo

clang-format: [Java] Don't let annotations confuse return type analysis.

Before:
@Test
ReturnType
doSomething(String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}

After:
@Test
ReturnType doSomething(
String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}

llvm-svn: 225964

show more ...

clang-format: [Java] Don't line-wrap before annotations' l_parens.

Before:
@SomeAnnotation
(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)
int i;

After:
@SomeAnnotation(
aaaaaaaaaaaaaaaaa,

clang-format: [Java] Don't line-wrap before annotations' l_parens.

Before:
@SomeAnnotation
(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)
int i;

After:
@SomeAnnotation(
aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)
int i;

llvm-svn: 225963

show more ...

clang-format: [Java] Don't get confused by leading annotations.

Before:
@Test(a)
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaaaa);

A

clang-format: [Java] Don't get confused by leading annotations.

Before:
@Test(a)
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaaaa);

After:
@Test(a)
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =
aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);

llvm-svn: 225962

show more ...

clang-format: [Java] Detect `native` keyword.

Before:
public native<X> Foo foo();

After:
public native <X> Foo foo();

llvm-svn: 225839

clang-format: [Java] Support formatting qualified annotations.

llvm-svn: 225559

clang-format: [Java] Fix incorrect detection of cast.

After:
return (a instanceof List<?>) ? aaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaa)

clang-format: [Java] Fix incorrect detection of cast.

After:
return (a instanceof List<?>) ? aaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaa)
: aaaaaaaaaaaaaaaaaaaaaaa;

After:
return (a instanceof List<?>)
? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)
: aaaaaaaaaaaaaaaaaaaaaaa;

llvm-svn: 225161

show more ...

clang-format: [Java] Fix incorrect recognition of annonymous classes.

Before:
someFunction(new Runnable() { public void run() { System.out.println(42);
}
});

After:
someFunction(new Runnabl

clang-format: [Java] Fix incorrect recognition of annonymous classes.

Before:
someFunction(new Runnable() { public void run() { System.out.println(42);
}
});

After:
someFunction(new Runnable() {
public void run() {
System.out.println(42);
}
});

llvm-svn: 225142

show more ...

clang-format: Re-enable comment re-indentation for Java/JS.

This was broken by r224120.

llvm-svn: 225130

Don't break string literals in Java and JavaScript.

The proper way to break string literals in these languages is by inserting a "+"
between parts which we don't support yet. So we disable string li

Don't break string literals in Java and JavaScript.

The proper way to break string literals in these languages is by inserting a "+"
between parts which we don't support yet. So we disable string literal breaking
until then.

llvm-svn: 224120

show more ...

clang-format: Indent correctly in conditional expressions after return.

This only applies when not aligning after the return itself (which is
commonly done for C++.

Before:
return aaaaaaaaaa

clang-format: Indent correctly in conditional expressions after return.

This only applies when not aligning after the return itself (which is
commonly done for C++.

Before:
return aaaaaaaaaa
? bbbbbbbbbb(
bbbbbb) // This is indented relative to aaaaaaaaaa.
: b;

After:
return aaaaaaaaaa
? bbbbbbbbbb(
bbbbbb)
: b;

llvm-svn: 223694

show more ...