[clang-format] Finalize children after formatting them (#73753)

This would also fix the overlapping replacements below:
```
$ clang-format
a(
#else
#endif
) = []() {
)}
The new repl

[clang-format] Finalize children after formatting them (#73753)

This would also fix the overlapping replacements below:
```
$ clang-format
a(
#else
#endif
) = []() {
)}
The new replacement overlaps with an existing replacement.
New replacement: <stdin>: 38:+7:"
"
Existing replacement: <stdin>: 38:+7:" "
```
Fixed #73487.

show more ...

[clang-format] Add BreakAdjacentStringLiterals option (#73432)

Closes #70451.

[clang-format] Fix a bug in formating `#define A x:` (#73220)

Fixed #70789.

[clang-format] Correctly annotate braces of empty functions (#72733)

Also fixed some existing test cases.

Fixed #57305.
Fixed #58251.

[clang-format][NFC] Skip alignArrayInitializers() for 1-row matrices (#72166)

[clang-format] Fix crashes in AlignArrayOfStructures (#72520)

Fixed #54815.
Fixed #55269.
Fixed #55493.
Fixed #68431.

[clang-format] Fix a bug in parsing function/variable names

Function and variable names are not detected when there is a
__attribute__((x)) preceding the name.

Fixes #64137.

Differential Revision:

[clang-format] Fix a bug in parsing function/variable names

Function and variable names are not detected when there is a
__attribute__((x)) preceding the name.

Fixes #64137.

Differential Revision: https://reviews.llvm.org/D156370

show more ...

[clang-format] Fix a bug in aligning comments in vector of structs (#72099)

Fixed #71825.

[clang-format] Handle control statements in BreakAfterAttributes (#71995)

This patch doesn't work for do-while loops.

Fixed #64474.

[clang-format] Handle variable declarations in BreakAfterAttributes (#71935)

Also fixed a bug in `isStartOfName()` and cleaned up some old test
cases.

Fixed #71563.

This is a rework of #71755.

Revert "[clang-format] Handle variable declarations in BreakAfterAttributes (#71755)"

This reverts commit f7bbb58690910a8320b0927525dfba19df69a910 which caused
another formatting failure in polly.

Reland "[clang-format] Handle variable declarations in BreakAfterAttributes (#71755)"

Also fixed another bug in isStartOfName().

Revert "[clang-format] Handle variable declarations in BreakAfterAttributes (#71755)"

This reverts commit 5c36f4332d93c6f9bd9b01a34149a635e07a00d3 which caused a
formatting error in polly.

[clang-format] Handle variable declarations in BreakAfterAttributes (#71755)

Also cleaned up some old test cases.

Fixes #71563.

[clang-format] Treat empty for/while loops as short loops (#70768)

A for/while loop with only a semicolon as its body should be treated as
an empty loop.

Fixes #61708.

[clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (#70360)

This patch addresses some examples of bad formatting in Clang. The following commit contains only changes suggested by

[clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (#70360)

This patch addresses some examples of bad formatting in Clang. The following commit contains only changes suggested by clang-format: https://github.com/llvm/llvm-project/pull/70349/commits/21689b56d1fc1db0b2263e8049ff656d3757ad36.
I believe it's a net negative on readability, with a couple of particularly bad cases. Highlights:
```diff
- [[clang::preferred_type(bool)]]
- mutable unsigned CachedLocalOrUnnamed : 1;
+ [[clang::preferred_type(bool)]] mutable unsigned CachedLocalOrUnnamed : 1;
```
```diff
- [[clang::preferred_type(TypeDependence)]]
- unsigned Dependence : llvm::BitWidth<TypeDependence>;
+ [[clang::preferred_type(TypeDependence)]] unsigned Dependence
+ : llvm::BitWidth<TypeDependence>;
```
```diff
- [[clang::preferred_type(ExceptionSpecificationType)]]
- unsigned ExceptionSpecType : 4;
+ [[clang::preferred_type(
+ ExceptionSpecificationType)]] unsigned ExceptionSpecType : 4;
```
Style guides doesn't appear to have an opinion on this matter.

show more ...

[clang-format] AllowShortCompoundRequirementOnASingleLine

clang-format brace wrapping did not take requires into consideration,
compound requirements will be affected by BraceWrapping.AfterFunction.

[clang-format] AllowShortCompoundRequirementOnASingleLine

clang-format brace wrapping did not take requires into consideration,
compound requirements will be affected by BraceWrapping.AfterFunction.

Closes #59412.

Differential Revision: https://reviews.llvm.org/D139834

show more ...

[clang-format] Don't break between string literal operands of << (#69871)

Fixes #44363.

Revert "[clang-format] Fix align consecutive declarations over function pointers"

This reverts commit a84e0b4bdc9999872adbdaafbade8164b197784b.

Fixes #68079.

[clang-format] Don't alter SpacesRequiredBefore of finalized tokens (#69897)

Fixes #69237.

[clang-format] Add space in placement new expression

Add AfterPlacementNew option to SpaceBeforeParensOptions to have more
control on placement new expressions.

Fixes #41501
Relates to #54703

Diff

[clang-format] Add space in placement new expression

Add AfterPlacementNew option to SpaceBeforeParensOptions to have more
control on placement new expressions.

Fixes #41501
Relates to #54703

Differential Revision: https://reviews.llvm.org/D127270

show more ...

[clang-format] Treat AttributeMacro more like __attribute__

There are two parts to this fix:
- Annotate the paren after an AttributeMacro as an AttributeLParen.
- Treat an AttributeMacro-without-par

[clang-format] Treat AttributeMacro more like __attribute__

There are two parts to this fix:
- Annotate the paren after an AttributeMacro as an AttributeLParen.
- Treat an AttributeMacro-without-paren the same as one with a paren.

I added a new test-case to differentiate a macro that is or is-not an
AttributeMacro; also handled whether ColumnLimit is set to infinite (0) or a
finite value, as part of this patch is in ContinuationIndenter.

Closes #68722.

Differential Revision: https://reviews.llvm.org/D145262

show more ...

Reland "[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)"

Reland 6a621ed8e4cb which failed on Windows but not macOS.

The failures were caused by moving the annotation of the

Reland "[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)"

Reland 6a621ed8e4cb which failed on Windows but not macOS.

The failures were caused by moving the annotation of the children from the
top to the bottom of TokenAnnotator::annotate(), resulting in invalid lines
including incomplete ones being skipped.

show more ...

Revert "[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)"

This reverts commit 6a621ed8e4cb02bd55fe4a4a0254615576b70a55 as it caused
buildbots to fail.

[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)

After annotating constructors/destructors as FunctionDeclarationName in
commit 08630512088, we have seen several issues beca

[clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (#67955)

After annotating constructors/destructors as FunctionDeclarationName in
commit 08630512088, we have seen several issues because ctors/dtors had
been treated differently than functions in aligning, wrapping, and
indenting.

This patch annotates ctors/dtors as CtorDtorDeclName instead and would
effectively revert commit 0468fa07f87f, which is obsolete now.

Fixed #67903.
Fixed #67907.

show more ...