[clang][analyzer] Simplify code of StreamChecker (NFC). (#79312)

A class is added that contains common functions and data members that are used in many of the "eval" functions. This results in short

[clang][analyzer] Simplify code of StreamChecker (NFC). (#79312)

A class is added that contains common functions and data members that are used in many of the "eval" functions. This results in shorter "eval" functions and less code repetition.

show more ...

[clang][analyzer] Remove unused variable in StreamChecker.cpp (NFC)

llvm-project/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:1125:17:
error: unused variable 'ASTC' [-Werror,-Wunused-variabl

[clang][analyzer] Remove unused variable in StreamChecker.cpp (NFC)

llvm-project/clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:1125:17:
error: unused variable 'ASTC' [-Werror,-Wunused-variable]
1125 | ASTContext &ASTC = C.getASTContext();
| ^~~~
1 error generated.

show more ...

[clang][analyzer] Support 'getdelim' and 'getline' in StreamChecker (#78693)

[clang][analyzer] Add function 'fscanf' to StreamChecker. (#78180)

[clang][analyzer] Add function 'fprintf' to StreamChecker. (#77613)

[clang][analyzer] Add function 'fprintf' to StreamChecker.

[clang][analyzer] Support 'tello' and 'fseeko' in the StreamChecker (#77580)

[clang][analyzer] Add function 'ungetc' to StreamChecker. (#77331)

`StdLibraryFunctionsChecker` is updated too with `ungetc`.

[clang][analyzer] Support 'fdopen' in the StreamChecker (#76776)

[clang][analyzer] Support `fflush` in the StreamChecker (#74296)

[clang][analyzer][NFC] Supplement comments in `evalFtell` of StreamChecker (#74291)

[clang][analyzer] Support `fgets` in the SteamChecker (#73638)

[clang][analyzer] Support `fputs` in the StreamChecker (#73335)

[clang][analyzer] Support `fgetc` in StreamChecker (#72627)

[clang][Analyzer][NFC] Use condition type for comparison in several checkers (#72358)

[clang][analyzer] Support `fputc` in StreamChecker (#71518)

[clang][analyzer][NFC] Remove redundant code in StreamChecker (#71394)

[clang][analyzer] Restrict 'fopen' & 'tmpfile' modeling to POSIX versions in StreamChecker (#70540)

'tmpfile' has only one form that it has no argument.

[clang][analyzer]][NFC] Simplify method 'ensureStreamNonNull' of StreamChecker (#70927)

The passed in parameter 'State' is always identical to 'C.getState()'.

[clang][analyzer][NFC] Combine similar methods of StreamChecker (#70170)

Methods StreamChecker::preFread and StreamChecker::preFwrite are quite
similar, so they can be combined to StreamChecker::pr

[clang][analyzer][NFC] Combine similar methods of StreamChecker (#70170)

Methods StreamChecker::preFread and StreamChecker::preFwrite are quite
similar, so they can be combined to StreamChecker::preFreadFwrite.

show more ...

[analyzer][NFC] Substitute operator() with lambda in StreamChecker

[clang][analyzer] No end-of-file when seek to file begin.

If `fseek` is used with 0 position and SEEK_SET it sets the position
to the start of the file. This should not cause FEOF (end of file) erro

[clang][analyzer] No end-of-file when seek to file begin.

If `fseek` is used with 0 position and SEEK_SET it sets the position
to the start of the file. This should not cause FEOF (end of file) error.
The case of an empty file is not handled for simplification.
It is not exactly defined in what cases `fseek` produces the different
error states. Normally feof should not happen at all because it is
possible to set the position after the end of file, but previous tests
showed that still feof (and any other error cases) can happen.

Reviewed By: donat.nagy

Differential Revision: https://reviews.llvm.org/D153363

show more ...

[CLANG] Fix potential null pointer dereference bugs

This patch uses castAs instead of getAs which will assert if the type doesn't match and adds nullptr check if needed.

Also this patch improves th

[CLANG] Fix potential null pointer dereference bugs

This patch uses castAs instead of getAs which will assert if the type doesn't match and adds nullptr check if needed.

Also this patch improves the codes and passes I.getData() instead of doing a lookup in dumpVarDefinitionName()
since we're iterating over the same map in LocalVariableMap::dumpContex().

Reviewed By: aaron.ballman, aaronpuchert

Differential Revision: https://reviews.llvm.org/D153033

show more ...

[clang][analyzer] Add report of NULL stream to StreamChecker.

The report of NULL stream was removed in commit 570bf97.
The old reason is not actual any more because the checker dependencies are chan

[clang][analyzer] Add report of NULL stream to StreamChecker.

The report of NULL stream was removed in commit 570bf97.
The old reason is not actual any more because the checker dependencies are changed.
It is not good to eliminate a failure state (where the stream is NULL) without
generating a bug report because other checkers are not able to find it later.
The checker did this with the NULL stream pointer, and because this checker
runs now before other checkers that can detect NULL pointers, the null pointer
bug was not found at all.

Reviewed By: steakhal

Differential Revision: https://reviews.llvm.org/D152169

show more ...

[clang] Use std::optional instead of llvm::Optional (NFC)

This patch replaces (llvm::|)Optional< with std::optional<. I'll post
a separate patch to remove #include "llvm/ADT/Optional.h".

This is p

[clang] Use std::optional instead of llvm::Optional (NFC)

This patch replaces (llvm::|)Optional< with std::optional<. I'll post
a separate patch to remove #include "llvm/ADT/Optional.h".

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

show more ...

[clang] Add #include <optional> (NFC)

This patch adds #include <optional> to those files containing
llvm::Optional<...> or Optional<...>.

I'll post a separate patch to actually replace llvm::Option

[clang] Add #include <optional> (NFC)

This patch adds #include <optional> to those files containing
llvm::Optional<...> or Optional<...>.

I'll post a separate patch to actually replace llvm::Optional with
std::optional.

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

show more ...