Changes in Makefile

2608d129d01ad9c57f31e59f35e4a5df7fd7f1fa - accel: Add crypto operation support

Tue, 04 Oct 2022 19:16:21 +0000

accel: Add crypto operation supportAdd functions to submit encrypt/decrypt operationsAdd RPCS to register and dump crypto keysSoftware accel module uses isa-l_crypto AEX_XTSfunctionalitySigned-off-by: Alexey Marchuk Change-Id: Iecf0e9913edf11ab85171d0fa467a2a62dfff984Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14858Tested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Reviewed-by: Shuhei Matsumoto List of files: /spdk/test/external_code/hello_world/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/test/external_code/hello_world/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/test/external_code/hello_world/Makefile

c9c7c281f8809a0cc54ae9e44e0fd87fb52ad5e8 - spelling: test

Thu, 25 Nov 2021 01:40:59 +0000

spelling: testPart of #2256* achieve* additionally* against* aliases* already* another* arguments* between* capabilities* comparison* compatibility* configuration* continuing* controlq* cpumask* default* depends* dereferenced* discussed* dissect* driver* environment* everything* excluded* existing* expectation* failed* fails* following* functions* hugepages* identifiers* implicitly* in_capsule* increment* initialization* initiator* integrity* iteration* latencies* libraries* management* namespace* negotiated* negotiation* nonexistent* number* occur* occurred* occurring* offsetting* operations* outstanding* overwhelmed* parameter* parameters* partition* preempts* provisioned* responded* segment* skipped* struct* subsystem* success* successfully* sufficiently* this* threshold* transfer* transferred* unchanged* unexpected* unregistered* useless* utility* value* variable* workloadChange-Id: I21ca7dab4ef575b5767e50aaeabc34314ab13396Signed-off-by: Josh Soref Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10409Community-CI: Broadcom CI Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins List of files: /spdk/test/external_code/hello_world/Makefile

af935f768e20bbfa9e866251ff68841b1090eea8 - event: Shift subsystem initialization code to a separate library

Fri, 26 Feb 2021 22:00:03 +0000

event: Shift subsystem initialization code to a separate libraryThis is useful for applications even if they elect not to use the SPDKevent framework.This doesn't shift everything in one go - just the subsysteminitialization logic. Configuration file loading also needs to movein a separate patch later.Change-Id: Id419df1045442d416650ed90e5ee78adfdd623d7Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6641Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Reviewed-by: Paul Luse Reviewed-by: Shuhei Matsumoto List of files: /spdk/test/external_code/hello_world/Makefile

f758833ef8f5845aaea525c50d725145ecdc186c - build: combine env_dpdk / event_bdev so pkgconfig can de-duplicate deps

Fri, 12 Feb 2021 18:28:04 +0000

build: combine env_dpdk / event_bdev so pkgconfig can de-duplicate deps- it shows nice feature and usage of pkg-config- it also prevents from duplicate symbols issue for static build incase listed libs have a common dependenciesSigned-off-by: Jacek Kalwas Change-Id: I1f470d202ea7efe03e354dca472fd50e97bca747Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6406Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Tomasz Zawadzki List of files: /spdk/test/external_code/hello_world/Makefile

79f9a7f572959b77852bb0946161a34e2c502923 - build: generate pkg-config files for SPDK

Thu, 24 Sep 2020 00:06:02 +0000

build: generate pkg-config files for SPDKUsers can now generate the necessary linker args for theirown applications using something like:PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvmeDependencies between libraries are included in the generated.pc files, so the user only needs to pass the top-level subsystemsor individual SPDK libraries they are using in their application.Modules will automatically be added to the output if the associatedlibrary is specified. For example, specifying "spdk_bdev" will includethe libraries not only for spdk_bdev, but also all of the bdev modules.Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archiveflags. They cannot be added to the .pc files without increasing the lengthof the argument string by a factor of 15x to 20x.Modify the test/external_code/hello_world Makefile to use pkg-config toensure this gets tested at some level in our autotest environment.Signed-off-by: Jim Harris Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfdReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371Community-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Shuhei Matsumoto List of files: /spdk/test/external_code/hello_world/Makefile

c006a8da16a2b83e9903e44c0baf212ae6ed5472 - test/external_code: use -pthread instead of -lpthread

Tue, 22 Dec 2020 20:08:05 +0000

test/external_code: use -pthread instead of -lpthread-pthread is what SPDK in-tree Makefiles use, so use thatin the external_code Makefile too. -pthread can beused both on the compilation and link stages.Signed-off-by: Jim Harris Change-Id: I8ef702b8fbde825a4191d961738ebc605b0aa4c5Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5675Community-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk List of files: /spdk/test/external_code/hello_world/Makefile

31e91a83fa28527b31cca593569ec911d192ae8e - test/external_code: make spdk_env_dpdk part of DPDK_LIBS

Mon, 21 Dec 2020 22:50:49 +0000

test/external_code: make spdk_env_dpdk part of DPDK_LIBSOur examples here show how to link in the DPDK environmentinto an SPDK application. That includes both spdk_env_dpdklibrary and the DPDK libraries. So put spdk_env_dpdk inthe DPDK_LIB variable in the Makefile.This will also simplify a future patch where we willuse pkg-config in this Makefile instead.Signed-off-by: Jim Harris Change-Id: I2c389eaa9900dbe5f77ccee536bd4edc0a54ccccReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5673Community-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk List of files: /spdk/test/external_code/hello_world/Makefile

f896aa6f1013830e2d1a4175d3bfc57144860cff - env_dpdk: add rte_rcu library dependency

Wed, 28 Oct 2020 17:27:13 +0000

env_dpdk: add rte_rcu library dependencyrte_hash depends on rte_rcu starting in upcomingDPDK 20.11 release. rte_rcu was only added inDPDK 19.05 release, so we need to check if itexists before linking it.Fixes issue #1661.Signed-off-by: Jim Harris Change-Id: I7e343c6f964b03cc62484b57803a3bad00f80288Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4947Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk List of files: /spdk/test/external_code/hello_world/Makefile

d792356a5aa1e7b006f6b26643c40aa4caaf4e5d - test/external_code: use variable to hold DPDK lib list

Wed, 28 Oct 2020 17:30:43 +0000

test/external_code: use variable to hold DPDK lib listSigned-off-by: Jim Harris Change-Id: Ie4a489926695cc56125f0e18796071f7730190f1Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4946Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk List of files: /spdk/test/external_code/hello_world/Makefile

68493f45af14bf30385f2605094772c130d8a10e - event: Add DPDK based governor

Thu, 03 Sep 2020 08:45:06 +0000

event: Add DPDK based governorSigned-off-by: Maciej Szwed Change-Id: Ide0ac38497bc500886e26fd219cb120113896966Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4152Tested-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris List of files: /spdk/test/external_code/hello_world/Makefile

6b41a08654b6c6545c099ecb66e12e3d3a1bf6e2 - dpdkbuild: build dpdk with meson+ninja

Mon, 23 Mar 2020 16:55:08 +0000

dpdkbuild: build dpdk with meson+ninjaMakefile support in DPDK was deprecated and will be removed soon,so switch to the officially supported way of building DPDK -with meson and ninja. Two new tools. Basically, our Makefileswill invoke meson+ninja for DPDK, no other SPDK components areaffected.Apparently DPDK wanted to move away from an octopus-like configsystem and the ideology behind meson configuration is simple now:build everything by default. Some PMDs can be explicitly disabledwith meson command line, but all libraries (both static and sharedversions) and test apps are built unconditionally.How long does it take to build minimal DPDK with meson? Too much.On my machine half of the total build time is spent on librarieswe don't need at all. (I have some hacks up my sleeve to disablebuilding those libraries - see the subsequent patch.) As for theofficial way of building a minimal DPDK, there was a patch [1]on dpdk mailing list to introduce more specific configuration,but it was rejected:> We talked about this a few times in the past, and it was actually one> of the design goals to _avoid_ replicating the octopus-like config> system of the makefiles. That's because it makes the test matrix> insanely complicated, not to mention the harm to user friendliness,> among other things.>> If someone doesn't want to use a PMD, they can just avoid installing it> - it's simple enough.>> Sorry, but from me it's a very strong NACK.Let's not follow that direction, hack the DPDK build system instead.As for advantages of meson+ninja over Makefiles? I can't find any.It's another build system that does a lot for you with some functions,magic options, and a built-in dependency system. It seems nice if you knowthe syntax, but it's another component that you need to learn, debug,and possibly find bugs in (there's a lot of github issues open for meson).I would compare it to CMake.As for changes in this patch: rather that explicitly disablingPMDs we don't need, specify a list of PMDs we do need and disableeverything else found in ./dpdk/drivers/*. This way we won't haveto disable the new PMDs as they're added to DPDK.Meson configuration also sets RTE_EAL_PMD_PATH #define to a valid directorywith built PMD shared libs. When it's set, DPDK dynamically loads all sharedlibraries inside. The drivers there depend on DPDK shared libs and fail toload in static SPDK builds, so we disable them altogether by unsettingRTE_EAL_PMD_PATH in the meson-generated config file - just likeDPDK Makefiles did. EAL checks for RTE_EAL_PMD_PATH being empty and skipsloading any external PMDs then. We do it for both static and shared libs.We specify all PMDs at build time for now, so there's just no need to loadthem dynamically.We have three more hacks in our submodule: * disable building dpdk apps by commenting-out a line in dpdk/meson.build * disable building unnecessary libs (build everything that spdk *may* need) * build isa-l compress pmd with `-L[...] -lisal`. DPDK expects to find libisal with pkg-config. We don't want to prepare a pkg-config file, so comment-out a failing check in another meson.build file and provide isa-l through CFLAGS and LDFLAGS.We also need to make some changes to our test/external_code. First ofall, -ldpdk is no more. Meson build generates a pkg-config file with alllibs, but we'll switch to it in a separate patch - for now just specifyall -lrte_ libs one by one. -Wl,--no-as-needed has to be added to sometest cases, otherwise rte_mempool_ring isn't loaded. We don't use anyAPIs from this library, it only has a static constructor that providesa few callbacks used by rte_mempool_create(). Also, since DPDK now buildsboth static and shared libraries, we need to add -Wl,-Bstatic to forceusing static libswhere required. It's only needed for DPDK libs, but weuse it for SPDK libs as well since there's no harm.As for performance:$ ./configure --enable-debug --with-crypto --with-reduce$ time make -j40 -C dpdkbuild allwith meson:real 0m8.287suser 1m7.983ssys 0m10.548sbefore, with the old DPDK makefiles:real 0m20.232suser 0m55.921ssys 0m16.491sThe subsequent builds are much faster too:$ time make -j40 -C dpdkbuild allmeson:real 0m0.876suser 0m0.663ssys 0m0.217smakefiles:real 0m10.150suser 0m11.740ssys 0m6.772s[1] http://inbox.dpdk.org/dev/1a07d1cd59d84dce84e56c10fdabf5e5504560a6.camel@debian.org/Change-Id: Ic65db563014100bafb12e61ee0530cc2ae64401dSigned-off-by: Darek Stojaczyk Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1440Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/test/external_code/hello_world/Makefile

c8c899f4921bd84df21cc3a89bc1b8a05f4f1f5c - dpdk: update submodule to DPDK 20.05

Wed, 22 Jul 2020 13:49:50 +0000

dpdk: update submodule to DPDK 20.05With update to DPDK 20.05 EAL requires rte_telemetry,external make tests were missing specifying this lib.Signed-off-by: Tomasz Zawadzki Change-Id: I9f5eaea46b47da48fc81b4fff0199cd75ff6af78Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3483Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/test/external_code/hello_world/Makefile

37bf49b1d5d80a608d6064b401f238c5437abc18 - sock: Add dependency on socket subsystem to other subsystems

Tue, 28 Jan 2020 21:47:46 +0000

sock: Add dependency on socket subsystem to other subsystemsSigned-off-by: Evgeniy Kochetov Change-Id: I665760166d54f6156b54735015bd2b586e91c345Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/616Community-CI: Mellanox Build BotCommunity-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto List of files: /spdk/test/external_code/hello_world/Makefile

3509378604091522ca585b7facad2f5f84899bfe - test/autobuild: verify external code can link to libs

Tue, 21 Jan 2020 17:18:46 +0000

test/autobuild: verify external code can link to libsThis test helps ensure that nothing about the way we build our sharedobjects changes in a way that breaks external applications or bdevmodules trying to link to SPDK.Change-Id: I45ac36a2afc873b04eb237f4e633a9d84066737cSigned-off-by: Seth Howell Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/435Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI List of files: /spdk/test/external_code/hello_world/Makefile