Changes in Makefile

355312bfcd3751f9af17fbefc90373fb8a269614 - so_ver: increase all major versions after SPDK 24.01

Fri, 26 Jan 2024 11:19:16 +0000

so_ver: increase all major versions after SPDK 24.01To allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all componentsDue to patch below being introduced after v24.01 code freeze,bdev lib version should not be increased:61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_chShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Signed-off-by: Tomasz Zawadzki Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/shared_lib/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/shared_lib/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/shared_lib/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/shared_lib/Makefile

047c067c05ff22df06c053990998184b8a940514 - so_ver: increase all major versions

Mon, 31 Jan 2022 09:55:58 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 22.05release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/shared_lib/Makefile

e4070ee0e012c345f4c059f125f4f9ce3be66690 - so_ver: increase all major versions

Fri, 29 Jan 2021 10:11:25 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the quarterly releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 21.04release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: I44d01154430a074103bd21c7084f44932e81fe72Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6167Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/shared_lib/Makefile

d37a5797ef90e18db1458c4deaebb92942fa7e30 - build: add SO_SUFFIX for combined spdk.so library

Tue, 29 Sep 2020 14:22:25 +0000

build: add SO_SUFFIX for combined spdk.so libraryThis fixes bug where combined shared library would benamed "libspdk.so."Signed-off-by: Jim Harris Change-Id: I9868bf9e1cd6f365e1f28e7a34792ae8b85bf608Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4464Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto List of files: /spdk/shared_lib/Makefile

a39c8420dc955dade8902fc4396fc5685fcc27b9 - build: remove spdk.so library from .PHONY

Tue, 29 Sep 2020 14:24:17 +0000

build: remove spdk.so library from .PHONYTargets listed in .PHONY are always built - butin this case if the underlying spdk.so.$VER libraryhasn't been modified, there's no reason to redo thesymlink.Signed-off-by: Jim Harris Change-Id: Ife60f1de6dd6d0997bc5adf40d039cfd1dbc88ecReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4463Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto List of files: /spdk/shared_lib/Makefile

d18e63206a4b5d710756d7e7d9c42ef0db0c5d58 - mk/lib: add a check that major and minor version is set for libs.

Sun, 10 May 2020 20:40:09 +0000

mk/lib: add a check that major and minor version is set for libs.Also, while we are here, consolidate setting SO_SUFFIX to one spot.Previously, it was possible for a library to slip throughwithout an SO version.Signed-off-by: Seth Howell Change-Id: I4db5fa5839502d266c6259892e5719b05134518cReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotCommunity-CI: Broadcom CIReviewed-by: Paul Luse Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki List of files: /spdk/shared_lib/Makefile

193927830ddced41dfebfe7cdb14d543aaf84a2c - make: rev SO versions individually for libraries.

Fri, 28 Feb 2020 20:47:11 +0000

make: rev SO versions individually for libraries.This will allow us to keep track of compatibility issues on aper-library basis.Change-Id: Ib0c796adb1efe1570212a503ed660bef6f142b6eSigned-off-by: Seth Howell Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1067Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/shared_lib/Makefile

266ca9401317d10eeb71127e21e77937f1241e6a - Revert "shared_lib: add as_needed to the libspdk.so linker script"

Wed, 17 Jul 2019 08:04:32 +0000

Revert "shared_lib: add as_needed to the libspdk.so linker script"This reverts commit 346fefc364235c869ddef21958fc34e0393a8426.That commit breaks the shared object build when linking against theimplicit top level linker script. It makes it so that none of theconstructor functions get properly linked in.Change-Id: I3477acbd86f44b6d5e949eb6725ca4c1b71a55b5Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462149Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Changpeng Liu List of files: /spdk/shared_lib/Makefile

c4d9daeb7bf491bc0eb6e8d417b75d44773cb009 - Makefile: Add possibility to uninstall spdk.

Wed, 02 Jan 2019 09:28:02 +0000

Makefile: Add possibility to uninstall spdk.Add uninstall target to makefiles to be able to performreverse of install target.Fixes #464This patch adds 'uninstall' target to makefile.'make uninstall' will remove spdk_tgt app, headers, librariesand shared libraries from system directories defined by $DESTDIR.Additionaly, if there will be any empty directories left afterthis operation, they will be removed as well.Signed-off-by: Piotr Pelplinski Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/shared_lib/Makefile

14e443bdfbf9dd0d8782f4b2aec9e3577afcaf01 - build: fix duplicated clean target in shared_lib/Makefile

Wed, 13 Feb 2019 15:28:03 +0000

build: fix duplicated clean target in shared_lib/MakefileAdd a CLEAN_FILES macro that shared_lib/Makefile can useto add to the list of files to be cleaned.Fixes #663.Signed-off-by: Jim Harris Change-Id: I12982e0989e02a69aaea4e470777301280090096Reviewed-on: https://review.gerrithub.io/c/444427Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu List of files: /spdk/shared_lib/Makefile

f425b985138d03b5420aee3bd94510f7c2ca9c7f - ut_mock: rename library from spdk_mock to ut_mock

Mon, 19 Nov 2018 09:41:01 +0000

ut_mock: rename library from spdk_mock to ut_mockThis matches the lib/ut_mock directory name, and alsoavoids the final library being named spdk_spdk_mock.a.Signed-off-by: Jim Harris Change-Id: I80ec09568d0455d1f131e45694b6e2d536e6ca91Reviewed-on: https://review.gerrithub.io/433909Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Darek Stojaczyk List of files: /spdk/shared_lib/Makefile

346fefc364235c869ddef21958fc34e0393a8426 - shared_lib: add as_needed to the libspdk.so linker script

Wed, 03 Oct 2018 00:30:59 +0000

shared_lib: add as_needed to the libspdk.so linker scriptspecifying as_needed in the linker script prevents us from creating moreruntime dependencies than necessary for a given application linking tolibspdk.soChange-Id: Ifd3788e210c5e6a0e19749cb575c3dfb494a41d2Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/427808Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Shuhei Matsumoto Reviewed-by: Lance Hartmann Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/shared_lib/Makefile

c779298802acfbda92794c519423e0d04208f327 - Make: Build shared libs while building static libs

Wed, 19 Sep 2018 17:11:18 +0000

Make: Build shared libs while building static libsThis will allow us to specify more granular system dependencies for each.so file.Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/426129Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Lance Hartmann Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/shared_lib/Makefile

cc5fedc6ebb84d0191ecf1e0f8e7c4d1ec20fbae - build: add quiet output for recently added shared lib build

Wed, 05 Sep 2018 20:15:16 +0000

build: add quiet output for recently added shared lib buildSigned-off-by: Jim Harris Change-Id: I3fa790389f56715629c0301f101a5244dc7ae516Reviewed-on: https://review.gerrithub.io/424723Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins Reviewed-by: Lance Hartmann Reviewed-by: Seth Howell Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto List of files: /spdk/shared_lib/Makefile

e9424c7e1ca6f7f74820a47d9506121ab4f015cd - build: add build of individual shared libraries

Fri, 10 Aug 2018 18:47:37 +0000

build: add build of individual shared librariesChange-Id: Ief6ba77352a0248bbc608d98a0b338f2e03ee0dcSigned-off-by: Lance Hartmann Reviewed-on: https://review.gerrithub.io/422306Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Chandler-Test-Pool: SPDK Automated Test System List of files: /spdk/shared_lib/Makefile

3f6f569854504af1d7a5b293f378990d75a18b23 - shared_lib: Update shared lib build and install

Fri, 10 Aug 2018 18:08:56 +0000

shared_lib: Update shared lib build and installUpdates build and install of shared lib to conform withstandard naming conventions for shared libraries, includingthe setting of the lib's soname.Change-Id: Ib46d298ab5f77fd8c32b7c04022b546446189428Signed-off-by: Lance Hartmann Reviewed-on: https://review.gerrithub.io/421936Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/shared_lib/Makefile

b5ed37ed0ec80a0230a39554e2f79c9b88cfa1a8 - shared_lib: add libspdk_thread to libspdk.so

Thu, 28 Jun 2018 16:05:11 +0000

shared_lib: add libspdk_thread to libspdk.soThis was missed when splitting thread into its own library; the threadsymbols were missing from libspdk.so.Change-Id: Ibcd1ea8cc5be1340cc4b848c81b4c92b036675a8Fixes: 02d75f6237c8 ("thread: Move threading abstraction code out of util")Fixes: 6f46e272c3c0 ("build: add combined shared library (libspdk.so)")Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/417171Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto List of files: /spdk/shared_lib/Makefile