Changes in Makefile

355312bfcd3751f9af17fbefc90373fb8a269614 - so_ver: increase all major versions after SPDK 24.01

Fri, 26 Jan 2024 11:19:16 +0000

so_ver: increase all major versions after SPDK 24.01To allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all componentsDue to patch below being introduced after v24.01 code freeze,bdev lib version should not be increased:61623c5ca9 bdev: add spdk_bdev_io padding in place of io_submit_chShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Signed-off-by: Tomasz Zawadzki Change-Id: I0166d6be6c17bbbf985d48b5dfcb36f1d4af1b48Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21582Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/scsi/Makefile

986fb7b3ef33fe066da9bc9cb91d86f8db4da0b1 - vhost-scsi: support SBC-3 compare_and_write IO

Mon, 11 Sep 2023 11:46:16 +0000

vhost-scsi: support SBC-3 compare_and_write IOSupport compare_and_write from SBC-3 for 1 block sincespdk_bdev_comparev_and_writev_blocks function supportscompare_and_write of only 1 block currently.Change-Id: I1069fa6c9070a5f16b8867f62740a2dce8a282daSigned-off-by: Haoqian He Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19873Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris List of files: /spdk/lib/scsi/Makefile

ed7054e3f812175168cccd3d8e533adf8cff9422 - test/abi: remove checking exported API from headers

Mon, 29 May 2023 13:35:08 +0000

test/abi: remove checking exported API from headersHaving --header-dir parameter for abidiff seems to filter outsome of the API changes. As a result few were notaccounted for since the SPDK 23.05 code freeze.Remove that parameter and add appropriate changes.Suppressed changes in spdk_nvme_qpair since this is from nvme_internal.hand transparent to the public API. Yet abidiff catches that once we remove--header-dir option:(113075be66)nvme/rdma: Fix cq/qp destroy order'struct spdk_nvme_qpair' changed: type size hasn't changed 1 data member insertion: 'uint8_t destroy_in_progress', at offset 103 (in bits) at nvme_internal.h:444:1Increased libspdk_nvmf from 15.0 to 16.0 due to following commits:(a711d629cb)lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init'struct spdk_dif_ctx' changed: type size changed from 384 to 416 (in bits) 1 data member insertion: 'spdk_dif_pi_format dif_pi_format', at offset 160 (in bits) at dif.h:63:1Increased libspdk_scsi from 6.0 to 7.0 due to following commit:(a711d629cb)lib/util/dif: Add an ext_opts param to spdk_dif_ctx_init'struct spdk_dif_ctx' changed: type size changed from 384 to 416 (in bits) 1 data member insertion: 'spdk_dif_pi_format dif_pi_format', at offset 160 (in bits) at dif.h:63:1Reported-by: Konrad Sztyber Signed-off-by: Tomasz Zawadzki Change-Id: I6841f1620111ea2a4750160afdc8a78ebec2b210Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/18435Community-CI: Mellanox Build BotReviewed-by: Ben Walker Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber List of files: /spdk/lib/scsi/Makefile

3359bf34d682202107c227ea42ace1c600a04657 - so_ver: increase all major versions

Mon, 23 Jan 2023 17:24:28 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 23.05release.Looks like this was left over from prior LTS, to avoid thatmake sure it is only skipped when running against v23.01.x as latestrelease.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsShort reference to how the versions were changed:MAX=$(git grep "SO_VER := " | cut -d" " -f 3 | sort -ubnr | head -1)for((i=$MAX;i>0;i-=1)); do find . -name "Makefile" -exec \ sed -i -e "s/SO_VER := $i\$/SO_VER := $(($i+1))/g" {} +; donefind . -name "Makefile" -exec \ sed -i -e "s/SO_MINOR := .*/SO_MINOR := 0/g" {} +Change-Id: I3e5681802c0a5ac6d7d652a18896997cd07cc8bfSigned-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16419Reviewed-by: Ben Walker Reviewed-by: Konrad Sztyber Tested-by: SPDK CI Jenkins List of files: /spdk/lib/scsi/Makefile

a6dbe3721eb3b5990707fc3e378c95e505dd8ab5 - update Intel copyright notices

Tue, 01 Nov 2022 20:26:26 +0000

update Intel copyright noticesper Intel policy to include file commit date using git cmdbelow. The policy does not apply to non-Intel (C) notices.git log --follow -C90% --format=%ad --date default | tail -1and then pull just the 4 digit year from the result.Intel copyrights were not added to files where Intel either hadno contribution ot the contribution lacked substance (ie licenseheader updates, formatting changes, etc). Contribution date used"--follow -C95%" to get the most accurate date.Note that several files in this patch didn't end the license/(c)block with a blank comment line so these were added as the vastmajority of files do have this last blank line. Simply there forconsistency.Signed-off-by: paul luse Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot List of files: /spdk/lib/scsi/Makefile

488570ebd418ba07c9e69e65106dcc964f3bb41b - Replace most BSD 3-clause license text with SPDX identifier.

Fri, 03 Jun 2022 19:15:11 +0000

Replace most BSD 3-clause license text with SPDX identifier.Many open source projects have moved to using SPDX identifiersto specify license information, reducing the amount ofboilerplate code in every source file. This patch replacesthe bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clauseidentifier.Almost all of these files share the exact same license text,and this patch only modifies the files that contain themost common license text. There can be slight variationsbecause the third clause contains company names - most say"Intel Corporation", but there are instances for Nvidia,Samsung, Eideticom and even "the copyright holder".Used a bash script to automate replacement of the license textwith SPDX identifier which is checked into scripts/spdx.sh.Signed-off-by: Jim Harris Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Changpeng Liu Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: List of files: /spdk/lib/scsi/Makefile

047c067c05ff22df06c053990998184b8a940514 - so_ver: increase all major versions

Mon, 31 Jan 2022 09:55:58 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the future releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 22.05release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: Id1a5358882dc496faa5b0b5c9a63b326c378c551Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11361Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/scsi/Makefile

f61d81e47c853607ffe0681becf0a8e8883125d0 - scsi: Add spdk_scsi_dev_get_first/next_lun() to traverse all LUNs

Wed, 06 Oct 2021 14:58:49 +0000

scsi: Add spdk_scsi_dev_get_first/next_lun() to traverse all LUNsAdd two public APIs spdk_scsi_dev_get_first_lun() andspdk_scsi_dev_get_next_lun() to remove the dependency on the macroconstant SPDK_SCSI_DEV_MAX_LUN from lib/iscsi and lib/vhost.Signed-off-by: Shuhei Matsumoto Change-Id: I6546697f823fe9f4fa34e1161f5c7fa912dd2d59Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9608Community-CI: Broadcom CI Community-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: GangCao Reviewed-by: Ben Walker List of files: /spdk/lib/scsi/Makefile

e4070ee0e012c345f4c059f125f4f9ce3be66690 - so_ver: increase all major versions

Fri, 29 Jan 2021 10:11:25 +0000

so_ver: increase all major versionsTo allow SO_MINOR updates on LTS for the whole year it is supported,the major version for all components needs to be increased.This is to prevent scenario where two versions exists with matchingversions, but conflicting ABI.Ex. Next SPDK release adds an API call increasing the minor version,then LTS needs just a subset of those additions.Increasing major so version after LTS, allows the quarterly releasesto update versions as needed. Yet allowing LTS to increase minorversion separately.Disabled test for increasing SO version without ABI change, asthat is goal of this patch. This check shall be removed with SPDK 21.04release.This patch:- increases SO_VER by 1 for all components- resets SO_MINOR to 0 for all components- removes suppressions for ABI testsSigned-off-by: Tomasz Zawadzki Change-Id: I44d01154430a074103bd21c7084f44932e81fe72Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6167Community-CI: Broadcom CICommunity-CI: Mellanox Build BotTested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/lib/scsi/Makefile

5029fe14b66f0e27ba8b429c7edabafe35bb102f - scsi: add bdev resize callback support

Tue, 08 Sep 2020 15:32:48 +0000

scsi: add bdev resize callback supportCurrently, the scsi bdev only supports the hotremove event,and the scsi library uses the deprecated `spdk_bdev_open` function.In this patch, add the resize event support, so the upper layercould do more actions, like vhost-scsi could notify the guest os.For the scsi compatibility, add _ext suffix for some public api.Change-Id: I3254d4570142893f953f7f42da31efb5a3685033Signed-off-by: Li Feng Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4353Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/scsi/Makefile

4c156e637961e60628e9cb68d3deb841c72d7584 - lib/scsi: downgrade SCSI SO version

Mon, 29 Jun 2020 14:02:01 +0000

lib/scsi: downgrade SCSI SO versionInternal headers (such as one in SCSI) should not trigger theSO versoning fialures. This was addressed by patch:(f53bf76)test/check_so_deps: limit scope of header checks.Additionally quite recently another patch increased the SO versionfor SCSI:(6b6a3ff)scsi: add SPC2 RESERVE/RELEASE supportThey were not in the same relation chain when being submitted,so they didn't test against each other.This resulted in:SO name for libspdk_scsi.so changed without a change to abi. please revert that change.For this reason this patch revs down the SO version for SCSI lib.Signed-off-by: Tomasz Zawadzki Change-Id: I69caae6c139e546afe2eeeae3395dc80ff898339Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3114Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk List of files: /spdk/lib/scsi/Makefile

6b6a3ff91f77970587950b17ddb58bb65d690c8b - scsi: add SPC2 RESERVE/RELEASE support

Mon, 08 Jun 2020 06:13:10 +0000

scsi: add SPC2 RESERVE/RELEASE supportSome OS(Windows and VMWARE esxi) will send SPC2 RESERVE/RELEASEcommands when formatting the filesystems, but in our previousimplementation of reservation feature, we didn't add such support,in specification SPC3/4, they all include one section "Exceptions toSPC-2 RESERVE and RELEASE behavior" feature for compatible support ofSCP2 RESERVE/RELEASE, so we add this support now.Fix issue #1414.Change-Id: I65d85ffb3b8f824b0ae4e130f53f01d95735d700Signed-off-by: Changpeng Liu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2802Tested-by: SPDK CI Jenkins Community-CI: Broadcom CICommunity-CI: Mellanox Build BotReviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto List of files: /spdk/lib/scsi/Makefile

d18e63206a4b5d710756d7e7d9c42ef0db0c5d58 - mk/lib: add a check that major and minor version is set for libs.

Sun, 10 May 2020 20:40:09 +0000

mk/lib: add a check that major and minor version is set for libs.Also, while we are here, consolidate setting SO_SUFFIX to one spot.Previously, it was possible for a library to slip throughwithout an SO version.Signed-off-by: Seth Howell Change-Id: I4db5fa5839502d266c6259892e5719b05134518cReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2361Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build BotCommunity-CI: Broadcom CIReviewed-by: Paul Luse Reviewed-by: Ben Walker Reviewed-by: Aleksey Marchuk Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/scsi/Makefile

e99aa891086c2ab08000df76f11307e175766026 - lib/scsi: add map file

Thu, 16 Apr 2020 04:23:18 +0000

lib/scsi: add map fileSigned-off-by: Shuhei Matsumoto Change-Id: I019ad7147e4e9bc223d1a772e9284d18d5591aceReviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1897Community-CI: Mellanox Build BotCommunity-CI: Broadcom CITested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Paul Luse Reviewed-by: Vitaliy Mysak Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki List of files: /spdk/lib/scsi/Makefile

799e0a84af06f396a2d4d56da0df3d48b3ea88d2 - lib/scsi: Merge append and execute SCSI task into a single function

Mon, 13 Apr 2020 17:17:32 +0000

lib/scsi: Merge append and execute SCSI task into a single functionBoth for SCSI IO task and management task, append and executeoperations bad bbeen separated into different functions.Append operation was for LUN reset, and separating into two differentfunctions was for clarification and readability.LUN reset is sufficiently stable now.Merging append and execute SCSI task into a single function is goodas API and enables us to do optimization.For SCSI management task, merge spdk_scsi_lun_append_mgmt_task intospdk_scsi_lun_execute_mgmt_task() simply.For SCSI IO task, merge spdk_scsi_lun_append_task intospdk_scsi_lun_execute_task() and do a small optimization.The refined spdk_scsi_lun_execute_task() adds the IO task to thepending list if there is any pending management task, executes allexisting penging IO tasks first and then the IO task if there is anypending IO task, or executes the IO task directly otherwise.Update unit test accordingly.Signed-off-by: Shuhei Matsumoto Change-Id: I26ffc4f4f62747d8cdecb90690f26cd58a9c17f7Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1817Tested-by: SPDK CI Jenkins Community-CI: Broadcom CIReviewed-by: Changpeng Liu Reviewed-by: Jim Harris List of files: /spdk/lib/scsi/Makefile

193927830ddced41dfebfe7cdb14d543aaf84a2c - make: rev SO versions individually for libraries.

Fri, 28 Feb 2020 20:47:11 +0000

make: rev SO versions individually for libraries.This will allow us to keep track of compatibility issues on aper-library basis.Change-Id: Ib0c796adb1efe1570212a503ed660bef6f142b6eSigned-off-by: Seth Howell Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1067Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker List of files: /spdk/lib/scsi/Makefile

d0d19eb82e3ba677162ae5c1930d9ddcf728bcbf - scsi: add persistent reservation out with register feature support

Tue, 14 May 2019 04:32:13 +0000

scsi: add persistent reservation out with register feature supportTo establish a persistent reservation the application client shall firstregister an I_T nexus with the device server. An application client registerswith a logical unit by issuing a PERSISTENT RESERVE OUT command with REGISTERservice action or REGISTER AND IGNORE EXISTING KEY service action.Specify Initiator Ports (SPEC_I_PT) bit and All Target Ports (ALL_TG_PT) bitare not supported for now, the registrants belong to the I_T nexus who sendsthe command.Also Activate Persist Through Power Loss (APTPL) bit will be supported infollowing patches.Change-Id: If057a764a4bfa73017f98048c94b697dbfa4b4a1Signed-off-by: Changpeng Liu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/436088Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins List of files: /spdk/lib/scsi/Makefile

a862d1cdd6099ce964559238c2443679e6c4938e - scsi: remove lun_db

Wed, 03 Jan 2018 18:58:01 +0000

scsi: remove lun_dbChange-Id: Icc40b66cd0c6f63242bc3d3f26b34f323450c570Signed-off-by: Pawel Wodkowski Reviewed-on: https://review.gerrithub.io/393501Tested-by: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: Reviewed-by: Dariusz Stojaczyk Reviewed-by: Ben Walker List of files: /spdk/lib/scsi/Makefile

543cb17248ab28373fe73dc29332819817aa7d5e - build: remove $(ENV_CFLAGS) where not necessary

Mon, 11 Dec 2017 22:38:24 +0000

build: remove $(ENV_CFLAGS) where not necessaryOnly Makefiles for libraries that directly depend on DPDK (rather thanthe SPDK env abstraction) should add $(ENV_CFLAGS).Change-Id: Ifdf44d3ef8c42bbf7f20edd524b330d00658235bSigned-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/392818Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Jim Harris List of files: /spdk/lib/scsi/Makefile

dc9e11163e349c7f1ea5cebb52b74ee1c9ccb107 - bdev: add API to translate to SCSI status

Wed, 18 Jan 2017 22:15:35 +0000

bdev: add API to translate to SCSI statusMove the scsi_nvme translation code from the SCSI library into bdev, andprovide a generic way to translate any bdev_io status into a SCSIstatus.Change-Id: Ib61a6209387c24543e31574e2b5ca249e2ac8b74Signed-off-by: Daniel Verkamp List of files: /spdk/lib/scsi/Makefile